profile
viewpoint
Dan Adler dadlerj Sourcegraph Inc San Francisco, CA

sourcegraph/python-langserver 101

Language server which talks LSP via JSONRPC for Python.

sourcegraph/emacs-lsp 97

LSP support for Emacs

lsif/lsif.github.io 3

https://lsif.dev

dadlerj/dullard 1

A lightweight, fast XLSX reader

dadlerj/go-github 0

Go library for accessing the GitHub API

dadlerj/gowalker 0

Go Walker is a server that generates Go projects API documentation on the fly.

dadlerj/language-server-protocol 0

Defines a common protocol for language servers.

dadlerj/markvis-bar 0

Bar chart generator for markvis in browser and node.js.

dadlerj/markvis-line 0

Line chart generator for markvis in browser and node.js.

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventsourcegraph/sourcegraph

Dan Adler

commit sha 33589ccd296e4e65178cd14891567ff4c7aa7dd1

Fix pricing model docs (#14805)

view details

push time in 3 days

delete branch sourcegraph/sourcegraph

delete branch : sub-docs

delete time in 3 days

PR merged sourcegraph/sourcegraph

Fix pricing model docs

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+8 -22

1 comment

1 changed file

dadlerj

pr closed time in 3 days

PR opened sourcegraph/sourcegraph

Fix pricing model docs

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+8 -22

0 comment

1 changed file

pr created time in 3 days

create barnchsourcegraph/sourcegraph

branch : sub-docs

created branch time in 3 days

push eventsourcegraph/sourcegraph

Keegan Carruthers-Smith

commit sha 558bf6ac760a256cdf1d3f15cff118b7fd47d2b2

doc: methodology for lines of code ping (#14750) * doc: methodology for lines of code ping * move description to admin/subscriptions

view details

push time in 3 days

delete branch sourcegraph/sourcegraph

delete branch : k/doc-loc

delete time in 3 days

PR merged sourcegraph/sourcegraph

Reviewers
doc: methodology for lines of code ping

Fixes https://github.com/sourcegraph/sourcegraph/issues/14743

+6 -0

3 comments

1 changed file

keegancsmith

pr closed time in 3 days

issue closedsourcegraph/sourcegraph

Add Documentation for Lines of Code Methodology

Describe the issue

A number of customers have asked for an explanation into the methodology for computing lines of code. Currently this info isn't documented in our Sourcegraph docs. It would be beneficial to add it there for easy sharing with customers. The document should answer questions such as:

  1. How do we compute lines of code? What counts as a "line" for our computation?
  2. Is indexed code treated differently than non-indexed code?
  3. How are lines counted across multiple branches?
  4. How are forks handled in the computation?
  5. Are there known cases where the calculation may not be accurate?

If there is any other information that would be pertinent to customers, it should be included as well.

Where is the issue located?

The lines of code ping: https://docs.sourcegraph.com/admin/pings#other-telemetry

closed time in 3 days

tistru
PullRequestReviewEvent

pull request commentsourcegraph/zoekt

zoekt-webserver: remove watchdog

One thing to think about is non-K8s deployments. Would this cause problems on Docker Compose?

keegancsmith

comment created time in 4 days

push eventsourcegraph/sourcegraph

Dan Adler

commit sha 93842f9a7eb0537c508823e605f0ffa645084b41

Revert "usagestats: replace usages of usagestatsdepreacted with usagestats pkg (#13810)" (#14784) This reverts commit d403b7f9a375248df588f9d987e023f58785473d.

view details

push time in 4 days

delete branch sourcegraph/sourcegraph

delete branch : revert-usagestats-change

delete time in 4 days

PR merged sourcegraph/sourcegraph

Revert "usagestats: replace usages of usagestatsdepreacted with usage…

…stats pkg (#13810)"

This reverts commit d403b7f9a375248df588f9d987e023f58785473d.

Still testing this now, so we shouldn't merge yet

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+9 -8

2 comments

4 changed files

dadlerj

pr closed time in 4 days

pull request commentsourcegraph/sourcegraph

Revert "usagestats: replace usages of usagestatsdepreacted with usage…

Seems fine locally. Will merge when it passes CI.

dadlerj

comment created time in 4 days

PR opened sourcegraph/sourcegraph

Reviewers
Revert "usagestats: replace usages of usagestatsdepreacted with usage…

…stats pkg (#13810)"

This reverts commit d403b7f9a375248df588f9d987e023f58785473d.

Still testing this now, so we shouldn't merge yet

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+9 -8

0 comment

4 changed files

pr created time in 4 days

create barnchsourcegraph/sourcegraph

branch : revert-usagestats-change

created branch time in 4 days

pull request commentsourcegraph/sourcegraph

doc: methodology for lines of code ping

Content looks great, but I'd prefer for this not to live in the pings page. Can you add this as a section "How lines of code are counted" to this page: https://docs.sourcegraph.com/admin/subscriptions?

keegancsmith

comment created time in 4 days

issue openedsourcegraph/sourcegraph

Permissions from multiple code hosts at once

Requested by:

  • https://app.hubspot.com/contacts/2762526/company/1799582875

Hi folks. I've been finalising our deployment and had a question about how repository permissions worked.

It's my understanding that they rely upon the information provided by the code host authentication, thus it's preferred that one use your code host for user authentication instead of going to an external SSO provider (e.g. Okta).

Is it possible to apply repository permissions from multiple code hosts, or is it only from the code host that authentication is configured with.

  • https://app.hubspot.com/contacts/2762526/company/1749032193

  • https://app.hubspot.com/contacts/2762526/company/693777200

#thanks to @unknwon for earlier confirming that we CAN support multiple code host permissions (e..g multiple GitLabs) at once!

Interestingly, we can support this for GitLab (using sudo access tokens or username equivalency: https://docs.sourcegraph.com/admin/repo/permissions#gitlab) and for Bitbucket Server (see https://docs.sourcegraph.com/admin/repo/permissions#bitbucket-server). But not for GitHub.

So two specific requests here:

  • Support username or email-based permission for GitHub (versus ONLY supporting it when GItHub is also the authn provider)
  • Simply confirm that Sourcegraph can handle supporting permissions from multiple code hosts with distinct permissions all connected in different ways (has this already been confirmed by you @unknwon ?)

created time in 5 days

Pull request review commentsourcegraph/sourcegraph

Add homepage panel stats to pings

 type SavedSearches struct { 	OrgSavedSearches     int32 } +// Panel homepage represents interaction data on the+// enterprise homepage panels.+type HomepagePanels struct {+	RecentFilesClickedPercentage           float64+	RecentSearchClickedPercentage          float64+	RecentRepositoriesClickedPercentage    float64+	SavedSearchesClickedPercentage         float64+	NewSavedSearchesClickedPercentage      float64+	TotalPanelViews                        float64

Sounds good. Not a big deal, but generally I'd recommend using the best matched number types where possible. E.g. for counts, there will never be fractional values, so ints are a better fit (no worries about weird rounding issues, they take less space, they help users make assumptions about the data that is being held here, etc., but again, not a big deal).

ebrodymoore

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentsourcegraph/sourcegraph

Add homepage panel stats to pings

 type SavedSearches struct { 	OrgSavedSearches     int32 } +// Panel homepage represents interaction data on the+// enterprise homepage panels.+type HomepagePanels struct {+	RecentFilesClickedPercentage           float64+	RecentSearchClickedPercentage          float64+	RecentRepositoriesClickedPercentage    float64+	SavedSearchesClickedPercentage         float64+	NewSavedSearchesClickedPercentage      float64+	TotalPanelViews                        float64

@ebrodymoore should this be a float64? What type is it in BigQuery? I assume an integer?

ebrodymoore

comment created time in 5 days

PullRequestReviewEvent

issue commentsourcegraph/sourcegraph

Editor extensions fail to generate correct URLs when jumping to Sourcegraph

Similar report from https://app.hubspot.com/contacts/2762526/company/693777200

This user is using the IntelliJ/JetBrains plugin.

This company is using src serve-git to convert Perforce repos and branches to git repositories in the Sourcegraph backend, so repo and branch naming is very different on the app than locally… We’d need some advanced repo/rev rename field (along the lines of how the repositoryPathPattern config option works in the webapp) to map from local git remote name to Sourcegraph URL.

E.g. some field like (totally made up, and not actually what they need): repoNameMapping: "{host}/hardcodedRepoName/{rev}@main" or something, where literal strings can be mixed with variable interpolation, where revisions can be used in interpolations, etc.

Details from the user:

Perhaps I need more in the URL? The net effect is that I have copy link to file and open file enabled but not search selection or search in repository. Neither option that is enabled seems to do anything.

Update: Based on documentation, I tried selecting text and both search selection and search in repository worked. Neither of the other options seems to do anything. My searches are not focused on the branch I care about - I don't know if that's something I adjust via a project setting or if I need to set something on the site. My top hits are all on the REDACTED branch and I really just care about REDACTED.

The documentation says By default, the plugin will use the origin git remote to determine which repository on Sourcegraph corresponds to your local repository. If your origin remote doesn't match Sourcegraph, you may instead configure a sourcegraph Git remote which will take priority. but I don't know how to do that and this isn't git, it's perforce.

See more in the thread: https://sourcegraph.slack.com/archives/C011899KB6U/p1602270142030200

dadlerj

comment created time in 6 days

PullRequestReviewEvent

pull request commentsourcegraph/sourcegraph

web: update generate license description

Thanks, I did miss that other update!

@dadlerj Ideally I would love to delete the first paragraph entirely... and guide everyone to use the linked handbook page as the single source of truth for what tags to put. This page is very easy to overlook and it seems very outdated to me.

Please delete it then, I agree with you.

unknwon

comment created time in 6 days

push eventsourcegraph/sourcegraph

Dan Adler

commit sha b81b3b4071dffb0c5c75e8ba4a3965b1c1375475

remove stages from pings (#14551) * Remove stages from pings * Update changelog and docs pages. * Fix types

view details

push time in 7 days

delete branch sourcegraph/sourcegraph

delete branch : rm-stages

delete time in 7 days

PR merged sourcegraph/sourcegraph

Reviewers
remove stages from pings

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+7 -473

3 comments

14 changed files

dadlerj

pr closed time in 7 days

push eventsourcegraph/sourcegraph

Thorsten Ball

commit sha 984859023094b76245015ecbee93f24765e22a8a

Use code-bg for code tags in docs (#14557)

view details

Keegan Carruthers-Smith

commit sha 61143bdffa6a43e6b5a3c8bc734bfb576c32f933

search: indexed config API supports multiple repo query arguments (#14558) This converts the API into a batch API by writing a JSON blob per "repo" query parameter in the order they are specified. Each zoekt indexserver currently queries this endpoint with a hardcoded concurrency of 32. This can cause many many HTTP requests, which on a linux machine without tuning can lead to socket errors. By converting this into a batch API we reduce the number of connections as well as moving the responsbility of concurrency to the frontend which has more knowledge of load/etc. We also remove backwards compatibility support where repo wasn't specified. Repo has been specified for multiple releases now.

view details

Ryan Slade

commit sha 9214e6656fbabe74ede778e97e7039f0719f842c

repo-updater: Add critical alerts (#14530) * repo-updater: Add critical alerts The number of user added repos is greater than 90% of our hard limit of 200k. Number of external services added is great than 20k No external services have synced in more than 8 hours. By default we backoff for up to 8 hours, so anything higher than this indicates a problem. * syncer_sync_start should be a rate Alert when we've performed <= 1 syncs for 8 hours. Ideally we want this to be <= 0 but our monitoring package doesn't allow this. Therefore we need to make this a warning as it'll fire for instances that only have 1 external service defined. * Fill in possible solutions and remove unnecessary panel * Adjust rate * Update monitoring/repo_updater.go Co-authored-by: Tomás Senart <tomas@sourcegraph.com> * Update monitoring/repo_updater.go Co-authored-by: Robert Lin <robert@bobheadxi.dev> * Update possible error descriptions * Fix alert * Switch alert to critical Co-authored-by: Tomás Senart <tomas@sourcegraph.com> Co-authored-by: Robert Lin <robert@bobheadxi.dev>

view details

Asdine El Hrychy

commit sha c8c970746592fc2efefa0c7edf7fdd946bec8cc9

Fix crash on Gitlab external service configuration (#14519) OneOf will prevent schemas from being saved and enforce choosing only one of the expected properties

view details

Dax McDonald

commit sha e8c211acd9bd42751d1a60ead7e8185bb6ba37ee

Fix redirects (#14545)

view details

Felix Becker

commit sha f9e62fe4ce323aa3d209711ec7322c6c4d9476c3

Fix nyc include filter after renames (#14563)

view details

Eric Fritz

commit sha 3defa94bffe4e934322712aa5cbb257a951b2406

codeintel: Store index job commands and output in the database (#14457)

view details

Felix Becker

commit sha 2e2becfd20ed38dbff603152c431879a177844eb

Don't show browser extension alert if it's already installed (#14561) Co-authored-by: TJ Kandala <kandalatj@gmail.com>

view details

Felix Becker

commit sha cf65dec202f59a16694764d8b059bb0f5304f921

Add after install page to browser extension (#14407)

view details

Eric Fritz

commit sha 2a5065055979626e8f171fdc1025c4506500bb63

codeintel: Refactor large interface in gitserver layer (#14496)

view details

Rijnard van Tonder

commit sha c46d7b16aa5fc648ce0ec5d1710ac21954f1dd1e

search: trigger search on cmd+enter in console (#14508)

view details

Christina Forney

commit sha 7d54a337c9338f5775cfb18e1ee884e0075415a4

Update links to developer docs in README (#14578)

view details

Rijnard van Tonder

commit sha 9baf830e530a9e52c49a4d21edbd4b0ac84989e9

search: preserve brackets in structural patterns (#14580)

view details

Juliana Peña

commit sha 4509ca63ad85083bf72f783aec553d0f256cfc82

search: homepage panels now use the correct `requestGraphQL` function (#14579) We had two `requestGraphQL` functions and we were using the wrong one. Fixed the homepage panels to use the right function, and also renamed the other one and added comments so hopefully this doesn't happen again.

view details

Marek

commit sha d0d3e568d29a3ae16424f290c74ec8b44d306c38

Update browser extension icon with alert state (#14555) Co-authored-by: Felix Becker <felix.b@outlook.com>

view details

TJ Kandala

commit sha 2fae54f689c5bef09bfe9518315577f78d6634a8

Implement hover alerts for private repositories (#14488) Co-authored-by: Felix Becker <felix.b@outlook.com>

view details

Eric Brody-Moore

commit sha dfe7a8a2288b5918cd5eb8643e9f1ce125440889

Distinguish org saved searches from total (#14424) * Distinguish org saved searches from total * indent

view details

Ryan Slade

commit sha 50b829daa2f04dbeb0ac8baa3cea6c09df75b801

repo-updater: Handle null value returned from metric query (#14583)

view details

Ryan Slade

commit sha 963dc0f16934ba2deb746e9ab3b063f81181c018

repo-updater: Don't log when error is nil (#14584) Our logging.Log function doesn't handle multierror's which are empty. Instead, we ensure that if it's empty we pass a nil error.

view details

Quinn Slack

commit sha d947204f7b216004d94c9b504952a986e3685e46

fix white flash on docsite in dark theme (#14586) fix #14492 - Load script in head - Pin pixel height of logo to reduce jitter

view details

push time in 7 days

push eventsourcegraph/sourcegraph

Dan Adler

commit sha abd1397705ae4e81a938ab3deedbfaefb8ba50d6

Remove code intel latencies from pings (#14554)

view details

push time in 7 days

PR merged sourcegraph/sourcegraph

Reviewers
Remove code intel latencies from pings

This rebases https://github.com/sourcegraph/sourcegraph/pull/13827 onto main. No other changes to @ebrodymoore 's original commits

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+18 -53

1 comment

7 changed files

dadlerj

pr closed time in 7 days

delete branch sourcegraph/sourcegraph

delete branch : ebm-codeintel-latencies-2

delete time in 7 days

pull request commentsourcegraph/sourcegraph

web: update generate license description

Can we list the full list of "meaningful" tags here? I see we have dev and true-up, but there are more, and it would be helpful to list them for the sake of consistency if multiple people will be generating licenses.

I'm picturing a table or bulleted list below that first paragraph. What do you think @unknwon ?

unknwon

comment created time in 7 days

push eventsourcegraph/sourcegraph

Thorsten Ball

commit sha 984859023094b76245015ecbee93f24765e22a8a

Use code-bg for code tags in docs (#14557)

view details

Keegan Carruthers-Smith

commit sha 61143bdffa6a43e6b5a3c8bc734bfb576c32f933

search: indexed config API supports multiple repo query arguments (#14558) This converts the API into a batch API by writing a JSON blob per "repo" query parameter in the order they are specified. Each zoekt indexserver currently queries this endpoint with a hardcoded concurrency of 32. This can cause many many HTTP requests, which on a linux machine without tuning can lead to socket errors. By converting this into a batch API we reduce the number of connections as well as moving the responsbility of concurrency to the frontend which has more knowledge of load/etc. We also remove backwards compatibility support where repo wasn't specified. Repo has been specified for multiple releases now.

view details

Ryan Slade

commit sha 9214e6656fbabe74ede778e97e7039f0719f842c

repo-updater: Add critical alerts (#14530) * repo-updater: Add critical alerts The number of user added repos is greater than 90% of our hard limit of 200k. Number of external services added is great than 20k No external services have synced in more than 8 hours. By default we backoff for up to 8 hours, so anything higher than this indicates a problem. * syncer_sync_start should be a rate Alert when we've performed <= 1 syncs for 8 hours. Ideally we want this to be <= 0 but our monitoring package doesn't allow this. Therefore we need to make this a warning as it'll fire for instances that only have 1 external service defined. * Fill in possible solutions and remove unnecessary panel * Adjust rate * Update monitoring/repo_updater.go Co-authored-by: Tomás Senart <tomas@sourcegraph.com> * Update monitoring/repo_updater.go Co-authored-by: Robert Lin <robert@bobheadxi.dev> * Update possible error descriptions * Fix alert * Switch alert to critical Co-authored-by: Tomás Senart <tomas@sourcegraph.com> Co-authored-by: Robert Lin <robert@bobheadxi.dev>

view details

Asdine El Hrychy

commit sha c8c970746592fc2efefa0c7edf7fdd946bec8cc9

Fix crash on Gitlab external service configuration (#14519) OneOf will prevent schemas from being saved and enforce choosing only one of the expected properties

view details

Dax McDonald

commit sha e8c211acd9bd42751d1a60ead7e8185bb6ba37ee

Fix redirects (#14545)

view details

Felix Becker

commit sha f9e62fe4ce323aa3d209711ec7322c6c4d9476c3

Fix nyc include filter after renames (#14563)

view details

Eric Fritz

commit sha 3defa94bffe4e934322712aa5cbb257a951b2406

codeintel: Store index job commands and output in the database (#14457)

view details

Felix Becker

commit sha 2e2becfd20ed38dbff603152c431879a177844eb

Don't show browser extension alert if it's already installed (#14561) Co-authored-by: TJ Kandala <kandalatj@gmail.com>

view details

Felix Becker

commit sha cf65dec202f59a16694764d8b059bb0f5304f921

Add after install page to browser extension (#14407)

view details

Eric Fritz

commit sha 2a5065055979626e8f171fdc1025c4506500bb63

codeintel: Refactor large interface in gitserver layer (#14496)

view details

Rijnard van Tonder

commit sha c46d7b16aa5fc648ce0ec5d1710ac21954f1dd1e

search: trigger search on cmd+enter in console (#14508)

view details

Christina Forney

commit sha 7d54a337c9338f5775cfb18e1ee884e0075415a4

Update links to developer docs in README (#14578)

view details

Rijnard van Tonder

commit sha 9baf830e530a9e52c49a4d21edbd4b0ac84989e9

search: preserve brackets in structural patterns (#14580)

view details

Juliana Peña

commit sha 4509ca63ad85083bf72f783aec553d0f256cfc82

search: homepage panels now use the correct `requestGraphQL` function (#14579) We had two `requestGraphQL` functions and we were using the wrong one. Fixed the homepage panels to use the right function, and also renamed the other one and added comments so hopefully this doesn't happen again.

view details

Marek

commit sha d0d3e568d29a3ae16424f290c74ec8b44d306c38

Update browser extension icon with alert state (#14555) Co-authored-by: Felix Becker <felix.b@outlook.com>

view details

TJ Kandala

commit sha 2fae54f689c5bef09bfe9518315577f78d6634a8

Implement hover alerts for private repositories (#14488) Co-authored-by: Felix Becker <felix.b@outlook.com>

view details

Eric Brody-Moore

commit sha dfe7a8a2288b5918cd5eb8643e9f1ce125440889

Distinguish org saved searches from total (#14424) * Distinguish org saved searches from total * indent

view details

Ryan Slade

commit sha 50b829daa2f04dbeb0ac8baa3cea6c09df75b801

repo-updater: Handle null value returned from metric query (#14583)

view details

Ryan Slade

commit sha 963dc0f16934ba2deb746e9ab3b063f81181c018

repo-updater: Don't log when error is nil (#14584) Our logging.Log function doesn't handle multierror's which are empty. Instead, we ensure that if it's empty we pass a nil error.

view details

Quinn Slack

commit sha d947204f7b216004d94c9b504952a986e3685e46

fix white flash on docsite in dark theme (#14586) fix #14492 - Load script in head - Pin pixel height of logo to reduce jitter

view details

push time in 7 days

push eventsourcegraph/sourcegraph

Dan Adler

commit sha c34e76a0bcba0c8067e1995ec18815523a820f64

changelog

view details

push time in 9 days

pull request commentsourcegraph/sourcegraph

third-party-licenses: add syntect_server licenses

Thanks!

Curious why you included the dependencies of a dependency here—i.e., why include third-party-licenses/ThirdPartySyntectServer.dependencies.json instead of only including the third-party-licenses/ThirdPartySyntectServer.txt file?

I don't see it having any big downsides of course (only small, practical concerns like making this directory more confusing and adding more file formats than necessary), but my impression is that because most of the sub-licenses (standard MIT/BSD/Apache) don't require this sort of sub-attribution, particularly given the code isn't available in this repository (whereas we would want to include these disclosures in the syntect fork).

I'm no expert, of course. Mostly curious if you are doing it to have a margin of safety and because there's no downside, or if you have reason to believe I'm incorrect and we do need to include these.

slimsag

comment created time in 9 days

pull request commentsourcegraph/about

Updating company values

It won't be in this state for long. We are going to continue to iterate on this.

This was actually my assumption, called out in my last note. My personal preference is to make incremental-but-complete improvements to this page than leaving TODOs.

christinaforney

comment created time in 10 days

pull request commentsourcegraph/about

Updating company values

If the only objection to this PR is "content is missing" then I think we should merge. If there are actual concerns with the proposed values then that is worth discussing before merging.

My point definitely wasn't that "content is missing". It was:

It leaves them up to the interpretation of whoever on the team (or otherwise) is reading them at that moment

So in response to your question about whether I have actual concerns about the proposed values, I'm not really 100% sure? I guess I'm 99% sure I'm fine with them—in this case, it feels low risk since the titles are reasonably clear (e.g. "Grow continuously" I don't think there's much left to interpretation, but "Be human" is slightly more vague).

I just noticed the one-liner descriptions at the top in the TOC though. They definitely help alleviate my concern a bit, and simply copying those short descriptions down to each of the sections would be better...

This is purely a process comment, not any sort of opposition to the new values.

christinaforney

comment created time in 10 days

pull request commentsourcegraph/about

Updating company values

Thanks! Love the index at the top, I've wanted it in the past, too.

I'm a little hesitant about adding values that we don't have a description for, though. It leaves them up to the interpretation of whoever on the team (or otherwise) is reading them at that moment. Would you be opposed to leaving them off until that's available in a follow-up PR that I assume you'll be adding?

christinaforney

comment created time in 10 days

issue commentsourcegraph/sourcegraph

React Maximum update depth exceeded errror on search result pages

3.18.0. But these can be super hard to reproduce (I tried when I encountered my issue at the top of the thread, which may be totally unrelated since it was on a site-admin page). These may be two totally unrelated issues as well.

I asked the customer to notify us if the user can capture the stack trace next time. Anything else to request here?

dadlerj

comment created time in 10 days

push eventsourcegraph/sourcegraph

Dan Adler

commit sha 94d4cbe9de11bb9abc849285939a78b51ff288fb

changelog

view details

push time in 10 days

push eventsourcegraph/sourcegraph

Dan Adler

commit sha b5b5cf588ed49d1ebf6dfce2be15913fa24637e5

go formatting

view details

push time in 10 days

push eventsourcegraph/sourcegraph

Dan Adler

commit sha d96d5fbe48a3b42b58fa6f644507cb21c0abdd19

Fix go tests

view details

push time in 10 days

pull request commentslimsag/syntect

Sourcegraph theme updates

Fixes https://github.com/sourcegraph/sourcegraph/issues/14546

slimsag

comment created time in 11 days

PR opened sourcegraph/sourcegraph

Reviewers
Remove code intel latencies from pings

This rebases https://github.com/sourcegraph/sourcegraph/pull/13827 onto main. No other changes to @ebrodymoore 's original commits

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+3 -28

0 comment

4 changed files

pr created time in 11 days

create barnchsourcegraph/sourcegraph

branch : ebm-codeintel-latencies-2

created branch time in 11 days

issue commentsourcegraph/sourcegraph

Add better description and resolution steps for zoekt-webserver: fs_io_operations alert

This is not urgent by the way—just an example of something that came up while the customer was reviewing our default alerts.

dadlerj

comment created time in 11 days

Pull request review commentsourcegraph/sourcegraph

Distinguish org saved searches from total

 func GetSavedSearches(ctx context.Context) (*types.SavedSearches, error) { 	(SELECT COUNT(DISTINCT user_id) FROM saved_searches) AS uniqueUsers, 	(SELECT COUNT(*) FROM event_logs WHERE event_logs.name = 'SavedSearchEmailNotificationSent') AS notificationsSent, 	(SELECT COUNT(*) FROM event_logs WHERE event_logs.name = 'SavedSearchEmailClicked') AS notificationsClicked,-	(SELECT COUNT(DISTINCT user_id) FROM event_logs WHERE event_logs.name = 'ViewSavedSearchListPage') AS uniqueUserPageViews	+	(SELECT COUNT(DISTINCT user_id) FROM event_logs WHERE event_logs.name = 'ViewSavedSearchListPage') AS uniqueUserPageViews,+	(SELECT COUNT(*) FROM saved_searches WHERE org_id IS NOT NULL) AS orgSavedSearches	

Just to confirm, you've checked that org_id is null when it's a user saved search, rather than being zero or some other value?

ebrodymoore

comment created time in 11 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentsourcegraph/sourcegraph

remove stages from pings

Fixes https://github.com/sourcegraph/sourcegraph/issues/14179

dadlerj

comment created time in 11 days

PR opened sourcegraph/sourcegraph

Reviewers
remove stages from pings

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+7 -473

0 comment

14 changed files

pr created time in 11 days

push eventsourcegraph/sourcegraph

Dan Adler

commit sha 09e3486a063bb417446448b3b3f1c1769180267f

Fix types

view details

push time in 11 days

create barnchsourcegraph/sourcegraph

branch : rm-stages

created branch time in 11 days

issue openedsourcegraph/sourcegraph

Add better description and resolution steps for zoekt-webserver: fs_io_operations alert

Reported by https://app.hubspot.com/contacts/2762526/company/693777200

https://docs.sourcegraph.com/admin/observability/alert_solutions#zoekt-webserver-fs-io-operations has no possible solutions

Diff search points me to this commit: https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/commit/e8e86b961b28f769facf1489d2b101ada99f41f7?visible=4

Assigning @bobheadxi but feel free to redirect if someone else should be involved

created time in 11 days

issue commentsourcegraph/sourcegraph

Syntax highlighting contrast fails Web Content Accessibility Guidelines

Note from @slimsag :

Worth reiterating that editing this is really pretty straightforward:

https://sourcegraph.slack.com/archives/C0W2E592M/p1596479729021400?thread_ts=1596324374.013800&cid=C0W2E592M

It also wouldn't be hard for us to offer a high-contrast syntax highlighting theme option in the user settings. I would love that (although it wouldn't match the rest of the app)

dadlerj

comment created time in 11 days

issue openedsourcegraph/sourcegraph

Syntax highlighting contrast fails Web Content Accessibility Guidelines

Reported by https://app.hubspot.com/contacts/2762526/company/693777200

Discussion in Slack: https://sourcegraph.slack.com/archives/C0HMGV90V/p1602173122127700

What customization/color options do we have? I know there are some branding options, but have received feedback about colors that was unexpected.

And from the end user:

Light theme, comments are #93A1A1 on #FFFFFF, with a contrast of 2.67:1, which fails pretty much everything.

Dark theme, they’re #2B8A3E on #0E121B, with a contrast of 4.28:1, which only passes WCAG AA for large text (and objects/UI components), but fails AAA and AA for normal text.

The user suggested that simply adding a high contrast option would be a fine workaround for now

created time in 11 days

issue commentsourcegraph/sourcegraph

Minified React error #185

Just assigning Joel and Felix for triage

dadlerj

comment created time in 11 days

issue commentsourcegraph/sourcegraph

Minified React error #185

Just reported by https://app.hubspot.com/contacts/2762526/company/693777200

I've gotten a react error from SourceGraph a couple of times this morning. Are we monitoring these/reporting them to SG?

Sourcegraph encountered an unexpected error. If reloading the page doesn't fix it, contact your site admin or Sourcegraph support. Minified React error #185; visit https://reactjs.org/docs/error-decoder.html?invariant=185 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.

(refreshing does seem to help)

https://sourcegraph.REDACTED.com/search?q=repo:REDACTED+count:1000+-file:REDACTED+-file:REDACTED+REDACTED&patternType=regexp&case=yes is where I most recently hit it

Details at https://sourcegraph.slack.com/archives/C011899KB6U/p1602194969024400

So a search results page—not on the sidebar!

dadlerj

comment created time in 11 days

issue commentsourcegraph/sourcegraph

Codecov extension not showing "Coverage: N%"

Not urgent for me

sqs

comment created time in 11 days

issue commentsourcegraph/sourcegraph

Codecov extension not showing "Coverage: N%"

Interestingly, it is still visible on GitHub, even while it's not on Sourcegraph.com

image

sqs

comment created time in 11 days

issue commentsourcegraph/sourcegraph

Remove site_activity.Stages from pings

I'd support just removing this entire structure and add that value (ver) as a sub-field to the saved_searches data instead.

ebrodymoore

comment created time in 12 days

issue openedsourcegraph/sourcegraph

No way to specify hostnameToPattern argument in VS Code Sourcegraph extension

Reported by https://app.hubspot.com/contacts/2762526/company/555146901

JIRA ticket: https://sourcegraph.atlassian.net/jira/servicedesk/projects/SG/queues/custom/1/SG-364

Hi,I am trying to use sourcegraph plugin for vs-code. When I try to use Command Palette, Open in sourcegraph it adds a $HOSTNAME/$LOCAL-ORG-NAME/ to the URL and I get a 404 not found. This is my setting:

$REDACTED

After clarifying the URL that opened, we found:

Correct url: https://sourcegraph.example.com/$SG-ORG-NAME/$REPONAME/-/blob/README.md

When opened through VS code plugin: https://sourcegraph.example.com/$HOSTNAME/$LOCAL-ORG-NAME/$REPONAME@master/-/blob/README.md

(obviously I've redacted a lot here... Perhaps easier to check the JIRA thread above)

My takeaway from the above: the site admin has set repositoryPathPattern to convert URLs from $HOSTNAME/$LOCAL-ORG-NAME/$REPONAME to $SG-ORG-NAME/$REPONAME instead.

After digging in to our editor link handler, my hunch is that the lookup breaks because the repo names are different (?).

It looks like at some point in the past we anticipated that this would happen, and added support for the editor to pass in the pattern for replacing links: commit that added it, and where it is used.

Unfortunately it seems that this is not used anywhere in our VS Code plugin: https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/sourcegraph/+repo:vscode+hostname_patterns&patternType=literal

As a potential workaround, I'm going to ask the user to use the sourcegraph.remoteUrlReplacements property (https://marketplace.visualstudio.com/items?itemName=sourcegraph.sourcegraph) to replace $HOSTNAME/$LOCAL-ORG-NAME/$REPONAME with $SG-ORG-NAME/$REPONAME and see if that helps.

created time in 14 days

issue commentsourcegraph/sourcegraph

Metrics or indicator for search readiness (for massive scale instances)

Response to @slimsag :

I actually don't think determinism is a critical component of this (in the way we've used that term to talk about search priorities in the past). Because their searches are comprehensive, the results set should be deterministic, yes, but that's a side effect of the fact that it's comprehensive (rather than inherent to the search)! E.g., order of results doesn't matter, but knowing that 100% of results will be returned is essential.

Curious to hear from @christinaforney @poojaj-tech and @lguychard on how we can better serve this search use case.

dadlerj

comment created time in 14 days

issue commentsourcegraph/sourcegraph

Side by side diff view

Hm, good question. I don't see these two as perfect tradeoffs—if we support Gerrit, that would make some of the customers who want this capability happy, but not all. If we support this feature, that would be nice for some companies that want the Gerrit browser extension, but not all.

Simply comparing the two projects on their own distinct merits, I definitely see Gerrit support as a higher priority though.

dadlerj

comment created time in 16 days

issue openedsourcegraph/sourcegraph

Ability to sort admin users list, repos list, etc. by different columns

Requested by https://app.hubspot.com/contacts/2762526/company/693777200

They'd like to sort the user list by how recently users have been active. I've tried to add this in the past, but it's difficult to do this with our filteredconnection structure.

And of course, even if filteredconnections supported it, it's hard to do this in general given each table is generated in its own way on the backend, and we may not have a GraphQL resolver that accepts an order option...

If helpful, we can break this out into issues for each list.

created time in 18 days

PullRequestReviewEvent

push eventsourcegraph/about

Dan Adler

commit sha 994c335d39a41f4c8d79e8514952b8c46d449a29

Remove "People ops" from page title (#1663)

view details

push time in 18 days

delete branch sourcegraph/about

delete branch : onboarding-title

delete time in 18 days

PR opened sourcegraph/about

WIP: add operations goals
+46 -1

0 comment

2 changed files

pr created time in 18 days

create barnchsourcegraph/about

branch : ops-goals

created branch time in 18 days

issue commentsourcegraph/sourcegraph

Metrics or indicator for search readiness (for massive scale instances)

From @rrhyne :

@keegan, in the streaming search kickoff, we talked about possibly displaying a few of these metrics on a per search basis. Are they all available to display? Would that make sense for each search, or would this kind of content be more appropriate in the search log idea you mentioned?

From @keegancsmith :

these statistics are available to display as the search progresses :slightly_smiling_face: Right now we don't plumb them all the way to the frontend, but we can if we need to (and its quite pleasing to see for longer searches) (edited)

Things like differing result counts hopefully will mostly be solved as streaming gets mature. Root cause is how our file match limits and time limits interact with what is in the cache. Streaming will be able to mostly eliminate time limit part and we can have much higher defaults for file match limits. It won't solve issues around unindexed searches, but maybe our messaging will improve around distinguishing indexed vs non-indexed results.

dadlerj

comment created time in 18 days

issue commentsourcegraph/sourcegraph

Metrics or indicator for search readiness (for massive scale instances)

From @slimsag :

If the question here is more along the lines of "is my deployment healthy in terms of what we see at other customers (accepting that search perf and results are pretty non-deterministic)" then we would want alerts for:

  • If the clone queue (for updating or adding repos) grows too large. This already exists.
  • If Zoekt has not indexed most repositories. We don't have this.
  • If Zoekt is unavailable for some other reason frequently during searches (e.g. network failure.) We don't have this.

But I don't think this is actually what they are asking for. They, understandably, want confidence that search is fast and will return expected results in a deterministic way - which is not really what it is designed to do.

dadlerj

comment created time in 18 days

issue commentsourcegraph/sourcegraph

Metrics or indicator for search readiness (for massive scale instances)

From @slimsag :

I am not sure the actual product request here ("really need a good answer to is Sourcegraph ready for us to start searching now or not") is actually best handled by us on Distribution. More likely it is better handled by Search or Cloud teams, or maybe a mixture of all three - I'm not completely sure.

There are a lot of aspects at play here, including both what you mentioned (which mostly falls under repo-updater/cloud-team and zoekt/search-team) as well as deeper questions like "How do we ensure search performance is deterministic, or communicate that it is not?" this includes things like

  • Zoekt using mmap and the cache being cold and somewhat arbitrarily managed by the Linux kernel and not us. Indexes can "fall out of memory" without us knowing and search perf will then be quite bad until someone runs a search that requires those indexes again, and then search will be fast again. At large scales this means "I get less results and the UI isn't really clear about why"
  • Falling back to unindexed search for a somewhat non-deterministic set of repositories
  • Repositories being searched in a non-deterministic order, leading to non-deterministic amounts of results for the same query ran multiple times
  • Some queries being exponentially more expensive than others, even if indexed, and how to communicate that to users
dadlerj

comment created time in 18 days

issue commentsourcegraph/sourcegraph

Provide service account users for API access

@dadlerj: Is this to avoid the billing associated with a "bot" user?

Exactly, so this can also be solved for now via the sales team/discouts

What's the priority of this request from your perspective? Seems low to me.

Correct! Added ce/p4

dadlerj

comment created time in 18 days

push eventsourcegraph/about

Dan Adler

commit sha d844cb9db9e3d58dbf2ae93a215a8bb7eae38f6b

Add operations RFCs (#1653) * Add operations RFCs * Update link * Update link

view details

push time in 19 days

delete branch sourcegraph/about

delete branch : ops-docs

delete time in 19 days

PR merged sourcegraph/about

Reviewers
Add operations RFCs

Interested to hear feedback! The more I looked at our RFC docs and Christina's PD docs, the more I came to realize that not creating a whole new category would be beneficial. Instead, I created this summary that focuses more on how they are the same than trying to build a new template.

+31 -0

0 comment

2 changed files

dadlerj

pr closed time in 19 days

push eventsourcegraph/about

aileenrose

commit sha ee0a20e7e0a385255b6bda8bd0de62792c724dcc

Add marketing team logo! (#1652) * Add marketing team logo! * Remove VP job

view details

Farhan Attamimi

commit sha b4b3a6e8eb80ab3208ad2994597e865a2e20e41e

Update iteration_log.md

view details

Stefan Hengl

commit sha 80b52a09d6645ffc7168c09046cf7507ddf0f372

Update iteration_log.md

view details

Tomás Senart

commit sha 6040bb717dc47be49c1d472700f81a4cfcfd951b

Update Cloud team processes

view details

Tomás Senart

commit sha 1d6d5e75d9070cf30065a227abd52a36870708aa

Specify which kinds of issues

view details

Eric Brody-Moore

commit sha 205267b9bf68ccd5c85600da562fce49fe8c59a0

Update BizOps workflows (#1654) * Update BizOps workflows * Update index.md

view details

aileenrose

commit sha d431af640d36ca142c615e0ba6fc0822e560818b

Add link and fix meta titles (#1655)

view details

Stephen Gutekanst

commit sha 3f6ae6b675f749c07ccac1f70c3ae6a9d3d83091

distribution: add screencast for how to upgrade managed instances

view details

Stephen Gutekanst

commit sha b67a7b8d88ae43ed176c0c06477fcf31cb52828d

distribution: add missing header

view details

Juliana Peña

commit sha b998f97b74f5de7c61794dfabfbd56b3387e179d

Update iteration_log.md

view details

Nick Snyder

commit sha 5218297795d3372e0de2b0501fc927b42602ece2

format

view details

Nick Snyder

commit sha 382adc5500ba6bc461b119da50447226207375bb

master -> main

view details

Joel Kwartler

commit sha 52a6023ba81696755e6c4a5ac11eef894865f3e6

Formalizing a process for joining customer calls (#1615) * an approved proposal to define and centralize this process since we are using it in many teams' onboarding

view details

Felix Becker

commit sha 190cff5068242d959cc92f963cc5e24b588f4d16

Document 2-week iterations for the web team (#1656)

view details

Rijnard van Tonder

commit sha 2ee7bb82c5f0b0814e7495549988f2e8909eb4bc

Update iteration_log.md

view details

Robert Lin

commit sha 8c112c9e81842b9c57d52c90b1600206aab0991f

deployments: add link to managed instances (#1632)

view details

ElizabethStirling

commit sha 4a4c660fa20049ecb73a4eaaa22f09f11134d1c0

Explain how bounties are paid (#1649) * Explain how bounties are paid * Apply suggestions from code review Co-authored-by: Nick Snyder <nick@sourcegraph.com> Co-authored-by: Nick Snyder <nick@sourcegraph.com>

view details

Quinn Slack

commit sha dea75f3d53a5ce87a01ab57d5bb6b29988e375b6

google docs: no folder structure imposed

view details

Dan Adler

commit sha 3cebe43f7361f0bf7e1cd3ec77b5393e51e99861

Add spacing for bullets (#1664)

view details

Dan Adler

commit sha 01475b9a46d73cd755552de5c4a14aea9ea9ae69

Sales ops onboarding (#1665) * Update onboarding links * Add ops ad sales-ops onboarding * Fix broken links

view details

push time in 19 days

issue openedsourcegraph/sourcegraph

Metrics or indicator for search readiness (for massive scale instances)

Requested by https://app.hubspot.com/contacts/2762526/company/557692805

Discussion in Slack: https://sourcegraph.slack.com/archives/CJX299FGE/p1601066252032700

Context/use case

Company's instance has ~400k repositories, and their primary use case is comprehensive searches . I.e., searches to get ALL of the results across all of their code, even if it's thousands or tens of thousands of matches. They primarily use the API/CLI for this, but using the UI is important as well...

Problem

Overall, what they really need/want is an answer to “Is Sourcegraph ready for us to start searching now or not”. This wraps up several things, and it may be hard to come up with a single great metric here (since we are always cycling repos through the indexing queue). Do we have a good way to answer this question? E.g. some combo of metrics like:

  • How many repos haven’t been cloned at all yet?
  • How many repos don’t have an index at all yet?
  • How many repos haven’t been synced in the last [24h]?
  • How many repos don’t have an index in the last [24h], that do have an update in that time?
  • What is in the queue for indexing right now?
  • How many indexes aren’t loaded into memory yet?
  • Etc.

Additionally, I think updating the Site-admin > Repository status page also needs a bit of work (this falls on Cloud) for instances with huge numbers of repos. Summary metrics for the radio buttons like “Needs index” are probably more important than the full list.

Tagging both Search (for the bulk of this, the actual search stuff) and Distribution (for the metrics/observability aspect).

created time in 19 days

Pull request review commentsourcegraph/sourcegraph

licensing: add new plans and feature tags

 package licensing const ( 	// oldEnterpriseStarter is the old "Enterprise Starter" plan. 	oldEnterpriseStarter Plan = "old-starter-0"

I believe this is just for versioning. Plans change quite frequently, and if a customer was previously on enterprise, and we change what comes for free under enterprise in a new release, we don't want that customer's access to suddenly change as well. We'd have to create a new plan (-1 or -2 or whatever) at that point to reflect the new version, and all enterprise-0s would work the same as they did before.

unknwon

comment created time in 19 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventsourcegraph/about

Dan Adler

commit sha e68c7ee6f86469b9d0b6ebbbf02d86517bad6af1

Update support docs (#1522) * Update support docs * Fix links

view details

push time in 19 days

delete branch sourcegraph/about

delete branch : support-updates

delete time in 19 days

PR merged sourcegraph/about

Reviewers
Update support docs

Updated to be reflect current state! Note this depends on https://github.com/sourcegraph/about/pull/1521 being merged before all of these links will work.

+42 -51

0 comment

2 changed files

dadlerj

pr closed time in 19 days

push eventsourcegraph/about

Chris Pine

commit sha 5085b828de45883620b845fb6859359739a19045

update campaigns team goals (#1520) * update campaigns team goals Update the goals of the Campaigns team. I marked off what we have done (leaving it ~~strike-through~~ as the context is valuable for now). I also added a line about user testing, as that is an important part of validating that we are ready to open this up to a wider set of customers. * Update handbook/engineering/campaigns/index.md

view details

Aida DeWitt

commit sha e8abf0c0db667c7aadac3b25a9fa0bac8372df5d

Added list of teams hiring for full stack role

view details

Robert Lin

commit sha 2ee046a7c6e0a28fb93b19a150c97f07c235a126

reorganize deployment docs for more per-deployment details (#1518) * create a section for each deployment * group topics under 'deployment basics', 'testing', 'kubernetes', 'deploy-sourcegraph'

view details

Quinn Slack

commit sha 154b625f6fdebb581aba759be2d691720e3bee0f

mention local holiday observance in onboarding (#1523)

view details

Quinn Slack

commit sha 9d8dce9a0b2d4d66450556fc5605673dc90acca3

update default branch to main

view details

Quinn Slack

commit sha 9328b56dcec9c1d8cd62970461db911f47f99bff

update edit/history button default branches

view details

Quinn Slack

commit sha d2868712f96bec97bce6204b1273fc2774b55d95

fix too many redirects issue (#1524)

view details

Eric Fritz

commit sha 41f2147ffa2e45d0650dce40a80065c16c8cea0d

Add draft of lsif-go blog post (#1410) * Add draft of lsif-go blog post for 3.19 release. * Add technical writeup. * Update paths. * Replace gifs with asciicasts. * Respond to feedback. * Respond to small feedback. * Collapse blog posts. * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: uwedeportivo <534011+uwedeportivo@users.noreply.github.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: uwedeportivo <534011+uwedeportivo@users.noreply.github.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Fix dead link. * Use indexer, not emitter. * Rework striped mutex explanation. * Rephrase "Stop looking at the stuff that doesn't matter" section. * Rephrase all my idle cores. * Merge sections. * Respond to feedback. * Update narrative. * Commit suggestion. * Fix styles. * Small update to list. * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Aida DeWitt <aida@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Aida DeWitt <aida@sourcegraph.com> * Flip paragraphs. * Update intro paragraph. * edits * it is a huge repo but not a monorepo * Update first link to go AWS SDK. Co-authored-by: Beyang Liu <beyang@sourcegraph.com> Co-authored-by: uwedeportivo <534011+uwedeportivo@users.noreply.github.com> Co-authored-by: Aida DeWitt <aida@sourcegraph.com> Co-authored-by: Quinn Slack <quinn@slack.org>

view details

Gonzalo Peci

commit sha 6aafce86609275a418c458e3e628f7198537e160

Add Sourcegraph Social (#1526) * Add Sourecgraph Social * fixup! Add Sourecgraph Social * Update company/remote/calendar.md Co-authored-by: Quinn Slack <sqs@sourcegraph.com> * Update handbook/communication/index.md Co-authored-by: Quinn Slack <sqs@sourcegraph.com> * fixup! Add Sourecgraph Social * fixup! Add Sourecgraph Social * Update company/remote/index.md Co-authored-by: Quinn Slack <sqs@sourcegraph.com> * Rename calendar.md to social_calendar.md Co-authored-by: Quinn Slack <sqs@sourcegraph.com>

view details

Quinn Keast

commit sha ab431f3c0e0ec78ddf6baf57997cbb7c735ac8cd

Fix line break (#1527)

view details

Beyang Liu

commit sha 4c69ff481ae64dc7f7aeda8e7723ce2deba12230

podcast: fix transcript typos

view details

Beyang Liu

commit sha 8a2be274dbead3a910d4e7c00ec832d5eea7c591

podcast: link to transcript source

view details

Beyang Liu

commit sha 774ce811808ac18f72e867fd6a422f319e849304

podcast: remove um uh from transcript

view details

María Craig

commit sha 8797cf1943038a7c4aea53e00567cf942195743f

Small typos in Social Calendar (#1528)

view details

Gonzalo Peci

commit sha f007baa926b66bc1197ed2a7ebdf41fe45ba7f26

Reorganize on-call, incidents and observability docs (#1529) * Split playbooks to its own section * Move prometheus docs to the observability folder * Move observability to engineering * Move playbooks to a dedicated space * Fix broken links * Update handbook/engineering/incidents/on_call.md Co-authored-by: uwedeportivo <534011+uwedeportivo@users.noreply.github.com> * Update handbook/engineering/incidents/on_call.md Co-authored-by: uwedeportivo <534011+uwedeportivo@users.noreply.github.com> Co-authored-by: uwedeportivo <534011+uwedeportivo@users.noreply.github.com>

view details

Beyang Liu

commit sha b03ec2e7b0c26fdf9e23372cb8bbd0c21e390418

podcast: publish ms

view details

Gonzalo Peci

commit sha 090fed8b680f315f6b92d8d95b2e15aff11df36e

Remove deprecated shared document (#1530)

view details

Aida DeWitt

commit sha 1b1b71552f80fdf16b9f57e8e7313a0c6a033946

Minor formatting fix

view details

Pooja Jain

commit sha cd19e6cbe1d54d74a5b1d9d58909857398612b97

Add search goals to team page (#1462) * Add search team goals to team page * Update formatting * small formatting changes * Apply suggestions from code review Co-authored-by: Nick Snyder <nick@sourcegraph.com> * Update index.md move current focus and link to tracking issue under ## short term heading * Update handbook/engineering/search/index.md Rename to "Shareable" Co-authored-by: Farhan Attamimi <farhan@sourcegraph.com> * Update index.md rename to "Shareable" * Update handbook/engineering/search/index.md update phrasing for new user search experience Co-authored-by: Farhan Attamimi <farhan@sourcegraph.com> * Update index.md Rephrase to add "OpenGrok users eagerly migrate to Sourcegraph" * Update index.md Update to "Search expressions" Add links to term explanations that are potentially conflicting. * Update index.md Update Vision with suggested changes * Update index.md Update streaming and responsive search related content and add Plan: where the solution being worked on isn't obvious. * Update index.md updated phrasing for streaming search * Update index.md nit periods * Update index.md Remove wildcard syntax from short term goals until prioritization is clear * Update handbook/engineering/search/index.md Rephrase to focus on how search shows value of Sourcegraph to users Co-authored-by: Loïc Guychard <loic@sourcegraph.com> * Update handbook/engineering/search/index.md * Update index.md Delete long term goals since it largely overlaps with vision. * Update handbook/engineering/search/index.md * Update handbook/engineering/search/index.md Medium term goal for scaling indexed search Co-authored-by: Nick Snyder <nick@sourcegraph.com> * Update index.md small formatting change, add WIP to medium term goals * Update handbook/engineering/search/index.md Remove "Scalable" categorization. Co-authored-by: Nick Snyder <nick@sourcegraph.com> * Update index.md Fix broken formatting Co-authored-by: Pooja Jsin <poojajain@poojas-mbp.attlocal.net> Co-authored-by: Christina Forney <forney.christina@gmail.com> Co-authored-by: Christina Forney <christina@sourcegraph.com> Co-authored-by: Nick Snyder <nick@sourcegraph.com> Co-authored-by: Farhan Attamimi <farhan@sourcegraph.com> Co-authored-by: Loïc Guychard <loic@sourcegraph.com>

view details

Beyang Liu

commit sha 725255fae6fa92406735b361cae6bf71ccdf5bf9

typo

view details

push time in 19 days

push eventsourcegraph/about

Dan Adler

commit sha 8605d073f7cd193bf35f8e1b19f149c3ad9ad12d

Add CE to Eng handover docs (#1521) * Add CE to Eng handover docs * Add to index * Update * Tweaks for comments * Tweak

view details

push time in 19 days

delete branch sourcegraph/about

delete branch : ce-eng

delete time in 19 days

PR merged sourcegraph/about

Reviewers
Add CE to Eng handover docs

Given the recent discussion, I wanted to get this written down. This is a WIP document, and will be living for some time, especially as more clarity comes to the roles and responsibilities of the CE team. However, I thought it would be beneficial to document the "current state", even if it's not long-lived.

I only added one "new" thing to the process here: a priority tagging system that CE can use to communicate to Eng. Curious to hear your thoughts.

CC @nicksnyder @christinelovett @tistru for visibility

+38 -1

0 comment

2 changed files

dadlerj

pr closed time in 19 days

push eventsourcegraph/about

Dan Adler

commit sha 1f1f4f81706c19067f165a29c87c64bdb06105c3

Tweak

view details

push time in 19 days

push eventsourcegraph/about

Chris Pine

commit sha 5085b828de45883620b845fb6859359739a19045

update campaigns team goals (#1520) * update campaigns team goals Update the goals of the Campaigns team. I marked off what we have done (leaving it ~~strike-through~~ as the context is valuable for now). I also added a line about user testing, as that is an important part of validating that we are ready to open this up to a wider set of customers. * Update handbook/engineering/campaigns/index.md

view details

Aida DeWitt

commit sha e8abf0c0db667c7aadac3b25a9fa0bac8372df5d

Added list of teams hiring for full stack role

view details

Robert Lin

commit sha 2ee046a7c6e0a28fb93b19a150c97f07c235a126

reorganize deployment docs for more per-deployment details (#1518) * create a section for each deployment * group topics under 'deployment basics', 'testing', 'kubernetes', 'deploy-sourcegraph'

view details

Quinn Slack

commit sha 154b625f6fdebb581aba759be2d691720e3bee0f

mention local holiday observance in onboarding (#1523)

view details

Quinn Slack

commit sha 9d8dce9a0b2d4d66450556fc5605673dc90acca3

update default branch to main

view details

Quinn Slack

commit sha 9328b56dcec9c1d8cd62970461db911f47f99bff

update edit/history button default branches

view details

Quinn Slack

commit sha d2868712f96bec97bce6204b1273fc2774b55d95

fix too many redirects issue (#1524)

view details

Eric Fritz

commit sha 41f2147ffa2e45d0650dce40a80065c16c8cea0d

Add draft of lsif-go blog post (#1410) * Add draft of lsif-go blog post for 3.19 release. * Add technical writeup. * Update paths. * Replace gifs with asciicasts. * Respond to feedback. * Respond to small feedback. * Collapse blog posts. * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: uwedeportivo <534011+uwedeportivo@users.noreply.github.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: uwedeportivo <534011+uwedeportivo@users.noreply.github.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Beyang Liu <beyang@sourcegraph.com> * Fix dead link. * Use indexer, not emitter. * Rework striped mutex explanation. * Rephrase "Stop looking at the stuff that doesn't matter" section. * Rephrase all my idle cores. * Merge sections. * Respond to feedback. * Update narrative. * Commit suggestion. * Fix styles. * Small update to list. * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Aida DeWitt <aida@sourcegraph.com> * Update blogposts/2020/optimizing-a-code-intelligence-indexer.md Co-authored-by: Aida DeWitt <aida@sourcegraph.com> * Flip paragraphs. * Update intro paragraph. * edits * it is a huge repo but not a monorepo * Update first link to go AWS SDK. Co-authored-by: Beyang Liu <beyang@sourcegraph.com> Co-authored-by: uwedeportivo <534011+uwedeportivo@users.noreply.github.com> Co-authored-by: Aida DeWitt <aida@sourcegraph.com> Co-authored-by: Quinn Slack <quinn@slack.org>

view details

Gonzalo Peci

commit sha 6aafce86609275a418c458e3e628f7198537e160

Add Sourcegraph Social (#1526) * Add Sourecgraph Social * fixup! Add Sourecgraph Social * Update company/remote/calendar.md Co-authored-by: Quinn Slack <sqs@sourcegraph.com> * Update handbook/communication/index.md Co-authored-by: Quinn Slack <sqs@sourcegraph.com> * fixup! Add Sourecgraph Social * fixup! Add Sourecgraph Social * Update company/remote/index.md Co-authored-by: Quinn Slack <sqs@sourcegraph.com> * Rename calendar.md to social_calendar.md Co-authored-by: Quinn Slack <sqs@sourcegraph.com>

view details

Quinn Keast

commit sha ab431f3c0e0ec78ddf6baf57997cbb7c735ac8cd

Fix line break (#1527)

view details

Beyang Liu

commit sha 4c69ff481ae64dc7f7aeda8e7723ce2deba12230

podcast: fix transcript typos

view details

Beyang Liu

commit sha 8a2be274dbead3a910d4e7c00ec832d5eea7c591

podcast: link to transcript source

view details

Beyang Liu

commit sha 774ce811808ac18f72e867fd6a422f319e849304

podcast: remove um uh from transcript

view details

María Craig

commit sha 8797cf1943038a7c4aea53e00567cf942195743f

Small typos in Social Calendar (#1528)

view details

Gonzalo Peci

commit sha f007baa926b66bc1197ed2a7ebdf41fe45ba7f26

Reorganize on-call, incidents and observability docs (#1529) * Split playbooks to its own section * Move prometheus docs to the observability folder * Move observability to engineering * Move playbooks to a dedicated space * Fix broken links * Update handbook/engineering/incidents/on_call.md Co-authored-by: uwedeportivo <534011+uwedeportivo@users.noreply.github.com> * Update handbook/engineering/incidents/on_call.md Co-authored-by: uwedeportivo <534011+uwedeportivo@users.noreply.github.com> Co-authored-by: uwedeportivo <534011+uwedeportivo@users.noreply.github.com>

view details

Beyang Liu

commit sha b03ec2e7b0c26fdf9e23372cb8bbd0c21e390418

podcast: publish ms

view details

Gonzalo Peci

commit sha 090fed8b680f315f6b92d8d95b2e15aff11df36e

Remove deprecated shared document (#1530)

view details

Aida DeWitt

commit sha 1b1b71552f80fdf16b9f57e8e7313a0c6a033946

Minor formatting fix

view details

Pooja Jain

commit sha cd19e6cbe1d54d74a5b1d9d58909857398612b97

Add search goals to team page (#1462) * Add search team goals to team page * Update formatting * small formatting changes * Apply suggestions from code review Co-authored-by: Nick Snyder <nick@sourcegraph.com> * Update index.md move current focus and link to tracking issue under ## short term heading * Update handbook/engineering/search/index.md Rename to "Shareable" Co-authored-by: Farhan Attamimi <farhan@sourcegraph.com> * Update index.md rename to "Shareable" * Update handbook/engineering/search/index.md update phrasing for new user search experience Co-authored-by: Farhan Attamimi <farhan@sourcegraph.com> * Update index.md Rephrase to add "OpenGrok users eagerly migrate to Sourcegraph" * Update index.md Update to "Search expressions" Add links to term explanations that are potentially conflicting. * Update index.md Update Vision with suggested changes * Update index.md Update streaming and responsive search related content and add Plan: where the solution being worked on isn't obvious. * Update index.md updated phrasing for streaming search * Update index.md nit periods * Update index.md Remove wildcard syntax from short term goals until prioritization is clear * Update handbook/engineering/search/index.md Rephrase to focus on how search shows value of Sourcegraph to users Co-authored-by: Loïc Guychard <loic@sourcegraph.com> * Update handbook/engineering/search/index.md * Update index.md Delete long term goals since it largely overlaps with vision. * Update handbook/engineering/search/index.md * Update handbook/engineering/search/index.md Medium term goal for scaling indexed search Co-authored-by: Nick Snyder <nick@sourcegraph.com> * Update index.md small formatting change, add WIP to medium term goals * Update handbook/engineering/search/index.md Remove "Scalable" categorization. Co-authored-by: Nick Snyder <nick@sourcegraph.com> * Update index.md Fix broken formatting Co-authored-by: Pooja Jsin <poojajain@poojas-mbp.attlocal.net> Co-authored-by: Christina Forney <forney.christina@gmail.com> Co-authored-by: Christina Forney <christina@sourcegraph.com> Co-authored-by: Nick Snyder <nick@sourcegraph.com> Co-authored-by: Farhan Attamimi <farhan@sourcegraph.com> Co-authored-by: Loïc Guychard <loic@sourcegraph.com>

view details

Beyang Liu

commit sha 725255fae6fa92406735b361cae6bf71ccdf5bf9

typo

view details

push time in 19 days

Pull request review commentsourcegraph/about

Add CE to Eng handover docs

+# CE-to-Engineering issue handover process++When a prospect or customer files a new support ticket or raises a new issue, CE and Engineering should follow the steps below to ensure the issue is handled successfully.++## Principles++**CE is always the first line of defense.**++**Engineering should only feel a responsibility to get involved if tagged in by CE.**++**However, once someone is "assigned" to a ticket (whether formally, or they informally take over the conversation), it is up to them to either (1) see the issue through to resolution or (2) assign a new owner.**++Exceptions to the principles above:++- This does not apply to our public GitHub issue tracker; instead, it only applies to [official support channels](support.md). Issues filed in GitHub are the responsibility of Engineering and/or Product.+- Certain customers pay for dedicated support from a member of the Engineering team. Responding to issues filed by these customers is a shared responsibility for the assigned Engineer and CE (whoever sees it first).+- If an engineer sees a new question or issue come in from a company that they've already been introduced to, or if the question is in their direct area of expertise, they are encouraged to jump in directly.++Otherwise, if an engineer sees a new question or issue come in and they are interested in responding, they should just check with CE first (by posting in the #ce Slack channel).++## How CE hands issues to Engineering++1. The assigned CE will first reply to the prospect or customer that reported the issue.+1. If the issue is clearly a bug or a feature request (rather than a question that can be clarified or answered on the spot), [the CE will file or add on to a GitHub issue](customer_issues.md).+1. The CE will add a prioritization label to the issue, from `user/p0` to `user/p4`, based on a combination of (1) the severity of the issue, and (2) the prioritization of the reporting company. These labels mean the following:+  1. `user/p0`: The issue results in the company's Sourcegraph instance being unusable and the company is a [Tier 1 prospect or customer](../sales/index.md#segmentation).+  1. `user/p1`: The issue results in partial loss of functionality or serious disruption and the company is a [Tier 1 or Tier 2 prospect or customer](../sales/index.md#segmentation).

Thanks Julia! Agreed with that approach.

To be transparent, I'm not directly using this methodology yet, but when I started to document my process, this is roughly how I think about my own method for communicating prioritization of issues. This just adds an official tag onto it (versus my handling in a one-off way). I'll merge this now and get feedback from Tion and Christine once it's live.

@pecigonzalo thanks for the feedback. A few notes:

I believe this list is an extension or update to the one described here https://github.com/sourcegraph/about/blob/main/handbook/ce/support.md#slas.

It's actually quite different... That page reflects the promises we make to customers—i.e., the minimum service level required per our contract—while this list reflects our internal prioritization. There clearly is an intimate connection between the two, but they're not quite the same in terms of what they specify and how we want to describe them (and never quite will be).

Here is a draft idea on how we could handle this, I would PR this to incident document:

This is a great conversation—"what do we do about an issue that was described as a given level of seriousness by CE"—but it is slightly different from what this doc is adding. I'd like to start with our definition of how serious an issue is, and you (and Julia and others of course) can nail down the translation of this into the "so what".

dadlerj

comment created time in 19 days

PullRequestReviewEvent

push eventsourcegraph/about

Dan Adler

commit sha 9967bf05a14fcb08d96bd8106f757d46f991cf8e

Add links to onboardign (#1666)

view details

push time in 21 days

more