profile
viewpoint
Dan Adler dadlerj Sourcegraph Inc San Francisco, CA

sourcegraph/python-langserver 101

Language server which talks LSP via JSONRPC for Python.

sourcegraph/emacs-lsp 97

LSP support for Emacs

lsif/lsif.github.io 3

https://lsif.dev

dadlerj/dullard 1

A lightweight, fast XLSX reader

dadlerj/go-github 0

Go library for accessing the GitHub API

dadlerj/gowalker 0

Go Walker is a server that generates Go projects API documentation on the fly.

dadlerj/language-server-protocol 0

Defines a common protocol for language servers.

dadlerj/markvis-bar 0

Bar chart generator for markvis in browser and node.js.

dadlerj/markvis-line 0

Line chart generator for markvis in browser and node.js.

push eventsourcegraph/about

Dan Adler

commit sha b6349aff0951ba22c0fb969e555b1f37971539e4

Update security page (#1365) * Update security page * email -> e-mail * Modified the language for Dan's PR, and contributed some security specific detail (i.e 24x7x365). * Update security.md Minor copy edits. * Final tweaks * Typo Co-authored-by: Chayim I. Kirshen <chayim@gnupower.net> Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>

view details

push time in a day

delete branch sourcegraph/about

delete branch : security-page

delete time in a day

PR merged sourcegraph/about

Reviewers
Update security page

Multiple prospects and customers have found this section of our privacy page confusing. It does not delineate between sourcegraph.com and on-premise data access (e.g. in relation to application logs). This update is intended simply to clarify, without changing the meaning or intention of any of the bullets.

+26 -20

1 comment

1 changed file

dadlerj

pr closed time in a day

push eventsourcegraph/about

Dan Adler

commit sha 38a560ab5e4ea9243f16bfb1666017eda550cee2

Typo

view details

push time in a day

push eventsourcegraph/about

Dan Adler

commit sha f79c2947f6552539a8dc786a0d0c4921db7a7614

Final tweaks

view details

push time in a day

issue commentsourcegraph/sourcegraph

search.largeFiles not working

Anything we can do to investigate this? Curious if any diagnostic data would be helpful here @rvantonder

dadlerj

comment created time in 2 days

pull request commentsourcegraph/about

Add onboarding item: browser search engines

We provide this functionality through all browser extension users, actually (using src as the search engine starter term). It actually pulls in autocomplete suggestions as well, so it's even better than using a manual browser search engine offering.

image

chrispine

comment created time in 2 days

issue commentsourcegraph/sourcegraph

Diff search unreliable: times out fetching large repos. Search recommendations to add quotes is misleading.

@rvantonder sorry to clarify the issue, the timeout is not the problem. Well, it is the problem on their instance, but theirs is severely underpowered/underprovisioned (which is a separate conversation).

The timeouts are painful, but a separate thread. Quotes being added to the search by the recommendation (and thus changing the meaning of the search itself) was the only issue I wanted to raise here!

dadlerj

comment created time in 2 days

issue openedsourcegraph/sourcegraph

Timeout search recommendations in literal mode add quotes to searches

Just watched this happen during a demo with https://app.hubspot.com/contacts/2762526/company/2428850551.

Repro:

  1. https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/kubernetes/kubernetes%24+.+type:diff+timeout:1s&patternType=literal

  2. Click on the suggested search

  3. Note that quotes get added around the search term (. -> ".")

created time in 2 days

issue openedsourcegraph/sourcegraph

Not redirected to previous page after sign-in

Reported by https://app.hubspot.com/contacts/2762526/company/1686989427

A customer reported that after returning to Sourcegraph, taking some action (e.g. a search), and getting redirected to their SSO provider to sign in, they aren't returned back to that original search after completing the sign-in.

Not an urgent issue, but a small annoyance. And they are uncertain as to whether it's due to a limitation on their side.

I haven't tried to reproduce yet.

created time in 2 days

pull request commentsourcegraph/about

Update with new link to Dan's video with caption track

Just to check, where is this file located in Drive? It's in the shared drive, right, not your personal folder? If so, can you move it to the top-level "Customer engineering" folder?

quinnkeast

comment created time in 2 days

PR opened sourcegraph/about

Reviewers
Add information security policy acknowledgement to onboarding

This is only an initial outline of what we'll ultimately need in terms of new hire information security acknowledgement. I'd love to ask for support from the @sourcegraph/security team in fleshing out an actual internal policy doc that is actually useful and relevant, while still being concise and avoiding a bunch of boilerplate.

Please let me know if you support the form I've added here.

+1 -0

0 comment

1 changed file

pr created time in 3 days

create barnchsourcegraph/about

branch : security-acknowledgement

created branch time in 3 days

push eventsourcegraph/about

Dan Adler

commit sha 61a7184f7f53064545bb7eef2df6dd033432b0a8

email -> e-mail

view details

push time in 3 days

Pull request review commentsourcegraph/about

Update security page

 Learn more in our [pings documentation](https://docs.sourcegraph.com/admin/pings  [Sourcegraph can be configured to enforce repository permissions from code hosts.](https://docs.sourcegraph.com/admin/repo/permissions). Unit and integration tests protect the correctness of these permissions checks. -## Customer data+## Data access +When you run Sourcegraph on your own infrastructure, all application and user access logs are stored locally only. Sourcegraph employees and contractors never have access to your Sourcegraph or the code, user data, or application data stored in it (excluding any manual intervention, such as e-mailing logs for support purposes).++We maintain the following policies for sourcegraph.com data and any data provided via email or other support channels:
We maintain the following policies for sourcegraph.com data and any data provided via e-mail or other support channels:
dadlerj

comment created time in 3 days

PR opened sourcegraph/about

Reviewers
Update security page

Multiple prospects and customers have found this section of our privacy page confusing. It does not delineate between sourcegraph.com and on-premise data access (e.g. in relation to application logs). This update is intended simply to clarify, without changing the meaning or intention of any of the bullets.

+6 -3

0 comment

1 changed file

pr created time in 3 days

create barnchsourcegraph/about

branch : security-page

created branch time in 3 days

issue commentsourcegraph/sourcegraph

Cross-language API/IDL support (GraphQL, Thrift, Protobuf)

Requested by https://app.hubspot.com/contacts/2762526/company/451097663 during a training session today (for GraphQL)

sqs

comment created time in 3 days

issue commentsourcegraph/sourcegraph

Basic Protobuf/Thrift/GraphQL/etc. code intel

Requested by https://app.hubspot.com/contacts/2762526/company/451097663 during a 101 training session today

sqs

comment created time in 3 days

push eventsourcegraph/careers

Dan Adler

commit sha 51818a1ec06eda0b471a1c0aa0590357b7384fab

Sales Ops Analyst --> Open to more senior manager for this role as well (#118) * Sales Ops Analyst --> Open to more senior manager for this role as well * Update README.md

view details

push time in 3 days

delete branch sourcegraph/careers

delete branch : salesops

delete time in 3 days

push eventsourcegraph/careers

Dan Adler

commit sha 0e8e8587ea6a78e631d5fadbeb45122ea280df4a

Update README.md

view details

push time in 3 days

Pull request review commentsourcegraph/careers

Sales Ops Analyst --> Open to more senior manager for this role as well

 We're hiring! Check out our open positions: ### Sales  - [Account Executive](https://github.com/sourcegraph/careers/blob/master/job-descriptions/account-executive.md)-- [Sales Strategy & Operations Analyst](https://github.com/sourcegraph/careers/blob/master/job-descriptions/gtm-sales-operations.md)+- [Sales Strategy & Operations Analyst or Manager](https://github.com/sourcegraph/careers/blob/master/job-descriptions/gtm-sales-operations.md)  ### Customer engineering  - [Customer Engineer](https://github.com/sourcegraph/careers/blob/master/job-descriptions/customer-engineer.md)  ### Operations, finance, and legal--- [Sales Strategy & Operations Analyst](https://github.com/sourcegraph/careers/blob/master/job-descriptions/gtm-sales-operations.md)+- [Sales Strategy & Operations Analyst or Manager](https://github.com/sourcegraph/careers/blob/master/job-descriptions/gtm-sales-operations.md)

- [Sales Strategy & Operations Analyst or Manager](https://github.com/sourcegraph/careers/blob/master/job-descriptions/gtm-sales-operations.md)
dadlerj

comment created time in 3 days

push eventsourcegraph/careers

Dan Adler

commit sha 040f49146deba5420b3654d6bf0733926508083a

Contract manager-->Senior Commercial Counsel (#111)

view details

Nick Snyder

commit sha c61b8aabc2ad195421d30562fb37d5fef591311b

Engineering Manager - Web (#112)

view details

Noemi Mercado

commit sha feafb9dd9a6428e62ea87c34349e9e8886df9420

Removing Recruiter role I'll be closing this req.

view details

Noemi Mercado

commit sha a1aa1c53a7a204ab12d013e1529c2618ad120cee

Delete technical-recruiter.md Closing the req and removing from our careers page.

view details

Chayim

commit sha 6e4f00b2319c13a98c572481bacea3af6d8f2abc

Update software-engineer-security.md (#113) Updated job description for security engineer. Included link back to the handbook. Co-authored-by: Chayim I. Kirshen <chayim@gnupower.net> Co-authored-by: Nick Snyder <nick@sourcegraph.com>

view details

Quinn Slack

commit sha d1de487e7d83a7c84b31776a92cc2c8419467105

remove developer advocate (#117) We are not currently hiring for this position, although we will be soon.

view details

withdavidli

commit sha eafd8993e9b0aa3f4a07b844f5f3ee314405479c

Update software-engineer-security.md (#116) Suggest changing Qualification section to the following instead of leaving it open to all experiences. This will cut down on the number of applicants that are not qualified, do not have any security experience, or do not have experience developing software.

view details

Nick Snyder

commit sha 2a84e10e0d3678aea2e0f1fc4d99092c55391d7b

Update CODEOWNERS

view details

Dan Adler

commit sha e78bb99b78403c9abe7a48e45e3bb3ffedb77529

Merge branch 'master' into salesops

view details

push time in 3 days

create barnchsourcegraph/careers

branch : salesops

created branch time in 3 days

PR closed sourcegraph/about

WIP: Add customer engineering handbook docs

More to come here before ready for merging.

+98 -3

2 comments

10 changed files

dadlerj

pr closed time in 3 days

pull request commentsourcegraph/about

WIP: Add customer engineering handbook docs

Didn't even realize this was still open!

dadlerj

comment created time in 3 days

delete branch sourcegraph/about

delete branch : dan-pronunciation

delete time in 3 days

PR closed sourcegraph/about

Reviewers
Add dan's name pronunciation

Should I use a phonetic alphabet, or is this sufficient? E.g. "dæn"?

+1 -0

10 comments

1 changed file

dadlerj

pr closed time in 3 days

pull request commentsourcegraph/about

Add dan's name pronunciation

I'll do this the way other teammates are now doing it at some point instead!

dadlerj

comment created time in 3 days

delete branch sourcegraph/about

delete branch : ce-onboarding

delete time in 4 days

push eventsourcegraph/about

Dan Adler

commit sha 907b02098014a2ec158b58ff381f23b9c94867e3

Update CE onboarding training session steps (#1352)

view details

push time in 4 days

PR merged sourcegraph/about

Reviewers
Update CE onboarding training session steps

FYI @nicksnyder

+2 -3

0 comment

1 changed file

dadlerj

pr closed time in 4 days

PR opened sourcegraph/about

Reviewers
Update CE onboarding training session steps

FYI @nicksnyder

+2 -3

0 comment

1 changed file

pr created time in 4 days

create barnchsourcegraph/about

branch : ce-onboarding

created branch time in 4 days

issue commentsourcegraph/sourcegraph

Sourcegraph not recognizing that GitHub Enterprise repos are archived

@keegancsmith @unknwon find much more context in the customer thread in Slack: https://sourcegraph.slack.com/archives/CFNURMWHE/p1596125200035400?thread_ts=1596072731.028300&cid=CFNURMWHE

dadlerj

comment created time in 5 days

push eventsourcegraph/about

Dan Adler

commit sha 7a4ba112352345e999c5b4093a0dd47a4340fa91

Update Dan's title (#1331) Title change to better reflect role and responsibilities going forward.

view details

push time in 5 days

delete branch sourcegraph/about

delete branch : dan-title-change

delete time in 5 days

PR merged sourcegraph/about

Update Dan's title

Title change to better reflect role and responsibilities going forward.

+1 -1

0 comment

1 changed file

dadlerj

pr closed time in 5 days

PR opened sourcegraph/about

Reviewers
Update Dan's title

Title change to better reflect role and responsibilities going forward.

+1 -1

0 comment

1 changed file

pr created time in 5 days

create barnchsourcegraph/about

branch : dan-title-change

created branch time in 5 days

delete branch sourcegraph/about

delete branch : onboarding-1-1s

delete time in 8 days

push eventsourcegraph/about

Dan Adler

commit sha 2ece380158f2a2cab649784d3ce3a7903cb31b34

Add setting up 1 on 1s with distribution and sales (#1311)

view details

push time in 8 days

PR opened sourcegraph/about

Reviewers
Add setting up 1 on 1s with distribution and sales
+2 -0

0 comment

1 changed file

pr created time in 8 days

create barnchsourcegraph/about

branch : onboarding-1-1s

created branch time in 8 days

issue commentsourcegraph/sourcegraph

Sourcegraph not recognizing that GitHub Enterprise repos are archived

Is it possible that there's some race-condition-y thing where the repo got put into a weird state? E.g.:

  • We had the repo (before it was archived) on Sourcegraph
  • They archived it
  • Repo-updater checks for the repo list... The external service config tells it that we should exclude archived repos, and the GitHub API tells us that that repo was archived, so we stop fetching it and stop updating its metadata (WITHOUT going and flipping the "archived" flag in the db)
  • The syncer doesn't realize that it is archived, so it keeps getting re-scheduled for syncing (without ever updating the repo metadata)

This is a totally made up image of how these things all work together, but I hope you can get the idea that I'm going for here :)

dadlerj

comment created time in 9 days

issue commentsourcegraph/sourcegraph

Sourcegraph not recognizing that GitHub Enterprise repos are archived

From the customer:

One other thing I thought I’d mention: The fork exclusion on our instance does work, fork:yes/no/only all produce results as expected.

Perhaps there's a new version of the API for archived status? Or perhaps if the users explicitly exclude those repos in their ext service config, we automatically mark all repos as archived=false?

dadlerj

comment created time in 9 days

issue commentsourcegraph/sourcegraph

Sourcegraph not recognizing that GitHub Enterprise repos are archived

But from the GHE instance: image

dadlerj

comment created time in 9 days

issue commentsourcegraph/sourcegraph

Sourcegraph not recognizing that GitHub Enterprise repos are archived

And the result of that query:

sourcegraph=# select archived, metadata from repo where name like '%myorg/myrepo%';
 archived |                                                                                                                                  metadata
----------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 f        | {"ID": "$REDACTED", "URL": "https://github.example.com/myorg/myrepo", "IsFork": false, "IsPrivate": false, "DatabaseID": $REDACTED, "IsArchived": false, "Description": "", "NameWithOwner": "myorg/myrepo", "ViewerPermission": ""}
(1 row)

(actual org and repo name and URL removed)

dadlerj

comment created time in 9 days

issue commentsourcegraph/sourcegraph

Sourcegraph not recognizing that GitHub Enterprise repos are archived

Confirmed they are using a GitHub config, and they are on the GHE 2.21.2 release from a few weeks ago.

Interestingly, their ext service config actually had the following in it:

"exclude": [
                {
                    "archived": true
                },

Asked them to run the query above.

dadlerj

comment created time in 9 days

issue openedsourcegraph/sourcegraph

Sourcegraph not recognizing that GitHub Enterprise repos are archived

  • Sourcegraph version: 3.16

Reported by https://app.hubspot.com/contacts/2762526/company/693777177

When searching repositories on our internal Sourcegraph client, the archived: flag doesn’t seem to be reflected in search results

The customer reports seeing the same set of repos with archived:yes and archived:no (and no results at all with archived:only) even though at least one is archived (screenshot from GitHub Enterprise, the code host, confirms it).

Do we recognize archived status from all code hosts, including GitHub Enterprise? Should I ask about the external service config here?

created time in 10 days

PR opened sourcegraph/about

Reviewers
Update routing_questions.md
+7 -1

0 comment

1 changed file

pr created time in 10 days

create barnchsourcegraph/about

branch : add-auth-to-routing

created branch time in 10 days

push eventsourcegraph/about

Dan Adler

commit sha 7fc31696ca07b00b2c750e4de856ab5f1c3da30c

Fix newlines in ce training docs (#1301)

view details

push time in 10 days

delete branch sourcegraph/about

delete branch : dadlerj-patch-1

delete time in 10 days

PR merged sourcegraph/about

Reviewers
Fix newlines in ce training docs
+11 -0

0 comment

1 changed file

dadlerj

pr closed time in 10 days

PR opened sourcegraph/about

Reviewers
Fix newlines in ce training docs
+11 -0

0 comment

1 changed file

pr created time in 10 days

create barnchsourcegraph/about

branch : dadlerj-patch-1

created branch time in 10 days

push eventsourcegraph/about

Dan Adler

commit sha 5ed343435c5719a8b5ccf72e90f7591fe1413ccc

Add Austin and Tion to CE team (#1298)

view details

push time in 10 days

delete branch sourcegraph/about

delete branch : ce-team2

delete time in 10 days

push eventsourcegraph/about

Dan Adler

commit sha 2af77b1ab8d1893742d8de17edb56d417ea72636

Add training sessions to CE handbook (#1299)

view details

push time in 10 days

delete branch sourcegraph/about

delete branch : demo-flow

delete time in 10 days

PR merged sourcegraph/about

Reviewers
Add training sessions to CE handbook
+122 -0

1 comment

2 changed files

dadlerj

pr closed time in 10 days

pull request commentsourcegraph/about

Add training sessions to CE handbook

Thanks for the quick review @christinelovett !

dadlerj

comment created time in 10 days

issue commentsourcegraph/sourcegraph

Default search scope

Requested by https://app.hubspot.com/contacts/2762526/company/732945850 again just now:

Can we have count:1000 added to queries by default? Users are providing feedback to us that they don't like to add that in for each query.

beyang

comment created time in 10 days

PR opened sourcegraph/about

Reviewers
Add training sessions to CE handbook
+122 -0

0 comment

2 changed files

pr created time in 10 days

PR opened sourcegraph/about

Reviewers
Add Austin and Tion to CE team
+2 -2

0 comment

1 changed file

pr created time in 10 days

create barnchsourcegraph/about

branch : ce-team2

created branch time in 10 days

create barnchsourcegraph/about

branch : demo-flow

created branch time in 10 days

pull request commentsourcegraph/about

Update index.md

I think you have to add "https://" or "http://" in front of all external links—i.e., your LinkedIn. Otherwise this looks great, thanks!

tistru

comment created time in 10 days

CommitCommentEvent
CommitCommentEvent
CommitCommentEvent

issue openedsourcegraph/sourcegraph

search.largeFiles not working

Reported by https://app.hubspot.com/contacts/2762526/company/693777200

The user set search.largeFiles in his site config, then added a series of globs (e.g. *.ts). I then watched him run a search for the term that should have returned a match in a >1mb generated .ts file. It did not show up with index:only in the query.

Unfortunately, when we tried index:no, the search timed out (even with count:1000, it took so long that we hit a 504 gateway timeout), so there's no easy way to test given the scale of their monorepo.

I know that indexing has to re-run before it would be available, so I'll let them know to try waiting a few hours or a day with that in the config. Filing this preemptively in case that doesn't solve it.

created time in 16 days

push eventsourcegraph/sourcegraph

Dan Adler

commit sha 3f383db8a6757c9616a1bad36fa1c08403d8df0b

Add link to saved searches page in email (#11651) * Add link to saved searches page in email * Add changelog * Update changelog

view details

push time in 16 days

delete branch sourcegraph/sourcegraph

delete branch : saved-search-email

delete time in 16 days

PR merged sourcegraph/sourcegraph

Add link to saved searches page in email

Adds a useful link to saved search emails

+17 -2

2 comments

3 changed files

dadlerj

pr closed time in 16 days

push eventsourcegraph/sourcegraph

uwedeportivo

commit sha 87bf397d138233d8d06173d196c943994dd3b43e

Update latest release to 3.17.0 (#11607)

view details

Christina Forney

commit sha 571996f0dd2f9192bf0bed205eedc97a8bfd6479

Update permissions syncing for 3.17 release (#11608)

view details

Robert Lin

commit sha 716ceb75498932353008cdbb22e500d4221d15cb

docker-images(grafana): grafana v7 (#11583)

view details

ᴜɴᴋɴᴡᴏɴ

commit sha 7dffab3947bb924bbdef5cef44af3be3762047e3

e2e: add search tests (#11603)

view details

Thorsten Ball

commit sha 159091e03c87891c7141ef02e6a4f4aa6ea9860a

perf: Do not unnecessarily load patches.diff from DB (#11588) * perf: Do not unnecessarily load patches.diff from DB Most of the time when we load patches from the database we don't need to load the `diff` column, since we're mainly interested in foreign keys or the diff stat columns. Since the `diff`s can get pretty big, it makes sense to only load them when necessary. By not loading them, we should get a speed bump and use less memory for requests in which we're really only interested in the other columns (e.g. when we calculate the diff stat). This should fix #11126. * Use sqlf.Sprintf instead of strings.Replace

view details

Keegan Carruthers-Smith

commit sha d859cbb471cda6e3c21e2ee3de203d9a7ffac55d

repo-updater: dynamically update syncer update interval (#11630) I noticed this small change while working on something else. If someone updates the configuration for the update interval it won't take effect until the repo-updater process restarts. With this commit we will check the interval before we do the sleep, so will not require a process restart.

view details

Keegan Carruthers-Smith

commit sha 7a3a85b2881cd4cd9f915a012cb07817756831a7

repo-updater: optimize computeNotClonedCount (#11629) Co-authored-by: Stephen Gutekanst <stephen.gutekanst@gmail.com>

view details

Keegan Carruthers-Smith

commit sha c667073852cfa57635ec8f45c8380edf8655cd76

repo-updater: remove updateScheduler mutex (#11632) As far as I can tell this mutex serves no purpose. The only possible purpose is to serialize calls to UpdateFromDiff. However, the individual upsert and remove calls on the scheduler and queue have there own mutexes. Possibly if we had two concurrent `UpdateFromDiff` we could have an inconsistent state, but it would converge at the next UpdateFromDiff call. Additionally we only have one call site for UpdateFromDiff, and that never runs concurrently.

view details

Robert Lin

commit sha 5a395d91137670174aea4d217fe3be694e2d67ca

cmd(server): fix build version embed (#11633)

view details

Keegan Carruthers-Smith

commit sha e6a17497adf65f6e74d73f496bc75794c1a395fa

repo-updater: periodically bump priority of uncloned repositories (#11628) The git fetch/clone scheduler is unaware of which repositories are cloned or uncloned. It is only aware of repositories from the code host syncer. A repository can not be cloned even if the scheduler is aware of it for a few reasons: - The repository failed to cloned. - The repository was removed due to disk pressure. This commit adds a periodic sync between the list of repositories gitserver has cloned and the state of the scheduler. We walk the list of all repositories in the scheduler and if it is not cloned, we update its "due" date to be as if the repository was new (default 45s until we clone it). Note: all repositories returned from the repo store are in the scheduler via the code host syncer.

view details

Erik Seliger

commit sha 21553808511e9f0d9385dc917f0b8fbf05f1a216

Only create GitCommitResolver when doing symbol search (#11620) Previously, it would have been created independently of the search type.

view details

Robert Lin

commit sha 744fad15353726426ec41896bc21afaf7ddd8adc

monitoring: provisioning alerts fixes (#11542) * fix docs to consider both high and low cases * separate prom alerts descriptions * add changelog entry * Update CHANGELOG.md Co-authored-by: Stephen Gutekanst <stephen.gutekanst@gmail.com>

view details

Stephen Gutekanst

commit sha 34bd18124d6e3e6c1849e53d70d1650849837c70

./dev/zoekt/update (#11659)

view details

Robert Lin

commit sha 0e8b5da89940c939e26eb6d28999436bce71a5c8

schema: add support for OpsGenie notifier (#11615)

view details

Stephen Gutekanst

commit sha f142c9ce4e8d9c7d36579cdc4dd9ce487a74cdcd

fix upgrading from v3.17.0 -> v3.17.1 (#11667) * add failing test to reproduce upgrade issue #11666 * fix the failing test

view details

Keegan Carruthers-Smith

commit sha a1e179344d5962f9442018eeba24cb532bbf1570

search: always enable searchMultipleRevisionsPerRepository (#11671) This feature is ready for use. It is also required for Version Contexts to function with a repository being specified more than once. The CHANGELOG entry is copied from the original addition of the experimental feature.

view details

Keegan Carruthers-Smith

commit sha c073a0503df6db9b493d99a2add608f4e028586d

grafana: avoid copying go files in tree (#11673) The grafana build script temporarily copies ./monitoring to ./docker-images/grafana/monitoring. ./monitoring contains go files. However, whenever go files change our dev script would want to rebuild the things that have changed. So we would get into this state where the grafana build script would keep adding and removing go files, and our dev script would keep deciding we need to rebuild grafana. This commit does the build out of tree instead, to avoid the watch script seeing the go files come and go. An alternative implementation would be adding an ignore to the temporary directory, but that requires touching more places. Instead we adjust the hack used by grafana/build.sh.

view details

Keegan Carruthers-Smith

commit sha 0653305db9f2f0c0d8bd59fd9e2bb94d3b313426

zoekt: treat repo names case sensitively (#11670) Previously we treated zoekt repositories as if the case would not match what is returned from the repo database. However, Zoekt requires the correct caseing of the repo name to do the search. Additionally Zoekt uses the correct casing of the repo name when indexing. So the uses of ToLower when checking if a repo was indexed was unnecessary. Additionally in the case a repository name changed case we would incorrectly believe we have indexed the repo, but the actual zoekt search would fail due to the index being case sensitive. Additionally avoiding the calls to ToLower should improve performance. However, I didn't validate this (but naively it should).

view details

Keegan Carruthers-Smith

commit sha 9d90dc58264abf3d59159024f229efcf0ce6fd23

dev: watchman ignores hidden files (#11674) I noticed editors and other tools will often write to temporarily hidden files. This excludes them from triggering a rebuild. Note: we will still watch hidden directories, just not hidden files.

view details

Stephen Gutekanst

commit sha 53afb2e12e35b24d4138eee31767241f705fe44d

Update latest release to 3.17.1 (#11681)

view details

push time in 16 days

issue commentsourcegraph/sourcegraph

Branch names not showing up on search results

Interesting! I didn't realize that. I know that sometimes the branch name shows up (e.g. with version contexts, with specifically named branches in a search, etc.) so this was surprising. Thanks for raising it to product.

dadlerj

comment created time in 16 days

issue commentsourcegraph/sourcegraph

src-expose is first class

I'm fine with the name change. I don't think the external service piece is critical up-front...

Alternatively, would it be possible to simply add a button to the external services page that reflects src serve-git, and when you click it, it starts with that default config? Essentially, still use the "generic git host" service under the hood, but add a nice UI for it.

Adding this to the src cli is actually an interesting topic... I can see lots of benefits (e.g., release versioning, etc.), but this functionality definitely has a different UX (running as a server, often deployed via Docker on a remote machine, etc.). I don't want to have to backtrack on that decision now, but I'm curious what your thoughts are on doing this vs putting it in /cmd and running it alongside Sourcegraph?

keegancsmith

comment created time in 17 days

issue commentsourcegraph/sourcegraph

Branch names not showing up on search results

Could this also be related to the version context issue discussed in Slack? https://sourcegraph.slack.com/archives/CHEKCRWKV/p1595362401130000

dadlerj

comment created time in 17 days

issue openedsourcegraph/sourcegraph

Branch names not showing up on search results

Sourcegraph.com

Repro: https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/sourcegraph/sourcegraph%24%40*refs/heads/:%5Erefs/heads/master+file:migrations/++type:diff&patternType=literal

This search is ONLY searching non-default/non-master branches, but the branch names don't seem to show up on search result lines.

image

created time in 17 days

Pull request review commentsourcegraph/sourcegraph

Add link to saved searches page in email

 All notable changes to Sourcegraph are documented in this file. - Alerts are now configured using `observability.alerts` in the site configuration, instead of via the Grafana web UI. This does not yet support all Grafana notification channel types, and is not yet supported on `sourcegraph/server` ([#11473](https://github.com/sourcegraph/sourcegraph/issues/11473)). For more details, please refer to the [Sourcegraph alerting guide](https://docs.sourcegraph.com/admin/observability/alerting). - Experimental basic support for detecting if your Sourcegraph instance is over or under-provisioned has been added through a set of dashboards and warning-level alerts based on container utilization. - Query [operators](https://docs.sourcegraph.com/user/search/queries#operators) `and` and `or` are now enabled by default in all search modes for searching file content. [#11521](https://github.com/sourcegraph/sourcegraph/pull/11521)+- Saved search emails now include a link to the user's saved searches page. [#11651](https://github.com/sourcegraph/sourcegraph/pull/11651)
dadlerj

comment created time in 17 days

issue commentsourcegraph/sourcegraph

Unindexed repositories for Structural Search

Update from the customer:

If you visit the Site-admin > Repository Status page, and click on the "Needs index" option, how many do you see show up?

None show up under "Needs index".

did you ever disable search indexing (via setting the site-admin configuration option search.index.enabled to false)

I don't think we did and I don't see that option under site-admin/configuration.

poojaj-tech

comment created time in 18 days

issue commentsourcegraph/sourcegraph

Support for HTTPS_PROXY, HTTP_PROXY, and NO_PROXY env vars

Update from @slimsag:

To be completely clear, my analysis is that (1) we do not support *_PROXY and (2) that we should not support it because it is too limited. We need a different format than just respecting _PROXY so it is not brittle, preferably done through the site configuration.

dadlerj

comment created time in 18 days

issue openedsourcegraph/sourcegraph

Support for HTTPS_PROXY, HTTP_PROXY, and NO_PROXY env vars

Requested by https://app.hubspot.com/contacts/2762526/company/557692805

Context at https://sourcegraph.slack.com/archives/CTQ5LTF8D/p1592858268356300 and https://sourcegraph.slack.com/archives/CTQ5LTF8D/p1595011378044800

Hey team, I’m currently having issues reaching github.com from our sg instance. I’ve configured proxy env vars on three pods: gitserver, repo-updater, and github-proxy. These seem be to working correctly as when I sh into one of the containers I can hit the appropriate endpoints such as $REDACTED_URL. However, I am still getting the following error in the logs of github-proxy:

t=2020-06-22T20:28:37+0000 lvl=warn msg="proxy error" err="Get \"$REDACTED_URL\": dial tcp $REDACTED_IP:443: connect: connection timed out"

purpose of the proxy: allow access to the internet at large. we aren’t allowed to make direct contact with the internet, we must go through the proxy. so requests to github.com etc, must go through the proxy

result of curl: once i am in the github-proxy container, with the appropriate vars set, I able to curl the url i listed in the original message and get results.

for full context here is the proxy config for github-proxy pod:

- name: http_proxy
  value: "http://$REDACTED:8099"
- name: https_proxy
  value: "http://$REDACTED:8099"
- name: HTTP_PROXY
  value: "http://$REDACTED:8099"
- name: HTTPS_PROXY
  value: "http://$REDACTED:8099"
- name: no_proxy
  value: "$REDACTED"
- name: NO_PROXY
  value: "$REDACTED"

created time in 18 days

issue openedsourcegraph/sourcegraph

Indexing multiple branches timing out with git command `failed: exit status 128`

Reported by https://app.hubspot.com/contacts/2762526/company/768958891

See Slack thread at https://sourcegraph.slack.com/archives/CTJCMDCCS/p1595352999461200?thread_ts=1595350296.457900&cid=CTJCMDCCS

2020/07/21 17:35:51 error indexing <$REPO>@HEAD=<$SHA_BRANCH_LIST>: command [git -C /data/index/.indexserver.tmp/tmpfriend-6-554088670/<$REPO.git> -c protocol.version=2 fetch --depth=1 http://sourcegraph-frontend-internal/.internal/git/<$REPO> <$SHA LIST>] failed: exit status 128
OUT:
ERR: warning: redirecting to http://gitserver-0.gitserver:3178/git/<$REPO>/
error: RPC failed; HTTP 500 curl 22 The requested URL returned error: 500
fatal: the remote end hung up unexpectedly

When the user reduced the number of branches from double digits to just 1, it worked just fine. He then increased up to 5, and got the same error.

  • Kubernetes
  • Fetching code from Gerritt

created time in 18 days

issue commentsourcegraph/sourcegraph

Add SQL search-based code intelligence

@aidaeology just FYI I deleted the customer name as well as this history that included the customer name. Please use links to HubSpot (/company/ pages) when posting in our public issue tracker!

dadlerj

comment created time in 18 days

issue openedsourcegraph/sourcegraph

Rate limit requests to Sourcegraph API

Requested by:

  • https://app.hubspot.com/contacts/2762526/company/464956351
  • https://app.hubspot.com/contacts/2762526/company/557692805

From the latter:

given that i can envision (over the long-term) teams wanting to build automation using the API, something we've noticed with GHE is that teams will create tooling without regard to load impact ... so having rate limiting will minimize our need to play "whack-a-mole" usage cops ... with GHE, we frequently see teams that put things in place that run on schedules ... often times they get unintentionally mis-configured and we end up having to chase down the bad actors in a reactive manner

Related:

  • https://github.com/sourcegraph/sourcegraph/issues/10629
  • https://github.com/sourcegraph/sourcegraph/issues/5705
  • https://github.com/sourcegraph/sourcegraph/issues/5706

@slimsag this issue feels slightly different from #10629 but feel free to merge if you'd like.

created time in 18 days

issue commentsourcegraph/sourcegraph

Unindexed repositories for Structural Search

No need for anyone from distribution to get involved yet, I'll check with the customer

poojaj-tech

comment created time in 19 days

issue commentsourcegraph/sourcegraph

Unindexed repositories for Structural Search

Should all repos be indexed on an enterprise instance?

I would assume so. @rvantonder what reason could we have for a repo or series of repos to not be indexed? I can for more info from the customer.

poojaj-tech

comment created time in 19 days

push eventsourcegraph/about

Dan Adler

commit sha a2930fd9ac31c7d003a390b29d9f44a42c2446ac

Add sales-to-CE handover process docs, move license keys docs to CE handbook (#1195) * Add sales-to-CE handover process docs, move license keys docs to CE handbook * Update handbook/sales/sales_to_ce_handover.md Co-authored-by: Eric Brody-Moore <ericbm@sourcegraph.com> * Tweak license key docs * Update link Co-authored-by: Eric Brody-Moore <ericbm@sourcegraph.com>

view details

push time in 19 days

delete branch sourcegraph/about

delete branch : ae-to-ce-handoff

delete time in 19 days

push eventsourcegraph/about

Dan Adler

commit sha 3971f5bbe369c4af581a804642d0695c05c5e99e

Update link

view details

push time in 19 days

push eventsourcegraph/about

aileenrose

commit sha 8616e93172794361edf45498aa208116e56fb222

Fix icons (#1191) * Fix icons * Let's get the icon names correct * Update mdi-react to get updated icons.

view details

renovate[bot]

commit sha 023a82199140ca26ecda6d17b7aeffe4ebe906f3

Update Node.js to v14.5.0 (#997) * Update Node.js to v14.5.0 * Update Node.js to v14.5.0 * Update Node.js to v14.5.0 * Update Node.js to v14.5.0 * Fix icons * Update Node.js to v14.5.0 Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>

view details

renovate[bot]

commit sha ffa112049cb87295073017081c5ad8af2e092cf9

Update dependency typescript to ^3.9.6 (#1007) * Update dependency typescript to ^3.9.6 * Update icons Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>

view details

renovate[bot]

commit sha e3092dd91e2018e7ea2cda19106cf0ad208a650b

Update gatsby monorepo (#1028) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha dfad262aa38242987a54763cc57c5379a290ba74

Update dependency rehype-react to v6 (#1143) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>

view details

Nick Snyder

commit sha 3d6059c507dedcd98b8f3bb2dd9ea4eb25229d3e

Fix link to engineer laptop (#1192)

view details

aileenrose

commit sha e9d7758611c22c3b4c4ff54ec2b4713e26b17c73

Add def for Interesting inquiry (#922)

view details

aileenrose

commit sha 3499bd65950876982a55a495ff2aa19249e4a9b0

Remove duplicate meta tagging (#1179)

view details

aileenrose

commit sha 8ef1bc593011cff191f3bffe70be06b2568c812a

Remove deprecated pages (#1182)

view details

Nick Snyder

commit sha b35e22c28798c469827b4e0d9d4fc45ad2d7efa2

Update eng team (#1197)

view details

Beyang Liu

commit sha ba1811fe62164bdf765c42e99f5141c915d1e38d

podcast: new audio

view details

Christina Forney

commit sha 694e611c5726ca9f591e677a7405668540cc8fcc

Update slack channel for incidents (#1199)

view details

Quinn Slack

commit sha bdabde97e5a0884cfa8dac356b648bece8cd245b

add links to proposed handbook changes (#1194)

view details

Quinn Slack

commit sha 88ecb1cf36cb061c94b11e35057900c8ef967a99

upload large files to Google Drive and link to them from the handbook (#1193)

view details

Nick Snyder

commit sha 86b066c5e91e061f7cb1fcf50456fcde225517e5

Update non-engineer laptop (#1196)

view details

adam

commit sha 74e03f65c795fae6d0481b7da1bfa0b783641838

Create hiring-talent-sourcegraph-cloud.md (#1202)

view details

adam

commit sha f36b80e72ecd766fb7ae44bad1818fc21e7ffcf6

update with copy edits for momentum blog post

view details

adam

commit sha 8133673bfb15d93c97798dda046ab8c3b0a0f0e5

more copy edits to momentum post

view details

aileenrose

commit sha 119661ca4859dba029c8ca3124de834afcffcd19

Add latest news and secure cross-origin links (#1203)

view details

aileenrose

commit sha 133ae33fea6c3260f786f83547bb125ee8408761

Add canonical links to pages (#1180)

view details

push time in 19 days

push eventsourcegraph/about

Dan Adler

commit sha f273334409d93e00b1a5dcf2793534bb708deb17

Tweak license key docs

view details

push time in 19 days

push eventsourcegraph/about

Dan Adler

commit sha c4f6c3ca8cd18bdaa66a1e811725613e772d99dd

Update handbook/sales/sales_to_ce_handover.md Co-authored-by: Eric Brody-Moore <ericbm@sourcegraph.com>

view details

push time in 19 days

more