profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/czosel/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Christian Zosel czosel @adfinis-sygroup Bern, Switzerland https://twitter.com/chrzosel

czosel/elm-snake 1

Implementation of the classic snake game in elm.

czosel/adsycc 0

Adfinis SyGroup AG - Customer Center

czosel/angular-fcsa-number 0

An Angular directive that validates numbers and adds commas as thousand separators.

czosel/bootstrap 0

Native AngularJS (Angular) directives for Bootstrap. Smaller footprint (20kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!

czosel/caluma 0

A collaborative form editing service

czosel/code-ballet 0

Bi-Weekly Code Ballet Puzzles

push eventprojectcaluma/alexandria

David Vogt

commit sha ca0806048f2b3c80391b6d770070dda4260e8c9f

chore(deps): update dependencies Closes multiple Dependabot PRs

view details

Christian Zosel

commit sha 160c1af8f761d2cc19c75b7da828b67217ef4fe4

Merge pull request #207 from winged/dep_updated chore(deps): update dependencies

view details

push time in 17 hours

PR merged projectcaluma/alexandria

chore(deps): update dependencies

Closes multiple Dependabot PRs

+10 -10

0 comment

4 changed files

winged

pr closed time in 17 hours

PullRequestReviewEvent

Pull request review commentprojectcaluma/alexandria

chore(deps): update dependencies

 snapshots["test_api_destroy[DocumentViewSet] 1"] = {     "queries": [         'SELECT "alexandria_core_document"."created_at", "alexandria_core_document"."created_by_user", "alexandria_core_document"."created_by_group", "alexandria_core_document"."modified_at", "alexandria_core_document"."modified_by_user", "alexandria_core_document"."modified_by_group", "alexandria_core_document"."meta", "alexandria_core_document"."id", "alexandria_core_document"."title", "alexandria_core_document"."description", "alexandria_core_document"."category_id" FROM "alexandria_core_document" WHERE "alexandria_core_document"."id" = \'9dd4e461-268c-8034-f5c8-564e155c67a6\'::uuid',-        'SELECT "alexandria_core_document_tags"."id", "alexandria_core_document_tags"."document_id", "alexandria_core_document_tags"."tag_id" FROM "alexandria_core_document_tags" WHERE "alexandria_core_document_tags"."document_id" IN (\'9dd4e461-268c-8034-f5c8-564e155c67a6\'::uuid)',         'SELECT "alexandria_core_file"."created_at", "alexandria_core_file"."created_by_user", "alexandria_core_file"."created_by_group", "alexandria_core_file"."modified_at", "alexandria_core_file"."modified_by_user", "alexandria_core_file"."modified_by_group", "alexandria_core_file"."meta", "alexandria_core_file"."id", "alexandria_core_file"."type", "alexandria_core_file"."original_id", "alexandria_core_file"."name", "alexandria_core_file"."document_id" FROM "alexandria_core_file" WHERE "alexandria_core_file"."document_id" IN (\'9dd4e461-268c-8034-f5c8-564e155c67a6\'::uuid) ORDER BY "alexandria_core_file"."created_at" DESC',-        'DELETE FROM "alexandria_core_document_tags" WHERE "alexandria_core_document_tags"."id" IN (1)',+        'DELETE FROM "alexandria_core_document_tags" WHERE "alexandria_core_document_tags"."document_id" IN (\'9dd4e461-268c-8034-f5c8-564e155c67a6\'::uuid)',

Alright!

winged

comment created time in 17 hours

PullRequestReviewEvent

Pull request review commentprojectcaluma/alexandria

chore(deps): update dependencies

 snapshots["test_api_destroy[DocumentViewSet] 1"] = {     "queries": [         'SELECT "alexandria_core_document"."created_at", "alexandria_core_document"."created_by_user", "alexandria_core_document"."created_by_group", "alexandria_core_document"."modified_at", "alexandria_core_document"."modified_by_user", "alexandria_core_document"."modified_by_group", "alexandria_core_document"."meta", "alexandria_core_document"."id", "alexandria_core_document"."title", "alexandria_core_document"."description", "alexandria_core_document"."category_id" FROM "alexandria_core_document" WHERE "alexandria_core_document"."id" = \'9dd4e461-268c-8034-f5c8-564e155c67a6\'::uuid',-        'SELECT "alexandria_core_document_tags"."id", "alexandria_core_document_tags"."document_id", "alexandria_core_document_tags"."tag_id" FROM "alexandria_core_document_tags" WHERE "alexandria_core_document_tags"."document_id" IN (\'9dd4e461-268c-8034-f5c8-564e155c67a6\'::uuid)',         'SELECT "alexandria_core_file"."created_at", "alexandria_core_file"."created_by_user", "alexandria_core_file"."created_by_group", "alexandria_core_file"."modified_at", "alexandria_core_file"."modified_by_user", "alexandria_core_file"."modified_by_group", "alexandria_core_file"."meta", "alexandria_core_file"."id", "alexandria_core_file"."type", "alexandria_core_file"."original_id", "alexandria_core_file"."name", "alexandria_core_file"."document_id" FROM "alexandria_core_file" WHERE "alexandria_core_file"."document_id" IN (\'9dd4e461-268c-8034-f5c8-564e155c67a6\'::uuid) ORDER BY "alexandria_core_file"."created_at" DESC',-        'DELETE FROM "alexandria_core_document_tags" WHERE "alexandria_core_document_tags"."id" IN (1)',+        'DELETE FROM "alexandria_core_document_tags" WHERE "alexandria_core_document_tags"."document_id" IN (\'9dd4e461-268c-8034-f5c8-564e155c67a6\'::uuid)',

Where does this come from? Does it impact our users?

winged

comment created time in 18 hours

PullRequestReviewEvent

PR merged projectcaluma/alexandria

Reviewers
fix: extend uwsgi buffer

UWSGI has a buffer of 4096 bytes by default, in which all request headers must fit. If a user has particularly many roles/groups in their JWT token, this limit is exceeded. UWSGI will then abort the request, and the reverse proxy in front will respond with an error such as HTTP/502.

+1 -0

1 comment

1 changed file

winged

pr closed time in 18 hours

push eventprojectcaluma/alexandria

David Vogt

commit sha e2863e9b3eff2f7d485531a1ea32d24f262812c5

fix: extend uwsgi buffer UWSGI has a buffer of 4096 bytes by default, in which all request headers must fit. If a user has particularly many roles/groups in their JWT token, this limit is exceeded. UWSGI will then abort the request, and the reverse proxy in front will respond with an error such as HTTP/502.

view details

Christian Zosel

commit sha d40802e787f92066cafbc1897f56680722d34f7c

Merge pull request #193 from winged/fix_uwsgi_buffer fix: extend uwsgi buffer

view details

push time in 18 hours

PullRequestReviewEvent

release projectcaluma/alexandria

v0.2.0

released time in 20 hours

created tagprojectcaluma/alexandria

tagv0.2.0

Document management service

created time in 20 hours

PR opened projectcaluma/alexandria

Reviewers
chore: release 0.2.0
+13 -1

0 comment

2 changed files

pr created time in 21 hours

push eventprojectcaluma/alexandria

Christian Zosel

commit sha a0a8f4667c35f200a1472ae0aefb8c120a6dfd96

chore: release 0.2.0

view details

push time in 21 hours

create barnchprojectcaluma/alexandria

branch : release-0.2.0

created branch time in 21 hours

Pull request review commentprojectcaluma/ember-alexandria

feat: multiselect, refactor tag manager, ember update

 module("Integration | Component | document-card", function (hooks) {     assert.dom("[data-test-download]").isVisible();   }); -  test("donwload file", async function (assert) {-    const stub = sinon.stub(fileSaver, "saveAs");+  test("download file", async function (assert) {+    // eslint-disable-next-line import/no-named-as-default-member+    const fileSaverStub = sinon.stub(fileSaver, "saveAs");

As discussed: It seems that ember-sinon-qunit needs to be imported that way ...

StephanH90

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentprojectcaluma/ember-alexandria

feat: multiselect, refactor tag manager, ember update

 export default class DocumentsService extends Service {       throw new Error(response.statusText, response.status);     }   }++  /**+   * Clears the document selection+   */+  @action clearDocumentSelection() {+    this.selectedDocuments = [];+    this.updateRoute();+  }++  /**+   * Checks if the document is selected+   *+   * @param {Object} doc an EmberData representation of a Document+   * @returns {Boolean} If the document is selected+   */+  @action documentIsSelected(doc) {+    return !!this.selectedDocuments.find((d) => d.id === doc.id);+  }++  /**+   * Selects the document+   * @param {Object} doc an EmberData representation of a Document+   */+  @action selectDocument(doc) {+    if (!this.selectedDocuments.includes(doc)) {+      this.selectedDocuments = [...this.selectedDocuments, doc];+      this.updateRoute();+    }+  }++  /**+   * Removes a document from the document selection+   * @param {Object} doc an EmberData representation of a Document+   */+  @action deselectDocument(doc) {+    this.selectedDocuments = this.selectedDocuments.filter(+      (d) => d.id !== doc.id+    );+    this.updateRoute();+  }

As discussed, implementing shift selection (especially finding the first element) is clumsy with sets.

StephanH90

comment created time in 2 days

push eventczosel/tt-mobile

Christian Zosel

commit sha 6bd956a06b82a4df3cbd791802fa89909d5eaaf6

fix: change fallback text in region schedule

view details

Christian Zosel

commit sha c3ebb529e2941015c1bfc8d51b161879ff7bc3b3

chore: bump widgets package

view details

push time in 2 days

Pull request review commentprojectcaluma/ember-alexandria

feat: multiselect, refactor tag manager, ember update

 module("Integration | Component | document-card", function (hooks) {     assert.dom("[data-test-download]").isVisible();   }); -  test("donwload file", async function (assert) {-    const stub = sinon.stub(fileSaver, "saveAs");+  test("download file", async function (assert) {+    // eslint-disable-next-line import/no-named-as-default-member+    const fileSaverStub = sinon.stub(fileSaver, "saveAs");

If this works, it needs to be fixed at many places ...

StephanH90

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentprojectcaluma/ember-alexandria

feat: multiselect, refactor tag manager, ember update

 module("Integration | Component | document-card", function (hooks) {   test("delete file", async function (assert) {     this.document = {       id: 1,+      // eslint-disable-next-line import/no-named-as-default-member       destroyRecord: sinon.fake(),

same as above

StephanH90

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentprojectcaluma/ember-alexandria

feat: multiselect, refactor tag manager, ember update

 module("Integration | Component | document-card", function (hooks) {     assert.dom("[data-test-download]").isVisible();   }); -  test("donwload file", async function (assert) {-    const stub = sinon.stub(fileSaver, "saveAs");+  test("download file", async function (assert) {+    // eslint-disable-next-line import/no-named-as-default-member+    const fileSaverStub = sinon.stub(fileSaver, "saveAs");

Did you try fixing the linting error instead of disabling it? Something like

import { stub } from "sinon"
StephanH90

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentprojectcaluma/ember-alexandria

feat: multiselect, refactor tag manager, ember update

 @use "components/document-details"; @use "components/document-grid"; -+// * DOCUMENT LIST VIEW .cursor-pointer {   cursor: pointer; }+.document-list {+  user-select: none;+  -moz-user-select: none;+}

Shall we drop this in favor of .no-select?

StephanH90

comment created time in 4 days

Pull request review commentprojectcaluma/ember-alexandria

feat: multiselect, refactor tag manager, ember update

 export default class TagsService extends Service {   }    /**-   * Adds a tag to a document and creates the tag if necessary.+   * Adds a tag to a document and creates the tag if necessary. Returns the added tag    *    * @param {Object} document The target document.    * @param {Object|String} tag Either e tag instance or a name.+   * @returns {Object} addedTag The added tag    */   @action async add(document, tag) {     if (typeof tag === "string") {-      const existing = this.allTags.findBy("name", tag);-+      tag = tag.trim();+      const existing = this.allTags.findBy("id", dasherize(tag));

Nitpick: I think it's bad style to re-assign arguments (doesn't matter for primitive data types, but can cause subtle bugs when args are passed by reference...). I'd declare a new variable for the return value instead of reusing the argument.

StephanH90

comment created time in 4 days

PullRequestReviewEvent