profile
viewpoint

curiousleo/bazel_compilation_database 3

Generate compile_commands.json for your Bazel C++ project for YouCompleteMe semantic completion.

curiousleo/2to11 2

2048 AI

curiousleo/cqengine-phtree 1

PhTree indices for CQEngine

curiousleo/agda-bigop 0

Big operators in Agda: Cambridge CST Part III thesis (2015)

curiousleo/agda-coinduction-experiments 0

Infinite data structures in Agda

curiousleo/agda-playground 0

Agda playground

curiousleo/agda-stdlib 0

The Agda standard library

curiousleo/ais-api 0

AIS API

curiousleo/AixLib 0

A Modelica model library for building performance simulations

curiousleo/algorithms 0

Toy implementations of a few algorithms and data structures

startedrossberg/1ml

started time in 2 days

issue closedFZJ-IEK3-VSA/tsam

Helmholtz Energy System 2.0 tsam page: wrong repo link

https://www.helmholtz.de/en/research/energy/energy-system-2050/heci-artikel/time-series-aggregation-module-tsam/ says:

Open-source available here.

But "here" links to http//. It should link to https://github.com/FZJ-IEK3-VSA/tsam.

I'm aware that the tsam team probably cannot change the Helmholtz website, but perhaps you can get in touch to get the link fixed. I couldn't find a "webmaster" e-mail address or anything like that, so I thought I'd at least report this issue here.

closed time in 6 days

curiousleo

issue commentFZJ-IEK3-VSA/tsam

Helmholtz Energy System 2.0 tsam page: wrong repo link

The link has now been fixed.

curiousleo

comment created time in 6 days

push eventcuriousleo/setup

Leonhard Markert

commit sha fe2f4b0ac1f9b9e0af8eb47c40870e755631af0a

(git) add aliases

view details

Leonhard Markert

commit sha ee2c7ca88dd36d4e7ee93d4fb9d91cfacde6fb59

(libvirtd) enable

view details

Leonhard Markert

commit sha 979dac305800c921cd56a2c413babf41c7aad443

(vim) add zig-vim plugin

view details

push time in 9 days

startedbellard/quickjs

started time in 12 days

startedarminbiere/kissat

started time in 13 days

startedcodr7/liblg

started time in 13 days

startedjoshday/OnlineStats.jl

started time in 18 days

issue openedFZJ-IEK3-VSA/tsam

Helmholtz Energy System 2.0 tsam page: wrong repo link

https://www.helmholtz.de/en/research/energy/energy-system-2050/heci-artikel/time-series-aggregation-module-tsam/ says:

Open-source available here.

But "here" links to http//. It should link to https://github.com/FZJ-IEK3-VSA/tsam.

I'm aware that the tsam team probably cannot change the Helmholtz website, but perhaps you can get in touch to get the link fixed. I couldn't find a "webmaster" e-mail address or anything like that, so I thought I'd at least report this issue here.

created time in 19 days

pull request commentRWTH-EBC/AixLib

Travis: build with Python 3 (fixes master build)

Ready for review.

curiousleo

comment created time in 19 days

pull request commentRWTH-EBC/AixLib

Travis: build with Python 3 (fixes master build)

Build succeeded: https://travis-ci.org/github/RWTH-EBC/AixLib/builds/734503875

curiousleo

comment created time in 19 days

delete branch curiousleo/AixLib

delete branch : patch-1

delete time in 19 days

push eventcuriousleo/AixLib

Leonhard Markert

commit sha 3209a8469426b594a9cdb0f0829eabc137d67042

2to3 runUnitTests.py

view details

push time in 19 days

PR opened RWTH-EBC/AixLib

Travis: build with Python 3

Travis CI for this project is configured to use Python 2.7 and fails on master, which is indicated by a read "build: failing" badge on this project's GitHub landing page. The underlying problem is this:

  File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/buildingspy/development/validator.py", line 84, in _getInfoRevisionsHTML

    with open(moFile, mode="r", encoding="utf-8") as f:

TypeError: 'encoding' is an invalid keyword argument for this function

In Python 2.7, open does not accept an encoding parameter. In Python 3, it does. https://docs.python.org/2.7/library/functions.html#open https://docs.python.org/3.8/library/functions.html#open

Additionally, the call stack clearly shows that open is called from the BuildingsPy library. The BuildingsPy library build instruction make it clear that Python 3 is required. https://simulationresearch.lbl.gov/modelica/buildingspy/install.html

Python 3.9 is the latest and greatest Python 3 version, but it was released less than a week ago. Python 3.8 was released a year ago and still receives bugfixes (as opposed to older versions which only receive security updates), so that seems like a good compromise.

+1 -1

0 comment

1 changed file

pr created time in 19 days

push eventcuriousleo/AixLib

Leonhard Markert

commit sha cd4ac2d9ddff2e33100ead16d9c532266c34a5fd

Travis: build with Python 3 Travis CI currently uses Python 2.7 and fails on `master`. The underlying problem is this: ``` File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/buildingspy/development/validator.py", line 84, in _getInfoRevisionsHTML with open(moFile, mode="r", encoding="utf-8") as f: TypeError: 'encoding' is an invalid keyword argument for this function ``` https://travis-ci.org/github/RWTH-EBC/AixLib/jobs/734457254#L295 In Python 2.7, `open` does not accept an `encoding` parameter. In Python 3.8, it does. https://docs.python.org/2.7/library/functions.html#open https://docs.python.org/3.8/library/functions.html#open Additionally, the call stack clearly shows that `open` is called from the BuildingsPy library. The BuildingsPy library build instruction make it clear that Python 3 is required. https://simulationresearch.lbl.gov/modelica/buildingspy/install.html Python 3.9 is the latest and greatest Python version, but it was released less than a week ago. Python 3.8 was released a year ago and still receives bugfixes (as opposed to older versions which only receive security updates), so that seems like a good compromise.

view details

push time in 19 days

push eventcuriousleo/AixLib

Leonhard Markert

commit sha 6451a383b93f1b7f9a73bcbf526360c2e395b218

Travis: build with Python 3.6 Travis CI currently uses Python 2.7 and fails on `master`. The underlying problem is this: ``` File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/buildingspy/development/validator.py", line 84, in _getInfoRevisionsHTML with open(moFile, mode="r", encoding="utf-8") as f: TypeError: 'encoding' is an invalid keyword argument for this function ``` https://travis-ci.org/github/RWTH-EBC/AixLib/jobs/734457254#L295 In Python 2.7, `open` does not accept an `encoding` parameter. In Python 3.6, it does. https://docs.python.org/2.7/library/functions.html#open https://docs.python.org/3.6/library/functions.html#open Additionally, the call stack clearly shows that `open` is called from the BuildingsPy library. The BuildingsPy library build instruction make it clear that Python 3 is required. https://simulationresearch.lbl.gov/modelica/buildingspy/install.html Python 3.9 is the latest and greatest Python version, but it was released less than a week ago. Python 3.8 was released a year ago and still receives bugfixes (as opposed to older versions which only receive security updates), so that seems like a good compromise.

view details

push time in 19 days

fork curiousleo/AixLib

A Modelica model library for building performance simulations

fork in 19 days

Pull request review commenttarget/lorri

doc(README): add FAQ entry for whether to check in .envrc

 By default, the upgrade command will upgrade from the `master` branch. Other upgrade options are available, including upgrading from a local clone. See `lorri self-upgrade --help` for more details. +## FAQ++### Should I check the `.envrc` into git/my source control?++Yes, you can!++`direnv` will ask to run `direnv allow` every time the `.envrc` changes,+and `lorri direnv` will never run anything else than what is required+to set up the nix environment, so from a security standpoint it is safe.

I would simply never publicly claim that something is secure without qualification if there hasn't at least been a third-party audit. It just too strong a claim to make without concrete, specific evidence that someone with relevant training has tried to circumvent the security measures you've put in place and did not succeed.

My suggestion would simply be to remove ", so from a security standpoint it is safe". The relevant bit for users is "will never run anything else than what is required".

Profpatsch

comment created time in 20 days

PullRequestReviewEvent

startedHejsil/zig-clap

started time in 23 days

Pull request review commenttarget/lorri

doc(README): add FAQ entry for whether to check in .envrc

 By default, the upgrade command will upgrade from the `master` branch. Other upgrade options are available, including upgrading from a local clone. See `lorri self-upgrade --help` for more details. +## FAQ++### Should I check the `.envrc` into git/my source control?++Yes, you can!++`direnv` will ask to run `direnv allow` every time the `.envrc` changes,+and `lorri direnv` will never run anything else than what is required+to set up the nix environment, so from a security standpoint it is safe.

from a security standpoint it is safe

Assuming Nix expression cannot escape their sandbox, etc. I would not make security claims like this.

Suggestion: "it is as safe as Nix itself", as the security claim basically boils down to "it doesn't add much insecurity on top of Nix".

Profpatsch

comment created time in a month

PullRequestReviewEvent

Pull request review commentnmattia/niv

Add sorri, a simpler lorri

+# vim: ft=bash++# sorri: a Simpler lORRI+#+# This is a simpler implementation of Tweag's lorri:+#   https://github.com/target/lorri+#+# sorri reuses lorri's tricks for figuring out the files to track for changes,+# but uses direnv's own mechanism for actually tracking those files.+# sorri uses a local cache at '~/.cache/niv-sorri-vX/'. Each entry is a+# directory containing two files:+#+#   ~/.cache/niv-sorri-v1/+#   └── 0716a121e4f986f9f8cf11f7c579d332+#       ├── link -> /nix/store/jfzkisfgmv3qgpzz3i8nai12y1cry77v-nix-shell+#       └── manifest+#+# `link` is the result of a previous evaluation. `manifest` is used to find+# that result of a previous evaluation. The directory name+# (0716a121e4f986f9f8cf11f7c579d332 above) is the hash of the `manifest`.+#+# `link` is a symlink to a shell script that sets a shell's variables.+#+#   cat ~/.cache/niv-sorri-v1/0716a121e4f986f9f8cf11f7c579d332/link+#   declare -x AR_x86_64_apple_darwin="/nix/store/amsm28x2hnsgp8c0nm4glkjc2gw2l9kw-cctools-binutils-darwin-927.0.2/bin/ar"+#   declare -x BZ2_LIB_DIR="/nix/store/7yikqcm4v4b57xv3cqknhdnf0p1aakxp-bzip2-1.0.6.0.1/lib"+#   declare -x BZ2_STATIC="1"+#   declare -x CARGO_BUILD_TARGET="x86_64-apple-darwin"+#   declare -x CARGO_TARGET_WASM32_UNKNOWN_UNKNOWN_LINKER="/nix/store/swiic36rl7njy6bfll5z0afl42c9q4s5-lld-9.0.1/bin/lld"+#+# `manifest` is a list of files used for an evaluation alongside their checksums:+#+#   $ cat ~/.cache/niv-sorri-v1/0716a121e4f986f9f8cf11f7c579d332/manifest+#   /Users/nicolas/niv/shell.nix:029451f2a9bee59f4ce002bdbdf20554+#   /Users/nicolas/niv/nix/default.nix:7ff8c9138044fc7e31f1d4ed2bf1c0ba+#   /Users/nicolas/niv/nix/overlays/buf/default.nix:c4a24e0bba0178b73f0211d0f26147e6+#   ...+#+# sorri first checks the existing cache entries (niv-sorry-v1/0716...,
# sorri first checks the existing cache entries (niv-sorri-v1/0716...,
nmattia

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

issue commentnytimes/openapi2proto

fixtures/accountv1-0.proto is not a valid protobuf file

See https://travis-ci.org/github/nytimes/openapi2proto/jobs/728735641#L158 for all validation failures on master.

curiousleo

comment created time in a month

push eventcuriousleo/openapi2proto

Leonhard Markert

commit sha e0a87c672a0314c4b841a40615d3b2c86106fa37

Validate fixture protos in CI

view details

push time in a month

push eventcuriousleo/openapi2proto

Leonhard Markert

commit sha dc609c1442d4905a846df6b0796f1dcb0ce545e3

Validate fixture protos in CI

view details

push time in a month

push eventcuriousleo/openapi2proto

Leonhard Markert

commit sha 889fe59f0158f3e2056aa4d18d11d210157de99e

Validate fixture protos in CI

view details

push time in a month

push eventcuriousleo/openapi2proto

Leonhard Markert

commit sha 1fb80a490b73bcd3f6d995a8353e581313f40085

Validate fixture protos in CI

view details

push time in a month

PR opened nytimes/openapi2proto

Validate fixture protos in CI

I think it makes sense to validate protobuf files used as fixtures in CI.

This currently fails, demonstrating that some fixtures are currently not valid protobuf files.

Related: https://github.com/nytimes/openapi2proto/issues/130

+5 -0

0 comment

1 changed file

pr created time in a month

issue commentnytimes/openapi2proto

fixtures/accountv1-0.proto is not a valid protobuf file

kubernetes.proto has over a thousand "... is not defined" errors.

curiousleo

comment created time in a month

issue commentnytimes/openapi2proto

fixtures/accountv1-0.proto is not a valid protobuf file

books.proto is also incomplete:

books.proto:361:26: "GETReviewsFormatRequest" is not defined.
books.proto:361:60: "GETReviewsFormatResponse" is not defined.
curiousleo

comment created time in a month

create barnchcuriousleo/openapi2proto

branch : validate-proto

created branch time in a month

issue openednytimes/openapi2proto

fixtures/accountv1-0.proto is not a valid protobuf file

protoc v3.7.1 throws errors when parsing fixtures/accountv1-0.proto:

$ protoc --version
libprotoc 3.7.1
$ protoc -o/dev/null fixtures/accountv1-0.proto
fixtures/accountv1-0.proto:342:14: "Permissions" is already defined in "accountinformationapis.AccountRequest.DataMessage".
fixtures/accountv1-0.proto:646:14: "Permissions" is already defined in "accountinformationapis.CreateAccountRequest.DataMessage".
fixtures/accountv1-0.proto:362:18: "Permissions" is not defined.
fixtures/accountv1-0.proto:672:18: "Permissions" is not defined.
fixtures/accountv1-0.proto:1004:68: "CreateAccountRequest" is not a message type.
fixtures/accountv1-0.proto:1014:20: "GetAccountRequest" is not a message type.
fixtures/accountv1-0.proto:1039:62: "CreateAccountRequest" is not a message type.
$ echo $?
1

created time in a month

startedgrpc/grpc-java

started time in a month

pull request commentnytimes/openapi2proto

Kubernetes OpenAPI spec compatibility

@jprobinson and @lestrrat seem to have moved on from NYT.

@JustinFullerNYT, do you have enough context on this project to provide feedback on this draft PR?

curiousleo

comment created time in a month

issue commentnytimes/openapi2proto

Failed to transpile Kubernetes swagger.json: "'$ref' key contains non-string element (map[string]interface {})"

Possibly useful for future reference: https://github.com/kubernetes/kube-openapi is the code that generates the Kubernetes OpenAPI spec (from Go structs in https://github.com/kubernetes/kubernetes).

curiousleo

comment created time in a month

pull request commentnytimes/openapi2proto

Kubernetes OpenAPI spec compatibility

Feedback welcome. Ping @jprobinson @lestrrat (you commented on #82 and seem to have some context on this).

curiousleo

comment created time in a month

pull request commentnytimes/openapi2proto

Kubernetes OpenAPI spec compatibility

I don't really understand how kubernetes.proto was generated given that openapi2proto previously failed on kubernetes.json. So I'm not sure how valid it is to update kubernetes.proto here.

curiousleo

comment created time in a month

PR opened nytimes/openapi2proto

Kubernetes OpenAPI spec compatibility

Fixes #128 and #82.

Changes to make the Kubernetes fixture pass:

  • Ignore $ref declarations that are not strings
  • Allow primitive RPC return types
  • Update Kubernetes proto fixture

Additional changes:

  • Allow primitive RPC request types, for symmetry with the return type change

I'm mostly feeling my way around at this point. I haven't tested the changes other than running go test.

+14172 -12323

0 comment

4 changed files

pr created time in a month

push eventcuriousleo/openapi2proto

Leonhard Markert

commit sha 0adc9085f2f1fcb6a66bdca866280f35dc1755fa

Remove debug logging

view details

Leonhard Markert

commit sha f408633b2d7cfd8cc7ed607ee808cc21c96166d6

Allow primitive request types, for symmetry

view details

push time in a month

create barnchcuriousleo/openapi2proto

branch : kubernetes-compat

created branch time in a month

fork curiousleo/openapi2proto

A tool for generating Protobuf v3 schemas and gRPC service definitions from OpenAPI specifications

fork in a month

issue commentnytimes/openapi2proto

Adopt a more flexible way of resolving $ref references

I'm looking into this in the context of #128.

https://tools.ietf.org/html/draft-pbryan-zyp-json-ref-03 states in section 3:

    A JSON Reference is a JSON object, which contains a member named
   "$ref", which has a JSON string value.  Example:

   { "$ref": "http://example.com/example.json#/foo/bar" }

   If a JSON value does not have these characteristics, then it SHOULD
   NOT be interpreted as a JSON Reference.

   The "$ref" string value contains a URI [RFC3986], which identifies
   the location of the JSON value being referenced.  It is an error
   condition if the string value does not conform to URI syntax rules.
   Any members other than "$ref" in a JSON Reference object SHALL be
   ignored.

That seems pretty clear - $ref should contain a URI. Under which circumstances would

     "$ref": {
      "type": "string"
     }

be valid according to the OpenAPI spec?

jprobinson

comment created time in a month

issue openedgrpc/grpc-java

Export detailed metrics via OpenTelemetry

<!-- Please answer these questions before submitting a feature request. -->

Is your feature request related to a problem?

<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->

grpc-java exports detailed metrics via OpenCensus (code in /census). There's a guide for how to access those metrics here: https://opencensus.io/guides/grpc/java/.

OpenTelemetry is the official successor to OpenCensus. But grpc-java does not expose metrics in an OpenTelemetry-compatible way.

Describe the solution you'd like

<!-- A clear and concise description of what you want to happen. -->

It would be nice if the detailed metrics currently exposed via OpenCensus were exposed in an OpenTelemetry-compatible way.

Describe alternatives you've considered

<!-- A clear and concise description of any alternative solutions or features you've considered. -->

Setting up an OpenCensus-based metrics pipeline just for grpc-java -- certainly possible, but runs counter to the idea of unifying metrics and tracing under the OpenTelemetry umbrella.

Additional context

<!-- Add any other context about the feature request here. -->

Given that OpenTelemetry is the official successor to OpenCensus, I tried to figure out if OpenTelemetry is OpenCensus-compatible, but couldn't find relevant documentation. It is possible that this is the case and that OpenTelemetry support is a no-op as a result.

created time in a month

issue openednytimes/openapi2proto

Failed to transpile Kubernetes swagger.json: "'$ref' key contains non-string element (map[string]interface {})"

Generating protos for https://github.com/kubernetes/kubernetes/blob/965137a992ed755474f17fa6377ee3555745addd/api/openapi-spec/swagger.json failed:

$ openapi2proto -spec kubernetes-swagger.json
error: failed to transpile: failed to load OpenAPI spec: failed to resolve external references: failed to resolve object: failed to resolve map element for definitions: failed to resolve map element for io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1beta1.JSONSchemaProps: failed to resolve map element for properties: '$ref' key contains non-string element (map[string]interface {})

I don't know what this error means. It is certainly possible that this has been reported before -- it is possible that this is a duplicate of https://github.com/nytimes/openapi2proto/issues/82.

created time in a month

startedhaskell-core/core-libraries-proposals

started time in a month

startedphilsturgeon/awesome-earth

started time in 2 months

startedresponsibleproblemsolving/energy-usage

started time in 2 months

startedredsift/redbpf

started time in 2 months

startedalessandrod/snuffy

started time in 2 months

push eventtarget/lorri

tshaynik

commit sha 0b3d330e423cb376a3b7c2256165bca1cdf0f9f1

feat(sigterm): daemon exits with 0 on SIGINT or SIGTERM (#471) Make the `lorri daemon` subcommand exit with 0 on SIGINT or SIGTERM, instead of 130/143. Other `lorri` subcommands preserve the default SIGINT and SIGTERM behaviors. This change is done adds the [ctrlc](https://github.com/Detegr/rust-ctrlc) crate, by Antti Keränen, as a dependency. This crate provides a simple and safe interface for handling SIGINT and SIGTERM. An alternative to the `ctrlc` crate would be to implement the response to the signals using the the `nix` crate, which is already a lorri dependency. The downside of this would be adding `unsafe` code to the codebase. fixes #463

view details

push time in 2 months

PR merged target/lorri

feat(sigterm): daemon exits with 0 on SIGINT or SIGTERM

Make the lorri daemon subcommand exit with 0 on SIGINT or SIGTERM.

Other lorri subcommands preserve the default SIGINT and SIGTERM behaviors.

This change is done adds the ctrlc crate, by Antti Keränen, as a dependency. This crate provides a simple and safe interface for handling SIGINT and SIGTERM.

An alternative to the ctrlc crate would be to implement the response to the signals using the the nix crate, which is already a lorri dependency. The downside of this would be adding unsafe code to the codebase.

<!-- Thank you for your contribution!

If this is the first time you are contributing to lorri, please take a look at:

https://github.com/target/lorri/blob/master/CONTRIBUTING.md -->

<!-- Please replace ISSUE by the issue number this pull request addresses. --> Closes #463 .

Overview

<!-- Explain the approach you took to resolving the issue and provide necessary context.

There is no need to go into a lot of detail here: instead, try to make each commit self-explanatory and include good commit messages.

See https://github.com/target/lorri/blob/master/CONTRIBUTING.md for more on how to structure a pull request. -->

  • added the ctrlc crate as a dependency
  • added a function that exits with 0 for SIGINT or SIGTERM
  • call that function on the Daemon arm of the match statement in run_command()

Checklist

<!-- This checklist is here to help you and your reviewers, so feel free to edit it as appropriate, e.g. bugfixes don't usually require a documentation change. -->

  • [ ] Updated the documentation (code documentation, command help, ...)
  • [ ] Tested the change (unit or integration tests)
  • [x] Amended the changelog in release.nix (see release.nix for instructions)
+130 -0

0 comment

6 changed files

tshaynik

pr closed time in 2 months

issue closedtarget/lorri

Ctrc-C ing (SIGINT/SIGTERM) the daemon returns status 130/143 instead of 0

We should accept at least SIGTERM as valid shutdown request, if not SIGINT (which is useful on the command line).

On the command line it never saves lorri daemon in my history, because the return code is not successful.

closed time in 2 months

Profpatsch

Pull request review commenttarget/lorri

feat(sigterm): daemon exits with 0 on SIGINT or SIGTERM

 fn install_panic_handler() {     } } +// Exit with return code 0 on SIGINT and SIGTERM+fn install_signal_handler() {+    ctrlc::set_handler(move || {+        std::process::exit(0);+    })+    .expect("Error setting SIGINT and SIGTERM handler");

So it seems to me that set_handler should fail "basically never".

Thanks for providing this context! Given your analysis, I agree - expect seems like the right thing to use here.

tshaynik

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

issue closedtarget/lorri

Create man page

Feature description <!-- What would you like lorri to do? --> I’ve come to expect that valuable tools have a good man page. Personally I get a bad feeling about a tool if it doesn’t have at least a small one. We should add one.

Target users <!-- Who would this feature help, in what situations? --> Just normal unix users, when looking up man pages for tools is a normal part of the workflow. Compared to looking at --help output:

  • it lists everything, thus makes it possible to search for functionality
  • It can have more verbose descriptions of what a command does
  • It can have plain-text sections
  • Examples

The man page is (and should be) the first place to look to get a overview of what the tool does (and maybe links to tutorials, further reading, &c.)

closed time in 2 months

Profpatsch

issue commenttarget/lorri

Create man page

@tshaynik well spotted :)

Profpatsch

comment created time in 2 months

Pull request review commenttarget/lorri

feat(sigterm): daemon exits with 0 on SIGINT or SIGTERM

 edition = "2018"  [dependencies] atomicwrites = "0.2.3"+ctrlc = { version = "3.1.6", features = ["termination"] } crossbeam-channel = "0.3.8"

"cr[ossbeam-channel]" comes before "ct[rlc]" in the alphabet, would you mind moving the new dependency down by one?

tshaynik

comment created time in 2 months

Pull request review commenttarget/lorri

feat(sigterm): daemon exits with 0 on SIGINT or SIGTERM

 fn install_panic_handler() {     } } +// Exit with return code 0 on SIGINT and SIGTERM+fn install_signal_handler() {+    ctrlc::set_handler(move || {+        std::process::exit(0);+    })+    .expect("Error setting SIGINT and SIGTERM handler");

Given that all the signal handler itself does is provide a slightly nicer UX, crashing lorri if the handler cannot be set seems excessive. Under what circumstances would setting the handler fail?

  • If we expect set_handler to fail every now and then, I would propose just logging a warning on failure and moving on.
  • If set_handler fails "basically never", then calling expect here seems fine.
tshaynik

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

issue commenthyperium/tonic

tonic-examples build crashes: "No such file or directory"

@b333z thanks for the pointers! Coming back to tonic after a while, I encountered the same issue again. For the record, here is how to run the helloworld example in NixOS:

nix-shell -p cargo rustfmt protobuf
PROTOC=$(which protoc) cargo run --bin helloworld-server
curiousleo

comment created time in 2 months

starteddeater/perf_event_tests

started time in 2 months

startedNetflix/flamescope

started time in 2 months

push eventcuriousleo/perf-map-agent

prasun3

commit sha e64161d02857ae1e82b075ea3fe0bbc47f2e1695

Allow perf-map-agent to be loaded at startup Implemented Agent_OnLoad so that the agent may be loaded at startup. Previously the agent could only be attached at runtime

view details

Leonhard Markert

commit sha fa4e82a10ce6fac706df7eb7bcd11c1bae3128d6

Merge pull request #2 from prasun3/master Allow perf-map-agent to be loaded at startup

view details

push time in 2 months

PR merged curiousleo/perf-map-agent

Allow perf-map-agent to be loaded at startup

Implemented Agent_OnLoad so that the agent may be loaded at startup. Previously the agent could only be attached at runtime

https://github.com/jvm-profiling-tools/perf-map-agent/pull/85

+15 -0

0 comment

1 changed file

curiousleo

pr closed time in 2 months

PR opened curiousleo/perf-map-agent

Allow perf-map-agent to be loaded at startup

Implemented Agent_OnLoad so that the agent may be loaded at startup. Previously the agent could only be attached at runtime

https://github.com/jvm-profiling-tools/perf-map-agent/pull/85

+15 -0

0 comment

1 changed file

pr created time in 2 months

push eventcuriousleo/perf-map-agent

Paweł Dąbrowski

commit sha 3199e5ce2f09739968408596c75d8d87ea6aa7f3

Support for JDK 9+.

view details

Leonhard Markert

commit sha 8dcc2ebefc726b845071fe26e8fde4165b6c7b22

Merge pull request #1 from codewise/java-9-plus Support for JDK 9+.

view details

push time in 2 months

PR merged curiousleo/perf-map-agent

Support for JDK 9+.

https://github.com/jvm-profiling-tools/perf-map-agent/pull/83

+14 -3

0 comment

2 changed files

curiousleo

pr closed time in 2 months

PR opened curiousleo/perf-map-agent

Support for JDK 9+.
+14 -3

0 comment

2 changed files

pr created time in 2 months

fork curiousleo/perf-map-agent

A java agent to generate method mappings to use with the linux `perf` tool

fork in 2 months

pull request commentjvm-profiling-tools/perf-map-agent

Allow perf-map-agent to be loaded at startup

I am unfortunately not qualified to review this code, but being able to load the agent at startup would be very useful.

prasun3

comment created time in 2 months

startedGoogleContainerTools/distroless

started time in 2 months

delete branch curiousleo/cqengine-phtree

delete branch : update-dependencies

delete time in 2 months

push eventcuriousleo/cqengine-phtree

Leonhard Markert

commit sha c063fe58af481eb84c10a3a9f75e65049d03f005

Update dependencies (#14)

view details

push time in 2 months

create barnchcuriousleo/cqengine-phtree

branch : update-dependencies

created branch time in 2 months

delete branch curiousleo/cqengine-phtree

delete branch : update-buildifier

delete time in 2 months

push eventcuriousleo/cqengine-phtree

Leonhard Markert

commit sha 50b0bba7a3c2adfae8bd7aa9b201a33f041a5537

Update buildifier, google-java-format, test and benchmark dependencies (#13)

view details

push time in 2 months

push eventcuriousleo/cqengine-phtree

Leonhard Markert

commit sha f580a14589e5036c3e1ebe20fe21f72e3ea4c11b

Update jmh to 1.25

view details

Leonhard Markert

commit sha 32952681e626b819a9d34c2bf8046df68e882339

Update test dependencies

view details

push time in 2 months

push eventcuriousleo/cqengine-phtree

Leonhard Markert

commit sha ce410d2872a7e6de10bf61f76f6a80882fbf6cc8

Update google-java-format to 1.8

view details

push time in 2 months

create barnchcuriousleo/cqengine-phtree

branch : update-buildifier

created branch time in 2 months

push eventcuriousleo/cqengine-phtree

Leonhard Markert

commit sha 7e2fe3dffa26311795f9bf24f2ceacb812ce1a34

Bazel 2.0.0 compatibility (#12)

view details

push time in 2 months

delete branch curiousleo/cqengine-phtree

delete branch : update-bazel

delete time in 2 months

push eventcuriousleo/cqengine-phtree

Leonhard Markert

commit sha 074ae50bec7a6d1c439244e1a0280c4e8b17a9c2

Bazel 2.0.0 compatibility (#12)

view details

push time in 2 months

PR merged curiousleo/cqengine-phtree

Make project compatible with Bazel 2.0.0

No Maven dependency updates at this point, just Bazel stuff.

+1087 -98

0 comment

6 changed files

curiousleo

pr closed time in 2 months

push eventcuriousleo/cqengine-phtree

Leonhard Markert

commit sha 18b812f5afd7166e977f75958c8e5ab25539e4be

Update .travis.yml

view details

push time in 2 months

PR opened curiousleo/cqengine-phtree

Make project compatible with Bazel 2.0.0

No Maven dependency updates at this point, just Bazel stuff.

+1086 -97

0 comment

6 changed files

pr created time in 2 months

push eventcuriousleo/cqengine-phtree

Leonhard Markert

commit sha 135e7df96e44538381ae4d74b81efa3938f714b5

Make project compatible with Bazel 2.0.0

view details

push time in 2 months

create barnchcuriousleo/cqengine-phtree

branch : update-bazel

created branch time in 2 months

push eventcuriousleo/setup

Leonhard Markert

commit sha 7db325b289d315d27a8c6caf7a121acb702706f9

(j,minikube,podman,nix-index) add

view details

Leonhard Markert

commit sha 7378b8cb57e31343d4cc8f07b038e9d9ec7215dc

(dhall-vim) add

view details

push time in 2 months

Pull request review commenttweag/linear-base

Dependency updates

 # See https://hub.docker.com/r/tweag/linear-types/-resolver: lts-16.2+resolver: lts-16.8 compiler: ghc-8.11 allow-newer: true system-ghc: true  packages: - '.' +# If you update the extra-deps, make sure to also update cabal.project extra-deps:-- git: https://github.com/facundominguez/quickcheck.git-  commit: a498e7b41131cf7955b9e154ab26d37d1be10304-- git: https://github.com/facundominguez/lifted-async.git-  commit: 898eb485b21cc321058345998eedd8c409c326fd+# https://github.com/nick8325/quickcheck/pull/311+- git: https://github.com/phadej/quickcheck.git+  commit: d659a5e44b3304e7599321d506bf48d2e88389d0+# https://github.com/hedgehogqa/haskell-hedgehog/pull/392+- git: https://github.com/utdemir/haskell-hedgehog.git+  commit: c98aa9e33bf6871098d6f4ac94eeaac10383d696+  subdirs:+    - hedgehog+# below is required for getting quickcheck compile+- random-1.2.0

yes

utdemir

comment created time in 3 months

starteddhall-lang/dhall-nethack

started time in 3 months

more