profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/cribbles/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

contentful/rich-text 352

Libraries for handling and rendering Rich Text 📄

cribbles/Slipmat 3

Discogs clone, powered by Rails and Backbone

cribbles/gainz 2

A simple CLI cryptocurrency portfolio

cribbles/marked-ast 2

A modified version of chjj/marked that can produce an abstract syntax tree for Markdown

contentful/markdown-to-jsx 1

🏭 The most lightweight, customizable React markdown component.

cribbles/array_each_count 1

Ruby code kata designed for RSpec

contentful/marked-ast 0

A modified version of chjj/marked that can produce an abstract syntax tree for Markdown

cribbles/ActiveRecordLite 0

Lightweight SQLite ORM

cribbles/capybara-mocktime 0

Ruby gem for synchronizing time between tests and the browser using Timecop and Sinon.

cribbles/checkers 0

Ruby checkers game

delete branch contentful/field-editors

delete branch : fix/embeds

delete time in 4 hours

push eventcontentful/field-editors

Chris Sloop

commit sha 3b9835d70c1a376ff986fb6569814173b9d98c49

fix: block embed insertion (#794)

view details

push time in 4 hours

PR merged contentful/field-editors

fix: block embeds package:rich-text

Fixes block embed insertion in the webapp (or in other embedded contexts).

It's possible for the selection to get lost in these contexts when, e.g., selecting an entity means prompting a modal (and selecting from that modal using the mouse). To address this, we capture the selection before reaching selectEntity and reset the selection with Transforms.select right afterward.

+2 -0

0 comment

1 changed file

cribbles

pr closed time in 4 hours

PR opened contentful/field-editors

fix: block embeds

Fixes block embed insertion in the webapp (or in other embedded contexts).

It's possible for the selection to get lost in these contexts when, e.g., selecting an entity means prompting a modal (and selecting from that modal using the mouse). To address this, we capture the selection before reaching selectEntity and reset the selection with Transforms.select right afterward.

+2 -0

0 comment

1 changed file

pr created time in 7 hours

create barnchcontentful/field-editors

branch : fix/embeds

created branch time in 7 hours

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventcontentful/field-editors

Chris Sloop

commit sha d9864508c6d90449b09a3e185f19b043675ad136

feat: add embedded entity inline (#786) * chore: add ready only support for the new editor * fix: key shortcut for adding embedded assets * chore: create embedded entity inline component * feat: bump @contentful/field-editor-reference * feat: add keyboard shortcuts, fixes and tests * chore: improve deps * chore: prettier Co-authored-by: Cezar Sampaio <cezar.sampaio@contentful.com>

view details

push time in 7 days

delete branch contentful/field-editors

delete branch : feat/add-entity-inline

delete time in 7 days

PR merged contentful/field-editors

feat: add embedded entity inline package:rich-text tests
  • [x] adds embedded entity inline elements
    • keyboard shortcuts
    • cypress tests

Also

  • [x] fixes keyboard shortcut for asset inlines
  • [x] fixes "move to top" / "move to bottom" incorrectly appearing on embedded entry cards
+479 -20

0 comment

10 changed files

cribbles

pr closed time in 7 days

push eventcontentful/field-editors

Chris Sloop

commit sha 9155544e59a043dac64dcb2cc8e2a1481ea0d21d

chore: improve deps

view details

Chris Sloop

commit sha 310518a53ea12d3134421b8e6b7532f9ead3f616

chore: prettier

view details

push time in 7 days

Pull request review commentcontentful/field-editors

feat: add embedded entity inline

 describe('Rich Text Editor', () => {       });     }   });++  describe('Embedded Entry Inlines', () => {+    const methods: [string, () => void][] = [+      [+        'using the toolbar button',+        () => {+          cy.findByTestId('toolbar-entity-dropdown-toggle').click();+          cy.findByTestId('toolbar-toggle-embedded-entry-inline').click();+          cy.wait(100);+        },+      ],+      [+        'using the keyboard shortcut',+        () => {+          editor().type(`{${mod}}{shift}2`);+          cy.wait(100);+        }+      ]+    ];++    for (const [triggerMethod, triggerEmbeddedAsset] of methods) {+      describe(triggerMethod, () => {+        it('adds and removes embedded entries', () => {+          editor().click().typeInSlate('hello')+          triggerEmbeddedAsset();+          editor().click().typeInSlate('world')++          cy.wait(500);

Probably, but I think this is a larger issue we should address in the rest of our test suite. I'll add a ticket for it.

cribbles

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentcontentful/field-editors

feat: add embedded entity inline

 export function LinkedEntityBlock(props: LinkedEntityBlockProps) {     Transforms.removeNodes(editor, { at: pathToElement });   }; -  // TODO: fixme -- props not available on new editor-  const isDisabled = false; // editor.props.readOnly || editor.props.actionsDisabled;

We use it for the ReadOnlyRichTextEditor in the UI diff view: https://github.com/contentful/user_interface/blob/09590e62f7ccf4058b10efad175573ceb1077532/src/javascripts/app/widgets/RichText/ReadOnlyRichTextEditor.js#L14-L25

But that's in coordination with readOnly and I can't remember if there was a practical rather than semantic reason for separating between these two.

cribbles

comment created time in 7 days

PullRequestReviewEvent

push eventcribbles/cribbles.github.io

Chris Sloop

commit sha 26609c90e7516e156538d3bab775e693fa432015

Reformat resume

view details

Chris Sloop

commit sha a86b1ece1cf78787b3b1702c2e1d08bbb26526ad

Reformat homepage

view details

push time in 8 days

PR opened contentful/field-editors

feat: add entity inline
  • [x] adds embedded entity inline elements
    • keyboard shortcuts
    • cypress tests

Also

  • [x] fixes keyboard shortcut for asset inlines
  • [x] fixes "move to top" / "move to bottom" incorrectly appearing on embedded entry cards
+472 -20

0 comment

10 changed files

pr created time in 8 days

push eventcontentful/field-editors

z0al

commit sha d7ca79d5fd8bf973dacfb3e00391bf8f2c730cee

chore: auto publish alpha Rich Text package (#782)

view details

z0al

commit sha 4b35661577ee2b061110ba23b1ac3fc42c62ea28

Revert "chore: auto publish alpha Rich Text package (#782)" (#783) This reverts commit d7ca79d5fd8bf973dacfb3e00391bf8f2c730cee.

view details

Cezar Sampaio

commit sha 520fbd397f98d455a48be3a8104f589ac20daad6

chore: add ready only support for the new editor

view details

Cezar Sampaio

commit sha 35d7b2691e4adc0a559f7b6a0faadf79a9be7821

fix: key shortcut for adding embedded assets

view details

Cezar Sampaio

commit sha a264753dd7aef1a0aff181d91ee3a705fbf54e50

chore: create embedded entity inline component

view details

Chris Sloop

commit sha c160295a7afba460e9a8353cfed24a29b2296bdf

feat: bump @contentful/field-editor-reference

view details

Chris Sloop

commit sha 1434088d5e926d54fca4018f142122b9b1434448

feat: add keyboard shortcuts, fixes and tests

view details

push time in 8 days

push eventcontentful/field-editors

Chris Sloop

commit sha 2c146496889459d5e805a7cbd8b6e091629bb32b

feat: bump @contentful/field-editor-reference

view details

Chris Sloop

commit sha 90f46e2a45c09497971aeea2f6f63bc1d6eb82bc

feat: embedded entry inlines

view details

push time in 8 days

delete branch contentful/field-editors

delete branch : fix/move-options

delete time in 8 days

push eventcontentful/field-editors

Chris Sloop

commit sha bf951b2d15234c3698a535898e7a5c233765e856

fix: render dropdown list or fragment (#785)

view details

push time in 8 days

PR merged contentful/field-editors

Reviewers
fix: render dropdown list or fragment package:reference

Fixes https://github.com/contentful/field-editors/pull/784

For reasons not obvious to me, false actually causes this to fail with

TypeError: Cannot read property 'type' of null

I confess I am not sure why this solution works (ternary to default undefined or anything else falsy has the same problem), but it's low cost and accomplishes basically the same thing with the same DOM markup in the end. If anyone has any further suggestions / thoughts, I am open.

+2 -2

2 comments

1 changed file

cribbles

pr closed time in 8 days

pull request commentcontentful/field-editors

fix: render dropdown list or fragment

@taye awesome, fished around than way longer than I should've and couldn't find that

cribbles

comment created time in 8 days

PR opened contentful/field-editors

fix: render dropdown list or fragment

Fixes https://github.com/contentful/field-editors/pull/784

For reasons not obvious to me, false actually causes this to fail with

TypeError: Cannot read property 'type' of null

I confess I am not sure why this solution works (ternary to default undefined or anything else falsy has the same problem), but it's low cost and accomplishes basically the same thing with the same DOM markup in the end. If anyone has any further suggestions / thoughts, I am open.

+2 -2

0 comment

1 changed file

pr created time in 8 days

create barnchcontentful/field-editors

branch : fix/move-options

created branch time in 8 days

push eventcontentful/field-editors

Chris Sloop

commit sha 8a522f0e1e0c21d9eb6642bde4f509760448dc37

feat: add hasMoveOptions property (#784)

view details

push time in 8 days

delete branch contentful/field-editors

delete branch : feat/new-options

delete time in 8 days

PR merged contentful/field-editors

Reviewers
feat: add hasMoveOptions property package:reference

Affects the WrappedEntryCard element of the reference editor

  • [x] adds hasMoveOptions property for "Move to top" and "Move to bottom" options
  • [x] doesn't impose event.preventDefault() on click events when the element is not clickable
  • [x] adds missing property to a React.useEffect
+25 -21

0 comment

1 changed file

cribbles

pr closed time in 8 days