profile
viewpoint
Cory LaNou corylanou @gopherguides Cadott, WI http://www.twitter.com/corylanou Co-founder at Gopher Guides (Love training @golang). Mentor to software developers and entrepreneurs.

corylanou/go-meetup 136

Running a Go Meetup

corylanou/go-1-hour-boot-camp 15

Presentation that gives a high level overview of Go and some basic language use case highlights.

corylanou/go-mongo-presentation 9

Presentation on how to use MongoDB and Go

corylanou/add-go-lint-issue 4

Script that allows you to easily create a "go lint" issue for your repo

corylanou/go-colorize-stack 3

Piping in to this program test output as will colorize the lines of code that belong to your project.

corylanou/go-meetup-events 3

Scrape meetup events for tech

corylanou/go-swag 3

Go swag is awesome, here is a list of how to get more!

corylanou/go-marketing 2

Series of go tutorials used for marketing purposes

corylanou/cloud-elements-demo 1

Sample projects used for a cloud elements project

chrisklein/hackdenver 0

hackdenver

PullRequestReviewEvent

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 7c9c8da37abbfa22c786bb2d2add8489d1a65342

filesystemService.Dir first pass

view details

Cory LaNou

commit sha fc5ded7ff93370b9184c3485036d2598fcebfa49

fix tests for example filesystem loop

view details

Cory LaNou

commit sha 9aeea20343bfaa3cfe86cbbf6fdaef3cca2295bc

add filesystem file endpoint

view details

Cory LaNou

commit sha f5c9f2724767f3e3deaf00e95ccac1a02841ceff

add listen-directory filesystem endpoint

view details

Cory LaNou

commit sha 309ae185fad12756dffece283f529ad02320ee56

minor renaming

view details

Cory LaNou

commit sha 83ddc17536e51579a4e5e021a107bc6ef326f490

finish filesystem service

view details

Cory LaNou

commit sha 10c5342822a645ca8b0b59586635b4b07eb4be47

fix method comment

view details

Cory LaNou

commit sha 7de77526d6e26b2e227599eaa738bfe3c6d643c0

Merge pull request #30 from open-olive/RDE-431-filewatcher SIDE-820 Add Filesystem Service

view details

push time in 6 days

delete branch open-olive/loop-development-kit-go

delete branch : RDE-431-filewatcher

delete time in 6 days

PR merged open-olive/loop-development-kit-go

Reviewers
SIDE-820 Add Filesystem Service

Adds the following filesystem services:

Dir(string) ([]FileInfo, error)
ListenDir(context.Context, string, ListenDirHandler) error
File(string) (FileInfo, error)
ListenFile(context.Context, string, ListenFileHandler) error
+3797 -79

0 comment

95 changed files

corylanou

pr closed time in 6 days

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 10c5342822a645ca8b0b59586635b4b07eb4be47

fix method comment

view details

push time in 6 days

push eventopen-olive/loop-development-kit-go

richseviora

commit sha 24021e299c88a2afd078aa0330230af31770387f

[SIDE-834] Add Cursor client and server

view details

richseviora

commit sha a1afe0198dfda3844a3597c5540a8e990f76a9dc

[SIDE-834] Connect cursor client

view details

Rich Seviora

commit sha 65d9497dbf2c349630d2936a78165714ba1af19c

Merge pull request #29 from open-olive/SIDE-834/cursor-position [SIDE-834] Add Cursor Service

view details

Cory LaNou

commit sha 7c9c8da37abbfa22c786bb2d2add8489d1a65342

filesystemService.Dir first pass

view details

Cory LaNou

commit sha fc5ded7ff93370b9184c3485036d2598fcebfa49

fix tests for example filesystem loop

view details

Cory LaNou

commit sha 9aeea20343bfaa3cfe86cbbf6fdaef3cca2295bc

add filesystem file endpoint

view details

Cory LaNou

commit sha f5c9f2724767f3e3deaf00e95ccac1a02841ceff

add listen-directory filesystem endpoint

view details

Cory LaNou

commit sha 309ae185fad12756dffece283f529ad02320ee56

minor renaming

view details

Cory LaNou

commit sha 83ddc17536e51579a4e5e021a107bc6ef326f490

finish filesystem service

view details

push time in 6 days

create barnchopen-olive/loop-development-kit-go

branch : SIDE-826-window-service

created branch time in 7 days

PR opened open-olive/loop-development-kit-go

Reviewers
SIDE-820 filewatcher

Adds the following filewatcher services:

Dir(string) ([]FileInfo, error)
ListenDir(context.Context, string, ListenDirHandler) error
File(string) (FileInfo, error)
ListenFile(context.Context, string, ListenFileHandler) error
+3791 -74

0 comment

89 changed files

pr created time in 7 days

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 42c94b801a0bb564d95afe8ed12c442b82e0fe5d

finish filesystem service

view details

push time in 7 days

PullRequestReviewEvent

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha c08a6caace348c7a3f85562d66c2f16585c42fcc

Use a character instead of scancode This will allow for cross platform OS development without having to know the specifics on keyboard scancodes.

view details

Cory LaNou

commit sha 9ff0add70a1614dca5251ff7a85d8f89f7acd9c1

Merge pull request #4 from open-olive/RDE-431-scancode-character RDE-431 Use a character instead of scancode

view details

richseviora

commit sha e682350c91bc243616d96c9b4397f4e7322f7e06

[SIDE-805] Add Broker and StdIO services

view details

richseviora

commit sha 7c597629d68f92fd5d24d9f4bd599c1fcbfb1830

[SIDE-815] Rename, Add Error to WhisperFormStreamResponse

view details

Rich Seviora

commit sha 9f09dbce62734256683e80b01b880167400b9390

Apply suggestions from code review [SIDE-805] Align package and go_package options Co-authored-by: Cory LaNou <cory@lanou.com>

view details

Rich Seviora

commit sha e5a91b1eee627e9f482928d25b5af8ab1bd0937d

Merge pull request #6 from open-olive/SIDE-815/add-form-error [SIDE-815] Rename, Add Error to WhisperFormStreamResponse

view details

Rich Seviora

commit sha ec1155825d66b3596b95e638f1d9825bbd7312e0

Merge pull request #5 from open-olive/SIDE-805/broker-and-stdio [SIDE-805] Add Broker and StdIO services

view details

richseviora

commit sha f428403decd6d09e853179bf1cd551e79b83f546

[SIDE-824] Add context param to listener functions

view details

richseviora

commit sha c63f555a773d38b12c41dc3e86c7c6fff0b0a0aa

[SIDE-824] Return an array of process infos instead of one obj

view details

Rich Seviora

commit sha 3208b697f6cebbbc92153dadbac04256fd4e2f24

Merge pull request #27 from open-olive/SIDE-824/add-context-to-process [SIDE-824] Add Context To Listener Functions

view details

richseviora

commit sha 345988dbfc8f2db94af7afc01bd3b190988cf671

[SIDE-824] Implement Process Server, Client

view details

richseviora

commit sha 980ed97cd301ef5d0c93c508ce212438d0a91ddf

[SIDE-849] Add Process Host broker ID

view details

richseviora

commit sha 450a0e4b967dadd5df07d649b49246d4890ec11e

[SIDE-849] Add remaining host broker IDs

view details

Rich Seviora

commit sha 822bc28f88098c37c4554c81c70cdec91c3e65b4

Merge pull request #7 from open-olive/SIDE-849/process-sensor [SIDE-849] Add Process Host broker ID

view details

richseviora

commit sha afa91bc41800d3c38df63107d672cd45ac2cb910

Merge commit '822bc28f88098c37c4554c81c70cdec91c3e65b4' into SIDE-849/process-sensor

view details

richseviora

commit sha 2e1b901d671f1e8cb27afdf1f698df7a742a788d

[SIDE-824] Subtree misaligned, rebuilding

view details

richseviora

commit sha 4e8f11ebbdea38f61ad6fec0dd3473b30d79dc3c

Add 'shared/' from commit '822bc28f88098c37c4554c81c70cdec91c3e65b4' git-subtree-dir: shared git-subtree-mainline: 2e1b901d671f1e8cb27afdf1f698df7a742a788d git-subtree-split: 822bc28f88098c37c4554c81c70cdec91c3e65b4

view details

richseviora

commit sha bca2190f165cb6f7a46ad53a9bacde47b20277bc

[SIDE-824] Rebuild protoc

view details

richseviora

commit sha aae6a632da61e2097a91c696e5f7e0e3fbca4ad7

[SIDE-849] Update Whisper with proto changes

view details

Rich Seviora

commit sha f2a891c347774cfd790e4b17060535ce902280e1

Merge pull request #28 from open-olive/SIDE-849/process-sensor [SIDE-849] Implement Process Server and Client

view details

push time in 8 days

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha f93a537ff7c67565a90a76710b82ef513e72b9fe

add listen-directory filesystem endpoint

view details

push time in 12 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha a29f6db026bf2019599b4e1345f76c3d6fc016a5

add filesystem file endpoint

view details

push time in 16 days

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha ad025a3009652878144c9b865a94c1b672e40cd1

fix tests for example filesystem loop

view details

push time in 16 days

create barnchopen-olive/loop-development-kit-go

branch : RDE-431-filewatcher

created branch time in 19 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentopen-olive/loop-development-kit-shared

[SIDE-805] Add Broker and StdIO services

+syntax = "proto3";+package plugin;
package proto;
richseviora

comment created time in 20 days

Pull request review commentopen-olive/loop-development-kit-shared

[SIDE-805] Add Broker and StdIO services

+syntax = "proto3";+package plugin;+option go_package = "plugin";
package proto;
option go_package = ".;proto";
richseviora

comment created time in 20 days

Pull request review commentopen-olive/loop-development-kit-shared

[SIDE-805] Add Broker and StdIO services

+syntax = "proto3";+package plugin;+option go_package = "plugin";

I'm not sure, but I think it should be

option go_package = ".;proto";
richseviora

comment created time in 20 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventopen-olive/loop-development-kit-go

Ian Gall

commit sha fd7418849c8095fc265295d62b0edc6d7ddc9aa4

Initial commit

view details

Billy Murray

commit sha fa6be70d01cbce55579b54a73d011abc5aa2643c

Added protobuf definitions

view details

BillyMurrayOlive

commit sha 79eee4c979b078d12851cdaaaab1854755500523

Merge pull request #1 from open-olive/feature/RDE-431-loop-upgrade Added protobuf definitions

view details

Cory LaNou

commit sha b51b876875235bac97d1e81b73d1b356d9ecdff0

first pass at hotkey stream

view details

Billy Murray

commit sha cb9901a1edf5282b23003d165f68c603e4d9f558

Renamed files to file in response

view details

Billy Murray

commit sha 94a18fd79d83f203e74ba83cc6a431559375ff05

Added keyboard host

view details

Billy Murray

commit sha 7ff9b20ccbd21573e1980589ac48a7978d445054

Only one hotkey can be registered on a stream

view details

Billy Murray

commit sha 47be1dd4085b77660a6edec7482d385d8369c50a

Support for whisper interaction

view details

BillyMurrayOlive

commit sha bdcec8fe18d54350f62df3821a926d4efc32c012

Merge pull request #3 from open-olive/RDE-431-loop-upgrade-whisper-interaction Rde 431 loop upgrade whisper interaction

view details

Cory LaNou

commit sha 89e030b8f5a8b03d44cee59759ec4ebb26bc1f87

Add 'shared/' from commit 'bdcec8fe18d54350f62df3821a926d4efc32c012' git-subtree-dir: shared git-subtree-mainline: b51b876875235bac97d1e81b73d1b356d9ecdff0 git-subtree-split: bdcec8fe18d54350f62df3821a926d4efc32c012

view details

Cory LaNou

commit sha 0e3e621ff4d7672189b7c1b9fbd05076481b46f0

wip

view details

Cory LaNou

commit sha 09734b5af360139e01f87f61e6c897be94613b9b

remove subtree for now

view details

Cory LaNou

commit sha ee6e8da6131b6081fc350fd8846051158283dec3

Add 'shared/' from commit '7ff9b20ccbd21573e1980589ac48a7978d445054' git-subtree-dir: shared git-subtree-mainline: 09734b5af360139e01f87f61e6c897be94613b9b git-subtree-split: 7ff9b20ccbd21573e1980589ac48a7978d445054

view details

Cory LaNou

commit sha d92fa0911d481b8daf03c4734b3baacbcc2e94da

hotkeys now use a character instead of scan code

view details

Cory LaNou

commit sha 35977541e80f69c6f74d97c51593d234dbf89515

Merge pull request #26 from open-olive/RDE-431-keyboard-hotkey-service RDE-431 keyboard hotkey service

view details

push time in 21 days

delete branch open-olive/loop-development-kit-go

delete branch : RDE-431-keyboard-hotkey-service

delete time in 21 days

PR merged open-olive/loop-development-kit-go

Reviewers
RDE-431 keyboard hotkey service

This adds the "hot key" keyboard service.

+965 -87

0 comment

33 changed files

corylanou

pr closed time in 21 days

Pull request review commentopen-olive/loop-development-kit-go

RDE-431 keyboard hotkey service

 type KeyboardService interface { }  type Hotkey struct {-	Scancode  int+	Key       rune 	Modifiers KeyModifier } +func (h Hotkey) Match(v Hotkey) bool {+	if h.Key != v.Key {+		return false+	}+	// You can't do a direct bitmask as Alt means Altleft or AltRight.  So checking all combinations is the only safe way to actually compare+	l, r := h.Modifiers, v.Modifiers+	return (l.AltLeft() == r.AltLeft() || l.Alt() == r.Alt()) && (l.AltRight() == r.AltRight() || l.Alt() == r.Alt()) &&+		(l.ControlLeft() == r.ControlLeft()) || l.Control() == r.Control() && (l.ControlRight() == r.ControlRight() || l.Control() == r.Control()) &&+		(l.MetaLeft() == r.MetaLeft() || l.Meta() == r.Meta()) && (l.MetaRight() == r.MetaRight() || l.Meta() == r.Meta()) &&+		(l.ShiftLeft() == r.ShiftLeft() || l.Shift() == r.Shift()) && (l.ShiftRight() == r.ShiftRight() || l.Shift() == r.Shift())+}+ type KeyModifier int -func (k KeyModifier) AltLeft() bool  { return int(k)&keyModifierAltLeft == keyModifierAltLeft }-func (k KeyModifier) AltRight() bool { return int(k)&keyModifierAltRight == keyModifierAltRight }-func (k KeyModifier) Alt() bool      { return int(k)&keyModifierAlt == keyModifierAlt }+func (k KeyModifier) AltLeft() bool {+	return int(k)&KeyModifierCommandAltLeft == KeyModifierCommandAltLeft+}+func (k KeyModifier) AltRight() bool {+	return int(k)&KeyModifierCommandAltRight == KeyModifierCommandAltRight+}+func (k KeyModifier) Alt() bool { return int(k)&KeyModifierCommandAlt == KeyModifierCommandAlt } func (k KeyModifier) ControlLeft() bool {-	return int(k)&keyModifierControlLeft == keyModifierControlLeft+	return int(k)&KeyModifierControlLeft == KeyModifierControlLeft } func (k KeyModifier) ControlRight() bool {-	return int(k)&keyModifierControlRight == keyModifierControlRight+	return int(k)&KeyModifierControlRight == KeyModifierControlRight }-func (k KeyModifier) Control() bool    { return int(k)&keyModifierControl == keyModifierControl }-func (k KeyModifier) MetaLeft() bool   { return int(k)&keyModifierMetaLeft == keyModifierMetaLeft }-func (k KeyModifier) MetaRight() bool  { return int(k)&keyModifierMetaRight == keyModifierMetaRight }-func (k KeyModifier) Meta() bool       { return int(k)&keyModifierMeta == keyModifierMeta }-func (k KeyModifier) ShiftLeft() bool  { return int(k)&keyModifierShiftLeft == keyModifierShiftLeft }-func (k KeyModifier) ShiftRight() bool { return int(k)&keyModifierShiftRight == keyModifierShiftRight }-func (k KeyModifier) Shift() bool      { return int(k)&keyModifierShift == keyModifierShift }+func (k KeyModifier) Control() bool    { return int(k)&KeyModifierControl == KeyModifierControl }+func (k KeyModifier) MetaLeft() bool   { return int(k)&KeyModifierMetaLeft == KeyModifierMetaLeft }+func (k KeyModifier) MetaRight() bool  { return int(k)&KeyModifierMetaRight == KeyModifierMetaRight }+func (k KeyModifier) Meta() bool       { return int(k)&KeyModifierMeta == KeyModifierMeta }+func (k KeyModifier) ShiftLeft() bool  { return int(k)&KeyModifierShiftLeft == KeyModifierShiftLeft }+func (k KeyModifier) ShiftRight() bool { return int(k)&KeyModifierShiftRight == KeyModifierShiftRight }+func (k KeyModifier) Shift() bool      { return int(k)&KeyModifierShift == KeyModifierShift }  // generate this base formatted code from: https://play.golang.org/p/CukMdzwdU0P const (-	keyModifierAltLeft      = 1 << 0  //  00000000000000000000000000000001 -> 1-	keyModifierAltRight     = 1 << 1  //  00000000000000000000000000000010 -> 2-	keyModifierAlt          = 1 << 2  //  00000000000000000000000000000100 -> 4-	keyModifierControlLeft  = 1 << 3  //  00000000000000000000000000001000 -> 8-	keyModifierControlRight = 1 << 4  //  00000000000000000000000000010000 -> 16-	keyModifierControl      = 1 << 5  //  00000000000000000000000000100000 -> 32-	keyModifierMetaLeft     = 1 << 6  //  00000000000000000000000001000000 -> 64-	keyModifierMetaRight    = 1 << 7  //  00000000000000000000000010000000 -> 128-	keyModifierMeta         = 1 << 8  //  00000000000000000000000100000000 -> 256-	keyModifierShiftLeft    = 1 << 9  //  00000000000000000000001000000000 -> 512-	keyModifierShiftRight   = 1 << 10 //  00000000000000000000010000000000 -> 1024-	keyModifierShift        = 1 << 11 //  00000000000000000000100000000000 -> 2048+	// Alt on Windows, Command on Mac

So after double checking, that is the correct logic, but it did make me take a closer look at the sensor in olive helps itself and refactor the os specific files to make it crystal clear. As such, there is nothing to change here.

corylanou

comment created time in 21 days

PullRequestReviewEvent

push eventopen-olive/loop-development-kit-shared

Cory LaNou

commit sha c08a6caace348c7a3f85562d66c2f16585c42fcc

Use a character instead of scancode This will allow for cross platform OS development without having to know the specifics on keyboard scancodes.

view details

Cory LaNou

commit sha 9ff0add70a1614dca5251ff7a85d8f89f7acd9c1

Merge pull request #4 from open-olive/RDE-431-scancode-character RDE-431 Use a character instead of scancode

view details

push time in 21 days

delete branch open-olive/loop-development-kit-shared

delete branch : RDE-431-scancode-character

delete time in 21 days

PR merged open-olive/loop-development-kit-shared

Reviewers
RDE-431 Use a character instead of scancode

This will allow for cross platform OS development without having to know the specifics on keyboard scancodes.

+1 -1

0 comment

1 changed file

corylanou

pr closed time in 21 days

Pull request review commentopen-olive/loop-development-kit-go

RDE-431 keyboard hotkey service

 type KeyboardService interface { }  type Hotkey struct {-	Scancode  int+	Key       rune 	Modifiers KeyModifier } +func (h Hotkey) Match(v Hotkey) bool {+	if h.Key != v.Key {+		return false+	}+	// You can't do a direct bitmask as Alt means Altleft or AltRight.  So checking all combinations is the only safe way to actually compare+	l, r := h.Modifiers, v.Modifiers+	return (l.AltLeft() == r.AltLeft() || l.Alt() == r.Alt()) && (l.AltRight() == r.AltRight() || l.Alt() == r.Alt()) &&+		(l.ControlLeft() == r.ControlLeft()) || l.Control() == r.Control() && (l.ControlRight() == r.ControlRight() || l.Control() == r.Control()) &&+		(l.MetaLeft() == r.MetaLeft() || l.Meta() == r.Meta()) && (l.MetaRight() == r.MetaRight() || l.Meta() == r.Meta()) &&+		(l.ShiftLeft() == r.ShiftLeft() || l.Shift() == r.Shift()) && (l.ShiftRight() == r.ShiftRight() || l.Shift() == r.Shift())+}+ type KeyModifier int -func (k KeyModifier) AltLeft() bool  { return int(k)&keyModifierAltLeft == keyModifierAltLeft }-func (k KeyModifier) AltRight() bool { return int(k)&keyModifierAltRight == keyModifierAltRight }-func (k KeyModifier) Alt() bool      { return int(k)&keyModifierAlt == keyModifierAlt }+func (k KeyModifier) AltLeft() bool {+	return int(k)&KeyModifierCommandAltLeft == KeyModifierCommandAltLeft+}+func (k KeyModifier) AltRight() bool {+	return int(k)&KeyModifierCommandAltRight == KeyModifierCommandAltRight+}+func (k KeyModifier) Alt() bool { return int(k)&KeyModifierCommandAlt == KeyModifierCommandAlt } func (k KeyModifier) ControlLeft() bool {-	return int(k)&keyModifierControlLeft == keyModifierControlLeft+	return int(k)&KeyModifierControlLeft == KeyModifierControlLeft } func (k KeyModifier) ControlRight() bool {-	return int(k)&keyModifierControlRight == keyModifierControlRight+	return int(k)&KeyModifierControlRight == KeyModifierControlRight }-func (k KeyModifier) Control() bool    { return int(k)&keyModifierControl == keyModifierControl }-func (k KeyModifier) MetaLeft() bool   { return int(k)&keyModifierMetaLeft == keyModifierMetaLeft }-func (k KeyModifier) MetaRight() bool  { return int(k)&keyModifierMetaRight == keyModifierMetaRight }-func (k KeyModifier) Meta() bool       { return int(k)&keyModifierMeta == keyModifierMeta }-func (k KeyModifier) ShiftLeft() bool  { return int(k)&keyModifierShiftLeft == keyModifierShiftLeft }-func (k KeyModifier) ShiftRight() bool { return int(k)&keyModifierShiftRight == keyModifierShiftRight }-func (k KeyModifier) Shift() bool      { return int(k)&keyModifierShift == keyModifierShift }+func (k KeyModifier) Control() bool    { return int(k)&KeyModifierControl == KeyModifierControl }+func (k KeyModifier) MetaLeft() bool   { return int(k)&KeyModifierMetaLeft == KeyModifierMetaLeft }+func (k KeyModifier) MetaRight() bool  { return int(k)&KeyModifierMetaRight == KeyModifierMetaRight }+func (k KeyModifier) Meta() bool       { return int(k)&KeyModifierMeta == KeyModifierMeta }+func (k KeyModifier) ShiftLeft() bool  { return int(k)&KeyModifierShiftLeft == KeyModifierShiftLeft }+func (k KeyModifier) ShiftRight() bool { return int(k)&KeyModifierShiftRight == KeyModifierShiftRight }+func (k KeyModifier) Shift() bool      { return int(k)&KeyModifierShift == KeyModifierShift }  // generate this base formatted code from: https://play.golang.org/p/CukMdzwdU0P const (-	keyModifierAltLeft      = 1 << 0  //  00000000000000000000000000000001 -> 1-	keyModifierAltRight     = 1 << 1  //  00000000000000000000000000000010 -> 2-	keyModifierAlt          = 1 << 2  //  00000000000000000000000000000100 -> 4-	keyModifierControlLeft  = 1 << 3  //  00000000000000000000000000001000 -> 8-	keyModifierControlRight = 1 << 4  //  00000000000000000000000000010000 -> 16-	keyModifierControl      = 1 << 5  //  00000000000000000000000000100000 -> 32-	keyModifierMetaLeft     = 1 << 6  //  00000000000000000000000001000000 -> 64-	keyModifierMetaRight    = 1 << 7  //  00000000000000000000000010000000 -> 128-	keyModifierMeta         = 1 << 8  //  00000000000000000000000100000000 -> 256-	keyModifierShiftLeft    = 1 << 9  //  00000000000000000000001000000000 -> 512-	keyModifierShiftRight   = 1 << 10 //  00000000000000000000010000000000 -> 1024-	keyModifierShift        = 1 << 11 //  00000000000000000000100000000000 -> 2048+	// Alt on Windows, Command on Mac

Hmm... maybe you are right here. I'm remembering that I remapped my keys on my windows keyboard on my mac. So I mapped them by "placement" on the keyboard, not by "name" on the keyboard. Let me fix that quick as I think this would be wrong for people that don't remap their windows keyboard on mac (although most people do). I think the right decision is sticking with the name of they key as it appears though.

corylanou

comment created time in 21 days

PullRequestReviewEvent

issue commentgolangci/golangci-lint

False positive for goimports and gofmt when line ending is CRLF

I don't think this is a golangci-lint issue, it's a git issue. On github, you solve it by adding a .gitattributes file and adding this line to it:

*.go text eol=lf 

For travis CI, you solve it with by adding this config to the .travis.yml file:

git:
  autocrlf: input

Maybe this needs to be added very clearly in the CI documentation section. It has solved 100% of my gofmt golint issues by doing this.

velut

comment created time in 22 days

PR opened open-olive/loop-development-kit-shared

Use a character instead of scancode

This will allow for cross platform OS development without having to know the specifics on keyboard scancodes.

+1 -1

0 comment

1 changed file

pr created time in 22 days

PR opened open-olive/loop-development-kit-go

RDE-431 keyboard hotkey service

This adds the "hot key" keyboard service.

+965 -87

0 comment

33 changed files

pr created time in 22 days

push eventopen-olive/loop-development-kit-go

Billy Murray

commit sha cb9901a1edf5282b23003d165f68c603e4d9f558

Renamed files to file in response

view details

Billy Murray

commit sha 94a18fd79d83f203e74ba83cc6a431559375ff05

Added keyboard host

view details

Billy Murray

commit sha 7ff9b20ccbd21573e1980589ac48a7978d445054

Only one hotkey can be registered on a stream

view details

Billy Murray

commit sha 47be1dd4085b77660a6edec7482d385d8369c50a

Support for whisper interaction

view details

BillyMurrayOlive

commit sha bdcec8fe18d54350f62df3821a926d4efc32c012

Merge pull request #3 from open-olive/RDE-431-loop-upgrade-whisper-interaction Rde 431 loop upgrade whisper interaction

view details

Cory LaNou

commit sha 89e030b8f5a8b03d44cee59759ec4ebb26bc1f87

Add 'shared/' from commit 'bdcec8fe18d54350f62df3821a926d4efc32c012' git-subtree-dir: shared git-subtree-mainline: b51b876875235bac97d1e81b73d1b356d9ecdff0 git-subtree-split: bdcec8fe18d54350f62df3821a926d4efc32c012

view details

Cory LaNou

commit sha 0e3e621ff4d7672189b7c1b9fbd05076481b46f0

wip

view details

Cory LaNou

commit sha 09734b5af360139e01f87f61e6c897be94613b9b

remove subtree for now

view details

Cory LaNou

commit sha ee6e8da6131b6081fc350fd8846051158283dec3

Add 'shared/' from commit '7ff9b20ccbd21573e1980589ac48a7978d445054' git-subtree-dir: shared git-subtree-mainline: 09734b5af360139e01f87f61e6c897be94613b9b git-subtree-split: 7ff9b20ccbd21573e1980589ac48a7978d445054

view details

Cory LaNou

commit sha d92fa0911d481b8daf03c4734b3baacbcc2e94da

hotkeys now use a character instead of scan code

view details

push time in 22 days

PullRequestReviewEvent

push eventopen-olive/loop-development-kit-go

Ian Gall

commit sha fd7418849c8095fc265295d62b0edc6d7ddc9aa4

Initial commit

view details

Billy Murray

commit sha fa6be70d01cbce55579b54a73d011abc5aa2643c

Added protobuf definitions

view details

BillyMurrayOlive

commit sha 79eee4c979b078d12851cdaaaab1854755500523

Merge pull request #1 from open-olive/feature/RDE-431-loop-upgrade Added protobuf definitions

view details

Cory LaNou

commit sha 7147d96abf66d5d064fdb83b1e9574a1f4ed1ee0

remove proto so we can use a shared subtree instead

view details

Cory LaNou

commit sha 946ec80ec5e90017f9d493914e6fb78e1816bccf

Add 'proto/' from commit '79eee4c979b078d12851cdaaaab1854755500523' git-subtree-dir: proto git-subtree-mainline: 7147d96abf66d5d064fdb83b1e9574a1f4ed1ee0 git-subtree-split: 79eee4c979b078d12851cdaaaab1854755500523

view details

Cory LaNou

commit sha 5ba79e86fb2c90bc6ffd6bef76022dd7fd8dc958

update with shared ldk subtree

view details

push time in 23 days

PR closed open-olive/loop-development-kit-shared

Reviewers
Update keyboard proto

This makes a fundamental change to how we specify the key to watch for when subscribing to the KeyboardHotKeyStream. The big reason for this is that if you provide a scan code, you need to know the windows vs. mac/unix key code. We should do that heavy lifting and make it transparent to the ldk consumer. This way they can provide the letter a for the key they want to watch for, instead of 4 for mac or 30 for windows. For a Go project, this would be trivial (but more work of course), but is even more work for a node project. It would also require a lot of code duplication between the node ldk and go ldk if we use scan codes instead of character codes.

+17 -13

1 comment

1 changed file

corylanou

pr closed time in 23 days

pull request commentopen-olive/loop-development-kit-shared

Update keyboard proto

I'm closing this PR in favor of a future PR that is pushed up from the shared git-subtree. Stay tuned.

corylanou

comment created time in 23 days

PullRequestReviewEvent

Pull request review commentopen-olive/loop-development-kit-shared

Update keyboard proto

 service Keyboard { }  message KeyboardHotkey {-    int32 scancode = 1;--    // bit 0 = altL-    // bit 1 = altR-    // bit 2 = ctrlL-    // bit 3 = ctrlR-    // bit 4 = metaL-    // bit 5 = metaR-    // bit 6 = shiftL-    // bit 7 = shiftR+    string key = 1;++    // bit 0  = altL+    // bit 1  = altR+    // bit 2  = alt+    // bit 3  = ctrlL+    // bit 4  = ctrlR+    // bit 5  = ctrl+    // bit 6  = metaL+    // bit 7  = metaR+    // bit 8  = meta+    // bit 9  = shiftL+    // bit 10 = shiftR+    // bit 11 = shift     int32 modifiers = 2; }  message KeyboardHotkeyStreamRequest {-    repeated KeyboardHotkey hotkeys = 1;+    KeyboardHotkey hotkey = 1;

If you want to monitor more than one hotkey combination you will need to have another stream open and watch for that combination as well.

corylanou

comment created time in 23 days

Pull request review commentopen-olive/loop-development-kit-shared

Update keyboard proto

 service Keyboard { }  message KeyboardHotkey {-    int32 scancode = 1;--    // bit 0 = altL-    // bit 1 = altR-    // bit 2 = ctrlL-    // bit 3 = ctrlR-    // bit 4 = metaL-    // bit 5 = metaR-    // bit 6 = shiftL-    // bit 7 = shiftR+    string key = 1;++    // bit 0  = altL+    // bit 1  = altR+    // bit 2  = alt+    // bit 3  = ctrlL+    // bit 4  = ctrlR+    // bit 5  = ctrl+    // bit 6  = metaL+    // bit 7  = metaR+    // bit 8  = meta+    // bit 9  = shiftL+    // bit 10 = shiftR+    // bit 11 = shift     int32 modifiers = 2; }  message KeyboardHotkeyStreamRequest {-    repeated KeyboardHotkey hotkeys = 1;+    KeyboardHotkey hotkey = 1; }  message KeyboardHotkeyStreamResponse {-    bool pressed = 1;+    bool scanned = 1;

I don't know that receiving both the key up and key down for a hotkey makes sense. So I simplified it to just a scanned, meaning we detected that your hotkey combination was pressed.

corylanou

comment created time in 23 days

PullRequestReviewEvent

PR opened open-olive/loop-development-kit-shared

Update keyboard proto

This makes a fundamental change to how we specify the key to watch for when subscribing to the KeyboardHotKeyStream. The big reason for this is that if you provide a scan code, you need to know the windows vs. mac/unix key code. We should do that heavy lifting and make it transparent to the ldk consumer. This way they can provide the letter a for the key they want to watch for, instead of 4 for mac or 30 for windows. For a Go project, this would be trivial (but more work of course), but is even more work for a node project. It would also require a lot of code duplication between the node ldk and go ldk if we use scan codes instead of character codes.

+17 -13

0 comment

1 changed file

pr created time in 23 days

create barnchopen-olive/loop-development-kit-shared

branch : RDE-431-hotkey-stream

created branch time in 23 days

delete branch open-olive/loop-development-kit-go

delete branch : RDE-431-keyboard-new-services

delete time in 23 days

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 168ec6d15bd96201002ea592fb5efe7f0424f5eb

implemented keyboard character service

view details

Cory LaNou

commit sha 3815d269133ccd41cfaafc60a2a9ee385ffdc368

Merge pull request #25 from open-olive/RDE-431-keyboard-new-services RDE-431 - Implemented keyboard character service

view details

push time in 23 days

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 0bd8a83db525b466755c193526930294cd37f244

update LDK for keyboard service/client. add examples

view details

Cory LaNou

commit sha 76450227b6ef09cb553899d9f45ab1839be08ec3

fix lint errors

view details

Cory LaNou

commit sha fb985f2c4ea572ce5869a033576db6ac08eff6a8

remove nested golagnci lint configs

view details

Cory LaNou

commit sha 7d0f6a769b5a5b61dddff99f8bdcac61c3ecebe4

add ldktest package, refactor examples to use ldktest

view details

Cory LaNou

commit sha 12dd314f10bf296d0bc260dceb69f8f4dfcbc9bb

remove commented out code

view details

Cory LaNou

commit sha 4141f26819e7b142ab8b5d3c99c68ff1b071d96b

minor fixes/comments

view details

Cory LaNou

commit sha e7a05d509d47bb4dbc5ca3abaf4f0a07ced85e7e

Merge pull request #24 from open-olive/RDE-431-keyboard RDE-431 Loop Upgrade - Add Keyboard/Clipboard Functionality back in

view details

push time in a month

delete branch open-olive/loop-development-kit-go

delete branch : RDE-431-keyboard

delete time in a month

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 4141f26819e7b142ab8b5d3c99c68ff1b071d96b

minor fixes/comments

view details

push time in a month

Pull request review commentopen-olive/loop-development-kit-go

RDE-431 Loop Upgrade - Add Keyboard/Clipboard Functionality back in

 func (m *ClipboardServer) ClipboardReadStream(emp *empty.Empty, stream proto.Cli 		if err != nil { 			errText = err.Error() 		}--		if err := stream.Send(&proto.ClipboardReadStreamResponse{+		if e := stream.Send(&proto.ClipboardReadStreamResponse{ 			Error: errText, 			Text:  text,-		}); err != nil {-			fmt.Println(err)+		}); e != nil {+			// This should only happen if the context was cancelled for some reason and the stream shuts down.+			fmt.Println("error: ldk.ClipboardServer.ClipbardReadStream -> stream.Send:", e) 		} 	} -	return m.Impl.Listen(stream.Context(), handler)+	go func() {+		err := m.Impl.Listen(stream.Context(), handler)+		// TODO: move this to a real logger once we move this into sidekick+		fmt.Println("error: ldk.ClipboardServer.ClipbardReadStream -> Listen:", err)

Yes... I just blew myself up locally when I hit that line. Clearly missing some tests...

corylanou

comment created time in a month

PullRequestReviewEvent

Pull request review commentopen-olive/loop-development-kit-go

RDE-431 Loop Upgrade - Add Keyboard/Clipboard Functionality back in

+REPO := github.com/open-olive/sidekick-controller-examplego+PKG := examplego++GIT_COMMIT := $(shell git rev-list -1 HEAD)+GIT_BRANCH := $(if $(shell echo $$BRANCH_NAME),$(shell echo $$BRANCH_NAME),$(shell git rev-parse --abbrev-ref HEAD))+VERSION := $(if $(shell echo $$VERSION),$(shell echo $$VERSION),"0.0.0-localdev-unset")+GOPATH := $(shell go env GOPATH)++install:+# The following command is needed to allow go get to clone from private bitbucket repos+	@ git config --global url."git@bitbucket.org:".insteadOf "https://bitbucket.org/"+	go mod download+	go mod tidy++assets:+	@ echo "Compiling assets"+	@ go get github.com/go-bindata/go-bindata/...+	@ $(GOPATH)/bin/go-bindata -o bind/assets.go -pkg bind assets/...+	@ go mod tidy++build/darwin-amd64/plugin:+	go build \+	     -ldflags "-X ${REPO}/controller/controller.GitBranch=${GIT_BRANCH} -X ${REPO}/sensor/sensor.GitCommit=${GIT_COMMIT} -X ${REPO}/sensor/sensor.Version=${VERSION}" \+	     -o build/darwin-amd64/plugin ./++build/windows-amd64/plugin:+	GOOS=windows go build  \+	     -ldflags "-X ${REPO}/controller/controller.GitBranch=${GIT_BRANCH} -X ${REPO}/sensor/sensor.GitCommit=${GIT_COMMIT} -X ${REPO}/sensor/sensor.Version=${VERSION}" \+	     -o build/windows-amd64/plugin.exe ./++clean:+	rm -rf ./build++build: clean build/darwin-amd64/plugin build/windows-amd64/plugin++deploy-local: build

This is temporary until sidekick has the loop library updated in our branch again. Right now we can't use the loop library as it's broken. I'll make a note in the Makefile that we need to delete this before merging to master, so on our final review we should catch that. Thoughts?

corylanou

comment created time in a month

PullRequestReviewEvent

Pull request review commentopen-olive/loop-development-kit-go

RDE-431 Loop Upgrade - Add Keyboard/Clipboard Functionality back in

+REPO := github.com/open-olive/sidekick-controller-examplego+PKG := examplego++GIT_COMMIT := $(shell git rev-list -1 HEAD)+GIT_BRANCH := $(if $(shell echo $$BRANCH_NAME),$(shell echo $$BRANCH_NAME),$(shell git rev-parse --abbrev-ref HEAD))+VERSION := $(if $(shell echo $$VERSION),$(shell echo $$VERSION),"0.0.0-localdev-unset")+GOPATH := $(shell go env GOPATH)++install:+# The following command is needed to allow go get to clone from private bitbucket repos+	@ git config --global url."git@bitbucket.org:".insteadOf "https://bitbucket.org/"+	go mod download+	go mod tidy++assets:+	@ echo "Compiling assets"+	@ go get github.com/go-bindata/go-bindata/...+	@ $(GOPATH)/bin/go-bindata -o bind/assets.go -pkg bind assets/...+	@ go mod tidy++build/darwin-amd64/plugin:+	go build \+	     -ldflags "-X ${REPO}/controller/controller.GitBranch=${GIT_BRANCH} -X ${REPO}/sensor/sensor.GitCommit=${GIT_COMMIT} -X ${REPO}/sensor/sensor.Version=${VERSION}" \+	     -o build/darwin-amd64/plugin ./++build/windows-amd64/plugin:+	GOOS=windows go build  \+	     -ldflags "-X ${REPO}/controller/controller.GitBranch=${GIT_BRANCH} -X ${REPO}/sensor/sensor.GitCommit=${GIT_COMMIT} -X ${REPO}/sensor/sensor.Version=${VERSION}" \+	     -o build/windows-amd64/plugin.exe ./++clean:+	rm -rf ./build++build: clean build/darwin-amd64/plugin build/windows-amd64/plugin++deploy-local: build

Maybe deploy-local is the wrong word. We end up doing this constantly when we develop locally to get the plugin into sidekick. This may have already changed and I'm not aware? Mostly, I'm looking to make the step easy to remember when I come back to the project and can't remember what to do to use it locally as I make local changes. Thoughts?

corylanou

comment created time in a month

PullRequestReviewEvent

PR opened open-olive/loop-development-kit-go

RDE-431 Loop Upgrade - Add Keyboard/Clipboard Functionality back in
  • Get clipboard working with stream
  • Get keyboard working with stream
  • Add example packages
  • Add ldktest package for testing loops.
+1765 -10

0 comment

34 changed files

pr created time in a month

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 12dd314f10bf296d0bc260dceb69f8f4dfcbc9bb

remove commented out code

view details

push time in a month

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 7d0f6a769b5a5b61dddff99f8bdcac61c3ecebe4

add ldktest package, refactor examples to use ldktest

view details

push time in a month

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha fb985f2c4ea572ce5869a033576db6ac08eff6a8

remove nested golagnci lint configs

view details

push time in a month

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 76450227b6ef09cb553899d9f45ab1839be08ec3

fix lint errors

view details

push time in a month

create barnchopen-olive/loop-development-kit-go

branch : RDE-431-keyboard

created branch time in a month

push eventopen-olive/sidekick-controller-examplego

Cory LaNou

commit sha 686f99358cf8ef11172a5dd7bd679c9940a63151

update for latest clipboard service

view details

push time in a month

push eventopen-olive/loop-development-kit-go

BillyMurrayOlive

commit sha a041095a1179b24e2fdea286735e7d6dbb4967ae

Merge pull request #20 from open-olive/feature/RDE-431-loop-upgrade Feature/rde 431 loop upgrade

view details

Cory LaNou

commit sha 9c148061a9e80e389a605442a22c671815d51d17

SIDE-566 - add ci scripts

view details

Cory LaNou

commit sha fbcc9c0753e266f51b8eda1a6d3367a0bdb29491

Merge pull request #21 from open-olive/SIDE-566-ci-scripts SIDE-566 - add ci scripts

view details

Billy Murray

commit sha b92d46bcf7830d6e526d03e636c62907e3c9a2ba

WIP storage and whisper services

view details

Billy Murray

commit sha 4f4f4fcc532b17149339c701d886a3b04fdb8d59

Reran protoc

view details

Billy Murray

commit sha 4e6a786f75e2f449795db0109cae0b812e716e37

WIP fixed all outstanding linter errors

view details

Billy Murray

commit sha 6b0d7cae2a5ec7cd14b32b659f84eece65e63547

Fixed comment issues

view details

Billy Murray

commit sha 689fb9535d9fefa6018799c4be3cf4010b5abb1f

Remove passing metadata and storage documentation into grpc server

view details

Billy Murray

commit sha 563589113af60b824822df2738c1f70896b65ed7

Removed category

view details

Billy Murray

commit sha fc6793ebb3f1acabb04ee7ea9335db3ca7cb0ee5

Fixed not passing whisper brokerID to loop server

view details

Billy Murray

commit sha 0da257dd194d83b4b374634d33af6ba711deba55

Simplified whisper to whisperMsg

view details

Billy Murray

commit sha 14c82d20b260c5afdfc1eeb43d9a207132515b7a

First pass at clipboard service

view details

Billy Murray

commit sha 3213997fb14edc0bc72c9e689bcbc2d0ca9b87cb

WIP adding clipboard service

view details

Cory LaNou

commit sha 896fb20e9792d595e10f79bcb64f0b621ae79858

wip clipboard sensor loop

view details

Billy Murray

commit sha 87acd22c90924451bea218d24343d7ebe5e62347

Added ClipboardReadStream to server

view details

Billy Murray

commit sha 4e7c482a29bcdf1cf7eb49f6b281925576182b0f

Finished adding clipboard service

view details

Billy Murray

commit sha cca5b4fa03b4c9e4b3b331d5df4017ee5a7f2296

Cancel the context in the go routine

view details

Billy Murray

commit sha e7de8a11746c23aba8b0939963073e6ed09d2070

Added logs to track flow in clipboard client

view details

Billy Murray

commit sha 4ea5ac59302a7db6cb0c000d332712d05461290a

Removed errors from ClipboardReadStreamCallback

view details

Cory LaNou

commit sha 9ad72eb9e8766d6fae9764dd9f59f2ae7f19ae25

wip plumb back in error for clipboard callback

view details

push time in a month

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 035d4a3d4f109f764919bfcc3d1c34ab4b107b75

SIDE-566 - add ci scripts

view details

Cory LaNou

commit sha 5ae33fd32c2a0288fdc9186d4b3d1a8bdbe23760

fix bad merge

view details

Cory LaNou

commit sha f5fe9d3b5204d65d3062e9f48e32026326a1e41a

fix misleading test success

view details

Cory LaNou

commit sha 0cb16f7a24a0bc54f37100b3ea308857a798fa1b

fix lint issues

view details

push time in a month

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 2468f64d95c6807154077f20b1776f61620cd180

work out hot key use cases

view details

push time in a month

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 9c148061a9e80e389a605442a22c671815d51d17

SIDE-566 - add ci scripts

view details

Cory LaNou

commit sha fbcc9c0753e266f51b8eda1a6d3367a0bdb29491

Merge pull request #21 from open-olive/SIDE-566-ci-scripts SIDE-566 - add ci scripts

view details

push time in a month

delete branch open-olive/loop-development-kit-go

delete branch : SIDE-566-ci-scripts

delete time in a month

PR merged open-olive/loop-development-kit-go

Reviewers
SIDE-566 - add ci scripts
  • test
  • test race
  • golangci
  • reorg/update Makefile
+190 -31

0 comment

13 changed files

corylanou

pr closed time in a month

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 9c148061a9e80e389a605442a22c671815d51d17

SIDE-566 - add ci scripts

view details

push time in a month

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 62657a479337655bc755db8fc1973881166e5d2f

add context to service signatures. renaming things

view details

push time in a month

Pull request review commentopen-olive/loop-development-kit-go

SIDE-566 - add ci scripts

+on: [push, pull_request]+name: Test

No, but the first name in the config should be Test Race. Good catch. Updated. Thanks.

corylanou

comment created time in a month

PullRequestReviewEvent

Pull request review commentopen-olive/loop-development-kit-go

SIDE-566 - add ci scripts

+on: [push, pull_request]+name: Test+jobs:+  test:+    strategy:+      matrix:+        go-version: [1.14.x, 1.15.x]+        os: [macos-latest, windows-latest]+    runs-on: ${{ matrix.os }}+    steps:+    - name: Install Go+      uses: actions/setup-go@v2+      with:+        go-version: ${{ matrix.go-version }}+    - name: Checkout code+      uses: actions/checkout@v2+    - name: Test+      run: go test -v ./...

Huh, it works on GH. Nice. Updated.

corylanou

comment created time in a month

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 54f3338f132273a5fa7be70279fa8cbb2cdd837a

does make work on windows GH build?

view details

push time in a month

Pull request review commentopen-olive/loop-development-kit-go

SIDE-566 - add ci scripts

+on: [push, pull_request]+name: Test+jobs:+  test:+    strategy:+      matrix:+        go-version: [1.14.x, 1.15.x]+        os: [macos-latest, windows-latest]+    runs-on: ${{ matrix.os }}+    steps:+    - name: Install Go+      uses: actions/setup-go@v2+      with:+        go-version: ${{ matrix.go-version }}+    - name: Checkout code+      uses: actions/checkout@v2+    - name: Test+      run: go test -v ./...

I don't think that work son the windows builds then because on GH windows doesn't have make, but I haven't verified. I can try it to see what happens. I agree it would be nice to use the make commands here instead.

corylanou

comment created time in a month

PullRequestReviewEvent

Pull request review commentopen-olive/loop-development-kit-go

SIDE-566 - add ci scripts

+name: golangci-lint+on:+  push:+    tags:+      - v*+    branches:+      - master+  pull_request:+jobs:+  golangci:+    strategy:+      matrix:+        go-version: [1.15.x]+        os: [macos-latest, windows-latest]

This is future proofing for when we do, but yes, in theory, we don't need it now. For me, it's free, and quick on GH (not like travis), so I felt it didn't hurt to have it. I can go either way on this.

corylanou

comment created time in a month

PullRequestReviewEvent

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 7e70d518a63537c0adcd997226bf0fb03089609f

use lastest version of golangci-lint

view details

push time in a month

Pull request review commentopen-olive/loop-development-kit-go

SIDE-566 - add ci scripts

 module github.com/open-olive/loop-development-kit-go go 1.14  require (

This was the result of running go mod tidy. Not sure why it was so out of date. In theory, I could probably check it in without updating go.mod, but that feels wrong too... I generally hate that go.mod can cause this type of code churn without any good reason...

corylanou

comment created time in a month

PullRequestReviewEvent

PR opened open-olive/loop-development-kit-go

SIDE-566 - add ci scripts
  • test
  • test race
  • golangci
  • reorg/update Makefile
+190 -31

0 comment

13 changed files

pr created time in a month

create barnchopen-olive/loop-development-kit-go

branch : SIDE-566-ci-scripts

created branch time in a month

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha fff8dce459e949eee0917c810c04b743d83c1b04

wip - added keyboard service/server/client. some clipboard cleanup

view details

push time in a month

PullRequestReviewEvent

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha 2fa0bf938aa53932185ba791864e440eddb668fb

make sure you have err is not nil before callign a method

view details

push time in a month

push eventopen-olive/sidekick-controller-examplego

Cory LaNou

commit sha 7cc2eac5b00a57809895d104bc859faa061327f3

wip plumb in error for clipboard callback

view details

push time in a month

push eventopen-olive/loop-development-kit-go

Cory LaNou

commit sha d5ed5386096ab3288c7f33a711877cb6c49434af

wip plumb back in error for clipboard callback

view details

push time in a month

push eventopen-olive/sidekick-controller-examplego

Cory LaNou

commit sha 5672edb612558bc7634b0f4e38db8d780d3f0466

get tests working

view details

Cory LaNou

commit sha 8c648b7cc8ea060c35058a8f61b0b4611842222c

Merge branch 'feature/RDE-431-loop-upgrade' of github.com:open-olive/sidekick-controller-examplego into feature/RDE-431-loop-upgrade

view details

Cory LaNou

commit sha 87d3a8318bcf3b844319eb24ab20f4e975b6b29d

tests are working.. again

view details

push time in a month

more