profile
viewpoint
Cornelius Weig corneliusweig @Google Munich

GoogleContainerTools/skaffold 10594

Easy and Repeatable Kubernetes Development

corneliusweig/rakkess 677

Review Access - kubectl plugin to show an access matrix for k8s server resources

corneliusweig/ketall 192

Like `kubectl get all`, but get really all resources

corneliusweig/kubernetes-lxd 145

A step-by-step guide to get kubernetes running inside an LXC container

corneliusweig/konfig 63

konfig helps to merge, split or import kubeconfig files

corneliusweig/skaffold-create-react-app 6

Showcase for Skaffold with create-react-app

corneliusweig/krew-index-tracker 1

Saves download statistics of `krew.dev` plugins to BigQuery

corneliusweig/kubectx 1

Switch faster between clusters and namespaces in kubectl

corneliusweig/release-notes 1

Generates release notes from merged pull request since last release

corneliusweig/berglas 0

A tool for managing secrets on Google Cloud

created repositoryluksa/luksa.github.io

created time in 8 hours

pull request commentkubernetes-sigs/krew

Add documentation for default index URI variable

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/krew/pull/669#" title="Author self-approved">chriskim06</a> To complete the pull request process, please assign corneliusweig after the PR has been reviewed. You can assign the PR to them by writing /assign @corneliusweig in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["corneliusweig"]} -->

chriskim06

comment created time in 14 hours

PR opened kubernetes-sigs/krew

Add documentation for default index URI variable

So I wasn't super sure where this should go. After looking around I was thinking about either adding it as a separate page under the setup/ tree or consolidating this with the update check doc. I landed on consolidating the two but let me know what you guys think.

Fixes #637

/assign @ahmetb /assign @corneliusweig <!-- For proposed features, make sure there's an issue it's discussed first -->

+38 -19

0 comment

2 changed files

pr created time in 14 hours

push eventinspirer/textmapper

Evgeny Gryaznov

commit sha e2b9892352c19e9ee4202dc54f530d1aee745e6e

Update IJ project files.

view details

Evgeny Gryaznov

commit sha 3afe670a44bcb63264169b1b113cd01aee5af99b

Add a way to report extra flags in addition to the node type.

view details

push time in 16 hours

PR closed google/eng-practices

Update looking-for.md

I found this https://google.github.io/eng-practices/review/reviewer/looking-for.html and was confused about what CL stood for.

+1 -1

3 comments

1 changed file

oscarmandley

pr closed time in 18 hours

pull request commentgoogle/eng-practices

Update looking-for.md

Hi, thanks for the PR. We're planning to address the widespread use of "CL" within the content with a fix to issue #22, which will involve a tooling fix on our side. (Apologies for the slow movement on the issue; 2020 has been...something.)

oscarmandley

comment created time in 18 hours

pull request commentkubernetes-sigs/krew-index

Add kubectl-env plugin

Please read the naming guide. This plug-in doesn't do what I would expect it to do despite the name "env". That's a sign you've chosen a generic yet vague name. Please consider renaming. /hold

almariah

comment created time in a day

pull request commentgoogle/eng-practices

Update looking-for.md

@googlebot I signed it!

oscarmandley

comment created time in a day

pull request commentgoogle/eng-practices

Update looking-for.md

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

<!-- need_sender_cla -->

oscarmandley

comment created time in a day

PR opened google/eng-practices

Update looking-for.md

I found this https://google.github.io/eng-practices/review/reviewer/looking-for.html and was confused about what CL stood for.

+1 -1

0 comment

1 changed file

pr created time in a day

fork leewalter/ketall

Like `kubectl get all`, but get really all resources

fork in a day

pull request commentkubernetes-sigs/krew-index

Add kubectl-env plugin

/assign @corneliusweig

almariah

comment created time in 2 days

pull request commentkubernetes-sigs/krew-index

Add kubectl-env plugin

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/krew-index/pull/937#" title="Author self-approved">almariah</a> To complete the pull request process, please assign corneliusweig after the PR has been reviewed. You can assign the PR to them by writing /assign @corneliusweig in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["corneliusweig"]} -->

almariah

comment created time in 2 days

pull request commentkubernetes-sigs/krew-index

Add kubectl-env plugin

Welcome @almariah! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes-sigs/krew-index'>kubernetes-sigs/krew-index</a> 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation. <br><br>You can also check if kubernetes-sigs/krew-index has its own contribution guidelines. <br><br>You may want to refer to our testing guide if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:

almariah

comment created time in 2 days

PR opened kubernetes-sigs/krew-index

Add kubectl-env plugin

Add kubectl-env plugin

https://github.com/almariah/kubectl-env

+32 -0

0 comment

1 changed file

pr created time in 2 days

issue commentkubernetes-sigs/krew

Consider add Go Vet tool in the CI

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

Dentrax

comment created time in 2 days

startedcorneliusweig/kubernetes-lxd

started time in 2 days

startedfransking/flink-statefun-tasks

started time in 2 days

startedcorneliusweig/kubernetes-lxd

started time in 3 days

startedjoe-elliott/cert-exporter

started time in 3 days

push eventkubernetes-sigs/krew-index

Andrew Lavery

commit sha d938e1d3c6d9996dc52201c2f1a8302daf904d93

schemahero v0.11.3 (#936) Signed-off-by: Andrew Lavery <laverya@umich.edu>

view details

push time in 3 days

PR merged kubernetes-sigs/krew-index

Reviewers
schemahero v0.11.3 approved cncf-cla: yes lgtm size/S

<!--

PLUGIN DEVELOPERS: If you are submitting a new plugin

  • Make sure you read the Plugin Naming Guide: https://krew.sigs.k8s.io/docs/developer-guide/develop/naming-guide/
  • Verify you can install your plugin locally: kubectl krew install --manifest=[...] --archive=[...]

--> Yes, I will be moving to the krew releaser bot soon.

+7 -7

2 comments

1 changed file

laverya

pr closed time in 3 days

pull request commentkubernetes-sigs/krew-index

schemahero v0.11.3

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/krew-index/pull/936#issuecomment-733968366" title="Approved">ahmetb</a>, <a href="https://github.com/kubernetes-sigs/krew-index/pull/936#" title="Author self-approved">laverya</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

laverya

comment created time in 3 days

pull request commentkubernetes-sigs/krew-index

schemahero v0.11.3

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

laverya

comment created time in 3 days

PR opened kubernetes-sigs/krew-index

schemahero v0.11.3

<!--

PLUGIN DEVELOPERS: If you are submitting a new plugin

  • Make sure you read the Plugin Naming Guide: https://krew.sigs.k8s.io/docs/developer-guide/develop/naming-guide/
  • Verify you can install your plugin locally: kubectl krew install --manifest=[...] --archive=[...]

--> Yes, I will be moving to the krew releaser bot soon.

+7 -7

0 comment

1 changed file

pr created time in 3 days

startedchromedp/docker-headless-shell

started time in 3 days

push eventkubernetes-sigs/krew

Chris Kim

commit sha 9749c9e021e4c28342eae1dd28de7fd63269a426

Default index function (#668) * Add function for getting default index URI * Add variable in update command * Update pkg/index/util.go Co-authored-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com> * Add simple unit test for DefaultIndex function * Code review change Co-authored-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>

view details

push time in 3 days

PR merged kubernetes-sigs/krew

Default index function approved cncf-cla: yes lgtm size/M

Adding this based on the comment here https://github.com/kubernetes-sigs/krew/pull/666#discussion_r528472892. This reverts back constants.go so that it only has the constant values and adds a pkg/index/util.go that has the DefaultIndex function in it.

/assign @ahmetb /assign @corneliusweig

Related issue: #637 <!-- For proposed features, make sure there's an issue it's discussed first -->

+72 -17

5 comments

5 changed files

chriskim06

pr closed time in 3 days

pull request commentkubernetes-sigs/krew

Default index function

Ya I'd like to do them in a separate PR, I'll be able to submit that PR this weekend.

/hold cancel

chriskim06

comment created time in 3 days

more