profile
viewpoint

apple/swift 54871

The Swift Programming Language

apple/swift-evolution 11802

This maintains proposals for changes and user-visible enhancements to the Swift Programming Language.

apple/swift-package-manager 8136

The Package Manager for the Swift Programming Language

apple/swift-corelibs-foundation 4107

The Foundation Project, providing core utilities, internationalization, and OS independence

apple/swift-corelibs-libdispatch 1962

The libdispatch Project, (a.k.a. Grand Central Dispatch), for concurrency on multicore hardware

apple/swift-corelibs-xctest 872

The XCTest Project, A Swift core library for providing unit test support

apple/swift-llbuild 822

A low-level build system, used by Xcode and the Swift Package Manager

apple/swift-system 793

Swift System provides idiomatic interfaces to system calls and low-level currency types.

push eventllvm/llvm-project

zhanghb97

commit sha a2914e0c158cc7f72cd08c92274a315dd640e073

[mlir][Python] Fix comments of 'getCapsule' and 'createFromCapsule' The `getCapsule` and `createFromCapsule` comments incorrectly state the `PyMlirContext` and `MlirContext` in `PyLocation`, `PyAttribute`, and `PyType` classes. Differential Revision: https://reviews.llvm.org/D95413

view details

push time in a few seconds

push eventllvm/llvm-project

zhanghb97

commit sha a2914e0c158cc7f72cd08c92274a315dd640e073

[mlir][Python] Fix comments of 'getCapsule' and 'createFromCapsule' The `getCapsule` and `createFromCapsule` comments incorrectly state the `PyMlirContext` and `MlirContext` in `PyLocation`, `PyAttribute`, and `PyType` classes. Differential Revision: https://reviews.llvm.org/D95413

view details

push time in 4 minutes

push eventapple/swift

Slava Pestov

commit sha 5b64ef81840eb8b6ffd768d412ac442bf5d1c514

Sema: Remove a bit of dead code in DerivedConformanceDifferentiable.cpp

view details

Slava Pestov

commit sha f55f290a47f3be25f02521aaaeea4dbe258541ad

Merge pull request #35594 from slavapestov/squash-dead-code-warning Sema: Remove a bit of dead code in DerivedConformanceDifferentiable.cpp

view details

swift-ci

commit sha aa4df86c7cc8fa77ea5b50312e09f4e00d0d5de2

Merge remote-tracking branch 'origin/main' into rebranch

view details

push time in 12 minutes

push eventapple/swift

Slava Pestov

commit sha 5b64ef81840eb8b6ffd768d412ac442bf5d1c514

Sema: Remove a bit of dead code in DerivedConformanceDifferentiable.cpp

view details

Slava Pestov

commit sha f55f290a47f3be25f02521aaaeea4dbe258541ad

Merge pull request #35594 from slavapestov/squash-dead-code-warning Sema: Remove a bit of dead code in DerivedConformanceDifferentiable.cpp

view details

push time in 14 minutes

pull request commentapple/swift

Fix SILInstruction::mayRelease to handle unmanaged_release_value.

@swift-ci test

atrick

comment created time in 14 minutes

PR opened apple/swift

Reviewers
Fix SILInstruction::mayRelease to handle unmanaged_release_value.

Apparently this API was never called from any OSSA passes.

Fixes rdar://73507733 ([SR-14090]: [Source Compat] swift-futures 5.1 fails to build from main branch)

+31 -0

0 comment

2 changed files

pr created time in 15 minutes

push eventllvm/llvm-project

Johannes Doerfert

commit sha 8c7fdc4c61bff94a3ac1bb4877d1c00e01ee53be

[OpenMP] Add source location information to the libomptarget profile In much of the libomptarget interface we have an ident_t object now, if it is not null we can use it to improve the profile output. For now, we simply use the ident_t "source information string" as generated by the FE. Reviewed By: tianshilei1992 Differential Revision: https://reviews.llvm.org/D95282

view details

push time in 16 minutes

push eventllvm/llvm-project

Johannes Doerfert

commit sha bd756286d2e774716a12f55db27d070595058d53

[OpenMP][FIX] Enforce a function boundary for a new data environment Whenever we enter a new OpenMP data environment we want to enter a function to simplify reasoning. Later we probably want to remove the entire specialization wrt. the if clause and pass the result to the runtime, for now this should fix PR48686. Reviewed By: ABataev Differential Revision: https://reviews.llvm.org/D94315

view details

push time in 17 minutes

pull request commentllvm/mlir-npcomp

Enable building using LLVM_EXTERNAL_PROJECTS.

Sounds good to me. Other than the GitHub checks and using external builds locally, is there anything else I can test before I land these changes?

mikeurbach

comment created time in 18 minutes

push eventllvm/llvm-project

Johannes Doerfert

commit sha 8c7fdc4c61bff94a3ac1bb4877d1c00e01ee53be

[OpenMP] Add source location information to the libomptarget profile In much of the libomptarget interface we have an ident_t object now, if it is not null we can use it to improve the profile output. For now, we simply use the ident_t "source information string" as generated by the FE. Reviewed By: tianshilei1992 Differential Revision: https://reviews.llvm.org/D95282

view details

push time in 21 minutes

push eventllvm/llvm-project

Johannes Doerfert

commit sha bd756286d2e774716a12f55db27d070595058d53

[OpenMP][FIX] Enforce a function boundary for a new data environment Whenever we enter a new OpenMP data environment we want to enter a function to simplify reasoning. Later we probably want to remove the entire specialization wrt. the if clause and pass the result to the runtime, for now this should fix PR48686. Reviewed By: ABataev Differential Revision: https://reviews.llvm.org/D94315

view details

push time in 21 minutes

pull request commentllvm/mlir-npcomp

Enable building using LLVM_EXTERNAL_PROJECTS.

Wow @stellaraccident you reviewed faster than I could request it. I do wonder if there may be some CMake incantation to handle the layering under 'tools' differently. If you are OK with this as-is, I will leave that to future spelunking.

Caught me at an opportune time :)

If it works, let's commit as-is. Incremental CMake work is the name of the game... we can shift things later with smaller changes once we figure out how to do them.

mikeurbach

comment created time in 23 minutes

pull request commentllvm/mlir-npcomp

Enable building using LLVM_EXTERNAL_PROJECTS.

Wow @stellaraccident you reviewed faster than I could request it. I do wonder if there may be some CMake incantation to handle the layering under 'tools' differently. If you are OK with this as-is, I will leave that to future spelunking.

mikeurbach

comment created time in 26 minutes

Pull request review commentllvm/mlir-npcomp

Enable building using LLVM_EXTERNAL_PROJECTS.

 set(LLVM_TARGET_DEFINITIONS Passes.td) mlir_tablegen(Passes.h.inc -gen-pass-decls ${NPCOMP_TABLEGEN_ARGS}) add_public_tablegen_target(NPCOMPConversionPassIncGen) -add_mlir_doc(Passes -gen-pass-doc ConversionPasses ./)+add_mlir_doc(Passes -gen-pass-doc NPCOMPConversionPasses ./)

Thx. Copy-pasta from the beginning of the project.

mikeurbach

comment created time in 27 minutes

Pull request review commentllvm/mlir-npcomp

Enable building using LLVM_EXTERNAL_PROJECTS.

 import lit.llvm lit.llvm.initialize(lit_config, config)  # Let the main config do the real work.-lit_config.load_config(config, "@CMAKE_SOURCE_DIR@/frontends/pytorch/test/lit.cfg.py")+lit_config.load_config(config, "@CMAKE_CURRENT_SOURCE_DIR@/lit.cfg.py")

I'm ok with it if it works. Can't think of anything better without fiddling with it.

mikeurbach

comment created time in 27 minutes

Pull request review commentllvm/mlir-npcomp

Enable building using LLVM_EXTERNAL_PROJECTS.

 config.npcomp_tools_dir = os.path.join(config.npcomp_obj_root, 'bin')  # Tweak the PATH to include the tools dir.+npcomp_python_dir = "python" if config.npcomp_built_standalone else "tools/npcomp/python"

Let's land it in a working state how you have it. Then I/someone can try to find a more targeted place to put it. I'd hope we can just emit all of the python artifacts into the top level build/python directory: even across projects, they form a namespace that must not overlap, so having everything write to that directory is ok (CMake will complain if two projects then try to write the same thing into the python namespace).

mikeurbach

comment created time in 28 minutes

Pull request review commentllvm/mlir-npcomp

Enable building using LLVM_EXTERNAL_PROJECTS.

 set(MLIR_NPCOMP_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) set(MLIR_NPCOMP_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})  add_custom_target(check-npcomp)-add_custom_target(check-all)-add_dependencies(check-all check-npcomp)+add_custom_target(check-npcomp-all)

sgtm

mikeurbach

comment created time in 30 minutes

pull request commentapple/swift

[SILGen] Enable alternative entry point name.

@swift-ci please asan test

nate-chandler

comment created time in 32 minutes

pull request commentapple/swift

[SILGen] Enable alternative entry point name.

@swift-ci please clean test

nate-chandler

comment created time in 32 minutes

Pull request review commentllvm/mlir-npcomp

Enable building using LLVM_EXTERNAL_PROJECTS.

 set(LLVM_TARGET_DEFINITIONS Passes.td) mlir_tablegen(Passes.h.inc -gen-pass-decls ${NPCOMP_TABLEGEN_ARGS}) add_public_tablegen_target(NPCOMPConversionPassIncGen) -add_mlir_doc(Passes -gen-pass-doc ConversionPasses ./)+add_mlir_doc(Passes -gen-pass-doc NPCOMPConversionPasses ./)

This was conflicting with the MLIR ConversionPasses name.

mikeurbach

comment created time in 39 minutes

Pull request review commentllvm/mlir-npcomp

Enable building using LLVM_EXTERNAL_PROJECTS.

 import lit.llvm lit.llvm.initialize(lit_config, config)  # Let the main config do the real work.-lit_config.load_config(config, "@CMAKE_SOURCE_DIR@/frontends/pytorch/test/lit.cfg.py")+lit_config.load_config(config, "@CMAKE_CURRENT_SOURCE_DIR@/lit.cfg.py")

I think this change is a safe way to make this path agnostic to CMAKE_SOURCE_DIR, which can be different for an external build. It works on my computer and the GitHub check, but please correct me if I'm wrong.

mikeurbach

comment created time in 40 minutes

Pull request review commentllvm/mlir-npcomp

Enable building using LLVM_EXTERNAL_PROJECTS.

 config.npcomp_tools_dir = os.path.join(config.npcomp_obj_root, 'bin')  # Tweak the PATH to include the tools dir.+npcomp_python_dir = "python" if config.npcomp_built_standalone else "tools/npcomp/python"

I found that the npcomp python artifacts were placed under tools/npcomp/python when doing an external build. A couple things about this: 1) I'm not sure if there is a better way to use CMake to put the python just in build/python when doing an external build, 2) I think the npcomp in the tools/npcomp/python path comes from the name passed to the LLVM_EXTERNAL_PROJECTS flag, so this may not be guaranteed to match for everyone's setup. I have a feeling there is a better way to achieve this line of python with CMake, but I haven't figured it out yet.

mikeurbach

comment created time in 41 minutes

Pull request review commentllvm/mlir-npcomp

Enable building using LLVM_EXTERNAL_PROJECTS.

 set(MLIR_NPCOMP_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) set(MLIR_NPCOMP_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})  add_custom_target(check-npcomp)-add_custom_target(check-all)-add_dependencies(check-all check-npcomp)+add_custom_target(check-npcomp-all)

The check-all target seemed to conflict with the MLIR one. I added this npcomp namespacing, but I'm not sure if there is a better way.

mikeurbach

comment created time in an hour

Pull request review commentllvm/mlir-npcomp

Enable building using LLVM_EXTERNAL_PROJECTS.

 config.npcomp_tools_dir = os.path.join(config.npcomp_obj_root, 'bin')  # Tweak the PATH to include the tools dir.+npcomp_python_dir = "python" if config.npcomp_built_standalone else "tools/npcomp/python"

Side comment (nothing to do about it here): I find this layering of such projects under 'tools' to be really annoying but haven't taken the time to see what would need to be done to pop it up a level.

mikeurbach

comment created time in 37 minutes

PR opened llvm/mlir-npcomp

Enable building using LLVM_EXTERNAL_PROJECTS.

This allows building NPCOMP as an external project of LLVM, similar to how CIRCT can be built: https://github.com/llvm/circt/pull/227.

The CMake options to use this build style look like this:

  -DLLVM_EXTERNAL_PROJECTS=npcomp \
  -DLLVM_EXTERNAL_NPCOMP_SOURCE_DIR=/path/to/mlir-npcomp \
+64 -39

0 comment

7 changed files

pr created time in an hour

push eventapple/swift

Saleem Abdulrasool

commit sha 4f740a4784586484bf16fc69c1d742daa71520f6

Concurrency: support draining the main queue in single threaded mode When built in single threaded mode, the runtime does not use dispatch to queue the tasks. As a result, pumping the dispatch main queue will simply wait indefinitely. In the single threaded mode, simply halt execution and drain all pending tasks before returning. This allows forward progress in the single threaded mode.

view details

Saleem Abdulrasool

commit sha 62f90501580f2aede9260b93c4bb41d0ffa08955

Merge pull request #35584 from compnerd/single-threaded-drain Concurrency: support draining the main queue in single threaded mode

view details

swift-ci

commit sha 321b08a64fb40dea589170c03098c829a60cba4d

Merge remote-tracking branch 'origin/main' into rebranch

view details

push time in an hour

push eventllvm/llvm-project

Hsiangkai Wang

commit sha b69932b550acf565e11c9d4effae24a444ad7ca5

[RISCV] Implement vlsegff intrinsics. Differential Revision: https://reviews.llvm.org/D95303

view details

Hsiangkai Wang

commit sha f19849a07b6728a5100dde3baf8c2bd3bb5e0d6e

[RISCV] Update V extension to v1.0-draft 08a0b464. Differential Revision: https://reviews.llvm.org/D94583

view details

push time in an hour

push eventllvm/llvm-project

Hsiangkai Wang

commit sha b69932b550acf565e11c9d4effae24a444ad7ca5

[RISCV] Implement vlsegff intrinsics. Differential Revision: https://reviews.llvm.org/D95303

view details

Hsiangkai Wang

commit sha f19849a07b6728a5100dde3baf8c2bd3bb5e0d6e

[RISCV] Update V extension to v1.0-draft 08a0b464. Differential Revision: https://reviews.llvm.org/D94583

view details

push time in an hour

pull request commentapple/swift

[SILGen] Enable alternative entry point name.

Build failed Swift Test Linux Platform Git Sha - e552c1521f325208bbe45803068e5e80394539e1

nate-chandler

comment created time in an hour

more