apple/swift 53897
The Swift Programming Language
apple/swift-evolution 11546
This maintains proposals for changes and user-visible enhancements to the Swift Programming Language.
apple/swift-package-manager 8005
The Package Manager for the Swift Programming Language
apple/swift-corelibs-foundation 4029
The Foundation Project, providing core utilities, internationalization, and OS independence
apple/swift-corelibs-libdispatch 1894
The libdispatch Project, (a.k.a. Grand Central Dispatch), for concurrency on multicore hardware
apple/swift-corelibs-xctest 862
The XCTest Project, A Swift core library for providing unit test support
apple/swift-llvm 802
A low-level build system, used by Xcode and the Swift Package Manager
apple/swift-lldb 645
This is the version of LLDB that supports the Swift programming language & REPL.
push eventapple/swift-corelibs-foundation
commit sha e50b83b1a3349aa8ebcc9cd20a598258bdbbad1b
[FileManager] _attributesOfItem: use creationDate from the stat extension in NSURL rather than repeating that logic The last case in stat.creationDate also works for Android.
commit sha ff29c5b355efdc908f3f89658c68826ffd644b02
Merge pull request #2905 from buttaface/create [FileManager] _attributesOfItem: use creationDate from the stat extension in NSURL
push time in 2 hours
PR merged apple/swift-corelibs-foundation
rather than repeating that logic
The last case in stat.creationDate also works for Android.
Note that it uses st_birthtimespec instead on Darwin, let me know if that makes a difference. @compnerd, this pull redoes #2884 because it didn't work on Android and to reuse the existing logic, let me know what you think.
pr closed time in 2 hours
pull request commentapple/swift-corelibs-foundation
[FileManager] _attributesOfItem: use creationDate from the stat extension in NSURL
Thanks for the cleanup @buttaface!
comment created time in 2 hours
pull request commentapple/swift-corelibs-foundation
[FileManager] _attributesOfItem: use creationDate from the stat extension in NSURL
I was more worried about the property not existing and this failing to build. Seems that the property is present. LGTM.
comment created time in 2 hours
push eventcompnerd/swift-devenv
commit sha 62a0ed0860d7e2da8f5c052c2bbda982d0586ecb
workflows: use modern commands for environment changes
push time in 2 hours
PR merged compnerd/swift-devenv
echo "::set-env ... style commands are deprecated now. GitHub encourages users to migrate to Environment Files as they are more secure.
This upgrades env and path setup to use environment files. Should fix warnings in workflows.
pr closed time in 2 hours
pull request commentcompnerd/swift-devenv
workflows: use modern commands for environment changes
Thanks @lxbndr! I didn't know about that functionality.
comment created time in 2 hours
pull request commentcompnerd/swift-devenv
workflows: split the CI and CD aspects
Yeah, I set to the draft mode so that I can adjust the description with changes before the release is made public. Is there a way to create a commit message with the release that has the highlights of the release? Perhaps having a CHANGELOG.txt and building it from that?
comment created time in 2 hours
PR merged compnerd/swift-win32
Rather than making Button equatable, make all views equatable by
making View equatable. This is safe to do as we check the underlying
hWnd as a means of checking equality.
pr closed time in 2 hours
push eventcompnerd/swift-win32
commit sha 794feebc4873bd4cbc33ce096df2911953deca41
UI: make `View` equatable Rather than making `Button` equatable, make all views equatable by making `View` equatable. This is safe to do as we check the underlying `hWnd` as a means of checking equality.
push time in 2 hours
pull request commentapple/swift-corelibs-foundation
[Windows] Fix thread local storage cleanup
Hmm, if the DLL_THREAD_DETACH is only doing this to handle the cleanup on the unload, we should remove it as the FLS will be sufficient for the cleanup.
comment created time in 12 hours
push eventapple/swift
commit sha a5034bc22bb825dad61fcd8d1b1a65f87f019bf0
Correct path in Windows build guide
commit sha bce662067adab5d4bb6083add7b91567a0f86415
Merge pull request #34355 from texasmichelle/windows_typo Correct a path in the Windows build instructions
push time in 12 hours
PR merged apple/swift
<!-- What's in this pull request? --> Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: --> Resolves SR-NNNN.
<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci
Thank you for your contribution to Swift! -->
pr closed time in 12 hours
PR opened compnerd/swift-win32
Rather than making Button equatable, make all views equatable by
making View equatable. This is safe to do as we check the underlying
hWnd as a means of checking equality.
pr created time in 14 hours
pull request commentapple/swift
Correct a path in the Windows build instructions
@swift-ci please smoke test
comment created time in 15 hours
pull request commentapple/swift-corelibs-foundation
[FileManager] _attributesOfItem: use creationDate from the stat extension in NSURL
Could you please ensure that this still works on Windows? If it does, LGTM.
comment created time in 15 hours
push eventapple/swift-corelibs-foundation
commit sha bd4051bee033c9e40f8f842da81997021a8ab005
Make mach_absolute_time implementation consistent with libdispatch
commit sha 2132247e1deb71a3d8f7d1bf73468e4061baa04d
Merge pull request #2907 from readdle/mach-absolute-time-win [Windows] Make mach_absolute_time implementation consistent with libdispatch
push time in 15 hours
PR merged apple/swift-corelibs-foundation
libdispatch uses QueryUnbiasedInterruptTimePrecise as base time source for timers. This changes CoreFoundation to use same source to schedule timers properly.
Current implementation is observed to work in most cases, because QueryPerformanceCounter could return same value as QueryUnbiasedInterruptTimePrecise. E.g. it provides reliable values on Windows VM hosted on my MacBook, as well as on cloud CI agents (GitHub Actions/Azure Pipelines). Perhaps virtualization affects the result. But on my Windows desktop these two sources return incomparably different values, making CFRunLoop unable to calculate correct timeout deadline.
The issue comes out as hang of TestNotificationQueue.test_postNowForDefaultRunLoopMode test. I also had similar problem with s-p-m, and this change fixes it as well.
pr closed time in 15 hours
push eventcompnerd/swift-devenv
commit sha eb81323cb537bf77d383d17743e863ebaaff85d8
Update release.yml Correct the version specifier for `upload-release-asset`.
push time in 15 hours
push eventcompnerd/swift-com
commit sha d7ba1be2cb6cf3db9cec314f1db571e466639591
SwiftCOM: shuffle files around (NFC) Rename COMCore to COMBase to mirror the Windows SDK. Move RawTyped.swift into Support as it is an internal supporting utility.
push time in 15 hours
PR merged compnerd/swift-com
Rename COMCore to COMBase to mirror the Windows SDK. Move RawTyped.swift into Support as it is an internal supporting utility.
pr closed time in 15 hours
PR opened compnerd/swift-com
Rename COMCore to COMBase to mirror the Windows SDK. Move RawTyped.swift into Support as it is an internal supporting utility.
pr created time in 16 hours
push eventcompnerd/swift-nio
commit sha fa03178ce46e4043634679fcd4626882b2329e23
NIO: implement `sendmsg` and `recvmsg` on Windows `WSASendMsg` and `WSARecvMsg` are not directly accessible to use. Instead, one must perform an IOCTL on the socket to retrieve the extension point and then use that function pointer to perform the operation. Use this to implement the functionality on Windows.
push time in 16 hours
pull request commentapple/swift-corelibs-foundation
[Windows] Make mach_absolute_time implementation consistent with libdispatch
@swift-ci please test
comment created time in 19 hours
pull request commentapple/swift-corelibs-foundation
[SR-13300] FileManager _updateTimes (microseconds)
Should probably run this on Windows as well to make sure that it doesn't cause a regression, I can kick off a test run once the CI here passes.
comment created time in 19 hours
pull request commentapple/swift-corelibs-foundation
[SR-13300] FileManager _updateTimes (microseconds)
@swift-ci please test
comment created time in 19 hours
pull request commentapple/swift-corelibs-foundation
[SR-13300] FileManager _updateTimes (microseconds)
@benrimmington thanks! I don't mind too much about the separation of the commits, and since the intermediate states in this case should be okay, I dont think that they really matter. The final result of this looks much better, thank you for the additional changes!
comment created time in 19 hours
pull request commentapple/swift-tools-support-core
Windows: replace `MSVCRT` with `CRT`
@abertelrud - once it is accepted, I think that I should be able to coordinate the changes in short order
comment created time in 21 hours
push eventcompnerd/swift-devenv
commit sha 5718a825ec39f01d2e835e2e71f6f0096049bf2c
workflows: split the CI and CD aspects Rather than use a single pipeline for both, split the two to enable building with optimizations when performing a release. Furthermore, trigger the job on a tag creation rather than commit message. Alter the implementation to use official GitHub action tasks as it already permits the operations.
push time in a day
PR merged compnerd/swift-devenv
Rather than use a single pipeline for both, split the two to enable building with optimizations when performing a release. Furthermore, trigger the job on a tag creation rather than commit message. Alter the implementation to use official GitHub action tasks as it already permits the operations.
pr closed time in a day
pull request commentcompnerd/swift-build
Sure, but this repository is primarily CI configuration - it isn't even a project that you would really build locally very much. So it seems very odd to me to have that exclusion in this project. For most projects, I agree, ignoring build directories is a good thing.
comment created time in a day
push eventcompnerd/swift-system
commit sha 734f1c25075cbdf740cfb31fbc021d24d3cfa7a2
Initial port to Windows This adds enough shims and tweaks the types sufficiently to allow building System on Windows.
push time in a day
Pull request review commentapple/swift-system
public struct Errno: RawRepresentable, Error, Hashable, Codable { public static var EBADMACHO: Errno { malformedMachO } #endif +#if os(Windows)+ /// Operation canceled.+ ///+ /// The scheduled operation was canceled.+ ///+ /// The corresponding C error is `ECANCELED`.+ @_alwaysEmitIntoClient+ public static var canceled: Errno { Errno(_ECANCELLED) }++ @_alwaysEmitIntoClient+ @available(*, unavailable, renamed: "canceled")+ public static var ECANCELLED: Errno { canceled }+#else
Thanks for catching that! That should have been canceled. It doesn't help that I have a tendency to spell it as "cancelled". I think it is more valuable to have the common spelling here rather than preserve the difference between the spelling that Windows adopts and Unix adopts.
comment created time in a day
Pull request review commentapple/swift-system
public var system_errno: CInt { #endif public func system_open(_ path: UnsafePointer<CChar>, _ oflag: Int32) -> CInt {+#if os(Windows)+ var fh: CInt = -1+ _ = _sopen_s(&fh, path, oflag, _SH_DENYNO, _S_IREAD | _S_IWRITE)+ return fh+#else open(path, oflag)+#endif } +#if os(Windows)+public func system_open(+ _ path: UnsafePointer<CChar>, _ oflag: Int32, _ mode: CInt+) -> CInt {
If we want to do that, I think that doing a follow up might be the best way forward.
comment created time in a day
push eventcompnerd/swift-nio
commit sha 70ca7aad2babaa810238151d836371679c4038b3
NIO: silence error on Windows (#1668) The `ignoreSIGPIPE` does nothing on Windows. However, add an overload to differentiate between a socket and file descriptor as they may be different. This is the case on Windows, where file descriptors are 32-bit but socket are 64-bit. fixup! e51406c61972420c43734b1d089712bc408e097b
commit sha d8c5a5ec84005d50339a604dc8e60f352a6c7b01
NIO: expose `LINGER` as a public type on Windows (#1675) The Windows `LINGER` type is meant to be exposed as it is a low-level system detail for `SocketChannelOptions`. See #1673 for relevant discussion. Co-authored-by: Cory Benfield <lukasa@apple.com>
commit sha 1cdbf763fb15cf2277fbf075dd475168270c7eb0
NIO: reflow some comments (NFC) (#1677)
commit sha 20e63d07dc1cc689aa671b3561b5954c974927ee
NIO: extract control message handling into a separate protocol (#1678) These are part of the BSD sockets APIs, but not directly related to the socket interfaces. Create an extension point to permit the different platforms to shuffle their implementation into place. This provides a nicer spelling for the functions and enables the codepaths on Windows as well.
commit sha 5b3ee8e1c92b3510b1032ae035bbaec5cb609b59
NIO: implement `sendmsg` and `recvmsg` on Windows `WSASendMsg` and `WSARecvMsg` are not directly accessible to use. Instead, one must perform an IOCTL on the socket to retrieve the extension point and then use that function pointer to perform the operation. Use this to implement the functionality on Windows.
commit sha 0bd4041044d04c5229b1e0448e2cf352359a362a
NIO: implement network interface enumeration for Windows Partially implement network interface enumeration. This is sufficient to build up the structures for basic operations. Although the interface information is incomplete, this provides enough structure to continue porting the rest of the NIO interfaces.
commit sha 32d0ade801343a0d0e9b8959dfe3c5eba54d006e
NIO: implement address resolution on Windows Windows has a slightly different API for address resolution. Implement the Windows path for addrinfo resolution.
commit sha a9a2af80c49e64c50dd5d9813fbb7f680ad5534e
WIP/DNM: windows support work (2020)
push time in a day
push eventcompnerd/swift-nio
commit sha 70ca7aad2babaa810238151d836371679c4038b3
NIO: silence error on Windows (#1668) The `ignoreSIGPIPE` does nothing on Windows. However, add an overload to differentiate between a socket and file descriptor as they may be different. This is the case on Windows, where file descriptors are 32-bit but socket are 64-bit. fixup! e51406c61972420c43734b1d089712bc408e097b
commit sha d8c5a5ec84005d50339a604dc8e60f352a6c7b01
NIO: expose `LINGER` as a public type on Windows (#1675) The Windows `LINGER` type is meant to be exposed as it is a low-level system detail for `SocketChannelOptions`. See #1673 for relevant discussion. Co-authored-by: Cory Benfield <lukasa@apple.com>
commit sha 1cdbf763fb15cf2277fbf075dd475168270c7eb0
NIO: reflow some comments (NFC) (#1677)
commit sha 20e63d07dc1cc689aa671b3561b5954c974927ee
NIO: extract control message handling into a separate protocol (#1678) These are part of the BSD sockets APIs, but not directly related to the socket interfaces. Create an extension point to permit the different platforms to shuffle their implementation into place. This provides a nicer spelling for the functions and enables the codepaths on Windows as well.
commit sha 5b3ee8e1c92b3510b1032ae035bbaec5cb609b59
NIO: implement `sendmsg` and `recvmsg` on Windows `WSASendMsg` and `WSARecvMsg` are not directly accessible to use. Instead, one must perform an IOCTL on the socket to retrieve the extension point and then use that function pointer to perform the operation. Use this to implement the functionality on Windows.
push time in a day
pull request commentapple/swift-corelibs-foundation
Foundation: migrate to the new `CRT` module
@swift-ci please test Linux platform
comment created time in a day
pull request commentapple/swift-corelibs-foundation
Foundation: migrate to the new `CRT` module
@swift-ci please clean test
comment created time in a day
pull request commentcompnerd/swift-build
I'm not convinced from the diff that this is useful. The downloaded file can end up anywhere. If you tend to download the installer into the current directory, you could always use core.excludesfile globally to augment the ignore list. Is there something that I'm missing?
comment created time in a day
push eventcompnerd/swift-build
commit sha 40b16a3dcfd6d6a3b649452411127512583156b2
Add quiet option
push time in a day
PR merged compnerd/swift-build
This allows this to be more easily used from a CI environment where the print just spits out 50k lines of download progress. The printing had to be moved to a separate function due to the lambda.
<!-- Reviewable:start -->
This change is <img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/> <!-- Reviewable:end -->
pr closed time in a day
pull request commentapple/swift-corelibs-foundation
Foundation: migrate to the new `CRT` module
@swift-ci please test Linux platform
comment created time in 2 days
push eventcompnerd/swift-win32
commit sha 9f8f4cdcfbbb60b36e4298d1f8f4641a7b73b1ac
UI: add `WindowSceneDelegate` This defines the `WindowSceneDelegate` protocol to enable the application to responding to the window scene.
push time in 2 days
PR merged compnerd/swift-win32
This defines the WindowSceneDelegate protocol to enable the
application to responding to the window scene.
pr closed time in 2 days
PR opened compnerd/swift-win32
This defines the WindowSceneDelegate protocol to enable the
application to responding to the window scene.
pr created time in 2 days
pull request commentcompnerd/swift-devenv
workflows: split the CI and CD aspects
CC: @sosan
Id like to get your opinion on this. Can you use this as the basis for something better? Or is there a reason to not trigger things this way instead?
comment created time in 2 days
pull request commentcompnerd/swift-devenv
Ah, I actually found that GitHub has something for this already? It showed how to trigger the task on the tag. I'm not very familiar with the GitHub Actions, so if you have a better way to do that than splitting it up into two different workflows, it would be great, but, seems like something like #8 might be a good thing to allow triggering the release only on tagging of a release rather than requiring a commit.
comment created time in 2 days
PR opened compnerd/swift-devenv
Rather than use a single pipeline for both, split the two to enable building with optimizations when performing a release. Furthermore, trigger the job on a tag creation rather than commit message. Alter the implementation to use official GitHub action tasks as it already permits the operations.
pr created time in 2 days
push eventcompnerd/swift-devenv
commit sha 5fe77d7e37cfda4c72590e43bd7af2bf71338432
README: cleanup extraneous whitespace
push time in 2 days
push eventcompnerd/swift-devenv
commit sha ffa3da9e539f313ff41bf9947de18bedc61e1b07
Support: silence warning (NFC)
commit sha 8b6fee6ee937e12b4c267a10623fefc653c21f85
devenv: failure to copy is not an error The failure may be a user-initiated cancellation of the copy request or a denial of privilege escalation for copying to a restricted area. We should report the failure instead.
commit sha 1b5441615f8b1a6aa6cf5f05ddd715c3417e2900
devenv: clean up lifetime issues Explicitly extend the lifetime of the progress reporter as that has no additional reference after the type has been advised to the file operation. Clean up the error message that is printed when an item is not found.
push time in 2 days
push eventcompnerd/swift-com
commit sha 13146b7e33a467c75cc32af497955619d0487ce2
SwiftCOM: minor tweaks to `IFileOperationProgressSink` Rename `Storage` to `Object` as it represents the COM object as if it were implemented in C. Rename the `pointer` field to `wrapper` as it is the Swift wrapper class pointer. Swap the order of the `AddRef` & assignment.
commit sha 8515883cbb4952e0473235f9afd287c301d1aa8b
SwiftCOM: improve memory management of the COM interface This simplifies and improves the memory manage of the COM wrapper type. It is now much easier to reason about the reference count of the type and the unmanaged reference that we use to convert between the WinSDK and the Swift wrapper type.
push time in 2 days
push eventcompnerd/swift-com
commit sha 7a13bc1a3740e70c50dafa82d55ef73bae26ee3a
SwiftCOM: improve memory management of the COM interface This simplifies and improves the memory manage of the COM wrapper type. It is now much easier to reason about the reference count of the type and the unmanaged reference that we use to convert between the WinSDK and the Swift wrapper type.
push time in 2 days
pull request commentcompnerd/swift-devenv
@sosan oh, one thing that would be really useful is to do that particular build with -c release so that the release is actually done with the release mode optimizations.
comment created time in 2 days
push eventcompnerd/swift-devenv
commit sha 758e8bc6e12f62aa685acaf19088ccef1ef5bc19
CI: add support for creating a release binary Add support to trigger a release build to be uploaded via a `[release]` tag in the commit message.
push time in 2 days
pull request commentcompnerd/swift-devenv
Oh, that is a really cool trick for the release management! Thank you so much for that! I'm actually hoping to cut a 0.0.1 release soon since I think I just figured out the last bit of the changes that I wanted to do for one of the dependencies.
comment created time in 2 days
pull request commentapple/swift-corelibs-foundation
Foundation: migrate to the new `CRT` module
@swift-ci please test Linux platform
comment created time in 2 days
pull request commentapple/swift-driver
SwiftDriver: use `ucrt` instead of `MSVCRT`
@owenv would you mind merging this for me?
comment created time in 2 days
pull request commentapple/swift-argument-parser
Windows: migrate to `CRT` from `MSVCRT`
This needs to be synchronized with https://github.com/apple/swift/pull/34299
comment created time in 2 days
pull request commentapple/swift-argument-parser
Windows: migrate to `CRT` from `MSVCRT`
@swift-ci please test
comment created time in 2 days
PR opened apple/swift-argument-parser
The Windows environment calls the library CRT. This also enables the
removal of the visualc module from the Swift SDK overlay.
<!-- Thanks for contributing to the Swift Argument Parser!
If this pull request adds new API, please add '?template=new.md'
to the URL to switch to the appropriate template.
Before you submit your request, please replace the paragraph
below with the relevant details, and complete the steps in the
checklist by placing an 'x' in each box:
- [x] I've completed this task
- [ ] This task isn't completed
-->
Replace this paragraph with a description of your changes and rationale. Provide links to an existing issue or external references/discussions, if appropriate.
Checklist
- [ ] I've added at least one test that validates that my change is working, if appropriate
- [ ] I've followed the code style of the rest of the project
- [ ] I've read the Contribution Guidelines
- [ ] I've updated the documentation if necessary
pr created time in 2 days
pull request commentapple/swift-corelibs-foundation
Foundation: migrate to the new `CRT` module
Please do not merge this - it needs to be synchronized with https://github.com/apple/swift/pull/34299
comment created time in 2 days
pull request commentapple/swift-corelibs-foundation
Foundation: migrate to the new `CRT` module
@swift-ci please test
comment created time in 2 days
PR opened apple/swift-corelibs-foundation
The Windows environment calls the library CRT. Additionally, this
enables the removal of the visualc module from the Swift SDK overlay
for Windows.
pr created time in 2 days
pull request commentapple/swift-tools-support-core
Windows: replace `MSVCRT` with `CRT`
Please do not merge this - this needs to be synchronized with https://github.com/apple/swift/pull/34299
comment created time in 2 days
pull request commentapple/swift-tools-support-core
Windows: replace `MSVCRT` with `CRT`
@swift-ci please test
comment created time in 2 days
PR opened apple/swift-tools-support-core
This is part of the migration path to remove the use of the visualc
module from the Swift SDK for Windows. The use of the stdout and
stderr types requires the use of the Swift overlay as the C library
interfaces are not directly usable with the same name.
pr created time in 2 days