profile
viewpoint

colbyr/aware 27

self-validating models for Laravel\Eloquent

colbyr/BADM 4

Bad-Ass Data Model

colbyr/hipst-a-graph 2

What's you hipster score?

colbyr/deck.js 1

Modern HTML Presentations

colbyr/dotfiles 1

configs 'n' things

colbyr/AsyncStorage 0

Shims ReactNative.AsyncStorage into an npm package.

colbyr/chesster 0

playin' chess like a boss

push eventcolbyr/dotfiles

Colby Rabideau

commit sha 48b64afa821883257a04ec2e17abaaf338a3fc7a

finicky changes

view details

Colby Rabideau

commit sha 2b7a82eb0a5da4ef31e316dc0078622a2e0f0022

ignore .paw files

view details

Colby Rabideau

commit sha 82840094ce9ae881f93e764628405efc3d545227

iterm updates

view details

push time in 4 days

issue commentRecordReplay/devtools

Outline view should be virtualized

Here's the progress I made on the virtualized list https://github.com/RecordReplay/devtools/pull/4592

jasonLaster

comment created time in 15 days

PR opened RecordReplay/devtools

WIP: Virtualized source outline

https://github.com/RecordReplay/devtools/issues/4442

I think this covers most of the outline components functionality.

https://user-images.githubusercontent.com/478109/142709569-a54d7dc0-5584-4489-9a4d-b83fe2f196ba.mov

Replay of the storybook: https://app.replay.io/recording/fcd52802-098c-4532-a7ec-7c7de90b08c9?point=54194598465603617740857971228805283&time=25279&hasFrames=false#

Todos

  • [ ] scroll the list when cursorPosition changes
  • [ ] styling
+516 -146

0 comment

7 changed files

pr created time in 15 days

push eventcolbyr/devtools

Josh Morrow

commit sha 27421ee3ebbe612dd88c6a1819753a42198c8ea5

Change right padding on vertical-panels to 8px

view details

Josh Morrow

commit sha 78d9c583e920d4d7362d8ce1fc7dcbfe2ff77278

Make the sources accordion stack properly This adds a new Accordion class, which shares an interface with the old one, but is IMO considerably simpler. Right now it only has a stacked mode, but it's quite simple to add a non-stacked mode by setting `flex-basis: 0` and `flex-grow: 1` on open children. One thing that I don't love about this design is that the heights use a content basis, which means that if there is any overflow, the shrunken space will be shared evenly by the children, but their final heights will reflect differences in their contents. This means in situations where there are contents with very different heights you will have very uneven heights after shrinking as well. There are a lot of examples in storybook to play around with. ![CleanShot 2021-11-16 at 11 44 54](https://user-images.githubusercontent.com/5903784/142054841-2979bbf1-ad15-4718-88fa-0514f81cef76.png) ![CleanShot 2021-11-16 at 11 44 42](https://user-images.githubusercontent.com/5903784/142054844-69a04e4d-88a7-414c-bbdf-ad8e5126e684.png) Fixes #3200 (finally)

view details

Holger Benl

commit sha 41f98eb588f28307952db727895e2cc537a947d2

Don't redraw the current screenshot if it hasn't been replaced earlier (#4496)

view details

Jaril

commit sha bc4ffaa30d7e9eeb8edcf50a1b9d895e9e4e8997

Dismiss the download replay nag if the user has already downloaded replay via the team member onboarding flow (#4529)

view details

Jaril

commit sha aa18d4cd4009adcbac069f465d27761d1e520a8a

Add a button for opening quick open (#4533)

view details

Jaril

commit sha 4ad6355d3033a2a1ae35e1f52ef2c53319ffe371

Change the way we're tracking upload waiting time to be sent to honeycomb (#4534)

view details

Josh Morrow

commit sha dc5f4df39d02e17d2226c0ea017f569ee7dbf6c7

Add a useFeature hook This sets an observer on our preferences store and allows for a component to refresh when that preference changes. This is used for `features`, but it could easily be expanded to other `prefs`. This allows us to update the secondary toolbox to add or remove the network monitor without refreshing the page.

view details

Josh Morrow

commit sha a7584b763bb9e7c95e54878b7624305085c775d5

Add cleanup task to useFeature hook This was accidentally committed in another branch, but was intended to be part of dc5f4df39d02e17d2226c0ea017f569ee7dbf6c7.

view details

Colby Rabideau

commit sha bba2a4e75692d1fcd295ba8d9e735a531a3fd436

upgrade to @replayrecord/protocol@0.15.3 (#4540)

view details

Jaril

commit sha 73a1f69f1254812232fef083a0ea23f4da2be50e

Move the circular loader to the play button (#4536) * Getting the loader working, sort of * Circular progress loader — needs z-index help Co-authored-by: Jon Bell <github@lot23.com>

view details

Jaril

commit sha 3341521630eaabc3190bc14725cef400e28e12ab

Add sessionId to kpi-time-to-view-replay (#4543)

view details

Jaril

commit sha fb87c784c26667a8e80fdcd97df6dc8c2864efdd

Fix share button height (#4544)

view details

Jaril

commit sha c9b66127819a3f08a49f23730c1999f2dfc097c5

Track mouse over events in mixpanel (#4546)

view details

Colby Rabideau

commit sha 22d4a1b6d609c1a49e764447dd6a531dc243526c

implement searchSources in ThreadFront (#4538)

view details

Jaril

commit sha 4a1112c05b1f01e0a2bcf0e1533bd1b79d8546fc

Mixpanel editor mouseover followups (#4548)

view details

Josh Morrow

commit sha bfe04f15b5ae60ed024b2050727375813c2e9464

Make the request table columns resizable This was pretty straight-forward, although I had to fiddle with the plugins quite a bit to get them to behave nicely with all of the other styling we have going on. https://user-images.githubusercontent.com/5903784/142302532-682a07e1-a02d-4984-8a1e-7c55142219b3.mp4

view details

Josh Morrow

commit sha 488ab3fdcbe4fe2f37009a17bd4624352e79c0fd

Add a request detail view to the network tab - Add a `RequestDetail` component that will show a more detailed view of the selected request - Put that detail view into a SplitBox in the Network tab - Change all tabs in the SecondaryToolbox to toggle their visibility, rather than their presence in the DOM, so that it's more likely to keep state as people are switching tabs. - Add headers to the storybook mock data - Try and get storybook to work with request table and request detail components. One frustrating thing about Storybook is that when it doesn't work it just... doesn't work. The components don't appear in the sidebar, but there are no errors, or any signal about what's wrong. The only thing I've realized here is that calling `connect` in a file can break Storybook *even if the component you are important from that file *isn't* the connected component. I'm not digging further into this right now, it's just not worth the rabbit hole 🐰 . https://user-images.githubusercontent.com/5903784/142294108-3b2a6e46-80ee-46e2-b020-d53c82d95ea6.mp4

view details

Josh Morrow

commit sha 0896c3e18b76bd471e136fc1d7c5c0707b6f16e3

Make the request table filterable This was surprisingly easy, the only tough part was getting the "now" line to properly line up and appear/disappear when the current search was or was not in the search results. https://user-images.githubusercontent.com/5903784/142331850-dc8538b7-239a-4414-a5f5-3a06c5caccf2.mp4

view details

Holger Benl

commit sha c434629e5eadcb3194d550c1cd8c7290bacdb6ac

Don't try to render the elements panel without its redux slice

view details

Holger Benl

commit sha 9261cb34e935fc5cf75da7800753571670f66afc

Fix the rendering of text nodes in the object inspector

view details

push time in 15 days

delete branch colbyr/devtools

delete branch : faster-outline

delete time in 15 days

push eventRecordReplay/devtools

Colby Rabideau

commit sha b1aea85fcfe0337f4fcdeddd24e169abef2a5693

Outline perf improvements (#4571) Memoize the outline list items for less re-renders.

view details

push time in 15 days

PR merged RecordReplay/devtools

Reviewers
Outline perf improvements

Related to https://github.com/RecordReplay/devtools/issues/4442

I don't know if I'm going to have time re-write the outline view with react-window before EOD tomorrow. I'm gonna try but in the meantime, this fixes the most egregious problems with the one we have now.

Right now every component in the outline scrolls any time you scroll or click in the source panel. For a big module, that update feels real slow (It's extra slow in the video because I turned on highlight component updates). ~Also focusing doesn't work in the panel at all.~

https://user-images.githubusercontent.com/478109/142503738-3cba405c-1ee5-47b9-be14-2bfa1301cc72.mov

This PR memoizes the components that make up the list of functions, and removes props that would've triggered needless rerenders.

(Again the video is artificially janky from highlight component updates)

https://user-images.githubusercontent.com/478109/142504191-3953bcfe-734e-48a5-98a3-a840f5cfa1b6.mov

Replay: https://app.replay.io/recording/1e307651-ae2d-4ddb-a105-9011addf2b58#

+67 -53

2 comments

1 changed file

colbyr

pr closed time in 15 days

delete branch colbyr/devtools

delete branch : fix-result-counts

delete time in 15 days

push eventRecordReplay/devtools

Colby Rabideau

commit sha a5b78d43a586ba45fdb5167a0fdcf0f40f323f47

Fix search result counts (#4582) Fixes the search result count and scrolling for many matches.

view details

push time in 15 days

PR merged RecordReplay/devtools

Reviewers
Fix search result counts

Fixes https://github.com/RecordReplay/devtools/issues/4577 Also let's the result container scroll.

After

Screen Shot 2021-11-19 at 11 06 22 AM

Replay: https://app.replay.io/recording/c7bb4069-bed4-4646-ad3b-f161cf99a913

+23 -16

1 comment

2 changed files

colbyr

pr closed time in 15 days

issue closedRecordReplay/devtools

Full Text Search matches should be results not files

https://app.replay.io/recording/c76148af-2592-4570-bf1f-f929bbc03646?point=151225646010824678624700953633227311&time=50742.0746217288&hasFrames=true#

closed time in 15 days

jasonLaster

push eventcolbyr/devtools

Colby Rabideau

commit sha 840f020ec585491ed9ff18e144ef56291b8c792b

remove consolelog

view details

push time in 15 days

Pull request review commentRecordReplay/devtools

Fix search result counts

 export class ProjectSearch extends Component {   }    render() {+    console.info(this.state);

lol whoops good catch

colbyr

comment created time in 15 days

PullRequestReviewEvent

push eventcolbyr/devtools

Colby Rabideau

commit sha b5299520142d9e8aae45e792eb6d7488dd97866c

formatMatches -> formatMatchesBySource

view details

Colby Rabideau

commit sha 3204399be63e85403325d5bfaa6961426c0cce4d

fix result scrolling

view details

push time in 15 days

PR opened RecordReplay/devtools

Fix search result counts

Fixes https://github.com/RecordReplay/devtools/issues/4577

+22 -14

0 comment

2 changed files

pr created time in 15 days

create barnchcolbyr/devtools

branch : fix-result-counts

created branch time in 15 days

PullRequestReviewEvent

pull request commentRecordReplay/devtools

Outline perf improvements

Replay incoming: [insert replay here]

colbyr

comment created time in 16 days

push eventcolbyr/devtools

Colby Rabideau

commit sha a80bb323d0090926ea3c8e48f37cb5c621880984

cleanup

view details

push time in 16 days

PR opened RecordReplay/devtools

Outline fixes

Related to https://github.com/RecordReplay/devtools/issues/4442

I don't know if I'm going to have time re-write the outline view with react-window before EOD tomorrow. I'm gonna try but in the meantime, this fixes the most egregious problems with the one we have now.

Right now every component in the outline scrolls any time you scroll or click in the source panel. For a big module, that update feels real slow (It's extra slow in the video because I turned on highlight component updates). Also focusing doesn't work in the panel at all.

https://user-images.githubusercontent.com/478109/142503738-3cba405c-1ee5-47b9-be14-2bfa1301cc72.mov

This PR memoizes the components that make up the list of functions, and removes props that would've triggered needless rerenders.

It also fixes auto-focusing within the outline view.

(Again the video is artificially janky from highlight component updates)

https://user-images.githubusercontent.com/478109/142504191-3953bcfe-734e-48a5-98a3-a840f5cfa1b6.mov

+68 -50

0 comment

1 changed file

pr created time in 16 days

delete branch colbyr/devtools

delete branch : codepoint-helpers

delete time in 16 days

push eventcolbyr/devtools

Colby Rabideau

commit sha 219ef3ea3a21fa0dbfd2620723a7337ba6814cf0

remove a log

view details

push time in 16 days

create barnchcolbyr/devtools

branch : faster-outline

created branch time in 16 days

Pull request review commentRecordReplay/devtools

Add file search to the left sidebar

 export class ProjectSearch extends Component {       return;     }     const matches = results.matches;-    if (matches.length) {-      return (-        <ManagedTree-          getRoots={() => matches}-          getChildren={file => file.matches || []}-          itemHeight={24}-          autoExpandAll={true}-          autoExpandDepth={1}-          autoExpandNodeChildrenLimit={100}-          getParent={item => null}-          getPath={getFilePath}-          renderItem={this.renderItem}-          focused={this.state.focusedItem}-          onFocus={this.onFocus}-        />-      );++    if (!matches.length) {+      const msg = results.status === "LOADING" ? "Loading\u2026" : "No results found";+      return <div className="px-2">{msg}</div>;

This early return feels way better than the other one 🌴

jaril

comment created time in 16 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventRecordReplay/devtools

Colby Rabideau

commit sha 94bf3743e868b66f17b93b16e4afc9f14a9bf7dc

Codepoint helpers (#4567)

view details

push time in 16 days

PR merged RecordReplay/devtools

Reviewers
Codepoint helpers

RE: https://github.com/RecordReplay/devtools/pull/4561#discussion_r752427573

Adds the code point string helpers @jasonLaster suggested.

+100 -3

1 comment

3 changed files

colbyr

pr closed time in 16 days

more