profile
viewpoint
C. K. Tang cktang88 Nashville, TN Vanderbilt CS, @hackNY '18, prev Director of Development @VandyHacks

startedggreer/the_silver_searcher

started time in 4 days

startedpaulhodel/jexcel

started time in 5 days

startedcharlax/engineering-management

started time in 5 days

startedjkup/awesome-personal-blogs

started time in 5 days

startedpoteto/hiring-without-whiteboards

started time in 5 days

startedkilimchoi/engineering-blogs

started time in 5 days

push eventcktang88/dotfiles

C. K. Tang

commit sha 488632f9a5e95d2b5d14ce2d0b090fe9414dbcae

Update README.md

view details

push time in 6 days

push eventcktang88/dotfiles

C. K. Tang

commit sha 9684c82d1422f93588765461b00a111bd10529d1

Create install.sh

view details

push time in 6 days

PR closed kelseyhightower/nocode

Show how to implement no code in Python
+1 -0

0 comment

1 changed file

cktang88

pr closed time in 7 days

PR closed mwufi/css-days

Add fire
+2 -2

0 comment

1 changed file

cktang88

pr closed time in 7 days

delete branch cktang88/yoga2

delete branch : patch-1

delete time in 7 days

PR closed prisma/yoga2

Fix broken link in README

<!-- Thank you for your pull request. Please provide a description above and review the requirements below. If PR contains feature please make sure that corresponding issue is created and linked in PR

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: ./CONTRIBUTING.md -->

Description

Progress

  • [ ] Implementation
  • [ ] Documentation
  • [ ] Tests
+1 -1

0 comment

1 changed file

cktang88

pr closed time in 7 days

starteduber-go/zap

started time in 8 days

startedlibra/libra

started time in 8 days

issue commentcktang88/meta-idle

there's nothing here

Feel free to contribute :)

mwufi

comment created time in 10 days

issue openedVandyHacks/vaken

Use enzyme and shallow rendering in frontend tests

https://airbnb.io/enzyme/

These are way more reliable/useful and probably faster than snapshot testing

created time in 10 days

issue openedachrysaetos/hello_world2

add js and css

created time in 11 days

startedurbit/urbit

started time in 11 days

starteddgryski/go-perfbook

started time in 11 days

startedbcrumbs/reactackle

started time in 11 days

issue openedachrysaetos/hello_world

there's no code in this repo

created time in 11 days

startedreact-cosmos/react-cosmos

started time in 11 days

startedlydiahallie/javascript-questions

started time in 12 days

startedentropic-dev/entropic

started time in 12 days

push eventVandyHacks/vh-hackpack-express-mongo

cktang88

commit sha 5680b2b021988a48fa43cee7cfbf8455078fe681

Update deps

view details

push time in 14 days

push eventVandyHacks/vh-hackpack-express-mongo

cktang88

commit sha bf796d59f5e0e882453a1e1db0d9653cb5ede04f

Add basic CSS

view details

push time in 14 days

PublicEvent

startedTrillCyborg/onefraction

started time in 17 days

startedsystem-ui/theme-ui

started time in 18 days

startedgatsbyjs/gatsby-starter-blog

started time in 18 days

startedduke7553/files-uwp

started time in 18 days

push eventcktang88/dotfiles

C. K. Tang

commit sha a5f870f451deaf8023fea40f643bf7bc09c414c6

Update README.md

view details

push time in 19 days

push eventcktang88/dotfiles

C. K. Tang

commit sha 4d3c7fdc8e7f15493cbaad16ce721d8b9e12a3f3

Update README.md

view details

push time in 19 days

startedreduxjs/reselect

started time in 19 days

startedbenbjohnson/thesecretlivesofdata

started time in 21 days

starteddata-ppf/data-ppf.github.io

started time in 25 days

CommitCommentEvent
CommitCommentEvent
CommitCommentEvent

startedmetafizzy/zdog

started time in a month

push eventcktang88/dotfiles

C. K. Tang

commit sha b31d0e020476f13df588879d312ae0d8fd93d1ff

Update README.md

view details

push time in a month

push eventcktang88/dotfiles

C. K. Tang

commit sha f1d6b874cc3add666e991d1e0a77424b73a877a5

Fix path

view details

push time in a month

issue openeddwmkerr/hacker-laws

Bonini's Paradox

https://en.wikipedia.org/wiki/Bonini%27s_paradox

created time in a month

Pull request review commentVandyHacks/vaken

Refactor auth code more

 export const createStrategyHandler = (authType: AuthType) => async ( 			} 		} else { 			// no user found, create new user-			logger.debug('> Creating user.....');-			const newUser = {-				authLevel: AuthLevel.HACKER,-				authType,-				email: profile.emails[0].value,-				googleId: profile.id,-				password: `${authType}!123`,-			};-			const createdUser = await UserModel.create(newUser);-			if (createdUser) {-				// create hacker-				const createdHacker = await HackerModel.create({-					email: createdUser.email,-					status: Status.Created,-					user: createdUser._id,-				});-				if (createdHacker) {-					logger.debug(createdUser);-					done(null, createdUser);-				} else {-					done(null, false);-				}-			} else {-				done(null, false);-			}+			createAuthenticatedUser(authType, profileEmail, (user as any).id, done);

it doesn't matter in this case because we only care about the id, the user type is enforced when it's originally passed in as a param of the func

github-actions[bot]

comment created time in a month

Pull request review commentVandyHacks/vaken

Refactor auth code more

 export const createStrategyHandler = (authType: AuthType) => async ( 			} 		} else { 			// no user found, create new user-			logger.debug('> Creating user.....');-			const newUser = {-				authLevel: AuthLevel.HACKER,-				authType,-				email: profile.emails[0].value,-				googleId: profile.id,-				password: `${authType}!123`,-			};-			const createdUser = await UserModel.create(newUser);-			if (createdUser) {-				// create hacker-				const createdHacker = await HackerModel.create({-					email: createdUser.email,-					status: Status.Created,-					user: createdUser._id,-				});-				if (createdHacker) {-					logger.debug(createdUser);-					done(null, createdUser);-				} else {-					done(null, false);-				}-			} else {-				done(null, false);-			}+			createAuthenticatedUser(authType, profileEmail, (user as any).id, done);

User | null doesn't have the id field

github-actions[bot]

comment created time in a month

issue openedVandyHacks/vaken

Add support for more OAuth providers

in src/server/auth.ts

Currently supports Google and Github only.

created time in a month

Pull request review commentVandyHacks/vaken

Refactor auth code more

 passport.use( 	) ); +// create hacker from user+export const createHackerFromUser = async (user: InstanceType<User>, done: Function) => {+	const createdHacker = await HackerModel.create({+		email: user.email,+		status: Status.Created,+		user: user._id,+	});+	if (createdHacker) {+		logger.debug(user);+		done(null, user);+	} else {+		done(null, false);+	}+};++// create a new user+export const createAuthenticatedUser = async (+	authType: AuthType,+	email: string,+	id: any,+	done: Function+) => {+	logger.debug('> Creating user.....');+	const newUser = {+		authLevel: AuthLevel.HACKER,+		authType,+		email,+		githubId: authType === AuthType.GITHUB ? id : undefined,

yeah another issue

github-actions[bot]

comment created time in a month

issue openedVandyHacks/vaken

Don't generate OAuth users with a hardcoded password

in src/server/auth.ts

created time in a month

Pull request review commentVandyHacks/vaken

Refactor auth code more

 passport.use( 	) ); +// create hacker from user+export const createHackerFromUser = async (user: InstanceType<User>, done: Function) => {+	const createdHacker = await HackerModel.create({+		email: user.email,+		status: Status.Created,+		user: user._id,+	});+	if (createdHacker) {+		logger.debug(user);+		done(null, user);+	} else {+		done(null, false);+	}+};++// create a new user+export const createAuthenticatedUser = async (+	authType: AuthType,+	email: string,+	id: any,+	done: Function+) => {+	logger.debug('> Creating user.....');+	const newUser = {+		authLevel: AuthLevel.HACKER,+		authType,+		email,+		githubId: authType === AuthType.GITHUB ? id : undefined,+		googleId: authType === AuthType.GOOGLE ? id : undefined,+		password: `${authType}!123`,

this is copied from before, will create issue

github-actions[bot]

comment created time in a month

Pull request review commentVandyHacks/vaken

Refactor auth code more

 export const createStrategyHandler = (authType: AuthType) => async ( 			} 		} else { 			// no user found, create new user-			logger.debug('> Creating user.....');-			const newUser = {-				authLevel: AuthLevel.HACKER,-				authType,-				email: profile.emails[0].value,-				googleId: profile.id,-				password: `${authType}!123`,-			};-			const createdUser = await UserModel.create(newUser);-			if (createdUser) {-				// create hacker-				const createdHacker = await HackerModel.create({-					email: createdUser.email,-					status: Status.Created,-					user: createdUser._id,-				});-				if (createdHacker) {-					logger.debug(createdUser);-					done(null, createdUser);-				} else {-					done(null, false);-				}-			} else {-				done(null, false);-			}+			createAuthenticatedUser(authType, profileEmail, (user as any).id, done);

typescript says it can be null even though the else statement makes that impossible

github-actions[bot]

comment created time in a month

push eventVandyHacks/vaken

cktang88

commit sha 04630b6de916f9a14974701234d7551758c9283b

Fix user type with Typegoose

view details

push time in a month

push eventVandyHacks/vaken

cktang88

commit sha 89c072cdcba7e356778e7ce35b45484a765f10af

Refactor auth, fix #14

view details

cktang88

commit sha f7347b2bb5b9da72dc0eabfbbbce029f6f532150

Add test for auth

view details

cktang88

commit sha 5a8c56f3d23353bdd5d2a8c249f71a4ce14d951e

Refactor auth into smaller methods

view details

push time in a month

create barnchVandyHacks/vaken

branch : kwuang-refactor-auth

created branch time in a month

push eventVandyHacks/vaken

cktang88

commit sha 89c072cdcba7e356778e7ce35b45484a765f10af

Refactor auth, fix #14

view details

cktang88

commit sha f7347b2bb5b9da72dc0eabfbbbce029f6f532150

Add test for auth

view details

push time in a month

issue closedVandyHacks/vaken

Unify Github/Google OAuth2 auth callback patterns

https://github.com/VandyHacks/vaken/blob/dev/src/server/auth.ts

The Github and Google OAuth2 related code is really similar, can be refactored into common funcs.

closed time in a month

cktang88

PR merged VandyHacks/vaken

Refactor auth code

This is an automated pull request to update the container collection kwuang-refactor-auth

+69 -113

1 comment

2 changed files

github-actions[bot]

pr closed time in a month

push eventVandyHacks/vaken

cktang88

commit sha 0e95699e5a02731ed83fecf763082280b9c11c19

Add test for auth

view details

push time in a month

create barnchVandyHacks/vaken

branch : kwuang-refactor-auth

created branch time in a month

push eventVandyHacks/vaken

cktang88

commit sha c8fe8d6f8f936c48b2d2723703892622c64e7bf0

Improve mongo connect handler

view details

push time in a month

push eventVandyHacks/vaken

Benjamin Cooper

commit sha b650c78119f81d3155e3eab481c1691d5b8842da

fix 2 files and remove eslint-config-typescript

view details

C. K. Tang

commit sha 67fa19d51be3b96f14f0d1b35977fe8ac131c7e5

Update CONTRIBUTING.md

view details

cktang88

commit sha 269bf69f6039fabb148a38c3bd84f1047816efce

Make more eslint config global

view details

cktang88

commit sha 88c951c2401c8e03d934887074279f9b7b1de5c4

Disable sensitive lint rule for tests

view details

cktang88

commit sha cb6c5e88d9ca31dbea00d0c5f0a06577d6e30fd6

Remove func return type lint rule in server

view details

cktang88

commit sha ba123e80315721184fe4e1cef3bfad151cb1c371

Make server lint config more specific

view details

cktang88

commit sha c970dd1f3bfa024c05064bea79779f1baaef080b

Add types to userRouter

view details

cktang88

commit sha cf24eb05e7fbaa0dc083f157bf4fea281e023647

Revert auth serialize user param type

view details

push time in a month

create barnchVandyHacks/vaken

branch : kwuang-test-index

created branch time in a month

push eventVandyHacks/vaken

cktang88

commit sha 6281b3fb88d5a75bb509543047e3e3ef98e5e5c3

Revert auth serialize user param type

view details

push time in a month

push eventVandyHacks/vaken

cktang88

commit sha b09889d4928ecb547204126dc09bbf94dc970302

Add types to userRouter

view details

push time in a month

push eventVandyHacks/vaken

C. K. Tang

commit sha 67fa19d51be3b96f14f0d1b35977fe8ac131c7e5

Update CONTRIBUTING.md

view details

push time in a month

PR merged VandyHacks/vaken

Update CONTRIBUTING.md approved
+11 -4

1 comment

1 changed file

cktang88

pr closed time in a month

PR opened VandyHacks/vaken

Update CONTRIBUTING.md
+11 -4

0 comment

1 changed file

pr created time in a month

create barnchVandyHacks/vaken

branch : cktang88-patch-1

created branch time in a month

push eventVandyHacks/vaken

cktang88

commit sha 92967a26551435867263137a1c25341eddaf9059

Make server lint config more specific

view details

push time in a month

push eventVandyHacks/vaken

cktang88

commit sha db255427d12d89e9e69e484a8a75b472e597ccf4

Remove func return type lint rule in server

view details

push time in a month

push eventVandyHacks/vaken

cktang88

commit sha 849abc679c70a6ff768c81a2012c13b383ee380a

Disable sensitive lint rule for tests

view details

push time in a month

create barnchVandyHacks/vaken

branch : kwuang-lint3

created branch time in a month

push eventVandyHacks/vaken

Benjamin Cooper

commit sha b650c78119f81d3155e3eab481c1691d5b8842da

fix 2 files and remove eslint-config-typescript

view details

push time in a month

issue openedVandyHacks/vaken

Speed up webpack config

https://webpack.js.org/guides/build-performance/

created time in a month

issue openedVandyHacks/vaken

CreateLogin: Show helpful error messages for invalid email, password

Currently just highlights the input box red, instead of saying eg. why a password is invalid (needs at least at least 1 symbol (@$!%*#?&), 1 number, 1 letter, and is at least 8 characters long)

created time in a month

push eventVandyHacks/vaken

cktang88

commit sha e416c7472e74e069b94ff77b0b825f9697710b9c

Test LoginHandler

view details

push time in a month

create barnchVandyHacks/vaken

branch : kwuang-refactor

created branch time in a month

push eventVandyHacks/vaken

cktang88

commit sha 0dd69712d01b7c00f8c120118eedaf2d44d6f686

Test index, frame, sidebar

view details

cktang88

commit sha d5ad56ada6d4b478eab48ce42a67f62b37ebf0be

Test RadioSlider

view details

cktang88

commit sha ae37bc89b54ae2535fdb62e7e741eeabc66f0e49

Fix test using mock fetch

view details

push time in a month

PR merged VandyHacks/vaken

Clean up a few tests approved

Most of the line changes in the PR is from:

  1. split up client/index.tsx into two files for easier testing
  2. Update snapshots
+362 -119

1 comment

15 changed files

github-actions[bot]

pr closed time in a month

push eventVandyHacks/vaken

cktang88

commit sha 0bd94da9c805a73b8e0ff199ea03beca11bc684f

Fix test using mock fetch

view details

push time in a month

issue openedVandyHacks/vaken

Actually test graphql properly using proper mocking

See https://www.apollographql.com/docs/graphql-tools/mocking#addMockFunctionsToSchema

Related to #215

created time in a month

push eventVandyHacks/vaken

cktang88

commit sha 24e19b9583cd025059eef2dfe0cfbf5f2ff20835

Test RadioSlider

view details

push time in a month

issue commentVandyHacks/vaken

Can't test Google OAuth locally

Can you make a PR to the README that says this?

cktang88

comment created time in a month

create barnchVandyHacks/vaken

branch : kwuang-test8

created branch time in a month

issue openedVandyHacks/vaken

Can't test Google OAuth locally

image @ftiet any ideas why?

created time in a month

push eventVandyHacks/vaken

cktang88

commit sha 850f9faa05a707667a22a5e37103f6e08de77088

Fix lint error and regression from lint fix

view details

cktang88

commit sha b27b50cfb5cba746db9c631cb24ab3bb1159a9f0

Small typos

view details

push time in a month

PR merged VandyHacks/vaken

Fix lint error and regression from lint fix in client/index.tsx approved

This is an automated pull request to update the container collection kwuang-lint-fix2

+18 -12

1 comment

2 changed files

github-actions[bot]

pr closed time in a month

push eventVandyHacks/vaken

cktang88

commit sha 6dbaaaa2933cf2e6b6b2cc8915fbb2b36ac4a045

Small typos

view details

push time in a month

create barnchVandyHacks/vaken

branch : kwuang-lint-fix2

created branch time in a month

push eventVandyHacks/vaken

C. K. Tang

commit sha 772d96a5b459ce81501c2061158c4ea67e5ff17f

Split jest config into projects

view details

push time in a month

issue closedVandyHacks/vaken

Use different projects in jest to separate browser/server testing configs

browser should use jsdom env, server should use node env. To accomplish this, probably use https://jestjs.io/docs/en/configuration.html#projects-array-string-projectconfig

closed time in a month

cktang88

push eventVandyHacks/vaken

cktang88

commit sha 426d54ac08c06f5b6a482d4a5ec043d4d760d72a

Create stricter eslint config

view details

cktang88

commit sha 7627c21b5b40be340013a93a437180fba14390c8

Auto lint-fix

view details

cktang88

commit sha 6f368e1c8ad3733264bc284ac1273aff804c3e47

Manually fix some lint errors

view details

cktang88

commit sha 5bd4f0e993721ba60291a67a0d981f3e298c1c74

Remove old test

view details

cktang88

commit sha 88c5b626d39c475db337573356e4f77d33fd55b8

Let eslint skip arg with weird type def

view details

cktang88

commit sha 3da3b532a635e3d28e242b178e415d67e50ed59b

Fix auth test for linting

view details

cktang88

commit sha c123a78a07f38fd089563b3f5a92d1db1977febd

Update env vars mock for CI

view details

cktang88

commit sha 686c39110edb228cf45d8762266abee41ecb4289

Fix env path

view details

C. K. Tang

commit sha d08e19f3e176e962f5ee4fc8692ac2b04c6f4643

Split jest config into projects

view details

push time in a month

push eventVandyHacks/vaken

cktang88

commit sha 426d54ac08c06f5b6a482d4a5ec043d4d760d72a

Create stricter eslint config

view details

cktang88

commit sha 7627c21b5b40be340013a93a437180fba14390c8

Auto lint-fix

view details

cktang88

commit sha 6f368e1c8ad3733264bc284ac1273aff804c3e47

Manually fix some lint errors

view details

cktang88

commit sha 5bd4f0e993721ba60291a67a0d981f3e298c1c74

Remove old test

view details

cktang88

commit sha 88c5b626d39c475db337573356e4f77d33fd55b8

Let eslint skip arg with weird type def

view details

cktang88

commit sha 3da3b532a635e3d28e242b178e415d67e50ed59b

Fix auth test for linting

view details

cktang88

commit sha c123a78a07f38fd089563b3f5a92d1db1977febd

Update env vars mock for CI

view details

cktang88

commit sha 686c39110edb228cf45d8762266abee41ecb4289

Fix env path

view details

push time in a month

PR merged VandyHacks/vaken

Reviewers
Add stricter linting config approved

Introduces many new eslint errors, especially server-side. (and closes #91) Also fixes a few of the new errors.

+116 -85

2 comments

21 changed files

github-actions[bot]

pr closed time in a month

push eventVandyHacks/vaken

cktang88

commit sha ff710114acea5bb8a1a9b553c7b8e45cabb04221

Fix env path

view details

push time in a month

more