C. K. Tang cktang88 Nashville, TN Vanderbilt CS, @hackNY '18, prev Director of Development @VandyHacks

push eventVandyHacks/vaken

Benjamin Cooper

commit sha 25b60d6cf6d0d13d67f006b78e4031740ea43e9a

Moving out default check to separate action

view details

push time in 2 hours

PR merged VandyHacks/vaken

Moving out default check to separate action approved

Default detection has been moved out of main action: https://github.com/bencooper222/check-for-node-dep-changes/commit/1e3249760522f56076637d669b6028ce9188a687

So we now have to check ourselves.

+6 -0

0 comment

1 changed file

bencooper222

pr closed time in 2 hours

Pull request review commentVandyHacks/vaken

Ci lint setup

 module.exports = { 				extensions: ['.tsx', '.jsx'], 			}, 		],-		'sort-keys-fix/sort-keys-fix': ['error', 'asc', { caseSensitive: true, natural: true }],

why remove sort-keys?

bencooper222

comment created time in 5 hours

pull request commentVandyHacks/vaken

Ci lint setup

lol what are these commit messages

bencooper222

comment created time in 5 hours

issue commentVandyHacks/vaken

Use `npm ci` or `npm i` during tests?

npm i unless there's a problem?

bencooper222

comment created time in 5 hours

issue commentVandyHacks/vaken

Add meta information to client

If configurability is hard, we can just have instructions telling them to just directly edit the html.

bencooper222

comment created time in 6 hours

issue commentVandyHacks/vaken

Set up CI

Can we close this and just use #26 ?

IrfaanKhalid

comment created time in 6 hours

issue commentVandyHacks/vaken

Clean up eslint warnings and errors

no-unused-vars is good

is there something like no-unused-imports too

bencooper222

comment created time in 7 hours

issue commentVandyHacks/vaken

Clean up eslint warnings and errors

no-console would break every single file in the repo

bencooper222

comment created time in 7 hours

issue commentVandyHacks/vaken

Fix code that doesn't adhere to .editorconfig

how slow is it?

bencooper222

comment created time in 7 hours

issue commentVandyHacks/vaken

Switch to PostgreSQL

The duplication of data is a large problem if we have to keep changing things in multiple places. If we do, then I'd seriously consider SQL. Otherwise, I think we're fine with Mongo because the majority of the app is already written and it's unlikely to undergo major modifications to the models in the future.

leonm1

comment created time in 7 hours

push eventVandyHacks/vaken

Benjamin Cooper

commit sha dee833248152e1d045326528fcd5ce95ea8360ba

Match GH required approvals

view details

push time in 11 hours

PR merged VandyHacks/vaken

Match GH required approvals
+1 -1

0 comment

1 changed file

bencooper222

pr closed time in 11 hours

issue commentVandyHacks/vaken

Switch to PostgreSQL

Okay but Mongo has:

  • Atlas
  • human readable dumps
  • good interop with JS lang, allowing storing of whole JS objects, etc.
leonm1

comment created time in 11 hours

issue commentVandyHacks/vaken

Set OG Image for repo

I like the vaken logo Alan made

bencooper222

comment created time in 11 hours

pull request commentVandyHacks/vaken

Dockerize

Yeah I think we should discuss this more.

It's also maybe hard to get docker to work on Windows Home and even WSL?

leonm1

comment created time in 11 hours

push eventVandyHacks/vaken

Benjamin Cooper

commit sha ff29eb86136e654996c4ed5755ba8d1b822a8c49

Add non-intrusive editor config

view details

Benjamin Cooper

commit sha f3d99a16935149af41e5626f649ad3187158955e

Linting on new config

view details

Benjamin Cooper

commit sha cb36abf972f202699494a3f734a66c0fb544ca59

Remove copyrights

view details

Benjamin Cooper

commit sha 1a57f8fb9dbbc2de6e7a235a996e3df2449d33b6

Ran lint to eliminate lf; may have side effects

view details

Benjamin Cooper

commit sha d313080cf6ca1eb0b77ec05788fd925e45d26f48

Reproduced comment that was against lint rules

view details

Benjamin Cooper

commit sha a2cc496ce038ae5f56d6cacb256baca9226e16c3

More line ending changes

view details

Benjamin Cooper

commit sha 076c2fdadfcb1343f44165bc098654f20428f8e6

Remove bad comment

view details

Benjamin Cooper

commit sha 32b0c30c8f41f2a74c12f52828d12143177f082a

Used eclint to fix more files

view details

push time in 11 hours

PR merged VandyHacks/vaken

Add non-intrusive editor config with painful shortterm lint consequences approved

This will be disruptive short term but enforcing LF is really necessary. The rest is just gravy. Closes #30

+2894 -2889

4 comments

25 changed files

bencooper222

pr closed time in 11 hours

issue closedVandyHacks/vaken

Add an editor config

I'll be honest, whenever I make one, it never does anything. But it seems important if properly done.

closed time in 11 hours

bencooper222

issue commentVandyHacks/vaken

Nodemon limits

Maybe use https://www.npmjs.com/package/node-dev

cktang88

comment created time in a day

pull request commentVandyHacks/vaken

Add non-intrusive editor config

I'd suggest breaking this up into several PRs

bencooper222

comment created time in a day

pull request commentVandyHacks/vaken

Add non-intrusive editor config

This PR title is misleading given how much behavior is changed.

bencooper222

comment created time in a day

Pull request review commentVandyHacks/vaken

Add non-intrusive editor config

 export const Profile: React.FunctionComponent<{}> = (): JSX.Element => { 				draft[PROFILE] = { ...data.getUserByEmail }; 			}); 		}-	}, [data]);+	}, [data, setFormData]);  	useEffect((): (() => void) => { 		if (setActionButton) setActionButton(<HeaderButton text="Submit" onClick={submit} />);  		return () => { 			if (setActionButton) setActionButton(undefined); 		};-	}, [formData]);+	}, [formData, setActionButton, submit]);

?

bencooper222

comment created time in a day

Pull request review commentVandyHacks/vaken

Add non-intrusive editor config

 export const Application: FunctionComponent<{}> = (): JSX.Element => { 		return () => { 			if (setActionButton) setActionButton(undefined); 		};-	}, []);+	}, [setActionButton]);

?

bencooper222

comment created time in a day

Pull request review commentVandyHacks/vaken

Add non-intrusive editor config

 export const Profile: React.FunctionComponent<{}> = (): JSX.Element => { 				draft[PROFILE] = { ...data.getUserByEmail }; 			}); 		}-	}, [data]);+	}, [data, setFormData]);

what is this change?

bencooper222

comment created time in a day

issue openedVandyHacks/vaken

Nodemon limits

When running npm run dev-server, I get [nodemon] Internal watch failed: ENOSPC: System limit for number of file watchers reached, watch '.../vaken/src/server/inputs'

created time in a day

issue commentVandyHacks/vaken

Remove unused dependences

I'm pretty sure all the ones above have no imports calling them.

cktang88

comment created time in a day

issue commentVandyHacks/vaken

Remove unused dependences

yeah depcheck and npm-check don't work with our import syntax, see #47

cktang88

comment created time in a day

push eventVandyHacks/vaken

C. K. Tang

commit sha fee761f1d7d472be929e71c9790c463f2bc38086

Create CONTRIBUTING.md

view details

push time in a day

PR merged VandyHacks/vaken

Create CONTRIBUTING.md
+41 -0

0 comment

1 changed file

cktang88

pr closed time in a day

push eventVandyHacks/vaken

C. K. Tang

commit sha 642afe72a4e8cab1f7f24420c5896a53ba920374

Update README.md

view details

push time in a day

PR merged VandyHacks/vaken

Update README.md
+27 -0

0 comment

1 changed file

cktang88

pr closed time in a day

issue commentVandyHacks/vaken

Switch to PostreSQL

wdym by duplication?

leonm1

comment created time in a day

PR opened VandyHacks/vaken

Update README.md
+27 -0

0 comment

1 changed file

pr created time in a day

create barnchVandyHacks/vaken

branch : cktang88-patch-2

created branch time in a day

PR opened VandyHacks/vaken

Create CONTRIBUTING.md
+41 -0

0 comment

1 changed file

pr created time in a day

create barnchVandyHacks/vaken

branch : cktang88-patch-1

created branch time in a day

push eventcktang88/dotfiles

cktang88

commit sha 82471550360ff896f3d62d672373d4f463d53b62

Touch up readme

view details

push time in a day

issue commentVandyHacks/vaken

Improve CONTRIBUTING.md

I'm going to init it

bencooper222

comment created time in a day

push eventVandyHacks/vaken

Benjamin Cooper

commit sha d2304b9465f11abee98ce4020c247c28aeda5df7

Update README.md

view details

C. K. Tang

commit sha 04dbcfa586ec5899a55be76441cd6bfa1e338234

Merge pull request #62 from VandyHacks/bencooper222-patch-1 Update README.md

view details

push time in a day

PR merged VandyHacks/vaken

Update README.md
+1 -0

0 comment

1 changed file

bencooper222

pr closed time in a day

create barnchVandyHacks/vaken

branch : kwuang-2

created branch time in a day

pull request commentVandyHacks/vaken

Fix #51

why is there so much stuff on this pr @bencooper222

cktang88

comment created time in a day

startedsoul-lang/SOUL

started time in a day

push eventVandyHacks/vaken

C. K. Tang

commit sha 2f696f24e6a3d1bce47594e69855538562ae69d1

Create dummy_test.ts

view details

push time in a day

push eventVandyHacks/vaken

C. K. Tang

commit sha fcca636c72cba3287ef0b424221321a584b021c3

Update package.json

view details

push time in a day

push eventVandyHacks/vaken

C. K. Tang

commit sha 921e6a41ec20e86bf5688c9651d8eaa1a8987258

Create jest.config.js

view details

push time in a day

push eventVandyHacks/vaken

Benjamin Cooper

commit sha 1f75a5c397dd226b45b636627058de56888041c5

Add dependency change -> message slack workflow

view details

C. K. Tang

commit sha 5bd6bac1fdfab2eaa09b8bc7a03f3966b8462101

Merge pull request #59 from VandyHacks/msg-slack-ondepchange Add dependency change -> message slack workflow

view details

push time in a day

push eventVandyHacks/vaken

cktang88

commit sha e2482f720f5c735521707ca26f4937be62eb0c2e

Remove redundant fields

view details

push time in a day

PR opened VandyHacks/vaken

Fix #51

Fix #51

+30 -1

0 comment

1 changed file

pr created time in a day

create barnchVandyHacks/vaken

branch : kwuang-1

created branch time in a day

issue commentVandyHacks/vaken

Parse phone numbers

why frontend? Any malicious actor can mess with frontend stuff. I think if it's security related, it should definitely be backend.

IrfaanKhalid

comment created time in a day

push eventVandyHacks/vaken

Benjamin Cooper

commit sha 40fb4e6c51b8b5c3dda7966c1c3f017223462476

Update main.workflow

view details

Benjamin Cooper

commit sha cabacee9c37d939697a556024cef9f3e70d72a35

Don't fail cleanup tests

view details

C. K. Tang

commit sha 096a72dc435078aa96b8ba03103acfb09b243264

Merge pull request #58 from VandyHacks/pr-merge-clean-action Update main.workflow

view details

push time in a day

PR merged VandyHacks/vaken

Update main.workflow
+13 -0

0 comment

1 changed file

bencooper222

pr closed time in a day

issue openedVandyHacks/vaken

Update deps

npm outdated

In the future hopefully we can automate this.

created time in a day

push eventVandyHacks/vaken

Benjamin Cooper

commit sha 7d12d151a49ae61952b4070cfaf20f49a3888de0

Nonbreaking audit changes

view details

C. K. Tang

commit sha ac0241f74572109d89a55f682c9fbc03bbd4240b

Merge pull request #56 from VandyHacks/npm-audit-fix Nonbreaking audit changes

view details

push time in a day

PR merged VandyHacks/vaken

Nonbreaking audit changes
+974 -113

0 comment

2 changed files

bencooper222

pr closed time in a day

issue openedVandyHacks/vaken

Ugly HackerTable code

https://github.com/VandyHacks/vaken/blob/dev/src/client/routes/manage/HackerTable.tsx

This render code is ugly af. Should look for ways to clean it up

created time in a day

issue openedVandyHacks/vaken

Try to find a lib for FlexContainer

https://github.com/VandyHacks/vaken/blob/dev/src/client/components/Containers/FlexContainers.tsx

^^ that seems like a lot of general code, maybe someone's already done it?

@leonm1

created time in a day

issue commentVandyHacks/vaken

dev-server script not cross-platform

i feel personally attacked

cktang88

comment created time in a day

issue openedVandyHacks/vaken

dev-server script not cross-platform

Currently on windows: image

Replace with "dev-server": "nodemon" ?

created time in a day

issue openedVandyHacks/vaken

Proxy error on start

Just ran npm start and got:

image

created time in a day

issue closedVandyHacks/vaken

Remove "Copyright Vanderbilt University" from every file

No one:

Not a damn single person:

Vanderbilt University: COPYRIGHT VANDERBILT UNIVERSITY

closed time in a day

bencooper222

issue commentVandyHacks/vaken

Remove "Copyright Vanderbilt University" from every file

Fixed https://github.com/VandyHacks/vaken/commit/44c2ac4fa2577bd1375cffae11a44062941bf21b

bencooper222

comment created time in a day

push eventVandyHacks/vaken

cktang88

commit sha 44c2ac4fa2577bd1375cffae11a44062941bf21b

Remove copyright

view details

push time in a day

push eventcktang88/Constellation

cktang88

commit sha e715a5675676580d39e82bc772f743b4653d19dd

Fix crash on change game type

view details

push time in a day

delete branch VandyHacks/vaken

delete branch : bencooper222-patch-1

delete time in a day

push eventVandyHacks/vaken

Benjamin Cooper

commit sha 1bc4a49a006db3130b1d61db3d3d7d329e869abe

Update LICENSE

view details

C. K. Tang

commit sha 987a50618ba00329aca1f1944e9a52b41727a006

Merge pull request #36 from VandyHacks/bencooper222-patch-1 Update LICENSE

view details

push time in a day

PR merged VandyHacks/vaken

Reviewers
Update LICENSE

I'm assuming there's no issue but might as well make sure.

+1 -1

0 comment

1 changed file

bencooper222

pr closed time in a day

issue openedVandyHacks/vaken

Remove unused dependences

[ ] Less

  • some other stuff? (audit)

related to #47

created time in a day

issue commentVandyHacks/vaken

Use npm-check

oh actually this doesn't work well for typescript import syntax :(

cktang88

comment created time in a day

issue openedVandyHacks/vaken

Use npm-check

https://www.npmjs.com/package/npm-check

Check for outdated, incorrect, and unused dependencies.

created time in a day

issue commentVandyHacks/vaken

Design documentation system

Fiddly's not really a sufficient docs system, it simply generates a static site from the README.

bencooper222

comment created time in a day

issue closedVandyHacks/vaken

Make an issue labeling system

In particular, we badly need a no -> extreme priority classification system.

closed time in 2 days

bencooper222

issue commentVandyHacks/vaken

Add an editor config

I think we should just let people use their own editor configs

bencooper222

comment created time in 2 days

issue commentVandyHacks/vaken

Make an issue labeling system

i also like this https://medium.com/@dave_lunny/sane-github-labels-c5d2e6004b63

bencooper222

comment created time in 2 days

issue commentVandyHacks/vaken

Make an issue labeling system

how about:

Priority tags [low-priority] [medium-priority] [high-priority]

Type tags [wont-fix] [bug] [enhancement] [question]

Difficulty tags [good first issue] [hard]

bencooper222

comment created time in 2 days

issue commentVandyHacks/vaken

Use GraphQL Inspector?

this seems interesting, probably worth looking into

bencooper222

comment created time in 2 days

issue commentVandyHacks/vaken

Add GitHub apps and integrations

code coverage is gonna be useless until we after we write significant amounts of tests

bencooper222

comment created time in 2 days

issue openedVandyHacks/vaken

Add Husky for precommit hooks

https://github.com/typicode/husky

created time in 2 days

issue openedVandyHacks/vaken

Document components

For each frontend component, at least have a header block comment detailing what is does, and how it is currently used

created time in 2 days

issue openedVandyHacks/vaken

Cite/explain Regex

https://github.com/VandyHacks/vaken/blob/dev/src/common/ValidationFunctions.ts

Where did we get those two regex tests from?

created time in 2 days

issue openedVandyHacks/vaken

OrganizerDash redefines enums

https://github.com/VandyHacks/vaken/blob/dev/src/client/routes/dashboard/OrganizerDash.tsx#L77

Is there a good reason why this redefines many of the enums in /server/enums? Maybe move enums to the /common folder and then refactor?

created time in 2 days

issue openedVandyHacks/vaken

Unify Github/Google OAuth2 auth callback patterns

https://github.com/VandyHacks/vaken/blob/dev/src/server/auth.ts

The Github and Google OAuth2 related code is really similar, can be refactored into common funcs.

created time in 2 days

issue openedVandyHacks/vaken

Unify SSO callback funcs

https://github.com/VandyHacks/vaken/blob/dev/src/server/api/UserRouter.ts

Github and Google SSO callback handlers are basically the same --> refactor as one func taking params.

created time in 2 days

issue openedVandyHacks/vaken

Team model shouldn't keep track of size

Size should be aggregated whenever needed by getting length of array, not separate field. Separate field is easy to forget to update, etc.

created time in 2 days

issue openedVandyHacks/vaken

Unify /data and /models

Unify the models in /server/data and /server/models.

See https://github.com/19majkel94/type-graphql/blob/master/examples/typegoose/entities/recipe.ts

created time in 2 days

issue openedVandyHacks/vaken

Refactor SchoolCounts model

Same as #9 , don't need a separate model for this.

created time in 2 days

issue openedVandyHacks/vaken

Refactor hacker shirt sizes

https://github.com/VandyHacks/vaken/blob/dev/src/server/data/HackerShirtSizes.ts

Why are we keeping track of this in a model? We can aggregate this data in real-time whenever queried.

created time in 2 days

issue openedVandyHacks/vaken

Avoid array with nullable values in hackerList

https://github.com/VandyHacks/vaken/blob/dev/src/server/resolvers/HackerResolver.ts#L53

should make Promise<Hacker> and only push to array if value is not null

created time in 2 days

issue openedVandyHacks/vaken

Minimize use of `any`

There's quite a lot of use of any types throughout several files. Not sure if intentional, but let's try to replace these if we can.

created time in 2 days

startedVandyHacks/vaken

started time in 2 days

push eventcktang88/meta-idle

C. K. Tang

commit sha 91f64e0b8a3dbc3748b4882fdd248ab8b1790447

Update README.md

view details

push time in 2 days

startedsveltejs/svelte

started time in 2 days

startedmikolajdobrucki/ikonate

started time in 5 days

startedspaceuptech/space-cloud

started time in 8 days

startedseek-oss/playroom

started time in 8 days

starteddarkreader/darkreader

started time in 8 days

more