profile
viewpoint

cjgillot/rtti 2

Implementation of multimethods in C++.

cjgillot/cacolac 0

Gyrokinetic linear analysis based on trajectory computation

cjgillot/ChefDep 0

Logiciel pour le suivi du dépannage à la 12F

cjgillot/fipy 0

FiPy is a Finite Volume PDE solver written in Python

cjgillot/fruits 0

Plus de fruits :)

cjgillot/mycas 0

A small symbolic manipulation library inspired from GiNaC.

cjgillot/openfisca-france 0

French tax and benefit system for OpenFisca

cjgillot/rust 0

A safe, concurrent, practical language.

cjgillot/rust-analyzer 0

An experimental Rust compiler front-end for IDEs

cjgillot/salsa 0

A generic framework for on-demand, incrementalized computation. Inspired by adapton, glimmer, and rustc's query system.

delete branch cjgillot/rust

delete branch : clean-cache

delete time in 8 days

delete branch cjgillot/rust

delete branch : rename-depkind

delete time in 8 days

pull request commentrust-lang/rust

Rename rustc_middle::cstore::DepKind to CrateDepKind

Searching for uses of dep_graph::DepKind requires to filter out this other type. In addition, this requires some import gymnastics to avoid having both conflict.

cjgillot

comment created time in 9 days

push eventcjgillot/rust

Camille GILLOT

commit sha 4d4b8f2d4179cf29089c58e0d9a81c8945af4f4a

Rename rustc_middle::cstore::DepKind to DependencyKind.

view details

push time in 9 days

PR opened rust-lang/rust

Introduce an abstraction for EvaluationCache and SelectionCache

The small duplicated code has been moved to librustc_query_system.

The remaining changes are some cleanups of structural impls.

+145 -367

0 comment

8 changed files

pr created time in 9 days

PR opened rust-lang/rust

Rename rustc_middle::cstore::DepKind to DependencyKind.

It is ambiguous with DepGraph's own DepKind.

+35 -35

0 comment

7 changed files

pr created time in 9 days

create barnchcjgillot/rust

branch : clean-cache

created branch time in 9 days

create barnchcjgillot/rust

branch : rename-depkind

created branch time in 9 days

push eventcjgillot/rust

Manish Goregaokar

commit sha ef3dc09fa7078d36ea5831ee9a3eb5c335cdb2f3

Rollup merge of #73989 - RalfJung:ub-enum-test, r=oli-obk adjust ub-enum test to be endianess-independent @cuviper noted that our test fails on "other" endianess systems (I never know which is which^^), so let's fix that.

view details

Manish Goregaokar

commit sha 2ae7d8cdba4ee8584bdcdcd22699d151a6b8959f

Rollup merge of #74045 - tmiasko:config-debug, r=nikomatsakis Explain effects of debugging options from config.toml

view details

Manish Goregaokar

commit sha 427ef98bc3ed87190f389bebc64cc76604c0213a

Rollup merge of #74076 - sunfishcode:wasi-fileext-newmethods, r=alexcrichton Add `read_exact_at` and `write_all_at` to WASI's `FileExt` This adds `read_exact_at` and `write_all_at` to WASI's `FileExt`, similar to the Unix versions of the same names.

view details

Manish Goregaokar

commit sha 2da709ea212871674800c3808e548d756cdca249

Rollup merge of #74099 - jonhoo:deque-range, r=dtolnay Add VecDeque::range* methods This patch adds `VecDeque::range` and `VecDeque::range_mut` to provide iterators over a sub-range of a `VecDeque`. This behavior can be emulated with `skip` and `take`, but directly providing a `Range` is more ergonomic. This also partially makes up for `VecDeque`'s lack of `SliceIndex` support.

view details

Manish Goregaokar

commit sha 3a6209cd706179f7cb639f5688adad5b0dd3ad1c

Rollup merge of #74100 - lzutao:strip-bootstrap, r=Mark-Simulacrum Use str::strip* in bootstrap This is technically a breaking change, replacing the use of `trim_start_matches` with `strip_prefix`. However, because in `rustc -Vv` output there are no lines starting with multiple "release:", this should go unnoticed in practice.

view details

Manish Goregaokar

commit sha fa50a878f5a23411dabcb4ab4a0450ab3a748826

Rollup merge of #74103 - ajpaverd:cfguard-msvc-only, r=nikomatsakis Only add CFGuard on `windows-msvc` targets As @ollie27 pointed out in #73893, the `cfguard` module flag causes incorrect behavior on `windows-gnu` targets. This patch restricts rustc to only add this flag for `windows-msvc` targets (this may need to be changed if other linkers gain support for CFGuard).

view details

Manish Goregaokar

commit sha 8efa197ee4477340095f7455dde2de2c990cace0

Rollup merge of #74109 - nbdd0121:issue-74082, r=petrochenkov Only allow `repr(i128/u128)` on enum Fixes #74082

view details

Manish Goregaokar

commit sha eb1754efec623c7d712104421a58ef61f6e54fe4

Rollup merge of #74122 - nnethercote:startup-cleanup, r=petrochenkov Start-up clean-up r? @petrochenkov

view details

Manish Goregaokar

commit sha 8355024ed0cda6b041bc0adb2ca17193946b6c8e

Rollup merge of #74125 - ayazhafiz:i/74050, r=matthewjasper Correctly mark the ending span of a match arm Closes #74050 r? @matthewjasper

view details

Manish Goregaokar

commit sha d2f8c30951581fa35bde0dbdd3260c5019b50421

Rollup merge of #74127 - tamird:allowlist, r=oli-obk Avoid "whitelist" Other terms are more inclusive and precise.

view details

Manish Goregaokar

commit sha cc3b57fa519c20b03675121aef7bc8b0d7125bd0

Rollup merge of #74129 - matklad:rust-analyzer-2020-07-07, r=Mark-Simulacrum :arrow_up: rust-analyzer This updates rust-analyzer submodule to the latest release. I plan to do that every Monday after rust-analyzer release (about 16:00 CET). This is semi-automated by https://github.com/rust-analyzer/rust-analyzer/pull/5253/files#diff-c06f6a9cbd0ad2421bcc2ddc28805457R77-R100. Who would be the appropriate person to r? on Mondays?

view details

Manish Goregaokar

commit sha b43c26eb9d8ccd830204c7317e9e46241a2dc432

Rollup merge of #74135 - ehuss:update-books, r=ehuss Update books ## book 3 commits in 4e7c00bece1544d409312ec93467beb62b5bd0cb..84a31397b34f9d405df44f2899ff17a4828dba18 2020-06-19 09:39:12 -0400 to 2020-07-04 10:50:18 -0500 - Update Windows install instructions (rust-lang/book#2389) - Update ch01-02-hello-world.md (rust-lang/book#2386) - bump mdbook version in github action (rust-lang/book#2380) ## reference 2 commits in 04d5d5d7ba624b6f5016298451f3a63d557f3260..0ea7bc494f1289234d8800bb9185021e0ad946f0 2020-06-16 15:08:05 -0700 to 2020-07-02 15:33:04 -0700 - Fix mis-capitalization of type name. (rust-lang-nursery/reference#844) - Fix name of trait for array indexing. (rust-lang-nursery/reference#840) ## embedded-book 1 commits in 616962ad0dd80f34d8b802da038d0aed9dd691bb..94d9ea8460bcbbbfef1877b47cb930260b5849a7 2020-06-23 16:03:45 +0000 to 2020-07-05 14:17:40 +0000 - Note on transformation of static variables by attribute exception (rust-embedded/book#251) ## rust-by-example 1 commits in 6f94ccb48da6fa4ed0031290f21411cf789f7d5e..229c6945a26a53a751ffa4f9cb418388c00029d3 2020-06-20 17:51:30 -0300 to 2020-07-06 10:13:15 -0300 - Modify comments (rust-lang/rust-by-example#1359)

view details

Manish Goregaokar

commit sha 8f2304f0c4fa7ffd5fa912e12c90403382c55d00

Rollup merge of #74145 - michaelforney:rust-installer, r=Mark-Simulacrum Update rust-installer to latest version This pulls in a fix for the install script on some tr(1) implementations, as well as an update to use `anyhow` instead of `failure` for error handling.

view details

Manish Goregaokar

commit sha 8376fcd5ce17c9187a08f5bfef56ea36d2a54cf4

Rollup merge of #74161 - tblah:riscv64gc-dockerfile-improvment, r=Mark-Simulacrum Fix disabled dockerfiles When the dockerfiles were moved into the host-x86_64 directory, paths for COPY commands were updated with the new host-x86_64/ prefix. This suggested that the intended context was src/ci/docker. However, the context for disabled docker images was src/ci/docker/host-x86_64. This broke the new paths and prevented src/ci/docker/scripts from being included in the context at all. This commit corrects this context allowing docker to find the files it needs for COPY commands. Also includes a quick fix to riscv recommended by @bjorn3

view details

Manish Goregaokar

commit sha 79fc3861dfd1190b257ef7f4208533c3945254b7

Rollup merge of #74162 - lcnr:ToPredicate-no-ref, r=varkor take self by value in ToPredicate

view details

bors

commit sha 346aec9b02f3c74f3fce97fd6bda24709d220e49

Auto merge of #74235 - Manishearth:rollup-bgs3q14, r=Manishearth Rollup of 19 pull requests Successful merges: - #71322 (Accept tuple.0.0 as tuple indexing (take 2)) - #72303 (Add core::future::{poll_fn, PollFn}) - #73862 (Stabilize casts and coercions to `&[T]` in const fn) - #73887 (stabilize const mem::forget) - #73989 (adjust ub-enum test to be endianess-independent) - #74045 (Explain effects of debugging options from config.toml) - #74076 (Add `read_exact_at` and `write_all_at` to WASI's `FileExt`) - #74099 (Add VecDeque::range* methods) - #74100 (Use str::strip* in bootstrap) - #74103 (Only add CFGuard on `windows-msvc` targets) - #74109 (Only allow `repr(i128/u128)` on enum) - #74122 (Start-up clean-up) - #74125 (Correctly mark the ending span of a match arm) - #74127 (Avoid "whitelist") - #74129 (:arrow_up: rust-analyzer) - #74135 (Update books) - #74145 (Update rust-installer to latest version) - #74161 (Fix disabled dockerfiles) - #74162 (take self by value in ToPredicate) Failed merges: r? @ghost

view details

Oliver Scherer

commit sha dd872be5da0887d800ae9a001ec212c7161f661c

Stabilize `transmute` in constants and statics but not const fn

view details

Oliver Scherer

commit sha 1eb0053dcddcb55e46f8ba5b4083f7a3f5872be0

Stabilize `transmute` in constants and statics but not const fn

view details

Dennis Hamester

commit sha 689e360d8273ed13e433ce3e7ae1046e33894234

test: rustdoc-ui: Add issue-74134, replacing test/rustdoc/issue-74134-* As per the discussion in PR #74147, the 4 individual tests are replaced by a single one. The test is expanded to cover all 4 public/private cases, each with and without --document-private-items.

view details

Dennis Hamester

commit sha 97048595e1e7bf3fc270ecf14ccaaac4cc71a241

test: rustdoc-ui: Expand issue-74134 to cover types in a private module

view details

push time in 13 days

push eventcjgillot/rust

Manish Goregaokar

commit sha 089a6e15f662cf4eaa502bbe84504dedc6fc4b0d

Rollup merge of #74146 - RalfJung:miri, r=RalfJung update miri Fixes https://github.com/rust-lang/rust/issues/74132 Cc @rust-lang/miri r? @ghost

view details

Manish Goregaokar

commit sha d4d11118ef55501a73d423651e45c0102afd0209

Rollup merge of #74150 - tamird:blocklist, r=nikomatsakis Avoid "blacklist" Other terms are more inclusive and precise. Clippy still has a lint named "blacklisted-name", but renaming it would be a breaking change, so is left for future work. The target configuration option "abi-blacklist" has been depreciated and renamed to "unsupported-abis". The old name continues to work.

view details

Manish Goregaokar

commit sha 31d53decd06f9cd854bbfe11f03abcd398e396b6

Rollup merge of #74184 - Manishearth:doc-intra-doc, r=GuillaumeGomez Add docs for intra-doc-links Fixes https://github.com/rust-lang/rust/issues/66000 Hmm, for some reason my push closed the previous PR

view details

Manish Goregaokar

commit sha 9353e21bfdea148e910b2530270a3418db836bf3

Rollup merge of #74188 - estebank:tweak-ascription-typo-heuristic, r=petrochenkov Tweak `::` -> `:` typo heuristic and reduce verbosity Do not trigger on correct type ascription expressions with trailing operators and _do_ trigger on likely path typos where a turbofish is used. On likely path typos, remove note explaining type ascription. Clean up indentation. r? @petrochenkov

view details

Guillaume Gomez

commit sha 970174a1e5d45f82608fdc220de99f34eccb2008

Add option to collapse automatically implementors

view details

Esteban Küber

commit sha 520fb92c33e8f446349c76103da5b204ff2ad9dc

Reword incorrect `self` token suggestion

view details

bors

commit sha e59b08e62ea691916d2f063cac5aab4634128022

Auto merge of #74195 - Manishearth:rollup-h3m0sl8, r=Manishearth Rollup of 14 pull requests Successful merges: - #73292 (Fixing broken link for the Eq trait) - #73791 (Allow for parentheses after macro intra-doc-links) - #74070 ( Use for<'tcx> fn pointers in Providers, instead of having Providers<'tcx>.) - #74077 (Use relative path for local links to primitives) - #74079 (Eliminate confusing "globals" terminology.) - #74107 (Hide `&mut self` methods from Deref in sidebar if there are no `DerefMut` impl for the type.) - #74136 (Fix broken link in rustdocdoc) - #74137 (Update cargo) - #74142 (Liballoc use vec instead of vector) - #74143 (Try remove unneeded ToString import in liballoc slice) - #74146 (update miri) - #74150 (Avoid "blacklist") - #74184 (Add docs for intra-doc-links) - #74188 (Tweak `::` -> `:` typo heuristic and reduce verbosity) Failed merges: - #74122 (Start-up clean-up) - #74127 (Avoid "whitelist") r? @ghost

view details

Yuki Okushi

commit sha 6864546049d8f41b0521ee7dc5dedac4850f6c88

Add a help to use `in_band_lifetimes` in nightly

view details

Yuki Okushi

commit sha a9b64766a47ce7a0ad6768b7a74bae7fa991576e

Tweak wording

view details

Nicholas Nethercote

commit sha 0a7d2970e5947e7a2940a32e6975817a389b0708

Eliminate `rust_input`. It has a single call site and having it as a separate (higher-order!) function makes the code harder to read.

view details

Nicholas Nethercote

commit sha 1e8ec2db1d3d695958a8040fbb3491a4378ef7ae

Add an explanatory comment to `scoped_thread`.

view details

Nicholas Nethercote

commit sha 4ad5de22d182578e846a6ccc69940e76a820381c

Tweak `spawn_thread_pool`. This makes the two versions (parallel and non-parallel) more similar to each other.

view details

Nicholas Nethercote

commit sha bf7078615b868f7359bff58933fd5236fabe7280

Change some function names. A couple of these are quite long, but they do a much better job of explaining what they do, which was non-obvious before.

view details

Lzu Tao

commit sha 481988b0832de4b28fd1f4a52f0df2801f62bda8

Use str::strip* in bootstrap This commit replaces the use of `trim_start_matches` because in `rustc -Vv` output there are no lines starting with multiple "release:".

view details

Ivan Tham

commit sha 1fb0ed0e2ce788d8f69969bdb81967ca3c9a7f26

Minor refactor for rustc_resolve diagnostics match Use `matches!` instead of old `if let`

view details

Andrew Paverd

commit sha 1ca7bfe481a18909e4769a9f6aee58f8cec17b44

Only add cfguard module flag on windows-msvc

view details

Caio

commit sha c3756927478afe8d3a880edc469afd766c2f9e82

Remove some Default impls

view details

Tamir Duberstein

commit sha 62cf767a4a39b47677d18110359d9e7152dc9d1c

Avoid "whitelist" Other terms are more inclusive and precise.

view details

Tamir Duberstein

commit sha cf91c54cc6e20462bf6c5c63a3ab0b6afe8b7f0e

Avoid "whitelist" Other terms are more inclusive and precise.

view details

Christian Duerr

commit sha 298a1fa3bd8ec04350b1bff6a6d92e34abf2e198

Move range_minus_one to pedantic This moves the range_minus_one lint to the pedantic category, so there will not be any warnings emitted by default. This should work around problems where the suggestion is impossible to resolve due to the range consumer only accepting a specific range implementation, rather than the `RangeBounds` trait (see #3307). While it is possible to work around this by extracting the boundary into a variable, I don't think clippy should encourage people to disable or work around lints, but instead the lints should be fixable. So hopefully this will help until a proper implementation checks what the range is used for.

view details

push time in 14 days

push eventcjgillot/rust

Erik Desjardins

commit sha 23d7b3f6f1a345ad95f0812c85613627164b6c39

Remove an unwrap in layout computation

view details

Mohsen Zohrevandi

commit sha 1466598e19321bc6b97aef8271a317e78211d54d

Address review comments

view details

Manish Goregaokar

commit sha ec1e7e9dbc83e57da7809cfc32c01e881b42555b

Rollup merge of #71322 - petrochenkov:tuple00, r=nikomatsakis Accept tuple.0.0 as tuple indexing (take 2) If we expect something identifier-like when parsing a field name after `.`, but encounter a float token, we break that float token into parts, similarly to how we break `&&` into `&` `&`, or `<<` into `<` `<`, etc. An alternative to https://github.com/rust-lang/rust/pull/70420.

view details

Manish Goregaokar

commit sha d82588b45aa866418a3cc88924e939015fd1bd1c

Rollup merge of #72303 - yoshuawuyts:future-poll-fn, r=dtolnay Add core::future::{poll_fn, PollFn} This is a sibling PR to #70834, adding `future::poll_fn`. This is a small helper function that helps bridge the gap between "poll state machines" and "async/await". It was first introduced in [futures@0.1.7](https://docs.rs/futures/0.1.7/futures/future/fn.poll_fn.html) in December of 2016, and has been tried and tested as part of the ecosystem for the past 3.5 years. ## Implementation Much of the same reasoning from #70834 applies: by returning a concrete struct rather than an `async fn` we get to mark the future as `Unpin`. It also becomes named which allows storing it in structs without boxing. This implementation has been modified from the implementation in `futures-rs`. ## References - [`futures::future::poll_fn`](https://docs.rs/futures/0.3.5/futures/future/fn.poll_fn.html) - [`async_std::future::poll_fn`](https://docs.rs/async-std/1.5.0/async_std/future/fn.poll_fn.html)

view details

Manish Goregaokar

commit sha f4f969027c6378264be509ba5ae512e35258f2e5

Rollup merge of #73862 - oli-obk:const_array_to_slice, r=RalfJung Stabilize casts and coercions to `&[T]` in const fn Part of #64992 There was never a reason to not stabilize this, we just accidentally prevented them when we implemented the `min_const_fn` feature that gave us `const fn` on stable. This PR stabilizes these casts (which are already stable in `const` outside `const fn`), while keeping all other unsizing casts (so `T` -> `dyn Trait`) unstable within const fn. These casts have no forward compatibility concerns with any future features for const eval and users were able to use them under the `const_fn` feature gate already since at least the miri merger, possibly longer. r? @rust-lang/lang

view details

Manish Goregaokar

commit sha efda2b58b095306d068a3a165de62acd1e94911b

Rollup merge of #73887 - DutchGhost:master, r=oli-obk stabilize const mem::forget Stabilizes const `mem::forget` as implemented in https://github.com/rust-lang/rust/pull/69617 and tracked in https://github.com/rust-lang/rust/issues/69616. Closes https://github.com/rust-lang/rust/issues/69616

view details

Manish Goregaokar

commit sha ef3dc09fa7078d36ea5831ee9a3eb5c335cdb2f3

Rollup merge of #73989 - RalfJung:ub-enum-test, r=oli-obk adjust ub-enum test to be endianess-independent @cuviper noted that our test fails on "other" endianess systems (I never know which is which^^), so let's fix that.

view details

Manish Goregaokar

commit sha 2ae7d8cdba4ee8584bdcdcd22699d151a6b8959f

Rollup merge of #74045 - tmiasko:config-debug, r=nikomatsakis Explain effects of debugging options from config.toml

view details

Manish Goregaokar

commit sha 427ef98bc3ed87190f389bebc64cc76604c0213a

Rollup merge of #74076 - sunfishcode:wasi-fileext-newmethods, r=alexcrichton Add `read_exact_at` and `write_all_at` to WASI's `FileExt` This adds `read_exact_at` and `write_all_at` to WASI's `FileExt`, similar to the Unix versions of the same names.

view details

Manish Goregaokar

commit sha 2da709ea212871674800c3808e548d756cdca249

Rollup merge of #74099 - jonhoo:deque-range, r=dtolnay Add VecDeque::range* methods This patch adds `VecDeque::range` and `VecDeque::range_mut` to provide iterators over a sub-range of a `VecDeque`. This behavior can be emulated with `skip` and `take`, but directly providing a `Range` is more ergonomic. This also partially makes up for `VecDeque`'s lack of `SliceIndex` support.

view details

Manish Goregaokar

commit sha 3a6209cd706179f7cb639f5688adad5b0dd3ad1c

Rollup merge of #74100 - lzutao:strip-bootstrap, r=Mark-Simulacrum Use str::strip* in bootstrap This is technically a breaking change, replacing the use of `trim_start_matches` with `strip_prefix`. However, because in `rustc -Vv` output there are no lines starting with multiple "release:", this should go unnoticed in practice.

view details

Manish Goregaokar

commit sha fa50a878f5a23411dabcb4ab4a0450ab3a748826

Rollup merge of #74103 - ajpaverd:cfguard-msvc-only, r=nikomatsakis Only add CFGuard on `windows-msvc` targets As @ollie27 pointed out in #73893, the `cfguard` module flag causes incorrect behavior on `windows-gnu` targets. This patch restricts rustc to only add this flag for `windows-msvc` targets (this may need to be changed if other linkers gain support for CFGuard).

view details

Manish Goregaokar

commit sha 8efa197ee4477340095f7455dde2de2c990cace0

Rollup merge of #74109 - nbdd0121:issue-74082, r=petrochenkov Only allow `repr(i128/u128)` on enum Fixes #74082

view details

Manish Goregaokar

commit sha eb1754efec623c7d712104421a58ef61f6e54fe4

Rollup merge of #74122 - nnethercote:startup-cleanup, r=petrochenkov Start-up clean-up r? @petrochenkov

view details

Manish Goregaokar

commit sha 8355024ed0cda6b041bc0adb2ca17193946b6c8e

Rollup merge of #74125 - ayazhafiz:i/74050, r=matthewjasper Correctly mark the ending span of a match arm Closes #74050 r? @matthewjasper

view details

Manish Goregaokar

commit sha d2f8c30951581fa35bde0dbdd3260c5019b50421

Rollup merge of #74127 - tamird:allowlist, r=oli-obk Avoid "whitelist" Other terms are more inclusive and precise.

view details

Manish Goregaokar

commit sha cc3b57fa519c20b03675121aef7bc8b0d7125bd0

Rollup merge of #74129 - matklad:rust-analyzer-2020-07-07, r=Mark-Simulacrum :arrow_up: rust-analyzer This updates rust-analyzer submodule to the latest release. I plan to do that every Monday after rust-analyzer release (about 16:00 CET). This is semi-automated by https://github.com/rust-analyzer/rust-analyzer/pull/5253/files#diff-c06f6a9cbd0ad2421bcc2ddc28805457R77-R100. Who would be the appropriate person to r? on Mondays?

view details

Manish Goregaokar

commit sha b43c26eb9d8ccd830204c7317e9e46241a2dc432

Rollup merge of #74135 - ehuss:update-books, r=ehuss Update books ## book 3 commits in 4e7c00bece1544d409312ec93467beb62b5bd0cb..84a31397b34f9d405df44f2899ff17a4828dba18 2020-06-19 09:39:12 -0400 to 2020-07-04 10:50:18 -0500 - Update Windows install instructions (rust-lang/book#2389) - Update ch01-02-hello-world.md (rust-lang/book#2386) - bump mdbook version in github action (rust-lang/book#2380) ## reference 2 commits in 04d5d5d7ba624b6f5016298451f3a63d557f3260..0ea7bc494f1289234d8800bb9185021e0ad946f0 2020-06-16 15:08:05 -0700 to 2020-07-02 15:33:04 -0700 - Fix mis-capitalization of type name. (rust-lang-nursery/reference#844) - Fix name of trait for array indexing. (rust-lang-nursery/reference#840) ## embedded-book 1 commits in 616962ad0dd80f34d8b802da038d0aed9dd691bb..94d9ea8460bcbbbfef1877b47cb930260b5849a7 2020-06-23 16:03:45 +0000 to 2020-07-05 14:17:40 +0000 - Note on transformation of static variables by attribute exception (rust-embedded/book#251) ## rust-by-example 1 commits in 6f94ccb48da6fa4ed0031290f21411cf789f7d5e..229c6945a26a53a751ffa4f9cb418388c00029d3 2020-06-20 17:51:30 -0300 to 2020-07-06 10:13:15 -0300 - Modify comments (rust-lang/rust-by-example#1359)

view details

Manish Goregaokar

commit sha 8f2304f0c4fa7ffd5fa912e12c90403382c55d00

Rollup merge of #74145 - michaelforney:rust-installer, r=Mark-Simulacrum Update rust-installer to latest version This pulls in a fix for the install script on some tr(1) implementations, as well as an update to use `anyhow` instead of `failure` for error handling.

view details

Manish Goregaokar

commit sha 8376fcd5ce17c9187a08f5bfef56ea36d2a54cf4

Rollup merge of #74161 - tblah:riscv64gc-dockerfile-improvment, r=Mark-Simulacrum Fix disabled dockerfiles When the dockerfiles were moved into the host-x86_64 directory, paths for COPY commands were updated with the new host-x86_64/ prefix. This suggested that the intended context was src/ci/docker. However, the context for disabled docker images was src/ci/docker/host-x86_64. This broke the new paths and prevented src/ci/docker/scripts from being included in the context at all. This commit corrects this context allowing docker to find the files it needs for COPY commands. Also includes a quick fix to riscv recommended by @bjorn3

view details

push time in 14 days

push eventcjgillot/rust

Nicholas Nethercote

commit sha 0a7d2970e5947e7a2940a32e6975817a389b0708

Eliminate `rust_input`. It has a single call site and having it as a separate (higher-order!) function makes the code harder to read.

view details

Nicholas Nethercote

commit sha 1e8ec2db1d3d695958a8040fbb3491a4378ef7ae

Add an explanatory comment to `scoped_thread`.

view details

Nicholas Nethercote

commit sha 4ad5de22d182578e846a6ccc69940e76a820381c

Tweak `spawn_thread_pool`. This makes the two versions (parallel and non-parallel) more similar to each other.

view details

Nicholas Nethercote

commit sha bf7078615b868f7359bff58933fd5236fabe7280

Change some function names. A couple of these are quite long, but they do a much better job of explaining what they do, which was non-obvious before.

view details

Lzu Tao

commit sha 481988b0832de4b28fd1f4a52f0df2801f62bda8

Use str::strip* in bootstrap This commit replaces the use of `trim_start_matches` because in `rustc -Vv` output there are no lines starting with multiple "release:".

view details

Ivan Tham

commit sha 1fb0ed0e2ce788d8f69969bdb81967ca3c9a7f26

Minor refactor for rustc_resolve diagnostics match Use `matches!` instead of old `if let`

view details

Andrew Paverd

commit sha 1ca7bfe481a18909e4769a9f6aee58f8cec17b44

Only add cfguard module flag on windows-msvc

view details

Caio

commit sha c3756927478afe8d3a880edc469afd766c2f9e82

Remove some Default impls

view details

Tamir Duberstein

commit sha 62cf767a4a39b47677d18110359d9e7152dc9d1c

Avoid "whitelist" Other terms are more inclusive and precise.

view details

Tamir Duberstein

commit sha cf91c54cc6e20462bf6c5c63a3ab0b6afe8b7f0e

Avoid "whitelist" Other terms are more inclusive and precise.

view details

Christian Duerr

commit sha 298a1fa3bd8ec04350b1bff6a6d92e34abf2e198

Move range_minus_one to pedantic This moves the range_minus_one lint to the pedantic category, so there will not be any warnings emitted by default. This should work around problems where the suggestion is impossible to resolve due to the range consumer only accepting a specific range implementation, rather than the `RangeBounds` trait (see #3307). While it is possible to work around this by extracting the boundary into a variable, I don't think clippy should encourage people to disable or work around lints, but instead the lints should be fixable. So hopefully this will help until a proper implementation checks what the range is used for.

view details

Christian Duerr

commit sha ba2a85dadc61bbfeb483ca0d05ddfda213da1329

Run update_lints

view details

Jon Gjengset

commit sha a1a19cbbe1c17dc03ca689db002181c9bd95f529

Add tracking issue

view details

Pietro Albini

commit sha 34994a9ebc1d34be79031c2b5e857f9ad24f268e

ci: allow gating gha on everything but macOS In our GitHub Actions setup macOS is too unreliable to gate on it, but the other builders work fine. This commit splits the macOS builders into a separate job (called auto-fallible), allowing us to gate on the auto job without failing due to macOS spurious failures.

view details

bors

commit sha daecab3a784f28082df90cebb204998051f3557d

Auto merge of #74181 - pietroalbini:ci-gha-fallible-macos, r=Mark-Simulacrum Gate GHA on everything but macOS The macOS spurious failure started happening again. As we discussed during the infra team meeting, this gates on everything but macOS. r? @Mark-Simulacrum

view details

Guillaume Gomez

commit sha 2ca24b618e40e92f8061419928dcd0f1f15527e5

Add margin after doc search results

view details

Takayuki Nakata

commit sha 780a4c87de88d7f747c7847b71c90c8268fe4b66

Fix typo

view details

Christian Duerr

commit sha b3c719608d2c969323714517837f0c68aca23d81

Fix test failures

view details

Christian Duerr

commit sha afa4148cc6dee0f9e0ca5b33f2511b9305d84fcb

Fix tests a bit more

view details

bors

commit sha 7d611d92240d43d9a04cf8db0cb4fb5690f8249c

Auto merge of #5769 - robojumper:match_like_matches_macro, r=phansch new lint: match_like_matches_macro Suggests using the `matches!` macro from `std` where appropriate. `redundant_pattern_matching` has been moved into the `matches` pass to allow suppressing the suggestion where `is_some` and friends are a better replacement. changelog: new lint: `match_like_matches_macro`

view details

push time in 14 days

startedchristianpoveda/sire

started time in 20 days

issue openedjbigot/zpp

Issue line number directives

Understanding compilation errors in the zpp output can be challenging because of mismatching line numbers.

C family languages support #line directives. Those can be used to re-sync the compiler diagnostics to the pre-zpp input file.

I have a prototype implementation in gysela merge 633.

created time in a month

issue openedjbigot/zpp

Make bash more strict

Bash has a lot of implicit semantics for non-existent variables. This can cause competing directives (like $OMP) to be eaten silently.

Setting a stricter mode for bash by default can help a lot.

set -e # Abort on first error
set -u # Err on undefined variable
set -o pipefail # Err on redirection failure

This would be a breaking change. The zpp standard library is not set -u safe. See gysela merge !633 for a few examples.

created time in a month

fork cjgillot/zpp

The "Z" pre-processor, the last preprocessor you'll ever need

fork in a month

Pull request review commentrust-lang/rust

Const prop: erase all block-only locals at the end of every block

 impl<'mir, 'tcx> MutVisitor<'tcx> for ConstPropagator<'mir, 'tcx> {                 }             }         }-        // We remove all Locals which are restricted in propagation to their containing blocks.-        for local in self.locals_of_current_block.iter() {++        // We remove all Locals which are restricted in propagation to their containing blocks and+        // which were modified in the current block.+        // Take it out of the ecx so we can get a mutable reference to the ecx for `remove_const`+        let mut locals = std::mem::take(&mut self.ecx.machine.written_only_inside_own_block_locals);+        for &local in locals.iter() {             Self::remove_const(&mut self.ecx, local);         }-        self.locals_of_current_block.clear();+        locals.clear();+        // Put it back so we reuse the heap of the storage+        self.ecx.machine.written_only_inside_own_block_locals = locals;+        if cfg!(debug_assertions) {+            // Ensure we are correctly erasing locals with the non-debug-assert logic.+            for local in self.ecx.machine.only_propagate_inside_block_locals.iter() {

This loop does not do anything, since written_only_inside_own_block_locals (ie. locals) has just been cleared.

oli-obk

comment created time in a month

push eventcjgillot/rust

mibac138

commit sha d4fe9553f65df51a18999e956fd507e26271e74e

Implement partial error recovery for `let` with `BinOpEq` When parsing `let x: i8 += 1` the compiler interprets `i8` as a trait which makes it more complicated to do error recovery. More advanced error recovery is not implemented in this commit.

view details

mibac138

commit sha 48ff12acb184672393692e087927a66ff7907d71

Expand partial error recovery for `let` with `BinOpEq`

view details

mibac138

commit sha 05d653199871955eba90abdd3b176603f030ab60

Error recovery for `let` with `+=`

view details

mibac138

commit sha 6ad24baf06c687517f188e8c6e6ce848924d001c

Adjust according to estebank's review comments

view details

mibac138

commit sha 98532a30901d7544c49fe82f499db53699645de0

Adjust according to petrochenkov's review comments

view details

Rich Kadel

commit sha a6127e3fde9e8d24388847ad1b442a4337f19965

Merge pull request #1 from rust-lang/master update from upstream

view details

Benjamin Saunders

commit sha 730f7366bba5abdf5ae0c2f1222795e40d48f90c

Fix asinh of negative values When `x` has large magnitude, `x + ((x * x) + 1.0).sqrt()` approaches `x + x.abs()`. For negative values of `x`, this leads to catastrophic cancellation, resulting in large errors or even 0 being passed to `ln`, producing incorrect results including `-inf`. Becuase asinh is an odd function, i.e. -asinh(x) = asinh(-x) for all x, we can avoid the catastrophic cancellation and obtain correct results by taking the absolute value of `self` for the first term. `self * self` is always positive, so in effect this gives us `x.abs().asinh().copysign(x)` which as discussed above is algebraically equivalent, but is much more accurate.

view details

Aaron Hill

commit sha ebe5a916b08d5d58b03fe551a95038d9cf964781

Properly encode AnonConst into crate metadata Fixes #68104 Previous, we were encoding AnonConst as a regular Const, causing us to treat them differently after being deserialized in another compilation session.

view details

Mikail Bagishov

commit sha 591584e71f7d8a613d586066c8b01c1eecf08f35

Add tests for 'impl Default for [T; N]'

view details

Bastian Kauschke

commit sha b3aa5e38107df9e9b16a0a003afaa3d12d80bb86

add str to common types

view details

Mikail Bagishov

commit sha 3313bf62ac45fab2c39e49c788423153754087a9

Skip leak test on targets without panic=unwind

view details

Ralf Jung

commit sha f7d745f33d950c050e0a5a2ee2ee9f0e1269e956

tag/niche terminology cleanup

view details

Ralf Jung

commit sha 7a6d03c2699787644b44f7bc3e8252d1508880b8

miri errors: rename InvalidDiscriminant -> InvalidTag

view details

Vadim Petrochenkov

commit sha d1c275b350f9ae74be92114f4819d6afb55d6007

linker: MSVC supports linking static libraries as a whole archive

view details

Carol (Nichols || Goulding)

commit sha 1bc4e45b3fe3a0817908bd7cc21ec23798d38d63

Only highlight results via mouseover if mouse has moved

view details

Yoshua Wuyts

commit sha 2764e54c29d0f19242e794d5eecd00cc5470f530

impl ToSocketAddrs for (String, u16)

view details

Nathan Corbyn

commit sha df996e8e12b094e3aedfe0e35c2a8ded57f56890

Make `need_type_info_err` more conservative

view details

Nathan Corbyn

commit sha b4ddd9183103586ba1456241b9c117a420bb6d6b

Add FIXME to comment regarding local patterns Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>

view details

Oliver Scherer

commit sha 20abc70e04eefa252e5a8bfe934cb54c51c1da37

Don't intern memory in const prop. This isn't sound without validation. We don't want to report errors in case of failure to intern and validate, we just don't want to const prop. Interning and const prop is not built for this, let's not do it until we have a clearer picture on aggregate propagation.

view details

Wesley Wiser

commit sha 1e88f130a347f8b223031eafe75c0772ccfec00c

Stop allowing `Indirect(..)` values to be propagated Closes #72679 Closes #72372 Closes #72285

view details

push time in 2 months

create barnchcjgillot/rust

branch : split-query

created branch time in 2 months

pull request commentrust-lang/rust

Remove Spans from HIR -- 1/N -- Span collection

I have not managed to mitigate the perf regression. Still looking.

cjgillot

comment created time in 2 months

push eventcjgillot/rust

mibac138

commit sha d4fe9553f65df51a18999e956fd507e26271e74e

Implement partial error recovery for `let` with `BinOpEq` When parsing `let x: i8 += 1` the compiler interprets `i8` as a trait which makes it more complicated to do error recovery. More advanced error recovery is not implemented in this commit.

view details

mibac138

commit sha 48ff12acb184672393692e087927a66ff7907d71

Expand partial error recovery for `let` with `BinOpEq`

view details

mibac138

commit sha 05d653199871955eba90abdd3b176603f030ab60

Error recovery for `let` with `+=`

view details

mibac138

commit sha 6ad24baf06c687517f188e8c6e6ce848924d001c

Adjust according to estebank's review comments

view details

mibac138

commit sha 98532a30901d7544c49fe82f499db53699645de0

Adjust according to petrochenkov's review comments

view details

Rich Kadel

commit sha a6127e3fde9e8d24388847ad1b442a4337f19965

Merge pull request #1 from rust-lang/master update from upstream

view details

Benjamin Saunders

commit sha 730f7366bba5abdf5ae0c2f1222795e40d48f90c

Fix asinh of negative values When `x` has large magnitude, `x + ((x * x) + 1.0).sqrt()` approaches `x + x.abs()`. For negative values of `x`, this leads to catastrophic cancellation, resulting in large errors or even 0 being passed to `ln`, producing incorrect results including `-inf`. Becuase asinh is an odd function, i.e. -asinh(x) = asinh(-x) for all x, we can avoid the catastrophic cancellation and obtain correct results by taking the absolute value of `self` for the first term. `self * self` is always positive, so in effect this gives us `x.abs().asinh().copysign(x)` which as discussed above is algebraically equivalent, but is much more accurate.

view details

Aaron Hill

commit sha ebe5a916b08d5d58b03fe551a95038d9cf964781

Properly encode AnonConst into crate metadata Fixes #68104 Previous, we were encoding AnonConst as a regular Const, causing us to treat them differently after being deserialized in another compilation session.

view details

Mikail Bagishov

commit sha 591584e71f7d8a613d586066c8b01c1eecf08f35

Add tests for 'impl Default for [T; N]'

view details

Bastian Kauschke

commit sha b3aa5e38107df9e9b16a0a003afaa3d12d80bb86

add str to common types

view details

Mikail Bagishov

commit sha 3313bf62ac45fab2c39e49c788423153754087a9

Skip leak test on targets without panic=unwind

view details

Ralf Jung

commit sha f7d745f33d950c050e0a5a2ee2ee9f0e1269e956

tag/niche terminology cleanup

view details

Ralf Jung

commit sha 7a6d03c2699787644b44f7bc3e8252d1508880b8

miri errors: rename InvalidDiscriminant -> InvalidTag

view details

Vadim Petrochenkov

commit sha d1c275b350f9ae74be92114f4819d6afb55d6007

linker: MSVC supports linking static libraries as a whole archive

view details

Carol (Nichols || Goulding)

commit sha 1bc4e45b3fe3a0817908bd7cc21ec23798d38d63

Only highlight results via mouseover if mouse has moved

view details

Yoshua Wuyts

commit sha 2764e54c29d0f19242e794d5eecd00cc5470f530

impl ToSocketAddrs for (String, u16)

view details

Nathan Corbyn

commit sha df996e8e12b094e3aedfe0e35c2a8ded57f56890

Make `need_type_info_err` more conservative

view details

Nathan Corbyn

commit sha b4ddd9183103586ba1456241b9c117a420bb6d6b

Add FIXME to comment regarding local patterns Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>

view details

Oliver Scherer

commit sha 20abc70e04eefa252e5a8bfe934cb54c51c1da37

Don't intern memory in const prop. This isn't sound without validation. We don't want to report errors in case of failure to intern and validate, we just don't want to const prop. Interning and const prop is not built for this, let's not do it until we have a clearer picture on aggregate propagation.

view details

Wesley Wiser

commit sha 1e88f130a347f8b223031eafe75c0772ccfec00c

Stop allowing `Indirect(..)` values to be propagated Closes #72679 Closes #72372 Closes #72285

view details

push time in 2 months

push eventcjgillot/rust

mibac138

commit sha d4fe9553f65df51a18999e956fd507e26271e74e

Implement partial error recovery for `let` with `BinOpEq` When parsing `let x: i8 += 1` the compiler interprets `i8` as a trait which makes it more complicated to do error recovery. More advanced error recovery is not implemented in this commit.

view details

mibac138

commit sha 48ff12acb184672393692e087927a66ff7907d71

Expand partial error recovery for `let` with `BinOpEq`

view details

mibac138

commit sha 05d653199871955eba90abdd3b176603f030ab60

Error recovery for `let` with `+=`

view details

mibac138

commit sha 6ad24baf06c687517f188e8c6e6ce848924d001c

Adjust according to estebank's review comments

view details

mibac138

commit sha 98532a30901d7544c49fe82f499db53699645de0

Adjust according to petrochenkov's review comments

view details

Rich Kadel

commit sha a6127e3fde9e8d24388847ad1b442a4337f19965

Merge pull request #1 from rust-lang/master update from upstream

view details

Benjamin Saunders

commit sha 730f7366bba5abdf5ae0c2f1222795e40d48f90c

Fix asinh of negative values When `x` has large magnitude, `x + ((x * x) + 1.0).sqrt()` approaches `x + x.abs()`. For negative values of `x`, this leads to catastrophic cancellation, resulting in large errors or even 0 being passed to `ln`, producing incorrect results including `-inf`. Becuase asinh is an odd function, i.e. -asinh(x) = asinh(-x) for all x, we can avoid the catastrophic cancellation and obtain correct results by taking the absolute value of `self` for the first term. `self * self` is always positive, so in effect this gives us `x.abs().asinh().copysign(x)` which as discussed above is algebraically equivalent, but is much more accurate.

view details

Aaron Hill

commit sha ebe5a916b08d5d58b03fe551a95038d9cf964781

Properly encode AnonConst into crate metadata Fixes #68104 Previous, we were encoding AnonConst as a regular Const, causing us to treat them differently after being deserialized in another compilation session.

view details

Mikail Bagishov

commit sha 591584e71f7d8a613d586066c8b01c1eecf08f35

Add tests for 'impl Default for [T; N]'

view details

Bastian Kauschke

commit sha b3aa5e38107df9e9b16a0a003afaa3d12d80bb86

add str to common types

view details

Mikail Bagishov

commit sha 3313bf62ac45fab2c39e49c788423153754087a9

Skip leak test on targets without panic=unwind

view details

Ralf Jung

commit sha f7d745f33d950c050e0a5a2ee2ee9f0e1269e956

tag/niche terminology cleanup

view details

Ralf Jung

commit sha 7a6d03c2699787644b44f7bc3e8252d1508880b8

miri errors: rename InvalidDiscriminant -> InvalidTag

view details

Vadim Petrochenkov

commit sha d1c275b350f9ae74be92114f4819d6afb55d6007

linker: MSVC supports linking static libraries as a whole archive

view details

Carol (Nichols || Goulding)

commit sha 1bc4e45b3fe3a0817908bd7cc21ec23798d38d63

Only highlight results via mouseover if mouse has moved

view details

Yoshua Wuyts

commit sha 2764e54c29d0f19242e794d5eecd00cc5470f530

impl ToSocketAddrs for (String, u16)

view details

Nathan Corbyn

commit sha df996e8e12b094e3aedfe0e35c2a8ded57f56890

Make `need_type_info_err` more conservative

view details

Nathan Corbyn

commit sha b4ddd9183103586ba1456241b9c117a420bb6d6b

Add FIXME to comment regarding local patterns Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>

view details

Oliver Scherer

commit sha 20abc70e04eefa252e5a8bfe934cb54c51c1da37

Don't intern memory in const prop. This isn't sound without validation. We don't want to report errors in case of failure to intern and validate, we just don't want to const prop. Interning and const prop is not built for this, let's not do it until we have a clearer picture on aggregate propagation.

view details

Wesley Wiser

commit sha 1e88f130a347f8b223031eafe75c0772ccfec00c

Stop allowing `Indirect(..)` values to be propagated Closes #72679 Closes #72372 Closes #72285

view details

push time in 2 months

push eventcjgillot/rust

mibac138

commit sha d4fe9553f65df51a18999e956fd507e26271e74e

Implement partial error recovery for `let` with `BinOpEq` When parsing `let x: i8 += 1` the compiler interprets `i8` as a trait which makes it more complicated to do error recovery. More advanced error recovery is not implemented in this commit.

view details

mibac138

commit sha 48ff12acb184672393692e087927a66ff7907d71

Expand partial error recovery for `let` with `BinOpEq`

view details

mibac138

commit sha 05d653199871955eba90abdd3b176603f030ab60

Error recovery for `let` with `+=`

view details

mibac138

commit sha 6ad24baf06c687517f188e8c6e6ce848924d001c

Adjust according to estebank's review comments

view details

mibac138

commit sha 98532a30901d7544c49fe82f499db53699645de0

Adjust according to petrochenkov's review comments

view details

Rich Kadel

commit sha a6127e3fde9e8d24388847ad1b442a4337f19965

Merge pull request #1 from rust-lang/master update from upstream

view details

Benjamin Saunders

commit sha 730f7366bba5abdf5ae0c2f1222795e40d48f90c

Fix asinh of negative values When `x` has large magnitude, `x + ((x * x) + 1.0).sqrt()` approaches `x + x.abs()`. For negative values of `x`, this leads to catastrophic cancellation, resulting in large errors or even 0 being passed to `ln`, producing incorrect results including `-inf`. Becuase asinh is an odd function, i.e. -asinh(x) = asinh(-x) for all x, we can avoid the catastrophic cancellation and obtain correct results by taking the absolute value of `self` for the first term. `self * self` is always positive, so in effect this gives us `x.abs().asinh().copysign(x)` which as discussed above is algebraically equivalent, but is much more accurate.

view details

Aaron Hill

commit sha ebe5a916b08d5d58b03fe551a95038d9cf964781

Properly encode AnonConst into crate metadata Fixes #68104 Previous, we were encoding AnonConst as a regular Const, causing us to treat them differently after being deserialized in another compilation session.

view details

Mikail Bagishov

commit sha 591584e71f7d8a613d586066c8b01c1eecf08f35

Add tests for 'impl Default for [T; N]'

view details

Bastian Kauschke

commit sha b3aa5e38107df9e9b16a0a003afaa3d12d80bb86

add str to common types

view details

Mikail Bagishov

commit sha 3313bf62ac45fab2c39e49c788423153754087a9

Skip leak test on targets without panic=unwind

view details

Ralf Jung

commit sha f7d745f33d950c050e0a5a2ee2ee9f0e1269e956

tag/niche terminology cleanup

view details

Ralf Jung

commit sha 7a6d03c2699787644b44f7bc3e8252d1508880b8

miri errors: rename InvalidDiscriminant -> InvalidTag

view details

Vadim Petrochenkov

commit sha d1c275b350f9ae74be92114f4819d6afb55d6007

linker: MSVC supports linking static libraries as a whole archive

view details

Carol (Nichols || Goulding)

commit sha 1bc4e45b3fe3a0817908bd7cc21ec23798d38d63

Only highlight results via mouseover if mouse has moved

view details

Yoshua Wuyts

commit sha 2764e54c29d0f19242e794d5eecd00cc5470f530

impl ToSocketAddrs for (String, u16)

view details

Nathan Corbyn

commit sha df996e8e12b094e3aedfe0e35c2a8ded57f56890

Make `need_type_info_err` more conservative

view details

Nathan Corbyn

commit sha b4ddd9183103586ba1456241b9c117a420bb6d6b

Add FIXME to comment regarding local patterns Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>

view details

Oliver Scherer

commit sha 20abc70e04eefa252e5a8bfe934cb54c51c1da37

Don't intern memory in const prop. This isn't sound without validation. We don't want to report errors in case of failure to intern and validate, we just don't want to const prop. Interning and const prop is not built for this, let's not do it until we have a clearer picture on aggregate propagation.

view details

Wesley Wiser

commit sha 1e88f130a347f8b223031eafe75c0772ccfec00c

Stop allowing `Indirect(..)` values to be propagated Closes #72679 Closes #72372 Closes #72285

view details

push time in 2 months

push eventcjgillot/rust

mibac138

commit sha d4fe9553f65df51a18999e956fd507e26271e74e

Implement partial error recovery for `let` with `BinOpEq` When parsing `let x: i8 += 1` the compiler interprets `i8` as a trait which makes it more complicated to do error recovery. More advanced error recovery is not implemented in this commit.

view details

mibac138

commit sha 48ff12acb184672393692e087927a66ff7907d71

Expand partial error recovery for `let` with `BinOpEq`

view details

mibac138

commit sha 05d653199871955eba90abdd3b176603f030ab60

Error recovery for `let` with `+=`

view details

mibac138

commit sha 6ad24baf06c687517f188e8c6e6ce848924d001c

Adjust according to estebank's review comments

view details

mibac138

commit sha 98532a30901d7544c49fe82f499db53699645de0

Adjust according to petrochenkov's review comments

view details

Rich Kadel

commit sha a6127e3fde9e8d24388847ad1b442a4337f19965

Merge pull request #1 from rust-lang/master update from upstream

view details

Benjamin Saunders

commit sha 730f7366bba5abdf5ae0c2f1222795e40d48f90c

Fix asinh of negative values When `x` has large magnitude, `x + ((x * x) + 1.0).sqrt()` approaches `x + x.abs()`. For negative values of `x`, this leads to catastrophic cancellation, resulting in large errors or even 0 being passed to `ln`, producing incorrect results including `-inf`. Becuase asinh is an odd function, i.e. -asinh(x) = asinh(-x) for all x, we can avoid the catastrophic cancellation and obtain correct results by taking the absolute value of `self` for the first term. `self * self` is always positive, so in effect this gives us `x.abs().asinh().copysign(x)` which as discussed above is algebraically equivalent, but is much more accurate.

view details

Aaron Hill

commit sha ebe5a916b08d5d58b03fe551a95038d9cf964781

Properly encode AnonConst into crate metadata Fixes #68104 Previous, we were encoding AnonConst as a regular Const, causing us to treat them differently after being deserialized in another compilation session.

view details

Mikail Bagishov

commit sha 591584e71f7d8a613d586066c8b01c1eecf08f35

Add tests for 'impl Default for [T; N]'

view details

Bastian Kauschke

commit sha b3aa5e38107df9e9b16a0a003afaa3d12d80bb86

add str to common types

view details

Mikail Bagishov

commit sha 3313bf62ac45fab2c39e49c788423153754087a9

Skip leak test on targets without panic=unwind

view details

Ralf Jung

commit sha f7d745f33d950c050e0a5a2ee2ee9f0e1269e956

tag/niche terminology cleanup

view details

Ralf Jung

commit sha 7a6d03c2699787644b44f7bc3e8252d1508880b8

miri errors: rename InvalidDiscriminant -> InvalidTag

view details

Vadim Petrochenkov

commit sha d1c275b350f9ae74be92114f4819d6afb55d6007

linker: MSVC supports linking static libraries as a whole archive

view details

Carol (Nichols || Goulding)

commit sha 1bc4e45b3fe3a0817908bd7cc21ec23798d38d63

Only highlight results via mouseover if mouse has moved

view details

Yoshua Wuyts

commit sha 2764e54c29d0f19242e794d5eecd00cc5470f530

impl ToSocketAddrs for (String, u16)

view details

Nathan Corbyn

commit sha df996e8e12b094e3aedfe0e35c2a8ded57f56890

Make `need_type_info_err` more conservative

view details

Nathan Corbyn

commit sha b4ddd9183103586ba1456241b9c117a420bb6d6b

Add FIXME to comment regarding local patterns Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>

view details

Oliver Scherer

commit sha 20abc70e04eefa252e5a8bfe934cb54c51c1da37

Don't intern memory in const prop. This isn't sound without validation. We don't want to report errors in case of failure to intern and validate, we just don't want to const prop. Interning and const prop is not built for this, let's not do it until we have a clearer picture on aggregate propagation.

view details

Wesley Wiser

commit sha 1e88f130a347f8b223031eafe75c0772ccfec00c

Stop allowing `Indirect(..)` values to be propagated Closes #72679 Closes #72372 Closes #72285

view details

push time in 2 months

push eventcjgillot/rust

mibac138

commit sha d4fe9553f65df51a18999e956fd507e26271e74e

Implement partial error recovery for `let` with `BinOpEq` When parsing `let x: i8 += 1` the compiler interprets `i8` as a trait which makes it more complicated to do error recovery. More advanced error recovery is not implemented in this commit.

view details

mibac138

commit sha 48ff12acb184672393692e087927a66ff7907d71

Expand partial error recovery for `let` with `BinOpEq`

view details

mibac138

commit sha 05d653199871955eba90abdd3b176603f030ab60

Error recovery for `let` with `+=`

view details

mibac138

commit sha 6ad24baf06c687517f188e8c6e6ce848924d001c

Adjust according to estebank's review comments

view details

mibac138

commit sha 98532a30901d7544c49fe82f499db53699645de0

Adjust according to petrochenkov's review comments

view details

Rich Kadel

commit sha a6127e3fde9e8d24388847ad1b442a4337f19965

Merge pull request #1 from rust-lang/master update from upstream

view details

Benjamin Saunders

commit sha 730f7366bba5abdf5ae0c2f1222795e40d48f90c

Fix asinh of negative values When `x` has large magnitude, `x + ((x * x) + 1.0).sqrt()` approaches `x + x.abs()`. For negative values of `x`, this leads to catastrophic cancellation, resulting in large errors or even 0 being passed to `ln`, producing incorrect results including `-inf`. Becuase asinh is an odd function, i.e. -asinh(x) = asinh(-x) for all x, we can avoid the catastrophic cancellation and obtain correct results by taking the absolute value of `self` for the first term. `self * self` is always positive, so in effect this gives us `x.abs().asinh().copysign(x)` which as discussed above is algebraically equivalent, but is much more accurate.

view details

Aaron Hill

commit sha ebe5a916b08d5d58b03fe551a95038d9cf964781

Properly encode AnonConst into crate metadata Fixes #68104 Previous, we were encoding AnonConst as a regular Const, causing us to treat them differently after being deserialized in another compilation session.

view details

Mikail Bagishov

commit sha 591584e71f7d8a613d586066c8b01c1eecf08f35

Add tests for 'impl Default for [T; N]'

view details

Bastian Kauschke

commit sha b3aa5e38107df9e9b16a0a003afaa3d12d80bb86

add str to common types

view details

Mikail Bagishov

commit sha 3313bf62ac45fab2c39e49c788423153754087a9

Skip leak test on targets without panic=unwind

view details

Ralf Jung

commit sha f7d745f33d950c050e0a5a2ee2ee9f0e1269e956

tag/niche terminology cleanup

view details

Ralf Jung

commit sha 7a6d03c2699787644b44f7bc3e8252d1508880b8

miri errors: rename InvalidDiscriminant -> InvalidTag

view details

Vadim Petrochenkov

commit sha d1c275b350f9ae74be92114f4819d6afb55d6007

linker: MSVC supports linking static libraries as a whole archive

view details

Carol (Nichols || Goulding)

commit sha 1bc4e45b3fe3a0817908bd7cc21ec23798d38d63

Only highlight results via mouseover if mouse has moved

view details

Yoshua Wuyts

commit sha 2764e54c29d0f19242e794d5eecd00cc5470f530

impl ToSocketAddrs for (String, u16)

view details

Nathan Corbyn

commit sha df996e8e12b094e3aedfe0e35c2a8ded57f56890

Make `need_type_info_err` more conservative

view details

Nathan Corbyn

commit sha b4ddd9183103586ba1456241b9c117a420bb6d6b

Add FIXME to comment regarding local patterns Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>

view details

Oliver Scherer

commit sha 20abc70e04eefa252e5a8bfe934cb54c51c1da37

Don't intern memory in const prop. This isn't sound without validation. We don't want to report errors in case of failure to intern and validate, we just don't want to const prop. Interning and const prop is not built for this, let's not do it until we have a clearer picture on aggregate propagation.

view details

Wesley Wiser

commit sha 1e88f130a347f8b223031eafe75c0772ccfec00c

Stop allowing `Indirect(..)` values to be propagated Closes #72679 Closes #72372 Closes #72285

view details

push time in 2 months

push eventcjgillot/rust

mibac138

commit sha d4fe9553f65df51a18999e956fd507e26271e74e

Implement partial error recovery for `let` with `BinOpEq` When parsing `let x: i8 += 1` the compiler interprets `i8` as a trait which makes it more complicated to do error recovery. More advanced error recovery is not implemented in this commit.

view details

mibac138

commit sha 48ff12acb184672393692e087927a66ff7907d71

Expand partial error recovery for `let` with `BinOpEq`

view details

mibac138

commit sha 05d653199871955eba90abdd3b176603f030ab60

Error recovery for `let` with `+=`

view details

mibac138

commit sha 6ad24baf06c687517f188e8c6e6ce848924d001c

Adjust according to estebank's review comments

view details

mibac138

commit sha 98532a30901d7544c49fe82f499db53699645de0

Adjust according to petrochenkov's review comments

view details

Rich Kadel

commit sha a6127e3fde9e8d24388847ad1b442a4337f19965

Merge pull request #1 from rust-lang/master update from upstream

view details

Benjamin Saunders

commit sha 730f7366bba5abdf5ae0c2f1222795e40d48f90c

Fix asinh of negative values When `x` has large magnitude, `x + ((x * x) + 1.0).sqrt()` approaches `x + x.abs()`. For negative values of `x`, this leads to catastrophic cancellation, resulting in large errors or even 0 being passed to `ln`, producing incorrect results including `-inf`. Becuase asinh is an odd function, i.e. -asinh(x) = asinh(-x) for all x, we can avoid the catastrophic cancellation and obtain correct results by taking the absolute value of `self` for the first term. `self * self` is always positive, so in effect this gives us `x.abs().asinh().copysign(x)` which as discussed above is algebraically equivalent, but is much more accurate.

view details

Aaron Hill

commit sha ebe5a916b08d5d58b03fe551a95038d9cf964781

Properly encode AnonConst into crate metadata Fixes #68104 Previous, we were encoding AnonConst as a regular Const, causing us to treat them differently after being deserialized in another compilation session.

view details

Mikail Bagishov

commit sha 591584e71f7d8a613d586066c8b01c1eecf08f35

Add tests for 'impl Default for [T; N]'

view details

Bastian Kauschke

commit sha b3aa5e38107df9e9b16a0a003afaa3d12d80bb86

add str to common types

view details

Mikail Bagishov

commit sha 3313bf62ac45fab2c39e49c788423153754087a9

Skip leak test on targets without panic=unwind

view details

Ralf Jung

commit sha f7d745f33d950c050e0a5a2ee2ee9f0e1269e956

tag/niche terminology cleanup

view details

Ralf Jung

commit sha 7a6d03c2699787644b44f7bc3e8252d1508880b8

miri errors: rename InvalidDiscriminant -> InvalidTag

view details

Vadim Petrochenkov

commit sha d1c275b350f9ae74be92114f4819d6afb55d6007

linker: MSVC supports linking static libraries as a whole archive

view details

Carol (Nichols || Goulding)

commit sha 1bc4e45b3fe3a0817908bd7cc21ec23798d38d63

Only highlight results via mouseover if mouse has moved

view details

Yoshua Wuyts

commit sha 2764e54c29d0f19242e794d5eecd00cc5470f530

impl ToSocketAddrs for (String, u16)

view details

Nathan Corbyn

commit sha df996e8e12b094e3aedfe0e35c2a8ded57f56890

Make `need_type_info_err` more conservative

view details

Nathan Corbyn

commit sha b4ddd9183103586ba1456241b9c117a420bb6d6b

Add FIXME to comment regarding local patterns Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>

view details

Oliver Scherer

commit sha 20abc70e04eefa252e5a8bfe934cb54c51c1da37

Don't intern memory in const prop. This isn't sound without validation. We don't want to report errors in case of failure to intern and validate, we just don't want to const prop. Interning and const prop is not built for this, let's not do it until we have a clearer picture on aggregate propagation.

view details

Wesley Wiser

commit sha 1e88f130a347f8b223031eafe75c0772ccfec00c

Stop allowing `Indirect(..)` values to be propagated Closes #72679 Closes #72372 Closes #72285

view details

push time in 2 months

push eventcjgillot/rust

Juan Aguilar Santillana

commit sha e9c78db0861f6495f903a41e087c9628d777b87b

Update annotate-snippets-rs to 0.8.0

view details

Juan Aguilar Santillana

commit sha f16060f386c3ceee257b2c38ce5072b2d0943b6a

Add UI test where `annotated_files` count is > 1 #64205

view details

Mark Rousskov

commit sha 318b8b6aabb2ef0fae0c0aafbba2c7ad97fb3a2a

Add hint for collect type

view details

Philipp Krones

commit sha d4092ace00d60634bcdc22135d82e05a53971263

Merge pull request #5584 from Mark-Simulacrum/beta-next Add hint for collect type

view details

Juan Aguilar Santillana

commit sha 8fc62029114a917969a55a50f05c1688599a5c33

Fix make sure out primary file comes first

view details

Andy Russell

commit sha c379fb5b3a351cf26dc136ee8b8bc557aa904a75

remove extra space from crate-level doctest names

view details

Bastian Kauschke

commit sha 72a2d35f165a94e17cd17e56cb61e3dcbef7eb2d

fix is_const_context

view details

Bastian Kauschke

commit sha ecb593379c3ab075940a3fbf2e980ec5260b6ca4

refactor check_for_cast

view details

Bastian Kauschke

commit sha 6da17d244b08e5f14edd1645fbd07d1f042d00b7

`is_const_context` -> `is_inside_const_context`

view details

Lzu Tao

commit sha 221c482142f84d5889edb8d17efab6470c81cf04

Stabilize str_strip feature

view details

Bastian Kauschke

commit sha e820a03d1c905d58b27d7ac6d85f450f9754ba79

iterate List by value

view details

Matthew McAllister

commit sha 98eb29cbba66561cf184f2d7f4277b38bd6b2aad

Fix trait alias inherent impl resolution Fixes #60021 and #72415.

view details

CAD97

commit sha 91f52a51a23f8c5e8c82c49bbf3ab1bb781d3b02

impl AsRef<[T]> for vec::IntoIter<T>

view details

CAD97

commit sha 738f8487fd78a7d860be4e65eee85c9a0e957c13

stabilize vec_drain_as_slice

view details

Aaron Hill

commit sha 9cee22c1a401ace6dd8633335b131c47a37d7bac

Display information about captured variable in `FnMut` error Fixes #69446 When we encounter a region error involving an `FnMut` closure, we display a specialized error message. However, we currently do not tell the user which upvar was captured. This makes it difficult to determine the cause of the error, especially when the closure is large. This commit records marks constraints involving closure upvars with `ConstraintCategory::ClosureUpvar`. When we decide to 'blame' a `ConstraintCategory::Return`, we additionall store the captured upvar if we found a `ConstraintCategory::ClosureUpvar` in the path. When generating an error message, we point to relevant spans if we have closure upvar information available. We further customize the message if an `async` closure is being returned, to make it clear that the captured variable is being returned indirectly.

view details

Jonathan Schwender

commit sha 2b26b8b32bb2246caa0a82b6ea16f11da3686d0e

Fix documentation example for gcov profiling Incremental compilation needs to be turned off. Also added the other RUSTFLAGS that should/need to be turned on.

view details

Trevor Spiteri

commit sha da18df285910446d5b4c212b96379e694f47533f

doc: make impl block collapsible if it has an associated constant Fixes #71822.

view details

Eduardo Broto

commit sha 64a05f56c33d4754808ef85e634f72a9053c56fd

len_zero: skip ranges if feature `range_is_empty` is not enabled

view details

Matthias Krüger

commit sha 7b490903809ce5c03c83869357a68e88f8cc0799

clippy_dev: add ra_setup This takes an absolute path to a rustc repo and adds path-dependencies that point towards the respective rustc subcrates into the Cargo.tomls of the clippy and clippy_lints crate. This allows rustc-analyzer to show proper type annotations etc on rustc-internals inside the clippy repo. Usage: cargo dev ra-setup /absolute/path/to/rust/ cc https://github.com/rust-analyzer/rust-analyzer/issues/3517 cc https://github.com/rust-lang/rust-clippy/issues/5514

view details

flip1995

commit sha a0e9f9bd0dca39ccff47baedffa94aca74911a86

Merge commit '7ea7cd165ad6705603852771bf82cc2fd6560db5' into clippyup2

view details

push time in 2 months

push eventcjgillot/rust

Juan Aguilar Santillana

commit sha e9c78db0861f6495f903a41e087c9628d777b87b

Update annotate-snippets-rs to 0.8.0

view details

Juan Aguilar Santillana

commit sha f16060f386c3ceee257b2c38ce5072b2d0943b6a

Add UI test where `annotated_files` count is > 1 #64205

view details

Mark Rousskov

commit sha 318b8b6aabb2ef0fae0c0aafbba2c7ad97fb3a2a

Add hint for collect type

view details

Philipp Krones

commit sha d4092ace00d60634bcdc22135d82e05a53971263

Merge pull request #5584 from Mark-Simulacrum/beta-next Add hint for collect type

view details

Juan Aguilar Santillana

commit sha 8fc62029114a917969a55a50f05c1688599a5c33

Fix make sure out primary file comes first

view details

Andy Russell

commit sha c379fb5b3a351cf26dc136ee8b8bc557aa904a75

remove extra space from crate-level doctest names

view details

Bastian Kauschke

commit sha 72a2d35f165a94e17cd17e56cb61e3dcbef7eb2d

fix is_const_context

view details

Bastian Kauschke

commit sha ecb593379c3ab075940a3fbf2e980ec5260b6ca4

refactor check_for_cast

view details

Bastian Kauschke

commit sha 6da17d244b08e5f14edd1645fbd07d1f042d00b7

`is_const_context` -> `is_inside_const_context`

view details

Lzu Tao

commit sha 221c482142f84d5889edb8d17efab6470c81cf04

Stabilize str_strip feature

view details

Bastian Kauschke

commit sha e820a03d1c905d58b27d7ac6d85f450f9754ba79

iterate List by value

view details

Matthew McAllister

commit sha 98eb29cbba66561cf184f2d7f4277b38bd6b2aad

Fix trait alias inherent impl resolution Fixes #60021 and #72415.

view details

CAD97

commit sha 91f52a51a23f8c5e8c82c49bbf3ab1bb781d3b02

impl AsRef<[T]> for vec::IntoIter<T>

view details

CAD97

commit sha 738f8487fd78a7d860be4e65eee85c9a0e957c13

stabilize vec_drain_as_slice

view details

Aaron Hill

commit sha 9cee22c1a401ace6dd8633335b131c47a37d7bac

Display information about captured variable in `FnMut` error Fixes #69446 When we encounter a region error involving an `FnMut` closure, we display a specialized error message. However, we currently do not tell the user which upvar was captured. This makes it difficult to determine the cause of the error, especially when the closure is large. This commit records marks constraints involving closure upvars with `ConstraintCategory::ClosureUpvar`. When we decide to 'blame' a `ConstraintCategory::Return`, we additionall store the captured upvar if we found a `ConstraintCategory::ClosureUpvar` in the path. When generating an error message, we point to relevant spans if we have closure upvar information available. We further customize the message if an `async` closure is being returned, to make it clear that the captured variable is being returned indirectly.

view details

Jonathan Schwender

commit sha 2b26b8b32bb2246caa0a82b6ea16f11da3686d0e

Fix documentation example for gcov profiling Incremental compilation needs to be turned off. Also added the other RUSTFLAGS that should/need to be turned on.

view details

Trevor Spiteri

commit sha da18df285910446d5b4c212b96379e694f47533f

doc: make impl block collapsible if it has an associated constant Fixes #71822.

view details

Eduardo Broto

commit sha 64a05f56c33d4754808ef85e634f72a9053c56fd

len_zero: skip ranges if feature `range_is_empty` is not enabled

view details

Matthias Krüger

commit sha 7b490903809ce5c03c83869357a68e88f8cc0799

clippy_dev: add ra_setup This takes an absolute path to a rustc repo and adds path-dependencies that point towards the respective rustc subcrates into the Cargo.tomls of the clippy and clippy_lints crate. This allows rustc-analyzer to show proper type annotations etc on rustc-internals inside the clippy repo. Usage: cargo dev ra-setup /absolute/path/to/rust/ cc https://github.com/rust-analyzer/rust-analyzer/issues/3517 cc https://github.com/rust-lang/rust-clippy/issues/5514

view details

flip1995

commit sha a0e9f9bd0dca39ccff47baedffa94aca74911a86

Merge commit '7ea7cd165ad6705603852771bf82cc2fd6560db5' into clippyup2

view details

push time in 2 months

push eventcjgillot/rust

Juan Aguilar Santillana

commit sha e9c78db0861f6495f903a41e087c9628d777b87b

Update annotate-snippets-rs to 0.8.0

view details

Juan Aguilar Santillana

commit sha f16060f386c3ceee257b2c38ce5072b2d0943b6a

Add UI test where `annotated_files` count is > 1 #64205

view details

Mark Rousskov

commit sha 318b8b6aabb2ef0fae0c0aafbba2c7ad97fb3a2a

Add hint for collect type

view details

Philipp Krones

commit sha d4092ace00d60634bcdc22135d82e05a53971263

Merge pull request #5584 from Mark-Simulacrum/beta-next Add hint for collect type

view details

Juan Aguilar Santillana

commit sha 8fc62029114a917969a55a50f05c1688599a5c33

Fix make sure out primary file comes first

view details

Andy Russell

commit sha c379fb5b3a351cf26dc136ee8b8bc557aa904a75

remove extra space from crate-level doctest names

view details

Bastian Kauschke

commit sha 72a2d35f165a94e17cd17e56cb61e3dcbef7eb2d

fix is_const_context

view details

Bastian Kauschke

commit sha ecb593379c3ab075940a3fbf2e980ec5260b6ca4

refactor check_for_cast

view details

Bastian Kauschke

commit sha 6da17d244b08e5f14edd1645fbd07d1f042d00b7

`is_const_context` -> `is_inside_const_context`

view details

Lzu Tao

commit sha 221c482142f84d5889edb8d17efab6470c81cf04

Stabilize str_strip feature

view details

Bastian Kauschke

commit sha e820a03d1c905d58b27d7ac6d85f450f9754ba79

iterate List by value

view details

Matthew McAllister

commit sha 98eb29cbba66561cf184f2d7f4277b38bd6b2aad

Fix trait alias inherent impl resolution Fixes #60021 and #72415.

view details

CAD97

commit sha 91f52a51a23f8c5e8c82c49bbf3ab1bb781d3b02

impl AsRef<[T]> for vec::IntoIter<T>

view details

CAD97

commit sha 738f8487fd78a7d860be4e65eee85c9a0e957c13

stabilize vec_drain_as_slice

view details

Aaron Hill

commit sha 9cee22c1a401ace6dd8633335b131c47a37d7bac

Display information about captured variable in `FnMut` error Fixes #69446 When we encounter a region error involving an `FnMut` closure, we display a specialized error message. However, we currently do not tell the user which upvar was captured. This makes it difficult to determine the cause of the error, especially when the closure is large. This commit records marks constraints involving closure upvars with `ConstraintCategory::ClosureUpvar`. When we decide to 'blame' a `ConstraintCategory::Return`, we additionall store the captured upvar if we found a `ConstraintCategory::ClosureUpvar` in the path. When generating an error message, we point to relevant spans if we have closure upvar information available. We further customize the message if an `async` closure is being returned, to make it clear that the captured variable is being returned indirectly.

view details

Jonathan Schwender

commit sha 2b26b8b32bb2246caa0a82b6ea16f11da3686d0e

Fix documentation example for gcov profiling Incremental compilation needs to be turned off. Also added the other RUSTFLAGS that should/need to be turned on.

view details

Trevor Spiteri

commit sha da18df285910446d5b4c212b96379e694f47533f

doc: make impl block collapsible if it has an associated constant Fixes #71822.

view details

Eduardo Broto

commit sha 64a05f56c33d4754808ef85e634f72a9053c56fd

len_zero: skip ranges if feature `range_is_empty` is not enabled

view details

Matthias Krüger

commit sha 7b490903809ce5c03c83869357a68e88f8cc0799

clippy_dev: add ra_setup This takes an absolute path to a rustc repo and adds path-dependencies that point towards the respective rustc subcrates into the Cargo.tomls of the clippy and clippy_lints crate. This allows rustc-analyzer to show proper type annotations etc on rustc-internals inside the clippy repo. Usage: cargo dev ra-setup /absolute/path/to/rust/ cc https://github.com/rust-analyzer/rust-analyzer/issues/3517 cc https://github.com/rust-lang/rust-clippy/issues/5514

view details

flip1995

commit sha a0e9f9bd0dca39ccff47baedffa94aca74911a86

Merge commit '7ea7cd165ad6705603852771bf82cc2fd6560db5' into clippyup2

view details

push time in 2 months

create barnchcjgillot/rust

branch : nospan-ty

created branch time in 2 months

push eventcjgillot/rust

Juan Aguilar Santillana

commit sha e9c78db0861f6495f903a41e087c9628d777b87b

Update annotate-snippets-rs to 0.8.0

view details

Juan Aguilar Santillana

commit sha f16060f386c3ceee257b2c38ce5072b2d0943b6a

Add UI test where `annotated_files` count is > 1 #64205

view details

Mark Rousskov

commit sha 318b8b6aabb2ef0fae0c0aafbba2c7ad97fb3a2a

Add hint for collect type

view details

Philipp Krones

commit sha d4092ace00d60634bcdc22135d82e05a53971263

Merge pull request #5584 from Mark-Simulacrum/beta-next Add hint for collect type

view details

Juan Aguilar Santillana

commit sha 8fc62029114a917969a55a50f05c1688599a5c33

Fix make sure out primary file comes first

view details

Andy Russell

commit sha c379fb5b3a351cf26dc136ee8b8bc557aa904a75

remove extra space from crate-level doctest names

view details

Bastian Kauschke

commit sha 72a2d35f165a94e17cd17e56cb61e3dcbef7eb2d

fix is_const_context

view details

Bastian Kauschke

commit sha ecb593379c3ab075940a3fbf2e980ec5260b6ca4

refactor check_for_cast

view details

Bastian Kauschke

commit sha 6da17d244b08e5f14edd1645fbd07d1f042d00b7

`is_const_context` -> `is_inside_const_context`

view details

Lzu Tao

commit sha 221c482142f84d5889edb8d17efab6470c81cf04

Stabilize str_strip feature

view details

Bastian Kauschke

commit sha e820a03d1c905d58b27d7ac6d85f450f9754ba79

iterate List by value

view details

Matthew McAllister

commit sha 98eb29cbba66561cf184f2d7f4277b38bd6b2aad

Fix trait alias inherent impl resolution Fixes #60021 and #72415.

view details

CAD97

commit sha 91f52a51a23f8c5e8c82c49bbf3ab1bb781d3b02

impl AsRef<[T]> for vec::IntoIter<T>

view details

CAD97

commit sha 738f8487fd78a7d860be4e65eee85c9a0e957c13

stabilize vec_drain_as_slice

view details

Aaron Hill

commit sha 9cee22c1a401ace6dd8633335b131c47a37d7bac

Display information about captured variable in `FnMut` error Fixes #69446 When we encounter a region error involving an `FnMut` closure, we display a specialized error message. However, we currently do not tell the user which upvar was captured. This makes it difficult to determine the cause of the error, especially when the closure is large. This commit records marks constraints involving closure upvars with `ConstraintCategory::ClosureUpvar`. When we decide to 'blame' a `ConstraintCategory::Return`, we additionall store the captured upvar if we found a `ConstraintCategory::ClosureUpvar` in the path. When generating an error message, we point to relevant spans if we have closure upvar information available. We further customize the message if an `async` closure is being returned, to make it clear that the captured variable is being returned indirectly.

view details

Jonathan Schwender

commit sha 2b26b8b32bb2246caa0a82b6ea16f11da3686d0e

Fix documentation example for gcov profiling Incremental compilation needs to be turned off. Also added the other RUSTFLAGS that should/need to be turned on.

view details

Trevor Spiteri

commit sha da18df285910446d5b4c212b96379e694f47533f

doc: make impl block collapsible if it has an associated constant Fixes #71822.

view details

Eduardo Broto

commit sha 64a05f56c33d4754808ef85e634f72a9053c56fd

len_zero: skip ranges if feature `range_is_empty` is not enabled

view details

Matthias Krüger

commit sha 7b490903809ce5c03c83869357a68e88f8cc0799

clippy_dev: add ra_setup This takes an absolute path to a rustc repo and adds path-dependencies that point towards the respective rustc subcrates into the Cargo.tomls of the clippy and clippy_lints crate. This allows rustc-analyzer to show proper type annotations etc on rustc-internals inside the clippy repo. Usage: cargo dev ra-setup /absolute/path/to/rust/ cc https://github.com/rust-analyzer/rust-analyzer/issues/3517 cc https://github.com/rust-lang/rust-clippy/issues/5514

view details

flip1995

commit sha a0e9f9bd0dca39ccff47baedffa94aca74911a86

Merge commit '7ea7cd165ad6705603852771bf82cc2fd6560db5' into clippyup2

view details

push time in 2 months

push eventcjgillot/rust

Ralf Jung

commit sha 58ae4a9a5388d9c2c5e4ac435ea69a2b456ab008

de-promote Duration::from_secs

view details

Juan Aguilar Santillana

commit sha e9c78db0861f6495f903a41e087c9628d777b87b

Update annotate-snippets-rs to 0.8.0

view details

Juan Aguilar Santillana

commit sha f16060f386c3ceee257b2c38ce5072b2d0943b6a

Add UI test where `annotated_files` count is > 1 #64205

view details

Mark Rousskov

commit sha 318b8b6aabb2ef0fae0c0aafbba2c7ad97fb3a2a

Add hint for collect type

view details

Philipp Krones

commit sha d4092ace00d60634bcdc22135d82e05a53971263

Merge pull request #5584 from Mark-Simulacrum/beta-next Add hint for collect type

view details

csmoe

commit sha 29a41f0d86b82c2731cc2ab8c8a26272e773e4c3

add ui test for issue-69276

view details

Juan Aguilar Santillana

commit sha 8fc62029114a917969a55a50f05c1688599a5c33

Fix make sure out primary file comes first

view details

Andy Russell

commit sha c379fb5b3a351cf26dc136ee8b8bc557aa904a75

remove extra space from crate-level doctest names

view details

csmoe

commit sha 008d90a66a30bc8ff498f8ad47dea315c1853a75

create error code E0754

view details

csmoe

commit sha 633e4aafe65cd424cf6c8076869df1b49a4e0ec4

suggest on Self return type

view details

csmoe

commit sha 8841ede3648b5f12284dae850ec065374fd3af46

bless suggestion on spell out

view details

csmoe

commit sha 2f311b07c8d95b1192e585e983535de89bcbdfaa

Merge branch 'master' into issue-69276

view details

Bastian Kauschke

commit sha 72a2d35f165a94e17cd17e56cb61e3dcbef7eb2d

fix is_const_context

view details

Bastian Kauschke

commit sha ecb593379c3ab075940a3fbf2e980ec5260b6ca4

refactor check_for_cast

view details

Bastian Kauschke

commit sha 6da17d244b08e5f14edd1645fbd07d1f042d00b7

`is_const_context` -> `is_inside_const_context`

view details

Lzu Tao

commit sha 221c482142f84d5889edb8d17efab6470c81cf04

Stabilize str_strip feature

view details

Bastian Kauschke

commit sha e820a03d1c905d58b27d7ac6d85f450f9754ba79

iterate List by value

view details

Matthew McAllister

commit sha 98eb29cbba66561cf184f2d7f4277b38bd6b2aad

Fix trait alias inherent impl resolution Fixes #60021 and #72415.

view details

CAD97

commit sha 91f52a51a23f8c5e8c82c49bbf3ab1bb781d3b02

impl AsRef<[T]> for vec::IntoIter<T>

view details

CAD97

commit sha 738f8487fd78a7d860be4e65eee85c9a0e957c13

stabilize vec_drain_as_slice

view details

push time in 2 months

delete branch cjgillot/rust

delete branch : both

delete time in 2 months

delete branch cjgillot/rust

delete branch : notables

delete time in 2 months

push eventcjgillot/rust

Juan Aguilar Santillana

commit sha e9c78db0861f6495f903a41e087c9628d777b87b

Update annotate-snippets-rs to 0.8.0

view details

Juan Aguilar Santillana

commit sha f16060f386c3ceee257b2c38ce5072b2d0943b6a

Add UI test where `annotated_files` count is > 1 #64205

view details

Mark Rousskov

commit sha 318b8b6aabb2ef0fae0c0aafbba2c7ad97fb3a2a

Add hint for collect type

view details

Philipp Krones

commit sha d4092ace00d60634bcdc22135d82e05a53971263

Merge pull request #5584 from Mark-Simulacrum/beta-next Add hint for collect type

view details

Juan Aguilar Santillana

commit sha 8fc62029114a917969a55a50f05c1688599a5c33

Fix make sure out primary file comes first

view details

Andy Russell

commit sha c379fb5b3a351cf26dc136ee8b8bc557aa904a75

remove extra space from crate-level doctest names

view details

Bastian Kauschke

commit sha 72a2d35f165a94e17cd17e56cb61e3dcbef7eb2d

fix is_const_context

view details

Bastian Kauschke

commit sha ecb593379c3ab075940a3fbf2e980ec5260b6ca4

refactor check_for_cast

view details

Bastian Kauschke

commit sha 6da17d244b08e5f14edd1645fbd07d1f042d00b7

`is_const_context` -> `is_inside_const_context`

view details

Lzu Tao

commit sha 221c482142f84d5889edb8d17efab6470c81cf04

Stabilize str_strip feature

view details

Bastian Kauschke

commit sha e820a03d1c905d58b27d7ac6d85f450f9754ba79

iterate List by value

view details

Matthew McAllister

commit sha 98eb29cbba66561cf184f2d7f4277b38bd6b2aad

Fix trait alias inherent impl resolution Fixes #60021 and #72415.

view details

CAD97

commit sha 91f52a51a23f8c5e8c82c49bbf3ab1bb781d3b02

impl AsRef<[T]> for vec::IntoIter<T>

view details

CAD97

commit sha 738f8487fd78a7d860be4e65eee85c9a0e957c13

stabilize vec_drain_as_slice

view details

Aaron Hill

commit sha 9cee22c1a401ace6dd8633335b131c47a37d7bac

Display information about captured variable in `FnMut` error Fixes #69446 When we encounter a region error involving an `FnMut` closure, we display a specialized error message. However, we currently do not tell the user which upvar was captured. This makes it difficult to determine the cause of the error, especially when the closure is large. This commit records marks constraints involving closure upvars with `ConstraintCategory::ClosureUpvar`. When we decide to 'blame' a `ConstraintCategory::Return`, we additionall store the captured upvar if we found a `ConstraintCategory::ClosureUpvar` in the path. When generating an error message, we point to relevant spans if we have closure upvar information available. We further customize the message if an `async` closure is being returned, to make it clear that the captured variable is being returned indirectly.

view details

Jonathan Schwender

commit sha 2b26b8b32bb2246caa0a82b6ea16f11da3686d0e

Fix documentation example for gcov profiling Incremental compilation needs to be turned off. Also added the other RUSTFLAGS that should/need to be turned on.

view details

Trevor Spiteri

commit sha da18df285910446d5b4c212b96379e694f47533f

doc: make impl block collapsible if it has an associated constant Fixes #71822.

view details

Eduardo Broto

commit sha 64a05f56c33d4754808ef85e634f72a9053c56fd

len_zero: skip ranges if feature `range_is_empty` is not enabled

view details

Matthias Krüger

commit sha 7b490903809ce5c03c83869357a68e88f8cc0799

clippy_dev: add ra_setup This takes an absolute path to a rustc repo and adds path-dependencies that point towards the respective rustc subcrates into the Cargo.tomls of the clippy and clippy_lints crate. This allows rustc-analyzer to show proper type annotations etc on rustc-internals inside the clippy repo. Usage: cargo dev ra-setup /absolute/path/to/rust/ cc https://github.com/rust-analyzer/rust-analyzer/issues/3517 cc https://github.com/rust-lang/rust-clippy/issues/5514

view details

flip1995

commit sha a0e9f9bd0dca39ccff47baedffa94aca74911a86

Merge commit '7ea7cd165ad6705603852771bf82cc2fd6560db5' into clippyup2

view details

push time in 2 months

pull request commentrust-lang/rust

Remove Spans from HIR -- 1/N -- Span collection

The regression is real. I have one suspect: the hashing of the hir_owner_spans query result. This is an IndexVec<ItemLocalId, Span>, so it can be large. I am looking for a solution.

cjgillot

comment created time in 2 months

push eventcjgillot/rust

Ralf Jung

commit sha 58ae4a9a5388d9c2c5e4ac435ea69a2b456ab008

de-promote Duration::from_secs

view details

csmoe

commit sha 29a41f0d86b82c2731cc2ab8c8a26272e773e4c3

add ui test for issue-69276

view details

csmoe

commit sha 008d90a66a30bc8ff498f8ad47dea315c1853a75

create error code E0754

view details

csmoe

commit sha 633e4aafe65cd424cf6c8076869df1b49a4e0ec4

suggest on Self return type

view details

csmoe

commit sha 8841ede3648b5f12284dae850ec065374fd3af46

bless suggestion on spell out

view details

csmoe

commit sha 2f311b07c8d95b1192e585e983535de89bcbdfaa

Merge branch 'master' into issue-69276

view details

Ralf Jung

commit sha 52ed89ae8c264d8885bfda4f79033289db459c02

from_u32_unchecked: check validity when debug assertions are enabled

view details

Guillaume Gomez

commit sha bcf57d8f20830683d0b66e231010903146a298e7

Fix escape key handling

view details

Vadim Petrochenkov

commit sha 071f0422c6dd897bc61891f96d4448df44d8069f

linker: Add a linker rerun hack for gcc versions not supporting -static-pie

view details

Esteban Küber

commit sha 04243710a0077ad140b8259c21bc1aac02057a48

Account for trailing comma when suggesting `where` clauses Fix #72693.

view details

Esteban Küber

commit sha 0d18136b776cd7cda2c4932f447e6484377f42b2

Move common code to `WhereClause`

view details

Bastian Kauschke

commit sha 15955772276e5574414a6ff630495a9898a99efb

Borrow<[T]> for Interned<'tcx, List<T>>

view details

Petr Hosek

commit sha 21abc8879cddd0002ca1da2eaa0f8e27ef09fa99

Make libunwind build hermetic We want to avoid exporting any symbols from Rust's version of libunwind, and to do so we need to disable visibility annotations to make sure that the -fvisibility=hidden has effect, and also hide global new/delete. This matches the CMake build of libunwind.

view details

Bastian Kauschke

commit sha 8f8cb710cc682cdb29d21cfa39af88c7e8534d76

remove trivial `mk_predicate`s

view details

Felix S. Klock II

commit sha 905d738b1af874e248b9fe7fe4b115458975d401

`StableSourceFileId::new_from_pieces` does not need to be public. (and I want to discourage further use of it if possible.)

view details

Felix S. Klock II

commit sha da09fd3db0c71680e16311140d07e8f1e079af82

Split payload of FileName::Real to track both real and virutalized paths. Such splits arise from metadata refs into libstd. This way, we can (in a follow on commit) continue to emit the virtual name into things like the like the StableSourceFileId that ends up in incremetnal build artifacts, while still using the devirtualized file path when we want to access the file. Note that this commit is intended to be a refactoring; the actual fix to the bug in question is in a follow-on commit.

view details

Felix S. Klock II

commit sha 5e5a3d58678d70ad49b87251a12d11dea52e69b0

Use the virtual name for libstd files in StableSourceFileId and also in the encoded build artifacts. Fix #70924.

view details

Yuki Okushi

commit sha 77503578e1e727228ce47dd7847302936cf80a23

Return early to avoid ICE

view details

Ralf Jung

commit sha 72d85db6eea29004a467842923c07169bc304217

expose char::encode_utf8_raw for libstd

view details

Ralf Jung

commit sha 3182cdf9baf8ed9e8ae24f4742ee5d3d01c2b54a

wtf8: use encode_utf8_raw

view details

push time in 2 months

pull request commentrust-lang/rust

Remove Spans from HIR -- 3/N -- hir::Item

r? @ghost , sorry

cjgillot

comment created time in 2 months

pull request commentrust-lang/rust

Remove Spans from HIR -- 2/N -- Small HIR nodes

r? @ghost , sorry

cjgillot

comment created time in 2 months

PR opened rust-lang/rust

Remove Spans from HIR -- 2/N -- hir::Item

Third step in rust-lang/compiler-team#294 Builds on #73094 Split out of #72015

This PR removes the span from hir::Item.

+1504 -1402

0 comment

149 changed files

pr created time in 2 months

PR opened rust-lang/rust

Remove Spans from HIR -- 2/N -- Small HIR nodes

Second step in rust-lang/compiler-team#294 Builds on #72878 Split out of #72015

This PR gradually removes spans from HIR nodes with low usage. Along the way, HIR visiting stops passing the spans to the visitor.

+1013 -932

0 comment

114 changed files

pr created time in 2 months

push eventcjgillot/rust

push time in 2 months

push eventcjgillot/rust

Camille GILLOT

commit sha 6d085af566832b9be80e0be09f751f1d0cd33fcc

Fix fulldeps tests.

view details

Camille GILLOT

commit sha c9849c12c6968f8a9eeebe0173ff2b4da7310b0a

Pass HirId in librustc_typeck::check.

view details

Camille GILLOT

commit sha 820dc47f041f967b215a9064eedf6600f9648a88

Pass HirId in librustc_lint.

view details

Camille GILLOT

commit sha b85490b21c372e858eb286ebaabb416f1cce4bf1

Pass HirId in librustc_passes::stability.

view details

Camille GILLOT

commit sha a71c82a1b8a014afdce2cd61daaa9489ab643a01

Remove span from hir::Item.

view details

push time in 2 months

create barnchcjgillot/rust

branch : nospan-item

created branch time in 2 months

create barnchcjgillot/rust

branch : nospan-small

created branch time in 2 months

push eventcjgillot/rust

Ralf Jung

commit sha 58ae4a9a5388d9c2c5e4ac435ea69a2b456ab008

de-promote Duration::from_secs

view details

csmoe

commit sha 29a41f0d86b82c2731cc2ab8c8a26272e773e4c3

add ui test for issue-69276

view details

csmoe

commit sha 008d90a66a30bc8ff498f8ad47dea315c1853a75

create error code E0754

view details

csmoe

commit sha 633e4aafe65cd424cf6c8076869df1b49a4e0ec4

suggest on Self return type

view details

csmoe

commit sha 8841ede3648b5f12284dae850ec065374fd3af46

bless suggestion on spell out

view details

csmoe

commit sha 2f311b07c8d95b1192e585e983535de89bcbdfaa

Merge branch 'master' into issue-69276

view details

Ralf Jung

commit sha 52ed89ae8c264d8885bfda4f79033289db459c02

from_u32_unchecked: check validity when debug assertions are enabled

view details

Guillaume Gomez

commit sha bcf57d8f20830683d0b66e231010903146a298e7

Fix escape key handling

view details

Vadim Petrochenkov

commit sha 071f0422c6dd897bc61891f96d4448df44d8069f

linker: Add a linker rerun hack for gcc versions not supporting -static-pie

view details

Esteban Küber

commit sha 04243710a0077ad140b8259c21bc1aac02057a48

Account for trailing comma when suggesting `where` clauses Fix #72693.

view details

Esteban Küber

commit sha 0d18136b776cd7cda2c4932f447e6484377f42b2

Move common code to `WhereClause`

view details

Bastian Kauschke

commit sha 15955772276e5574414a6ff630495a9898a99efb

Borrow<[T]> for Interned<'tcx, List<T>>

view details

Petr Hosek

commit sha 21abc8879cddd0002ca1da2eaa0f8e27ef09fa99

Make libunwind build hermetic We want to avoid exporting any symbols from Rust's version of libunwind, and to do so we need to disable visibility annotations to make sure that the -fvisibility=hidden has effect, and also hide global new/delete. This matches the CMake build of libunwind.

view details

Bastian Kauschke

commit sha 8f8cb710cc682cdb29d21cfa39af88c7e8534d76

remove trivial `mk_predicate`s

view details

Felix S. Klock II

commit sha 905d738b1af874e248b9fe7fe4b115458975d401

`StableSourceFileId::new_from_pieces` does not need to be public. (and I want to discourage further use of it if possible.)

view details

Felix S. Klock II

commit sha da09fd3db0c71680e16311140d07e8f1e079af82

Split payload of FileName::Real to track both real and virutalized paths. Such splits arise from metadata refs into libstd. This way, we can (in a follow on commit) continue to emit the virtual name into things like the like the StableSourceFileId that ends up in incremetnal build artifacts, while still using the devirtualized file path when we want to access the file. Note that this commit is intended to be a refactoring; the actual fix to the bug in question is in a follow-on commit.

view details

Felix S. Klock II

commit sha 5e5a3d58678d70ad49b87251a12d11dea52e69b0

Use the virtual name for libstd files in StableSourceFileId and also in the encoded build artifacts. Fix #70924.

view details

Yuki Okushi

commit sha 77503578e1e727228ce47dd7847302936cf80a23

Return early to avoid ICE

view details

Ralf Jung

commit sha 72d85db6eea29004a467842923c07169bc304217

expose char::encode_utf8_raw for libstd

view details

Ralf Jung

commit sha 3182cdf9baf8ed9e8ae24f4742ee5d3d01c2b54a

wtf8: use encode_utf8_raw

view details

push time in 2 months

push eventcjgillot/rust

Ralf Jung

commit sha 58ae4a9a5388d9c2c5e4ac435ea69a2b456ab008

de-promote Duration::from_secs

view details

csmoe

commit sha 29a41f0d86b82c2731cc2ab8c8a26272e773e4c3

add ui test for issue-69276

view details

csmoe

commit sha 008d90a66a30bc8ff498f8ad47dea315c1853a75

create error code E0754

view details

csmoe

commit sha 633e4aafe65cd424cf6c8076869df1b49a4e0ec4

suggest on Self return type

view details

csmoe

commit sha 8841ede3648b5f12284dae850ec065374fd3af46

bless suggestion on spell out

view details

csmoe

commit sha 2f311b07c8d95b1192e585e983535de89bcbdfaa

Merge branch 'master' into issue-69276

view details

Ralf Jung

commit sha 52ed89ae8c264d8885bfda4f79033289db459c02

from_u32_unchecked: check validity when debug assertions are enabled

view details

Guillaume Gomez

commit sha bcf57d8f20830683d0b66e231010903146a298e7

Fix escape key handling

view details

Vadim Petrochenkov

commit sha 071f0422c6dd897bc61891f96d4448df44d8069f

linker: Add a linker rerun hack for gcc versions not supporting -static-pie

view details

Esteban Küber

commit sha 04243710a0077ad140b8259c21bc1aac02057a48

Account for trailing comma when suggesting `where` clauses Fix #72693.

view details

Esteban Küber

commit sha 0d18136b776cd7cda2c4932f447e6484377f42b2

Move common code to `WhereClause`

view details

Bastian Kauschke

commit sha 15955772276e5574414a6ff630495a9898a99efb

Borrow<[T]> for Interned<'tcx, List<T>>

view details

Petr Hosek

commit sha 21abc8879cddd0002ca1da2eaa0f8e27ef09fa99

Make libunwind build hermetic We want to avoid exporting any symbols from Rust's version of libunwind, and to do so we need to disable visibility annotations to make sure that the -fvisibility=hidden has effect, and also hide global new/delete. This matches the CMake build of libunwind.

view details

Bastian Kauschke

commit sha 8f8cb710cc682cdb29d21cfa39af88c7e8534d76

remove trivial `mk_predicate`s

view details

Felix S. Klock II

commit sha 905d738b1af874e248b9fe7fe4b115458975d401

`StableSourceFileId::new_from_pieces` does not need to be public. (and I want to discourage further use of it if possible.)

view details

Felix S. Klock II

commit sha da09fd3db0c71680e16311140d07e8f1e079af82

Split payload of FileName::Real to track both real and virutalized paths. Such splits arise from metadata refs into libstd. This way, we can (in a follow on commit) continue to emit the virtual name into things like the like the StableSourceFileId that ends up in incremetnal build artifacts, while still using the devirtualized file path when we want to access the file. Note that this commit is intended to be a refactoring; the actual fix to the bug in question is in a follow-on commit.

view details

Felix S. Klock II

commit sha 5e5a3d58678d70ad49b87251a12d11dea52e69b0

Use the virtual name for libstd files in StableSourceFileId and also in the encoded build artifacts. Fix #70924.

view details

Yuki Okushi

commit sha 77503578e1e727228ce47dd7847302936cf80a23

Return early to avoid ICE

view details

Ralf Jung

commit sha 72d85db6eea29004a467842923c07169bc304217

expose char::encode_utf8_raw for libstd

view details

Ralf Jung

commit sha 3182cdf9baf8ed9e8ae24f4742ee5d3d01c2b54a

wtf8: use encode_utf8_raw

view details

push time in 2 months

push eventcjgillot/rust

Camille GILLOT

commit sha 8aec0e9c9b061bfcd7382350df0a70b558454b45

Remove useless Clone bound in IndexVec.

view details

Camille GILLOT

commit sha 1efedf9f62f19479f9c3e5438d33fedcc32a8268

Introduce HirIdVec.

view details

Camille GILLOT

commit sha 57a0866dbd41c8c5c128ea9846f5daf9a72dad4c

Collect spans during HIR indexing.

view details

Camille GILLOT

commit sha a5a0b09aca51cfdc277a9e2beb1441991094e244

Introduce a query for HIR spans.

view details

Camille GILLOT

commit sha 2d3eb91851fd2e214f6a2af21e6cd73acca692e8

Collect spans during lowering.

view details

Camille GILLOT

commit sha b482c8044b4d015b69d9e9509d0f28f75f9484b4

Collect spans directly into an IndexVec.

view details

Camille GILLOT

commit sha 7e9b228f94783cee8181fdf07fa3dc304c375083

Directly use span map for indexing.

view details

Camille GILLOT

commit sha 87a24fc5183480311e48eddd984ada6cdc704ea2

Don't pass spans in hir::map::blocks.

view details

Camille GILLOT

commit sha 83afa06ff4d8e0dde36fb954a6debfe47dfb1799

Add comment.

view details

Camille GILLOT

commit sha cdba8536c3e80b8ab08747ac5fa1cc120e8e24a1

Stop passing the Span in HIR visiting.

view details

Camille GILLOT

commit sha f324a3584e30ff9851446477a4db7969593e342c

Remove span from hir::Param.

view details

Camille GILLOT

commit sha d93457f7e6956f0ff7ae99ae7de60315ef5e9ed0

Remove span from hir::Variant.

view details

Camille GILLOT

commit sha 4b395aeaeee7b8afd6d267df8d468fb8acdc51ed

Remove span from hir::StructField.

view details

Camille GILLOT

commit sha 0a65c85b9ad730a436e8394803c5128af39a9a17

Remove span from hir::Stmt.

view details

Camille GILLOT

commit sha a16c2d50824c79b007ff94350329bed067fa8079

Remove span from hir::Block.

view details

Camille GILLOT

commit sha fab3c23eb4469229b806d9f1a7424598cef089b9

Remove span from hir::MacroDef.

view details

Camille GILLOT

commit sha 68eacc5148327bb5398df60a03c738bdbc1ab9dd

Remove span from hir::GenericParam.

view details

Camille GILLOT

commit sha 44d9068e624adb3f3d7fd74dc6c382ecbb0840f4

Remove span from hir::Arm.

view details

Camille GILLOT

commit sha 79cc2ce5371e11318941f59a2f5832bec039e6d8

Remove span from hir::FieldPat.

view details

Camille GILLOT

commit sha 2fc231fdf79a6dd5bb4cdad47f3cbdefe63ae610

Remove span from hir::Local.

view details

push time in 2 months

push eventcjgillot/rust

Camille GILLOT

commit sha 8aec0e9c9b061bfcd7382350df0a70b558454b45

Remove useless Clone bound in IndexVec.

view details

Camille GILLOT

commit sha 1efedf9f62f19479f9c3e5438d33fedcc32a8268

Introduce HirIdVec.

view details

Camille GILLOT

commit sha 57a0866dbd41c8c5c128ea9846f5daf9a72dad4c

Collect spans during HIR indexing.

view details

Camille GILLOT

commit sha a5a0b09aca51cfdc277a9e2beb1441991094e244

Introduce a query for HIR spans.

view details

Camille GILLOT

commit sha 2d3eb91851fd2e214f6a2af21e6cd73acca692e8

Collect spans during lowering.

view details

Camille GILLOT

commit sha b482c8044b4d015b69d9e9509d0f28f75f9484b4

Collect spans directly into an IndexVec.

view details

Camille GILLOT

commit sha 7e9b228f94783cee8181fdf07fa3dc304c375083

Directly use span map for indexing.

view details

Camille GILLOT

commit sha 87a24fc5183480311e48eddd984ada6cdc704ea2

Don't pass spans in hir::map::blocks.

view details

Camille GILLOT

commit sha 83afa06ff4d8e0dde36fb954a6debfe47dfb1799

Add comment.

view details

Camille GILLOT

commit sha cdba8536c3e80b8ab08747ac5fa1cc120e8e24a1

Stop passing the Span in HIR visiting.

view details

Camille GILLOT

commit sha f324a3584e30ff9851446477a4db7969593e342c

Remove span from hir::Param.

view details

Camille GILLOT

commit sha d93457f7e6956f0ff7ae99ae7de60315ef5e9ed0

Remove span from hir::Variant.

view details

Camille GILLOT

commit sha 4b395aeaeee7b8afd6d267df8d468fb8acdc51ed

Remove span from hir::StructField.

view details

Camille GILLOT

commit sha 0a65c85b9ad730a436e8394803c5128af39a9a17

Remove span from hir::Stmt.

view details

Camille GILLOT

commit sha a16c2d50824c79b007ff94350329bed067fa8079

Remove span from hir::Block.

view details

Camille GILLOT

commit sha fab3c23eb4469229b806d9f1a7424598cef089b9

Remove span from hir::MacroDef.

view details

Camille GILLOT

commit sha 68eacc5148327bb5398df60a03c738bdbc1ab9dd

Remove span from hir::GenericParam.

view details

Camille GILLOT

commit sha 44d9068e624adb3f3d7fd74dc6c382ecbb0840f4

Remove span from hir::Arm.

view details

Camille GILLOT

commit sha 79cc2ce5371e11318941f59a2f5832bec039e6d8

Remove span from hir::FieldPat.

view details

Camille GILLOT

commit sha 2fc231fdf79a6dd5bb4cdad47f3cbdefe63ae610

Remove span from hir::Local.

view details

push time in 2 months

pull request commentrust-lang/rust

Remove Spans from HIR -- 1/N -- Span collection

I re-shuffled the commits to avoid the back and forth with the modifications. The only differences are a few comments.

cjgillot

comment created time in 2 months

Pull request review commentrust-lang/rust

Remove Spans from HIR -- 1/N -- Span collection

 impl<'a, 'hir> Visitor<'hir> for NodeCollector<'a, 'hir> {      fn visit_param(&mut self, param: &'hir Param<'hir>) {         let node = Node::Param(param);-        self.insert(param.pat.span, param.hir_id, node);+        self.insert(param.span, param.hir_id, node);

Actually, this span was only used inside a debugging operation. So no change in behaviour.

cjgillot

comment created time in 2 months

push eventcjgillot/rust

Camille GILLOT

commit sha 8aec0e9c9b061bfcd7382350df0a70b558454b45

Remove useless Clone bound in IndexVec.

view details

Camille GILLOT

commit sha 1efedf9f62f19479f9c3e5438d33fedcc32a8268

Introduce HirIdVec.

view details

Camille GILLOT

commit sha 57a0866dbd41c8c5c128ea9846f5daf9a72dad4c

Collect spans during HIR indexing.

view details

Camille GILLOT

commit sha a5a0b09aca51cfdc277a9e2beb1441991094e244

Introduce a query for HIR spans.

view details

Camille GILLOT

commit sha 2d3eb91851fd2e214f6a2af21e6cd73acca692e8

Collect spans during lowering.

view details

Camille GILLOT

commit sha b482c8044b4d015b69d9e9509d0f28f75f9484b4

Collect spans directly into an IndexVec.

view details

Camille GILLOT

commit sha 7e9b228f94783cee8181fdf07fa3dc304c375083

Directly use span map for indexing.

view details

Camille GILLOT

commit sha 87a24fc5183480311e48eddd984ada6cdc704ea2

Don't pass spans in hir::map::blocks.

view details

Camille GILLOT

commit sha 83afa06ff4d8e0dde36fb954a6debfe47dfb1799

Add comment.

view details

push time in 2 months

Pull request review commentrust-lang/rust

Remove Spans from HIR -- 1/N -- Span collection

 impl<'a, 'hir> Visitor<'hir> for NodeCollector<'a, 'hir> {      fn visit_param(&mut self, param: &'hir Param<'hir>) {         let node = Node::Param(param);-        self.insert(param.pat.span, param.hir_id, node);+        self.insert(param.span, param.hir_id, node);

This change should result in some user-visible result, and somehow does not appear in the tests.

cjgillot

comment created time in 2 months

Pull request review commentrust-lang/rust

Remove Spans from HIR -- 1/N -- Span collection

 impl<'a, 'hir> LoweringContext<'a, 'hir> {             hir_id         }; -        if !span.is_dummy() {-            match self.spans.insert(hir_id, span) {-                Some(sp) if !sp.is_dummy() => assert_eq!(sp, span),-                _ => {}-            };+        let stored_span = self.spans.entry(hir_id).or_insert(span);+        if *stored_span == DUMMY_SP {

In some cases, the HIR owners are assigned a HirId before the AST traversal. When this HirId is created, we do not have access to the proper Span. I use DUMMY_SP as a placeholder for delayed initialisation. I will add a comment about that.

cjgillot

comment created time in 2 months

Pull request review commentrust-lang/rust

Remove Spans from HIR -- 1/N -- Span collection

 impl<'hir> LoweringContext<'_, 'hir> {             VariantData::Tuple(ref fields, id) => hir::VariantData::Tuple(                 self.arena                     .alloc_from_iter(fields.iter().enumerate().map(|f| self.lower_struct_field(f))),-                self.lower_node_id(id, DUMMY_SP),+                self.lower_node_id(id, span),             ),-            VariantData::Unit(id) => hir::VariantData::Unit(self.lower_node_id(id, DUMMY_SP)),+            VariantData::Unit(id) => hir::VariantData::Unit(self.lower_node_id(id, span)),

The behaviour does not change here. This choice of span for the VariantData is the one already implemented in hir::map::NodeCollector::visit_variant.

cjgillot

comment created time in 2 months

Pull request review commentrust-lang/rust

Remove Spans from HIR -- 1/N -- Span collection

 impl<'a, 'hir> NodeCollector<'a, 'hir> {         (self.map, svh)     } -    fn insert_entry(&mut self, id: HirId, entry: Entry<'hir>, hash: Fingerprint) {+    fn insert_entry(&mut self, span: Span, id: HirId, entry: Entry<'hir>, hash: Fingerprint) {

I kept the API from the insert function. This span parameter is only used to assert the consistency of the span map. It will be removed later.

cjgillot

comment created time in 2 months

pull request commentrust-lang/rust

save_analysis: work on HIR tree instead of AST

There are still a few FIXME in the code. Do you plan to address them before merging?

marmeladema

comment created time in 2 months

Pull request review commentrust-lang/rust

save_analysis: work on HIR tree instead of AST

 fn text_sig(text: String) -> Signature {     Signature { text, defs: vec![], refs: vec![] } } -fn push_extern(text: &mut String, ext: Extern) {+/*fn push_extern(text: &mut String, ext: Extern) {

You forgot to remove this dead code.

marmeladema

comment created time in 2 months

push eventcjgillot/rust

Camille GILLOT

commit sha c03c7d71c11556d6509ea86fba0a7406d9ded01f

Replace Span by HirId in hir::Generics.

view details

Camille GILLOT

commit sha d821d835f66e27fbd9fe793fc7eb833719f3a96d

Replace Span by HirId in hir::WhereClause.

view details

push time in 2 months

push eventcjgillot/rust

Camille GILLOT

commit sha 181793d8026fa7da8e9a110465be268a9df1543c

Remove Span from hir::ConstArg.

view details

Camille GILLOT

commit sha 8c80230d2050303ffc093bebc7581f5692b41ce0

Remove Span from hir::TraitItemRef.

view details

Camille GILLOT

commit sha 9d281dee1d40c34d822f7a8dae9d1d223ccaea88

Remove Span from hir::ImplItemRef.

view details

Camille GILLOT

commit sha 98a4c4f194ae8e19909f40df0b81a4b286b0be35

Add a HirId to PolyTraitRef.

view details

Camille GILLOT

commit sha d1ed08476f454ac17db1072cb36e66dbd1e14fd0

Remove Span from PolyTraitRef.

view details

Camille GILLOT

commit sha 856d20953069d995d19ef5aba4ee462afdadb033

Remove Span from hir::Lifetime.

view details

Camille GILLOT

commit sha d64ab1016fa6b60bf14a42a4f5ac2265f98e0210

Replace Span by HirId in hir::Where*Predicate.

view details

Camille GILLOT

commit sha 623cdfe61084b6008a884da047e9d37970b04834

Remove Span from hir::ExprKind::Assign?

view details

Camille GILLOT

commit sha cf088d55cd0e6f257b0cb7dbe7e9f593002d5ada

Replace span by hir_id in hir::Path.

view details

Camille GILLOT

commit sha d42fb8197348836ae674b09efdf54db9fb4d47db

wip: Replace Span by HirId in hir::Generics.

view details

Camille GILLOT

commit sha 4ab75d4de72dc6323437371959677c775754a8d8

Replace Span by HirId in hir::WhereClause.

view details

push time in 2 months

pull request commentrust-lang/rust

Remove Spans from HIR -- 1/N -- Span collection

During the development of this PR, I found easiest to do the collection first, put some assertions I did not change the behaviour, and then proceed with each HIR type one by one.

The current end state is at #72015. That PR is already quite large (+3200, -2700). Furthermore, it does not remove all spans yet: HIR types that do not have a HirId are in progress.

The goal splitting is also to manage the effect on performance. I expect the reduction in invalidation to happen very late. In the mean time, using an exterior map gated behind a query will create slowdown. Those intermediate slowdowns deserve investigation. Otherwise, I would just be pushing the problem into another data structure.

Does this make sense to you @pnkfelix? How would you rather proceed?

cjgillot

comment created time in 2 months

Pull request review commentrust-lang/rust

save_analysis: work on HIR tree instead of AST

 pub fn run_compiler(                     });                      result-                    // AST will be dropped *after* the `after_analysis` callback-                    // (needed by the RLS)

If you remove that comment, can you move the drop of the AST where earlier?

marmeladema

comment created time in 2 months

pull request commentrust-lang/rust

save_analysis: work on HIR tree instead of AST

It appears you left some dead code commented out. Did you forget to remove it?

marmeladema

comment created time in 2 months

push eventcjgillot/rust

Benoît du Garreau

commit sha ef485c6fa97a562b0bc559ffbe38fee9bf1f745b

Impl Error for Infallible

view details

flip1995

commit sha 17d877cce28b22b9b345ec7ef8b14859d8b165c4

Update contributing section about syncing Clippy

view details

Steven Fackler

commit sha 2ce3f85d46edbf5105f2e93d2cbe56ad777b41e6

Tweak and stabilize AtomicN::fetch_update

view details

Philipp Krones

commit sha c1698fedeb69109f9b1aebc0bfccd9bf3112ccad

Apply suggestions from code review Co-authored-by: Phil Hansch <dev@phansch.net>

view details

Vadim Petrochenkov

commit sha 2d10babb71f6658c39279425ec5cda11a28d3af4

Stabilize fn-like proc macros in expression, pattern and statement positions

view details

Steven Fackler

commit sha 31c820552350e3f686a6f353982f0f31ecbaf4a7

Update src/libcore/sync/atomic.rs Co-authored-by: Ralf Jung <post@ralfj.de>

view details

Markus Westerlind

commit sha 1d8489c150df7d0e751f7c438541036df1a9ac5e

perf: Revert accidental inclusion of a part of #69218 This was accidentally included in #69494 after a rebase and given how much `inflate` and `keccak` stresses the obligation forest seems like a likely culprit to the regression in those benchmarks. (It is necessary in #69218 as obligation forest needs to accurately track the root variables or unifications will get lost)

view details

Guillaume Gomez

commit sha 7e855b59151f2e5c2a58fe422a273e997df14b24

Clean up rustdoc source code

view details

Erin Power

commit sha bb433914b5bdd6898200f8c1cadcfec27fbf7a26

Update RELEASES.md for 1.44.0

view details

Guillaume Gomez

commit sha c8fb0d7ef38957cd2b8f6e5b9b7ea47eaa6cca28

End unification of exit codes in librustdoc

view details

XAMPPRocky

commit sha bd5ed9e62f330971523fb75390b4a375bc1d875c

Update RELEASES.md Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>

view details

Bastian Kauschke

commit sha a8c152dfc921e8ec2c00f65e7c731197e522a96d

add regression tests + improve method name

view details

Bastian Kauschke

commit sha 3f661d25f9ce3b5ac6139c8d8bf4614b55dca5be

borrowck `DefId` -> `LocalDefId`

view details

Petr Hosek

commit sha c85768ed71eb09689e2065b122310dad2e1c42f6

Update the Fuchsia linker defaults This updates the linker defaults aligning them with Clang. Specifically, we use 4K pages on all platforms, we always use BIND_NOW, we prefer all loadable segments be separate and page aligned, and we support RELR relocations.

view details

Vardan Margaryan

commit sha 94e4b5ec316993200d75276b4e7c16a059bf3a57

Add the redundant_wildcard_enum_match lint

view details

Vardan Margaryan

commit sha 0ad9f7d651b52de4be6384c9b6dc893b389fd557

Fix trivial cases of new match_wildcard_for_single_variants lint

view details

Vardan Margaryan

commit sha 494830797744c09d6de3b2b2452ab185d2204005

Fix cases of match_wildcard_for_single_variants lint when it is spanned on Option

view details

Vardan Margaryan

commit sha 749619cfe34be1ee591f3af748fbdd4d2f54d3f0

Apply suggestions from PR review

view details

Vardan Margaryan

commit sha 1c59cd5f2110ff90a256f0948f05716403e84b85

Fix example code of wildcard_enum_match_arm lint

view details

Vardan Margaryan

commit sha 10313a2631efa6a01dc86199d554ce5a7c1bb51a

Revert "Fix cases of match_wildcard_for_single_variants lint when it is spanned on Option" This reverts commit 494830797744c09d6de3b2b2452ab185d2204005.

view details

push time in 2 months

push eventcjgillot/rust

Ralf Jung

commit sha 33541d5e55c3114e01e06b27715ae04372ce027f

clarify interaction of pin drop guarantee and panics

view details

Benoît du Garreau

commit sha ef485c6fa97a562b0bc559ffbe38fee9bf1f745b

Impl Error for Infallible

view details

Kevin Per

commit sha dfbc143e65dd4dc8499f7296ddc7889854a8cc7d

Adding if to prevent borrowing suggestion in structs #71136

view details

Kevin Per

commit sha bc29f1d062feeb68207c961d254652d6bff9fd9b

Adding new test #71136

view details

Kevin Per

commit sha d232be80f82b052fd023eb2f4904ccad0aa42d7a

Fix tidy checks

view details

flip1995

commit sha 17d877cce28b22b9b345ec7ef8b14859d8b165c4

Update contributing section about syncing Clippy

view details

Steven Fackler

commit sha 2ce3f85d46edbf5105f2e93d2cbe56ad777b41e6

Tweak and stabilize AtomicN::fetch_update

view details

Philipp Krones

commit sha c1698fedeb69109f9b1aebc0bfccd9bf3112ccad

Apply suggestions from code review Co-authored-by: Phil Hansch <dev@phansch.net>

view details

Eduardo Sánchez Muñoz

commit sha 68f89fcbf982d4b2a40d3175568bef194ee4f3b7

Make `std::char` functions and constants associated to `char`.

view details

Vadim Petrochenkov

commit sha 2d10babb71f6658c39279425ec5cda11a28d3af4

Stabilize fn-like proc macros in expression, pattern and statement positions

view details

Eduardo Sánchez Muñoz

commit sha 0e12a9d9ac6f69ddd72f2c028f668c0b55ac2eda

Try to fix doc links in new `char` methods.

view details

Steven Fackler

commit sha 31c820552350e3f686a6f353982f0f31ecbaf4a7

Update src/libcore/sync/atomic.rs Co-authored-by: Ralf Jung <post@ralfj.de>

view details

csmoe

commit sha e07f63e79a618a0c5e53a71d053da0fa0dbc6970

add testcase for issue-70818

view details

Tobias Rapp

commit sha f99344ace44abc91f76df276625e048f1e8a9536

Stabilize saturating_abs and saturating_neg Stabilizes the following signed integer functions with saturation mechanics: * saturating_abs() * saturating_neg() Closes #59983

view details

csmoe

commit sha fb81c429ebd45f9ba2b1810f548cf59a45feb222

make yield span optional

view details

csmoe

commit sha a5d103ff90f4ad90b1f13f5b5de83a3eb758d9e2

record upvar into GeneratorInteriorTypeCause

view details

csmoe

commit sha d4bdcfd3cfbfa025c5363149a14f2b36a584b54a

don't record upvars into generator interior

view details

csmoe

commit sha 382a963c17122470918e1491a733b81fb545330d

filter upvars that cause trait obligation

view details

csmoe

commit sha d2e5a8e2e966df119021e3db6f6d4c2e189865cd

bless issue-70818 test case

view details

Markus Westerlind

commit sha 1d8489c150df7d0e751f7c438541036df1a9ac5e

perf: Revert accidental inclusion of a part of #69218 This was accidentally included in #69494 after a rebase and given how much `inflate` and `keccak` stresses the obligation forest seems like a likely culprit to the regression in those benchmarks. (It is necessary in #69218 as obligation forest needs to accurately track the root variables or unifications will get lost)

view details

push time in 2 months

push eventcjgillot/rust

Benoît du Garreau

commit sha ef485c6fa97a562b0bc559ffbe38fee9bf1f745b

Impl Error for Infallible

view details

flip1995

commit sha 17d877cce28b22b9b345ec7ef8b14859d8b165c4

Update contributing section about syncing Clippy

view details

Steven Fackler

commit sha 2ce3f85d46edbf5105f2e93d2cbe56ad777b41e6

Tweak and stabilize AtomicN::fetch_update

view details

Philipp Krones

commit sha c1698fedeb69109f9b1aebc0bfccd9bf3112ccad

Apply suggestions from code review Co-authored-by: Phil Hansch <dev@phansch.net>

view details

Vadim Petrochenkov

commit sha 2d10babb71f6658c39279425ec5cda11a28d3af4

Stabilize fn-like proc macros in expression, pattern and statement positions

view details

Steven Fackler

commit sha 31c820552350e3f686a6f353982f0f31ecbaf4a7

Update src/libcore/sync/atomic.rs Co-authored-by: Ralf Jung <post@ralfj.de>

view details

Markus Westerlind

commit sha 1d8489c150df7d0e751f7c438541036df1a9ac5e

perf: Revert accidental inclusion of a part of #69218 This was accidentally included in #69494 after a rebase and given how much `inflate` and `keccak` stresses the obligation forest seems like a likely culprit to the regression in those benchmarks. (It is necessary in #69218 as obligation forest needs to accurately track the root variables or unifications will get lost)

view details

Guillaume Gomez

commit sha 7e855b59151f2e5c2a58fe422a273e997df14b24

Clean up rustdoc source code

view details

Erin Power

commit sha bb433914b5bdd6898200f8c1cadcfec27fbf7a26

Update RELEASES.md for 1.44.0

view details

Guillaume Gomez

commit sha c8fb0d7ef38957cd2b8f6e5b9b7ea47eaa6cca28

End unification of exit codes in librustdoc

view details

XAMPPRocky

commit sha bd5ed9e62f330971523fb75390b4a375bc1d875c

Update RELEASES.md Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>

view details

Bastian Kauschke

commit sha a8c152dfc921e8ec2c00f65e7c731197e522a96d

add regression tests + improve method name

view details

Bastian Kauschke

commit sha 3f661d25f9ce3b5ac6139c8d8bf4614b55dca5be

borrowck `DefId` -> `LocalDefId`

view details

Petr Hosek

commit sha c85768ed71eb09689e2065b122310dad2e1c42f6

Update the Fuchsia linker defaults This updates the linker defaults aligning them with Clang. Specifically, we use 4K pages on all platforms, we always use BIND_NOW, we prefer all loadable segments be separate and page aligned, and we support RELR relocations.

view details

Vardan Margaryan

commit sha 94e4b5ec316993200d75276b4e7c16a059bf3a57

Add the redundant_wildcard_enum_match lint

view details

Vardan Margaryan

commit sha 0ad9f7d651b52de4be6384c9b6dc893b389fd557

Fix trivial cases of new match_wildcard_for_single_variants lint

view details

Vardan Margaryan

commit sha 494830797744c09d6de3b2b2452ab185d2204005

Fix cases of match_wildcard_for_single_variants lint when it is spanned on Option

view details

Vardan Margaryan

commit sha 749619cfe34be1ee591f3af748fbdd4d2f54d3f0

Apply suggestions from PR review

view details

Vardan Margaryan

commit sha 1c59cd5f2110ff90a256f0948f05716403e84b85

Fix example code of wildcard_enum_match_arm lint

view details

Vardan Margaryan

commit sha 10313a2631efa6a01dc86199d554ce5a7c1bb51a

Revert "Fix cases of match_wildcard_for_single_variants lint when it is spanned on Option" This reverts commit 494830797744c09d6de3b2b2452ab185d2204005.

view details

push time in 2 months

PR opened rust-lang/rust

Remove Spans from HIR -- 1/N -- Span collection

First step in https://github.com/rust-lang/compiler-team/issues/294 Split out of https://github.com/rust-lang/rust/pull/72015

This PR collects the spans in the AST when lowering it to HIR. This collection constructs a HirId -> Span map as each HirId is assigned. This map is rendered accessible to the world through a query, and replaces the implementation of tcx.hir().span(...).

This PR needs a perf run.

r? @pnkfelix

+240 -183

0 comment

13 changed files

pr created time in 2 months

delete branch cjgillot/rust

delete branch : hirphan

delete time in 2 months

push eventcjgillot/rust

Benoît du Garreau

commit sha ef485c6fa97a562b0bc559ffbe38fee9bf1f745b

Impl Error for Infallible

view details

flip1995

commit sha 17d877cce28b22b9b345ec7ef8b14859d8b165c4

Update contributing section about syncing Clippy

view details

Steven Fackler

commit sha 2ce3f85d46edbf5105f2e93d2cbe56ad777b41e6

Tweak and stabilize AtomicN::fetch_update

view details

Philipp Krones

commit sha c1698fedeb69109f9b1aebc0bfccd9bf3112ccad

Apply suggestions from code review Co-authored-by: Phil Hansch <dev@phansch.net>

view details

Vadim Petrochenkov

commit sha 2d10babb71f6658c39279425ec5cda11a28d3af4

Stabilize fn-like proc macros in expression, pattern and statement positions

view details

Steven Fackler

commit sha 31c820552350e3f686a6f353982f0f31ecbaf4a7

Update src/libcore/sync/atomic.rs Co-authored-by: Ralf Jung <post@ralfj.de>

view details

Markus Westerlind

commit sha 1d8489c150df7d0e751f7c438541036df1a9ac5e

perf: Revert accidental inclusion of a part of #69218 This was accidentally included in #69494 after a rebase and given how much `inflate` and `keccak` stresses the obligation forest seems like a likely culprit to the regression in those benchmarks. (It is necessary in #69218 as obligation forest needs to accurately track the root variables or unifications will get lost)

view details

Guillaume Gomez

commit sha 7e855b59151f2e5c2a58fe422a273e997df14b24

Clean up rustdoc source code

view details

Erin Power

commit sha bb433914b5bdd6898200f8c1cadcfec27fbf7a26

Update RELEASES.md for 1.44.0

view details

Guillaume Gomez

commit sha c8fb0d7ef38957cd2b8f6e5b9b7ea47eaa6cca28

End unification of exit codes in librustdoc

view details

XAMPPRocky

commit sha bd5ed9e62f330971523fb75390b4a375bc1d875c

Update RELEASES.md Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>

view details

Bastian Kauschke

commit sha a8c152dfc921e8ec2c00f65e7c731197e522a96d

add regression tests + improve method name

view details

Bastian Kauschke

commit sha 3f661d25f9ce3b5ac6139c8d8bf4614b55dca5be

borrowck `DefId` -> `LocalDefId`

view details

Petr Hosek

commit sha c85768ed71eb09689e2065b122310dad2e1c42f6

Update the Fuchsia linker defaults This updates the linker defaults aligning them with Clang. Specifically, we use 4K pages on all platforms, we always use BIND_NOW, we prefer all loadable segments be separate and page aligned, and we support RELR relocations.

view details

Vardan Margaryan

commit sha 94e4b5ec316993200d75276b4e7c16a059bf3a57

Add the redundant_wildcard_enum_match lint

view details

Vardan Margaryan

commit sha 0ad9f7d651b52de4be6384c9b6dc893b389fd557

Fix trivial cases of new match_wildcard_for_single_variants lint

view details

Vardan Margaryan

commit sha 494830797744c09d6de3b2b2452ab185d2204005

Fix cases of match_wildcard_for_single_variants lint when it is spanned on Option

view details

Vardan Margaryan

commit sha 749619cfe34be1ee591f3af748fbdd4d2f54d3f0

Apply suggestions from PR review

view details

Vardan Margaryan

commit sha 1c59cd5f2110ff90a256f0948f05716403e84b85

Fix example code of wildcard_enum_match_arm lint

view details

Vardan Margaryan

commit sha 10313a2631efa6a01dc86199d554ce5a7c1bb51a

Revert "Fix cases of match_wildcard_for_single_variants lint when it is spanned on Option" This reverts commit 494830797744c09d6de3b2b2452ab185d2204005.

view details

push time in 2 months

push eventcjgillot/rust

Ralf Jung

commit sha 33541d5e55c3114e01e06b27715ae04372ce027f

clarify interaction of pin drop guarantee and panics

view details

Kevin Per

commit sha dfbc143e65dd4dc8499f7296ddc7889854a8cc7d

Adding if to prevent borrowing suggestion in structs #71136

view details

Kevin Per

commit sha bc29f1d062feeb68207c961d254652d6bff9fd9b

Adding new test #71136

view details

Kevin Per

commit sha d232be80f82b052fd023eb2f4904ccad0aa42d7a

Fix tidy checks

view details

Eduardo Sánchez Muñoz

commit sha 68f89fcbf982d4b2a40d3175568bef194ee4f3b7

Make `std::char` functions and constants associated to `char`.

view details

Eduardo Sánchez Muñoz

commit sha 0e12a9d9ac6f69ddd72f2c028f668c0b55ac2eda

Try to fix doc links in new `char` methods.

view details

csmoe

commit sha e07f63e79a618a0c5e53a71d053da0fa0dbc6970

add testcase for issue-70818

view details

Tobias Rapp

commit sha f99344ace44abc91f76df276625e048f1e8a9536

Stabilize saturating_abs and saturating_neg Stabilizes the following signed integer functions with saturation mechanics: * saturating_abs() * saturating_neg() Closes #59983

view details

csmoe

commit sha fb81c429ebd45f9ba2b1810f548cf59a45feb222

make yield span optional

view details

csmoe

commit sha a5d103ff90f4ad90b1f13f5b5de83a3eb758d9e2

record upvar into GeneratorInteriorTypeCause

view details

csmoe

commit sha d4bdcfd3cfbfa025c5363149a14f2b36a584b54a

don't record upvars into generator interior

view details

csmoe

commit sha 382a963c17122470918e1491a733b81fb545330d

filter upvars that cause trait obligation

view details

csmoe

commit sha d2e5a8e2e966df119021e3db6f6d4c2e189865cd

bless issue-70818 test case

view details

csmoe

commit sha c9e146515ba391410069a6fe3e55a4a1935bc5ae

checking on either interior or upvar

view details

Jubilee

commit sha 510fce10f8a22521ec861f4446a304f9a2e4c5bd

Unblock font loading in rustdoc.css rustdoc's font loading defaults to "auto", so browsers may block render. But rustdoc's case prefers a faster TTI for scrolling, this means the strictest font-display in use should be "swap". rustdoc's fonts do provide notable legibility improvements but first-time users will have little trouble reading without. This means "optional" is preferred. The one exception is Source Serif Pro: it's a big difference for body text, so "fallback" is preferred over "optional" to cause a (tiny) block.

view details

Vadim Petrochenkov

commit sha 1899afa685a9b43cccff0869c2b210bd397306a6

rustc-book: Document `-Z strip=val` option

view details

Esteban Küber

commit sha 0dcde02cc7bdd47f48af12e911829390c2864c47

Ignore arguments when looking for `IndexMut` for subsequent `mut` obligation Given code like `v[&field].boo();` where `field: String` and `.boo(&mut self)`, typeck will have decided that `v` is accessed using `Index`, but when `boo` adds a new `mut` obligation, `convert_place_op_to_mutable` is called. When this happens, for *some reason* the arguments' dereference adjustments are completely ignored causing an error saying that `IndexMut` is not satisfied: ``` error[E0596]: cannot borrow data in an index of `Indexable` as mutable --> src/main.rs:30:5 | 30 | v[&field].boo(); | ^^^^^^^^^ cannot borrow as mutable | = help: trait `IndexMut` is required to modify indexed content, but it is not implemented for `Indexable` ``` This is not true, but by changing `try_overloaded_place_op` to retry when given `Needs::MutPlace` without passing the argument types, the example successfully compiles. I believe there might be more appropriate ways to deal with this.

view details

bdbai

commit sha 5bfb7e7437dac924825be123f7c9645b4e4367e5

Add target thumbv7a-uwp-windows-msvc

view details

Jeremy Fitzhardinge

commit sha ff9646c0adc149dfff194665785f4daa3aa6d9c3

Stabilize process_set_argv0 feature for Unix This stabilizes process_set_argv0 targeting 1.45.0. It has been useful in practice and seems useful as-is. The equivalent feature could be implemented for Windows, but as far as I know nobody has. That can be done separately. Tracking issue: #66510

view details

Esteban Küber

commit sha a3f30bbc2d28572f9fa429cf3b31d7f95d3b0dda

Don't `type_of` on trait assoc ty without default Fix #72076.

view details

push time in 2 months

push eventcjgillot/rust

Ralf Jung

commit sha 33541d5e55c3114e01e06b27715ae04372ce027f

clarify interaction of pin drop guarantee and panics

view details

Kevin Per

commit sha dfbc143e65dd4dc8499f7296ddc7889854a8cc7d

Adding if to prevent borrowing suggestion in structs #71136

view details

Kevin Per

commit sha bc29f1d062feeb68207c961d254652d6bff9fd9b

Adding new test #71136

view details

Kevin Per

commit sha d232be80f82b052fd023eb2f4904ccad0aa42d7a

Fix tidy checks

view details

Eduardo Sánchez Muñoz

commit sha 68f89fcbf982d4b2a40d3175568bef194ee4f3b7

Make `std::char` functions and constants associated to `char`.

view details

Eduardo Sánchez Muñoz

commit sha 0e12a9d9ac6f69ddd72f2c028f668c0b55ac2eda

Try to fix doc links in new `char` methods.

view details

csmoe

commit sha e07f63e79a618a0c5e53a71d053da0fa0dbc6970

add testcase for issue-70818

view details

Tobias Rapp

commit sha f99344ace44abc91f76df276625e048f1e8a9536

Stabilize saturating_abs and saturating_neg Stabilizes the following signed integer functions with saturation mechanics: * saturating_abs() * saturating_neg() Closes #59983

view details

csmoe

commit sha fb81c429ebd45f9ba2b1810f548cf59a45feb222

make yield span optional

view details

csmoe

commit sha a5d103ff90f4ad90b1f13f5b5de83a3eb758d9e2

record upvar into GeneratorInteriorTypeCause

view details

csmoe

commit sha d4bdcfd3cfbfa025c5363149a14f2b36a584b54a

don't record upvars into generator interior

view details

csmoe

commit sha 382a963c17122470918e1491a733b81fb545330d

filter upvars that cause trait obligation

view details

csmoe

commit sha d2e5a8e2e966df119021e3db6f6d4c2e189865cd

bless issue-70818 test case

view details

csmoe

commit sha c9e146515ba391410069a6fe3e55a4a1935bc5ae

checking on either interior or upvar

view details

Jubilee

commit sha 510fce10f8a22521ec861f4446a304f9a2e4c5bd

Unblock font loading in rustdoc.css rustdoc's font loading defaults to "auto", so browsers may block render. But rustdoc's case prefers a faster TTI for scrolling, this means the strictest font-display in use should be "swap". rustdoc's fonts do provide notable legibility improvements but first-time users will have little trouble reading without. This means "optional" is preferred. The one exception is Source Serif Pro: it's a big difference for body text, so "fallback" is preferred over "optional" to cause a (tiny) block.

view details

Vadim Petrochenkov

commit sha 1899afa685a9b43cccff0869c2b210bd397306a6

rustc-book: Document `-Z strip=val` option

view details

Esteban Küber

commit sha 0dcde02cc7bdd47f48af12e911829390c2864c47

Ignore arguments when looking for `IndexMut` for subsequent `mut` obligation Given code like `v[&field].boo();` where `field: String` and `.boo(&mut self)`, typeck will have decided that `v` is accessed using `Index`, but when `boo` adds a new `mut` obligation, `convert_place_op_to_mutable` is called. When this happens, for *some reason* the arguments' dereference adjustments are completely ignored causing an error saying that `IndexMut` is not satisfied: ``` error[E0596]: cannot borrow data in an index of `Indexable` as mutable --> src/main.rs:30:5 | 30 | v[&field].boo(); | ^^^^^^^^^ cannot borrow as mutable | = help: trait `IndexMut` is required to modify indexed content, but it is not implemented for `Indexable` ``` This is not true, but by changing `try_overloaded_place_op` to retry when given `Needs::MutPlace` without passing the argument types, the example successfully compiles. I believe there might be more appropriate ways to deal with this.

view details

bdbai

commit sha 5bfb7e7437dac924825be123f7c9645b4e4367e5

Add target thumbv7a-uwp-windows-msvc

view details

Jeremy Fitzhardinge

commit sha ff9646c0adc149dfff194665785f4daa3aa6d9c3

Stabilize process_set_argv0 feature for Unix This stabilizes process_set_argv0 targeting 1.45.0. It has been useful in practice and seems useful as-is. The equivalent feature could be implemented for Windows, but as far as I know nobody has. That can be done separately. Tracking issue: #66510

view details

Esteban Küber

commit sha a3f30bbc2d28572f9fa429cf3b31d7f95d3b0dda

Don't `type_of` on trait assoc ty without default Fix #72076.

view details

push time in 2 months

Pull request review commentrust-lang/rust

Implement associated lang items

 pub fn provide(providers: &mut Providers<'_>) {     providers.hir_owner_nodes = |tcx, id| tcx.index_hir(LOCAL_CRATE).map[id].with_bodies.as_deref();     map::provide(providers); }++pub trait TargetExt {

Can this extension trait go back in librustc_passes? It does not really need to be in librustc_middle.

Aaron1011

comment created time in 3 months

push eventcjgillot/rust

Ralf Jung

commit sha 33541d5e55c3114e01e06b27715ae04372ce027f

clarify interaction of pin drop guarantee and panics

view details

Kevin Per

commit sha dfbc143e65dd4dc8499f7296ddc7889854a8cc7d

Adding if to prevent borrowing suggestion in structs #71136

view details

Kevin Per

commit sha bc29f1d062feeb68207c961d254652d6bff9fd9b

Adding new test #71136

view details

Kevin Per

commit sha d232be80f82b052fd023eb2f4904ccad0aa42d7a

Fix tidy checks

view details

Eduardo Sánchez Muñoz

commit sha 68f89fcbf982d4b2a40d3175568bef194ee4f3b7

Make `std::char` functions and constants associated to `char`.

view details

Eduardo Sánchez Muñoz

commit sha 0e12a9d9ac6f69ddd72f2c028f668c0b55ac2eda

Try to fix doc links in new `char` methods.

view details

csmoe

commit sha e07f63e79a618a0c5e53a71d053da0fa0dbc6970

add testcase for issue-70818

view details

Tobias Rapp

commit sha f99344ace44abc91f76df276625e048f1e8a9536

Stabilize saturating_abs and saturating_neg Stabilizes the following signed integer functions with saturation mechanics: * saturating_abs() * saturating_neg() Closes #59983

view details

csmoe

commit sha fb81c429ebd45f9ba2b1810f548cf59a45feb222

make yield span optional

view details

csmoe

commit sha a5d103ff90f4ad90b1f13f5b5de83a3eb758d9e2

record upvar into GeneratorInteriorTypeCause

view details

csmoe

commit sha d4bdcfd3cfbfa025c5363149a14f2b36a584b54a

don't record upvars into generator interior

view details

csmoe

commit sha 382a963c17122470918e1491a733b81fb545330d

filter upvars that cause trait obligation

view details

csmoe

commit sha d2e5a8e2e966df119021e3db6f6d4c2e189865cd

bless issue-70818 test case

view details

csmoe

commit sha c9e146515ba391410069a6fe3e55a4a1935bc5ae

checking on either interior or upvar

view details

Jubilee

commit sha 510fce10f8a22521ec861f4446a304f9a2e4c5bd

Unblock font loading in rustdoc.css rustdoc's font loading defaults to "auto", so browsers may block render. But rustdoc's case prefers a faster TTI for scrolling, this means the strictest font-display in use should be "swap". rustdoc's fonts do provide notable legibility improvements but first-time users will have little trouble reading without. This means "optional" is preferred. The one exception is Source Serif Pro: it's a big difference for body text, so "fallback" is preferred over "optional" to cause a (tiny) block.

view details

Vadim Petrochenkov

commit sha 1899afa685a9b43cccff0869c2b210bd397306a6

rustc-book: Document `-Z strip=val` option

view details

Esteban Küber

commit sha 0dcde02cc7bdd47f48af12e911829390c2864c47

Ignore arguments when looking for `IndexMut` for subsequent `mut` obligation Given code like `v[&field].boo();` where `field: String` and `.boo(&mut self)`, typeck will have decided that `v` is accessed using `Index`, but when `boo` adds a new `mut` obligation, `convert_place_op_to_mutable` is called. When this happens, for *some reason* the arguments' dereference adjustments are completely ignored causing an error saying that `IndexMut` is not satisfied: ``` error[E0596]: cannot borrow data in an index of `Indexable` as mutable --> src/main.rs:30:5 | 30 | v[&field].boo(); | ^^^^^^^^^ cannot borrow as mutable | = help: trait `IndexMut` is required to modify indexed content, but it is not implemented for `Indexable` ``` This is not true, but by changing `try_overloaded_place_op` to retry when given `Needs::MutPlace` without passing the argument types, the example successfully compiles. I believe there might be more appropriate ways to deal with this.

view details

bdbai

commit sha 5bfb7e7437dac924825be123f7c9645b4e4367e5

Add target thumbv7a-uwp-windows-msvc

view details

Jeremy Fitzhardinge

commit sha ff9646c0adc149dfff194665785f4daa3aa6d9c3

Stabilize process_set_argv0 feature for Unix This stabilizes process_set_argv0 targeting 1.45.0. It has been useful in practice and seems useful as-is. The equivalent feature could be implemented for Windows, but as far as I know nobody has. That can be done separately. Tracking issue: #66510

view details

Esteban Küber

commit sha a3f30bbc2d28572f9fa429cf3b31d7f95d3b0dda

Don't `type_of` on trait assoc ty without default Fix #72076.

view details

push time in 3 months

push eventcjgillot/rust

Ralf Jung

commit sha 33541d5e55c3114e01e06b27715ae04372ce027f

clarify interaction of pin drop guarantee and panics

view details

Kevin Per

commit sha dfbc143e65dd4dc8499f7296ddc7889854a8cc7d

Adding if to prevent borrowing suggestion in structs #71136

view details

Kevin Per

commit sha bc29f1d062feeb68207c961d254652d6bff9fd9b

Adding new test #71136

view details

Kevin Per

commit sha d232be80f82b052fd023eb2f4904ccad0aa42d7a

Fix tidy checks

view details

Eduardo Sánchez Muñoz

commit sha 68f89fcbf982d4b2a40d3175568bef194ee4f3b7

Make `std::char` functions and constants associated to `char`.

view details

Eduardo Sánchez Muñoz

commit sha 0e12a9d9ac6f69ddd72f2c028f668c0b55ac2eda

Try to fix doc links in new `char` methods.

view details

csmoe

commit sha e07f63e79a618a0c5e53a71d053da0fa0dbc6970

add testcase for issue-70818

view details

Tobias Rapp

commit sha f99344ace44abc91f76df276625e048f1e8a9536

Stabilize saturating_abs and saturating_neg Stabilizes the following signed integer functions with saturation mechanics: * saturating_abs() * saturating_neg() Closes #59983

view details

csmoe

commit sha fb81c429ebd45f9ba2b1810f548cf59a45feb222

make yield span optional

view details

csmoe

commit sha a5d103ff90f4ad90b1f13f5b5de83a3eb758d9e2

record upvar into GeneratorInteriorTypeCause

view details

csmoe

commit sha d4bdcfd3cfbfa025c5363149a14f2b36a584b54a

don't record upvars into generator interior

view details

csmoe

commit sha 382a963c17122470918e1491a733b81fb545330d

filter upvars that cause trait obligation

view details

csmoe

commit sha d2e5a8e2e966df119021e3db6f6d4c2e189865cd

bless issue-70818 test case

view details

csmoe

commit sha c9e146515ba391410069a6fe3e55a4a1935bc5ae

checking on either interior or upvar

view details

Matthew Jasper

commit sha 000993904b32e82e2cf8b0b22510ac602a69ef24

Check associated opaque types in check_opaque_types

view details

Matthew Jasper

commit sha 214aa9980659de40cbc11147ceea219e210d0de8

Make pretty printing `TyKind::Def` do something

view details

Matthew Jasper

commit sha ce7555d96def535f3d58c8d9634014826adf62b3

Stop special casing top level TAIT

view details

Matthew Jasper

commit sha 85101537eaaf60b374f86defa7605d318e63b544

Remove associated opaque types They're unused now.

view details

Matthew Jasper

commit sha 421c2f798399c4609df4cc35dfcb9ecd9f28b5af

Forbid lifetime elision in let position impl Trait This is consistent with types.

view details

Matthew Jasper

commit sha 24daec35df866018273ba6a2f919a304ec59a1e4

Add more tests for type alias impl Trait

view details

push time in 3 months

create barnchcjgillot/rust

branch : hirphan

created branch time in 3 months

delete branch cjgillot/rust

delete branch : nospan-perf

delete time in 3 months

push eventcjgillot/rust

Camille GILLOT

commit sha c4dc569b5bca1cb6196c2253e24e0c2491ea24d8

Don't pass spans in hir::map::blocks.

view details

push time in 3 months

create barnchcjgillot/rust

branch : nospan-lowering

created branch time in 3 months

issue commentrust-lang/rust

`HirId`-ification initiative

Ideally, those conversions would be reduced to

#[inline]
pub fn local_def_id_to_hir_id(&self, id: LocalDefId) -> hir::HirId {
    hir::HirId { owner: id, local_id: ItemLocalId::new(0) }
}

The issue is that some LocalDefId do not correspond to HIR nodes. The two maps are not equivalent. I got bit recently by this one. This happens when a DefId is created, but the HIR node is associated another unrelated HirId, no none at all. Fixing this requires to map the creation of LocalDefIds to HIR owners when lowering.

zackmdavis

comment created time in 3 months

issue commentrust-lang/rust

`HirId`-ification initiative

The LocalDefId <-> HirId is trivial, since a HirId is just the combination of a LocalDefId and a ItemlLocalId (an index inside the LocalDefId). The maps in the forward direction NodeId -> LocalDefId, HirId are used by HIR lowering a lot. Those allow to link together the HIR nodes. I do not know where the backwards map HirId -> NodeId are used.

zackmdavis

comment created time in 3 months

fork cjgillot/salsa

A generic framework for on-demand, incrementalized computation. Inspired by adapton, glimmer, and rustc's query system.

fork in 3 months

startedsalsa-rs/salsa

started time in 3 months

create barnchcjgillot/rust

branch : nospan-perf

created branch time in 3 months

pull request commentrust-lang/rust

Remove Spans from HIR

The HIR lowering regression appears to be mitigated. The performance diff is now located on all the other queries. For a very few cases, the query count is lower, and compilation is faster. For the rest, the query count is unchanged, and compilation is slower: it takes more work to get the spans.

cjgillot

comment created time in 3 months

push eventcjgillot/rust

CAD97

commit sha b70e7fd0db5d23a2e045e89b8bc7e5564acce9b7

Add inherent impls for unchecked math intrinsics

view details

CAD97

commit sha 2fcfd233f755c548ddc4d5fda517a7dbb9f04ba3

Redesign the Step trait

view details

CAD97

commit sha f34322d71f6ba523fb2c0ebef258d7e51a7531c8

Adjust Step::forward_checked docs for large types Co-Authored-By: Nadrieril Feneanar <nadrieril@users.noreply.github.com>

view details

Josh Stone

commit sha b0fb57bd8d18946787a79d1244154f2512dcf15b

impl From<Cow> for boxed slices and strings These forward `Borrowed`/`Owned` values to existing `Box::from` impls. - `From<Cow<'_, [T]>> for Box<[T]>` - `From<Cow<'_, str>> for Box<str>` - `From<Cow<'_, CStr>> for Box<CStr>` - `From<Cow<'_, OsStr>> for Box<OsStr>` - `From<Cow<'_, Path>> for Box<Path>`

view details

Josh Stone

commit sha 6d40751b37ef453bee5d8a9c47b00ef205d61738

impl From<Cow> for Rc and Arc These forward `Borrowed`/`Owned` values to existing `From` impls. impl<'a, B> From<Cow<'a, B>> for Rc<B> where B: ToOwned + ?Sized, Rc<B>: From<&'a B> + From<B::Owned>, impl<'a, B> From<Cow<'a, B>> for Arc<B> where B: ToOwned + ?Sized, Arc<B>: From<&'a B> + From<B::Owned>,

view details

Josh Stone

commit sha 23f71fe5b518c6136990f79733155b4fa1314d2b

Add tests from Cow

view details

Josh Stone

commit sha 22efd959109b9a231edbc81a8bc818eaa5763e78

Bless From<Cow> UI changes

view details

Donough Liu

commit sha 079817d62481ca8d84ca87dde9a276a1d5d663cf

Make `prefix` immutable

view details

Matthew Jasper

commit sha cb2703945ca3c6c9664a5a9ec606430cb79ba2c8

Use min_specialization in liballoc - Remove a type parameter from `[A]RcFromIter`. - Remove an implementation of `[A]RcFromIter` that didn't actually specialize anything. - Remove unused implementation of `IsZero` for `Option<&mut T>`. - Change specializations of `[A]RcEqIdent` to use a marker trait version of `Eq`. - Remove `BTreeClone`. I couldn't find a way to make this work with `min_specialization`. - Add `rustc_unsafe_specialization_marker` to `Copy` and `TrustedLen`.

view details

rail

commit sha ad9ad6f402e3e15706519e59ef111a941d28d5af

Don't negate resulted offsets when `offset` is subtraction by 0

view details

rail

commit sha 37261a904ce2fbd4137180500c57f75f29945828

Print 0 when `end` and `offset` is 0, and also simplify the suggestion

view details

rail

commit sha 75ad839cd26c1da17fe6ba3aae1153ee96de26c8

Do not trigger `manual_memcpy` for `RangeTo`

view details

rail

commit sha c94f0f49f8e025aae11534f9f2b4c59c34b1edb8

Remove all `ref` keyword

view details

rail

commit sha 7dd0f3459f558c1b557223a042f549b378cacae9

Refactor `if` to use `else` and iterator combinators

view details