profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/chungy/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

chungy/reflac 26

Shell script to recompress FLAC files

chungy/cmdpack 11

mirror/fork of cmdpack by Neill Corlett

chungy/diveintopython 9

Dive Into Python 5.4, for Python2

chungy/Dive-Into-Python-3 5

Push of Mark Pilgrim's DIP3 after his disappearance

chungy/ex-vi 3

lift of the ex-vi CVS repo

chungy/chocolate-doom 2

Chocolate Doom is a Doom source port that is conservative and historically accurate.

chungy/CssGitHubWindows 2

(UserStyle) GitHub Windows Edition [MIT]

chocolatiers/ChocoRenderLimits 1

This is ChocoRenderLimits which is used to assist vanilla mappers in testing and keeping within vanilla limits.

chungy/doom-pwads 1

Make PWADs of Doom's levels

chungy/doomretro 1

The classic, refined DOOM source port. For Windows PC.

issue commentmatrix-org/matrix-appservice-irc

Bridge libera.chat

I also don't get automatically identified after using !storepass

TheEvilSkeleton

comment created time in a month

issue commentchocolate-doom/chocolate-doom

chocolate-heretic does not honor -config parameter

You need to use -extraconfig for the non-vanilla configuration file.

wesleywerner

comment created time in 2 months

issue commentchocolate-doom/chocolate-doom

Supporting the behaviors of two variations of Hexen 1.1

Thus, there are 3 options to tackle this:

  • Just do nothing and leave the older A_SoAExplode behaviors.
  • Revert my change.
  • Support both variations of Hexen 1.1, in the same way that Chocolate Doom supports 4 variations of Doom identified as "1.9".

If we only want to support one version, I think the behavior of the Mar 12 build is the "correct" one, as it appears to be the most common version of Hexen 1.1. I believe the Mar 22 build was primarily distributed through the "TestDrive" software (included on Heretic SotSS, Master Levels, Hexen Deathkings, Quake Shareware) and thus far less likely to be known or relied upon.

Supporting two versions shouldn't be very difficult, and as you say, such a thing is already handled with Doom 1.9 (Registered/Doom2, Ultimate, two versions of Final Doom). Naming might be weird, but we also already have "final" and "final2" without anybody making much of a fuss. The recent convention of calling it Hexen 1.1r2 might work fine enough. Default to "1.1" (Mar 12), have a "1.1r2" (Mar 22) to emulate also.

NY00123

comment created time in 2 months

issue commentopenzfs/zfs

after zpool upgrade, the need to update bootcode is not mentioned

What's required depends heavily on factors such as whether the pool is even required for booting (I know, your zroot example is one such), whether the partitions are in MBR or GPT format, and whether you use BIOS or UEFI to boot.

I feel like the bootloader is out of scope and it's a detail of system administration external to ZFS, especially when OpenZFS also covers Linux and its even more varied mechanisms for booting.

I'm assuming this particular instance follows an upgrade from FreeBSD 12.x to 13.0. FreeBSD probably should document their upgrade procedures to include updating the boot loader.

dlangille

comment created time in 2 months

push eventfreedoom/freedoom.github.io

Mike Swanson

commit sha 5af68fe5b8100fada6f6c2a4e64eba84d5c5a92b

COPYING: Update © year to 2021

view details

Mike Swanson

commit sha 7af9eb7aa53fbbc5a21cb3ff3d9fd569f512b37c

help: remove “website” explicit ID AsciiDoc automatically generates links, though with a underscore to start, we don’t internally link to this section from any other page.

view details

Mike Swanson

commit sha 8f17f6047cfb5848d3b1fcf6b8eec50287c29139

help: Clarify our denial for financial contributions Based on gh:freedoom/freedoom#739, we don’t take donations.

view details

push time in 2 months

issue closedfreedoom/freedoom

Donate Cash/Coin?

I was looking at the help freedoom page but I didn't see any mention of donating money to the project. Are you accepting that kind of donation?

closed time in 2 months

david-a-redick

issue commentfreedoom/freedoom

Donate Cash/Coin?

We are not and not in a position of hiring asset designers to do so, nor do we currently use for-pay hosting services that make it necessary.

I appreciate the desire to financially support the project, but we don't have a present need for it.

david-a-redick

comment created time in 2 months

issue commentfreedoom/freedoom

IDEA: Use Open sourced romero assets

I don't think John Romero actually has any legal power over the files. Just because he released them doesn't really mean they're open source.

Plus they probably don't mesh thematically with Freedoom.

abcd1234-byte

comment created time in 2 months

issue commentCh0wW/iwadverifier

Need to get Hexen's "Retail Store Beta" WAD hashes

You can get a copy via the https://github.com/Doom-Utils/iwad-patches repository. The beta WAD in particular has an md5sum of c88a2bb3d783e2ad7b599a8e301e099e

Ch0wW

comment created time in 2 months

PR opened openzfs/zfs

Disable normalization implicitly when setting "utf8only=off".

Motivation and Context

When creating a new zfs file system and -o utf8only=off is passed as a parameter, the option could silently be overridden and switched to the on state due to the parent dataset having a normalization value != none. This is counter-intuitive and potentially harmful as it may go unnoticed until a non-UTF8 conforming file name is attempted to be created, at which moment the normal error about an invalid UTF8 sequence will be returned.

The zfsprops(8) manpage for utf8only has language already that might imply this: "If this property is explicitly set to off, the normalization property must either not be explicitly set or be set to none."

I describe the issue in #11892 with an example sequence of commands that triggers the bad behavior.

Description

lib/libzfs/libzfs_dataset.c already has code that detects when the normalization property is set and switches utf8only to on. Added another conditional to set normalization to none when utf8only is set to off.

How Has This Been Tested?

Compiled a version of ZFS with this change, ran my sample commands as I presented in the open issue, and checked the utf8only and normalization properties to make sure they are set as appropriate.

Types of changes

<!--- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Performance enhancement (non-breaking change which improves efficiency)
  • [ ] Code cleanup (non-breaking change which makes code smaller or more readable)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • [ ] Documentation (a change to man pages or other documentation)

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [X] My code follows the OpenZFS code style requirements.
  • [ ] I have updated the documentation accordingly.
  • [X] I have read the contributing document.
  • [ ] I have added tests to cover my changes.
  • [ ] I have run the ZFS Test Suite with this change applied.
  • [X] All commit messages are properly formatted and contain Signed-off-by.
+9 -0

0 comment

1 changed file

pr created time in 2 months

push eventchungy/zfs

Brian Atkinson

commit sha 19c9247d5754fc3d534f1561899f3a3f3a341927

Fixing m4 iops rename check The configure check for iops->rename wanting flags was missing the AC_MSG_CHECKING() so it would just print yes without saying what was being checked. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Brian Atkinson <batkinson@lanl.gov> Closes #11825

view details

Brian Behlendorf

commit sha 9f9e1b5425ffa3e248504e401828eb13a3f1d00e

CI: Increase free space in workflow Recently we've been running out of free space in the ubuntu 20.04 environment resulting in test failures. This appears to be caused by a change in the default available free space and not because of any change in OpenZFS. Try and avoid this failure by applying a suggested workaround which removes some unnecessary files. https://github.com/actions/virtual-environments/issues/2840 Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #11826

view details

Ryan Moeller

commit sha 3ba10f9a6ae3c1b339fb7ff78a6bc9c314e3e08c

Atomically check and set dropped zevent count ratelimit_dropped isn't protected by a lock and is expected to be updated atomically. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #11822

view details

Ryan Moeller

commit sha 032a213e2e6b791364301e9de029e7b8189a69a0

Don't scale zfs_zevent_len_max by CPU count The lower bound for this scaling to too low and the upper bound is too high. Use a fixed default length of 512 instead, which is a reasonable value on any system. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #11822

view details

Ryan Moeller

commit sha c05eec32a7f7eeeb17c328f39da742a8096a5991

Allow pool names that look like Solaris disk names Nothing bad happens if a prefix of your pool name matches a disk name. This is a bit of a silly restriction at this point. Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Ryan Moeller <freqlabs@FreeBSD.org> Closes #11781 Closes #11813

view details

Brian Behlendorf

commit sha fe6babced2f3a5eff9d70e380f2054d5f18fa4c0

Bump libzfs.so and libzpool.so versions Bump the library versions as advised by the libtool guidelines. https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html Two new functions were added but no existing functions were changed, so we increase the version and the age (version:revision:age). Added functions (2): - boolean_t zpool_is_draid_spare(const char *); - zpool_compat_status_t zpool_load_compat(const char *, boolean_t *, char *, char *); Additionally bump the libzpool.so version information. This library is for internal use but we still want to update the version to track major changes to the interfaces. The libzfsbootenv, libuutil, libnvpair and libzfs_core libraries have not been updated. Reviewed-by: Richard Laager <rlaager@wiktel.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #11817

view details

Ryan Moeller

commit sha 02aaf11fc793e0c632223a95d24db0969d0ba602

FreeBSD: Fix stable/12 after AT_BENEATH removal Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #11827

view details

Ryan Moeller

commit sha dce31763491e462876ff8706cb651bf488f443a0

Avoid taking global lock to destroy zfsdev state We have exclusive access to our zfsdev state object in this section until it is invalidated by setting zs_minor to -1, so we can destroy the state without taking a lock if we do the invalidation last, after a member to ensure correct ordering. While here, strengthen the assertions that zs_minor is valid when we enter. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ryan Moeller <freqlabs@FreeBSD.org> Closes #11751

view details

Ryan Moeller

commit sha 583e320546972945b9bf79fac82bf3c398d74d3b

ZTS: inheritance/inherit_001_pos is flaky Add inheritance/inherit_001_pos to the maybe fails on FreeBSD list. Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #11830

view details

наб

commit sha 3ef80eefff37d92315b030008edc853512d487da

zed: set names for all threads Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #11807

view details

наб

commit sha ca2ce9c50b6b579741de12867c9b7cbf4f799cb4

zed: use separate reaper thread and collect ZEDLETs asynchronously Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #11807

view details

наб

commit sha 02a0fa19995a865fe5194f1777e77dc8779d89b6

zed: remove unused zed_file_close_on_exec() The FIXME comment was there since the initial implementation in 2014, there are no users Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #11807

view details

наб

commit sha 73218f41b4413ec75a5d877771a03ab98e8fb3c3

zed: allow limiting concurrent jobs 200ms time-out is relatively long, but if we already hit the cap, then we'll likely be able to spawn multiple new jobs when we wake up Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #11807

view details

Brian Behlendorf

commit sha c0af3c7b2c7bf1c601b4130533a9efebe42c581c

Add RELEASES.md file Document the project's policy regarding publishing and maintaining official OpenZFS releases. Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #11821

view details

наб

commit sha 943df59ed942182427ed50b94a346dc22c4407e6

bash_completion.d: always call zfs/zpool binaries directly /dev/zfs is 0:0 666 on most systems, so the [ -w /dev/zfs ] check always succeeds, but if zfs isn't in $PATH (e.g. when completing from "/sbin/zfs list" on a regular account) this can lead to error spew like nabijaczleweli@szarotka:~$ /sbin/zfs list bash: zfs: command not found @ bash: zfs: command not found We only do read-only commands, and quite general ones at that, so there's no need to elevate one way or another. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #11828

view details

Andrea Gelmini

commit sha bf169e9f15efbc343b931f20cfad5d2b59c8a821

Fix various typos Correct an assortment of typos throughout the code base. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Closes #11774

view details

Brian Behlendorf

commit sha ec580225d2b2fb78ea9e12d0b08a185fbb50c7a6

ZTS: pool_checkpoint improvements The pool_checkpoint tests may incorrectly fail because several of them invoke zdb for an imported pool. In this scenario it's not unexpected for zdb to fail if the pool is modified. To resolve this these zdb checks are now done after the pool has been exported. Additionally, the default cleanup functions assumed the pool would be imported when they were run. If this was not the case they're exit early and fail to cleanup all of the test state causing subsequent tests to fail. Add a check to only destroy the pool when it is imported. Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #11832

view details

наб

commit sha 61b50107a58a1da9d86f5f81dc35d039ca629aae

libzutil: zfs_isnumber(): return false if input empty zpool list, which is the only user, would mistakenly try to parse the empty string as the interval in this case: $ zpool list "a" cannot open 'a': no such pool $ zpool list "" interval cannot be zero usage: <usage string follows> which is now symmetric with zpool get: $ zpool list "" cannot open '': name must begin with a letter Avoid breaking the "interval cannot be zero" string. There simply isn't a need for this, and it's user-facing. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #11841 Closes #11843

view details

George Melikov

commit sha d35708b18705adf3b1854061bec1f6ba29545aec

man: fix wrong .Xr macros usages In addition, html doc will have working hyperlinks. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: George Melikov <mail@gmelikov.ru> Closes #11845

view details

наб

commit sha 57a1214e3aa295a8f4b5683bf6891d99cb297112

zpool-features.5: remove "booting not possible with this feature"s The exact limitations on what features are supported when booting vary considerably depending on the environment. In order to minimize confusion avoid categorical statements which assume GRUB2 is being used. The supported GRUB2 features are covered earlier in this man page for easy reference. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #11842

view details

push time in 2 months

issue commentDoom-Utils/iwad-patches

Please add Boom 2.0x and MBF

I believe anything that isn't an official release of the game engines is out-of-scope. We have some rare ones, but presumably everything here is what was compiled by someone at sometime by id, Raven, or Rogue.

fabiangreffrath

comment created time in 3 months

issue commentDoom-Utils/iwad-patches

Please add Boom 2.0x and MBF

Maybe as an alternative, we can have a different repository hosting binaries of prominent/dead source ports?

fabiangreffrath

comment created time in 3 months

issue commentDoom-Utils/iwad-patches

Please add Boom 2.0x and MBF

I don't think this repository is really an appropriate place for them, and all the binaries I know of are on idgames...

There is (some) source code in the historic-ports repo: https://github.com/Doom-Utils/historic-ports/commits/mbf

fabiangreffrath

comment created time in 3 months

issue closedDoom-Utils/iwad-patches

Hexen v1.1 to "retail store beta"

@xttl provided some binary deltas here: https://www.doomworld.com/forum/topic/121524-hexen-v11-to-retail-store-beta-downgrader/

closed time in 3 months

fabiangreffrath

issue commentDoom-Utils/iwad-patches

Hexen v1.1 to "retail store beta"

Seems I looked at the Doomworld thread at the same time as you. I've added what I think should be a complete set of files, thanks :)

fabiangreffrath

comment created time in 3 months

push eventDoom-Utils/iwad-patches

Mike Swanson

commit sha f6291cc52ddaf3448c09c73fc34e759006824020

vanilla-engine: add variants of the Hexen engine files Newly-discovered by xttl (at Doomworld) is a pre-retail build of Hexen leaked to the public via warez channels. It is being provided here for historical reference. There are variants of both 1.0 and 1.1 also discovered, without a clear origin, perhaps floppy disk versions or some quick unversioned patched was released to fix critical issues (see Doom 2 1.7→1.7a). Steam notably distributes the “r1” version of 1.1, while GOG.com distributes the “r2” version. My own CD of Hexen carries the “r2”…

view details

Mike Swanson

commit sha e182fae748f04da36320dab5328a03eaf72bdf92

hexen.wad: Add “beta” version discovered by @xttl

view details

push time in 3 months