profile
viewpoint
Christian Moritz chrmoritz Dresden, Germany

chrmoritz/qr3d 2

a WebGL based 3D QR code renderer which can be used to test QR code scanners ability to read them under high angles, bad light conditions etc.

chrmoritz/asura-chess 0

GW2 Asura Chess Game (hmtl5, javascript, css)

chrmoritz/brew 0

:beer: The missing package manager for OS X

chrmoritz/cargo_gn 0

Cargo GN integration

chrmoritz/chromium_build 0

Deno floats patches to //build here (they will be sent upstream eventually)

chrmoritz/deno 0

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

chrmoritz/dns.js.org 0

Free and short JS.ORG domains for GitHub Pages

chrmoritz/formula-patches 0

:hospital: Patches for Homebrew formulae

chrmoritz/fritzapi 0

Home automation API for Fritz!Box, Fritz!DECT and FRITZ!Powerline devices

Pull request review commentHomebrew/homebrew-core

elasticsearch 7.6

+class ElasticsearchAT76 < Formula+  desc "Distributed search & analytics engine"+  homepage "https://www.elastic.co/products/elasticsearch"+  url "https://github.com/elastic/elasticsearch/archive/v7.6.2.tar.gz"+  sha256 "6ff4871dcae6954e13680aefc196da574a59a36418d06a7e095550ce81a370f8"++  head do+    url "https://github.com/elasticsearch/elasticsearch.git"+  end++  depends_on "openjdk"++  def cluster_name+    "elasticsearch_#{ENV["USER"]}"+  end++  def install+    # Build the package from source+    system "./gradlew", ":distribution:archives:oss-no-jdk-darwin-tar:assemble"++    mkdir "tar" do+      # Extract the package to the tar directory+      system "tar", "--strip-components=1", "-xf",+        Dir["../distribution/archives/oss-no-jdk-darwin-tar/build/distributions/elasticsearch-oss-*.tar.gz"].first++      # Install into package directory+      libexec.install "bin", "config", "lib", "modules"
      libexec.install "bin", "lib", "modules"
      (etc/"elasticsearch").install Dir["config/*"]

and updating the config inreplace's below

ankane

comment created time in 2 days

Pull request review commentHomebrew/homebrew-core

elasticsearch 7.6

+class ElasticsearchAT76 < Formula+  desc "Distributed search & analytics engine"+  homepage "https://www.elastic.co/products/elasticsearch"+  url "https://github.com/elastic/elasticsearch/archive/v7.6.2.tar.gz"+  sha256 "6ff4871dcae6954e13680aefc196da574a59a36418d06a7e095550ce81a370f8"++  head do+    url "https://github.com/elasticsearch/elasticsearch.git"+  end++  depends_on "openjdk"++  def cluster_name+    "elasticsearch_#{ENV["USER"]}"+  end++  def install+    # Build the package from source+    system "./gradlew", ":distribution:archives:oss-no-jdk-darwin-tar:assemble"++    mkdir "tar" do+      # Extract the package to the tar directory+      system "tar", "--strip-components=1", "-xf",+        Dir["../distribution/archives/oss-no-jdk-darwin-tar/build/distributions/elasticsearch-oss-*.tar.gz"].first++      # Install into package directory+      libexec.install "bin", "config", "lib", "modules"+    end++    inreplace libexec/"bin/elasticsearch-env",+              "if [ -z \"$ES_PATH_CONF\" ]; then ES_PATH_CONF=\"$ES_HOME\"/config; fi",+              "if [ -z \"$ES_PATH_CONF\" ]; then ES_PATH_CONF=\"#{etc}/elasticsearch\"; fi"++    # Set up Elasticsearch for local development:+    inreplace "#{libexec}/config/elasticsearch.yml" do |s|+      # 1. Give the cluster a unique name+      s.gsub!(/#\s*cluster\.name\: .*/, "cluster.name: #{cluster_name}")++      # 2. Configure paths+      s.sub!(%r{#\s*path\.data: /path/to.+$}, "path.data: #{var}/lib/elasticsearch/")+      s.sub!(%r{#\s*path\.logs: /path/to.+$}, "path.logs: #{var}/log/elasticsearch/")+    end++    inreplace "#{libexec}/config/jvm.options", %r{logs/gc.log}, "#{var}/log/elasticsearch/gc.log"++    # Move config files into etc+    (etc/"elasticsearch").install Dir[libexec/"config/*"]+    (libexec/"config").rmtree++    bin.install libexec/"bin/elasticsearch",+                libexec/"bin/elasticsearch-keystore",+                libexec/"bin/elasticsearch-plugin",+                libexec/"bin/elasticsearch-shard"+    bin.env_script_all_files(libexec/"bin", :JAVA_HOME => Formula["openjdk"].opt_prefix)+  end++  def post_install+    # Make sure runtime directories exist+    (var/"lib/elasticsearch").mkpath+    (var/"log/elasticsearch").mkpath+    ln_s etc/"elasticsearch", libexec/"config" unless (libexec/"config").exist?+    (var/"elasticsearch/plugins").mkpath+    ln_s var/"elasticsearch/plugins", libexec/"plugins" unless (libexec/"plugins").exist?+    # fix test not being able to create keystore because of sandbox permissions+    system bin/"elasticsearch-keystore", "create" unless (etc/"elasticsearch/elasticsearch.keystore").exist?

A far as I understand this, we need a created keystore to run the tests. But because etc/elasticsearch is protected by the sandbox during test time, we need to create said keystore in post_install.

However I'm not sure how good and bad already creating a default keystore is for actual users of this formula.

ankane

comment created time in 2 days

pull request commentHomebrew/homebrew-core

v8 8.3.110.9

@jeroen Did you update all the resources according to the DEPS file? For me it looks like you could have missed the icu upgrade in: https://github.com/v8/v8/blob/8.4.371.7/DEPS#L79

chrmoritz

comment created time in 6 days

issue commentHomebrew/homebrew-core

brew test node failing

It's looks like you have damaged your npm/npx installation (in /usr/local/bin) somehow.

Could you try to run brew postinstall node and then try brew test node again?

ryenus

comment created time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-0.10.0

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-0.11.0

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-0.12.0

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : v8-7.5.288.30

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-0.13.0

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : v8-7.6.303.27

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : node-12.7.0

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : v8-7.6.303.29

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-0.14.0

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-0.16.0

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-0.15.0

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : node-12.8.1

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : node@10-10.16.3

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : node@8-8.16.1

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-0.17.0

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : v8-7.7.299.11

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : joplin-1.0.150

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-0.26.0

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-0.25.0

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : v8-7.9.317.31

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-0.28.0

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-0.28.1

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-0.30.0

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : v8-8.0.426.16

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : v8-8.0.426.25

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-1.0.1

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-1.0.0

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : v8-8.1.307.28

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-0.40.0

delete time in 10 days

delete branch chrmoritz/homebrew-core

delete branch : deno-0.42.0

delete time in 10 days

delete branch chrmoritz/homebrew-deno

delete branch : deno-1.0.1

delete time in 10 days

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha 5a29e44df6b38c8acdf035b33ad7699309dca5ae

deno 1.0.1 (#6)

view details

push time in 10 days

PR merged chrmoritz/homebrew-deno

deno 1.0.1
+3 -3

0 comment

1 changed file

chrmoritz

pr closed time in 10 days

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha 74968f07b93ce82c29f667ad705f9adb93ed4ffc

Update deno.rb

view details

push time in 10 days

delete branch chrmoritz/homebrew-deno

delete branch : deno-1.0.0

delete time in 10 days

PR opened chrmoritz/homebrew-deno

deno 1.0.1
+2 -2

0 comment

1 changed file

pr created time in 10 days

create barnchchrmoritz/homebrew-deno

branch : deno-1.0.1

created branch time in 10 days

create barnchchrmoritz/homebrew-core

branch : deno-1.0.1

created branch time in 10 days

PR opened Homebrew/homebrew-core

deno 1.0.1

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in 10 days

pull request commentHomebrew/homebrew-core

v8 8.3.110.9

Wait what, you can now nest a patch block into a resource block. That's great! 👍 (This wasn't possible a few years ago when I've needed it the last time).

I've just applied the deno revert for now, instead of creating our own. I hope that's fine.

chrmoritz

comment created time in 11 days

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha 9c81126a576881c361c0dacd928ac996907d08e5

v8 8.3.110.9

view details

push time in 11 days

pull request commentHomebrew/homebrew-core

v8 8.3.110.9

Can you tell me, how to do so?

It tries to apply the patch for installing the resources if I try to use a normal top level patch block and fails because the resources files aren't there yet,

chrmoritz

comment created time in 11 days

pull request commentHomebrew/homebrew-core

v8 8.3.110.9

On High Sierra:

[1357/1372] rm -f obj/third_party/zlib/google/libcompression_utils_portable.a && TOOL_VERSION=1589958237 python ../build/toolchain/mac/filter_libtool.py /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static -D  -o obj/third_party/zlib/google/libcompression_utils_portable.a -filelist obj/third_party/zlib/google/libcompression_utils_portable.a.rsp
FAILED: obj/third_party/zlib/google/libcompression_utils_portable.a 
rm -f obj/third_party/zlib/google/libcompression_utils_portable.a && TOOL_VERSION=1589958237 python ../build/toolchain/mac/filter_libtool.py /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static -D  -o obj/third_party/zlib/google/libcompression_utils_portable.a -filelist obj/third_party/zlib/google/libcompression_utils_portable.a.rsp
error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: unknown option character `D' in: -D
Usage: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols]
Usage: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load]

Oh I forgot that we have to either drop High Sierra support or revert that specific chromium/build commit similar to like it was done in https://github.com/denoland/chromium_build/commit/56551e71dc0281cc1d9471caf6a02d02f18c830e.

chrmoritz

comment created time in 11 days

pull request commentHomebrew/homebrew-core

v8 8.3.110.9

No, unfortunately not. Google tends to adopt the latest clang features quite quickly.

But it's likely that Apple clang 12 (which will be shipped with macOS 10.16 this autumn) will be based on llvm 10 and compatible again.

chrmoritz

comment created time in 11 days

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha d6d8b8eba491ae2719fec7239c3deda1f60101ae

v8 8.3.110.9

view details

push time in 11 days

create barnchchrmoritz/homebrew-core

branch : v8-8.3.110.9

created branch time in 11 days

PR opened Homebrew/homebrew-core

v8 8.3.110.9

Created with brew bump-formula-pr.

+16 -18

0 comment

1 changed file

pr created time in 11 days

issue commentdenoland/deno

failed to run custom build command for rusty_v8 v0.4.2

AppData\Local\Temp\cargoXXXXX is just the temporary dictionary, where the build happens on Windows.

Running set V8_FROM_SOURCE=1 and cargo install deno should build an 32-bit version from source (Note that this would require Python 2.7 to be installed.)

May I ask you how you've installed rust? Did you by any chance installed the 32-bit version of rust or did you run any command to change the target architecture from x86_64-pc-windows-msvc to i686-pc-windows-msvc like passing a --target argument to cargo install deno? What's the output of running rustup toolchain list (if you use rustup)?

offline-pixel

comment created time in 11 days

issue commentdenoland/deno

failed to run custom build command for rusty_v8 v0.4.2

From rusty_v8_release_i686-pc-windows-msvc.lib it looks like you're trying to build a 32-bit version of deno. However there are no prebuilt binaries available for a 32-bit version of rusty_v8 and that's why the download fails. If you really intended to build a 32-bit version, you have to set the environment variable V8_FROM_SOURCE=1 or otherwise target x86_64-pc-windows-msvc.

But if you just want to install the latest version of deno, then there are also complete binaries available at the release page or you could use deno_install.

offline-pixel

comment created time in 12 days

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha ba95e7f1a927ec955fa9cdddc251b38242f6797b

deno 1.0.0 (#5)

view details

push time in 17 days

PR merged chrmoritz/homebrew-deno

deno 1.0.0
+4 -4

0 comment

1 changed file

chrmoritz

pr closed time in 17 days

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha 0627fb924a4d7a551d0b84177f6773fcb69e6bb7

Update deno.rb

view details

push time in 17 days

delete branch chrmoritz/homebrew-deno

delete branch : deno-0.41.0

delete time in 17 days

PR opened chrmoritz/homebrew-deno

Update deno.rb
+3 -3

0 comment

1 changed file

pr created time in 17 days

create barnchchrmoritz/homebrew-deno

branch : deno-1.0.0

created branch time in 17 days

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha 917688377f0672a01c06b0aa63ab4eb59e27b15a

deno 1.0.0

view details

push time in 17 days

create barnchchrmoritz/homebrew-core

branch : deno-1.0.0

created branch time in 17 days

PR opened Homebrew/homebrew-core

deno 1.0.0

Created with brew bump-formula-pr.

+3 -3

0 comment

1 changed file

pr created time in 17 days

push eventchrmoritz/material-ui-pickers

Christian Moritz

commit sha 7eb44e8894e545c25582fcbe4cda61343d0916b4

fix typo

view details

push time in 24 days

fork chrmoritz/material-ui-pickers

Date & Time pickers, built with ❤️ for @material-ui/core

https://material-ui-pickers.dev

fork in 24 days

create barnchchrmoritz/homebrew-core

branch : deno-0.42.0

created branch time in a month

PR opened Homebrew/homebrew-core

deno 0.42.0

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in a month

pull request commentHomebrew/homebrew-core

elasticsearch, kibana 6.8.8

Because:

  • it's a complicated update and we still need to find someone, who wants to do it
  • not all beats are migrated yet to allow a OSS only build, so we would need to remove some of them, because these old 6.x.x beats aren't compatible with the 7.x.x stack
Bo98

comment created time in a month

pull request commentHomebrew/homebrew-core

elasticsearch, kibana 6.8.8

There is a reason, why we used to ship the exact requested node LTS version as a request.

If you want to continue to use node@10 for it, you might be better done with removing the engines.node field from the package.json, because it's checked in multiple places by both yarn and their own build scripts.

https://github.com/elastic/kibana/blob/v6.8.8/package.json#L430

Bo98

comment created time in a month

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha 504334f9c6ee3dbcff10503a6d60f578535fd63b

deno 0.41.0 (#4)

view details

push time in a month

PR merged chrmoritz/homebrew-deno

deno 0.41.0
+3 -3

0 comment

1 changed file

chrmoritz

pr closed time in a month

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha 0f5eb603ef20f57cb1ab1b79b50c0e43858099e5

Update deno.rb

view details

push time in a month

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha 0cbb64c8bd7456bb7ee5d93397f79334263ffcf4

Update build_bottle.yml

view details

push time in a month

PR opened chrmoritz/homebrew-deno

deno 0.41.0
+2 -2

0 comment

1 changed file

pr created time in a month

create barnchchrmoritz/homebrew-deno

branch : deno-0.41.0

created branch time in a month

issue commentdenoland/deno

Cannot be installed with Homebrew on Linux

Exactly, it's related to the Python 2 EOL and the fact that Chromium/build unfortunately still only works with Python 2. Building anything which requires Python 2 on Homebrew (for Linux) is just no longer supported at all (it still works on macOS if the ancient system python 2 is working with it, but apple could decide to drop that anytime too).

I've now moved my experiment with pypy2 in it's own tap: https://github.com/chrmoritz/homebrew-deno/blob/master/Formula/deno.rb.

You could try it out with brew install chrmoritz/deno/deno (it also includes a Github Actions built bottle for 0.40.0).

davidbailey00

comment created time in 2 months

delete branch chrmoritz/homebrew-deno

delete branch : test_bottle

delete time in 2 months

delete branch chrmoritz/homebrew-deno

delete branch : deno-0.40.0

delete time in 2 months

delete branch chrmoritz/homebrew-deno

delete branch : chrmoritz-patch-1

delete time in 2 months

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha d96af3d7075cefd543e628671241a08b8698470b

deno 0.40.0 (#3)

view details

push time in 2 months

PR merged chrmoritz/homebrew-deno

deno 0.40.0
+4 -4

0 comment

1 changed file

chrmoritz

pr closed time in 2 months

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha 95ecd030babd71fa8d01c753a6951e296a2ea5dd

Update deno.rb

view details

push time in 2 months

PR opened chrmoritz/homebrew-deno

deno 0.40.0
+2 -2

0 comment

1 changed file

pr created time in 2 months

create barnchchrmoritz/homebrew-deno

branch : chrmoritz-patch-1

created branch time in 2 months

PR closed chrmoritz/homebrew-deno

deno 0.40.0
+3 -9

0 comment

1 changed file

chrmoritz

pr closed time in 2 months

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha ab5ac024a13c2935eb482d44ea2688c6afd2a11b

deno: cleanup

view details

push time in 2 months

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha d5aa9c0932f7d44b658d24ec692b9f261a5d9775

brew test-bot: pass root-url

view details

push time in 2 months

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha 81909c0ac1264ac50f0c5eb4fa765354f58df924

deno: update bottle root_url

view details

push time in 2 months

delete tag chrmoritz/homebrew-deno

delete tag : 0.39.0

delete time in 2 months

created tagchrmoritz/homebrew-deno

tagbottles

denon for Linuxbrew

created time in 2 months

release chrmoritz/homebrew-deno

bottles

released time in 2 months

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha 99af16e85110ce9cf5d37a57dcfaa6a5036b2198

remove unseless gn resource [skip ci]

view details

push time in 2 months

PR opened chrmoritz/homebrew-deno

deno 0.40.0
+3 -3

0 comment

1 changed file

pr created time in 2 months

create barnchchrmoritz/homebrew-deno

branch : deno-0.40.0

created branch time in 2 months

create barnchchrmoritz/homebrew-core

branch : deno-0.40.0

created branch time in 2 months

PR opened Homebrew/homebrew-core

deno 0.40.0

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in 2 months

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha 7e510a757aff39f8897a6188ed4e6b46b609b4e9

test building a bottle (#1)

view details

push time in 2 months

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha 906011ae3282439a4c6420449c8010f0a1a696a3

Update deno.rb

view details

push time in 2 months

push eventchrmoritz/homebrew-deno

Christian Moritz

commit sha 7115d3edd6a063ce5c0e8536b0c02130ae58bc55

Update deno.rb

view details

push time in 2 months

created tagchrmoritz/homebrew-deno

tag0.39.0

denon for Linuxbrew

created time in 2 months

more