profile
viewpoint
Christian Moritz chrmoritz Dresden, Germany

create barnchchrmoritz/homebrew-core

branch : deno-0.10.0

created branch time in a day

PR opened Homebrew/homebrew-core

deno 0.10.0

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in a day

pull request commentHomebrew/homebrew-core

chronograf 1.7.12

I can reproduce the test failure locally on the first run. However all subsequent test runs are passing. So there might be some missing bootstrap which fails the first run only?

chenrui333

comment created time in 3 days

pull request commentHomebrew/homebrew-core

chronograf 1.7.12

Alternatively we could upgrade a few build dependencies for node 12 support (or just delete the yarn.lock file altogether, because the semver ranges in their package.json are relaxed enough to match the node 12 compatible versions):

@@ -27,10 +27,10 @@ class Chronograf < Formula
     chronograf_path = buildpath/"src/github.com/influxdata/chronograf"
     chronograf_path.install buildpath.children
 
-    # fixes yarn + upath@1.0.4 incompatibility, remove once upath is upgraded to 1.0.5+
-    Pathname.new("#{ENV["HOME"]}/.yarnrc").write("ignore-engines true\n")
-
     cd chronograf_path do
+      cd "ui" do # fix node 12 compatibility
+        system "yarn", "upgrade", "parcel@1.11.0", "node-sass@4.12.0"
+      end
       system "make", "dep"
       system "make", ".jssrc"
       system "make", "chronograf"
chenrui333

comment created time in 4 days

pull request commentHomebrew/homebrew-core

chronograf 1.7.12

I think this requires a depends_on "node@10" => :build for now (however the actual critical build error is the one from deasync and not from the optional fsevents dependency).

Also I think we should finally remove the ignore-engines workaround added over a year ago here.

chenrui333

comment created time in 5 days

issue commentHomebrew/homebrew-core

Making newest version of gcc versioned formula alias to gcc formula causes ``brew install gcc@ver`` to fail

I don't think the the alias is the real issue here, because it only makes it possible to refer to the latest unversioned formula as gcc@9 instead of having to omit the version prefix for the latest version.

The real issue is that there is no way to migrate the gcc 8.3.0 (installed at a time were is was the latest unversioned version) to the new versioned gcc@8 (after it got added during the gcc 9 upgrade). But unfortunately there is no reliable way to tell if a user wants to upgrade to the new major version or stay within the current major version (which as of now requires to reinstall the newly created versioned formula).

Also brew install always fails if the formula is already installed, regardless it's major version. So you would have to handle the case that one versioned formula line of gcc is already installed anyway. It's likely that travis will upgrade to a preinstalled gcc 9.x in the near future and than you would have to special case this too by not doing a brew install gcc@9 there (and maybe having not the latest minor version) or you could keep using brew reinstall gcc@N to always have the latest minor version for a given major line.

gdevenyi

comment created time in 8 days

issue commentHomebrew/homebrew-core

Making newest version of gcc versioned formula alias to gcc formula causes ``brew install gcc@ver`` to fail

Yeah, I think brew reinstall gcc@N would work fine for that use case and you don't even need the brew install gcc@N || part, because reinstall doesn't complain about the formula not being installed.

gdevenyi

comment created time in 9 days

issue commentHomebrew/homebrew-core

Making newest version of gcc versioned formula alias to gcc formula causes ``brew install gcc@ver`` to fail

I think your issue is caused by the fact, that the gcc 8.3.0 on the travis image was not installed through gcc@8, but through the normal unversioned gcc formula (which the gcc@9 Alias currently points too) at a time where the unversioned gcc formula did still install version 8.3.0 (prior to the 9.1.0 upgrade in https://github.com/Homebrew/homebrew-core/commit/763ca1f3c6291f24c1f69ffaf2d156fee3bdef67).

If you call brew install gcc or (gcc@9 which is equivalent) than brew looks at the metadata of the current installed gcc and just sees that you try to install a newer version of the unversioned formula over a currently installed (and very outdated) old version and suggest the upgrade.

But brew reinstall gcc@9 should work fine for you use case, shouldn't it?

gdevenyi

comment created time in 9 days

create barnchchrmoritz/homebrew-core

branch : deno-0.9.0

created branch time in 11 days

PR opened Homebrew/homebrew-core

deno 0.9.0

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in 11 days

create barnchchrmoritz/homebrew-core

branch : deno-0.8.0

created branch time in 18 days

PR opened Homebrew/homebrew-core

deno 0.8.0

Created with brew bump-formula-pr.

+14 -18

0 comment

1 changed file

pr created time in 18 days

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha 0f53f0f98f6ff6d778a21bba4fcb75cea7b88f63

v8 7.5.288.22

view details

push time in 22 days

PR opened Homebrew/homebrew-core

v8 7.5.288.22

Created with brew bump-formula-pr.

+6 -7

0 comment

1 changed file

pr created time in 22 days

create barnchchrmoritz/homebrew-core

branch : v8-7.5.288.22

created branch time in 22 days

pull request commentdenoland/deno

build improvements for packagers of deno

Would you mind adding some documentation for DENO_GN_PATH and DENO_NINJA_PATH to the manual? I think this section is appropriate: https://github.com/denoland/deno/blob/master/website/manual.md#other-useful-commands

Sure. I though about adding some documentation there yesterday, but I think I've forgotten it because it was already late and I wanted to submit this PR.

chrmoritz

comment created time in a month

push eventchrmoritz/deno

Christian Moritz

commit sha b0be09bdd4dbf954f376f2b53def33a3b6ebae2f

tools/third_party: add DENO_GN_PATH and DENO_NINJA_PATH env vars

view details

Christian Moritz

commit sha c45ac2c1c4a814f691d7ae7d2e735a7f07568603

tools/setup: don't download sccache if --no-binary-download is passed

view details

push time in a month

PR opened Homebrew/homebrew-core

deno 0.7.0

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in a month

create barnchchrmoritz/homebrew-core

branch : deno-0.7.0

created branch time in a month

PR opened denoland/deno

build improvements for packagers of deno

This PR adds some improvements to the build tooling of deno which could be useful for packagers of deno. These ideas came up during the creating of the homebrew formula in https://github.com/Homebrew/homebrew-core/pull/35645. With is being merged the homebrew formula could make use of your build scripts (tools/setup.py and tools/build.py) and be even more simple as shown in this gist:

Refs: #1474

The first commit to ./tools/third_party.py simply adds the option to override the default gn_path and ninja_path by setting the newly added DENO_GN_PATH and DENO_NINJA_PATH environment variables.

The second commit fixes ./tools/setup.py's --no-binary-download option to also disable the download of the sccache binary. To make it work I had to refactor the ./tools/prebuilt.py a bit to separate the getting the platform specific path to the binary from actually downloading said binary.

+20 -13

0 comment

3 changed files

pr created time in a month

push eventchrmoritz/deno

Steven

commit sha ccdab617081b8f12e6c4a498ef4b387f8c5cc772

Remove prefix $ and > from manual (#2404)

view details

ztplz

commit sha 86684799c4b98a61c5845a7ef1d2e743b0e4851e

typo (#2366)

view details

Andy Hayden

commit sha 62c377fc19ac49138da5c3b3ee3b9d3854a44474

Add brew install deno to manual (#2407)

view details

Bartek Iwańczuk

commit sha 73ac5f89f022a3965c68705cef284386a9365419

add module and line no for Rust logger (#2409)

view details

Adam Conrad

commit sha 9fd4096235a308a0d405888ef808d6c665bef355

add EventTarget implementation (#2377)

view details

Bartek Iwańczuk

commit sha 824542e61e1dbef09ca9388deca0c595a3e3e1df

chore: Port Python tests to unittest (#2408)

view details

Ryan Dahl

commit sha 3c355c2b3296cb930c37de44634b479cd7230ed6

Add 'brew install deno' to homepage (#2412)

view details

Ryan Dahl

commit sha 53b6356ec5eac1c84610c2d2e75b527485c47f3c

Correct tokio_util::block_on() and op_fetch_module_meta_data op_fetch_module_meta_data is an op that is used by the TypeScript compiler. TypeScript requires this op to be sync. However the implementation of the op does things on the event loop (like fetching HTTP resources). In certain situations this can lead to deadlocks. The runtime's thread pool can be filled with ops waiting on the result of op_fetch_module_meta_data. The runtime has a maximum number of threads it can use (the number of logical CPUs on the system). This patch changes tokio_util::block_on to launch a new Tokio runtime for evaluating the future, thus bipassing the max-thread problem. This is only an issue in op_fetch_module_meta_data. Other synchronous ops are truly synchornous, not interacting with the event loop. TODO comments are added to direct future development.

view details

Ryan Dahl

commit sha 64d2b7bc90cf6fdba661d6d3fe243fe332c076ee

Change tools/fmt_test.py to always download prettier This is to ensure a more fair test. Also we were already downloading from the internet since we changed the URL to use std@v0.5.0. This change exposes an OOM bug, which is then fixed in the upcoming compiler refactor by changing checkJs compiler option to false.

view details

Ryan Dahl

commit sha 856c44213b7faf507d4b481cfc170b2fd08f971a

TS compiler refactor * Compiler no longer has its own Tokio runtime. Compiler handles one message and then exits. * Uses the simpler ts.CompilerHost interface instead of ts.LanguageServiceHost. * avoids recompiling the same module by introducing a hacky but simple `hashset<string>` that stores the module names that have been already compiled. * Removes the CompilerConfig op. * Removes a lot of the mocking stuff in compiler.ts like `this._ts`. It is not useful as we don't even have tests. * Turns off checkJs because it causes fmt_test to die with OOM.

view details

Christian Moritz

commit sha 4205d062f08b4c892bfbcdb185e48de38c7f124a

tools/third_party: add DENO_GN_PATH and DENO_NINJA_PATH env vars

view details

Christian Moritz

commit sha d7bb9bb85a232b454ece7cdc702134afd6c26f90

tools/setup: don't download sccache if --no-binary-download is passed

view details

push time in a month

create barnchchrmoritz/deno

branch : buildOptions

created branch time in a month

fork chrmoritz/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in a month

issue commentdenoland/deno

option to setup/build only use native

I think there is still room for improvements here.

Here is an even simpler homebrew formula which requires 2 small patches to denos build ./tools to make it work using your setup.py and build.py scripts by passing all required options in through environment variables.

  • The first patch to ./tools/third_party.py simply adds the option to override the default gn_path and ninja_path by setting the DENO_GN_PATH and DENO_NINJA_PATH environment variables. (Not sure if adding 2 new environment variables is the best solution here, but they have to persist to subprocess spawned by gn.)
  • The second patch to ./tools/setup.py fixes setup.py's --no-binary-download option to also disable the download of the sccache binary.

Would something like this be acceptable here?

hayd

comment created time in a month

Pull request review commentHomebrew/homebrew-core

deno v0.5.0 (new formula)

+class Deno < Formula+  desc "Command-line JavaScript / TypeScript engine"+  homepage "https://deno.land/"+  url "https://github.com/denoland/deno.git",+    :tag      => "v0.6.0",+    :revision => "22feb74ba12215597416b5531f8a557302283e79"++  depends_on "llvm" => :build+  depends_on "ninja" => :build+  depends_on "node" => :build+  depends_on "python@2" => :build # GN require Python 2.7++  depends_on "rust" => :build++  # https://bugs.chromium.org/p/chromium/issues/detail?id=620127+  depends_on :macos => :el_capitan++  resource "gn" do+    url "https://gn.googlesource.com/gn.git",+      :revision => "64b846c96daeb3eaf08e26d8a84d8451c6cb712b"+  end++  def install+    # Build gn from source and add it to the PATH+    (buildpath/"gn").install resource("gn")+    cd "gn" do+      system "python", "build/gen.py"+      system "ninja", "-C", "out/", "gn"+    end+    ENV.prepend_path "PATH", buildpath/"gn/out"++    # change the path of gn and ninja to the homebrew provided ones (we don't do binary downloads here)+    inreplace "tools/third_party.py" do |s|+      s.gsub! "gn_path = tp(depot_tools_path, \"gn\")", "gn_path = \"#{buildpath}/gn/out/gn\""+      s.gsub! "ninja_path = tp(depot_tools_path, \"ninja\")", "ninja_path = \"#{Formula["ninja"].bin}/ninja\""

@hayd Here is a working formula to showcase how the build could look like (using setup.py and build.py) if we get upstream support for setting gn_path and ninja_path through environment variables: https://gist.github.com/chrmoritz/3dfc9fa7acc720cf5e1289e51662f69c (also it simply disables the sccache download, however this should probably be conditional based on the --no-binary-downloads argument)

hayd

comment created time in a month

Pull request review commentHomebrew/homebrew-core

deno v0.5.0 (new formula)

+class Deno < Formula+  desc "Command-line JavaScript / TypeScript engine"+  homepage "https://deno.land/"+  url "https://github.com/denoland/deno.git",+    :tag      => "v0.6.0",+    :revision => "22feb74ba12215597416b5531f8a557302283e79"++  depends_on "llvm" => :build+  depends_on "ninja" => :build+  depends_on "node" => :build+  depends_on "python@2" => :build # GN require Python 2.7++  depends_on "rust" => :build++  # https://bugs.chromium.org/p/chromium/issues/detail?id=620127+  depends_on :macos => :el_capitan++  resource "gn" do+    url "https://gn.googlesource.com/gn.git",+      :revision => "64b846c96daeb3eaf08e26d8a84d8451c6cb712b"+  end++  def install+    # Build gn from source and add it to the PATH+    (buildpath/"gn").install resource("gn")+    cd "gn" do+      system "python", "build/gen.py"+      system "ninja", "-C", "out/", "gn"+    end+    ENV.prepend_path "PATH", buildpath/"gn/out"++    # change the path of gn and ninja to the homebrew provided ones (we don't do binary downloads here)+    inreplace "tools/third_party.py" do |s|+      s.gsub! "gn_path = tp(depot_tools_path, \"gn\")", "gn_path = \"#{buildpath}/gn/out/gn\""+      s.gsub! "ninja_path = tp(depot_tools_path, \"ninja\")", "ninja_path = \"#{Formula["ninja"].bin}/ninja\""

@ry We are already calling gn and ninja directly. The problem is, that gn is spawning a script at some point, which fails if the gn_path in third_party.py isn't valid.

[474/638] python ../../tools/write_gn_args.py gen/cli/gn_args.txt
FAILED: gen/cli/gn_args.txt 
python ../../tools/write_gn_args.py gen/cli/gn_args.txt
gn.py: Could not find gn executable at: /private/tmp/deno-20190523-89403-1umch2/buildtools/mac/gn
Traceback (most recent call last):
  File "../../tools/write_gn_args.py", line 14, in <module>
    env=third_party.google_env())
  File "/private/tmp/deno-20190523-89403-1umch2/tools/util.py", line 65, in run_output
    return subprocess.check_output(args, cwd=cwd, env=env, shell=shell)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 223, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['/private/tmp/deno-20190523-89403-1umch2/third_party/depot_tools/gn', 'args', '/private/tmp/deno-20190523-89403-1umch2/target/release', '--list', '--short', '--overrides-only']' returned non-zero exit status 2

This is with calling gn directly, but gnonly being in the users PATH and not located in ./buildtools/mac => ./third_party/v8/buildtools/mac.

hayd

comment created time in a month

Pull request review commentHomebrew/homebrew-core

deno v0.5.0 (new formula)

+class Deno < Formula+  desc "Command-line JavaScript / TypeScript engine"+  homepage "https://deno.land/"+  url "https://github.com/denoland/deno.git",+    :tag      => "v0.6.0",+    :revision => "22feb74ba12215597416b5531f8a557302283e79"++  depends_on "llvm" => :build+  depends_on "ninja" => :build+  depends_on "node" => :build+  depends_on "python@2" => :build # GN require Python 2.7++  depends_on "rust" => :build++  # https://bugs.chromium.org/p/chromium/issues/detail?id=620127+  depends_on :macos => :el_capitan++  resource "gn" do+    url "https://gn.googlesource.com/gn.git",+      :revision => "64b846c96daeb3eaf08e26d8a84d8451c6cb712b"+  end++  def install+    # Build gn from source and add it to the PATH+    (buildpath/"gn").install resource("gn")+    cd "gn" do+      system "python", "build/gen.py"+      system "ninja", "-C", "out/", "gn"+    end+    ENV.prepend_path "PATH", buildpath/"gn/out"++    # change the path of gn and ninja to the homebrew provided ones (we don't do binary downloads here)+    inreplace "tools/third_party.py" do |s|+      s.gsub! "gn_path = tp(depot_tools_path, \"gn\")", "gn_path = \"#{buildpath}/gn/out/gn\""+      s.gsub! "ninja_path = tp(depot_tools_path, \"ninja\")", "ninja_path = \"#{Formula["ninja"].bin}/ninja\""

@hayd Thanks. Just to clarify, these are the 2 things witch are blocking us from using setup.py and build.py directly:

  • make setup.py's --no-binary-downloads option skip the download of sccache too
  • make third_party.py's gn_path and ninja_path (used by a lot of build tooling) configurable. I'd prefer using another gn-argument here (because we have to set clang_base_pat anyway), but I guess a simple environment variable would be ok too.
hayd

comment created time in a month

pull request commentHomebrew/homebrew-core

deno v0.5.0 (new formula)

@zbeekman Done, could you please take another look?

I've just moved our from source compiled gn binary to the expected location (where depot_tools would put it's binary downloads) to avoid patching the gn_path of the build system (the patched ninja_path was already unnecessary since we call the ninja binary directly and it's not called in a subprocess).

hayd

comment created time in a month

push eventhayd/homebrew-core

Michihito Shigemura

commit sha 8b40989b1d1b900b25c6423299166f56ef8b96ed

ansible 2.8.0 Closes #39988. Signed-off-by: Izaak Beekman <zbeekman@gmail.com>

view details

BrewTestBot

commit sha 533358d4c9006038ebcb07da2dfad06e3e4fdfb1

ansible: update 2.8.0 bottle.

view details

Rui Chen

commit sha 988dcc85dac0e071fdc2ca01865a49567edcf0a7

webpack 4.32.0 Closes #40084. Signed-off-by: Izaak Beekman <zbeekman@gmail.com>

view details

BrewTestBot

commit sha 9babb16a7467bc9e2ac6bf6aee78b071985942dc

webpack: update 4.32.0 bottle.

view details

Steve Boswell

commit sha 4ade5fff54cf59495378fb5200ebb0b6bd342ead

atari800 4.1.0 Closes #40090. Signed-off-by: Izaak Beekman <zbeekman@gmail.com>

view details

BrewTestBot

commit sha f75245efbe43ba6898ccf6d5588eb0ff988fa3c7

atari800: update 4.1.0 bottle.

view details

Andrés Hernández

commit sha 84655f68e9965329ab226f15dd439800703d9dd7

atlantis 0.7.2 (new formula) Closes #39980. Signed-off-by: Izaak Beekman <zbeekman@gmail.com>

view details

BrewTestBot

commit sha 08ab93a878e85f4f780a2626197de1979dc9f6cb

atlantis: add 0.7.2 bottle.

view details

Rui Chen

commit sha 93e2c040b4da6b40fa18b8561269be57bd25aeab

kubeprod 1.3.2 Closes #40099. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha ca19dfe40bb02cfe3b88a4ee8565d345bf1b4ec9

kubeprod: update 1.3.2 bottle.

view details

Rui Chen

commit sha 830d4961730937135968a547b5150ef0b28d6509

serverless 1.43.0 Closes #40100. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 89b6b641b59226861767fa87bae03a709dcc4672

serverless: update 1.43.0 bottle.

view details

Rui Chen

commit sha e18809d5850685b7076de4bdc4ca868a1a23a866

opa 0.11.0 Closes #40101. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha ee0799c96389b8920379995626e0589d2bbb33c5

opa: update 0.11.0 bottle.

view details

Andrew Lavery

commit sha 87dadea2ef16d684ea5159b3c4b71fa66119321d

ship 0.44.0 Closes #40102. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 3f35ffe15a6bd10396734aa28d34b781a767b363

ship: update 0.44.0 bottle.

view details

Rui Chen

commit sha 2c836428ef7ebed9f1563e89d3f96ab71192fab7

riff 0.3.1 Closes #40104. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 142c3dfb468a4235d488d57b3b22106af1467d79

riff: update 0.3.1 bottle.

view details

404NetworkError

commit sha 66f353e88114cab1f2811d45a260a86d51eb8dac

youtube-dl 2019.05.20 Closes #40105. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

404NetworkError

commit sha 8d2a449b41ebde4f33b5b6fbe808b4fcdbdfc8c9

qpdf 8.4.2 Closes #40106. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

push time in a month

Pull request review commentHomebrew/homebrew-core

deno v0.5.0 (new formula)

+class Deno < Formula+  desc "Command-line JavaScript / TypeScript engine"+  homepage "https://deno.land/"+  url "https://github.com/denoland/deno.git",+    :tag      => "v0.6.0",+    :revision => "22feb74ba12215597416b5531f8a557302283e79"++  depends_on "llvm" => :build+  depends_on "ninja" => :build+  depends_on "node" => :build+  depends_on "python@2" => :build # GN require Python 2.7++  depends_on "rust" => :build++  # https://bugs.chromium.org/p/chromium/issues/detail?id=620127+  depends_on :macos => :el_capitan++  resource "gn" do+    url "https://gn.googlesource.com/gn.git",+      :revision => "64b846c96daeb3eaf08e26d8a84d8451c6cb712b"+  end++  def install+    # Build gn from source and add it to the PATH+    (buildpath/"gn").install resource("gn")+    cd "gn" do+      system "python", "build/gen.py"+      system "ninja", "-C", "out/", "gn"+    end+    ENV.prepend_path "PATH", buildpath/"gn/out"++    # change the path of gn and ninja to the homebrew provided ones (we don't do binary downloads here)+    inreplace "tools/third_party.py" do |s|+      s.gsub! "gn_path = tp(depot_tools_path, \"gn\")", "gn_path = \"#{buildpath}/gn/out/gn\""+      s.gsub! "ninja_path = tp(depot_tools_path, \"ninja\")", "ninja_path = \"#{Formula["ninja"].bin}/ninja\""

@zbeekman

Has this been reported/patched upstream? I.e., a way to avoid binary downloads?

Upstream (similar to v8 itself) only supports building with the binary devtools (ninja, gn, clang) downloaded from Googles depot_tools. This inreplace is not about preventing this binary download (we don't use the tooling which would cause the binary download here anymore, but instead call ninja and gn directly). It's about telling some part of the build (invoked by gn) where the these tool are located, because some of them would just fail if they can't find gn at the well known binary depot_tools download path (even if a working version of gn is in the PATH, but the just don't even look for it there).

In my mind, this is the only remaining blocker. Since this is patching the build, a patch do block is preferable to inreplace here. It should use the url and sha256 form of patch do and have a comment explaining why the patch is needed, when it should be removed, and linking to upstream issue reports and/or PRs. Ideally the patch should be at homebrew/formula-patches (you can submit a PR) but if it's the .patch url of an upstream PR that's acceptable too.

Of cause we could create a patch for this. Alternatively working with even more symlinks for the deno build could work too.

Once this is done, squashing and rebasing ontop of the latest homebrew-core:master would also be greatly appreciated. Thanks!

Sure

@hayd

does --no-binary-downloads do the equivalent here? (Can we replace the inreplace with that?) The inreplace is needed during the build so that scrips called by gn can find the correct path to gn and don't just look in the binary depot_tools location and fail because they can't find gnthere. Maybe even more symlinks would fix this? Also --no-binary-downloads is incomplete, because it would still download sccache. Also it doesn't change anything about the assumption, where gn and ninja should be located (inside subdirectories of depot_tools).

hayd

comment created time in a month

pull request commentHomebrew/homebrew-core

grafana 6.2.0

Looks like grafana's build dependencies aren't quite compatible with node 12 yet (it wasn't tested during the node 12 PR because it's a build-only dependency).

Fortunately it can be easily fixed by bumping node-sass to 4.12.0.

--- a/Formula/grafana.rb
+++ b/Formula/grafana.rb
@@ -17,6 +17,9 @@ class Grafana < Formula
   depends_on "yarn" => :build
 
   def install
+    # fix node 12 compatibility
+    inreplace "package.json", "\"node-sass\": \"4.11.0\",", "\"node-sass\": \"4.12.0\","
+
     ENV["GOPATH"] = buildpath
     grafana_path = buildpath/"src/github.com/grafana/grafana"
     grafana_path.install buildpath.children

chenrui333

comment created time in a month

Pull request review commentHomebrew/homebrew-core

babel 7.4.5

 class Babel < Formula   desc "Compiler for writing next generation JavaScript"   homepage "https://babeljs.io/"-  url "https://registry.npmjs.org/@babel/cli/-/cli-7.4.4.tgz"-  sha256 "aa6b4c8d5564e44f68e0ac1198e8a13ae641fcd9af3119e38538e34a691f1dbb"+  url "https://github.com/babel/babel/archive/v7.4.5.tar.gz"+  sha256 "0e046a7b2ba5207b741bfb8de34dd4a15d6d4efa4deee0f8a1a7e4a0a4a8f045"

But you should still use the @babel/core npm package here instead of the github monorepo, which contains all the babel related packages in one repository plus some tooling.

chenrui333

comment created time in a month

pull request commentHomebrew/homebrew-core

babel 7.4.5

Looks like babel doesn't do a new cli release for every core release anymore. Maybe it's time to switch the main url with the babel-core resource (to make it similar to what we already do for webpack) and adjust the formula logic accordingly.

diff --git a/Formula/babel.rb b/Formula/babel.rb
index 5d21196272..bb36956e6d 100644
--- a/Formula/babel.rb
+++ b/Formula/babel.rb
@@ -4,8 +4,8 @@ require "json"
 class Babel < Formula
   desc "Compiler for writing next generation JavaScript"
   homepage "https://babeljs.io/"
-  url "https://registry.npmjs.org/@babel/cli/-/cli-7.4.4.tgz"
-  sha256 "aa6b4c8d5564e44f68e0ac1198e8a13ae641fcd9af3119e38538e34a691f1dbb"
+  url "https://registry.npmjs.org/@babel/core/-/core-7.4.5.tgz"
+  sha256 "23950a9e697f5efee8dae8e6d7855f0dd22885c40a5243df1c0fd5b0b522f0e6"
 
   bottle do
     sha256 "700aa5420c7d1b736a331ce97bd97b96b3c4966e486cf14a75d07a2526b9cfd9" => :mojave
@@ -15,17 +15,18 @@ class Babel < Formula
 
   depends_on "node"
 
-  resource "babel-core" do
-    url "https://registry.npmjs.org/@babel/core/-/core-7.4.4.tgz"
-    sha256 "e6fb0fdbf80d37114f28c2bb8903b2d14e5d7c88ea19ba23e38a3d55e2dd13ee"
+  resource "babel-cli" do
+    url "https://registry.npmjs.org/@babel/cli/-/cli-7.4.4.tgz"
+    sha256 "aa6b4c8d5564e44f68e0ac1198e8a13ae641fcd9af3119e38538e34a691f1dbb"
   end
 
   def install
-    (buildpath/"node_modules/@babel/core").install resource("babel-core")
+    (buildpath/"node_modules/@babel/core").install Dir["*"]
+    buildpath.install resource("babel-cli")
 
     # declare babel-core as a bundledDependency of babel-cli
     pkg_json = JSON.parse(IO.read("package.json"))
-    pkg_json["dependencies"]["@babel/core"] = resource("babel-core").version
+    pkg_json["dependencies"]["@babel/core"] = version
     pkg_json["bundledDependencies"] = ["@babel/core"]
     IO.write("package.json", JSON.pretty_generate(pkg_json))
 
@@ -40,9 +41,5 @@ class Babel < Formula
 
     system bin/"babel", "script.js", "--out-file", "script-compiled.js"
     assert_predicate testpath/"script-compiled.js", :exist?, "script-compiled.js was not generated"
-
-    # Uncomment this for the next release,
-    # see https://github.com/Homebrew/homebrew-core/pull/35304#issuecomment-449335627.
-    # assert_equal version, resource("babel-core").version
   end
 end
chenrui333

comment created time in a month

issue commentHomebrew/homebrew-core

bin.install failing silently

You are still pouring the official bottle here, which doesn't include the mkpasswd binary. If you want to test your modification you have to explicitly pass --build-from-source (or short -s). Like brew install -vds brew install https://raw.githubusercontent.com/mcandre/homebrew-core/2b26f2d82c0a8fe898f13e39ff0c51955573e40b/Formula/whois.rb (to get a from source verbose debug build).

mcandre

comment created time in a month

push eventhayd/homebrew-core

Christian Moritz

commit sha d2aa61f6c429403bc762ab4c2ecf6be797576862

deno 0.6.0

view details

push time in a month

pull request commentHomebrew/homebrew-core

elasticsearch 6.8.0

This looks like a current issue with the CI and unrelated to all the PR failing because of it atm. Also notable is that brew doctor reports some uncommitted modifications to brew.

BTW: I've started to look into getting the elastic formulae upgraded to version 7 in https://github.com/Homebrew/homebrew-core/compare/master...chrmoritz:elastic7, but I couldn't get elasticsearch 7 to work yet.

chenrui333

comment created time in a month

push eventhayd/homebrew-core

Rui Chen

commit sha b1caa50434a39913e85a919fe11c01fe08a80396

velero 0.11.1 Closes #39996. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha aa5fe7e2e812daf650114d1aeb8f218a2e06b40f

velero: update 0.11.1 bottle.

view details

Caleb Xu

commit sha f8015f16e5842cca9cafde77479e7c9a23b8bed8

etl 1.2.2

view details

Caleb Xu

commit sha 00fba5c082a961a371458e2c49d0df2605004b05

synfig 1.2.2 Closes #39989. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha a9676593649bbd2fc5b680abe07a6ba739d9dac6

etl: update 1.2.2 bottle.

view details

BrewTestBot

commit sha 1d4ea810a9784cf8afa7cecdf7fd31a23eae9458

synfig: update 1.2.2 bottle.

view details

Caleb Xu

commit sha 79c43e1b913720572663bd6dd8f0b7479e83a5e2

tcsh 6.21.00 Closes #39976. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 613c67e26fb3e22a51b8d4a04079007edbe84dcf

tcsh: update 6.21.00 bottle.

view details

Caleb Xu

commit sha c0b2f048cb0ae03b328433d1e6a496c4663862c3

tbb 2019_U6 Closes #39977. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha cb4aafef3dec6251852aa120f6491e782e73f515

tbb: update 2019_U6 bottle.

view details

Caleb Xu

commit sha c2655f3b190e0361e5c598f76a65ea4fffb37b51

sysbench 1.0.17 Closes #39978. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 60e2aa2facc0adfc200370e3bb5ddb1624ebc3da

sysbench: update 1.0.17 bottle.

view details

Caleb Xu

commit sha 07ab7399218c7342f7aa4bb8e529728d2052980b

rancid 3.9 Closes #39979. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 27238e83510d8c31874cd2c24fc273ac4eccbb85

rancid: update 3.9 bottle.

view details

Caleb Xu

commit sha d0614e56b35c217fa8dd241337551e6d411b46ef

tass64 1.54.1900 Closes #39974. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 5b51784d8f33af26c540e4aa2bf4aa69d41225b4

tass64: update 1.54.1900 bottle.

view details

Caleb Xu

commit sha 2b9ac8321e78844dae8f6e50af5b14cdf4e82992

spin 6.4.9 Closes #39973. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha a4cf8b533863311efe45fd19767cb316b7434196

spin: update 6.4.9 bottle.

view details

Caleb Xu

commit sha eb75f04dd0a18cbc34eb4e50a13916fb605e20dd

qd 2.3.22 Closes #39972. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 70ce8b6b9ee3f88d894bf2c48b70f4286930f232

qd: update 2.3.22 bottle.

view details

push time in a month

push eventhayd/homebrew-core

Christian Moritz

commit sha dc7d3bd061394584c504ac4f80c908c9d339e7cd

deno 0.5.0

view details

push time in a month

Pull request review commentHomebrew/homebrew-core

deno v0.5.0 (new formula)

 class Deno < Formula-  desc "command-line JavaScript / TypeScript engine"+  desc "Command-line JavaScript / TypeScript engine"   homepage "https://deno.land/"-  url "https://chromium.googlesource.com/chromium/tools/depot_tools.git",-      :revision => "aec259ea62328ce39916607876956239fbce29b8"-  version "0.3.3" # the version of the deno checkout, not a depot_tools version--  # depot_tools/GN require Python 2.7+-  # depends_on "python@2" => :build+  url "https://github.com/denoland/deno.git",+    :tag      => "v0.5.0",+    :revision => "23aca36d52220efbfbc07abbe165bd2c9ade2009" +  depends_on "llvm" => :build+  depends_on "ninja" => :build   depends_on "node" => :build+  depends_on "python@2" => :build # GN require Python 2.7+   depends_on "rust" => :build    # https://bugs.chromium.org/p/chromium/issues/detail?id=620127   depends_on :macos => :el_capitan +  resource "gn" do+    url "https://gn.googlesource.com/gn.git",+      :revision => "64b846c96daeb3eaf08e26d8a84d8451c6cb712b"+  end+   def install-    # Add depot_tools in PATH-    ENV.prepend_path "PATH", buildpath-    # Prevent from updating depot_tools on every call-    # see https://www.chromium.org/developers/how-tos/depottools#TOC-Disabling-auto-update-    ENV["DEPOT_TOOLS_UPDATE"] = "0"-    ENV["CHROMIUM_BUILDTOOLS_PATH"] = buildpath + "/deno/buildtools/"+    # Build gn from source and add it to the PATH+    (buildpath/"gn").install resource("gn")+    cd "gn" do+      system "python", "build/gen.py"+      system "ninja", "-C", "out/", "gn"+    end+    ENV.prepend_path "PATH", buildpath/"gn/out" -    # Initialize and sync gclient-    system "gclient", "root"-    system "gclient", "config", "--spec", <<~EOS-      solutions = [-        {-          "url": "https://github.com/denoland/deno.git",-          "managed": False,-          "name": "deno",-          "custom_deps": {},-        },-      ]-      target_os = [ "mac" ]-      target_os_only = True-      cache_dir = "#{HOMEBREW_CACHE}/gclient_cache"-    EOS+    ENV["DENO_BUILD_MODE"] = "release"+    inreplace "tools/third_party.py" do |s|+      s.gsub! "gn_path = tp(depot_tools_path, \"gn\")", "gn_path = \"#{buildpath}/gn/out/gn\""+      s.gsub! "ninja_path = tp(depot_tools_path, \"ninja\")", "ninja_path = \"#{Formula["ninja"].bin}/ninja\""+    end+    # restore node_modules symlink, which go converted to a copy of the folder by brew (is this a bug?)+    rm_rf "node_modules"+    ln_sf "third_party/node_modules", "node_modules"

This would only work for users who are on brew master (HOMEBREW_DEVELOPER set or did run a dev command). Everyone else on the latest stable brew tag doesn't have this fix yet, so we have to wait until the next brew version is cut to finally remove this workaround.

hayd

comment created time in a month

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha 49b45adcb0c939ac54c37b17ed67ba48e167cfea

[WIP] elasticsearch 7.0.1

view details

Christian Moritz

commit sha 04b5719921f8bc3144e845ad3c7a3abc8e1a7273

auditbeat 7.0.1

view details

Christian Moritz

commit sha 05d914edfcf2166e64712fbd06c98064512bb382

metricbeat 7.0.1

view details

Christian Moritz

commit sha 28be744d0edb984508b447c6e202add59345fe4b

filebeat 7.0.1

view details

Christian Moritz

commit sha d8466775b20db3bd9086e10f0c5b74fe7046b2d5

What should we do with the now broken heart/packetbeat?

view details

push time in a month

create barnchchrmoritz/homebrew-core

branch : elastic7

created branch time in a month

push eventhayd/homebrew-core

Christian Moritz

commit sha fc1648d913f1fcff9a13d42059f32d00448f1c26

deno 0.5.0

view details

push time in a month

push eventhayd/homebrew-core

Christian Moritz

commit sha 650bf8decbf7fe44abcc3092ccc6ec4cb27e28db

deno 0.5.0

view details

push time in a month

push eventhayd/homebrew-core

Christian Moritz

commit sha 22e64d4d3fbfb115af69e64a40769a29e998b97d

deno 0.5.0

view details

push time in a month

pull request commentHomebrew/homebrew-core

deno v0.5.0 (new formula)

This should be ready now. (CI still pending)

@fxcoudert Could you please take another look?

hayd

comment created time in a month

push eventhayd/homebrew-core

Christian Moritz

commit sha 6b9532579e17afb95b44a0bf70fdd4eb9296d053

deno 0.5.0

view details

push time in a month

delete branch chrmoritz/brew

delete branch : unpackDir

delete time in a month

Pull request review commentHomebrew/homebrew-core

deno v0.5.0 (new formula)

 class Deno < Formula-  desc "command-line JavaScript / TypeScript engine"+  desc "Command-line JavaScript / TypeScript engine"   homepage "https://deno.land/"-  url "https://chromium.googlesource.com/chromium/tools/depot_tools.git",-      :revision => "aec259ea62328ce39916607876956239fbce29b8"-  version "0.3.3" # the version of the deno checkout, not a depot_tools version--  # depot_tools/GN require Python 2.7+-  # depends_on "python@2" => :build+  url "https://github.com/denoland/deno.git",+    :tag      => "v0.5.0",+    :revision => "23aca36d52220efbfbc07abbe165bd2c9ade2009" +  depends_on "llvm" => :build+  depends_on "ninja" => :build   depends_on "node" => :build+  depends_on "python@2" => :build # GN require Python 2.7+   depends_on "rust" => :build    # https://bugs.chromium.org/p/chromium/issues/detail?id=620127   depends_on :macos => :el_capitan +  resource "gn" do+    url "https://gn.googlesource.com/gn.git",+      :revision => "64b846c96daeb3eaf08e26d8a84d8451c6cb712b"+  end+   def install-    # Add depot_tools in PATH-    ENV.prepend_path "PATH", buildpath-    # Prevent from updating depot_tools on every call-    # see https://www.chromium.org/developers/how-tos/depottools#TOC-Disabling-auto-update-    ENV["DEPOT_TOOLS_UPDATE"] = "0"-    ENV["CHROMIUM_BUILDTOOLS_PATH"] = buildpath + "/deno/buildtools/"+    # Build gn from source and add it to the PATH+    (buildpath/"gn").install resource("gn")+    cd "gn" do+      system "python", "build/gen.py"+      system "ninja", "-C", "out/", "gn"+    end+    ENV.prepend_path "PATH", buildpath/"gn/out" -    # Initialize and sync gclient-    system "gclient", "root"-    system "gclient", "config", "--spec", <<~EOS-      solutions = [-        {-          "url": "https://github.com/denoland/deno.git",-          "managed": False,-          "name": "deno",-          "custom_deps": {},-        },-      ]-      target_os = [ "mac" ]-      target_os_only = True-      cache_dir = "#{HOMEBREW_CACHE}/gclient_cache"-    EOS+    ENV["DENO_BUILD_MODE"] = "release"+    inreplace "tools/third_party.py" do |s|+      s.gsub! "gn_path = tp(depot_tools_path, \"gn\")", "gn_path = \"#{buildpath}/gn/out/gn\""+      s.gsub! "ninja_path = tp(depot_tools_path, \"ninja\")", "ninja_path = \"#{Formula["ninja"].bin}/ninja\""+    end+    # restore node_modules symlink, which go converted to a copy of the folder by brew (is this a bug?)+    rm_rf "node_modules"+    ln_sf "third_party/node_modules", "node_modules"

I think it is, but It's still pending because of the giant gettext job and the other PR queued.

hayd

comment created time in a month

Pull request review commentHomebrew/homebrew-core

deno v0.5.0 (new formula)

 class Deno < Formula-  desc "command-line JavaScript / TypeScript engine"+  desc "Command-line JavaScript / TypeScript engine"   homepage "https://deno.land/"-  url "https://chromium.googlesource.com/chromium/tools/depot_tools.git",-      :revision => "aec259ea62328ce39916607876956239fbce29b8"-  version "0.3.3" # the version of the deno checkout, not a depot_tools version--  # depot_tools/GN require Python 2.7+-  # depends_on "python@2" => :build+  url "https://github.com/denoland/deno.git",+    :tag      => "v0.5.0",+    :revision => "23aca36d52220efbfbc07abbe165bd2c9ade2009" +  depends_on "llvm" => :build+  depends_on "ninja" => :build   depends_on "node" => :build+  depends_on "python@2" => :build # GN require Python 2.7+   depends_on "rust" => :build    # https://bugs.chromium.org/p/chromium/issues/detail?id=620127   depends_on :macos => :el_capitan +  resource "gn" do+    url "https://gn.googlesource.com/gn.git",+      :revision => "64b846c96daeb3eaf08e26d8a84d8451c6cb712b"+  end+   def install-    # Add depot_tools in PATH-    ENV.prepend_path "PATH", buildpath-    # Prevent from updating depot_tools on every call-    # see https://www.chromium.org/developers/how-tos/depottools#TOC-Disabling-auto-update-    ENV["DEPOT_TOOLS_UPDATE"] = "0"-    ENV["CHROMIUM_BUILDTOOLS_PATH"] = buildpath + "/deno/buildtools/"+    # Build gn from source and add it to the PATH+    (buildpath/"gn").install resource("gn")+    cd "gn" do+      system "python", "build/gen.py"+      system "ninja", "-C", "out/", "gn"+    end+    ENV.prepend_path "PATH", buildpath/"gn/out" -    # Initialize and sync gclient-    system "gclient", "root"-    system "gclient", "config", "--spec", <<~EOS-      solutions = [-        {-          "url": "https://github.com/denoland/deno.git",-          "managed": False,-          "name": "deno",-          "custom_deps": {},-        },-      ]-      target_os = [ "mac" ]-      target_os_only = True-      cache_dir = "#{HOMEBREW_CACHE}/gclient_cache"-    EOS+    ENV["DENO_BUILD_MODE"] = "release"+    inreplace "tools/third_party.py" do |s|+      s.gsub! "gn_path = tp(depot_tools_path, \"gn\")", "gn_path = \"#{buildpath}/gn/out/gn\""+      s.gsub! "ninja_path = tp(depot_tools_path, \"ninja\")", "ninja_path = \"#{Formula["ninja"].bin}/ninja\""+    end+    # restore node_modules symlink, which go converted to a copy of the folder by brew (is this a bug?)+    rm_rf "node_modules"+    ln_sf "third_party/node_modules", "node_modules"

I've opened https://github.com/Homebrew/brew/pull/6141/files.

hayd

comment created time in a month

PR opened Homebrew/brew

fix copying top level symlinks to folders in directory unpack_strategy
  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [x] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

This PR fixes a issue in the directory unpack_strategy, which currently does not preserve top level symlinks pointing to directories. Instead of copying the symlink (as a singe file) we are currently recursively copying the content of the folder to which the symlink points to. At the end the unpacked source does not contain the top level symlink (pointing to a folder within the source) anymore, because brew has converted it to a complete copy of said folder.

This breaks deno (see: https://github.com/Homebrew/homebrew-core/pull/35645#discussion_r284924995) and the added test case.

The current code is broken because child.directory? is true for symlinks pointing to folder too, but we should preserve them. That's why an additional check if the child is not a symlink was added to determine if we should recursively copy the contents of the child (in case it's a non symlink folder) or just the file itself.

+9 -1

0 comment

2 changed files

pr created time in a month

push eventchrmoritz/brew

Christian Moritz

commit sha 3bb0f8c6653efe830bbb7a73092921f96634a891

fix copying top level symlinks to folders in directory unpack_strategy

view details

push time in a month

Pull request review commentHomebrew/homebrew-core

deno v0.5.0 (new formula)

 class Deno < Formula-  desc "command-line JavaScript / TypeScript engine"+  desc "Command-line JavaScript / TypeScript engine"   homepage "https://deno.land/"-  url "https://chromium.googlesource.com/chromium/tools/depot_tools.git",-      :revision => "aec259ea62328ce39916607876956239fbce29b8"-  version "0.3.3" # the version of the deno checkout, not a depot_tools version--  # depot_tools/GN require Python 2.7+-  # depends_on "python@2" => :build+  url "https://github.com/denoland/deno.git",+    :tag      => "v0.5.0",+    :revision => "23aca36d52220efbfbc07abbe165bd2c9ade2009" +  depends_on "llvm" => :build+  depends_on "ninja" => :build   depends_on "node" => :build+  depends_on "python@2" => :build # GN require Python 2.7+   depends_on "rust" => :build    # https://bugs.chromium.org/p/chromium/issues/detail?id=620127   depends_on :macos => :el_capitan +  resource "gn" do+    url "https://gn.googlesource.com/gn.git",+      :revision => "64b846c96daeb3eaf08e26d8a84d8451c6cb712b"+  end+   def install-    # Add depot_tools in PATH-    ENV.prepend_path "PATH", buildpath-    # Prevent from updating depot_tools on every call-    # see https://www.chromium.org/developers/how-tos/depottools#TOC-Disabling-auto-update-    ENV["DEPOT_TOOLS_UPDATE"] = "0"-    ENV["CHROMIUM_BUILDTOOLS_PATH"] = buildpath + "/deno/buildtools/"+    # Build gn from source and add it to the PATH+    (buildpath/"gn").install resource("gn")+    cd "gn" do+      system "python", "build/gen.py"+      system "ninja", "-C", "out/", "gn"+    end+    ENV.prepend_path "PATH", buildpath/"gn/out" -    # Initialize and sync gclient-    system "gclient", "root"-    system "gclient", "config", "--spec", <<~EOS-      solutions = [-        {-          "url": "https://github.com/denoland/deno.git",-          "managed": False,-          "name": "deno",-          "custom_deps": {},-        },-      ]-      target_os = [ "mac" ]-      target_os_only = True-      cache_dir = "#{HOMEBREW_CACHE}/gclient_cache"-    EOS+    ENV["DENO_BUILD_MODE"] = "release"+    inreplace "tools/third_party.py" do |s|+      s.gsub! "gn_path = tp(depot_tools_path, \"gn\")", "gn_path = \"#{buildpath}/gn/out/gn\""+      s.gsub! "ninja_path = tp(depot_tools_path, \"ninja\")", "ninja_path = \"#{Formula["ninja"].bin}/ninja\""+    end+    # restore node_modules symlink, which go converted to a copy of the folder by brew (is this a bug?)+    rm_rf "node_modules"+    ln_sf "third_party/node_modules", "node_modules"

Yeah, this looks like a brew bug. Possible fix in https://github.com/chrmoritz/brew/commit/16a11b15bac53d0fea6b612c817c772443ab51c9. Thanks @hayd for discovering it.

hayd

comment created time in a month

create barnchchrmoritz/brew

branch : unpackDir

created branch time in a month

push eventhayd/homebrew-core

Christian Moritz

commit sha 42db50a166bea278fe68f91b8c1463bbdebcdca1

deno 0.5.0 (no binaries used during build)

view details

push time in a month

Pull request review commentHomebrew/homebrew-core

deno v0.5.0 (new formula)

+class Deno < Formula+  desc "command-line JavaScript / TypeScript engine"+  homepage "https://deno.land/"+  url "https://chromium.googlesource.com/chromium/tools/depot_tools.git",+      :revision => "aec259ea62328ce39916607876956239fbce29b8"+  version "0.3.3" # the version of the deno checkout, not a depot_tools version++  # depot_tools/GN require Python 2.7++  # depends_on "python@2" => :build++  depends_on "node" => :build+  depends_on "rust" => :build++  # https://bugs.chromium.org/p/chromium/issues/detail?id=620127+  depends_on :macos => :el_capitan++  def install+    # Add depot_tools in PATH+    ENV.prepend_path "PATH", buildpath

Oh, your right. brew seems to replace all symlinks with actual copies of the folders and I can reproduce this locally. I wonder if this is intended or a bug in brew.

hayd

comment created time in a month

Pull request review commentHomebrew/homebrew-core

deno v0.5.0 (new formula)

+class Deno < Formula+  desc "command-line JavaScript / TypeScript engine"+  homepage "https://deno.land/"+  url "https://chromium.googlesource.com/chromium/tools/depot_tools.git",+      :revision => "aec259ea62328ce39916607876956239fbce29b8"+  version "0.3.3" # the version of the deno checkout, not a depot_tools version++  # depot_tools/GN require Python 2.7++  # depends_on "python@2" => :build++  depends_on "node" => :build+  depends_on "rust" => :build++  # https://bugs.chromium.org/p/chromium/issues/detail?id=620127+  depends_on :macos => :el_capitan++  def install+    # Add depot_tools in PATH+    ENV.prepend_path "PATH", buildpath

The symlink is actual required for the TypeScript transpilation to work (I've already tried to remove it). If we remove the symlink we need to patch this line to rebase_path("//third_party/node_modules/ts-node/dist/bin.js", root_build_dir),

hayd

comment created time in a month

push eventhayd/homebrew-core

Christian Moritz

commit sha 3d9aae9bfd2073b628e94fcb0baa2380449caf52

deno 0.5.0 (no binaries used during build)

view details

push time in a month

Pull request review commentHomebrew/homebrew-core

deno v0.5.0 (new formula)

+class Deno < Formula+  desc "command-line JavaScript / TypeScript engine"+  homepage "https://deno.land/"+  url "https://chromium.googlesource.com/chromium/tools/depot_tools.git",+      :revision => "aec259ea62328ce39916607876956239fbce29b8"+  version "0.3.3" # the version of the deno checkout, not a depot_tools version++  # depot_tools/GN require Python 2.7++  # depends_on "python@2" => :build++  depends_on "node" => :build+  depends_on "rust" => :build++  # https://bugs.chromium.org/p/chromium/issues/detail?id=620127+  depends_on :macos => :el_capitan++  def install+    # Add depot_tools in PATH+    ENV.prepend_path "PATH", buildpath

I've fixed it with patching the rollup config with

inreplace "rollup.config.js", "third_party/node_modules/typescript/lib/typescript.js", "node_modules/typescript/lib/typescript.js"

But to be honest I don't know why rollup is using the node_modules symlink in the root directory for a homebrew build, but the actual node_modules inside third_party outside homebrew. I've just looked at the symptoms of the failed build and adjusted the rollup.config.js according to it.

hayd

comment created time in a month

Pull request review commentHomebrew/homebrew-core

deno v0.5.0 (new formula)

+class Deno < Formula+  desc "command-line JavaScript / TypeScript engine"+  homepage "https://deno.land/"+  url "https://chromium.googlesource.com/chromium/tools/depot_tools.git",+      :revision => "aec259ea62328ce39916607876956239fbce29b8"+  version "0.3.3" # the version of the deno checkout, not a depot_tools version++  # depot_tools/GN require Python 2.7++  # depends_on "python@2" => :build++  depends_on "node" => :build+  depends_on "rust" => :build++  # https://bugs.chromium.org/p/chromium/issues/detail?id=620127+  depends_on :macos => :el_capitan++  def install+    # Add depot_tools in PATH+    ENV.prepend_path "PATH", buildpath

There is definitely something wrong with the generated compiler.js. Here is the diff between a compiler.js from a working build outside homebrew to a broken one within homebrew: https://gist.github.com/chrmoritz/49ef50d3e1b54ca4a64375eafa6ff1e3

hayd

comment created time in a month

Pull request review commentHomebrew/homebrew-core

deno v0.5.0 (new formula)

+class Deno < Formula+  desc "command-line JavaScript / TypeScript engine"+  homepage "https://deno.land/"+  url "https://chromium.googlesource.com/chromium/tools/depot_tools.git",+      :revision => "aec259ea62328ce39916607876956239fbce29b8"+  version "0.3.3" # the version of the deno checkout, not a depot_tools version++  # depot_tools/GN require Python 2.7++  # depends_on "python@2" => :build++  depends_on "node" => :build+  depends_on "rust" => :build++  # https://bugs.chromium.org/p/chromium/issues/detail?id=620127+  depends_on :macos => :el_capitan++  def install+    # Add depot_tools in PATH+    ENV.prepend_path "PATH", buildpath

You probably mean that symlinking which is done in run_node.py. I think gn is calling this script just fine and the rollup script which is called with it seems to run just fine. It's the snapshot creation which fails for the compiler.js, but just works fine for the main.js.

hayd

comment created time in a month

Pull request review commentHomebrew/homebrew-core

deno v0.3.0 (new formula)

+class Deno < Formula+  desc "command-line JavaScript / TypeScript engine"+  homepage "https://deno.land/"+  url "https://chromium.googlesource.com/chromium/tools/depot_tools.git",+      :revision => "aec259ea62328ce39916607876956239fbce29b8"+  version "0.3.3" # the version of the deno checkout, not a depot_tools version++  # depot_tools/GN require Python 2.7++  # depends_on "python@2" => :build++  depends_on "node" => :build+  depends_on "rust" => :build++  # https://bugs.chromium.org/p/chromium/issues/detail?id=620127+  depends_on :macos => :el_capitan++  def install+    # Add depot_tools in PATH+    ENV.prepend_path "PATH", buildpath

@hayd Thanks, I've pushed my latest version based on deno 0.5.0 to this PR and rebased it on master (so that we can test with latest rust...).

hayd

comment created time in a month

push eventhayd/homebrew-core

BrewTestBot

commit sha a3b27bd0a7f03629bd7e9086674e7b04d3339e86

skaffold: update 0.28.0 bottle.

view details

Tom Schoonjans

commit sha e85f8e62ec5c7547322d34feddc207ab4b8b3741

evince: fix build against GLib 2.60.x Closes #39183 Closes #39359. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 5eb69e03a268d0f9f4cfbe4f17485ba0246c31ff

evince: update 3.30.2_1 bottle.

view details

Chongyu Zhu

commit sha 0058ce3266c68216cbd6f3a381ea5288a14fc5a8

flatbuffers 1.11.0 Closes #39355. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha df9f78ed4219dc5f3f4432220b4c5b727d3982e3

flatbuffers: update 1.11.0 bottle.

view details

Chongyu Zhu

commit sha f4c9337269b2752abf82e0b689f6ea9e2bd44f67

ipython 7.5.0 Closes #39356. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 95b9d65601e56f42bf092b663aa44fc1aa69dc2c

ipython: update 7.5.0 bottle.

view details

Igor Kapkov

commit sha b5a27220adeb20cb1fef0ad890312c87fb7ba89e

lmod 8.0.8 Closes #39367. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 4536e409501e0ba99274261dfd0275745fc08e89

lmod: update 8.0.8 bottle.

view details

Ivan Kozlovic

commit sha 46d8316efea03d6cbd9b95384ee0249933a71e5c

nats-streaming-server 0.14.1 Closes #39361. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 35ba8d52b9037dc4df90e32f78f2d0b5f5ae0de1

nats-streaming-server: update 0.14.1 bottle.

view details

Janek Bevendorff

commit sha e47d1797f5761949c8f65f97bab29e316ae20d9b

quazip 0.7.6 Closes #39362. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha c5a005ff37527556c15a0bfb4fe9941f92a16aa7

quazip: update 0.7.6 bottle.

view details

dana

commit sha 30f2f5d07f86b0db302262a46a1278d46d446fa8

cmocka 1.1.5 Closes #39363. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 20770251638a4f436ea81406baf9c3c3cd7cddbe

cmocka: update 1.1.5 bottle.

view details

Toshiki Murayama

commit sha a7dfdefdecfea2c8cf1a90039e9c2c8b8c697ad6

volt 0.3.6 Closes #39365. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 8649ac703cc103aab456b0c3036fbd1ff840c734

volt: update 0.3.6 bottle.

view details

Igor Kapkov

commit sha 573ffce8c1f6f7cb8d94a12c10f4f61dcfd73435

traefik 1.7.11 Closes #39368. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 5d110a378cb689ca4cf2ed7c234b77593768aa36

traefik: update 1.7.11 bottle.

view details

Andrea Bolognani

commit sha 1a0a0061f24556dd7acc104aa969b05284c5b407

readline: Fix pkg-config support Closes #38972. Signed-off-by: Andrea Bolognani <eof@kiyuko.org> Closes #39349. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

push time in a month

pull request commentHomebrew/homebrew-core

deno v0.3.0 (new formula)

@hayd That's not the issue, I think I'm already beyond that problem.

It's just that the snapshot_creator has some strange issue with the already transpiled TypeScript (which I can't really debug).

Here is the transpiled gen/cli/bundle/compiler.js: https://gist.github.com/chrmoritz/fc1d42f579a6129e51c769e70ce539ca (the this._ts.createLanguageService is on line 134163, yes it's a large file)

hayd

comment created time in a month

issue commentlaurent22/joplin

Issue with installation of terminal application

Yeah thanks, 1.0.135 is working fine for me again.

leveled

comment created time in a month

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha e6b95eb1337a4b5e0fc40a618ca85fc8f03b1862

joplin 1.0.135

view details

push time in a month

pull request commentHomebrew/homebrew-core

joplin 1.0.128

Ups, should be fixed now.

chrmoritz

comment created time in a month

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha c438134741e1758f29d7c3a5ec142410e1471b9b

joplin 1.0.128

view details

push time in a month

pull request commentHomebrew/homebrew-core

joplin 1.0.128

The missing locales are fixed in 1.0.128.

Note: The newer 1.0.129 release changed the build script (resulting in a different directory layout without any other change), but didn't update the main entry point accordingly, so it's broken too atm and that's why I'm sticking here with the otherwise identical 1.0.128

chrmoritz

comment created time in a month

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha ad99f498a3530b78b61f6d60407f63be89729e9a

joplin 1.0.128

view details

push time in a month

issue commentlaurent22/joplin

Issue with installation of terminal application

It still doesn't work in 1.0.129 (1.0.128 is fine) because https://github.com/laurent22/joplin/commit/4638f11c5ea8f99a7a2f8ab35de178791b92b8e9 moved all the js files to a app directory, but the bin entry in package.json still points to ./main.js. So either this entry point should be changed to ./app/main.js or all the js files should be moved to the top level folder again as it was before.

leveled

comment created time in a month

PR opened Homebrew/homebrew-core

joplin 1.0.127

Created with brew bump-formula-pr.

+2 -11

0 comment

1 changed file

pr created time in a month

create barnchchrmoritz/homebrew-core

branch : joplin-1.0.127

created branch time in a month

pull request commentHomebrew/homebrew-core

v8 7.6.160

We are trying to track v8 stable and to canary here in homebrew, so this has to wait another 78 days unfortunately. If you need a canary version of v8 please consider creating such a formula in a own personal tap: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap.

Also the build failures are likely caused by the missing resource upgrades (You have to check the DEPS file of your selected v8 tag for their correct revisions).

chenrui333

comment created time in a month

PR opened Homebrew/homebrew-core

jsdoc3 3.6.2

Created with brew bump-formula-pr.

+2 -5

0 comment

1 changed file

pr created time in a month

create barnchchrmoritz/homebrew-core

branch : jsdoc3-3.6.2

created branch time in a month

create barnchchrmoritz/homebrew-core

branch : joplin-1.0.125

created branch time in 2 months

PR opened Homebrew/homebrew-core

joplin 1.0.125

Created with brew bump-formula-pr.

+5 -4

0 comment

1 changed file

pr created time in 2 months

create barnchchrmoritz/joplin

branch : sqlite

created branch time in 2 months

pull request commentHomebrew/homebrew-core

node 11 (version)

Node 11.15.0 is the latest node@11 version released yesterday. However please not that node 11 isn't a LTS version and will be in Maintenance (security fixes only) mode after this last minor update until the end of June, when it finally becomes End of Life. This would also be the first time that we'd create a versioned formula for an odd node release.

joshmedeski

comment created time in 2 months

delete branch chrmoritz/joplin

delete branch : node12

delete time in 2 months

pull request commentlaurent22/joplin

CLI: update sharp (for node 12 compatibility)

Did you test if adding a large image to a note will downsize it as expected?

Yes, it got downsized to the 1920px max.

chrmoritz

comment created time in 2 months

pull request commentlaurent22/joplin

CLI: update sharp (for node 12 compatibility)

@laurent22 I've only tested the CLI version of joplin with this PR yet and I can confirm that image resizing is working fine there.

But if I'm reading the resizeImage_ code correctly sharp isn't used at all for the desktop version (anymore?), but electron's nativeImage is used there instead. Maybe sharp was used in some older version for the electron client too and caused some issues leading to the downgrade from 0.18 to 0.17 in the past. But since then sharp was already upgraded to version 0.20.8 (=current used version).

Because of that I don't think that #102 is still relevant. This change should only affect the CLI version and not the electron desktop version.

chrmoritz

comment created time in 2 months

pull request commentlaurent22/joplin

CLI: update sharp (for node 12 compatibility)

If you update sharp will it still run on node 8 and node 10?

Yes, it will still run on node 6+ and it's tested on node 6/8/10/11/12 (see sharp's travis config).

chrmoritz

comment created time in 2 months

PR opened laurent22/joplin

CLI: update sharp (for node 12 compatibility)

This PR is part 1 / 2 of what is needed to make joplin cli compatible with node 12. Part 2 will be to update sqlite3 to a version with node 12 support. Unfortunately the fix for it didn't make it into a stable version yet (see also: https://github.com/mapbox/node-sqlite3/issues/1138), so we still have to wait for that.

This is currently the last remaining blocker for Homebrew to make all node formulae compatible with the latest current node 12 release in https://github.com/Homebrew/homebrew-core/pull/39188.

In this PR the version of the joplin cli dependency sharp is bumped from 0.20.8 to 0.22.1 for node compatibility and some deprecated and now removed function calls are replaced with their suggested replacements.

+78 -48

0 comment

3 changed files

pr created time in 2 months

create barnchchrmoritz/joplin

branch : node12

created branch time in 2 months

pull request commentHomebrew/homebrew-core

node 12.0.0

Sorry, but I'm a bit confused if the current discussion is about jsdoc3 (already fixed in this PR) or joplin.

@75lb: While my personal opinion is also that JavaScript dev tools are better installed vie npm as a devDependency instead of globally via homebrew, the fact that formula angular-cli are getting 1800 installs through homebrew every month clearly shows that there is indeed demand for it. But the formula which is still broken here is joplin, a note taking cmd line application, which is not only relevant excursively for js devs and therefore deserves a place in homebrew for that purpose.

@SMillerDev: It's also not clear to me if you are talking about jsdoc3 - the not so actively maintained project with low install counts, which got broken through a very outdated dependency (using private node API's), but with a easy fix available and already applied here - or about joplin - the actively maintained project which unfortunately has some dependencies on native addons, which doesn't always get updated in time for new node current releases, but it's also building and working fine if you manually upgrade these dependencies for compatible versions as shown here: https://gist.github.com/chrmoritz/1dbb5d753cf3399efc368d3264585faa

diogoazevedos

comment created time in 2 months

pull request commentHomebrew/homebrew-core

node 12.0.0

Unfortunately the blocker for upstreaming a fix to joplin is waiting for sqlite3 to release a stable version with the node 12 fix (and because there are waiting for an AppVeyor update with node 12 preinstalled this could take still a while). While bumping sqlite3 by one commit to the node 12 fix would be possible in homebrew (we are forcing to build native addons from source anyway) it wouldn't be upstreamable because of the lack of prebuild binaries for that specific commit.

The only options we have are either to patch it for node 12 compatibility ourself (as we did for node 10 in https://github.com/Homebrew/homebrew-core/commit/37e646d1dc91f590f88237ec9dcee36d954ea704#diff-28df9642f3d69826b09db80713ed92ed a year ago) or make it depend_on "node@10, which would still need a build dependency on the normal node formula and some shebang manipulation to point to the key-only node@10.

diogoazevedos

comment created time in 2 months

fork chrmoritz/joplin

Joplin - a note taking and to-do application with synchronization capabilities for Windows, macOS, Linux, Android and iOS. Forum: https://discourse.joplinapp.org/

https://joplinapp.org

fork in 2 months

pull request commentHomebrew/homebrew-core

node 12.0.0

The remaining joplin build error is caused by an incompatibility of the native addon sharp with the v8 abi from node 12. Fortunately sharp has already released a Node 12 compatibility update just 6 hours ago. So we will just have to wait until it's pushed to npm and patch joplin to use this instead. Also it might be worth to upgrade joplin to the latest version instead of the revision bump:

diff --git a/Formula/joplin.rb b/Formula/joplin.rb
index 962b78d77d..67fffdffbb 100644
--- a/Formula/joplin.rb
+++ b/Formula/joplin.rb
@@ -3,8 +3,8 @@ require "language/node"
 class Joplin < Formula
   desc "Note taking and to-do application with synchronisation capabilities"
   homepage "https://joplin.cozic.net/"
-  url "https://registry.npmjs.org/joplin/-/joplin-1.0.123.tgz"
-  sha256 "5b7830a9be0b7bc5a1db33a17f7c4c21ef2fcbb7568013b8fd1663bba6d02e5a"
+  url "https://registry.npmjs.org/joplin/-/joplin-1.0.124.tgz"
+  sha256 "6da64d5ff859d2e6648ebcdc4e99486461db4eba13d4827f0261ac4d5be8de35"
 
   bottle do
     sha256 "907470b99b73cd37d1144679f010a76313ac4d5d8c1e800485706088dd9b1617" => :mojave
@@ -16,6 +16,7 @@ class Joplin < Formula
   depends_on "node"
 
   def install
+    inreplace "package.json", "\"sharp\": \"^0.20.8\",", "\"sharp\": \"^0.22.1\","
     system "npm", "install", *Language::Node.std_npm_install_args(libexec)
     bin.install_symlink Dir["#{libexec}/bin/*"]
   end

(Doesn't work yet, but will as soon as sharp 0.22.1 is published on npm.

diogoazevedos

comment created time in 2 months

pull request commentHomebrew/homebrew-core

joplin 1.0.142

Also the latest joplin CLI release is v1.0.124 (see npm and their latest GitHub cli-v1.0.124 tag). The 1.0.142 is the latest version of the Desktop client.

alebcay

comment created time in 2 months

Pull request review commentHomebrew/homebrew-core

node 12.0.0

 class Jsdoc3 < Formula     sha256 "9d5a8b63309f02f86c42c7cf6973a000f4eda4ad0e1cea080a64674abea0a2da" => :el_capitan   end -  depends_on "node"+  depends_on "node@10"    def install     system "npm", "install", *Language::Node.std_npm_install_args(libexec)
     system "npm", "install", *Language::Node.std_npm_install_args(libexec)
     inreplace libexec/"lib/node_modules/jsdoc/node_modules/requizzle/lib/requizzle.js",
               "if (lookupPaths[0] === targetPath && lookupPaths[1].length === 0) {",
               "if (lookupPaths == null || lookupPaths[0] === targetPath && lookupPaths[1].length === 0) {"

and revert back the dependency to just node

diogoazevedos

comment created time in 2 months

pull request commentHomebrew/homebrew-core

node 12.0.0

The node 12 compatibility is quite a easy fix:

inreplace libexec/"lib/node_modules/jsdoc/node_modules/requizzle/lib/requizzle.js",
              "if (lookupPaths[0] === targetPath && lookupPaths[1].length === 0) {",
              "if (lookupPaths == null || lookupPaths[0] === targetPath && lookupPaths[1].length === 0) {"

Add this to the end of jsdoc3 install method.

diogoazevedos

comment created time in 2 months

pull request commentHomebrew/homebrew-core

node 12.0.0

Maybe update jsdoc3 dependency to node@10?

Unfortunately it's not that easy as it won't work out of the box with the versioned node formula.

diogoazevedos

comment created time in 2 months

pull request commentHomebrew/homebrew-core

deno v0.3.0 (new formula)

However the gn tag isn't the blocker here. It's the getting the formula working without binary downloads. After a quick try in https://gist.github.com/chrmoritz/7be25daadaf211bb4d2576bd3ed64643 I'm still getting errors from python ../../tools/write_gn_args.py gen/cli/gn_args.txt, because it's expecting build tools (like gn) to be located at specific paths instead of looking for it in the PATH first.

hayd

comment created time in 2 months

pull request commentHomebrew/homebrew-core

v8 7.4.288.25 depot_tools less build

@SMillerDev v8 7.4.288.25 is stable now. Could you (or someone else) please take another look?

chrmoritz

comment created time in 2 months

pull request commentHomebrew/homebrew-core

node 12.0.0

joplin will need a revision bump to rebuild it's native addon part

jsdoc3 seems to use some undocumented API via requizzle, which breaks node 12 compatibility?

diogoazevedos

comment created time in 2 months

pull request commentHomebrew/homebrew-core

deno v0.3.0 (new formula)

@dj-hedgehog gn didn't get it standalone formula, but it's still possible to add gn as a resource of the deno formula and build it from source as part of the deno build. It's just that getting rid of depot_tools and it's binary downloads is a non trivial task, see also the current work for v8 in #39157.

hayd

comment created time in 2 months

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha 22001409a1a55f98edeb2612c1bebb15540ebed8

v8: build with homebrew llvm on <= High Sierra

view details

push time in 2 months

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha 6dcbcdf08f8fd20a7b1b93fef5b30f0a66da7ffc

v8: build with homebrew llvm on <= High Sierra

view details

push time in 2 months

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha d5e85ae4e8840861a35be7f997cfb9472c8f0fa4

v8: use Googles clang on High Sierra and below

view details

push time in 2 months

more