profile
viewpoint
Christian Moritz chrmoritz Dresden, Germany

pull request commentHomebrew/homebrew-core

now-cli 16.1.1 (new formula)

@SMillerDev: Can we get this merged? @JounQin: now 16.1.2 is available now, so it couldn't hurt if we upgrade to this beforehand

JounQin

comment created time in 2 days

PR opened Homebrew/homebrew-core

deno 0.16.0

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in 2 days

create barnchchrmoritz/homebrew-core

branch : deno-0.16.0

created branch time in 2 days

Pull request review commentHomebrew/homebrew-core

now-cli 15.8.7 (new formula)

+require "language/node"++class NowCliBeta < Formula+  desc "The command-line interface for Now"+  homepage "https://zeit.co/now"+  url "https://registry.npmjs.org/now/-/now-16.1.0.tgz"+  sha256 "c089f0add1a4652f01f945d7fed75c811e6268b7c1c180e96876581480f59242"++  depends_on "node"++  def install+    rm Dir["dist/{*.exe,xsel}"]+    inreplace "dist/index.js" do |s|+      s.gsub! /(\w+).(\w+)=getUpdateCommand/, "\\1.\\2=async()=>'Please run `brew upgrade now-cli` to update Now CLI.'"+      s.gsub! '"now update"', '"brew upgrade now-cli"'+    end

now update does nothing more than printing the correct update command to the console and it does it pretty fine once we've patched it in getUpdateCommand. There is no need to avoid it since it won't run something again, it just hints the user how to update itself based on how it was installed.

The thing which broke the regex earlier was the rename from getUpgradeCommand to getUpdateCommand, which wouldn't be covered by your regex. Your regex would just cover moving it from a default export to a non-default named export, which is quite unlikely because it lives now in its own file serving only the single purpose to get the installation method dependent update command.

JounQin

comment created time in 9 days

Pull request review commentHomebrew/homebrew-core

now-cli 15.8.7 (new formula)

+require "language/node"++class NowCliBeta < Formula+  desc "The command-line interface for Now"+  homepage "https://zeit.co/now"+  url "https://registry.npmjs.org/now/-/now-16.1.0.tgz"+  sha256 "c089f0add1a4652f01f945d7fed75c811e6268b7c1c180e96876581480f59242"++  depends_on "node"++  def install+    rm Dir["dist/{*.exe,xsel}"]+    inreplace "dist/index.js" do |s|+      s.gsub! /(\w+).(\w+)=getUpdateCommand/, "\\1.\\2=async()=>'Please run `brew upgrade now-cli` to update Now CLI.'"+      s.gsub! '"now update"', '"brew upgrade now-cli"'+    end

Yeah, but now update would just print:

> Please run `brew upgrade now-cli` to update Now CLI

which is totally fine for us. Just drop this and only replace the getUpdateCommand. And since we are doing only 1 replace than a inreplace block with multiple s.gsub! isn't necessary anymore and you can just use a normal inreplace.

BTW: Also your regex wouldn't survive a exported name change from getUpdateCommand to something else either. The first part is just the webpacked default export and given it's in it's own get-update-command.ts now it's quite unlike to change to something else than the default export.

JounQin

comment created time in 9 days

Pull request review commentHomebrew/homebrew-core

now-cli 15.8.7 (new formula)

+require "language/node"++class NowCliBeta < Formula+  desc "The command-line interface for Now"+  homepage "https://zeit.co/now"+  url "https://registry.npmjs.org/now/-/now-16.1.0.tgz"+  sha256 "c089f0add1a4652f01f945d7fed75c811e6268b7c1c180e96876581480f59242"++  depends_on "node"++  def install+    rm Dir["dist/{*.exe,xsel}"]+    inreplace "dist/index.js" do |s|+      s.gsub! /(\w+).(\w+)=getUpdateCommand/, "\\1.\\2=async()=>'Please run `brew upgrade now-cli` to update Now CLI.'"+      s.gsub! '"now update"', '"brew upgrade now-cli"'+    end

But they changed the getUpdateCommand function in https://github.com/zeit/now-cli/commit/05c2f69523be6f23717d91cd5124221bbd73fdca#diff-9e2823661fa83a88b9ec7ba4be79faf2 to only return the command and not all the boilerplate text around it, so this inreplace needs to be updated for it. Also it's moved to it's own file now it it's there the single default export, so assuming that it will stay this way should be pretty safe.

For what was you s.gsub! '"now update"', '"brew upgrade now-cli"' intended?

JounQin

comment created time in 9 days

Pull request review commentHomebrew/homebrew-core

now-cli 15.8.7 (new formula)

+require "language/node"++class NowCliBeta < Formula
class NowCli < Formula

This isn't a beta and it doesn't match the naming convention.

JounQin

comment created time in 9 days

Pull request review commentHomebrew/homebrew-core

now-cli 15.8.7 (new formula)

+require "language/node"++class NowCliBeta < Formula+  desc "The command-line interface for Now"+  homepage "https://zeit.co/now"+  url "https://registry.npmjs.org/now/-/now-16.1.0.tgz"+  sha256 "c089f0add1a4652f01f945d7fed75c811e6268b7c1c180e96876581480f59242"
  url "https://registry.npmjs.org/now/-/now-16.1.1.tgz"
  sha256 "caf5db829121c8518796abeda1c048127859badc086330c06c30ff8c5ed69e67"

now 16.1.1 is available now

JounQin

comment created time in 9 days

Pull request review commentHomebrew/homebrew-core

now-cli 15.8.7 (new formula)

+require "language/node"++class NowCliBeta < Formula+  desc "The command-line interface for Now"+  homepage "https://zeit.co/now"+  url "https://registry.npmjs.org/now/-/now-16.1.0.tgz"+  sha256 "c089f0add1a4652f01f945d7fed75c811e6268b7c1c180e96876581480f59242"++  depends_on "node"++  def install+    rm Dir["dist/{*.exe,xsel}"]+    inreplace "dist/index.js" do |s|+      s.gsub! /(\w+).(\w+)=getUpdateCommand/, "\\1.\\2=async()=>'Please run `brew upgrade now-cli` to update Now CLI.'"+      s.gsub! '"now update"', '"brew upgrade now-cli"'+    end
    inreplace "dist/index.js", "t.default=getUpdateCommand",
                               "t.default=async()=>'brew upgrade now-cli'"

This should be enough to update the update-command.

JounQin

comment created time in 9 days

PR opened Homebrew/homebrew-core

node@10 10.16.3

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in 9 days

create barnchchrmoritz/homebrew-core

branch : node@10-10.16.3

created branch time in 9 days

PR opened Homebrew/homebrew-core

node@8 8.16.1

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in 9 days

create barnchchrmoritz/homebrew-core

branch : node@8-8.16.1

created branch time in 9 days

PR opened Homebrew/homebrew-core

node 12.8.1

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in 10 days

create barnchchrmoritz/homebrew-core

branch : node-12.8.1

created branch time in 10 days

PR opened Homebrew/homebrew-core

deno 0.15.0

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in 11 days

create barnchchrmoritz/homebrew-core

branch : deno-0.15.0

created branch time in 11 days

pull request commentHomebrew/homebrew-core

git 2.22.1

I think the test-bot failure here is caused by https://github.com/Homebrew/homebrew-test-bot/pull/267. Since the formula itself (git in this case) isn't uninstalled anymore, the git version installed by this formula is used during the cleanup (calling git -C homebrew/homebrew-core checkout master -f). But unfortunately we've already forcefully uninstalled it's dependency and therefore it's broken.

leonklingele

comment created time in 12 days

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha f495115b0f287b0b1b010393ed97ab9966fac23b

deno: use cargo for building

view details

push time in 15 days

push eventchrmoritz/homebrew-core

Jeroen Ooms

commit sha e81cb684053ab175fe9700e84f99b3a64d33e74b

tesseract 4.1.0 Closes #42424. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha 61a4e917a178d59885e939939c35546d578fb639

tesseract: update 4.1.0 bottle.

view details

Ryan S. Elliott

commit sha d03fafe33ecbf9983b892d1820386d88616b2403

kim-api 2.1.1

view details

Ryan S. Elliott

commit sha 2eddd0dcb26f8e3d13af6b070e240abbc427705b

openkim-models-2019-07-25 Closes #42434. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha 1a5bb0269967e62fb95217373793c54b1e34a3c7

kim-api: update 2.1.1 bottle.

view details

BrewTestBot

commit sha 30edc9969b82112b283e942716cff49bce82b7c1

openkim-models: update 2019-07-25 bottle.

view details

Jean-Francois Simoneau

commit sha c795f2b51ac1d3e405efdfdb453c205ac76f5a32

png++ 0.2.10 Closes #42430. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha c3c3f2d62e9b996aae00af95100dcff7ae89dfdd

png++: update 0.2.10 bottle.

view details

Sean T. Allen

commit sha e82c3a5c5524008dd7cc02470e14d4c27634318c

pony-stable 0.2.1 Closes #42366. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha 111ea06623adfc88f5bfaaf5783c306c2a6ce139

pony-stable: update 0.2.1 bottle.

view details

EricFromCanada

commit sha f280da3608edab9b729f214e04e5971156f05c02

x11vnc 0.9.16 Closes #42293. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha e9961cf93f7d2e61c884a086dead912a9ac55695

x11vnc: update 0.9.16 bottle.

view details

Caleb Xu

commit sha 91d25d7eaf3a2b363c0649495515657434202fe6

spin 6.5.0 Closes #42297. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha 08b23acb0b1c1209161508065c6a51583cd402a2

spin: update 6.5.0 bottle.

view details

Paul Emm. Katsoulakis

commit sha 28501c560df497f43504c37e8485773fb1208f7b

netdata: fix edit-config issue Fixed edit-config issue having wrong paths, reported on https://github.com/netdata/netdata/issues/6165 Also added extra configure flags, to comply with the netdata way of configuring. Closes #42330. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha 2c97973dda17c70c6219d8e867b96892b5314e8e

netdata: update 1.16.0 bottle.

view details

lcdtyph

commit sha cf185cd7b2e08ce74773297e18ecb5ba93c49135

cjson: build both static and shared libraries Closes #42393. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha c52b21b1651a77394d79bc549f76d5e8a98eb13a

cjson: update 1.7.12 bottle.

view details

Matt Brown

commit sha 6f7be63a8a078914ada0b89b71c01357aa14c231

tfenv: install share directory for gpg verification tfenv has logic for verifying the Terraform releases that it downloads with gpg or gpgv. When gpgv is used, tfenv tries to verify the download's signature based on a key for Hashicorp that is bundled with the tfenv release in the `share` directory - but the homebrew formula is not installing that directory. Closes #42396. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

Juan Carlos Alonso

commit sha 838e42706d97b333658dc3387f7b5e5fd2e7624e

benthos 2.9.3 (new formula) Closes #42421. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

push time in 15 days

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha 79a7406957095d0d91c21316e9f534102a841928

deno 0.14.0

view details

push time in 15 days

PR opened Homebrew/homebrew-core

v8 7.6.303.29

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in 15 days

create barnchchrmoritz/homebrew-core

branch : v8-7.6.303.29

created branch time in 15 days

create barnchchrmoritz/homebrew-core

branch : deno-0.14.0

created branch time in 16 days

PR opened Homebrew/homebrew-core

deno 0.14.0

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in 16 days

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha b8db2f51a3123f76b936df550c26ac31e8c4548e

ungit: fix flaky test

view details

push time in 24 days

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha 25125410a8f9713f519e1fd44cb78accc810156e

ungit: fix flaky test

view details

push time in 24 days

push eventchrmoritz/deno

Christian Moritz

commit sha 388b73892fb2319809f85d7ab20f585e7edaf69a

appveyour: try without sccache

view details

push time in 24 days

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha 53cd1e4cfe014eff263214df34afd15c13905228

node 12.7.0

view details

push time in 24 days

push eventchrmoritz/deno

Ryan Dahl

commit sha 22942773dc82a78354ad8757f2848b0fcdd93b62

turn off treat_warnings_as_errors

view details

Ryan Dahl

commit sha 4ae34ed3fdcf984141179b446edfaeef85a078aa

fix test

view details

afinch7

commit sha e3757bb1678ce1703da244ac688ee394c62eefe3

update cargo_gn

view details

afinch7

commit sha 7e5cffe6e3b322fc9edade8e8ebf5d4fd41893f3

remove CARGO_TARGET_DIR from travis config

view details

afinch7

commit sha 2257637b53d02dab972180b59c852a733781eb99

fmt

view details

afinch7

commit sha 2462e1b6274cf7be6b0f919e3f5a998f5944df08

pass custom env to ninja on windows

view details

afinch7

commit sha 13b33f7eccf2d38fff52aa6aab50c47fcef99245

update cargo_gn again and fix binary size benchmark

view details

afinch7

commit sha 0f91a057d2914d66d91042767d64735a0b5b519b

revert cargo_gn dep back to master

view details

Christian Moritz

commit sha 2db5744d460cbd3280f0524ad458ecfcc98f4877

appveyour: try without sccache

view details

push time in 24 days

PR opened Homebrew/homebrew-core

v8 7.6.303.27

Created with brew bump-formula-pr.

+23 -22

0 comment

2 changed files

pr created time in 24 days

create barnchchrmoritz/homebrew-core

branch : v8-7.6.303.27

created branch time in 24 days

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha bb6b13e3691175482f18df95e98345a48b29878f

deno 0.13.0

view details

push time in 24 days

create barnchchrmoritz/homebrew-core

branch : deno-0.13.0

created branch time in 24 days

PR opened Homebrew/homebrew-core

deno 0.13.0

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in 24 days

push eventchrmoritz/homebrew-core

Igor Kapkov

commit sha 9dd8a02a03254bfb4466d365f57051cb9386873f

folly 2019.07.22.00 Closes #42309. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha 31ea95bb5d34411e591259846a8d7ce8a2e571f7

folly: update 2019.07.22.00 bottle.

view details

EricFromCanada

commit sha 062c74c2bcfec6356815e661517cc506d5461aea

vnstat 2.3 Closes #42354. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha e598c4cf0c0b5fb9a2bc9ec09299352d3467209f

vnstat: update 2.3 bottle.

view details

Igor Kapkov

commit sha ba2c4cf355e338e691300fd22447d50f463ca6cd

git-lfs 2.8.0 Closes #42353. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha d28a80f0900c3a8f455940dd436d1c42362fd928

git-lfs: update 2.8.0 bottle.

view details

Rui Chen

commit sha c667d5200428c824baa4b4ee5de9d5dd3a7d132d

k3d 1.3.0 Closes #42350. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha 60538aabbd75afc3aa70bc702dc40b837db64b30

k3d: update 1.3.0 bottle.

view details

Rui Chen

commit sha 03265dea6b0bf67dfdc2cff046cbb3c78ffb1af9

telegraf 1.11.3 Closes #42347. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha 868056103be4f4f862ef90afdc82112e7ee62e17

telegraf: update 1.11.3 bottle.

view details

Rui Chen

commit sha eb5feb3c1f5afde3f7b70c5594c724399b039117

terragrunt 0.19.10 Closes #42344. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha 6b4d507105f766c28e5c051ef71350c5518e9963

terragrunt: update 0.19.10 bottle.

view details

Rui Chen

commit sha 149b0ed06289cdf354c7d9c9651cb0feefa55d1b

webpack 4.37.0 Closes #42336. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha d75d3f51d7f65955e65a6d8424d5880de82e27d9

webpack: update 4.37.0 bottle.

view details

Rui Chen

commit sha c824add8371dfe95b068fe620ed963b0758c1d36

exploitdb 2019-07-23 Closes #42335. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

Andrew Lavery

commit sha 29d9180a3e5af5b92fac2da2fc4a4b9469976d49

ship 0.49.1 Closes #42349. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha 8f8419940cb66c9da81f1ba0a8a04e0ef90c0a1e

ship: update 0.49.1 bottle.

view details

Brian Callahan

commit sha 30dabf9db913a79a35a06bdbe44939420f00585b

mg 6.5 Closes #42348. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

BrewTestBot

commit sha 86129086d11b9f6ec82ea10c191932682e988459

mg: update 6.5 bottle.

view details

Caleb Xu

commit sha 42e166b07a3c892ff7441cf954a6a5e22e587d0a

debianutils 4.8.6.3 Closes #42340. Signed-off-by: Chongyu Zhu <i@lembacon.com>

view details

push time in 25 days

pull request commentHomebrew/homebrew-core

now-cli 15.8.0 (new formula)

@JounQin I don't think your last commit is really necessary, because they are removing the pkg embedding with the next minor (major?) version completely. Then we should be able to just fetch their transpiled files from npm and do the regular normal node formula installation like in: https://gist.github.com/chrmoritz/cf4274d7934e295bd08f4c4e28e9a166#file-now-cli-rb-L11-L14 (using their canary atm).

JounQin

comment created time in a month

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha 904ddcef1b3899f5ac50f19e0605b80320d6b5ba

node 12.7.0

view details

push time in a month

create barnchchrmoritz/homebrew-core

branch : node-12.7.0

created branch time in a month

PR opened Homebrew/homebrew-core

node 12.7.0

Created with brew bump-formula-pr.

+4 -4

0 comment

1 changed file

pr created time in a month

Pull request review commentdenoland/deno

Use cargo_gn to build using "cargo build"

 default_args = {   use_jumbo_build = true    symbol_level = 1-  treat_warnings_as_errors = true++  # TODO(ry) Change this back to 'true'. This is to workaround windows error+  # that is only encountered when building with cargo_gn.+  #   clang-cl: error: argument unused during compilation:+  #   '-mno-incremental-linker-compatible'+  #   [-Werror,-Wunused-command-line-argument]+  treat_warnings_as_errors = false

Also this happens only when using sccache (it doesn't happen when calling clang-cl directly).

ry

comment created time in a month

push eventchrmoritz/deno

Christian Moritz

commit sha 2cfeaadf655e0052d8359f4fcb94b8e953e63a3f

appveyour: try without sccache

view details

push time in a month

push eventchrmoritz/deno

Bartek Iwańczuk

commit sha 8214b686cea3f6ad57d7da49a44d33185fdeb098

Refactor DenoDir (#2636) * rename `ModuleMetaData` to `SourceFile` and remove TS specific functionality * add `TsCompiler` struct encapsulating processing of TypeScript files * move `SourceMapGetter` trait implementation to `//cli/compiler.rs` * add low-level `DiskCache` API for general purpose caches and use it in `DenoDir` and `TsCompiler` for filesystem access * don't use hash-like filenames for compiled modules, instead use metadata file for storing compilation hash * add `SourceFileCache` for in-process caching of loaded files for fast subsequent access * define `SourceFileFetcher` trait encapsulating loading of local and remote files and implement it for `DenoDir` * define `use_cache` and `no_fetch` flags on `DenoDir` instead of using in fetch methods

view details

迷渡

commit sha a0b8f13f18b24924d050e196baf6132b27a6011f

Rename powershell highlighting to shell (#2654)

view details

迷渡

commit sha ac98bd8a7ce13e6aaf35d13b8743281df24806d7

fix timer's params length (#2655)

view details

Ryan Dahl

commit sha bc12a3ba56b39ba8dd3f5afcccebca177361eab2

Reorder tools/format.py so slowest are last (#2661)

view details

Ryan Dahl

commit sha 55ca0f09cb50f8bc6b0590a9a88febc41f91e51b

REPL shouldn't panic when it gets SIGINT (#2662)

view details

Ryan Dahl

commit sha a37bc0088f9de76108fe0bd9243c794b413d73cf

Remove hacky normalize_path (#2660)

view details

andy finch

commit sha 056c14617565291cb00df9fec6f9779a3669089f

Fix expected dyn before AnyError trait (#2663)

view details

andy finch

commit sha 042484d45afe129f0c08d387870e4c6de019c34b

remove v8::Locker from deno_respond (#2664)

view details

andy finch

commit sha 621af21e6eab9b0f736d5b6e8acc48dbad4a68d2

only use Locker when calling into js (#2665)

view details

Ryan Dahl

commit sha a00d087b39da7894276c2292335d2709a6cebd8c

Improve example on homepage (#2667)

view details

Bartek Iwańczuk

commit sha 34f212f257af3ccce4a1cb8e9b75b9cb5cb1c13b

fix: bring back --no-fetch flag (#2671)

view details

andy finch

commit sha c98d9bf7097575ec9832864f0e0d076a4763717c

removed unnecessary implementation from SourceFileFetcher (#2670)

view details

Yoshiya Hinosawa

commit sha 9c22961b6a06a75dad68bad87328857a9f7a55dc

feat(website/benchmark): enable zoom of charts (#2668)

view details

Ryan Dahl

commit sha 707338f12d3b67b26eb153ba24c9d89196c03690

Remove Deno.build.args feature This is a minor feature which complicates the build signifigantly. Removing to ease refactoring the build system: https://github.com/denoland/deno/issues/2608

view details

Ryan Dahl

commit sha 1e9862a6ad806ed0189f0c8fde1bf9ca1dc39cba

WIP cargo_gn integration

view details

Ryan Dahl

commit sha 1e0f76df3929d1b2f39df052a34da723dfa607a6

Run tests with 'cargo build'

view details

Christian Moritz

commit sha 0e7df94cfbe02cdfbd845f3452efae3e7c8a9dfa

appveyour: try without sccache

view details

push time in a month

push eventchrmoritz/cargo_gn

Christian Moritz

commit sha 71d42267c7187fb8ed868e2ab5d02b0dcaa4ed8a

fix ci builds

view details

push time in a month

PR opened denoland/cargo_gn

fix ci builds
  • travis:
    • need to set $GN and $NINJA because we don't install them to a location in the $PATH
    • clone and build them actual inside $HOME and not at root level (the cwd in the install step)
  • azure:
    • ninja from ubuntu 16.04 apt is way to old (1.5.2), so we have to build a recent version from source here too
+12 -6

0 comment

2 changed files

pr created time in a month

push eventchrmoritz/cargo_gn

Christian Moritz

commit sha 0b20ec765fff09286cd4350bf30476cc58350a51

fix ci builds

view details

push time in a month

push eventchrmoritz/cargo_gn

Christian Moritz

commit sha 06276422aa423b267af4be617ede2d725981fa2e

fix ci builds

view details

push time in a month

push eventchrmoritz/cargo_gn

Christian Moritz

commit sha 9d99897c770761e14559978179b58d0d06968b12

fix ci builds

view details

push time in a month

delete branch chrmoritz/cargo_gn

delete branch : patch-1

delete time in a month

delete branch chrmoritz/cargo_gn

delete branch : patch-2

delete time in a month

push eventchrmoritz/cargo_gn

Christian Moritz

commit sha 7f9b14836b2895e685cdbfacfbd6a046e959e68e

fix ci builds

view details

push time in a month

push eventchrmoritz/cargo_gn

Christian Moritz

commit sha 891eaf58420235c97b072332acdb00d27abec9d3

add ninja to PATH and set GN env variable

view details

push time in a month

Pull request review commentHomebrew/homebrew-core

now-cli 15.8.0 (new formula)

+require "language/node"++class NowCli < Formula+  desc "The command-line interface for Now"+  homepage "https://zeit.co/now"+  url "https://github.com/zeit/now-cli/archive/15.8.0.tar.gz"+  sha256 "a0ac758dfe87e67cbfded18d44d8eca657f4ec1767f44ee3b4380738859e836c"++  depends_on "node" => :build++  def install+    inreplace "package.json" do |s|+      s.gsub! /^.*"postinstall".*$/, "" # don't run postinstall+    end++    system "npm", "install", *Language::Node.local_npm_install_args+    system "npm", "run", "build"++    # Read the target node version from package.json+    target = IO.read("package.json").match(/\"(node\d+(\.\d+){2})-[^"]+\"/)[1]++    # This packages now-cli together with a patched version of node+    pkg_args = %W[+      --c=package.json+      --o=now+      --options=no-warnings+      --targets=#{target}+    ]

I can reproduce this build failure locally, but is must have something to do with their build config/patches, because we don't see this for official node builds.

An alternativ would be trying to do something like this https://github.com/chrmoritz/homebrew-core/commit/4521080efdd15534fe8d4685823e565cb01fc545 to get it to work against our node at runtime.

But regardless which method we choose, we should patch the update check. Letting it suggest to update it via npm every time a new version is available, even when it wasn't installed that way is probably a bad idea.

JounQin

comment created time in a month

create barnchchrmoritz/homebrew-core

branch : now-cli

created branch time in a month

Pull request review commentHomebrew/homebrew-core

now-cli 15.8.0 (new formula)

+require "language/node"++class NowCli < Formula+  desc "The command-line interface for Now"+  homepage "https://zeit.co/now"+  url "https://github.com/zeit/now-cli/archive/15.8.0.tar.gz"+  sha256 "a0ac758dfe87e67cbfded18d44d8eca657f4ec1767f44ee3b4380738859e836c"++  depends_on "node" => :build++  def install+    inreplace "package.json" do |s|+      s.gsub! /^.*"postinstall".*$/, "" # don't run postinstall+    end++    system "npm", "install", *Language::Node.local_npm_install_args+    system "npm", "run", "build"++    # Read the target node version from package.json+    target = IO.read("package.json").match(/\"(node\d+(\.\d+){2})-[^"]+\"/)[1]++    # This packages now-cli together with a patched version of node+    pkg_args = %W[+      --c=package.json+      --o=now+      --options=no-warnings+      --targets=#{target}+    ]

Adding --build makes sense here, because unfortunately using our node at runtime would be overly complicated.

Also don't forget to replace assert File.exist?("bash/index.sh") assert_predicate "bash/index.sh", :exist? and so on in test to fix the audit error.

JounQin

comment created time in a month

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha 20d72a659d7f5cc0e9f74201a1db2af6ec001dbf

deno: use cargo for building

view details

push time in a month

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha 5146e783c9e55afd2e6e090e4a06e6b26eff36a1

deno: use cargo for building

view details

push time in a month

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha b50fea7b979da65e46aa7fd2eb7e0ce82aa11cd9

deno: use cargo for building

view details

push time in a month

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha 686221c2b55f9ca6d7d6e57d804cf4d55694a27d

deno: use cargo for building

view details

push time in a month

pull request commentdenoland/deno

WIP build with cargo instead of tool/build.py

Sure, we're already building our own gn binary as part of the build and we can keep doing so (as long as a custom gn/ninja is still configurable via CARGO_GN_PATH, ...).

ry

comment created time in a month

Pull request review commentdenoland/deno

WIP build with cargo instead of tool/build.py

 jobs:     - name: "cargo release linux x86_64"       os: linux       script:+      # CARGO_GN_PATH and CARGO_NINJA_PATH allivate the need to build these+      # tools from scratch. See docs at https://crates.io/crates/cargo_gn+      - export CARGO_GN_PATH=$TRAVIS_BUILD_DIR/buildtools/linux64/gn+      - export CARGO_NINJA_PATH=$TRAVIS_BUILD_DIR/third_party/depot_tools/ninja       - ./tools/lint.py       - ./tools/test_format.py       - cargo build -vv --release --locked       - cargo clippy --all-targets --release --locked -- -D clippy::all+      # TODO(ry) Warning! The following does not run libdeno_test+      - ./tools/test.py
      - DENO_BUILD_MODE=release ./tools/test.py

(cargo is building only the release target, so we can't test the debug one here)

The windows/appveyor failure could be related to https://github.com/mozilla/sccache/issues/264.

Also it might be worth adding a cargo mac job to the ci matrix if this is going to become the default build frontend.

ry

comment created time in a month

Pull request review commentHomebrew/homebrew-core

now-cli 15.8.0 (new formula)

+require "language/node"++class NowCli < Formula+  desc "The command-line interface for Now"+  homepage "https://zeit.co/now"+  url "https://github.com/zeit/now-cli/archive/15.8.0.tar.gz"+  sha256 "a0ac758dfe87e67cbfded18d44d8eca657f4ec1767f44ee3b4380738859e836c"++  depends_on "node" => :build++  def install+    inreplace "package.json" do |s|+      s.gsub! /^.*"postinstall".*$/, "" # don't run postinstall+    end++    system "npm", "install", *Language::Node.local_npm_install_args+    system "npm", "run", "build"++    # Read the target node version from package.json+    target = IO.read("package.json").match(/\"(node\d+(\.\d+){2})-[^"]+\"/)[1]++    # This packages now-cli together with a patched version of node+    pkg_args = %W[+      --c=package.json+      --o=now+      --options=no-warnings+      --targets=#{target}+    ]

Is this able to use our node@10 (or even node) at runtime?

Alternatively could you please add at least the --build option here. It's preferred to not pull large prebuilt binaries (such as custom prebuilt node binaries here) during the formula build and instead build everything from source.

JounQin

comment created time in a month

PR opened Homebrew/homebrew-core

v8 7.5.288.30

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in a month

create barnchchrmoritz/homebrew-core

branch : v8-7.5.288.30

created branch time in a month

push eventchrmoritz/deno

Christian Moritz

commit sha 47aca675d5a1cfd248054ccb2ceae17f8e2509ea

travis.yml cargo: use gcc-5 on linux (with sccache)

view details

push time in a month

pull request commentdenoland/deno

WIP build with cargo instead of tool/build.py

Shouldn't something like this work with sccache?

    - name: "cargo release linux x86_64"
      os: linux
      addons:
        apt:
          sources:
            - ubuntu-toolchain-r-test
          packages:
            - g++-5
      script:
      - export CC="sccache gcc-5" && export CXX="sccache g++-5"
      - ./tools/lint.py
      - ./tools/test_format.py
      - cargo build -vv --release --locked
      - cargo clippy --all-targets --release --locked -- -D clippy::all

Also it would be great, if tools/build_common.rs would continue to support adding gn args passed in via the DENO_BUILD_ARGS environment variable or having a similar alternative to it (so that you can still pass in clang_base_path= for example).

ry

comment created time in a month

pull request commentdenoland/deno

WIP build with cargo instead of tool/build.py

Right, but I guess gcc-5 should be sufficient to build ninja and gn, because work building v8 Google's clang is used anyway. Which mean either upgrading to xenial (instead of trusty) image or using something like https://github.com/chrmoritz/deno/commit/7483c30a6c1140102418d9786c4db8712f9ddc0c for gcc-5 should be enough. https://docs.travis-ci.com/user/languages/cpp/#c11c11-and-beyond-and-toolchain-versioning

ry

comment created time in a month

push eventchrmoritz/deno

Ryan Dahl

commit sha 1fde15c0bc77e0c5cc6f7cbf27b4e072e1ad6c46

Fix REPL when it receives EOF (#2638)

view details

Ryan Dahl

commit sha bd6ebb32df11641e148fd0adca41e7188f16afce

hyper_hello should be in its own crate (#2641) So that "cargo build" will build it when the gn frontend is eventually removed.

view details

Yoshiya Hinosawa

commit sha 9c454998646ef49f652bc919f53503ed07a1c55c

Support window.onload (#2643)

view details

Ryan Dahl

commit sha 4e248ecda9bb31478c6db7f5e76fa12b64b516a9

v0.12.0

view details

迷渡

commit sha 181cfc9fb5bd2cbb7cd0a994a845e1901d256770

Adjust console constructor (#2649) https://github.com/denoland/deno/pull/2073#discussion_r303401539

view details

Ryan Dahl

commit sha 481a82c983e40201589e105e28be4ce809e46a60

Edits to manual (#2646)

view details

Ryan Dahl

commit sha 469aab384b80204fbd2facbb092af995c59844da

Remove Deno.build.args feature This is a minor feature which complicates the build signifigantly. Removing to ease refactoring the build system: https://github.com/denoland/deno/issues/2608

view details

Ryan Dahl

commit sha bcee70656721fce22cf9f7a24e1ab44ab915e25b

WIP cargo_gn integration

view details

Christian Moritz

commit sha 7483c30a6c1140102418d9786c4db8712f9ddc0c

travis.yml cargo: use gcc-5 on linux and add macOS job

view details

push time in a month

create barnchchrmoritz/homebrew-core

branch : denoCargo

created branch time in a month

push eventchrmoritz/brew

Christian Moritz

commit sha 170c6e0c704aa264ff3ad2cf8249c8732deea33f

bump-formula-pr: refactor audit to own method to reduce complexity

view details

push time in a month

push eventchrmoritz/brew

Christian Moritz

commit sha 2d9e7922b967f0928ac3e0040cbae8889d5fad31

bump-formula-pr: rename versioned alias if necessary

view details

Christian Moritz

commit sha a1aec1b443b33a26aebc63337e54ebf560b4c75e

bump-formula-pr: refactor audit to own method to reduce complexity

view details

push time in a month

pull request commentdenoland/deno

WIP build with cargo instead of tool/build.py

@ry This way unintentional closed, because apparently GitHub's fix syntax does also work if you are only linking to PR comments.

ry

comment created time in a month

push eventchrmoritz/cargo_gn

Christian Moritz

commit sha 4b56e6caa81d0dc232c2dbd53cb03ca6927263c1

create gn_out directory first

view details

push time in a month

pull request commentdenoland/deno

WIP build with cargo instead of tool/build.py

@ry Oh I see. But I think I found the real issue here. You a writing the args.gn file after calling gn gen target/{release,debug}/gn_out, which is already to late. I think https://github.com/denoland/cargo_gn/pull/7 should fix this.

ry

comment created time in a month

PR opened denoland/cargo_gn

fix: write args.gn before calling gn gen

This should fix https://github.com/denoland/deno/pull/2640#issuecomment-512516678.

+3 -3

0 comment

1 changed file

pr created time in a month

push eventchrmoritz/cargo_gn

Christian Moritz

commit sha 0d795891fdd9d420d4cd76d61258b9bd84be9ce9

fix: write args.gn before calling gn gen

view details

push time in a month

fork chrmoritz/cargo_gn

Cargo GN integration

fork in a month

pull request commentdenoland/deno

WIP build with cargo instead of tool/build.py

@ry Looks like the old gn based system / setup.py writes the args.gn file to target/{release,debug}/args.gn, while the new cargo_gn based system puts the args.gn file into target/{release,debug}**/gn_out/**args.gn.

ry

comment created time in a month

pull request commentdenoland/deno

WIP build with cargo instead of tool/build.py

This does not make it independent of clang, unfortunately. It seems the V8 build is strongly tied to the Google clang binaries.

At least I was able to build it without Google clang after adding clang_base_path="/usr/local/opt/llvm/" (pointing to homebrews llvm-8) to the args in .gn. It just requires a very recent version of llvm/clang, which of cause might not be easily available for your distribution. Even Apples clang, which ships with Mojave isn't new enough anymore for the latest v8 (it still is enough for 7.5 but I think it will break after it).

Also adding it to release_args in tools/build_common.rs didn't work for me. So it looks like cargo_gn doesn't pass these options to gn correctly yet, which might also be the reason why sccache isn't working correctly for you.

ry

comment created time in a month

pull request commentHomebrew/brew

bump-formula-pr: add update-alias option to rename formula aliases if necessary

I've addressed both comments and made it the default behavior after hardening the versioned_alias regex a bit more to only match versioned alias ending on an @ followed by a 1- or 2-digit version number.

chrmoritz

comment created time in a month

push eventchrmoritz/brew

Christian Moritz

commit sha 8d9278904a8327949743b9c9ba6d0fb94f633af5

bump-formula-pr: rename versioned alias if necessary

view details

Christian Moritz

commit sha 54266cd5daef9ce93f423b4cb321c8f08f4f51a5

bump-formula-pr: refactor audit to own method to reduce complexity

view details

push time in a month

Pull request review commentHomebrew/brew

bump-formula-pr: add update-alias option to rename formula aliases if necessary

 def check_for_duplicate_pull_requests(formula)       EOS     end   end++  def alias_update_pair(formula, new_formula_version)+    versioned_alias = formula.aliases.grep(/.@\d/).first+    return if versioned_alias.nil?++    name, old_alias_version = versioned_alias.split("@")+    if old_alias_version.split(".").length == 1

Ah, that was what you've meant. I've forgot that ruby has an inline if/else too (however with quite a different syntax compared to python).

chrmoritz

comment created time in a month

Pull request review commentHomebrew/brew

bump-formula-pr: add update-alias option to rename formula aliases if necessary

 def check_for_duplicate_pull_requests(formula)       EOS     end   end++  def alias_update_pair(formula, new_formula_version)+    versioned_alias = formula.aliases.grep(/.@\d/).first+    return if versioned_alias.nil?++    name, old_alias_version = versioned_alias.split("@")+    if old_alias_version.split(".").length == 1+      new_alias_version, = *new_formula_version.to_s.match(/^\d+/)+    else+      new_alias_version, = *new_formula_version.to_s.match(/^\d+\.\d+/)+    end+    return if Version.create(new_alias_version) <= Version.create(old_alias_version)++    [versioned_alias, "#{name}@#{new_alias_version}"]+  end++  def run_audit(formula, alias_rename)+    if args.dry_run?+      if args.no_audit?+        ohai "Skipping `brew audit`"+      elsif args.strict?+        ohai "brew audit --strict #{formula.path.basename}"+      else+        ohai "brew audit #{formula.path.basename}"+      end

Sure, given that it is its own function. Also this could possible be done in inreplace_pairs() too I guess.

chrmoritz

comment created time in a month

PR opened Homebrew/homebrew-core

deno 0.12.0

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in a month

create barnchchrmoritz/homebrew-core

branch : deno-0.12.0

created branch time in a month

Pull request review commentHomebrew/brew

bump-formula-pr: add update-alias option to rename formula aliases if necessary

 def check_for_duplicate_pull_requests(formula)       EOS     end   end++  def alias_update_pair(formula, new_formula_version)+    versioned_alias = formula.aliases.grep(/.@\d/).first+    return if versioned_alias.nil?++    name, old_alias_version = versioned_alias.split("@")+    version_regex = (old_alias_version.split(".").length == 1) ? /^\d+/ : /^\d+\.\d+/

I hope you had something like this in mind? (If we are using a whole if...else statement than we can just inline the regex.) https://github.com/Homebrew/brew/blob/e605713be8837a33407a23e82be160913489f5b9/Library/Homebrew/dev-cmd/bump-formula-pr.rb#L437-L443

chrmoritz

comment created time in a month

push eventchrmoritz/brew

Christian Moritz

commit sha 626188ebeefb8e4a858c3fc70a168ebdb458a320

bump-formula-pr: rename versioned alias if necessary

view details

Christian Moritz

commit sha 09b92f76608a3d978de0f14e59535f559c62c09a

bump-formula-pr: refactor audit to own method to reduce complexity

view details

Christian Moritz

commit sha e605713be8837a33407a23e82be160913489f5b9

bump-formula-pr: make it an --update-alias option (maybe?)

view details

push time in a month

Pull request review commentHomebrew/brew

bump-formula-pr: add update-alias option to rename formula aliases if necessary

 def bump_formula_pr       branch = "#{formula.name}-#{new_formula_version}"       git_dir = Utils.popen_read("git rev-parse --git-dir").chomp       shallow = !git_dir.empty? && File.exist?("#{git_dir}/shallow")+      changed_files = [formula.path]+      changed_files += alias_rename unless alias_rename.nil?

changed it here and everywhere else

chrmoritz

comment created time in a month

pull request commentHomebrew/brew

bump-formula-pr: add update-alias option to rename formula aliases if necessary

Thanks @MikeMcQuaid for the review. I've addressed you comments.

What would be the downsides of making this the default behaviour rather than making it a flag?

I think it's just me being a bit overcautious about some edge cases this could break, like if a formula completely changes it's version schema. However in this casebrew bump-formula-pr shouldn't be used anyway / the update would need to be done manually anyway. So maybe it's fine making this the default behaviour.

chrmoritz

comment created time in a month

push eventchrmoritz/brew

Christian Moritz

commit sha 4eeef13eed2a55d47b805fedc8e5ece4b7737115

bump-formula-pr: rename versioned alias if necessary

view details

Christian Moritz

commit sha 4aa7b94f38c1cf58ec45057d166d66dcd8424c1d

bump-formula-pr: make it an --update-alias option (maybe?)

view details

push time in a month

push eventchrmoritz/brew

Christian Moritz

commit sha 0ad9feee5b0e9c3bedf460ead35d020ff82321d3

squash! bump-formula-pr: add update-alias option update man pages

view details

push time in a month

PR opened Homebrew/brew

bump-formula-pr: add update-alias option to rename formula aliases if necessary
  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example. => currently there are no tests for bump-formula-pr
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

This PR adds an --update-alias to brew bump-formula-pr to updated the versioned alias pointing to a formula (e.g. node@12 => node), if the version bump makes it necessary to update said alias (e.g. bumping to node 13 needs an node@13 alias).

Without this change I usually run into issues when trying to bump v8 with brew bump-formula-pr, because every minor v8 update requires a rename of the (currently) v8@7.5 alias. Using brew bump-formula-pr for such a minor v8 version bump will fail with a audit error correctly complaining about the incorrect alias. Even worse: If you think you are clever and are doing the alias rename by yourself before running brew bump-formula-pr it will complete (audit passes), but it will result in a broken PR (without the alias rename) because brew bump-formula-pr does only commit changes to the formula itself atm and just does not commit your alias rename.

With this PR you could simple run brew bump-formula-pr --strict --update-alias v8 ... and it will notice the outdated alias, make the rename for you and also commits the renamed alias in addition to the formula changes for you. I've conservatively put it behind the --update-alias option now, but you might want to consider making it the default behavior later after enough testing.

This first commit contains the actual change to support --update-alias and the second commit is just a little refactor necessary to avoid brew style's Cyclomatic complexity for bump_formula_pr is too high. [77/75] error. I've left them separated for easier review, but I can squash them before merging.

+55 -25

0 comment

1 changed file

pr created time in a month

push eventchrmoritz/brew

Christian Moritz

commit sha 9fa30264648bb5a801ef1d484e6a271f9f2ad9ba

squash! bump-formula-pr: add update-alias option reduced cyclomatic complexity

view details

push time in a month

delete branch chrmoritz/homebrew-core

delete branch : node-13.1.2

delete time in a month

PR closed Homebrew/homebrew-core

node 13.1.2

Created with brew bump-formula-pr.

+2 -2

0 comment

2 changed files

chrmoritz

pr closed time in a month

create barnchchrmoritz/homebrew-core

branch : node-13.1.2

created branch time in a month

PR opened Homebrew/homebrew-core

node 13.1.2

Created with brew bump-formula-pr.

+2 -2

0 comment

2 changed files

pr created time in a month

push eventchrmoritz/brew

Christian Moritz

commit sha 78dbf0cfcce7b92ad04a4b4628481ec0c208a8e3

bump-formula-pr: add update-alias option

view details

push time in a month

push eventchrmoritz/brew

Chongyu Zhu

commit sha ba9dde9a4e384cb590718331d74e18da5e78786e

python_virtualenv_constants: upgrade virtualenv to 16.6.2

view details

Chongyu Zhu

commit sha 59b1d63bb039649e67846f6187c4d93f28711b54

Merge pull request #6295 from lembacon/virtualenv-16.6.2 python_virtualenv_constants: upgrade virtualenv to 16.6.2

view details

Christian Moritz

commit sha 1c39b24b60a075690108c733feef794e6685fabe

bump-formula-pr: add update-alias option

view details

push time in a month

pull request commentdenoland/deno

WIP build with cargo instead of tool/build.py

@ry No unfortunately not. I was just trying out the cargo based build from this PR an recognized the error from a too outdated clang. Locally I even build without sccache by commenting out the unimplemented!();.

ry

comment created time in a month

more