profile
viewpoint
Chris Kim chriskim06 @Blend Oakland, CA

chriskim06/dotfiles 1

A collection of dotfiles and other scripts

chriskim06/electron-inbox 1

A simple Electron app for Google Inbox

chriskim06/userscripts 1

This is a repository containing the userscripts that I have written

chriskim06/cli-experimental 0

Experimental Kubectl libraries and commands.

chriskim06/coc.nvim 0

Intellisense engine for vim8 & neovim, full language server protocol support as VSCode

chriskim06/coin-detail 0

The code for the coin detail skill

chriskim06/delve 0

Delve is a debugger for the Go programming language.

chriskim06/echo 0

A simple echo server to test building dockerfiles.

pull request commentkubernetes-sigs/krew

Add documentation for default index URI variable

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/krew/pull/669#" title="Author self-approved">chriskim06</a> To complete the pull request process, please assign corneliusweig after the PR has been reviewed. You can assign the PR to them by writing /assign @corneliusweig in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["corneliusweig"]} -->

chriskim06

comment created time in 14 hours

pull request commentkubernetes-sigs/krew-index

Add kubectl-env plugin

Please read the naming guide. This plug-in doesn't do what I would expect it to do despite the name "env". That's a sign you've chosen a generic yet vague name. Please consider renaming. /hold

almariah

comment created time in a day

pull request commentkubernetes-sigs/krew-index

Add kubectl-env plugin

/assign @corneliusweig

almariah

comment created time in 2 days

pull request commentkubernetes-sigs/krew-index

Add kubectl-env plugin

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/krew-index/pull/937#" title="Author self-approved">almariah</a> To complete the pull request process, please assign corneliusweig after the PR has been reviewed. You can assign the PR to them by writing /assign @corneliusweig in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["corneliusweig"]} -->

almariah

comment created time in 2 days

pull request commentkubernetes-sigs/krew-index

Add kubectl-env plugin

Welcome @almariah! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes-sigs/krew-index'>kubernetes-sigs/krew-index</a> 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation. <br><br>You can also check if kubernetes-sigs/krew-index has its own contribution guidelines. <br><br>You may want to refer to our testing guide if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:

almariah

comment created time in 2 days

PR opened kubernetes-sigs/krew-index

Add kubectl-env plugin

Add kubectl-env plugin

https://github.com/almariah/kubectl-env

+32 -0

0 comment

1 changed file

pr created time in 2 days

issue commentkubernetes-sigs/krew

Consider add Go Vet tool in the CI

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

Dentrax

comment created time in 2 days

push eventkubernetes-sigs/krew-index

Andrew Lavery

commit sha d938e1d3c6d9996dc52201c2f1a8302daf904d93

schemahero v0.11.3 (#936) Signed-off-by: Andrew Lavery <laverya@umich.edu>

view details

push time in 3 days

PR merged kubernetes-sigs/krew-index

Reviewers
schemahero v0.11.3 approved cncf-cla: yes lgtm size/S

<!--

PLUGIN DEVELOPERS: If you are submitting a new plugin

  • Make sure you read the Plugin Naming Guide: https://krew.sigs.k8s.io/docs/developer-guide/develop/naming-guide/
  • Verify you can install your plugin locally: kubectl krew install --manifest=[...] --archive=[...]

--> Yes, I will be moving to the krew releaser bot soon.

+7 -7

2 comments

1 changed file

laverya

pr closed time in 3 days

pull request commentkubernetes-sigs/krew-index

schemahero v0.11.3

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/krew-index/pull/936#issuecomment-733968366" title="Approved">ahmetb</a>, <a href="https://github.com/kubernetes-sigs/krew-index/pull/936#" title="Author self-approved">laverya</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

laverya

comment created time in 3 days

pull request commentkubernetes-sigs/krew-index

schemahero v0.11.3

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

laverya

comment created time in 3 days

PR opened kubernetes-sigs/krew-index

schemahero v0.11.3

<!--

PLUGIN DEVELOPERS: If you are submitting a new plugin

  • Make sure you read the Plugin Naming Guide: https://krew.sigs.k8s.io/docs/developer-guide/develop/naming-guide/
  • Verify you can install your plugin locally: kubectl krew install --manifest=[...] --archive=[...]

--> Yes, I will be moving to the krew releaser bot soon.

+7 -7

0 comment

1 changed file

pr created time in 3 days

startedchromedp/docker-headless-shell

started time in 3 days

push eventkubernetes-sigs/krew

Chris Kim

commit sha 9749c9e021e4c28342eae1dd28de7fd63269a426

Default index function (#668) * Add function for getting default index URI * Add variable in update command * Update pkg/index/util.go Co-authored-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com> * Add simple unit test for DefaultIndex function * Code review change Co-authored-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>

view details

push time in 3 days

PR merged kubernetes-sigs/krew

Default index function approved cncf-cla: yes lgtm size/M

Adding this based on the comment here https://github.com/kubernetes-sigs/krew/pull/666#discussion_r528472892. This reverts back constants.go so that it only has the constant values and adds a pkg/index/util.go that has the DefaultIndex function in it.

/assign @ahmetb /assign @corneliusweig

Related issue: #637 <!-- For proposed features, make sure there's an issue it's discussed first -->

+72 -17

5 comments

5 changed files

chriskim06

pr closed time in 3 days

push eventkubernetes-sigs/krew-index

krew-release-bot

commit sha e069c0b9392640e949c774fe7f3c6b69b2141e04

new version v2.2.5 of view-serviceaccount-kubeconfig (#935)

view details

push time in 3 days

PR merged kubernetes-sigs/krew-index

Reviewers
release new version v2.2.5 of view-serviceaccount-kubeconfig approved cncf-cla: yes lgtm size/S

hey krew-index team,

I am krew-release-bot, and I would like to open this PR to publish version v2.2.5 of view-serviceaccount-kubeconfig on behalf of @superbrothers.

Thanks, @krew-release-bot

+7 -7

2 comments

1 changed file

krew-release-bot

pr closed time in 3 days

pull request commentkubernetes-sigs/krew-index

release new version v2.2.5 of view-serviceaccount-kubeconfig

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/krew-index/pull/935#issuecomment-733695732" title="Approved">ahmetb</a>, <a href="https://github.com/kubernetes-sigs/krew-index/pull/935#" title="Author self-approved">krew-release-bot</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

krew-release-bot

comment created time in 3 days

pull request commentkubernetes-sigs/krew-index

release new version v2.2.5 of view-serviceaccount-kubeconfig

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

krew-release-bot

comment created time in 3 days

PR opened kubernetes-sigs/krew-index

release new version v2.2.5 of view-serviceaccount-kubeconfig

hey krew-index team,

I am krew-release-bot, and I would like to open this PR to publish version v2.2.5 of view-serviceaccount-kubeconfig on behalf of @superbrothers.

Thanks, @krew-release-bot

+7 -7

0 comment

1 changed file

pr created time in 3 days

pull request commentkubernetes-sigs/krew

Default index function

/lgtm Release the hold of you want to do the documentation in a separate PR.

chriskim06

comment created time in 3 days

Pull request review commentkubernetes-sigs/krew

Default index function

+// Copyright 2020 The Kubernetes Authors.+//+// Licensed under the Apache License, Version 2.0 (the "License");+// you may not use this file except in compliance with the License.+// You may obtain a copy of the License at+//+//      http://www.apache.org/licenses/LICENSE-2.0+//+// Unless required by applicable law or agreed to in writing, software+// distributed under the License is distributed on an "AS IS" BASIS,+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+// See the License for the specific language governing permissions and+// limitations under the License.++package index++import (+	"os"+	"testing"++	"sigs.k8s.io/krew/pkg/constants"+)++func TestDefaultIndex(t *testing.T) {+	if got := DefaultIndex(); got != constants.DefaultIndexURI {+		t.Errorf("expected DefaultIndex() to be %q; got=%q", constants.DefaultIndexURI, got)
		t.Errorf("DefaultIndex() = %q, want %q", got, constants.DefaultIndexURI)

Same below.

chriskim06

comment created time in 4 days

pull request commentkubernetes-sigs/krew

Default index function

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/krew/pull/668#issuecomment-733191896" title="Approved">ahmetb</a>, <a href="https://github.com/kubernetes-sigs/krew/pull/668#" title="Author self-approved">chriskim06</a>, <a href="https://github.com/kubernetes-sigs/krew/pull/668#pullrequestreview-537818881" title="Approved">corneliusweig</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

chriskim06

comment created time in 4 days

pull request commentkubernetes-sigs/krew

Default index function

/approve

I'm now thinking if this option is worth documenting somewhere. We have other options like $KREW_ROOT that also are not documented, maybe in the future.

chriskim06

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew

Default index function

+// Copyright 2020 The Kubernetes Authors.+//+// Licensed under the Apache License, Version 2.0 (the "License");+// you may not use this file except in compliance with the License.+// You may obtain a copy of the License at+//+//      http://www.apache.org/licenses/LICENSE-2.0+//+// Unless required by applicable law or agreed to in writing, software+// distributed under the License is distributed on an "AS IS" BASIS,+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+// See the License for the specific language governing permissions and+// limitations under the License.++package index++import (+	"os"++	"sigs.k8s.io/krew/pkg/constants"+)++func DefaultIndex() string {

a mini unit-test would be great for this.

chriskim06

comment created time in 4 days

issue commentkubernetes-sigs/krew

Does not work on Ubuntu

I’m suspecting of an old installation or corrupted index (due to possibly exiting in the middle of it)?

mabushey

comment created time in 4 days

pull request commentkubernetes-sigs/krew

Default index function

New changes are detected. LGTM label has been removed.

chriskim06

comment created time in 4 days

issue commentkubernetes-sigs/krew

Does not work on Ubuntu

Interesting. Can you reproduce this? Aside: how did you install krew?

mabushey

comment created time in 4 days

pull request commentkubernetes-sigs/krew

Default index function

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/krew/pull/668#" title="Author self-approved">chriskim06</a>, <a href="https://github.com/kubernetes-sigs/krew/pull/668#pullrequestreview-537818881" title="Approved">corneliusweig</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

chriskim06

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew

Default index function

+// Copyright 2019 The Kubernetes Authors.
// Copyright 2020 The Kubernetes Authors.
chriskim06

comment created time in 4 days

more