profile
viewpoint
Hugo Beauzée-Luyssen chouquette @videolabs Paris http://www.beauzee.fr

chouquette/medialibrary 5

Mirror repository - No PR will be reviewed

chouquette/coveraggregator 2

Cover profile aggregator for golang

3XX0/vlc-torrent 1

Torrent streaming implementation for VLC

chouquette/backtrace-rs 0

Backtraces in Rust

chouquette/cc-rs 0

Rust library for build scripts to compile C/C++ code into a Rust library

chouquette/faad2 0

Freeware Advanced Audio (AAC) Decoder faad2 mirror

push eventchouquette/medialibrary

Hugo Beauzée-Luyssen

commit sha ffaad75201e71b6b59b6bb8f1e9eac80df46c467

migration: Fix 26 to 27 migration on macOS refs #270

view details

Hugo Beauzée-Luyssen

commit sha 0f88f723e4a176789842b93f3caf844d91393fc8

MediaLibrary: Fix iOS detection refs #270

view details

push time in 5 days

PR closed videolabs/libspatialaudio

Adm renderer

Added an ADM renderer with support for Objects, DirectSpeaker, Binaural, and HOA inputs. Supports several ADM metadata parameters such as diffuseness, divergence, and channel locking.

The PointSourcePanner (Rec. ITU-R BS.2127-0) implements only the Polar processing path, not the Cartesian. If the metadata specifies Cartesian the coordinates are converted to polar and the Polar path is used.

Outputs can be stereo, binaural, quad, 5.x, and 7.x. If binaural output is selected then the libspatialaudio HOA engine is used for spatialisation.

+3818 -32

1 comment

30 changed files

peterStitt

pr closed time in 11 days

pull request commentvideolabs/libspatialaudio

Adm renderer

Superseeded by #24

peterStitt

comment created time in 11 days

push eventvideolabs/libspatialaudio

Peter Stitt

commit sha 70ef0b5beb3b46fb69ffdcaab9e9f2eca3a6fe6f

Added option to have position interpolate over a given duration of the next frame

view details

Peter Stitt

commit sha 22a541774b6a99e55ef9147f211ee576b3b65880

Updated the classes that use convolution internally to allow block sizes less than the max set at configuration

view details

Peter Stitt

commit sha 5d45aea11887d32ad04b67a005d9745c7cba7dff

Added Mono as a preset to the AmbisonicDecoder class so that shelf filtering is not applied in this case.

view details

Peter Stitt

commit sha 46364e6a0c00a668d4de41f89fe47a63e96d2dc4

Fixed loud audio when configuring AmbisonicBinauralizer with order 0

view details

Peter Stitt

commit sha 46e50b9cbff4d531658cb46fe726dd8fff6c90f4

Fixed a bug that caused an allocation error

view details

Peter Stitt

commit sha 3950ef32d9adeaab63efdfa4442ff6923b669a53

Added AddStream() method to BFormat

view details

Peter Stitt

commit sha 8d577d79525055fce8dfca8d849561f284f0258f

AmbisonicEncoder: use unsigned for nInterpSamples

view details

Peter Stitt

commit sha 9bf9f6db097c5ccf12a017f90a4ae83be9ca8c96

Added ProcessAccumul() method for CAmbisonicEncoder

view details

Peter Stitt

commit sha 06c48003590b646353790229187622b818004b0b

CMakeLists.txt: switch to c++14

view details

Peter Stitt

commit sha 8306cdc37818a208eb5362d08707dc225bd8d13d

Added a basic ADM renderer to handle Object, DirectSpeaker and HOA streams

view details

push time in 11 days

PR merged videolabs/libspatialaudio

Adm renderer (fixup)

Based on https://github.com/videolabs/libspatialaudio/pull/23

Just reworking commits messages and order, and fixing few warnings.

+3808 -29

0 comment

28 changed files

tguillem

pr closed time in 11 days

push eventchouquette/medialibrary

Hugo Beauzée-Luyssen

commit sha 09e707bcef2f27855dfd5c4ee6b10bce514327a8

Bump libvlcpp submodule

view details

push time in 16 days

push eventchouquette/medialibrary

Hugo Beauzée-Luyssen

commit sha 3c62c21263e83b463b7017d48f04eabba963fabc

CI: Bump images

view details

Jonas Mueller

commit sha 97677b25ad07a689837b8342aa5de3059d8fce3a

Add spec for extended M3U playlist Fix #266 Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

view details

push time in 16 days

PR closed videolan/vlc

Monika
+16 -57

1 comment

1 changed file

jitu0956

pr closed time in 24 days

PR closed videolan/vlc

Saroj

EEEE

+2 -55

1 comment

1 changed file

jitu0956

pr closed time in 24 days

push eventchouquette/medialibrary

Hugo Beauzée-Luyssen

commit sha c75f9d279d6d3f95ee121ec88f1fc0d19208f396

Media: Remove usages of real_last_played_date refs #268

view details

push time in a month

push eventchouquette/medialibrary

Hugo Beauzée-Luyssen

commit sha 5b6bd296f681953015c9228f3e20cc40fcc54364

Artist: Fix tracks ordering when sorting by albums Fix #265

view details

push time in a month

push eventchouquette/medialibrary

Hugo Beauzée-Luyssen

commit sha 12fde057a470946353eab4ebd204f26d9be15322

configure.ac: Bump copyright year

view details

push time in 2 months

push eventchouquette/medialibrary

Hugo Beauzée-Luyssen

commit sha e861a002686795139c9dd7af374c6e1af66af664

CI: Use rules instead of except/only

view details

push time in 2 months

push eventvideolabs/libmicrodns

Hugo Beauzée-Luyssen

commit sha deb7ed7bf05dc26802a0ca1987049b31405b8930

mdns: Fix getifaddrs fallback This primarily fix build & behavior on android which doesn't have getifaddrs

view details

push time in 2 months

created tagvideolabs/libmicrodns

tag0.2.0

Minimal mDNS resolver (and announcer) cross-platform library

created time in 2 months

push eventvideolabs/libmicrodns

Hugo Beauzée-Luyssen

commit sha d5936a49a4260e658b24178d2ae356a53cca3cf1

meson.build: Bump the soversion We changed a functions signature and added a new one

view details

Hugo Beauzée-Luyssen

commit sha b394b7280efcb350e827f7d6bce96c2d554686cb

meson.build: Bump version to 0.2.0

view details

push time in 2 months

push eventvideolabs/libmicrodns

Hugo Beauzée-Luyssen

commit sha 18db06925c3fcfc3c284ff81eacda18b1cc96362

mdns: ctx: Rename if_addr to intf_idx Since it always contains the interface index now

view details

Hugo Beauzée-Luyssen

commit sha 14b11550f1e724e594d0b6e75ad0892bc057fd9e

os_mcast_join: Rename mintf to intf_idx

view details

Hugo Beauzée-Luyssen

commit sha 5d47ff59dc1466c6094b9ae35d66e01f1755504d

compat: Remove multicast_if type It's always an unsigned integer, never a pointer

view details

Hugo Beauzée-Luyssen

commit sha 6f5daf60a100c9ee0581c9924cfbc099b7d761f7

compat: Fix joining multicast group using IP_ADD_MEMBERSHIP Fix #36

view details

Hugo Beauzée-Luyssen

commit sha 54644bcfdcda09d839c5d4f0a66682e0be0827aa

mdns: Fix invalid cast warning

view details

push time in 2 months

PR merged videolabs/libmicrodns

Fix multicast group joining for ipv4

When using IP_ADD_MEMBERSHIP we need to use the interface's address, not its index

+21 -21

0 comment

3 changed files

chouquette

pr closed time in 2 months

issue closedvideolabs/libmicrodns

Failure to initialize using IPv4 when MCAST_JOIN_GROUP is not available

When trying to join the multicast group using IP_ADD_MEMBERSHIP as a fallback for MCAST_JOIN_GROUP, we end up providing an invalid interface to ip_mreq::imr_interface which is an IN_ADDR in this case, as opposed to:

  • the interface index for IPv6 (when using both IP_ADD_MEMBERSHIP or MCAST_JOIN_GROUP)
  • The interface index when using IPv4 with MCAST_JOIN_GROUP

It's possible to quick & dirty fix this by ifdefing the win32 code and copy a different field (in a different loop), but it might be a better idea to provide both interface index & addresses.

Another option is to drop the fallback since MCAST_JOIN_GROUP is available since Vista (AFAICS)

closed time in 2 months

chouquette

push eventchouquette/libmicrodns

Hugo Beauzée-Luyssen

commit sha 4d500f0e7665b5e637b58ee8be5c608f1e56925f

compat: Remove multicast_if type It's always an unsigned integer, never a pointer

view details

Hugo Beauzée-Luyssen

commit sha 0db8767d3101e208f1fd7b5df7c0d07e836c1750

compat: Fix joining multicast group using IP_ADD_MEMBERSHIP Fix #36

view details

Hugo Beauzée-Luyssen

commit sha ebaee764e45493b97e3ffe18286d75c712323820

mdns: Fix invalid cast warning

view details

push time in 2 months

PR opened videolabs/libmicrodns

Fix multicast group joining for ipv4

When using IP_ADD_MEMBERSHIP we need to use the interface's address, not its index

+21 -21

0 comment

3 changed files

pr created time in 2 months

create barnchchouquette/libmicrodns

branch : fix_mcast_join_ipv4

created branch time in 2 months

issue openedvideolabs/libmicrodns

Failure to initialize using IPv4 when MCAST_JOIN_GROUP is not available

When trying to join the multicast group using IP_ADD_MEMBERSHIP as a fallback for MCAST_JOIN_GROUP, we end up providing an invalid interface to ip_mreq::imr_interface which is an IN_ADDR in this case, as opposed to:

  • the interface index for IPv6 (when using both IP_ADD_MEMBERSHIPorMCAST_JOIN_GROUP`)
  • The interface index when using IPv4 with MCAST_JOIN_GROUP

It's possible to quick & dirty fix this by ifdefing the win32 code and copy a different field (in a different loop), but it might be a better idea to provide both interface index & addresses.

Another option is to drop the fallback since MCAST_JOIN_GROUP is available since Vista (AFAICS)

created time in 2 months

push eventvideolabs/libmicrodns

Hugo Beauzée-Luyssen

commit sha 90803f18e91088d63e9d86b792891696fd9ed96e

examples: Fix announce callback

view details

Hugo Beauzée-Luyssen

commit sha 9a780077e85e9b9ad40bb10efa07c5863c167bb8

Update NEWS

view details

Hugo Beauzée-Luyssen

commit sha ea397d3aac5bc5cb19d66b78e36910debd115503

examples: Fix the announce example

view details

push time in 2 months

issue closedvideolabs/libmicrodns

IPV6 announcement fails on Linux

To reproduce, change the announce example to init libmicrodns with MDNS_ADDR_IPV6 instead of MDNS_ADDR_IPV4.

Binding the socket will fail with "invalid argument"

if (bind(ctx->conns[i].sock, (const struct sockaddr *) &ctx->addr, ss_len(&ctx->addr)) < 0)
                    return mdns_destroy(ctx), (MDNS_NETERR);

The socket is created for the correct address family (AF_INET6) and ss_len(&ctx->addr) matches sizeof(struct sockaddr_in6)

I'm trying to figure out what's wrong but so far not having any luck. If anyone has any ideas, let me know.

closed time in 2 months

rolznz

issue commentvideolabs/libmicrodns

IPV6 announcement fails on Linux

This should be fixed by #35

rolznz

comment created time in 2 months

push eventvideolabs/libmicrodns

Hugo Beauzée-Luyssen

commit sha 45a88deb513fa406a95d1b99b4aa00a5633c968f

mdns_serve: Invoke the callback early to send the initial announce

view details

Hugo Beauzée-Luyssen

commit sha fb7111d55df71e1673726a8a139a1a91634aa5a1

mdns_serve: Fix leak

view details

Hugo Beauzée-Luyssen

commit sha 7fe1a38600bd9d464e55eaab78ff1a81a37f24cc

mdns: is_interface_valuable: Constify input parameter

view details

Hugo Beauzée-Luyssen

commit sha bb28a10bd36844d20cdb40e673d2e05e4d06f160

mdns_resolve: Simplify address family assignment

view details

Hugo Beauzée-Luyssen

commit sha 8a9e59fe56d563c3def1dc764e4c07eb56075f3b

mdns: Probe the current interface family when assigning results Since we will soon handle multiple family and the parameter we were using will be removed

view details

Hugo Beauzée-Luyssen

commit sha d4567252dc6023ee4a28fa4c07398caaad647020

mdns: Replace mdns_ip struct by sockaddr_storage Since that's what the structure was containing anyway

view details

Hugo Beauzée-Luyssen

commit sha 120eaee861da6ffa35002363c0b883bc59d04500

mdns: Store the multicast address per-connection When we handle dual stack, we will need a different address depending on the IP version we're using

view details

Hugo Beauzée-Luyssen

commit sha 8cddfa783b4612bd278904653fd1a6964a0d1be7

mdns: Bind the socket with the interface address Not the multicast address

view details

Hugo Beauzée-Luyssen

commit sha 390c51259d404a50dc12dcf43d58c18a3ae87067

mdns: Rename mdns_ip to intf_addr Since that's what the field contains

view details

Hugo Beauzée-Luyssen

commit sha 461a65ee709c69d3d3aa77228659804d8ba63518

mdns: Use existing helpers to get protocol levels

view details

Hugo Beauzée-Luyssen

commit sha cd80fa309ac23c004b56a72abdff2cbb69de7116

utils: Add and use a lenght helper for sockaddr*

view details

Hugo Beauzée-Luyssen

commit sha 1117603de4d78e8d322a4cd8a66ef57f4cd9c550

mdns_init: Fix loopback enabling for ipv6 setsockopt was rejecting the argument when passed as an uint8_t, and the option needed to be adjusted when using an ipv6 socket

view details

Hugo Beauzée-Luyssen

commit sha 2c5de2459610a05067e3911f5b9536d2092b4a6e

mdns: Split counting interfaces in a separate function

view details

Hugo Beauzée-Luyssen

commit sha b7622a1db1fcb8ec910726e0805a8d12180f8b56

mdns: Do the entire interface filtering in the same function Instead of having a bit of local filtering duplicated, which could cause disparities between the 2 result sets

view details

Hugo Beauzée-Luyssen

commit sha 82e9f73c60cfdb1f97933815b4e254097306e100

mdns: Add support for multiple multicast addresses Which will help when we'll need to use the ipv4 and ipv6 ones simultaneously

view details

Hugo Beauzée-Luyssen

commit sha e7257d0f89e39fe64cb01586beaa8003dcb23eb7

mdns: Fix ipv6 interfaces filtering We are interested in link local interfaces so that we can use the scope_id field, and use it to specify which interface index we want to send multicast requests through

view details

Hugo Beauzée-Luyssen

commit sha df0c452acdcb2786869a02ff25b251700d12c317

mdns: Fix and simplify interface selection Providing the interface index (which is the integer returned by if_nametoindex for an IPV4 connection, and the content of sockaddr_in6.sin6_scope_id for an IPV6 connection) is enough. With this, we can remove the additional call to setsockopt(..., IP_MULTICAST_IF)

view details

Hugo Beauzée-Luyssen

commit sha 283196be2a6b3338d5bbaa0bf170ccd4a77086be

mdns: Fix interface index on win32 While IP_MULTICAST_IF used the index in network byte order, setsockopt with MCAST_JOIN_GROUP uses the index in host byte order

view details

Hugo Beauzée-Luyssen

commit sha b53a31b8073ff4f611eb811801272771e46100e3

mdns: Use the appropriate multicast address for the protocol Instead of the 1st which might be using a different protocol version

view details

Hugo Beauzée-Luyssen

commit sha a0fef457388ec30193a983dde33189384e086755

mdns: win32: Give up if the selected adapter doesn't have an address

view details

push time in 2 months

PR merged videolabs/libmicrodns

Implement dual stack support

This PR adds support for dual stack & adds some missing bits for announcing.

It's been tested on linux but doesn't build yet for win32. It also needs to be tested on android and ideally on a win32 virtual machine which is a good environment to check for regression when it comes to multiple adapters handling

+286 -155

1 comment

9 changed files

chouquette

pr closed time in 2 months

push eventchouquette/libmicrodns

Hugo Beauzée-Luyssen

commit sha a1f698a0939fe2eaa784ba473ef3f298344f8bdf

rr: Provide the packet length even when it's 0 Otherwise a 0 length TXT packet would be invalid

view details

Hugo Beauzée-Luyssen

commit sha 2c2004ff92ff070ae71d7e34fddcc532e69b4b11

mdns: Expose an announce type to the announce callback And allow the application to explicitely require an initial announce packet. We now also expose a goodbye announce type, in order to implement clean shutdown, and not wait for the TTL to expire until our services are considered gone

view details

push time in 2 months

push eventchouquette/libmicrodns

Hugo Beauzée-Luyssen

commit sha b29402fa9c76ef29925bee27acbdcddd9bd1ece9

mdns: Instruct the application to send goodbye packets So that we can have a clean shutdown, and not wait for the TTL to expire until our services are considered gone

view details

Hugo Beauzée-Luyssen

commit sha d061b8ca678d00ca070318585560f59c31c36972

rr: Provide the packet length even when it's 0 Otherwise a 0 length TXT packet would be invalid

view details

push time in 2 months

push eventchouquette/libmicrodns

Hugo Beauzée-Luyssen

commit sha 5555e675358d03d96655e3519d2660c777109c13

mdns: announce: Let the application filter its service types There is no easy way to support multiple service types otherwise.

view details

Hugo Beauzée-Luyssen

commit sha 6b619d5d0f6ad7d9523b76e73c598b003a89e262

mdns: Don't pass mdns_recv return to the announce callback mdns_recv returns -1 on error and 0 on success, but we don't invoke the callback when mdns_recv fails, so we were passing a useless parameter always equal to 0.

view details

push time in 2 months

push eventchouquette/libmicrodns

Hugo Beauzée-Luyssen

commit sha 77c78fe5703f42f41ac38fbc4bd4b748f929e32a

meson.build: Bump version Since the API semantic changed a bit

view details

push time in 2 months

push eventchouquette/libmicrodns

Jean-Baptiste Kempf

commit sha 7407a9380b9712bba43729edea97d0cd51d7b136

Fix copyright from vlc authors

view details

Hugo Beauzée-Luyssen

commit sha 32906fe1df1c1a72f77b79a6eb4b8304376e2dae

mdns_serve: Invoke the callback early to send the initial announce

view details

Hugo Beauzée-Luyssen

commit sha adf41b28fb0a488c0441b7eb36e9dd14ba1d891a

mdns_serve: Fix leak

view details

Hugo Beauzée-Luyssen

commit sha 7074c4818c6c2718b30da792d60af915077e0b2e

mdns: is_interface_valuable: Constify input parameter

view details

Hugo Beauzée-Luyssen

commit sha 9b390d44f298723a03b76eac519b1da2815578d6

mdns_resolve: Simplify address family assignment

view details

Hugo Beauzée-Luyssen

commit sha be5062bc69f93e2cfc07409e5157c67d141e0122

mdns: Probe the current interface family when assigning results Since we will soon handle multiple family and the parameter we were using will be removed

view details

Hugo Beauzée-Luyssen

commit sha 1151c99258d851634e9dbd3100fb788c318d8dea

mdns: Replace mdns_ip struct by sockaddr_storage Since that's what the structure was containing anyway

view details

Hugo Beauzée-Luyssen

commit sha dbb1c5a46f9cc563f8b2ae835cbfd645737e3197

mdns: Store the multicast address per-connection When we handle dual stack, we will need a different address depending on the IP version we're using

view details

Hugo Beauzée-Luyssen

commit sha b2e540a7c2cba0d9af61fe2bab92768ce1097b06

mdns: Bind the socket with the interface address Not the multicast address

view details

Hugo Beauzée-Luyssen

commit sha 140a4907e9fdb89ce292c9f854cd3f894998931c

mdns: Rename mdns_ip to intf_addr Since that's what the field contains

view details

Hugo Beauzée-Luyssen

commit sha ff3dc986c0c06b7a0690575dda6e3f0bb151bfae

mdns: Use existing helpers to get protocol levels

view details

Hugo Beauzée-Luyssen

commit sha 994da59048da593447dc77bda2e9fbd7139bcc9b

utils: Add and use a lenght helper for sockaddr*

view details

Hugo Beauzée-Luyssen

commit sha d360f64eb35565581332605c92706aa2f7d13dee

mdns_init: Fix loopback enabling for ipv6 setsockopt was rejecting the argument when passed as an uint8_t, and the option needed to be adjusted when using an ipv6 socket

view details

Hugo Beauzée-Luyssen

commit sha b05e67fc287d0ad639869b264928efe0eee6fad6

mdns: Split counting interfaces in a separate function

view details

Hugo Beauzée-Luyssen

commit sha 7c00a91318ac519d4b25d37aba809cb5614647e2

mdns: Do the entire interface filtering in the same function Instead of having a bit of local filtering duplicated, which could cause disparities between the 2 result sets

view details

Hugo Beauzée-Luyssen

commit sha 3c833c5b6416fdf381ad8361f9234559d76b9356

mdns: Add support for multiple multicast addresses Which will help when we'll need to use the ipv4 and ipv6 ones simultaneously

view details

Hugo Beauzée-Luyssen

commit sha 72210fb6d5cb2fadb9eaadcac992c11f5f234d07

mdns: Fix ipv6 interfaces filtering We are interested in link local interfaces so that we can use the scope_id field, and use it to specify which interface index we want to send multicast requests through

view details

Hugo Beauzée-Luyssen

commit sha 698519c953e38068ea08153b1cb83140811dc15c

mdns: Fix and simplify interface selection Providing the interface index (which is the integer returned by if_nametoindex for an IPV4 connection, and the content of sockaddr_in6.sin6_scope_id for an IPV6 connection) is enough. With this, we can remove the additional call to setsockopt(..., IP_MULTICAST_IF)

view details

Hugo Beauzée-Luyssen

commit sha 08c204c3c66fcc3ee44814e0ab7f92408d0f0aff

mdns: Fix interface index on win32 While IP_MULTICAST_IF used the index in network byte order, setsockopt with MCAST_JOIN_GROUP uses the index in host byte order

view details

Hugo Beauzée-Luyssen

commit sha f55a3aad3a8793536e92b27e1e2f370e3a5a77c2

mdns: Use the appropriate multicast address for the protocol Instead of the 1st which might be using a different protocol version

view details

push time in 2 months

push eventchouquette/libmicrodns

Hugo Beauzée-Luyssen

commit sha 71e008706261086f4a4894278d68393492d62e76

mdns: Use the appropriate multicast address for the protocol Instead of the 1st which might be using a different protocol version

view details

Hugo Beauzée-Luyssen

commit sha 97b1ba8355a8e28d01c4ef4e3a025ec402d49745

mdns: win32: Give up if the selected adapter doesn't have an address

view details

Hugo Beauzée-Luyssen

commit sha 4b2718cfd0fd1100d6c27eaf818bcd720b01f7fc

mdns: win32: Fix interface filtering

view details

Hugo Beauzée-Luyssen

commit sha c30f2b02d3f944e28767d58d3cec5976742fc934

mdns: Share bind() code with win32

view details

Hugo Beauzée-Luyssen

commit sha 1b4b07eb259d650c598e5e22b381efa311a7367c

Add dual stack support We now can pass NULL instead of an IPV4/IPV6 address to use both

view details

push time in 2 months

Pull request review commentvideolabs/libmicrodns

Dual stack

 mdns_resolve(struct mdns_ctx *ctx, const char *addr, unsigned short port)         struct sockaddr_storage *mcast_addrs = NULL;         size_t i;         int status;+        int family;          sprintf(buf, "%hu", port);         memset(&hints, 0, sizeof(hints));-        hints.ai_family = AF_UNSPEC;         hints.ai_socktype = SOCK_DGRAM;         hints.ai_flags = AI_NUMERICHOST | AI_NUMERICSERV;-        errno = getaddrinfo(addr, buf, &hints, &res);-        if (errno != 0)++        if (addr == NULL) {+            family = AF_UNSPEC;+            hints.ai_family = family;+            /* First, get the ipv4 multicast address info */+            errno = getaddrinfo(MDNS_ADDR_IPV4, buf, &hints, &res);+            if (errno != 0)+                    return (MDNS_LKPERR);

I was expecting some issues with a getaddrinfo() failure, I tried disabling ipv6 entirely on my system, getaddrinfo() appears to be returning some valid records anyway.

However, at a later stage when the interfaces are probed, they won't be ipv4/6 enabled and won't be taken into account (https://github.com/videolabs/libmicrodns/blob/6e96f538d3f99e452194e8711b05f88d9b966d72/src/mdns.c#L97) If dual stack is enabled, it will use the other protocol, if the user explicitely requested a protocol version but they don't have any adapter using that protocol, it will gracefully fail to initialize

TL;DR I think the current code is ok

chouquette

comment created time in 2 months

PullRequestReviewEvent

push eventchouquette/libmicrodns

Hugo Beauzée-Luyssen

commit sha 24610da6f36c4f2f22ca1090d0c1f168177a7145

mdns: Fix interface index on win32 While IP_MULTICAST_IF used the index in network byte order, setsockopt with MCAST_JOIN_GROUP uses the index in host byte order

view details

Hugo Beauzée-Luyssen

commit sha 814b01c7b727759a291c6c6730b4f453d872947e

mdns: Use the appropriate multicast address for the protocol Instead of the 1st which might be using a different protocol version

view details

Hugo Beauzée-Luyssen

commit sha 6f849b052f3dd732a48aa1f0fdead3a9f6f4ae06

mdns: win32: Give up if the selected adapter doesn't have an address

view details

Hugo Beauzée-Luyssen

commit sha ae4246ecfdf3610c5b4ab4553ec56a79bdd2e229

mdns: win32: Fix interface filtering

view details

Hugo Beauzée-Luyssen

commit sha 678a428945939c9d0960afaf94ccc01fc8851d41

mdns: Share bind() code with win32

view details

Hugo Beauzée-Luyssen

commit sha 6e96f538d3f99e452194e8711b05f88d9b966d72

Add dual stack support We now can pass NULL instead of an IPV4/IPV6 address to use both

view details

push time in 2 months

Pull request review commentvideolabs/libmicrodns

Dual stack

 mdns_resolve(struct mdns_ctx *ctx, const char *addr, unsigned short port)         struct sockaddr_storage *mcast_addrs = NULL;         size_t i;         int status;+        int family;          sprintf(buf, "%hu", port);         memset(&hints, 0, sizeof(hints));-        hints.ai_family = AF_UNSPEC;         hints.ai_socktype = SOCK_DGRAM;         hints.ai_flags = AI_NUMERICHOST | AI_NUMERICSERV;-        errno = getaddrinfo(addr, buf, &hints, &res);-        if (errno != 0)++        if (addr == NULL) {+            family = AF_UNSPEC;+            hints.ai_family = family;+            /* First, get the ipv4 multicast address info */+            errno = getaddrinfo(MDNS_ADDR_IPV4, buf, &hints, &res);+            if (errno != 0)+                    return (MDNS_LKPERR);

That's a valid point. I'll fix this once I'm done with windows fixes

chouquette

comment created time in 2 months

PullRequestReviewEvent

push eventchouquette/libmicrodns

Hugo Beauzée-Luyssen

commit sha 4004ced347a6e975fc5b7b74c066cded02bf9532

mdns: Add support for multiple multicast addresses Which will help when we'll need to use the ipv4 and ipv6 ones simultaneously

view details

Hugo Beauzée-Luyssen

commit sha b289acfa8068a582859c8df5aa41bdaef9dc80a7

mdns: Fix ipv6 interfaces filtering We are interested in link local interfaces so that we can use the scope_id field, and use it to specify which interface index we want to send multicast requests through

view details

Hugo Beauzée-Luyssen

commit sha f05281ce6fd4af59ded25df93762f0db2537f4f1

mdns: Fix and simplify interface selection Providing the interface index (which is the integer returned by if_nametoindex for an IPV4 connection, and the content of sockaddr_in6.sin6_scope_id for an IPV6 connection) is enough. With this, we can remove the additional call to setsockopt(..., IP_MULTICAST_IF)

view details

Hugo Beauzée-Luyssen

commit sha 040ee3700ef156d56b09bb7d6d84d7649f579283

mdns: Use the appropriate multicast address for the protocol Instead of the 1st which might be using a different protocol version

view details

Hugo Beauzée-Luyssen

commit sha 812648a0c6ac269d35dfb6079721a3de13e70d41

mdns: Share bind() code with win32

view details

Hugo Beauzée-Luyssen

commit sha 59105c714fb7cad9f64b16aabc1a33fcd63684ad

Add dual stack support We now can pass NULL instead of an IPV4/IPV6 address to use both

view details

push time in 2 months

PR opened videolabs/libmicrodns

Dual stack

This PR adds support for dual stack & adds some missing bits for announcing.

It's been tested on linux but doesn't build yet for win32. It also needs to be tested on android and ideally on a win32 virtual machine which is a good environment to check for regression when it comes to multiple adapters handling

+155 -105

0 comment

7 changed files

pr created time in 2 months

create barnchchouquette/libmicrodns

branch : dual_stack

created branch time in 2 months

push eventchouquette/medialibrary

Hugo Beauzée-Luyssen

commit sha b29ede38e58c5df699d15b261bd0142471ab6575

FsDiscoverer: Remove outdated comment

view details

Hugo Beauzée-Luyssen

commit sha c10e7b2f2b747cd2ae28cdb73d724d2074af39ab

FsDiscoverer: Pass a boolean to flag root folders So we can have a different strategy when discovering a root folder or a subfolder

view details

Hugo Beauzée-Luyssen

commit sha b208f5b7f0e7981efbc779018d5ae7f117f331d2

FsDiscoverer: Refine behavior for removable devices Don't delete a folder stored in a removable device if the root folder can't be read. This is likely to be because the device was just mounted and is not ready to be read from. This is preventing any folder I indexed from my NAS to be removed when I power it on: MediaLibrary.cpp:2715 onDeviceMounted Device doop changed presence state: 0 -> 1 [...] DiscovererWorker.cpp:527 runReloadDevice Reloading entrypoint on mounted device: smb://192.168.0.101:445/.../ FsDiscoverer.cpp:355 checkFolder Failed to browse smb://192.168.0.101:445/.../: Failed to browse network directory: Unknown error: Input/output error FsDiscoverer.cpp:172 checkRemovedDevices The device containing smb://192.168.0.101:445/.../ is removable. Refreshing device cache... [...] MediaLibrary.cpp:870 deleteFolder deleting folder smb://192.168.0.101:445/.../

view details

push time in 2 months

push eventchouquette/medialibrary

Hugo Beauzée-Luyssen

commit sha 74ddc3b5a220d8a264d06495833ca8d0c452a405

sqlite: Connection: Fix comment

view details

Hugo Beauzée-Luyssen

commit sha 2eea743d42b94b4151cbc91fd436bc75948b9a81

sqlite: Connection: Privatize foreign key & recursive triggers togglers

view details

Hugo Beauzée-Luyssen

commit sha 1ae81dccc220c16ee3ea9a510cabe0545509b8f5

sqlite: Connection: Return early when the connection already exists

view details

Hugo Beauzée-Luyssen

commit sha 4d81e1883be37144ebf543de824ef045ea3f60c1

sqlite: Connection: Reindent after last change

view details

Hugo Beauzée-Luyssen

commit sha 213d48a4490cb0b1c71c9d2db46bb0d3cdfbb5d1

sqlite: Connection: Remove blank line

view details

Hugo Beauzée-Luyssen

commit sha e402e29f7fe52a2b136e823b9b6cdaa04e46f3a7

sqlite: Connection: Don't use thread_local when building with gcc-mingw Fix #264

view details

Hugo Beauzée-Luyssen

commit sha 0565810630634a7aeb6560e4a26dd2838cae5a43

CI: Bump win32 image to use a GCC based toolchain

view details

push time in 2 months

PR closed videolan/vlc

Added avs2 and avs3 decoders.

Added avs2 and avs3 decoders for VLC.

+450 -12

1 comment

14 changed files

xatabhk

pr closed time in 2 months

pull request commentvideolan/vlc

Added avs2 and avs3 decoders.

Hi,

This looks like a very decent MR, but this is a mirror and nothing gets reviewed here. Please refer to https://wiki.videolan.org/Sending_Patches_VLC/

xatabhk

comment created time in 2 months

more