profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/chienandalu/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
David Vidal chienandalu Tecnativa Madrid

chienandalu/doodba-devel 0

Officially supported scaffolding template for your Doodba projects

chienandalu/maintainer-tools 0

Odoo Maintainers Tools for OCA members which evaluate and maintain repositories.

chienandalu/OCB 0

Odoo Community Backports

chienandalu/project 0

Odoo Project Management and Services Company Addons

chienandalu/stock-logistics-workflow 0

Odoo Stock, Workflow and Organization

chienandalu/test 0

learning in progress...

Tecnativa/field-service 0

Field Service Management

push eventTecnativa/delivery-carrier

david

commit sha f652226441e525315f85b1b87f541166357f05ea

[ADD] delivery_schenker: New module TT31005

view details

push time in a day

pull request commentOCA/rma

[13.0][FIX] rma: return location

I just added an extra fix

chienandalu

comment created time in a day

push eventTecnativa/rma

david

commit sha 89595be62c7d17fa81a973c25eac45df3479b762

[FIX] rma: default team and responsible Having a default responsible value as it was defined doesn't behave right when the user it's a portal one or the petition comes from a sudo(). Also, by design it was expected to have a default team if it wasn't defined, but as it was implemented that wasn't possible. TT32056

view details

push time in a day

Pull request review commentOCA/margin-analysis

[12.0][IMP] sale_margin_delivered: No compute margin delivered fields for no delivered lines

 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). {     "name": "Sale Margin Delivered",-    "version": "12.0.1.0.1",+    "version": "12.0.1.0.2",

As there's a migration script, it's force to ensure the right path

sergio-teruel

comment created time in a day

PullRequestReviewEvent

PR opened OCA/social

[FIX] mass_mailing_partner: wrong company implementation

FW of #778

See issue https://github.com/OCA/social/issues/776

cc @Tecnativa

please review @ernestotejeda @ivantodorovich @pedrobaeza

+7 -18

0 comment

4 changed files

pr created time in a day

PR opened OCA/rma

[13.0][FIX] rma: return location

The new implementation wasn't getting the value set in the wizard.

cc @Tecnativa TT32046

ping @ernestotejeda @pedrobaeza

+2 -5

0 comment

1 changed file

pr created time in a day

create barnchTecnativa/rma

branch : 13.0-fix-rma-return-location

created branch time in a day

PullRequestReviewEvent

Pull request review commentOCA/web

[13.0][ADD] web_time_range_menu_custom

+==========================+Web Time Range Menu Custom+==========================++.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!+   !! This file is generated by oca-gen-addon-readme !!+   !! changes will be overwritten.                   !!+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!++.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png+    :target: https://odoo-community.org/page/development-status+    :alt: Beta+.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png+    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html+    :alt: License: AGPL-3+.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fweb-lightgray.png?logo=github+    :target: https://github.com/OCA/web/tree/v13/web_time_range_menu_custom+    :alt: OCA/web+.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png+    :target: https://translation.odoo-community.org/projects/web-v13/web-v13-web_time_range_menu_custom+    :alt: Translate me on Weblate+.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png+    :target: https://runbot.odoo-community.org/runbot/162/v13+    :alt: Try me on Runbot++|badge1| |badge2| |badge3| |badge4| |badge5| ++Extend period and comparison period options for the time range menu adding a new option called "Custom Period".

It'd be nice to have a brief usage section and an screenshot

Tardo

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentOCA/e-commerce

[13.0][IMP]website_sale_hide_empty_category improvements

 class ProductPublicCategory(models.Model):     _inherit = "product.public.category" -    has_product_recursive = fields.Boolean(+    count_product_recursive = fields.Integer(         string="This category or one of its children has products",-        compute="_compute_has_product_recursive",+        compute="_compute_count_product_recursive",     ) -    @api.depends("product_tmpl_ids", "child_id.has_product_recursive")-    def _compute_has_product_recursive(self):+    @api.depends("product_tmpl_ids", "child_id.count_product_recursive")+    def _compute_count_product_recursive(self):         for category in self:-            category.has_product_recursive = bool(-                category.product_tmpl_ids-                or any(child.has_product_recursive for child in category.child_id)-            )+            category.count_product_recursive = len(+                category.product_tmpl_ids.filtered("is_published")

I was going to propose that, but I think the two fields can coexist in this module. You can compute the two fields altogether and let the boolean be set by the counter (bool(count_result)). The compute doesn't return anything anyway, so you can add that behavior.

So the changes would be to keep everything as it is now adding the counter field to the compute.

Then you can just add the custom view extension, as it's not going to harm anything pre-existing

Maybe for v14 (you can put it on the roadmap) the module can be split on two:

  • The one that renders the count
  • The one that hides the category depending on that count.
Rad0van

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentOCA/e-commerce

[13.0][IMP]website_sale_hide_empty_category improvements

 class ProductPublicCategory(models.Model):     _inherit = "product.public.category" -    has_product_recursive = fields.Boolean(+    count_product_recursive = fields.Integer(         string="This category or one of its children has products",-        compute="_compute_has_product_recursive",+        compute="_compute_count_product_recursive",     ) -    @api.depends("product_tmpl_ids", "child_id.has_product_recursive")-    def _compute_has_product_recursive(self):+    @api.depends("product_tmpl_ids", "child_id.count_product_recursive")+    def _compute_count_product_recursive(self):         for category in self:-            category.has_product_recursive = bool(-                category.product_tmpl_ids-                or any(child.has_product_recursive for child in category.child_id)-            )+            category.count_product_recursive = len(+                category.product_tmpl_ids.filtered("is_published")

I think it would be less disruptive to just add the product counter as a complementary field. Keep in mind that custom extensions could be broken removing a field just in the middle of a version. The same goes with the views. Custom themes could rely on the current xml architecture, and no ecommerce holder will be happy when a 500 raises after updating the module.

You can add some migration notes anyway to remove the boolean in the next version.

Rad0van

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

PR opened OCA/social

[13.0][FIX] mass_mailing_partner: wrong company implementation

FW of #777

See issue https://github.com/OCA/social/issues/776

cc @Tecnativa

please review @ernestotejeda @ivantodorovich @pedrobaeza

+7 -18

0 comment

4 changed files

pr created time in 2 days

push eventTecnativa/delivery-carrier

david

commit sha 7ec7909ca5e249ae5e93b0586ef3a7953a61cb21

[ADD] delivery_schenker: New module TT31005

view details

push time in 2 days

Pull request review commentOCA/delivery-carrier

[13.0][ADD] delivery_local_pickup: Adds a local pickup carrier

+# Copyright 2021 Tecnativa - Víctor Martínez+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).+from odoo import _, fields, models+++class DeliveryCarrier(models.Model):+    _inherit = "delivery.carrier"++    delivery_type = fields.Selection(selection_add=[("local_pickup", "Local pickup")])+    local_address_id = fields.Many2one(+        comodel_name="res.partner", string="Local address"+    )++    def local_pickup_send_shipping(self, pickings):+        return [self.local_pickup_create_shipping(p) for p in pickings]++    def local_pickup_create_shipping(self, picking):+        return {"exact_price": False, "tracking_number": _("Local pickup")}

I'd go for a picking name plus carrier name. For example, for the picking WH/OUT/0001 and the carrier name Store Pickup we would get something like: "Your tracking reference is WH/OUT/0001 (Store Pickup)"

Which way more informative, don't you think?

victoralmau

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentOCA/social

[FIX] mass_mailing_partner: wrong company implementation

Ok, done

chienandalu

comment created time in 2 days

push eventTecnativa/social

david

commit sha e9c982882f683c9cbe379d0c519ecdf9c39ec744

[FIX] mass_mailing_partner: wrong company implementation See issue https://github.com/OCA/social/issues/776

view details

push time in 2 days

pull request commentOCA/social

[FIX] mass_mailing_partner: wrong company implementation

Well, all the mass_mailing stuff is quite company agnostic

chienandalu

comment created time in 2 days

Pull request review commentOCA/social

[FIX] mass_mailing_partner: wrong company implementation

 def _prepare_partner(self):             'email': self.email,             'country_id': self.country_id.id,             'title': self.title_id.id,-            'company_id': self._get_company(),+            'company_id': self.company_name,

oops, yes :sweat_smile:

chienandalu

comment created time in 2 days

PullRequestReviewEvent