profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/cassi10/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

issue closedresponsively-org/responsively-app

CLI domains with none or one character after . route to about:blank

🐞 bug report

✍️ Description

This is on Windows. Not sure about other OS's.

When starting Responsively through CLI command the address localhost, localhost.c, google, google.a route to about:blank instead. However, google.aa or localhost.com go to the specified route.

🕵🏼‍♂️ Is this a regression?

Unknown, not tested. I assume this began when the feature to open through CLI was added.

🔬 Minimal Reproduction

Open Powershell or cmd. Run command ResponsivelyApp.exe "localhost" or "google" or "google.a". Wait for it to boot.

🌍 Your Environment

<!-- Press Ctrl/Cmd + F1 and paste it here. --> <pre><code> Version: 0.17.0 Electron: 9.3.1 Chrome: 83.0.4103.122 Node.js: 12.14.1 V8: 8.3.110.13-electron.0 OS: Windows_NT x64 10.0.19042 </code></pre>

🔥 Exception or Error or Screenshot

I see no errors.

EDIT

I believe the cause of the problem is the isURL (this line exactly) function from the validator module. It seems you need the require_tld: false option to allow URL's like localhost and google to pass.

closed time in a month

cassi10

issue commentresponsively-org/responsively-app

CLI domains with none or one character after . route to about:blank

Yep, that PR seems to fix this issue. Thanks!

cassi10

comment created time in a month

issue openedresponsively-org/responsively-app

CLI domains with none or one character after . route to about:blank

🐞 bug report

✍️ Description

This is on Windows. Not sure about other OS's.

When starting Responsively through CLI command the address localhost, localhost.c, google, google.a route to about:blank instead. However, google.aa or localhost.com go to the specified route.

🕵🏼‍♂️ Is this a regression?

Unknown, not tested. I assume this began when the feature to open through CLI was added.

🔬 Minimal Reproduction

Open Powershell or cmd. Run command ResponsivelyApp.exe "localhost" or "google" or "google.a". Wait for it to boot.

🌍 Your Environment

<!-- Press Ctrl/Cmd + F1 and paste it here. --> <pre><code> Version: 0.17.0 Electron: 9.3.1 Chrome: 83.0.4103.122 Node.js: 12.14.1 V8: 8.3.110.13-electron.0 OS: Windows_NT x64 10.0.19042 </code></pre>

🔥 Exception or Error or Screenshot

I see no errors.

created time in a month