profile
viewpoint
Brandon Waterloo [MSFT] bwateratmsft @Microsoft https://www.microsoft.com Developer @ Microsoft

bwateratmsft/GrblJog 1

Jog controller for Grbl machines

bwateratmsft/acr-build-helloworld-node 0

Sample Node.js application for use in demonstrating Azure Container Registry Build.

bwateratmsft/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

bwateratmsft/docker-modem 0

Docker Remote API network stack driver.

bwateratmsft/dockerode 0

Docker + Node = Dockerode (Node.js module for Docker's Remote API)

bwateratmsft/microsoft.github.io 0

Microsoft on GitHub

bwateratmsft/vscode-docker 0

Docker extension for VS Code.

bwateratmsft/vscode-docker-explorer 0

Docker Explorer for Visual Studio Code

bwateratmsft/vscode-docs 0

Public documentation for Visual Studio Code

issue commentmicrosoft/vscode-docker

There is a transient error in Docker view before switching to the local Docker assets

This is probably a consequence of #2205

v-ruizh

comment created time in 17 days

issue commentmicrosoft/vscode-docker

Remote Host SSL Error on Windows 7

Pageant should work as an SSH agent; you will need to set the environment variable SSH_AUTH_SOCK = pageant, more on that here. Can you try out that guide and let us know if things work with Pageant?

Also, the Remote - Containers extension may have a command to attach without using the Docker extension's explorer view--I believe their extension only uses the Docker CLI, no Dockerode (this, agent auth may not be necessary). I'm away from my computer and not able to check at the immediate moment.

calee88

comment created time in 17 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha 3415f217c5399de8cd4056245a889e8920926955

Change how tree init errors are caught (#2205)

view details

push time in 17 days

delete branch microsoft/vscode-docker

delete branch : bmw/error

delete time in 17 days

PR merged microsoft/vscode-docker

Change how tree init errors are caught

Fixes #2204. I don't think the error is widespread enough to warrant another servicing release; only about .1%.

+73 -76

0 comment

1 changed file

bwateratmsft

pr closed time in 17 days

issue closedmicrosoft/vscode-docker

Extension activation error: "No such file or directory, open ..."

I'm seeing some activation failures, ~.1% failure rate. The overwhelming majority of these failures happen on Windows but there are results for both Linux and Mac.

Error: ENOENT: no such file or directory, open '<REDACTED: user-file-path>' Stack: Object.openSync fs.js:447:3\nObject.func asar.js:140:31\nObject.func [as openSync] asar.js:140:31

closed time in 17 days

bwateratmsft

PR opened microsoft/vscode-docker

Reviewers
Change how tree init errors are caught

Fixes #2204. I don't think the error is widespread enough to warrant another servicing release; only about .1%.

+73 -76

0 comment

1 changed file

pr created time in 17 days

issue commentmicrosoft/vscode-docker

Extension activation error: "No such file or directory, open ..."

I have a theory. The error is not really new, but it used to happen during context init, now happens during activation. The constructor for Dockerode also used to be in context init but is now in activation.

If DOCKER_CERT_PATH is set, docker-modem tries to open ca.pem, cert.pem, and key.pem. This will fail with the error message we see. Additionally, nearly all instances of this error have a host source of env, strengthening this theory.

What I'm not sure about is why almost all of the errors happen on Windows. :shrug:

bwateratmsft

comment created time in 17 days

create barnchmicrosoft/vscode-docker

branch : bmw/error

created branch time in 17 days

issue commentmicrosoft/vscode-docker

Extension activation error: "No such file or directory, open ..."

This looks similar to some older VSCode issues, e.g. https://github.com/microsoft/vscode/issues/78384.

bwateratmsft

comment created time in 17 days

issue openedmicrosoft/vscode-docker

Extension activation error: "No such file or directory, open ..."

I'm seeing some activation failures, ~.1% failure rate. The overwhelming majority of these failures happen on Windows but there are results for both Linux and Mac.

Error: ENOENT: no such file or directory, open '<REDACTED: user-file-path>' Stack: Object.openSync fs.js:447:3\nObject.func asar.js:140:31\nObject.func [as openSync] asar.js:140:31

created time in 17 days

PR opened microsoft/vscode-docker

Bump version, changelog, notices for 1.5.0

This PR will update the changelog, notices, etc. for 1.5.0. Assuming no changes are made to package-lock.json package versions before release, NOTICE.html is up to date. Likely, additional things will need to be added to CHANGELOG.md.

+8216 -23603

0 comment

4 changed files

pr created time in 17 days

create barnchmicrosoft/vscode-docker

branch : bmw/1.5.0

created branch time in 17 days

push eventbwateratmsft/vscode-docs

Brandon Waterloo [MSFT]

commit sha 9645338d88437bc7e8967578c39a289750fc0c84

Update docs about setting

view details

push time in 17 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha 6870f8e69b88c2bc0ae23bc89006537bc305cc12

Build task validation for .NET

view details

push time in 17 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha 219950181fb26b8b1a4195a8e3082bfd658fd107

Remove unnecessary code for windows versions

view details

push time in 17 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha 5b9bea0af767a46326d17b43f46e58829782ed60

Implement netcore scaffolding info

view details

Brandon Waterloo [MSFT]

commit sha baac3d9fbc9a14efdc28db297042dd893053a2fb

Implement java info gathering phase

view details

push time in 17 days

issue commentmicrosoft/vscode

CustomExecution2 Feedback: expose variable resolvers

This should work for the Docker extension. Would it be possible to make it object-recursive? Otherwise we can pretty easily deal with the recursion ourselves.

bwateratmsft

comment created time in 17 days

issue closedmicrosoft/vscode-docker

Configuration property descriptions are garbled

Version: 1.47.3 Commit: 91899dcef7b8110878ea59626991a18c8a6a1b3e Date: 2020-07-23T13:08:29.692Z (4 days ago) Electron: 7.3.2 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Darwin x64 19.6.0 Docker extension 1.41.1

image

Note descriptions for configuration properties show localization keys instead of expected information

closed time in 18 days

karolz-ms

issue commentmicrosoft/vscode-docker

Configuration property descriptions are garbled

For an example, I looked at the Python extension. Their settings have hardcoded English strings in package.json, but their command names are localized. Here's what their settings show in the marketplace: image

But their commands (mostly) have the same garbling as our settings: image

I found a VSCode issue tracking this, I'll close this one as external: https://github.com/microsoft/vscode/issues/54111

karolz-ms

comment created time in 18 days

issue closedmicrosoft/vscode-docker

An error "timeout after 1000 ms" occurs after stopping debugging a Python project

OS: Win 10 Build Version: 20200724.4

Repro Steps:

  1. Open a Python Django/Flask project and add Docker support for it in VS Code insider.
  2. F5 --> Wait for navigating to the Terminal window "Python Debug Console" during debugging --> Stop debugging.
  3. Check the result.

Expect: There is no error after stopping debugging.

Actual: An error "timeout after 1000 ms" occurs after stopping debugging. image

closed time in 18 days

v-ruizh

issue commentmicrosoft/vscode-docker

An error "timeout after 1000 ms" occurs after stopping debugging a Python project

I was able to reproduce this a few times. I think I know what is happening. Python's debug model is to start a "server" session on the local machine and a "client" session within the container. The "server" session is started and waits for the "client" session to connect back to it.

The client session takes up to a few seconds to make that connection (this is that docker exec ... debugpy ... call). If you click "Stop" during this time period, the server session tries to send the stop message to the client, but fails because the client hasn't connected yet. The error pops up. The server then "gives up" on sending that message, but the debug session then stops. Because the session stops, our code to remove the container activates, and the container is removed, so the client session is cleaned up.

I don't think there is really anything we can do about this issue, but fortunately the negative effects it would have had are mitigated by our container removal. The only negative effect is the error toast. For now I'll close this issue, but if we get some user reports maybe we can look at fixes within VSCode or debugpy.

v-ruizh

comment created time in 18 days

issue commentmicrosoft/vscode-docker

Extension issue

@VitaRox does this happen consistently?

VitaRox

comment created time in 18 days

issue commentmicrosoft/vscode-docker

An error "timeout after 1000 ms" occurs after stopping debugging a Python project

This is coming from the Python extension.

v-ruizh

comment created time in 18 days

issue commentmicrosoft/vscode-docker

test

@Bruce20091128 do you have a workspace folder open?

Bruce20091128

comment created time in 18 days

issue commentmicrosoft/vscode-docker

Configuration property descriptions are garbled

@karolz-ms This would need to go either to marketplace or to VSCode core. This same issue exists for the extension title and description, and is why we reverted the description to the non-localizable string.

karolz-ms

comment created time in 18 days

issue commentmicrosoft/vscode-docker

Remove CoreCLR debug

Relatedly, if you F5 outside of a workspace and choose the not-deprecated debugging option, you get "Cannot read property '0' of undefined'" from resolveDebugConfiguration.

bwateratmsft

comment created time in 18 days

issue commentmicrosoft/vscode-docker

Enable use off compose down, restart and up on shortcuts.

I agree, Windows shortcuts aren't the best for this. Symbolic links are one option but you'd have to figure out ways to ensure the correct build context is used. In general, I would suggest keeping one "project" to one workspace folder, so that in any given workspace folder only one docker-compose.yml is present (or even, one per workspace).

pablostellet

comment created time in 18 days

issue openedmicrosoft/vscode-docker

Remove CoreCLR debug

The legacy .NET debug has been deprecated for a while now with warnings to anyone still using it; I think it's fine to remove at this point. Should look at refactoring what is still in use (e.g. OS provider, vsdbg downloader, etc.) and removing what is not.

created time in 18 days

issue closedmicrosoft/vscode-docker

whats wrong

<!-- IMPORTANT: Please be sure to remove any private information before submitting. -->

Does this occur consistently? <!-- TODO: Type Yes or No --> Repro steps: <!-- TODO: Share the steps needed to reliably reproduce the problem. Please include actual and expected results. -->

Action: debugCoreClr Error type: Error Error Message: No workspace folder is associated with debugging.

Version: 1.4.1 OS: win32 OS Release: 10.0.18362 Product: Visual Studio Code Product Version: 1.47.2 Language: en

<details> <summary>Call Stack</summary>

DockerNetCoreDebugConfigurationProvider.resolveDockerDebugConfiguration extension.bundle.js:578:847643
extension.bundle.js:578:847550extension.bundle.js:578:847550
Object.<anonymous> extension.bundle.js:3:495519
extension.bundle.js:3:494710extension.bundle.js:3:494710
o extension.bundle.js:3:494396
Object.callWithTelemetryAndErrorHandling extension.bundle.js:3:495427
DockerNetCoreDebugConfigurationProvider.resolveDebugConfiguration extension.bundle.js:578:847481
extensionHostProcess.js:855:493extensionHostProcess.js:855:493
processTicksAndRejections task_queues.js:85:5

</details>

closed time in 18 days

jiger60

issue commentmicrosoft/vscode-docker

whats wrong

Dupe of #1451

jiger60

comment created time in 18 days

issue commentmicrosoft/vscode-docker

ed1

@Viniciuspnascimento It looks like Docker is not installed, can you verify that you have it installed?

Viniciuspnascimento

comment created time in 18 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha 7e47b552f2698eb96cb965f7d422b2bda6559e86

Finish python maybe

view details

push time in 21 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha 71ce0ac63b056472284851efe4742fcbb97a9775

Remove unneeded config provider

view details

Brandon Waterloo [MSFT]

commit sha cf7d51ccb9b5212d00de4ed8da3361b8202944c5

Remove files with no further business logic

view details

Brandon Waterloo [MSFT]

commit sha f7fdec65274a1930ef0aabb0b96cdd67f3a1bfdb

More files without business logic

view details

Brandon Waterloo [MSFT]

commit sha ad4767b64d6694b438991d5bc8cc5e71d7f10d84

Implementing Node and Python info gathering

view details

push time in 21 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha 10741efbb393f77cbfcf007f4b393359ebe97621

Fix context type issue (#2193)

view details

Brandon Waterloo [MSFT]

commit sha 578a078419058467c254a6645435df7a8cea9c3f

Merge branch 'master' into bmw/scaffolding

view details

Brandon Waterloo [MSFT]

commit sha d76ea59ced5aa2cc4a90db49cdeef5e656c42e41

Treat compose as separate command

view details

Brandon Waterloo [MSFT]

commit sha d0c7bdbe18f8e72981623825fbab09dcaca161ea

Fix template

view details

Brandon Waterloo [MSFT]

commit sha a706e3505536597154110fb412e2ec091d4d803c

Start actually removing old

view details

Brandon Waterloo [MSFT]

commit sha dc7edae7363974cefe5315c229303057ac9f67f1

Remove some things that are no longer used

view details

Brandon Waterloo [MSFT]

commit sha ded43ee459f8b302535a295d06d0f22986cdfa3f

Removing more

view details

Brandon Waterloo [MSFT]

commit sha b73a7000e07283c4de7d61025f9cb56de38c04bf

Dead code cleanup

view details

push time in 21 days

GollumEvent

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha c89bf97f09dea5d3c42518887567d761bc012f00

I don't even feel like a commit message anymore

view details

push time in 21 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha 549c377fe9c457bad4c356484e493ee92f60be12

Bugfixes

view details

push time in 21 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha 54e0ae40bdc75a31de1928a9543069db61a927ec

Bugfix

view details

Brandon Waterloo [MSFT]

commit sha 5c65483e0ed8c92f5c4cf01e8ea379c816b37230

Renaming some properties

view details

push time in 21 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha 10741efbb393f77cbfcf007f4b393359ebe97621

Fix context type issue (#2193)

view details

push time in 21 days

delete branch microsoft/vscode-docker

delete branch : bmw/ctx

delete time in 21 days

PR merged microsoft/vscode-docker

Fix context type issue

Fixes #2190

+1 -1

0 comment

1 changed file

bwateratmsft

pr closed time in 21 days

issue closedmicrosoft/vscode-docker

Fail to show the Docker assets with error "This view is not supported in the current Docker context"

OS: Win 10/Mac Build Version: 20200723.12 Regression: Previous Build

Repro Steps:

  1. Install the Docker extension.
  2. Navigate to "Docker View" and check the Docker assets.

Expect: All Docker assets show well.

Actual: Fail to show the Docker assets with an error "This view is not supported in the current Docker context". image

More Info:

  1. This issue reproduces if there is only one default Docker context.
  2. This issue does not reproduce if there are several Docker contexts.
  3. This issue does not reproduce on the previous build 20200723.3.

closed time in 21 days

v-ruizh

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha cfb8121275e41db2e209d63d0a7bb964b3369758

Always run new task for attach / run interactive (#2189)

view details

Brandon Waterloo [MSFT]

commit sha 1af3a024a1ebcf037303310f910a1db9a4fc9b1f

Merge branch 'master' into bmw/scaffolding

view details

Brandon Waterloo [MSFT]

commit sha 243c4d8ecaf683be5709619c818512d2bba9cf3d

Major refactoring to use subwizards

view details

Brandon Waterloo [MSFT]

commit sha d3e12cb17af98b6f438316f4c8b4bb410becf035

More refactoring

view details

Brandon Waterloo [MSFT]

commit sha 92f555c6cc8d3241c9a48f0c3031bad661e34461

Add some templates

view details

Brandon Waterloo [MSFT]

commit sha 83bbaba8c420969b52857ca23959205fc523e0d8

Templating stuff

view details

Brandon Waterloo [MSFT]

commit sha 68e24c9db717053a8b632084ef60ed8db35a3e26

Magically scan upward for templates

view details

Brandon Waterloo [MSFT]

commit sha 48dd928aa9eb8f7245f503c0526f5d22bde2e5c8

Fill out the Dockerfile templates

view details

Brandon Waterloo [MSFT]

commit sha bcd38f44152a1ed3ba4e7d9aaff640e23b7aa100

More refactoring

view details

Brandon Waterloo [MSFT]

commit sha d82ce8ec8208d418070292ad9bb022adc53b4f28

Continued refactoring

view details

Brandon Waterloo [MSFT]

commit sha 1d9a619ffe8071442a1d21fd1c617cab493b38b6

Fixes

view details

Brandon Waterloo [MSFT]

commit sha 38ba372d50033d9f0dc0c6b89a38f4e58d8c9fe5

Implement so much more stuff

view details

push time in 21 days

issue commentdocker/aci-integration-beta

Node.js Docker SDK API set

The object interfaces pretty closely match what is in the Docker Engine API, by design. Dockerode returns JSON objects unchanged from the engine, and for the most part, I wanted to not alter Dockerodes' objects either. We do a little bit of transformation to get things into the model we use and to make datetimes more consistent.

On the whole, I think the Docker Engine API is more or less what we need. The biggest challenge with Dockerode is that it is not context-aware; there are so many ways to control the ultimate Docker endpoint that it was a difficult problem to manage.

karolz-ms

comment created time in 21 days

issue commentmicrosoft/vscode-docker

The webpage keeps loading forever after debugging Django project more than 3 times

I haven't been able to repro today though as mentioned I've seen this in the past. @v-ruizh, if you hit this issue again can you check VSCode to see if it is stopped at an exception or breakpoint, etc.? If so, see if pressing continue (F5) in VSCode causes the web page to be loaded.

v-ruizh

comment created time in 22 days

Pull request review commentmicrosoft/vscode-docker

Fix context type issue

 const defaultContext: Partial<DockerContext> = {     Id: 'default',
     Name: 'default',
     Description: 'Current DOCKER_HOST based configuration',
+    Type: 'moby',

The real bug was at line 202, the lack of setting Type: 'moby'. Setting it in the default context here makes sense since a DOCKER_HOST-based configuration is always 'moby', and it removes the need for the same line at line 250 below.

bwateratmsft

comment created time in 22 days

PR opened microsoft/vscode-docker

Reviewers
Fix context type issue

Fixes #2190

+1 -1

0 comment

1 changed file

pr created time in 22 days

create barnchmicrosoft/vscode-docker

branch : bmw/ctx

created branch time in 22 days

Pull request review commentmicrosoft/vscode-dapr

Add default for componentsPath property.

 export default class DaprdCommandTaskProvider extends CommandTaskProvider {                                 .withNamedArg('--alsologtostderr', daprDefinition.alsoLogToStdErr, { assignValue: true })                                 .withNamedArg('--app-id', daprDefinition.appId)                                 .withNamedArg('--app-port', daprDefinition.appPort)-                                .withNamedArg('--components-path', daprDefinition.componentsPath)+                                .withNamedArg('--components-path', daprDefinition.componentsPath ?? './components')
                                .withNamedArg('--components-path', daprDefinition.componentsPath || './components')

Unless '' (empty string) is a valid value, I'd use || instead of ??.

philliphoff

comment created time in 22 days

issue commentmicrosoft/vscode-docker

Fail to show the Docker assets with error "This view is not supported in the current Docker context"

It appears it is trying to use the new Docker SDK provider in an old context. I'll investigate.

v-ruizh

comment created time in 22 days

issue commentmicrosoft/vscode-docker

Enable use off compose down, restart and up on shortcuts.

What are your shortcut files called?

pablostellet

comment created time in 22 days

issue commentmicrosoft/vscode-docker

The webpage keeps loading forever after debugging Django project more than 3 times

I've seen this happen but every time it was VSCode silently hitting a breakpoint or halting on an exception.

v-ruizh

comment created time in 22 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha cfb8121275e41db2e209d63d0a7bb964b3369758

Always run new task for attach / run interactive (#2189)

view details

push time in 22 days

delete branch microsoft/vscode-docker

delete branch : bmw/taskid

delete time in 22 days

issue closedmicrosoft/vscode-docker

Executing interactive commands as tasks prevents recreating new identical ones

The logic to change CLI commands into tasks has caused one issue--if a task of the exact same command line is running already (one of the interactive ones, basically), another of the same cannot be executed.

For example, choose an Alpine image, and do "Run Interactive", which will open a task that will stay running. Do the same thing again, and instead of running a second container interactively, the task system says the task is already running. Arguably, this behavior is correct for attach shell (if you have a shell attached to a particular container already, it will simply direct you back to that shell, rather than making a new one), but I think it's sub-ideal for run interactive in particular.

closed time in 22 days

bwateratmsft

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha 14272b7ab34ed8f552eb0110a3b406f4d5fd2d88

Use home as default cwd for tasks (#2178)

view details

Brandon Waterloo [MSFT]

commit sha bf4c2b50f63e473c59b0404706eb0d2bf3941ac8

Cherry-pick Make context switch listeners even more best-effort (#2182) (#2183)

view details

Brandon Waterloo [MSFT]

commit sha 33fd749ed1e82bd1eead16ee8fbcd13d61ac0612

Fix network logic (#2187)

view details

Brandon Waterloo [MSFT]

commit sha d7f9027de60b92f6f5c722f869c441820bda2d10

Make command templates context type aware (#2176) * Extend cmd customization for context types * Add unit tests for command template selection

view details

Brandon Waterloo [MSFT]

commit sha 7883f74169cdd3894a263c1b883b9e6563bb209f

Merge branch 'master' into bmw/scaffolding

view details

Brandon Waterloo [MSFT]

commit sha a0225eed6b75c15c287143f2a05c90e2d54fc62c

Additional Python implementation

view details

push time in 22 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha d7f9027de60b92f6f5c722f869c441820bda2d10

Make command templates context type aware (#2176) * Extend cmd customization for context types * Add unit tests for command template selection

view details

push time in 22 days

delete branch microsoft/vscode-docker

delete branch : bmw/contextcommands

delete time in 22 days

PR merged microsoft/vscode-docker

Make command templates context type aware

Fixes #2168. Template commands are made context-aware, so that different commands can match different contexts.

With the old behavior, the order is as follows:

  1. Look for any template with a match property that matches
  2. Look for any template without a match property
  3. Use the default template

With this new behavior, the order is as follows (more or less the same as above):

  1. Look for any template whose context type matches AND with a match property that matches
  2. Look for any template whose context type matches AND without a match property
  3. Use the default template whose context type matches

If no contextType property is explicitly specified on any template, it is treated as 'all' and will apply in any context. 'legacy' currently matches only 'moby' contexts, and 'new' currently matches only 'aci' contexts (though it is likely there will be more in the future).

TODO: create an issue or PR to update the docs.

+864 -62

1 comment

9 changed files

bwateratmsft

pr closed time in 22 days

issue closedmicrosoft/vscode-docker

Compose up / down commands will not work in ACI context

The command needs to be altered so that docker-compose becomes docker compose. Additionally, --build needs to be removed.

closed time in 22 days

bwateratmsft

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha 18150046599c489b0d5ab9a49220ac9008c1dcec

Minor fixes

view details

push time in 22 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha bf4c2b50f63e473c59b0404706eb0d2bf3941ac8

Cherry-pick Make context switch listeners even more best-effort (#2182) (#2183)

view details

Brandon Waterloo [MSFT]

commit sha a8d13cf1d9decfdd2346eef00d17b1b0ec8b0389

Merge branch 'master' into bmw/contextcommands

view details

Brandon Waterloo [MSFT]

commit sha 33fd749ed1e82bd1eead16ee8fbcd13d61ac0612

Fix network logic (#2187)

view details

Brandon Waterloo [MSFT]

commit sha a7a6bc84ce4da3d7368c8357bcb3eda7432fb8b7

Merge branch 'master' into bmw/contextcommands

view details

Brandon Waterloo [MSFT]

commit sha dce88d0bdd1bf4a499b455a3badac6fe20460395

Phrasing change

view details

push time in 22 days

PR opened microsoft/vscode-docker

Reviewers
Always run new task for attach / run interactive

Fixes #2188

+10 -3

0 comment

3 changed files

pr created time in 22 days

create barnchmicrosoft/vscode-docker

branch : bmw/taskid

created branch time in 22 days

issue commentmicrosoft/vscode-docker

Compose up / down commands will not work in ACI context

I have a PR for the doc updates: https://github.com/microsoft/vscode-docs/pull/3902

bwateratmsft

comment created time in 22 days

PR opened microsoft/vscode-docs

Update command customization info

This updates the documentation about command customization to reflect the changes in https://github.com/microsoft/vscode-docker/issues/2168 / https://github.com/microsoft/vscode-docker/pull/2176. @karolz-ms FYI.

This should not be merged until Docker extension version 1.5.0 is released, tentatively around August 17.

+12 -7

0 comment

1 changed file

pr created time in 22 days

push eventbwateratmsft/vscode-docs

Brandon Waterloo [MSFT]

commit sha b5d00d6db233785fcc9ca0b2498cc5225febee8f

Update command customization info

view details

push time in 22 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha 33fd749ed1e82bd1eead16ee8fbcd13d61ac0612

Fix network logic (#2187)

view details

push time in 22 days

delete branch microsoft/vscode-docker

delete branch : bmw/groupbynet

delete time in 22 days

issue closedmicrosoft/vscode-docker

Group by networks is not working

Group by networks always groups under <none> which is not correct.

closed time in 22 days

bwateratmsft

issue commentmicrosoft/vscode-docker

Executing interactive commands as tasks prevents recreating new identical ones

I found an easy way to do this, and we can choose on a per-command basis what the behavior should be.

"Run Interactive", "Attach Shell", and "View Logs" are the potentially interactive commands. @BigMorty - which commands do you think should always open a new task, and which should re-use an already-running task? Personally I think "Run Interactive" should always run a new container, "View Logs" should open an existing one, and I could go either way on "Attach Shell". Do you think there's a use case for attaching multiple shells to the same container?

bwateratmsft

comment created time in 22 days

fork bwateratmsft/vscode-docs

Public documentation for Visual Studio Code

http://code.visualstudio.com/docs

fork in 22 days

issue openedmicrosoft/vscode-docker

Executing commands as tasks prevents recreating new ones

The logic to change CLI commands into tasks has caused one issue--if a task of the exact same command line is running already (one of the interactive ones, basically), another of the same cannot be executed.

For example, choose an Alpine image, and do "Run Interactive", which will open a task that will stay running. Do the same thing again, and instead of running a second container interactively, the task system says the task is already running. Arguably, this behavior is correct for attach shell (if you have a shell attached to a particular container already, it will simply direct you back to that shell, rather than making a new one), but I think it's sub-ideal for run interactive in particular.

created time in 22 days

issue closedmicrosoft/vscode-docker

An error occurs when executing "Run/Run Interactive/Pull/Push..." commands for Docker image

OS: Mac Build Version: 20200720.3

Repro Steps: Right click one Docker image and execute "Run/Run Interactive/Pull/Push..." commands.

Expect: Succeed to execute these commands "Run/Run Interactive/Pull/Push...".

Actual: An error "Cannot read property 'uri' of undefined" occurs. Screen Shot 2020-07-22 at 5 54 57 PM

More Info: This issue does not reproduce on Windows.

closed time in 22 days

v-ruizh

issue commentmicrosoft/vscode-docker

An error occurs when executing "Run/Run Interactive/Pull/Push..." commands for Docker image

Verified this is now fixed in the latest VSCode Insiders build.

v-ruizh

comment created time in 22 days

PR opened microsoft/vscode-docker

Fix network logic

Fixes #2185

+1 -1

0 comment

1 changed file

pr created time in 22 days

create barnchmicrosoft/vscode-docker

branch : bmw/groupbynet

created branch time in 22 days

Pull request review commentmicrosoft/vscode-docker

Make command templates context type aware

 async function quickPickTemplate(context: IActionContext, templates: CommandTemp 
     return selection.data;
 }
+
+function getConstrainedTemplates(templates: CommandTemplate[], matchContext: string[], currentContextType: ContextType): CommandTemplate[] {
+    return templates.filter(template => {
+        if (!template.contextTypes && !template.match) {
+            // If neither contextTypes nor match is defined, this is an unconstrained template

(If CommandTemplate was a class I could easily use a get method but it's just an interface...)

bwateratmsft

comment created time in 23 days

Pull request review commentmicrosoft/vscode-docker

Make command templates context type aware

 async function quickPickTemplate(context: IActionContext, templates: CommandTemp 
     return selection.data;
 }
+
+function getConstrainedTemplates(templates: CommandTemplate[], matchContext: string[], currentContextType: ContextType): CommandTemplate[] {
+    return templates.filter(template => {
+        if (!template.contextTypes && !template.match) {
+            // If neither contextTypes nor match is defined, this is an unconstrained template

I'm not sure I follow. If I added such a property I would basically have to apply the same logic in these methods in order to set it; wouldn't it be about the same amount of code?

bwateratmsft

comment created time in 23 days

issue openedmicrosoft/vscode-docker

Group by networks is not working

Group by networks always groups under <none> which is not correct.

created time in 23 days

issue commentmicrosoft/vscode-docker

EACCES: permission denied on extension activation

A fix has been released in 1.4.1.

nileshdattatraykedare

comment created time in 23 days

created tagmicrosoft/vscode-docker

tagv1.4.1

Docker extension for Visual Studio Code

created time in 23 days

release microsoft/vscode-docker

v1.4.1

released time in 23 days

create barnchmicrosoft/vscode-docker

branch : bmw/eaccess_1.5

created branch time in 23 days

issue closedmicrosoft/vscode-docker

EACCES: permission denied on extension activation

<!-- IMPORTANT: Please be sure to remove any private information before submitting. -->

Does this occur consistently? <!-- TODO: Type Yes or No --> Repro steps: <!-- TODO: Share the steps needed to reliably reproduce the problem. Please include actual and expected results. -->

Action: docker.activate Error type: EACCES Error Message: EACCES: permission denied, watch '/Users/nileshk/.docker/config.json'

Version: 1.4.0 OS: darwin OS Release: 19.5.0 Product: Visual Studio Code Product Version: 1.47.2 Language: en

<details> <summary>Call Stack</summary>

FSWatcher.start watchers.js:165:26
Object.watch fs.js:1270:11
new DockerContextManager extension.bundle.js:578:855139
extension.bundle.js:33:376703
processTicksAndRejections task_queues.js:85:5

</details>

closed time in 23 days

nileshdattatraykedare

delete branch microsoft/vscode-docker

delete branch : bmw/eaccess

delete time in 23 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha 754fd61ab850e708334c5cb218ec8b8b847d4ae6

Make context switch listeners even more best-effort (#2182) * Make context switch listeners even more best-effort * Prep 1.4.1

view details

push time in 23 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha 9c336aa9740225c04470c8afa66302555ef23d56

Widen the try/catch

view details

push time in 23 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha a00dffbf8c1ee1eec51c489a49f5d241b3714e2f

Prep 1.4.1

view details

push time in 23 days

create barnchmicrosoft/vscode-docker

branch : rel/1.4.1

created branch time in 23 days

create barnchmicrosoft/vscode-docker

branch : bmw/eaccess

created branch time in 23 days

issue commentmicrosoft/vscode-docker

EACCES: permission denied

@nileshdattatraykedare Can you check the permissions on your Docker config file? The context in which you are running VSCode does not have permissions to access it which is strange.

nileshdattatraykedare

comment created time in 23 days

push eventmicrosoft/vscode-docker

Brandon Waterloo [MSFT]

commit sha ea784bad19ba29a13bc7f8678495299e24421880

Fix test failure

view details

push time in 23 days

more