profile
viewpoint
Brian Anderson brson PingCAP https://brson.github.io I write Rust code. Also, I do other things — things that aren't even related to Rust.

brson/basic-http-server 281

A simple static HTTP server in Rust, for learning and local doc development

brson/annotated-std-rs 66

An annotation of the Rust standard library

brson/big_s 15

Rust's missing `String` literal

brson/being-rust 14

Intro to Rust talk

brson/archaea 13

Historic Rust code browsing

alegalle/rustgl_4_2_core 8

Opengl 3.2 - 4.2 bindings for rust

brson/android-plugin 2

An sbt plugin for Android development in Scala

Aimeedeer/bigannouncement 1

bigannouncement.eth

push eventbrson/blam

Brian Anderson

commit sha 2a07d0f24715e6706e997903d7c009fecc7b60a1

.

view details

push time in an hour

push eventbrson/blam

Brian Anderson

commit sha 1e258f7b4b7c1c4776dc6b4ffde2225aab015051

.

view details

Brian Anderson

commit sha 982e3107d070d71f0d654e9e7faf68e6e871c196

.

view details

push time in an hour

push eventbrson/blam

Brian Anderson

commit sha 657a294fee30084744a8a43939f0117a67f90c83

.

view details

Brian Anderson

commit sha 352d5798933de64cb558f7b083910e364f3cde03

.

view details

Brian Anderson

commit sha 9b82efd007ec91272d07acb82b8a97927eabc2ed

.

view details

push time in an hour

push eventbrson/blam

Brian Anderson

commit sha 0f65bb3e7a37de9afa2aff4194088615f30c9070

.

view details

push time in 2 hours

push eventbrson/blam

Brian Anderson

commit sha a0d86a68dc19eb60db904f2b33833577bf1f2bc7

.

view details

push time in 2 hours

push eventbrson/blam

Brian Anderson

commit sha c04a98bad6789d1f570ba211dd044edaadc43655

.

view details

Brian Anderson

commit sha 92b358d5e28139305c7b161c49e985d0856b4642

.

view details

Brian Anderson

commit sha 7316aa1aadff3fb52298d539edd7a609f145e16f

.

view details

push time in 6 hours

push eventbrson/blam

Brian Anderson

commit sha 84a63338e2ee35905acf92b68a91ba1f5bc108b9

.

view details

push time in 7 hours

push eventbrson/blam

Brian Anderson

commit sha 4897b7b7e0b59d96fec1320c73e60c4e3b898ea8

.

view details

Brian Anderson

commit sha c2ddc09dfca0cd715c4cdac01d9d5f3fc9d0208b

.

view details

push time in 7 hours

push eventbrson/blam

Brian Anderson

commit sha f441b8d32501083c370149d5a8e916e01b61fa1b

.

view details

push time in 7 hours

push eventbrson/blam

Brian Anderson

commit sha 42adaee3f199a6869039b8f17afa9359c51fa680

.

view details

Brian Anderson

commit sha c3f17da649487a45da1654f4fed6b9d08016b8dd

.

view details

push time in 7 hours

push eventbrson/blam

Brian Anderson

commit sha 1c1b0e3c57d91f287ef95a0990daf9e6cc7922aa

.

view details

Brian Anderson

commit sha d460c4dd3029eb2bf3a333f690dede186d7b16a6

.

view details

Brian Anderson

commit sha 658032d093e8b6e901f89b938435c6ee87417c25

.

view details

Brian Anderson

commit sha 0a6d1bcd1a4477fa9cb95896c64f4139c68e21f9

.

view details

push time in 7 hours

push eventbrson/blam

Brian Anderson

commit sha f196c34e8fd0c481bf4c6b51029ba0d13299d1e2

.

view details

push time in 14 hours

push eventbrson/blam

Brian Anderson

commit sha 883d270d53f1b3dcd36440291d62013fde07cfee

.

view details

push time in 16 hours

push eventbrson/blam

Brian Anderson

commit sha 1d28a568c8855141c1d31e1b0b33366dceaed0b8

.

view details

Brian Anderson

commit sha d6f14a06bfc7d7058ea72296f3c6c8be42b864e8

.

view details

push time in 16 hours

push eventbrson/blam

Brian Anderson

commit sha d0816a28b295fa4d2e686fc6551d07671662f786

.

view details

Brian Anderson

commit sha f65e1c1c457fc8740999a6e77ce59c9c4c1bac53

.

view details

Brian Anderson

commit sha dfcfddc46a6bbeee64722cad8caa1826df2cebda

.

view details

push time in 16 hours

push eventbrson/blam

Brian Anderson

commit sha 1fec2d572f85235ce747a090913860862447cb33

.

view details

push time in 17 hours

push eventbrson/blam

Brian Anderson

commit sha 1d125635333285bbe89e93615cb1cb03857c7628

.

view details

Brian Anderson

commit sha 5582a28c25e91bb5954365d382120c31603137c9

.

view details

Brian Anderson

commit sha d3b62968c56388c4c2789f96fd4a222b2c746b59

.

view details

push time in 17 hours

push eventbrson/blam

Brian Anderson

commit sha d3728cff7d97a82b4c7e52ba3ad9ed79e1c35be3

.

view details

Brian Anderson

commit sha 85351ac277d5944bd3c13efadc4a485cc058ee66

.

view details

Brian Anderson

commit sha 7e9ea37ed94db7f33d23d55b0eed01f90f35ce6c

.

view details

Brian Anderson

commit sha 443e225848509c1c85caceae5b52c587c124e027

.

view details

push time in 17 hours

push eventbrson/blam

Brian Anderson

commit sha 43d20c1da78ecea68866341f959608d38601265e

.

view details

push time in 19 hours

push eventbrson/blam

Brian Anderson

commit sha ca1104be03167212d3f5edfb7772ba49022667df

.

view details

Brian Anderson

commit sha 42e6d0ebdb7c1716d306117dfb9d32a891d6c325

.

view details

push time in 21 hours

create barnchbrson/cgagame

branch : master

created branch time in 21 hours

created repositorybrson/cgagame

created time in 21 hours

push eventbrson/chtk

Brian Anderson

commit sha 5b455fdcae24f9ab448de1c48a29c57befaee1d8

.

view details

Brian Anderson

commit sha 546b28ce964caab9472c2f463d3cd1c047e1b5e1

.

view details

Brian Anderson

commit sha c6cbf3b9120607ab541ffdcdec91d4ca28dfdfd6

.

view details

Brian Anderson

commit sha ffc14e7c29fce963f0180fcc656db7ac9a0ea5a6

.

view details

Brian Anderson

commit sha adf123fce0d2749e2087c5c21d0d96bd13e88112

.

view details

Brian Anderson

commit sha da4e8ebd6454a1f6d4f24932ef83153d1655d8e3

.

view details

Brian Anderson

commit sha ee77e5d3878b4370766bb17655c68cc68d42dcfb

.

view details

push time in 3 days

push eventbrson/tikv

Brian Anderson

commit sha 47ceee696fe30ca9524831aea76cb57310473fcf

server: Parameterize resolve over engines Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 4 days

create barnchbrson/tikv

branch : engine-traits-more-tikv

created branch time in 4 days

PR closed tikv/tikv

Fix two memory leaks

<!-- Thank you for contributing to TiKV!

If you haven't already, please read TiKV's CONTRIBUTING document.

If you're unsure about anything, just ask; somebody should be along to answer within a day or two. -->

What have you changed?

These are two cases where servers are not shutdown property and continue to run after they go out of scope. Fixed by adding shutdown on drop.

I only know these to fix leaks in test cases but one could impact production code as well.

Found with valgrind.

There are more leaks of this kind to find and fix.

What is the type of the changes?

  • Bugfix (a change which fixes an issue)

How is the PR tested?

valgrind

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

no

Does this PR affect tidb-ansible?

no

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Any examples? (optional)

+40 -5

8 comments

2 changed files

brson

pr closed time in 4 days

pull request commenttikv/tikv

Fix two memory leaks

I think I'll just close this. I don't think this leak has a significant production impact. More of this type of instrumented analysis would likely continue to be productive.

brson

comment created time in 4 days

pull request commenttikv/tikv

Fix two memory leaks

This probably needs to be re-investigated from scratch at this point.

brson

comment created time in 4 days

issue commenttikv/tikv

Engine abstraction tracking issue

This has made a lot of progress. We're still months away from being able to run tikv with a real alternative engine, but most of the pieces are mostly in place now.

  • The raftstore crate is almost completely parameterized over the KvEngine trait, but is not yet free of the engine_rocks dependency. There is perhaps one more test still using RocksEngine directly, and the crate still uses the engine_rocks::PerfContext global state.
  • The engine_test crate provides a mechanism for picking which engine to construct at compile time, and is used in the raftstore crate to make it testable with other engines, currently just engine_rocks and engine_panic

There's enough scaffolding to begin adding other engines, and a few are in progress:

  • @5kbpers is working on a skiplist-based in-memory engine
  • @skyzh is working on https://github.com/tikv/agatedb
  • I am working on a simple engine while I build an engine conformance test suite, engine_traits_tests

The way to implement an engine is:

  • Copy engine_panic to engine_myengine
  • Make it a dependency of engine_test, and fill in the boilerplate in engine_test/src/lib.rs so that it can be constructed for test cases
  • Add engine_myengine to tikv/Cargo.toml and fill out feature flags, copying from engine_panic

Then you should be able to run tests against raftstore with

cargo test -p raftstore --no-default-features --features=protobuf-codec,test-engines-myengine

Currently I am working on:

  • Creating a conformance test suite for engines, called engine_traits_tests. This should help a lot when adding new engines.
  • Moving engine_rocks dependencies from the tikv crate
brson

comment created time in 4 days

issue commenttikv/tikv

Make multiple storage engines testable

This is done through the engine_test crate. See its crate docs and usage in raftstore for details.

brson

comment created time in 4 days

push eventbrson/coconuts

Brian Anderson

commit sha 6d65f5e9d33f2db80ef99a275fdd7e6bc767bb22

.

view details

push time in 4 days

push eventbrson/tikv

Xintao

commit sha 77a2fa6db69ef6a885c6ee09e1d66f3697a37183

Encryption: reduce lock range of file_dict and background the key rotation (#8805) Signed-off-by: Xintao <hunterlxt@live.com>

view details

Liqi Geng

commit sha cac226a6a00fcb54dc320894e5bab24e9edd6b0c

raftstore: remove the overhead of traversing new committed entries (#8847) Signed-off-by: gengliqi <gengliqiii@gmail.com>

view details

NingLin-P

commit sha b2630d167adf90c01687d6f9163f1623bb4bd3b9

raftstore: record the noop entry message temporarily like pending_votes (#8820) Signed-off-by: linning <linningde25@gmail.com>

view details

龙方淞

commit sha fcb2791312203f40167a92bc9bf4c4421e72ecad

txn: Move acquire_pessimistic_lock action (#8835) Signed-off-by: longfangsong <longfangsong@icloud.com>

view details

Brian Anderson

commit sha dbfe7730dd0fddb34cb8c3a7f8a079a1349d2d41

Remove CFHandles from engine_traits (#8856) Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

glorv

commit sha eefee83f4107171d911db92d5007c38d93a3ac20

importer: do not set in memory in importer sst writer (#8852) Signed-off-by: glorv <glorvs@163.com>

view details

NingLin-P

commit sha 417be27592712f3c752ec8e4c1d4520fe50aae5c

test: fix unstable test test_node_merge_write_data_to_source_region_after_merging (#8871) Signed-off-by: linning <linningde25@gmail.com>

view details

5kbpers

commit sha 8c7d117eade1aba4cd22e96b3a9e501156593a7f

error_code: re-format metafile (#8870) Signed-off-by: 5kbpers <tangminghua@pingcap.com>

view details

Brian Anderson

commit sha efe648e215cb9cccd66a0901fe63fbf73c234c5a

Add engine_traits_tests crate Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 53093603dc8b94d1364e1ca59972dd5cbc385644

engine_traits_tests: Add simple ctor tests Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha b5081b2fb61730d893934bfd519421f42cc8fad6

engine_test: Add a simple read/write test Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 638fef1a1de40318f78b8b9d5aa9d5c7b24efc00

engine_traits_tests: Add another simple read/write test Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 42410d2d15e49ddbfed7be1c23efc722ff1961eb

engine_traits_tests: Another CFNamesExt test Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha cf3654d2a69e74ab060e00cf7a20e93fada3eb84

engine_traits_tests: Add another cf get/put test Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 6220de0d74d11478a092804d686763d54f448ef1

engine_rocks: Add 'rtcheck' feature to engine_rocks and turn it on As described in Cargo.toml Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 83727012caabd13b00d86d89822b67e197745b78

engine_traits_tests: Add test for empty engine iterators Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 3fb4d4a03a2b88a6b7dd0baa9952e6609984cbee

engine_traits_tests: Add forward iteration test Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha efd68b0cadc29da3630de33b577206cb163a1bf1

engine_traits_test: Add reverse iteration test Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 1f9ee6b6b4e2c5c3bf1519b9959e21e1693f5352

engine_traits_tests: Add iteration seek to key test Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha bdb1ef851e08e36b7c6116862f9e034dedae7e97

engine_traits_tests: Add test for seek to key then iterate backwards Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 4 days

push eventbrson/chtk

Brian Anderson

commit sha 6c7aefdb4d2e705387fd7e2b49b286d818c9ce86

.

view details

push time in 5 days

push eventbrson/chtk

Brian Anderson

commit sha 27838593f38d8751cf425b3a2e0530589498f676

.

view details

push time in 5 days

push eventbrson/chtk

Brian Anderson

commit sha 01c73de34df96256f13dcac506c5b016de33b82e

.

view details

push time in 5 days

push eventbrson/chtk

Brian Anderson

commit sha 814cff0014dc301ce3f819ff85e9d17e73bb9658

.

view details

push time in 5 days

push eventbrson/chtk

Brian Anderson

commit sha a7c5f3544cb13a0382de04a8217a086a5849e34a

.

view details

push time in 5 days

create barnchbrson/chtk

branch : master

created branch time in 5 days

created repositorybrson/chtk

created time in 5 days

create barnchbrson/blam

branch : master

created branch time in 5 days

created repositorybrson/blam

created time in 5 days

PR opened tikv/tikv

Remove CFHandles from engine_traits

<!-- Thank you for contributing to TiKV!

If you haven't already, please read TiKV's CONTRIBUTING document.

If you're unsure about anything, just ask; somebody should be along to answer within a day or two.

PR Title Format:

  1. module [, module2, module3]: what's changed
  2. *: what's changed -->

What problem does this PR solve?

Part of https://github.com/tikv/tikv/issues/6402

Problem Summary:

While column families are mostly used by name, there are a few places where engine_traits exposes CFHandles. This patch removes them.

What is changed and how it works?

Related changes

Check List <!--REMOVE the items that are not applicable-->

Release note <!-- bugfixes or new feature need a release note -->

  • No release note
+96 -183

0 comment

27 changed files

pr created time in 6 days

push eventbrson/tikv

Brian Anderson

commit sha a883a066d1c036f835053ae9ffc5c8b05d7a49e4

engine_traits: Remove CFHandle trait and associated type Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 625f5f277c693c269dddf2c9eb14c263001590f2

engine_traits: Rename CFHandleExt to CFOptionsExt Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha dcc8be211655671183aa7094a18a5e0b6079617a

rustfmt Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 6 days

create barnchbrson/tikv

branch : engine_traits_tests

created branch time in 6 days

create barnchbrson/tikv

branch : engine-traits-no-cfhandle

created branch time in 6 days

push eventbrson/tikv

Jay

commit sha da71027a3a2f99ff625caaa6ad552eca628a426d

tikv_alloc: fix profiling (#8741) Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

view details

Yilin Chen

commit sha 0b05a9947ca1bc29e090a24a58d8838f1574f9f8

concurrency manager: add memory usage test and lock table benchmarks (#8715) Signed-off-by: Yilin Chen <sticnarf@gmail.com>

view details

Vishnunarayan K I

commit sha 08aed4e161e3340aa8aa34317467a8fd77dc03de

copr: Improve `BitVec` perf (#8747) Signed-off-by: Vishnunarayan K I <appukuttancr@gmail.com>

view details

Xuanwo

commit sha 760551133c63d78bf82420125cd0607302ec675a

copr: Implement non-nullable support for vargs (#8740) Signed-off-by: Xuanwo <github@xuanwo.io>

view details

Yatin Maan

commit sha d6de756ddc3e79eedf74e86f464767fab064a486

copr: Vectorize month_name (#8749) Signed-off-by: yatinmaan <yatinmaan1@gmail.com>

view details

crazycs

commit sha 1f2b76f6b2fbe12a1cbee47079dfa4541720f73d

*: update sysinfo version to fix undiscovered disk information (#8791) Signed-off-by: crazycs520 <crazycs520@gmail.com>

view details

yiwu-arbug

commit sha 4784818535668e0e286edebffe9efe40cd9d25de

rocksdb: Compaction guard: split SST by region boundaries (#8115) Signed-off-by: Yi Wu <yiwu@pingcap.com>

view details

qupeng

commit sha 2cbfc2b4965aa88da5104f89822600b91a7f01b4

implement mvcc consistency check (#8703) Signed-off-by: qupeng <qupeng@pingcap.com>

view details

Yilin Chen

commit sha 7e59be4dae9b6dde0f4575cb030497386fd3b083

test: stablize future_pool::tests::test_tick again (#8795) Signed-off-by: Yilin Chen <sticnarf@gmail.com>

view details

Jay

commit sha 52c8492edec6ede7f4a1705c2a32e86ff38e82a0

tikv-server: enable mem profiling features by default (#8794) Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

view details

Qinxuan Chen

commit sha 5fb90cef4895947abe8f18aefec345b775cc37b8

Remove useless timer pool (#8782) Signed-off-by: koushiro <koushiro.cqx@gmail.com>

view details

Liu Cong

commit sha 5a9a3284ef4a4e1832d1ceda5f49f5beb27dd663

metrics: add fast tune panals (#8798) Signed-off-by: Liu Cong <innerr@gmail.com>

view details

Yilin Chen

commit sha d810b9de30c89b3ee4fd5e1090b0ada3d750b770

txn: remove async commit configurations (#8753) Signed-off-by: Yilin Chen <sticnarf@gmail.com>

view details

cfzjywxk

commit sha a83a240737f2bf379b6662c84b9152c7758eea09

txn: move scheduler process counter into worker (#8773) Signed-off-by: cfzjywxk <lsswxr@163.com>

view details

Lei Zhao

commit sha f88f88a5f34724d06bea062329ce0e71ad4b9e40

tikv_util: use singleton sysinfo::System (#8799) Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

view details

Jay

commit sha e6d6c19b9013adc53fecdd26621b476fe2ce3810

*: cleanup dependencies (#8803) Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

view details

5kbpers

commit sha c29df878d216914852884b62557e157452d4ba49

Makefile: do not gen error code before build (#8807) Signed-off-by: 5kbpers <tangminghua@pingcap.com>

view details

Wallace

commit sha fae016ec4ce5776d7336163274af881f8fb041fc

Ingest SST instead of writing memtable directly when delete a large range of keys. (#7794) Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

view details

Jay

commit sha a6485f37ba2d46b70ffe07441021fa6de375fbf7

*: remove setup configuration of jemalloc profile (#8813) Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

view details

Liu Cong

commit sha 68d6487263fc6ecfe67fb490b7b5574469044f38

metrics: add write-batch-size-too-big panels to Fast-Tune (#8812) Signed-off-by: Liu Cong <innerr@gmail.com>

view details

push time in 6 days

push eventbrson/tikv

Greg Weber

commit sha 2a2fa03da53b63f3fc24d7ea53aead40176979b5

fix links to point to tikv instead of pingcap (#8776) Signed-off-by: Greg Weber <greg@pingcap.com>

view details

Patrick Jiang(白泽)

commit sha 16643d839eb0fa38e798aa699116fc09a62eede6

*: update rust-rocksdb version to fix build failed (#8784) Signed-off-by: Patrick <patrickjiang0530@gmail.com>

view details

Jay

commit sha da71027a3a2f99ff625caaa6ad552eca628a426d

tikv_alloc: fix profiling (#8741) Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

view details

Yilin Chen

commit sha 0b05a9947ca1bc29e090a24a58d8838f1574f9f8

concurrency manager: add memory usage test and lock table benchmarks (#8715) Signed-off-by: Yilin Chen <sticnarf@gmail.com>

view details

Vishnunarayan K I

commit sha 08aed4e161e3340aa8aa34317467a8fd77dc03de

copr: Improve `BitVec` perf (#8747) Signed-off-by: Vishnunarayan K I <appukuttancr@gmail.com>

view details

Xuanwo

commit sha 760551133c63d78bf82420125cd0607302ec675a

copr: Implement non-nullable support for vargs (#8740) Signed-off-by: Xuanwo <github@xuanwo.io>

view details

Yatin Maan

commit sha d6de756ddc3e79eedf74e86f464767fab064a486

copr: Vectorize month_name (#8749) Signed-off-by: yatinmaan <yatinmaan1@gmail.com>

view details

crazycs

commit sha 1f2b76f6b2fbe12a1cbee47079dfa4541720f73d

*: update sysinfo version to fix undiscovered disk information (#8791) Signed-off-by: crazycs520 <crazycs520@gmail.com>

view details

yiwu-arbug

commit sha 4784818535668e0e286edebffe9efe40cd9d25de

rocksdb: Compaction guard: split SST by region boundaries (#8115) Signed-off-by: Yi Wu <yiwu@pingcap.com>

view details

qupeng

commit sha 2cbfc2b4965aa88da5104f89822600b91a7f01b4

implement mvcc consistency check (#8703) Signed-off-by: qupeng <qupeng@pingcap.com>

view details

Yilin Chen

commit sha 7e59be4dae9b6dde0f4575cb030497386fd3b083

test: stablize future_pool::tests::test_tick again (#8795) Signed-off-by: Yilin Chen <sticnarf@gmail.com>

view details

Jay

commit sha 52c8492edec6ede7f4a1705c2a32e86ff38e82a0

tikv-server: enable mem profiling features by default (#8794) Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

view details

Qinxuan Chen

commit sha 5fb90cef4895947abe8f18aefec345b775cc37b8

Remove useless timer pool (#8782) Signed-off-by: koushiro <koushiro.cqx@gmail.com>

view details

Liu Cong

commit sha 5a9a3284ef4a4e1832d1ceda5f49f5beb27dd663

metrics: add fast tune panals (#8798) Signed-off-by: Liu Cong <innerr@gmail.com>

view details

Yilin Chen

commit sha d810b9de30c89b3ee4fd5e1090b0ada3d750b770

txn: remove async commit configurations (#8753) Signed-off-by: Yilin Chen <sticnarf@gmail.com>

view details

cfzjywxk

commit sha a83a240737f2bf379b6662c84b9152c7758eea09

txn: move scheduler process counter into worker (#8773) Signed-off-by: cfzjywxk <lsswxr@163.com>

view details

Lei Zhao

commit sha f88f88a5f34724d06bea062329ce0e71ad4b9e40

tikv_util: use singleton sysinfo::System (#8799) Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

view details

Jay

commit sha e6d6c19b9013adc53fecdd26621b476fe2ce3810

*: cleanup dependencies (#8803) Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

view details

5kbpers

commit sha c29df878d216914852884b62557e157452d4ba49

Makefile: do not gen error code before build (#8807) Signed-off-by: 5kbpers <tangminghua@pingcap.com>

view details

Wallace

commit sha fae016ec4ce5776d7336163274af881f8fb041fc

Ingest SST instead of writing memtable directly when delete a large range of keys. (#7794) Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

view details

push time in 6 days

PR opened tikv/agatedb

skiplist: Fix undefined behavior in arena drop

The Vec must be deallocated with the same pointer alignment and capacity as it is created.

Signed-off-by: Brian Anderson andersrb@gmail.com

Found with miri cc @RalfJung

+3 -1

0 comment

1 changed file

pr created time in 6 days

create barnchbrson/agatedb

branch : fixub

created branch time in 6 days

fork brson/agatedb

A persistent key-value storage in rust.

fork in 6 days

pull request commenttikv/tikv

Make raftstore testable with arbitrary combinations of storage engines

/merge

brson

comment created time in 6 days

push eventbrson/tikv

Brian Anderson

commit sha bb7d280c13a426e4a92c332b16fbb90f5082de3f

rustfmt Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 6 days

pull request commenttikv/tikv

Make raftstore testable with arbitrary combinations of storage engines

I've addressed all comments, but as indicated I have mostly declined making stylistic changes that alter the existing rocks API names, to maintain consistency with the existing APIs while they are still used in the rest of the codebase. The API should be reviewed for stylistic consistency but I prefer to do that sometime in the future.

brson

comment created time in 6 days

pull request commenttikv/tikv

Make raftstore testable with arbitrary combinations of storage engines

/merge

brson

comment created time in 6 days

Pull request review commenttikv/tikv

Make raftstore testable with arbitrary combinations of storage engines

+// Copyright 2020 TiKV Project Authors. Licensed under Apache-2.0.++//! Engines for use in the test suite, implementing both the KvEngine+//! and RaftEngine traits.+//!+//! These engines link to all other engines, providing concrete single storage+//! engine type to run tests against.+//!+//! This provides a simple way to integrate non-RocksDB engines into the+//! existing test suite without too much disruption.+//!+//! Engines presently supported by this crate are+//!+//! - RocksEngine from engine_rocks+//! - PanicEngine from engine_panic+//!+//! TiKV uses two different storage engine instances,+//! the "raft" engine, for storing consensus data,+//! and the "kv" engine, for storing user data.+//!+//! The types and constructors for these two engines are located in the `raft`+//! and `kv` modules respectively.+//!+//! The engine for each module is chosen at compile time with feature flags:+//!+//! - `--features test-engine-kv-rocksdb`+//! - `--features test-engine-raft-rocksdb`+//! - `--features test-engine-kv-panic`+//! - `--features test-engine-raft-panic`+//!+//! By default, the `tikv` crate turns on `test-engine-kv-rocksdb`,+//! and `test-engine-raft-rocksdb`. This behavior can be disabled+//! with `--disable-default-features`.+//!+//! The `tikv` crate additionally provides two feature flags that+//! contral both the `kv` and `raft` engines at the same time:+//!+//! - `--features test-engines-rocksdb`+//! - `--features test-engines-panic`+//!+//! So, e.g., to run the test suite with the panic engine:+//!+//! ```+//! cargo test --all --disable-default-features --features=protobuf_codec,test-engines-panic+//! ```+//!+//! We'll probably revisit the engine-testing strategy in the future,+//! e.g. by using engine-parameterized tests instead.+//!+//! This create also contains a `ctor` module that contains constructor methods+//! appropriate for constructing storage engines of any type. It is intended+//! that this module is _the only_ module within TiKV that knows about concrete+//! storage engines, and that it be extracted into its own crate for use in+//! TiKV, once the full requirements are better understood.++/// Types and constructors for the "raft" engine+pub mod raft {+    use crate::ctor::{CFOptions, DBOptions, EngineConstructorExt};+    use engine_traits::Result;++    #[cfg(feature = "test-engine-raft-panic")]+    pub use engine_panic::{+        PanicEngine as RaftTestEngine, PanicSnapshot as RaftTestSnapshot,+        PanicWriteBatch as RaftTestWriteBatch,+    };++    #[cfg(feature = "test-engine-raft-rocksdb")]+    pub use engine_rocks::{+        RocksEngine as RaftTestEngine, RocksSnapshot as RaftTestSnapshot,+        RocksWriteBatch as RaftTestWriteBatch,+    };++    pub fn new_engine(+        path: &str,+        db_opt: Option<DBOptions>,+        cfs: &[&str],

I have made this change.

brson

comment created time in 6 days

PullRequestReviewEvent

Pull request review commenttikv/tikv

Make raftstore testable with arbitrary combinations of storage engines

+// Copyright 2020 TiKV Project Authors. Licensed under Apache-2.0.++//! Engines for use in the test suite, implementing both the KvEngine+//! and RaftEngine traits.+//!+//! These engines link to all other engines, providing concrete single storage+//! engine type to run tests against.+//!+//! This provides a simple way to integrate non-RocksDB engines into the+//! existing test suite without too much disruption.+//!+//! Engines presently supported by this crate are+//!+//! - RocksEngine from engine_rocks+//! - PanicEngine from engine_panic+//!+//! TiKV uses two different storage engine instances,+//! the "raft" engine, for storing consensus data,+//! and the "kv" engine, for storing user data.+//!+//! The types and constructors for these two engines are located in the `raft`+//! and `kv` modules respectively.+//!+//! The engine for each module is chosen at compile time with feature flags:+//!+//! - `--features test-engine-kv-rocksdb`+//! - `--features test-engine-raft-rocksdb`+//! - `--features test-engine-kv-panic`+//! - `--features test-engine-raft-panic`+//!+//! By default, the `tikv` crate turns on `test-engine-kv-rocksdb`,+//! and `test-engine-raft-rocksdb`. This behavior can be disabled+//! with `--disable-default-features`.+//!+//! The `tikv` crate additionally provides two feature flags that+//! contral both the `kv` and `raft` engines at the same time:+//!+//! - `--features test-engines-rocksdb`+//! - `--features test-engines-panic`+//!+//! So, e.g., to run the test suite with the panic engine:+//!+//! ```+//! cargo test --all --disable-default-features --features=protobuf_codec,test-engines-panic+//! ```+//!+//! We'll probably revisit the engine-testing strategy in the future,+//! e.g. by using engine-parameterized tests instead.+//!+//! This create also contains a `ctor` module that contains constructor methods+//! appropriate for constructing storage engines of any type. It is intended+//! that this module is _the only_ module within TiKV that knows about concrete+//! storage engines, and that it be extracted into its own crate for use in+//! TiKV, once the full requirements are better understood.++/// Types and constructors for the "raft" engine+pub mod raft {+    use crate::ctor::{CFOptions, DBOptions, EngineConstructorExt};

This is also just carrying over existing names from the rocks apis and again I'd prefer to do API cleanup as a dedicated task elsewhere.

brson

comment created time in 6 days

PullRequestReviewEvent

push eventbrson/tikv

Brian Anderson

commit sha 8ec91d247d1ebb00b01f98784a3c131e3c76c6b2

engine_test: Rename CryptoOpts to CryptoOptions Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 56fb56e5d6fb3b4dce7aeb05e3502056261f0f51

engine_test: Remove extra cf options for raft ctors Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 6 days

Pull request review commenttikv/tikv

Make raftstore testable with arbitrary combinations of storage engines

+// Copyright 2020 TiKV Project Authors. Licensed under Apache-2.0.++//! Engines for use in the test suite, implementing both the KvEngine+//! and RaftEngine traits.+//!+//! These engines link to all other engines, providing concrete single storage+//! engine type to run tests against.+//!+//! This provides a simple way to integrate non-RocksDB engines into the+//! existing test suite without too much disruption.+//!+//! Engines presently supported by this crate are+//!+//! - RocksEngine from engine_rocks+//! - PanicEngine from engine_panic+//!+//! TiKV uses two different storage engine instances,+//! the "raft" engine, for storing consensus data,+//! and the "kv" engine, for storing user data.+//!+//! The types and constructors for these two engines are located in the `raft`+//! and `kv` modules respectively.+//!+//! The engine for each module is chosen at compile time with feature flags:+//!+//! - `--features test-engine-kv-rocksdb`+//! - `--features test-engine-raft-rocksdb`+//! - `--features test-engine-kv-panic`+//! - `--features test-engine-raft-panic`+//!+//! By default, the `tikv` crate turns on `test-engine-kv-rocksdb`,+//! and `test-engine-raft-rocksdb`. This behavior can be disabled+//! with `--disable-default-features`.+//!+//! The `tikv` crate additionally provides two feature flags that+//! contral both the `kv` and `raft` engines at the same time:+//!+//! - `--features test-engines-rocksdb`+//! - `--features test-engines-panic`+//!+//! So, e.g., to run the test suite with the panic engine:+//!+//! ```+//! cargo test --all --disable-default-features --features=protobuf_codec,test-engines-panic+//! ```+//!+//! We'll probably revisit the engine-testing strategy in the future,+//! e.g. by using engine-parameterized tests instead.+//!+//! This create also contains a `ctor` module that contains constructor methods+//! appropriate for constructing storage engines of any type. It is intended+//! that this module is _the only_ module within TiKV that knows about concrete+//! storage engines, and that it be extracted into its own crate for use in+//! TiKV, once the full requirements are better understood.++/// Types and constructors for the "raft" engine+pub mod raft {+    use crate::ctor::{CFOptions, DBOptions, EngineConstructorExt};+    use engine_traits::Result;++    #[cfg(feature = "test-engine-raft-panic")]+    pub use engine_panic::{+        PanicEngine as RaftTestEngine, PanicSnapshot as RaftTestSnapshot,+        PanicWriteBatch as RaftTestWriteBatch,+    };++    #[cfg(feature = "test-engine-raft-rocksdb")]+    pub use engine_rocks::{+        RocksEngine as RaftTestEngine, RocksSnapshot as RaftTestSnapshot,+        RocksWriteBatch as RaftTestWriteBatch,+    };++    pub fn new_engine(+        path: &str,+        db_opt: Option<DBOptions>,+        cfs: &[&str],+        opts: Option<Vec<CFOptions>>,+    ) -> Result<RaftTestEngine> {+        RaftTestEngine::new_engine(path, db_opt, cfs, opts)+    }++    pub fn new_engine_opt(+        path: &str,+        db_opt: DBOptions,+        cfs_opts: Vec<CFOptions>,+    ) -> Result<RaftTestEngine> {+        RaftTestEngine::new_engine_opt(path, db_opt, cfs_opts)+    }+}++/// Types and constructors for the "kv" engine+pub mod kv {+    use crate::ctor::{CFOptions, DBOptions, EngineConstructorExt};+    use engine_traits::Result;++    #[cfg(feature = "test-engine-kv-panic")]+    pub use engine_panic::{+        PanicEngine as KvTestEngine, PanicSnapshot as KvTestSnapshot,+        PanicWriteBatch as KvTestWriteBatch,+    };++    #[cfg(feature = "test-engine-kv-rocksdb")]+    pub use engine_rocks::{+        RocksEngine as KvTestEngine, RocksSnapshot as KvTestSnapshot,+        RocksWriteBatch as KvTestWriteBatch,+    };++    pub fn new_engine(+        path: &str,+        db_opt: Option<DBOptions>,+        cfs: &[&str],+        opts: Option<Vec<CFOptions>>,+    ) -> Result<KvTestEngine> {+        KvTestEngine::new_engine(path, db_opt, cfs, opts)+    }++    pub fn new_engine_opt(+        path: &str,+        db_opt: DBOptions,+        cfs_opts: Vec<CFOptions>,+    ) -> Result<KvTestEngine> {+        KvTestEngine::new_engine_opt(path, db_opt, cfs_opts)+    }+}++/// Create a storage engine with a concrete type. This should ultimately be the+/// only module within TiKv that needs to know about concrete engines. Other+/// code only uses the `engine_traits` abstractions.+///+/// At the moment this has a lot of open-coding of engine-specific+/// initialization, but in the future more constructor abstractions should be+/// pushed down into engine_traits.+///+/// This module itself is intended to be extracted from this crate into its own+/// crate, once the requirements for engine construction are better understood.+pub mod ctor {+    use engine_traits::Result;++    /// Engine construction+    ///+    /// For simplicity, all engine constructors are expected to configure every+    /// engine such that all of TiKV and its tests work correctly, for the+    /// constructed column families.+    ///+    /// Specifically, this means that RocksDB constructors should set up+    /// all properties collectors, always.+    pub trait EngineConstructorExt: Sized {+        /// Create a new engine with either:+        ///+        /// - The column families specified as `cfs`, with default options, or+        /// - The column families specified as `opts`, with options.+        ///+        /// Note that if `opts` is not `None` then the `cfs` argument is completely ignored.+        fn new_engine(+            path: &str,+            db_opt: Option<DBOptions>,+            cfs: &[&str],+            opts: Option<Vec<CFOptions>>,+        ) -> Result<Self>;++        /// Create a new engine with specified column families and options+        fn new_engine_opt(path: &str, db_opt: DBOptions, cfs_opts: Vec<CFOptions>) -> Result<Self>;+    }++    #[derive(Clone)]+    pub enum CryptoOpts {+        None,+        DefaultCtrEncryptedEnv(Vec<u8>),+    }++    #[derive(Clone)]+    pub struct DBOptions {+        encryption: CryptoOpts,+    }++    impl DBOptions {+        pub fn new() -> DBOptions {+            DBOptions {+                encryption: CryptoOpts::None,+            }+        }++        pub fn with_default_ctr_encrypted_env(&mut self, ciphertext: Vec<u8>) {+            self.encryption = CryptoOpts::DefaultCtrEncryptedEnv(ciphertext);+        }+    }++    pub struct CFOptions<'a> {+        pub cf: &'a str,

This is again mirroring pre-existing APIs and I'd like to leave as-is for now.

brson

comment created time in 6 days

PullRequestReviewEvent

Pull request review commenttikv/tikv

Make raftstore testable with arbitrary combinations of storage engines

+// Copyright 2020 TiKV Project Authors. Licensed under Apache-2.0.++//! Engines for use in the test suite, implementing both the KvEngine+//! and RaftEngine traits.+//!+//! These engines link to all other engines, providing concrete single storage+//! engine type to run tests against.+//!+//! This provides a simple way to integrate non-RocksDB engines into the+//! existing test suite without too much disruption.+//!+//! Engines presently supported by this crate are+//!+//! - RocksEngine from engine_rocks+//! - PanicEngine from engine_panic+//!+//! TiKV uses two different storage engine instances,+//! the "raft" engine, for storing consensus data,+//! and the "kv" engine, for storing user data.+//!+//! The types and constructors for these two engines are located in the `raft`+//! and `kv` modules respectively.+//!+//! The engine for each module is chosen at compile time with feature flags:+//!+//! - `--features test-engine-kv-rocksdb`+//! - `--features test-engine-raft-rocksdb`+//! - `--features test-engine-kv-panic`+//! - `--features test-engine-raft-panic`+//!+//! By default, the `tikv` crate turns on `test-engine-kv-rocksdb`,+//! and `test-engine-raft-rocksdb`. This behavior can be disabled+//! with `--disable-default-features`.+//!+//! The `tikv` crate additionally provides two feature flags that+//! contral both the `kv` and `raft` engines at the same time:+//!+//! - `--features test-engines-rocksdb`+//! - `--features test-engines-panic`+//!+//! So, e.g., to run the test suite with the panic engine:+//!+//! ```+//! cargo test --all --disable-default-features --features=protobuf_codec,test-engines-panic+//! ```+//!+//! We'll probably revisit the engine-testing strategy in the future,+//! e.g. by using engine-parameterized tests instead.+//!+//! This create also contains a `ctor` module that contains constructor methods+//! appropriate for constructing storage engines of any type. It is intended+//! that this module is _the only_ module within TiKV that knows about concrete+//! storage engines, and that it be extracted into its own crate for use in+//! TiKV, once the full requirements are better understood.++/// Types and constructors for the "raft" engine+pub mod raft {+    use crate::ctor::{CFOptions, DBOptions, EngineConstructorExt};+    use engine_traits::Result;++    #[cfg(feature = "test-engine-raft-panic")]+    pub use engine_panic::{+        PanicEngine as RaftTestEngine, PanicSnapshot as RaftTestSnapshot,+        PanicWriteBatch as RaftTestWriteBatch,+    };++    #[cfg(feature = "test-engine-raft-rocksdb")]+    pub use engine_rocks::{+        RocksEngine as RaftTestEngine, RocksSnapshot as RaftTestSnapshot,+        RocksWriteBatch as RaftTestWriteBatch,+    };++    pub fn new_engine(+        path: &str,+        db_opt: Option<DBOptions>,+        cfs: &[&str],+        opts: Option<Vec<CFOptions>>,+    ) -> Result<RaftTestEngine> {+        RaftTestEngine::new_engine(path, db_opt, cfs, opts)+    }++    pub fn new_engine_opt(+        path: &str,+        db_opt: DBOptions,+        cfs_opts: Vec<CFOptions>,+    ) -> Result<RaftTestEngine> {+        RaftTestEngine::new_engine_opt(path, db_opt, cfs_opts)+    }+}++/// Types and constructors for the "kv" engine+pub mod kv {+    use crate::ctor::{CFOptions, DBOptions, EngineConstructorExt};+    use engine_traits::Result;++    #[cfg(feature = "test-engine-kv-panic")]+    pub use engine_panic::{+        PanicEngine as KvTestEngine, PanicSnapshot as KvTestSnapshot,+        PanicWriteBatch as KvTestWriteBatch,+    };++    #[cfg(feature = "test-engine-kv-rocksdb")]+    pub use engine_rocks::{+        RocksEngine as KvTestEngine, RocksSnapshot as KvTestSnapshot,+        RocksWriteBatch as KvTestWriteBatch,+    };++    pub fn new_engine(+        path: &str,+        db_opt: Option<DBOptions>,+        cfs: &[&str],+        opts: Option<Vec<CFOptions>>,+    ) -> Result<KvTestEngine> {+        KvTestEngine::new_engine(path, db_opt, cfs, opts)+    }++    pub fn new_engine_opt(+        path: &str,+        db_opt: DBOptions,+        cfs_opts: Vec<CFOptions>,+    ) -> Result<KvTestEngine> {+        KvTestEngine::new_engine_opt(path, db_opt, cfs_opts)+    }+}++/// Create a storage engine with a concrete type. This should ultimately be the+/// only module within TiKv that needs to know about concrete engines. Other+/// code only uses the `engine_traits` abstractions.+///+/// At the moment this has a lot of open-coding of engine-specific+/// initialization, but in the future more constructor abstractions should be+/// pushed down into engine_traits.+///+/// This module itself is intended to be extracted from this crate into its own+/// crate, once the requirements for engine construction are better understood.+pub mod ctor {+    use engine_traits::Result;++    /// Engine construction+    ///+    /// For simplicity, all engine constructors are expected to configure every+    /// engine such that all of TiKV and its tests work correctly, for the+    /// constructed column families.+    ///+    /// Specifically, this means that RocksDB constructors should set up+    /// all properties collectors, always.+    pub trait EngineConstructorExt: Sized {+        /// Create a new engine with either:+        ///+        /// - The column families specified as `cfs`, with default options, or+        /// - The column families specified as `opts`, with options.+        ///+        /// Note that if `opts` is not `None` then the `cfs` argument is completely ignored.+        fn new_engine(+            path: &str,+            db_opt: Option<DBOptions>,+            cfs: &[&str],+            opts: Option<Vec<CFOptions>>,+        ) -> Result<Self>;++        /// Create a new engine with specified column families and options+        fn new_engine_opt(path: &str, db_opt: DBOptions, cfs_opts: Vec<CFOptions>) -> Result<Self>;+    }++    #[derive(Clone)]+    pub enum CryptoOpts {

Will do.

brson

comment created time in 6 days

PullRequestReviewEvent

Pull request review commenttikv/tikv

Make raftstore testable with arbitrary combinations of storage engines

+// Copyright 2020 TiKV Project Authors. Licensed under Apache-2.0.++//! Engines for use in the test suite, implementing both the KvEngine+//! and RaftEngine traits.+//!+//! These engines link to all other engines, providing concrete single storage+//! engine type to run tests against.+//!+//! This provides a simple way to integrate non-RocksDB engines into the+//! existing test suite without too much disruption.+//!+//! Engines presently supported by this crate are+//!+//! - RocksEngine from engine_rocks+//! - PanicEngine from engine_panic+//!+//! TiKV uses two different storage engine instances,+//! the "raft" engine, for storing consensus data,+//! and the "kv" engine, for storing user data.+//!+//! The types and constructors for these two engines are located in the `raft`+//! and `kv` modules respectively.+//!+//! The engine for each module is chosen at compile time with feature flags:+//!+//! - `--features test-engine-kv-rocksdb`+//! - `--features test-engine-raft-rocksdb`+//! - `--features test-engine-kv-panic`+//! - `--features test-engine-raft-panic`+//!+//! By default, the `tikv` crate turns on `test-engine-kv-rocksdb`,+//! and `test-engine-raft-rocksdb`. This behavior can be disabled+//! with `--disable-default-features`.+//!+//! The `tikv` crate additionally provides two feature flags that+//! contral both the `kv` and `raft` engines at the same time:+//!+//! - `--features test-engines-rocksdb`+//! - `--features test-engines-panic`+//!+//! So, e.g., to run the test suite with the panic engine:+//!+//! ```+//! cargo test --all --disable-default-features --features=protobuf_codec,test-engines-panic+//! ```+//!+//! We'll probably revisit the engine-testing strategy in the future,+//! e.g. by using engine-parameterized tests instead.+//!+//! This create also contains a `ctor` module that contains constructor methods+//! appropriate for constructing storage engines of any type. It is intended+//! that this module is _the only_ module within TiKV that knows about concrete+//! storage engines, and that it be extracted into its own crate for use in+//! TiKV, once the full requirements are better understood.++/// Types and constructors for the "raft" engine+pub mod raft {+    use crate::ctor::{CFOptions, DBOptions, EngineConstructorExt};+    use engine_traits::Result;++    #[cfg(feature = "test-engine-raft-panic")]+    pub use engine_panic::{+        PanicEngine as RaftTestEngine, PanicSnapshot as RaftTestSnapshot,+        PanicWriteBatch as RaftTestWriteBatch,+    };++    #[cfg(feature = "test-engine-raft-rocksdb")]+    pub use engine_rocks::{+        RocksEngine as RaftTestEngine, RocksSnapshot as RaftTestSnapshot,+        RocksWriteBatch as RaftTestWriteBatch,+    };++    pub fn new_engine(+        path: &str,+        db_opt: Option<DBOptions>,+        cfs: &[&str],+        opts: Option<Vec<CFOptions>>,+    ) -> Result<RaftTestEngine> {+        RaftTestEngine::new_engine(path, db_opt, cfs, opts)+    }++    pub fn new_engine_opt(

I think it does refer to the fact that the function takes options, but the messy API is legacy cruft. These are just wrappers, with the same names, around existing APIs. There really shouldn't be two constructor functions here that do almost the exact same thing, but for now I've been mostly preserving existing APIs to ease the transition. Eventually these should be cleaned up, but I'd rather not do that now.

brson

comment created time in 6 days

PullRequestReviewEvent

push eventbrson/tikv

Jay

commit sha da71027a3a2f99ff625caaa6ad552eca628a426d

tikv_alloc: fix profiling (#8741) Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

view details

Yilin Chen

commit sha 0b05a9947ca1bc29e090a24a58d8838f1574f9f8

concurrency manager: add memory usage test and lock table benchmarks (#8715) Signed-off-by: Yilin Chen <sticnarf@gmail.com>

view details

Vishnunarayan K I

commit sha 08aed4e161e3340aa8aa34317467a8fd77dc03de

copr: Improve `BitVec` perf (#8747) Signed-off-by: Vishnunarayan K I <appukuttancr@gmail.com>

view details

Xuanwo

commit sha 760551133c63d78bf82420125cd0607302ec675a

copr: Implement non-nullable support for vargs (#8740) Signed-off-by: Xuanwo <github@xuanwo.io>

view details

Yatin Maan

commit sha d6de756ddc3e79eedf74e86f464767fab064a486

copr: Vectorize month_name (#8749) Signed-off-by: yatinmaan <yatinmaan1@gmail.com>

view details

crazycs

commit sha 1f2b76f6b2fbe12a1cbee47079dfa4541720f73d

*: update sysinfo version to fix undiscovered disk information (#8791) Signed-off-by: crazycs520 <crazycs520@gmail.com>

view details

yiwu-arbug

commit sha 4784818535668e0e286edebffe9efe40cd9d25de

rocksdb: Compaction guard: split SST by region boundaries (#8115) Signed-off-by: Yi Wu <yiwu@pingcap.com>

view details

qupeng

commit sha 2cbfc2b4965aa88da5104f89822600b91a7f01b4

implement mvcc consistency check (#8703) Signed-off-by: qupeng <qupeng@pingcap.com>

view details

Yilin Chen

commit sha 7e59be4dae9b6dde0f4575cb030497386fd3b083

test: stablize future_pool::tests::test_tick again (#8795) Signed-off-by: Yilin Chen <sticnarf@gmail.com>

view details

Jay

commit sha 52c8492edec6ede7f4a1705c2a32e86ff38e82a0

tikv-server: enable mem profiling features by default (#8794) Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

view details

Qinxuan Chen

commit sha 5fb90cef4895947abe8f18aefec345b775cc37b8

Remove useless timer pool (#8782) Signed-off-by: koushiro <koushiro.cqx@gmail.com>

view details

Liu Cong

commit sha 5a9a3284ef4a4e1832d1ceda5f49f5beb27dd663

metrics: add fast tune panals (#8798) Signed-off-by: Liu Cong <innerr@gmail.com>

view details

Yilin Chen

commit sha d810b9de30c89b3ee4fd5e1090b0ada3d750b770

txn: remove async commit configurations (#8753) Signed-off-by: Yilin Chen <sticnarf@gmail.com>

view details

cfzjywxk

commit sha a83a240737f2bf379b6662c84b9152c7758eea09

txn: move scheduler process counter into worker (#8773) Signed-off-by: cfzjywxk <lsswxr@163.com>

view details

Lei Zhao

commit sha f88f88a5f34724d06bea062329ce0e71ad4b9e40

tikv_util: use singleton sysinfo::System (#8799) Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

view details

Jay

commit sha e6d6c19b9013adc53fecdd26621b476fe2ce3810

*: cleanup dependencies (#8803) Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

view details

5kbpers

commit sha c29df878d216914852884b62557e157452d4ba49

Makefile: do not gen error code before build (#8807) Signed-off-by: 5kbpers <tangminghua@pingcap.com>

view details

Wallace

commit sha fae016ec4ce5776d7336163274af881f8fb041fc

Ingest SST instead of writing memtable directly when delete a large range of keys. (#7794) Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

view details

Jay

commit sha a6485f37ba2d46b70ffe07441021fa6de375fbf7

*: remove setup configuration of jemalloc profile (#8813) Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

view details

Liu Cong

commit sha 68d6487263fc6ecfe67fb490b7b5574469044f38

metrics: add write-batch-size-too-big panels to Fast-Tune (#8812) Signed-off-by: Liu Cong <innerr@gmail.com>

view details

push time in 6 days

push eventbrson/tikv

Greg Weber

commit sha 2a2fa03da53b63f3fc24d7ea53aead40176979b5

fix links to point to tikv instead of pingcap (#8776) Signed-off-by: Greg Weber <greg@pingcap.com>

view details

Patrick Jiang(白泽)

commit sha 16643d839eb0fa38e798aa699116fc09a62eede6

*: update rust-rocksdb version to fix build failed (#8784) Signed-off-by: Patrick <patrickjiang0530@gmail.com>

view details

Brian Anderson

commit sha 865eebbe0e48b9073cd6fbe35c4f57a34e60e865

Add engine_test crate https://github.com/tikv/tikv/issues/8452 Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 33991cec3d26f2d6dbffe53e827e47ba4649aba6

engine_test: Keep hacking on engine constructors Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 2249e55f8de8a3537137c614cae8ce24b755408e

engine_test: Make engine ctors look like rocks engine ctors Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 2db1aee7e446cadd31790f93d3fba34fc2a14d32

engine_test: ColumnFamilyOptions is clonable Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 1cfbe4fff751a09919f49eafa2fcc9514b709cf9

raftstore: Convert to engine_test Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 88c3b0dd60ad99a5fa257acf103060d6ebba5d9f

raftstore: Convert to engine_test Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 9b25ec5407fa7c33516f20aa37899fd50f26fde8

engine_test: Add no_range_properties to ColumnFamilyOptions Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 3a2aec65ffc0feeb0eacc6dd2697d83790f1d010

engine_test: Add disable_auto_compactions to ColumnFamilyOptions Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha f4b4e74ab26519f73b54a8701824f637b25a8f49

raftstore: Convert to engine_test Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 67f11104efa968a5be0ee6ebd388e23df8bac5b3

engine_traits: Add set_level_zero_file_num_compaction_trigger and set_disable_auto_compactions to ColumnFamilyOptions Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 5f31b40c0363fcf1030c148ac19567d8d6d21420

engine_test: Avoid raw APIs Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha fc5039bd249ed74f32fe0b20d70a0ddd4806eea5

engine_test: Add new_engine ctor function Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 9dcbb7fcf733bb388323c072962dc0c77467e413

raftstore: Convert to engine_test Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 6ef2f473fb72d59af62260928c5a43723ebefa25

raftstore: Convert to engine_test Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha eb1d28d7736010a99e119881d6613a292d32f7fe

engine_test: Create defs for KvTestSnapshot and RaftTestSnapshot Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 1d1ef37ab41835dbaf53363703eda04f86d0f35c

raftstore: Convert to engine_test Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha dfae5e4beefb459e64259319cc7cbda8e9adfef6

raftstore: Convert to engine_test Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 7a2a9f88000de79418b4645f1ae87990d6e420a0

raftstore: Use KvTestEngine instead of RocksEngine Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 6 days

push eventbrson/blocksy2

Brian Anderson

commit sha 045177429e4d794ac3fbbf4dc5b898a1a2f4ad80

.

view details

push time in 9 days

push eventbrson/blocksy2

Brian Anderson

commit sha ef58662009a1a5dad1ca9f077fe8ba0cdcaf97a7

.

view details

Brian Anderson

commit sha 196ce170919763b68a8fdeea1946b019ce55fa33

.

view details

push time in 9 days

push eventbrson/blocksy2

Brian Anderson

commit sha e6ed9cd164cc58427806f2e82923a2d575e41709

.

view details

push time in 9 days

push eventbrson/blocksy2

Brian Anderson

commit sha 92cb62dc5911af0b700ce5412c5a85101ba4ab94

.

view details

push time in 9 days

push eventbrson/blocksy2

Brian Anderson

commit sha e1b51e42a9fca4008db659fd88380898a2c5af22

.

view details

push time in 9 days

push eventbrson/blocksy2

Brian Anderson

commit sha 4fc51c4092107d1f9a42206bf253a884bb39b105

.

view details

Brian Anderson

commit sha 70dc36d1794496397625301257e0388d2f3326ff

.

view details

push time in 9 days

push eventbrson/blocksy2

Brian Anderson

commit sha ec9502506efae2f2177bcaf32d3a9b78b17c845a

.

view details

push time in 9 days

push eventbrson/blocksy2

Brian Anderson

commit sha 0700cb528ca1e75800d97427cd5d96662f559f90

.

view details

Brian Anderson

commit sha 63cc5c650846cb42bdbca0fb8bbb61560b085e0b

.

view details

Brian Anderson

commit sha de5cfd55389b1ad15ddff0e4eddbec007dc3f3a3

.

view details

Brian Anderson

commit sha 2669cfac578933493e4d2cb529434ef8c602f9fb

.

view details

Brian Anderson

commit sha 1c3f77509d7633753b19f06ff062898259c79cd2

.

view details

push time in 9 days

push eventbrson/blocksy2

Brian Anderson

commit sha 2cf0dcf77c54a15b776954ca35d2a3c06311ea60

.

view details

push time in 11 days

push eventbrson/blocksy2

Brian Anderson

commit sha 8451a57e95572b54d6f62fe5d867c5958f559e5d

.

view details

push time in 11 days

push eventbrson/blocksy2

Brian Anderson

commit sha 7cb5c3ccfaf709bea4df0480e9b1d3bee36be6a0

.

view details

Brian Anderson

commit sha 00c0fd54726bd8d1f7461817f42a65c8764c829a

.

view details

push time in 11 days

push eventbrson/blocksy2

Brian Anderson

commit sha c724ea6bf9d5a3364fade2eb22db36ded87310ea

.

view details

Brian Anderson

commit sha 01e942a99384af4db8b33796fc0fa79a71f412f5

.

view details

Brian Anderson

commit sha 022422b36a7da78256d870eac78a4f08de3caac3

.

view details

Brian Anderson

commit sha 12b298c45ed9d232bcaf5b6fdc08972a23c23cc3

.

view details

push time in 11 days

push eventbrson/blocksy2

Brian Anderson

commit sha 56fb2ad56c18d0add1e836c0f06068186b1d201e

.

view details

Brian Anderson

commit sha 6ca48aeb596cb5c7c9a8fbba4c1244a41f081ee8

.

view details

Brian Anderson

commit sha 160e37e04419e75b7ba931dded089addc686bd8e

.

view details

push time in 11 days

push eventbrson/blocksy2

Brian Anderson

commit sha b6a6b5f5db4aa76f4a4121b80a51b9a96f7c9536

.

view details

push time in 13 days

push eventbrson/blocksy2

Brian Anderson

commit sha 5686eebaaeb8b410424348c2718ba141e559beea

.

view details

push time in 13 days

push eventbrson/blocksy2

Brian Anderson

commit sha a0f8d66d433311faca235d855b7f0f21bb9b1850

.

view details

Brian Anderson

commit sha 1f3aa41ef85a714fe3b1cc4721629ab65be7f141

.

view details

push time in 13 days

push eventbrson/blocksy2

Brian Anderson

commit sha a5cac8d972af5a416898b5334cbf9abc06541fc9

.

view details

push time in 13 days

push eventbrson/blocksy2

Brian Anderson

commit sha 80e16b8cddf00721f03595f0558cb6c357585006

.

view details

push time in 13 days

push eventbrson/blocksy2

Brian Anderson

commit sha fa117bf66396d272ed2caf144029c722e3980f87

.

view details

Brian Anderson

commit sha 5311b5fe5cc53623fb0e4bc65e4c4870e7b55822

.

view details

Brian Anderson

commit sha 7b288e8f6ef1bfbe92c570599dbc82cd30d24065

.

view details

Brian Anderson

commit sha 11161a2e4b5b21e6e2b3462c2c8f7dbfb446ba2c

.

view details

push time in 13 days

push eventbrson/blocksy2

Brian Anderson

commit sha 076bf5c31bd0ed1413b2aab39429e04188bfa34e

.

view details

Brian Anderson

commit sha 4ab800cf6fe8efd46cbba0a94ef5f0c60708064a

.

view details

Brian Anderson

commit sha 945e5b90cd13f734bd79eb6a64f3d43849a1c46e

.

view details

Brian Anderson

commit sha ed99759a8c64bb756830707577cf25dc7598615e

.

view details

push time in 13 days

push eventbrson/blocksy2

Brian Anderson

commit sha d7eb6b5fc181893c1f4d152bb0109aa77b69633b

.

view details

Brian Anderson

commit sha 7d0faeca0088dbf5dd5086f8e0f0090041d3dd1b

.

view details

Brian Anderson

commit sha 33dc10cc5f372a206b84c627e8c161b738e024f4

.

view details

Brian Anderson

commit sha e8f549229e1508f5501d08b36d52ec5c0384b2fa

.

view details

Brian Anderson

commit sha 85472013e0db9638f71848464b73199a549adb57

.

view details

push time in 13 days

push eventbrson/blocksy2

Brian Anderson

commit sha c0a3b5f85b6f351872b71e9b732f84c34798a2a9

.

view details

push time in 13 days

push eventbrson/blocksy2

Brian Anderson

commit sha 2276fce8c0ebd4f73bfc70275bcd90a93ea76291

.

view details

Brian Anderson

commit sha e782864d09a052e59f83963edd49893d8d1a8bbd

.

view details

Brian Anderson

commit sha 2bd2f0fce6796237a920d7a61f87176e4bf6c10b

.

view details

Brian Anderson

commit sha 2b79914035d9327ff67bd22a77e308e915fc881b

.

view details

Brian Anderson

commit sha fa2a816e66d659bb26c35d42c746fa034ab0946a

.

view details

Brian Anderson

commit sha d7534d30ae33be8938149627cc44271994d734c7

.

view details

Brian Anderson

commit sha 91c15813aa4d2663d6233aa6ecc474bcae3382de

.

view details

Brian Anderson

commit sha ff1671603296b7c2a0892bf91acd68f7dcc77741

.

view details

Brian Anderson

commit sha be0d98fdfc1706ca39b86b2d025a69ba3020cdb4

.

view details

Brian Anderson

commit sha a3509776c927507b0a1c590e5318d1e72ec61620

.

view details

Brian Anderson

commit sha 4cb8991e47f92224ccb48a1e872c3763baebcf41

.

view details

Brian Anderson

commit sha 57738e15cf3a28731e677686dd720100fd619980

.

view details

Brian Anderson

commit sha 67e93918a4dcc7300fe91fd36269094184f9df0d

.

view details

Brian Anderson

commit sha 6d9ddf7f0ed6ab025ae8666b2b096d4e389a796a

.

view details

push time in 13 days

push eventbrson/blocksy2

Brian Anderson

commit sha 91a444fe1830b8ba8b57ad88b2ad275ee88819c7

.

view details

push time in 14 days

push eventbrson/blocksy2

Brian Anderson

commit sha a4d0a9e141da04d2c9e0f8edaa231216ce2834b2

.

view details

Brian Anderson

commit sha 05f53201e70c7063d17653e5e7c11ff47952efd8

.

view details

Brian Anderson

commit sha b284d4513cf8092955a0b6fc6ef1f4aa1ee245d7

.

view details

Brian Anderson

commit sha d65eaa74b43d03c10cf70a49d5f5fd7c2aea3ac6

.

view details

Brian Anderson

commit sha 632c2f18c915bde273fbe0ae21378abd2143f1ef

.

view details

Brian Anderson

commit sha 4ebc897c4c5e09b54d4711ebde2203575293d01c

.

view details

Brian Anderson

commit sha 2a1c391bcb8eccb7063e11b7223a85ee86691c46

.

view details

Brian Anderson

commit sha b4f42506288dd6c231d1249da52756ef7534fca5

.

view details

Brian Anderson

commit sha ce880f5b1f4f33aadee720b1f0d5cf92052c4884

.

view details

Brian Anderson

commit sha 17137d6fd503037415c4dab8a791682b4bb319d7

.

view details

Brian Anderson

commit sha 921064998fb79dde63ff9ec9c5152819553fc8a0

.

view details

Brian Anderson

commit sha b2688d5857010b013292d7a2de77d5807391b01f

.

view details

push time in 14 days

push eventbrson/blocksy2

Brian Anderson

commit sha 00c5805030052bc8727f5faa61e5b60ff8ff55ac

.

view details

push time in 14 days

push eventbrson/blocksy2

Brian Anderson

commit sha 7525b42cd6f2d112128751c34750fd2198961d79

.

view details

push time in 14 days

push eventbrson/blocksy2

Brian Anderson

commit sha 29aeb47fa880ba50e82b7bd4b608fb1ffb654c04

.

view details

Brian Anderson

commit sha 3044a321e2cfdcde38a0b5d796a17d574c7127da

.

view details

Brian Anderson

commit sha af89f8d272a43c56a3d24d169b60348b6c8004a3

.

view details

Brian Anderson

commit sha d7f7fb633c7cb1a2d8ead187a1c8f735b06bb12c

.

view details

Brian Anderson

commit sha 8916f19b2c4ae1c0dc4becdc12c3d6a6d3b52b28

.

view details

Brian Anderson

commit sha df8b44ec902c434518bea3fae05d926a5cf4a859

.

view details

push time in 14 days

push eventbrson/blocksy2

Brian Anderson

commit sha 163885f82d57ad597930f5f1276f66b9889eee17

Derive Debug Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 2b3d3ad264b07cbbf05ae8e48b62461a2b47778b

.

view details

Brian Anderson

commit sha b75cde01e079fcaa415cbc7bbcd1a8d6461c9c97

.

view details

push time in 14 days

push eventbrson/blocksy2

Brian Anderson

commit sha 13f04d76d8ca2be41349b09139e372da65fbe2f6

.

view details

push time in 14 days

push eventbrson/blocksy2

Brian Anderson

commit sha 95d48b3a5f6df5e5fdd2d4ee9bd47ebb76351110

.

view details

push time in 14 days

create barnchbrson/blocksy2

branch : master

created branch time in 14 days

created repositorybrson/blocksy2

created time in 14 days

more