profile
viewpoint

bricef/dotfiles 4

My linux dotfiles and utility scripts

bricef/bmenu 3

A simple gtk menu utility that supports dynamic menus and arbitrary depth. A dirt simple gtk clone of OpenBox's menus.

bricef/dcpu16-lisp 2

Lisp Compiler and interpreter for Notch's DCPU16

bricef/ant-sim 1

Simulation of pheromone deposition in Pharaoh's Ants

bricef/electronics-intro 1

An Introduction to electronics: A course in elementary electronics.

bricef/aha 0

Ansi HTML Adapter

issue openedweaveworks/grafanalib

SeriesOverride object needs @attr.s

Should this object need a class decorator @attr.s?

created time in 2 hours

startedjirilebl/diffyqs

started time in 4 hours

issue commentcortexproject/cortex

Docs: Update the Architecture Section about the Ring

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

gotjosh

comment created time in 6 hours

issue commentcortexproject/cortex

Fix deprecated gRPC naming.Watcher

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

zendern

comment created time in 6 hours

issue commentcortexproject/cortex

Support multiple regions with disjoint ingesters and DB replication

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

ThePants999

comment created time in 6 hours

issue commentcortexproject/cortex

Make each ingester use its own key in the ring

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

gouthamve

comment created time in 6 hours

issue commentcortexproject/cortex

query-frontend: Response caching should work for subqueries and part queries.

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

bwplotka

comment created time in 6 hours

issue commentcortexproject/cortex

DynamoDB: Make min usage for scaledown configurable

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

dcherman

comment created time in 6 hours

issue commentcortexproject/cortex

TSDB unloading

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

pstibrany

comment created time in 6 hours

issue commentcortexproject/cortex

Reduce the risk of having unregistered metrics

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

pracucci

comment created time in 6 hours

PR closed cortexproject/cortex

Selectively disable Indexing of Labels size/XL stale

<!-- Thanks for sending a pull request! Before submitting:

  1. Read our CONTRIBUTING.md guide
  2. Rebase your PR if it gets out of sync with master -->

What this PR does: This PR introduces a new config under the chunk_store section called as exclude labels. These labels are skipped from the lookup_series_from_matchers function inside series_store. Hence reducing index lookups.

Signed-off-by: Jay Batra jaybatra73@gmail.com

Which issue(s) this PR fixes: Fixes #2068

Checklist

  • [x] Tests updated
  • [ ] Documentation added
  • [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
+492 -36

3 comments

10 changed files

jaybatra26

pr closed time in 6 hours

issue commentweaveworks/kured

lock on a separate/safe object rather than DaemonSet

still relevant.

anguslees

comment created time in 10 hours

pull request commentfluxcd/flux

Adding rollout strategy variable for Flux deployment in chart

Great! To pass the DCO check, follow these instructions: https://github.com/fluxcd/flux/pull/3325/checks?check_run_id=1475249188. If you are happy rebasing, rebasing on master from this repo will remove the "out-of-date" message too (but I can do that rebase if you're not comfortable doing it).

Rebased and signoff =) Should I bump the chart's version (I think it's a minor, new feature but not a breaking one, but can be seen as a fix too) or it's automatic with the Continuous Integration ?

ViBiOh

comment created time in 10 hours

Pull request review commentweaveworks/kured

implement issue-19 add prefer no schedule taint to avoid double draining of pods

 func rebootAsRequired(nodeID string, window *timewindow.TimeWindow, TTL time.Dur 		release(lock) 	} +	if !rebootRequired() {+		preferNoSchedule(client, nodeID, false)+	}+ 	source := rand.NewSource(time.Now().UnixNano()) 	tick := delaytick.New(source, period) 	for range tick {-		if window.Contains(time.Now()) && rebootRequired() && !rebootBlocked(client, nodeID) {-			node, err := client.CoreV1().Nodes().Get(context.TODO(), nodeID, metav1.GetOptions{})-			if err != nil {-				log.Fatal(err)-			}-			nodeMeta.Unschedulable = node.Spec.Unschedulable--			if acquire(lock, &nodeMeta, TTL) {-				if !nodeMeta.Unschedulable {-					drain(client, node)-				}-				commandReboot(nodeID)-				for {-					log.Infof("Waiting for reboot")-					time.Sleep(time.Minute)-				}-			}+		if !window.Contains(time.Now()) {+			continue+		}++		if !rebootRequired() {+			continue+		}++		preferNoSchedule(client, nodeID, true)++		if rebootBlocked(client, nodeID) {+			continue+		}++		node, err := client.CoreV1().Nodes().Get(context.TODO(), nodeID, metav1.GetOptions{})+		if err != nil {+			log.Fatal(err)+		}+		nodeMeta.Unschedulable = node.Spec.Unschedulable++		if !acquire(lock, &nodeMeta, TTL) {+			continue

I added a comment for the untaint outside the loop, moved the tainting inside the check for rebootBlocked, and added a untaint to allow for the the reboot window.

Taints got their own package and better naming, the bool is hidden.

Does this look good to you?

damoon

comment created time in 11 hours

Pull request review commentweaveworks/kured

Force golang version

 jobs:     steps:       - name: Checkout         uses: actions/checkout@v2-        with:-          fetch-depth: "0"

I'm not sure if this can be removed. The chart-testing-action uses the changes to find the charts which are changed. That's the default behavior unless it is specified otherwise in the ct.yaml

evrardjp

comment created time in 11 hours

pull request commentfluxcd/flux

Adding rollout strategy variable for Flux deployment in chart

Great! To pass the DCO check, follow these instructions: https://github.com/fluxcd/flux/pull/3325/checks?check_run_id=1475249188. If you are happy rebasing, rebasing on master from this repo will remove the "out-of-date" message too (but I can do that rebase if you're not comfortable doing it).

ViBiOh

comment created time in 11 hours

pull request commentfluxcd/flux

Adding rollout strategy variable for Flux deployment in chart

I would just hard-wire the strategy to Recreate.

I've updated my pull-request (and the associated comment) to reflect this ;)

ViBiOh

comment created time in 12 hours

pull request commentfluxcd/flux

Adding rollout strategy variable for Flux deployment in chart

I didn't want to enforce the strategy or break existing behavior

Ah I see, you were being careful -- I shan't argue with that :-)

I expect people do not notice that it's defaulting to rolling update, and would not notice a change. Previously there was no way to override the strategy, and there is no reason to run more than one replica. I would just hard-wire the strategy to Recreate.

ViBiOh

comment created time in 12 hours

PR closed fluxcd/flux

Upgrade to kubectl 1.17.12

This PR updates kubectl to 1.17.12

kubectl versions with patch versions lower than v1.18.8 v1.17.11 or v1.16.14 have issues updating CRD files, due to a bug when handling deeply nested CRDs. This bug will make kubectl apply -f [...] hang. Ref: https://cert-manager.io/docs/installation/upgrading/upgrading-0.15-0.16/

+23 -12

5 comments

3 changed files

dabeck

pr closed time in 12 hours

pull request commentfluxcd/flux

Upgrade to kubectl 1.17.12

kubectl was updated to 1.18.9 in #3309. I think this will fix the particular problem of updating CRD files, @dabeck. We may have to stick with packages from 1.17 for now, as noted in #3309. I'm going to close this PR, since it's probably not possible to make progress, and the substantive issue is fixed (and release in 1.21.0). Thanks!

dabeck

comment created time in 12 hours

push eventfluxcd/flux

Joao Vitor Lacerda Guimaraes

commit sha 5e92d88053acbae0f84b9b2c16c027450e477cba

sets memcached namespace as required by flux deployment https://github.com/fluxcd/flux/blob/master/chart/flux/templates/deployment.yaml#L208 ``` - --memcached-hostname={{ .Values.memcached.hostnameOverride | default (printf "%s-memcached" (include "flux.fullname" .)) }} ``` Signed-off-by: Joao Vitor Lacerda Guimaraes <joaog@ciandt.com>

view details

Michael Bridgen

commit sha 26b2e68736891e4ea2b7b4a1701ea37d592d3c2a

Merge pull request #3346 from joaovitor/memcache_namespace sets memcached namespace as required by flux deployment

view details

push time in 12 hours

PR merged fluxcd/flux

sets memcached namespace as required by flux deployment

sets memcached namespace as required by flux deployment

The deployment of helm chart requires the memcache service in the same namespace of flux deployment. This small change sets the namespace in the service deployment.


https://github.com/fluxcd/flux/blob/master/chart/flux/templates/deployment.yaml#L208

- --memcached-hostname={{ .Values.memcached.hostnameOverride | default (printf "%s-memcached" (include "flux.fullname" .)) }}
+1 -0

0 comment

1 changed file

joaovitor

pr closed time in 12 hours

issue openedfluxcd/flux

Bump kubectl and packages to 1.18

created time in 12 hours

pull request commentfluxcd/flux

Adding rollout strategy variable for Flux deployment in chart

I'm curious about the use case you have in mind. In general you don't want or need any more than one flux pod of a particular deployment running; so Recreate is the only sensible strategy (I'm surprised it's not just inlined into the chart).

Yep exactly, I want the Recreate strategy but as there is no strategy defined, the default strategy is RollingUpdate which cause to have 2 pods running at the same time.

I didn't want to enforce the strategy or break existing behavior for others users, so I've setted it under condition.

ViBiOh

comment created time in 12 hours

Pull request review commentweaveworks/kured

Implement universal notification mechanism using shoutrrr

 func main() { 	rootCmd := &cobra.Command{ 		Use:   "kured", 		Short: "Kubernetes Reboot Daemon",+		PreRun: flagcheck,

I feel it is a good place since it will not be inherited to the children, and the arguments should be loaded also.

atighineanu

comment created time in 12 hours

startedravwojdyla/pyspark_gcs

started time in 13 hours

pull request commentfluxcd/flux

Adding rollout strategy variable for Flux deployment in chart

I'm curious about the use case you have in mind. In general you don't want or need any more than one flux pod of a particular deployment running; so Recreate is the only sensible strategy (I'm surprised it's not just inlined into the chart).

ViBiOh

comment created time in 13 hours

startedsimeonschaub/ArtifactUtils.jl

started time in 13 hours

PR opened weaveworks/kured

Force golang version

Without this, golang version used is the golang version decided by github.

This should be deterministic.

+61 -8

0 comment

5 changed files

pr created time in 13 hours

issue closedweaveworks/kured

"Failed to build time window: unknown time zone America/New_York" error when using timeZone flag

Using the kured helm chart version 2.1.1 with the 1.4.5 kured release, with the configuration.timeZone: "America/New_York" setting (see HelmRelease yaml), kured pods fail to start up crashing with the following error:

"Failed to build time window: unknown time zone America/New_York"

I also tried setting the value to EST5EDT and the same error occurs.

The golang time module documentation even shows America/New_York as an example for a timezone to use.

closed time in 14 hours

billimek
more