profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/brianteeman/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Brian Teeman brianteeman United Kingdom https://brian.teeman.net Co-founder @Joomla

brianteeman/btvideo 5

Joomla Custom Field - The video displays just like a regular embed but approximately 224× faster

brianteeman/cleanedit 3

A Joomla 4 system plugin to make editing content distraction free.

brianteeman/btvideo-module 1

Joomla Module - The video displays just like a regular embed but approximately 224× faster

brianteeman/ableplayer 0

fully accessible cross-browser HTML5 media player.

brianteeman/accessibility 0

add accessibility to your website

brianteeman/acymailing6 0

A newsletter plugin for Wordpress and Joomla

brianteeman/AnimatedGridLayout 0

A responsive, magazine-like website layout with a grid item animation effect when opening the content

brianteeman/AnimatedGridLayout-1 0

Animated Grid Layout - a fork from

brianteeman/AssetFix 0

Application for fixing assets

brianteeman/ATEM_tally_light_with_ESP8266 0

Wireless tally light for use with ATEM switchers, which connects over WiFi, using a D1 mini board (ESP8266 WiFi module).

pull request commentjoomla/joomla-cms

[4.0] Add class to CLOSE button

RTC<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/33775">issues.joomla.org/tracker/joomla-cms/33775</a>.</sub>

rjharishabh

comment created time in a minute

pull request commentjoomla/joomla-cms

[4.0] Add class to CLOSE button

I have tested this item :white_check_mark: successfully on 50871abf2cea529df2fad9c1bb9f5932837c86f4<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/33775">issues.joomla.org/tracker/joomla-cms/33775</a>.</sub>

rjharishabh

comment created time in 4 minutes

issue commentjoomla/joomla-cms

[4.0] [Media] Save without page reload + strange editing logic

I was able to reproduce all 3 of these. Issues confirmed.

Kostelano

comment created time in 11 minutes

issue openedjoomla/joomla-cms

[4.0] [Media] Save without page reload + strange editing logic

Steps to reproduce the issue

Go to Media Manager, select any image to edit.

  1. For example, on the rotation tab, make changes to the image quality and degrees (use the buttons 0/90/180/270). Press the RESET button. The image returns to its original position, but the indicators themselves in the fields are in place (unchanged).

  2. If you click on the button to save the image, this will happen, as practice has shown, but without reloading the page. At the same time, there is no information / progress bar for the user.

  3. Does the image quality change work ONLY in combination with other parameters? If I make changes only to the quality (reduce, for example, to 10), after saving the image does not change the file size (respectively, the quality too). If, along with decreasing the quality, I make any other changes (rotation, cropping, etc), the image changes. Why can't I make only quality changes? The size of the image width / height may suit me.

Screenshot_3

  1. Arrows in the fields do not work (everywhere according to Joomla 4). In Joomla 3, these arrows work.

Screenshot_4

created time in 36 minutes

issue openedjoomla/joomla-cms

[4.0] cachetime and cache_path in configuration hidden

Steps to reproduce the issue

  • When you disable caching in Joomla configuration the fields cachetime and cache_path will be hidden by showon events.

Expected result

  • Never hidden because are used by the Cache class used e.g. by plg_system_cache and lots of 3rd extensions and codes taht use these basic settings.

Additional comments

  • It happened intentionally that these fields are not hidden. There were already discussions in the past.

created time in an hour

issue openedjoomla/joomla-cms

[4.0] Notification on the associations tab (in menu options)

Steps to reproduce the issue

Include the multilingual associations component / language filter plugin. Go to the menu, select, for example, the menu item HOME. On the associations tab:

  1. If the item is not assigned a language, the legend does not contain parameters. In this case, it is better to hide the legend or display the notification inside the legend.

  2. The type of notification does not match the Joomla styles 4. Or am I wrong? On the next tab (and in other places too), the notification style is different.

Screenshot_1

Notification in another tab:

Screenshot_2

created time in an hour

issue closedjoomla/joomla-cms

[4.0b1] uploading disallowed media gives generic error message

Steps to reproduce the issue

from a default install of Joomla 4 try to upload a PHP or zip file in media manager in admin

Expected result

A specific message saying this file type is not allowed.

Actual result

Generic unhelpful message Screenshot 2020-06-08 at 17 34 35

The Ajax call returns no message

{"success":false,"message":"","messages":null,"data":null}

closed time in 2 hours

PhilETaylor

issue commentjoomla/joomla-cms

[4.0b1] uploading disallowed media gives generic error message

Closing as duplicate of #33702.

PhilETaylor

comment created time in 2 hours

pull request commentjoomla/joomla-cms

[4.0] com_cpanel submenu

RTC<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/33811">issues.joomla.org/tracker/joomla-cms/33811</a>.</sub>

brianteeman

comment created time in 2 hours

pull request commentjoomla/joomla-cms

[4.0] Fix Modules Filter

Nothing else than what I have said.

joomdonation

comment created time in 2 hours

pull request commentjoomla/joomla-cms

[4.0] com_cpanel submenu

Sorry, I'm confused. Not in this PR. But I was talking about comment https://github.com/joomla/joomla-cms/pull/33808#issuecomment-839154832.

brianteeman

comment created time in 2 hours

pull request commentjoomla/joomla-cms

[4.0] com_cpanel submenu

I have tested this item :white_check_mark: successfully on eb450a116ee017c09ce95016779afe7e18753076<br /><br />PR works. The only thing that is confusing is what Phil mentioned - the problem of underlining for external links. <hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/33811">issues.joomla.org/tracker/joomla-cms/33811</a>.</sub>

brianteeman

comment created time in 2 hours

issue closedjoomla/joomla-cms

[4.0] Private Messages: you can write (answer) to yourself

Steps to reproduce the issue

After creating a personal data request like in issue https://github.com/joomla/joomla-cms/issues/33810, you can now send yourself a message.

You, as an administrator, have received a notification that a user has requested data.

Screenshot_4

You can read the notification and reply to yourself. Yes, I agree that this is pointless and nonsense. But that's a catch.

The system should issue an error message when sending such a response.

You are simply not on the list of users to which you can send a message. And here - you are already entered into the field.

Screenshot_5

closed time in 2 hours

Kostelano

pull request commentjoomla/joomla-cms

Fix com media layout

I have tested this item :white_check_mark: successfully on 6c926b64c074a9796da373993d19f1274e5dd62c<br /><br />Real retest, it works. <hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/33753">issues.joomla.org/tracker/joomla-cms/33753</a>.</sub>

eopws

comment created time in 2 hours

pull request commentjoomla/joomla-cms

[4.0] Remove obsolete table "#__csp" from support.sql so it's not created on new installations

RTC<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/33835">issues.joomla.org/tracker/joomla-cms/33835</a>.</sub>

richard67

comment created time in 2 hours

pull request commentjoomla/joomla-cms

[4.0] Remove obsolete table "#__csp" from support.sql so it's not created on new installations

I have tested this item :white_check_mark: successfully on 242da63d97a529e65fd3d0cb6ee454d10e9bbeb6<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/33835">issues.joomla.org/tracker/joomla-cms/33835</a>.</sub>

richard67

comment created time in 2 hours

pull request commentjoomla/joomla-cms

[4.0] Fix Modules Filter

@Stuartemk No, it's not valid syntax. For type casting, we will still have to use the original code:

$filters = (array) $app->getUserState('com_modules.modules.' . $clientId . '.filter');
joomdonation

comment created time in 3 hours

pull request commentjoomla/joomla-cms

[4.0] Fix Modules Filter

Maybe I'm confused, but I think this should be changed

$filters = (array) $app->getUserState('com_modules.modules.' . $clientId . '.filter');

for this

$filters = [ ] $app->getUserState('com_modules.modules.' . $clientId . '.filter');

Regards

joomdonation

comment created time in 3 hours

issue commentjoomla/joomla-cms

Custom field param of subform type not accesible in component as com_fields inserted custom field.

Could you provide step-by-step instruction on how to reproduce the issue?

mperaya

comment created time in 3 hours

issue commentjoomla/joomla-cms

Read more stops working if a category or menu or the same alias exists

After the new information i cannot conform the issue.

uglyeoin

comment created time in 3 hours

pull request commentjoomla/joomla-cms

[4.0] Remove duplicate scss lines for form stylings

Thank you @eyvazahmadzada for your contribution. You need to check the classes before removing the duplicates: if a class is a Bootstrap class (e.g. form-check) a override of the class should be in the file administrator/templates/atum/scss/vendor/bootstrap/_form.scss, if the class is specific for Atum, the class should be in administrator/templates/atum/scss/blocks/_form.scss. At least that is the logic I would expect from the scss files in the template. Yes, you're right, that makes more sense. I've made a new commit to place stylings in their appropriate file.

eyvazahmadzada

comment created time in 4 hours

issue commentjoomla/joomla-cms

[4.0] Smart Search: New Filter: select switch not working + language constant problem

@Kostelano Can you provide more system information, please?

Kostelano

comment created time in 4 hours

pull request commentjoomla/joomla-cms

[4.0] Remove duplicate scss lines for form stylings

Thank you @eyvazahmadzada for your contribution. You need to check the classes before removing the duplicates: if a class is a Bootstrap class (e.g. form-check) a override of the class should be in the file administrator/templates/atum/scss/vendor/bootstrap/_form.scss, if the class is specific for Atum, the class should be in administrator/templates/atum/scss/blocks/_form.scss. At least that is the logic I would expect from the scss files in the template.

eyvazahmadzada

comment created time in 4 hours

pull request commentjoomla/joomla-cms

Fixed layout of extension name position in com_installer

Instead of adding a new class, how about using mb-3 or my-3?

Fixed. @Quy, thanks for remark :)

eopws

comment created time in 4 hours

push eventjoomla/joomla-cms

Yatharth Vyas

commit sha 6a841a36a71eafcb049c5524b89070c070f5b0c3

[4.0] Display Custom Fields for Frontend Contact View Conditionally (#33818) Pull Request for Issue #33801 .

view details

push time in 5 hours

PR merged joomla/joomla-cms

[4.0] Display Custom Fields for Frontend Contact View Conditionally PR-4.0-dev RTC

Pull Request for Issue #33801

Summary of Changes

Refactored the foreach block. The loop iteration is executed if the field's value exists and its parent Field Group is to be displayed.

Testing Instructions

  1. Activate user profile
  2. Create a contact
  3. Set display user profile
  4. Create a custom field in users (Multiple fields under multiple field groups are recommended for thorough testing)
  5. Let the field empty in the user's profile
  6. Create a contact menu item
  7. Visit the contact created from Frontend

Before the PR, you will be able to see the field groups for all possible groups, including those left blank. After the PR, Only those groups will be shown that have a field with a value.

<hr>

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

None

+2 -6

9 comments

1 changed file

YatharthVyas

pr closed time in 5 hours

pull request commentjoomla/joomla-cms

[4.0] Remove duplicate scss lines for form stylings

I have tested this item :white_check_mark: successfully on 9753763582f9891bc9007d828a9516c88d9e279a<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/33834">issues.joomla.org/tracker/joomla-cms/33834</a>.</sub>

eyvazahmadzada

comment created time in 5 hours

pull request commentjoomla/joomla-cms

[4.0] Cache Handler

Thanks!

brianteeman

comment created time in 5 hours