profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/brettcannon/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Brett Cannon brettcannon @microsoft Vancouver, BC, Canada https://snarky.ca

brettcannon/caniusepython3 415

Can I Use Python 3?

brettcannon/check-for-changed-files 6

Action to check that PRs have changed certain files

brettcannon/awesome-stellar 1

👨‍🚀 A curated list of Stellar applications, blog posts, educational resources, tools, and more.

brettcannon/bedevere 1

A bot to help identify missing information for CPython pull requests

brettcannon/actions-workflow-samples 0

Help developers to easily get started with GitHub Action workflows to deploy to Azure

brettcannon/Adafruit_CircuitPython_CircuitPlayground 0

CircuitPython library for CircuitPlayground

brettcannon/ansible 0

Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.

brettcannon/argv 0

Node based command line argument parser

brettcannon/asyncio-doc 0

Asyncio documentation

push eventbrettcannon/brettcannon

brettcannon

commit sha 2e3116bed59b0b3f4fd90262e7d5315a81b6293b

Update README.md

view details

push time in 2 hours

startedbrettcannon/python-launcher

started time in 3 hours

Pull request review commentpython/peps

Support code highlighting

 # Requirements for building PEPs with Sphinx-sphinx >= 3.5-docutils >= 0.16+Pygments ~= 2.9.0+Sphinx ~= 4.0.2+docutils ~= 0.17.1 

Okay, changed it back

ofek

comment created time in 4 hours

Pull request review commentpython/peps

Support code highlighting

 # Requirements for building PEPs with Sphinx-sphinx >= 3.5-docutils >= 0.16+Pygments ~= 2.9.0+Sphinx ~= 4.0.2+docutils ~= 0.17.1 

Only question I'd have is if better to pin to compatible releases or all future? (~= vs >=) - historically been unpinned so I think that means the latest release has always been used (but I am not best placed to make this call, as no idea if e.g. previously there have been breaking changes to PEP rendering due to dependency changes, or the risk appetite for this in the future vs new features that may or may not be used)

A

ofek

comment created time in 10 hours

Pull request review commentpython/peps

Support code highlighting

 jobs:       - name: Install dependencies         run: |           python -m pip install -U pip-          python -m pip install -U docutils+          python -m pip install -U docutils pygments

Pushed commit!

ofek

comment created time in 12 hours

startedbrettcannon/python-launcher

started time in 12 hours

Pull request review commentpython/peps

Support code highlighting

 jobs:       - name: Install dependencies         run: |           python -m pip install -U pip-          python -m pip install -U docutils+          python -m pip install -U docutils pygments

Perils of reading commit info from emails and not checking the latest! Feel free to bump the docutils/sphix reqs, they are current as of April 2020, so 0.17.z / 4.y.z may be more appropriate.

A

ofek

comment created time in 13 hours

Pull request review commentpython/peps

Support code highlighting

 jobs:       - name: Install dependencies         run: |           python -m pip install -U pip-          python -m pip install -U docutils+          python -m pip install -U docutils pygments

Hi @ofek - not sure if youve seen there is an existing reqs file in the repo for the sphinx work? https://github.com/python/peps/blob/master/requirements.txt -- would your one conflict with the pre-existing one?

A

ofek

comment created time in 13 hours

startedbrettcannon/python-launcher

started time in 13 hours

startedbrettcannon/python-launcher

started time in 20 hours

startedbrettcannon/python-launcher

started time in a day

startedbrettcannon/python-launcher

started time in a day

Pull request review commentpython/peps

Support code highlighting

 jobs:       - name: Install dependencies         run: |           python -m pip install -U pip-          python -m pip install -U docutils+          python -m pip install -U docutils pygments

Done!

ofek

comment created time in a day

issue commentpython/peps

Create ePub versions of PEPs

Gotten an initial implementation working, although unstyled (I don't know if ePubs are expected to be styled?) and with one error (literal/code blocks overlapping with body text). xref #1995, 387b19b...37d9975

I am not sure if read the docs would be able to handle this out of the box, as I've customised Sphinx significantly for PEP purposes, disabling the native index, search, javascript, permalinking, etc. As of this, a lot of the stuff Sphinx expects for just changing the builder name to work doesn't exist (e.g. I had to turn off the custom templates I've done for the HTML variant as they with epub).

Just my two pennies' worth, but it may turn out that ePub support is as complicated as the custom HTML - adding a lot of potential maintenence burden for a historically low change infrastructure piece? I will continue to work on it but wanted to (constructively!) raise the challenge now as I think about it.

A

AA-Turner

comment created time in a day

PR opened python/peps

Sphinx - epub

A stab at ePub support (xref #1994).

Previewing on a desktop app (adobe digital editions) everything looks fine apart from code blocks (e.g. page 66), so will have a look at overriding the CSS.

Test: make sphinx-epub and look at build/PEPs.epub. This is the one massive file for all PEPs approach, which is the default from the Sphinx ePub 3 writer -- if a per-PEP solution were wanted, I imagine this may be tricker.

cc: @froi, @Mariatta

+25 -0

0 comment

3 changed files

pr created time in a day

push eventbrettcannon/brettcannon

brettcannon

commit sha 5d5a032141ea9f16d94306087879501bd12f495e

Update README.md

view details

push time in a day

created tagbrettcannon/python-launcher

tagv0.17.0

Python launcher for Unix

created time in a day

issue commentpython/peps

Create ePub versions of PEPs

As a design decision, would 1 massive epub file (~5,500 pages), or individual files per PEP be preferred?

@froi would be interested in your views as an epub user?

A

AA-Turner

comment created time in a day

issue commentpython/peps

Build PEPs using Sphinx

The intention with using pages was so previews on forks (to <user>.github.io/peps) worked out of the box - although I admit I haven't written that part of the GHA script yet. This was originally discussed in #25 I think.

A

brettcannon

comment created time in a day

delete branch brettcannon/python-launcher

delete branch : dependabot/cargo/comfy-table-3.0.0

delete time in a day

PR closed brettcannon/python-launcher

Bump comfy-table from 2.1.0 to 3.0.0

Bumps comfy-table from 2.1.0 to 3.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/nukesor/comfy-table/releases">comfy-table's releases</a>.</em></p> <blockquote> <h2>v3.0.0</h2> <h2>[3.0.0] - 2021-06-13</h2> <h1>Breaking changes</h1> <ul> <li>Remove most custom traits and replace them with std's generic <code>From</code> trait. <br /> Check the docs on the trait implementations for Cell, Row and Cells</li> <li>Add the <code>Cells</code> type, to allow super generic <code>Iterator -> Row</code> conversions.</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/Nukesor/comfy-table/blob/master/CHANGELOG.md">comfy-table's changelog</a>.</em></p> <blockquote> <h2>[3.0.0] - 2021-06-13</h2> <h1>Breaking changes</h1> <ul> <li>Remove most custom traits and replace them with std's generic <code>From</code> trait. <br /> Check the docs on the trait implementations for Cell, Row and Cells</li> <li>Add the <code>Cells</code> type, to allow super generic <code>Iterator -> Row</code> conversions.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/Nukesor/comfy-table/commit/a8e2b7c2f7a2706313dbaaf8fcca3c0bca05b227"><code>a8e2b7c</code></a> (cargo-release) version 3.0.0</li> <li><a href="https://github.com/Nukesor/comfy-table/commit/1d9ec254fa2c0194d010560ec2f0beea58c2c4b1"><code>1d9ec25</code></a> Changelog: Set date</li> <li><a href="https://github.com/Nukesor/comfy-table/commit/b7206c7628d4c0f4fe946dc9bdc108ca66aa8dcd"><code>b7206c7</code></a> deps: Update dependencies</li> <li><a href="https://github.com/Nukesor/comfy-table/commit/c2f529d13c70ce833fca129098bdcd5653da4541"><code>c2f529d</code></a> Use copied instead of map in table.get_style</li> <li><a href="https://github.com/Nukesor/comfy-table/commit/9892249c26e776c06e3cc102d1c1f53550f0d0d1"><code>9892249</code></a> Use map in table::get_style</li> <li><a href="https://github.com/Nukesor/comfy-table/commit/fc34b4ab8d09b3234f90c677b65b12a5a96ba6c4"><code>fc34b4a</code></a> Replace old custom traits with std's From</li> <li><a href="https://github.com/Nukesor/comfy-table/commit/c42f5ede8448880b6e9cf6e5220aaba931e38f6e"><code>c42f5ed</code></a> Clarify docs for set_delimiter</li> <li><a href="https://github.com/Nukesor/comfy-table/commit/7f54d87cb6d178656fe9067c842ee9aaabb5051a"><code>7f54d87</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/nukesor/comfy-table/issues/28">#28</a> from Nukesor/split_ci_tasks</li> <li><a href="https://github.com/Nukesor/comfy-table/commit/31c9837c7b66f1cb7c3bfc0dfcbedfc612624790"><code>31c9837</code></a> Split CI into tests and styling</li> <li><a href="https://github.com/Nukesor/comfy-table/commit/dfe499acc94b908f0b1b5aa32e9395c14de600b1"><code>dfe499a</code></a> Write more test comments</li> <li>Additional commits viewable in <a href="https://github.com/nukesor/comfy-table/compare/v2.1.0...v3.0.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+27 -17

1 comment

2 changed files

dependabot[bot]

pr closed time in a day

pull request commentbrettcannon/python-launcher

Bump comfy-table from 2.1.0 to 3.0.0

Looks like comfy-table is up-to-date now, so this is no longer needed.

dependabot[bot]

comment created time in a day

issue commentpython/peps

Build PEPs using Sphinx

Not sure who gets to decide on this, but I'd like for us to create a readthedocs project so we can preview @AA-Turner's PRs in ReadTheDocs. What do folks think?

brettcannon

comment created time in a day

issue commentpython/peps

Create ePub versions of PEPs

Thanks. ReadTheDocs can also handle the ePub generation. It is a built-in feature on their side: https://docs.readthedocs.io/en/stable/downloadable-documentation.html

AA-Turner

comment created time in a day

issue commentpython/peps

Create ePub versions of PEPs

Resources (no idea how useful, for future me):

https://www.sphinx-doc.org/en/master/faq.html#epub-info https://www.sphinx-doc.org/en/master/usage/builders/index.html#sphinx.builders.epub3.Epub3Builder

AA-Turner

comment created time in a day

issue openedpython/peps

Create ePub versions of PEPs

cc: @Mariatta @froi

I know that we can generate ePub using Sphinx. Is that something we can get if we're going with GitHub pages?

Originally posted by @Mariatta in https://github.com/python/peps/pull/1933#issuecomment-864294524

created time in a day

pull request commentpython/peps

Sphinx - theming

Hi Mariatta,

Thanks for the feedback :)

Will have a look at ePubs, although I don't have a kindle so I don't think I can preview? (after writing this I'll probably find an epub app for my phone within 30 seconds!)

Could I suggest though that it's tackled in a separate PR? Currently I'm focussed on trying to replicate what we currently have - but appreciate moving to Sphinx opens more avenues, which is partly the point I guess! I will open an issue to track ePub generation.

A

AA-Turner

comment created time in a day

pull request commentpython/peps

Sphinx - theming

Just wanted to mention that I took a quick look at https://aa-turner.github.io/peps/ and it looks pretty cool.

I know that we can generate ePub using Sphinx. Is that something we can get if we're going with GitHub pages? I know that it is something we can get easily if hosting it in readthedocs.

cc @froi who was wondering about ePub version of the PEPs.

AA-Turner

comment created time in a day

pull request commentpython/peps

Sphinx - theming

@pablogsal - rebased on master, I summarised changes above but can provide more detail if you'd like on anything :)

Do you know who best to contact to get GH pages enabled on this repo, incidentally?

A

AA-Turner

comment created time in a day

Pull request review commentpython/peps

Support code highlighting

 jobs:       - name: Install dependencies         run: |           python -m pip install -U pip-          python -m pip install -U docutils+          python -m pip install -U docutils pygments

Perhaps we should create requirements.txt and pin the versions ofdocutils and pygments.

ofek

comment created time in a day