profile
viewpoint
Jeff Brateman braebot PayPal/Braintree

braebot/apk_grabber 7

Apk grabber - grabs apks from android devices

braebot/digits-android 1

Digits for Android

braebot/braintree-testing 0

Chrome extension to fill form elements with Briantree's testing credit cards numbers.

braebot/eslint 0

A fully pluggable tool for identifying and reporting on patterns in JavaScript.

braebot/github-scrape-prs 0

Scrape a repositories PRs

braebot/github-templates 0

Github templates for usage in other projects

braebot/krakenjs.github.io 0

Source for the kraken website

braebot/merge 0

test for merge reverting

pull request commentbraintree/framebus

Fix #41: do not broadcast to frames we opened

I had to update chromedriver to 87.0.0 to make the functional tests work locally. I though this would be only a local issue, but since the travis build is failing with the same error message about chromedriver 85...

blutorange

comment created time in 17 hours

PR opened braintree/framebus

Fix #41: do not broadcast to frames we opened

Fixes #41 Did a bit of testing and the fix I suggested seems to work out.

First I was trying to add a unit test for this, but that did not work out since it's not a real browser environment.

So I added a functional test to popup-spec.js that fails without the fix. I also added another expectation to the other tests in ``popup-spec.jsthat makes them all fail without the fix -- that they receive the message only once. The were many<p>` elements being created which tests failed to detect. With the fix, all tests pass again.

+61 -1

0 comment

4 changed files

pr created time in 17 hours

PR opened braintree/braintree_java

Http client : No need to do a complex status message parsing if the server response is a success

Summary

Http client : No need to do a complex status message parsing if the server response is a success hopefully most of the response are success !

Checklist

  • [X] Added changelog entry
  • [X] Ran unit tests (mvn verify -DskipITs)
+14 -9

0 comment

2 changed files

pr created time in 2 days

PR opened braintree/braintree_java

avoid allocating memory / constructing object if the message is not going to be logged

Summary

avoid allocating memory / constructing object if the message is not going to be logged

Checklist

  • [X] Added changelog entry
  • [X] Ran unit tests (mvn verify -DskipITs)
+17 -8

0 comment

2 changed files

pr created time in 2 days

PR opened braintree/braintree_java

Re-use patterns, Avoid compiling / creating pattern when not needed

Summary

Re-use patterns Avoid compiling / creating pattern when not needed (String#replaceAll) No need to do the compilation each time : Pattern are thread safe

Already covered by tests except for EnumUtils where a test was missing (added)

Checklist

  • [X] Added changelog entry
  • [X] Ran unit tests (mvn verify -DskipITs)
+36 -15

0 comment

6 changed files

pr created time in 2 days

PR opened braintree/braintree_java

Avoid multiple node traversal in webhooks parsing

Summary

Avoid multiple node traversal in webhooks parsing Parsing is now similar to other classes (eg Transaction)

Checklist

  • [X] Added changelog entry
  • [X] Ran unit tests (mvn verify -DskipITs)
+42 -26

0 comment

2 changed files

pr created time in 2 days

PR opened braintree/braintree_java

Crypto#secureCompare : use the primitive type as the return value could not be null

Summary

Fix Crypto#secureCompare signature to use the primitive type as the return value could not be null

Checklist

  • [ X] Added changelog entry
  • [ X] Ran unit tests (mvn verify -DskipITs)
+4 -1

0 comment

2 changed files

pr created time in 2 days

issue openedbraintree/braintree-ios-drop-in

Cordova implementation it is posible?

Is your feature request related to a problem? Please describe. Create app of native framework7 (vue) with dropin braintree Javascript, but apple store not allow to push app with only card payments so I need apple pay subscription in my cordova app.

Describe the solution you'd like I need use subscription payment base on braintree with apple pay options on app cordova (framework7)

Do you have maybe any solutions?

created time in 2 days

issue commentbraintree/framebus

Infinite loop when sending events to/from a window included via framebus#include

I took a look at the unit tests and noticed that there are some tests that check for endless loops, such as

https://github.com/braintree/framebus/blob/master/spec/unit/broadcast.spec.ts#L83-L89

The first problem here is that child.top = frame should actually be child.top = child, or the child is not recognized as having an opener. The second problem is that this part in broadcast.ts

https://github.com/braintree/framebus/blob/master/src/lib/broadcast.ts#L26-L32

There is actually a "Max call stack size error exceeded" error thrown, but it's swallowed by the catch block, which results in the test not failing when it should.

What I mentioned above alone doesn't seem enough. I might have more time during the weekend to investigate further

blutorange

comment created time in 2 days

issue openedbraintree/braintree_ios

Cordova implementation its posible

Is your feature request related to a problem? Please describe. Create app of native framework7 (vue) with dropin braintree Javascript, but apple store not allow to push app with only card payments so I need apple pay subscription in my cordova app.

Describe the solution you'd like I need use subscription payment base on braintree with apple pay options on app cordova (framework7)

Do you have maybe any solutions?

created time in 3 days

issue openedbraintree/braintree_ios

BraintreeDropIn module crashes the app on slow internet connection

Integration Details (please complete the following information):

  • SDK/Library Version: braintree-ios-drop-in 8.1.1, braintree_ios 4.36.1
  • Environment: Sandbox
  • iOS Version: iOS 14.2
  • Device iPhone X
  • Integration type & version Carthage 0.36

Describe the bug When opening payment method action sheet and selecting add card, we sometimes get a crash when inputing card details.

It usually happens when the internet connection is very unstable and on high latency.

To Reproduce Steps to reproduce the behavior:

  1. Have network conditioner set to very bad network
  2. Open add card sheet in braintree drop in
  3. Start inputing details for new card
  4. App freezes and then crash

Expected behavior App not freezes and does not crash.

Stack trace

0  CoreFoundation                 0x1a4d219d4 __exceptionPreprocess
1  libobjc.A.dylib                0x1b86d2b54 objc_exception_throw
2  CoreFoundation                 0x1a4d8bd98 -[__NSCFString characterAtIndex:].cold.1
3  CoreFoundation                 0x1a4c0ab54 -[__NSArrayM objectAtIndex:]
4  BraintreeDropIn                0x104dee8e8 -[BTCardFormViewController advanceFocusFromField:] + 476 (BTCardFormViewController.m:476)
5  BraintreeDropIn                0x104df0f60 -[BTCardFormViewController validateButtonPressed:] + 709 (BTCardFormViewController.m:709)
6  BraintreeDropIn                0x104df15ec -[BTCardFormViewController formFieldDidChange:] + 751 (BTCardFormViewController.m:751)
7  BraintreeUIKit                 0x104b5c37c -[BTUIKCardNumberFormField fieldContentDidChange] + 114 (BTUIKCardNumberFormField.m:114)
8  UIKitCore                      0x1a758b27c -[UIApplication sendAction:to:from:forEvent:]
9  UIKitCore                      0x1a6f20254 -[UIControl sendAction:to:forEvent:]
10 UIKitCore                      0x1a6f20598 -[UIControl _sendActionsForEvents:withEvent:]
11 UIKitCore                      0x1a789e1d0 -[UITextField fieldEditorDidChange:]
12 UIKitCore                      0x1a7883d38 -[UIFieldEditor textInputDidChange:]
13 UIKitCore                      0x1a78ae658 -[UITextInputController _sendDelegateChangeNotificationsForText:selection:]
14 UIKitCore                      0x1a78b0b84 -[UITextInputController _insertText:fromKeyboard:]
15 UIKitCore                      0x1a78b176c -[UITextInputController insertText:]
16 UIKitCore                      0x1a7887408 -[UIFieldEditor insertFilteredText:]
17 UIKitCore                      0x1a78a412c -[UITextField insertFilteredText:]
18 UIKitCore                      0x1a7381ca8 -[UIKeyboardImpl insertText:updateInputSource:]
19 UIKitCore                      0x1a737b33c -[UIKeyboardImpl _performKeyboardOutput:shouldCheckDelegate:]
20 UIKitCore                      0x1a737aed0 -[UIKeyboardImpl performKeyboardOutput:]
21 UIKitCore                      0x1a7379efc __55-[UIKeyboardImpl handleKeyboardInput:executionContext:]_block_invoke_2
22 UIKitCore                      0x1a73aca60 -[UIKeyboardTaskEntry execute:]
23 UIKitCore                      0x1a73ab644 -[UIKeyboardTaskQueue continueExecutionOnMainThread]
24 Foundation                     0x1a6015614 __NSThreadPerformPerform
25 CoreFoundation                 0x1a4ca1be0 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
26 CoreFoundation                 0x1a4ca1ae0 __CFRunLoopDoSource0
27 CoreFoundation                 0x1a4ca0e28 __CFRunLoopDoSources0
28 CoreFoundation                 0x1a4c9b3d0 __CFRunLoopRun
29 CoreFoundation                 0x1a4c9ab90 CFRunLoopRunSpecific
30 GraphicsServices               0x1bafbd598 GSEventRunModal
31 UIKitCore                      0x1a7584638 -[UIApplication _run]
32 UIKitCore                      0x1a7589bb8 UIApplicationMain
33 <Redacted>                    0x102bb1e18 main + 12 (AppDelegate.swift:12)
34 libdyld.dylib                  0x1a4979588 start

created time in 3 days

issue commentbraintree/framebus

Infinite loop when sending events to/from a window included via framebus#include

Yeah I might do that, though I need to do a bit more testing to see what happens when you have an iframe that opens a window etc.

blutorange

comment created time in 3 days

issue commentbraintree/framebus

Infinite loop when sending events to/from a window included via framebus#include

That logic looks sound to me. Feel free to open a PR!

blutorange

comment created time in 3 days

issue commentbraintree/framebus

Infinite loop when sending events to/from a window included via framebus#include

While I suppose it may be arguable what's wrong, if you consider this line:

https://github.com/braintree/framebus/blob/3463a36562fe32519918fcbaaa66f60946f7e417/src/lib/broadcast.ts#L12-L16

The parent window broadcasts to the opener of child window, which is the parent window itself. This in turn attempts to broadcast to the child windows again, which calls the code above again, resulting in an endless loop. If I add a check like this:

if (hasOpener(frame) && frame.opener.top !== window.top) {

it works and only invokes the listener once. Not sure if this is the best place to fix this though

blutorange

comment created time in 4 days

issue openedbraintree/framebus

Infinite loop when sending events to/from a window included via framebus#include

General information

  • Library version: 3.0.x / 4.0.x / 5.0.x
  • Browser: 86.0.4240.183 (Official Build) (64-bit) / FireFox 83.0 (64-bit)

Issue description

First of all, let me say that this is a really nice and simple library. I made a simple demo to check out how it works and test if I can use it. I think I may have found one issue that occurs when using #include:

  • Main page creates a framebus, opens a window via window.open, includes it in the event system via framebus#include and emits a message event when a button is clicked
  • Opened window also creates a framebus, registers a listener for message and logs a message when the event occurs
  • This result in an endless loop with the event listener being invoked over and over again

See attached simple-demo.zip for a simple example:

npm i
npx webpack
npx http-server

Then open "index.html" in a web browser, click on open, then open dev tools in the opened window, then click on open in the original window. The dev tools in the opened window keeps logging a message.

image

created time in 4 days

push eventbraintree/braintree-ios-drop-in

Susan Stevens

commit sha b6680d6c522483440168dc80c5ba15863754ed70

Restructure Podfile so that BraintreeDropIn target isn't muddied by CocoaPods

view details

push time in 4 days

push eventbraintree/braintree-ios-drop-in

Susan Stevens

commit sha 278b32d184212e286ecb5072288f749662fd9107

Remove unneeded import in unit test bridging header

view details

push time in 4 days

issue commentbraintree/braintree_java

Create discount & plan

Hi @tandacedric, discounts and plans can't be created programmatically. They must be created through the Braintree Control Panel. Here's a guide with more information.

tandacedric

comment created time in 4 days

issue openedbraintree/braintree_java

Create discount & plan

How to create discount and plan programmatically using Java SDK?

created time in 4 days

issue commentbraintree/braintree-web-drop-in

3DS 2.0 VerifyCard Issue.

Hi, I'm having the same issue trying to verifyCard with an amount of 0.00. Are you going to allow this scenario?

VBJeffrey

comment created time in 4 days

fork friederbluemle/Core-1

The models used within the CocoaPods gem

fork in 4 days

issue closedbraintree/braintree_android

Ummm

Impersonation Identity fraud

closed time in 4 days

Dour420

issue openedbraintree/braintree_android

Ummm

Impersonation Identity fraud

created time in 4 days

startedWebAssembly/WASI

started time in 4 days

push eventbraintree/braintree-ios-drop-in

scannillo

commit sha 822bdfe04dd7baa3336673be67d97784b0d34605

* Revert bundle ID name * Remove unused bridging header Signed-off-by: Susan Stevens <susan.stevens@getbraintree.com>

view details

push time in 5 days

Pull request review commentbraintree/braintree-ios-drop-in

Move Demo into own Xcodeproj + other cleanup

 @interface BTPaymentSelectionViewController () @property (nonatomic, strong) UILabel *vaultedPaymentsHeader; @property (nonatomic, strong) UIButton *vaultedPaymentsEditButton; @property (nonatomic, strong) UICollectionView *savedPaymentMethodsCollectionView;+@property (nonatomic, strong) id application;

Added for use in BTPaymentSelectionViewControllerTests.m

scannillo

comment created time in 5 days

push eventbraintree/braintree-ios-drop-in

scannillo

commit sha 39b5592c7500826446343f16dc5fa1dfc252adc5

Cleanup TODOs; Remove unused internal header file Signed-off-by: Susan Stevens <susan.stevens@getbraintree.com>

view details

push time in 5 days

PR opened braintree/braintree-ios-drop-in

Move Demo into own Xcodeproj + other cleanup

Summary of changes

  • Move demo app into it's own xcodeproj
  • Move UITests target to live in Demo.xcodeproj
  • Remove BTDropInOverrides and DisableVenmo option from Demo app
    • Added unit test in place of previous DisableVenmo use case
  • Add Braintree/UnionPay to Podfile
  • Move Image.assets to conventional Assets.xcassets directory
  • Turned warnings off for quoted include headers (this will get fixed in follow up PR)

Checklist

~[ ] Added a changelog entry~

Authors

@scannillo @sestevens

+1105 -931

0 comment

63 changed files

pr created time in 5 days

push eventbraintree/braintree-ios-drop-in

scannillo

commit sha e840b32c6f22a833e7addda7771b9b63b31cab7c

Specify project for UITests target in Podfile Signed-off-by: Susan Stevens <susan.stevens@getbraintree.com>

view details

push time in 5 days

PR opened braintree/browser-switch-android

Remove browserswitch fragment

Summary of changes

  • WIP

Checklist

  • [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

  • @sarahkoop
  • @sshropshire
+677 -1394

0 comment

35 changed files

pr created time in 5 days

more