profile
viewpoint
Braden Napier bradennapier @bradennapier Atlanta, GA

bradennapier/eslint-plus-action 14

ESLint via Github Actions on changed files with annotations & comments

bradennapier/intercomly 3

Typescript & Node Intercom v2.0 API Client

bradennapier/eslint-plugin-ts-import 1

Provide import-patterns that are expected to be followed within the rep

bradennapier/everywhere 1

A cross-platform boilerplate for sharing a codebase (in development)

bradennapier/gotcl 1

Automatically exported from code.google.com/p/gotcl

bradennapier/add-pr-comment 0

uses: mshick/add-pr-comment@v1

bradennapier/app-boilerplate 0

An App Boilerplate to build React Native, Web, and Electron Applications

bradennapier/app-manifest-webpack-plugin 0

A Webpack Plugin that generates images & favicons and injects into your index.html

bradennapier/async_hooks_repro 0

An example of Promise/async_hooks disconnect/problem for Node.js Github Issue

bradennapier/awesome 0

:sunglasses: Curated list of awesome lists

push eventidexio/idex-sdk-js

Braden Napier

commit sha 0b248bcba0267101d59e88bef4c7ce3fcfa451e4

fix(types): add ErrorShortCodes to sdk type exports

view details

idex-bot

commit sha a7c13333aef372878ea999544081ea7aebcc32eb

chore(release): 1.5.0-beta.4 [skip ci] ## [1.5.0-beta.4](https://github.com/idexio/idex-sdk-js/compare/v1.5.0-beta.3...v1.5.0-beta.4) (2020-10-07) ### Bug Fixes * **types:** add ErrorShortCodes to sdk type exports ([0b248bc](https://github.com/idexio/idex-sdk-js/commit/0b248bcba0267101d59e88bef4c7ce3fcfa451e4))

view details

Braden Napier

commit sha 1c39b9d1af73d105afc923e64e4cdfeee7c13984

Merge branch 'main' into beta

view details

Braden Napier

commit sha d6af90e7fa1e6d469ee7967af656c616f2b156bf

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

idex-bot

commit sha 1e2b332e4fb98c8bb3237b5a4eb22263e92b01f5

chore(release): 1.5.1-beta.1 [skip ci] ### [1.5.1-beta.1](https://github.com/idexio/idex-sdk-js/compare/v1.5.0...v1.5.1-beta.1) (2020-10-07) ### Bug Fixes * **types:** add ErrorShortCodes to sdk type exports ([0b248bc](https://github.com/idexio/idex-sdk-js/commit/0b248bcba0267101d59e88bef4c7ce3fcfa451e4))

view details

Juraj Husar

commit sha 9881311b044915694ad5ba0153e8d52814359644

fix(websocket): websocket.terminate() does not work in browser

view details

Jurosh

commit sha 5ce34c7eb65d728fc64b5e659fd3832bdf3f1cbe

Merge pull request #161 from idexio/feature/websocket-terminate-browser fix(websocket): websocket.terminate() does not work in browser

view details

idex-bot

commit sha 960207dd17c58ea96519691fae77f1425994b074

chore(release): 1.5.1-beta.2 [skip ci] ### [1.5.1-beta.2](https://github.com/idexio/idex-sdk-js/compare/v1.5.1-beta.1...v1.5.1-beta.2) (2020-10-08) ### Bug Fixes * **websocket:** websocket.terminate() does not work in browser ([9881311](https://github.com/idexio/idex-sdk-js/commit/9881311b044915694ad5ba0153e8d52814359644))

view details

Juraj Husar

commit sha 3109e0123d816821b9a4b9933ec5e107f2b6fa7b

fix(api): rest api can include "null" in txId fill response

view details

Jurosh

commit sha 53a1b30a4a79c05f790a3af0545d140e1b4fb33f

Merge pull request #162 from idexio/feature/fix-type-null fix(api): rest api can include "null" in txId fill response

view details

idex-bot

commit sha f4e15d31eb9d276df83f456ee74ae8f886f21a5a

chore(release): 1.5.1-beta.3 [skip ci] ### [1.5.1-beta.3](https://github.com/idexio/idex-sdk-js/compare/v1.5.1-beta.2...v1.5.1-beta.3) (2020-10-15) ### Bug Fixes * **api:** rest api can include "null" in txId fill response ([3109e01](https://github.com/idexio/idex-sdk-js/commit/3109e0123d816821b9a4b9933ec5e107f2b6fa7b))

view details

Braden Napier

commit sha 9bc96557641ffcc88847369041bb5bf8c1e34470

fix(rest): add live baseURL

view details

idex-bot

commit sha 22c1997be65185785db557d2a5d5b9ef2f24a89b

chore(release): 1.5.1-beta.4 [skip ci] ### [1.5.1-beta.4](https://github.com/idexio/idex-sdk-js/compare/v1.5.1-beta.3...v1.5.1-beta.4) (2020-10-20) ### Bug Fixes * **rest:** add live baseURL ([9bc9655](https://github.com/idexio/idex-sdk-js/commit/9bc96557641ffcc88847369041bb5bf8c1e34470))

view details

Braden Napier

commit sha 3b38776f1357b7b5dcf373b3f5f1583ff18b9280

Merge pull request #159 from idexio/beta Release beta

view details

push time in 7 days

PR merged idexio/idex-sdk-js

Release beta Release beta

This PR was generated automatically. Merging it will transition beta into main.

+63 -26

0 comment

10 changed files

idex-bot

pr closed time in 7 days

push eventidexio/idex-sdk-js

Braden Napier

commit sha 9bc96557641ffcc88847369041bb5bf8c1e34470

fix(rest): add live baseURL

view details

push time in 7 days

PR opened idexio/idex-sdk-js

Implement Ethereum Client SDK

Implements an additional EthereumClient to the sdk which can be used to easily deposit ETH and tokens to the exchange contract directly.

+5007 -294

0 comment

13 changed files

pr created time in 20 days

push eventidexio/idex-sdk-js

Braden Napier

commit sha c806f63add24a28bb27d697b8b8b1a11e84765db

fix(ethereum): implement contract getters in ethereum client

view details

push time in 20 days

push eventidexio/idex-sdk-js

Braden Napier

commit sha e155e8194aeda42ec81cb442ae085376e732590f

fix(ethereum): remove extra contract calls, implement depositEth

view details

Braden Napier

commit sha 3a9c7fd2caf29d254273e7951d2e11cb11493082

fix(ethereum): fix client options type for WeakMap

view details

Braden Napier

commit sha 8de4ba4fbefeee08114d7abf89582aece2d0b82a

fix(ethereum): fix type errors and warnings

view details

push time in 20 days

create barnchidexio/idex-sdk-js

branch : feat/ethereum-client

created branch time in 20 days

push eventidexio/idex-sdk-js

Braden Napier

commit sha 9dd00ff6b249de2d3371892c97617b9ef3a8c2c6

Merge pull request #152 from idexio/beta Release beta

view details

idex-bot

commit sha 03fbffd6bda0e885a0e1c4276166bc0d3c88e56d

chore(release): 1.5.0 [skip ci] ## [1.5.0](https://github.com/idexio/idex-sdk-js/compare/v1.4.2...v1.5.0) (2020-10-05) ### Features * **types:** cancelled to canceled ([1a380b6](https://github.com/idexio/idex-sdk-js/commit/1a380b6da597cb92c5488aa5917abc13e1d069cf)) * **websocket:** release beta for exposed transformWebsocketShortResponseMessage ([3a2a501](https://github.com/idexio/idex-sdk-js/commit/3a2a5011cec39475010178ba929cc804bd66672f)) ### Bug Fixes * use flag instead of optional field for quote quantity ([e50dd46](https://github.com/idexio/idex-sdk-js/commit/e50dd4652b3fc9a04490e0afce0ce50eea50ec20)) * **restresponse types:** level1 orderbook response can have empty bids and asks arrays ([8a2fe1a](https://github.com/idexio/idex-sdk-js/commit/8a2fe1a8c2a1f86053ca3a357a8e19c6fd2bb0f2)) * **websocket:** remove token manager and no websocket auth token re-use ([e53bbf2](https://github.com/idexio/idex-sdk-js/commit/e53bbf2c5800013f785b0f0e3fa3c4390718fc97)) * unify cancel naming - Rename cancelled to canceled ([a97f2fa](https://github.com/idexio/idex-sdk-js/commit/a97f2faa21f0ec8e8d0a9c104f38475cfaca8f80))

view details

Braden Napier

commit sha 1c39b9d1af73d105afc923e64e4cdfeee7c13984

Merge branch 'main' into beta

view details

Braden Napier

commit sha d6af90e7fa1e6d469ee7967af656c616f2b156bf

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 20 days

push eventidexio/idex-sdk-js

Braden Napier

commit sha 0b248bcba0267101d59e88bef4c7ce3fcfa451e4

fix(types): add ErrorShortCodes to sdk type exports

view details

push time in 20 days

startedscreego/server

started time in 20 days

push eventidexio/idex-sdk-js

Juraj Husar

commit sha a97f2faa21f0ec8e8d0a9c104f38475cfaca8f80

fix: unify cancel naming - Rename cancelled to canceled

view details

Juraj Husar

commit sha 3abc5bb18e0e4c92e57a3e78fec7acc0775000ba

docs(docs): fix getOrders docs link

view details

Juraj Husar

commit sha e53bbf2c5800013f785b0f0e3fa3c4390718fc97

fix(websocket): remove token manager and no websocket auth token re-use

view details

Juraj Husar

commit sha 34b59b8e404a36d379708b2080225497626fb417

Merge branch 'beta' into feature/cancelled-rename

view details

Jurosh

commit sha 91ac661e405394489ad57d609c9c723b6343586c

Merge pull request #151 from idexio/feature/cancelled-rename fix: unify cancel naming - Rename cancelled to canceled

view details

idex-bot

commit sha 770965ee5b63794ef0895367bdf3eb051c7402da

chore(release): 1.4.2-beta.32 [skip ci] ### [1.4.2-beta.32](https://github.com/idexio/idex-sdk-js/compare/v1.4.2-beta.31...v1.4.2-beta.32) (2020-09-14) ### Bug Fixes * unify cancel naming - Rename cancelled to canceled ([a97f2fa](https://github.com/idexio/idex-sdk-js/commit/a97f2faa21f0ec8e8d0a9c104f38475cfaca8f80))

view details

Jurosh

commit sha 6437744ae4b6529467383edc41e4b5eb93037706

Merge pull request #154 from idexio/feature/subscriptions-multiwallet-update fix(websocket): remove token manager and no websocket auth token re-use

view details

idex-bot

commit sha 29926908b68cc78d27e69ba21efa044fc535819c

chore(release): 1.4.2-beta.33 [skip ci] ### [1.4.2-beta.33](https://github.com/idexio/idex-sdk-js/compare/v1.4.2-beta.32...v1.4.2-beta.33) (2020-09-15) ### Bug Fixes * **websocket:** remove token manager and no websocket auth token re-use ([e53bbf2](https://github.com/idexio/idex-sdk-js/commit/e53bbf2c5800013f785b0f0e3fa3c4390718fc97))

view details

Jurosh

commit sha fb309f86255c7e57717bbede144d24d8db731382

Merge branch 'main' into beta

view details

idex-bot

commit sha 973aa13630841b783bcca07f19539a6a685e1d93

chore(release): 1.4.3-beta.1 [skip ci] ### [1.4.3-beta.1](https://github.com/idexio/idex-sdk-js/compare/v1.4.2...v1.4.3-beta.1) (2020-09-16) ### Bug Fixes * **websocket:** remove token manager and no websocket auth token re-use ([e53bbf2](https://github.com/idexio/idex-sdk-js/commit/e53bbf2c5800013f785b0f0e3fa3c4390718fc97)) * unify cancel naming - Rename cancelled to canceled ([a97f2fa](https://github.com/idexio/idex-sdk-js/commit/a97f2faa21f0ec8e8d0a9c104f38475cfaca8f80))

view details

Alexander Hustler

commit sha 8a2fe1a8c2a1f86053ca3a357a8e19c6fd2bb0f2

fix(restresponse types): level1 orderbook response can have empty bids and asks arrays

view details

alexhustler

commit sha 0328b99364f4dd2c78e6afef3918ff330827de49

Merge pull request #155 from idexio/p9-1901-fix-empty-orderbook-price-levels fix(restresponse types): level1 orderbook response can have empty bid…

view details

idex-bot

commit sha e70a15f9482b8a7397bebba453d7dc5a25d63738

chore(release): 1.4.3-beta.2 [skip ci] ### [1.4.3-beta.2](https://github.com/idexio/idex-sdk-js/compare/v1.4.3-beta.1...v1.4.3-beta.2) (2020-09-23) ### Bug Fixes * **restresponse types:** level1 orderbook response can have empty bids and asks arrays ([8a2fe1a](https://github.com/idexio/idex-sdk-js/commit/8a2fe1a8c2a1f86053ca3a357a8e19c6fd2bb0f2))

view details

Braden Napier

commit sha 1a380b6da597cb92c5488aa5917abc13e1d069cf

feat(types): cancelled to canceled

view details

Braden Napier

commit sha 2857281e32e1dbc08f2ebe12790cdde4f7f71cf0

chore(merge): merge beta

view details

Braden Napier

commit sha 05bea8a8dd5ed673685e78c74b168bc777311e96

Merge pull request #156 from idexio/feat/cancelled-to-canceled Semantic Changes to "cancelled" to fit api "canceled"

view details

idex-bot

commit sha 1983290c44d92d5074fbf3ebfd7734b904faeedd

chore(release): 1.5.0-beta.1 [skip ci] ## [1.5.0-beta.1](https://github.com/idexio/idex-sdk-js/compare/v1.4.3-beta.2...v1.5.0-beta.1) (2020-09-28) ### Features * **types:** cancelled to canceled ([1a380b6](https://github.com/idexio/idex-sdk-js/commit/1a380b6da597cb92c5488aa5917abc13e1d069cf))

view details

Juraj Husar

commit sha 279a58eb40484258a86c3b96f0880d991f95ccaf

chore(websocket): expose transformWebsocketShortResponseMessage

view details

Jurosh

commit sha 90c15e1d0f081167c773c6030c2911b5a17872d3

Merge pull request #157 from idexio/feature/export-transform-message chore(websocket): expose transformWebsocketShortResponseMessage

view details

Juraj Husar

commit sha 3a2a5011cec39475010178ba929cc804bd66672f

feat(websocket): release beta for exposed transformWebsocketShortResponseMessage

view details

push time in 21 days

PR merged idexio/idex-sdk-js

Release beta Release beta

This PR was generated automatically. Merging it will transition beta into main.

+93 -165

0 comment

11 changed files

idex-bot

pr closed time in 21 days

delete branch idexio/idex-sdk-js

delete branch : feat/cancelled-to-canceled

delete time in a month

push eventidexio/idex-sdk-js

Braden Napier

commit sha 1a380b6da597cb92c5488aa5917abc13e1d069cf

feat(types): cancelled to canceled

view details

Braden Napier

commit sha 2857281e32e1dbc08f2ebe12790cdde4f7f71cf0

chore(merge): merge beta

view details

Braden Napier

commit sha 05bea8a8dd5ed673685e78c74b168bc777311e96

Merge pull request #156 from idexio/feat/cancelled-to-canceled Semantic Changes to "cancelled" to fit api "canceled"

view details

push time in a month

pull request commentidexio/idex-sdk-js

Semantic Changes to "cancelled" to fit api "canceled"

Reopened to fix eslint bug for no-shadow

bradennapier

comment created time in a month

PullRequestEvent

pull request commentidexio/idex-sdk-js

Semantic Changes to "cancelled" to fit api "canceled"

Already similar merge done

bradennapier

comment created time in a month

create barnchidexio/idex-sdk-js

branch : feat/cancelled-to-canceled

created branch time in a month

startedcodemix/ts-sql

started time in a month

push eventodo-network/react-state-modules

snyk-bot

commit sha 589e99ac15f3c338080c651f80f8dcf1f2c9a89d

fix: examples/redux-compare/package.json & examples/redux-compare/yarn.lock to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NODEFETCH-674311

view details

push time in a month

push eventodo-network/react-state-modules

snyk-bot

commit sha 17e7983a37fd4d3ad46dab1a10bba1a1bf293e03

fix: examples/simple-app/package.json & examples/simple-app/yarn.lock to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NODEFETCH-674311

view details

push time in a month

startedoclif/oclif

started time in a month

pull request commentRedocly/redoc

[FEATURE] Collapsible Groups

The team never even responded to it so I don't think they are really open to ideas or public contribution.

At this point this PR is likely so out of date it'd need to be redone.

We use the PR ourselves directly at https://docs.idex.market but for our next gen docs are switching to even more custom options such as docosaurus or gatsby, unfortunately.

bradennapier

comment created time in a month

issue closedDataDog/dd-trace-js

trace_id not injected, only span_id

Describe the bug <!-- What the bug is, how to reproduce, and the expected behavior. -->

Environment Restify

  • Operation system: Kubernetes
  • Node version: 14
  • Tracer version: 0.25.1
  • Agent version:

My logs are not getting the trace_id injected, only the span_id so i can see from an apm context all the conntected logs -- but once i open the log i can not see the trace it is associated with (or when in my logs).

If I navigate to the log from the apm / trace then it has the trace until I close the log and reopen it then its gone.

image

closed time in 2 months

bradennapier

issue openedDataDog/dd-trace-js

trace_id not injected, only span_id

Describe the bug <!-- What the bug is, how to reproduce, and the expected behavior. -->

Environment Restify

  • Operation system: Kubernetes
  • Node version: 14
  • Tracer version: 0.25.1
  • Agent version:

My logs are not getting the trace_id injected, only the span_id so i can see from an apm context all the conntected logs -- but once i open the log i can not see the trace it is associated with (or when in my logs).

created time in 2 months

issue commentsequelize/sequelize

Javascript BigInt support in Node 10+

Given TypeScript, some casting due to bad typing from Sequelize, and some hackery -- this appears to implement BigInt support although not ideal. It expected setting supportsBigNumber and bigNumbersAsStrings in dialect options, although may not be strictly necessary.

import { Utils, DataType } from 'sequelize';
import { Sequelize } from 'sequelize-typescript';

// must use the auto binding method due to how sequelize handles these values internally
// invalid types for this value
// eslint-disable-next-line @typescript-eslint/no-explicit-any
class BIGINT_NATIVE_CLASS extends (Sequelize as any).DataTypes.ABSTRACT {
  key = 'BIGINT';

  static key = 'BIGINT';

  toSql = () => 'BIGINT(20) UNSIGNED';

  validate = (value: unknown) => {
    return typeof value === 'bigint';
  };

  _stringify = (value: bigint) => String(value);

  _sanitize = (value: string) => BigInt(value);

  _bindParam = (value: bigint | number | string, options: object) => {
    return options.bindParam(BigInt(value));
  };
}

// Mandatory: add the new type to DataTypes. Optionally wrap it on `Utils.classToInvokable` to
// be able to use this datatype directly without having to call `new` on it.
const BIGINT_NATIVE = (Utils.classToInvokable(
  BIGINT_NATIVE_CLASS,
  // eslint-disable-next-line @typescript-eslint/no-explicit-any
) as any) as DataType;

// eslint-disable-next-line @typescript-eslint/no-explicit-any
(Sequelize as any).DataTypes.BIGINT_NATIVE = BIGINT_NATIVE;

export { BIGINT_NATIVE };

gabegorelick

comment created time in 2 months

issue commentuuidjs/uuid

IDs sequenced by time?

FYI I built this awhile back which does this shuffling when converting uuidv1 into a binary format: https://github.com/odo-network/binary-uuid

binarykitchen

comment created time in 2 months

startedodo-network/binary-uuid

started time in 2 months

issue commentRobinBuschmann/sequelize-typescript

defaultScope seems not work

Default scope only applies to find methods like findOne or findAll, since you are creating the instance there it is returning the entire instance you created.

veronesecoms

comment created time in 2 months

issue closedtypescript-eslint/typescript-eslint

[@typescript-eslint/no-unused-vars] false positive with optional chaining

  • [x] I have tried restarting my IDE and the issue persists.
  • [x] I have updated to the latest version of the packages.
  • [x] I have read the FAQ and my problem is not listed.

Getting false positive no-unused-vars when using optional chaining

[{}, { type: 1 }].map((m) => ({
    type: m?.type,
}))

Expected Result

No linting issues

Actual Result

'm' is defined but never used.eslint@typescript-eslint/no-unused-vars

Versions

package version @typescript-eslint/eslint-plugin 4.0.1 @typescript-eslint/parser 4.0.1 TypeScript 4.0.2 ESLint 7.8.0 node 12.14.1

closed time in 2 months

bradennapier

issue commenttypescript-eslint/typescript-eslint

[@typescript-eslint/no-unused-vars] false positive with optional chaining

Yeah I think that I had a stuck version of eslint server running even through troubleshooting, restarts of VSCode, and days with this problem (and a few others which were upsetting, lol). I just upgraded OSX today and in doing so restarted my computer for the first time in..... awhile .... :-P and it seems to be fine now so I figured VSCode maybe didn't properly terminate the process for whatever reason when i restarted one time then it just sat there literally being a bug... and i hate bugs... total phobia of the things.

Thanks for looking into it!

bradennapier

comment created time in 2 months

issue commenttype-challenges/type-challenges

16 - Pop

Probably preferable to make the “any” become “unknown” in these examples since many default eslint configs as well as tsconfig like to complain about the use of any.

unknown works just as well here.

zheeeng

comment created time in 2 months

issue commentmicrosoft/TypeScript

Different type checking results for incremental vs non-incremental files

This was because i had strictNullChecks turned off for the tests so i assume it was moving to {} automatically... interesting side effect though

bradennapier

comment created time in 2 months

issue closedmicrosoft/TypeScript

Different type checking results for incremental vs non-incremental files

<!-- 🚨 STOP 🚨 STOP 🚨 STOP 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a bug, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:

  • Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  • Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the entire template below. -->

<!-- Please try to reproduce the issue with the latest published version. It may have already been fixed. For npm: typescript@next This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly --> TypeScript Version: 4.0.2

<!-- Search terms you tried before logging this (so others can find this issue more easily) --> Search Terms:

  • incremental
  • build
  • union check

Code

So this is pretty difficult to understand what is happening directly, its confusing me but I had noticed this was happening before... it only started becoming an issue recently.

Basically in any of my composite projects, the following works:

const COMMON_VALIDATION_CONFIG = {
  abortEarly: true,
};

function something() {
  const value = COMMON_VALIDATION_CONFIG || {}; // this is typed out to typeof COMMON_VALIDATION_CONFIG
}

image

However, for my tests folder, I instead have the rootDir set to the top level and it doesn't use references (otherwise every change to any file requires rebuilding all the tests). What is odd, is the type checking is now different:

const COMMON_VALIDATION_CONFIG = {
  abortEarly: true,
};

function something() {
  const value = COMMON_VALIDATION_CONFIG || {}; // this is typed out to {}
}

image


They both use identical configuration other than the check which resolves to the COMMON_VALIDATION_CONFIG additionally has:

"composite": true,
    "declaration": true,
    "declarationMap": true,
    "incremental": true,

and its tsconfig includes references.

Expected behavior:

Should provide consistent type checking behavior

Actual behavior:

It doesnt seem to, although there may be a specific reason for it?

Playground Link: <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->

Related Issues: <!-- Did you find other bugs that looked similar? -->

closed time in 2 months

bradennapier

issue openedmicrosoft/TypeScript

Different type checking results for incremental vs non-incremental files

<!-- 🚨 STOP 🚨 STOP 🚨 STOP 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a bug, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:

  • Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  • Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the entire template below. -->

<!-- Please try to reproduce the issue with the latest published version. It may have already been fixed. For npm: typescript@next This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly --> TypeScript Version: 3.7.x-dev.201xxxxx

<!-- Search terms you tried before logging this (so others can find this issue more easily) --> Search Terms:

  • incremental
  • build
  • union check

Code

So this is pretty difficult to understand what is happening directly, its confusing me but I had noticed this was happening before... it only started becoming an issue recently.

Basically in any of my composite projects, the following works:

const COMMON_VALIDATION_CONFIG = {
  abortEarly: true,
};

function something() {
  const value = COMMON_VALIDATION_CONFIG || {}; // this is typed out to typeof COMMON_VALIDATION_CONFIG
}

image

However, for my tests folder, I instead have the rootDir set to the top level and it doesn't use references (otherwise every change to any file requires rebuilding all the tests). What is odd, is the type checking is now different:

const COMMON_VALIDATION_CONFIG = {
  abortEarly: true,
};

function something() {
  const value = COMMON_VALIDATION_CONFIG || {}; // this is typed out to {}
}

image


They both use identical configuration other than the check which resolves to the COMMON_VALIDATION_CONFIG additionally has:

"composite": true,
    "declaration": true,
    "declarationMap": true,
    "incremental": true,

and its tsconfig includes references.

Expected behavior:

Should provide consistent type checking behavior

Actual behavior:

It doesnt seem to, although there may be a specific reason for it?

Playground Link: <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->

Related Issues: <!-- Did you find other bugs that looked similar? -->

created time in 2 months

issue commentbradennapier/eslint-plus-action

Action using deprecated CLIEngine

Is the command not working for you? ESLint did not implement the necessary features and when i asked the eslint team they told me to use CLIEngine.

WildCard65

comment created time in 2 months

issue commenttypescript-eslint/typescript-eslint

[@typescript-eslint/no-unused-vars] false positive with optional chaining

Could you please confirm to me here that your lint run is using the latest version of eslint?

Eslint core has full support for optional chaining, so this should be supported out of the box. repl

Another user had issues because they had multiple versions of eslint installed

Yep, and just updated to 7.8.1 as well same issue.

bradennapier

comment created time in 2 months

issue openedtypescript-eslint/typescript-eslint

[@typescript-eslint/no-unused-vars] false positive with optional chaining

  • [x] I have tried restarting my IDE and the issue persists.
  • [x] I have updated to the latest version of the packages.
  • [x] I have read the FAQ and my problem is not listed.

Getting false positive no-unused-vars when using optional chaining

e.outputMessages.map((m) => ({
    type: m?.type,
}))

Expected Result

No linting issues

Actual Result

'm' is defined but never used.eslint@typescript-eslint/no-unused-vars

Versions

package version @typescript-eslint/eslint-plugin 4.0.1 @typescript-eslint/parser 4.0.1 TypeScript 4.0.2 ESLint 7.8.0 node 12.14.1

created time in 2 months

issue commenttypescript-eslint/typescript-eslint

[no-unused-vars] v4 false positive with generic inference - with isolated reproduction repo

same false positive happens if you use ?.

e.outputMessages.map((m) => ({
          type: m?.type,
          code: (m as any)?.code,
        })),

image

willheslam

comment created time in 2 months

pull request commenttypescript-eslint/typescript-eslint

fix(eslint-plugin): [no-shadow] fix false-positive on enum declaration

did this regress or is it not released yet? all enums report no-shadow for me still on latest versions of everything.

bradzacher

comment created time in 2 months

push eventidexio/idex-sdk-js

Juraj Husar

commit sha 82fc852f9ea4e26084e165e946757d10279e7b8d

fix(api): do not send `market` parameter to the API when it's undefined

view details

Jurosh

commit sha ee39c8530287945c2b8c369d2ff4832ddc8e6606

Merge pull request #141 from idexio/feature/tickers-market-param fix(api): do not send `market` parameter to the API when it's undefined

view details

idex-bot

commit sha 300e9e224c6cab2d34c34b529da6e8d36943be73

chore(release): 1.4.1-beta.5 [skip ci] ### [1.4.1-beta.5](https://github.com/idexio/idex-sdk-js/compare/v1.4.1-beta.4...v1.4.1-beta.5) (2020-08-12) ### Bug Fixes * **api:** do not send `market` parameter to the API when it's undefined ([82fc852](https://github.com/idexio/idex-sdk-js/commit/82fc852f9ea4e26084e165e946757d10279e7b8d))

view details

Juraj Husar

commit sha c9427080ac83fa7e5da3a386b79747a9dfda66e6

Merge branch 'main' into beta

view details

idex-bot

commit sha ce383ddeb89e5918473d97bf66b27b8036417bd3

chore(release): 1.4.2-beta.1 [skip ci] ### [1.4.2-beta.1](https://github.com/idexio/idex-sdk-js/compare/v1.4.1...v1.4.2-beta.1) (2020-08-12) ### Bug Fixes * **api:** do not send `market` parameter to the API when it's undefined ([82fc852](https://github.com/idexio/idex-sdk-js/commit/82fc852f9ea4e26084e165e946757d10279e7b8d))

view details

Braden Napier

commit sha 6f4c4d9efc648ecf1ac87c6d9920fdad8484b4bc

fix(rest): make more web friendly by providing config options and helpers

view details

Braden Napier

commit sha 9bc8569c03f15078a1180bf7c7e369690cd6e0af

Merge pull request #143 from idexio/feature/more-web-friendly Web Optimizations

view details

idex-bot

commit sha 57c9d0f827269b5eac0b7909a276b4a77c427c77

chore(release): 1.4.2-beta.2 [skip ci] ### [1.4.2-beta.2](https://github.com/idexio/idex-sdk-js/compare/v1.4.2-beta.1...v1.4.2-beta.2) (2020-08-13) ### Bug Fixes * **rest:** make more web friendly by providing config options and helpers ([6f4c4d9](https://github.com/idexio/idex-sdk-js/commit/6f4c4d9efc648ecf1ac87c6d9920fdad8484b4bc))

view details

Braden Napier

commit sha 7b0cd9ecfeefa273e2e30956c185bfd36db6dea5

fix(rest): internal patch and put methods on authenticated client

view details

Braden Napier

commit sha 92d264c3f6a3f58398b45a3de94288b68589f740

Merge branch 'feature/more-web-friendly' into beta

view details

idex-bot

commit sha 1f4579b2afe9133168987c7431458f140eee62a5

chore(release): 1.4.2-beta.3 [skip ci] ### [1.4.2-beta.3](https://github.com/idexio/idex-sdk-js/compare/v1.4.2-beta.2...v1.4.2-beta.3) (2020-08-13) ### Bug Fixes * **rest:** internal patch and put methods on authenticated client ([7b0cd9e](https://github.com/idexio/idex-sdk-js/commit/7b0cd9ecfeefa273e2e30956c185bfd36db6dea5))

view details

Braden Napier

commit sha b3efb00c14bea7dc6aa175e71f14a2f17c69f2b5

fix(rest): normalize axios data access in authenticated client

view details

idex-bot

commit sha b5ba24f31c20fe0ddf87d7b3ac6940c742d912cf

chore(release): 1.4.2-beta.4 [skip ci] ### [1.4.2-beta.4](https://github.com/idexio/idex-sdk-js/compare/v1.4.2-beta.3...v1.4.2-beta.4) (2020-08-13) ### Bug Fixes * **rest:** normalize axios data access in authenticated client ([b3efb00](https://github.com/idexio/idex-sdk-js/commit/b3efb00c14bea7dc6aa175e71f14a2f17c69f2b5))

view details

Braden Napier

commit sha d86bf7acb003837476f7b9a5e33b9ca65e9c2be2

fix(rest): use same data prop access style for public as used by authenticated client

view details

Braden Napier

commit sha be21dcb027052f7bf7bfd381a96a130f99bf225c

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

idex-bot

commit sha 788abc0a0cebb851a70617150f3648dadebd684d

chore(release): 1.4.2-beta.5 [skip ci] ### [1.4.2-beta.5](https://github.com/idexio/idex-sdk-js/compare/v1.4.2-beta.4...v1.4.2-beta.5) (2020-08-13) ### Bug Fixes * **rest:** use same data prop access style for public as used by authenticated client ([d86bf7a](https://github.com/idexio/idex-sdk-js/commit/d86bf7acb003837476f7b9a5e33b9ca65e9c2be2))

view details

Alexander Hustler

commit sha 007b8e4c5932019071a6273424972a48a67c86c3

fix(enums): add limitMakerOnly to MarketStatus enum

view details

alexhustler

commit sha 129fc55d4fb45440f05202f7674c7af78cff7817

Merge pull request #144 from idexio/fix-market-status-enum fix(enums): add limitMakerOnly to MarketStatus enum

view details

idex-bot

commit sha fafd76eba88d029eb47c4d3fd2d1c482f1632fea

chore(release): 1.4.2-beta.6 [skip ci] ### [1.4.2-beta.6](https://github.com/idexio/idex-sdk-js/compare/v1.4.2-beta.5...v1.4.2-beta.6) (2020-08-21) ### Bug Fixes * **enums:** add limitMakerOnly to MarketStatus enum ([007b8e4](https://github.com/idexio/idex-sdk-js/commit/007b8e4c5932019071a6273424972a48a67c86c3))

view details

Alexander Hustler

commit sha 2155e851c42fb4b1b3f8796db7de31b796f1d104

fix(websocket): update orders event type to have the correct optional fields

view details

push time in 2 months

PR merged idexio/idex-sdk-js

Release beta Release beta

This PR was generated automatically. Merging it will transition beta into main.

+1648 -950

1 comment

25 changed files

idex-bot

pr closed time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha f10272ce70d1ae9e8853aaf6ba2055455a4e2a34

fix(websocket): implement client side liveness probe via ping

view details

Braden Napier

commit sha 1516e867d68b83dbc3413d75f64141a8ebaa698e

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha af9783b25a8ff98f60079ab5b5b269c11cf7fb65

fix(websocket): revert to addEventListener for isomorphic support

view details

Braden Napier

commit sha 48534fc64c1b55cea6f523435e2a408e6b2c117b

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 131224417e82783c170b95841a0efbb879ed3c74

fix(websocket): add better connection handling and events

view details

Braden Napier

commit sha 913344c985da9d1ebcfe76f9c128505929130b1b

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

issue commentwinstonjs/logform

TransformableInfo Typing out of date.

Yep, running into the same

dscalzi

comment created time in 2 months

issue commentonfido/onfido-node

Type declaration file not present on package dist root directory.

Also running into this.

Santiago8888

comment created time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha d6d81c1ff4addde88c3c83516ab5b741e4c2e22a

fix(dependencies): depend on tslib, not ts-lib for "importHelpers"

view details

Braden Napier

commit sha bfcda88ab1d41932aacd8b89a00f7a0d5f03dc07

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 767a5677952f87f9bcfccdd616fc2c3a1573276b

fix(websocket): we can only allow subscribe short names for public subscriptions since need wallet

view details

Braden Napier

commit sha 646378095fa668e086af0b51b535ea900c5397fe

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

issue commenttypescript-eslint/typescript-eslint

[no-shadow] new false positive in 4.0.0 for function argument types

For me the odd part is that the editor doesn't actually report it. It only shows up when I actually run eslint?

mceachen

comment created time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 9b3334c2099f6f1252e26a28a5d3101c8f1f790d

fix(websocket): fix type handling for ws events using on()

view details

Braden Napier

commit sha 8f924b2c0bf75fc7f4fac0db6aadd3f2b155358e

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 715a2ce78ccc0992bcfa8a9c86567fc50e570c6b

fix(websocket): unsubscribe doesnt require subscriptions (unsubscribe all)

view details

Braden Napier

commit sha 3b07ca63d7295471cecd3350485058df50a5b14b

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha ae64f5415bed01c1156a6ee623a0ee8ca0d45f83

fix(websocket): allow shortnames for unsubscribe as well

view details

Braden Napier

commit sha c1ce34a20ce2faaabd365898196de4a5546e7fc5

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 9fe4fe02e3106e2bedaf558f72218ac3707b45c1

fix(websocket): allow subscription to provide top level markets

view details

Braden Napier

commit sha fe19a52bb92d47fcced6d7a8447cf564b431c56b

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 9407b46c1ae7b771f04bf4c53e9bf7a01b6312e3

fix(websocket): allow websocket subscribe to use short (string) subscriptions

view details

Braden Napier

commit sha 8722f930fabbf20955be5331995f86832234a4e1

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha c5d42369deac45aee6a77c4f981a538400c09e16

fix(websocket): add type guard for isWebSocketResponseSubscriptions

view details

Braden Napier

commit sha 475ab105c290671f2fbc58f73b98c1b70380027b

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha ea49048caaff9bf8f3a7ea848445446c0058aa56

fix(websocket): add connectTimeout for webSocket and fix websocket client example in docs

view details

Braden Napier

commit sha b5074960fb5261a998e340ba714398d4fa0b12bf

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 03169ca3b47793622a3a103863a8e1182e9ec904

fix(websocket): ws.connect() can define if it wants to awaitConnected for its promise

view details

Braden Napier

commit sha 1087f1be710c97e7755ce72d86f1ae52995105e6

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 2cac2cca9dde6b9904d781ebceb847769f0f4b6d

fix(websocket): make ws requests chainable instead of returning void

view details

Braden Napier

commit sha c91feb5bd25f9dfcf8a65b5042bd2f0abc56ed15

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 4e720c08467a50d18ee11d77309c25cba7fb58b7

fix(websocket): add wallet optional key in auth subs types

view details

Braden Napier

commit sha bcf7991d7773d36f1b8b79bf30d66105dd210241

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 333ff053ca4807f94941734c6c05a5b71a32403d

fix(websocket): improve WebSocketRequestSubscriptionsByName typing

view details

Braden Napier

commit sha 9217614a9a3ce18eef0128dd47b25a818f588d9d

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 3a763e0ddc199a756dbd07fbdea99a4581625636

fix(websocket): fix response types for auth subscriptions to include wallet

view details

Braden Napier

commit sha ea6b4ca4d407b17d346a495bec82b88771af4b88

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 4204f61c5868bf9be3bc8c184b1d780a29b01476

fix(websocket): add authenticated object to unsubscribe for balances/orders

view details

Braden Napier

commit sha 3fd01a827341337f2a425d89bd195a401c1f5366

Merge branch 'beta' of github.com:idexio/idex-sdk-js into beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 65a350e7a1a3ef9990c3e1803b420760459233f7

fix(websocket): use a union so Exclude<> can be used for strict type case

view details

Braden Napier

commit sha 4635ecf5cc66543e0a5001db7e0638fc39b57e34

chore: merge beta

view details

push time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 619e77910e800aca0df8da246b4e90abcfea5457

fix(utils): export top level type guards for public use

view details

Braden Napier

commit sha 3fa990c3fa9ab229b0bee28cda94066d89889946

chore: merge working branch

view details

push time in 2 months

delete branch idexio/idex-sdk-js

delete branch : fix/ws-types

delete time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 161ece35dd8d740c1370270869f690363f50cb9f

fix(utils): add isCandleInterval type guard

view details

Braden Napier

commit sha 0188dc6ab25155b810fd4366b3f7f60397aafe72

Merge pull request #149 from idexio/fix/ws-types Add isCandleInterval type guard

view details

push time in 2 months

PR merged idexio/idex-sdk-js

Add isCandleInterval type guard

Since candle interval is generally strictly typed and string can not be used when it is expected, this type guard makes it possible to check to confirm a given string is a valid candle interval value.

+35 -24

0 comment

5 changed files

bradennapier

pr closed time in 2 months

PR opened idexio/idex-sdk-js

Add isCandleInterval type guard

Since candle interval is generally strictly typed and string can not be used when it is expected, this type guard makes it possible to check to confirm a given string is a valid candle interval value.

+35 -24

0 comment

5 changed files

pr created time in 2 months

create barnchidexio/idex-sdk-js

branch : fix/ws-types

created branch time in 2 months

delete branch idexio/idex-sdk-js

delete branch : fix/ws-types

delete time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 89099b19e6fab1a00b8e51936062c776740b8a4e

fix(typescript): fix build directory structure to resolve npm import

view details

Braden Napier

commit sha a35b0a7794d83dc75604ee495574604aed007844

Merge pull request #148 from idexio/fix/ws-types fix(typescript): fix build directory structure to resolve npm import

view details

push time in 2 months

PR merged idexio/idex-sdk-js

fix(typescript): fix build directory structure to resolve npm import
  • The build from the previous publish caused another level of folder depth in the dist folder so the npm module wouldn't work. This PR resolves that issue.
+1 -1

0 comment

1 changed file

bradennapier

pr closed time in 2 months

PR opened idexio/idex-sdk-js

fix(typescript): fix build directory structure to resolve npm import
  • The build from the previous publish caused another level of folder depth in the dist folder so the npm module wouldn't work. This PR resolves that issue.
+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchidexio/idex-sdk-js

branch : fix/ws-types

created branch time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha 75dd4a22cbf717ced88c3f91a72d883ffd39a785

fix(websocket): fix for websocket subscription types to make markets required

view details

Braden Napier

commit sha 93d4db73676927ea9930d55482c665cb318c9a06

fix(websocket): fix for remaining subscribe requests

view details

Braden Napier

commit sha eb086843a37d93627aa3d90d052993d4a5e30d56

fix(typescript): set typescript recommended config values

view details

Braden Napier

commit sha 42d99720b0ba4a38104a7c902b4c204f12355246

docs(websocket): provide tsdoc helper for wallet property

view details

Braden Napier

commit sha b13dd5d39dfd121e3f46d007b68ca5a3df86efa1

fix(websocket): add type guards for various subscription cases

view details

Braden Napier

commit sha 60bad8d58c5a5d390b60efea5cfe3e9779b02357

fix(websocket): add type guards to docs and finish implementing them

view details

Braden Napier

commit sha ac98f3f039214f64640791f2f3a3ed3aead99eac

Merge pull request #147 from idexio/fix/ws-types WebSocket Types & Guards

view details

push time in 2 months

delete branch idexio/idex-sdk-js

delete branch : fix/ws-types

delete time in 2 months

PR merged idexio/idex-sdk-js

WebSocket Types & Guards

In order to make the sdk easier to work with, this PR updates the WebSocket types to be more precise, as well as properly handling properties as required / optional where needed. It also properly types the expected subscriptions array.

  • Requires candles subscriptions always provided as object rather than allowing as a string like others (interval is required).
  • Top level subscribe is smart in that if a top level markets is not provided, the subscriptions that require markets provided will require the array themselves.
  • Provides exported constants for WEBSOCKET_AUTHENTICATED_SUBSCRIPTIONS and WEBSOCKET_UNAUTHENTICATED_SUBSCRIPTIONS which are array of accepted subscription names for each type of subscription.
  • Fixes bug in unsubscribe which accepted many invalid cases such as {}, { markets: [] }, among others.
  • Provides a loose type option for easier parsing of types.
  • Updates tsconfig to use recommended typescript config properties where possible
    • Full strict mode enabled
    • Strict file name case enforcement
    • useDefineForClassFields (adheres to es method for prop assignment)
    • importHelpers to reduce file size as recommended for npm libraries
  • Provides type guards for handling the various subscription cases and adds them to documentation
    • Need to document and add the already present REST API type guards as well
+538 -224

0 comment

18 changed files

bradennapier

pr closed time in 2 months

PR opened idexio/idex-sdk-js

WebSocket Types & Guards

In order to make the sdk easier to work with, this PR updates the WebSocket types to be more precise, as well as properly handling properties as required / optional where needed. It also properly types the expected subscriptions array.

  • Requires candles subscriptions always provided as object rather than allowing as a string like others (interval is required).
  • Top level subscribe is smart in that if a top level markets is not provided, the subscriptions that require markets provided will require the array themselves.
  • Provides exported constants for WEBSOCKET_AUTHENTICATED_SUBSCRIPTIONS and WEBSOCKET_UNAUTHENTICATED_SUBSCRIPTIONS which are array of accepted subscription names for each type of subscription.
  • Fixes bug in unsubscribe which accepted many invalid cases such as {}, { markets: [] }, among others.
  • Provides a loose type option for easier parsing of types.
  • Provides type guards for handling the various subscription cases and adds them to documentation
    • Need to document and add the already present REST API type guards as well
+538 -224

0 comment

18 changed files

pr created time in 2 months

push eventidexio/idex-sdk-js

Braden Napier

commit sha eb086843a37d93627aa3d90d052993d4a5e30d56

fix(typescript): set typescript recommended config values

view details

Braden Napier

commit sha 42d99720b0ba4a38104a7c902b4c204f12355246

docs(websocket): provide tsdoc helper for wallet property

view details

Braden Napier

commit sha b13dd5d39dfd121e3f46d007b68ca5a3df86efa1

fix(websocket): add type guards for various subscription cases

view details

Braden Napier

commit sha 60bad8d58c5a5d390b60efea5cfe3e9779b02357

fix(websocket): add type guards to docs and finish implementing them

view details

push time in 2 months

create barnchidexio/idex-sdk-js

branch : fix/ws-types

created branch time in 2 months

pull request commentmicrosoft/TypeScript

Reprioritize cross-project module specifier suggestions for auto-import

This sounds great! Thanks for the hard work on this issue!!

andrewbranch

comment created time in 2 months

issue commentprettier/prettier

Prettier 2.1.0 generates broken code with new `...infer T` syntax in TypeScript 4.0

@bradennapier feel free to open a new issue

Just replying to the message previous.

I'll have to play with the syntax when I can, I'm pretty sure what I said would work but on mobile atm.

It seems likely that prettier shouldn't correct either use of it -- or if the () is literally only valid when used as an array then it could be smarter.

If anyone else has time to test to confirm as well that'd be good.

The ...infer style is the new syntax though and worst case could be converted to the other style if needed in meantime easy enough :).

papb

comment created time in 2 months

issue commentprettier/prettier

Prettier 2.1.0 generates broken code with new `...infer T` syntax in TypeScript 4.0

I am not sure the exact semantics atm. It is actually quite possible that there are cases where ...(infer U) would be used in a valid way, I would have to play with it some more. There isn't actually any direct information there in the release notes.

papb

comment created time in 2 months

pull request commentprettier/prettier

Typescript: Fix broken format for `...infer T`

One thing to note -

...(infer U)

is also valid Typescript so I do not think prettier should automatically format it if someone writes it one way or another.

fisker

comment created time in 2 months

issue commentprettier/prettier

Support TypeScript 4.0

Figured it'd get missed ;) subtle difference but completely breaks inference.

sosukesuzuki

comment created time in 2 months

issue commentbradennapier/eslint-plus-action

Failed to generate URL to download artifact

Yeah, they have had some issues with actions from time to time.

luisherranz

comment created time in 2 months

startedcevek/ttypescript

started time in 2 months

issue commentmicrosoft/TypeScript

auto-import favors import from target instead of source

Thanks @andrewbranch not worried it won't be fixed, was just curious for real cause I was trying to think of a case :-P, thanks for the descriptive response though!

The paths are used to remove relative imports and is a fairly common request from people (there are lots of issues around this). It is a common pattern with webpack for example to add a resolve.alias to handle this so that your src dir is always allowed to imported as an absolute.

I accomplish this in typescript by adding https://github.com/zerkalica/zerollup as a plugin, but this issue would occur for anyone using webpack or rollup as example as well, or https://github.com/dividab/tsconfig-paths -- but there are probably around 10-12 packages all to deal with these cases.

eslint plugins also exist specifically for this https://github.com/alexgorbatchev/eslint-import-resolver-typescript

chengB12

comment created time in 2 months

startedalexgorbatchev/eslint-import-resolver-typescript

started time in 2 months

startedzerkalica/zerollup

started time in 2 months

starteddividab/tsconfig-paths

started time in 2 months

issue commentmicrosoft/vscode

(loading...) indicator overrides real results in TypeScript hover

That does not seem to make any difference. That was the first thing I tried the other day as mentioned a few comments up. I am having a massive other problem atm that is in another issue which I think may be partly to blame for the constant issues (it always wants to auto import my dist dir files instead of the right files).

Thanks, i'll try that again perhaps.

DanielRosenwasser

comment created time in 2 months

issue commentsequelize/sequelize

Javascript BigInt support in Node 10+

Seems like its about time we solve this :-)

gabegorelick

comment created time in 2 months

issue commentmicrosoft/vscode

(loading...) indicator overrides real results in TypeScript hover

So this is actually a lot worse than I originally thought as well. This loading will happen a lot... not just initial loading. It seems like about half the time I hover it has to load (for the 30-60 seconds) before showing any type information, even if no files have been changed.

DanielRosenwasser

comment created time in 2 months

more