profile
viewpoint

rust-lang/chalk 947

An implementation and definition of the Rust trait system using a PROLOG-like logic solver

brson/rust 9

pursuing the trifecta

alexcrichton/cargo 1

Cargo Experiments

rust-lang-ci/rust 1

Empowering everyone to build reliable and efficient software.

PR merged rust-lang/cargo

Remove redundant "For example, " S-waiting-on-bors
+1 -1

5 comments

1 changed file

sean-hut

pr closed time in 29 minutes

push eventrust-lang/cargo

Sean Hutchings

commit sha 587922d72911432ca7767aabac0d27557d875b5d

Remove redundant "For example, " Signed-off-by: Sean Hutchings <seanhut@yandex.com>

view details

bors

commit sha 31cf507295306f280996f2ff7651fe72a4bca58d

Auto merge of #8810 - sean-hut:remove-redundant-for-example, r=ehuss Remove redundant "For example, "

view details

push time in 29 minutes

pull request commentrust-lang/cargo

Remove redundant "For example, "

:sunny: Test successful - checks-actions Approved by: ehuss Pushing 31cf507295306f280996f2ff7651fe72a4bca58d to master... <!-- homu: {"type":"BuildCompleted","approved_by":"ehuss","base_ref":"master","builders":{"checks-actions":"https://github.com/rust-lang/cargo/runs/1312076686"},"merge_sha":"31cf507295306f280996f2ff7651fe72a4bca58d"} -->

sean-hut

comment created time in 29 minutes

pull request commentrust-lang/cargo

Remove redundant "For example, "

:hourglass: Testing commit 587922d72911432ca7767aabac0d27557d875b5d with merge 31cf507295306f280996f2ff7651fe72a4bca58d... <!-- homu: {"type":"BuildStarted","head_sha":"587922d72911432ca7767aabac0d27557d875b5d","merge_sha":"31cf507295306f280996f2ff7651fe72a4bca58d"} -->

sean-hut

comment created time in an hour

push eventrust-lang/cargo

Sean Hutchings

commit sha 587922d72911432ca7767aabac0d27557d875b5d

Remove redundant "For example, " Signed-off-by: Sean Hutchings <seanhut@yandex.com>

view details

bors

commit sha 31cf507295306f280996f2ff7651fe72a4bca58d

Auto merge of #8810 - sean-hut:remove-redundant-for-example, r=ehuss Remove redundant "For example, "

view details

push time in an hour

PR merged rust-lang/cargo

Document platform-specific build-dependencies S-waiting-on-bors

It turns out that target.'cfg()'.build-dependencies are a currently stable but undocumented feature. This PR mentions it in the cargo reference.

+13 -0

5 comments

1 changed file

roblabla

pr closed time in an hour

push eventrust-lang/cargo

Robin Lambertz

commit sha 2b2f0443fa2699abf535bd23095c7d41af1e534a

Document platform-specific build-dependencies It turns out that `target.'cfg()'.build-dependencies` are a currently stable but undocumented feature.

view details

bors

commit sha e497e325ece73d46c475abce0e8ff271355d7dbc

Auto merge of #8809 - roblabla:patch-1, r=ehuss Document platform-specific build-dependencies It turns out that `target.'cfg()'.build-dependencies` are a currently stable but undocumented feature. This PR mentions it in the cargo reference.

view details

push time in an hour

pull request commentrust-lang/cargo

Document platform-specific build-dependencies

:sunny: Test successful - checks-actions Approved by: ehuss Pushing e497e325ece73d46c475abce0e8ff271355d7dbc to master... <!-- homu: {"type":"BuildCompleted","approved_by":"ehuss","base_ref":"master","builders":{"checks-actions":"https://github.com/rust-lang/cargo/runs/1311972483"},"merge_sha":"e497e325ece73d46c475abce0e8ff271355d7dbc"} -->

roblabla

comment created time in an hour

pull request commentrust-lang/rust

BTreeMap: ban BoxedNode from Root

:umbrella: The latest upstream changes (presumably #77187) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author
ssomers

comment created time in an hour

pull request commentrust-lang/rust

Rollup of 16 pull requests

:pushpin: Commit 4236d27c9bb0af5cbdfaaa840b211827c65fb1ee has been approved by JohnTitor

<!-- @bors r=JohnTitor 4236d27c9bb0af5cbdfaaa840b211827c65fb1ee --> <!-- homu: {"type":"Approved","sha":"4236d27c9bb0af5cbdfaaa840b211827c65fb1ee","approver":"JohnTitor"} -->

JohnTitor

comment created time in an hour

pull request commentrust-lang/cargo

Remove redundant "For example, "

:pushpin: Commit 587922d72911432ca7767aabac0d27557d875b5d has been approved by ehuss

<!-- @bors r=ehuss 587922d72911432ca7767aabac0d27557d875b5d --> <!-- homu: {"type":"Approved","sha":"587922d72911432ca7767aabac0d27557d875b5d","approver":"ehuss"} -->

sean-hut

comment created time in an hour

pull request commentrust-lang/rust

Move ExpnId fingerprint cache from TLS to StableHashingContext

:sunny: Try build successful - checks-actions Build commit: 5b3632cd0dcd6a5560a00fecbf3ccb1b1254f98f (5b3632cd0dcd6a5560a00fecbf3ccb1b1254f98f) <!-- homu: {"type":"TryBuildCompleted","builders":{"checks-actions":"https://github.com/rust-lang-ci/rust/runs/1311880084"},"merge_sha":"5b3632cd0dcd6a5560a00fecbf3ccb1b1254f98f"} -->

Aaron1011

comment created time in an hour

pull request commentrust-lang/cargo

Document platform-specific build-dependencies

:hourglass: Testing commit 2b2f0443fa2699abf535bd23095c7d41af1e534a with merge e497e325ece73d46c475abce0e8ff271355d7dbc... <!-- homu: {"type":"BuildStarted","head_sha":"2b2f0443fa2699abf535bd23095c7d41af1e534a","merge_sha":"e497e325ece73d46c475abce0e8ff271355d7dbc"} -->

roblabla

comment created time in an hour

push eventrust-lang/cargo

Robin Lambertz

commit sha 2b2f0443fa2699abf535bd23095c7d41af1e534a

Document platform-specific build-dependencies It turns out that `target.'cfg()'.build-dependencies` are a currently stable but undocumented feature.

view details

bors

commit sha e497e325ece73d46c475abce0e8ff271355d7dbc

Auto merge of #8809 - roblabla:patch-1, r=ehuss Document platform-specific build-dependencies It turns out that `target.'cfg()'.build-dependencies` are a currently stable but undocumented feature. This PR mentions it in the cargo reference.

view details

push time in an hour

pull request commentrust-lang/cargo

Document platform-specific build-dependencies

:pushpin: Commit 2b2f0443fa2699abf535bd23095c7d41af1e534a has been approved by ehuss

<!-- @bors r=ehuss 2b2f0443fa2699abf535bd23095c7d41af1e534a --> <!-- homu: {"type":"Approved","sha":"2b2f0443fa2699abf535bd23095c7d41af1e534a","approver":"ehuss"} -->

roblabla

comment created time in an hour

pull request commentrust-lang/rust

Fix #66228 and #71924 (improve error message for wrong number of generic args)

:umbrella: The latest upstream changes (presumably #77187) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author
Patryk27

comment created time in an hour

pull request commentrust-lang/rust

rustc_span: avoid hashing ExpnId tag when using cached hash

:sunny: Try build successful - checks-actions Build commit: c78e1a98403d935f0d0ab399b69944da91214f16 (c78e1a98403d935f0d0ab399b69944da91214f16) <!-- homu: {"type":"TryBuildCompleted","builders":{"checks-actions":"https://github.com/rust-lang-ci/rust/runs/1311823030"},"merge_sha":"c78e1a98403d935f0d0ab399b69944da91214f16"} -->

tgnottingham

comment created time in 2 hours

PR merged rust-lang/rust

Support custom allocators in `Box` A-allocators S-waiting-on-bors T-libs merged-by-bors

r? @Amanieu

This pull request requires a crater run.

Prior work:

Currently blocked on:

  • ~#77118~
  • ~https://github.com/rust-lang/chalk/issues/615 (#77515)~
+577 -215

36 comments

30 changed files

TimDiekmann

pr closed time in 2 hours

pull request commentrust-lang/rust

Remove unused set-discriminant statements and assignments regardless of rvalue

:hourglass: Testing commit 4c3e06a0ba557c5915d8c00f23455461549f07f6 with merge a4d30a7b490065f0aa56f58e508a11546445aea9... <!-- homu: {"type":"BuildStarted","head_sha":"4c3e06a0ba557c5915d8c00f23455461549f07f6","merge_sha":"a4d30a7b490065f0aa56f58e508a11546445aea9"} -->

tmiasko

comment created time in 2 hours

push eventrust-lang-ci/rust

Tomasz Miąsko

commit sha 124b63acf333a6e938be5086d592657e312ea57d

simplify-locals: Add yet to be optimized test cases

view details

Tomasz Miąsko

commit sha 11269536e294a497b9991382cc9afda1b6ab9de0

simplify-locals: Represent use counts with u32

view details

Tomasz Miąsko

commit sha a6b64be8b51d680ca8185e519be81937c1a98ed0

simplify-locals: Unify use count visitors The simplify locals implementation uses two different visitors to update the locals use counts. The DeclMarker calculates the initial use counts. The StatementDeclMarker updates the use counts as statements are being removed from the block. Replace them with a single visitor that can operate in either mode, ensuring consistency of behaviour. Additionally use exhaustive match to clarify what is being optimized. No functional changes intended.

view details

Tomasz Miąsko

commit sha e1e48ae29b52d214f93d816e99056aacb102a90a

simplify-locals: Change RemoveStatements visitor into a function No functionl changes intended.

view details

Tomasz Miąsko

commit sha 52d37826858ee4dad6b66a3060994f41df247770

simplify-locals: Remove unused set-discriminant statements Update affected ui & incremental tests to use a user declared variable bindings instead of temporaries. The former are preserved because of debuginfo, the latter are not.

view details

Tomasz Miąsko

commit sha 4c3e06a0ba557c5915d8c00f23455461549f07f6

simplify-locals: Remove unused assignments regardless of rvalue kind

view details

bors

commit sha a4d30a7b490065f0aa56f58e508a11546445aea9

Auto merge of #77876 - tmiasko:simplify-locals, r=wesleywiser Remove unused set-discriminant statements and assignments regardless of rvalue * Represent use counts with u32 * Unify use count visitors * Change RemoveStatements visitor into a function * Remove unused set-discriminant statements * Use exhaustive match to clarify what is being optimized * Remove unused assignments regardless of rvalue kind

view details

push time in 2 hours

push eventrust-lang/rust

Tim Diekmann

commit sha f288cd2e179f600fa00c2a407206a12f6c5a91e0

Support custom allocators in `Box` Remove `Box::leak_with_alloc` Add leak-test for box with allocator Rename `AllocErr` to `AllocError` in leak-test Add `Box::alloc` and adjust examples to use the new API

view details

Tim Diekmann

commit sha d5720bba8f5b278616a2fbd0da39478879a3f68b

Fix mir-opt output for 32 bit

view details

Tim Diekmann

commit sha 955b37b3059a7e06842559af54e1685e33b0cf6c

Merge branch 'master' into box-alloc

view details

Tim Diekmann

commit sha 693a2bf18b7090202784f561de3dfca45c4f79be

Rename `Box::alloc` to `Box::alloc_ref`

view details

Tim Diekmann

commit sha 06e4497a04615ad95dff4240ca9980f19ed364ad

Merge remote-tracking branch 'upstream/master' into box-alloc

view details

bors

commit sha fd542592f08ca0d1f7255600115c2eafdf6b5da7

Auto merge of #77187 - TimDiekmann:box-alloc, r=Amanieu Support custom allocators in `Box` r? `@Amanieu` This pull request requires a crater run. ### Prior work: - #71873 - #58457 - [`alloc-wg`](https://github.com/TimDiekmann/alloc-wg)-crate Currently blocked on: - ~#77118~ - ~https://github.com/rust-lang/chalk/issues/615 (#77515)~

view details

push time in 2 hours

push eventrust-lang-ci/rust

Tim Diekmann

commit sha f288cd2e179f600fa00c2a407206a12f6c5a91e0

Support custom allocators in `Box` Remove `Box::leak_with_alloc` Add leak-test for box with allocator Rename `AllocErr` to `AllocError` in leak-test Add `Box::alloc` and adjust examples to use the new API

view details

Tim Diekmann

commit sha d5720bba8f5b278616a2fbd0da39478879a3f68b

Fix mir-opt output for 32 bit

view details

Tim Diekmann

commit sha 955b37b3059a7e06842559af54e1685e33b0cf6c

Merge branch 'master' into box-alloc

view details

Tim Diekmann

commit sha 693a2bf18b7090202784f561de3dfca45c4f79be

Rename `Box::alloc` to `Box::alloc_ref`

view details

Tim Diekmann

commit sha 06e4497a04615ad95dff4240ca9980f19ed364ad

Merge remote-tracking branch 'upstream/master' into box-alloc

view details

bors

commit sha fd542592f08ca0d1f7255600115c2eafdf6b5da7

Auto merge of #77187 - TimDiekmann:box-alloc, r=Amanieu Support custom allocators in `Box` r? `@Amanieu` This pull request requires a crater run. ### Prior work: - #71873 - #58457 - [`alloc-wg`](https://github.com/TimDiekmann/alloc-wg)-crate Currently blocked on: - ~#77118~ - ~https://github.com/rust-lang/chalk/issues/615 (#77515)~

view details

push time in 2 hours

pull request commentrust-lang/rust

Support custom allocators in `Box`

:sunny: Test successful - checks-actions Approved by: Amanieu Pushing fd542592f08ca0d1f7255600115c2eafdf6b5da7 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"Amanieu","base_ref":"master","builders":{"checks-actions":"https://github.com/rust-lang-ci/rust/runs/1311811632"},"merge_sha":"fd542592f08ca0d1f7255600115c2eafdf6b5da7"} -->

TimDiekmann

comment created time in 2 hours

pull request commentrust-lang/rust

Implement -Z function-sections=yes|no

:pushpin: Commit 056942215cf8dc39686fa80e42b4e73657d4fed5 has been approved by nagisa,bjorn3

<!-- @bors r=nagisa,bjorn3 056942215cf8dc39686fa80e42b4e73657d4fed5 --> <!-- homu: {"type":"Approved","sha":"056942215cf8dc39686fa80e42b4e73657d4fed5","approver":"nagisa,bjorn3"} -->

nox

comment created time in 2 hours

pull request commentrust-lang/rust

Move ExpnId fingerprint cache from TLS to StableHashingContext

:hourglass: Trying commit 06d76a63cda285e4443368521f07096b24732a01 with merge 5b3632cd0dcd6a5560a00fecbf3ccb1b1254f98f... <!-- homu: {"type":"TryBuildStarted","head_sha":"06d76a63cda285e4443368521f07096b24732a01","merge_sha":"5b3632cd0dcd6a5560a00fecbf3ccb1b1254f98f"} -->

Aaron1011

comment created time in 2 hours

push eventrust-lang-ci/rust

Aaron Hill

commit sha 06d76a63cda285e4443368521f07096b24732a01

Move ExpnId fingerprint cache from TLS to StableHashingContext

view details

bors

commit sha 5b3632cd0dcd6a5560a00fecbf3ccb1b1254f98f

Auto merge of #78418 - Aaron1011:expn-hash-cache, r=<try> Move ExpnId fingerprint cache from TLS to StableHashingContext

view details

push time in 2 hours

pull request commentrust-lang/rust

[Experiment] Testing out some formatting things.

:sunny: Try build successful - checks-actions Build commit: 238da19124ef17a0352a1ff2bb816d57c1e6b448 (238da19124ef17a0352a1ff2bb816d57c1e6b448) <!-- homu: {"type":"TryBuildCompleted","builders":{"checks-actions":"https://github.com/rust-lang-ci/rust/runs/1311731536"},"merge_sha":"238da19124ef17a0352a1ff2bb816d57c1e6b448"} -->

m-ou-se

comment created time in 2 hours

push eventrust-lang-ci/rust

Tyson Nottingham

commit sha a3623e05429952cd8cbfd875409d3cb7c8f8045d

rustc_span: avoid hashing ExpnId tag when using cached hash

view details

bors

commit sha c78e1a98403d935f0d0ab399b69944da91214f16

Auto merge of #78415 - tgnottingham:expn_id_tag_hash, r=<try> rustc_span: avoid hashing ExpnId tag when using cached hash

view details

push time in 2 hours

pull request commentrust-lang/rust

rustc_span: avoid hashing ExpnId tag when using cached hash

:hourglass: Trying commit a3623e05429952cd8cbfd875409d3cb7c8f8045d with merge c78e1a98403d935f0d0ab399b69944da91214f16... <!-- homu: {"type":"TryBuildStarted","head_sha":"a3623e05429952cd8cbfd875409d3cb7c8f8045d","merge_sha":"c78e1a98403d935f0d0ab399b69944da91214f16"} -->

tgnottingham

comment created time in 2 hours

pull request commentrust-lang/rust

Capture output from threads spawned in tests

:pushpin: Commit 7c4fe002131f1160f2054885ab40c74464951a64 has been approved by m-ou-se

<!-- @bors r=m-ou-se 7c4fe002131f1160f2054885ab40c74464951a64 --> <!-- homu: {"type":"Approved","sha":"7c4fe002131f1160f2054885ab40c74464951a64","approver":"m-ou-se"} -->

SergioBenitez

comment created time in 3 hours

push eventrust-lang-ci/rust

Eduard-Mihai Burtescu

commit sha 8c942c1511cc99fbc8f3e6ed56e5e3cfd8c0ff4a

rustc_mir: rename `location: SourceInfo` to `source_info`.

view details

Eduard-Mihai Burtescu

commit sha 708fc0b692b4ec7894986369214dc1f13ca33882

rustc_mir: use Instance more in the inliner.

view details

Eduard-Mihai Burtescu

commit sha 6bc5eafbce7dd3630a26b9f2e94938a4dfc61c06

rustc_mir: track inlined callees in SourceScopeData.

view details

Eduard-Mihai Burtescu

commit sha fb36440b7a0d2444dd079876d4fde6b0ee9d5670

test: ensure #[track_caller] tests also test MIR inlining.

view details

Eduard-Mihai Burtescu

commit sha 6451b39a25fbad9e991c6ea014a86217c52d3fd6

rustc_mir: support MIR-inlining #[track_caller] functions.

view details

Eduard-Mihai Burtescu

commit sha 387e31c9a7e6f7df3da513e2241a03e0b738ea4d

rustc_mir: properly map scope parent chains into the caller when inlining.

view details

Eduard-Mihai Burtescu

commit sha 2bfb462b58db63aaa0a43bacde39687928fe901e

rustc_mir: don't throw away inlined locals' spans.

view details

Eduard-Mihai Burtescu

commit sha 9d57c417fc1bac25b0274a34ae581c2e18a9d44e

rustc_codegen_llvm: create `DIFile`s from just `SourceFile`s.

view details

Eduard-Mihai Burtescu

commit sha fa2b381ec83556111a99750bcc7688521d7e8b0d

rustc_codegen_llvm: move DISubprogram creation to a dbg_scope_fn method.

view details

Eduard-Mihai Burtescu

commit sha 88d874de6395a5422caad1f61783dadd395d49d0

rustc_codegen_llvm: avoid converting between DILocation and Value.

view details

Eduard-Mihai Burtescu

commit sha 737499593db6d7702de3bf9d0070ec3f8e65d71e

rustc_codegen_llvm: expose DILocation to rustc_codegen_ssa.

view details

Eduard-Mihai Burtescu

commit sha 0ce4452fce0a1aa6d8a2a7f08da105c225463f4d

rustc_codegen_llvm: add support for inlined function debuginfo.

view details

Eduard-Mihai Burtescu

commit sha 9b21c50335887fe9ecbd44d5a3efa105feae0a6d

rustc_mir: create the Integrator as soon as possible in MIR inlining.

view details

Eduard-Mihai Burtescu

commit sha aff4d3e659872ec1fbf469e91575a9a711ce4705

rustc_mir: run the MIR inlining Integrator on the whole callee body at once.

view details

oli

commit sha f8aae504692295095454fa221c2ca1a7a46fb3c5

Prefer `bug!` over `unwrap()`

view details

oli

commit sha 7101ce9127d805e602ea3fa75d5bbea4bf1e5dce

Deduplicate span and dbg_scope adjustment

view details

oli

commit sha 7ae8bc3957fa78dbe99ec70ddbdc27a9be42e52d

Add an inlining debuginfo test

view details

oli

commit sha 2b3f00928c3b0db93c87d462a53c9f0df98f3e27

Ignore long lines in test

view details

bors

commit sha 0da6d42f297642a60f2640ec313b879b376b9ad8

Auto merge of #68965 - eddyb:mir-inline-scope, r=nagisa,oli-obk rustc_mir: track inlined callees in SourceScopeData. We now record which MIR scopes are the roots of *other* (inlined) functions's scope trees, which allows us to generate the correct debuginfo in codegen, similar to what LLVM inlining generates. This PR makes the `ui` test `backtrace-debuginfo` pass, if the MIR inliner is turned on by default. Also, `#[track_caller]` is now correct in the face of MIR inlining (cc `@anp).` Fixes #76997. r? `@rust-lang/wg-mir-opt`

view details

Mara Bos

commit sha 149b7e5c5c5a6336bb16e22f5d40bf62667ab40b

Work in progress.

view details

push time in 3 hours

pull request commentrust-lang/rust

[Experiment] Testing out some formatting things.

:hourglass: Trying commit 149b7e5c5c5a6336bb16e22f5d40bf62667ab40b with merge 238da19124ef17a0352a1ff2bb816d57c1e6b448... <!-- homu: {"type":"TryBuildStarted","head_sha":"149b7e5c5c5a6336bb16e22f5d40bf62667ab40b","merge_sha":"238da19124ef17a0352a1ff2bb816d57c1e6b448"} -->

m-ou-se

comment created time in 3 hours

pull request commentrust-lang/rust

Implement -Z function-sections=yes|no

:v: @bjorn3 can now approve this pull request <!-- homu: {"type":"Delegated","delegator":"jyn514","delegate":"bjorn3"} -->

nox

comment created time in 3 hours

pull request commentrust-lang/rust

Add [T]::as_chunks(_mut)

:pushpin: Commit 652f34d2709ec0c323ae632ba14992f80ebf7629 has been approved by LukasKalbertodt

<!-- @bors r=LukasKalbertodt 652f34d2709ec0c323ae632ba14992f80ebf7629 --> <!-- homu: {"type":"Approved","sha":"652f34d2709ec0c323ae632ba14992f80ebf7629","approver":"LukasKalbertodt"} -->

scottmcm

comment created time in 3 hours

pull request commentrust-lang/rust

Suggest that expressions that look like const generic arguments should be enclosed in brackets

:pushpin: Commit ac1454001cee3f344a1104fd0cf4012b93443b0b has been approved by petrochenkov

<!-- @bors r=petrochenkov ac1454001cee3f344a1104fd0cf4012b93443b0b --> <!-- homu: {"type":"Approved","sha":"ac1454001cee3f344a1104fd0cf4012b93443b0b","approver":"petrochenkov"} -->

varkor

comment created time in 3 hours

pull request commentrust-lang/rust

I can't stop writing copy propagation passes

:umbrella: The latest upstream changes (presumably #68965) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author
jonas-schievink

comment created time in 4 hours

pull request commentrust-lang/rust

Add some regression tests

:pushpin: Commit 4641d2e6aa990d3fb6730a3208e9fd857f52eb33 has been approved by lcnr

<!-- @bors r=lcnr 4641d2e6aa990d3fb6730a3208e9fd857f52eb33 --> <!-- homu: {"type":"Approved","sha":"4641d2e6aa990d3fb6730a3208e9fd857f52eb33","approver":"lcnr"} -->

camelid

comment created time in 4 hours

pull request commentrust-lang/rust

[mir-opt] Allow debuginfo to be generated for a constant or a Place

:umbrella: The latest upstream changes (presumably #68965) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author
wesleywiser

comment created time in 4 hours

PR merged rust-lang/rust

rustc_mir: track inlined callees in SourceScopeData. A-mir-opt S-waiting-on-bors merged-by-bors

We now record which MIR scopes are the roots of other (inlined) functions's scope trees, which allows us to generate the correct debuginfo in codegen, similar to what LLVM inlining generates. This PR makes the ui test backtrace-debuginfo pass, if the MIR inliner is turned on by default.

Also, #[track_caller] is now correct in the face of MIR inlining (cc @anp).

Fixes #76997.

r? @rust-lang/wg-mir-opt

+878 -618

78 comments

68 changed files

eddyb

pr closed time in 4 hours

push eventrust-lang-ci/rust

Tim Diekmann

commit sha f288cd2e179f600fa00c2a407206a12f6c5a91e0

Support custom allocators in `Box` Remove `Box::leak_with_alloc` Add leak-test for box with allocator Rename `AllocErr` to `AllocError` in leak-test Add `Box::alloc` and adjust examples to use the new API

view details

Tim Diekmann

commit sha d5720bba8f5b278616a2fbd0da39478879a3f68b

Fix mir-opt output for 32 bit

view details

Tim Diekmann

commit sha 955b37b3059a7e06842559af54e1685e33b0cf6c

Merge branch 'master' into box-alloc

view details

Tim Diekmann

commit sha 693a2bf18b7090202784f561de3dfca45c4f79be

Rename `Box::alloc` to `Box::alloc_ref`

view details

Tim Diekmann

commit sha 06e4497a04615ad95dff4240ca9980f19ed364ad

Merge remote-tracking branch 'upstream/master' into box-alloc

view details

bors

commit sha fd542592f08ca0d1f7255600115c2eafdf6b5da7

Auto merge of #77187 - TimDiekmann:box-alloc, r=Amanieu Support custom allocators in `Box` r? `@Amanieu` This pull request requires a crater run. ### Prior work: - #71873 - #58457 - [`alloc-wg`](https://github.com/TimDiekmann/alloc-wg)-crate Currently blocked on: - ~#77118~ - ~https://github.com/rust-lang/chalk/issues/615 (#77515)~

view details

push time in 4 hours

pull request commentrust-lang/rust

Support custom allocators in `Box`

:hourglass: Testing commit 06e4497a04615ad95dff4240ca9980f19ed364ad with merge fd542592f08ca0d1f7255600115c2eafdf6b5da7... <!-- homu: {"type":"BuildStarted","head_sha":"06e4497a04615ad95dff4240ca9980f19ed364ad","merge_sha":"fd542592f08ca0d1f7255600115c2eafdf6b5da7"} -->

TimDiekmann

comment created time in 4 hours

push eventrust-lang/rust

Eduard-Mihai Burtescu

commit sha 8c942c1511cc99fbc8f3e6ed56e5e3cfd8c0ff4a

rustc_mir: rename `location: SourceInfo` to `source_info`.

view details

Eduard-Mihai Burtescu

commit sha 708fc0b692b4ec7894986369214dc1f13ca33882

rustc_mir: use Instance more in the inliner.

view details

Eduard-Mihai Burtescu

commit sha 6bc5eafbce7dd3630a26b9f2e94938a4dfc61c06

rustc_mir: track inlined callees in SourceScopeData.

view details

Eduard-Mihai Burtescu

commit sha fb36440b7a0d2444dd079876d4fde6b0ee9d5670

test: ensure #[track_caller] tests also test MIR inlining.

view details

Eduard-Mihai Burtescu

commit sha 6451b39a25fbad9e991c6ea014a86217c52d3fd6

rustc_mir: support MIR-inlining #[track_caller] functions.

view details

Eduard-Mihai Burtescu

commit sha 387e31c9a7e6f7df3da513e2241a03e0b738ea4d

rustc_mir: properly map scope parent chains into the caller when inlining.

view details

Eduard-Mihai Burtescu

commit sha 2bfb462b58db63aaa0a43bacde39687928fe901e

rustc_mir: don't throw away inlined locals' spans.

view details

Eduard-Mihai Burtescu

commit sha 9d57c417fc1bac25b0274a34ae581c2e18a9d44e

rustc_codegen_llvm: create `DIFile`s from just `SourceFile`s.

view details

Eduard-Mihai Burtescu

commit sha fa2b381ec83556111a99750bcc7688521d7e8b0d

rustc_codegen_llvm: move DISubprogram creation to a dbg_scope_fn method.

view details

Eduard-Mihai Burtescu

commit sha 88d874de6395a5422caad1f61783dadd395d49d0

rustc_codegen_llvm: avoid converting between DILocation and Value.

view details

Eduard-Mihai Burtescu

commit sha 737499593db6d7702de3bf9d0070ec3f8e65d71e

rustc_codegen_llvm: expose DILocation to rustc_codegen_ssa.

view details

Eduard-Mihai Burtescu

commit sha 0ce4452fce0a1aa6d8a2a7f08da105c225463f4d

rustc_codegen_llvm: add support for inlined function debuginfo.

view details

Eduard-Mihai Burtescu

commit sha 9b21c50335887fe9ecbd44d5a3efa105feae0a6d

rustc_mir: create the Integrator as soon as possible in MIR inlining.

view details

Eduard-Mihai Burtescu

commit sha aff4d3e659872ec1fbf469e91575a9a711ce4705

rustc_mir: run the MIR inlining Integrator on the whole callee body at once.

view details

oli

commit sha f8aae504692295095454fa221c2ca1a7a46fb3c5

Prefer `bug!` over `unwrap()`

view details

oli

commit sha 7101ce9127d805e602ea3fa75d5bbea4bf1e5dce

Deduplicate span and dbg_scope adjustment

view details

oli

commit sha 7ae8bc3957fa78dbe99ec70ddbdc27a9be42e52d

Add an inlining debuginfo test

view details

oli

commit sha 2b3f00928c3b0db93c87d462a53c9f0df98f3e27

Ignore long lines in test

view details

bors

commit sha 0da6d42f297642a60f2640ec313b879b376b9ad8

Auto merge of #68965 - eddyb:mir-inline-scope, r=nagisa,oli-obk rustc_mir: track inlined callees in SourceScopeData. We now record which MIR scopes are the roots of *other* (inlined) functions's scope trees, which allows us to generate the correct debuginfo in codegen, similar to what LLVM inlining generates. This PR makes the `ui` test `backtrace-debuginfo` pass, if the MIR inliner is turned on by default. Also, `#[track_caller]` is now correct in the face of MIR inlining (cc `@anp).` Fixes #76997. r? `@rust-lang/wg-mir-opt`

view details

push time in 4 hours

issue closedrust-lang/rust

MIR inlining doesn't properly adjust SourceScopeData parent_scope fields.

After MIR inlining, this example (see on godbolt):

fn foo() {
    let f = |x| { let y = x; y };
    f(())
}

produces this scope shape (I've removed all the lets and spans):

    scope 1 {
        debug f => _1;
        scope 2 {
            debug x => _4;
        }
    }
    scope 3 {
        debug y => _3;
    }

You can see x is properly located, in the inlined outermost callee scope (2) as a child of the callsite scope (1). But y isn't, as its scope (3) keeps the original parent_scope (0) it had in the callee body, pre-inlining.

Will try to fix this as part of #68965, or maybe open a separate PR if I can shuffle the commits around. cc @rust-lang/wg-mir-opt

closed time in 4 hours

eddyb

push eventrust-lang-ci/rust

Eduard-Mihai Burtescu

commit sha 8c942c1511cc99fbc8f3e6ed56e5e3cfd8c0ff4a

rustc_mir: rename `location: SourceInfo` to `source_info`.

view details

Eduard-Mihai Burtescu

commit sha 708fc0b692b4ec7894986369214dc1f13ca33882

rustc_mir: use Instance more in the inliner.

view details

Eduard-Mihai Burtescu

commit sha 6bc5eafbce7dd3630a26b9f2e94938a4dfc61c06

rustc_mir: track inlined callees in SourceScopeData.

view details

Eduard-Mihai Burtescu

commit sha fb36440b7a0d2444dd079876d4fde6b0ee9d5670

test: ensure #[track_caller] tests also test MIR inlining.

view details

Eduard-Mihai Burtescu

commit sha 6451b39a25fbad9e991c6ea014a86217c52d3fd6

rustc_mir: support MIR-inlining #[track_caller] functions.

view details

Eduard-Mihai Burtescu

commit sha 387e31c9a7e6f7df3da513e2241a03e0b738ea4d

rustc_mir: properly map scope parent chains into the caller when inlining.

view details

Eduard-Mihai Burtescu

commit sha 2bfb462b58db63aaa0a43bacde39687928fe901e

rustc_mir: don't throw away inlined locals' spans.

view details

Eduard-Mihai Burtescu

commit sha 9d57c417fc1bac25b0274a34ae581c2e18a9d44e

rustc_codegen_llvm: create `DIFile`s from just `SourceFile`s.

view details

Eduard-Mihai Burtescu

commit sha fa2b381ec83556111a99750bcc7688521d7e8b0d

rustc_codegen_llvm: move DISubprogram creation to a dbg_scope_fn method.

view details

Eduard-Mihai Burtescu

commit sha 88d874de6395a5422caad1f61783dadd395d49d0

rustc_codegen_llvm: avoid converting between DILocation and Value.

view details

Eduard-Mihai Burtescu

commit sha 737499593db6d7702de3bf9d0070ec3f8e65d71e

rustc_codegen_llvm: expose DILocation to rustc_codegen_ssa.

view details

Eduard-Mihai Burtescu

commit sha 0ce4452fce0a1aa6d8a2a7f08da105c225463f4d

rustc_codegen_llvm: add support for inlined function debuginfo.

view details

Eduard-Mihai Burtescu

commit sha 9b21c50335887fe9ecbd44d5a3efa105feae0a6d

rustc_mir: create the Integrator as soon as possible in MIR inlining.

view details

Eduard-Mihai Burtescu

commit sha aff4d3e659872ec1fbf469e91575a9a711ce4705

rustc_mir: run the MIR inlining Integrator on the whole callee body at once.

view details

oli

commit sha f8aae504692295095454fa221c2ca1a7a46fb3c5

Prefer `bug!` over `unwrap()`

view details

oli

commit sha 7101ce9127d805e602ea3fa75d5bbea4bf1e5dce

Deduplicate span and dbg_scope adjustment

view details

oli

commit sha 7ae8bc3957fa78dbe99ec70ddbdc27a9be42e52d

Add an inlining debuginfo test

view details

oli

commit sha 2b3f00928c3b0db93c87d462a53c9f0df98f3e27

Ignore long lines in test

view details

bors

commit sha 0da6d42f297642a60f2640ec313b879b376b9ad8

Auto merge of #68965 - eddyb:mir-inline-scope, r=nagisa,oli-obk rustc_mir: track inlined callees in SourceScopeData. We now record which MIR scopes are the roots of *other* (inlined) functions's scope trees, which allows us to generate the correct debuginfo in codegen, similar to what LLVM inlining generates. This PR makes the `ui` test `backtrace-debuginfo` pass, if the MIR inliner is turned on by default. Also, `#[track_caller]` is now correct in the face of MIR inlining (cc `@anp).` Fixes #76997. r? `@rust-lang/wg-mir-opt`

view details

push time in 4 hours

pull request commentrust-lang/rust

rustc_mir: track inlined callees in SourceScopeData.

:sunny: Test successful - checks-actions Approved by: nagisa,oli-obk Pushing 0da6d42f297642a60f2640ec313b879b376b9ad8 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"nagisa,oli-obk","base_ref":"master","builders":{"checks-actions":"https://github.com/rust-lang-ci/rust/runs/1311343092"},"merge_sha":"0da6d42f297642a60f2640ec313b879b376b9ad8"} -->

eddyb

comment created time in 4 hours

pull request commentrust-lang/rust

Improve formatting of hash collections docs

:pushpin: Commit 59f108885ed38c7f7049a1830b7c50205989cb17 has been approved by jonas-schievink

<!-- @bors r=jonas-schievink 59f108885ed38c7f7049a1830b7c50205989cb17 --> <!-- homu: {"type":"Approved","sha":"59f108885ed38c7f7049a1830b7c50205989cb17","approver":"jonas-schievink"} -->

camelid

comment created time in 4 hours

pull request commentrust-lang/rust

Add compiler support for LLVM's x86_64 ERMSB feature

:pushpin: Commit ad552bc17e9e494e039f3db180d4e63be44fe889 has been approved by petrochenkov

<!-- @bors r=petrochenkov ad552bc17e9e494e039f3db180d4e63be44fe889 --> <!-- homu: {"type":"Approved","sha":"ad552bc17e9e494e039f3db180d4e63be44fe889","approver":"petrochenkov"} -->

josephlr

comment created time in 4 hours

pull request commentrust-lang/rust

Make CTFE able to check for UB...

:sunny: Try build successful - checks-actions Build commit: 3dbdd3b981f75f965ac04452739653a3d47ff0ed (3dbdd3b981f75f965ac04452739653a3d47ff0ed) <!-- homu: {"type":"TryBuildCompleted","builders":{"checks-actions":"https://github.com/rust-lang-ci/rust/runs/1310967232"},"merge_sha":"3dbdd3b981f75f965ac04452739653a3d47ff0ed"} -->

oli-obk

comment created time in 5 hours

pull request commentrust-lang/rust

Fix `x.py clippy`

:umbrella: The latest upstream changes (presumably #77975) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author
jyn514

comment created time in 6 hours

push eventrust-lang-ci/rust

bjorn3

commit sha 98dae86d214226b2d9bf400bae39f040f279821b

Update cranelift

view details

bjorn3

commit sha 7bf9b8e6e13bdead4217217e8f66cbf0eff414a5

Update gimli

view details

bjorn3

commit sha 80fc7b569ce01da361c160ce98686655fab4aa64

Use crates.io version of ar again

view details

bjorn3

commit sha 97747aa91a731b537251f327cd30924f4aa8d935

Update Cargo.lock

view details

bjorn3

commit sha bb7a990ee790b9063f1c4e0aa7911d618c3e4386

Extract driver.rs

view details

bjorn3

commit sha 2aeffa679a6c9a36459b5aa8d77277e80c17a30c

Rustup to rustc 1.36.0-nightly (cfdc84a00 2019-05-07)

view details

dependabot[bot]

commit sha 82d113cad41cee9ab0e797664b847f6f1791dc80

Bump syn from 0.15.33 to 0.15.34 Bumps [syn](https://github.com/dtolnay/syn) from 0.15.33 to 0.15.34. - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](https://github.com/dtolnay/syn/compare/0.15.33...0.15.34) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

dependabot[bot]

commit sha 6663c9f185de6dfc52942145160f58aa1a2e37bc

Bump serde from 1.0.90 to 1.0.91 Bumps [serde](https://github.com/serde-rs/serde) from 1.0.90 to 1.0.91. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](https://github.com/serde-rs/serde/compare/v1.0.90...v1.0.91) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

dependabot[bot]

commit sha 9c638ea8fa80c52cc4c20345e289cb3e595f2d91

Merge pull request #526 from bjorn3/dependabot/cargo/syn-0.15.34

view details

dependabot[bot]

commit sha 031d7284486814b50759e42978884c39e111c8f3

Merge pull request #525 from bjorn3/dependabot/cargo/serde-1.0.91

view details

dependabot[bot]

commit sha e998997f98e936bfa7445272df1aaa43448c736a

Bump proc-macro2 from 0.4.29 to 0.4.30 (#527) Bumps [proc-macro2](https://github.com/alexcrichton/proc-macro2) from 0.4.29 to 0.4.30. - [Release notes](https://github.com/alexcrichton/proc-macro2/releases) - [Commits](https://github.com/alexcrichton/proc-macro2/compare/0.4.29...0.4.30) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

bjorn3

commit sha 0046ce4c85d7db52923578a0d907597aa26b61e4

Partial support for wasm32-unknown-wasi as host triple This needs a rustc compiled for wasi (see rust-lang/miri#722) It also needs CraneStation/target-lexicon#14

view details

bjorn3

commit sha 5593bc8cd3ea06500879551b0acad373266d22af

Update cranelift

view details

bjorn3

commit sha 8ff6febdbf89d44e445be4094e97cc8b58b21a04

Update cranelift

view details

bjorn3

commit sha d078fde07a5e1b6892318e4d772b2ec490b3620f

Rustup to rustc 1.36.0-nightly (dec4c5201 2019-05-24)

view details

dependabot-preview[bot]

commit sha b408885f70bf97a84603f866690253a3505556c8

Bump cranelift from `dcce879` to `be02e94` Bumps [cranelift](https://github.com/CraneStation/cranelift) from `dcce879` to `be02e94`. - [Release notes](https://github.com/CraneStation/cranelift/releases) - [Commits](https://github.com/CraneStation/cranelift/compare/dcce8792b18888228759122356683215f802d6a7...be02e945613270d17a316a23a58e0791d5712cee) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha e914cb300e651f833b1e6b1b6e9a9efe066fccec

Merge pull request #566 from bjorn3/dependabot/cargo/cranelift-be02e94

view details

bjorn3

commit sha 5db3fcd1698f7d9c7593cd9d25b42a52210f0cee

Update Cargo.lock

view details

bjorn3

commit sha 610f377b7de358e6c3a7d57fe1a236347a48c833

Rustup to rustc 1.36.0-nightly (f49269398 2019-05-25)

view details

bjorn3

commit sha b625e56488798ccf843cb21b54c3ca8b1dbd969b

Rustup to rustc 1.37.0-nightly (3ade426ed 2019-05-30)

view details

push time in 6 hours

pull request commentrust-lang/rust

Make CTFE able to check for UB...

:hourglass: Trying commit 60e41550266833277bb4f3fb94ddf2b2f5fa2fd8 with merge 3dbdd3b981f75f965ac04452739653a3d47ff0ed... <!-- homu: {"type":"TryBuildStarted","head_sha":"60e41550266833277bb4f3fb94ddf2b2f5fa2fd8","merge_sha":"3dbdd3b981f75f965ac04452739653a3d47ff0ed"} -->

oli-obk

comment created time in 6 hours

pull request commentrust-lang/rust

cg_llvm: split dwarf support

:umbrella: The latest upstream changes (presumably #77975) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author
davidtwco

comment created time in 6 hours

push eventrust-lang/rust

bjorn3

commit sha d4ed46fa757d753b64cd45de2604878780d7189a

Merge pull request #495 from bjorn3/use_cg_clif_link Use cg clif link

view details

bjorn3

commit sha 421fe2e982bd6173a17aa850557f031d3e1dfd2c

Update cranelift

view details

bjorn3

commit sha 27ea27e2e3e77f82cc470dd695f54ececa16cb4b

Fix using using the same vtable twice

view details

bjorn3

commit sha f473ba8f87a8397e358a79f8ccae2d944f7bee95

Rustup to rustc 1.36.0-nightly (938d4ffe1 2019-04-27)

view details

dependabot[bot]

commit sha c33d127a59cffa64b9b9096cedd409df01f4f755

Bump cranelift from `4f69c32` to `c0ee30f` Bumps [cranelift](https://github.com/CraneStation/cranelift) from `4f69c32` to `c0ee30f`. - [Release notes](https://github.com/CraneStation/cranelift/releases) - [Commits](https://github.com/CraneStation/cranelift/compare/4f69c32572a13f4ded3b05542abf476d1cd2ead8...c0ee30f9a95bd80bd6485c21bad7e8e0b8c5caf0) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

dependabot[bot]

commit sha 8de77b90119bb8969b4608760c04f4b8161dcfe0

Merge pull request #511 from bjorn3/dependabot/cargo/cranelift-c0ee30f

view details

dependabot[bot]

commit sha 8fa92b8bb4d457408a1cceae5bcc1ab5f10b8341

Bump libc from 0.2.51 to 0.2.53 (#508) Bumps [libc](https://github.com/rust-lang/libc) from 0.2.51 to 0.2.53. - [Release notes](https://github.com/rust-lang/libc/releases) - [Commits](https://github.com/rust-lang/libc/compare/0.2.51...0.2.53) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

dependabot[bot]

commit sha bbd83ebf9d91789edba826171fd6a43b6d17aac7

Bump proc-macro2 from 0.4.27 to 0.4.29 (#507) Bumps [proc-macro2](https://github.com/alexcrichton/proc-macro2) from 0.4.27 to 0.4.29. - [Release notes](https://github.com/alexcrichton/proc-macro2/releases) - [Commits](https://github.com/alexcrichton/proc-macro2/compare/0.4.27...0.4.29) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

bjorn3

commit sha 8598a34e4514e90bf22eba00ec07c6cee5842df7

Rustup to rustc 1.36.0-nightly (a3404557c 2019-05-03)

view details

bjorn3

commit sha 98dae86d214226b2d9bf400bae39f040f279821b

Update cranelift

view details

bjorn3

commit sha 7bf9b8e6e13bdead4217217e8f66cbf0eff414a5

Update gimli

view details

bjorn3

commit sha 80fc7b569ce01da361c160ce98686655fab4aa64

Use crates.io version of ar again

view details

bjorn3

commit sha 97747aa91a731b537251f327cd30924f4aa8d935

Update Cargo.lock

view details

bjorn3

commit sha bb7a990ee790b9063f1c4e0aa7911d618c3e4386

Extract driver.rs

view details

bjorn3

commit sha 2aeffa679a6c9a36459b5aa8d77277e80c17a30c

Rustup to rustc 1.36.0-nightly (cfdc84a00 2019-05-07)

view details

dependabot[bot]

commit sha 82d113cad41cee9ab0e797664b847f6f1791dc80

Bump syn from 0.15.33 to 0.15.34 Bumps [syn](https://github.com/dtolnay/syn) from 0.15.33 to 0.15.34. - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](https://github.com/dtolnay/syn/compare/0.15.33...0.15.34) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

dependabot[bot]

commit sha 6663c9f185de6dfc52942145160f58aa1a2e37bc

Bump serde from 1.0.90 to 1.0.91 Bumps [serde](https://github.com/serde-rs/serde) from 1.0.90 to 1.0.91. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](https://github.com/serde-rs/serde/compare/v1.0.90...v1.0.91) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

dependabot[bot]

commit sha 9c638ea8fa80c52cc4c20345e289cb3e595f2d91

Merge pull request #526 from bjorn3/dependabot/cargo/syn-0.15.34

view details

dependabot[bot]

commit sha 031d7284486814b50759e42978884c39e111c8f3

Merge pull request #525 from bjorn3/dependabot/cargo/serde-1.0.91

view details

dependabot[bot]

commit sha e998997f98e936bfa7445272df1aaa43448c736a

Bump proc-macro2 from 0.4.29 to 0.4.30 (#527) Bumps [proc-macro2](https://github.com/alexcrichton/proc-macro2) from 0.4.29 to 0.4.30. - [Release notes](https://github.com/alexcrichton/proc-macro2/releases) - [Commits](https://github.com/alexcrichton/proc-macro2/compare/0.4.29...0.4.30) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

push time in 6 hours

push eventrust-lang-ci/rust

bjorn3

commit sha d4ed46fa757d753b64cd45de2604878780d7189a

Merge pull request #495 from bjorn3/use_cg_clif_link Use cg clif link

view details

bjorn3

commit sha 421fe2e982bd6173a17aa850557f031d3e1dfd2c

Update cranelift

view details

bjorn3

commit sha 27ea27e2e3e77f82cc470dd695f54ececa16cb4b

Fix using using the same vtable twice

view details

bjorn3

commit sha f473ba8f87a8397e358a79f8ccae2d944f7bee95

Rustup to rustc 1.36.0-nightly (938d4ffe1 2019-04-27)

view details

dependabot[bot]

commit sha c33d127a59cffa64b9b9096cedd409df01f4f755

Bump cranelift from `4f69c32` to `c0ee30f` Bumps [cranelift](https://github.com/CraneStation/cranelift) from `4f69c32` to `c0ee30f`. - [Release notes](https://github.com/CraneStation/cranelift/releases) - [Commits](https://github.com/CraneStation/cranelift/compare/4f69c32572a13f4ded3b05542abf476d1cd2ead8...c0ee30f9a95bd80bd6485c21bad7e8e0b8c5caf0) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

dependabot[bot]

commit sha 8de77b90119bb8969b4608760c04f4b8161dcfe0

Merge pull request #511 from bjorn3/dependabot/cargo/cranelift-c0ee30f

view details

dependabot[bot]

commit sha 8fa92b8bb4d457408a1cceae5bcc1ab5f10b8341

Bump libc from 0.2.51 to 0.2.53 (#508) Bumps [libc](https://github.com/rust-lang/libc) from 0.2.51 to 0.2.53. - [Release notes](https://github.com/rust-lang/libc/releases) - [Commits](https://github.com/rust-lang/libc/compare/0.2.51...0.2.53) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

dependabot[bot]

commit sha bbd83ebf9d91789edba826171fd6a43b6d17aac7

Bump proc-macro2 from 0.4.27 to 0.4.29 (#507) Bumps [proc-macro2](https://github.com/alexcrichton/proc-macro2) from 0.4.27 to 0.4.29. - [Release notes](https://github.com/alexcrichton/proc-macro2/releases) - [Commits](https://github.com/alexcrichton/proc-macro2/compare/0.4.27...0.4.29) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

bjorn3

commit sha 8598a34e4514e90bf22eba00ec07c6cee5842df7

Rustup to rustc 1.36.0-nightly (a3404557c 2019-05-03)

view details

bjorn3

commit sha 98dae86d214226b2d9bf400bae39f040f279821b

Update cranelift

view details

bjorn3

commit sha 7bf9b8e6e13bdead4217217e8f66cbf0eff414a5

Update gimli

view details

bjorn3

commit sha 80fc7b569ce01da361c160ce98686655fab4aa64

Use crates.io version of ar again

view details

bjorn3

commit sha 97747aa91a731b537251f327cd30924f4aa8d935

Update Cargo.lock

view details

bjorn3

commit sha bb7a990ee790b9063f1c4e0aa7911d618c3e4386

Extract driver.rs

view details

bjorn3

commit sha 2aeffa679a6c9a36459b5aa8d77277e80c17a30c

Rustup to rustc 1.36.0-nightly (cfdc84a00 2019-05-07)

view details

dependabot[bot]

commit sha 82d113cad41cee9ab0e797664b847f6f1791dc80

Bump syn from 0.15.33 to 0.15.34 Bumps [syn](https://github.com/dtolnay/syn) from 0.15.33 to 0.15.34. - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](https://github.com/dtolnay/syn/compare/0.15.33...0.15.34) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

dependabot[bot]

commit sha 6663c9f185de6dfc52942145160f58aa1a2e37bc

Bump serde from 1.0.90 to 1.0.91 Bumps [serde](https://github.com/serde-rs/serde) from 1.0.90 to 1.0.91. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](https://github.com/serde-rs/serde/compare/v1.0.90...v1.0.91) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

dependabot[bot]

commit sha 9c638ea8fa80c52cc4c20345e289cb3e595f2d91

Merge pull request #526 from bjorn3/dependabot/cargo/syn-0.15.34

view details

dependabot[bot]

commit sha 031d7284486814b50759e42978884c39e111c8f3

Merge pull request #525 from bjorn3/dependabot/cargo/serde-1.0.91

view details

dependabot[bot]

commit sha e998997f98e936bfa7445272df1aaa43448c736a

Bump proc-macro2 from 0.4.29 to 0.4.30 (#527) Bumps [proc-macro2](https://github.com/alexcrichton/proc-macro2) from 0.4.29 to 0.4.30. - [Release notes](https://github.com/alexcrichton/proc-macro2/releases) - [Commits](https://github.com/alexcrichton/proc-macro2/compare/0.4.29...0.4.30) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

push time in 6 hours

PR merged rust-lang/rust

Add cg_clif as optional codegen backend S-waiting-on-bors merged-by-bors

Rustc_codegen_cranelift is an alternative codegen backend for rustc based on Cranelift. It has the potential to improve compilation times in debug mode. In my experience the compile time improvements over debug mode LLVM for a clean build are about 20-30% in most cases.

This PR adds cg_clif as optional codegen backend. By default it is only enabled for ./x.py check. It can be enabled for ./x.py build too by adding cranelift to the rust.codegen-backends array in config.toml.

MCP: https://github.com/rust-lang/compiler-team/issues/270

r? @Mark-Simulacrum

+17049 -39

14 comments

98 changed files

bjorn3

pr closed time in 6 hours

push eventrust-lang-ci/rust

Eduard-Mihai Burtescu

commit sha 8c942c1511cc99fbc8f3e6ed56e5e3cfd8c0ff4a

rustc_mir: rename `location: SourceInfo` to `source_info`.

view details

Eduard-Mihai Burtescu

commit sha 708fc0b692b4ec7894986369214dc1f13ca33882

rustc_mir: use Instance more in the inliner.

view details

Eduard-Mihai Burtescu

commit sha 6bc5eafbce7dd3630a26b9f2e94938a4dfc61c06

rustc_mir: track inlined callees in SourceScopeData.

view details

Eduard-Mihai Burtescu

commit sha fb36440b7a0d2444dd079876d4fde6b0ee9d5670

test: ensure #[track_caller] tests also test MIR inlining.

view details

Eduard-Mihai Burtescu

commit sha 6451b39a25fbad9e991c6ea014a86217c52d3fd6

rustc_mir: support MIR-inlining #[track_caller] functions.

view details

Eduard-Mihai Burtescu

commit sha 387e31c9a7e6f7df3da513e2241a03e0b738ea4d

rustc_mir: properly map scope parent chains into the caller when inlining.

view details

Eduard-Mihai Burtescu

commit sha 2bfb462b58db63aaa0a43bacde39687928fe901e

rustc_mir: don't throw away inlined locals' spans.

view details

Eduard-Mihai Burtescu

commit sha 9d57c417fc1bac25b0274a34ae581c2e18a9d44e

rustc_codegen_llvm: create `DIFile`s from just `SourceFile`s.

view details

Eduard-Mihai Burtescu

commit sha fa2b381ec83556111a99750bcc7688521d7e8b0d

rustc_codegen_llvm: move DISubprogram creation to a dbg_scope_fn method.

view details

Eduard-Mihai Burtescu

commit sha 88d874de6395a5422caad1f61783dadd395d49d0

rustc_codegen_llvm: avoid converting between DILocation and Value.

view details

Eduard-Mihai Burtescu

commit sha 737499593db6d7702de3bf9d0070ec3f8e65d71e

rustc_codegen_llvm: expose DILocation to rustc_codegen_ssa.

view details

Eduard-Mihai Burtescu

commit sha 0ce4452fce0a1aa6d8a2a7f08da105c225463f4d

rustc_codegen_llvm: add support for inlined function debuginfo.

view details

Eduard-Mihai Burtescu

commit sha 9b21c50335887fe9ecbd44d5a3efa105feae0a6d

rustc_mir: create the Integrator as soon as possible in MIR inlining.

view details

Eduard-Mihai Burtescu

commit sha aff4d3e659872ec1fbf469e91575a9a711ce4705

rustc_mir: run the MIR inlining Integrator on the whole callee body at once.

view details

oli

commit sha f8aae504692295095454fa221c2ca1a7a46fb3c5

Prefer `bug!` over `unwrap()`

view details

oli

commit sha 7101ce9127d805e602ea3fa75d5bbea4bf1e5dce

Deduplicate span and dbg_scope adjustment

view details

oli

commit sha 7ae8bc3957fa78dbe99ec70ddbdc27a9be42e52d

Add an inlining debuginfo test

view details

oli

commit sha 2b3f00928c3b0db93c87d462a53c9f0df98f3e27

Ignore long lines in test

view details

bors

commit sha 0da6d42f297642a60f2640ec313b879b376b9ad8

Auto merge of #68965 - eddyb:mir-inline-scope, r=nagisa,oli-obk rustc_mir: track inlined callees in SourceScopeData. We now record which MIR scopes are the roots of *other* (inlined) functions's scope trees, which allows us to generate the correct debuginfo in codegen, similar to what LLVM inlining generates. This PR makes the `ui` test `backtrace-debuginfo` pass, if the MIR inliner is turned on by default. Also, `#[track_caller]` is now correct in the face of MIR inlining (cc `@anp).` Fixes #76997. r? `@rust-lang/wg-mir-opt`

view details

push time in 6 hours

pull request commentrust-lang/rust

rustc_mir: track inlined callees in SourceScopeData.

:hourglass: Testing commit 2b3f00928c3b0db93c87d462a53c9f0df98f3e27 with merge 0da6d42f297642a60f2640ec313b879b376b9ad8... <!-- homu: {"type":"BuildStarted","head_sha":"2b3f00928c3b0db93c87d462a53c9f0df98f3e27","merge_sha":"0da6d42f297642a60f2640ec313b879b376b9ad8"} -->

eddyb

comment created time in 6 hours

pull request commentrust-lang/rust

Add cg_clif as optional codegen backend

:sunny: Test successful - checks-actions Approved by: Mark-Simulacrum Pushing 35debd4c111610317346f46d791f32551d449bd8 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"Mark-Simulacrum","base_ref":"master","builders":{"checks-actions":"https://github.com/rust-lang-ci/rust/runs/1310705076"},"merge_sha":"35debd4c111610317346f46d791f32551d449bd8"} -->

bjorn3

comment created time in 6 hours

pull request commentrust-lang/rust

Fix typo in lint description

:pushpin: Commit 74a98912354324e985b087923bf0448e98f309d4 has been approved by lcnr

<!-- @bors r=lcnr 74a98912354324e985b087923bf0448e98f309d4 --> <!-- homu: {"type":"Approved","sha":"74a98912354324e985b087923bf0448e98f309d4","approver":"lcnr"} -->

notriddle

comment created time in 6 hours

pull request commentrust-lang/stdarch

Add shift-and-insert Arm intrinsics.

:umbrella: The latest upstream changes (presumably dd981c00dca35127a4307046d025ab2259d492b9) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author
AdamHillier

comment created time in 7 hours

pull request commentrust-lang/rust

Prefer to use `print_def_path`

:pushpin: Commit 6fdd53b7de6bbc6d8739774bd74febc31ac08e3f has been approved by estebank

<!-- @bors r=estebank 6fdd53b7de6bbc6d8739774bd74febc31ac08e3f --> <!-- homu: {"type":"Approved","sha":"6fdd53b7de6bbc6d8739774bd74febc31ac08e3f","approver":"estebank"} -->

JohnTitor

comment created time in 7 hours

pull request commentrust-lang/rust

resolve: private fields in tuple struct ctor diag

:pushpin: Commit 27bb27f71c2e99ef23c6dc70c3f43998b0c69486 has been approved by estebank

<!-- @bors r=estebank 27bb27f71c2e99ef23c6dc70c3f43998b0c69486 --> <!-- homu: {"type":"Approved","sha":"27bb27f71c2e99ef23c6dc70c3f43998b0c69486","approver":"estebank"} -->

davidtwco

comment created time in 8 hours

pull request commentrust-lang/rust

TypeFoldable: take self by value

:sunny: Try build successful - checks-actions Build commit: 278109bc25e7ecaa3bdff46a33f00adac710f4d2 (278109bc25e7ecaa3bdff46a33f00adac710f4d2) <!-- homu: {"type":"TryBuildCompleted","builders":{"checks-actions":"https://github.com/rust-lang-ci/rust/runs/1310149651"},"merge_sha":"278109bc25e7ecaa3bdff46a33f00adac710f4d2"} -->

lcnr

comment created time in 8 hours

push eventrust-lang-ci/rust

bjorn3

commit sha d4ed46fa757d753b64cd45de2604878780d7189a

Merge pull request #495 from bjorn3/use_cg_clif_link Use cg clif link

view details

bjorn3

commit sha 421fe2e982bd6173a17aa850557f031d3e1dfd2c

Update cranelift

view details

bjorn3

commit sha 27ea27e2e3e77f82cc470dd695f54ececa16cb4b

Fix using using the same vtable twice

view details

bjorn3

commit sha f473ba8f87a8397e358a79f8ccae2d944f7bee95

Rustup to rustc 1.36.0-nightly (938d4ffe1 2019-04-27)

view details

dependabot[bot]

commit sha c33d127a59cffa64b9b9096cedd409df01f4f755

Bump cranelift from `4f69c32` to `c0ee30f` Bumps [cranelift](https://github.com/CraneStation/cranelift) from `4f69c32` to `c0ee30f`. - [Release notes](https://github.com/CraneStation/cranelift/releases) - [Commits](https://github.com/CraneStation/cranelift/compare/4f69c32572a13f4ded3b05542abf476d1cd2ead8...c0ee30f9a95bd80bd6485c21bad7e8e0b8c5caf0) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

dependabot[bot]

commit sha 8de77b90119bb8969b4608760c04f4b8161dcfe0

Merge pull request #511 from bjorn3/dependabot/cargo/cranelift-c0ee30f

view details

dependabot[bot]

commit sha 8fa92b8bb4d457408a1cceae5bcc1ab5f10b8341

Bump libc from 0.2.51 to 0.2.53 (#508) Bumps [libc](https://github.com/rust-lang/libc) from 0.2.51 to 0.2.53. - [Release notes](https://github.com/rust-lang/libc/releases) - [Commits](https://github.com/rust-lang/libc/compare/0.2.51...0.2.53) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

dependabot[bot]

commit sha bbd83ebf9d91789edba826171fd6a43b6d17aac7

Bump proc-macro2 from 0.4.27 to 0.4.29 (#507) Bumps [proc-macro2](https://github.com/alexcrichton/proc-macro2) from 0.4.27 to 0.4.29. - [Release notes](https://github.com/alexcrichton/proc-macro2/releases) - [Commits](https://github.com/alexcrichton/proc-macro2/compare/0.4.27...0.4.29) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

bjorn3

commit sha 8598a34e4514e90bf22eba00ec07c6cee5842df7

Rustup to rustc 1.36.0-nightly (a3404557c 2019-05-03)

view details

bjorn3

commit sha 98dae86d214226b2d9bf400bae39f040f279821b

Update cranelift

view details

bjorn3

commit sha 7bf9b8e6e13bdead4217217e8f66cbf0eff414a5

Update gimli

view details

bjorn3

commit sha 80fc7b569ce01da361c160ce98686655fab4aa64

Use crates.io version of ar again

view details

bjorn3

commit sha 97747aa91a731b537251f327cd30924f4aa8d935

Update Cargo.lock

view details

bjorn3

commit sha bb7a990ee790b9063f1c4e0aa7911d618c3e4386

Extract driver.rs

view details

bjorn3

commit sha 2aeffa679a6c9a36459b5aa8d77277e80c17a30c

Rustup to rustc 1.36.0-nightly (cfdc84a00 2019-05-07)

view details

dependabot[bot]

commit sha 82d113cad41cee9ab0e797664b847f6f1791dc80

Bump syn from 0.15.33 to 0.15.34 Bumps [syn](https://github.com/dtolnay/syn) from 0.15.33 to 0.15.34. - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](https://github.com/dtolnay/syn/compare/0.15.33...0.15.34) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

dependabot[bot]

commit sha 6663c9f185de6dfc52942145160f58aa1a2e37bc

Bump serde from 1.0.90 to 1.0.91 Bumps [serde](https://github.com/serde-rs/serde) from 1.0.90 to 1.0.91. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](https://github.com/serde-rs/serde/compare/v1.0.90...v1.0.91) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

dependabot[bot]

commit sha 9c638ea8fa80c52cc4c20345e289cb3e595f2d91

Merge pull request #526 from bjorn3/dependabot/cargo/syn-0.15.34

view details

dependabot[bot]

commit sha 031d7284486814b50759e42978884c39e111c8f3

Merge pull request #525 from bjorn3/dependabot/cargo/serde-1.0.91

view details

dependabot[bot]

commit sha e998997f98e936bfa7445272df1aaa43448c736a

Bump proc-macro2 from 0.4.29 to 0.4.30 (#527) Bumps [proc-macro2](https://github.com/alexcrichton/proc-macro2) from 0.4.29 to 0.4.30. - [Release notes](https://github.com/alexcrichton/proc-macro2/releases) - [Commits](https://github.com/alexcrichton/proc-macro2/compare/0.4.29...0.4.30) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

push time in 9 hours

pull request commentrust-lang/rust

Add cg_clif as optional codegen backend

:hourglass: Testing commit ac4f7deb2f3558d2d923fa6ddcbb7210db9c2d52 with merge 35debd4c111610317346f46d791f32551d449bd8... <!-- homu: {"type":"BuildStarted","head_sha":"ac4f7deb2f3558d2d923fa6ddcbb7210db9c2d52","merge_sha":"35debd4c111610317346f46d791f32551d449bd8"} -->

bjorn3

comment created time in 9 hours

PR merged rust-lang/rust

update Miri S-waiting-on-bors merged-by-bors

Fixes https://github.com/rust-lang/rust/issues/78339 Cc @rust-lang/miri r? @ghost

+1 -1

5 comments

1 changed file

RalfJung

pr closed time in 9 hours

push eventrust-lang/rust

Ralf Jung

commit sha 357333320819a6eed427669b4d583c6fdfeeaedd

update Miri

view details

bors

commit sha c96e11c781af319199af77347d55f08085e15453

Auto merge of #78395 - RalfJung:miri, r=RalfJung update Miri Fixes https://github.com/rust-lang/rust/issues/78339 Cc `@rust-lang/miri` r? `@ghost`

view details

push time in 9 hours

issue closedrust-lang/rust

`miri` no longer builds after rust-lang/rust#78334

Hello, this is your friendly neighborhood mergebot. After merging PR rust-lang/rust#78334, I observed that the tool miri has failing tests. A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @jonas-schievink, do you think you would have time to do the follow-up work? If so, that would be great!

closed time in 9 hours

rust-highfive

push eventrust-lang-ci/rust

Ralf Jung

commit sha 357333320819a6eed427669b4d583c6fdfeeaedd

update Miri

view details

bors

commit sha c96e11c781af319199af77347d55f08085e15453

Auto merge of #78395 - RalfJung:miri, r=RalfJung update Miri Fixes https://github.com/rust-lang/rust/issues/78339 Cc `@rust-lang/miri` r? `@ghost`

view details

push time in 9 hours

pull request commentrust-lang/rust

Add cg_clif as optional codegen backend

:pushpin: Commit ac4f7deb2f3558d2d923fa6ddcbb7210db9c2d52 has been approved by Mark-Simulacrum

<!-- @bors r=Mark-Simulacrum ac4f7deb2f3558d2d923fa6ddcbb7210db9c2d52 --> <!-- homu: {"type":"Approved","sha":"ac4f7deb2f3558d2d923fa6ddcbb7210db9c2d52","approver":"Mark-Simulacrum"} -->

bjorn3

comment created time in 9 hours

PR merged rust-lang/crates.io

Update dependency fastboot-app-server to v3 S-waiting-on-review

This PR contains the following updates:

Package Type Update Change
fastboot-app-server dependencies major 2.0.0 -> 3.0.0

Release Notes

<details> <summary>ember-fastboot/fastboot-app-server</summary>

v3.0.0

Compare Source

:boom: Breaking Change
:rocket: Enhancement
:memo: Documentation
:house: Internal
Committers: 8
1.1.2-beta.1
  • Bump fastboot version to allow opting into rehydration.
1.1.0
  • README updates
  • Bumping version of base-auth to 2.0.0
  • Bumping version of fastboot and fastboot-express-middleware to 1.1.0

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+50 -69

5 comments

2 changed files

renovate[bot]

pr closed time in 9 hours

push eventrust-lang/crates.io

Renovate Bot

commit sha c58dbbdeb5a22037ce0db28831f7a389ed58fc93

Update dependency fastboot-app-server to v3

view details

bors

commit sha edf594c5827facae8f084c6b517447bdde1e9018

Auto merge of #2964 - rust-lang:renovate/fastboot-app-server-3.x, r=Turbo87 Update dependency fastboot-app-server to v3 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [fastboot-app-server](https://togithub.com/ember-fastboot/fastboot-app-server) | dependencies | major | [`2.0.0` -> `3.0.0`](https://renovatebot.com/diffs/npm/fastboot-app-server/2.0.0/3.0.0) | --- ### Release Notes <details> <summary>ember-fastboot/fastboot-app-server</summary> ### [`v3.0.0`](https://togithub.com/ember-fastboot/fastboot-app-server/blob/master/CHANGELOG.md#v300-2020-10-26) [Compare Source](https://togithub.com/ember-fastboot/fastboot-app-server/compare/v2.0.0...v3.0.0) ##### :boom: Breaking Change - [#&#8203;124](https://togithub.com/ember-fastboot/fastboot-app-server/pull/124) Update FastBoot v3 ([`@&#8203;bobisjan](https://togithub.com/bobisjan))` - [#&#8203;123](https://togithub.com/ember-fastboot/fastboot-app-server/pull/123) Drop Node 8 and 13 support ([`@&#8203;bobisjan](https://togithub.com/bobisjan))` ##### :rocket: Enhancement - [#&#8203;120](https://togithub.com/ember-fastboot/fastboot-app-server/pull/120) Remove legacy Node.js support leftovers ([`@&#8203;bobisjan](https://togithub.com/bobisjan))` - [#&#8203;96](https://togithub.com/ember-fastboot/fastboot-app-server/pull/96) Expose `distPath` on `reload` event ([`@&#8203;nathanhammond](https://togithub.com/nathanhammond))` ##### :memo: Documentation - [#&#8203;49](https://togithub.com/ember-fastboot/fastboot-app-server/pull/49) Avoid `server.js` naming conflict ([`@&#8203;oskarrough](https://togithub.com/oskarrough))` - [#&#8203;79](https://togithub.com/ember-fastboot/fastboot-app-server/pull/79) Adds notes to readme about overriding the workerCount ([`@&#8203;Duder-onomy](https://togithub.com/Duder-onomy))` - [#&#8203;106](https://togithub.com/ember-fastboot/fastboot-app-server/pull/106) Add link to s3-notifier ([`@&#8203;allthesignals](https://togithub.com/allthesignals))` - [#&#8203;115](https://togithub.com/ember-fastboot/fastboot-app-server/pull/115) Add link to fastboot-gcloud-storage-notifier in README ([`@&#8203;YoranBrondsema](https://togithub.com/YoranBrondsema))` - [#&#8203;114](https://togithub.com/ember-fastboot/fastboot-app-server/pull/114) Add link to fastboot-gcloud-storage-downloader in README ([`@&#8203;YoranBrondsema](https://togithub.com/YoranBrondsema))` - [#&#8203;122](https://togithub.com/ember-fastboot/fastboot-app-server/pull/122) Update README.md ([`@&#8203;wagenet](https://togithub.com/wagenet))` ##### :house: Internal - [#&#8203;128](https://togithub.com/ember-fastboot/fastboot-app-server/pull/128) Update linting setup ([`@&#8203;rwjblue](https://togithub.com/rwjblue))` - [#&#8203;129](https://togithub.com/ember-fastboot/fastboot-app-server/pull/129) Update mocha to latest. ([`@&#8203;rwjblue](https://togithub.com/rwjblue))` - [#&#8203;127](https://togithub.com/ember-fastboot/fastboot-app-server/pull/127) Update dependencies to latest. ([`@&#8203;rwjblue](https://togithub.com/rwjblue))` - [#&#8203;126](https://togithub.com/ember-fastboot/fastboot-app-server/pull/126) Migrate to GitHub Actions. ([`@&#8203;rwjblue](https://togithub.com/rwjblue))` - [#&#8203;125](https://togithub.com/ember-fastboot/fastboot-app-server/pull/125) Add release automation. ([`@&#8203;rwjblue](https://togithub.com/rwjblue))` - [#&#8203;121](https://togithub.com/ember-fastboot/fastboot-app-server/pull/121) Migrate to ESLint ([`@&#8203;bobisjan](https://togithub.com/bobisjan))` ##### Committers: 8 - Greg Larrenaga ([`@&#8203;Duder-onomy](https://togithub.com/Duder-onomy))` - Jan Bobisud ([`@&#8203;bobisjan](https://togithub.com/bobisjan))` - Matt Gardner ([`@&#8203;allthesignals](https://togithub.com/allthesignals))` - Nathan Hammond ([`@&#8203;nathanhammond](https://togithub.com/nathanhammond))` - Oskar ([`@&#8203;oskarrough](https://togithub.com/oskarrough))` - Peter Wagenet ([`@&#8203;wagenet](https://togithub.com/wagenet))` - Robert Jackson ([`@&#8203;rwjblue](https://togithub.com/rwjblue))` - Yoran Brondsema ([`@&#8203;YoranBrondsema](https://togithub.com/YoranBrondsema))` ##### 1.1.2-beta.1 - Bump fastboot version to allow opting into rehydration. ##### 1.1.0 - README updates - Bumping version of `base-auth` to 2.0.0 - Bumping version of `fastboot` and `fastboot-express-middleware` to 1.1.0 </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/rust-lang/crates.io).

view details

push time in 9 hours

pull request commentrust-lang/crates.io

Update dependency fastboot-app-server to v3

:sunny: Test successful - checks-travis Approved by: Turbo87 Pushing edf594c5827facae8f084c6b517447bdde1e9018 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"Turbo87","base_ref":"master","builders":{"checks-travis":"https://travis-ci.com/github/rust-lang/crates.io/builds/192838032"},"merge_sha":"edf594c5827facae8f084c6b517447bdde1e9018"} -->

renovate[bot]

comment created time in 9 hours

push eventrust-lang-ci/rust

Bastian Kauschke

commit sha c105925d21dda7a904cf14e70d099be88585d74b

add IdFunctor to rustc_data_structures

view details

Bastian Kauschke

commit sha a43d5aa463894c1c96829e136f2f8ff4423ea844

compiler: fold by value

view details

Bastian Kauschke

commit sha ba0ac55ceb508f7ddf48e92339363809d411339c

clippy: fold by value

view details

Bastian Kauschke

commit sha f54fff8c857e065780d6607a9c29ee114485430f

stop dropping your tea everywhere

view details

lcnr

commit sha c25850e0de9afd69acb9d5fb664e1c4a1ff32b52

words

view details

Bastian Kauschke

commit sha 3145b29b7a8f6108589c72eb742347984cc400ee

manually impl map_id for Vec<T>

view details

Bastian Kauschke

commit sha 5e6d39baf57184ea0ca694e92b63852f38d7f0ec

cleanup

view details

Bastian Kauschke

commit sha 4acbefd3acd6bb29a454c9da7560ddb9f6c4ae93

rename type foldable macro

view details

Bastian Kauschke

commit sha d80bba06976dcd8c45e8fa199b8fd7380cc0fd4b

remove clones in `Terminator` fold impl

view details

Bastian Kauschke

commit sha 25c293e71a66b2b0d0911a89fb6a0b2ace2ceb79

cleanup

view details

Bastian Kauschke

commit sha 35ac70e8b8d37254e6fb90615d7a83aad0a8dfe2

further cleanup

view details

Bastian Kauschke

commit sha bf23af2e1971e6b8c9573dccf17d4947490f55c3

remove clone

view details

bors

commit sha 278109bc25e7ecaa3bdff46a33f00adac710f4d2

Auto merge of #78313 - lcnr:somebody-fold-me, r=<try> TypeFoldable: take self by value Implements https://github.com/rust-lang/compiler-team/issues/371 which is currently still in FCP. r? `@nikomatsakis`

view details

push time in 9 hours

pull request commentrust-lang/rust

TypeFoldable: take self by value

:hourglass: Trying commit bf23af2e1971e6b8c9573dccf17d4947490f55c3 with merge 278109bc25e7ecaa3bdff46a33f00adac710f4d2... <!-- homu: {"type":"TryBuildStarted","head_sha":"bf23af2e1971e6b8c9573dccf17d4947490f55c3","merge_sha":"278109bc25e7ecaa3bdff46a33f00adac710f4d2"} -->

lcnr

comment created time in 9 hours

pull request commentrust-lang/rust

BTreeMap: move generic support functions out of navigate.rs

:pushpin: Commit 0da7941e1c820021b14146fd48b818c82db9b0e4 has been approved by Mark-Simulacrum

<!-- @bors r=Mark-Simulacrum 0da7941e1c820021b14146fd48b818c82db9b0e4 --> <!-- homu: {"type":"Approved","sha":"0da7941e1c820021b14146fd48b818c82db9b0e4","approver":"Mark-Simulacrum"} -->

ssomers

comment created time in 9 hours

pull request commentrust-lang/crates.io

Update dependency fastboot-app-server to v3

:hourglass: Testing commit c58dbbdeb5a22037ce0db28831f7a389ed58fc93 with merge edf594c5827facae8f084c6b517447bdde1e9018... <!-- homu: {"type":"BuildStarted","head_sha":"c58dbbdeb5a22037ce0db28831f7a389ed58fc93","merge_sha":"edf594c5827facae8f084c6b517447bdde1e9018"} -->

renovate[bot]

comment created time in 9 hours

push eventrust-lang/crates.io

Renovate Bot

commit sha c58dbbdeb5a22037ce0db28831f7a389ed58fc93

Update dependency fastboot-app-server to v3

view details

bors

commit sha edf594c5827facae8f084c6b517447bdde1e9018

Auto merge of #2964 - rust-lang:renovate/fastboot-app-server-3.x, r=Turbo87 Update dependency fastboot-app-server to v3 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [fastboot-app-server](https://togithub.com/ember-fastboot/fastboot-app-server) | dependencies | major | [`2.0.0` -> `3.0.0`](https://renovatebot.com/diffs/npm/fastboot-app-server/2.0.0/3.0.0) | --- ### Release Notes <details> <summary>ember-fastboot/fastboot-app-server</summary> ### [`v3.0.0`](https://togithub.com/ember-fastboot/fastboot-app-server/blob/master/CHANGELOG.md#v300-2020-10-26) [Compare Source](https://togithub.com/ember-fastboot/fastboot-app-server/compare/v2.0.0...v3.0.0) ##### :boom: Breaking Change - [#&#8203;124](https://togithub.com/ember-fastboot/fastboot-app-server/pull/124) Update FastBoot v3 ([`@&#8203;bobisjan](https://togithub.com/bobisjan))` - [#&#8203;123](https://togithub.com/ember-fastboot/fastboot-app-server/pull/123) Drop Node 8 and 13 support ([`@&#8203;bobisjan](https://togithub.com/bobisjan))` ##### :rocket: Enhancement - [#&#8203;120](https://togithub.com/ember-fastboot/fastboot-app-server/pull/120) Remove legacy Node.js support leftovers ([`@&#8203;bobisjan](https://togithub.com/bobisjan))` - [#&#8203;96](https://togithub.com/ember-fastboot/fastboot-app-server/pull/96) Expose `distPath` on `reload` event ([`@&#8203;nathanhammond](https://togithub.com/nathanhammond))` ##### :memo: Documentation - [#&#8203;49](https://togithub.com/ember-fastboot/fastboot-app-server/pull/49) Avoid `server.js` naming conflict ([`@&#8203;oskarrough](https://togithub.com/oskarrough))` - [#&#8203;79](https://togithub.com/ember-fastboot/fastboot-app-server/pull/79) Adds notes to readme about overriding the workerCount ([`@&#8203;Duder-onomy](https://togithub.com/Duder-onomy))` - [#&#8203;106](https://togithub.com/ember-fastboot/fastboot-app-server/pull/106) Add link to s3-notifier ([`@&#8203;allthesignals](https://togithub.com/allthesignals))` - [#&#8203;115](https://togithub.com/ember-fastboot/fastboot-app-server/pull/115) Add link to fastboot-gcloud-storage-notifier in README ([`@&#8203;YoranBrondsema](https://togithub.com/YoranBrondsema))` - [#&#8203;114](https://togithub.com/ember-fastboot/fastboot-app-server/pull/114) Add link to fastboot-gcloud-storage-downloader in README ([`@&#8203;YoranBrondsema](https://togithub.com/YoranBrondsema))` - [#&#8203;122](https://togithub.com/ember-fastboot/fastboot-app-server/pull/122) Update README.md ([`@&#8203;wagenet](https://togithub.com/wagenet))` ##### :house: Internal - [#&#8203;128](https://togithub.com/ember-fastboot/fastboot-app-server/pull/128) Update linting setup ([`@&#8203;rwjblue](https://togithub.com/rwjblue))` - [#&#8203;129](https://togithub.com/ember-fastboot/fastboot-app-server/pull/129) Update mocha to latest. ([`@&#8203;rwjblue](https://togithub.com/rwjblue))` - [#&#8203;127](https://togithub.com/ember-fastboot/fastboot-app-server/pull/127) Update dependencies to latest. ([`@&#8203;rwjblue](https://togithub.com/rwjblue))` - [#&#8203;126](https://togithub.com/ember-fastboot/fastboot-app-server/pull/126) Migrate to GitHub Actions. ([`@&#8203;rwjblue](https://togithub.com/rwjblue))` - [#&#8203;125](https://togithub.com/ember-fastboot/fastboot-app-server/pull/125) Add release automation. ([`@&#8203;rwjblue](https://togithub.com/rwjblue))` - [#&#8203;121](https://togithub.com/ember-fastboot/fastboot-app-server/pull/121) Migrate to ESLint ([`@&#8203;bobisjan](https://togithub.com/bobisjan))` ##### Committers: 8 - Greg Larrenaga ([`@&#8203;Duder-onomy](https://togithub.com/Duder-onomy))` - Jan Bobisud ([`@&#8203;bobisjan](https://togithub.com/bobisjan))` - Matt Gardner ([`@&#8203;allthesignals](https://togithub.com/allthesignals))` - Nathan Hammond ([`@&#8203;nathanhammond](https://togithub.com/nathanhammond))` - Oskar ([`@&#8203;oskarrough](https://togithub.com/oskarrough))` - Peter Wagenet ([`@&#8203;wagenet](https://togithub.com/wagenet))` - Robert Jackson ([`@&#8203;rwjblue](https://togithub.com/rwjblue))` - Yoran Brondsema ([`@&#8203;YoranBrondsema](https://togithub.com/YoranBrondsema))` ##### 1.1.2-beta.1 - Bump fastboot version to allow opting into rehydration. ##### 1.1.0 - README updates - Bumping version of `base-auth` to 2.0.0 - Bumping version of `fastboot` and `fastboot-express-middleware` to 1.1.0 </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/rust-lang/crates.io).

view details

push time in 9 hours

pull request commentrust-lang/crates.io

Update dependency fastboot-app-server to v3

:pushpin: Commit c58dbbdeb5a22037ce0db28831f7a389ed58fc93 has been approved by Turbo87

<!-- @bors r=Turbo87 c58dbbdeb5a22037ce0db28831f7a389ed58fc93 --> <!-- homu: {"type":"Approved","sha":"c58dbbdeb5a22037ce0db28831f7a389ed58fc93","approver":"Turbo87"} -->

renovate[bot]

comment created time in 9 hours

pull request commentrust-lang/rust

[do not merge] get build artifact for freebsd

:sunny: Try build successful - checks-actions Build commit: 688c68b99d9ece86c9b2389ccaff13c442bcae2e (688c68b99d9ece86c9b2389ccaff13c442bcae2e) <!-- homu: {"type":"TryBuildCompleted","builders":{"checks-actions":"https://github.com/rust-lang-ci/rust/runs/1309787497"},"merge_sha":"688c68b99d9ece86c9b2389ccaff13c442bcae2e"} -->

lzutao

comment created time in 9 hours

pull request commentrust-lang/rust

perf: Only process changed obligations in ObligationForest

:sunny: Try build successful - checks-actions Build commit: 30a3e111a6443337457980ccf94a22d0b8c9d02e (30a3e111a6443337457980ccf94a22d0b8c9d02e) <!-- homu: {"type":"TryBuildCompleted","builders":{"checks-actions":"https://github.com/rust-lang-ci/rust/runs/1309675356"},"merge_sha":"30a3e111a6443337457980ccf94a22d0b8c9d02e"} -->

Marwes

comment created time in 10 hours

pull request commentrust-lang/rust

Add some regression tests

:pushpin: Commit 25dbbbd4a060bd8fce07f8a6ed03d30c82266ff3 has been approved by Mark-Simulacrum

<!-- @bors r=Mark-Simulacrum 25dbbbd4a060bd8fce07f8a6ed03d30c82266ff3 --> <!-- homu: {"type":"Approved","sha":"25dbbbd4a060bd8fce07f8a6ed03d30c82266ff3","approver":"Mark-Simulacrum"} -->

camelid

comment created time in 10 hours

pull request commentrust-lang/rust

Add lexicographical comparison doc

:pushpin: Commit 42844ed2cf4ca0ff2a9271e0aaa8e5910c5f4ccd has been approved by kennytm

<!-- @bors r=kennytm 42844ed2cf4ca0ff2a9271e0aaa8e5910c5f4ccd --> <!-- homu: {"type":"Approved","sha":"42844ed2cf4ca0ff2a9271e0aaa8e5910c5f4ccd","approver":"kennytm"} -->

Rustin-Liu

comment created time in 10 hours

PR merged rust-lang/crates.io

services/session: Add user ids to Sentry context A-frontend S-waiting-on-review

This will make it easier to associate backend errors with frontend errors on Sentry.

r? @pietroalbini

+5 -0

4 comments

1 changed file

Turbo87

pr closed time in 10 hours

push eventrust-lang/crates.io

Tobias Bieniek

commit sha 9a1deb2cdda1ebe46cd5f4cd589cc1e66fbdf90d

services/session: Add user ids to Sentry context

view details

bors

commit sha 99a4c5b44971017c00daf7096ef6d43959efd4db

Auto merge of #2963 - Turbo87:sentry-user, r=pietroalbini services/session: Add user ids to Sentry context This will make it easier to associate backend errors with frontend errors on Sentry. r? `@pietroalbini`

view details

push time in 10 hours

pull request commentrust-lang/crates.io

services/session: Add user ids to Sentry context

:sunny: Test successful - checks-travis Approved by: pietroalbini Pushing 99a4c5b44971017c00daf7096ef6d43959efd4db to master... <!-- homu: {"type":"BuildCompleted","approved_by":"pietroalbini","base_ref":"master","builders":{"checks-travis":"https://travis-ci.com/github/rust-lang/crates.io/builds/192818296"},"merge_sha":"99a4c5b44971017c00daf7096ef6d43959efd4db"} -->

Turbo87

comment created time in 10 hours

pull request commentrust-lang/rust

add system-llvm-libunwind config option

:pushpin: Commit 66fa42a94627dc04de6d44227c5d06fec6b26d76 has been approved by Mark-Simulacrum

<!-- @bors r=Mark-Simulacrum 66fa42a94627dc04de6d44227c5d06fec6b26d76 --> <!-- homu: {"type":"Approved","sha":"66fa42a94627dc04de6d44227c5d06fec6b26d76","approver":"Mark-Simulacrum"} -->

Keruspe

comment created time in 10 hours

push eventrust-lang-ci/rust

Lzu Tao

commit sha 59c636c7d5070487e137b2f7cd128c30935b7fe0

Update backtrace for bsd

view details

Lzu Tao

commit sha 81d50b6803d35612c504acc8da1385a2d8c106b6

[dnm] add freebsd to pr and try builds

view details

Lzu Tao

commit sha 0d1b28ad859c08fd7299bc36f613adad05cf7290

allow my fork

view details

Lzu Tao

commit sha 185a5312126ba03d729e3bc3a9cfb78f73235473

libc

view details

Lzu Tao

commit sha 53d3f4e8545f3445b4866922c6f9890868ba4172

up bt

view details

Lzu Tao

commit sha 762f58cbdfd0c6c501559b344282e095bbfa1a42

fixup! libc

view details

Lzu Tao

commit sha 5f08588e9d1c47c6096ab0364903636bbd334349

one libc

view details

Lzu Tao

commit sha 8b1c607f73807647af6111c58021ce7b8ccf78c8

fixup! one libc

view details

Lzu Tao

commit sha cd7644eb83a6e1f8728cec2044ace4284d384d9b

libc

view details

Lzu Tao

commit sha 7cd92aa7fd3b57894690ca46fb479fa717a55cfc

unsound

view details

bors

commit sha 688c68b99d9ece86c9b2389ccaff13c442bcae2e

Auto merge of #78357 - lzutao:backtrace-bsd, r=<try> [do not merge] get build artifact for freebsd This PR updates backtrace-rs submodule to get the artifact for testing. cc #78184 .

view details

push time in 10 hours

pull request commentrust-lang/rust

[do not merge] get build artifact for freebsd

:hourglass: Trying commit 7cd92aa7fd3b57894690ca46fb479fa717a55cfc with merge 688c68b99d9ece86c9b2389ccaff13c442bcae2e... <!-- homu: {"type":"TryBuildStarted","head_sha":"7cd92aa7fd3b57894690ca46fb479fa717a55cfc","merge_sha":"688c68b99d9ece86c9b2389ccaff13c442bcae2e"} -->

lzutao

comment created time in 10 hours

pull request commentrust-lang/rust

Suggest calling await on method call and field access

:pushpin: Commit 28f02fbf3e26738047135a577622a313a1c3bfb3 has been approved by oli-obk

<!-- @bors r=oli-obk 28f02fbf3e26738047135a577622a313a1c3bfb3 --> <!-- homu: {"type":"Approved","sha":"28f02fbf3e26738047135a577622a313a1c3bfb3","approver":"oli-obk"} -->

estebank

comment created time in 10 hours

pull request commentrust-lang/crates.io

services/session: Add user ids to Sentry context

:hourglass: Testing commit 9a1deb2cdda1ebe46cd5f4cd589cc1e66fbdf90d with merge 99a4c5b44971017c00daf7096ef6d43959efd4db... <!-- homu: {"type":"BuildStarted","head_sha":"9a1deb2cdda1ebe46cd5f4cd589cc1e66fbdf90d","merge_sha":"99a4c5b44971017c00daf7096ef6d43959efd4db"} -->

Turbo87

comment created time in 10 hours

push eventrust-lang/crates.io

Tobias Bieniek

commit sha 9a1deb2cdda1ebe46cd5f4cd589cc1e66fbdf90d

services/session: Add user ids to Sentry context

view details

bors

commit sha 99a4c5b44971017c00daf7096ef6d43959efd4db

Auto merge of #2963 - Turbo87:sentry-user, r=pietroalbini services/session: Add user ids to Sentry context This will make it easier to associate backend errors with frontend errors on Sentry. r? `@pietroalbini`

view details

push time in 10 hours

pull request commentrust-lang/crates.io

services/session: Add user ids to Sentry context

:pushpin: Commit 9a1deb2cdda1ebe46cd5f4cd589cc1e66fbdf90d has been approved by pietroalbini

<!-- @bors r=pietroalbini 9a1deb2cdda1ebe46cd5f4cd589cc1e66fbdf90d --> <!-- homu: {"type":"Approved","sha":"9a1deb2cdda1ebe46cd5f4cd589cc1e66fbdf90d","approver":"pietroalbini"} -->

Turbo87

comment created time in 10 hours

pull request commentrust-lang/rust

Remove unused set-discriminant statements and assignments regardless of rvalue

:pushpin: Commit 4c3e06a0ba557c5915d8c00f23455461549f07f6 has been approved by wesleywiser

<!-- @bors r=wesleywiser 4c3e06a0ba557c5915d8c00f23455461549f07f6 --> <!-- homu: {"type":"Approved","sha":"4c3e06a0ba557c5915d8c00f23455461549f07f6","approver":"wesleywiser"} -->

tmiasko

comment created time in 10 hours

pull request commentrust-lang/rust

rustc_mir: track inlined callees in SourceScopeData.

:pushpin: Commit 2b3f00928c3b0db93c87d462a53c9f0df98f3e27 has been approved by nagisa,oli-obk

<!-- @bors r=nagisa,oli-obk 2b3f00928c3b0db93c87d462a53c9f0df98f3e27 --> <!-- homu: {"type":"Approved","sha":"2b3f00928c3b0db93c87d462a53c9f0df98f3e27","approver":"nagisa,oli-obk"} -->

eddyb

comment created time in 10 hours

push eventrust-lang-ci/rust

Pietro Albini

commit sha 0ee1e91c111e5383ddfa6e0c5adcc1084d12a9d6

build-manifest: allow creating a list of files shipped in a release

view details

bors

commit sha 9f6c670c4b4273b2c7c0af07a524d4240c926bfc

Auto merge of #78196 - pietroalbini:shipped-files, r=Mark-Simulacrum Allow creating a list of files shipped in a release This PR adds the `BUILD_MANIFEST_SHIPPED_FILES_PATH` environment variable to `build-manifest`, which writes a list of all the files referenced in the manifest to the path defined in the variable. The use for this is for `promote-release` to prune files unused files before publishing a release. This PR **does not implement any pruning**, it just adds support for it to be implemented in the future on `promote-release`'s side. r? `@Mark-Simulacrum`

view details

Markus Westerlind

commit sha 85bbd7d608c82b8f2b88d4d5b3ade0b3e0b2f761

perf: Avoid allocating a new Vec on each stall

view details

Markus Westerlind

commit sha 4cf514a064984b6992ca042bc926395a9d67e457

perf: Only process changed obligations in ObligationForest This rewrites most of ObligationForest forest so to avoid iterating through the entire set of obligations on each `select` attempt. Instead only the obligations that can actually make progress are processed. This gives great speedups in benchmarks such as `inflate` which create a large number of pending obligations. To support this the unification tables where extended to to keep track of which type inference variables that has actually changed at each step. Which then lets `ObligationForest` get a list of only the changed variables at each step which it can map back to its obligations. In addition to this primary change, many of the other iterations in `ObligationForest` were refactored to only process lists of the nodes that they actually are interested in. The extra bookkeeping needed for this was possible without the primary change but were a performance regressions there as they slowed down the main loop. As the main loop is no longer the main issue these optimizations could be re-applied.

view details

Markus Westerlind

commit sha 64b2bbd55032c413a221c16071796caab6224389

perf: Avoid logging unifications that ObligationForest do not watch

view details

Markus Westerlind

commit sha bb70251337e3a18c8af9395a815c150b00a5f9bb

refactor: Prefer copy_from_slice instead of explicit loop

view details

Markus Westerlind

commit sha 65014d8306442463eadb455df963156edf89895e

Optimize ModifiedSet for faster snapshot/rollback Snapshot/rollback is done a lot in certain workloads so optimizing for it makes sense as there is very little additional overhead for the set/drain case (which are called relatively rarely)

view details

Markus Westerlind

commit sha 6eeea051a95270089726640d31101c6374540090

refactor: Make UnifyLog have lower overhead snapshots

view details

Markus Westerlind

commit sha aa4595adb608ac54e25dedcee1565e719c9ad759

perf: No need to track modified variables in a bitset Each variable will only be set once anyway due since only variable instantiation calls it.

view details

Markus Westerlind

commit sha 31fb673fa52e2eef154353b424d3d17f23983deb

Start reading where ModifiedSet currently is

view details

Markus Westerlind

commit sha cd86ce146ae99798802b7b2a11abee91f12979fa

Rebase on top of undo_log unification

view details

Markus Westerlind

commit sha 0f08a69749eacb98f19c43f990a2cceb7a605fb6

Clear the modified set once no snapshots exist

view details

Markus Westerlind

commit sha f5dbb04753e184347ecff771616bfbb3e2b7e7b6

Document the additions

view details

Markus Westerlind

commit sha 22abfb69bf1e0789420ebcb1446b5ac1af77074c

refactor: Simplify obligation_forest

view details

Markus Westerlind

commit sha f771696fb291dd2e3dc63b6d7e7ba8f07e3103ef

perf: No need to resolve variables in fulfillment

view details

Markus Westerlind

commit sha 34f3303b9ab205a88a281c7b0d9fe70ef7c6da64

Document obligation forest changes

view details

Markus Westerlind

commit sha 795c8106a1b6add148aa909589fa4babfb570b53

Restore clearing of stalled_on before process_obligation

view details

Markus Westerlind

commit sha 4dcb97343cba89142217fbbf09d61c2675025fdf

fix: Avoid dropping and re-registering offsets in the obligation forest This could in theory cause modified variables to be lost, causing typecheck failures. To make the deregistering easier a helper type to deregister on drop were added

view details

Markus Westerlind

commit sha c49182b71a46a1120f27c3d675e3926ee48367ff

Ensure that predicates that change are marked as done The alternative_predicates does not appear necessary, as long as the predicate is marked done.

view details

Markus Westerlind

commit sha 8e6ca044794c68fd9d3215c968ebe323d1094903

Restore alternative predicates for obligation forest Extracted a test from the object crate found while running on CI (did not exist the in the actual test suite).

view details

push time in 10 hours

pull request commentrust-lang/rust

perf: Only process changed obligations in ObligationForest

:hourglass: Trying commit 22c5b9403a75a7526bff23ba06a61d4129f21e2c with merge 30a3e111a6443337457980ccf94a22d0b8c9d02e... <!-- homu: {"type":"TryBuildStarted","head_sha":"22c5b9403a75a7526bff23ba06a61d4129f21e2c","merge_sha":"30a3e111a6443337457980ccf94a22d0b8c9d02e"} -->

Marwes

comment created time in 10 hours

PR merged rust-lang/rust

Allow creating a list of files shipped in a release S-waiting-on-bors merged-by-bors

This PR adds the BUILD_MANIFEST_SHIPPED_FILES_PATH environment variable to build-manifest, which writes a list of all the files referenced in the manifest to the path defined in the variable. The use for this is for promote-release to prune files unused files before publishing a release.

This PR does not implement any pruning, it just adds support for it to be implemented in the future on promote-release's side.

r? @Mark-Simulacrum

+41 -12

6 comments

2 changed files

pietroalbini

pr closed time in 11 hours

pull request commentrust-lang/rust

update Miri

:hourglass: Testing commit 357333320819a6eed427669b4d583c6fdfeeaedd with merge c96e11c781af319199af77347d55f08085e15453... <!-- homu: {"type":"BuildStarted","head_sha":"357333320819a6eed427669b4d583c6fdfeeaedd","merge_sha":"c96e11c781af319199af77347d55f08085e15453"} -->

RalfJung

comment created time in 11 hours

push eventrust-lang-ci/rust

Ralf Jung

commit sha 357333320819a6eed427669b4d583c6fdfeeaedd

update Miri

view details

bors

commit sha c96e11c781af319199af77347d55f08085e15453

Auto merge of #78395 - RalfJung:miri, r=RalfJung update Miri Fixes https://github.com/rust-lang/rust/issues/78339 Cc `@rust-lang/miri` r? `@ghost`

view details

push time in 11 hours

more