profile
viewpoint

rust-lang/chalk 912

An implementation and definition of the Rust trait system using a PROLOG-like logic solver

brson/rust 9

pursuing the trifecta

rust-lang-ci/rust 1

Empowering everyone to build reliable and efficient software.

alexcrichton/cargo 0

Cargo Experiments

push eventrust-lang/rust-clippy

Tomasz Miąsko

commit sha e9677105bf85a2b0c57e8d67d2ed22a286333033

try_err: Consider Try impl for Poll when generating suggestions There are two different implementation of Try trait for Poll type; Poll<Result<T, E>> and Poll<Option<Result<T, E>>>. Take them into account when generating suggestions. For example, for Err(e)? suggest either return Poll::Ready(Err(e)) or return Poll::Ready(Some(Err(e))) as appropriate.

view details

bors

commit sha 3d7e3fdffd380d0d98f63e878b3ef9948b9452ca

Auto merge of #5857 - tmiasko:try-err-poll, r=matthiaskrgr try_err: Consider Try impl for Poll when generating suggestions There are two different implementation of `Try` trait for `Poll` type: `Poll<Result<T, E>>` and `Poll<Option<Result<T, E>>>`. Take them into account when generating suggestions. For example, for `Err(e)?` suggest either `return Poll::Ready(Err(e))` or `return Poll::Ready(Some(Err(e)))` as appropriate. Fixes #5855 changelog: try_err: Consider Try impl for Poll when generating suggestions

view details

push time in 15 minutes

pull request commentrust-lang/rust-clippy

try_err: Consider Try impl for Poll when generating suggestions

:hourglass: Testing commit e9677105bf85a2b0c57e8d67d2ed22a286333033 with merge 3d7e3fdffd380d0d98f63e878b3ef9948b9452ca... <!-- homu: {"type":"BuildStarted","head_sha":"e9677105bf85a2b0c57e8d67d2ed22a286333033","merge_sha":"3d7e3fdffd380d0d98f63e878b3ef9948b9452ca"} -->

tmiasko

comment created time in 15 minutes

pull request commentrust-lang/rust-clippy

try_err: Consider Try impl for Poll when generating suggestions

:pushpin: Commit e9677105bf85a2b0c57e8d67d2ed22a286333033 has been approved by matthiaskrgr

<!-- @bors r=matthiaskrgr e9677105bf85a2b0c57e8d67d2ed22a286333033 --> <!-- homu: {"type":"Approved","sha":"e9677105bf85a2b0c57e8d67d2ed22a286333033","approver":"matthiaskrgr"} -->

tmiasko

comment created time in 15 minutes

pull request commentrust-lang/rust

Implement Error for &(impl Error)

:sunny: Try build successful - checks-actions, checks-azure Build commit: 353a0a223066e9f46a1d935f2271a26c3c5002bb (353a0a223066e9f46a1d935f2271a26c3c5002bb) <!-- homu: {"type":"TryBuildCompleted","builders":{"checks-azure":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=35803","checks-actions":"https://github.com/rust-lang-ci/rust/runs/948239278"},"merge_sha":"353a0a223066e9f46a1d935f2271a26c3c5002bb"} -->

KodrAus

comment created time in an hour

pull request commentrust-lang/rust

Add regression test for #72787

:pushpin: Commit f3380547138df05d4ac23e4a905756cfbe76fc79 has been approved by lcnr

<!-- @bors r=lcnr f3380547138df05d4ac23e4a905756cfbe76fc79 --> <!-- homu: {"type":"Approved","sha":"f3380547138df05d4ac23e4a905756cfbe76fc79","approver":"lcnr"} -->

JulianKnodt

comment created time in 2 hours

PR merged rust-lang/rust

Completes support for coverage in external crates A-spurious S-waiting-on-bors merged-by-bors

Follow-up to #74959 :

The prior PR corrected for errors encountered when trying to generate the coverage map on source code inlined from external crates (including macros and generics) by avoiding adding external DefIds to the coverage map.

This made it possible to generate a coverage report including external crates, but the external crate coverage was incomplete (did not include coverage for the DefIds that were eliminated.

The root issue was that the coverage map was converting Span locations to source file and locations, using the SourceMap for the current crate, and this would not work for spans from external crates (compliled with a different SourceMap).

The solution was to convert the Spans to filename and location during MIR generation instead, so precompiled external crates would already have the correct source code locations embedded in their MIR, when imported into another crate.

@wesleywiser FYI r? @tmandry

+411 -368

59 comments

15 changed files

richkadel

pr closed time in 2 hours

push eventrust-lang-ci/rust

David Wood

commit sha 5f89f02c4e7d06dcb94434b8b30ce457b06eda5c

mir: use `FiniteBitSet<u32>` in polymorphization This commit changes polymorphization to return a `FiniteBitSet<u32>` rather than a `FiniteBitSet<u64>` because most functions do not use anywhere near sixty-four generic parameters so keeping a `u64` around is unnecessary in most cases. Signed-off-by: David Wood <david@davidtw.co>

view details

David Wood

commit sha 70b49c7bddec33e6972610e024fcbb3576aa9be3

metadata: skip empty polymorphization bitset This commit skips encoding empty polymorphization results - while polymorphization is disabled, this should be every polymorphization result; but when polymorphization is re-enabled, this would help with non-generic functions and those which do use all their parameters (most functions). Signed-off-by: David Wood <david@davidtw.co>

view details

David Wood

commit sha 63fadee21f4d3d7a07381dafc6cd2dfd644b5b02

mir: add debug assertion to check polymorphization This commit adds some debug assertions to `ensure_monomorphic_enough` which checks that unused generic parameters have been replaced with a parameter. Signed-off-by: David Wood <david@davidtw.co>

view details

bors

commit sha 7f8ff84b510e3ff04865cfdd5ef95e677227e0c8

Auto merge of #75155 - davidtwco:polymorphization-incr-comp-optimisations, r=lcnr polymorphization: various improvements This PR includes a handful of polymorphisation-related changes: - @Mark-Simulacrum's suggestions [from this comment](https://github.com/rust-lang/rust/pull/74633#issuecomment-668684433): - Use a `FiniteBitSet<u32>` over a `FiniteBitSet<u64>` as most functions won't have 64 generic parameters. - Don't encode polymorphisation results in metadata when every parameter is used (in this case, just invoking polymorphisation will probably be quicker). - @lcnr's suggestion [from this comment](https://github.com/rust-lang/rust/pull/74717#discussion_r463690015). - Add an debug assertion in `ensure_monomorphic_enough` to make sure that polymorphisation did what we expect. r? @lcnr

view details

push time in 2 hours

pull request commentrust-lang/rust

polymorphization: various improvements

:hourglass: Testing commit 63fadee21f4d3d7a07381dafc6cd2dfd644b5b02 with merge 7f8ff84b510e3ff04865cfdd5ef95e677227e0c8... <!-- homu: {"type":"BuildStarted","head_sha":"63fadee21f4d3d7a07381dafc6cd2dfd644b5b02","merge_sha":"7f8ff84b510e3ff04865cfdd5ef95e677227e0c8"} -->

davidtwco

comment created time in 2 hours

push eventrust-lang/rust

Rich Kadel

commit sha e0dc8dec273b4cba44a91c1b4433e3dcd117919f

Completes support for coverage in external crates The prior PR corrected for errors encountered when trying to generate the coverage map on source code inlined from external crates (including macros and generics) by avoiding adding external DefIds to the coverage map. This made it possible to generate a coverage report including external crates, but the external crate coverage was incomplete (did not include coverage for the DefIds that were eliminated. The root issue was that the coverage map was converting Span locations to source file and locations, using the SourceMap for the current crate, and this would not work for spans from external crates (compliled with a different SourceMap). The solution was to convert the Spans to filename and location during MIR generation instead, so precompiled external crates would already have the correct source code locations embedded in their MIR, when imported into another crate.

view details

bors

commit sha dab2ae0404014b4fbc5a32a8c954fe6068b25f71

Auto merge of #75037 - richkadel:llvm-coverage-map-gen-5.2, r=wesleywiser Completes support for coverage in external crates Follow-up to #74959 : The prior PR corrected for errors encountered when trying to generate the coverage map on source code inlined from external crates (including macros and generics) by avoiding adding external DefIds to the coverage map. This made it possible to generate a coverage report including external crates, but the external crate coverage was incomplete (did not include coverage for the DefIds that were eliminated. The root issue was that the coverage map was converting Span locations to source file and locations, using the SourceMap for the current crate, and this would not work for spans from external crates (compliled with a different SourceMap). The solution was to convert the Spans to filename and location during MIR generation instead, so precompiled external crates would already have the correct source code locations embedded in their MIR, when imported into another crate. @wesleywiser FYI r? @tmandry

view details

push time in 2 hours

push eventrust-lang-ci/rust

Rich Kadel

commit sha e0dc8dec273b4cba44a91c1b4433e3dcd117919f

Completes support for coverage in external crates The prior PR corrected for errors encountered when trying to generate the coverage map on source code inlined from external crates (including macros and generics) by avoiding adding external DefIds to the coverage map. This made it possible to generate a coverage report including external crates, but the external crate coverage was incomplete (did not include coverage for the DefIds that were eliminated. The root issue was that the coverage map was converting Span locations to source file and locations, using the SourceMap for the current crate, and this would not work for spans from external crates (compliled with a different SourceMap). The solution was to convert the Spans to filename and location during MIR generation instead, so precompiled external crates would already have the correct source code locations embedded in their MIR, when imported into another crate.

view details

bors

commit sha dab2ae0404014b4fbc5a32a8c954fe6068b25f71

Auto merge of #75037 - richkadel:llvm-coverage-map-gen-5.2, r=wesleywiser Completes support for coverage in external crates Follow-up to #74959 : The prior PR corrected for errors encountered when trying to generate the coverage map on source code inlined from external crates (including macros and generics) by avoiding adding external DefIds to the coverage map. This made it possible to generate a coverage report including external crates, but the external crate coverage was incomplete (did not include coverage for the DefIds that were eliminated. The root issue was that the coverage map was converting Span locations to source file and locations, using the SourceMap for the current crate, and this would not work for spans from external crates (compliled with a different SourceMap). The solution was to convert the Spans to filename and location during MIR generation instead, so precompiled external crates would already have the correct source code locations embedded in their MIR, when imported into another crate. @wesleywiser FYI r? @tmandry

view details

push time in 2 hours

pull request commentrust-lang/rust

Completes support for coverage in external crates

:sunny: Test successful - checks-actions, checks-azure Approved by: wesleywiser Pushing dab2ae0404014b4fbc5a32a8c954fe6068b25f71 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"wesleywiser","base_ref":"master","builders":{"checks-azure":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=35802","checks-actions":"https://github.com/rust-lang-ci/rust/runs/948028495"},"merge_sha":"dab2ae0404014b4fbc5a32a8c954fe6068b25f71"} -->

richkadel

comment created time in 2 hours

push eventrust-lang-ci/rust

Bastian Kauschke

commit sha 06dbd06e4deab2255d310d38ed0ea28becf43664

forbid `#[track_caller]` on main

view details

Ivan Tham

commit sha c577d71e03cebb03d079670e8b9ce995fb79560b

Remove log alias from librustdoc

view details

Guillaume Gomez

commit sha 0275cd74096b71f6c641b06e73e6cb359303d6cc

Clean up E0745

view details

Felix Yan

commit sha 6d75d7c0843dc0f2b64b4427e3290222ef558227

Correct a typo in interpret/memory.rs

view details

Tim Diekmann

commit sha ab9362ad9a9b4b93951ccb577224dda367923226

Replace `Memoryblock` with `NonNull<[u8]>`

view details

Tim Diekmann

commit sha 929e37d4bfb2d6c99094a8a89c5feda47d25bbbe

Revert renaming of "memory block"

view details

Tim Diekmann

commit sha 93d98328d161bcdf002f9d2f7f916f01c6fce3b1

Revert missing "memory block"

view details

Bastian Kauschke

commit sha 9127e27cec22cb130d0a96094196995d72b19030

tweak error message

view details

Eric Huss

commit sha 583133308ba82f4140c3d8b80ead7766d0f86906

Update books

view details

bors

commit sha 32d14eba47ee8bb0b5edb04bcf652517f81c4cf5

Auto merge of #75130 - lcnr:array_chunks, r=ecstatic-morse forbid `#[track_caller]` on main fixes #75125 cc @anp

view details

Yuki Okushi

commit sha 7b39f75187f14a7d8b3735967499b457d85b17cb

Rollup merge of #75139 - pickfire:librustdoc-import, r=jyn514 Remove log alias from librustdoc r? @jyn514

view details

Yuki Okushi

commit sha 008228a708302d4dd8359dccee6a8a85fff3865e

Rollup merge of #75140 - GuillaumeGomez:cleanup-e0745, r=pickfire Clean up E0745 r? @Dylan-DPC

view details

Yuki Okushi

commit sha 7123daff5359dc3ebabcf4d1e00b085c27455877

Rollup merge of #75149 - felixonmars:patch-1, r=wesleywiser Correct a typo in interpret/memory.rs

view details

Yuki Okushi

commit sha 5f87ee0ab1bcbf708d27e928296cb44ce9ba9c5f

Rollup merge of #75152 - TimDiekmann:replace_memblock, r=Amanieu Replace `Memoryblock` with `NonNull<[u8]>` Closes rust-lang/wg-allocators#61 r? @Amanieu

view details

Yuki Okushi

commit sha 324faf1aacddb9197ea9c1e2296c7102a069513c

Rollup merge of #75168 - ehuss:update-books, r=ehuss Update books ## reference 7 commits in b329ce37424874ad4db94f829a55807c6e21d2cb..c9b2736a059469043177e1e4ed41a55d7c63ac28 2020-07-20 08:54:08 -0700 to 2020-08-03 03:34:03 -0700 - Fix documented build output path. (rust-lang-nursery/reference#870) - Update token usage table. (rust-lang-nursery/reference#868) - Allow trait inner attributes (rust-lang-nursery/reference#864) - patterns.md - add word "underscore" to _ paragraph (rust-lang-nursery/reference#865) - Drive-by mention unsafe fn closure coercion (rust-lang-nursery/reference#802) - grammar: Change "For awhile" to "For a while" (rust-lang-nursery/reference#857) - Added Unpin to list of Auto Traits (rust-lang-nursery/reference#854) ## book 7 commits in a914f2c7e5cdb771fa465de142381a51c53b580e..363293c1c5ce9e84ea3935a5e29ce8624801208a 2020-07-21 09:20:05 -0500 to 2020-08-03 15:56:30 -0500 - replace commas with m-dashes to improve readability of chapter 4.1 (rust-lang/book#2419) - Update TOML link to official website (rust-lang/book#2411) - Add github repo link (rust-lang/book#2265) - Remove the version number entirely so we can stop updating it - Add link to the `Vec&lt;T&gt;` API documentation (rust-lang/book#2249) - link to stdlib atomic docs (rust-lang/book#2361) - mdbook version used is now 0.4.x (rust-lang/book#2410) ## rust-by-example 1 commits in 229c6945a26a53a751ffa4f9cb418388c00029d3..2e9271981adc32613365810f3428334c07095215 2020-07-06 10:13:15 -0300 to 2020-07-27 13:39:16 -0500 - Replaced "princess" with "royal" (rust-lang/rust-by-example#1363) ## embedded-book 1 commits in 94d9ea8460bcbbbfef1877b47cb930260b5849a7..b5256448a2a4c1bec68b93c0847066f92f2ff5a9 2020-07-05 14:17:40 +0000 to 2020-07-24 23:09:29 +0000 - Update c-with-rust.md (rust-embedded/book#256)

view details

bors

commit sha 119d2a1a98fe87d4ae6cabf12134a0ef2fb95851

Auto merge of #75174 - JohnTitor:rollup-z9djftk, r=JohnTitor Rollup of 5 pull requests Successful merges: - #75139 (Remove log alias from librustdoc) - #75140 (Clean up E0745) - #75149 (Correct a typo in interpret/memory.rs) - #75152 (Replace `Memoryblock` with `NonNull<[u8]>`) - #75168 (Update books) Failed merges: r? @ghost

view details

Ashley Mannix

commit sha 39466bc58b15cca644afcdf79a152625fc75987e

implement Error for &(impl Error)

view details

bors

commit sha 353a0a223066e9f46a1d935f2271a26c3c5002bb

Auto merge of #75180 - KodrAus:feat/error-by-ref, r=<try> Implement Error for &(impl Error) Opening this up just to see what it breaks. It's unfortunate that `&(impl Error)` doesn't actually implement `Error`. If this direct approach doesn't work out then I'll try something different, like an `Error::by_ref` method.

view details

push time in 2 hours

pull request commentrust-lang/rust

Implement Error for &(impl Error)

:hourglass: Trying commit 39466bc58b15cca644afcdf79a152625fc75987e with merge 353a0a223066e9f46a1d935f2271a26c3c5002bb... <!-- homu: {"type":"TryBuildStarted","head_sha":"39466bc58b15cca644afcdf79a152625fc75987e","merge_sha":"353a0a223066e9f46a1d935f2271a26c3c5002bb"} -->

KodrAus

comment created time in 2 hours

pull request commentrust-lang/rust

polymorphization: various improvements

:pushpin: Commit 63fadee21f4d3d7a07381dafc6cd2dfd644b5b02 has been approved by lcnr

<!-- @bors r=lcnr 63fadee21f4d3d7a07381dafc6cd2dfd644b5b02 --> <!-- homu: {"type":"Approved","sha":"63fadee21f4d3d7a07381dafc6cd2dfd644b5b02","approver":"lcnr"} -->

davidtwco

comment created time in 3 hours

pull request commentrust-lang/rust

Add regression test for #64494

:pushpin: Commit 7dd1b6a22fc7c98cc3e3daeaae3a51bc184fee34 has been approved by lcnr

<!-- @bors r=lcnr 7dd1b6a22fc7c98cc3e3daeaae3a51bc184fee34 --> <!-- homu: {"type":"Approved","sha":"7dd1b6a22fc7c98cc3e3daeaae3a51bc184fee34","approver":"lcnr"} -->

JulianKnodt

comment created time in 3 hours

pull request commentrust-lang/rust

New zeroed slice

:umbrella: The latest upstream changes (presumably #75174) made this pull request unmergeable. Please resolve the merge conflicts.

amosonn

comment created time in 3 hours

PR merged rust-lang/rust

Remove log alias from librustdoc C-cleanup S-waiting-on-bors T-rustdoc

r? @jyn514

+1 -1

16 comments

1 changed file

pickfire

pr closed time in 4 hours

PR merged rust-lang/rust

Clean up E0745 S-waiting-on-bors

r? @Dylan-DPC

+7 -4

6 comments

1 changed file

GuillaumeGomez

pr closed time in 4 hours

PR merged rust-lang/rust

Correct a typo in interpret/memory.rs S-waiting-on-bors
+1 -1

3 comments

1 changed file

felixonmars

pr closed time in 4 hours

PR merged rust-lang/rust

Replace `Memoryblock` with `NonNull<[u8]>` S-waiting-on-bors

Closes rust-lang/wg-allocators#61

r? @Amanieu

+135 -120

6 comments

17 changed files

TimDiekmann

pr closed time in 4 hours

push eventrust-lang-ci/rust

Rich Kadel

commit sha e0dc8dec273b4cba44a91c1b4433e3dcd117919f

Completes support for coverage in external crates The prior PR corrected for errors encountered when trying to generate the coverage map on source code inlined from external crates (including macros and generics) by avoiding adding external DefIds to the coverage map. This made it possible to generate a coverage report including external crates, but the external crate coverage was incomplete (did not include coverage for the DefIds that were eliminated. The root issue was that the coverage map was converting Span locations to source file and locations, using the SourceMap for the current crate, and this would not work for spans from external crates (compliled with a different SourceMap). The solution was to convert the Spans to filename and location during MIR generation instead, so precompiled external crates would already have the correct source code locations embedded in their MIR, when imported into another crate.

view details

bors

commit sha dab2ae0404014b4fbc5a32a8c954fe6068b25f71

Auto merge of #75037 - richkadel:llvm-coverage-map-gen-5.2, r=wesleywiser Completes support for coverage in external crates Follow-up to #74959 : The prior PR corrected for errors encountered when trying to generate the coverage map on source code inlined from external crates (including macros and generics) by avoiding adding external DefIds to the coverage map. This made it possible to generate a coverage report including external crates, but the external crate coverage was incomplete (did not include coverage for the DefIds that were eliminated. The root issue was that the coverage map was converting Span locations to source file and locations, using the SourceMap for the current crate, and this would not work for spans from external crates (compliled with a different SourceMap). The solution was to convert the Spans to filename and location during MIR generation instead, so precompiled external crates would already have the correct source code locations embedded in their MIR, when imported into another crate. @wesleywiser FYI r? @tmandry

view details

push time in 4 hours

pull request commentrust-lang/rust

Completes support for coverage in external crates

:hourglass: Testing commit e0dc8dec273b4cba44a91c1b4433e3dcd117919f with merge dab2ae0404014b4fbc5a32a8c954fe6068b25f71... <!-- homu: {"type":"BuildStarted","head_sha":"e0dc8dec273b4cba44a91c1b4433e3dcd117919f","merge_sha":"dab2ae0404014b4fbc5a32a8c954fe6068b25f71"} -->

richkadel

comment created time in 4 hours

PR merged rust-lang/rust

Update books S-waiting-on-bors

reference

7 commits in b329ce37424874ad4db94f829a55807c6e21d2cb..c9b2736a059469043177e1e4ed41a55d7c63ac28 2020-07-20 08:54:08 -0700 to 2020-08-03 03:34:03 -0700

  • Fix documented build output path. (rust-lang-nursery/reference#870)
  • Update token usage table. (rust-lang-nursery/reference#868)
  • Allow trait inner attributes (rust-lang-nursery/reference#864)
  • patterns.md - add word "underscore" to _ paragraph (rust-lang-nursery/reference#865)
  • Drive-by mention unsafe fn closure coercion (rust-lang-nursery/reference#802)
  • grammar: Change "For awhile" to "For a while" (rust-lang-nursery/reference#857)
  • Added Unpin to list of Auto Traits (rust-lang-nursery/reference#854)

book

7 commits in a914f2c7e5cdb771fa465de142381a51c53b580e..363293c1c5ce9e84ea3935a5e29ce8624801208a 2020-07-21 09:20:05 -0500 to 2020-08-03 15:56:30 -0500

  • replace commas with m-dashes to improve readability of chapter 4.1 (rust-lang/book#2419)
  • Update TOML link to official website (rust-lang/book#2411)
  • Add github repo link (rust-lang/book#2265)
  • Remove the version number entirely so we can stop updating it
  • Add link to the Vec&lt;T&gt; API documentation (rust-lang/book#2249)
  • link to stdlib atomic docs (rust-lang/book#2361)
  • mdbook version used is now 0.4.x (rust-lang/book#2410)

rust-by-example

1 commits in 229c6945a26a53a751ffa4f9cb418388c00029d3..2e9271981adc32613365810f3428334c07095215 2020-07-06 10:13:15 -0300 to 2020-07-27 13:39:16 -0500

  • Replaced "princess" with "royal" (rust-lang/rust-by-example#1363)

embedded-book

1 commits in 94d9ea8460bcbbbfef1877b47cb930260b5849a7..b5256448a2a4c1bec68b93c0847066f92f2ff5a9 2020-07-05 14:17:40 +0000 to 2020-07-24 23:09:29 +0000

  • Update c-with-rust.md (rust-embedded/book#256)
+4 -4

3 comments

4 changed files

ehuss

pr closed time in 4 hours

PR merged rust-lang/rust

Rollup of 5 pull requests S-waiting-on-bors merged-by-bors rollup

Successful merges:

  • #75139 (Remove log alias from librustdoc)
  • #75140 (Clean up E0745)
  • #75149 (Correct a typo in interpret/memory.rs)
  • #75152 (Replace Memoryblock with NonNull<[u8]>)
  • #75168 (Update books)

Failed merges:

r? @ghost

+148 -130

4 comments

24 changed files

JohnTitor

pr closed time in 4 hours

push eventrust-lang/rust

Ivan Tham

commit sha c577d71e03cebb03d079670e8b9ce995fb79560b

Remove log alias from librustdoc

view details

Guillaume Gomez

commit sha 0275cd74096b71f6c641b06e73e6cb359303d6cc

Clean up E0745

view details

Felix Yan

commit sha 6d75d7c0843dc0f2b64b4427e3290222ef558227

Correct a typo in interpret/memory.rs

view details

Tim Diekmann

commit sha ab9362ad9a9b4b93951ccb577224dda367923226

Replace `Memoryblock` with `NonNull<[u8]>`

view details

Tim Diekmann

commit sha 929e37d4bfb2d6c99094a8a89c5feda47d25bbbe

Revert renaming of "memory block"

view details

Tim Diekmann

commit sha 93d98328d161bcdf002f9d2f7f916f01c6fce3b1

Revert missing "memory block"

view details

Eric Huss

commit sha 583133308ba82f4140c3d8b80ead7766d0f86906

Update books

view details

Yuki Okushi

commit sha 7b39f75187f14a7d8b3735967499b457d85b17cb

Rollup merge of #75139 - pickfire:librustdoc-import, r=jyn514 Remove log alias from librustdoc r? @jyn514

view details

Yuki Okushi

commit sha 008228a708302d4dd8359dccee6a8a85fff3865e

Rollup merge of #75140 - GuillaumeGomez:cleanup-e0745, r=pickfire Clean up E0745 r? @Dylan-DPC

view details

Yuki Okushi

commit sha 7123daff5359dc3ebabcf4d1e00b085c27455877

Rollup merge of #75149 - felixonmars:patch-1, r=wesleywiser Correct a typo in interpret/memory.rs

view details

Yuki Okushi

commit sha 5f87ee0ab1bcbf708d27e928296cb44ce9ba9c5f

Rollup merge of #75152 - TimDiekmann:replace_memblock, r=Amanieu Replace `Memoryblock` with `NonNull<[u8]>` Closes rust-lang/wg-allocators#61 r? @Amanieu

view details

Yuki Okushi

commit sha 324faf1aacddb9197ea9c1e2296c7102a069513c

Rollup merge of #75168 - ehuss:update-books, r=ehuss Update books ## reference 7 commits in b329ce37424874ad4db94f829a55807c6e21d2cb..c9b2736a059469043177e1e4ed41a55d7c63ac28 2020-07-20 08:54:08 -0700 to 2020-08-03 03:34:03 -0700 - Fix documented build output path. (rust-lang-nursery/reference#870) - Update token usage table. (rust-lang-nursery/reference#868) - Allow trait inner attributes (rust-lang-nursery/reference#864) - patterns.md - add word "underscore" to _ paragraph (rust-lang-nursery/reference#865) - Drive-by mention unsafe fn closure coercion (rust-lang-nursery/reference#802) - grammar: Change "For awhile" to "For a while" (rust-lang-nursery/reference#857) - Added Unpin to list of Auto Traits (rust-lang-nursery/reference#854) ## book 7 commits in a914f2c7e5cdb771fa465de142381a51c53b580e..363293c1c5ce9e84ea3935a5e29ce8624801208a 2020-07-21 09:20:05 -0500 to 2020-08-03 15:56:30 -0500 - replace commas with m-dashes to improve readability of chapter 4.1 (rust-lang/book#2419) - Update TOML link to official website (rust-lang/book#2411) - Add github repo link (rust-lang/book#2265) - Remove the version number entirely so we can stop updating it - Add link to the `Vec&lt;T&gt;` API documentation (rust-lang/book#2249) - link to stdlib atomic docs (rust-lang/book#2361) - mdbook version used is now 0.4.x (rust-lang/book#2410) ## rust-by-example 1 commits in 229c6945a26a53a751ffa4f9cb418388c00029d3..2e9271981adc32613365810f3428334c07095215 2020-07-06 10:13:15 -0300 to 2020-07-27 13:39:16 -0500 - Replaced "princess" with "royal" (rust-lang/rust-by-example#1363) ## embedded-book 1 commits in 94d9ea8460bcbbbfef1877b47cb930260b5849a7..b5256448a2a4c1bec68b93c0847066f92f2ff5a9 2020-07-05 14:17:40 +0000 to 2020-07-24 23:09:29 +0000 - Update c-with-rust.md (rust-embedded/book#256)

view details

bors

commit sha 119d2a1a98fe87d4ae6cabf12134a0ef2fb95851

Auto merge of #75174 - JohnTitor:rollup-z9djftk, r=JohnTitor Rollup of 5 pull requests Successful merges: - #75139 (Remove log alias from librustdoc) - #75140 (Clean up E0745) - #75149 (Correct a typo in interpret/memory.rs) - #75152 (Replace `Memoryblock` with `NonNull<[u8]>`) - #75168 (Update books) Failed merges: r? @ghost

view details

push time in 4 hours

push eventrust-lang-ci/rust

Ivan Tham

commit sha c577d71e03cebb03d079670e8b9ce995fb79560b

Remove log alias from librustdoc

view details

Guillaume Gomez

commit sha 0275cd74096b71f6c641b06e73e6cb359303d6cc

Clean up E0745

view details

Felix Yan

commit sha 6d75d7c0843dc0f2b64b4427e3290222ef558227

Correct a typo in interpret/memory.rs

view details

Tim Diekmann

commit sha ab9362ad9a9b4b93951ccb577224dda367923226

Replace `Memoryblock` with `NonNull<[u8]>`

view details

Tim Diekmann

commit sha 929e37d4bfb2d6c99094a8a89c5feda47d25bbbe

Revert renaming of "memory block"

view details

Tim Diekmann

commit sha 93d98328d161bcdf002f9d2f7f916f01c6fce3b1

Revert missing "memory block"

view details

Eric Huss

commit sha 583133308ba82f4140c3d8b80ead7766d0f86906

Update books

view details

Yuki Okushi

commit sha 7b39f75187f14a7d8b3735967499b457d85b17cb

Rollup merge of #75139 - pickfire:librustdoc-import, r=jyn514 Remove log alias from librustdoc r? @jyn514

view details

Yuki Okushi

commit sha 008228a708302d4dd8359dccee6a8a85fff3865e

Rollup merge of #75140 - GuillaumeGomez:cleanup-e0745, r=pickfire Clean up E0745 r? @Dylan-DPC

view details

Yuki Okushi

commit sha 7123daff5359dc3ebabcf4d1e00b085c27455877

Rollup merge of #75149 - felixonmars:patch-1, r=wesleywiser Correct a typo in interpret/memory.rs

view details

Yuki Okushi

commit sha 5f87ee0ab1bcbf708d27e928296cb44ce9ba9c5f

Rollup merge of #75152 - TimDiekmann:replace_memblock, r=Amanieu Replace `Memoryblock` with `NonNull<[u8]>` Closes rust-lang/wg-allocators#61 r? @Amanieu

view details

Yuki Okushi

commit sha 324faf1aacddb9197ea9c1e2296c7102a069513c

Rollup merge of #75168 - ehuss:update-books, r=ehuss Update books ## reference 7 commits in b329ce37424874ad4db94f829a55807c6e21d2cb..c9b2736a059469043177e1e4ed41a55d7c63ac28 2020-07-20 08:54:08 -0700 to 2020-08-03 03:34:03 -0700 - Fix documented build output path. (rust-lang-nursery/reference#870) - Update token usage table. (rust-lang-nursery/reference#868) - Allow trait inner attributes (rust-lang-nursery/reference#864) - patterns.md - add word "underscore" to _ paragraph (rust-lang-nursery/reference#865) - Drive-by mention unsafe fn closure coercion (rust-lang-nursery/reference#802) - grammar: Change "For awhile" to "For a while" (rust-lang-nursery/reference#857) - Added Unpin to list of Auto Traits (rust-lang-nursery/reference#854) ## book 7 commits in a914f2c7e5cdb771fa465de142381a51c53b580e..363293c1c5ce9e84ea3935a5e29ce8624801208a 2020-07-21 09:20:05 -0500 to 2020-08-03 15:56:30 -0500 - replace commas with m-dashes to improve readability of chapter 4.1 (rust-lang/book#2419) - Update TOML link to official website (rust-lang/book#2411) - Add github repo link (rust-lang/book#2265) - Remove the version number entirely so we can stop updating it - Add link to the `Vec&lt;T&gt;` API documentation (rust-lang/book#2249) - link to stdlib atomic docs (rust-lang/book#2361) - mdbook version used is now 0.4.x (rust-lang/book#2410) ## rust-by-example 1 commits in 229c6945a26a53a751ffa4f9cb418388c00029d3..2e9271981adc32613365810f3428334c07095215 2020-07-06 10:13:15 -0300 to 2020-07-27 13:39:16 -0500 - Replaced "princess" with "royal" (rust-lang/rust-by-example#1363) ## embedded-book 1 commits in 94d9ea8460bcbbbfef1877b47cb930260b5849a7..b5256448a2a4c1bec68b93c0847066f92f2ff5a9 2020-07-05 14:17:40 +0000 to 2020-07-24 23:09:29 +0000 - Update c-with-rust.md (rust-embedded/book#256)

view details

bors

commit sha 119d2a1a98fe87d4ae6cabf12134a0ef2fb95851

Auto merge of #75174 - JohnTitor:rollup-z9djftk, r=JohnTitor Rollup of 5 pull requests Successful merges: - #75139 (Remove log alias from librustdoc) - #75140 (Clean up E0745) - #75149 (Correct a typo in interpret/memory.rs) - #75152 (Replace `Memoryblock` with `NonNull<[u8]>`) - #75168 (Update books) Failed merges: r? @ghost

view details

push time in 4 hours

pull request commentrust-lang/rust

Rollup of 5 pull requests

:sunny: Test successful - checks-actions, checks-azure Approved by: JohnTitor Pushing 119d2a1a98fe87d4ae6cabf12134a0ef2fb95851 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"JohnTitor","base_ref":"master","builders":{"checks-azure":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=35801","checks-actions":"https://github.com/rust-lang-ci/rust/runs/947754602"},"merge_sha":"119d2a1a98fe87d4ae6cabf12134a0ef2fb95851"} -->

JohnTitor

comment created time in 4 hours

push eventrust-lang-ci/rust

Ivan Tham

commit sha c577d71e03cebb03d079670e8b9ce995fb79560b

Remove log alias from librustdoc

view details

Guillaume Gomez

commit sha 0275cd74096b71f6c641b06e73e6cb359303d6cc

Clean up E0745

view details

Felix Yan

commit sha 6d75d7c0843dc0f2b64b4427e3290222ef558227

Correct a typo in interpret/memory.rs

view details

Tim Diekmann

commit sha ab9362ad9a9b4b93951ccb577224dda367923226

Replace `Memoryblock` with `NonNull<[u8]>`

view details

Tim Diekmann

commit sha 929e37d4bfb2d6c99094a8a89c5feda47d25bbbe

Revert renaming of "memory block"

view details

Tim Diekmann

commit sha 93d98328d161bcdf002f9d2f7f916f01c6fce3b1

Revert missing "memory block"

view details

Eric Huss

commit sha 583133308ba82f4140c3d8b80ead7766d0f86906

Update books

view details

Yuki Okushi

commit sha 7b39f75187f14a7d8b3735967499b457d85b17cb

Rollup merge of #75139 - pickfire:librustdoc-import, r=jyn514 Remove log alias from librustdoc r? @jyn514

view details

Yuki Okushi

commit sha 008228a708302d4dd8359dccee6a8a85fff3865e

Rollup merge of #75140 - GuillaumeGomez:cleanup-e0745, r=pickfire Clean up E0745 r? @Dylan-DPC

view details

Yuki Okushi

commit sha 7123daff5359dc3ebabcf4d1e00b085c27455877

Rollup merge of #75149 - felixonmars:patch-1, r=wesleywiser Correct a typo in interpret/memory.rs

view details

Yuki Okushi

commit sha 5f87ee0ab1bcbf708d27e928296cb44ce9ba9c5f

Rollup merge of #75152 - TimDiekmann:replace_memblock, r=Amanieu Replace `Memoryblock` with `NonNull<[u8]>` Closes rust-lang/wg-allocators#61 r? @Amanieu

view details

Yuki Okushi

commit sha 324faf1aacddb9197ea9c1e2296c7102a069513c

Rollup merge of #75168 - ehuss:update-books, r=ehuss Update books ## reference 7 commits in b329ce37424874ad4db94f829a55807c6e21d2cb..c9b2736a059469043177e1e4ed41a55d7c63ac28 2020-07-20 08:54:08 -0700 to 2020-08-03 03:34:03 -0700 - Fix documented build output path. (rust-lang-nursery/reference#870) - Update token usage table. (rust-lang-nursery/reference#868) - Allow trait inner attributes (rust-lang-nursery/reference#864) - patterns.md - add word "underscore" to _ paragraph (rust-lang-nursery/reference#865) - Drive-by mention unsafe fn closure coercion (rust-lang-nursery/reference#802) - grammar: Change "For awhile" to "For a while" (rust-lang-nursery/reference#857) - Added Unpin to list of Auto Traits (rust-lang-nursery/reference#854) ## book 7 commits in a914f2c7e5cdb771fa465de142381a51c53b580e..363293c1c5ce9e84ea3935a5e29ce8624801208a 2020-07-21 09:20:05 -0500 to 2020-08-03 15:56:30 -0500 - replace commas with m-dashes to improve readability of chapter 4.1 (rust-lang/book#2419) - Update TOML link to official website (rust-lang/book#2411) - Add github repo link (rust-lang/book#2265) - Remove the version number entirely so we can stop updating it - Add link to the `Vec&lt;T&gt;` API documentation (rust-lang/book#2249) - link to stdlib atomic docs (rust-lang/book#2361) - mdbook version used is now 0.4.x (rust-lang/book#2410) ## rust-by-example 1 commits in 229c6945a26a53a751ffa4f9cb418388c00029d3..2e9271981adc32613365810f3428334c07095215 2020-07-06 10:13:15 -0300 to 2020-07-27 13:39:16 -0500 - Replaced "princess" with "royal" (rust-lang/rust-by-example#1363) ## embedded-book 1 commits in 94d9ea8460bcbbbfef1877b47cb930260b5849a7..b5256448a2a4c1bec68b93c0847066f92f2ff5a9 2020-07-05 14:17:40 +0000 to 2020-07-24 23:09:29 +0000 - Update c-with-rust.md (rust-embedded/book#256)

view details

bors

commit sha 119d2a1a98fe87d4ae6cabf12134a0ef2fb95851

Auto merge of #75174 - JohnTitor:rollup-z9djftk, r=JohnTitor Rollup of 5 pull requests Successful merges: - #75139 (Remove log alias from librustdoc) - #75140 (Clean up E0745) - #75149 (Correct a typo in interpret/memory.rs) - #75152 (Replace `Memoryblock` with `NonNull<[u8]>`) - #75168 (Update books) Failed merges: r? @ghost

view details

push time in 6 hours

PR merged rust-lang/rust

forbid `#[track_caller]` on main S-waiting-on-bors beta-nominated merged-by-bors

fixes #75125

cc @anp

+75 -6

15 comments

7 changed files

lcnr

pr closed time in 6 hours

pull request commentrust-lang/rust

Rollup of 5 pull requests

:hourglass: Testing commit 324faf1aacddb9197ea9c1e2296c7102a069513c with merge 119d2a1a98fe87d4ae6cabf12134a0ef2fb95851... <!-- homu: {"type":"BuildStarted","head_sha":"324faf1aacddb9197ea9c1e2296c7102a069513c","merge_sha":"119d2a1a98fe87d4ae6cabf12134a0ef2fb95851"} -->

JohnTitor

comment created time in 6 hours

push eventrust-lang/rust

Bastian Kauschke

commit sha 06dbd06e4deab2255d310d38ed0ea28becf43664

forbid `#[track_caller]` on main

view details

Bastian Kauschke

commit sha 9127e27cec22cb130d0a96094196995d72b19030

tweak error message

view details

bors

commit sha 32d14eba47ee8bb0b5edb04bcf652517f81c4cf5

Auto merge of #75130 - lcnr:array_chunks, r=ecstatic-morse forbid `#[track_caller]` on main fixes #75125 cc @anp

view details

push time in 6 hours

push eventrust-lang-ci/rust

Bastian Kauschke

commit sha 06dbd06e4deab2255d310d38ed0ea28becf43664

forbid `#[track_caller]` on main

view details

Bastian Kauschke

commit sha 9127e27cec22cb130d0a96094196995d72b19030

tweak error message

view details

bors

commit sha 32d14eba47ee8bb0b5edb04bcf652517f81c4cf5

Auto merge of #75130 - lcnr:array_chunks, r=ecstatic-morse forbid `#[track_caller]` on main fixes #75125 cc @anp

view details

push time in 6 hours

issue closedrust-lang/rust

Program crashes with #[track_caller] applied to main()

Code

#[track_caller]
fn main() {
    panic!("{}: oh no", std::panic::Location::caller());
}

Meta

Crash occurs in both 1.46.0 beta and in current nightly.

rustc --version --verbose:

rustc 1.46.0-beta.2 (6f959902b 2020-07-23)
binary: rustc
commit-hash: 6f959902b3103c49ca981fbc01871589c3498489
commit-date: 2020-07-23
host: x86_64-unknown-linux-gnu
release: 1.46.0-beta.2
LLVM version: 10.0
rustc 1.47.0-nightly (81e754c35 2020-08-02)
binary: rustc
commit-hash: 81e754c359c471f91263813c46c67955071716a7
commit-date: 2020-08-02
host: x86_64-unknown-linux-gnu
release: 1.47.0-nightly
LLVM version: 10.0

Error output

memory allocation of 94396265198519 bytes failed

<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_ASSIGN_START -->

<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"lcnr"}$$TRIAGEBOT_ASSIGN_DATA_END -->

<!-- TRIAGEBOT_ASSIGN_END --> <!-- TRIAGEBOT_END -->

closed time in 6 hours

flowbish

pull request commentrust-lang/rust

forbid `#[track_caller]` on main

:sunny: Test successful - checks-actions, checks-azure Approved by: ecstatic-morse Pushing 32d14eba47ee8bb0b5edb04bcf652517f81c4cf5 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"ecstatic-morse","base_ref":"master","builders":{"checks-azure":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=35800","checks-actions":"https://github.com/rust-lang-ci/rust/runs/947528566"},"merge_sha":"32d14eba47ee8bb0b5edb04bcf652517f81c4cf5"} -->

lcnr

comment created time in 6 hours

pull request commentrust-lang/rust

Rollup of 5 pull requests

:pushpin: Commit 324faf1aacddb9197ea9c1e2296c7102a069513c has been approved by JohnTitor

<!-- @bors r=JohnTitor 324faf1aacddb9197ea9c1e2296c7102a069513c --> <!-- homu: {"type":"Approved","sha":"324faf1aacddb9197ea9c1e2296c7102a069513c","approver":"JohnTitor"} -->

JohnTitor

comment created time in 6 hours

pull request commentrust-lang/rust

New zeroed slice

@amosonn: :key: Insufficient privileges: not in try users

amosonn

comment created time in 7 hours

pull request commentrust-lang/rust

New zeroed slice

@amosonn: :key: Insufficient privileges: not in try users

amosonn

comment created time in 7 hours

push eventrust-lang-ci/rust

bors

commit sha 32d14eba47ee8bb0b5edb04bcf652517f81c4cf5

Auto merge of #75130 - lcnr:array_chunks, r=ecstatic-morse forbid `#[track_caller]` on main fixes #75125 cc @anp

view details

push time in 8 hours

pull request commentrust-lang/rust

forbid `#[track_caller]` on main

:hourglass: Testing commit 9127e27cec22cb130d0a96094196995d72b19030 with merge 32d14eba47ee8bb0b5edb04bcf652517f81c4cf5... <!-- homu: {"type":"BuildStarted","head_sha":"9127e27cec22cb130d0a96094196995d72b19030","merge_sha":"32d14eba47ee8bb0b5edb04bcf652517f81c4cf5"} -->

lcnr

comment created time in 8 hours

pull request commentrust-lang/rust

Rollup of 6 pull requests

:broken_heart: Test failed - checks-actions <!-- homu: {"type":"BuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/947368676","builder_name":"checks-actions"} -->

Manishearth

comment created time in 8 hours

pull request commentrust-lang/rust

manually implement traits for Span

:sunny: Try build successful - checks-actions, checks-azure Build commit: 81c7500e4c3105606180dd88a7c0696c1bdebb36 (81c7500e4c3105606180dd88a7c0696c1bdebb36) <!-- homu: {"type":"TryBuildCompleted","builders":{"checks-azure":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=35798","checks-actions":"https://github.com/rust-lang-ci/rust/runs/947343158"},"merge_sha":"81c7500e4c3105606180dd88a7c0696c1bdebb36"} -->

lcnr

comment created time in 8 hours

pull request commentrust-lang/rust

Completes support for coverage in external crates

@richkadel: :key: Insufficient privileges: not in try users

richkadel

comment created time in 8 hours

push eventrust-lang-ci/rust

Bastian Kauschke

commit sha 06dbd06e4deab2255d310d38ed0ea28becf43664

forbid `#[track_caller]` on main

view details

Ivan Tham

commit sha c577d71e03cebb03d079670e8b9ce995fb79560b

Remove log alias from librustdoc

view details

Guillaume Gomez

commit sha 0275cd74096b71f6c641b06e73e6cb359303d6cc

Clean up E0745

view details

Felix Yan

commit sha 6d75d7c0843dc0f2b64b4427e3290222ef558227

Correct a typo in interpret/memory.rs

view details

Tim Diekmann

commit sha ab9362ad9a9b4b93951ccb577224dda367923226

Replace `Memoryblock` with `NonNull<[u8]>`

view details

Tim Diekmann

commit sha 929e37d4bfb2d6c99094a8a89c5feda47d25bbbe

Revert renaming of "memory block"

view details

Tim Diekmann

commit sha 93d98328d161bcdf002f9d2f7f916f01c6fce3b1

Revert missing "memory block"

view details

Bastian Kauschke

commit sha 9127e27cec22cb130d0a96094196995d72b19030

tweak error message

view details

Eric Huss

commit sha 583133308ba82f4140c3d8b80ead7766d0f86906

Update books

view details

Manish Goregaokar

commit sha 16226c10aa70e50802b9c36644e464c7f01fddf0

Rollup merge of #75130 - lcnr:array_chunks, r=ecstatic-morse forbid `#[track_caller]` on main fixes #75125 cc @anp

view details

Manish Goregaokar

commit sha 82b4f87773edc8ca98160ba09f17c0127f7a8b96

Rollup merge of #75139 - pickfire:librustdoc-import, r=jyn514 Remove log alias from librustdoc r? @jyn514

view details

Manish Goregaokar

commit sha 74f35619de9ce3d3f64a1b8a84f686393ac01acf

Rollup merge of #75140 - GuillaumeGomez:cleanup-e0745, r=pickfire Clean up E0745 r? @Dylan-DPC

view details

Manish Goregaokar

commit sha fdb4a5fccae16bbf25f2a553e5181b52986a76d6

Rollup merge of #75149 - felixonmars:patch-1, r=wesleywiser Correct a typo in interpret/memory.rs

view details

Manish Goregaokar

commit sha c587ba812677378ea4813e1dc545bba2031cf048

Rollup merge of #75152 - TimDiekmann:replace_memblock, r=Amanieu Replace `Memoryblock` with `NonNull<[u8]>` Closes rust-lang/wg-allocators#61 r? @Amanieu

view details

Manish Goregaokar

commit sha 867f7e8da906ebc93ffb109175d69b571ec79880

Rollup merge of #75168 - ehuss:update-books, r=ehuss Update books ## reference 7 commits in b329ce37424874ad4db94f829a55807c6e21d2cb..c9b2736a059469043177e1e4ed41a55d7c63ac28 2020-07-20 08:54:08 -0700 to 2020-08-03 03:34:03 -0700 - Fix documented build output path. (rust-lang-nursery/reference#870) - Update token usage table. (rust-lang-nursery/reference#868) - Allow trait inner attributes (rust-lang-nursery/reference#864) - patterns.md - add word "underscore" to _ paragraph (rust-lang-nursery/reference#865) - Drive-by mention unsafe fn closure coercion (rust-lang-nursery/reference#802) - grammar: Change "For awhile" to "For a while" (rust-lang-nursery/reference#857) - Added Unpin to list of Auto Traits (rust-lang-nursery/reference#854) ## book 7 commits in a914f2c7e5cdb771fa465de142381a51c53b580e..363293c1c5ce9e84ea3935a5e29ce8624801208a 2020-07-21 09:20:05 -0500 to 2020-08-03 15:56:30 -0500 - replace commas with m-dashes to improve readability of chapter 4.1 (rust-lang/book#2419) - Update TOML link to official website (rust-lang/book#2411) - Add github repo link (rust-lang/book#2265) - Remove the version number entirely so we can stop updating it - Add link to the `Vec&lt;T&gt;` API documentation (rust-lang/book#2249) - link to stdlib atomic docs (rust-lang/book#2361) - mdbook version used is now 0.4.x (rust-lang/book#2410) ## rust-by-example 1 commits in 229c6945a26a53a751ffa4f9cb418388c00029d3..2e9271981adc32613365810f3428334c07095215 2020-07-06 10:13:15 -0300 to 2020-07-27 13:39:16 -0500 - Replaced "princess" with "royal" (rust-lang/rust-by-example#1363) ## embedded-book 1 commits in 94d9ea8460bcbbbfef1877b47cb930260b5849a7..b5256448a2a4c1bec68b93c0847066f92f2ff5a9 2020-07-05 14:17:40 +0000 to 2020-07-24 23:09:29 +0000 - Update c-with-rust.md (rust-embedded/book#256)

view details

bors

commit sha 4de50af855fed92f9a77dfc92ba69b9cd53541ff

Auto merge of #75170 - Manishearth:rollup-ucn7dm9, r=Manishearth Rollup of 6 pull requests Successful merges: - #75130 (forbid `#[track_caller]` on main) - #75139 (Remove log alias from librustdoc) - #75140 (Clean up E0745) - #75149 (Correct a typo in interpret/memory.rs) - #75152 (Replace `Memoryblock` with `NonNull<[u8]>`) - #75168 (Update books) Failed merges: r? @ghost

view details

push time in 8 hours

pull request commentrust-lang/rust

Rollup of 6 pull requests

:hourglass: Testing commit 867f7e8da906ebc93ffb109175d69b571ec79880 with merge 4de50af855fed92f9a77dfc92ba69b9cd53541ff... <!-- homu: {"type":"BuildStarted","head_sha":"867f7e8da906ebc93ffb109175d69b571ec79880","merge_sha":"4de50af855fed92f9a77dfc92ba69b9cd53541ff"} -->

Manishearth

comment created time in 8 hours

pull request commentrust-lang/rust

Completes support for coverage in external crates

:broken_heart: Test failed - checks-actions <!-- homu: {"type":"BuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/947281371","builder_name":"checks-actions"} -->

richkadel

comment created time in 8 hours

pull request commentrust-lang/rust

Rollup of 6 pull requests

:pushpin: Commit 867f7e8da906ebc93ffb109175d69b571ec79880 has been approved by Manishearth

<!-- @bors r=Manishearth 867f7e8da906ebc93ffb109175d69b571ec79880 --> <!-- homu: {"type":"Approved","sha":"867f7e8da906ebc93ffb109175d69b571ec79880","approver":"Manishearth"} -->

Manishearth

comment created time in 8 hours

pull request commentrust-lang/rust

Correct a typo in interpret/memory.rs

:pushpin: Commit 6d75d7c0843dc0f2b64b4427e3290222ef558227 has been approved by wesleywiser

<!-- @bors r=wesleywiser 6d75d7c0843dc0f2b64b4427e3290222ef558227 --> <!-- homu: {"type":"Approved","sha":"6d75d7c0843dc0f2b64b4427e3290222ef558227","approver":"wesleywiser"} -->

felixonmars

comment created time in 8 hours

push eventrust-lang-ci/rust

Dan Gohman

commit sha 1a3e4d81406c700d90d6d482163b60c5efc18505

Remove the `--no-threads` workaround for wasm targets. Remove `--no-threads` from the wasm-ld command-line, which was a workaround for [an old bug] which was fixed in LLVM 9.0, and is no longer needed. Also, the `--no-threads` option has been [removed upstream]. [an old bug]: https://bugs.llvm.org/show_bug.cgi?id=41508 [removed upstream]: https://reviews.llvm.org/D76885

view details

Bastian Kauschke

commit sha 747be77500d4dcec1b4904248406592c26383e49

manually implement traits for Span

view details

Bastian Kauschke

commit sha d713815754784abedd597f0c507522f523c62106

structural_eq

view details

Bastian Kauschke

commit sha 78e5db03c12dab72fc410b3b508cdf956a82d2b6

Use newtype for `Span.base_or_index`

view details

Bastian Kauschke

commit sha 0663412b4bbe9f70a701ee800a5fa36fcc578c92

words

view details

Bastian Kauschke

commit sha 365acd0fab9fc344867199baebb0fadc1de9b0a8

add `repr(transparent)` to `SpanBaseOrIndex`

view details

bors

commit sha 07f1fdecfed85fe4be14b293eb913560a6cd60ba

Auto merge of #75161 - sunfishcode:wasm-no-threads, r=alexcrichton Remove the `--no-threads` workaround for wasm targets. Remove `--no-threads` from the wasm-ld command-line, which was a workaround for [an old bug] which was fixed in LLVM 9.0, and is no longer needed. Also, the `--no-threads` option has been [removed upstream]. [an old bug]: https://bugs.llvm.org/show_bug.cgi?id=41508 [removed upstream]: https://reviews.llvm.org/D76885 r? @alexcrichton

view details

bors

commit sha 81c7500e4c3105606180dd88a7c0696c1bdebb36

Auto merge of #75164 - lcnr:span-overwrite, r=<try> manually implement traits for Span `PartialEq::eq` is used a few billion times, so it might be worth it to go the extra mile here. This also changes `base_or_index` to a `newtype_index`, meaning that the 256 highest values are used as a niche, thereby allowing `Option<Span>` to have the same size as `Span`. r? @nnethercote

view details

push time in 9 hours

pull request commentrust-lang/rust

manually implement traits for Span

:hourglass: Trying commit 365acd0fab9fc344867199baebb0fadc1de9b0a8 with merge 81c7500e4c3105606180dd88a7c0696c1bdebb36... <!-- homu: {"type":"TryBuildStarted","head_sha":"365acd0fab9fc344867199baebb0fadc1de9b0a8","merge_sha":"81c7500e4c3105606180dd88a7c0696c1bdebb36"} -->

lcnr

comment created time in 9 hours

pull request commentrust-lang/rust

Update cargo

:pushpin: Commit f6855eacd1544cea34134dfdb7c7f426e5b0442a has been approved by ehuss

<!-- @bors r=ehuss f6855eacd1544cea34134dfdb7c7f426e5b0442a --> <!-- homu: {"type":"Approved","sha":"f6855eacd1544cea34134dfdb7c7f426e5b0442a","approver":"ehuss"} -->

ehuss

comment created time in 9 hours

pull request commentrust-lang/rust

Completes support for coverage in external crates

:hourglass: Testing commit e0dc8dec273b4cba44a91c1b4433e3dcd117919f with merge 92c20f72f8b3bc26a4b007afb030959f01643f68... <!-- homu: {"type":"BuildStarted","head_sha":"e0dc8dec273b4cba44a91c1b4433e3dcd117919f","merge_sha":"92c20f72f8b3bc26a4b007afb030959f01643f68"} -->

richkadel

comment created time in 9 hours

push eventrust-lang-ci/rust

Rich Kadel

commit sha e0dc8dec273b4cba44a91c1b4433e3dcd117919f

Completes support for coverage in external crates The prior PR corrected for errors encountered when trying to generate the coverage map on source code inlined from external crates (including macros and generics) by avoiding adding external DefIds to the coverage map. This made it possible to generate a coverage report including external crates, but the external crate coverage was incomplete (did not include coverage for the DefIds that were eliminated. The root issue was that the coverage map was converting Span locations to source file and locations, using the SourceMap for the current crate, and this would not work for spans from external crates (compliled with a different SourceMap). The solution was to convert the Spans to filename and location during MIR generation instead, so precompiled external crates would already have the correct source code locations embedded in their MIR, when imported into another crate.

view details

bors

commit sha 92c20f72f8b3bc26a4b007afb030959f01643f68

Auto merge of #75037 - richkadel:llvm-coverage-map-gen-5.2, r=wesleywiser Completes support for coverage in external crates Follow-up to #74959 : The prior PR corrected for errors encountered when trying to generate the coverage map on source code inlined from external crates (including macros and generics) by avoiding adding external DefIds to the coverage map. This made it possible to generate a coverage report including external crates, but the external crate coverage was incomplete (did not include coverage for the DefIds that were eliminated. The root issue was that the coverage map was converting Span locations to source file and locations, using the SourceMap for the current crate, and this would not work for spans from external crates (compliled with a different SourceMap). The solution was to convert the Spans to filename and location during MIR generation instead, so precompiled external crates would already have the correct source code locations embedded in their MIR, when imported into another crate. @wesleywiser FYI r? @tmandry

view details

push time in 9 hours

PR merged rust-lang/rust

Remove the `--no-threads` workaround for wasm targets. S-waiting-on-bors merged-by-bors

Remove --no-threads from the wasm-ld command-line, which was a workaround for an old bug which was fixed in LLVM 9.0, and is no longer needed.

Also, the --no-threads option has been removed upstream.

r? @alexcrichton

+0 -7

4 comments

1 changed file

sunfishcode

pr closed time in 9 hours

push eventrust-lang/rust

Dan Gohman

commit sha 1a3e4d81406c700d90d6d482163b60c5efc18505

Remove the `--no-threads` workaround for wasm targets. Remove `--no-threads` from the wasm-ld command-line, which was a workaround for [an old bug] which was fixed in LLVM 9.0, and is no longer needed. Also, the `--no-threads` option has been [removed upstream]. [an old bug]: https://bugs.llvm.org/show_bug.cgi?id=41508 [removed upstream]: https://reviews.llvm.org/D76885

view details

bors

commit sha 07f1fdecfed85fe4be14b293eb913560a6cd60ba

Auto merge of #75161 - sunfishcode:wasm-no-threads, r=alexcrichton Remove the `--no-threads` workaround for wasm targets. Remove `--no-threads` from the wasm-ld command-line, which was a workaround for [an old bug] which was fixed in LLVM 9.0, and is no longer needed. Also, the `--no-threads` option has been [removed upstream]. [an old bug]: https://bugs.llvm.org/show_bug.cgi?id=41508 [removed upstream]: https://reviews.llvm.org/D76885 r? @alexcrichton

view details

push time in 9 hours

push eventrust-lang-ci/rust

Dan Gohman

commit sha 1a3e4d81406c700d90d6d482163b60c5efc18505

Remove the `--no-threads` workaround for wasm targets. Remove `--no-threads` from the wasm-ld command-line, which was a workaround for [an old bug] which was fixed in LLVM 9.0, and is no longer needed. Also, the `--no-threads` option has been [removed upstream]. [an old bug]: https://bugs.llvm.org/show_bug.cgi?id=41508 [removed upstream]: https://reviews.llvm.org/D76885

view details

bors

commit sha 07f1fdecfed85fe4be14b293eb913560a6cd60ba

Auto merge of #75161 - sunfishcode:wasm-no-threads, r=alexcrichton Remove the `--no-threads` workaround for wasm targets. Remove `--no-threads` from the wasm-ld command-line, which was a workaround for [an old bug] which was fixed in LLVM 9.0, and is no longer needed. Also, the `--no-threads` option has been [removed upstream]. [an old bug]: https://bugs.llvm.org/show_bug.cgi?id=41508 [removed upstream]: https://reviews.llvm.org/D76885 r? @alexcrichton

view details

push time in 9 hours

pull request commentrust-lang/rust

Remove the `--no-threads` workaround for wasm targets.

:sunny: Test successful - checks-actions, checks-azure Approved by: alexcrichton Pushing 07f1fdecfed85fe4be14b293eb913560a6cd60ba to master... <!-- homu: {"type":"BuildCompleted","approved_by":"alexcrichton","base_ref":"master","builders":{"checks-azure":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=35796","checks-actions":"https://github.com/rust-lang-ci/rust/runs/947120822"},"merge_sha":"07f1fdecfed85fe4be14b293eb913560a6cd60ba"} -->

sunfishcode

comment created time in 9 hours

pull request commentrust-lang/rust

Update books

:pushpin: Commit 583133308ba82f4140c3d8b80ead7766d0f86906 has been approved by ehuss

<!-- @bors r=ehuss 583133308ba82f4140c3d8b80ead7766d0f86906 --> <!-- homu: {"type":"Approved","sha":"583133308ba82f4140c3d8b80ead7766d0f86906","approver":"ehuss"} -->

ehuss

comment created time in 9 hours

PR merged rust-lang/cargo

Fix close_output test. S-waiting-on-bors

The close_output test was randomly failing on rust-lang/rust's CI. This should fix the error. I ran the test in a loop on the rust-lang 16-thread CPU for 10,000 times over the course of 1.5 hours without fail. The same stress test without this patch failed relatively easily.

I'm a bit on the fence, as this means the test is no longer testing a realistic scenario (the compiler usually doesn't emit a megabyte of diagnostics). Moving this test to a single-threaded runner should also solve the problem. I can't decide if it matters enough to bother. WDYT?

Closes #8564

+14 -3

7 comments

1 changed file

ehuss

pr closed time in 9 hours

push eventrust-lang/cargo

Eric Huss

commit sha 191250b910154e7aa6aefa029007cc1b1d2ec4d8

Fix close_output test.

view details

bors

commit sha 1653f354644834073d6d2541e27fae94588e685e

Auto merge of #8587 - ehuss:close_output-fix, r=alexcrichton Fix close_output test. The close_output test was randomly failing on rust-lang/rust's CI. This should fix the error. I ran the test in a loop on the rust-lang 16-thread CPU for 10,000 times over the course of 1.5 hours without fail. The same stress test without this patch failed relatively easily. I'm a bit on the fence, as this means the test is no longer testing a realistic scenario (the compiler usually doesn't emit a megabyte of diagnostics). Moving this test to a single-threaded runner should also solve the problem. I can't decide if it matters enough to bother. WDYT? Closes #8564

view details

push time in 9 hours

issue closedrust-lang/cargo

close_output test is randomly failing

TLDR: Should we run some flaky tests single-threaded? (Nope)

The build::close_output test is randomly failing on CI. There were some fixes applied in #8286 in May 26, but there appears to be more recent failures:

https://github.com/rust-lang/rust/pull/74312#issuecomment-657964827 https://github.com/rust-lang/rust/pull/74408#issuecomment-659603027 https://github.com/rust-lang/rust/pull/74908#issuecomment-665912840 https://github.com/rust-lang/rust/pull/74923 (https://github.com/rust-lang-ci/rust/runs/924743383)

The failure is:

---- build::close_output stdout ----
thread 'build::close_output' panicked at 'assertion failed: !status.success()', src/tools/cargo/tests/testsuite/build.rs:5016:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I am uncertain how this is possible, so maybe someone could double check that what I wrote makes sense. The test covers what happens when stdout or stderr is closed in the middle of the build. It uses a proc-macro as a sync point so that the test can know when compilation has started, and to emit data to stdout or stderr during the build. It should follow this sequence:

  1. Starts a TCP server.
  2. Starts the build.
  3. The proc-macro starts building.
  4. The proc-macro connects to the TCP server, and waits for the test to tell it it is OK to continue.
  5. Test receives connection from proc-macro
  6. Test closes stdout.
  7. Test tells proc-macro to continue.
  8. Proc-macro starts spewing stuff to stdout to cargo, which through the internal job queue ends up attempting to write to stdout. Since stdout was closed in step 6, this should fail.
  9. Cargo should exit with an error after rustc is done.

For some reason, at step 8, it successfully writes to stdout, and step 9 returns success.

I've been doing a few tests, and it gets worse based on the number of concurrent tests running. When run single threaded, I cannot get it to fail (even with the system under heavy load).

I'm feeling this is somewhat related to #7858. Is there still a race condition, even with atomic O_CLOEXEC? That is, AIUI, the file descriptors are still inherited across fork, and only closed when exec is called. If so, then there is a small window where the file descriptors have extra duplicates which prevent them from fully closing immediately.

I'm thinking a simple solution would be to isolate these tests into a separate test executable which runs with --test-threads=1 (or maybe a simple no-harness test?). This should prevent concurrent tests from interfering with one another. The downside is that this makes it more cumbersome to run all of the test suite. (Testing shows this probably won't fix this test.)

closed time in 9 hours

ehuss

pull request commentrust-lang/cargo

Fix close_output test.

:sunny: Test successful - checks-actions Approved by: alexcrichton Pushing 1653f354644834073d6d2541e27fae94588e685e to master... <!-- homu: {"type":"BuildCompleted","approved_by":"alexcrichton","base_ref":"master","builders":{"checks-actions":"https://github.com/rust-lang/cargo/runs/947124528"},"merge_sha":"1653f354644834073d6d2541e27fae94588e685e"} -->

ehuss

comment created time in 9 hours

PR merged rust-lang/rust-clippy

Remove obsolete known problems unnecessary_fold S-waiting-on-review

The known problems looks to be obsolete since NLL is stable.

changelog: none

+1 -2

5 comments

1 changed file

camsteffen

pr closed time in 9 hours

push eventrust-lang/rust-clippy

Cameron Steffen

commit sha 0ccdf2913a335c4f0b34098f84baeeb3fc852255

Remove obsolete known problems unnecessary_fold

view details

bors

commit sha 2ceb8c6c2d029f01f7656d02e59b2d69187875c4

Auto merge of #5865 - camsteffen:unnecessary-fold-known-probs, r=Manishearth Remove obsolete known problems unnecessary_fold The known problems looks to be obsolete since NLL is stable. changelog: none

view details

push time in 9 hours

pull request commentrust-lang/rust-clippy

Remove obsolete known problems unnecessary_fold

:sunny: Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test Approved by: Manishearth Pushing 2ceb8c6c2d029f01f7656d02e59b2d69187875c4 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"Manishearth","base_ref":"master","builders":{"checks-action_test":"https://github.com/rust-lang/rust-clippy/runs/947100913","checks-action_dev_test":"https://github.com/rust-lang/rust-clippy/runs/947055144","checks-action_remark_test":"https://github.com/rust-lang/rust-clippy/runs/947053092"},"merge_sha":"2ceb8c6c2d029f01f7656d02e59b2d69187875c4"} -->

camsteffen

comment created time in 9 hours

pull request commentrust-lang/rust

Completes support for coverage in external crates

:pushpin: Commit e0dc8dec273b4cba44a91c1b4433e3dcd117919f has been approved by wesleywiser

<!-- @bors r=wesleywiser e0dc8dec273b4cba44a91c1b4433e3dcd117919f --> <!-- homu: {"type":"Approved","sha":"e0dc8dec273b4cba44a91c1b4433e3dcd117919f","approver":"wesleywiser"} -->

richkadel

comment created time in 10 hours

pull request commentrust-lang/rust

Completes support for coverage in external crates

:bulb: This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: #75161
richkadel

comment created time in 10 hours

push eventrust-lang/cargo

Eric Huss

commit sha 191250b910154e7aa6aefa029007cc1b1d2ec4d8

Fix close_output test.

view details

bors

commit sha 1653f354644834073d6d2541e27fae94588e685e

Auto merge of #8587 - ehuss:close_output-fix, r=alexcrichton Fix close_output test. The close_output test was randomly failing on rust-lang/rust's CI. This should fix the error. I ran the test in a loop on the rust-lang 16-thread CPU for 10,000 times over the course of 1.5 hours without fail. The same stress test without this patch failed relatively easily. I'm a bit on the fence, as this means the test is no longer testing a realistic scenario (the compiler usually doesn't emit a megabyte of diagnostics). Moving this test to a single-threaded runner should also solve the problem. I can't decide if it matters enough to bother. WDYT? Closes #8564

view details

push time in 10 hours

pull request commentrust-lang/cargo

Fix close_output test.

:hourglass: Testing commit 191250b910154e7aa6aefa029007cc1b1d2ec4d8 with merge 1653f354644834073d6d2541e27fae94588e685e... <!-- homu: {"type":"BuildStarted","head_sha":"191250b910154e7aa6aefa029007cc1b1d2ec4d8","merge_sha":"1653f354644834073d6d2541e27fae94588e685e"} -->

ehuss

comment created time in 10 hours

pull request commentrust-lang/cargo

Fix close_output test.

:pushpin: Commit 191250b910154e7aa6aefa029007cc1b1d2ec4d8 has been approved by alexcrichton

<!-- @bors r=alexcrichton 191250b910154e7aa6aefa029007cc1b1d2ec4d8 --> <!-- homu: {"type":"Approved","sha":"191250b910154e7aa6aefa029007cc1b1d2ec4d8","approver":"alexcrichton"} -->

ehuss

comment created time in 10 hours

push eventrust-lang/rust-clippy

Cameron Steffen

commit sha 0ccdf2913a335c4f0b34098f84baeeb3fc852255

Remove obsolete known problems unnecessary_fold

view details

bors

commit sha 2ceb8c6c2d029f01f7656d02e59b2d69187875c4

Auto merge of #5865 - camsteffen:unnecessary-fold-known-probs, r=Manishearth Remove obsolete known problems unnecessary_fold The known problems looks to be obsolete since NLL is stable. changelog: none

view details

push time in 10 hours

pull request commentrust-lang/rust-clippy

Remove obsolete known problems unnecessary_fold

:hourglass: Testing commit 0ccdf2913a335c4f0b34098f84baeeb3fc852255 with merge 2ceb8c6c2d029f01f7656d02e59b2d69187875c4... <!-- homu: {"type":"BuildStarted","head_sha":"0ccdf2913a335c4f0b34098f84baeeb3fc852255","merge_sha":"2ceb8c6c2d029f01f7656d02e59b2d69187875c4"} -->

camsteffen

comment created time in 10 hours

pull request commentrust-lang/rust-clippy

Remove obsolete known problems unnecessary_fold

:pushpin: Commit 0ccdf2913a335c4f0b34098f84baeeb3fc852255 has been approved by Manishearth

<!-- @bors r=Manishearth 0ccdf2913a335c4f0b34098f84baeeb3fc852255 --> <!-- homu: {"type":"Approved","sha":"0ccdf2913a335c4f0b34098f84baeeb3fc852255","approver":"Manishearth"} -->

camsteffen

comment created time in 10 hours

pull request commentrust-lang/rust

Upgrade to LLVM 11 (rc1)

:sunny: Try build successful - checks-actions, checks-azure Build commit: d76f848d4c1ae4a85aa13749907856758b9ae769 (d76f848d4c1ae4a85aa13749907856758b9ae769) <!-- homu: {"type":"TryBuildCompleted","builders":{"checks-azure":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=35791","checks-actions":"https://github.com/rust-lang-ci/rust/runs/946972023"},"merge_sha":"d76f848d4c1ae4a85aa13749907856758b9ae769"} -->

cuviper

comment created time in 10 hours

push eventrust-lang-ci/rust

Dan Gohman

commit sha 1a3e4d81406c700d90d6d482163b60c5efc18505

Remove the `--no-threads` workaround for wasm targets. Remove `--no-threads` from the wasm-ld command-line, which was a workaround for [an old bug] which was fixed in LLVM 9.0, and is no longer needed. Also, the `--no-threads` option has been [removed upstream]. [an old bug]: https://bugs.llvm.org/show_bug.cgi?id=41508 [removed upstream]: https://reviews.llvm.org/D76885

view details

bors

commit sha 07f1fdecfed85fe4be14b293eb913560a6cd60ba

Auto merge of #75161 - sunfishcode:wasm-no-threads, r=alexcrichton Remove the `--no-threads` workaround for wasm targets. Remove `--no-threads` from the wasm-ld command-line, which was a workaround for [an old bug] which was fixed in LLVM 9.0, and is no longer needed. Also, the `--no-threads` option has been [removed upstream]. [an old bug]: https://bugs.llvm.org/show_bug.cgi?id=41508 [removed upstream]: https://reviews.llvm.org/D76885 r? @alexcrichton

view details

push time in 11 hours

pull request commentrust-lang/rust

Remove the `--no-threads` workaround for wasm targets.

:hourglass: Testing commit 1a3e4d81406c700d90d6d482163b60c5efc18505 with merge 07f1fdecfed85fe4be14b293eb913560a6cd60ba... <!-- homu: {"type":"BuildStarted","head_sha":"1a3e4d81406c700d90d6d482163b60c5efc18505","merge_sha":"07f1fdecfed85fe4be14b293eb913560a6cd60ba"} -->

sunfishcode

comment created time in 11 hours

pull request commentrust-lang/rust

Prevent `__rust_begin_short_backtrace` frames from being tail-call optimised away

:broken_heart: Test failed - checks-actions <!-- homu: {"type":"BuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/946924997","builder_name":"checks-actions"} -->

eggyal

comment created time in 11 hours

push eventrust-lang-ci/rust

Alan Egerton

commit sha 18d4ba34907e7d0b9fc142a9d9a9c5bbdae4279f

Prevent `__rust_begin_short_backtrace` frames from being tail-call optimised away

view details

bors

commit sha c70a4d6c76d010b569fa4d16b2ffb7eced04bc52

Auto merge of #75048 - eggyal:force-no-tco-start-backtrace-frame, r=Mark-Simulacrum Prevent `__rust_begin_short_backtrace` frames from being tail-call optimised away I've stumbled across some situations where there (unexpectedly) was no `__rust_begin_short_backtrace` frame on the stack during unwinding. On closer examination, it appeared that the calls to that function had been tail-call optimised away. This PR follows [@bjorn3's suggestion on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Disabling.20tail.20call.20optimisation.3F/near/205699133), by adding calls to `black_box` that hint to rustc not to perform TCO. Fixes #47429

view details

push time in 11 hours

pull request commentrust-lang/rust

Prevent `__rust_begin_short_backtrace` frames from being tail-call optimised away

:hourglass: Testing commit 18d4ba34907e7d0b9fc142a9d9a9c5bbdae4279f with merge c70a4d6c76d010b569fa4d16b2ffb7eced04bc52... <!-- homu: {"type":"BuildStarted","head_sha":"18d4ba34907e7d0b9fc142a9d9a9c5bbdae4279f","merge_sha":"c70a4d6c76d010b569fa4d16b2ffb7eced04bc52"} -->

eggyal

comment created time in 11 hours

pull request commentrust-lang/rust

Replace `Memoryblock` with `NonNull<[u8]>`

:broken_heart: Test failed - checks-actions <!-- homu: {"type":"BuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/946842420","builder_name":"checks-actions"} -->

TimDiekmann

comment created time in 11 hours

push eventrust-lang-ci/rust

Tim Diekmann

commit sha ab9362ad9a9b4b93951ccb577224dda367923226

Replace `Memoryblock` with `NonNull<[u8]>`

view details

Tim Diekmann

commit sha 929e37d4bfb2d6c99094a8a89c5feda47d25bbbe

Revert renaming of "memory block"

view details

Tim Diekmann

commit sha 93d98328d161bcdf002f9d2f7f916f01c6fce3b1

Revert missing "memory block"

view details

bors

commit sha 8d188d8fa7066ffe69511440d73ea6099eaefaf4

Auto merge of #75152 - TimDiekmann:replace_memblock, r=Amanieu Replace `Memoryblock` with `NonNull<[u8]>` Closes rust-lang/wg-allocators#61 r? @Amanieu

view details

push time in 11 hours

pull request commentrust-lang/rust

Replace `Memoryblock` with `NonNull<[u8]>`

:hourglass: Testing commit 93d98328d161bcdf002f9d2f7f916f01c6fce3b1 with merge 8d188d8fa7066ffe69511440d73ea6099eaefaf4... <!-- homu: {"type":"BuildStarted","head_sha":"93d98328d161bcdf002f9d2f7f916f01c6fce3b1","merge_sha":"8d188d8fa7066ffe69511440d73ea6099eaefaf4"} -->

TimDiekmann

comment created time in 11 hours

pull request commentrust-lang/rust

forbid `#[track_caller]` on main

:broken_heart: Test failed - checks-actions <!-- homu: {"type":"BuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/946827023","builder_name":"checks-actions"} -->

lcnr

comment created time in 11 hours

push eventrust-lang-ci/rust

Bastian Kauschke

commit sha 06dbd06e4deab2255d310d38ed0ea28becf43664

forbid `#[track_caller]` on main

view details

Bastian Kauschke

commit sha 9127e27cec22cb130d0a96094196995d72b19030

tweak error message

view details

bors

commit sha 30e5c68e6961f49f14deb5e53d3d3a5d8e500842

Auto merge of #75130 - lcnr:array_chunks, r=ecstatic-morse forbid `#[track_caller]` on main fixes #75125 cc @anp

view details

push time in 11 hours

pull request commentrust-lang/rust

forbid `#[track_caller]` on main

:hourglass: Testing commit 9127e27cec22cb130d0a96094196995d72b19030 with merge 30e5c68e6961f49f14deb5e53d3d3a5d8e500842... <!-- homu: {"type":"BuildStarted","head_sha":"9127e27cec22cb130d0a96094196995d72b19030","merge_sha":"30e5c68e6961f49f14deb5e53d3d3a5d8e500842"} -->

lcnr

comment created time in 11 hours

pull request commentrust-lang/rust

Completes support for coverage in external crates

:broken_heart: Test failed - checks-actions <!-- homu: {"type":"BuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/946810107","builder_name":"checks-actions"} -->

richkadel

comment created time in 11 hours

pull request commentrust-lang/rust

Completes support for coverage in external crates

:hourglass: Testing commit e0dc8dec273b4cba44a91c1b4433e3dcd117919f with merge 118a0185f14f7936c3edb16044cf2b903dce4963... <!-- homu: {"type":"BuildStarted","head_sha":"e0dc8dec273b4cba44a91c1b4433e3dcd117919f","merge_sha":"118a0185f14f7936c3edb16044cf2b903dce4963"} -->

richkadel

comment created time in 11 hours

push eventrust-lang-ci/rust

Rich Kadel

commit sha e0dc8dec273b4cba44a91c1b4433e3dcd117919f

Completes support for coverage in external crates The prior PR corrected for errors encountered when trying to generate the coverage map on source code inlined from external crates (including macros and generics) by avoiding adding external DefIds to the coverage map. This made it possible to generate a coverage report including external crates, but the external crate coverage was incomplete (did not include coverage for the DefIds that were eliminated. The root issue was that the coverage map was converting Span locations to source file and locations, using the SourceMap for the current crate, and this would not work for spans from external crates (compliled with a different SourceMap). The solution was to convert the Spans to filename and location during MIR generation instead, so precompiled external crates would already have the correct source code locations embedded in their MIR, when imported into another crate.

view details

bors

commit sha 118a0185f14f7936c3edb16044cf2b903dce4963

Auto merge of #75037 - richkadel:llvm-coverage-map-gen-5.2, r=wesleywiser Completes support for coverage in external crates Follow-up to #74959 : The prior PR corrected for errors encountered when trying to generate the coverage map on source code inlined from external crates (including macros and generics) by avoiding adding external DefIds to the coverage map. This made it possible to generate a coverage report including external crates, but the external crate coverage was incomplete (did not include coverage for the DefIds that were eliminated. The root issue was that the coverage map was converting Span locations to source file and locations, using the SourceMap for the current crate, and this would not work for spans from external crates (compliled with a different SourceMap). The solution was to convert the Spans to filename and location during MIR generation instead, so precompiled external crates would already have the correct source code locations embedded in their MIR, when imported into another crate. @wesleywiser FYI r? @tmandry

view details

push time in 11 hours

pull request commentrust-lang/rust

Prevent `__rust_begin_short_backtrace` frames from being tail-call optimised away

:broken_heart: Test failed - checks-actions <!-- homu: {"type":"BuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/946796061","builder_name":"checks-actions"} -->

eggyal

comment created time in 11 hours

pull request commentrust-lang/rust

Upgrade to LLVM 11 (rc1)

:hourglass: Trying commit 632ce974857d7f93c0b658282a9ba9d3da1d06bc with merge d76f848d4c1ae4a85aa13749907856758b9ae769... <!-- homu: {"type":"TryBuildStarted","head_sha":"632ce974857d7f93c0b658282a9ba9d3da1d06bc","merge_sha":"d76f848d4c1ae4a85aa13749907856758b9ae769"} -->

cuviper

comment created time in 11 hours

push eventrust-lang-ci/rust

Josh Stone

commit sha 211888ba2d17f49b0ec60991d3c9079a290a3137

Don't make clang use gcc's include-fixed This was breaking `#include_next <limits.h>`, such that we weren't getting definitions of `PATH_MAX` and `_POSIX_ARG_MAX`.

view details

Josh Stone

commit sha 93915944f1e2ff3f83f2246fd29a4e568a809ed0

Upgrade to LLVM 11 (rc1)

view details

Yuki Okushi

commit sha cd7204ef394d1e53bb967086186e9b8664d7e268

Forbid non-derefable types explicitly in unsizing casts

view details

bors

commit sha f9d422ea78a4652c5d9ecd6b6d7577bdfbfd98a8

Auto merge of #75136 - JohnTitor:unsizing-casts-non-null, r=oli-obk Forbid non-derefable types explicitly in unsizing casts Fixes #75118 r? @oli-obk

view details

Josh Stone

commit sha 632ce974857d7f93c0b658282a9ba9d3da1d06bc

[DO NOT MERGE] test a fix for i686-mingw

view details

bors

commit sha d76f848d4c1ae4a85aa13749907856758b9ae769

Auto merge of #73526 - cuviper:rust-llvm11, r=<try> Upgrade to LLVM 11 (rc1) This builds on #73525 to try actually moving rust-lang/llvm-project to LLVM 11.

view details

push time in 11 hours

pull request commentrust-lang/rust

Prevent `__rust_begin_short_backtrace` frames from being tail-call optimised away

:hourglass: Testing commit 18d4ba34907e7d0b9fc142a9d9a9c5bbdae4279f with merge cca2c20c8b6cd0a71346bf7f85feb3c6291bd60d... <!-- homu: {"type":"BuildStarted","head_sha":"18d4ba34907e7d0b9fc142a9d9a9c5bbdae4279f","merge_sha":"cca2c20c8b6cd0a71346bf7f85feb3c6291bd60d"} -->

eggyal

comment created time in 11 hours

push eventrust-lang-ci/rust

Alan Egerton

commit sha 18d4ba34907e7d0b9fc142a9d9a9c5bbdae4279f

Prevent `__rust_begin_short_backtrace` frames from being tail-call optimised away

view details

bors

commit sha cca2c20c8b6cd0a71346bf7f85feb3c6291bd60d

Auto merge of #75048 - eggyal:force-no-tco-start-backtrace-frame, r=Mark-Simulacrum Prevent `__rust_begin_short_backtrace` frames from being tail-call optimised away I've stumbled across some situations where there (unexpectedly) was no `__rust_begin_short_backtrace` frame on the stack during unwinding. On closer examination, it appeared that the calls to that function had been tail-call optimised away. This PR follows [@bjorn3's suggestion on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Disabling.20tail.20call.20optimisation.3F/near/205699133), by adding calls to `black_box` that hint to rustc not to perform TCO. Fixes #47429

view details

push time in 11 hours

PR merged rust-lang/rust

Forbid non-derefable types explicitly in unsizing casts S-waiting-on-bors merged-by-bors

Fixes #75118 r? @oli-obk

+31 -1

9 comments

3 changed files

JohnTitor

pr closed time in 11 hours

push eventrust-lang/rust

Yuki Okushi

commit sha cd7204ef394d1e53bb967086186e9b8664d7e268

Forbid non-derefable types explicitly in unsizing casts

view details

bors

commit sha f9d422ea78a4652c5d9ecd6b6d7577bdfbfd98a8

Auto merge of #75136 - JohnTitor:unsizing-casts-non-null, r=oli-obk Forbid non-derefable types explicitly in unsizing casts Fixes #75118 r? @oli-obk

view details

push time in 11 hours

issue closedrust-lang/rust

ICE when coercing `NonNull<[T; 0]>` to `NonNull<[T]>` in const fn

Code

use core::ptr::NonNull;

pub const fn dangling_slice<T>() -> NonNull<[T]> {
    NonNull::<[T; 0]>::dangling()
}

Meta

rustc --version --verbose:

1.46.0-beta.2

(2020-07-23 6f959902b3103c49ca98)

Error output

   Compiling playground v0.0.1 (/playground)
thread 'rustc' panicked at 'called `Option::unwrap()` on a `None` value', src/librustc_mir/transform/qualify_min_const_fn.rs:196:58
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.46.0-beta.2 (6f959902b 2020-07-23) running on x86_64-unknown-linux-gnu

note: compiler flags: -C embed-bitcode=no -C codegen-units=1 -C debuginfo=2 --crate-type lib

note: some of the compiler flags provided by cargo are hidden

error: could not compile `playground`.

To learn more, run the command again with --verbose.

<!-- Include a backtrace in the code block by setting RUST_BACKTRACE=1 in your environment. E.g. RUST_BACKTRACE=1 cargo build. --> <details><summary><strong>Backtrace</strong></summary> <p>

thread 'rustc' panicked at 'called `Option::unwrap()` on a `None` value', src/librustc_mir/transform/qualify_min_const_fn.rs:196:58
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print_fmt
             at src/libstd/sys_common/backtrace.rs:78
   3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
             at src/libstd/sys_common/backtrace.rs:59
   4: core::fmt::write
             at src/libcore/fmt/mod.rs:1076
   5: std::io::Write::write_fmt
             at src/libstd/io/mod.rs:1537
   6: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:62
   7: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:49
   8: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:198
   9: std::panicking::default_hook
             at src/libstd/panicking.rs:217
  10: rustc_driver::report_ice
  11: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:530
  12: rust_begin_unwind
             at src/libstd/panicking.rs:437
  13: core::panicking::panic_fmt
             at src/libcore/panicking.rs:85
  14: core::panicking::panic
             at src/libcore/panicking.rs:50
  15: rustc_mir::transform::qualify_min_const_fn::is_min_const_fn
  16: rustc_mir::transform::check_consts::validation::Validator::check_body
  17: rustc_mir::transform::mir_const_qualif
  18: rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::mir_const_qualif>::compute
  19: rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl
  20: rustc_data_structures::stack::ensure_sufficient_stack
  21: rustc_query_system::query::plumbing::get_query_impl
  22: rustc_mir::transform::mir_validated
  23: rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::mir_validated>::compute
  24: rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl
  25: rustc_data_structures::stack::ensure_sufficient_stack
  26: rustc_query_system::query::plumbing::get_query_impl
  27: rustc_mir::borrow_check::mir_borrowck
  28: rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::mir_borrowck>::compute
  29: rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl
  30: rustc_data_structures::stack::ensure_sufficient_stack
  31: rustc_query_system::query::plumbing::get_query_impl
  32: rustc_query_system::query::plumbing::ensure_query_impl
  33: rustc_session::utils::<impl rustc_session::session::Session>::time
  34: rustc_interface::passes::analysis
  35: rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::analysis>::compute
  36: rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl
  37: rustc_query_system::query::plumbing::get_query_impl
  38: rustc_middle::ty::context::tls::enter_global
  39: rustc_interface::queries::<impl rustc_interface::interface::Compiler>::enter
  40: rustc_span::with_source_map
  41: rustc_interface::interface::create_compiler_and_run
  42: scoped_tls::ScopedKey<T>::set
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.46.0-beta.2 (6f959902b 2020-07-23) running on x86_64-unknown-linux-gnu

note: compiler flags: -C embed-bitcode=no -C codegen-units=1 -C debuginfo=2 --crate-type lib

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
#0 [mir_const_qualif] const checking `dangling`
#1 [mir_validated] processing `dangling`
#2 [mir_borrowck] borrow-checking `dangling`
#3 [analysis] running analysis passes on this crate
end of query stack
error: could not compile `playground`.

To learn more, run the command again with --verbose.

</p> </details>

closed time in 11 hours

rodrimati1992

push eventrust-lang-ci/rust

Yuki Okushi

commit sha cd7204ef394d1e53bb967086186e9b8664d7e268

Forbid non-derefable types explicitly in unsizing casts

view details

bors

commit sha f9d422ea78a4652c5d9ecd6b6d7577bdfbfd98a8

Auto merge of #75136 - JohnTitor:unsizing-casts-non-null, r=oli-obk Forbid non-derefable types explicitly in unsizing casts Fixes #75118 r? @oli-obk

view details

push time in 11 hours

pull request commentrust-lang/rust

Forbid non-derefable types explicitly in unsizing casts

:sunny: Test successful - checks-actions, checks-azure Approved by: oli-obk Pushing f9d422ea78a4652c5d9ecd6b6d7577bdfbfd98a8 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"oli-obk","base_ref":"master","builders":{"checks-azure":"https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=35788","checks-actions":"https://github.com/rust-lang-ci/rust/runs/946652502"},"merge_sha":"f9d422ea78a4652c5d9ecd6b6d7577bdfbfd98a8"} -->

JohnTitor

comment created time in 11 hours

pull request commentrust-lang/rust

Prevent `__rust_begin_short_backtrace` frames from being tail-call optimised away

:pushpin: Commit 18d4ba34907e7d0b9fc142a9d9a9c5bbdae4279f has been approved by Mark-Simulacrum

<!-- @bors r=Mark-Simulacrum 18d4ba34907e7d0b9fc142a9d9a9c5bbdae4279f --> <!-- homu: {"type":"Approved","sha":"18d4ba34907e7d0b9fc142a9d9a9c5bbdae4279f","approver":"Mark-Simulacrum"} -->

eggyal

comment created time in 12 hours

pull request commentrust-lang/rust

Completes support for coverage in external crates

:pushpin: Commit e0dc8dec273b4cba44a91c1b4433e3dcd117919f has been approved by wesleywiser

<!-- @bors r=wesleywiser e0dc8dec273b4cba44a91c1b4433e3dcd117919f --> <!-- homu: {"type":"Approved","sha":"e0dc8dec273b4cba44a91c1b4433e3dcd117919f","approver":"wesleywiser"} -->

richkadel

comment created time in 12 hours

push eventrust-lang-ci/rust

Nicholas Nethercote

commit sha eeb4b83289e09956e0dda174047729ca87c709fe

Remove two fields from `SubstFolder`. They're only used in error messages printed if there's an internal compiler error, and the cost of maintaining them is high enough to show up in profiles.

view details

bors

commit sha d08eb98698cbce56e599324fb83d55eef2cac408

Auto merge of #75133 - nnethercote:rm-SubstFolder-fields, r=matthewjasper Remove two fields from `SubstFolder`. They're only used in error messages printed if there's an internal compiler error, and the cost of maintaining them is high enough to show up in profiles. r? @matthewjasper

view details

Bastian Kauschke

commit sha 747be77500d4dcec1b4904248406592c26383e49

manually implement traits for Span

view details

Bastian Kauschke

commit sha d713815754784abedd597f0c507522f523c62106

structural_eq

view details

bors

commit sha 9c509a323b82b57aae17bc2a2060471600a0307f

Auto merge of #75164 - lcnr:span-overwrite, r=<try> manually implement traits for Span `PartialEq::eq` is used a few billion times, so it might be worth it to go the extra mile here. r? @nnethercote

view details

push time in 12 hours

more