profile
viewpoint
bokuweb bokuweb Japan https://medium.com/@bokuweb17 Embedded Hardware Engineer / Web Frontend Engineer

delete branch bokuweb/node-lcs-img-diff

delete branch : dependabot/npm_and_yarn/js-yaml-3.13.1

delete time in 13 hours

push eventbokuweb/node-lcs-img-diff

dependabot[bot]

commit sha 10caca4dfb11057e135bc7d72ddd1bd1fca0cac1

Bump js-yaml from 3.12.0 to 3.13.1 Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.12.0 to 3.13.1. - [Release notes](https://github.com/nodeca/js-yaml/releases) - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](https://github.com/nodeca/js-yaml/compare/3.12.0...3.13.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

bokuweb

commit sha 17b112737d975905da837e1e09c7fee1f905e86f

Merge pull request #2 from bokuweb/dependabot/npm_and_yarn/js-yaml-3.13.1 Bump js-yaml from 3.12.0 to 3.13.1

view details

push time in 13 hours

PR merged bokuweb/node-lcs-img-diff

Bump js-yaml from 3.12.0 to 3.13.1 dependencies

Bumps js-yaml from 3.12.0 to 3.13.1. <details> <summary>Changelog</summary>

Sourced from js-yaml's changelog.

3.13.1 / 2019-04-05

  • Fix possible code execution in (already unsafe) .load(), #480.

3.13.0 / 2019-03-20

  • Security fix: safeLoad() can hang when arrays with nested refs used as key. Now throws exception for nested arrays. #475.

3.12.2 / 2019-02-26

  • Fix noArrayIndent option for root level, #468.

3.12.1 / 2019-01-05

  • Added noArrayIndent option, #432. </details> <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 13 hours

push eventbokuweb/node-lcs-img-diff

bokuweb

commit sha 4647d028ef0ac17e9323d3af22dd7c4650c2d5b0

Update config.yml

view details

push time in 13 hours

push eventbokuweb/node-lcs-img-diff

bokuweb

commit sha 89e631b5f6c61da6f99c59c20ba7fd70361d925d

Update config.yml

view details

push time in 13 hours

push eventbokuweb/node-lcs-img-diff

bokuweb

commit sha 0efabc2ae3247ce24a58434ecedf4e9c38b7a7fa

Update config.yml

view details

push time in 13 hours

push eventbokuweb/node-lcs-img-diff

bokuweb

commit sha aa89e8b131124794acbc2cecffc5f097673ca7fc

Update config.yml

view details

push time in 13 hours

push eventbokuweb/node-lcs-img-diff

bokuweb

commit sha cd8b2d3008caaa5c7c253ebd911b8cf3ef2ed1f5

Update config.yml

view details

push time in 14 hours

push eventbokuweb/node-lcs-img-diff

bokuweb

commit sha 0b8d5ba1e16ab071b5d0d3919c8ca889084a3c9d

Update config.yml

view details

push time in 14 hours

push eventbokuweb/node-lcs-img-diff

bokuweb

commit sha 0ae0b5d7e275aeea7b55f357fbbc8cc10f082977

Update config.yml

view details

push time in 14 hours

push eventbokuweb/node-lcs-img-diff

bokuweb

commit sha 3fff3f2f298e484089490f4a0ca7060a594c9cd5

Update config.yml

view details

push time in 14 hours

push eventbokuweb/node-lcs-img-diff

bokuweb

commit sha ccc14d6eadc923c33cea316b6729464297abb586

Update config.yml

view details

push time in 14 hours

push eventbokuweb/node-lcs-img-diff

bokuweb

commit sha 3481f85ba3036685df3a3dccc277057a7c2350d4

Update config.yml

view details

push time in 14 hours

push eventbokuweb/node-lcs-img-diff

dependabot[bot]

commit sha b8aba2b23175188cefaf0774f88516b7b270ef1d

Bump lodash from 4.17.11 to 4.17.15 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

bokuweb

commit sha d3c51bcf150820207e98c2c01657ba65bf16422e

Merge pull request #1 from bokuweb/dependabot/npm_and_yarn/lodash-4.17.15 Bump lodash from 4.17.11 to 4.17.15

view details

push time in 14 hours

PR merged bokuweb/node-lcs-img-diff

Bump lodash from 4.17.11 to 4.17.15 dependencies

Bumps lodash from 4.17.11 to 4.17.15. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 14 hours

startedY2Z/monolith

started time in 20 hours

startedactions/upload-artifact

started time in 20 hours

push eventbokuweb/slate-editable-table

bokuweb

commit sha 056e375ceeafafa312e535c9984e14a213f52a68

fix: content type

view details

bokuweb

commit sha 22cc1f5f54ca12c8f18fdfc435cbbe375b505e4c

Merge branch 'master' of https://github.com/bokuweb/slate-editable-table

view details

push time in 2 days

startedorisano/pixelmatch

started time in 3 days

startedtomaka/wasm-timer

started time in 5 days

push eventbokuweb/react-rnd

bokuweb

commit sha d06328d261bfa4fa6bbf7bff73f977b572ce7110

Updates

view details

push time in 5 days

push eventbokuweb/react-rnd

renovate[bot]

commit sha b26acfb59044798bb4a825023ed4d3812b5d2d44

Update dependency react-draggable to v3.3.2 (#577)

view details

push time in 5 days

PR merged bokuweb/react-rnd

Update dependency react-draggable to v3.3.2

This PR contains the following updates:

Package Type Update Change
react-draggable dependencies patch 3.3.0 -> 3.3.2

Release Notes

<details> <summary>mzabriskie/react-draggable</summary>

v3.3.2

Compare Source

  • Use all: inherit instead of background: transparent; to fix selection styles.

v3.3.1

Compare Source

  • Fix React 16.9 componentWillMount deprecation.

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+10 -2

0 comment

2 changed files

renovate[bot]

pr closed time in 5 days

push eventbokuweb/react-rnd

bokuweb

commit sha e57b0e334e0ab18b0c56e1a2520d50128983c7b6

Updates

view details

push time in 5 days

push eventbokuweb/react-rnd

renovate[bot]

commit sha acce2e92e7d5abb9e06be1d9d27afc45d89eee83

Update dependency re-resizable to v6 (#576)

view details

push time in 5 days

PR merged bokuweb/react-rnd

Update dependency re-resizable to v6

This PR contains the following updates:

Package Type Update Change
re-resizable dependencies major 5.0.1 -> 6.0.0

Release Notes

<details> <summary>bokuweb/react-resizable-box</summary>

v6.0.0

Compare Source

:nail_care: Enhancement
  • Fix deprecated componentWillRecieveProps lifecycle method usage #​504
  • Feature request: Allow early exiting for onResizeStart #​494
:zap: Breaking changes
  • use PureComponent

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+5 -5

0 comment

2 changed files

renovate[bot]

pr closed time in 5 days

startedhecrj/setup-rust-action

started time in 6 days

created tagbokuweb/bounddoc

tag0.0.11

created time in 7 days

release bokuweb/bounddoc

0.0.11

released time in 7 days

push eventbokuweb/bounddoc

bokuweb

commit sha 0de3d82fb943d201c0c07d51c14e371c5be4091d

feat: Add indent to numberings

view details

bokuweb

commit sha 8c0668df36d9492a7d28fcc9df88c196d00bf824

Merge pull request #2 from bokuweb/apply-list-style feat: Add indent to numberings

view details

push time in 7 days

PR merged bokuweb/bounddoc

feat: Add indent to numberings
+1549 -1264

0 comment

5 changed files

bokuweb

pr closed time in 7 days

PR opened bokuweb/bounddoc

feat: Add indent to numberings
+1549 -1264

0 comment

5 changed files

pr created time in 7 days

create barnchbokuweb/bounddoc

branch : apply-list-style

created branch time in 7 days

starteddiningyo/dirv

started time in 8 days

startedtaisukef/ci0

started time in 8 days

push eventbokuweb/re-resizable

bokuweb

commit sha c59474e4c597733e5cd973d72d3090fdfa59848b

Updates

view details

push time in 8 days

startedPG-MANA/RuscV

started time in 9 days

startedgooglesamples/appauth-js-electron-sample

started time in 10 days

startedgoogle/filament

started time in 10 days

push eventreg-viz/reg-cli-report-ui

bokuweb

commit sha 5154e15869b07dde7ce0a8186c6c547e5e6464a3

fix: Add useMemo

view details

push time in 12 days

Pull request review commentreg-viz/reg-cli-report-ui

fix: Fixed a bug, search items are not fond when remove search word r…

 export const SidebarContainer = createContainer<SidebarValue>(() => {   const worker = useContext(WorkerContext);   const entities = EntityContainer.useContainer(); -  const [newItems, setNewItems] = useState(toStructualItems(entities.newItems));-  const [passedItems, setPassedItems] = useState(toStructualItems(entities.passedItems));-  const [failedItems, setFailedItems] = useState(toStructualItems(entities.failedItems));-  const [deletedItems, setDeletedItems] = useState(toStructualItems(entities.deletedItems));+  const defaultNewItems = toStructualItems(entities.newItems);+  const defaultPassedItems = toStructualItems(entities.passedItems);+  const defaultFailedItems = toStructualItems(entities.failedItems);+  const defaultDeletedItems = toStructualItems(entities.deletedItems);

Looks good :) thanks

bokuweb

comment created time in 12 days

push eventreg-viz/reg-cli-report-ui

bokuweb

commit sha a9ec9d7d86b9a912c54b85a74f6a5823e4c5adae

Update src/containers/sidebar/SidebarContainer.ts Co-Authored-By: tsuyoshi wada <wadackel@gmail.com>

view details

push time in 12 days

startedmozilla/neqo

started time in 12 days

startedriscv/riscv-tests

started time in 12 days

issue closedneon-bindings/neon

To run Neon with aws lambda function

Hi :) This project is so cool 👍 I am trying to run Neon with aws lambda. It was successful and it works with bellow example.

https://github.com/bokuweb-sandbox/rust-neon-lambda-sandbox

However, an error occurred when using nightly. (nightly-x86_64-unknown-linux-gnu rustc 1.28.0-nightly (a3085756e 2018-05-19))

Lambda function output bellow error.

"errorMessage": "/var/task/native/index.node: invalid ELF header",

I checked index.node with the readelf command. Indeed index.node was ELF format with stable, but different format with nightly.

Why is this? Are there any hints?

Thanks :)

closed time in 12 days

bokuweb

Pull request review commentreg-viz/reg-cli-report-ui

fix: Fixed a bug, search items are not fond when remove search word r…

 export const SidebarContainer = createContainer<SidebarValue>(() => {     }      const value = input.trim();--    if (value !== '') {-      worker.requestFilter({-        input,-        newItems,-        passedItems,-        failedItems,-        deletedItems,-      });-    } else {-      setNewItems(toStructualItems(entities.newItems));-      setPassedItems(toStructualItems(entities.passedItems));-      setFailedItems(toStructualItems(entities.failedItems));-      setDeletedItems(toStructualItems(entities.deletedItems));-    }

This block cause this issue. When remove words rapidly, set all items in else block for now. However it is overwritten by debounced worker response.

bokuweb

comment created time in 12 days

PR opened reg-viz/reg-cli-report-ui

fix: Fixed a choice group button style

I found not centered text in ChoiceGroup when using Firefox.

Screenshot from 2019-08-13 14-48-18

+1 -0

0 comment

1 changed file

pr created time in 12 days

create barnchreg-viz/reg-cli-report-ui

branch : fix-choice-group-style

created branch time in 12 days

Pull request review commentreg-viz/reg-cli-report-ui

fix: Fixed a bug, search items are not fond when remove search word r…

 export const SidebarContainer = createContainer<SidebarValue>(() => {     }      const value = input.trim();-

This block cause this issue. When remove words rapidly, set all items in else block for now. However it is overwritten by debounced worker response.

bokuweb

comment created time in 12 days

Pull request review commentreg-viz/reg-cli-report-ui

fix: Fixed a bug, search items are not fond when remove search word r…

 export const SidebarContainer = createContainer<SidebarValue>(() => {     }      const value = input.trim();--    if (value !== '') {-      worker.requestFilter({-        input,-        newItems,-        passedItems,-        failedItems,-        deletedItems,-      });-    } else {-      setNewItems(toStructualItems(entities.newItems));-      setPassedItems(toStructualItems(entities.passedItems));-      setFailedItems(toStructualItems(entities.failedItems));-      setDeletedItems(toStructualItems(entities.deletedItems));-    }+    worker.requestFilter({+      input: value,+      newItems: defaultNewItems,

I think it is better to post original default items to worker.

bokuweb

comment created time in 12 days

PR opened reg-viz/reg-cli-report-ui

fix: Fixed a bug, search items are not fond when remove search word r…

@tsuyoshiwada

At first, thanks for your great work :) I ran into searching issue. Please see following gif.

Peek 2019-08-13 14-05

Reproduced step

  1. input search word like foo, aaaaa.
  2. remove all search words rapidly.

Expected behavior

show all items.

Actual behavior

all items are not shown.

+23 -19

0 comment

2 changed files

pr created time in 12 days

create barnchreg-viz/reg-cli-report-ui

branch : fix-searching

created branch time in 12 days

push eventbokuweb/re-resizable

bokuweb

commit sha d32f0abb9a4408c4d6ad84696453dbd4e925ff9f

Updates

view details

push time in 12 days

push eventbokuweb/re-resizable

Renovate Bot

commit sha 320d572301cc4c36ec497ca64fb3d110e0570ac4

chore(deps): update dependency sinon to v7.4.1

view details

bokuweb

commit sha 153b83377b3d5b3e5ace68b55aa0df2ba915419a

Merge pull request #507 from bokuweb/renovate/sinon-7.x chore(deps): update dependency sinon to v7.4.1

view details

push time in 12 days

PR merged bokuweb/re-resizable

chore(deps): update dependency sinon to v7.4.1 renovate

This PR contains the following updates:

Package Type Update Change
sinon (source) devDependencies minor 7.3.2 -> 7.4.1

Release Notes

<details> <summary>sinonjs/sinon</summary>

v7.4.1

Compare Source

==================

  • Update nise and lolex (minor versions)
  • add callThroughWithNew method
  • add browser field
  • Create COMPATIBILITY.md (#​2051)
  • Fix sinon.resetHistory() does not reset history (#​2022)

</details>


Renovate configuration

:date: Schedule: "every weekend" in timezone Asia/Tokyo.

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+23 -28

0 comment

2 changed files

renovate[bot]

pr closed time in 12 days

push eventbokuweb/re-resizable

Renovate Bot

commit sha 6aa8a924d6defb4091c8c4074a5743cae9de1b8f

chore(deps): update react monorepo to v16.9.0

view details

bokuweb

commit sha b9366d3bf13d6b67b2651ba6eb5d58498901f777

Merge pull request #508 from bokuweb/renovate/react-monorepo chore(deps): update react monorepo to v16.9.0

view details

push time in 12 days

PR merged bokuweb/re-resizable

chore(deps): update react monorepo to v16.9.0 renovate

This PR contains the following updates:

Package Type Update Change
react (source) devDependencies minor 16.8.6 -> 16.9.0
react-dom (source) devDependencies minor 16.8.6 -> 16.9.0

Release Notes

<details> <summary>facebook/react</summary>

v16.9.0

Compare Source

React
  • Add <React.Profiler> API for gathering performance measurements programmatically. (@​bvaughn in #​15172)
  • Remove unstable_ConcurrentMode in favor of unstable_createRoot. (@​acdlite in #​15532)
React DOM
React DOM Server
React Test Utilities and Test Renderer

</details>


Renovate configuration

:date: Schedule: "every weekend" in timezone Asia/Tokyo.

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about these updates again.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+4 -32

0 comment

2 changed files

renovate[bot]

pr closed time in 12 days

startedTimonPost/crossterm

started time in 12 days

push eventbokuweb/re-resizable

bokuweb

commit sha 8d6479e2d17df2fea584d28b36b1459ed2f9cd41

Updates

view details

push time in 12 days

push eventbokuweb/re-resizable

bokuweb

commit sha 4c75ebb1ed1a663c82637b63ab562d28523bf359

Updates

view details

push time in 13 days

push eventbokuweb/re-resizable

bokuweb

commit sha 880a070637956433f1ef3cbe1da4d02931d40a5a

fix: #478

view details

push time in 13 days

issue closedbokuweb/re-resizable

Unable to run storybook on fresh install from master

First of all, thank you so much for this project! You've saved me a ton of time and effort with this project. Good job :-)

I'm trying to contribute an example to the docs, but am having trouble running storybook locally. If you would have any idea on why I'm getting these errors I'd love the help. If you don't know what's going on, that's okay, you can close the issue of you want.

Overview of the problem

<!-- UNCOMMENT THE APPROPRIATE LINES --> I'm using re-resizable version: I tried on both f2db33f and 7163a86 (master and one commit behind as of writing).

<!-- Could you please provide reproduced project on webpackbin with latest version rnd? -->

My browser is: N/A

I am sure this issue is not a duplicate? I searched "storybook" and didn't find anything.

Description

I forked the repo, pulled the code and tried to get things running. npm install and npm run test both succeeded. When I tried to get storybook going with npm run storybook, I got a ton of errors similar to the following:

Module not found:
Error: Cannot find module
'/Users/ahammes/dev/re-resizable/node_modules/babel-loader/lib/index.js!/Users/ahammes/dev/re-resizable/node_modules/core-js/modules/web.immediate.js'

Steps to Reproduce

  1. git clone https://github.com/bokuweb/re-resizable && cd re-resizable
  2. npm install
  3. npm run storybook

Expected behavior

Storybook compiles and starts running.

Actual behavior

A bunch of module not found errors.

closed time in 13 days

adamhammes

issue commentbokuweb/re-resizable

Fix deprecated componentWillRecieveProps lifecycle method usage

@nerrad Please try v6.0.0 :)

nerrad

comment created time in 13 days

pull request commentbokuweb/re-resizable

Fixes #494 Add optional abort for onResizeStart

@Samuel-Lewis Please try v6.0.0 :)

Samuel-Lewis

comment created time in 13 days

push eventbokuweb/re-resizable

bokuweb

commit sha f3d36f362469391232f1a5f71ad696def4b8603d

5.1.0

view details

bokuweb

commit sha f74da67106605c3712f941fd0d69d81868de873d

6.0.0

view details

push time in 13 days

push eventbokuweb/re-resizable

bokuweb

commit sha f45789bfb8ada09d2c00d41fc45e40b5e36b8590

fix: Remove willRecieveProps

view details

bokuweb

commit sha 23a94ae6a269471925efe204c7848ea997ddbc26

feat: use pure

view details

bokuweb

commit sha 06f2798d4fe6318308c090cb659d44a70be139fb

Merge pull request #509 from bokuweb/fix-#504 Fix #504

view details

push time in 13 days

issue closedbokuweb/re-resizable

Fix deprecated componentWillRecieveProps lifecycle method usage

Overview of the problem

<!-- UNCOMMENT THE APPROPRIATE LINES --> I'm using re-resizable version [5.0.1]. As implemented in the WordPress Gutenberg Project in the @wordpress/components package.

My browser is: Chrome

I am sure this issue is not a duplicate? Yes

Description

The componentWillReceiveProps lifecycle method is deprecated in React and beginning in React 17 will stop working. React in strict mode will show a warning for its usage. re-resizable implements this lifecycle method here:

https://github.com/bokuweb/re-resizable/blob/7ea154470567735149d5e3827cc9fb856f8e8f68/src/index.tsx#L463-L465

closed time in 13 days

nerrad

delete branch bokuweb/re-resizable

delete branch : fix-#504

delete time in 13 days

PR merged bokuweb/re-resizable

Fix #504

<!-- PLEASE READ THE FOLLOWING INSTRUCTIONS --> <!-- DO NOT REBUILD THE CSS OUTPUT IN YOUR PR -->

Proposed solution

<!-- Which specific problem does this PR solve and how? --> <!-- If it fixes a particular Issue, add "Fixes #ISSUE_NUMBER" in your title -->

Tradeoffs

<!-- What are the drawbacks of this solution? Are there alternative ones? --> <!-- Think of performance, build time, usability, complexity, coupling…) -->

Testing Done

<!-- How have you confirmed this feature works? -->

<!-- BEFORE SUBMITTING YOUR PR, MAKE SURE TO FOLLOW THESE STEPS: --> <!-- 1. Pull the latest master branch --> <!-- 4. If your PR fixes an issue, reference that issue -->

+12 -21

0 comment

1 changed file

bokuweb

pr closed time in 13 days

PR opened bokuweb/re-resizable

Fix #504

<!-- PLEASE READ THE FOLLOWING INSTRUCTIONS --> <!-- DO NOT REBUILD THE CSS OUTPUT IN YOUR PR -->

Proposed solution

<!-- Which specific problem does this PR solve and how? --> <!-- If it fixes a particular Issue, add "Fixes #ISSUE_NUMBER" in your title -->

Tradeoffs

<!-- What are the drawbacks of this solution? Are there alternative ones? --> <!-- Think of performance, build time, usability, complexity, coupling…) -->

Testing Done

<!-- How have you confirmed this feature works? -->

<!-- BEFORE SUBMITTING YOUR PR, MAKE SURE TO FOLLOW THESE STEPS: --> <!-- 1. Pull the latest master branch --> <!-- 4. If your PR fixes an issue, reference that issue -->

+12 -21

0 comment

1 changed file

pr created time in 13 days

push eventbokuweb/re-resizable

bokuweb

commit sha 23a94ae6a269471925efe204c7848ea997ddbc26

feat: use pure

view details

push time in 13 days

create barnchbokuweb/re-resizable

branch : fix-#504

created branch time in 13 days

pull request commentbokuweb/re-resizable

Fixes #494 Add optional abort for onResizeStart

@Samuel-Lewis LGTM

Samuel-Lewis

comment created time in 13 days

push eventbokuweb/re-resizable

Samuel Lewis

commit sha 02fbe3475d08429a9310bfb245e4e9b6ba621731

Add optional return boolean when calling onResizeStart to early exit and abort the resize sequence

view details

bokuweb

commit sha ffff47f8020219554cee9a8c5e691cb86028a2c8

Merge pull request #495 from Samuel-Lewis/feature/abort-onResizeStart Fixes #494 Add optional abort for onResizeStart

view details

push time in 13 days

issue closedbokuweb/re-resizable

Feature request: Allow early exiting for onResizeStart

Currently, when onResizeStart is called, the user provided onResizeStart (from props) is also called. In certain scenarios, however, some condition may be hit where the user wants to abort the resize.

The feature request would be to allow the user to return a boolean from their defined onResizeStart, and if it returns false, the re-resizable's onResizeStart would have an early exit and not cause any resizing.

closed time in 13 days

Samuel-Lewis

PR merged bokuweb/re-resizable

Fixes #494 Add optional abort for onResizeStart

Add optional return boolean when calling onResizeStart to early exit and abort the resize sequence

<!-- PLEASE READ THE FOLLOWING INSTRUCTIONS --> <!-- DO NOT REBUILD THE CSS OUTPUT IN YOUR PR -->

Proposed solution

<!-- Which specific problem does this PR solve and how? --> <!-- If it fixes a particular Issue, add "Fixes #ISSUE_NUMBER" in your title --> (From ticket #494) Currently, when onResizeStart is called, the user provided onResizeStart (from props) is also called. In certain scenarios, however, some condition may be hit where the user wants to abort the resize.

The feature request would be to allow the user to return a boolean from their defined onResizeStart, and if it returns false, the re-resizable's onResizeStart would have an early exit and not cause any resizing.

Tradeoffs

<!-- What are the drawbacks of this solution? Are there alternative ones? --> <!-- Think of performance, build time, usability, complexity, coupling…) --> Should not add any overheard or tradeoffs. This onResizeStart is only stopped if the user returns an explicit false. I'm sure there are many cases where the return is undefined, which should be unaffected by this change.

Testing Done

<!-- How have you confirmed this feature works? --> Confirmed locally in project. Added a test that initiates a resize, but immediately aborts. While the 'user' continues to resize, it checks the state isResizing state of the Resizable (should be false).

<!-- BEFORE SUBMITTING YOUR PR, MAKE SURE TO FOLLOW THESE STEPS: --> <!-- 1. Pull the latest master branch --> <!-- 4. If your PR fixes an issue, reference that issue -->

+23 -2

2 comments

2 changed files

Samuel-Lewis

pr closed time in 13 days

push eventbokuweb/re-resizable

bokuweb

commit sha 80dd9834ecf9c69f52108c3345f8c28fbb6aadc2

Update .travis.yml

view details

push time in 13 days

push eventbokuweb/re-resizable

bokuweb

commit sha 944e3427ea99decf128a10f38603b4fc27983045

Update .travis.yml

view details

push time in 13 days

pull request commentbokuweb/re-resizable

Fixes #494 Add optional abort for onResizeStart

@Samuel-Lewis Sorry I missed it. I'll check it later.

Samuel-Lewis

comment created time in 13 days

PR opened bokuweb/gopher-boy

Support wasm
+1029 -121

0 comment

15 changed files

pr created time in 13 days

push eventbokuweb/gopher-boy

bokuweb

commit sha 06a34b355b41e56213040e83ea37e38de753927b

fix: Fixed some specs

view details

push time in 13 days

push eventbokuweb/gopher-boy

bokuweb

commit sha fee297cafdc9714aeff30356855d665830bdf473

fix: Fixed some specs

view details

push time in 13 days

push eventbokuweb/gopher-boy

bokuweb

commit sha 5862e3585c433fb230b7a641d84acb6ddc9739f3

fix: Fixed some specs

view details

push time in 13 days

push eventbokuweb/gopher-boy

bokuweb

commit sha 1d08f97007c5c629db1a93eb772368784bc3f4b6

fix: Fixed some specs

view details

push time in 13 days

push eventbokuweb/gopher-boy

bokuweb

commit sha 4c7adc3ef909c89cc40561e3096ad1860511581a

feat: Add cpntroller and render case

view details

push time in 13 days

push eventbokuweb/gopher-boy

bokuweb

commit sha 9943613caa94cf9b9b8818078f1a735919ea000b

feat: Add wasm skeleton

view details

push time in 13 days

push eventbokuweb/gopher-boy

bokuweb

commit sha 946a6752be00b41b2a6e504059eb2d961378f994

feat: Add wasm skeleton

view details

push time in 14 days

push eventbokuweb/gopher-boy

bokuweb

commit sha be35ed799a2af47fc911f87f65ea05fc2bcf6a43

feat: Add wasm skeleton

view details

push time in 14 days

push eventbokuweb/gopher-boy

bokuweb

commit sha c488ea49ce41c3a6448a666ca537d824fdcfeecd

feat: Add wasm skeleton

view details

push time in 14 days

startedgo-interpreter/wagon

started time in 14 days

create barnchbokuweb/gopher-boy

branch : support-wasm

created branch time in 14 days

startedyurydelendik/wasmparser.rs

started time in 16 days

push eventbokuweb-sandbox/go-wasm-sandbox

bokuweb

commit sha d727773baff852ebe65df6541ccd556fb0c91db7

array sample

view details

push time in 16 days

startedry/deno_snapshot

started time in 17 days

push eventbokuweb-sandbox/go-wasm-sandbox

bokuweb

commit sha 254724386fc9e7f4c25c88091d18a688cd848c8b

rename

view details

push time in 17 days

create barnchbokuweb-sandbox/go-wasm-sandbox

branch : master

created branch time in 17 days

startedmichaeldzjap/react-pdf-sample

started time in 18 days

startedkt3k/remarker

started time in 18 days

startedbokuweb/gopher-boy

started time in 19 days

push eventbokuweb/slate-editable-table

bokuweb

commit sha 890a8c1fd5b8a94847d6458deb2b7cde7b8d52f2

Update README.md

view details

push time in 19 days

more