profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/boghyon/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Boghyon Hoffmann boghyon 43.9785319,15.3833068

boghyon/ACBST 0

my first Android app: a simple task manager (written originally by using Eclipse, imported to Android Studio.)

boghyon/code-prettify 0

An embeddable script that makes source-code snippets in HTML prettier.

boghyon/cors-anywhere 0

CORS Anywhere is a NodeJS reverse proxy which adds CORS headers to the proxied request.

boghyon/fiori-elements-opensap 0

This repository offers optional hands-on exercises for the free openSAP course "Developing and Extending SAP Fiori Elements Apps."

boghyon/gitpod-ui5-basic 0

Start coding in Gitpod (cloud IDE based on Eclipse Theia) with this basic UI5 application. Simply click on the Gitpod badge from README to launch.

boghyon/openui5 0

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.

boghyon/openui5-docs 0

OpenUI5 Markdown Documentation

boghyon/openui5-sample-app 0

OpenUI5 Sample App

boghyon/openui5-website 0

The OpenUI5 website.

issue commentSAP/openui5

Please provide an application wide shell bar option for standalone apps

Hi @dimovpetar

Sorry for the confusion. Let me try again to explain why I'd like to turn this into an enhancement request:

According to the sap.m.Shell documentation, it should be used as a root control that holds the sap.m.App. [...] Can you check if this works for you?

It's not an issue to wrap the entire — i.e. including sap.f.ShellBar — app with sap.m.Shell. That's no problem but also not what I described in my previous comment.

👉 Currently, it's not possible to wrap the content only — i.e. excluding sap.f.ShellBar — to imitate Fiori launchpad's letterbox in OpenUI5.

Here is a screenshot of an FLP sample with limited width enabled:
ui5 sap com_1 94 1_test-resources_sap_ui_demoapps_demokit_rta_freestyle_test_flpSandbox html
As you can see, despite having a sap.f.ShellBar-like header (FLP has its own bar control named sap.ushell.ui.ShellHeader):

  • Only the content is wrapped, excluding the header. ✔
  • No content is off-screen. Everything is still displayed. ✔

To imitate the FLP letterbox as described above, I proposed an enhancement request here: https://github.com/SAP/openui5/issues/3344#issuecomment-923032320

piejanssens

comment created time in 4 days

issue commentSAP/ui5-webcomponents

UI5Element: set focus on keyboard handling only

Is there a consideration to make use of the :focus-visible pseudo class for this? I requested it originally at https://github.com/SAP/openui5/issues/1289#issuecomment-289203290. The :focus-visible (formerly :focus-ring) would help improving:

  • Consistency of the ring visibility across the web platform.
  • Accessibility for physically or visually impaired people, enabling them to make the focus ring always visible depending on their system (OS or browser) settings.
  • (And more)

Browser support :focus-visible

  • Firefox, Chromium: ✔
  • Safari: implemented but yet to be enabled by default (currently behind a flag) according to Igalia in May 2021.

Sample

  1. Open https://jsbin.com/roputeb/edit?html,css,output on Windows or Android using a Chromium-based browser or Firefox.
  2. We can see that elements styled with :focus-visible display the focus ring according to browser's heuristics which is basically:
    • Display the focus ring always if keyboard.
    • Display the focus ring sometimes if clicked on <input> or <select>. Otherwise, no focus indicator on click.

Any thoughts?

ilhan007

comment created time in 5 days

issue commentSAP/openui5-docs

Central topic to learn about rendering in UI5

For future UI5 control development based on UI5 Web Components, follow https://github.com/SAP/ui5-webcomponents/issues/2926

boghyon

comment created time in 5 days

startedjs-soft/wdi5

started time in 7 days

startedui5-community/ui5-ts-shim-showcase

started time in 7 days

issue commentSAP/openui5

Please provide an application wide shell bar option for standalone apps

There is still an issue that letterboxing cannot be easily achieved with sap.f.ShellBar if the intension is wrapping the content only à la FLP. Here is an attempt with sap.m.Shell: https://plnkr.co/edit/HXcDItf01HesUiQn

run plnkr co_plunks_HXcDItf01HesUiQn_

As you can see, the 100th item is pushed out of the screen.

Cause: similar to sap.m.App, the sap.m.Shell forcefully applies height: 100%; to its parent elements on after rendering. https://github.com/SAP/openui5/blob/24eafa58f9f79e6664f085da42556436548ba00e/src/sap.m/src/sap/m/Shell.js#L179-L196 The <section>-HTMLElement of the Page then gets height: 100%; pushing the entire content downwards due to the already existing ShellBar. Disabling the forced height fixes the issue but then I've to overwrite Shell's onAfterRendering which is bad in terms of compatibility.

TL;DR

I'd turn this issue into an enhancement request.

  1. Deprecate sap.m.Shell as its header related properties are rarely used (and sap.m.Shell is never used by FLP)
  2. Offer some lightweight option to still apply theme-able letterbox to a certain container, like the screenshot above, which can be also commonly shared with non-OpenUI5 web apps (e.g. apps that use UI5 Web Components).

@codeworrior @petermuessig Was there a similar discussion about the future of sap.m.Shell? How can e.g. plain web apps using UI5 Web Components apply such theme-able letterboxing without sap.m.Shell?

piejanssens

comment created time in 8 days

startedtc39/proposal-pipeline-operator

started time in 11 days

startedSAP-samples/ui5-typescript-helloworld

started time in 12 days

issue commentSAP/openui5

Please provide an application wide shell bar option for standalone apps

Can we deprecate the entire sap.m.Shell instead? As this issue shows, standalone apps can't make use of the header properties such as the title, showLogout, etc.. And the FLP doesn't make use of sap.m.Shell either.

The only useful options to standalone app developers might be the letterboxing (appWidthLimited="true") and background properties such as logo, backgroundImage, etc. Maybe those options can be provided by plain CSS classes?

piejanssens

comment created time in 13 days

startedIBMPredictiveAnalytics/SPSSINC_TRANS

started time in 19 days

startedWICG/close-watcher

started time in 19 days

issue commentSAP/openui5

`Core.createComponent` has no `async` flag - API still relevant?

@gmkv Thanks. Just wanted to emphasize; my actual enhancement proposal is the deprecation of Core.createComponent as described in the issue description at the end. I doubt that the API is needed at all since we have multiple ways to create components.

boghyon

comment created time in 19 days

issue openedSAP/openui5

`Core.createComponent` has no `async` flag - API still relevant?

URL (minimal example if possible):

https://fioriappslibrary.hana.ondemand.com/ (Set a breakpoint at Core.prototype.createComponent in the devtools)

What is the expected result?

Applications can enable creating the component asynchronously when they call Core.createComponent with the appropriate options.

What happens instead?

The API doesn't explain how the component could be created asynchronously. No [vComponent.async] for example. https://github.com/SAP/openui5/blob/5a98abdf96035b79f3081754ea513d7e49b348de/src/sap.ui.core/src/sap/ui/core/Core.js#L2115-L2170 Also there is no proper @return value documented: According to the source code, Core.createComponent can actually return a promise in the async mode, or the synchronously created component.

Any other information? (attach screenshot if possible)

Is the above API actually still relevant? What is the purpose of Core.createComponent if there are other ways to create components asynchronously, especially now that we have the sap/ui/core/ComponentSupport? AFAIK only not-well maintained apps still use the API.

If the API has no much use and there are replacements, can it be deprecated?

created time in 20 days

startedWICG/csp-next

started time in 25 days

push eventboghyon/openui5

Teodor Taushanov

commit sha 7c880616b799fc264eadba6e86698b7ceb679ac1

[FIX] sap.tnt.NavigationList: Item position is now read after the item text BCP: 2180210026 Change-Id: I9095298b4e0e75d13a23ed3fabc0d6236172bbbc

view details

Alexander Deutschmann

commit sha f3591f42993a561bf9f8962c13bc1491e9a85dd8

[INTERNAL] Table: Keep the dom when destroying a column When a column is removed from the MDC Table, the inner column is destroyed. To avoid unnecessary UI changes, the DOM of the destroyed column is preserved. The rendering of the inner table will correctly update the DOM. Change-Id: Ibc1db7b0fa43eee6b09cf5c36618915317c41f21 BCP: 2180276308

view details

Boyan Rakilovski

commit sha 06639d26b0bf649144c9de5193d45a46e63b5ee0

[INTERNAL] sap.m.DynamicDateRange: current month is now the default for the month option JIRA: BGSOFUIBALKAN-5856 Change-Id: Id6433d4501dee3a8239c6056a27211d4c6f07413

view details

Martin Häuser

commit sha e8a890f2993990cbb76106ae41c0058c7e1b3f76

[INTERNAL]P13nChartOpa: clear cache BEFORE app start Change-Id: Ie14d2bbdf506fc9f5fba4153d70f52178d8b75a3

view details

sapui5

commit sha c306dff2e401b01dd652d79f81513e5ad160b59b

[INTERNAL][TEST] sap.m IconTabBarResponsivePaddings: reference images changed Change-Id: Idf87ff93f14b18d7f508a071d1119222682eb317

view details

sapui5

commit sha 8e3c0ad5fcc3df6a84220852e7ee52652dd91639

[INTERNAL][TEST] sap.m Select: reference images changed Change-Id: I3f7b8e7d6e6302ee6b087d8b89de0eec90623311

view details

Pramod Jayaram

commit sha d2d4b7490b54f0571a3251fbe6a6e6dba8f4e444

[INTERNAL] ListItemBase: Updated the font size of Navigated Row Previously, the font size for Belize was set to 0.75 rem. But according to design specification the font size should be 1 rem for belize theme. BCP: 2180299916 Change-Id: I95ce6b6d37d1397ce41ea3cc30c817cbf50d8e51

view details

sapui5

commit sha ae6135eb7f8abfdc10a50270ab106e73c91f8bd4

[INTERNAL][TEST] sap.m MessageView: reference images changed Change-Id: Iaa05dac0e07ffd944ee6d94186778f7158ad73c5

view details

Diana Pazheva

commit sha ae97528c363f47f59f5effb0e422e89bf593c69e

[INTERNAL] sap.f.routing.Router: Improve documentation Extends the documentation to highlight the difference with sap.m.routing.Router JIRA: BGSOFUIPIRIN-5057 Change-Id: I75ee166c83c73cc18cb6bc8210afb555101abe75

view details

Petar Dimov

commit sha 6293ac2be2411c8157cff25589ac302ef38ca8e4

[INTERNAL] sap.ui.integration.controls.ListContentItem: Fix color of action buttons When the list item is actionable and there are action buttons, they should be visible when the item is clicked. Change-Id: If5acc4c110900c05b977b462a19f40d177649cd5 Snippix: 91128 JIRA: BGSOFUIRODOPI-2596

view details

Thorsten Hochreuter

commit sha 8cd20c4eb1fb2bf607932710d8ffc14ae8314efc

[INTERNAL][FIX] Component_containedInLibrary: Fix unstable Tests - Reactivates a previously skipped tests due to voter failures - Refactors the tests to be independent of sap.ui.documentation components Commit: 3ed03a2f5a3c818ce3aa6538c336554d805c1544 Change-Id: I343f8bbe8bcb15302459aa3c5c40644714ca449d

view details

Sebastian Allmann

commit sha 73c3a36d732bcd7311bb6791043d39a2f91efc5b

[INTERNAL] DefineConditionPanel: on switching operator - empty token If a condition with value is changed from equal to contains an empty token is created. The value is cleared. As for some types (like String with isDigitSequence) a special parsing is needed the value needs to be formatted and parsed again. But as it is not known what the user initial entered it could lead to a different value. Change-Id: I68efe220f7ee8c5028f9a95cab0d408df2906ade

view details

Sebastian Allmann

commit sha cdd489e50e700b8fd9d635a3f2adff133b4aa282

[INTERNAL] MultiValueField: replace deprecated function Change-Id: I81cf06bfc8619454741946f38e4386c69107dc61

view details

sapui5

commit sha 552848178513b369e3baa32606d468427afed373

[INTERNAL][TEST] sap.m Carousel: reference images changed Change-Id: I23ee5239a75c83850ff7ca3d92e815c008aaafac

view details

Nia Peeva

commit sha a00aab8ffe3ab68edf5bc5cadc26349b1321a714

Merge "[INTERNAL][TEST] sap.m MessageView: reference images changed"

view details

sapui5

commit sha a9b29527cf28b53850c6288402ee7e09e730aae5

[INTERNAL][TEST] sap.m Popover: reference images changed Change-Id: I0d7dda015e9c5cd85a11b8e3e7025be639066980

view details

sapui5

commit sha a933d6895a2abf1f0833af30a23e01bdc608c89e

[INTERNAL][TEST] sap.m ObjectAttribute: reference images changed Change-Id: I16e87030380ba7549d18b1244c17a0f32c0e86b7

view details

sapui5

commit sha 7b6cc849a091cef3d8cb958f25b2aa48187ea695

[INTERNAL][TEST] sap.m ObjectMarker: reference images changed Change-Id: Iad94f76ab0daec1704ce878105c635860b262e7d

view details

sapui5

commit sha 4746880329546ba1e728f49978c5831d644675ea

[INTERNAL][TEST] sap.m ObjectStatus: reference images changed Change-Id: I443650a994792c94643646c2cdbeca2c9f243308

view details

Thorsten Hochreuter

commit sha 63e31c2d720d26945e6c2fa81e9a9e23420f7571

Merge "[INTERNAL][FIX] Component_containedInLibrary: Fix unstable Tests"

view details

push time in 25 days

startedzxing-js/library

started time in 25 days

issue commentSAP/openui5

API Reference: some `@public` and `@protected` methods aren't listed in the "Methods" section

@codeworrior Some valid methods with @protected don't seem to appear in the API reference at all. For example:

  • sap/m/ListBase:

    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListBase#methods/setSelectedContextPaths
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListBase#methods/getSelectedContextPaths
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListBase#methods/isAllSelectableSelected
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListBase#methods/getVisibleItems
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListBase#methods/getStickyFocusOffset
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListBase#methods/onBeforePageLoaded
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListBase#methods/onAfterPageLoaded
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListBase#methods/addNavSection
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListBase#methods/getMaxItemsCount
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListBase#methods/shouldRenderItems
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListBase#methods/shouldGrowingSuppressInvalidation
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListBase#methods/setNavigationItems
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListBase#methods/setItemFocusable
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListBase#methods/forwardTab

    Only getItemNavigation and getLastMode are currently visible in the API reference as @protected methods.

  • sap/m/ListItemBase:

    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListItemBase#methods/getBindingContextPath
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListItemBase#methods/isSelectedBoundTwoWay
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListItemBase#methods/getList
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListItemBase#methods/getListProperty
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListItemBase#methods/informList
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListItemBase#methods/getMode
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ListItemBase#methods/updateAccessibilityState

    Here, getContentAnnouncement and getTabbables are the only @protected methods visible in the API reference.

  • sap/m/SelectList:

    • https://openui5nightly.hana.ondemand.com/api/sap.m.SelectList#methods/findFirstEnabledItem
    • https://openui5nightly.hana.ondemand.com/api/sap.m.SelectList#methods/synchronizeSelection
    • https://openui5nightly.hana.ondemand.com/api/sap.m.SelectList#methods/isSelectionSynchronized
    • https://openui5nightly.hana.ondemand.com/api/sap.m.SelectList#methods/findLastEnabledItem
    • https://openui5nightly.hana.ondemand.com/api/sap.m.SelectList#methods/getVisibleItems
    • https://openui5nightly.hana.ondemand.com/api/sap.m.SelectList#methods/getSelectableItems
    • https://openui5nightly.hana.ondemand.com/api/sap.m.SelectList#methods/findItem
    • https://openui5nightly.hana.ondemand.com/api/sap.m.SelectList#methods/getItemByText
    • https://openui5nightly.hana.ondemand.com/api/sap.m.SelectList#methods/isItemSelected

    setSelection, getDefaultSelectedItem, and clearSelection are visible.

  • sap/m/Table:

    • https://openui5nightly.hana.ondemand.com/api/sap.m.Table#methods/_hasDynamicWidthColumn
    • https://openui5nightly.hana.ondemand.com/api/sap.m.Table#methods/getTableDomRef
    • https://openui5nightly.hana.ondemand.com/api/sap.m.Table#methods/checkGrowingFromScratch
    • https://openui5nightly.hana.ondemand.com/api/sap.m.Table#methods/onColumnResize
    • https://openui5nightly.hana.ondemand.com/api/sap.m.Table#methods/setTableHeaderVisibility
    • https://openui5nightly.hana.ondemand.com/api/sap.m.Table#methods/updateSelectAllCheckbox
    • https://openui5nightly.hana.ondemand.com/api/sap.m.Table#methods/getColSpan
    • https://openui5nightly.hana.ondemand.com/api/sap.m.Table#methods/getColCount
    • https://openui5nightly.hana.ondemand.com/api/sap.m.Table#methods/shouldRenderDummyColumn
    • https://openui5nightly.hana.ondemand.com/api/sap.m.Table#methods/hasPopin
    • https://openui5nightly.hana.ondemand.com/api/sap.m.Table#methods/isHeaderRowEvent
    • https://openui5nightly.hana.ondemand.com/api/sap.m.Table#methods/isFooterRowEvent

    Only enhanceAccessibilityState is visible.

  • sap/m/Toolbar:

    • https://openui5nightly.hana.ondemand.com/api/sap.m.Toolbar#methods/sap.m.Toolbar.isRelativeWidth
    • https://openui5nightly.hana.ondemand.com/api/sap.m.Toolbar#methods/sap.m.Toolbar.getOrigWidth
    • https://openui5nightly.hana.ondemand.com/api/sap.m.Toolbar#methods/sap.m.Toolbar.checkShrinkable
  • sap/m/ToolbarLayoutData:

    • https://openui5nightly.hana.ondemand.com/api/sap.m.ToolbarLayoutData#methods/getParentStyle
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ToolbarLayoutData#methods/applyProperties
  • sap/m/InputBase:

    • https://openui5nightly.hana.ondemand.com/api/sap.m.InputBase#methods/getChangeEventParams
  • sap.m.IBarInPageEnabler:

    • doesn't mention any of the @protected methods that are to be implemented.
  • sap/m/ComboBoxBase:

    • https://openui5nightly.hana.ondemand.com/api/sap.m.ComboBoxBase#methods/isPickerDialog
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ComboBoxBase#methods/isPlatformTablet
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ComboBoxBase#methods/getDropdownSettings
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ComboBoxBase#methods/_configureList
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ComboBoxBase#methods/getPickerTitle
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ComboBoxBase#methods/revertSelection
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ComboBoxBase#methods/getVisibleItems
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ComboBoxBase#methods/isItemSelected
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ComboBoxBase#methods/getKeys
    • https://openui5nightly.hana.ondemand.com/api/sap.m.ComboBoxBase#methods/getItemByText

    Many other @protected methods from the ComboBoxBase are actually visible in the API reference except of the above mentioned ones.

  • sap/m/Button:

    • is missing _bExcludeFromTabChain in the API reference despite having @protected for that field.
  • sap/ui/core/routing/HashChangerBase:

    • https://openui5nightly.hana.ondemand.com/api/sap.ui.core.routing.HashChangerBase#methods/getHash
  • sap/ui/core/routing/RouterHashChanger:

    • https://openui5nightly.hana.ondemand.com/api/sap.ui.core.routing.RouterHashChanger#methods/createSubHashChanger
  • (And probably more ...)

<br>

Why are the above methods not visible in the API reference? Not expecting @protected+@override methods to appear but if the methods have @protected only, shouldn't they be visible in the API ref?


On the other hand, some questionable visibility choices:

@public by mistake?

  • sap/m/RadioButton._updateLabelProperties is @public. Shouldn't it be @private like _getLabel and _updateGroupName?
  • sap/m/Input's on* methods are mostly @public. How can e.g. oInput.onBeforeRendering() be used in application development? Shouldn't these methods rather have @protected or @private instead?
    Weirdly, only the onsapright has @protected.
  • sap/m/ComboBox's ontap has @public. Same as sap/m/Input, how can ontap be leveraged publicly in application development? Is the control author allowing app developers to simply call oComboBox.ontap()?

@protected but shown as "Visibility: public" in API reference?

Possibly missing @protected?

  • The source code of sap/m/Select has a section called "protected methods". However, almost no methods are tagged with @protected. Even empty hook methods that are obviously meant to be overwritten (e.g. addContent / addContentToFlex) aren't tagged with @protected (and @virtual if applicable), hence invisible in the API reference.
  • Some controls provide @virtual (abstract) methods expected to be overwritten by subclasses. IMO @virtual methods should get @protected too so that they can be seen in the API reference. https://github.com/SAP/openui5/blob/295b0ce544e5854c5ee74426ff24825b36a6ab3d/src/sap.ui.layout/src/sap/ui/layout/cssgrid/GridLayoutBase.js#L211-L224
boghyon

comment created time in a month

issue commentSAP/openui5

`sap.ui.core.IAsyncContentCreation` leads to "Cannot read properties of null (reading `getId`)" on `Fragment` loading

@pubmikeb The issue https://github.com/SAP/openui5/issues/3134 refers rather to the v2.ODataModel requiring sap/ui/thirdparty/datajs.js synchronously if "preload": true. Not sure about the current state of i18n resources.

pubmikeb

comment created time in a month

issue commentSAP/openui5

`sap.ui.core.IAsyncContentCreation` leads to "Cannot read properties of null (reading `getId`)" on `Fragment` loading

@pubmikeb About the remaining sync XHR calls, here I documented what I'm currently aware of: https://blogs.sap.com/2018/04/26/ui5ers-buzz-29-asynchronify-your-app/comment-page-1/#comment-545788

The CLDR is one of them.

pubmikeb

comment created time in a month

issue commentSAP/openui5

v4.ODataModel evaluates preflight requests

Just an update for this thread: as @ThomasChadzelek and @UweReeder pointed out, Access-Control-Expose-Headers was missing in the response header. After https://github.com/OData/ODataSamples/issues/29#issuecomment-861736364, the header info OData-Version: 4.0 could be accessed from the client.

The OData V4 Trippin service now supports CORS.

boghyon

comment created time in a month

issue openedplnkr/feedback

All embedded plunks spread ads (and possibly malware) on click due to domain parked CodeFund CDN `<script>`

  1. Open a new browser window in Guest mode (== fresh new browser with default settings and no extensions)
  2. Go to https://embed.plnkr.co/
  3. Simply click somewhere (not the "Preview" iframe)

The embed.plnkr.co currently serves the following two scripts:

<script type="text/javascript" src="https://cdn2.codefund.app/assets/px.js?ch=1"></script>
<script type="text/javascript" src="https://cdn2.codefund.app/assets/px.js?ch=2"></script>

They both attempt to add the following click handler:

if (typeof _popwnd == 'undefined') {
   var _popwnd = -1;
   function _popwnd_open(){
       if (_popwnd!=-1) return;
       _popwnd = window.open('http://iyfnz.com/?dn=codefund.app&pid=9PO755G95', '_blank', '');
       _popwnd.blur();
       window.focus();
   }
};
window.addEventListener('click', _popwnd_open);

On 30. June 2020, there was an announcement that CodeFund is shutting down: https://web.archive.org/web/20200630235914/https://codefund.io/ Now that CodeFund is gone, all webpages using the above CDN address serve ads on click thanks to Skenzo Ltd. parking the domain codefund.app and spreading ads and possibly malware.

I think referring to remote scripts without <code>integrity="<em><hash></em>"</code> is not a good approach.

TL;DR

Please remove codefund CDN addresses and make use of integrity for all remaining remote scripts if applicable.

created time in a month

pull request commentSAP/openui5-docs

Update Step_19_Reuse_Dialogs_1945396.md

@FabioNascimento There is currently an ongoing refactoring in the walkthrough samples. The latest Component.js file in the step 19, for example, doesn't call this.rootControlLoaded() anymore: https://github.com/SAP/openui5/blob/c05eaed493fd328b0d80e73c0a15c19889db7120/src/sap.m/test/sap/m/demokit/tutorial/walkthrough/19/webapp/Component.js

The change was merged into OpenUI5 just today (https://github.com/SAP/openui5/commit/e71bef4eb459d064a5e3c89da4f2d82c8bcc6745#diff-f6a558bd9fc23bb8788fd852231242073b89c6594710566a04a8c87845ecc17a) to make use of the new loadFragment API in the controller.

I'm guessing that the text and the code snippets from the Walkthrough were already planned to be adapted accordingly by one of the maintainers.

FabioNascimento

comment created time in 2 months

startedWICG/eyedropper-api

started time in 2 months

delete branch boghyon/openui5

delete branch : messagepage_icon_fix

delete time in 2 months

pull request commentSAP/openui5

[FIX] sap.m.MessagePage: increase CSS specificity of main icon

@jdichev Thanks for accepting my PR. What do we do with this PR now? Do I close it?

boghyon

comment created time in 2 months

PullRequestEvent

PR closed SAP/openui5

[FIX] sap.m.MessagePage: increase CSS specificity of main icon in progress
  • Due to the low specificity for MessagePage's main icon, the font-size of all icons within the page was set to 6rem which affected even the icons within inserted buttons.
  • Increased specificity by prepending .sapMMessagePageIcon to the generic .sapUiIcon.

Below are screenshots (in sap_fiori_3_dark) of before and after the fix:

Before

localhost_8080_test-resources_sap_m_MessagePage html_sap-ui-debug=true sap-ui-language=en-US sap-ui-accessibility=true sap-ui-theme=sap_fiori_3_dark

After

localhost_8080_test-resources_sap_m_MessagePage html_sap-ui-debug=true sap-ui-language=en-US sap-ui-accessibility=true sap-ui-theme=sap_fiori_3_dark (1)

Fixes: https://github.com/SAP/openui5/issues/3145

+10 -14

3 comments

8 changed files

boghyon

pr closed time in 2 months

CommitCommentEvent

issue commentSAP/openui5

what's the O-listener in MessageProcessor's attachMessageChange function? is there a example?

function when there was error message pop up in UI5

@Vita-Meow Could you elaborate more on the case? I feel that it's not an issue about oListener but something else. Please ask a new question on either SAP Community or Stack Overflow with more information and details of what you're actually trying to achieve and what you've tried so far.

I'd avoid passing this.onMessageChange.bind(this) since the handler then becomes undetachable.

Vita-Meow

comment created time in 2 months

pull request commentSAP/openui5

[FIX] sap.m.MessagePage: increase CSS specificity of main icon

@nnaydenow Done! Sorry for the late response. Could you please check again?

boghyon

comment created time in 2 months