profile
viewpoint
Benjamin Bouvier bnjbvr Lyon, France https://benj.me Compiler engineer at @EmbarkStudios, previously @mozilla. Maintainer of @kresusapp.

bnjbvr/botzilla 24

Matrix bot tuned for Mozilla's needs

adngdb/arewereorganizedyet.com 19

are we reorganized yet?

bnjbvr/cargo-machete 7

Remove unused Rust dependencies with this one weird trick!

bnjbvr/baldrdashlift 2

cli tool to update Cranelift in Spidermonkey (Baldrdash)

bnjbvr/blog.benj.me 2

Sources of my blog https://blog.benj.me

bnjbvr/.files 1

My dot files

bnjbvr/addons-linter 1

🔍 Firefox Add-ons linter, written in JavaScript. 👁

bnjbvr/algorithms 1

Why would you keep for yourself the algorithms you're training for, when you can show their bugs to everybody?

bnjbvr/2019 0

Site permettant de comparer le programme des partis politiques candidats aux élections européennes de 2019

bnjbvr/americano 0

Make Express.js more opinioniated about configuration

push eventbnjbvr/slides

Benjamin Bouvier

commit sha e35b4f214c9440a916758d059c7b15131523e2b1

update

view details

push time in a day

push eventbnjbvr/slides

Benjamin Bouvier

commit sha ccb7833637431ab43e2e1dd2089f25fd0bb8ff46

remove empty www dir

view details

push time in a day

push eventbnjbvr/slides

Benjamin Bouvier

commit sha 6d90cd915cb01b61807bec90986886605760fb3c

add link to bytecode alliance announcement

view details

push time in a day

push eventbnjbvr/slides

Benjamin Bouvier

commit sha d8c322711985900e2311a03b1c5a3b07f1944405

new slides, who dis

view details

push time in a day

delete branch bnjbvr/ittapi

delete branch : reorganize-files

delete time in 2 days

PR closed intel/ittapi

Reorganize files to allow Rust compilation on Windows

This fixes #38 and allows to compile and use the Rust bindings on Windows. It simply moves the C files around, and creates symlinks to access them from the top-level directory, rather than doing the opposite. Since there's a C compile script buildall.py that works for all platforms and use cmake (and I'd expect cmake to follow symlinks on Windows), compilation of the C code should still work on Windows, although I can't test it unfortunately. Would be appreciated if someone could do that, please!

@abrown @jlb6740 please take a look.

+10 -18

3 comments

30 changed files

bnjbvr

pr closed time in 2 days

pull request commentintel/ittapi

Reorganize files to allow Rust compilation on Windows

Closing PR, we can have this discussion elsewhere.

bnjbvr

comment created time in 2 days

push eventkresusapp/kresus

Benjamin Bouvier

commit sha 7b528816a633f7966af55e2b6f9febff4c1ff9b7

Bump log4js to 6.4.0

view details

push time in 3 days

push eventbnjbvr/cargo-machete

Benjamin Bouvier

commit sha c07012248db70cba9d6f6b11ffc3d0d203323739

make it possible to scan specific dirs by passing them to cli

view details

Benjamin Bouvier

commit sha 9ac792735e97a1a44a62c27c88dd04531a0f1e36

disable --frozen for cargo-metadata

view details

push time in 4 days

push eventbnjbvr/cargo-machete

Benjamin Bouvier

commit sha 3ad7770292030b83f7b16410fd9317aeec80d099

Pass --frozen to cargo metadata, so as to not modify Cargo.lock

view details

push time in 4 days

push eventbnjbvr/cargo-machete

Benjamin Bouvier

commit sha 9a838226f96cf4d5c9ad1cbbff8d78b8c780e7f6

Add support for compound `use { X as Y }` statements (#11) * Add support for compound `use { X as Y }` statements Fixes #10. Sort of, as it might be very imprecise and I'm now hitting my limits on regular expression skills. * lol test * tweak regex and add regex-try app * remove unused dependencies heh

view details

push time in 4 days

delete branch bnjbvr/cargo-machete

delete branch : compound-use-as

delete time in 4 days

PR merged bnjbvr/cargo-machete

Add support for compound `use { X as Y }` statements

Fixes #10. Sort of, as it might be very imprecise and I'm now hitting my limits on regular expression skills.

@lqd, care to test if it works in your use case, please?

+2205 -2

1 comment

4 changed files

bnjbvr

pr closed time in 4 days

issue closedbnjbvr/cargo-machete

Renaming in compound use statements cause false positives

// use rustc_rayon_core as rayon_core; // Correctly marked used
use { rustc_rayon_core as rayon_core }; // Incorrectly marked unused

pub fn notify(_: &rayon_core::Registry) {
}

fn main() {
    println!("Hello, benjy bworld!");
}

Also: multiline compound use statements would be an issue as well.

Thanks @lqd for the report!

closed time in 4 days

bnjbvr

push eventbnjbvr/cargo-machete

Benjamin Bouvier

commit sha 2e5bb840d5aff423919ced455ceec527fe4089c7

remove unused dependencies heh

view details

push time in 4 days

push eventbnjbvr/cargo-machete

Benjamin Bouvier

commit sha e98fe1363112d408c52c13d3bfc4189815619145

tweak regex and add regex-try app

view details

push time in 4 days

push eventbnjbvr/cargo-machete

Benjamin Bouvier

commit sha 2cabaeb2933d4ce5f77b786379a1ca15aaed1567

lol test

view details

push time in 4 days

PR opened bnjbvr/cargo-machete

Add support for compound `use { X as Y }` statements

Fixes #10. Sort of, as it might be very imprecise and I'm now hitting my limits on regular expression skills.

@lqd, care to test if it works in your use case, please?

+41 -2

0 comment

1 changed file

pr created time in 4 days

create barnchbnjbvr/cargo-machete

branch : compound-use-as

created branch time in 4 days

issue commentbnjbvr/cargo-machete

Renaming in compound use statements cause false positives

Ideas for fixing this:

  • (Could be fixed by proper parsing, but that defeats the purpose of scanning text-only).
  • Do minimal parsing by keeping track of "use" statements and keep a count of {}.
  • Find statements of the form X::Y and try to find occurrences of as X in the code, scanning backwards from the line containing the X::Y statement. Not perfectly precise as there still could be false positives in contrived cases, but that could suffice.
bnjbvr

comment created time in 4 days

issue openedbnjbvr/cargo-machete

Renaming in compound use statements cause false positives

// use rustc_rayon_core as rayon_core; // Correctly marked used
use { rustc_rayon_core as rayon_core }; // Incorrectly marked unused

pub fn notify(_: &rayon_core::Registry) {
}

fn main() {
    println!("Hello, benjy bworld!");
}

Also: multiline compound use statements would be an issue as well.

created time in 5 days

pull request commentintel/ittapi

Reorganize files to allow Rust compilation on Windows

Sure thing! To be fair, somebody tested this PR on Windows and it might not be sufficient, because Cmake doesn't follow symbolic links either.

@abrown suggested that we could use a different Github repo, and use a git submodule to link to this one. That way, the Rust code folder would contain the C code, and we could compile it in a straightforward way, without the symbolic links issue at hand. I also think that makes sense because one could then set up CI specific to Rust in there, and make Rust support for this project first class. Would that be an acceptable solution?

bnjbvr

comment created time in 5 days

push eventbnjbvr/joke

Benjamin Bouvier

commit sha e22cf20ab79bde5ba5609932a45c51435e96fc70

remove CNAME :(

view details

push time in 6 days

pull request commentbytecodealliance/regalloc.rs

Make `WritableBase` public and add a blanket implementation

Could it be that one can add the wrapper to a type that's already wrapped, and end up with Writable<Writable<T>>? In any case, change looks fine to me, and this code is doomed anyways :)

fitzgen

comment created time in 6 days

issue commentEmbarkStudios/rust-ecosystem

Embark's pull requests

  • https://github.com/intel/ittapi/pull/39
repi

comment created time in 6 days

PR opened intel/ittapi

Reorganize files

This fixes #38 and allows to compile and use the Rust bindings on Windows. It simply moves the C files around, and creates symlinks to access them from the top-level directory, rather than doing the opposite. Since there's a C compile script buildall.py that works for all platforms and use cmake (and I'd expect cmake to follow symlinks on Windows), compilation of the C code should still work on Windows, although I can't test it unfortunately. Would be appreciated if someone could do that, please!

@abrown @jlb6740 please take a look.

+10 -18

0 comment

30 changed files

pr created time in 6 days

create barnchbnjbvr/ittapi

branch : reorganize-files

created branch time in 6 days

pull request commentbytecodealliance/regalloc.rs

Make `WritableBase` public and add a blanket implementation

It's a bit unfortunate, because we really wanted to allow random types being used in Writable, at the point of writing. If you just made WritableBase public, would it suffice so that you can add the empty impl for your own defined data structures? (don't think that would conflict with rust's rules)

fitzgen

comment created time in 6 days

issue commentintel/ittapi

Compile ittapi-rs' C code on Windows

A small reorganization of the code could maybe work: the interesting C source files would be moved to the Rust directory, and the C code itself would contain symlinks to those C files. Will try that.

bnjbvr

comment created time in 6 days

more