profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/blowekamp/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

blowekamp/itkOBBLabelMap 3

An ITK external module which extends the LabelMap to include Oriented Bounding Box attributes.

blowekamp/itkScaleSpace 3

An ITKv4 External Module for Scale Space Algorithms and Computation

blowekamp/ITK 2

Insight Toolkit

blowekamp/itkExternalTemplate 2

This module is now maintained in the Insight Software Consortium organization. https://github.com/InsightSoftwareConsortium/ITKModuleTemplate

blowekamp/CXMLTestFramework 1

A Testing Framework which utilized CMake and CDash, which adds support for comparing measurements to baselines.

blowekamp/itkBinaryMorphologyPerformance 1

An external module for ITKv4 which add performance oriented binary morphology filters

blowekamp/itkLocalDiscreteHessian 1

An ITK Module for Discrete Hessian Image Filters

blowekamp/itkPerformance 1

Test to evaluate the performance of ITKv4

blowekamp/CMake 0

CMake, the cross-platform, open-source build system.

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventSimpleITK/SimpleITK.github.io

Azure Release Agent for SimpleITK.github.io

commit sha cf9ce6b272cbf5274cd9a9cca4503bd47085c9be

Doxygen latest updated built from 19e9aa7014e2101561fe5fdf12f95d32f003d601

view details

push time in 2 days

release SimpleITK/SimpleITK

latest

released time in 2 days

push eventInsightSoftwareConsortium/ITK

Bradley Lowekamp

commit sha 63f4ab7dd8389820ed4130b86dd8e9c3b8089e1e

BUG: Fix ImageRegionSplitters with zero sized image When the image had a zero size, undefined results of division by zero occoured. For both the ImageRegionSplitterSlowDimension and the ImageRegionSplitterDirection classes when a region's size is zero, the region has one "split" region of a zero sized region.

view details

Bradley Lowekamp

commit sha a1c484ae73dd51b10908f2780caf3c9cdacbddc2

Merge pull request #2750 from blowekamp/FixZeroImageRegionSplitter BUG: Fix ImageRegionSplitters with zero sized image

view details

push time in 2 days

PR merged InsightSoftwareConsortium/ITK

BUG: Fix ImageRegionSplitters with zero sized image type:Bug type:Testing area:Core area:Filtering

When the image had a zero size, undefined results of division by zero occoured. For both the ImageRegionSplitterSlowDimension and the ImageRegionSplitterDirection classes when a region's size is zero, the region has one "split" region of a zero sized region.

closes #2741 <!-- The text within this markup is a comment, and is intended to provide guidelines to open a Pull Request for the ITK repository. This text will not be part of the Pull Request. -->

<!-- See the CONTRIBUTING (CONTRIBUTING.md) guide. Specifically:

Start ITK commit messages with a standard prefix (and a space):

  • BUG: fix for runtime crash or incorrect result
  • COMP: compiler error or warning fix
  • DOC: documentation change
  • ENH: new functionality
  • PERF: performance improvement
  • STYLE: no logic impact (indentation, comments)
  • WIP: Work In Progress not ready for merge

Provide a short, meaningful message that describes the change you made.

When the PR is based on a single commit, the commit message is usually left as the PR message.

A reference to a related issue or pull request (https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests) in your repository. You can automatically close a related issues using keywords (https://help.github.com/articles/closing-issues-using-keywords/)

@mentions (https://help.github.com/articles/basic-writing-and-formatting-syntax/#mentioning-people-and-teams) of the person or team responsible for reviewing proposed changes. -->

PR Checklist

  • [ ] No API changes were made (or the changes have been approved)
  • [ ] No major design changes were made (or the changes have been approved)
  • [ ] Added test (or behavior not changed)
  • [ ] Updated API documentation (or API not changed)
  • [ ] Added license to new files (if any)
  • [ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • [ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for further development details if necessary.

<!-- Thanks for contributing to ITK! -->

+37 -6

0 comment

5 changed files

blowekamp

pr closed time in 2 days

issue closedInsightSoftwareConsortium/ITK

LabelImageToLabelMapFilter takes a long time to complete on an empty image

<!-- The text within this markup is a comment, and is intended to provide guidelines to open an issue for the ITK repository. This text will not be part of the issue. -->

<!-- Before submitting an issue, please check that your issue has not been already filed. -->

The LabelImageToLabelMapFilter takes a long time to complete on an empty image.

<!-- Description of the bug. -->

The following code snippet can reproduce the bug.

<!--

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Provide a minimal, complete, compilable, and verifiable example (commonly abbreviated as MWE, Minimal Working Example, or sometimes referred to as SSEE, Short, Self Contained, Correct (Compilable) Example, SSCCE) or code snippet, either through a GitHub gist (https://gist.github.com/) or providing your own files (including your source code, CMakeLists.txt file if applicable, and your data) reproducing the issue or showing an incorrect result. -->

 auto p_filter = itk::LabelImageToLabelMapFilter<itk::Image<unsigned char, 3>>::New();
 auto p_image = itk::Image<unsigned char, 3>::New();
 p_image->SetRegions(itk::Size<3>{ 0, 0, 0 });
 p_image->Allocate(true);

 p_filter->SetInput(p_image);     
 p_filter->Update(); 

<!-- What you expect to happen. -->

Takes about 16 seconds to complete on my PC.

<!-- What actually happens. Include the relevant build error trace. -->

Reproducibility

<!-- What percentage of the time does it reproduce? -->

ITK version 5.1.2

<!-- If a tagged version, you can get this information by inspecting the ITK_VERSION_MAJOR ITK_VERSION_MINOR and ITK_VERSION_PATCH variable values in the ITKConfig.cmake file.

If the commit number is required, run $ git rev-parse --short HEAD. -->

Windows, CMake 3.18.2, Visual Studio 16.7.2

<!-- Which your OS, CMake, and compiler versions are, or your Python and installed package versions are. -->

Additional Information

<!-- Any additional information, configuration or data that might be necessary to reproduce the issue. -->

<!-- Note: Use issues for their purpose; issues are not for code help. Need help? Ask your question at ITK discourse (https://discourse.itk.org/). -->

closed time in 2 days

Janneke80

push eventblowekamp/ITK

Bradley Lowekamp

commit sha 63f4ab7dd8389820ed4130b86dd8e9c3b8089e1e

BUG: Fix ImageRegionSplitters with zero sized image When the image had a zero size, undefined results of division by zero occoured. For both the ImageRegionSplitterSlowDimension and the ImageRegionSplitterDirection classes when a region's size is zero, the region has one "split" region of a zero sized region.

view details

push time in 3 days

Pull request review commentInsightSoftwareConsortium/ITK

BUG: Fix ImageRegionSplitters with zero sized image

 itkLabelImageToLabelMapFilterTest(int argc, char * argv[])    conversion->Print(std::cout); +  zeroSizeCase();

done

blowekamp

comment created time in 3 days

PullRequestReviewEvent

push eventblowekamp/ITK

Bradley Lowekamp

commit sha aaa3e44e5d40cb528dab056f550a95519e5eff0f

BUG: Fix ImageRegionSplitters with zero sized image When the image had a zero size, undefined results of division by zero occoured. For both the ImageRegionSplitterSlowDimension and the ImageRegionSplitterDirection classes when a region's size is zero, the region has one "split" region of a zero sized region.

view details

push time in 3 days

PR opened InsightSoftwareConsortium/ITK

Reviewers
BUG: Fix ImageRegionSplitters with zero sized image

When the image had a zero size, undefined results of division by zero occoured. For both the ImageRegionSplitterSlowDimension and the ImageRegionSplitterDirection classes when a region's size is zero, the region has one "split" region of a zero sized region.

closes #2741 <!-- The text within this markup is a comment, and is intended to provide guidelines to open a Pull Request for the ITK repository. This text will not be part of the Pull Request. -->

<!-- See the CONTRIBUTING (CONTRIBUTING.md) guide. Specifically:

Start ITK commit messages with a standard prefix (and a space):

  • BUG: fix for runtime crash or incorrect result
  • COMP: compiler error or warning fix
  • DOC: documentation change
  • ENH: new functionality
  • PERF: performance improvement
  • STYLE: no logic impact (indentation, comments)
  • WIP: Work In Progress not ready for merge

Provide a short, meaningful message that describes the change you made.

When the PR is based on a single commit, the commit message is usually left as the PR message.

A reference to a related issue or pull request (https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests) in your repository. You can automatically close a related issues using keywords (https://help.github.com/articles/closing-issues-using-keywords/)

@mentions (https://help.github.com/articles/basic-writing-and-formatting-syntax/#mentioning-people-and-teams) of the person or team responsible for reviewing proposed changes. -->

PR Checklist

  • [ ] No API changes were made (or the changes have been approved)
  • [ ] No major design changes were made (or the changes have been approved)
  • [ ] Added test (or behavior not changed)
  • [ ] Updated API documentation (or API not changed)
  • [ ] Added license to new files (if any)
  • [ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • [ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for further development details if necessary.

<!-- Thanks for contributing to ITK! -->

+38 -6

0 comment

5 changed files

pr created time in 3 days

create barnchblowekamp/ITK

branch : FixZeroImageRegionSplitter

created branch time in 3 days

issue commentInsightSoftwareConsortium/ITK

LabelImageToLabelMapFilter takes a long time to complete on an empty image

I'm looking into this issue now...

Janneke80

comment created time in 3 days

push eventrickardcronholm/SimpleITK

Bradley Lowekamp

commit sha 744d11be3bb1c0526f881017dc206aad30fc1a86

Update Doxygen Docker image to use ubuntu 20.04 ITK 5.3 require CMake>=3.16.4. This requirement is available by default in Ubunut 20.04.

view details

Bradley Lowekamp

commit sha 7023c17d56ce841e9e10297c9618191e0e974097

Merge pull request #1456 from blowekamp/UpdateDoxygenDocker Update Doxygen Docker image to use ubuntu 20.04

view details

Bradley Lowekamp

commit sha bc32727f0dc3165581832f3189c137abebb98974

Add missing DICOM series external data.

view details

Rickard Cronholm

commit sha dcdb6693804134149b4f6d4cd47e434670ca4e1f

Changed DBUILD_EXAMPLES option to correct variable

view details

push time in 3 days

push eventSimpleITK/SimpleITK

Bradley Lowekamp

commit sha c818d7d998b85d01db116359311774435d4f94ea

Use manylinux2010's cmake version The base docker image contains an up todate cmake installation. The SimpleITK build has been using this and not the custom installed version.

view details

Bradley Lowekamp

commit sha cf96b90705ce8f199f8efc7ac44c812d2446513e

Remove old manylinux1 builds The manylinux1 base images are based on the old centos 5. We are unable to install the CMake >=3.16.5 version for ITK 5.3.

view details

Bradley Lowekamp

commit sha 19e9aa7014e2101561fe5fdf12f95d32f003d601

Merge pull request #1458 from blowekamp/Update_manylinux Update manylinux

view details

push time in 3 days

PR merged SimpleITK/SimpleITK

Update manylinux
+0 -34

0 comment

4 changed files

blowekamp

pr closed time in 3 days

issue openedSimpleITK/SimpleITK

Build Python many linux2014 wheels for packaging.

https://github.com/pypa/manylinux

created time in 4 days

pull request commentSimpleITK/SimpleITK

Changed DBUILD_EXAMPLES option to correct variable

I'll look into this further today.

rickardcronholm

comment created time in 4 days

push eventblowekamp/SimpleITK

Bradley Lowekamp

commit sha dfd4d6a3ff432f7d5671312c3a5bb848c15bd3b1

Set SimpleITK libraries to cxx_std_14 This matches the requirements of ITK 5.3

view details

Bradley Lowekamp

commit sha 05991b8ca2d480fdd1ef93bba27351098244eb3a

Update ITK superbuild version to v5.3.rc01

view details

Bradley Lowekamp

commit sha 34794c64dee565ead754d29a2bb2e631eddb1386

Changing expected number of iterations for LBFGS2 test This change in behavior appears to be related to the following ITK change: c34fb54e10ad4cfbb44d0507e2bb693bf9467259

view details

Jens-Peter Tuppatsch

commit sha a69afd18f201c5b0be4bd04f1a82cff82266a7aa

added files

view details

Dave Chen

commit sha 77d3f26dc63684bf0a2e352e2ed458637f5b9de3

removed old file

view details

Jens-Peter Tuppatsch

commit sha 5da1d1bff12e08b6150e89bff327dc504eeabe08

changed minimum number of in's to fulfill both test scenarios

view details

Bradley Lowekamp

commit sha a4bda54e9361b50a2a73f3eecece4c77887d1d73

On AZP Default CentOS agents use devtoolset-7 The default tool change is no longer supported by ITK.

view details

Bradley Lowekamp

commit sha d4819492cc779504c0b4b388ce99b8944ec83ebd

Merge pull request #1450 from blowekamp/UpdateITKv5.3rc1 Update ITK superbuild version to v5.3.rc01

view details

Dave Chen

commit sha 5534eb230e9605313a08cdd529cd26d3594691b6

fixed comment typo

view details

Dave Chen

commit sha 6850980606e5f0c09af29379181aea72c0cd9c2a

Merge pull request #766 from pettaa123/getSetBufferExample added setBuffer to getBuffer example

view details

Bradley Lowekamp

commit sha 7023c17d56ce841e9e10297c9618191e0e974097

Merge pull request #1456 from blowekamp/UpdateDoxygenDocker Update Doxygen Docker image to use ubuntu 20.04

view details

Bradley Lowekamp

commit sha c818d7d998b85d01db116359311774435d4f94ea

Use manylinux2010's cmake version The base docker image contains an up todate cmake installation. The SimpleITK build has been using this and not the custom installed version.

view details

Bradley Lowekamp

commit sha cf96b90705ce8f199f8efc7ac44c812d2446513e

Remove old manylinux1 builds The manylinux1 base images are based on the old centos 5. We are unable to install the CMake >=3.16.5 version for ITK 5.3.

view details

push time in 4 days

Pull request review commentInsightSoftwareConsortium/ITK

ENH: Register/UnRegister only in SmartPointer Con/Destructor.

 namespace itk #define itkSimpleNewMacro(x)                                                                                           \   static Pointer New()                                                                                                 \   {                                                                                                                    \-    Pointer smartPtr = ::itk::ObjectFactory<x>::Create();                                                              \-    if (smartPtr == nullptr)                                                                                           \+    Pointer smartPtr{ ::itk::ObjectFactory<x>::Create() };                                                             \+    if (smartPtr.IsNull())                                                                                             \     {                                                                                                                  \       smartPtr = new x;                                                                                                \     }                                                                                                                  \-    smartPtr->UnRegister();                                                                                            \     return smartPtr;                                                                                                   \   }                                                                                                                    \   ITK_MACROEND_NOOP_STATEMENT  #define itkCreateAnotherMacro(x)                                                                                       \   ::itk::LightObject::Pointer CreateAnother() const override                                                           \   {                                                                                                                    \-    ::itk::LightObject::Pointer smartPtr;                                                                              \-    smartPtr = x::New().GetPointer();                                                                                  \-    return smartPtr;                                                                                                   \+    return ::itk::LightObject::Pointer{ x::New().GetPointer() };                                                       \

Is there a move constructor which could be used here?

Leengit

comment created time in 4 days

PullRequestReviewEvent

pull request commentInsightSoftwareConsortium/ITK

ENH: Register/UnRegister only in SmartPointer Con/Destructor.

Changing the way reference counting is handled during construction of object gives me quite a bit of trepidations.

First, have you run Valgrind with these changes? Otherwise we don't know the reference counting is still working.

Only in the constructors and destructors for the SmartPointer should we invoke the underlying object's Register() or UnRegister() methods to handle the smart pointer reference count. T

I would disagree with this. These have been exposed public API methods since the beginning of ITK and existing code relies on the current interface and behavior. ITK objects can be owned by other objects besides smart pointers.

The code change does not appear to fix any bugs. It seems to just change the existing behavior which ITK developers have relied on. 👎

Perhaps at the next major ITK release the objects interface for smart pointers could be refined but I am opposed to it during minor release changes.

Leengit

comment created time in 4 days

issue commentSimpleITK/SimpleITK

Safe ITK/C++ exception handling in python

Please open a new issue. Please include a minimal reproducible example code, and the output for your problem.

take5v

comment created time in 4 days

create barnchSimpleITK/SimpleITK

branch : Update_manylinux

created branch time in 7 days

push eventSimpleITK/SimpleITK

Bradley Lowekamp

commit sha 744d11be3bb1c0526f881017dc206aad30fc1a86

Update Doxygen Docker image to use ubuntu 20.04 ITK 5.3 require CMake>=3.16.4. This requirement is available by default in Ubunut 20.04.

view details

Bradley Lowekamp

commit sha 7023c17d56ce841e9e10297c9618191e0e974097

Merge pull request #1456 from blowekamp/UpdateDoxygenDocker Update Doxygen Docker image to use ubuntu 20.04

view details

push time in 7 days

PR merged SimpleITK/SimpleITK

Reviewers
Update Doxygen Docker image to use ubuntu 20.04

ITK 5.3 require CMake>=3.16.4. This requirement is available by default in Ubunut 20.04.

+1 -1

0 comment

1 changed file

blowekamp

pr closed time in 7 days

PR opened SimpleITK/SimpleITK

Update manylinux
+1 -35

0 comment

5 changed files

pr created time in 7 days

create barnchblowekamp/SimpleITK

branch : Update_manylinux

created branch time in 7 days