profile
viewpoint
Bjarne Fyrstenborg bjarnef Herning, Denmark Web developer and Umbraco MVP.

bjarnef/color-palettes 5

Color Palettes

bjarnef/color-pickr 1

A simple color picker property editor for Umbraco.

bjarnef/air-datepicker 0

Cool jQuery datepicker

bjarnef/Analytics 0

Google Analytics for the Umbraco CMS for V7 aka Belle & newer only

bjarnef/Archetype 0

Archetype is an Umbraco 7 property editor that wraps other installed property editors.

bjarnef/BundlingAndMinificationForTheMasses 0

UI layer on top of http://aspnetoptimization.codeplex.com/ for Umbraco

bjarnef/CWS-Start 0

This is the new shiny MVC version of Umbraco CWS starter site package

bjarnef/FALM-Housekeeping-v7 0

Package for Umbraco 7 - This package create a new custom section with this tools: Umbraco logs manager, Media folder cleanup, Delete users and Version manager

bjarnef/jquery-facebook-wall 0

jQuery plugin that lets you show the latest updates from your facebook profile og page.

issue commentumbraco/Umbraco.UI

Feature: Color picker

I found this example which could be useful as inspiration: https://shoelace.style/components/color-picker?id=color-picker

bjarnef

comment created time in 11 hours

PullRequestReviewEvent

Pull request review commentumbraco/Umbraco.Cms.Integrations

Hubspot Forms integration.

+<div ng-controller="Umbraco.Cms.Integrations.Crm.Hubspot.FormPickerController as vm">++    <umb-load-indicator ng-if="vm.loading">+    </umb-load-indicator>++    <umb-node-preview ng-if="model.value"+                      name="model.value.name"+                      icon="model.icon"+                      description="model.value.fields"+                      allow-remove="true",++                      on-remove="vm.remove()">+    </umb-node-preview>++    <a ng-if="!model.value && !vm.loading"+       class="umb-node-preview-add"+       href=""+       ng-click="vm.openHubspotFormPickerOverlay()"+       prevent-default>+        <localize key="general_add">Add</localize>+    </a>++    <div ng-if="vm.error" class="alert alert-warning">+        {{ vm.error }}+    </div>++    <umb-overlay ng-if="vm.hubspotFormPickerOverlay.show"+                 model="vm.hubspotFormPickerOverlay"+                 view="vm.hubspotFormPickerOverlay.view"+                 position="right">+    </umb-overlay>

@AndyButland while <umb-overlay> still work, we should instead use editorService or overlayService. I think we only have a single reference left in core using <umb-overlay>.

AndyButland

comment created time in 15 hours

issue commentumbraco/Umbraco.UI

Feature: Color picker

Yes that would be great. I guess the spectrum color area could be a component, e.g. something like this https://iamkulykov.com/vanilla-colorful/

bjarnef

comment created time in 3 days

pull request commentumbraco/Umbraco-CMS

Added copy functionality for data types

Would be useful with more complex datatypes like Grid and Block List editor. https://github.com/umbraco/Umbraco-CMS/discussions/11388

patrickdemooij9

comment created time in 4 days

issue commentumbraco/Umbraco-CMS

Image not in memory cache after deploy

We made a few adjustments to block properties, styling. layout in views and a bit a markup and on a testimonial document type we changes a property using Media Picker 3 to another Media Picker 3 datatype instance using local crops.

image

However none of the changed are related to Master.cshtml and the image property (logo) on a Settings node, where the logo is request in master template.

bjarnef

comment created time in 5 days

issue commentumbraco/Umbraco-CMS

Image not in memory cache after deploy

@nul800sebastiaan I just had this error again today on same project after deployment.

image

Reloading memory cache fixed the issue though, but I am wondering what is causing the error.

image

bjarnef

comment created time in 5 days

issue commentumbraco/Umbraco.UI

Feature request: Color picker

I found this also as inspiration: https://github.com/juchar/color-picker

bjarnef

comment created time in 5 days

issue commentumbraco/Umbraco.Cloud.Issues

Make it possible to change email address for your Cloud account

I just had the need to change email for an existing editor user today as the customer/company has been re-branded, so they wanted to use the new email domain. However this isn't possible to change at the moment. The "Edit your Umbraco ID profile" in user dialog redirects to this page at https://identity.umbraco.com/, but doesn't allow us to change e-mail address.

image

For now we need to invite user using the new email.

hjaltedaniel-umbraco

comment created time in 6 days

pull request commentumbraco/Umbraco-CMS

Set default tree group for core trees

Great, thanks for reviewing this @elit0451 👍

bjarnef

comment created time in 6 days

delete branch bjarnef/Umbraco-CMS

delete branch : v9/feature/core-tree-default-tree-group

delete time in 6 days

issue commentumbraco/Umbraco.UI

Feature request: Color picker

@nielslyngsoe maybe I could find some time to look at this and learn about web components, but if HQ or other from the community want to work on this feel free to start building.

I guess the components should be vanilla JS - or depend on other components, but not external libraries?

Today we use these libraries in property editors:

  • Flatpickr (date picker)
  • noUiSlider (slider)
  • Spectrum (which use tinyColor) (color picker)
bjarnef

comment created time in 6 days

pull request commentumbraco/UmbracoDocs

Added docs for member transfer operations using Umbraco Deploy.

@AndyButland yeah, you're right. A moment I forgot I have already transferred member groups several times as schema data 🙈

AndyButland

comment created time in 7 days

pull request commentumbraco/UmbracoDocs

Added docs for member transfer operations using Umbraco Deploy.

@AndyButland would it be possible in Umbraco Deploy 4.5.0 to configure transfer/restore or member groups only, while not allowing transferring members?

Sometimes we could have a few member groups, where it would be useful to transfer between environments. This would also ensure same Guid/Key. Currently member groups are pretty much Umbraco nodes without any additional properties, but maybe sometime in future it may get additional properties.

AndyButland

comment created time in 7 days

pull request commentumbraco/Umbraco-CMS

Grant access to get all content types

@nul800sebastiaan any chance this can make it to v9.2.0 release? I need this for current project, which is close to release date, but curently editors can't create content templates from create dialog (when moved to content section), although they can create content templates for existing content nodes.

bjarnef

comment created time in 13 days

pull request commentumbraco/Umbraco-CMS

Update RemoveTreeController to use TController

@nul800sebastiaan we should use this instead, so developers can't pass in any type to RemoveTreeController<T>() method just like AddTreeController<T>() where T needs to inherit from ,TreeControllerBase.

bjarnef

comment created time in 13 days

push eventbjarnef/Umbraco-CMS

Bjarne Fyrstenborg

commit sha 582b714c64c884e43f33c1200ea097c034b11ffd

Adjust logic to newer JS syntax

view details

push time in 13 days

PR opened umbraco/Umbraco-CMS

Allow only unpublish in schedule publish overlay if user has permission

Prerequisites

  • [x] I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes https://github.com/umbraco/Umbraco-CMS/issues/11820

Description

Currently when content editors isn't allowed to unpublish a node, the unpublish action isn't shown. However it schedule publish overlay, the editor was still able to set unpublish date.

+94 -41

0 comment

5 changed files

pr created time in 13 days

create barnchbjarnef/Umbraco-CMS

branch : v9/bug/schedule-publish-unpublish

created branch time in 13 days

issue commentumbraco/Umbraco-CMS

Image not in memory cache after deploy

@nul800sebastiaan no I haven't seen it recently. It may be a random bug since it easy to reproduce. I'll keep a eye with the issue and if it should occur again.

bjarnef

comment created time in 13 days

issue commentumbraco/Umbraco-CMS

Scheduled publishing ignores unpublish permission

I can confirm this in v9.2.0-RC as well.

This button at "Unpublish at" should probably be disabled in this scenario and the editor can see if any unpublish date has been set.

If both publish and unpublish not are allowed the "Save & Publish" button isn't shown. However if unpublish is allowed but not publish, it isn't possible to unpublish (maybe this is by design?).

Not sure if there's a use-case where want content editors to unpublish content, but not publish content. It could be critical if the content editor by mistake unpublished content, but then can't publish it again 🙈 If that is the case maybe to toggles should reflect this, so disabling "publish" also disable "unpublish".

lbras

comment created time in 13 days

issue openedumbraco/Umbraco.UI

Feature request: Color picker

Based on some comments here https://github.com/umbraco/Umbraco-CMS/issues/11713 it would be great to have a color picker similar to the current <umb-color-picker> component in Umbraco.

Features

  • Zero dependencies / Vanilla JS
  • Touch support
  • Accessible
  • Alpha channel (opacity)

Nice to have

  • Popup or inline
  • Palette / predefined colors

I found an example here: https://www.npmjs.com/package/color-picker-web-component https://gh.grahamsh.com/color-picker/

created time in 15 days

issue commentumbraco/Umbraco-CMS

Tab Issue When Creating a Block Item

Yeah, the color picker isn't really accessible. Originally Umbraco used Spectrum http://bgrins.github.io/spectrum/ but later updated to use the v2 (fork of the original repository) https://seballot.github.io/spectrum/

It could probably use a button element and toggle the popup. However the palette still isn't navigable from keyboard.

Not sure if HQ has considered something regarding color picker is the UI library yet? or it is worth looking at before backoffice rebuild?

Something I also had in mind when building the Color Pickr package is that I wanted it to include touch support and built on vanilla JS, where I used this project https://github.com/Simonwep/pickr

I also found this accessible color, with touch support and built on vanilla JS: https://github.com/mdbassit/Coloris

However we probably can't replace the existing color picker library used in <umb-color-picker> component without breaking, so if we wanted to use another color picker, it should probably be a new component.

Or it could be a web component in the UI library. Maybe something like this: https://www.npmjs.com/package/color-picker-web-component

https://gh.grahamsh.com/color-picker/

prjseal

comment created time in 15 days

PR opened umbraco/Umbraco-CMS

Use pointer cursor pointer for keyboard shortcuts overview

Prerequisites

  • [x] I have added steps to test this contribution in the description below

Description

I noticed when hover the keyboard shortcuts overview element it no longer use pointer cursor. It is probably caused by either the element was changed or the previous removed styling which added cursor: pointer style to elements with ng-click attribute.

We have now a cursor-pointer class, which we can use here.

+4 -2

0 comment

1 changed file

pr created time in 15 days

PR opened umbraco/Umbraco-CMS

Null check in Examine backoffice search

Prerequisites

  • [x] I have added steps to test this contribution in the description below

Description

I noticed when searching in Examine dashboard using an empty term the search throw and exception, because if use Trim() on null.

+1 -1

0 comment

1 changed file

pr created time in 16 days

PR opened umbraco/Umbraco-CMS

Align tags vertically in content type property component

Prerequisites

  • [x] I have added steps to test this contribution in the description below

Description

I noticed the tags in properties on a content type wasn't really aligned vertically on a content type, so I have adjusted this a bit.

Before

After

image

+5 -4

0 comment

2 changed files

pr created time in 16 days

create barnchbjarnef/Umbraco-CMS

branch : v9/bug/property-tags-alignment

created branch time in 16 days

push eventbjarnef/Umbraco-CMS

Bjarne Fyrstenborg

commit sha 025db57b039345d50e94a29acef782bcb0554489

Fix issue with missing URLs shown in redirect management

view details

Bjarne Fyrstenborg

commit sha be8e7b285bb978158e16ce746002b99c6a137379

Fix incorrect styling of actions in tags editor

view details

push time in 16 days

more