profile
viewpoint

bitjammer/swift 0

The Swift Programming Language

bitjammer/swift-cmark 0

CommonMark parsing and rendering library and program in C

create barnchbitjammer/swift

branch : acgarland/emit-symbol-graph

created branch time in a month

create barnchbitjammer/swift

branch : acgarland/doc-comment-checks

created branch time in a month

delete branch bitjammer/swift

delete branch : acgarland/rdar-64178490-dont-link-private-symbols

delete time in 2 months

push eventapple/swift

Ashley Garland

commit sha ecf8d556e55eeb51b3558fd9f3a5796b2cc47427

[SymbolGraph] Don't link type identifier fragments to private symbols These links will never resolve because the symbols are never emitted in the first place. rdar://64178490

view details

AG

commit sha 528ace83248ba612c6712377cbd2b3b8152ed378

Merge pull request #33374 from bitjammer/acgarland/rdar-64178490-dont-link-private-symbols [SymbolGraph] Don't link type identifier fragments to private symbols

view details

push time in 2 months

PR merged apple/swift

[SymbolGraph] Don't link type identifier fragments to private symbols

These links will never resolve because the symbols are never emitted in the first place.

rdar://64178490

+31 -7

1 comment

4 changed files

bitjammer

pr closed time in 2 months

pull request commentapple/swift

[SymbolGraph] Don't link type identifier fragments to private symbols

@swift-ci Please smoke test

bitjammer

comment created time in 2 months

push eventapple/swift

Ashley Garland

commit sha 635550cd83684193793e74adddbdb79edbb11e38

[SymbolGraph] Check Loc validity before extracting text Hit this crash while walking an `import protocol ...` declaration. Check loc validity before calling `SourceManager::extractText`: there is an assertion at the beginning of this function. rdar://65258208

view details

AG

commit sha 05c33330c95edab5f558d323cd624fb845906943

Merge pull request #33370 from bitjammer/acgarland/rdar-65258208-crash-invalid-loc-extracttext [SymbolGraph] Check Loc validity before extracting text

view details

push time in 2 months

delete branch bitjammer/swift

delete branch : acgarland/rdar-65258208-crash-invalid-loc-extracttext

delete time in 2 months

PR merged apple/swift

[SymbolGraph] Check Loc validity before extracting text

Hit this crash while walking an import protocol ... declaration. Check loc validity before calling SourceManager::extractText: there is an assertion at the beginning of this function.

rdar://65258208

+19 -1

3 comments

3 changed files

bitjammer

pr closed time in 2 months

pull request commentapple/swift

[SymbolGraph] Check Loc validity before extracting text

Thank you!

bitjammer

comment created time in 2 months

pull request commentapple/swift

[SymbolGraph] Check Loc validity before extracting text

@swift-ci Please smoke test

bitjammer

comment created time in 2 months

PR opened apple/swift

Reviewers
[SymbolGraph] Don't link type identifier fragments to private symbols

These links will never resolve because the symbols are never emitted in the first place.

rdar://64178490

+31 -7

0 comment

4 changed files

pr created time in 2 months

pull request commentapple/swift

[SymbolGraph] Check Loc validity before extracting text

@nathawes It looks like you changed this code not too long ago; can you check this please? I hit this while walking to an ImportDecl for an import protocol M.X decl.

bitjammer

comment created time in 2 months

PR opened apple/swift

Reviewers
[SymbolGraph] Check Loc validity before extracting text

Hit this crash while walking an import protocol ... declaration. Check loc validity before calling SourceManager::extractText: there is an assertion at the beginning of this function.

rdar://65258208

+19 -1

0 comment

3 changed files

pr created time in 2 months

push eventbitjammer/swift

Ashley Garland

commit sha 635550cd83684193793e74adddbdb79edbb11e38

[SymbolGraph] Check Loc validity before extracting text Hit this crash while walking an `import protocol ...` declaration. Check loc validity before calling `SourceManager::extractText`: there is an assertion at the beginning of this function. rdar://65258208

view details

push time in 2 months

pull request commentapple/swift

[build] Remove unemployed 'skip-{build,test}-*' flags from build-script-impl

I haven't edited this file since it was reorganized some years ago. I recommend asking @shahmishal if he or someone else can review on this one. Thanks!

buttaface

comment created time in 3 months

more