profile
viewpoint

bitcoinuser/zap-android 1

Native android lightning wallet focused on user experience and ease of use ⚡️

bitcoinuser/BlueWallet 0

Bitcoin thin client for iOS & Android. Built with React Native

bitcoinuser/browser-laptop 0

Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux

bitcoinuser/rwallet 0

The RSK Wallet is based on our rWallet open-source code-base, which will allow developers and organizations to use it to build their own apps.

push eventmoney-on-chain/py_Moneyonchain

mulonemartin

commit sha 51039bf789fcaf3d07e5204b9098a971362375e9

Events refactor

view details

push time in 7 minutes

pull request commentrsksmart/rskj

Apply LGTM code suggestions

Kudos, SonarCloud Quality Gate passed!

<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Bugs
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Vulnerabilities
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Security Hotspots
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Code Smells

<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/40.png' alt='42.9%' width='16' height='16' /> 42.9% Coverage
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' /> 0.0% Duplication

nagarev

comment created time in 7 minutes

pull request commentrsksmart/rskj

Apply LGTM code suggestions

This pull request fixes 5 alerts when merging 23cedfa829ea6390811c6402079086cd95aedb1b into 106c2cdf7ab4556ca7f4011612a6c0259bb25459 - view on LGTM.com

fixed alerts:

  • 3 for Implicit narrowing conversion in compound assignment
  • 2 for Inconsistent equals and hashCode
nagarev

comment created time in 10 minutes

push eventrsksmart/rskj

Nazaret Garcia

commit sha 23cedfa829ea6390811c6402079086cd95aedb1b

Adding explicit cast

view details

push time in 18 minutes

pull request commentrsksmart/rskj

Apply LGTM code suggestions

Kudos, SonarCloud Quality Gate passed!

<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Bugs
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Vulnerabilities
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Security Hotspots
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Code Smells

<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='75.0%' width='16' height='16' /> 75.0% Coverage
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' /> 0.0% Duplication

nagarev

comment created time in 23 minutes

pull request commentrsksmart/rskj

Apply LGTM code suggestions

This pull request fixes 2 alerts when merging ac3f77443e28b4e116275fb960c60c536aee5129 into 106c2cdf7ab4556ca7f4011612a6c0259bb25459 - view on LGTM.com

fixed alerts:

  • 2 for Inconsistent equals and hashCode
nagarev

comment created time in 25 minutes

PR opened rsksmart/rskj

Apply LGTM code suggestions

<!--- Provide a general summary of your changes in the Title above -->

Description

<!--- Describe your changes in detail -->

Applying some code suggestions from LGTM plugin.

Motivation and Context

<!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. -->

Improve code quality in general.

How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, tests ran to see how --> <!--- your change affects other areas of the code, etc. -->

Using Unit Tests

Types of changes

<!--- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Requires Activation Code (Hard Fork)
  • Other information:
+15 -0

0 comment

2 changed files

pr created time in 33 minutes

create barnchrsksmart/rskj

branch : apply-lgtm-suggestions

created branch time in 40 minutes

push eventDistributedCollective/governance-dapp

Rytis Grincevicius

commit sha 3d1045f431fbe59235b74dfdd0f3d5c79d991bdd

Delegation - remove default address from input field and make it blank

view details

push time in an hour

push eventDistributedCollective/Sovryn-smart-contracts

David Haller

commit sha e84b3bad0a3363b2977dfe42a4271a5651423877

Updating Test for forwarding

view details

push time in 2 hours

issue commentgetumbrel/umbrel

Bounty: Mastodon app for Umbrel

Hey guys just wanted to chime in to clear up a few things.

Firstly @ronnicek / @esackbauer just wanted to address the security concerns you raised.

I feel that adding application which have nothing to do with Bitcoin can bring more security issues (or at least extend attack surface)

Apps in Umbrel are isolated at both the filesystem and execution level. One app can't read files from another app or execute binaries in the same context as another app. One compromised app cannot easily compromise another app. We are also working on taking this further to implement network level isolation, so one app can't even ping another app unless it has been specifically allowed access to it.

But it does add a lot of dependencies, doesn't it? Nginx proxy, hardware resources, network layout etc.etc.

The way Umbrel apps work is that they are installed on the fly at runtime, just like the app store on your phone. If you haven't installed an app on your device, none of it's code/binaries/dependencies exist on your device. You are not open to any extra attack surface if you don't install extra apps.

In terms of whether we will or will not specifically support Mastodon, we're open minded and always listening to user feedback. The generous bounty from @WhiteRabbitBTC is definitely a great signal to us that there's demand for Mastodon. However, the most commonly requested apps so far have been Dojo, Whirpool, LNDHub, mempool.space, and LNbits. So for now we want to keep the app store focused only around Bitcoin/LN apps.

WhiteRabbitBTC

comment created time in 2 hours

issue commentgetumbrel/umbrel

Connect() to 10.21.21.11:9050 failed after select(): Connection refused (111)

Oh!!! What a blunder I made... Disk space was not sufficient. Issue solved!

bhaskarndas

comment created time in 2 hours

push eventDistributedCollective/Sovryn-smart-contracts

David Haller

commit sha 12c4937f3e011cda92a79c4d53cddea856b9016d

Adding ForwardingContract test

view details

David Haller

commit sha b1f69e7d260b62868ad1d498198416b036f4a24e

closeWithDepositWithSig and getHash new method added

view details

David Haller

commit sha abdf3eabcaabd49d3f02fffe1b7cf3c14acaf78f

Forwarding contract

view details

David Haller

commit sha 966887fbb0e0a4e0d1378ab3772d665aa1813073

Signature Library

view details

David Haller

commit sha 19d33708b3cad33268a343b62c24dd0c07d4fe12

Adding new method closeWithDepositWithSig and getHash

view details

David Haller

commit sha b8620dfffc88c2da8b273ac6381378ef65e8b705

Change in swapExternalEvent and _swapsCall

view details

David Haller

commit sha cc0d2909d8d8c30be0a6a0989b71b1b666be2372

little change in internalSwap() method Minted tokens goes to user address not SwapsImplLocal

view details

David Haller

commit sha 9f289d3a8baa1f489785392850ea3af52daf3f42

Truffle configuration file

view details

David Haller

commit sha 23a3ec97763b74dcf49b85ca0361b940db4cf83f

Update truffle-config.js

view details

David Haller

commit sha 26bacc0df445dcc7f304c80da67b803468b63435

Update truffle-config.js

view details

David Haller

commit sha a21d0389584a4582ee23aeab6d2aa87e778df2c0

Update truffle-config.js

view details

David Haller

commit sha c54541318b516046bf98ac8e64be314548eb8405

Delete forwarding.sol

view details

David Haller

commit sha e9f4ebb9346765cefecb1bab99120e9e3f301787

Forwarding Contract

view details

David Haller

commit sha 6e2fcde6905cc8fb7bd0aaf0707fbf4ce987357c

Delete Forwarding.sol

view details

David Haller

commit sha 3f0ce758df58ef2d5df5868a49c8133fcd4418f0

Update truffle-config.js

view details

David Haller

commit sha 7263136541854abcb2cdb6f1ce2434435fff4c20

Creating Forwarding Contract

view details

David Haller

commit sha 7606b008bbc3f3f6b82dcef25b55ba119dfd7df0

Delete truffle-config.js

view details

David Haller

commit sha 22886772012e98669e12fd1c10061b85a548affe

Add files via upload

view details

David Haller

commit sha b6bf039dac34b170e8bbc39f3a40ad93eef5249f

Creating Forwarding Contract

view details

David Haller

commit sha f0c25fa8063310527b5a540142721ca56b01d3e5

Add files via upload

view details

push time in 2 hours

push eventDistributedCollective/Sovryn-smart-contracts

James Howlett

commit sha 094c828fd08a3faec3041feeee3c46f8a189f143

active governorAcceptAdmin

view details

push time in 2 hours

pull request commentACINQ/eclair

Update relay fees from eclair.conf

Codecov Report

Merging #1673 (2712924) into master (81f15aa) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1673      +/-   ##
==========================================
+ Coverage   85.95%   85.97%   +0.01%     
==========================================
  Files         151      151              
  Lines       11474    11483       +9     
  Branches      495      495              
==========================================
+ Hits         9863     9873      +10     
+ Misses       1611     1610       -1     
Impacted Files Coverage Δ
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 86.19% <100.00%> (+0.28%) :arrow_up:
...main/scala/fr/acinq/eclair/router/Validation.scala 91.41% <0.00%> (-1.50%) :arrow_down:
...nq/eclair/blockchain/electrum/ElectrumWallet.scala 80.25% <0.00%> (-0.26%) :arrow_down:
...clair/blockchain/electrum/ElectrumClientPool.scala 82.79% <0.00%> (+4.30%) :arrow_up:
t-bast

comment created time in 3 hours

push eventDistributedCollective/Sovryn-frontend

pietro-maximoff

commit sha 984b4c5b9edb2860ee559a8679d479e2e07da33a

[salesPage] - add metamask sov tutorial

view details

pietro-maximoff

commit sha 8b54ea85a67c8bcd7d0ccb7a70484dde17fab4a6

[salesPage] - added loader for email and code requests

view details

Pietro MaximOFF

commit sha 709186556c06d058c2dab7236ef24aed9557a08c

Merge pull request #240 from DistributedCollective/feat/sale-hotfix Feat/sale hotfix

view details

push time in 3 hours

PR opened ACINQ/eclair

Update relay fees from eclair.conf

If the eclair.conf changes while we're offline, we want to apply the fee changes to existing channels once they come back online.

+11 -2

0 comment

1 changed file

pr created time in 3 hours

create barnchACINQ/eclair

branch : update-relay-fee-from-conf

created branch time in 3 hours

issue commentACINQ/phoenix

Failure during top-up freshly created Phoenix wallets from e.g. LND via: lncli payinvoice

Thanks for the details, it's helpful. It looks like there is an issue on your lnd.

For your first attempt (the new Phoenix), we have updated the channel's relay_fees (the proportional fee was previously 0.01% and it's now 0.025%. Our node tells that to your lnd (through the FEE_INSUFFICIENT error), but your lnd node doesn't retry with this new fees taken into account.

Can you investigate why your node doesn't retry with the updated fees? That seems to be the culprit.

jk14

comment created time in 3 hours

pull request commentACINQ/eclair

Shutdown and UpdateFee should not be intertwined

I think there is also this scenario, where the fundee initiates the close

Done in https://github.com/ACINQ/eclair/pull/1661/commits/838d2d4a7c52069d4f08e5c49155ed335b15ced6 It showed that the channel code was not handling this correctly. It's a subtle change, I'm not 100% sure I got it right.

t-bast

comment created time in 3 hours

push eventACINQ/eclair

Bastien Teinturier

commit sha 7343283f9fe90773c6659d0ec35ceecafa6c3b9d

Add test for duplicate temporary channel id (#1660) This scenario was correctly handled, but we were missing test coverage.

view details

Bastien Teinturier

commit sha 629c2e69cad54b07b602252b575e6a9203d498c3

Fix rare race conditions in integration tests (#1653) When a channel goes to the CLOSED state, the actor will stop itself. We were previously sending messages to the actor asking for its state, which returns a failure when the actor is stopped. We can simply listen to state events to safely get the same result.

view details

Bastien Teinturier

commit sha b477d179ea0572672d93849a9c260ca91130819f

Update build instructions for front (#1658) It seems like we need to compile eclair-core's tests for the front (but we don't require running them). Fixes #1657

view details

Bastien Teinturier

commit sha e369ba9a1e419e7a3fe4af240fc5d38904ee1f58

More aggressively re-emit private channel updates (#1671) We had a delay mechanism before re-enabling reconnected channels to avoid creating frequent channel updates on flappy connections and flooding the network with unnecessary gossip. We don't need this protection for private channels since they're not gossiped to the rest of the network. And in the case of private channels to mobile wallets, we don't want to add any delay, otherwise the reconnected channel will not be in the router's graph and we'll have issues routing payments to that wallet (especially if they quickly disconnect, before our 10-seconds delay).

view details

Bastien Teinturier

commit sha d40b321d92895ac09222de84ebd7dd9095c8af20

Blockchain watchdogs use unique actor name (#1667) Actor names cannot conflict. Even though blockchain watchdog actors stop themselves after fetching block data, when blocks are found in a short interval, we may end up with multiple actors of the same type simultaneously alive, so we need them to have unique names. The blockcount isn't sufficient to make their names unique because forks can happen. Fixes #1665

view details

Bastien Teinturier

commit sha 9c4ab7d923a8e6947689c0129a2bfc6169aff657

Fix HTLC fulfill race condition in integration spec (#1666) We were extracting F's commit tx from its internal state right after receiving the `PaymentSent` event. The issue is that this could happen before the fulfill was completely signed on both sides, so the commit tx we obtained would still contain the HTLC and would be different from the one F would publish when closing.

view details

Bastien Teinturier

commit sha 81f15aabd99c8aaa0e6c418b9ff80ac7fb682bce

Refactor and improve some channel tests (#1654) * Add a few more tests around channel_reestablish scenarios. * Enrich existing tests and refactor common parts.

view details

t-bast

commit sha a471c5a9fe7164dedb123b79bb2413271cf66069

Don't update fee if shutdown sent If we restart after having initiated a shutdown, it doesn't make sense to update the fees of the commit tx.

view details

t-bast

commit sha 1df0d9c7a7fc975e08e2e9456ff34a44ee15184a

Don't send shutdown with unsigned fee update Same as with unsigned outgoing htlcs, if we've sent an update_fee but haven't signed it yet, we should not initiate the shutdown phase. The caller should probably retry the CMD_CLOSE (in a loop with delays).

view details

t-bast

commit sha f6e5cf013a92afc773dede5a7dbec9bf6bd9136a

Add test for first commit

view details

t-bast

commit sha 838d2d4a7c52069d4f08e5c49155ed335b15ced6

Handle additional case

view details

push time in 3 hours

pull request commentlightningnetwork/lightning-rfc

BOLT 1: make errors default to "soft" errors.

Interesting, eclair also defaults to fatal errors and closes channels when they happen, so old eclair will keep treating all errors as fatal regardless of the tlv flag. When the fatal TLV is missing, updated nodes will still want to consider these errors fatal and close the channel.

I think a separate (odd) message would be more appropriate, as it would work out of the box for non-upgraded nodes (they would simply ignore it so won't close a channel).

rustyrussell

comment created time in 4 hours

issue commentgetumbrel/umbrel

Bounty: Mastodon app for Umbrel

I would check out this implementation if you wanted something that works with the fediverse.

WhiteRabbitBTC

comment created time in 4 hours

issue commentACINQ/phoenix

Failure during top-up freshly created Phoenix wallets from e.g. LND via: lncli payinvoice

P.S. and both Phoenix wallets are in version: "1.4.5 (20)"

jk14

comment created time in 4 hours

issue commentACINQ/phoenix

Failure during top-up freshly created Phoenix wallets from e.g. LND via: lncli payinvoice

I just made quite fresh test, then:

fresh wallet payment hash: 251cc8a9a44c4a993fbf930ccd64b8480d1d252332af21231cd02bae06ddfed6 older wallet payment hash: 8b5dfd91df6a2acae5eac8690004e87a8ca32e3d4e6cb6409d869282c22a8bb2

root@vmi:~# lncli payinvoice lnbc101u1psq0ucapp5y5wv32dyf39fj0aljvxv6e9cfqx36ffrx2hjzgcu6q46upkalmtqdqqxqyjw5q9qtzqqqqqq9qsqsp5ezttdx3s297sgdm9q2sxuv2clnw5elhjnh8qydfp0rjqtwdc0hxsrzjqwryaup9lh50kkranzgcdnn2fgvx390wgj5jd07rwr3vxeje0glcllc9cmh5whunlsqqqqlgqqqqqeqqjq05sgpsdrnk29hwklttwtx3k6sgt3lhzyre3r8tdlhl3y2q87p9hpns38asl94ese8q07r2avc75gu73wrd2ctn4fhsu2cgfkkwhs65gpt67v7k Payment hash: 251cc8a9a44c4a993fbf930ccd64b8480d1d252332af21231cd02bae06ddfed6 Description: Amount (in satoshis): 10100 Fee limit (in satoshis): 10100 Destination: 02a81fefd5470a06b5b181380e66ff390160686de9f65d9be01405c6ef475f93fc Confirm payment (yes/no): yes +----------------------+--------------+--------------+--------------+------+----------+--------------------+---------------+ | HTLC_STATE | ATTEMPT_TIME | RESOLVE_TIME | RECEIVER_AMT | FEE | TIMELOCK | CHAN_OUT | ROUTE | +----------------------+--------------+--------------+--------------+------+----------+--------------------+---------------+ | FEE_INSUFFICIENT @ 1 | 1.460 | 7.927 | 10100 | 2.01 | 667034 | 732272545264959489 | ACINQ->02a81f | | FEE_INSUFFICIENT @ 1 | 8.048 | 11.283 | 10100 | 2.01 | 667034 | 732272545264959489 | ACINQ->02a81f | +----------------------+--------------+--------------+--------------+------+----------+--------------------+---------------+ Amount + fee: 0 + 0 sat Payment hash: 251cc8a9a44c4a993fbf930ccd64b8480d1d252332af21231cd02bae06ddfed6 Payment status: FAILED, reason: FAILURE_REASON_NO_ROUTE [lncli] FAILED root@vmi:~# lncli payinvoice lnbc102u1psq0u73pp53dwlmywldg4v4e02ep5sqp8g02x2xt3afektvsyas6fg9s323weqdqqxqyjw5q9qtzqqqqqq9qsqsp5nmqhner6kanu62ajfv8jh7zwyflxn8kx7qlyqpa25yc7fhz233vsrzjqwryaup9lh50kkranzgcdnn2fgvx390wgj5jd07rwr3vxeje0glcll6vs4fl73vr4gqqqqlgqqqqqeqqjqx8k89v60p884dp0uhay4pyzkhrw0tg7vfqv70xcnw6wl539uq9pj8e3xsyqjq7f4ry5qu2ynpche2a6u9ac4tz8lzvnf5vpqemmg70gq7n4yep Payment hash: 8b5dfd91df6a2acae5eac8690004e87a8ca32e3d4e6cb6409d869282c22a8bb2 Description: Amount (in satoshis): 10200 Fee limit (in satoshis): 10200 Destination: 023a4c09e9fbfffad181dd06f933a566919de32b4d10da5852224c8553ff4583aa Confirm payment (yes/no): yes +-------------------------------+--------------+--------------+--------------+--------+----------+--------------------+-----------------------------+ | HTLC_STATE | ATTEMPT_TIME | RESOLVE_TIME | RECEIVER_AMT | FEE | TIMELOCK | CHAN_OUT | ROUTE | +-------------------------------+--------------+--------------+--------------+--------+----------+--------------------+-----------------------------+ | TEMPORARY_CHANNEL_FAILURE @ 1 | 3.806 | 4.466 | 10200 | 3.03 | 667074 | 732626587887337472 | Boltz->ACINQ->023a4c | | SUCCEEDED | 5.598 | 8.546 | 10200 | 20.363 | 667074 | 732629886401445888 | OpenNode.com->ACINQ->023a4c | +-------------------------------+--------------+--------------+--------------+--------+----------+--------------------+-----------------------------+ Amount + fee: 10200 + 20.363 sat Payment hash: 8b5dfd91df6a2acae5eac8690004e87a8ca32e3d4e6cb6409d869282c22a8bb2 Payment status: SUCCEEDED, preimage: 89c59efde0e4b8a25c1f33b8bc08b753069abea5087136197bd279e0b97355e3 root@vmi:~# date Wed 20 Jan 2021 10:16:06 AM CET

jk14

comment created time in 4 hours

pull request commentDistributedCollective/Sovryn-frontend

Feat/sale hotfix

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sovryn/sovryn-dapp/pekr91gpa
✅ Preview: In Progress

pietro-maximoff

comment created time in 5 hours

push eventDistributedCollective/Sovryn-frontend

pietro-maximoff

commit sha 984b4c5b9edb2860ee559a8679d479e2e07da33a

[salesPage] - add metamask sov tutorial

view details

pietro-maximoff

commit sha 8b54ea85a67c8bcd7d0ccb7a70484dde17fab4a6

[salesPage] - added loader for email and code requests

view details

push time in 5 hours

startedbitcoinuser/zap-android

started time in 5 hours

more