profile
viewpoint
Sarah Bird birdsarah @mozilla Austin, TX Happy coder and aspiring data monkey.

aptivate/cmsbootstrap 15

Django-CMS basic theme with Bootstrap to get you started quickly. Low bandwidth and mobile friendly.

aptivate/africawatermap 8

A map of Africa's access to water and sanitation

aptivate/aptivate-monkeypatches 1

Specific monkey patches useful in Django projects.

aptivate/check_apt_last_update 1

A nagios plugin to warn if it is too long since apt update was last run.

aptivate/check_yum_last_update 1

A nagios plugin to warn if it is too long since yum update was last run.

aptivate/climate-content-pool 1

WordPress plugin that uploads posts to the Climate Tagger Content Pool

aptivate/climate-tagger 1

WordPress plugin to suggest tags for your posts, using the Climate Tagger API

aptivate/CodeIgniter 1

EllisLab's Open Source PHP Framework

aptivate/concur 1

Disk imaging GUI (inspired by G4L)

issue openedmozilla/fta

Missing tests - tech debt review

As we're doing some early scrabbling, we're accumulating some tech debt. This is a placeholder for that.

created time in 18 hours

issue openedmozilla/fta

Import all fathom examples

Leverage all the fathom data that's already been collected and import it all.

created time in 18 hours

issue openedmozilla/fta

Build display for a labeled page

created time in 18 hours

issue openedmozilla/fta

Add new models to FTA to build a workflow around assigning labeling tasks

assign labeling tasks, register progress.

created time in 18 hours

issue openedmozilla/fta

Add dimensions to sample info

can be useful in future for doing, say mobile vs desktop viewports.

created time in 18 hours

issue openedmozilla/fta

Build addon that pushes a page save to FTA

created time in 18 hours

issue openedmozilla/fta

Does singlepage overcome freezedry limitations?

created time in 18 hours

issue openedmozilla/fta

Put up app on server

created time in 18 hours

push eventmozilla/fta

Sarah Bird

commit sha 135c162c00cec422062bc88542951c10692efa35

Add reuben's picker. can't get iframe to load.

view details

push time in a day

push eventmozilla/fta

Sarah Bird

commit sha 4e0820760fdd6ca5ec86f2d5a589f4a7b532f4ec

Always read .env file

view details

Sarah Bird

commit sha 85c5b1deaa5a81cb1fdb0d2b78ccfad174b2a867

Add field to note where sample came from

view details

Sarah Bird

commit sha e8b09a33dc06db82ebf232a1c1d4c185ce4e1f0e

Add some more fields and a serializer

view details

Sarah Bird

commit sha e7842304e61edae5259624e422e3473cfb6418d5

Add a page to add a sample

view details

Sarah Bird

commit sha 815068b967dce856a60ea13768445edcdaf6ec65

Add placeholder for labeling interface

view details

push time in a day

push eventmozilla/fta

Sarah Bird

commit sha 146e26b93b19fe25226b31134c4fb4138cd8c728

Update README

view details

push time in 2 days

issue commentmozilla/fx-private-relay

relay icon is giant at https://dcwineanddine.com/

I think we can keep this as a dcwineanddine.com bug. Relay is still causing "bigness" and can't even see icon (As noted by @dholbert). Without relay:

Screenshot from 2020-10-26 12-52-35

With relay:

Screenshot from 2020-10-26 12-52-57

dholbert

comment created time in 2 days

issue commentmozilla/fx-private-relay

[Button] Private relay button makes the email form look broken at joann.com

Note this is a little tricky to reproduce but is reproduceable - ff81, addon v1.4.5.

dholbert

comment created time in 2 days

issue closedmozilla/fx-private-relay

Can't sing up with aliases generated via context menu or button

Affected versions Firefox 79 Firefox Private Relay 1.4.4 (used the AMO version because of the characters number limitation when creating accounts)

Affected platforms Ubuntu 18.04 Mac OS X 10.5 Windows 10

Steps to reproduce:

  1. Launch Firefox.
  2. Install the Firefox Private Relay add-on and SIgn in
  3. Navigate to Microsoft.com, reach the sign-up form
  4. Create a new account using a generated alias via context menu or by clicking on the "Generate new alias" button from the email field.

Expected behavior A new account should be created.

Actual behavior I get an error stating that "An email address is required". If I generate an account in the Firefox Relay Website, copy and paste it in the email field, then I can create the new account. Please see the screencast for more details.

Affected websites https://www.bing.com https://www.apple.com/

2020-08-14_11h13_00

closed time in 2 days

sbadau

issue closedmozilla/fx-private-relay

Generate new alias button doesn't match the size of the input

Firefox 78.0a1 (2020-05-27) (64-bit) - POP! OS Linux 20.04

https://mythirdbrain.substack.com/p/what-psychedelics-teach-us-about

Screenshot_2020-05-29 Mysterious Drugs that (Re)train Your Mind

closed time in 2 days

valenting

issue commentmozilla/fx-private-relay

Generate new alias button doesn't match the size of the input

Fixed as of v1.4.5, Oct 26, FF81, Linux

Screenshot from 2020-10-26 12-41-51

valenting

comment created time in 2 days

issue closedmozilla/fx-private-relay

The "Private Relay" button is not displayed on the email address field only after the page is refreshed.

Affected versions

  • Firefox 76.0.1
  • Private Relay add-on version 1.3.1

Affected platforms

  • Windows 10
  • Mac OS X 10.14
  • Ubuntu 18.04

Steps to reproduce:

  1. Launch Firefox.
  2. Install the Private Relay add-on
  3. Navigate to nytimes.com and click on the "LOG IN" button.
  4. Click on the "Create one" hyperlink.
  5. Observe the "Email Address" field.

Expected behaviour

  • The "Private Relay" button is displayed on the email address field.

Actual behaviour

  • The "Private Relay" button is not displayed, only after you refresh the page.

Additional notes

  • This happens on: adobe.com, too

closed time in 2 days

obotisan

issue commentmozilla/fx-private-relay

The "Private Relay" button is not displayed on the email address field only after the page is refreshed.

I cannot reproduce this Oct 26 with 1.4.5, FF81, Linux.

obotisan

comment created time in 2 days

issue commentmozilla/fx-private-relay

[Button] Private Relay button is displayed on passwords field

This is reproducible for me on Oct 26 with 1.4.5, FF81, Linux. Note it doesn't happen if 1password addon is active

Screenshot from 2020-10-26 12-35-40

Note that what's happening is relay icon popping on a hidden input field.

sbadau

comment created time in 2 days

issue commentmozilla/fx-private-relay

[Button] Private Relay button is displayed on passwords field

This is reproducible for me on Oct 26 with 1.4.5, FF81, Linux. Note it doesn't happen if 1password addon is active

Screenshot from 2020-10-26 12-35-40

sbadau

comment created time in 2 days

issue closedmozilla/fx-private-relay

Extension breaks newsletter form entry on www.mozilla.org

With the add-on enabled, both the styling and behavior of the newsletter forms on www.mozilla.org are affected:

STR:

1.) Visit https://www.mozilla.org/en-US/ 2.) Scroll down to the newsletter section titled "Love the Web?" 3.) Click on the "Your email address" field to focus it.

Expacted results:

When the email field is focused, the newsletter form should expand to reveal some further options.

Actual results:

The form does not expand, resulting in an unsuccessful first attempt at signup after entering an address and clicking "Sign up now". Also notice how the form styling isn't quite right, with the email field overflowing the parent container.

image

closed time in 2 days

alexgibson

issue commentmozilla/fx-private-relay

Extension breaks newsletter form entry on www.mozilla.org

I believe this is fixed as of Oct 26.

Screenshot from 2020-10-26 12-29-55

alexgibson

comment created time in 2 days

issue commentmozilla/fx-private-relay

Relay address textboxes draw overtop other content.

As you scroll up the newsletter page, the dom adjustment causes the email clobber the page

Screenshot from 2020-10-26 12-17-28

tomprince

comment created time in 2 days

issue commentmozilla/fx-private-relay

Relay address textboxes draw overtop other content.

On github org page:

Screenshot from 2020-10-06 13-36-56

After getting delete modal: Screenshot from 2020-10-06 13-36-56

This appears to be a z-index issue

tomprince

comment created time in 2 days

push eventmozilla/fta

Sarah Bird

commit sha 3f971f45b5a45ac2646558a9e4158cab020c3c4c

Add 1 test, so things are happy

view details

push time in 2 days

push eventmozilla/fta

Sarah Bird

commit sha b5ee8e184c821dba650ef3ea9b3a39e4a83c7f47

Header

view details

push time in 2 days

push eventmozilla/fta

Sarah Bird

commit sha 7a9534bf944086e4f96232c1813d0e3c1d9b75ec

Add samples app

view details

push time in 2 days

push eventmozilla/fta

Sarah Bird

commit sha 2eda0daf15d5401ee5d83cf183e3153feb74be50

Remove unused users app

view details

push time in 2 days

push eventmozilla/fta

Sarah Bird

commit sha 92b5b07a1d3238bbf9f2d22d12158e46a5668abd

Tweak README

view details

Sarah Bird

commit sha 3329662c0b9b2770096ff8eec940b1f426fffa93

Remove unused utility pieces

view details

push time in 3 days

push eventmozilla/fta

Sarah Bird

commit sha fdf6c31ef3c7338516ed020e4d48360e2b72e7ba

Revert "test lint fail" This reverts commit 29edac078c7ef50e3d5675a43c9070d0e494c348.

view details

Sarah Bird

commit sha 375aa9b7ce68b93d106237916f7790c25f72a97d

No docs needed for now.

view details

Sarah Bird

commit sha de0afc512a1d011856495aa7f6d1e4abdafb0fec

Fix things up to our needs

view details

Sarah Bird

commit sha d7a040bf304675e4efce1f6e9d51e42a2894a6de

Update README.md

view details

push time in 3 days

push eventmozilla/fta

Sarah Bird

commit sha 29edac078c7ef50e3d5675a43c9070d0e494c348

test lint fail

view details

push time in 3 days

push eventmozilla/fta

Sarah Bird

commit sha df969699d0ed52637e786c575f2a3b476c710049

Try again with lint run

view details

push time in 3 days

push eventmozilla/fta

Sarah Bird

commit sha 5ea16a6daf29bd570fa761d821a8d47181e55d5c

Try and run pre-commit checks on travis

view details

push time in 3 days

push eventmozilla/fta

Sarah Bird

commit sha 7abc6b781cfa669531bfcad9db97640db63b9778

Add travis badge

view details

push time in 4 days

push eventmozilla/fta

Sarah Bird

commit sha 52af1a7553d3d01d2c42fcd8f4060359b97859cf

Typo travis yaml

view details

push time in 4 days

push eventmozilla/fta

Sarah Bird

commit sha 4c7ddbd11aed601fb7f4d790de250949a8fcc786

Initial commit from cookiecutter-django

view details

push time in 6 days

create barnchmozilla/fta

branch : main

created branch time in 6 days

created repositorymozilla/fta

Fathom Training App - Utils to help with training fathom

created time in 6 days

pull request commentmozilla/fx-private-relay

[WIP] Fix collectstatic

Your suggestion:

  def _verify_jwt_with_fxa_key(req_jwt, private_relay_config):
      if private_relay_config.fxa_verifying_keys == None:
        raise Exception("FXA verifying keys are unavailable.")

seems great. It can cover a variety of settings where we don't have the verifying_keys as opposed to just this json request

Python nits:

  • is None is more idiomatic
  • should it be checking for an empty list?

Can you give me more context about the verifying keys and handling the checks in App setup rather than at runtime. Please explain to me like I don't know, cos I don't. I'm just thinking through where you have multiple instances running as we run a large web service and then some don't spin up because a check fails, but some are already running. What does this mean? What are the implications?

birdsarah

comment created time in 7 days

pull request commentmozilla/fx-private-relay

[WIP] Fix collectstatic

    The exceptions will be logged into Sentry,
    FXA will retry the callbacks until the callback is successful,
    The code in _authenticate_fxa_jwt already tries to call this ready code again, so:
    When the FXA verifying keys are available again (because FXA fixes the server), this code will populate fxa_verifying_keys,
    The callback will process successfully,
    FXA will stop retrying, and finally:
    We'll have a nice fat spike of FXA callback errors in Sentry so we know about it.

This all makes sense. Is there a need to serve a helpful error message back in some way? Maybe that's handled elsewhere I haven't reviewed the code extensively.

birdsarah

comment created time in 8 days

push eventmozilla/fx-private-relay

Sarah Bird

commit sha b2a9fbf04d4ef1c38543fd00fd7f80a926dfe4a0

Do not handle non 200 error code. Co-authored-by: luke crouch <luke.crouch@gmail.com>

view details

push time in 8 days

PR opened mozilla/fx-private-relay

[WIP] Fix collectstatic

This isn't finished I'm not sure what we want to do in the case of a non 200 error code as I don't have enough context, but I believe this solves the problem which I was also able to reproduce locally (presumably because I don't have a full setup yet).

+5 -2

0 comment

1 changed file

pr created time in 13 days

push eventmozilla/fx-private-relay

Sarah Bird

commit sha 4da09f2fcc29740a0dfa340152e9bc00a103e917

Add non 200 error handling for privaterelay/apps.py

view details

push time in 13 days

create barnchmozilla/fx-private-relay

branch : fix-collect-static

created branch time in 13 days

delete branch mozilla/fx-private-relay

delete branch : 687-pg-required

delete time in 13 days

push eventmozilla/fx-private-relay

Sarah Bird

commit sha 6fa1159e22cf789400ddaceab3b24b5411fae884

Fixes 687 (#704) Adds note about libpq requirement.

view details

push time in 13 days

PR merged mozilla/fx-private-relay

Fixes 687

Adds note about libpq requirement.

+5 -0

1 comment

1 changed file

birdsarah

pr closed time in 13 days

push eventmozilla/fx-private-relay

Se Yeon Kim

commit sha 62492e17b1c679a82d308a13189eb93a8e0dc2f7

Show attachment support on text email header

view details

Se Yeon Kim

commit sha 2905aa7032123e0653f3e5bbe3d4af4568f75b17

Show attachment support on html email header

view details

Se Yeon Kim

commit sha e8c41bbdf20e9d4eb22cfb8ce1656feb74ebdfdf

Update messaging on FAQ to support attachment

view details

Se Yeon Kim

commit sha 7e9aa853010b90f64d65fe94e737b99a7bc5ca5b

Merge branch 'master' into messaging-for-attachment-support-and-limits-596

view details

Se Yeon Kim

commit sha 7eaca65c72ff28484ad40d7e2762d6ae5b9fb051

Merge branch 'master' into messaging-for-attachment-support-and-limits-596

view details

Se Yeon Kim

commit sha 1de7ea765fb8acf2a41b9f6bb0897b33a8edc763

Add 150KB limit info on footer and help text

view details

cyril

commit sha 4ef190d32ae9e10f014884894d6278e8bc9a2fa5

Set display-name of From header to quoted-string

view details

Se Yeon Kim

commit sha 24948c870356369b1ab8abe3592f3a0c2a8219c4

Make information have more consistency Co-authored-by: luke crouch <luke.crouch@gmail.com>

view details

Se Yeon Kim

commit sha 794b18da9ba4b1086620671fcb25a34bb47583ac

Make information have more consistency

view details

Se Yeon Kim

commit sha 72ac027ca63a7e6c52c8bf9e1a5592287ad9f8f9

Merge branch 'messaging-for-attachment-support-and-limits-596' of github.com:mozilla/fx-private-relay into messaging-for-attachment-support-and-limits-596

view details

groovecoder

commit sha 86b0d29585582e7ce4f37c592904eff755d8e01d

just need " around the whole From value

view details

luke crouch

commit sha bd7b1c8af392400515f4550103bec4bde4929f67

Merge pull request #689 from mozilla/quoted-string-from-display fix ProtonMail delivery

view details

groovecoder

commit sha 8b7cc5d6404eff0f8c5e82debec864f41050484e

switch from jwt to PyJWT

view details

luke crouch

commit sha 0d1722b5adfd20bb41caba48cc2e90f855566851

Update privaterelay/views.py Co-authored-by: Se Yeon Kim <25109943+say-yawn@users.noreply.github.com>

view details

luke crouch

commit sha 641f691f0ad921caffcf9c2d8b0e1738e7b0ede9

Merge pull request #695 from mozilla/switch-to-pyjwt switch from jwt to PyJWT

view details

luke crouch

commit sha 69f716b2b1b098ebf8492da6428991a6e60610af

Merge pull request #664 from mozilla/messaging-for-attachment-support-and-limits-596 Messaging for attachment support and limits 596

view details

Peter deHaan

commit sha 6f269f40b390e474915f89679517290ec9f84824

Update web-ext dep

view details

Peter deHaan

commit sha b9d3b74111b6fdfb6182db10fd2243dab423f56b

Use plus-sign-white.svg instead of plus-sign.svg

view details

lesley

commit sha 77008d8400996af9a89ef554d6c31f94fb02a7ea

Remove Lockwise from the Bento menu

view details

Lesley Norton

commit sha e2d89c6e622b64910d0ad17dd16eee57fb8c008a

Merge pull request #700 from pdehaan/issue/697 Use plus-sign-white.svg instead of plus-sign.svg

view details

push time in 13 days

pull request commentmozilla/fx-private-relay

Fixes 687

ugh. this pr was a mess apologies. and sorry for the slow reply. i missed a notification somewhere. will fix today.

birdsarah

comment created time in 13 days

issue commentmozilla/fx-private-relay

Relay address textboxes draw overtop other content.

The above image does not capture the full extent of the problem. I'll post more screenshots tomorrow.

tomprince

comment created time in 22 days

issue openedmozilla/fx-private-relay

Addon should suggest alias for the domain on which they were created.

As a user of abine / blur, a feature I've come to expect / rely on is that the blur addon knows on which domain I've used an email previously and it helps me try to fill it.

When I'm on a page where I've previously made an alias, the drop down contains the alias address for me to fill along with the option to create a new address.

Additionally, for some domains I create multiple addresses. In this case, it gives me all the addresses and how long ago I made them (pictured below).

Image from iOS (1)

You can see that the UI also gives me the option to fill any of my forwarding address (image photoshopped for privacy).

Use cases:

  1. Associate an email with a domain: to me associating one email address with one domain is the whole reason I would use a service like blur or relay. My two concerns are tracking and spam. If one address is associated with multiple domains both these use cases are hindered:
  • In the case of spam, I can't simply turn off an address if it's getting useful email from one domain but not from another.
  • In the case of tracking I assume that one domain can have a single identity for me, but I wish to prevent:
    • my data being linked in the case of sites selling my information to one another and using email address as a linkage
    • my data being compromised in the case of a breach
  1. Associate multiple email addresses with a domain. This is an extension of my tracking concerns. There are occasions when one company can still know too much about me if they have a single email address as an identifier. This is often the case when the company is a service company. For example, opentable, chowhound, resy, toasttab, grubhub all provide a technology platform that allows me to interact with restaurants. However, I don't want resy to track me across the multiple restaurants I care to visit both in my home town and when I travel. So I typically make one email address per reservation.

created time in 22 days

issue commentbokeh/ipywidgets_bokeh

UI cluttered while tring to use this library

I'm confused. What's hapepning here @ItamarShDev? It looks like your first picture just didn't finish loading.

ItamarShDev

comment created time in 22 days

PR opened mozilla/fx-private-relay

Fixes 687

Adds note about libpq requirement.

+9 -1

0 comment

3 changed files

pr created time in 22 days

create barnchmozilla/fx-private-relay

branch : 687-pg-required

created branch time in 22 days

pull request commentmozilla/fx-private-relay

Update web-ext dep

LGTM

pdehaan

comment created time in 22 days

issue commentmozilla/OpenWPM

Update references to geckodriver 0.15

Hey @birdsarah, I would like to take on this issue, although it will be my first time contributing to an open source project.

GREAT!

you want me to look through the code/documentation and find any reference of geckodriver 0.15 and just make it say 0.26?

Not quite.

I will also be researching if the limitation is present or not with the updated version of geckodriver.

Yes!

It's my hunch that we can just change geckodriver 0.15 -> 0.26. But, I would like to make sure that where our documentation mentions that there was a specific limitation that was affecting us that either: a) that limitation is gone from geckodriver, or b) that limitation no longer affects OpenWPM because we've changed how OpenWPM works.

PLEASE DON'T HESITATE TO ASK! It would be way to much to expect you to know (b) in particular. Just gathering things and asking them in a PR is enormously valuable. Feel free to open a draft PR early and check in where you have questions.

Don't forget to check the wiki as well. You won't have wiki edit access I believe, so you can just add notes on the PR about wiki pieces that need to be updated.

birdsarah

comment created time in 22 days

issue commentmozilla/fx-private-relay

Increase number of accounts/aliases during beta?

I think the mentality of a limit can be challenging.

Would it be better to say unlimited but make a formal statement about service abuse so no more than n emails per day or some kind of API rate limit type thing that gives us a way to control rogue agents without putting the mental hurdle of "well how many of these do i need" in people's head.

pdehaan

comment created time in 23 days

issue commentmozilla/fx-private-relay

Relay address textboxes draw overtop other content.

Scroll and look at the mailing list signup box on https://www.cjr.org/tow_center_reports/the-guide-to-advertising-technology.php for another example.

Here's a screenshot of that including 1password successfully placing button. 1password uses shadow-dom

Screenshot from 2020-10-05 14-33-36

tomprince

comment created time in 23 days

issue commentmozilla/fx-private-relay

Update version of web-ext

Thank you @pdehaan I should really take the time to understand package.json properly.

birdsarah

comment created time in a month

issue openedmozilla/fx-private-relay

Update version of web-ext

By my understanding, web-ext is specified as greater than 3.2.1 in the package.json but for whatever reason it would only install that version rather than the latest.

3.2.1 didn't work for me similar to https://github.com/mozilla/web-ext/issues/1937.

Propose upping min version to latest 5.1.0

(I'll take this PR)

created time in a month

issue commentmozilla/OpenWPM

Installation of OpenWPM fails on OpenSuSe

No idea. Sorry.

vringar

comment created time in a month

issue openedmozilla/fx-private-relay

List postgres as a requirement

Postgres is not currently on my system (ubuntu 20.04) when I went to pip install requirements I got the following error:

Collecting psycopg2==2.8.4
  Downloading psycopg2-2.8.4.tar.gz (377 kB)
     |████████████████████████████████| 377 kB 33.6 MB/s 
    ERROR: Command errored out with exit status 1:
     command: /home/bird/miniconda3/envs/fx-private-relay/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-qvpsyaze/psycopg2/setup.py'"'"'; __file__='"'"'/tmp/pip-install-qvpsyaze/psycopg2/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-bjel7gxg
         cwd: /tmp/pip-install-qvpsyaze/psycopg2/
    Complete output (23 lines):
    running egg_info
    creating /tmp/pip-pip-egg-info-bjel7gxg/psycopg2.egg-info
    writing /tmp/pip-pip-egg-info-bjel7gxg/psycopg2.egg-info/PKG-INFO
    writing dependency_links to /tmp/pip-pip-egg-info-bjel7gxg/psycopg2.egg-info/dependency_links.txt
    writing top-level names to /tmp/pip-pip-egg-info-bjel7gxg/psycopg2.egg-info/top_level.txt
    writing manifest file '/tmp/pip-pip-egg-info-bjel7gxg/psycopg2.egg-info/SOURCES.txt'
    
    Error: pg_config executable not found.
    
    pg_config is required to build psycopg2 from source.  Please add the directory
    containing pg_config to the $PATH or specify the full executable path with the
    option:
    
        python setup.py build_ext --pg-config /path/to/pg_config build ...
    
    or with the pg_config option in 'setup.cfg'.
    
    If you prefer to avoid building psycopg2 from source, please install the PyPI
    'psycopg2-binary' package instead.
    
    For further information please check the 'doc/src/install.rst' file (also at
    <http://initd.org/psycopg/docs/install.html>).
    
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Fixed with sudo apt install postgres libpq-dev.

created time in a month

issue commentmozilla/fx-private-relay

Automated testing suite for web compat issues

If this could also go to webmail clients to actually walk thru sending/receiving email thru Relay that would be 👨‍🍳 💋 .

I think integration testing the Relay interface should be a separate issue. It's a much easier problem to solve.

say-yawn

comment created time in a month

issue commentmozilla/fx-private-relay

Automated testing suite for web compat issues

@davehunt wondering if you have any opinions on puppetteer vs browsertime vs diy selenium. We're looking to build out a test suite that runs integration tests that checks the performance of an addon.

say-yawn

comment created time in a month

pull request commentbokeh/demo.bokeh.org

Add link to community page in footer

Thank you @pavithraes.

pavithraes

comment created time in 2 months

push eventbokeh/demo.bokeh.org

Pavithra Eswaramoorthy

commit sha 34c2fbcf959b4c46272d04228fb3460c4c41ffbe

Add link to community page in footer

view details

Sarah Bird

commit sha e0f47a3f5e4537719e57e3c8b48ef11aa6f73ea0

Merge pull request #17 from bokeh/pavithraes-patch-1 Add link to community page in footer

view details

push time in 2 months

PullRequestReviewEvent

Pull request review commentmozilla/OpenWPM

Added scripts to set PYTHONUSERSITE

++import json+import os+import shutil+import sys++"""+    Creates env scripts to use PYTHONUSERSITE in our conda env+    Following these instructions on how to set this up:+    https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html#macos-and-linux++    Expected usage:+    ```+    conda activate openwpm+    conda info --json | python deploy_env_scripts.py+    conda activate openwpm+    ```++    This script aims to be plattform independent and idempotent+"""++CONDA_SCRIPT_DIR = "./etc/conda"

I still have a path in my head of how we can support windows. I think it would be good if we didn't add things that inhibit that possibility.

vringar

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentmozilla/OpenWPM

Separate JS instrument config from table

Thanks for doing this @englehardt

englehardt

comment created time in 2 months

issue commentdisconnectme/disconnect-tracking-protection

Add ebaystatic.com to entity list?

@gutmensch I don't think you understand the implications of adding a domain to the entities list. It often has counter-blocking effects as it allows multiple domains to be understood as all being from the same first-party, thereby allowing content that should work together to work together.

As a professional, I will refrain from responding to the rest of your comments. They are, at the least, off-topic for this issue.

birdsarah

comment created time in 2 months

issue commentmozilla/openwpm-crawler

Give redis-box a restart policy

yep. happy to chat here or on matrix.

vringar

comment created time in 2 months

issue commentmozilla/openwpm-crawler

Give redis-box a restart policy

well the redis box is seperate. if you run kubectl delete -f redis-box.yaml you have to go through the process to reset it up and update the crawl.yaml etc.

vringar

comment created time in 2 months

issue commentmozilla/openwpm-crawler

Give redis-box a restart policy

No, I regularly scale down my kubernetes cluster as you described. It's normal for me to want to run a series of crawls. Setting up all the infrastructure over and over again is a pain. So as a cost compromise, I will scale up and down resources as you describe so I'm not just needlessly leaving lots of nodes on for an extended period of time, but I save my self from repeating the same setup over and over again.

vringar

comment created time in 2 months

issue commentmozilla/openwpm-crawler

Give redis-box a restart policy

Sorry, in that particular case I was but I do most of my crawls on GCP

vringar

comment created time in 2 months

issue commentmozilla/openwpm-crawler

Give redis-box a restart policy

I think I just used some kind of redis flush command to do this.

vringar

comment created time in 2 months

Pull request review commentmozilla/OpenWPM

Upgrade to FF79

 #   resource_type HTTP_REQUESTS = {     (-        u'http://localtest.me:8000/test_pages/http_test_page.html',

If we were being purists, would this not be done in a separate PR. Just trying to understand.

vringar

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

push eventmozilla/OpenWPM

Stefan Zabka

commit sha 92d8edad2f68ee4171104e3520d61a3099a811e3

Make CI error out if our tests aren't passing (#729) * Make python tests error out if they aren't passing * Adding missing semicolon * Moved travis script into file This is done to avoid Travis removing all newlines in the file making it unparseable for bash * Fixing travis.sh * Delete test_failure.py Removing intentional test failure. Co-authored-by: Steven Englehardt <senglehardt@mozilla.com>

view details

push time in 2 months

delete branch mozilla/OpenWPM

delete branch : fixing_ci

delete time in 2 months

PR merged mozilla/OpenWPM

Reviewers
Make CI error out if our tests aren't passing

Closes #707

+14 -8

8 comments

2 changed files

vringar

pr closed time in 2 months

issue closedmozilla/OpenWPM

CI can fail but show as green :(

See build:

https://travis-ci.org/github/mozilla/OpenWPM/jobs/706059232

The tests failed spectacularly but because the codecov ran and exited with a 1. The tests showed as passing.

closed time in 2 months

birdsarah

pull request commentmozilla/OpenWPM

Make CI error out if our tests aren't passing

Sweet! r+ from me when the failing test is reversed.

vringar

comment created time in 2 months

pull request commentmozilla/OpenWPM

Added scripts to set PYTHONUSERSITE

I've just seen the tread on matrix so am caught up on your motivations.

vringar

comment created time in 3 months

pull request commentmozilla/OpenWPM

Added scripts to set PYTHONUSERSITE

I don't get this, we already set PYTHONUSERSITE where it's needed to solve the issue: https://github.com/mozilla/OpenWPM/blob/master/scripts/repin.sh#L12-L15

Why is the existing solution insufficient.

vringar

comment created time in 3 months

pull request commentmozilla/OpenWPM

Make python tests error out if they aren't passing

Can we just make this PR self contained. You add a deliberate fail, and then reverse it.

vringar

comment created time in 3 months

pull request commentmozilla/OpenWPM

Make python tests error out if they aren't passing

I'm confused. The tests in that PR are passing. As in, if I go and look at the travis logs, the tests are passing.

vringar

comment created time in 3 months

pull request commentmozilla/OpenWPM

Make python tests error out if they aren't passing

Can you add a commit where the tests fail?

vringar

comment created time in 3 months

pull request commentmozilla/OpenWPM

Update examples for JS instrument settings

Thanks @vringar.

vringar

comment created time in 3 months

push eventmozilla/OpenWPM

Stefan Zabka

commit sha 41023a800a1990e0b4177e1e345bb419d3dac222

Update examples for JS instrument settings (#722) Closes #720

view details

push time in 3 months

delete branch mozilla/OpenWPM

delete branch : javascript_instrumentation_update

delete time in 3 months

PR merged mozilla/OpenWPM

Reviewers
Update examples for JS instrument settings

Closes #720

+9 -8

2 comments

1 changed file

vringar

pr closed time in 3 months

issue closedmozilla/OpenWPM

JS instrumentation

@birdsarah In response to #717:

When I add

browser_params[i]['js_instrument_settings'] = {"window": ["postMessage"]}

to the demo, I get

Traceback (most recent call last):
  File "demo.py", line 45, in <module>
    manager = TaskManager.TaskManager(manager_params, browser_params)
  File "/home/openwpm/OpenWPM/automation/TaskManager.py", line 119, in __init__
    cleaned_js_settings = clean_js_instrumentation_settings(
  File "/home/openwpm/OpenWPM/automation/js_instrumentation.py", line 246, in clean_js_instrumentation_settings
    raise TypeError(
TypeError: js_instrumentation_settings must be a list.               Received {'window': ['postMessage']}


------------------
(program exited with code: 1)
Press return to continue

I get the same error when I use other examples from the documentation: https://github.com/mozilla/OpenWPM#instrumentation-and-data-access

closed time in 3 months

turban1988

issue openedmozilla/domain_utils

Installation instructions should read `domain-utils`

Not pip install domain_utils

created time in 3 months

issue commentmozilla/OpenWPM

JS instrumentation

Assuming, my suggestion above works, I propose updating this issue to be a documentation one to improve the current docs section.

turban1988

comment created time in 3 months

more