profile
viewpoint

bhollis/jsonview 981

A web extension that helps you view JSON documents in the browser.

bhollis/maruku 489

A pure-Ruby Markdown-superset interpreter (Official Repo).

bhollis/aruco-marker 48

JavaScript library for generating Aruco marker images

bhollis/brh-forms 6

Small WinForms controls for "toast" popups, window state management, and hyperlinked labels.

bhollis/middleman-blog 2

Blog engine for Middleman

bhollis/aspnet-imagegallery 1

Simple image gallery control for ASP.NET WebForms.

bhollis/haml 1

HTML Abstraction Markup Language - A Markup Haiku

bhollis/jquery-ujs 1

Ruby on Rails unobtrusive scripting adapter for jQuery

bhollis/middleman 1

Hand-crafted frontend development

issue closedDestinyItemManager/DIM

TypeError: Cannot read property 'currentActivityHash' of undefined

https://sentry.io/organizations/destiny-item-manager/issues/2029433142/?referrer=github_plugin

TypeError: Cannot read property 'currentActivityHash' of undefined
  at None (./src/app/active-mode/Views/CurrentActivity.tsx:36:59)

closed time in a few seconds

bhollis

issue commentDestinyItemManager/DIM

TypeError: Cannot read property 'currentActivityHash' of undefined

was resolved in #6249

bhollis

comment created time in a few seconds

push eventDestinyItemManager/DIM

Kyle Shay

commit sha 2f1e6a5acc3998ae9556342c7453f1a2a0f233ed

handle some additional cases for 0 or undefined hash

view details

push time in 8 minutes

PR opened DestinyItemManager/DIM

fix some sentry errors that have been firing related to active mode

Hopefully should fix the hashLookupFailure: DestinyActivityDefinition[0] issue

https://sentry.io/organizations/destiny-item-manager/issues/2071121558/?project=279673&query=is%3Aunresolved&statsPeriod=14d

+7 -2

0 comment

2 changed files

pr created time in 14 minutes

create barnchDestinyItemManager/DIM

branch : sentryactivmode

created branch time in 15 minutes

pull request commentDestinyItemManager/DIM

Always hide kill tracker perk in new perk display

for context, here is what the old perk display does: https://github.com/DestinyItemManager/DIM/blob/master/src/app/item-popup/ItemSocketsGeneral.tsx#L122

kyleshay

comment created time in 17 minutes

pull request commentDestinyItemManager/DIM

Always hide kill tracker perk in new perk display

I renamed the existing function -- that one looks to see if it is enabled and is used to determine to show the kill tracker count. yeah i think we'll always want to disable the perk display

kyleshay

comment created time in an hour

push eventDestinyItemManager/DIM

DIM i18n Bot

commit sha 58c495fd8d44e03d6c81c46b23058f1dacc450e6

i18n

view details

push time in 2 hours

issue commentDestinyItemManager/DIM

Mods in Loadout Optimizer not working

Wanted to add, I've tried it on my other character, and it works fine. Seems to only be bugged for the second character I made.

GreySkylet

comment created time in 6 hours

issue commentDestinyItemManager/DIM

Mods in Loadout Optimizer not working

Screenshot

GreySkylet

comment created time in 6 hours

issue openedDestinyItemManager/DIM

Mods in Loadout Optimizer not working

6.41.1

Google Chrome OS

I started a blank loadout in optimizer, selected a mod which cost 1 energy, and I expected all valid loadouts to appear (there should be many), but instead I got the "No builds found" message.

created time in 8 hours

push eventDestinyItemManager/DIM

Kyle Shay

commit sha e5828f2373acada048f70266c6f06657a57867fa

Fix inverse typo

view details

push time in 15 hours

PR opened DestinyItemManager/DIM

Active mode bugfix for saved search and cursor for dropodown

If you had no saved searches and save one, it would save it but it would thrown an error, this fixes it. Also I noticed that the dropdown in the sidecar for tags shows the text cursor when you hover the text, just going to always default it to the normal cursor.

+2 -1

0 comment

2 changed files

pr created time in 16 hours

create barnchDestinyItemManager/DIM

branch : fx

created branch time in 16 hours

push eventDestinyItemManager/DIM

Kyle Shay

commit sha 314e67ea8430ac0f20c53d469fda27fcccc4968c

better way of detecting kill tracker socket

view details

push time in 16 hours

create barnchDestinyItemManager/DIM

branch : kt

created branch time in 16 hours

PR opened DestinyItemManager/DIM

Reviewers
Don't run PR Build on master

Total oversight on my part. This should fix it.

+6 -1

0 comment

1 changed file

pr created time in 17 hours

create barnchDestinyItemManager/DIM

branch : bug/dont-run-pr-on-master

created branch time in 17 hours

create barnchDestinyItemManager/DIM

branch : chore/forked-repo-pr-workflow

created branch time in 18 hours

push eventDestinyItemManager/DIM

Ryan Rushton

commit sha aabe5bed91163a9a1165dd7462d4a4c3f9b6c350

Copy paste error when creating the yarn cache key

view details

Ryan Rushton

commit sha e2a1a5e6dfec5aa5a2b272f79d1ce3b58ed857fe

Merge pull request #6271 from DestinyItemManager/bug/cache-key-copy-paste-error Copy paste error when creating the yarn cache key

view details

push time in 18 hours

delete branch DestinyItemManager/DIM

delete branch : bug/cache-key-copy-paste-error

delete time in 18 hours

PR merged DestinyItemManager/DIM

Reviewers
Copy paste error when creating the yarn cache key

Something I just noticed while I was watching the latest beta build happen.

+3 -3

0 comment

3 changed files

ryan-rushton

pr closed time in 18 hours

PR opened DestinyItemManager/DIM

Reviewers
Copy paste error when creating the yarn cache key

Something I just noticed while I was watching the latest beta build happen.

+3 -3

0 comment

3 changed files

pr created time in 19 hours

create barnchDestinyItemManager/DIM

branch : bug/cache-key-copy-paste-error

created branch time in 19 hours

push eventDestinyItemManager/DIM

Ryan Rushton

commit sha bdda6f9fc509788a05514f09ccf33151ac1e8c8c

Tweaked the caching and used our own yarn cache in an effort to speed things up.

view details

Ryan Rushton

commit sha c09494a426a5c97d2de50c02b4a2d7b6d21538ec

Removed a comment just to see build time

view details

Ryan Rushton

commit sha 595baa4f54aeda3f4a0427ea81a67512a3988501

Removed lint, test, and eslint cache from the deploy beta workflow. Removed the eslint cache from the deploy prod workflow.

view details

Ryan Rushton

commit sha 8ce0cca1e5904be654c7f62a7598414d6a284930

Removed a cache key which would have allowed caches to pull a totally irrelevant cache.

view details

Ryan Rushton

commit sha 9b9c5d52bcdb38d8f69fa571d5f3ab0b8b6cb6cc

Merge pull request #6265 from DestinyItemManager/chore/build-speedup Build speedup

view details

push time in 19 hours

delete branch DestinyItemManager/DIM

delete branch : chore/build-speedup

delete time in 19 hours

more