A lighter version of Bahmni EMR as a Docker Image.
bharatak/AngularJS-Jasmine-Karma 0
Basics of using jasmine as a testing framework to test angular apps with karma/grunt
Core OpenMRS modules for Bahmni (including ERP & ELIS Atom Feed Clients)
docker containers for bahmni
Bahmni Automation Test Suite using Gauge Framework
Prototype of intellij plugin for Bahmni
Repository of bahmni deployment and RPMs
Build a Jekyll blog in minutes, without touching the command line.
push eventopenmrs/openmrs-module-dhisconnector
commit sha 5093dbd7d9e59bd32864aba2e6e6bebf553c0f31
DCM:15: Create a six monthly picker in run report (#22)
push time in 14 hours
PR merged openmrs/openmrs-module-dhisconnector
The issue I worked on
See https://issues.openmrs.org/projects/DCM/issues/DCM-15?filter=allopenissues
Description of what I changed:
Create a six monthly picker in run report
pr closed time in 14 hours
push eventopenmrs/openmrs-module-dhisconnector
commit sha d09c829720601065dcc49ac170fad37e765bc82a
DCM-32: Support SixMonthly April period type in automation (#24)
push time in 14 hours
PR merged openmrs/openmrs-module-dhisconnector
The issue I worked on
See https://issues.openmrs.org/browse/DCM-32
Description of what I changed:
Added SixMonthly April period type support for automation by updating the following method:
src/main/java/org/openmrs/module/dhisconnector/api/impl/DHISConnectorServiceImpl.java:transformToDHISPeriod
Added SixMonthly April to supported period types array.
pr closed time in 14 hours
Pull request review commentopenmrs/openmrs-module-oauth2login
OA-21: First authentication to create new OpenMRS user with roles from identity provider
public User toOpenmrsUser(Properties props) { * @return The corresponding value from the JSON, an empty String if none is found. */ public static String get(String userInfoJson, String propertyKey, Properties props, String defaultValue) {- String propertyValue = props.getProperty(propertyKey);+ String propertyValue = props.getProperty(propertyKey, null); String res = defaultValue; if (!StringUtils.isEmpty(propertyValue)) { res = JsonPath.read(userInfoJson, "$." + propertyValue); } return res; } + /**+ * Return a roles list based on the OAuth 2 properties mappings.+ * + * @param props The mappings between the user info fields and the corresponding OpenMRS+ * user/person properties.+ * @return The list of roles+ */+ public List<String> getRoles(Properties props) {++ String rolesName = get(userInfoJson, MAPPINGS_PFX + PROP_ROLES, props,+ null);+ if (rolesName != null) {+ return Arrays.asList(rolesName.split(","));+ } else {+ return new ArrayList<>();+ }+ }
Done
comment created time in 15 hours
Pull request review commentopenmrs/openmrs-module-oauth2login
OA-21: First authentication to create new OpenMRS user with roles from identity provider
public User toOpenmrsUser(Properties props) { * @return The corresponding value from the JSON, an empty String if none is found. */ public static String get(String userInfoJson, String propertyKey, Properties props, String defaultValue) {- String propertyValue = props.getProperty(propertyKey);+ String propertyValue = props.getProperty(propertyKey, null); String res = defaultValue; if (!StringUtils.isEmpty(propertyValue)) { res = JsonPath.read(userInfoJson, "$." + propertyValue); } return res; } + /**+ * Return a roles list based on the OAuth 2 properties mappings.+ * + * @param props The mappings between the user info fields and the corresponding OpenMRS+ * user/person properties.+ * @return The list of roles+ */+ public List<String> getRoles(Properties props) {++ String rolesName = get(userInfoJson, MAPPINGS_PFX + PROP_ROLES, props,+ null);+ if (rolesName != null) {+ return Arrays.asList(rolesName.split(","));+ } else {+ return new ArrayList<>();+ }+ }
It all looks good to me 👍
I would probably just 1) use streams to crush this getRoles method into a one-liner, and 2) probably add a new OAuth2UserTest.java to test this method a little.
comment created time in 19 hours
PR opened openmrs/openmrs-module-oauth2login
<!--- Add a pull request title above in this format --> <!--- real example: 'TRUNK-5111: Replace use of deprecated isVoided' --> <!--- 'TRUNK-JiraIssueNumber: JiraIssueTitle' -->
Description of what I changed
<!--- Describe your changes in detail --> <!--- It can simply be your commit message, which you must have -->
Issue I worked on
<!--- This project only accepts pull requests related to open issues --> <!--- Want a new feature or change? Discuss it in an issue first! --> <!--- Found a bug? Point us to the issue/or create one so we can reproduce it! --> <!--- Just add the issue number at the end: --> see https://issues.openmrs.org/browse/OA-21
Checklist: I completed these to help reviewers :)
<!--- Put an x in the box if you did the task -->
<!--- If you forgot a task please follow the instructions below -->
-
[x] My IDE is configured to follow the code style of this project.
-
[x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
-
[x] I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit. -
[x] All new and existing tests passed.
-
[x] My pull request is based on the latest changes of the master branch.
pr created time in 19 hours
push eventopenmrs/openmrs-module-dhisconnector
commit sha 921b2222a29037959c717f9f150b985f273151ae
DCM-31: Support SixMonthly period type in automation (#23)
push time in 3 days
PR merged openmrs/openmrs-module-dhisconnector
The issue I worked on
See https://issues.openmrs.org/browse/DCM-31
Description of what I changed:
Added SixMonthly period type support for automation by updating the following method:
src/main/java/org/openmrs/module/dhisconnector/api/impl/DHISConnectorServiceImpl.java:transformToDHISPeriod
Added SixMonthly as to supported period types array.
pr closed time in 3 days
issue commentopenmrs/openmrs-esm-login
Login app not redirecting to home app landing page after selecting location
Thank you!
comment created time in 3 days
issue commentopenmrs/openmrs-esm-login
Login app not redirecting to home app landing page after selecting location
Thanks Florian! Here's the commit: https://github.com/openmrs/openmrs-esm-login/commit/8abbb1179fa78f7c3a4e58823eb97845e2bbf9f9
comment created time in 5 days
created tagopenmrs/openmrs-esm-login
The login microfrontend for the OpenMRS SPA
created time in 5 days
issue closedopenmrs/openmrs-esm-login
Login app not redirecting to home app landing page after selecting location
Steps to reproduce:
- Login
- Select a location
- Click
Confirm
The login page is failing to successfully redirect the user to the home app landing page after selecting a location and clicking the Confirm button. Apologies if this is a known issue, just that it's been happening for quite some time now.
closed time in 5 days
denniskigen
issue commentopenmrs/openmrs-esm-login
Login app not redirecting to home app landing page after selecting location
I think this is the failing login redirect.
It should be fixed by now.
comment created time in 5 days
push eventopenmrs/openmrs-esm-login
commit sha 8abbb1179fa78f7c3a4e58823eb97845e2bbf9f9
Fixes broken referrer nav
push time in 5 days
PR closed openmrs/openmrs-esm-login
This doesn't really fix referrer navigation all the way. It's actually quite broken, because the useCurrentUser hook is holding onto the cached user even after the user is logged out. There's probably a refetchCurrentUser needed somewhere, perhaps in the CurrentUserContext, but I don't know where. I still have no idea why esm-login has a second layer of user caching/management outside of esm-api's in the first place.
pr closed time in 5 days
pull request commentopenmrs/openmrs-esm-login
Update core packages; fix referrer navigation; fix dist name
I'll close this also as we now use GitHub actions and the given referrer fix has been applied already. Still, improving the login should be done at some point.
comment created time in 5 days
pull request commentopenmrs/openmrs-module-dhisconnector
DCM-32: Support SixMonthly April period type in automation
@Piumal1999 Well done,you can also add your pr link to the ticket under comments
comment created time in 7 days
PR opened openmrs/openmrs-module-dhisconnector
The issue I worked on
See https://issues.openmrs.org/browse/DCM-32
Description of what I changed:
Added SixMonthly April period type support for automation by updating the following method:
src/main/java/org/openmrs/module/dhisconnector/api/impl/DHISConnectorServiceImpl.java:transformToDHISPeriod
Added SixMonthly April to supported period types array.
pr created time in 8 days
push eventopenmrs/openmrs-module-dhisconnector
commit sha 5713f56ce2ac121a94061ccaa77098f8b4837d39
[maven-release-plugin] rollback the release of 1.5.2
push time in 8 days
push eventopenmrs/openmrs-module-dhisconnector
commit sha 8c19d744c6d1ebfecbb055ca1c6bf559d745a613
[maven-release-plugin] prepare release 1.5.2
push time in 8 days
push eventopenmrs/openmrs-module-dhisconnector
commit sha e5f5dfbed67448929ff0543deba20fb9de43f982
[maven-release-plugin] prepare for next development iteration
push time in 8 days
push eventopenmrs/openmrs-module-dhisconnector
commit sha 39af236e360b9cae7ce5add5a2857d1890aa6743
[maven-release-plugin] prepare release 1.5.2
push time in 8 days
Pull request review commentopenmrs/openmrs-module-dhisconnector
DCM-21: Support Financial April period type in automation
public String transformToDHISPeriod(Calendar startDate, Calendar endDate, String endDate.set(Calendar.DAY_OF_YEAR, startDate.getActualMaximum(Calendar.DAY_OF_YEAR)); if (lastRun == null || !sdf.format(lastRun).equals(sdf.format(endDate.getTime()))) period = new SimpleDateFormat("yyyy").format(startDate.getTime());+ } else if (ReportingPeriodType.FinancialApril.name().equals(periodType)) {+ sdf = new SimpleDateFormat("yyyy");+ // Set the start date to 1st of April
please use https://docs.oracle.com/javase/7/docs/api/java/util/Calendar.html#APRIL and other specific values than direct integer values.
comment created time in 10 days
PR opened openmrs/openmrs-module-dhisconnector
The issue I worked on
See https://issues.openmrs.org/browse/DCM-31
Description of what I changed:
Added SixMonthly period type support for automation by updating the following method:
src/main/java/org/openmrs/module/dhisconnector/api/impl/DHISConnectorServiceImpl.java:transformToDHISPeriod
Added SixMonthly as to supported period types array.
pr created time in 14 days
PR closed openmrs/openmrs-module-dhisconnector
The issue I worked on
See https://issues.openmrs.org/projects/DCM/issues/DCM-15?filter=allopenissues
Description of what I changed:
Create a six monthly picker in run report
pr closed time in 14 days
PR opened openmrs/openmrs-module-dhisconnector
The issue I worked on
See https://issues.openmrs.org/projects/DCM/issues/DCM-15?filter=allopenissues
Description of what I changed:
Create a six monthly picker in run report
pr created time in 14 days