profile
viewpoint

mbebenita/Broadway 2496

A JavaScript H.264 decoder.

RecordReplay/gecko-dev 25

Record Replay gecko based browser source

bhackett1024/CodeInspector 6

(Experimental) Tool to track code executed and other metrics (coverage, hotness, ...) - DEMO URL BELOW

syg/ti-pldi2012 1

TI Paper

bhackett1024/arewefastyet 0

arewefastyet.com

bhackett1024/coral 0

Supporting code for http://coral.wiki

bhackett1024/debugger.html 0

The Firefox debugger that works anywhere :boom:

bhackett1024/devtools-core 0

:rocket: Packages for Firefox DevTools

bhackett1024/gcAnalysis 0

Scripts for analyses related to exact GC rooting in SpiderMonkey

issue commentRecordReplay/gecko-dev

Rebase: Remove dock nag

Clicking not now then cycles through two more nags to make replay the default browser and change the theme, which also need to be removed. Related, some of the changes we made to disable the new install and tour pages were removed in upstream and presumably replaced with stuff like this. We'll need to track down what is going on again to fix these.

bhackett1024

comment created time in a day

issue openedRecordReplay/gecko-dev

Rebase: Remove dock nag

When opening up the ESR rebase of replay (https://github.com/RecordReplay/backend/issues/3826) this is how the browser looks:

Screen Shot 2021-12-03 at 3 52 18 PM

This nag should be disabled.

created time in a day

push eventRecordReplay/gecko-dev

Brian Hackett

commit sha 5a094a9649d06427cf565a5d55b9cd8e30176e55

Fix build breaks

view details

push time in a day

delete branch RecordReplay/gecko-dev

delete branch : text-diagnostic

delete time in a day

push eventRecordReplay/gecko-dev

Brian Hackett

commit sha 96bfb6baf607b981ef4e2a98db71445eae1d35c6

Add diagnostic for backend issue 3659 (#612)

view details

push time in a day

PR merged RecordReplay/gecko-dev

Reviewers
Add diagnostic for backend issue 3659

For https://github.com/RecordReplay/backend/issues/3659. This adds back an assert removed in https://github.com/RecordReplay/backend/issues/2666, but for which we've still seen related mismatches in at least one user recording.

+9 -0

0 comment

1 changed file

bhackett1024

pr closed time in a day

pull request commentRecordReplay/gecko-dev

Disable eval cache when recording/replaying

This will cause more sources to appear when there are lots of evaluations, yeah. One possible change would be to retain entries in the eval cache forever (or have an alternate cache with such semantics), but AIUI the problems we're having with sources and breakpoint positions slowing down basic processing are unrelated to evals like this.

bhackett1024

comment created time in a day

delete branch RecordReplay/gecko-dev

delete branch : disable-eval-cache

delete time in a day

push eventRecordReplay/gecko-dev

Brian Hackett

commit sha aedf15d0b7c50c7b12cb93468b24f19fe101c69b

Disable eval cache when recording/replaying

view details

Brian Hackett

commit sha 73013fa2ad3152f2196d7d3600208bac75a1c122

Merge pull request #611 from RecordReplay/disable-eval-cache Disable eval cache when recording/replaying

view details

push time in a day

PR merged RecordReplay/gecko-dev

Reviewers
Disable eval cache when recording/replaying

Fixes https://github.com/RecordReplay/backend/issues/3246

The eval cache is used to avoid doing recompiling eval scripts when the same script is evaluated repeatedly. This is handy for improving sunspider performance and could be handy I guess on poorly written real websites, but the cache is swept / purged at non-deterministic points related to GC. The debugger's new script hook only fires on cache misses, and this hook needs to run at deterministic points. This PR disables the eval cache when recording/replaying to avoid this non-determinism.

+5 -1

0 comment

1 changed file

bhackett1024

pr closed time in a day

push eventRecordReplay/gecko-dev

Brian Hackett

commit sha 19b600e654bc3935a9d59a66c74c04ecfbec65cf

Reapply Accessible changes to new LocalAccessible class

view details

push time in a day

push eventRecordReplay/gecko-dev

Brian Hackett

commit sha b0fe272758fcac8c71996506d77d72a5a9656a4d

Remove special casing for default class constructors, spidermonkey removed its own special casing in bug 1690943

view details

push time in a day

push eventRecordReplay/gecko-dev

Brian Hackett

commit sha 6d8cf34455091b9639309533680aa86c22d53518

Restore spidermonkey instrumentation logic

view details

push time in a day

PullRequestReviewEvent

issue commentRecordReplay/devtools

Long time waiting for recording to load without any messages

I think the long delays in session creation are happening due to https://github.com/RecordReplay/backend/pull/3839. This shouldn't affect the total time to load the recording, but it will take a lot longer to get the session from the backend. The regression being fixed was deployed two days ago. There is a big spike in session creation times from around then, which is clearly visible in this graph:

https://ui.honeycomb.io/replay/datasets/backend/result/gCSvpoDAat4

bhackett1024

comment created time in a day

issue openedRecordReplay/gecko-dev

Browser shows VPN advertisement on startup

When I opened Replay a little while ago I saw an ad for mozilla's VPN service https://www.mozilla.org/en-US/firefox/welcome/11/

created time in a day

push eventRecordReplay/gecko-dev

Nika Layzell

commit sha 37a0464a0f31731c3696bca6791aa832f46da23c

Bug 1706302 - Part 3: Remove AWTerminate.UNKNOWN, r=pdahiya Previously the WebProgressListener in AboutWelcomeChild was detecting OnLocationChange notifications for loading about:welcome rather than notifications for navigating away from it, meaning that AWTerminate.UNKNOWN was almost immediately replaced as soon as the document was loaded, rather than only when navigating away. The DOMDocElementInserted event fires slightly later than DOMWindowCreated so the actor no longer sees the OnLocationChange notification for the current document, causing tests to fail. As this telemetry is no longer actively monitored, this patch removes AWTerminate.UNKNOWN to preserve the existing behaviour. Differential Revision: https://phabricator.services.mozilla.com/D118620

view details

Nihanth Subramanya

commit sha e883000c1c9bd58ce51279edc7d72afb52cb2f7c

Bug 1719851 - Allow default-branch regional pref values in DoH Config. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D119516

view details

Nihanth Subramanya

commit sha 5558378bbe3c1a47a8d208c81f2453fa18d6eddc

Bug 1719851 - Allow default-branch regional pref values in DoH Config. r=Gijs, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D119516

view details

Julian Descottes

commit sha faae1567647f53dcff28b7558a51242d6a78db5b

Bug 1719850 - [marionette] Enforce no-unused-vars for global variables in marionette eslint configuration r=webdriver-reviewers,whimboo Depends on D119508 Differential Revision: https://phabricator.services.mozilla.com/D119515

view details

Md. Pial Ahamed

commit sha f1b127ad861560215ce9482460da1615a006eb17

Bug 1716822 - Switch to JavaScript stack by default in active tab view r=julienw Switches to the JavaScript stacks by default when capturing profile with active tab view (with the "web developer" preset) Also refactors previous ternary condition for better readability Differential Revision: https://phabricator.services.mozilla.com/D119305

view details

Markus Stange

commit sha e440698c828df03b6153180a0634dd103862de46

Bug 1673755 - Strip pointer authentication hashes during stack walking on macOS arm64. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D117168

view details

Erik Nordin

commit sha 0990d594631cc52a9f081aa5497745576964f840

Bug 1719758 - Test result values before unwrapping in TestPluralRules r=platform-i18n-reviewers,dminor Modifies TestPluralRules.cpp to assert that all result values are okay before unwrapping them. Previously the test suite would crash if an error result was unwrapped. Now it will fail the test and report the failure. Differential Revision: https://phabricator.services.mozilla.com/D119465

view details

Gijs Kruitbosch

commit sha 37441d59775647f8f528d655ca39e71f861bdcd0

Bug 1705101 - remove now-unnecessary workarounds for bug 1699844, r=mtigley Differential Revision: https://phabricator.services.mozilla.com/D119506

view details

Molly Howell

commit sha 87cba8f0f41d56409ed13b2ee46d320bec70ee44

Bug 1718760 - Restore some erroneously removed menu item color properties. r=desktop-theme-reviewers,harry Differential Revision: https://phabricator.services.mozilla.com/D119229

view details

JMM

commit sha 22f37329059a49ffed8fa73715c1abb69cf4897f

Bug 1672548 - Add weekday skeleton to DateTimeFormat::FormatDateTime(). r=gregtatum Differential Revision: https://phabricator.services.mozilla.com/D119545

view details

Sam Foster

commit sha 58d620a957275ff469e3d6fc84ee8515959c73e4

Bug 1704970 - Move fxr's refresh icon to its own assets directory. Differential Revision: https://phabricator.services.mozilla.com/D117094

view details

Mike Hommey

commit sha 6bb2a4bab5321a3e073c57adc7f53caa6809c916

Bug 1713735 - Only build rlbox_lucet_sandbox when wasm-sandboxing is enabled. r=firefox-build-system-reviewers,mhentges Differential Revision: https://phabricator.services.mozilla.com/D119479

view details

Anny Gakhokidze

commit sha 17e5a34c2e121ba3ac13f7d316383b9346bfdb46

Bug 1646356 - Wait for hashchange event in a different way for browser_sessionHistory.js, r=kashav Differential Revision: https://phabricator.services.mozilla.com/D119458

view details

Jed Davis

commit sha ce1dc6dc069552b0898c1c5d3ba181a33c52eed0

Bug 1719391 - Fix fd leak during Linux sandbox file broker creation. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D119456

view details

Harry Twyford

commit sha 93961ec313638bd1f9df4f207f8dc770d4c76b96

Bug 1717509 - Part 1 - Hook up UrlbarProviderPlaces and fix various lint issues. r=adw,preferences-reviewers UnifiedComplete must stick around to serve as an mozIPlacesAutoComplete implementation for XUL consumers like search.js and privacy.js. Differential Revision: https://phabricator.services.mozilla.com/D119306

view details

Harry Twyford

commit sha eb4483f22ba4849c4cab7a6ac508f765bc137b18

Bug 1717509 - Part 2 - Minimal working UrlbarProviderPlaces. r=adw Differential Revision: https://phabricator.services.mozilla.com/D119307

view details

Harry Twyford

commit sha f14ae3766375ce31f3fb42c3c1593fef553bf2df

Bug 1717509 - Part 3 - Remove unused, obsolete, and duplicated code from UrlbarProviderPlaces. r=adw There's more I'd like to do here. Namely, I want to eliminate the Search class in favour of everything being part of ProviderPlaces, and I'd like to get rid of "match" objects/nsIAutoCompleteResult in favour of always dealing with UrlbarResults. I think major changes like those are best left to bug 1717511. The latter change would require moving the muxer-lite deduping code from ProviderPlaces to the muxer. That way, ProviderPlaces can just send results to the muxer as soon as they're ready rather than needing to first order them inside an nsIAutoCompleteResult. Differential Revision: https://phabricator.services.mozilla.com/D119308

view details

Harry Twyford

commit sha aca42929d0eebf2be715890c06bc870c5478e7a5

Bug 1717509 - Part 4 - Remove files and result group related to UnifiedComplete. r=adw Differential Revision: https://phabricator.services.mozilla.com/D119309

view details

Harry Twyford

commit sha 8ee5ae167896259bb9d1102167f680ea6801234e

Bug 1717509 - Part 5 - Replace references to UnifiedComplete with references to UrlbarProviderPlaces. r=adw Differential Revision: https://phabricator.services.mozilla.com/D119310

view details

Chris Peterson

commit sha 76babf22e6c4e8cb019e8fad8e4ba246f9ccc95c

Bug 1718564 - Fix -Wlogical-op warning in GamepadTouchState.h. r=cmartin gcc reports the following -Wlogical-op warning because the `touchId == aTouch.touchId` check is duplicated: GamepadTouchState.h:28:38: warning: logical 'and' of equal expressions [-Wlogical-op] Differential Revision: https://phabricator.services.mozilla.com/D118924

view details

push time in 2 days

issue commentRecordReplay/devtools

Long time waiting for recording to load without any messages

This is an important area to have good telemetry I think.

bhackett1024

comment created time in 2 days

PR opened RecordReplay/gecko-dev

Reviewers
Add diagnostic for backend issue 3659

For https://github.com/RecordReplay/backend/issues/3659. This adds back an assert removed in https://github.com/RecordReplay/backend/issues/2666, but for which we've still seen related mismatches in at least one user recording.

+9 -0

0 comment

1 changed file

pr created time in 2 days

create barnchRecordReplay/gecko-dev

branch : text-diagnostic

created branch time in 2 days

issue openedRecordReplay/devtools

Long time waiting for recording to load without any messages

I've been creating some node recordings to debug some stuff, but the UX while waiting for the recording to load isn't very good. The tab sits for a long time when trying to view the recording, with no messaging at all about what is happening. Here is the recording FWIW https://app.replay.io/recording/71194c1d-b4e8-4c44-91c8-a6ac12bc1f58?

created time in 2 days

PR opened RecordReplay/gecko-dev

Reviewers
Disable eval cache when recording/replaying

Fixes https://github.com/RecordReplay/backend/issues/3246

The eval cache is used to avoid doing recompiling eval scripts when the same script is evaluated repeatedly. This is handy for improving sunspider performance and could be handy I guess on poorly written real websites, but the cache is swept / purged at non-deterministic points related to GC. The debugger's new script hook only fires on cache misses, and this hook needs to run at deterministic points. This PR disables the eval cache when recording/replaying to avoid this non-determinism.

+5 -1

0 comment

1 changed file

pr created time in 2 days

create barnchRecordReplay/gecko-dev

branch : disable-eval-cache

created branch time in 2 days

delete branch RecordReplay/gecko-dev

delete branch : analyze-args-realm

delete time in 3 days

push eventRecordReplay/gecko-dev

Brian Hackett

commit sha e0465f3ced63a8951403851c2aa870af06a2a5a5

Enter realm of script in Debugger::getFrame before analyzing arguments usage

view details

Brian Hackett

commit sha 8b7ad599b9363b105497708f0354e0a3dc619d9e

Merge pull request #609 from RecordReplay/analyze-args-realm Enter realm of script in Debugger::getFrame before analyzing argument…

view details

push time in 3 days

PR merged RecordReplay/gecko-dev

Enter realm of script in Debugger::getFrame before analyzing argument…

…s usage

Fixes https://github.com/RecordReplay/backend/issues/3564

+5 -3

1 comment

1 changed file

bhackett1024

pr closed time in 3 days

pull request commentRecordReplay/gecko-dev

Enter realm of script in Debugger::getFrame before analyzing argument…

I don't see comparable code in current upstream firefox, but maybe I'll see something in the upcoming rebase. Either way upstreaming this change isn't super important.

bhackett1024

comment created time in 3 days

PR opened RecordReplay/gecko-dev

Reviewers
Enter realm of script in Debugger::getFrame before analyzing argument…

…s usage

Fixes https://github.com/RecordReplay/backend/issues/3564

+5 -3

0 comment

1 changed file

pr created time in 3 days

create barnchRecordReplay/gecko-dev

branch : analyze-args-realm

created branch time in 3 days

delete branch RecordReplay/gecko-dev

delete branch : timer-diagnostics

delete time in 3 days

more