profile
viewpoint
Ben Gorlick bgorlick Puerto Rico, San Francisco

bgorlick/amoveo 0

A blockchain for trust-free markets in financial derivatives

bgorlick/bips 0

Bitcoin Improvement Proposals

bgorlick/bitcoin 0

Bitcoin Core integration/staging tree

bgorlick/btcresearch 0

CABRA — Comprehensive Academic Bitcoin Research Archive

bgorlick/glog 0

C++ implementation of the Google logging module

bgorlick/grin 0

Minimal implementation of the MimbleWimble protocol.

bgorlick/janusgraph 0

JanusGraph: an open-source, distributed graph database

bgorlick/kugelblitz 0

Controlling lightning

bgorlick/ledger-live-desktop 0

Ledger Live (Desktop)

PR opened sourcecred/sourcecred

Update yarn.lock for latest package.json changes

Description

yarn.lock file was not updated in some recent PR and is out of sync with package.json

Test Plan

Run yarn install and ensure that the yarn.lock file is up to date / has no changes

+77 -1

0 comment

1 changed file

pr created time in 2 minutes

create barnchsourcecred/sourcecred

branch : chore/update-yarn-lock

created branch time in 3 minutes

PR opened sourcecred/sourcecred

Return identityId in ensureIdentityExists function

Description

Returning the newly generated (or existing) identity ID in this function improves the developer ergonomics when using this function through the SourceCred API to create identities programmatically and then do further processing on said identities.

Test Plan

Ensure CI tests pass

+11 -6

0 comment

2 changed files

pr created time in 6 minutes

create barnchsourcecred/sourcecred

branch : improve-ensure-identity-exists

created branch time in 7 minutes

push eventparitytech/substrate

Bastian Köcher

commit sha 11f4786840678b5cea72f06837913abf136d3e89

Lol

view details

push time in 13 minutes

issue openedlightningnetwork/lnd

pathfinding: add a routing fee-inclusive option to query routes and send payment

Now that KeySend and MPP record support is more widely distributed, it can be safe to send a payment to a recipient which is routing fee inclusive instead of a static value.

For example, if a user were to make a withdrawal from an exchange, the exchange could KeySend to their public key a withdrawal sum that is inclusive of the routing fees required to fulfill that withdrawal. It is good practice to pass forward these types of routing fees to the recipient given that they may themselves be part of the routing path.

In the current QueryRoutes and SendPayment APIs, there is no way to specify that the total value of the payment should be inclusive of the routing fees. An extension to these APIs would allow for modifying that final HTLC value down.

With this API the exchange or other custodial wallet could offer a button to "withdraw all LN funds" without concerning themselves with the possibility of over-withdrawing. A UX issue that is present in some of these wallets today is that they do not allow withdrawing more than 99% of the value of the wallet value over LN in order to preserve funds for the routing fee.

This is something that can be worked around in various other ways but it could be more optimal and easier to integrate if incorporated into the pathfinding API calls themselves.

created time in an hour

PR opened sourcecred/sourcecred

Add Ledger utils to public API

Description

Allows users of the NPM package to use helpful functions like diffLedger, computeDistribution, ensureIdentityExists, etc.

Test Plan

Ensure CI tests pass and Ledger utils are available in packaged output (npm pack)

+16 -0

0 comment

2 changed files

pr created time in an hour

create barnchsourcecred/sourcecred

branch : feature/ledger-utils

created branch time in an hour

Pull request review commentlightningnetwork/lnd

[WIP] discovery: pinned syncers

 func testGraphTopologyNotifications(net *lntest.NetworkHarness, t *harnessTest)  	const chanAmt = funding.MaxBtcFundingAmount +	alice, err := net.NewNode("alice", nil)+	require.NoError(t.t, err)+	defer shutdownAndAssert(net, t, alice)++	bob, err := net.NewNode("bob", nil)+	require.NoError(t.t, err)+	defer shutdownAndAssert(net, t, bob)++	// Connect Alice and Bob.+	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)+	err = net.EnsureConnected(ctxt, alice, bob)+	require.NoError(t.t, err)++	// Alice stimmy.

:joy:

cfromknecht

comment created time in an hour

Pull request review commentlightningnetwork/lnd

[WIP] discovery: pinned syncers

 type Config struct {  	Routing *lncfg.Routing `group:"routing" namespace:"routing"` +	Gossip *lncfg.Gossip `group:"gossip" namespace:"gossip"`

Thoughts on moving the existing numgraphsyncpeers flag here and deprecating the top-level one while still parsing it? Then we can remove the top-level one at a later release.

cfromknecht

comment created time in an hour

Pull request review commentlightningnetwork/lnd

[WIP] discovery: pinned syncers

 func (m *SyncManager) syncerHandler() { 		initialHistoricalSyncSignal chan struct{} 	) +	setHistoricalSyncer := func(s *GossipSyncer) {

Nit: rename to setInitialHistoricalSyncer.

cfromknecht

comment created time in 2 hours

Pull request review commentlightningnetwork/lnd

[WIP] discovery: pinned syncers

 message Peer {         Denotes that we are not receiving new graph updates from the peer.         */         PASSIVE_SYNC = 2;++        /*+        Denotes that this peer is pinned into an active sync.+        */+        PINNED_ACTIVE_SYNC = 3;++        PINNED_PASSIVE_SYNC = 4;

Missing comment. Maybe this state distinction isn't needed after all though, as pinned passive will eventually become pinned active with the current logic.

cfromknecht

comment created time in an hour

Pull request review commentlightningnetwork/lnd

[WIP] discovery: pinned syncers

 func (m *SyncManager) syncerHandler() { 			// keep track of the corresponding syncer to properly 			// handle disconnects. We'll also use a signal to know 			// when the historical sync completed.-			setHistoricalSyncer(s)+			if !isPinnedSyncer {+				setHistoricalSyncer(s)

Seems like this should be done for our first pinned syncer as well? This would allow us to detect when they disconnect and start one with a different peer.

cfromknecht

comment created time in an hour

Pull request review commentlightningnetwork/lnd

[WIP] discovery: pinned syncers

 func (m *SyncManager) syncerHandler() {  			s := m.createGossipSyncer(newSyncer.peer) +			isPinnedSyncer := m.isPinnedSyncer(s)+ 			// attemptHistoricalSync determines whether we should 			// attempt an initial historical sync when a new peer 			// connects. 			attemptHistoricalSync := false  			m.syncersMu.Lock() 			switch {+			// For pinned syncers, we will immediately transition+			// the peer into an active (pinned) sync state.+			case isPinnedSyncer:

Seems like this should be handled further below in case this is the first syncer we see so that we attempt the historical sync and still keep them as pinned active?

cfromknecht

comment created time in 2 hours

Pull request review commentlightningnetwork/lnd

[WIP] discovery: pinned syncers

 type SyncManager struct { 	// currently receiving new graph updates from. 	inactiveSyncers map[route.Vertex]*GossipSyncer +	pinnedSyncers map[route.Vertex]struct{}

Nit: any reason to have these given that they're already present in the config?

cfromknecht

comment created time in 2 hours

Pull request review commentlightningnetwork/lnd

[WIP] discovery: pinned syncers

 func (m *SyncManager) syncerHandler() { 			// If we've already performed an initial historical 			// sync, we won't try again with our passive peers. 			if m.IsGraphSynced() {+				m.cfg.HistoricalSyncTicker.Pause()

Given my previous comment, we want to keep the ticker running here and below.

cfromknecht

comment created time in 2 hours

Pull request review commentlightningnetwork/lnd

[WIP] discovery: pinned syncers

 func (m *SyncManager) syncerHandler() { 		// Our HistoricalSyncTicker has ticked, so we'll randomly select 		// a peer and force a historical sync with them. 		case <-m.cfg.HistoricalSyncTicker.Ticks():-			s := m.forceHistoricalSync()+			// If we've already performed an initial historical+			// sync, we won't try again with our passive peers.+			if m.IsGraphSynced() {

This should remain where it was, as the idea is to periodically perform historical syncs after our initial one to ensure we converge towards the full graph through different peers. The continue for the IsGraphSynced call previously was to avoid tracking the syncer we chose as the historical one. Maybe adding a comment would make that more clear?

cfromknecht

comment created time in 2 hours

pull request commentsourcecred/sourcecred

core/weights: Weights class

@decentralion I think this is good to merge, pending a pass from you

elihanover

comment created time in 2 hours

delete branch sourcecred/sourcecred

delete branch : dependabot/npm_and_yarn/webpack-cli-4.3.1

delete time in 3 hours

PR closed sourcecred/sourcecred

build(deps-dev): bump webpack-cli from 3.3.12 to 4.3.1 dependencies

Bumps webpack-cli from 3.3.12 to 4.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/webpack/webpack-cli/releases">webpack-cli's releases</a>.</em></p> <blockquote> <h2>v4.3.1</h2> <h2><a href="https://github.com/webpack/webpack-cli/compare/webpack-cli@4.3.0...webpack-cli@4.3.1">4.3.1</a> (2020-12-31)</h2> <h3>Bug Fixes</h3> <ul> <li>error message on not installed module loaders for configuration (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2282">#2282</a>) (<a href="https://github.com/webpack/webpack-cli/commit/29eaa8e843510e020ac4b57a13622df40713fe27">29eaa8e</a>)</li> <li>peer dependencies (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2284">#2284</a>) (<a href="https://github.com/webpack/webpack-cli/commit/083f2a069d6dc0a3b9492eb3f205474ba843acfd">083f2a0</a>)</li> <li>provide useful error on unknown command (<a href="https://github.com/webpack/webpack-cli/commit/d6380bb6c6756d2a00ac20f2ffc454481d97e4d3">d6380bb</a>)</li> <li>the <code>--help</code> option is working without <code>webpack-dev-server</code> (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2267">#2267</a>) (<a href="https://github.com/webpack/webpack-cli/commit/1dae54da94d3220437b9257efe512447023de1d3">1dae54d</a>)</li> <li>the <code>--progress</code> option is working with <code>--json</code> (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2276">#2276</a>) (<a href="https://github.com/webpack/webpack-cli/commit/05956030cbb1491a2e9313732470bcd4ebe5a36d">0595603</a>)</li> </ul> <h2>v4.3.0</h2> <h1><a href="https://github.com/webpack/webpack-cli/compare/webpack-cli@4.2.0...webpack-cli@4.3.0">4.3.0</a> (2020-12-25)</h1> <h3>Bug Fixes</h3> <ul> <li>fix problems with <code>--mode</code> and config resolution, there are situations when we resolve an invalid config file, the <code>--mode</code> option does not affect on config resolution, if you faced with an error after updating, please use the <code>--config</code> option</li> <li>correct usage of cli-flags (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2205">#2205</a>) (<a href="https://github.com/webpack/webpack-cli/commit/c8fc7d1f195800c4fbe54ed6533e694f40fa7a1b">c8fc7d1</a>)</li> <li>defer setting default mode to core (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2095">#2095</a>) (<a href="https://github.com/webpack/webpack-cli/commit/3eb410e5d8f8e2149910b65f4a028c85f8af5d28">3eb410e</a>)</li> <li>respect the <code>--watch-options-stdin</code> option (<a href="https://github.com/webpack/webpack-cli/commit/2d1e001e7f4f560c2b36607bd1b29dfe2aa32066">2d1e001</a>)</li> <li>respect <code>--color</code>/<code>--no-color</code> option (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2042">#2042</a>) (<a href="https://github.com/webpack/webpack-cli/commit/09bd8126e95c9675b1f6862451f629cd4c439adb">09bd812</a>)</li> <li>stringify stats using streaming approach (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2190">#2190</a>) (<a href="https://github.com/webpack/webpack-cli/commit/9bf4e925757b02f7252073501562c95e762dc59b">9bf4e92</a>)</li> <li>use logger for error with proper exit code (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2076">#2076</a>) (<a href="https://github.com/webpack/webpack-cli/commit/2c9069fd1f7c0fb70f019900e4b841c5ea33975e">2c9069f</a>)</li> <li>reduce spammy logs (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2206">#2206</a>) (<a href="https://github.com/webpack/webpack-cli/commit/9b3cc283d7b74aa3bb26fe36c6110436b016e0d9">9b3cc28</a>)</li> <li>respect the <code>infrastructureLogging.level</code> option (logger uses <code>stderr</code>) (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2144">#2144</a>) (<a href="https://github.com/webpack/webpack-cli/commit/7daccc786a0eb4eeae4c5b3632fc28240a696170">7daccc7</a>)</li> <li>respect all options from command line for the <code>server</code> command</li> <li><code>help</code> and <code>version</code> output</li> <li>respect <code>stats</code> from the config (webpack@4) (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2098">#2098</a>) (<a href="https://github.com/webpack/webpack-cli/commit/2d6e5c6f4ed967368a81742bf347e39f24ee16c8">2d6e5c6</a>)</li> <li>fixed colors work with multi compiler mode (webpack@4)</li> </ul> <h3>Features</h3> <ul> <li>add <code>bundle</code> command (alias for <code>webpack [options]</code>)</li> <li>add <code>pnpm</code> support for package installation (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2040">#2040</a>) (<a href="https://github.com/webpack/webpack-cli/commit/46cba367f06a6354fe98fcb15e7771e819feeac0">46cba36</a>)</li> </ul> <h2>v4.2.0</h2> <h1><a href="https://github.com/webpack/webpack-cli/compare/webpack-cli@4.1.0...webpack-cli@4.2.0">4.2.0</a> (2020-11-04)</h1> <h3>Bug Fixes</h3> <ul> <li>--config-name behaviour for functional configs (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2006">#2006</a>) (<a href="https://github.com/webpack/webpack-cli/commit/29ecf8dbcd1c5c7d75fc7fb1634107697832d952">29ecf8d</a>)</li> <li>assign cache value for default configs (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2013">#2013</a>) (<a href="https://github.com/webpack/webpack-cli/commit/d2e3c74d32b0141c694259cf4f31e6c48b0f681d">d2e3c74</a>)</li> <li>callback deprecation (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/1977">#1977</a>) (<a href="https://github.com/webpack/webpack-cli/commit/2cb0c0e383670949ce31231edbfda514f47c3dfc">2cb0c0e</a>)</li> <li>handle core flags for webpack 4 (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2023">#2023</a>) (<a href="https://github.com/webpack/webpack-cli/commit/ea66a7e3ec6eabcc439b96acb21e2a25be2e35e5">ea66a7e</a>)</li> <li>help and version functionality (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/1972">#1972</a>) (<a href="https://github.com/webpack/webpack-cli/commit/e8010b3aac695971e542ad4d3584ce534da39b8f">e8010b3</a>)</li> </ul> <h3>Features</h3> <ul> <li>export utils from core for other packages (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2011">#2011</a>) (<a href="https://github.com/webpack/webpack-cli/commit/3004549c06b3fe00708d8e1eecf42419e0f72f66">3004549</a>)</li> <li>progress supports string argument (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2000">#2000</a>) (<a href="https://github.com/webpack/webpack-cli/commit/f13346e6acb46e982a5d20fa1d2ae56fc52523dc">f13346e</a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md">webpack-cli's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/webpack/webpack-cli/compare/webpack-cli@4.3.0...webpack-cli@4.3.1">4.3.1</a> (2020-12-31)</h2> <h3>Bug Fixes</h3> <ul> <li>error message on not installed module loaders for configuration (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2282">#2282</a>) (<a href="https://github.com/webpack/webpack-cli/commit/29eaa8e843510e020ac4b57a13622df40713fe27">29eaa8e</a>)</li> <li>peer dependencies (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2284">#2284</a>) (<a href="https://github.com/webpack/webpack-cli/commit/083f2a069d6dc0a3b9492eb3f205474ba843acfd">083f2a0</a>)</li> <li>provide useful error on unknown command (<a href="https://github.com/webpack/webpack-cli/commit/d6380bb6c6756d2a00ac20f2ffc454481d97e4d3">d6380bb</a>)</li> <li>the <code>--help</code> option is working without <code>webpack-dev-server</code> (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2267">#2267</a>) (<a href="https://github.com/webpack/webpack-cli/commit/1dae54da94d3220437b9257efe512447023de1d3">1dae54d</a>)</li> <li>the <code>--progress</code> option is working with <code>--json</code> (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2276">#2276</a>) (<a href="https://github.com/webpack/webpack-cli/commit/05956030cbb1491a2e9313732470bcd4ebe5a36d">0595603</a>)</li> </ul> <h1><a href="https://github.com/webpack/webpack-cli/compare/webpack-cli@4.2.0...webpack-cli@4.3.0">4.3.0</a> (2020-12-25)</h1> <h3>Bug Fixes</h3> <ul> <li>fix problems with <code>--mode</code> and config resolution, there are situations when we resolve an invalid config file, the <code>--mode</code> option does not affect on config resolution, if you faced with an error after updating, please use the <code>--config</code> option</li> <li>correct usage of cli-flags (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2205">#2205</a>) (<a href="https://github.com/webpack/webpack-cli/commit/c8fc7d1f195800c4fbe54ed6533e694f40fa7a1b">c8fc7d1</a>)</li> <li>defer setting default mode to core (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2095">#2095</a>) (<a href="https://github.com/webpack/webpack-cli/commit/3eb410e5d8f8e2149910b65f4a028c85f8af5d28">3eb410e</a>)</li> <li>respect the <code>--watch-options-stdin</code> option (<a href="https://github.com/webpack/webpack-cli/commit/2d1e001e7f4f560c2b36607bd1b29dfe2aa32066">2d1e001</a>)</li> <li>respect <code>--color</code>/<code>--no-color</code> option (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2042">#2042</a>) (<a href="https://github.com/webpack/webpack-cli/commit/09bd8126e95c9675b1f6862451f629cd4c439adb">09bd812</a>)</li> <li>stringify stats using streaming approach (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2190">#2190</a>) (<a href="https://github.com/webpack/webpack-cli/commit/9bf4e925757b02f7252073501562c95e762dc59b">9bf4e92</a>)</li> <li>use logger for error with proper exit code (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2076">#2076</a>) (<a href="https://github.com/webpack/webpack-cli/commit/2c9069fd1f7c0fb70f019900e4b841c5ea33975e">2c9069f</a>)</li> <li>reduce spammy logs (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2206">#2206</a>) (<a href="https://github.com/webpack/webpack-cli/commit/9b3cc283d7b74aa3bb26fe36c6110436b016e0d9">9b3cc28</a>)</li> <li>respect the <code>infrastructureLogging.level</code> option (logger uses <code>stderr</code>) (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2144">#2144</a>) (<a href="https://github.com/webpack/webpack-cli/commit/7daccc786a0eb4eeae4c5b3632fc28240a696170">7daccc7</a>)</li> <li>respect all options from command line for the <code>server</code> command</li> <li><code>help</code> and <code>version</code> output</li> <li>respect <code>stats</code> from the config (webpack@4) (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2098">#2098</a>) (<a href="https://github.com/webpack/webpack-cli/commit/2d6e5c6f4ed967368a81742bf347e39f24ee16c8">2d6e5c6</a>)</li> <li>fixed colors work with multi compiler mode (webpack@4)</li> </ul> <h3>Features</h3> <ul> <li>add <code>bundle</code> command (alias for <code>webpack [options]</code>)</li> <li>add <code>pnpm</code> support for package installation (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2040">#2040</a>) (<a href="https://github.com/webpack/webpack-cli/commit/46cba367f06a6354fe98fcb15e7771e819feeac0">46cba36</a>)</li> </ul> <h1><a href="https://github.com/webpack/webpack-cli/compare/webpack-cli@4.1.0...webpack-cli@4.2.0">4.2.0</a> (2020-11-04)</h1> <h3>Bug Fixes</h3> <ul> <li>--config-name behaviour for fuctional configs (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2006">#2006</a>) (<a href="https://github.com/webpack/webpack-cli/commit/29ecf8dbcd1c5c7d75fc7fb1634107697832d952">29ecf8d</a>)</li> <li>assign cache value for default configs (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2013">#2013</a>) (<a href="https://github.com/webpack/webpack-cli/commit/d2e3c74d32b0141c694259cf4f31e6c48b0f681d">d2e3c74</a>)</li> <li>callback deprecation (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/1977">#1977</a>) (<a href="https://github.com/webpack/webpack-cli/commit/2cb0c0e383670949ce31231edbfda514f47c3dfc">2cb0c0e</a>)</li> <li>handle core flags for webpack 4 (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2023">#2023</a>) (<a href="https://github.com/webpack/webpack-cli/commit/ea66a7e3ec6eabcc439b96acb21e2a25be2e35e5">ea66a7e</a>)</li> <li>help and version functionality (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/1972">#1972</a>) (<a href="https://github.com/webpack/webpack-cli/commit/e8010b3aac695971e542ad4d3584ce534da39b8f">e8010b3</a>)</li> </ul> <h3>Features</h3> <ul> <li>export utils from core for other packages (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2011">#2011</a>) (<a href="https://github.com/webpack/webpack-cli/commit/3004549c06b3fe00708d8e1eecf42419e0f72f66">3004549</a>)</li> <li>progress supports string argument (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2000">#2000</a>) (<a href="https://github.com/webpack/webpack-cli/commit/f13346e6acb46e982a5d20fa1d2ae56fc52523dc">f13346e</a>)</li> <li>suggest the closest match based on the Levenshtein distance algorithm (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2010">#2010</a>) (<a href="https://github.com/webpack/webpack-cli/commit/491a582620b64ed4acbccd04f687adc28a5e4cff">491a582</a>)</li> </ul> <h1><a href="https://github.com/webpack/webpack-cli/compare/webpack-cli@4.0.0...webpack-cli@4.1.0">4.1.0</a> (2020-10-19)</h1> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/webpack/webpack-cli/commit/a5171999177925529a1c54f242afc2bd9c9e4fe3"><code>a517199</code></a> chore(release): publish new version</li> <li><a href="https://github.com/webpack/webpack-cli/commit/083f2a069d6dc0a3b9492eb3f205474ba843acfd"><code>083f2a0</code></a> fix: peer dependencies (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2284">#2284</a>)</li> <li><a href="https://github.com/webpack/webpack-cli/commit/29eaa8e843510e020ac4b57a13622df40713fe27"><code>29eaa8e</code></a> fix: error message on not installed module loaders for configuration (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2282">#2282</a>)</li> <li><a href="https://github.com/webpack/webpack-cli/commit/d6380bb6c6756d2a00ac20f2ffc454481d97e4d3"><code>d6380bb</code></a> fix: provide useful error on unknown command</li> <li><a href="https://github.com/webpack/webpack-cli/commit/d885426671ead56168e1f008dbfd6fe19fb57edd"><code>d885426</code></a> chore(deps-dev): bump @types/node from 14.14.16 to 14.14.17 (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2279">#2279</a>)</li> <li><a href="https://github.com/webpack/webpack-cli/commit/2b5874e7da98d5439be6e30b6b9ffb0aa19f0b03"><code>2b5874e</code></a> refactor: code (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2280">#2280</a>)</li> <li><a href="https://github.com/webpack/webpack-cli/commit/a3092ef2b51ece30221f7dd7b30a686626c1fd7a"><code>a3092ef</code></a> fix: respect the <code>output.publicPath</code> option for the <code>serve</code>command (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2271">#2271</a>)</li> <li><a href="https://github.com/webpack/webpack-cli/commit/05956030cbb1491a2e9313732470bcd4ebe5a36d"><code>0595603</code></a> fix: the <code>--progress</code> option is working with <code>--json</code> (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2276">#2276</a>)</li> <li><a href="https://github.com/webpack/webpack-cli/commit/818fc1cbdf3c5b756b8ade6a2e7e032616aa520b"><code>818fc1c</code></a> chore(deps-dev): bump webpack from 5.11.0 to 5.11.1 (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2270">#2270</a>)</li> <li><a href="https://github.com/webpack/webpack-cli/commit/92826d621df7454fd12b949ed926c236004439a0"><code>92826d6</code></a> tests: open and serve (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2275">#2275</a>)</li> <li>Additional commits viewable in <a href="https://github.com/webpack/webpack-cli/compare/v3.3.12...webpack-cli@4.3.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+130 -85

1 comment

2 changed files

dependabot[bot]

pr closed time in 3 hours

pull request commentsourcecred/sourcecred

build(deps-dev): bump webpack-cli from 3.3.12 to 4.3.1

Superseded by #2681.

dependabot[bot]

comment created time in 3 hours

PR opened sourcecred/sourcecred

build(deps-dev): bump webpack-cli from 3.3.12 to 4.4.0

Bumps webpack-cli from 3.3.12 to 4.4.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/webpack/webpack-cli/releases">webpack-cli's releases</a>.</em></p> <blockquote> <h2>v4.4.0</h2> <h1><a href="https://github.com/webpack/webpack-cli/compare/webpack-cli@4.3.1...webpack-cli@4.4.0">4.4.0</a> (2021-01-19)</h1> <h3>Bug Fixes</h3> <ul> <li>better description for <code>--no-watch-options-stdin</code> (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2288">#2288</a>) (<a href="https://github.com/webpack/webpack-cli/commit/4ee8665e01e8dce16448e0a4d3dd2293731695ab">4ee8665</a>)</li> <li>double commands output in help (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2298">#2298</a>) (<a href="https://github.com/webpack/webpack-cli/commit/efe81e986a6dca5cc9b72a5c9312dc21409f65b1">efe81e9</a>)</li> <li>pass all <code>argv</code> to configurations when <code>serve</code> command used (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2345">#2345</a>) (<a href="https://github.com/webpack/webpack-cli/commit/5070b9bcbd5bdac00088d0c21486ad181a4df000">5070b9b</a>)</li> <li>respect <code>--stats</code>, <code>--color</code> and <code>--no-color</code> option for <code>serve</code> command (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2312">#2312</a>) (<a href="https://github.com/webpack/webpack-cli/commit/73d3feced18b4e3708f958707326a6642a594cf2">73d3fec</a>)</li> <li>show exact package name while prompting for installation (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2338">#2338</a>) (<a href="https://github.com/webpack/webpack-cli/commit/ffc93e556d784e2d4409cb0d3a92d737850996f4">ffc93e5</a>)</li> <li>webpack installation prompt message (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2316">#2316</a>) (<a href="https://github.com/webpack/webpack-cli/commit/3659c5e529fe1319251ef1c713d6cc758f7f5353">3659c5e</a>)</li> </ul> <h3>Features</h3> <ul> <li>added the <code>configtest</code> command (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2303">#2303</a>) (<a href="https://github.com/webpack/webpack-cli/commit/eb7b18937d045261a5b20ca8356e8b4ae4dfcaad">eb7b189</a>)</li> <li>added the <code>build</code> command (aliases - <code>bundle</code> and <code>b</code>) (<a href="https://github.com/webpack/webpack-cli/commit/7590f66663ce701d52d9276c3adf9dbdfd1a0fa4">7590f66</a>)</li> <li>added the <code>watch</code> command (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2357">#2357</a>) (<a href="https://github.com/webpack/webpack-cli/commit/9693f7d9543a8fce610c4ef903ccca0d12d229a1">9693f7d</a>)</li> <li>allow to pass parseOption to CLI class (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2299">#2299</a>) (<a href="https://github.com/webpack/webpack-cli/commit/2af08013852a95c6f6462c56a9994a4ee28c6ea1">2af0801</a>)</li> <li>allow to use <code>help</code> command to show option information (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2353">#2353</a>) (<a href="https://github.com/webpack/webpack-cli/commit/15eb411237dcdcf0db7a501c103fe53f9b82903f">15eb411</a>)</li> <li>show multiple suggestions on unknown options (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2349">#2349</a>) (<a href="https://github.com/webpack/webpack-cli/commit/7314d6ca927473da2f355a7d356a943471488606">7314d6c</a>)</li> </ul> <h2>v4.3.1</h2> <h2><a href="https://github.com/webpack/webpack-cli/compare/webpack-cli@4.3.0...webpack-cli@4.3.1">4.3.1</a> (2020-12-31)</h2> <h3>Bug Fixes</h3> <ul> <li>error message on not installed module loaders for configuration (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2282">#2282</a>) (<a href="https://github.com/webpack/webpack-cli/commit/29eaa8e843510e020ac4b57a13622df40713fe27">29eaa8e</a>)</li> <li>peer dependencies (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2284">#2284</a>) (<a href="https://github.com/webpack/webpack-cli/commit/083f2a069d6dc0a3b9492eb3f205474ba843acfd">083f2a0</a>)</li> <li>provide useful error on unknown command (<a href="https://github.com/webpack/webpack-cli/commit/d6380bb6c6756d2a00ac20f2ffc454481d97e4d3">d6380bb</a>)</li> <li>the <code>--help</code> option is working without <code>webpack-dev-server</code> (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2267">#2267</a>) (<a href="https://github.com/webpack/webpack-cli/commit/1dae54da94d3220437b9257efe512447023de1d3">1dae54d</a>)</li> <li>the <code>--progress</code> option is working with <code>--json</code> (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2276">#2276</a>) (<a href="https://github.com/webpack/webpack-cli/commit/05956030cbb1491a2e9313732470bcd4ebe5a36d">0595603</a>)</li> </ul> <h2>v4.3.0</h2> <h1><a href="https://github.com/webpack/webpack-cli/compare/webpack-cli@4.2.0...webpack-cli@4.3.0">4.3.0</a> (2020-12-25)</h1> <h3>Bug Fixes</h3> <ul> <li>fix problems with <code>--mode</code> and config resolution, there are situations when we resolve an invalid config file, the <code>--mode</code> option does not affect on config resolution, if you faced with an error after updating, please use the <code>--config</code> option</li> <li>correct usage of cli-flags (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2205">#2205</a>) (<a href="https://github.com/webpack/webpack-cli/commit/c8fc7d1f195800c4fbe54ed6533e694f40fa7a1b">c8fc7d1</a>)</li> <li>defer setting default mode to core (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2095">#2095</a>) (<a href="https://github.com/webpack/webpack-cli/commit/3eb410e5d8f8e2149910b65f4a028c85f8af5d28">3eb410e</a>)</li> <li>respect the <code>--watch-options-stdin</code> option (<a href="https://github.com/webpack/webpack-cli/commit/2d1e001e7f4f560c2b36607bd1b29dfe2aa32066">2d1e001</a>)</li> <li>respect <code>--color</code>/<code>--no-color</code> option (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2042">#2042</a>) (<a href="https://github.com/webpack/webpack-cli/commit/09bd8126e95c9675b1f6862451f629cd4c439adb">09bd812</a>)</li> <li>stringify stats using streaming approach (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2190">#2190</a>) (<a href="https://github.com/webpack/webpack-cli/commit/9bf4e925757b02f7252073501562c95e762dc59b">9bf4e92</a>)</li> <li>use logger for error with proper exit code (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2076">#2076</a>) (<a href="https://github.com/webpack/webpack-cli/commit/2c9069fd1f7c0fb70f019900e4b841c5ea33975e">2c9069f</a>)</li> <li>reduce spammy logs (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2206">#2206</a>) (<a href="https://github.com/webpack/webpack-cli/commit/9b3cc283d7b74aa3bb26fe36c6110436b016e0d9">9b3cc28</a>)</li> <li>respect the <code>infrastructureLogging.level</code> option (logger uses <code>stderr</code>) (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2144">#2144</a>) (<a href="https://github.com/webpack/webpack-cli/commit/7daccc786a0eb4eeae4c5b3632fc28240a696170">7daccc7</a>)</li> <li>respect all options from command line for the <code>server</code> command</li> <li><code>help</code> and <code>version</code> output</li> <li>respect <code>stats</code> from the config (webpack@4) (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2098">#2098</a>) (<a href="https://github.com/webpack/webpack-cli/commit/2d6e5c6f4ed967368a81742bf347e39f24ee16c8">2d6e5c6</a>)</li> <li>fixed colors work with multi compiler mode (webpack@4)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md">webpack-cli's changelog</a>.</em></p> <blockquote> <h1><a href="https://github.com/webpack/webpack-cli/compare/webpack-cli@4.3.1...webpack-cli@4.4.0">4.4.0</a> (2021-01-19)</h1> <h3>Bug Fixes</h3> <ul> <li>better description for <code>--no-watch-options-stdin</code> (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2288">#2288</a>) (<a href="https://github.com/webpack/webpack-cli/commit/4ee8665e01e8dce16448e0a4d3dd2293731695ab">4ee8665</a>)</li> <li>double commands output in help (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2298">#2298</a>) (<a href="https://github.com/webpack/webpack-cli/commit/efe81e986a6dca5cc9b72a5c9312dc21409f65b1">efe81e9</a>)</li> <li>pass all <code>argv</code> to configurations when <code>serve</code> command used (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2345">#2345</a>) (<a href="https://github.com/webpack/webpack-cli/commit/5070b9bcbd5bdac00088d0c21486ad181a4df000">5070b9b</a>)</li> <li>respect <code>--stats</code>, <code>--color</code> and <code>--no-color</code> option for <code>serve</code> command (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2312">#2312</a>) (<a href="https://github.com/webpack/webpack-cli/commit/73d3feced18b4e3708f958707326a6642a594cf2">73d3fec</a>)</li> <li>show exact package name while prompting for installation (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2338">#2338</a>) (<a href="https://github.com/webpack/webpack-cli/commit/ffc93e556d784e2d4409cb0d3a92d737850996f4">ffc93e5</a>)</li> <li>webpack installation prompt message (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2316">#2316</a>) (<a href="https://github.com/webpack/webpack-cli/commit/3659c5e529fe1319251ef1c713d6cc758f7f5353">3659c5e</a>)</li> </ul> <h3>Features</h3> <ul> <li>added the <code>configtest</code> command (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2303">#2303</a>) (<a href="https://github.com/webpack/webpack-cli/commit/eb7b18937d045261a5b20ca8356e8b4ae4dfcaad">eb7b189</a>)</li> <li>added the <code>build</code> command (aliases - <code>bundle</code> and <code>b</code>) (<a href="https://github.com/webpack/webpack-cli/commit/7590f66663ce701d52d9276c3adf9dbdfd1a0fa4">7590f66</a>)</li> <li>added the <code>watch</code> command (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2357">#2357</a>) (<a href="https://github.com/webpack/webpack-cli/commit/9693f7d9543a8fce610c4ef903ccca0d12d229a1">9693f7d</a>)</li> <li>allow to pass parseOption to CLI class (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2299">#2299</a>) (<a href="https://github.com/webpack/webpack-cli/commit/2af08013852a95c6f6462c56a9994a4ee28c6ea1">2af0801</a>)</li> <li>allow to use <code>help</code> command to show option information (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2353">#2353</a>) (<a href="https://github.com/webpack/webpack-cli/commit/15eb411237dcdcf0db7a501c103fe53f9b82903f">15eb411</a>)</li> <li>show multiple suggestions on unknown options (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2349">#2349</a>) (<a href="https://github.com/webpack/webpack-cli/commit/7314d6ca927473da2f355a7d356a943471488606">7314d6c</a>)</li> </ul> <h2><a href="https://github.com/webpack/webpack-cli/compare/webpack-cli@4.3.0...webpack-cli@4.3.1">4.3.1</a> (2020-12-31)</h2> <h3>Bug Fixes</h3> <ul> <li>error message on not installed module loaders for configuration (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2282">#2282</a>) (<a href="https://github.com/webpack/webpack-cli/commit/29eaa8e843510e020ac4b57a13622df40713fe27">29eaa8e</a>)</li> <li>peer dependencies (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2284">#2284</a>) (<a href="https://github.com/webpack/webpack-cli/commit/083f2a069d6dc0a3b9492eb3f205474ba843acfd">083f2a0</a>)</li> <li>provide useful error on unknown command (<a href="https://github.com/webpack/webpack-cli/commit/d6380bb6c6756d2a00ac20f2ffc454481d97e4d3">d6380bb</a>)</li> <li>the <code>--help</code> option is working without <code>webpack-dev-server</code> (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2267">#2267</a>) (<a href="https://github.com/webpack/webpack-cli/commit/1dae54da94d3220437b9257efe512447023de1d3">1dae54d</a>)</li> <li>the <code>--progress</code> option is working with <code>--json</code> (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2276">#2276</a>) (<a href="https://github.com/webpack/webpack-cli/commit/05956030cbb1491a2e9313732470bcd4ebe5a36d">0595603</a>)</li> </ul> <h1><a href="https://github.com/webpack/webpack-cli/compare/webpack-cli@4.2.0...webpack-cli@4.3.0">4.3.0</a> (2020-12-25)</h1> <h3>Bug Fixes</h3> <ul> <li>fix problems with <code>--mode</code> and config resolution, there are situations when we resolve an invalid config file, the <code>--mode</code> option does not affect on config resolution, if you faced with an error after updating, please use the <code>--config</code> option</li> <li>correct usage of cli-flags (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2205">#2205</a>) (<a href="https://github.com/webpack/webpack-cli/commit/c8fc7d1f195800c4fbe54ed6533e694f40fa7a1b">c8fc7d1</a>)</li> <li>defer setting default mode to core (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2095">#2095</a>) (<a href="https://github.com/webpack/webpack-cli/commit/3eb410e5d8f8e2149910b65f4a028c85f8af5d28">3eb410e</a>)</li> <li>respect the <code>--watch-options-stdin</code> option (<a href="https://github.com/webpack/webpack-cli/commit/2d1e001e7f4f560c2b36607bd1b29dfe2aa32066">2d1e001</a>)</li> <li>respect <code>--color</code>/<code>--no-color</code> option (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2042">#2042</a>) (<a href="https://github.com/webpack/webpack-cli/commit/09bd8126e95c9675b1f6862451f629cd4c439adb">09bd812</a>)</li> <li>stringify stats using streaming approach (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2190">#2190</a>) (<a href="https://github.com/webpack/webpack-cli/commit/9bf4e925757b02f7252073501562c95e762dc59b">9bf4e92</a>)</li> <li>use logger for error with proper exit code (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2076">#2076</a>) (<a href="https://github.com/webpack/webpack-cli/commit/2c9069fd1f7c0fb70f019900e4b841c5ea33975e">2c9069f</a>)</li> <li>reduce spammy logs (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2206">#2206</a>) (<a href="https://github.com/webpack/webpack-cli/commit/9b3cc283d7b74aa3bb26fe36c6110436b016e0d9">9b3cc28</a>)</li> <li>respect the <code>infrastructureLogging.level</code> option (logger uses <code>stderr</code>) (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2144">#2144</a>) (<a href="https://github.com/webpack/webpack-cli/commit/7daccc786a0eb4eeae4c5b3632fc28240a696170">7daccc7</a>)</li> <li>respect all options from command line for the <code>server</code> command</li> <li><code>help</code> and <code>version</code> output</li> <li>respect <code>stats</code> from the config (webpack@4) (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2098">#2098</a>) (<a href="https://github.com/webpack/webpack-cli/commit/2d6e5c6f4ed967368a81742bf347e39f24ee16c8">2d6e5c6</a>)</li> <li>fixed colors work with multi compiler mode (webpack@4)</li> </ul> <h3>Features</h3> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/webpack/webpack-cli/commit/f55d44d243d6e101f7e7c88ddf0e7c567e33bd08"><code>f55d44d</code></a> chore(release): publish new version</li> <li><a href="https://github.com/webpack/webpack-cli/commit/586d228d40608e10ee99b99e146561854835fb26"><code>586d228</code></a> chore(deps-dev): bump eslint-config-prettier from 7.1.0 to 7.2.0 (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2364">#2364</a>)</li> <li><a href="https://github.com/webpack/webpack-cli/commit/366521e8d820a498ea2d95e8e41c218b019fe7d0"><code>366521e</code></a> chore(deps-dev): bump eslint from 7.17.0 to 7.18.0 (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2359">#2359</a>)</li> <li><a href="https://github.com/webpack/webpack-cli/commit/9693f7d9543a8fce610c4ef903ccca0d12d229a1"><code>9693f7d</code></a> feat: added the <code>watch</code> command (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2357">#2357</a>)</li> <li><a href="https://github.com/webpack/webpack-cli/commit/451b904393c9d0b92e49d8c7706a847ab1b2dc8b"><code>451b904</code></a> chore(deps-dev): bump husky from 4.3.7 to 4.3.8 (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2360">#2360</a>)</li> <li><a href="https://github.com/webpack/webpack-cli/commit/8aeca45aaafdddcae4adabc414c43e8486850772"><code>8aeca45</code></a> chore(deps-dev): bump webpack from 5.14.0 to 5.15.0 (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2358">#2358</a>)</li> <li><a href="https://github.com/webpack/webpack-cli/commit/487691abc8d817f5b3c1ab87743d7235ff15d956"><code>487691a</code></a> feat: <code>configtest</code> validate default configuration (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2354">#2354</a>)</li> <li><a href="https://github.com/webpack/webpack-cli/commit/38869d20075fc2fd0a5a65cc88f855bcb5928e21"><code>38869d2</code></a> chore(deps-dev): bump @types/node from 14.14.20 to 14.14.21 (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2355">#2355</a>)</li> <li><a href="https://github.com/webpack/webpack-cli/commit/15eb411237dcdcf0db7a501c103fe53f9b82903f"><code>15eb411</code></a> feat: allow to use <code>help</code> command to show option information (<a href="https://github-redirect.dependabot.com/webpack/webpack-cli/issues/2353">#2353</a>)</li> <li><a href="https://github.com/webpack/webpack-cli/commit/7590f66663ce701d52d9276c3adf9dbdfd1a0fa4"><code>7590f66</code></a> feat: added <code>build</code> command (aliases - 'bundle' and 'b')</li> <li>Additional commits viewable in <a href="https://github.com/webpack/webpack-cli/compare/v3.3.12...webpack-cli@4.4.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+235 -86

0 comment

2 changed files

pr created time in 3 hours

delete branch sourcecred/sourcecred

delete branch : dependabot/npm_and_yarn/flow-bin-0.142.0

delete time in 3 hours

PR closed sourcecred/sourcecred

build(deps-dev): bump flow-bin from 0.135.0 to 0.142.0 dependencies

Bumps flow-bin from 0.135.0 to 0.142.0. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/flowtype/flow-bin/commits">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+5 -5

1 comment

2 changed files

dependabot[bot]

pr closed time in 3 hours

pull request commentsourcecred/sourcecred

build(deps-dev): bump flow-bin from 0.135.0 to 0.142.0

Superseded by #2680.

dependabot[bot]

comment created time in 3 hours

PR opened sourcecred/sourcecred

build(deps-dev): bump flow-bin from 0.135.0 to 0.143.1

Bumps flow-bin from 0.135.0 to 0.143.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/flowtype/flow-bin/commits">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+82 -6

0 comment

2 changed files

pr created time in 3 hours

create barnchsourcecred/sourcecred

branch : dependabot/npm_and_yarn/flow-bin-0.143.1

created branch time in 3 hours

push eventsourcecred/sourcecred

Thena Seer

commit sha 25ea35e293e584e4394886c67c53753a715ce796

Add last distribution timestamp to the AccountOverview page (#2673)

view details

Eli

commit sha 1d15e8223f263dfa7d290a31ff287c45a8e88e12

core/ledger: add NonnegativeGrain type (#2666) __Context__ This commit adds a `NonnegativeGrain` type which will be used by grain allocation policies for the type of their budgets. This helps push a subspace of error handling onto Flow. `NonnegativeGrain` is implemented as an oqaque type similar to Grain, with stricter lifting functions which check for nonnegativity. __Test Plan__ Unit tests for `NonnegativeGrain` are provided. The tests are forks of tests on `Grain`.

view details

Eli

commit sha cd80249caecd463cfc94f621d5b0f0f148247f9d

policies: Use NonnegativeGrain as budget type (#2669) * core/ledger: add NonnegativeGrain type __Context__ This commit adds a `NonnegativeGrain` type which will be used by grain allocation policies for the type of their budgets. This helps push a subspace of error handling onto Flow. `NonnegativeGrain` is implemented as an oqaque type similar to Grain, with stricter lifting functions which check for nonnegativity. __Test Plan__ Unit tests for `NonnegativeGrain` are provided. The tests are forks of tests on `Grain`. * policies: Use NonnegativeGrain as budget type __Context__ This commit uses the `NonnegativeGrain` type for the budget type of grain allocation policies. This helps strongly enforce the nonnegativity of budgets, while reducing the need to manually check if budgets are negative. In addition, we use `NonnegativeGrain`'s parser to parse directly into policies without any upgrading. __Test Plan__ Policy unit tests all updated to lift budget input into `NonnegativeGrain`.

view details

Eli

commit sha 56bc1a2ff87252b982b7f8d683cc2f3f2d6ec2dd

grain allocation policies: add config parser (#2670) __Context__ This commit adds a new parser for each grain allocation policy, as well as a higher order parser which checks that the data parses to one of the allocation policies. This will be used in our upgraded grain config, which will take an array of allocation policies. This parser parses user input directly into allocation policies without needing any upgrade functions. This will help us eliminate the `toDistributionPolicy` function in `api/grainConfig` entirely. The main difference in this parser is that it allows users to enter human readable grain amounts instead of attoGrain amounts without needing to write an upgrade function. __Test Plan__ Trivial change, tests for the `numberParser` subparser are provided in `core/ledger/nonnegativegrain.test`.

view details

Eli

commit sha 9e05e891e6f26de68826cfd22f4b867a5115dbe1

cli/grain2: grain2 command using CredGraph (#2672) __Context__ This commit implements a `grain2` command, which is a simple fork of `grain` that moves away from using the soon to be deprecated `CredView` and instead uses `CredGraph`. This is part of a larger effort from @blueridger to replace `CredView` with `CredGrainView`. Note that `grain2` now loads the `CredGraph` instead of `CredResults`. This commit also implements forks of `applyDistributions` and `computeCredAccounts` to take a `CredGraph` instead of a `CredView`. We can phase out the originals when we deprecate `CredView` officially. __Assumptions__ - Original applyDistributions and computeCredAccounts works. I forked this assuming it works, but there's no test for it. __Test Plan__ Ran `grain2` and `grain` on the same sample instance. - Distribution output in ledger matches using JSON.stringify - -s flag does not write to ledger in grain2 as expected

view details

Kevin Siegler

commit sha e852a98200eedb3a1d89f6ba75a35abe43b12a44

Add CODEOWNERS config (#2635) Add CODEOWNERS config This config will enable Github to automatically assign reviewers on opened Pull Requests. test plan: If you've been @'d please approve this PR to agree to your assignments

view details

Hammad Jutt

commit sha 41fcd6c03e625324b9af9da02c0c38763914fd5b

Implement LedgerDiskStorage for LedgerManager (#2653) This implementation of LedgerStorage can be used in a locally running frontend to replace our current method for loading and saving the ledger to the local filesystem. This storage adapter can later be swapped out for one that talks to GitHub directly, allowing for instance management without dealing with git and eventually without needing to run it locally once we have our auth system in place Test Plan: Dont have unit tests in frontend code, so just sanity check that the implementation looks right. Future PR will refactor the loading code to use this instead, that's when it can be tested in the front end directly.

view details

Eli

commit sha 883964f31d73971e58ac2d1c1efcb75d51e33600

grainConfig: take array of policies (#2671) __Context__ After implementing the Recent policy and a variant of Balanced (#2584), we can see that adding policy parameters for new policies is both tedious on from our perspective as well as for the user. More specifically, on the user side, their config is a flat object with parameters from different policies sitting side by side. Here, we implement more structure by taking an array of policies. Right now, an example config/grain.json might look as follows: ```js { "balancedPerWeek": 30 "immediatePerWeek": 50, "recentPerWeek": 20, "maxSimultaneousDistributions": 2, "discount": 0.5 } ``` This also forced us to check each policy explicitly downstream in toDistributionPolicy, which could be a lot cleaner if we could leverage the AllocationPolicy type we already have. Now, we have a parser which will eliminate the need for the function entirely after we remove the deprecated config. Config now looks (for example) as follows: ```js { allocationPolicies: [ { policyType: "BALANCED", budget: 100 }, { policyType: "RECENT", budget: 50, discount: 0.1 }, { policyType: "RECENT", budget: 100, discount: 0.5 }] } ``` Note that for the time being, we support the deprecated config. For example: ```js { balancedPerWeek: 10, immediatePerWeek: 10, allocationPolicies: [ { policyType: "BALANCED", budget: 100 }, { policyType: "RECENT", budget: 50, discount: 0.1 }, { policyType: "RECENT", budget: 100, discount: 0.5 }] } `` This also lets us take multiple versions of the same policies. This allows us to create richer ensembles of policies. For instance, I might want to run a Recent policy with a 90% discount, and another one with a 5% discount. __Test Plan__ Unit tests are provided here for both the parser, and well as toDistributionPolicy, which serves to check the config.

view details

Eli

commit sha 3dc9fca313f091fe99ba7a267cbf058e2a7ccd2c

grain cli: distribution + allocation markdown tables (#2571) __Description__ This adds support for generating markdown tables of distributions given an instance's `config/grain.json`. Users can now view the grain distributed to each recipient across individual policies and also collectively. Each distribution generates a table showing the aggregate distribution to users across policies along with their percentage share. For each allocation policy in the distribution, we also provide tables with the amount distributed to each user. __Test Plan__ I tested this using different policy configs on my local instance, and sanity checked the formatting myself. In addition I ran this with 1Hive's instance to make sure the currency logic worked in practice. Wrote unit test for formatting helper function.

view details

Eli

commit sha fac25f6c23005f8c3a9cb79471d83e6f71eca668

immediate policy: add lookback parameter (#2660) Right now, the immediate policy uses cred from the most recent interval. This generalizes it such that users can create policies based on the past N weeks, without the discounting of the Recent policy. This includes an optional `numInteravlsLookback` parameter in the `ImmediatePolicy` type, which defaults to 1 in config until #2600 gets merged, at which point we'll allow users to specify alternative lookback lengths. Note, this raises a question around naming, as Recent is actually a better name here, and we could use something for the current Recent policies that highlights the discounting more. __Test Plan__ Unit tests provided check that the `immediatePolicy` works for valid params, and also checks for invalid `numIntervalsLookback` parameters. This also updates the snapshot in `core/ledger/ledger.test` to include this extra paramter on the `ImmediatePolicy`.

view details

Hammad Jutt

commit sha 0d9da61466edb3ce6d86cbf7a66a55d228f7511d

Use LedgerManager to control loading ledger state on frontend (#2655) * Fix warnings for missing key value in renderIdentities React needs the key to be on the containing element when rendering a list of items, otherwise it gives error for missing key value. Test plan: Ensure there's no missing key value error in console when on the Identities page * Use LedgerManager to control loading ledger state on frontend Replaces the manual loading method used previously to using the LedgerManager to abstract the loading logic. Can be used to enable different ledger storage backends in the future. Test Plan: Ensure ledger still loads correctly and UI updates when making ledger changes * Add try/catch around loading ledger in LedgerManager Graceful failure allows frontend to display all types of ledger loading errors instead of throwing an error that breaks the render loop. Test Plan: Ensure a failed ledger load still renders the error message on the front end

view details

Hammad Jutt

commit sha fe37de8f3802aca4f9c99b45794dc673a13e1af5

Update Save Ledger logic to use LedgerManager Replaced all the instances of the manually written POST requests with a saveLedger function so that the LedgerManager logic is used to save to disk and abstracted from the UI layer. Can be used in the future to persist the ledger to various backends. Also added an alert so the user gets a visual confirmation that the Ledger has been saved (or if there was an error) Test Plan: Update the ledger from the Identities / Transfer / Special distribution pages and save it. Ensure the ledger file is updated and the alert confirms the ledger was saved.

view details

Hammad Jutt

commit sha 6c0e31563122bfdf8b2594040b876ba690ed7075

Add source files to published NPM package This allows editors to show code completion, highlighting, and makes it easy for users to know what options / params are available when consuming the sourcecred API from the NPM package. This is accomplished by including the src/ folder in the list of files included in the NPM package. Adding the "module" field in the package.json also enables users to use the `import sourcecred from 'sourcecred';` syntax and get the same code completion / highlighting benefits as using `const sourcecred = require('sourcecred');`. Lastly, setting `libraryExport: "default"` in webpack.config.api.js makes it so users dont need to write `const sourcecred = require('sourcecred').default;` when importing the package. Test Plan: Install the test package that's bundled using this new setup and see if code completion / highlighting is working correctly: `yarn add sourcecred-publish-test`

view details

VictorGinelli

commit sha b07b18c9bbd6c3dfbd26cacc72670c5a114511f0

Generate base docs (#2435) Add jsdoc for automated doc generation

view details

dependabot[bot]

commit sha 66188a222d3e13dfb5ded06d2c3060e83578e530

build(deps-dev): bump eslint from 7.17.0 to 7.18.0 Bumps [eslint](https://github.com/eslint/eslint) from 7.17.0 to 7.18.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v7.17.0...v7.18.0) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 3 hours

delete branch sourcecred/sourcecred

delete branch : cred-graph-intervals

delete time in 3 hours

more