profile
viewpoint

beyang/cheerio 13

Some utility commands you wish were in Python's pip

beyang/black 1

Make everything black

beyang/about 0

Sourcegraph blog, feature announcements, and website (about.sourcegraph.com)

beyang/ajenti 0

Ajenti - the web admin panel everyone wants.

beyang/angular-app 0

Reference application for AngularJS

beyang/angular-dataform 0

Reliable, componentized data form controls for AngularJS

beyang/angular-seed 0

Seed project for angular apps.

PR opened sourcegraph/sourcegraph

Reviewers
remove deprecated /repos/list endpoint (replaced by /repos/index)

Remove the deprecated /repos/list endpoint, which was previously used by zoekt to determine which repos to index. This call has been replaced by /repos/index.

The docs have been updated to reflect this.

+1 -163

0 comment

4 changed files

pr created time in 20 minutes

create barnchsourcegraph/sourcegraph

branch : bl/remove-deprecated-repos-list-endpoing

created branch time in 21 minutes

create barnchbeyang/tmp8

branch : master

created branch time in an hour

created repositorybeyang/tmp8

created time in an hour

push eventbeyang/tmp7

Beyang Liu

commit sha e1b2bfd6607ef826ddf11f233f93eae530981578

hash

view details

push time in an hour

create barnchbeyang/tmp7

branch : master

created branch time in an hour

created repositorybeyang/tmp7

created time in an hour

create barnchbeyang/tmp6

branch : master

created branch time in an hour

created repositorybeyang/tmp6

created time in an hour

create barnchbeyang/tmp5

branch : master

created branch time in an hour

created repositorybeyang/tmp5

created time in an hour

create barnchbeyang/tmp4

branch : master

created branch time in an hour

created repositorybeyang/tmp4

created time in an hour

create barnchbeyang/tmp1

branch : master

created branch time in an hour

created repositorybeyang/tmp1

created time in an hour

PublicEvent

create barnchbeyang/tmp0

branch : master

created branch time in 12 hours

created repositorybeyang/tmp0

created time in 12 hours

push eventsourcegraph/about

Beyang Liu

commit sha 087dd96d890986de44384eb518780d9c24dc154e

podcast: eculver: update link

view details

push time in 13 hours

push eventsourcegraph/about

Beyang Liu

commit sha 2b3f4cea36c397dc711d682fd780c814b36257ac

podcast: lh: update name

view details

push time in 13 hours

issue commentsourcegraph/sourcegraph

Diff query for unknown revision is slow

@aisbaa has this issue been resolved for you?

beyang

comment created time in a day

push eventsourcegraph/about

Beyang Liu

commit sha cd88e96555821cb8a746e101869014c94ed9fcc4

podcast: lh

view details

push time in 2 days

create barnchsourcegraph/about

branch : bl/podcast-lh

created branch time in 2 days

create barnchsourcegraph/about

branch : bl/podcast/lh

created branch time in 2 days

push eventsourcegraph/about

Beyang Liu

commit sha 32a365483059cf1757937b93401f45297bb7d8ea

podcast: correct publish date

view details

push time in 2 days

push eventsourcegraph/about

Beyang Liu

commit sha 1c992023746c8f86c9692cd88c035ccfc51141fc

podcast: publish evan culver

view details

push time in 3 days

push eventsourcegraph/about

Beyang Liu

commit sha 82f8e851e643916f827162a3ca376c7679281ac2

podcast: david cramer better transcript

view details

push time in 3 days

PR opened sourcegraph/about

Propose edits to the LSIF "year in review" blog post

@efritz PTAL. I added a TODO(efritz) and we should add back the PR links so they are more integrated into the flow of the text.

+123 -89

0 comment

1 changed file

pr created time in 3 days

push eventsourcegraph/about

Beyang Liu

commit sha eacdd57b2403dda7bdec1a1af8f7f707032988ba

edits

view details

push time in 3 days

push eventsourcegraph/about

Beyang Liu

commit sha 96b6125af63928c43310ae9c68e43981d07bf3fc

.

view details

push time in 4 days

push eventsourcegraph/about

Beyang Liu

commit sha f1fda37405aadd7b9835568afd916e804a01146c

.

view details

push time in 5 days

push eventsourcegraph/about

Beyang Liu

commit sha 20a863bf5c69c75ed1e2e860b200df5c4a2302d6

.

view details

push time in 5 days

push eventsourcegraph/about

Beyang Liu

commit sha 00bea40bd7cd376d5f0ef54d83c59979d2db3784

fix link and build

view details

Beyang Liu

commit sha a4c8573c37ae29950b62df05489d7f224175f140

wip

view details

Beyang Liu

commit sha 399fbbf0fc3e22adf684b0365a6a5b372cbf6da4

wip

view details

push time in 5 days

push eventsourcegraph/about

Beyang Liu

commit sha 00bea40bd7cd376d5f0ef54d83c59979d2db3784

fix link and build

view details

push time in 5 days

push eventsourcegraph/about

Beyang Liu

commit sha 373a6db0d57a5bd5a29d6b97536949e2a807baaa

podcast: publish charity majors

view details

Beyang Liu

commit sha b3f05a3361dd1e7ff557a86e39bb9561fdbb5ac6

podcast: evan culver

view details

Christina Forney

commit sha e75417a5d5fb8afcdad225cdf4ec3eb1e6770e31

Move design into product, clean up spacing, clean up links (#1119)

view details

Tomás Senart

commit sha 8248cdbc6ee9349a87de8a2e57c5d7a4697cb1d8

Read tracking issues docs in on-boarding

view details

Quinn Slack

commit sha b25a924c20bfa12a2c2099fbd09461a27f413d78

Sharing company financials with candidates (#1116)

view details

Chayim

commit sha a07478c8dac8eb7e3ed43c674e903181aad4aaee

Update holidays.md (#1125) Updating holiday policy to including advance reminders to team and managers.

view details

Nick Snyder

commit sha d8ca30a64af9b06c0e5b7f4c559da09c5bff3ea2

Clarify Loïc's and Nick's involvement in search team (#1122)

view details

Quinn Slack

commit sha fbc0077f155ba22da7ec7eb470b387edbe6ad895

Update company_meeting.md

view details

Chayim

commit sha 2a94f08e4b2f5df6c9551a206691ee295a6beaf7

Update index.md (#1121) Adding myself to Sourcegraph.

view details

Nick Snyder

commit sha dc490c9785872930407706514afdafdeb226e8a8

Link to real examples for progress updates (#1127)

view details

Nick Snyder

commit sha 461fef71a3642cb2ad8e2089f0dbd4ca74f749e6

Add security team responsibilities (#1124)

view details

Beyang Liu

commit sha 977bab9ed4b1e82293f8e989f70444bf7b2bc1b8

podcast: more prominent subscribe CTA, add youtube link (#1128)

view details

AlicjaSuska

commit sha 0e104629fb274063d43c0f2fea6be2db5ae531a8

Added: Alicja to the Team page

view details

Quinn Slack

commit sha 6c65491a3e8ac9dbdfce402a324aad4f91d6b46f

add campaigns new flow doc pages

view details

Beyang Liu

commit sha c5e3a5b917f6b7509276bcf4c02a62ff5e2ed53e

Revert "blog: unpublish posts for now, until cleanup and rerelease" This reverts commit 3d4c35f018cfe4a4a6f27ad63f81b1241322f3ae.

view details

Nick Snyder

commit sha c5e4020b9bcc849b543cde2b53b6cd88d332c887

fix formatting

view details

Eric Fritz

commit sha f6f6507cebb3bab4ec5ce17a999bb9e01ac4a489

Mark Eric Fritz as code intelligence project lead (#1132)

view details

Stephen Gutekanst

commit sha ee90a612f508036ff2992f4472c5faee05d0624f

document how to set up Zoom recordings to go to Slack automatically (#1133) * entry * document how to setup Zoom recordings to go to Slack automatically

view details

LaureenH

commit sha 31d92189b7c5ceb48f8a26c04a2ad44d87052dba

major editorial changes to the guide, addition of RFC 184 terminology to the term usage guide, added headings, rearranged content for easier reference and grouping of like items.

view details

LaureenH

commit sha 0d6b27e8807f6ebe3c4b881fdacada3377559d84

Merge branch 'master' of github.com:sourcegraph/about

view details

push time in 5 days

push eventsourcegraph/about

Beyang Liu

commit sha a340880e34081929e3192e8d5ef721a9a530858e

blog: 3.17 precise code intel blog post edits (#1118) Co-authored-by: Eric Fritz <eric@eric-fritz.com>

view details

push time in 5 days

delete branch sourcegraph/about

delete branch : bl/precise-code-intel-blog

delete time in 5 days

PR merged sourcegraph/about

Reviewers
blog: 3.17 precise code intel blog post edits

@efritz here's my initial edit of the post. I marked action items for you with TODO(efritz) in the code. PTAL

cc @LaureenH

Roadmap from here (not necessarily done in serial):

  • [x] Eric adds additional content and detail (see TODO(efritz) in the code)
  • [ ] Laureen takes a pass, signs off
  • [x] Beyang takes a final pass
  • [x] Change the URL (add a redirect from the old one)
  • [ ] We will republish and reshare on social media when this is done. Hold off on posting to HN for a few days to see if a community member posts it.
+244 -111

3 comments

2 changed files

beyang

pr closed time in 5 days

pull request commentsourcegraph/about

blog: 3.17 precise code intel blog post edits

Merging this proactively, since I think the post is already published and I think the improvements are clear. @LaureenH happy to address any comments you after in a subsequent patch.

beyang

comment created time in 5 days

push eventsourcegraph/about

Beyang Liu

commit sha 9f89e854d28a309f765643110bceaee0540a122f

minor changes

view details

push time in 5 days

push eventsourcegraph/about

Beyang Liu

commit sha c4bb1007090a44b6cc3971f8765c726f48bced06

update URL

view details

push time in 5 days

push eventsourcegraph/about

Beyang Liu

commit sha 6342cc67ee1c3af2e8c32d8fa37438cf424a999c

update hero image

view details

push time in 5 days

push eventsourcegraph/about

Beyang Liu

commit sha 939afe4ee1cd729a391d8712e43230a375c1fea4

more edits

view details

push time in 6 days

pull request commentsourcegraph/about

blog: 3.17 precise code intel blog post edits

@efritz one last TODO for you. @LaureenH this is ready for your review.

beyang

comment created time in 6 days

push eventsourcegraph/about

Beyang Liu

commit sha 0a47ba3ba1e0a03d363f9f69bb0b5f3a9ba05d04

more edits

view details

push time in 6 days

create barnchsourcegraph/about

branch : bl/tmp

created branch time in 6 days

push eventsourcegraph/about

Nick Snyder

commit sha b50e93695e7b016aeec3ec99b8d8c962b397eceb

Weekly updates from each engineering team (#1083)

view details

Quinn Slack

commit sha d8388e1f3043809909b366cf6a8b8d14b9b29187

CEO interview description (#1110)

view details

Rob Rhyne

commit sha 471875af1b111df1181d072856e861ecb3030778

Design process documentation (#1084)

view details

Rob Rhyne

commit sha 9682e5f40f6308e29109e49371eabb3cc1b77d2e

Add product designer onboarding (#1113)

view details

Rob Rhyne

commit sha 42f271c12d7734eef6cbababd4d586494838cf56

Add potential UX projects

view details

Dan Adler

commit sha 28c3a1c3e5bb41673ce92565eb6579e185aaeba6

Add Slack messaging during off-hours policy (#1068) * Add Slack messaging during off-hours policy * Fix links * Fix links

view details

Dan Adler

commit sha b4b76c6dbc62c9958734a10f98d39a9d50fb25d6

Move "support" to "ce"; add CE onboarding (#1081) * support -> CE; add CE onboarding * Add redirects and update links * Fix broken links

view details

Beyang Liu

commit sha 3d4c35f018cfe4a4a6f27ad63f81b1241322f3ae

blog: unpublish posts for now, until cleanup and rerelease

view details

Beyang Liu

commit sha 373a6db0d57a5bd5a29d6b97536949e2a807baaa

podcast: publish charity majors

view details

Beyang Liu

commit sha b3f05a3361dd1e7ff557a86e39bb9561fdbb5ac6

podcast: evan culver

view details

Christina Forney

commit sha e75417a5d5fb8afcdad225cdf4ec3eb1e6770e31

Move design into product, clean up spacing, clean up links (#1119)

view details

Tomás Senart

commit sha 8248cdbc6ee9349a87de8a2e57c5d7a4697cb1d8

Read tracking issues docs in on-boarding

view details

Quinn Slack

commit sha b25a924c20bfa12a2c2099fbd09461a27f413d78

Sharing company financials with candidates (#1116)

view details

Chayim

commit sha a07478c8dac8eb7e3ed43c674e903181aad4aaee

Update holidays.md (#1125) Updating holiday policy to including advance reminders to team and managers.

view details

Nick Snyder

commit sha d8ca30a64af9b06c0e5b7f4c559da09c5bff3ea2

Clarify Loïc's and Nick's involvement in search team (#1122)

view details

Quinn Slack

commit sha fbc0077f155ba22da7ec7eb470b387edbe6ad895

Update company_meeting.md

view details

Chayim

commit sha 2a94f08e4b2f5df6c9551a206691ee295a6beaf7

Update index.md (#1121) Adding myself to Sourcegraph.

view details

Nick Snyder

commit sha dc490c9785872930407706514afdafdeb226e8a8

Link to real examples for progress updates (#1127)

view details

Nick Snyder

commit sha 461fef71a3642cb2ad8e2089f0dbd4ca74f749e6

Add security team responsibilities (#1124)

view details

Beyang Liu

commit sha 977bab9ed4b1e82293f8e989f70444bf7b2bc1b8

podcast: more prominent subscribe CTA, add youtube link (#1128)

view details

push time in 7 days

startedmicrosoft/pyright

started time in 7 days

push eventsourcegraph/about

Beyang Liu

commit sha 9545d907d2a3c9b2296151cef84edbd0eda8d61b

fix build

view details

push time in 7 days

push eventsourcegraph/about

Beyang Liu

commit sha cd5be00d9f8186aef6367ff0b76230a919cce8c0

podcast: do not preload files to avoid polluting stats

view details

push time in 8 days

create barnchsourcegraph/sourcegraph

branch : bl/explore

created branch time in 8 days

issue openedsourcegraph/sourcegraph

Add word wrap to code view

Word wrap would be nice when reading Markdown files with long paragraphs (example).

created time in 8 days

push eventsourcegraph/about

Beyang Liu

commit sha c5e3a5b917f6b7509276bcf4c02a62ff5e2ed53e

Revert "blog: unpublish posts for now, until cleanup and rerelease" This reverts commit 3d4c35f018cfe4a4a6f27ad63f81b1241322f3ae.

view details

push time in 9 days

startedrShetty/awesome-podcasts

started time in 9 days

push eventsourcegraph/about

Beyang Liu

commit sha 977bab9ed4b1e82293f8e989f70444bf7b2bc1b8

podcast: more prominent subscribe CTA, add youtube link (#1128)

view details

push time in 9 days

delete branch sourcegraph/about

delete branch : bl/podcast-cta

delete time in 9 days

create barnchsourcegraph/about

branch : bl/podcast-cta

created branch time in 9 days

PR opened sourcegraph/about

rm docsite.json (docsite config is set in private config repo

It appears the docsite config is set in a private config repo, and this docsite.json is overridden. So its existence is misleading.

+0 -12

0 comment

1 changed file

pr created time in 10 days

create barnchsourcegraph/about

branch : bl/remove-docsite-config

created branch time in 10 days

push eventsourcegraph/about

Beyang Liu

commit sha b3f05a3361dd1e7ff557a86e39bb9561fdbb5ac6

podcast: evan culver

view details

push time in 10 days

push eventsourcegraph/about

Beyang Liu

commit sha 373a6db0d57a5bd5a29d6b97536949e2a807baaa

podcast: publish charity majors

view details

push time in 10 days

create barnchsourcegraph/about

branch : bl/precise-code-intel-blog-2

created branch time in 10 days

push eventsourcegraph/about

Beyang Liu

commit sha 3d4c35f018cfe4a4a6f27ad63f81b1241322f3ae

blog: unpublish posts for now, until cleanup and rerelease

view details

push time in 10 days

PR opened sourcegraph/about

Reviewers
blog: 3.17 precise code intel blog post edits

@efritz here's my initial edit of the post. I marked action items for you with TODO(efritz) in the code. PTAL

cc @LaureenH

Roadmap from here (not necessarily done in serial):

  • [ ] Eric adds additional content and detail (see TODO(efritz) in the code)
  • [ ] Laureen takes a pass, signs off
  • [ ] Beyang takes a final pass
  • [ ] Change the URL (add a redirect from the old one)
  • [ ] We will republish and reshare on social media when this is done. Hold off on posting to HN for a few days to see if a community member posts it.
+132 -110

0 comment

1 changed file

pr created time in 10 days

push eventsourcegraph/about

Beyang Liu

commit sha 5314f671e097c20f4b519c7cb390a160a19ea187

blog: 3.17 precise code intel blog post edits

view details

push time in 10 days

push eventsourcegraph/about

Beyang Liu

commit sha 016f357dbdee1bd9e22635b0710f60f0e155be89

.

view details

push time in 11 days

push eventsourcegraph/about

Beyang Liu

commit sha 7bd8efbe9e04e233e4f8420fed8b6ff2895aacde

.

view details

push time in 11 days

push eventsourcegraph/about

Beyang Liu

commit sha 62ec8c828f644d79862f792d83d4cba97bf086b6

.

view details

push time in 11 days

push eventsourcegraph/about

Beyang Liu

commit sha 5d6a288baa64f714942a4715d200be9322528f37

.

view details

push time in 11 days

push eventsourcegraph/about

Beyang Liu

commit sha 193d3224b538187d24b976e85292d2cc8a0e4084

.

view details

push time in 12 days

push eventsourcegraph/about

Beyang Liu

commit sha 95cb60a91089ad6ce3c47481af7c1e479b7efb54

.

view details

push time in 12 days

push eventsourcegraph/about

Beyang Liu

commit sha 06e1cd7fcbab5cc705e654a74b2624ba3907ae54

.

view details

push time in 13 days

push eventsourcegraph/about

Beyang Liu

commit sha c45f6e4bce2baa357046c20c79155d7745070704

wip

view details

push time in 13 days

push eventsourcegraph/about

Beyang Liu

commit sha 2b3e00e9c654ee01d935f1d71f0d053562616a48

podcast: publish ryan djurovich

view details

Beyang Liu

commit sha bf11e4dae45a077046463818f1020b7e5bafae47

podcast: fix some typos

view details

Beyang Liu

commit sha 6c79fe33d0629f44b59c0bff52147fd22a11ba2c

podcast: fix more typos

view details

Beyang Liu

commit sha 43ca1c5dd41f072975f3bb1d2fae1ff9db5ca06c

podcast: typo

view details

Beyang Liu

commit sha 06ad2be46ed5c760d7e6a2d5fae5d011f40ad25c

podcast: more typos

view details

Beyang Liu

commit sha c2ac4335079a4f1a0e57202931c6834cc53b1418

podcast: add show note link

view details

Dax McDonald

commit sha 49a09aeeeeab27aa2388d7d6685252dd4be81f69

Add note on tagging for reviewing RFCs (#1091)

view details

adam

commit sha 8946eb4cce3437c46d0642ade7fa377e4194a86f

remove online meetup (#1092)

view details

aileenrose

commit sha d69f7bd3cb690ea95e7c103b48068836f03d9ef2

Remove events (#1094)

view details

aileenrose

commit sha 263531973008e9d381c0f6d96c051ba77c6d1c09

Add Amazon logo (#1093)

view details

garo (they/them)

commit sha e2151fdc1734ca120f93fdf553708e34075fd2f0

Add Just Workplace value

view details

garo (they/them)

commit sha 81ca5772e772e0dd59f19e44e56e9fab42eec191

Update values.md

view details

Quinn Slack

commit sha 90ca366ca6ba1c85905194c02d4874f9202c3911

update install links (#1097)

view details

aileenrose

commit sha c10da49aaf51225f6093c776c537004c4e4b6218

Add website style guide and organize handbook index (#1076) * Add website style guide and organize handbook index * Fix logomark image and width.

view details

adam

commit sha 4b1003717900faf5e2261f738030d1e71ed819d6

update copy (#1098) * update copy fix install/upgrade links at the bottom * Update announcing-sourcegraph-3.17.md

view details

Noemi Mercado

commit sha 102b18998649cc58291939daff483180d55988e6

Update spending-company-money.md Specifying insurance includes Apple Care for Macs.

view details

Christina Forney

commit sha b49b33b27413938b795d17b82baa700bdfee5f94

Fixes #967 - update contributors script with PRs and pull team members (#1088)

view details

adam

commit sha d0ea8274da0475c1f6a7f88459d6a70b4bf03a80

more copy edits (#1102) based on feedback from Quinn

view details

adam

commit sha ab10abff26a2c3c53f230a9a01d8cd170a292ec7

remove link (#1103)

view details

Beyang Liu

commit sha dcded58aae3ec16d4bda90f500f96ca1a5772937

podcast: update charity majors summary

view details

push time in 13 days

issue commentsourcegraph/sourcegraph

Diff query for unknown revision is slow

My 2c on this:

  1. In general, I think it is better to have an explicit parameter to change the behavior of a request being made, rather than a "global" config parameter that affects behavior implicitly. As @ryanslade mentioned, this makes issues harder to diagnose and debug.
  2. No request to Sourcegraph should take down the entire site. There will always be users trying to do new things with our API and they and @aisbaa shouldn't have to worry about which requests might take down the site.

Could the fix for this address both? E.g.,

  • Add a parameter to the GraphQL endpoint to opt-in or out of blocking on fetching the revision.
  • Regardless of what the parameter value is, the request shouldn't bring down the entire site. It is better to return an error as a response than to compromise the entire site, no matter what the request is.
beyang

comment created time in 13 days

push eventsourcegraph/about

Beyang Liu

commit sha dcded58aae3ec16d4bda90f500f96ca1a5772937

podcast: update charity majors summary

view details

push time in 14 days

create barnchsourcegraph/about

branch : bl/precise-code-intel-blog

created branch time in 14 days

issue openedsourcegraph/sourcegraph

Make repo language query cache configurable

This is a follow up to https://github.com/sourcegraph/sourcegraph/issues/11466.

A team inside the customer relies on the GraphQL endpoint for languages in a repo to keep track of this information. They would like to ensure the results are no more than an hour stale. One possible way (not necessarily the best) of accomplishing this is to make the cache TTL configurable.

@aisbaa can you let us know the urgency level so we can prioritize accordingly?

created time in 16 days

push eventsourcegraph/about

Beyang Liu

commit sha c2ac4335079a4f1a0e57202931c6834cc53b1418

podcast: add show note link

view details

push time in 17 days

push eventsourcegraph/about

Beyang Liu

commit sha 06ad2be46ed5c760d7e6a2d5fae5d011f40ad25c

podcast: more typos

view details

push time in 17 days

push eventsourcegraph/about

Beyang Liu

commit sha 43ca1c5dd41f072975f3bb1d2fae1ff9db5ca06c

podcast: typo

view details

push time in 17 days

push eventsourcegraph/about

Beyang Liu

commit sha 6c79fe33d0629f44b59c0bff52147fd22a11ba2c

podcast: fix more typos

view details

push time in 17 days

push eventsourcegraph/about

Beyang Liu

commit sha bf11e4dae45a077046463818f1020b7e5bafae47

podcast: fix some typos

view details

push time in 17 days

push eventsourcegraph/about

Beyang Liu

commit sha 2b3e00e9c654ee01d935f1d71f0d053562616a48

podcast: publish ryan djurovich

view details

push time in 17 days

push eventsourcegraph/about

Beyang Liu

commit sha 02c0dadad2c683f70c31d613edeb90f19ba71aa4

podcast: fix typo

view details

push time in 17 days

push eventsourcegraph/about

Beyang Liu

commit sha e2752008972183fddbf4afb999f220bca88a8ec1

podcast: charity majors

view details

push time in 17 days

push eventsourcegraph/about

Beyang Liu

commit sha 55ab2bb3981479a357930109bdd964db85211062

fix capitalization

view details

push time in 20 days

create barnchsourcegraph/codenav-bash

branch : master

created branch time in 22 days

created repositorysourcegraph/codenav-bash

A Sourcegraph extension that provides code navigation for Bash and shell scripts

created time in 22 days

push eventsourcegraph/about

Beyang Liu

commit sha c1547a9710220d83758a88c8f189dcbc058ae007

podcast: episode 2: ryan djurovich don't preload audio on page load

view details

push time in 22 days

issue openedsourcegraph/sourcegraph

CTO: 3.18 Tracking Issue

Podcast

Roadmap doc

  • [ ] Release episode 2: Ryan Djurovich
  • [ ] Release episode 3: Charity Majors
  • [ ] Release episode 4: Evan Culver

Code intelligence

  • [ ] Release bash code intelligence extension
  • [ ] Bash exploration blog post
  • [ ] Take a deep dive into LSIF and see if you can improve Java indexer

created time in 22 days

push eventsourcegraph/sourcegraph

Beyang Liu

commit sha f921375982622b36f65edc9067b160cc0cf608fa

sort detected languages properly (#11468) sort detected languages by bytes if USE_ENHANCED_LANGUAGE_DETECTION=false

view details

push time in 24 days

push eventsourcegraph/sourcegraph

Beyang Liu

commit sha e77507d060a40355e7b86fb093d21a7149ea03ac

sort detected languages properly (#11468) sort detected languages by bytes if USE_ENHANCED_LANGUAGE_DETECTION=false

view details

push time in 24 days

delete branch sourcegraph/sourcegraph

delete branch : bl/fix-lang-detect

delete time in 24 days

PR merged sourcegraph/sourcegraph

sort detected languages properly

Sort detected languages properly even if USE_ENHANCED_LANGUAGE_DETECTION=false

Potentially fixes https://github.com/sourcegraph/sourcegraph/issues/11466

I'm not sure if this fix is good, because I'm unsure of the cost of invoking FileInfo.Size() for Go. Given that the customer set USE_ENHANCED_LANGUAGE_DETECTION=false for performance reasons, I want to ensure this fix actually works on their very large Go monorepo (see the issue description for more details).

+24 -10

2 comments

4 changed files

beyang

pr closed time in 24 days

issue closedsourcegraph/sourcegraph

Repository language query not returning correct results in a timely fashion

Original Slack thread: https://sourcegraph.slack.com/archives/CTGBWCKM0/p1591986011002500

Customer is issuing the following GraphQL query:

query ListLanguages($repoName: String!) {
  repository(name: $repoName) {
    language
    commit(rev: "HEAD") {
      languages
    }
  }
}

Their security team relies on this endpoint to be notified which languages are represented in the repository. The customer has USE_ENHANCED_LANGUAGE_DETECTION=false. On a lot of repositories, the wrong languages are returned, including their large Go mono-repo. The endpoint returns this (note the ordering is alphabetical with caps first):

{
  "data": {
    "repository": {
      "language": "AGS Script",
      "commit": {
        "languages": [
          "AGS Script",
          "AMPL",
          "ANTLR",
          "Assembly",
          "Awk",
          "C",
          "C++",
          "CSS",
          "CSV",
          ...
          "TeX",
          "Text",
          "Thrift",
          "Unity3D Asset",
          "Unix Assembly",
          "XML",
          "YAML",
          "YANG",
          "reStructuredText"
        ]
      }
    }
  }
}

Invoking enry (which is the library/tool we use under the hood) on a local checkout yields this (note the order is most common language first):

./enry ./path/to/repo -mode=oneline
<redacted>%	Go
<redacted>%	Python
<redacted>%	Thrift
<redacted>%	JavaScript
<redacted>%	Shell
<redacted>%	HTML
<redacted>%	TSQL
<redacted>%	CSS
<redacted>%	Makefile
<redacted>%	C
....
<redacted>%	PLSQL

Setting USE_ENHANCED_LANGUAGE_DETECTION=true fixes the languages detected for other repositories, but causes the request to timeout for the Go mono repo.

I have repro'd this on a local dev server on the code from github.com/sourcegraph/sourcegraph.

Customer notes that this was working earlier, but it is possible this has been broken since they set USE_ENHANCED_LANGUAGE_DETECTION=false in March 2020.

closed time in 24 days

beyang

push eventsourcegraph/about

Beyang Liu

commit sha f83f06b6ced3e96e72138ff00105067c0321fb32

podcast: publish david cramer

view details

push time in 24 days

PR opened sourcegraph/sourcegraph

Reviewers
sort detected languages properly

sort detected languages properly even if USE_ENHANCED_LANGUAGE_DETECTION=false

Potentially fixes https://github.com/sourcegraph/sourcegraph/issues/11466

+2 -0

0 comment

1 changed file

pr created time in a month

more