startedShizukuIchi/winXP

started time in a month

pull request commentdenoland/deno

WIP: Max latency

Sounds good. Looking forward to your talk on Thurs!

bernard-lin

comment created time in a month

push eventbernard-lin/deno

Bernard Lin

commit sha 9ec20f0ba0acb136447eba0d65e28987b63503cf

update function name for clarification

view details

push time in a month

Pull request review commentdenoland/deno

WIP: Max latency

 def hyper_http_benchmark(hyper_hello_exe):  def http_benchmark(deno_exe, hyper_hello_exe, core_http_bench_exe):     r = {}+    m = {}+     # TODO Rename to "deno_tcp"-    r["deno"] = deno_http_benchmark(deno_exe)-    r["deno_net_http"] = deno_net_http_benchmark(deno_exe)-    r["deno_core_single"] = deno_core_single(core_http_bench_exe)-    r["deno_core_multi"] = deno_core_multi(core_http_bench_exe)-    r["node"] = node_http_benchmark()-    r["node_tcp"] = node_tcp_benchmark()-    r["hyper"] = hyper_http_benchmark(hyper_hello_exe)-    return r+    denoHttp = deno_http_benchmark(deno_exe)+    denoNetHttp = deno_net_http_benchmark(deno_exe)+    denoCoreSingle = deno_core_single(core_http_bench_exe)+    denoCoreMulti = deno_core_multi(core_http_bench_exe)+    nodeHttp = node_http_benchmark()+    nodeTcp = node_tcp_benchmark()+    hyperHttp = hyper_http_benchmark(hyper_hello_exe)++    dic = {+        "deno": denoHttp,

thanks! it does look much cleaner

bernard-lin

comment created time in a month

push eventbernard-lin/deno

Bernard Lin

commit sha 47b50dfacc8efb9722fec41c2a60be15dc4b594e

use dict comprehension

view details

push time in a month

starteddenoland/deno

started time in a month

pull request commentdenoland/deno

WIP: Max latency

@ry - ready for another look

bernard-lin

comment created time in a month

push eventbernard-lin/deno

Bernard Lin

commit sha d763d0e46311381b32b455ba0894a0cc62ee6213

allow for different latency units

view details

push time in a month

pull request commentdenoland/deno

WIP: Max latency

will finish this tonight!

bernard-lin

comment created time in a month

issue commentnodeschool/nyc

Mentor registration May 7th

I'm in!

fhinkel

comment created time in a month

issue commentreact-spring/react-spring

👋 Maintainers wanted

I've loved using this library but haven't paid as much attention to its development. I'll start watching the repo 🙂

drcmda

comment created time in a month

Pull request review commentdenoland/deno

WIP: Max latency

 def extract_number(pattern, string):   def parse_wrk_output(output):-    req_per_sec = None+    stats = {}+    stats['req_per_sec'] = None+    stats['max_latency'] = None     for line in output.split("\n"):-        if req_per_sec is None:-            req_per_sec = extract_number(r'Requests/sec:\s+(\d+)', line)-    return req_per_sec+        if stats['req_per_sec'] is None:+            stats['req_per_sec'] = extract_number(r'Requests/sec:\s+(\d+)',+                                                  line)+        if stats['max_latency'] is None:+            stats['max_latency'] = extract_number(+                r'Latency(?:\s+(\d+).\d+[a-z]+){3}', line)

ah good point. noted, thanks!

bernard-lin

comment created time in a month

pull request commentdenoland/deno

WIP: Max latency

@bernard-lin , you should add req_per_sec and max_latency keys to {} in http_benchmark.py

def http_benchmark(deno_exe, hyper_hello_exe, core_http_bench_exe):
    r = {}
    # TODO Rename to "deno_tcp"
    r["deno"] = deno_http_benchmark(deno_exe)
    r["deno_net_http"] = deno_net_http_benchmark(deno_exe)
    r["deno_core_single"] = deno_core_single(core_http_bench_exe)
    r["deno_core_multi"] = deno_core_multi(core_http_bench_exe)
    r["node"] = node_http_benchmark()
    r["node_tcp"] = node_tcp_benchmark()
    r["hyper"] = hyper_http_benchmark(hyper_hello_exe)
    return r

Example:

def http_benchmark(deno_exe, hyper_hello_exe, core_http_bench_exe):
    r = {}
    m = {}
    # TODO Rename to "deno_tcp"
    r["deno"] = deno_http_benchmark(deno_exe)["req_per_sec"]
    r["deno_net_http"] = deno_net_http_benchmark(deno_exe)["req_per_sec"]
    r["deno_core_single"] = deno_core_single(core_http_bench_exe)["req_per_sec"]
    r["deno_core_multi"] = deno_core_multi(core_http_bench_exe)["req_per_sec"]
    r["node"] = node_http_benchmark()["req_per_sec"]
    r["node_tcp"] = node_tcp_benchmark()["req_per_sec"]
    r["hyper"] = hyper_http_benchmark(hyper_hello_exe)["req_per_sec"]

    m["deno"] = deno_http_benchmark(deno_exe)["max_latency"]
    m["deno_net_http"] = deno_net_http_benchmark(deno_exe)["max_latency"]
    m["deno_core_single"] = deno_core_single(core_http_bench_exe)["max_latency"]
    m["deno_core_multi"] = deno_core_multi(core_http_bench_exe)["max_latency"]
    m["node"] = node_http_benchmark()["max_latency"]
    m["node_tcp"] = node_tcp_benchmark()["max_latency"]
    m["hyper"] = hyper_http_benchmark(hyper_hello_exe)["max_latency"]

    return { "req_per_sec": r, "max_latency": m }

Thanks @Kermit-Xuan! I'm just realizing now that I missed that. I'm not too familiar with Python - would that result in calling each benchmark function (e.g. deno_http_benchmark(deno_exe)) twice? Or would it use the same result?

bernard-lin

comment created time in a month

push eventbernard-lin/deno

Bernard Lin

commit sha bdcca21448edf63966f99647497f370a5d979313

update regex

view details

push time in a month

PR opened denoland/deno

WIP: Max latency

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

This is a PR for #1963. Is there any way to check if this works without building to master?

+33 -10

0 comment

6 changed files

pr created time in a month

create barnchbernard-lin/deno

branch : max_latency

created branch time in a month

issue commentdenoland/deno

Benchmark wanted: tail latency in http requests

I'll take a crack at this

ry

comment created time in a month

fork bernard-lin/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in a month

startednodeschool/nyc

started time in 2 months

issue commentnodeschool/nyc

Mentor Registration – March 16th, 2019

I'm registered 🙂

bnb

comment created time in 2 months

issue commentnodeschool/nyc

Mentor Registration – March 16th, 2019

Hi! I'd like to be a mentor, but this would be my first time

bnb

comment created time in 2 months

startedkentcdodds/react-testing-library

started time in 3 months

startedleandrowd/react-responsive-carousel

started time in 3 months

push eventbernard-lin/gatsby-starter-netlify-cms

bernardlin12

commit sha a4fcf750d32cef4af4a725bcd51f5ed8cf2ea697

Update Blog “2016-12-17-making-sense-of-the-scaas-new-flavor-wheel”

view details

push time in 3 months

startedgaearon/overreacted.io

started time in 3 months

more