profile
viewpoint

benjamingr/bluebird-api 36

Bluebird compatible API on top of native promises.

addaleax/node 4

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

benjamingr/Auto-Translate 4

Translating multiple languages in JS/HTML through JSON seamlessly

benjamingr/blaze-lib 1

Automatically exported from code.google.com/p/blaze-lib

benjamingr/act 0

A simple reactive front-end framework

benjamingr/analytics.js-integration-auryc 0

Segment Auryc Javascript Integration

benjamingr/angular.js 0

HTML enhanced for web apps

benjamingr/ApplicationInsights-node.js 0

Microsoft Application Insights SDK for node.js

benjamingr/Array.prototype.includes 0

Spec, tests, reference implementation, and docs for ESnext-track Array.prototype.includes

push eventbenjamingr/ConnecTech

Benjamin Gruenbaum

commit sha a10a02b9f53a07a2e9e59c9c0b550a31883bb442

Delete package-lock.json

view details

push time in 5 hours

fork benjamingr/ConnecTech

Web application that help students/some people that's want to improve their web development skills to connect with experienced Developers and lectures

fork in 5 hours

issue commenttestimio/root-cause

If Testim Editor extension is not installed - user gets prompted in Testim Cloud

@Bnaya was this fixed already by any chance?

benjamingr

comment created time in a day

pull request commentsinonjs/fake-timers

Removing the use of eval in Node.js

It also might make sense from a security PoV to remove peer5 (my old employer from when I started contributing which I believe was added) unless they've made commits since.

itayperry

comment created time in a day

pull request commentsinonjs/fake-timers

Removing the use of eval in Node.js

https://www.npmjs.com/~benjamin.gruenbaum @mroderick

itayperry

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

startedcodemix/ts-sql

started time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentnodejs/node

http: allow passing array of key/val into writeHead

I'm not sure what such a comment would say.

The array passed to .writeHead is in the same format .rawHeaders returns.

Or something similar?

ronag

comment created time in 6 days

push eventbenjamingr/mentor-student-project

Benjamin Gruenbaum

commit sha e41d2a37efca740964c113a749edea5eb8fe731a

add cors for development so that client can access server

view details

push time in 7 days

issue openedbenjamingr/mentor-student-project

Remove the database credentials from source control

  • Change the Mongo password
  • Read about environment variables
  • Put the new password in an environment variable

created time in 7 days

startedbenjamingr/mentor-student-project

started time in 7 days

MemberEvent
MemberEvent
MemberEvent

push eventbenjamingr/mentor-student-project

Benjamin Gruenbaum

commit sha 6ff2da015dab895e18ce14ba1382ce6735bfa202

changes

view details

push time in 7 days

create barnchbenjamingr/mentor-student-project

branch : master

created branch time in 7 days

created repositorybenjamingr/mentor-student-project

Coordination of the TechCareer mentor student project

created time in 7 days

pull request commentnodejs/node

http: allow passing array of key/val into writeHead

In the docs

ronag

comment created time in 7 days

startedbgauryy/webscanner

started time in 7 days

issue commenttestimio/root-cause

If Testim Editor extension is not installed - user gets prompted in Testim Cloud

This might be an old version issue - we need better errors in case the user is running an older version of root-cause

benjamingr

comment created time in 7 days

issue commenttestimio/root-cause

If Testim Editor extension is not installed - user gets prompted in Testim Cloud

It also appears that the link to a specific test from the "suite runs" suite broke.

benjamingr

comment created time in 7 days

issue openedtestimio/root-cause

If Testim Editor extension is not installed - user gets prompted in Testim Cloud

Need to not require extension installation for the root-cause viewer. This broke sometime in the last few weeks.

created time in 7 days

issue commenttestimio/root-cause

Ability to filter tests that didn't use puppeteer from root-cause ls

We can in some point ignore if there are 0 steps, But we need to think what do to on test failure

We should, and it also creates an issue in root-cause cloud

benjamingr

comment created time in 7 days

issue openedtestimio/root-cause

Ability to filter tests that didn't use puppeteer from root-cause ls

Currently even tests that had no actions are shown in root-cause ls

Reported by @talkl

created time in 7 days

PullRequestReviewEvent

pull request commenttestimio/root-cause

stacktrace iteration

What's this?

Bnaya

comment created time in 7 days

issue commentgoldbergyoni/nodebestpractices

Always prefer `return await` over `return` when returning a promise

This looks like a regression in chrome that happened sometime in the last few years I think. It doesn't actually require Promise.all or array.map to show:

{
(async function notAsyncSoDoesNotGetStitched() {
  // remove the await and notAsyncSoDoesNotGetStitched disappears
  return await failAsync();
})()
async function failAsync() {
  await Promise.resolve();
  throw Error();
}
}

So I am changing my mind and I agree until this is fixed it is better to recommend return await

Alexsey

comment created time in 7 days

pull request commentnodejs/node

process: Change default --unhandled-rejections=throw

And... 5 years later, I feel like my biggest regret regarding promises early on in Node was finally fixed 🎉 Chapeau!

If anyone is wondering there is still a ton of interesting work to do in this space and improvement ideas/suggestions.

dfabulich

comment created time in 8 days

PullRequestReviewEvent

Pull request review commenttestimio/root-cause

Contributors flow improvment

 import path from 'path'; import fs from 'fs-extra'; import cors from 'cors'; import debug from 'debug';+import childProcess from 'child_process'; import http, { ServerResponse, IncomingMessage } from 'http';  const loggerDebug = debug('root-cause:debug'); const loggerError = debug('root-cause:error'); +const DEV_STATIC_FILES_LOCATION = path.resolve(__dirname, '../../client/build');+const PROD_STATIC_FILES_LOCATION = path.resolve(__dirname, '../dist/client-static');+const STATIC_INDEX_FILE = 'index.html';+ let server: http.Server; +async function buildClientStatics() {+    await new Promise<void>((res, rej) => {+        childProcess.exec('yarn workspace @testim/root-cause-client-bundled build', {+            windowsHide: true,+        }, (error, sdtOut, stdErr) => {+            if (error) {+                rej(error);+            } else {+                res();+            }+        });+    });++    if (!await fs.pathExists(path.resolve(DEV_STATIC_FILES_LOCATION, STATIC_INDEX_FILE))) {+        throw new Error('Dev statics are missing after build, this is not expected.');+    }+}++function isDevMode() {+    return __filename.endsWith('.ts');+}  export async function openServer(port: number, testPath: string): Promise<string> {     const app = express();      loggerDebug('testPath', testPath); -    if (!await fs.pathExists(path.resolve(__dirname, '../client-static/index.html')) && !await fs.pathExists(path.resolve(__dirname, '../dist/client-static/index.html'))) {-        throw new Error('missing client static');+    if (isDevMode()) {+        console.log('--- Dev mode detected ---');+        console.log('For better client development experience, you may start the client dev server on a new terminal using:');+        console.log('yarn workspace @testim/root-cause-client-bundled start');+        console.log('but keep this server also running');++        if (!await fs.pathExists(path.resolve(DEV_STATIC_FILES_LOCATION, STATIC_INDEX_FILE))) {+            console.log('Client Static files not found, building client project...');+            await buildClientStatics();

Warning sounds fine

Bnaya

comment created time in 8 days

PullRequestReviewEvent

Pull request review commenttestimio/root-cause

Contributors flow improvment

-### Contributing Guide +# Contributing Guide   ## Signing the CLA  In order to contribute code you need to sign [the CLA](https://docs.google.com/document/d/1X-EoFIW1PMe8H-DJyZDScsTolPKm22-9P1JgSuiFNfE/edit?usp=sharing) which makes it possible for us to release this code as AGPL but consume it internally in a different license. -If you have any issues wit hthe CLA or signing it please contact us (benji@testim.io / bnaya@testim.io) directly.-+If you have any issues with the CLA or signing it please contact us (benji@testim.io / bnaya@testim.io) directly.   ## Technical Know-How -This monorepo is managed with yarn workspaces in order to build it:+This monorepo is managed with yarn workspaces.  +The codebase is written with typescript, and linted using eslint.  +It's recommended to have properer IDE integration with the tools in use (eslint, editorconfig) before modifying the code++### Prerequisite+- yarn [Installation instructions](https://classic.yarnpkg.com/en/docs/install/#mac-stable)+- node 12/14 [Installation instructions](https://nodejs.org/en/download/package-manager/) -```shell+## Dependencies install+The first step for local development would be to install the dependencies+```sh # install dependencies yarn-# run a package, for example the tester+```++## Running the tests+To run the whole test suite:+```sh+yarn test+```+On a clean clone, the test are expected to pass. if they don't, please let us know!
On a clean clone, the tests are supposed to pass. if they don't, please let us know!
Bnaya

comment created time in 8 days

PullRequestReviewEvent

Pull request review commenttestimio/root-cause

Contributors flow improvment

-### Contributing Guide +# Contributing Guide   ## Signing the CLA  In order to contribute code you need to sign [the CLA](https://docs.google.com/document/d/1X-EoFIW1PMe8H-DJyZDScsTolPKm22-9P1JgSuiFNfE/edit?usp=sharing) which makes it possible for us to release this code as AGPL but consume it internally in a different license. -If you have any issues wit hthe CLA or signing it please contact us (benji@testim.io / bnaya@testim.io) directly.-+If you have any issues with the CLA or signing it please contact us (benji@testim.io / bnaya@testim.io) directly.   ## Technical Know-How -This monorepo is managed with yarn workspaces in order to build it:+This monorepo is managed with yarn workspaces.  +The codebase is written with typescript, and linted using eslint.  +It's recommended to have properer IDE integration with the tools in use (eslint, editorconfig) before modifying the code++### Prerequisite+- yarn [Installation instructions](https://classic.yarnpkg.com/en/docs/install/#mac-stable)+- node 12/14 [Installation instructions](https://nodejs.org/en/download/package-manager/) -```shell+## Dependencies install+The first step for local development would be to install the dependencies
The first step for local development would be to install dependencies:
Bnaya

comment created time in 8 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commenttestimio/root-cause

Contributors flow improvment

-### Contributing Guide +# Contributing Guide   ## Signing the CLA  In order to contribute code you need to sign [the CLA](https://docs.google.com/document/d/1X-EoFIW1PMe8H-DJyZDScsTolPKm22-9P1JgSuiFNfE/edit?usp=sharing) which makes it possible for us to release this code as AGPL but consume it internally in a different license. -If you have any issues wit hthe CLA or signing it please contact us (benji@testim.io / bnaya@testim.io) directly.-+If you have any issues with the CLA or signing it please contact us (benji@testim.io / bnaya@testim.io) directly.   ## Technical Know-How -This monorepo is managed with yarn workspaces in order to build it:+This monorepo is managed with yarn workspaces.  +The codebase is written with typescript, and linted using eslint.  +It's recommended to have properer IDE integration with the tools in use (eslint, editorconfig) before modifying the code++### Prerequisite+- yarn [Installation instructions](https://classic.yarnpkg.com/en/docs/install/#mac-stable)+- node 12/14 [Installation instructions](https://nodejs.org/en/download/package-manager/) -```shell+## Dependencies install
## Installing Dependencies
Bnaya

comment created time in 8 days

PullRequestReviewEvent

Pull request review commenttestimio/root-cause

Contributors flow improvment

-### Contributing Guide +# Contributing Guide   ## Signing the CLA  In order to contribute code you need to sign [the CLA](https://docs.google.com/document/d/1X-EoFIW1PMe8H-DJyZDScsTolPKm22-9P1JgSuiFNfE/edit?usp=sharing) which makes it possible for us to release this code as AGPL but consume it internally in a different license. -If you have any issues wit hthe CLA or signing it please contact us (benji@testim.io / bnaya@testim.io) directly.-+If you have any issues with the CLA or signing it please contact us (benji@testim.io / bnaya@testim.io) directly.   ## Technical Know-How -This monorepo is managed with yarn workspaces in order to build it:+This monorepo is managed with yarn workspaces.  +The codebase is written with typescript, and linted using eslint.  +It's recommended to have properer IDE integration with the tools in use (eslint, editorconfig) before modifying the code
It's recommended to have proper IDE integration with the tools in use (eslint, editorconfig) before modifying the code
Bnaya

comment created time in 8 days

Pull request review commenttestimio/root-cause

Contributors flow improvment

-### Contributing Guide +# Contributing Guide   ## Signing the CLA  In order to contribute code you need to sign [the CLA](https://docs.google.com/document/d/1X-EoFIW1PMe8H-DJyZDScsTolPKm22-9P1JgSuiFNfE/edit?usp=sharing) which makes it possible for us to release this code as AGPL but consume it internally in a different license. -If you have any issues wit hthe CLA or signing it please contact us (benji@testim.io / bnaya@testim.io) directly.-+If you have any issues with the CLA or signing it please contact us (benji@testim.io / bnaya@testim.io) directly.   ## Technical Know-How -This monorepo is managed with yarn workspaces in order to build it:+This monorepo is managed with yarn workspaces.  +The codebase is written with typescript, and linted using eslint.  
The codebase is written with TypeScript, and linted using ESLint.  

?

Bnaya

comment created time in 8 days

PullRequestReviewEvent

pull request commentnodejs/node

http: allow passing array of key/val into writeHead

Sure... But since we already do arrays I don't see any advantage. I guess one does not exclude the other.

I'm confused by this. This is an intermediary format that only one library uses. Passing a string of headers (concatenated) is something I've seen in many servers/languages.

Would the optimisation be impossible without going through the third (array) format?

ronag

comment created time in 8 days

pull request commentnodejs/node

http: allow passing array of key/val into writeHead

I still don't understand this feature request/PR. Is this is a specific format that afaik only unidici uses?

Wouldn't it make more sense to support raw headers as a string?

ronag

comment created time in 8 days

pull request commenttestimio/root-cause

Add conventional commits

Hey, the CLA is live.

Shai can you please sign it? (saying "I agree to the CLA" in a GitHub comment is sufficient for now) - It transfers <s>your kidneys</s> ownership of committed code to us after you commit so we can consume the code with a different license internally.

shairez

comment created time in 8 days

push eventtestimio/root-cause

Benjamin Gruenbaum

commit sha fb06774577f80a12730f1d167af625791b6abf8b

Update CONTRIBUTING.md

view details

push time in 8 days

PullRequestReviewEvent

issue commentgoldbergyoni/nodebestpractices

Always prefer `return await` over `return` when returning a promise

In case if getUser would throw the map would not be in a stacktrace.

Are you sure about that?

Uploading Screen Shot 2020-09-21 at 20.08.52.png…

Alexsey

comment created time in 9 days

PullRequestReviewEvent

pull request commentnodejs/node

http: allow passing array of key/val into writeHead

Enables an optimization when the user already has the headers in an array form, e.g. when proxying.

Why would proxying imply the user gets the headers in array form?

ronag

comment created time in 9 days

PullRequestReviewEvent

issue commenttestimio/root-cause

Using root-cause jest integration with typescript (ts-jest)

We use TypeScript throughout this project - you can see integration examples in https://github.com/testimio/root-cause/tree/main/integration-examples - I'll hit you up (on FB)

talkl

comment created time in 9 days

Pull request review commentnodejs/node

process: Change default --unhandled-rejections=throw

 if (process.argv[2] === 'child') {   const options = { encoding: 'utf8' };   const proc = spawnSync(     process.execPath, ['--expose-internals', __filename, 'child'], options);-  strictEqual(proc.status, 0);+  strictEqual(proc.status, 1);

This code spawns itself and then lets itself die (with throw new Error(eyecatcher)), it used to emit a warning (on unhandled rejection) and then terminate (with status 0, since Node didn't crash on unhandled rejections).

Now it emits the error and then dies - so it terminates with status 1.

I am not sure why the original code suppressed unhandled rejections though since that would still test that no process segfault occurs. Looking at the blame this looks mostly for historical reasons since tests didn't use to crash on unhandled rejections by default.

dfabulich

comment created time in 9 days

PullRequestReviewEvent

issue commenttestimio/root-cause

Root Cause Jest integration - blank npx root-cause show <result-id> page

@Bnaya any chance we can add a (small) example of puppeteer-cluster to our examples?

talkl

comment created time in 9 days

issue commenttestimio/root-cause

Root Cause Jest integration - blank npx root-cause show <result-id> page

Hey, interesting.

Any chance you can make a repro repository?

So when i open npx root-cause show i see nothing.

When you say nothing, do you mean "no runs found" or "a run with no screenshots"?

it couldn't understand where page variable is defined (I'm using typescript).

Root cause (automatic integration) expects a page global variable (globalThis.page) like jest-puppeteer defines. You can use root-cause without jest-puppeteer or defining a global using the lower-level .attach API.

I suspect that https://github.com/thomasdondorf/puppeteer-cluster would require you to (instead of using the setupFilesAfterEnv jest hook) use rootCause.attach directly on the pages inside cluster.task

talkl

comment created time in 9 days

issue commentmicrosoft/playwright

[BUG] Playwright doesn't work with GitHub codespaces out of the box

Strange indeed, I will check later - the project indeed uses yarn workspaces (lerna wasn't used in the demo it's only used for publishing)

benjamingr

comment created time in 9 days

issue commentmicrosoft/playwright

[BUG] Playwright doesn't work with GitHub codespaces out of the box

Hey, literally any repository without setting the devcontainer.json would work, I used this code and this repo: https://github.com/testimio/root-cause/tree/main/integration-examples/launch-api

benjamingr

comment created time in 10 days

issue commentmicrosoft/playwright

[BUG] Playwright doesn't work with GitHub codespaces out of the box

Are you using some GitHub Codespace configuration?

I am using the default configuration (Ubuntu pre-loaded with a bunch of stuff I think?), which puppeteer seems to work with and installation seems to work with both puppeteer and playwright.

The failure in particular is in the difference between where playwright downloads chrome to (in the default codespace image) and where playwright expects to find it when .launch is called.

benjamingr

comment created time in 12 days

issue openedmicrosoft/playwright

[BUG] Playwright doesn't work with GitHub codespaces out of the box

Context:

  • Playwright Version: [what Playwright version do you use?] latest
  • Operating System: [e.g. Windows, Linux or Mac] Linux (GitHub codespaces)
  • Node.js version: [e.g. 10.12, 10.14] v12.16.3
  • Browser: [e.g. All, Chromium, Firefox, WebKit] Chromium
  • Extra: [any specific details about your environment] This bug is when trying to use Playwright in GitHub codespaces

Code Snippet

Help us help you! Put down a short code snippet that illustrates your bug and that we can run and debug locally.

I tried running the most basic root cause example that doesn't use any test runner.

Launching playwright fails, launching puppeteer works:

codespace:~/workspace/root-cause/integration-examples/launch-api$ yarn example-playwright
Debugger listening on ws://127.0.0.1:32991/6b2e0f01-e5dd-4162-bc7f-7796a9800f68
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
yarn run v1.22.4
$ ts-node playwright-example-ts.ts
(node:4934) UnhandledPromiseRejectionWarning: browserType.launch: Failed to launch chromium because executable doesn't exist at /home/codespace/.cache/ms-playwright/chromium-799411/chrome-linux/chrome
Try re-installing playwright with "npm install playwright"
Note: use DEBUG=pw:api environment variable and rerun to capture Playwright logs.: 
    at BrowserType._wrapApiCall (/home/codespace/workspace/root-cause/integration-examples/launch-api/node_modules/playwright/lib/client/channelOwner.js:76:15)
    at BrowserType.launch (/home/codespace/workspace/root-cause/integration-examples/launch-api/node_modules/playwright/lib/client/browserType.js:48:21)
    at launchPlaywrightByOptions (/home/codespace/workspace/root-cause/integration-examples/launch-api/node_modules/@testim/root-cause-core/lib/launch.js:102:31)
    at launchImpl (/home/codespace/workspace/root-cause/integration-examples/launch-api/node_modules/@testim/root-cause-core/lib/launch.js:30:25)
(node:4934) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:4934) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Done in 5.84s.
Waiting for the debugger to disconnect...

# puppeteer (works)
codespace:~/workspace/root-cause/integration-examples/launch-api$ yarn example-puppeteer
Debugger listening on ws://127.0.0.1:35661/34eade25-1f25-4f47-97fd-2fde3b0502f6
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
yarn run v1.22.4
$ node puppeteer-example.js
Debugger listening on ws://127.0.0.1:37475/125e24ed-d575-4c82-a208-2a0f22ff896e
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
Root Cause viewer: http://localhost:9876
Press any key to exit

created time in 12 days

PullRequestReviewEvent

pull request commentnodejs/node

process: introduce codeGenerationFromString event

I don't understand the use case for this - why would I use this?

vdeturckheim

comment created time in 14 days

pull request commentsinonjs/fake-timers

Removing the use of eval in Node.js

@fatso83 I didn't know when a release would happen and didn't want to release a major without talking to anyone mostly

itayperry

comment created time in 15 days

PR opened sinonjs/fake-timers

Reviewers
Revert "Add stack trace to code recursively scheduling timers"

Reverts sinonjs/fake-timers#325

https://github.com/sinonjs/fake-timers/issues/337

cc @alistairjcbrown

+18 -432

0 comment

2 changed files

pr created time in 15 days

pull request commentnodejs/node

process: Change default --unhandled-rejections=throw

Super excited this is making progress 🎉

dfabulich

comment created time in 15 days

issue commentnodejs/TSC

Voting on the default behavior for Promise unhandled rejections

Also worth mentioning that it's important we move swiftly on this and change the default.

We can (and should) explore "throw on GC" semantics in the future but I feel there needs to be a considerable amount of work before it gets presented to the TSC and I feel that the people who feel strongly about exploring it should likely do the (specification and research) work.

mmarchini

comment created time in 15 days

issue commentnodejs/TSC

Voting on the default behavior for Promise unhandled rejections

Hey, just wanted to thank everyone involved and especially Mary for persevering and moving things forward when it was the difficult thing to do and required a lot of work.

So thanks Mary and to other people involved - looking forward to this finally being fixed.

mmarchini

comment created time in 15 days

push eventpetkaantonov/bluebird

Benjamin Gruenbaum

commit sha 6c8c069c34829557abfaca66d7f22383b389a4b5

Fix toFastProperties (#1636) * Fix toFastProperties * es5 * I forgot bluebird has a lint that enforces spaces over tabs * Update util.js * lint

view details

push time in 18 days

delete branch petkaantonov/bluebird

delete branch : benjamingr-patch-5

delete time in 18 days

pull request commentnodejs/node

doc: add PoojaDurgad as a triager

huh, good to know.

PoojaDurgad

comment created time in 18 days

delete branch testimio/mhtml-parser

delete branch : dependabot/npm_and_yarn/yargs-parser-13.1.2

delete time in 19 days

push eventtestimio/mhtml-parser

dependabot[bot]

commit sha d3ea725cb9a4040f00879b6d427fe13007cf7b7e

Bump yargs-parser from 13.1.1 to 13.1.2 Bumps [yargs-parser](https://github.com/yargs/yargs-parser) from 13.1.1 to 13.1.2. - [Release notes](https://github.com/yargs/yargs-parser/releases) - [Changelog](https://github.com/yargs/yargs-parser/blob/master/docs/CHANGELOG-full.md) - [Commits](https://github.com/yargs/yargs-parser/commits) Signed-off-by: dependabot[bot] <support@github.com>

view details

Benjamin Gruenbaum

commit sha 775c7419273d5f9db48b2411545f445e9d6d3f67

Merge pull request #15 from testimio/dependabot/npm_and_yarn/yargs-parser-13.1.2 Bump yargs-parser from 13.1.1 to 13.1.2

view details

push time in 19 days

PR merged testimio/mhtml-parser

Bump yargs-parser from 13.1.1 to 13.1.2 dependencies

Bumps yargs-parser from 13.1.1 to 13.1.2. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/yargs/yargs-parser/blob/master/docs/CHANGELOG-full.md">yargs-parser's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/yargs/yargs-parser/compare/v14.0.0...v15.0.0">15.0.0</a> (2019-10-07)</h2> <h3>Features</h3> <ul> <li>rework <code>collect-unknown-options</code> into <code>unknown-options-as-args</code>, providing more comprehensive functionality (<a href="https://github.com/yargs/yargs-parser/commit/ef771ca">ef771ca</a>)</li> </ul> <h3>BREAKING CHANGES</h3> <ul> <li>rework <code>collect-unknown-options</code> into <code>unknown-options-as-args</code>, providing more comprehensive functionality</li> </ul> <h2><a href="https://github.com/yargs/yargs-parser/compare/v13.1.1...v14.0.0">14.0.0</a> (2019-09-06)</h2> <h3>Bug Fixes</h3> <ul> <li>boolean arrays with default values (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/185">#185</a>) (<a href="https://github.com/yargs/yargs-parser/commit/7d42572">7d42572</a>)</li> <li>boolean now behaves the same as other array types (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/184">#184</a>) (<a href="https://github.com/yargs/yargs-parser/commit/17ca3bd">17ca3bd</a>)</li> <li>eatNargs() for 'opt.narg === 0' and boolean typed options (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/188">#188</a>) (<a href="https://github.com/yargs/yargs-parser/commit/c5a1db0">c5a1db0</a>)</li> <li>maybeCoerceNumber now takes precedence over coerce return value (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/182">#182</a>) (<a href="https://github.com/yargs/yargs-parser/commit/2f26436">2f26436</a>)</li> <li>take into account aliases when appending arrays from config object (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/199">#199</a>) (<a href="https://github.com/yargs/yargs-parser/commit/f8a2d3f">f8a2d3f</a>)</li> </ul> <h3>Features</h3> <ul> <li>add configuration option to "collect-unknown-options" (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/181">#181</a>) (<a href="https://github.com/yargs/yargs-parser/commit/7909cc4">7909cc4</a>)</li> <li>maybeCoerceNumber() now takes into account arrays (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/187">#187</a>) (<a href="https://github.com/yargs/yargs-parser/commit/31c204b">31c204b</a>)</li> </ul> <h3>BREAKING CHANGES</h3> <ul> <li>unless "parse-numbers" is set to "false", arrays of numeric strings are now parsed as numbers, rather than strings.</li> <li>we have dropped the broken "defaulted" functionality; we would like to revisit adding this in the future.</li> <li>maybeCoerceNumber now takes precedence over coerce return value (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/182">#182</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/yargs/yargs-parser/commits">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~oss-bot">oss-bot</a>, a new releaser for yargs-parser since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+4 -4

0 comment

1 changed file

dependabot[bot]

pr closed time in 19 days

pull request commentnodejs/node

doc: add PoojaDurgad as a triager

Hey welcome 👋

This isn't actually our process and there is no official "triager" role.

Thanks a ton for wanting to help with this! It's appreciated.

I think a good step to help triage would be to go to the issues and try to confirm bug reports people have opened, help isolate issues and then (if you're up for it) building Node.js from source and stepping through the debugger while reproducing these issues.

There are many other ways to help with triage, everyone is allowed to do this.

If you are stuck or unsure what to do - feel free to reach out to me (my email is in the README) or other people from the project.

PoojaDurgad

comment created time in 19 days

pull request commentnodejs/node

fs: loosen validation to allow objects with an own toString function

https://github.com/nodejs/node/pull/34993#issuecomment-689788313 @nodejs/documentation can someone please comment on this 🙏 :) ?

ljharb

comment created time in 19 days

issue commentsinonjs/fake-timers

Need new release

@fatso83 - can you make a release? Otherwise I can try doing one but I never did one before for fake-timers.

We can also set up releases to happen from the CI so they are more frequent

fristedt

comment created time in 19 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

startedtestimio/root-cause-interactive-demo

started time in 20 days

issue commentnodejs/TSC

Voting on the default behavior for Promise unhandled rejections

that's not a promise though

thenable then? 😅

(sorry couldn't resist)

mmarchini

comment created time in 21 days

issue commentsinonjs/fake-timers

Support `temporal` TC39 proposal

Cc @littledan I remember you asking for feedback on Temporal.

Is there anything other than .now that sinon would need to fake?

SimenB

comment created time in 23 days

PullRequestReviewEvent

issue commenttc39/proposal-cancellation

Automatic cancellation support for Promises

I can ask Node to run a survey though we just ran one for unhandledRejection.

Anyway I didn't realize abort semantics were even on the table. I thought that disinterest semantics were consensus as abort semantics are dangerous.

That's why bluebird switched to disinterest like 5 years ago.

martinheidegger

comment created time in 25 days

Pull request review commenttestimio/root-cause

use npx for schema generate and downlevel dts

 set -ex tsc mkdir -p ./dist/client-static cp -R ../client/build/* ./dist/client-static-downlevel-dts ./dist ./dist/ts3.4+npx downlevel-dts ./dist ./dist/ts3.4

Isn't it better to lock a version here or is it fine to install this "lazily"?

Bnaya

comment created time in 25 days

PullRequestReviewEvent

Pull request review commenttestimio/root-cause

Welcome prettier

 import { launch } from '@testim/root-cause';  launch(-    {-        testName: __filename,-        noServer: false,-        automationLibrary: 'puppeteer',-        browserOptions: { headless: false },-    },-    async (page) => {-        await page.goto('http://jsbin.testim.io/ces');-        await page.click('[data-job=GET_OK]', { delay: 800 });-        await page.click('[data-job=GET_404]', { delay: 800 });-        await page.click('[data-job=POST_OK]', { delay: 800 });-        await page.click('[data-job=POST_404]', { delay: 800 });+  {+    testName: __filename,+    noServer: false,+    automationLibrary: 'puppeteer',+    browserOptions: { headless: false },+  },+  async (page) => {+    await page.goto('http://jsbin.testim.io/ces');+    await page.click('[data-job=GET_OK]', { delay: 800 });+    await page.click('[data-job=GET_404]', { delay: 800 });+    await page.click('[data-job=POST_OK]', { delay: 800 });+    await page.click('[data-job=POST_404]', { delay: 800 }); -        await page.evaluate(async () => {-            await new Promise((res) => {-                setTimeout(res, 300);-            });+    await page.evaluate(async () => {+      await new Promise((res) => {+        setTimeout(res, 300);+      }); -            for (const el of document.querySelectorAll('[data-job]' as 'button')) {-                const mousedown = new MouseEvent('mousedown');-                el.dispatchEvent(mousedown);+      for (const el of document.querySelectorAll('[data-job]' as 'button')) {+        const mousedown = new MouseEvent('mousedown');+        el.dispatchEvent(mousedown); -                // eslint-disable-next-line no-await-in-loop-                await new Promise((res) => {-                    setTimeout(res, 100);-                });-            }--            await new Promise((res) => {-                setTimeout(res, 5000);-            });+        // eslint-disable-next-line no-await-in-loop

Can we drop this eslint-rule while we are at it we know promises and the implications

Bnaya

comment created time in 25 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

issue commenttestimio/root-cause

README: Link GIF screencast to a full video screencast

Would it help if there was a full-length video showing integration + a demo or do you mean just the gif in mp4 format?

nonZero

comment created time in a month

issue openedtestimio/root-cause

Visual Studio Code Plugin

Hey,

On a call with @auchenberg (thanks again by the way!) he mentioned that when he was working on vscode a lot of times a goal was getting feedback closest to the code.

We should consider developing a VSCode plugin that adds the screenshots (and direct links) inside the test in VSCode, dumps the console in vscode's console and adds a link to cloud runs if the user has cloud runs active.

created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

issue commentnodejs/TSC

Voting on the default behavior for Promise unhandled rejections

Just a comment on the name of the voting system - so I'm hiding it to keep discussion on the topic Mary requested.

I actually did several courses on voting systems (fun fact).

Some common rules are:

  • Copeland (You choose the candidate who wins the most other characters in pairwise elections)
  • Borda count (Each voter submits preferences over the alternatives, points are then given (from 0 to n-1 for each voter). Highest total wins. (Violates Condorcet winner))
  • Single Transferable Vote (Candidate with the least points is eliminated at each round)
  • Anti Plurality (Choose the least unliked candidate (the one the least agents placed last)).
  • Sequential pairwise voting (Each time two candidates are placed against one another).

There are many others - the method you are describing is simply called Two-round or "runoff voting". It's fine for us.

mmarchini

comment created time in a month

issue commentdenoland/deno

discussion: Run web platform tests

For what it's worth when I worked on EventTarget fixes in Node I ran into several issues that Deno didn't deal with.

I am starting to be convinced the solution for things like EventTarget is to have a third party implementation that's pure JS to run all the tests against and to have both Node and Deno consume it

lucacasonato

comment created time in a month

more