Context

Trello card 1634 - We've had a lot of duplicate requests in the system, due at least in part to a bug fixed in #1478. I've removed most of the duplicate requests where it was clear which ones should be kept and which deleted, but there will still be some (around a couple of hundred) where it was not clear.

MNOs have been using various statuses for the duplicates - some problem_no_match_for_number, some problem_ineligible, some problem_other, etc - but it would be much clearer for everyone involved if they had an explicit duplicate status to use for them.

Changes proposed in this pull request

Add problem_duplicate status to ExtraMobileDataRequests

Guidance to review

Needs content review from @Lloyd-K or @emmajhf

Screenshots:

Updates the requirements on view_component to permit the latest version. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/view_component/releases">view_component's releases</a>.</em></p> <blockquote> <h2>v2.26.1</h2> <ul> <li> <p>Fix bug that raises when trying to use a collection before the component has been compiled.</p> <p><em>Blake Williams</em></p> </li> </ul> <h2>v2.26.0</h2> <ul> <li> <p>Lazily evaluate component <code>content</code> in <code>render?</code>, preventing the <code>content</code> block from being evaluated when <code>render?</code> returns false.</p> <p><em>Blake Williams</em></p> </li> <li> <p>Do not generate template when using <code>--inline</code> flag.</p> <p><em>Hans Lemuet</em></p> </li> <li> <p>Add <code>--inline</code> option to the Haml and Slim generators</p> <p><em>Hans Lemuet</em></p> </li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/github/view_component/blob/main/CHANGELOG.md">view_component's changelog</a>.</em></p> <blockquote> <h2>2.26.1</h2> <ul> <li> <p>Fix bug that raises when trying to use a collection before the component has been compiled.</p> <p><em>Blake Williams</em></p> </li> </ul> <h2>2.26.0</h2> <ul> <li> <p>Lazily evaluate component <code>content</code> in <code>render?</code>, preventing the <code>content</code> block from being evaluated when <code>render?</code> returns false.</p> <p><em>Blake Williams</em></p> </li> <li> <p>Do not generate template when using <code>--inline</code> flag.</p> <p><em>Hans Lemuet</em></p> </li> <li> <p>Add <code>--inline</code> option to the Haml and Slim generators</p> <p><em>Hans Lemuet</em></p> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/github/view_component/commit/ef5a5f0132479fd71044cda9cfd39fa01e71af25"><code>ef5a5f0</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/github/view_component/issues/645">#645</a> from github/release-v2.26.1</li> <li><a href="https://github.com/github/view_component/commit/fb0f71daac0c165e18df602a035dad2c36aa658e"><code>fb0f71d</code></a> release v2.26.1</li> <li><a href="https://github.com/github/view_component/commit/024d12c1e1459e8e30359fd82bd382e5e9176279"><code>024d12c</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/github/view_component/issues/644">#644</a> from github/bmw/param-fix</li> <li><a href="https://github.com/github/view_component/commit/d96d6dbff5667b9afaf24b7fd31875fa117895c2"><code>d96d6db</code></a> Merge branch 'main' into bmw/param-fix</li> <li><a href="https://github.com/github/view_component/commit/1242066fdac16a31ef805c989de7e6f63994da48"><code>1242066</code></a> Add changelog entry</li> <li><a href="https://github.com/github/view_component/commit/53992be98461a7d405ceb1d2fa5db07b28802d42"><code>53992be</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/github/view_component/issues/643">#643</a> from github/slot-without-content-block</li> <li><a href="https://github.com/github/view_component/commit/0a989ad8a8d0191f073cfb5658584e234319f113"><code>0a989ad</code></a> Decouple collection parameters from compilation</li> <li><a href="https://github.com/github/view_component/commit/1a9717d8d13c2dc5b66f91ceb006969e0e2e66c2"><code>1a9717d</code></a> remove warning when slot does not receive a content block</li> <li><a href="https://github.com/github/view_component/commit/a855b96cccff379ac6d6a8af4267161f48cdff1a"><code>a855b96</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/github/view_component/issues/641">#641</a> from github/release-v2.26.0</li> <li><a href="https://github.com/github/view_component/commit/5f3b36ead8c7a35e84d5f0ee923c187f9801bbac"><code>5f3b36e</code></a> release v2.26.0</li> <li>Additional commits viewable in <a href="https://github.com/github/view_component/compare/v2.25.1...v2.26.1">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

• Update frequency (including time of day and day of week)
• Pull request limits (per update run and/or open at any time)
• Automerge options (never/patch/minor, and dev/runtime dependencies)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)

</details>

ditto

Agree with @tonyheadford here - Relations sounds too much like a generic ActiveRecord thing. I'd favour SchoolLink, but any of the options Tony suggests would be fine

Bumps config from 2.2.3 to 3.0.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rubyconfig/config/blob/master/CHANGELOG.md">config's changelog</a>.</em></p> <blockquote> <h2>3.0.0</h2> <h3>BREAKING CHANGES</h3> <ul> <li>After upgrade behaviour of <code>to_h</code> would change and match behaviour of <code>to_hash</code>. Check <a href="https://github-redirect.dependabot.com/rubyconfig/config/issues/217#issuecomment-741953382">#217</a> for more details.</li> <li><code>Config::Options#load_env!</code> and <code>Config::Options#reload_env!</code> have been removed. If you need to reload settings after modifying the <code>ENV</code> hash, use <code>Config.reload!</code> or <code>Config::Options#reload!</code> instead.</li> </ul> <h3>Bug fixes</h3> <ul> <li>Added alias <code>to_h</code> for <code>to_hash</code> (<a href="https://github-redirect.dependabot.com/railsconfig/config/issues/277">#277</a>)</li> </ul> <h3>Changes</h3> <ul> <li>Add <code>Config::Sources::EnvSource</code> for loading settings from flat <code>Hash</code>es with <code>String</code> keys and <code>String</code> values, such as from AWS SecretsManager (<a href="https://github-redirect.dependabot.com/railsconfig/config/pull/299">#299</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rubyconfig/config/commit/a0339bb2af0838afca908a9d724ffb70994cf27c"><code>a0339bb</code></a> Bump to version 3.0.0</li> <li><a href="https://github.com/rubyconfig/config/commit/351c819f75d53aa5621a226b5957c79ac82ded11"><code>351c819</code></a> Refactor environment variable handling into new Sources::EnvSource (<a href="https://github-redirect.dependabot.com/rubyconfig/config/issues/299">#299</a>)</li> <li><a href="https://github.com/rubyconfig/config/commit/2748274b187aa86e71d8b88951a9ab57d7f988d0"><code>2748274</code></a> Update README badges</li> <li><a href="https://github.com/rubyconfig/config/commit/c53194dff361859cedfd22092c58679a203c374e"><code>c53194d</code></a> Run tests in random order (<a href="https://github-redirect.dependabot.com/rubyconfig/config/issues/298">#298</a>)</li> <li><a href="https://github.com/rubyconfig/config/commit/c59d105a870032c8ed1796d6c3f5d8e153ef991c"><code>c59d105</code></a> Additional tests for parsing values (<a href="https://github-redirect.dependabot.com/rubyconfig/config/issues/296">#296</a>)</li> <li><a href="https://github.com/rubyconfig/config/commit/d2c53565f84195e78e87d22f902ff1325ff5b692"><code>d2c5356</code></a> Added alias <code>to_h</code> for <code>to_hash</code> (<a href="https://github-redirect.dependabot.com/rubyconfig/config/issues/297">#297</a>)</li> <li>See full diff in <a href="https://github.com/rubyconfig/config/compare/2.2.3...3.0.0">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

• Update frequency (including time of day and day of week)
• Pull request limits (per update run and/or open at any time)
• Automerge options (never/patch/minor, and dev/runtime dependencies)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)

</details>

This was caused by a change to the underlying component to always insert a top border. There was then a fix applied in https://github.com/alphagov/govuk_publishing_components/pull/1907 which needs to be manually applied.

Before:

After:

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

This was caused by a change to the underlying component to always insert a top border. There was then a fix applied in https://github.com/alphagov/govuk_publishing_components/pull/1907 which needs to be manually applied.

Before:

After:

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Trello: https://trello.com/c/cwsh79vA/200-rollout-of-continuous-deployment

This adds a script to wrap around the calls made to "initctl start $app", "initctl restart $app" and "initctl reload $app" as part of an application deployment. This script adds the ability to monitor that these calls result in a new process that is actually running and the old process ending.

The motivation to add this is to support continuous deployment on GOV.UK. In particular the need to know that a service is successfully running after a restart 1. I felt the most consistent way this could be solved was by applying a wrapper command rather than modifying the deployment scripts for services specifically. This wrapper is also helpful for the other major GOV.UK app services as it will fail a deployment if these fail to start which will mean we know of a problem sooner.

I expect this to be applied by changing 2 from:

if fetch(:perform_hard_restart, false)
  run "sudo initctl start #{application} 2>/dev/null || sudo initctl restart #{application}"
else
  run "sudo initctl start #{application} 2>/dev/null || sudo govuk_unicorn_reload #{application}"
end

to:

if fetch(:perform_hard_restart, false)
  run "sudo govuk_supervised_initctl start #{application} || sudo govuk_supervised_initctl restart #{application}"
else
  run "sudo govuk_supervised_initctl start #{application} || sudo govuk_supervised_initctl reload #{application}"
end

I'm pretty convinced that this wrapper script is rather a nasty way to solve these problems and I expect that it's probably resolved with better/newer tools. It seems strange that upstart doesn't realise it started something that failed instantly - maybe systemd knows how to deal with that? I hope and expect this script to only live as long as we continue using Trusty.

Note this script supersedes govuk_unicorn_reload and once things are migrated to this I will remove that.