profile
viewpoint
Ben Gourley bengourley @bugsnag Bath http://bengourley.co.uk ¯\_(ツ)_/¯

bengourley/basic-express-site-2016 72

Simple example Node website using Express (2016 edition)

bengourley/anytime 20

A date/time picker

bengourley/break 18

Know when breakpoints are entered/exited in your JavaScript

bengourley/choo-resume 15

choo-resume + hot-rld = hot app reload in choo

bengourley/browjadify 7

Browserify transform. Injects compiled jade templates in place of compileJade() function calls.

bengourley/Cap 2

A compile-to-JavaScript language.

bengourley/browser-fingerprint 1

Generate a fingerprint for a browser

bengourley/cf-base-view 1

A base for frontend cf views to extend

bengourley/compact 1

A simple JavaScript and CSS compacting middleware for express

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha fc53d428404e51431c5d9265c112281baac2ab1a

test(react-native): @skip annotation doesn't work

view details

push time in 2 minutes

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha e2ceeecc3463e2f204f55ec9c08090bb8c939518

wip

view details

push time in 13 minutes

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha cae5bdfdd61fe5771a2d9c669a8b704035bd9b41

wip

view details

push time in 11 hours

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha cbe5790d51584201b810e00e1b50e8ee40ae79ed

wip

view details

push time in 16 hours

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha 170100484b659362f2aa0d2a4f02ca4f6fb94f28

wip

view details

push time in 17 hours

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha 74722a459ed8d76e8a23d54681e30010c8ec4eb7

wip

view details

push time in 17 hours

create barnchbugsnag/bugsnag-js

branch : tests/rn-navigation-tests-bg

created branch time in 17 hours

Pull request review commentbugsnag/bugsnag-js

[PLAT-5050] Add anonymous device ID

     And the payload has a valid sessions array   } end++Then("the event device ID is valid") do+  if has_local_storage+    step('the event "device.id" matches "^c[a-z0-9]{20,32}$"')+  elsif can_run_javascript+    $logger.info('Local storage is not supported in this browser, assuming device ID is null')+    step('the event "device.id" is null')+  else+    # if there's no local storage and we can't run javascript from Selenium, we+    # don't know if the device ID is null or not, so we can't assert against it+    $logger.warn('Selenium cannot run JavaScript in this browser. Device ID will not be checked!')+  end+end++Then("the event device ID is {string}") do |expected_id|+  if has_local_storage+    step("the event \"device.id\" equals \"#{expected_id}\"")+  elsif can_run_javascript+    $logger.info('Local storage is not supported in this browser, assuming device ID is null')+    step('the event "device.id" is null')+  else+    # if there's no local storage and we can't run javascript from Selenium, we+    # don't know if the device ID is null or not, so we can't assert against it+    $logger.warn('Selenium cannot run JavaScript in this browser. Device ID will not be checked!')+  end+end++When("I save {string} in local storage as {string}") do |key, value|

it does, but as established, this check failing doesn't mean local storage is not available, on mobile devices it just means you can execture arbitrary JS over the selenium interface

imjoehaines

comment created time in a day

PullRequestReviewEvent

Pull request review commentbugsnag/bugsnag-js

[PLAT-5050] Add anonymous device ID

     And the payload has a valid sessions array   } end++Then("the event device ID is valid") do

I think we ought to assume that it can run. At the moment this gives us "false" positives for this feature on mobile browsers without actually testing it.

imjoehaines

comment created time in a day

PullRequestReviewEvent

Pull request review commentbugsnag/bugsnag-js

[PLAT-5050] Add anonymous device ID

 module.exports = (nav = navigator, screen = window.screen) => ({           : 'portrait'     } +    if (client._config.generateAnonymousId) {+      const id = getDeviceId()++      // If there's no ID, it's likely because localStorage is disabled+      if (id) {+        device.id = id

as long as getDeviceId() returns an id or undefined, I think it's safe enough and terser to do:

device.id = getDeviceId()

imjoehaines

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha 1ccead26882bb2d5baffea7ae06ac5def4011f6c

test(delivery-react-native): Skip tests for commented out feature

view details

push time in a day

push eventbugsnag/bugsnag-js

Joe Haines

commit sha e07b030fcd3225d0aed92ec55650f4ef186ee88e

feat(expo): bump netinfo version to match Expo 39

view details

Joe Haines

commit sha 841305c773b6b850a124f33ce184aa5761d787e0

feat(expo-cli): Pick Expo <39 compatible version

view details

Dan Skinner

commit sha 6cb59fcbab119ae315efa8daf4af902bc4752df6

test(plugin-network-breadcrumbs): convert tests

view details

Dan Skinner

commit sha ebf9d8353d9fed0523f99c188fedade699145622

test(plugin-navigation-breadcrumbs): convert tests

view details

Dan Skinner

commit sha f9e59f4ddc95202cf215fa8d3ba4a1015129b1f6

test(plugin-react-native-global-error-handler): convert tests

view details

Dan Skinner

commit sha 83c0735a327b82186c22897c2c5610fda3a873c7

test(plugin-react-native-session): convert tests

view details

Ben Gourley

commit sha 1b470e55653527bd3291a8f1c74d67d44b5e87b4

Merge pull request #1057 from bugsnag/convert-tests-to-jest test(plugin-network-breadcrumbs): convert tests

view details

Ben Gourley

commit sha d76429d3076cf5a2bdba9efc71198070c2a07ffc

refactor(examples): Handle native promise rejection so that it works in dev mode

view details

djskinner

commit sha ac11be7a27d6353fa6d78ce88515d771dcf6c32e

Merge pull request #1058 from bugsnag/convert-tests-to-jest-2 test(plugin-navigation-breadcrumbs): convert tests

view details

djskinner

commit sha 07ed735156523dfefc7ac48306f39689baa040e9

Merge pull request #1059 from bugsnag/convert-tests-to-jest-3 test(plugin-react-native-global-error-handler, plugin-react-native-session): convert tests

view details

Joe Haines

commit sha 05aaaabafc9ca078f9dc9bfaec6670b39598563e

chore: update changelog

view details

Joe Haines

commit sha 6ee7b2e997244d55b0746d8c37ea40a58fc85d3a

Merge branch 'next' into expo-39

view details

Joe Haines

commit sha be54a4fdb580986511a6496f8301e59bd30da20c

Merge pull request #1052 from bugsnag/expo-39 Expo SDK 39 support

view details

Ben Gourley

commit sha 390379a53ab26daa30ef39ead7021a22eaf509cd

refactor(react-native): Hold nativeStack feature until pipeline supports it

view details

Ben Gourley

commit sha 97ffaa37da60964059f54d109ae7186784ec895e

Merge branch 'next' into integration/rn-native-stack

view details

push time in a day

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentbugsnag/bugsnag-js

[PLAT-5002] Include native stacktraces JS errors caused by native promise rejections

I've tested this in debug/prod builds on both platforms, using the rn0.63 example in this repo. All working as expected. However, I can't approve the PR since I originally raised it 🙃

bengourley

comment created time in 2 days

PullRequestReviewEvent

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha 1d146c15732ac409fd76ea62b872fe96d0b5ea04

chore: Update changelog

view details

Ben Gourley

commit sha 5f345caa4f2efdef67bf14386107f24aea46a5cc

dep(react-native): Bump cocoa to latest next

view details

push time in 2 days

delete branch bugsnag/bugsnag-js

delete branch : convert-tests-to-jest

delete time in 2 days

push eventbugsnag/bugsnag-js

Dan Skinner

commit sha 6cb59fcbab119ae315efa8daf4af902bc4752df6

test(plugin-network-breadcrumbs): convert tests

view details

Ben Gourley

commit sha 1b470e55653527bd3291a8f1c74d67d44b5e87b4

Merge pull request #1057 from bugsnag/convert-tests-to-jest test(plugin-network-breadcrumbs): convert tests

view details

push time in 2 days

PR merged bugsnag/bugsnag-js

test(plugin-network-breadcrumbs): convert tests

Goal

Conversion of tests from jasmine to jest and TypeScript for consistency and performance and improved type checking.

Design

See previous discussions

Changeset

Converted plugin-network-breadcrumbs tests from jasmine to jest.

Testing

Automated tests pass. Changes to test files, internal types and configuration only.

+116 -93

1 comment

4 changed files

djskinner

pr closed time in 2 days

PullRequestReviewEvent

push eventbugsnag/bugsnag-js

Dan Skinner

commit sha f1dfd22b00963af25a5756256cd8d01c4282335c

test(plugin-express, plugin-koa, plugin-restify): convert tests

view details

johnkiely1

commit sha 744eaf071f4ea2d208b1de93c7998210ec8555da

Update README.md

view details

johnkiely1

commit sha 7389d8c88112adfa68af29b4ea7f00507f92dff7

Update examples/reactnative/rn063example/README.md Co-authored-by: Tom Longridge <tom@bugsnag.com>

view details

johnkiely1

commit sha 3f482dd0f18da04e8f70eb922c64518d319bc613

Merge pull request #1033 from bugsnag/update-rnexample-readme Update RN example README with links to documentation

view details

Dan Skinner

commit sha a37348b95b464ea7aa328aac8bc39fce93c4a970

Merge branch 'next' into convert-tests-to-jest-6 * next: (31 commits) Update examples/reactnative/rn063example/README.md Update README.md v7.3.4 chore: Update changelog for release chore(react-native): Bump bugsnag-android to v5.1.0 Check if CDN uploads are successful chore: Update changelog test(react-native): Don't shrink test classes feat(react-native): Bump vendored android version test(react-native): Enable proguard on test apps refactor(react-native): Remove duplicate proguard rules fix: suppress unchecked cast warnings for RN Android test(delivery-xml-http-request): improve interface naming test(delivery-react-native): derive NativeClientEvent type refactor(react-native): Remove unnecessary log hash is not required include client-side sourcemap upload example Tests: Update local-test-util script to use same dockerfile base as others v7.3.3 Organise the changelog into sections ...

view details

Dan Skinner

commit sha 66147ab34f7a1bfbb2d9423987f56e6faba7d0bc

fix(react-native): update bugsnag-cocoa Updates the vendored bugsnag-cocoa to 6.1.4 primarily to incorporate the following fixes: - Copy the metadata observer list rather than mutating it directly.

view details

djskinner

commit sha e4cc223d1efa07cc1575bd95e61a4dd997b876e2

Merge pull request #1020 from bugsnag/convert-tests-to-jest-6 test(plugin-express, plugin-koa, plugin-restify): convert tests

view details

djskinner

commit sha bb03b2fe260a44db2f12e4c84e331213d4e9eefe

Merge pull request #1048 from bugsnag/update-bugsnag-cocoa fix(react-native): update bugsnag-cocoa

view details

Dan Skinner

commit sha 9b21050fe4a818e586276014f1f4a4225eb482dd

chore: update changelog

view details

Dan Skinner

commit sha 8158d4561e413b122108bc134cf673e30b30b17e

chore: update changelog

view details

djskinner

commit sha 49ed63057aa82e8c21a15ddef7c0e5642c5c4cf6

Merge pull request #1049 from bugsnag/release/v7.3.5 Release v7.3.5

view details

Dan Skinner

commit sha ad798ee3c9b9f84e2204991452be4405265e1a4a

v7.3.5

view details

Steve Kirkland

commit sha 35548f3f482159db93c1420b4e756a9663406ba6

ci(publish): handle 404 when @bugsnag/js is not in registry at all

view details

Steve Kirkland

commit sha e806d043aaa92f49f8d21f47078590e3c41ba964

docs(test): add React Native 0.63 to list of available options

view details

Steve Kirkland

commit sha 786cbfd75f5a3e3ff7440a9b876bbd2909e412cc

chore(expo): remove broken and out of date build script

view details

Steve Kirkland

commit sha 5729ff5600a56e32902bacb68719ce362e3be029

ci(mac): use macOS 10.15 build queue

view details

Steve Kirkland

commit sha 064a3bf70c5d863d4c037eaf47322e4c94529860

ci(mac): use refined naming convention for buildkite queues

view details

Dan Skinner

commit sha b61079292403e79e1761642bc9670b9f274a67d3

test(plugin-react-native-orientation-breadcrumbs): convert tests

view details

fractalwrench

commit sha 5992e445935ec33410ea98497d7ad4f8b40b7c51

chore: fix RN 0.63 example app setup

view details

djskinner

commit sha 6f71079f98b760aab5b55b45a51e509289f5a9db

Merge pull request #1055 from bugsnag/convert-tests-to-jest test(plugin-react-native-orientation-breadcrumbs): convert tests

view details

push time in 2 days

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha c6f82f647a654186804fc8f55d9213a98fdfcbe1

dep(react-native): update cocoa notifier to v6.1.6

view details

push time in 2 days

delete branch bugsnag/bugsnag-js

delete branch : rn-native-stack/mazerunner-tests

delete time in 2 days

push eventbugsnag/bugsnag-js

fractalwrench

commit sha b93090449858955503c7221c70f00af520696719

test: verify native stacktrace parising of RN promise rejection

view details

Ben Gourley

commit sha 6325c903b1a298e2e53a49c85c3869d661120ae1

Merge pull request #1066 from bugsnag/rn-native-stack/mazerunner-tests Add E2E scenario to verify RN native stack parsing

view details

push time in 2 days

PR merged bugsnag/bugsnag-js

Add E2E scenario to verify RN native stack parsing

Goal

Adds mazerunner scenarios which verify that the nativeStack property is parsed by the Android/iOS layers when passed by the JS layer in calls to dispatch().

The native layers should convert the information in nativeStack into a usable stacktrace and add it to the event.errors array after the original JS error.

+111 -15

1 comment

1 changed file

fractalwrench

pr closed time in 2 days

pull request commentbugsnag/bugsnag-js

Expo SDK 39 support

Just needs a changelog entry, otherwise good to merge.

imjoehaines

comment created time in 5 days

PullRequestReviewEvent

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha 64db15a411b1d729d59bed8b878f1c3baa7049ff

fix(plugin-react-navigation): Missing quotes off of string

view details

push time in 5 days

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha ca18c3dd21721ed3eee34e7593d46747f7f71fc1

refactor(plugin-react-navigation): Make types more straightforward

view details

push time in 5 days

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha 7c16ab8d97f74a1e29990cea5eedfb89105afeea

refactor(plugin-react-navigation): Give plugin class a more descriptive name

view details

Ben Gourley

commit sha f9a5906acce1c224f40a83e150fbd949ef9debb6

test(plugin-react-navigation): Use variables to make tests more readable

view details

Ben Gourley

commit sha 9731e6300f3f67cdaa759d3f2b5b7b1bd2290d3f

refactor(plugin-react-navigation): Add onReady event breadcrumb

view details

push time in 5 days

Pull request review commentbugsnag/bugsnag-js

[PLAT-5010]: Create React Navigation plugin

+import Plugin from '../'+import Client from '@bugsnag/core/client'+import TestRenderer from 'react-test-renderer'+import * as React from 'react'+import { NavigationContainer, NavigationContainerRef } from '@react-navigation/native'++jest.mock('@react-navigation/native')++afterEach(() => jest.clearAllMocks())++describe('plugin: react navigation', () => {

The ref has to be passed in in order to mock the getCurrentRoute() behaviour of the navigation lib.

bengourley

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentbugsnag/bugsnag-js

[PLAT-5010]: Create React Navigation plugin

+import { Plugin } from '@bugsnag/core'+import { NavigationContainer } from '@react-navigation/native'++// eslint-disable-next-line @typescript-eslint/no-empty-interface+interface BugsnagPluginReactNavigation extends Plugin { }+// eslint-disable-next-line @typescript-eslint/no-extraneous-class+declare class BugsnagPluginReactNavigation {+  constructor()+}

It's so that the class dynamically recieves all of the members of the Plugin interface. More context/discussion here https://github.com/bugsnag/bugsnag-js/pull/1067#discussion_r494207534 resulting in less duplication.

Since the duplication is minimal (just the load signature) I think it would be less confusing to duplicate so I'll switch.

bengourley

comment created time in 6 days

PullRequestReviewEvent

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha 9a1a868df5e4f691df66ded416c6e75907ddc150

fix(plugin-react-navigation): Add types to package files list Co-authored-by: Joe Haines <hello@joehaines.co.uk>

view details

push time in 6 days

create barnchbugsnag/bugsnag-js

branch : react-native-navigation-test-fixture-app

created branch time in 6 days

PullRequestReviewEvent

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha 40c2565c9685c9245ba6e5944d8e654e45f2b6e7

chore(test): Remove example project keys

view details

push time in 6 days

create barnchbugsnag/bugsnag-js

branch : react-navigation-text-fixture-app

created branch time in 6 days

push eventbugsnag/bugsnag-js

Steve Kirkland

commit sha 35548f3f482159db93c1420b4e756a9663406ba6

ci(publish): handle 404 when @bugsnag/js is not in registry at all

view details

Steve Kirkland

commit sha e806d043aaa92f49f8d21f47078590e3c41ba964

docs(test): add React Native 0.63 to list of available options

view details

Steve Kirkland

commit sha 786cbfd75f5a3e3ff7440a9b876bbd2909e412cc

chore(expo): remove broken and out of date build script

view details

Steve Kirkland

commit sha 5729ff5600a56e32902bacb68719ce362e3be029

ci(mac): use macOS 10.15 build queue

view details

Steve Kirkland

commit sha 064a3bf70c5d863d4c037eaf47322e4c94529860

ci(mac): use refined naming convention for buildkite queues

view details

Dan Skinner

commit sha b61079292403e79e1761642bc9670b9f274a67d3

test(plugin-react-native-orientation-breadcrumbs): convert tests

view details

fractalwrench

commit sha 5992e445935ec33410ea98497d7ad4f8b40b7c51

chore: fix RN 0.63 example app setup

view details

djskinner

commit sha 6f71079f98b760aab5b55b45a51e509289f5a9db

Merge pull request #1055 from bugsnag/convert-tests-to-jest test(plugin-react-native-orientation-breadcrumbs): convert tests

view details

Jamie Lynch

commit sha 9e3851151d296c79256046c21a5cd2ae1190d9bd

Merge pull request #1056 from bugsnag/PLAT-5074 Fix RN 0.63 example app setup

view details

Ben Gourley

commit sha 7b5f9b58bc3d7e8783d487875f2fab2a545cee18

Merge pull request #1050 from bugsnag/handle-empty-npm Handle empty NPM registry when building React Native test fixture

view details

Joe Haines

commit sha f50d7a210f62ec63744c6eb6916e5a1874a008be

feat(react-native): Allow plugins to be set in JS

view details

Joe Haines

commit sha cb2ec3aafd9dac7d7cf054c77e7729cc67760bbc

chore: add changelog entry

view details

Steve Kirkland

commit sha 9a87d34ff55f14958a296d8be0b761448c6537dc

test(expo): remove instructions for running expo tests locally on iOS

view details

Ben Gourley

commit sha ad7ada1f726c65062f3599c00395721a1234eb22

Merge pull request #1064 from bugsnag/allow-plugins-in-react-native React Native: allow plugins to be set in JS

view details

Steve Kirkland

commit sha 76af6368c384a5f5e3efc7c5d1a00409ca34ca28

Merge pull request #1053 from bugsnag/build-ios-with-macos-10.15 Use MacOS 10.15 build servers

view details

Ben Gourley

commit sha 64328f8447bf6c34be2c2c16129b9c09b1f39bb9

feat(plugin-react-navigation): Create React Navigation plugin

view details

Ben Gourley

commit sha c48d2e1fb1ca64a4a687fdd6f911340a07d5005d

feat(plugin-react-navigation): Get types working

view details

Ben Gourley

commit sha dd57e42e293a6c32d5e817a7b971620636c26ae2

chore: Update changelog

view details

push time in 6 days

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha a65f16114e7950f279db846ddc0098c1ad39eeff

feat(plugin-react-navigation): Get types working

view details

push time in 6 days

create barnchbugsnag/bugsnag-js

branch : bengourley/react-navigation-plugin

created branch time in 7 days

PullRequestReviewEvent

Pull request review commentbugsnag/bugsnag-js

Add plugin for React Native Navigation

+module.exports = class BugsnagPluginReactNativeNavigation {+  constructor (Navigation) {+    this.Navigation = Navigation+  }++  load (client) {+    let lastComponent++    this.Navigation.events().registerComponentDidAppearListener(event => {+      client.setContext(event.componentName)++      if (lastComponent !== event.componentName) {+        client.leaveBreadcrumb(

This ought to honour the enabledBreadcrumbTypes config option…

if (client._config.enabledBreadcrumbTypes && client._config.enabledBreadcrumbTypes.includes('navigation')) {
imjoehaines

comment created time in 7 days

Pull request review commentbugsnag/bugsnag-js

Add plugin for React Native Navigation

+{+  "name": "@bugsnag/plugin-react-native-navigation",+  "version": "7.3.5",+  "main": "react-native-navigation.js",+  "description": "@bugsnag/react-native plugin for integration with react-native-navigation",+  "homepage": "https://www.bugsnag.com/",+  "repository": {+    "type": "git",+    "url": "git@github.com:bugsnag/bugsnag-js.git"+  },+  "publishConfig": {+    "access": "public"+  },+  "files": [+    "*.js"+  ],+  "author": "Bugsnag",+  "license": "MIT",+  "devDependencies": {+    "@bugsnag/core": "^7.3.5"+  },+  "peerDependencies": {+    "@bugsnag/core": "^7.0.0",+    "react-native-navigation": "^7.0.0"

Is this incompatible with older versions? Could this version constraint be more loose?

imjoehaines

comment created time in 7 days

PullRequestReviewEvent

delete branch bugsnag/bugsnag-js

delete branch : allow-plugins-in-react-native

delete time in 8 days

push eventbugsnag/bugsnag-js

Joe Haines

commit sha f50d7a210f62ec63744c6eb6916e5a1874a008be

feat(react-native): Allow plugins to be set in JS

view details

Joe Haines

commit sha cb2ec3aafd9dac7d7cf054c77e7729cc67760bbc

chore: add changelog entry

view details

Ben Gourley

commit sha ad7ada1f726c65062f3599c00395721a1234eb22

Merge pull request #1064 from bugsnag/allow-plugins-in-react-native React Native: allow plugins to be set in JS

view details

push time in 8 days

PR merged bugsnag/bugsnag-js

React Native: allow plugins to be set in JS

Goal

To develop optional plugins for the React Native notifier, we need to allow the plugins option to be set from JS — it's currently not in the list of properties the JS layer is allowed to set

Testing

I've tested with an in-progress plugin and it gets loaded as expected

+7 -1

1 comment

2 changed files

imjoehaines

pr closed time in 8 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentbugsnag/bugsnag-js

[PLAT-5002] Pass nativeStack property to native layer and set up tests

Closing in favour of #1061.

bengourley

comment created time in 8 days

PR opened bugsnag/bugsnag-js

[PLAT-5002] Include native stacktraces JS errors caused by native promise rejections

When a native module method is called from JS and the native promise is rejected, the JS layer receives the native stacktrace.

This PR brings together the native and JS changes required to include this stacktrace in the event as an additional entry in the errors array.

+13333 -119

0 comment

64 changed files

pr created time in 8 days

create barnchbugsnag/bugsnag-js

branch : integration/rn-native-stack

created branch time in 8 days

delete branch bugsnag/bugsnag-js

delete branch : handle-empty-npm

delete time in 8 days

push eventbugsnag/bugsnag-js

Steve Kirkland

commit sha 35548f3f482159db93c1420b4e756a9663406ba6

ci(publish): handle 404 when @bugsnag/js is not in registry at all

view details

Steve Kirkland

commit sha e806d043aaa92f49f8d21f47078590e3c41ba964

docs(test): add React Native 0.63 to list of available options

view details

Ben Gourley

commit sha 7b5f9b58bc3d7e8783d487875f2fab2a545cee18

Merge pull request #1050 from bugsnag/handle-empty-npm Handle empty NPM registry when building React Native test fixture

view details

push time in 8 days

PR merged bugsnag/bugsnag-js

Handle empty NPM registry when building React Native test fixture

Goal

After completely clearing out our local NPM registry, I found that the publish.js script failed due to npm view versions returning 404 when there are no @bugsnag/js artifacts at all. This handles that special case, together with any other failure to detect existing versions. If it fails for a different reason and it actually causes the publish to fail (failing to detect existing versions doesn't necessarily mean that the publish will fail), the script will simply error at a later stage and we can investigate and fix the underlying cause.

Changeset

I also noticed that RN 0.63 was missing from the list of available testing options.

Testing

Verified by the fact that the CI for this PR now runs.

+10 -2

1 comment

2 changed files

twometresteve

pr closed time in 8 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha 378debc250425e0723b57eeddc59a1d5b621b245

test(react-native): Spike out tests for native stack

view details

push time in 13 days

issue commentbugsnag/bugsnag-js

Browser bundle is quite large

Ciao @bengourley, any update on supporting a lighter version of Bugsnag?

Making a "lite" version is not something that we are going to be working on any time soon.

With the new Core Web Vitals standards coming out, have a 11-12kB gzipped for a Bug reporting library is not a fair tradeoff especially

This is simply how big an error monitoring tool has to be – take a look at other providers, they are all of the same order of magnitude once you have manual error reporting, automatic error reporting and a bunch of useful breadcrumbs and contextual information.

especially if we use very little of the library

You probably use more of the library than you realise.

jescalan

comment created time in 13 days

issue commentbugsnag/bugsnag-js

Browser bundle is quite large

The reason why nothing gets removed is because your modules are imported with require. The whole tree-shaking thing revolves on using ES imports. Migrating your CommonJS imports to ES ones will resolve this issue ;)

This isn't true. There is a tree shaking module for browserify. Everything included in the bundle is essential.

jescalan

comment created time in 13 days

PullRequestReviewEvent

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha a0a914fb10affc3244d739edff6bb75de9e72fce

test(react-native): Spike out tests for native stack

view details

push time in 14 days

PullRequestReviewEvent

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha 7efcb319ddbd77224753dfc671d48346bd24b200

test(react-native): Spike out tests for native stack

view details

push time in 14 days

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha b7fe1b7c2bf06366cfe563e35cd095a6b7316a3a

test(react-native): Spike out tests for native stack

view details

push time in 14 days

create barnchbugsnag/bugsnag-js

branch : bengourley/rn-native-stack

created branch time in 14 days

delete branch bugsnag/bugsnag-js

delete branch : convert-tests-to-jest-7

delete time in 16 days

push eventbugsnag/bugsnag-js

Dan Skinner

commit sha 96c7afac7d47b5ed5c7d584b97c0eb81eeda9b1b

test(delivery-react-native): convert tests

view details

Dan Skinner

commit sha d123522e3c8521e4a64bf128db13cd6caa9c875d

Merge branch 'next' into convert-tests-to-jest-7 * next: hash is not required include client-side sourcemap upload example Tests: Update local-test-util script to use same dockerfile base as others v7.3.3 Organise the changelog into sections Update changelog test(plugin-contextualize): convert tests test(plugin-client-ip): convert tests fix(lerna): replace all non-server characters in branch names when publishing chore: clean test dependencies test(plugin-react-native-client-sync): convert tests Tests: Ensure tests use latest V2 mazerunner release docs: Fix typos in upgrade guide Tests: Improve duplicate request resilience using reset_with_timeout

view details

Dan Skinner

commit sha 1383a1c0f808ecd4c6837de7956c94dc9c38cb2e

test(delivery-react-native): derive NativeClientEvent type

view details

Ben Gourley

commit sha 569a24ced923ca68d42ce4ace1514baa5c82e1d6

Merge branch 'next' into convert-tests-to-jest-7

view details

Ben Gourley

commit sha 12e28815498e3e934f8f4e5808bbe9838677e9c4

Merge pull request #1021 from bugsnag/convert-tests-to-jest-7 test(delivery-react-native): convert tests

view details

push time in 16 days

PR merged bugsnag/bugsnag-js

test(delivery-react-native): convert tests

Goal

Conversion of tests from jasmine to jest and TypeScript for consistency and performance and improved type checking.

Design

See previous discussions

Changeset

Converted delivery-react-native tests from jasmine to jest.

Testing

Automated tests pass. Changes to test files, internal types and configuration only.

+24 -11

1 comment

4 changed files

djskinner

pr closed time in 16 days

push eventbugsnag/bugsnag-js

Dan Skinner

commit sha e6e0d1d31349f78e9afca768a5871a372dd6461a

test(delivery-xml-http-request): convert tests

view details

Ben Gourley

commit sha 4d3182e1b239b1ae8df71e8d196f01c7b5c405b1

refactor(react-native): Remove unnecessary log

view details

Dan Skinner

commit sha ef6a23b1b5614934d787b12832b13bf04bb04cdc

test(delivery-xml-http-request): improve interface naming

view details

Dan Skinner

commit sha 2b6687f5d7edc1ed3ffc8bd3f0df929e9398d0e5

Merge branch 'next' into convert-tests-to-jest-4 * next: hash is not required include client-side sourcemap upload example Tests: Update local-test-util script to use same dockerfile base as others v7.3.3 Organise the changelog into sections Update changelog test(plugin-contextualize): convert tests test(plugin-client-ip): convert tests fix(lerna): replace all non-server characters in branch names when publishing chore: clean test dependencies test(plugin-react-native-client-sync): convert tests Tests: Ensure tests use latest V2 mazerunner release docs: Fix typos in upgrade guide Tests: Improve duplicate request resilience using reset_with_timeout

view details

fractalwrench

commit sha 02e172f83b3a5e78663c63313aa27b52c04f4618

fix: suppress unchecked cast warnings for RN Android

view details

djskinner

commit sha 2de4bc0251d9d56c6f7c4a68908dfbff38812ff7

Merge pull request #1018 from bugsnag/convert-tests-to-jest-4 test(delivery-xml-http-request): convert tests

view details

Ben Gourley

commit sha 64015fcffc175b445961f8345bd466e480434a1d

refactor(react-native): Remove duplicate proguard rules

view details

Ben Gourley

commit sha 2db269985a07dd03a9f3a250ef70bc4563799fa1

test(react-native): Enable proguard on test apps

view details

Ben Gourley

commit sha ba2fe4678e92c6288a7de72dba238564ac3b3bda

feat(react-native): Bump vendored android version

view details

Ben Gourley

commit sha 6b1be96ff77b6d752cd56f10759e23d57f66c399

test(react-native): Don't shrink test classes

view details

Ben Gourley

commit sha f8243212f0108459ebad4778f2729a454cd7739d

chore: Update changelog

view details

Ben Gourley

commit sha eaa6115a9a9b9eff62f2e9747de24b8649a53872

Merge pull request #1030 from bugsnag/bengourley/rn-proguard-fix [PLAT-4921] Fix @bugsnag/react-native proguard compatibility

view details

Jamie Lynch

commit sha 8332754beb1f791de825d4353ebcdf37277bf3e2

Merge branch 'next' into PLAT-4923/suppress-warnings

view details

Jamie Lynch

commit sha 00f9fc4f4c49d8e554b744b207085903f0aa7bb5

Merge pull request #1027 from bugsnag/PLAT-4923/suppress-warnings Suppress unchecked cast warnings for React Native Android

view details

Joe Haines

commit sha 2984074b329909f11d0579dfde66edb41e7550f5

Check if CDN uploads are successful Knox doesn't error if the request is not successful, so we need to check the status code ourselves Ultimately we may want to move to a maintained library but, with this check, debugging should be less of a problem in future

view details

Ben Gourley

commit sha 8073662df52b1a21846c1780fa1527f3446dd9e9

Merge pull request #1031 from bugsnag/cdn-upload-fail-on-http-error Check if CDN uploads are successful

view details

Ben Gourley

commit sha 56688f764b03cf893616a06700f9645a186268bd

Merge pull request #1028 from bugsnag/bengourley/remove-log refactor(react-native): Remove unnecessary log

view details

Ben Gourley

commit sha 39a73cc449b65a79a32bf28235b1348f20cda5c1

chore(react-native): Bump bugsnag-android to v5.1.0

view details

Ben Gourley

commit sha 248588580ad29a3feee919ac83c2a6aedc2da6ac

chore: Update changelog for release

view details

Ben Gourley

commit sha 29efc955a82c63a606d47afdd1f776d87751d23a

Release v7.3.4

view details

push time in 16 days

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha 39a73cc449b65a79a32bf28235b1348f20cda5c1

chore(react-native): Bump bugsnag-android to v5.1.0

view details

Ben Gourley

commit sha 248588580ad29a3feee919ac83c2a6aedc2da6ac

chore: Update changelog for release

view details

Ben Gourley

commit sha 29efc955a82c63a606d47afdd1f776d87751d23a

Release v7.3.4

view details

Ben Gourley

commit sha 2aa1e04f004208ef809dd814a34742c5ccd42212

v7.3.4

view details

push time in 20 days

release bugsnag/bugsnag-js

v7.3.4

released time in 20 days

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha 2aa1e04f004208ef809dd814a34742c5ccd42212

v7.3.4

view details

push time in 20 days

created tagbugsnag/bugsnag-js

tagv7.3.4

Javascript error handling tool for Bugsnag. Monitor and report JavaScript bugs & errors.

created time in 20 days

push eventbugsnag/bugsnag-js

Alex Moinet

commit sha 4704ed5c6ebac238822c9b7ac60591f8c4a4406a

Tests: Improve duplicate request resilience using reset_with_timeout

view details

Alex Moinet

commit sha 0757368d9329f1c2899b26e202e296f5c1233e02

Tests: Ensure tests use latest V2 mazerunner release

view details

Dan Skinner

commit sha 91f488f3fb27df508376c0fdbabb5c104a247406

test(plugin-react-native-client-sync): convert tests

view details

Dan Skinner

commit sha 7dd29f49c218b6aa9e4ba1f91479797a3209685f

chore: clean test dependencies

view details

Steve Kirkland

commit sha a7440c5a0a5158892456a4cf7ed2e957532e6b3b

fix(lerna): replace all non-server characters in branch names when publishing

view details

Dan Skinner

commit sha 2a8167fd5601b4b760457064349f1d59b35cd92d

test(plugin-client-ip): convert tests

view details

Dan Skinner

commit sha e6e0d1d31349f78e9afca768a5871a372dd6461a

test(delivery-xml-http-request): convert tests

view details

Dan Skinner

commit sha ced3a7df0392a87b3a409151d42a41f3b1665c68

test(plugin-contextualize): convert tests

view details

Alex Moinet

commit sha 3d6483717231282f157cc32311343c3de028d6e2

Tests: Update local-test-util script to use same dockerfile base as others

view details

Alex Moinet

commit sha 9f74bf2157260cb2579b7caa95da0fb325a1f76e

Merge pull request #1024 from bugsnag/tests/use-reset-with-timeout [PLAT-3907] Use the `latest-v2-cli` branch and `reset_with_timeout` method

view details

Steve Nester

commit sha ce8c728fb4dc7ee18e4fdfcf4454efaaed7d3d1a

include client-side sourcemap upload example

view details

Steve Nester

commit sha faa2c84a614be3c8d3788f5af2641c39eb76826f

hash is not required

view details

Steve Kirkland

commit sha 4df6a88e2fecc10efa31e9c534dc83f43fea0eb8

Merge pull request #1022 from bugsnag/tms/Branch_Naming-1.2 fix(lerna): replace non-semver characters publishing

view details

Steve Nester

commit sha 97c791305c13c126bbaf8bf9d2c7086aa1173476

Merge pull request #1025 from bugsnag/SUP-52b Add `BugsnagSourceMapUploaderPlugin` to nuxtjs example project

view details

Dan Skinner

commit sha 561d3f362cb4f8f62a88903c955ac378f7ef9953

Merge branch 'next' into convert-tests-to-jest-2 * next: hash is not required include client-side sourcemap upload example Tests: Update local-test-util script to use same dockerfile base as others v7.3.3 Organise the changelog into sections Update changelog fix(lerna): replace all non-server characters in branch names when publishing Tests: Ensure tests use latest V2 mazerunner release docs: Fix typos in upgrade guide Tests: Improve duplicate request resilience using reset_with_timeout

view details

djskinner

commit sha c0a39911ad6080de40d784aa989af625b567d752

Merge pull request #1016 from bugsnag/convert-tests-to-jest-2 chore: clean test dependencies

view details

djskinner

commit sha 41c9ff793f96006ca785e7520459550a6adfd50f

Merge branch 'next' into convert-tests-to-jest

view details

djskinner

commit sha bda94e845917c66d8f305a7128a905ba31de8017

Merge pull request #1015 from bugsnag/convert-tests-to-jest test(plugin-react-native-client-sync): convert tests

view details

djskinner

commit sha 48d6139521f6da0167de4782e04f9cdb5a5caee6

Merge branch 'next' into convert-tests-to-jest-3

view details

Ben Gourley

commit sha 4d3182e1b239b1ae8df71e8d196f01c7b5c405b1

refactor(react-native): Remove unnecessary log

view details

push time in 20 days

delete branch bugsnag/bugsnag-js

delete branch : release/v7.3.4

delete time in 20 days

PR merged bugsnag/bugsnag-js

Release v7.3.4

7.3.4 (2020-09-10)

Fixed

  • (react-native): Suppress unchecked cast warnings for React Native Android #1027
  • (react-native): Provide proguard rules to ensure reflection works on minified/obfuscated Android builds #1030

Removed

  • (react-native): Remove unnecessary log on iOS #1028
+470 -6417

1 comment

115 changed files

bengourley

pr closed time in 20 days

PR opened bugsnag/bugsnag-js

Reviewers
Release v7.3.4

7.3.4 (2020-09-10)

Fixed

  • (react-native): Suppress unchecked cast warnings for React Native Android #1027
  • (react-native): Provide proguard rules to ensure reflection works on minified/obfuscated Android builds #1030

Removed

  • (react-native): Remove unnecessary log on iOS #1028
+470 -6417

0 comment

115 changed files

pr created time in 20 days

create barnchbugsnag/bugsnag-js

branch : release/v7.3.4

created branch time in 20 days

delete branch bugsnag/bugsnag-js

delete branch : bengourley/remove-log

delete time in 20 days

push eventbugsnag/bugsnag-js

Ben Gourley

commit sha 4d3182e1b239b1ae8df71e8d196f01c7b5c405b1

refactor(react-native): Remove unnecessary log

view details

Ben Gourley

commit sha 56688f764b03cf893616a06700f9645a186268bd

Merge pull request #1028 from bugsnag/bengourley/remove-log refactor(react-native): Remove unnecessary log

view details

push time in 20 days

PR merged bugsnag/bugsnag-js

refactor(react-native): Remove unnecessary log

Noticed a log that was used for debugging which can be removed.

+0 -1

1 comment

1 changed file

bengourley

pr closed time in 20 days

delete branch bugsnag/bugsnag-js

delete branch : cdn-upload-fail-on-http-error

delete time in 20 days

push eventbugsnag/bugsnag-js

Joe Haines

commit sha 2984074b329909f11d0579dfde66edb41e7550f5

Check if CDN uploads are successful Knox doesn't error if the request is not successful, so we need to check the status code ourselves Ultimately we may want to move to a maintained library but, with this check, debugging should be less of a problem in future

view details

Ben Gourley

commit sha 8073662df52b1a21846c1780fa1527f3446dd9e9

Merge pull request #1031 from bugsnag/cdn-upload-fail-on-http-error Check if CDN uploads are successful

view details

push time in 20 days

PR merged bugsnag/bugsnag-js

Check if CDN uploads are successful

Goal

Knox doesn't error if the request is unsuccessful, so we need to check the status code ourselves

Ultimately we may want to move to a maintained library but, with this check, debugging should be less of a problem in future

Testing

Manually tested by attempting to upload with invalid credentials — before the change the script silently does nothing; now it fails with an error

+14 -3

1 comment

1 changed file

imjoehaines

pr closed time in 20 days

PullRequestReviewEvent

delete branch bugsnag/bugsnag-js

delete branch : bengourley/rn-proguard-fix

delete time in a month

more