profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/bcoe/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Benjamin E. Coe bcoe Google Oakland https://twitter.com/benjamincoe Co-founded Attachments.me, early employee at npm Inc. Maintains yargs, Istanbul, contributes to Node.js. Currently cloud at Google.

bcoe/Adventures-in-Document-Thumbnailing 14

Some thoughts I have about creating thumbnails of common document types.

bcoe/ansible-nagios-config 10

Ansible role for configuring Nagios 4.

bcoe/apidoc-md 9

Generate API documentation for your README from comments in your source-code

bcoe/AFHTTPRequestOperationManager-Timeout 6

Add timeout functionality to AFHTTPRequestOperationManager with Category

bcoe/any-path 4

:rage2: make the keys on an object path.sep agnostic.

AkashaCoin/ravejs 3

RaveJS Beginnings

bcoe/assertassert 3

:trollface: for when you can't decide on an assertion library

bcoe/ansible-pg-wale 2

Configure Heroku's WAL-E for Postgres

ashwinGokhale/IstanbulSplashPage 1

Splash page for Istanbul

bcoe/ansible-elasticsearch 1

Ansible playbook for Elasticsearch

issue commentgoogleapis/google-api-nodejs-client

@googleapis packages are not being updated in npm

This for brining this bug to our attention @MarcCelani-at, the issue that was preventing submodules from publishing has been addressed as of last week, see recent publications of modules like https://www.npmjs.com/package/@googleapis/sqladmin.

Other modules will be released as updates are made. Do you have an explicit need for new features in @googleapis/admin, or did you just raise this as an example?

MarcCelani-at

comment created time in 20 hours

issue closedgoogleapis/release-please

Node submodules not being published

I think we're failing to release our @googleapis node submodules, see this bug report

closed time in 20 hours

sofisl

issue commentgoogleapis/release-please

Node submodules not being published

This has been fixed as of Friday.

sofisl

comment created time in 20 hours

issue openedgoogleapis/repo-automation-bots

owlbot: OwlBot should not run against draft PRs unless explicitly triggered

Today, OwlBot runs against Draft PRs, it might be worth considering only running OwlBot once the draft is turned into an actual PR.

This is based on feedback from @minherz.

Refs: https://github.com/googleapis/nodejs-secret-manager/pull/298

created time in 21 hours

PR closed googleapis/nodejs-secret-manager

test: testing draft PRs with OwlBot do not merge cla: yes api: secretmanager

Is OwlBot currently applied to draft PRs?

+8 -8

0 comment

4 changed files

bcoe

pr closed time in 21 hours

PR opened googleapis/nodejs-secret-manager

test: testing draft PRs with OwlBot

Is OwlBot currently applied to draft PRs?

+1 -1

0 comment

1 changed file

pr created time in 21 hours

create barnchgoogleapis/nodejs-secret-manager

branch : test-draft-pr

created branch time in 21 hours

PullRequestReviewEvent

Pull request review commentgoogleapis/nodejs-storage

test: pull testbench docker image, kokoro presubmit conformance test …

+/*!

nit: I would be tempted to cll this test-bench-util.ts, this just tends to be the JavaScript convention.

ddelgrosso1

comment created time in a day

PullRequestReviewEvent

issue commentnodejs/node

fs.rmSync() not releasing file handles

@andrewhodel I tested with Amazon's lambda base image and unfortunately it didn't reproduce, this is the container I'm running:

Linux 297e8b498d12 4.9.184-linuxkit #1 SMP Tue Jul 2 22:58:16 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

One thing that jumped out at me, I notice in your sample code does not require('fs');, which for me results in:

ReferenceError: fs is not defined

When executing the script. How do you execute the sample code you shared?

  1. ssh into AWS instance?
  2. execute with node I assume?
andrewhodel

comment created time in 2 days

push eventgoogleapis/nodejs-translate

release-please[bot]

commit sha add1b537cf798e89d0771707dc9894b1b5051e4e

chore: release 6.3.0 (#714) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

view details

push time in 5 days

delete branch googleapis/nodejs-translate

delete branch : release-v6.3.0

delete time in 5 days

PR merged googleapis/nodejs-translate

chore: release 6.3.0 cla: yes autorelease: pending api: translate

:robot: I have created a release *beep* *boop*

6.3.0 (2021-09-13)

Features

  • added v3 proto for online/batch document translation and updated v3beta1 proto for format conversion (#719) (76c9a13)
  • turns on self-signed JWT feature flag (#713) (41062a6)

Bug Fixes

  • add missing annotation for batch document translation (#715) (b893e3d)
  • build: set default branch to main (#722) (26b9ba7)
  • remove unnecessary assertion (#721) (a5a1f82)

This PR was generated with Release Please. See documentation.

+17 -2

1 comment

3 changed files

release-please[bot]

pr closed time in 5 days

PR closed googleapis/nodejs-translate

fix(deps): update dependency is-html to v3 cla: yes api: translate

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
is-html ^2.0.0 -> ^3.0.0 age adoption passing confidence

Release Notes

<details> <summary>sindresorhus/is-html</summary>

v3.0.0

Compare Source

Breaking

</details>


Configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

+1 -1

0 comment

1 changed file

renovate-bot

pr closed time in 5 days

PullRequestReviewEvent

issue openedgoogleapis/repo-automation-bots

python-logging fails when attempting to create pull request

Output:

2021-09-16 17:25:47,774 synthtool [ERROR] > Failed executing nox -s blacken:
SyntaxError: invalid syntax
                                                    ^
    session.install("flask", "-c", constraints_path)session.install("webob", "-c", constraints_path)session.install("django", "-c", constraints_path)
  File "/workspace/python-logging/noxfile.py", line 91
    return compile(source, filename, mode, flags,
  File "/usr/local/lib/python3.9/ast.py", line 50, in parse
    module: ast.Module = ast.parse(source, filename=filename)

Failed Build:

https://pantheon.corp.google.com/cloud-build/builds;region=global/5ec42a1a-e3c0-4c17-a378-952d3a534ff5;step=0?project=repo-automation-bots

created time in 5 days

issue commentgoogleapis/repo-automation-bots

Exception with OwlBot Java post-processor "could not find expected ':'"

Bumped down to p2 since this is an edge case?

bcoe

comment created time in 5 days

Pull request review commentgoogleapis/gapic-generator-typescript

feat: auto generate samples for each method

+// Copyright 2021 Google LLC+//+// Licensed under the Apache License, Version 2.0 (the "License");+// you may not use this file except in compliance with the License.+// You may obtain a copy of the License at+//+//      http://www.apache.org/licenses/LICENSE-2.0+//+// Unless required by applicable law or agreed to in writing, software+// distributed under the License is distributed on an "AS IS" BASIS,+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+// See the License for the specific language governing permissions and+// limitations under the License.+++'use strict';++function main() {

whoops, noticed we're missing variable names in main(), so that we can run form terminal.

sofisl

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentgoogleapis/gapic-generator-typescript

feat: auto generate samples for each method.

+// Copyright 2021 Google LLC+//+// Licensed under the Apache License, Version 2.0 (the "License");+// you may not use this file except in compliance with the License.+// You may obtain a copy of the License at+//+//      http://www.apache.org/licenses/LICENSE-2.0+//+// Unless required by applicable law or agreed to in writing, software+// distributed under the License is distributed on an "AS IS" BASIS,+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+// See the License for the specific language governing permissions and+// limitations under the License.+++'use strict';++function main() {+  // [START asset_list_feeds_sample]+  /**+   * TODO(developer): Uncomment these variables before running the sample.+   */+  /**+   *  Required. The parent project/folder/organization whose feeds are to be+   *  listed. It can only be using project/folder/organization number (such as+   *  "folders/12345")", or a project ID (such as "projects/my-project-id").+   */+  // const parent = 'abc123'++  // Imports the Asset library+  const {AssetServiceClient} = require('@google-cloud/asset').v1;++  // Instantiates a client+  const assetClient = new AssetServiceClient();++  async function listFeeds() {+    // Construct request+    const request = {+      parent,+    };++    // Run request+    const response = await assetClient.listFeeds(request);

@sofisl shoed me that this was the case, retract my comment 😄

sofisl

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentgoogleapis/gapic-generator-typescript

feat: auto generate samples for each method.

++++'use strict';++function main() {+  // [START asset_batch_get_assets_history_sample]+  /**+   * TODO(developer): Uncomment these variables before running the sample.+   */+  /**+   *  Required. The relative name of the root asset. It can only be an+   *  organization number (such as "organizations/123"), a project ID (such as+   *  "projects/my-project-id")", or a project number (such as "projects/12345").+   */+  // const parent ='abc123'+  /**+   *  A list of the full names of the assets. For example:+   *  `//compute.googleapis.com/projects/my_project_123/zones/zone1/instances/instance1`.+   *  See [Resource+   *  Names](https://cloud.google.com/apis/design/resource_names#full_resource_name)+   *  and [Resource Name+   *  Format](https://cloud.google.com/asset-inventory/docs/resource-name-format)+   *  for more info.+   *  The request becomes a no-op if the asset name list is empty, and the max+   *  size of the asset name list is 100 in one request.+   */+  // const assetNames ='abc123'+  /**+   *  Optional. The content type.+   */+  // const [contentType] =''+  /**+   *  Optional. The time window for the asset history. Both start_time and+   *  end_time are optional and if set, it must be after the current time minus+   *  35 days. If end_time is not set, it is default to current timestamp.+   *  If start_time is not set, the snapshot of the assets at end_time will be+   *  returned. The returned results contain all temporal assets whose time+   *  window overlap with read_time_window.+   */+  // const [readTimeWindow] =''++  // Imports the Asset library+  const {AssetServiceClient} = require('@google-cloud/asset');++  // Instantiates a client+  const assetClient = new AssetServiceClient();++  async function batchGetAssetsHistory() {+    // Construct request+    const request = {+      parent,+    };++    // Run request+    const response = await assetClient.batchGetAssetsHistory(request);+    console.log(`Response: ${response}`);

I think we should just console.log(response), which will output it without [obj Object] but doesn't require JSON.stringify.

I think for util.inspect we'd need ti require('util').

sofisl

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentgoogleapis/gapic-generator-typescript

feat: auto generate samples for each method.

+// Copyright 2021 Google LLC+//+// Licensed under the Apache License, Version 2.0 (the "License");+// you may not use this file except in compliance with the License.+// You may obtain a copy of the License at+//+//      http://www.apache.org/licenses/LICENSE-2.0+//+// Unless required by applicable law or agreed to in writing, software+// distributed under the License is distributed on an "AS IS" BASIS,+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+// See the License for the specific language governing permissions and+// limitations under the License.+++'use strict';++function main() {+  // [START asset_list_feeds_sample]+  /**+   * TODO(developer): Uncomment these variables before running the sample.+   */+  /**+   *  Required. The parent project/folder/organization whose feeds are to be+   *  listed. It can only be using project/folder/organization number (such as+   *  "folders/12345")", or a project ID (such as "projects/my-project-id").+   */+  // const parent = 'abc123'++  // Imports the Asset library+  const {AssetServiceClient} = require('@google-cloud/asset').v1;++  // Instantiates a client+  const assetClient = new AssetServiceClient();++  async function listFeeds() {+    // Construct request+    const request = {+      parent,+    };++    // Run request+    const response = await assetClient.listFeeds(request);

If a method like listFeeds has an equivalent listFeedsAsync, I would prefer that we only generate a sample for listFeedsAsync, and show the syntax:

for async (const resp of ssetClient.listFeeds(request)) {
  console.info(resp);
}

I mention later on in review.

This could be follow on work IMO too, I would open tracking issues on this repository for any improvements we want to make to sample generation.

sofisl

comment created time in 5 days

Pull request review commentgoogleapis/gapic-generator-typescript

feat: auto generate samples for each method.

+// Copyright 2021 Google LLC+//+// Licensed under the Apache License, Version 2.0 (the "License");+// you may not use this file except in compliance with the License.+// You may obtain a copy of the License at+//+//      http://www.apache.org/licenses/LICENSE-2.0+//+// Unless required by applicable law or agreed to in writing, software+// distributed under the License is distributed on an "AS IS" BASIS,+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+// See the License for the specific language governing permissions and+// limitations under the License.+++'use strict';++function main() {+  // [START asset_batch_get_assets_history_sample]+  /**+   * TODO(developer): Uncomment these variables before running the sample.+   */+  /**+   *  Required. The relative name of the root asset. It can only be an

Having these comments in the sample is great, in the past I would hunt these down in the source files.

sofisl

comment created time in 5 days

Pull request review commentgoogleapis/gapic-generator-typescript

feat: auto generate samples for each method.

+// Copyright 2021 Google LLC+//+// Licensed under the Apache License, Version 2.0 (the "License");+// you may not use this file except in compliance with the License.+// You may obtain a copy of the License at+//+//      http://www.apache.org/licenses/LICENSE-2.0+//+// Unless required by applicable law or agreed to in writing, software+// distributed under the License is distributed on an "AS IS" BASIS,+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+// See the License for the specific language governing permissions and+// limitations under the License.+++'use strict';++function main() {+  // [START asset_batch_get_assets_history_sample]+  /**+   * TODO(developer): Uncomment these variables before running the sample.+   */+  /**+   *  Required. The relative name of the root asset. It can only be an+   *  organization number (such as "organizations/123"), a project ID (such as+   *  "projects/my-project-id")", or a project number (such as "projects/12345").+   */+  // const parent = 'abc123'+  /**+   *  A list of the full names of the assets. For example:+   *  `//compute.googleapis.com/projects/my_project_123/zones/zone1/instances/instance1`.+   *  See [Resource

Nit: part of me wishes we removed markdown links, but I think this is a "nice to have" we could do in follow up work.

sofisl

comment created time in 5 days