profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/baujla/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

baujla/swift-llbuild 0

A low-level build system, used by Xcode 9 and the Swift Package Manager

mlinsenbard/481FinalProject 0

Final project repository for movie suggestion knowledge engine.

troxellophilus/Ultra-Air-Arcade 0

Ultra Air Arcade Source

pull request commentapple/swift

[Test] Disabled two Concurrency tests for back deploy.

@swift-ci please clean test linux platform

nate-chandler

comment created time in 16 minutes

pull request commentapple/swift

[Test] Disabled two Concurrency tests for back deploy.

@swift-ci please clean test macos platform

nate-chandler

comment created time in 16 minutes

push eventapple/swift-evolution

Marina Gornostaeva

commit sha 0079a2c392762b7c78d009ef82a568279a684a1e

Fix typos in SE-0309

view details

Marina Gornostaeva

commit sha e5edb02149f197193701f15bec432e48196f0431

Improve wording in SE-0309 - bring back 'iff'

view details

Marina

commit sha 62aa74ac88c3e051ae05e625e27d15ceda97ba49

Update proposals/0309-unlock-existential-types-for-all-protocols.md

view details

Joe Groff

commit sha 1d3f499dc9fbcde07d44f16fc4f0a29eb0419603

Merge pull request #1333 from hybridcattt/fix-typos-0309 Fix typos in SE-0309

view details

push time in 30 minutes

PR merged apple/swift-evolution

Fix typos in SE-0309

Fixing two small typos in SE-0309.

GitHub is not showing the diff right for the first change (perhaps due to line being too long) - the typo is in 'straightforwand' 🙂

+3 -3

1 comment

1 changed file

hybridcattt

pr closed time in 30 minutes

pull request commentapple/swift-evolution

Fix typos in SE-0309

Thanks @hybridcattt!

hybridcattt

comment created time in 30 minutes

push eventapple/swift

Ben Langmuir

commit sha 4dca0c61fbe2e1b6eea001655e9af5ce6189311e

[completion] Clarify and simplify not-recommended state Combine IsNotRecommended with NotRecommendedReason and improve the names of the existing cases to more clearly identify the cases they apply to. Now all not-recommended completions are required to have a reason.

view details

Ben Langmuir

commit sha dbd2dd4edb79e0aefca5e351dae3aab82211246c

[completion] Make NotRecommendedReason an enum class

view details

Ben Langmuir

commit sha 7253dae1a8980e01efe6d4d744dd8a5d78746d71

Merge pull request #36964 from benlangmuir/not-recommended-improvement-5.5 [5.5][completion] Clarify and simplify not-recommended state

view details

push time in 36 minutes

PR merged apple/swift

[5.5][completion] Clarify and simplify not-recommended state r5.5

Cherry-pick https://github.com/apple/swift/pull/36961 to release/5.5


Combine IsNotRecommended with NotRecommendedReason and improve the names of the existing cases to more clearly identify the cases they apply to. Now all not-recommended completions are required to have a reason.

+54 -63

1 comment

5 changed files

benlangmuir

pr closed time in 36 minutes

Pull request review commentapple/swift-evolution

Fix typos in SE-0309

 func test(_ collection: RandomAccessCollection) { ``` ___ -This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value iff the following criteria hold:+This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value if and only if the following criteria hold: * The type of the invoked member (accessor — for storage declarations), as viewed in context of the *base type*, must **not** contain references to `Self` or `Self`-rooted associated types in [non-covariant](https://en.wikipedia.org/wiki/Covariance_and_contravariance_(computer_science)) position.

Awesome, added it to the changes :)

hybridcattt

comment created time in an hour

Pull request review commentapple/swift-evolution

Fix typos in SE-0309

 func test(_ collection: RandomAccessCollection) { ``` ___ -This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value iff the following criteria hold:+This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value if the following criteria hold:

Thank you!

hybridcattt

comment created time in an hour

Pull request review commentapple/swift-evolution

Fix typos in SE-0309

 func test(_ collection: RandomAccessCollection) { ``` ___ -This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value iff the following criteria hold:+This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value if and only if the following criteria hold: * The type of the invoked member (accessor — for storage declarations), as viewed in context of the *base type*, must **not** contain references to `Self` or `Self`-rooted associated types in [non-covariant](https://en.wikipedia.org/wiki/Covariance_and_contravariance_(computer_science)) position.

Your suggestion looks fine to me!

hybridcattt

comment created time in an hour

pull request commentapple/swift

Prevent arbitrary objects from conforming to RNG.

@swift-ci please test linux

stephentyrone

comment created time in an hour

Pull request review commentapple/swift-evolution

Fix typos in SE-0309

 func test(_ collection: RandomAccessCollection) { ``` ___ -This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value iff the following criteria hold:+This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value if and only if the following criteria hold: * The type of the invoked member (accessor — for storage declarations), as viewed in context of the *base type*, must **not** contain references to `Self` or `Self`-rooted associated types in [non-covariant](https://en.wikipedia.org/wiki/Covariance_and_contravariance_(computer_science)) position.

While examining this section, I found the sentence structure here a bit hard to parse. I suggest we reverse the wording for easier understanding, which then also mirrors the outlined limitations above

This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value *unless*:
* The type of the invoked member (accessor — for storage declarations), as viewed in context of the *base type*, contains references to `Self` or `Self`-rooted associated types in [non-covariant](https://en.wikipedia.org/wiki/Covariance_and_contravariance_(computer_science)) position.

Feel free to discard this suggestion if you think it's not necessary.

hybridcattt

comment created time in 3 hours

PR opened apple/swift-syntax

Make tokens public

Waiting for #268 to be merged

+127 -127

0 comment

2 changed files

pr created time in 3 hours

Pull request review commentapple/swift-evolution

Fix typos in SE-0309

 func test(_ collection: RandomAccessCollection) { ``` ___ -This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value iff the following criteria hold:+This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value if the following criteria hold:

Updated to use the spelled out version. From the context it seems intentional and not a typo.

hybridcattt

comment created time in 3 hours

Pull request review commentapple/swift-syntax

Add Buildable gyb

+%{+  from gyb_syntax_support import *+  from gyb_syntax_support.kinds import lowercase_first_word+  from gyb_syntax_support.kinds import SYNTAX_BASE_KINDS+  # -*- mode: Swift -*-+  # Ignore the following admonition it applies to the resulting .swift file only++  def syntax_buildable_child_type(syntax_kind, is_token=False, is_optional=False):+    if syntax_kind in SYNTAX_BASE_KINDS:+      buildable_type = syntax_kind + 'Buildable'+    elif not is_token:+      buildable_type = syntax_kind+    elif 'List' in syntax_kind:+      buildable_type = syntax_kind + 'Syntax'+    else:+      buildable_type = 'TokenSyntax'++    if is_optional:+      buildable_type += '?'++    return buildable_type+}%+//// Automatically Generated From DeclBuildables.swift.gyb.+//===----------------------------------------------------------------------===//+//+// This source file is part of the Swift.org open source project+//+// Copyright (c) 2014 - 2021 Apple Inc. and the Swift project authors+// Licensed under Apache License v2.0 with Runtime Library Exception+//+// See https://swift.org/LICENSE.txt for license information+// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors+//+//===----------------------------------------------------------------------===//++import SwiftSyntax++// MARK: Protocols++% for kind in SYNTAX_BASE_KINDS:+%   if kind != 'SyntaxCollection':+%     build_kind = 'Syntax' if kind == 'Syntax' else kind + 'Syntax'+%     if kind == 'Syntax':+public protocol ${kind}ListBuildable {+%     else:+public protocol ${kind}ListBuildable: SyntaxListBuildable {+%     end+  func build${kind}List(format: Format, leadingTrivia: Trivia?) -> [${build_kind}]

Would some documentation like this help?

  /// Builds list of `${kind}`s
  /// - Parameter format: The `Format` to use.
  /// - Parameter leadingTrivia: Replaces the the last leading trivia if not nil.
kimdv

comment created time in 3 hours

pull request commentapple/swift

[cmake] [unittests] include googletest headers to Xcode project header search paths

Hum, interesting ... this could potentially fix the problem people were having https://forums.swift.org/t/gtest-gtest-h-not-found-in-typeref-cpp-while-compiling-the-compiler/44399 ?

rollmind

comment created time in 3 hours

push eventapple/swift

Luciano Almeida

commit sha ddeb1929c47b4ac5f88473ce36471941ffbbb4b2

[DiagnosticQol][SR-14505] Use DeclDescriptive kind in missing return data flow diagnostics (#36952) * [Diagnostics] Use DeclDescriptiveKind on data flow diagnostics to improve diagnostic message * [tests] Add regression tests to SILOptimizer/return.swift * [tests] Adapt other tests to changes of SR-14505 * [Diagnostics] Adapt message for missing return diagnostics, remove article * [Diagnostics] Adapt message for missing return diagnostics to have a note with fix * [tests] Adjust tests in validation suit

view details

swift_jenkins

commit sha 752948a9fe6b291aa86f2e9010c14997a7c6ed9d

Merge remote-tracking branch 'origin/main' into next

view details

push time in 3 hours

push eventapple/swift-syntax

Kim de Vos

commit sha 87b17c3512b18dcbed6a49749dec669aebf22ebd

Fix typo

view details

Alex Hoppen

commit sha 2ce4a331f948aaff6febdc9c9f0a082b85dbebb8

Merge pull request #275 from kimdv/kimdv/fix-typo Fix typo

view details

push time in 3 hours

PR merged apple/swift-syntax

Fix typo

Fixes a small typo

+192 -192

2 comments

2 changed files

kimdv

pr closed time in 3 hours

push eventapple/swift

Luciano Almeida

commit sha ddeb1929c47b4ac5f88473ce36471941ffbbb4b2

[DiagnosticQol][SR-14505] Use DeclDescriptive kind in missing return data flow diagnostics (#36952) * [Diagnostics] Use DeclDescriptiveKind on data flow diagnostics to improve diagnostic message * [tests] Add regression tests to SILOptimizer/return.swift * [tests] Adapt other tests to changes of SR-14505 * [Diagnostics] Adapt message for missing return diagnostics, remove article * [Diagnostics] Adapt message for missing return diagnostics to have a note with fix * [tests] Adjust tests in validation suit

view details

push time in 3 hours

PR merged apple/swift

[DiagnosticQol][SR-14505] Use DeclDescriptive kind in missing return data flow diagnostics

<!-- What's in this pull request? --> Separate closure and declaration on diagnoseMissingReturn data flow diagnostics and use better descriptive naming.

<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: --> Resolves SR-14505.

<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci

Thank you for your contribution to Swift! -->

+124 -58

11 comments

9 changed files

LucianoPAlmeida

pr closed time in 3 hours

pull request commentapple/swift

[cmake] [unittests] include googletest headers to Xcode project header search paths

@varungandhi-apple check please, and thank you.

rollmind

comment created time in 3 hours

PR opened apple/swift

[cmake] [unittests] include googletest headers to Xcode project header search paths

add target include directories on AddSwiftUnittests.cmake module. currently generated Xcode project doesn't include googletest headers after https://reviews.llvm.org/D86616

+3 -0

0 comment

1 changed file

pr created time in 3 hours

Pull request review commentapple/swift

[DNM] Lift the 'Self or associated type' restriction

 bool ASTContext::isASCIIString(StringRef s) const {   }   return true; }++/// Classify usages of Self in the given type.+///+/// \param position The position we are currently at, in terms of variance.+static SelfReferenceInfo+findExistentialSelfReferences(GenericSignature existentialSig, Type type,+                              SelfReferencePosition position) {+  // If there are no type parameters, we're done.+  if (!type->hasTypeParameter())+    return SelfReferenceInfo();++  // Tuples preserve variance.+  if (auto tuple = type->getAs<TupleType>()) {+    auto info = SelfReferenceInfo();+    for (auto &elt : tuple->getElements()) {+      info |= findExistentialSelfReferences(existentialSig, elt.getType(),+                                            position);+    }++    // A covariant Self result inside a tuple will not be bona fide.+    info.hasCovariantSelfResult = false;++    return info;+  }++  // Function preserve variance in the result type, and flip variance in+  // the parameter type.+  if (auto funcTy = type->getAs<AnyFunctionType>()) {+    auto inputInfo = SelfReferenceInfo();+    for (auto param : funcTy->getParams()) {+      // inout parameters are invariant.+      if (param.isInOut()) {+        inputInfo |=+            findExistentialSelfReferences(existentialSig, param.getPlainType(),+                                          SelfReferencePosition::Invariant);+        continue;+      }+      inputInfo |= findExistentialSelfReferences(+          existentialSig, param.getParameterType(), position.flipped());+    }++    // A covariant Self result inside a parameter will not be bona fide.+    inputInfo.hasCovariantSelfResult = false;++    auto resultInfo = findExistentialSelfReferences(+        existentialSig, funcTy->getResult(), position);+    if (resultInfo.selfRef == SelfReferencePosition::Covariant) {+      resultInfo.hasCovariantSelfResult = true;+    }+    return inputInfo |= resultInfo;+  }++  // Metatypes preserve variance.+  if (auto metaTy = type->getAs<MetatypeType>()) {+    return findExistentialSelfReferences(existentialSig,+                                         metaTy->getInstanceType(), position);+  }++  // Optionals preserve variance.+  if (auto optType = type->getOptionalObjectType()) {+    return findExistentialSelfReferences(existentialSig, optType, position);+  }++  // DynamicSelfType preserves variance.+  // FIXME: This shouldn't ever appear in protocol requirement+  // signatures.+  if (auto selfType = type->getAs<DynamicSelfType>()) {+    return findExistentialSelfReferences(existentialSig,+                                         selfType->getSelfType(), position);+  }++  // Bound generic types are invariant.+  if (auto boundGenericType = type->getAs<BoundGenericType>()) {

Special-case covariance is already implemented on the main branch. This branch needs a rebase.

theblixguy

comment created time in 4 hours

pull request commentapple/swift

[SourceKit] Add locations for symbols in external modules

Artem ended up making it compile-able in older compilers, so should hopefully work this time 🤞

@swift-ci please build toolchain macOS platform

bnbarham

comment created time in 4 hours

Pull request review commentapple/swift-evolution

Fix typos in SE-0309

 func test(_ collection: RandomAccessCollection) { ``` ___ -This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value iff the following criteria hold:+This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value if the following criteria hold:

"iff" was removed from public API documentation: apple/swift#27115

hybridcattt

comment created time in 4 hours

Pull request review commentapple/swift-evolution

Fix typos in SE-0309

 func test(_ collection: RandomAccessCollection) { ``` ___ -This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value iff the following criteria hold:+This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value if the following criteria hold:

TIL - I've never seen it shortened like that before (having studied math in another language). Would you agree that it'd be clearer, if it's spelled out fully?

hybridcattt

comment created time in 4 hours

Pull request review commentapple/swift-syntax

Add Buildable gyb

+%{+  from gyb_syntax_support import *+  from gyb_syntax_support.kinds import lowercase_first_word+  from gyb_syntax_support.kinds import SYNTAX_BASE_KINDS+  # -*- mode: Swift -*-+  # Ignore the following admonition it applies to the resulting .swift file only++  def syntax_buildable_child_type(type_name, syntax_kind, is_token, is_optional=False):+    if syntax_kind in SYNTAX_BASE_KINDS:+      buildable_type = syntax_kind + 'Buildable'+    elif not is_token:+      buildable_type = syntax_kind+    else:+      buildable_type = type_name++    if is_optional:+      buildable_type += '?'++    return buildable_type+}%+//// Automatically Generated From DeclBuildables.swift.gyb.+//===----------------------------------------------------------------------===//+//+// This source file is part of the Swift.org open source project+//+// Copyright (c) 2014 - 2021 Apple Inc. and the Swift project authors+// Licensed under Apache License v2.0 with Runtime Library Exception+//+// See https://swift.org/LICENSE.txt for license information+// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors+//+//===----------------------------------------------------------------------===//++import SwiftSyntax++// MARK: Protocols++% for kind in SYNTAX_BASE_KINDS:+%   if kind != 'SyntaxCollection':+%     build_kind = 'Syntax' if kind == 'Syntax' else kind + 'Syntax'+%     if kind == 'Syntax':+public protocol ${kind}ListBuildable {+%     else:+public protocol ${kind}ListBuildable: SyntaxListBuildable {+%     end+  func build${kind}List(format: Format, leadingTrivia: Trivia?) -> [${build_kind}]+}++%     if kind == 'Syntax':+public protocol ${kind}Buildable: ${kind}ListBuildable {+%     else:+public protocol ${kind}Buildable: SyntaxBuildable, ${kind}ListBuildable {+%     end+  func build${kind}(format: Format, leadingTrivia: Trivia?) -> ${build_kind}+}++extension ${kind}Buildable {+%     if kind != 'Syntax':+  func build${kind}(format: Format) -> ${build_kind} {+    build${kind}(format: format, leadingTrivia: nil)+  }+%     end+  public func buildSyntax(format: Format) -> Syntax {+    buildSyntax(format: format, leadingTrivia: nil)+  }++  public func buildSyntax(format: Format, leadingTrivia: Trivia?) -> Syntax {+    Syntax(build${kind}(format: format, leadingTrivia: leadingTrivia))+  }++  public func build${kind}List(format: Format) -> [${build_kind}] {+    build${kind}List(format: format, leadingTrivia: nil)+  }++  public func build${kind}List(format: Format, leadingTrivia: Trivia?) -> [${build_kind}] {+    [build${kind}(format: format, leadingTrivia: leadingTrivia)]+  }+}++%   end+% end++// MARK: - Buildables++% for node in SYNTAX_NODES:+%   if node.is_buildable():+public struct ${node.syntax_kind}: ${node.base_kind}Buildable {

Will do it another.

kimdv

comment created time in 4 hours

pull request commentapple/swift-syntax

Add Buildable gyb

Let’s see what CI has to say about this.

https://github.com/apple/swift/pull/36726

@swift-ci Please test

kimdv

comment created time in 5 hours

Pull request review commentapple/swift-syntax

Add Buildable gyb

+import XCTest+import SwiftSyntax+import SwiftSyntaxBuilder++final class EnumCaseElementTests: XCTestCase {+  func test_enumCaseElementInit() {+    let leadingTrivia = Trivia.garbageText("␣")+    let string = SyntaxFactory.makeStringSegment("Hello World")+    let segment = StringSegment(content: string)+    let segments = StringLiteralSegments([segment])++    let stringLiteralExpr: ExprBuildable = StringLiteralExpr(openDelimiter: nil,+                                                             openQuote: SyntaxFactory.makeStringQuoteToken(),

Let’s put it in a follow-up PR before any more discussions about it come up, complicating this PR even further.

kimdv

comment created time in 5 hours