profile
viewpoint

bastilian/atom-packages.directory 27

Current Source Code to build http://atom-packages.directory (Possibly a future version here: https://github.com/bastilian/AtomPackagesDirectory)

bastilian/antitheme 6

Theme for Ghost

bastilian/fluxapi 4

Ruby Fluxiom API wrapper

bastilian/basecamp_notify 1

Simple Capistrano plugin to post a Basecamp message for each deploy listing the git commit messages that happened since the last deploy

bastilian/ansible 0

Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/

bastilian/attachment_fu 0

Treat an ActiveRecord model as a file attachment, storing its patch, size, content type, etc.

bastilian/awesome-mac 0

 Now we have become very big, Different from the original idea. Collect premium software in various categories.

bastilian/cockpit-podman 0

Cockpit UI for podman containers

bastilian/community-templates 0

A place to share templates for various OSes for Foreman's provisioning

push eventRedHatInsights/compliance-backend

Josef Hák

commit sha 1dc32d14f4e85855e72043b7df103f1cf6fbfa3e

moved grafana board configmap from saas-templates (#588)

view details

push time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentRedHatInsights/frontend-components

[RHICOMPL-859][RHICOMPL-955] Improve compliance policy card labels and tooltip

 class SystemPolicyCard extends React.Component {                         </Tooltip> }                     </TextContent>                     <div className='margin-bottom-md' >-                        <Tooltip content={-                            'The system compliance score is calculated by OpenSCAP and ' +-                            'is a normalized weighted sum of rules selected for this policy.'-                        }>-                            { this.complianceIcon(compliant) }-                            <Text component={ TextVariants.small }>-                                { rulesPassed } of { rulesPassed + rulesFailed } rules passed ({ passedPercentage })-                            </Text>-                        </Tooltip>+                        { this.complianceIcon(compliant) }+                        <Text component={ TextVariants.small }>+                            { rulesFailed } rule{ rulesFailed === 1 ? '' : 's' } failed+                            { " " }

I'd prefer just adding a space to the span at the bottom. It doesn't need to be precise. And it only marginally, about 1,5px, skews the position.

Behaviour around preserving space in JSX has been changing over time so I'd avoid it.

vkrizan

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentRedHatInsights/frontend-components

[RHICOMPL-859][RHICOMPL-955] Improve compliance policy card labels and tooltip

 class SystemPolicyCard extends React.Component {                         </Tooltip> }                     </TextContent>                     <div className='margin-bottom-md' >-                        <Tooltip content={-                            'The system compliance score is calculated by OpenSCAP and ' +-                            'is a normalized weighted sum of rules selected for this policy.'-                        }>-                            { this.complianceIcon(compliant) }-                            <Text component={ TextVariants.small }>-                                { rulesPassed } of { rulesPassed + rulesFailed } rules passed ({ passedPercentage })-                            </Text>-                        </Tooltip>+                        { this.complianceIcon(compliant) }+                        <Text component={ TextVariants.small }>+                            { rulesFailed } rule{ rulesFailed === 1 ? '' : 's' } failed+                            { " " }+                            <Tooltip+                                position='bottom'

The maxWidth should be set to make the content fit into 3 lines and not have policy in a single line as mentioned in the Jira

vkrizan

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentRedHatInsights/frontend-components

[RHICOMPL-859][RHICOMPL-955] Improve compliance policy card labels and tooltip

 class SystemPolicyCard extends React.Component {                         </Tooltip> }                     </TextContent>                     <div className='margin-bottom-md' >-                        <Tooltip content={-                            'The system compliance score is calculated by OpenSCAP and ' +-                            'is a normalized weighted sum of rules selected for this policy.'-                        }>-                            { this.complianceIcon(compliant) }-                            <Text component={ TextVariants.small }>-                                { rulesPassed } of { rulesPassed + rulesFailed } rules passed ({ passedPercentage })-                            </Text>-                        </Tooltip>+                        { this.complianceIcon(compliant) }+                        <Text component={ TextVariants.small }>+                            { rulesFailed } rule{ rulesFailed === 1 ? '' : 's' } failed+                            { " " }

It doesn't hurt if it is also triggered on that space. Makes the target bigger. ;)

vkrizan

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentRedHatInsights/frontend-components

[RHICOMPL-859][RHICOMPL-955] Improve compliance policy card labels and tooltip

 class SystemPolicyCard extends React.Component {                         </Tooltip> }                     </TextContent>                     <div className='margin-bottom-md' >-                        <Tooltip content={-                            'The system compliance score is calculated by OpenSCAP and ' +-                            'is a normalized weighted sum of rules selected for this policy.'-                        }>-                            { this.complianceIcon(compliant) }-                            <Text component={ TextVariants.small }>-                                { rulesPassed } of { rulesPassed + rulesFailed } rules passed ({ passedPercentage })-                            </Text>-                        </Tooltip>+                        { this.complianceIcon(compliant) }+                        <Text component={ TextVariants.small }>+                            { rulesFailed } rule{ rulesFailed === 1 ? '' : 's' } failed+                            { " " }

Shorter than a ?

vkrizan

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentRedHatInsights/frontend-components

[RHICOMPL-859][RHICOMPL-955] Improve compliance policy card labels and tooltip

 class SystemPolicyCard extends React.Component {                         </Tooltip> }                     </TextContent>                     <div className='margin-bottom-md' >-                        <Tooltip content={-                            'The system compliance score is calculated by OpenSCAP and ' +-                            'is a normalized weighted sum of rules selected for this policy.'-                        }>-                            { this.complianceIcon(compliant) }-                            <Text component={ TextVariants.small }>-                                { rulesPassed } of { rulesPassed + rulesFailed } rules passed ({ passedPercentage })-                            </Text>-                        </Tooltip>+                        { this.complianceIcon(compliant) }+                        <Text component={ TextVariants.small }>+                            { rulesFailed } rule{ rulesFailed === 1 ? '' : 's' } failed+                            { " " }

This is not needed. Just use a space within the span It should be preserved and not ignored when rendering.

vkrizan

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentRedHatInsights/frontend-components

[RHICOMPL-859][RHICOMPL-955] Improve compliance policy card labels and tooltip

 class SystemPolicyCard extends React.Component {     }      render() {-        const { policy, benchmark, rulesPassed, rulesFailed, compliant, lastScanned, score } = this.state.policy;+        const { policy, benchmark, _, rulesFailed, compliant, lastScanned, score } = this.state.policy;

Why the _? If it's not used don't assign it. ;)

vkrizan

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentRedHatInsights/frontend-components

[RHICOMPL-859][RHICOMPL-955] Improve compliance policy card labels and tooltip

 exports[`CullingInformation it should render correctly without any date 1`] = ` <Fragment>   <Tooltip-    content="System scheduled for inventory removal in -18297 days"+    content="System scheduled for inventory removal in -18296 days"

This will probably cause TravisCI to fail. Better not commit this.

vkrizan

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentRedHatInsights/frontend-components

[RHICOMPL-859][RHICOMPL-955] Improve compliance policy card labels and tooltip

 class SystemPolicyCard extends React.Component {                         </Tooltip> }                     </TextContent>                     <div className='margin-bottom-md' >-                        <Tooltip content={-                            'The system compliance score is calculated by OpenSCAP and ' +-                            'is a normalized weighted sum of rules selected for this policy.'-                        }>-                            { this.complianceIcon(compliant) }-                            <Text component={ TextVariants.small }>-                                { rulesPassed } of { rulesPassed + rulesFailed } rules passed ({ passedPercentage })-                            </Text>-                        </Tooltip>+                        { this.complianceIcon(compliant) }+                        <Text component={ TextVariants.small }>+                            { rulesFailed } rule{ rulesFailed == 1 ? '' : 's' } failed

You could write this as { rulesFailed != 1 && 's' }

vkrizan

comment created time in 3 days

push eventRedHatInsights/compliance-frontend

Viliam Krizan

commit sha 6dd19eab1098c8b6395c2e7c031a77e48257bf9d

[RHICOMPL-732] Default to failed rules on systems detail page Note, that the `useLocation().query` from React Router no longer works.

view details

Sebastian Gräßl

commit sha 08d88b2d6ff3177775c17a014f9c99c8b161a75d

Bump @redhat-cloud-services/frontend-components-inventory-compliance to 2.2.6 (#764)

view details

push time in 3 days

push eventRedHatInsights/compliance-frontend

Viliam Krizan

commit sha 6dd19eab1098c8b6395c2e7c031a77e48257bf9d

[RHICOMPL-732] Default to failed rules on systems detail page Note, that the `useLocation().query` from React Router no longer works.

view details

Sebastian Gräßl

commit sha 08d88b2d6ff3177775c17a014f9c99c8b161a75d

Bump @redhat-cloud-services/frontend-components-inventory-compliance to 2.2.6 (#764)

view details

push time in 3 days

push eventRedHatInsights/compliance-frontend

Karel Hala

commit sha f7fad51d894bf6a5a6e338c72c77a105cc50628a

Mark systems table as full view (#766)

view details

push time in 3 days

PR merged RedHatInsights/compliance-frontend

[RHICOMPL-974] Mark systems table as full view

Inventory full view [1]

In order to show proper RBAC state in systems table we need to pass fullView prop to inventory component. This applies only to systems page as it's the only place where inventory table is just one component on screen. Without this prop the unAuthorized component would be in table, which is not correct based on our mocks.

[1] https://github.com/RedHatInsights/frontend-components/blob/master/packages/inventory/doc/inventory.md#using-rbac-with-inventory

+11 -3

1 comment

2 changed files

karelhala

pr closed time in 3 days

PullRequestReviewEvent

Pull request review commentRedHatInsights/frontend-components

Idea for running locally

 These tasks are preconfigured  To test changes from packages in this repository in other applications follow these steps: -1. Run `npm install` in the root of the `frontend-components` working copy-2. Remove `react` and `react-dom` from `node_modules`-  ```-  rm -rf node_modules/react; rm -rf node_modules/react-dom-  ```-  This is because we want to use hooks and different reacts are not playing nicely with hooks [facebook/react/issues/15315](https://github.com/facebook/react/issues/15315)--3. Link `react` and `react-dom` from your application. Running from folder that contains your application and frontend components. Running `ls` in this folder would yield `<application-folder>  insights-proxy  frontend-components`-```-ln -s $PWD/<application-folder>/node_modules/react frontend-components/node_modules/react-ln -s $PWD/<application-folder>/node_modules/react-dom frontend-components/node_modules/react-dom-```--4. Change into the directory of the package you are working on, for example `cd packages/components` and run `npm link`*-5. Change into the directory of the application you'd like to include the package and run `npm link @redhat-cloud-services/frontend-components`*+1. Install [yalc](https://github.com/whitecolor/yalc) globally. e.g. `npm install -g yalc`.+2. Run `npm install` in the root of the `frontend-components` working copy.+3. Change into the directory of the package you are working on, for example `cd packages/components` and run `yalc publish`*

The yalc publish documentation mentions it will "copy" assets that would normally be pushed, does this mean that publish needs to be run anytime assets are rebuilt when running rpm start?

josejulio

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentRedHatInsights/compliance-backend

[RHICOMPL-965] Fix remediation import for rules w/o canonical profile

 def remediation_issue_id   private    def short_profile_ref_id-    profile = profiles.canonical.first-    short_ref_id = profile.ref_id.downcase.split(+    profile_ref_ids = profiles.collect(&:ref_id).to_set

+1

vkrizan

comment created time in 4 days

Pull request review commentRedHatInsights/compliance-backend

[RHICOMPL-965] Fix remediation import for rules w/o canonical profile

 def remediation_issue_id   private    def short_profile_ref_id-    profile = profiles.canonical.first-    short_ref_id = profile.ref_id.downcase.split(+    profile_ref_ids = profiles.collect(&:ref_id).to_set

Why not use .uniq.first instead of transforming it to a set? collect should already return an array.

vkrizan

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentRedHatInsights/compliance-backend

[RHICOMPL-965] Fix remediation import for rules w/o canonical profile

 def remediation_issue_id   private    def short_profile_ref_id-    profile = profiles.canonical.first-    short_ref_id = profile.ref_id.downcase.split(+    profile_ref_ids = profiles.collect(&:ref_id).to_set

Why not use a [0] at the end and assign only one ref_id as profile_ref_id?

If it's nil it can raise the error and it would avoid the .first.

Or am I missing something?

vkrizan

comment created time in 4 days

PullRequestReviewEvent

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 08d88b2d6ff3177775c17a014f9c99c8b161a75d

Bump @redhat-cloud-services/frontend-components-inventory-compliance to 2.2.6 (#764)

view details

push time in 5 days

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 08d88b2d6ff3177775c17a014f9c99c8b161a75d

Bump @redhat-cloud-services/frontend-components-inventory-compliance to 2.2.6 (#764)

view details

push time in 5 days

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 08d88b2d6ff3177775c17a014f9c99c8b161a75d

Bump @redhat-cloud-services/frontend-components-inventory-compliance to 2.2.6 (#764)

view details

push time in 5 days

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 08d88b2d6ff3177775c17a014f9c99c8b161a75d

Bump @redhat-cloud-services/frontend-components-inventory-compliance to 2.2.6 (#764)

view details

push time in 5 days

push eventRedHatInsights/compliance-frontend

Viliam Krizan

commit sha 6dd19eab1098c8b6395c2e7c031a77e48257bf9d

[RHICOMPL-732] Default to failed rules on systems detail page Note, that the `useLocation().query` from React Router no longer works.

view details

push time in 5 days

push eventRedHatInsights/compliance-frontend

Viliam Krizan

commit sha 6dd19eab1098c8b6395c2e7c031a77e48257bf9d

[RHICOMPL-732] Default to failed rules on systems detail page Note, that the `useLocation().query` from React Router no longer works.

view details

push time in 5 days

push eventRedHatInsights/compliance-frontend

Viliam Krizan

commit sha 6dd19eab1098c8b6395c2e7c031a77e48257bf9d

[RHICOMPL-732] Default to failed rules on systems detail page Note, that the `useLocation().query` from React Router no longer works.

view details

push time in 5 days

push eventRedHatInsights/compliance-frontend

Viliam Krizan

commit sha 6dd19eab1098c8b6395c2e7c031a77e48257bf9d

[RHICOMPL-732] Default to failed rules on systems detail page Note, that the `useLocation().query` from React Router no longer works.

view details

push time in 5 days

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 08d88b2d6ff3177775c17a014f9c99c8b161a75d

Bump @redhat-cloud-services/frontend-components-inventory-compliance to 2.2.6 (#764)

view details

push time in 5 days

push eventbastilian/compliance-frontend

Viliam Krizan

commit sha 6dd19eab1098c8b6395c2e7c031a77e48257bf9d

[RHICOMPL-732] Default to failed rules on systems detail page Note, that the `useLocation().query` from React Router no longer works.

view details

Sebastian Gräßl

commit sha af8fc091f7f1866b35258951c171743a893739c1

Bump @redhat-cloud-services/frontend-components-inventory-compliance to 2.2.6

view details

push time in 5 days

create barnchbastilian/compliance-frontend

branch : bump_inventory_compliance_2

created branch time in 5 days

push eventRedHatInsights/frontend-components

Sebastian Gräßl

commit sha 2496f5cf82f0d7f4d09cdf3765280b6ca9e54cea

[RHICOMPL-732] Values for radio filters aren't arrays

view details

Sebastian Gräßl

commit sha f4682bb67181f0a5822209bcee4c1de9521d9a23

Merge pull request #744 from bastilian/732 [RHICOMPL-732] Values for radio filters aren't arrays

view details

push time in 5 days

PR merged RedHatInsights/frontend-components

[RHICOMPL-732] Values for radio filters aren't arrays release

When enabling hidePassed the filter value needs to be a single one and not an array.

+1 -1

0 comment

1 changed file

bastilian

pr closed time in 5 days

PullRequestReviewEvent

push eventbastilian/frontend-components

Karel Hala

commit sha 2c2af5218bcf54f6d0829be713bf5e056b58713a

Allow custom filters to be passed from parent

view details

Karel Hala

commit sha cdc4cdd45df48be6f878afb7b27a3c908e3b7916

Merge branch 'master' into inventory-custom-filters

view details

Martin Maroši

commit sha 96d6ceb4aae501165dea7c059d47e404aee89313

Merge pull request #734 from karelhala/inventory-custom-filters Allow custom filters to be passed from parent

view details

Sebastian Gräßl

commit sha 2496f5cf82f0d7f4d09cdf3765280b6ca9e54cea

[RHICOMPL-732] Values for radio filters aren't arrays

view details

push time in 5 days

PullRequestReviewEvent

pull request commentRedHatInsights/compliance-frontend

[RHICOMPL-732] Default to failed rules on systems detail page

@akofink @vkrizan The issue with the wrong label and weird behaviour should be fixed with this: https://github.com/RedHatInsights/frontend-components/pull/744

vkrizan

comment created time in 5 days

PR opened RedHatInsights/frontend-components

[RHICOMPL-732] Values for radio filters aren't arrays

When enabling hidePassed the filter value needs to be a single one and not an array.

+1 -1

0 comment

1 changed file

pr created time in 5 days

create barnchbastilian/frontend-components

branch : 732

created branch time in 5 days

push eventbastilian/frontend-components

Richard Vsiansky

commit sha 4a27cc9c7ff0ef130047376bba847f6ba9c08f0f

Rename billing_source.bucket to billing_source.data_source.bucket

view details

Richard Všianský

commit sha 1abe97ad03d7912a200d3a1af0e86091b781ee71

Merge pull request #729 from rvsia/renameBucket Rename billing_source.bucket to billing_source.data_source.bucket

view details

Karel Hala

commit sha 2dc781713b354baf7e00f093f4d0fabb2b27c01f

Fix inventory drawer issues (#723) * Fix inventory drawer issues * Hide edit buttons in drawer

view details

Karel Hala

commit sha 60587fd53575cd443c4412acd992f9ba9c7c5279

Fire filter changes only after data are loaded (#731) * Fire filter changes only after data are loaded * Use constant to hold the refresh value

view details

Robin Knaur

commit sha fb171408e0f5dc1d833efce9ec88a8b3093b6c45

Add filename hashing (#730) Co-authored-by: Karel Hala <khala@redhat.com>

view details

Filip Hlavac

commit sha 9e6ea621a9959d6fa3397f0c08932c73594aebfb

Add scrolling and enhance "See more" in Conditional Filter (#704) * Update CF showMore and scrolling * Update snapshots * Remove styling for cond. filter options scrolling Co-authored-by: Karel Hala <khala@redhat.com>

view details

Alexander Rivera

commit sha e0808ccb7fe27631e7c1d0a1705610f209a049fb

Fully working Error Component (#732) * Fully working errorstate * addressing pr requests * 2nd pass * cleaning defaultMessage * clean linting * cleaner Co-authored-by: Alexander Rivera <hq@aleriver@redhat.com-mac> Co-authored-by: Karel Hala <khala@redhat.com>

view details

Richard Vsiansky

commit sha d0bdae06f734d89b68f711ec06929bf7ce22830c

Remove S3 Bucket from review when cost is no selected - just updating of tests

view details

Martin Maroši

commit sha 9983b394fdca78cbe3681b9016c1c586a4992bea

Merge pull request #733 from rvsia/testRemovedS3BucketFromARN Remove S3 Bucket from review when cost is not selected

view details

Karel Hala

commit sha 531dcd6fc6726f2e5fdec674eadd189d57ed5c30

Do not fire refresh on mount if custom refresh is present (#735)

view details

Robin Knaur

commit sha d6696fa2e489bc2b24c06469417ea1f067f5bc32

Spacing in platform toolbar (#647) * Use new version of Patternfly * Import Patternfly styles * Remove redudant spacing in Toolbar * Change spacing between search and button in toolbar * Update snapshots * Add chip groups spacing

view details

Karel Hala

commit sha 2199ad5ed680278018020dc2e1acd450be9cdc6d

Add information about linking react and react-dom (#736) * Add information about linking react and react-dom * Add few more info to README

view details

Karel Hala

commit sha 9c7439dfa2df5869e10840488ff82aa40bf93d72

Introduce labels to pie chart

view details

Karel Hala

commit sha 609a5dd4dd939f4bfbeecc62d9a30bf7f1054afb

Fix does have permission by using permission if given

view details

Karel Hala

commit sha 85bb0eb342d811a10746d2d5419bd49c3980e063

Remove return statement

view details

Richard Všianský

commit sha 89a7d19b23885eaaf3044429202780ff27db7e51

Merge pull request #739 from karelhala/proper-have-permissions Fix does have permission by using permission if given

view details

Richard Všianský

commit sha d93d53b64b0d871f0a9e16667504c515272e513f

Merge branch 'master' into introduce-labels

view details

Richard Vsiansky

commit sha 9b7a3b7a261b5a3e031ff9e5d8e9b47891e2bb84

Make Ansible URL field consistent

view details

Martin Maroši

commit sha 23c0fb64e747edb07abaecc1c1ff807a32df97f2

Merge pull request #738 from karelhala/introduce-labels Introduce labels to pie chart

view details

Martin Maroši

commit sha be9c9f61409f2bcb5fe5404adf61b51beccdf8ae

Merge branch 'master' into makeAnsibleURLConsistent

view details

push time in 5 days

Pull request review commentRedHatInsights/compliance-frontend

[RHICOMPL-732] Default to failed rules on systems detail page

 export const SystemDetails = () => {     const { data, error, loading } = useQuery(QUERY, {         variables: { inventoryId }     });-    const location = useLocation();-    const hidePassed = location.query && location.query.hidePassed;

We shouldn't have to worry about that at all anymore. This seems to have been introduced a while back before there were proper filters: https://github.com/RedHatInsights/compliance-frontend/pull/90

vkrizan

comment created time in 6 days

PullRequestReviewEvent

pull request commentRedHatInsights/compliance-frontend

[RHICOMPL-732] Default to failed rules on systems detail page

@vkrizan There seems to be an issue with the filter/chip building. That's why you also see just "passed" or "failed" instead of the full correct label. I'm looking into that.

vkrizan

comment created time in 6 days

PullRequestReviewEvent

Pull request review commentRedHatInsights/compliance-frontend

[RHICOMPL-732] Default to failed rules on systems detail page

 export const SystemDetails = () => {                 <br/>             </PageHeader>             <Main>-                <ComplianceSystemDetails hidePassed={ hidePassed } inventoryId={ inventoryId } />+                <ComplianceSystemDetails hidePassed={ true } inventoryId={ inventoryId } />

hidePassed={ true } can be just hidePassed without explicitly setting it to true. React will assume it to be true if it is set.

vkrizan

comment created time in 6 days

PR opened jaywcjlove/awesome-mac

Add Nova text editor

NOTE: A similar PR may already be submitted! Please search among the Pull request before creating one.

Types of Changes

What types of changes does your PR introduce? Put an x in all boxes that apply

  • [x] New addition to list
  • [ ] Fixing bug in existing item in list
  • [ ] Removing item from list
  • [ ] Changing structure (organization) of list

Proposed Changes

Nova is the new, somewhat successor of Coda.

PR Checklist

Put an x in the boxes once you've completed each step. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x] I have read the CONTRIBUTING guide
  • [x] I have explained why this PR is important
  • [x] I have added necessary documentation (if appropriate)
+1 -0

0 comment

1 changed file

pr created time in 7 days

push eventbastilian/awesome-mac

Sebastian Gräßl

commit sha 192ccb235af04ae68a563178bae2433348cfc7f0

Add Nova text editor

view details

push time in 7 days

fork bastilian/awesome-mac

 Now we have become very big, Different from the original idea. Collect premium software in various categories.

https://git.io/macx

fork in 7 days

fork bastilian/open-source-mac-os-apps

🚀 Awesome list of open source applications for macOS.

fork in 7 days

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 1a44d154c505eafdad729d8a6f2cf89856800714

[RHICOMPL-777] Bump frontend-components-inventory-compliance

view details

push time in 9 days

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 1a44d154c505eafdad729d8a6f2cf89856800714

[RHICOMPL-777] Bump frontend-components-inventory-compliance

view details

push time in 9 days

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 1a44d154c505eafdad729d8a6f2cf89856800714

[RHICOMPL-777] Bump frontend-components-inventory-compliance

view details

push time in 10 days

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 1a44d154c505eafdad729d8a6f2cf89856800714

[RHICOMPL-777] Bump frontend-components-inventory-compliance

view details

push time in 10 days

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 1a44d154c505eafdad729d8a6f2cf89856800714

[RHICOMPL-777] Bump frontend-components-inventory-compliance

view details

push time in 10 days

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 1a44d154c505eafdad729d8a6f2cf89856800714

[RHICOMPL-777] Bump frontend-components-inventory-compliance

view details

push time in 10 days

PullRequestReviewEvent

PR opened RedHatInsights/compliance-frontend

[RHICOMPL-777] Bump frontend-components-inventory-compliance

See https://github.com/RedHatInsights/frontend-components/pull/737 for changes included in this bump

+23 -4

0 comment

2 changed files

pr created time in 10 days

create barnchbastilian/compliance-frontend

branch : bump_inventory_compliance

created branch time in 10 days

PR closed RedHatInsights/compliance-frontend

Bump @redhat-cloud-services/frontend-components-inventory-compliance from 2.1.6 to 2.2.4 dependencies

Bumps @redhat-cloud-services/frontend-components-inventory-compliance from 2.1.6 to 2.2.4. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/RedHatInsights/frontend-components/commits">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+4 -4

1 comment

2 changed files

dependabot-preview[bot]

pr closed time in 10 days

push eventRedHatInsights/frontend-components

Sebastian Gräßl

commit sha 9ea75a4d2805136f42f0cfbd95ca2714d880c8ac

[RHICOMPL-777] Fix issue with empty state flashing

view details

Sebastian Gräßl

commit sha 2fb1a324622e7bfc5d98108abd9a3d6c69143be3

Merge pull request #737 from bastilian/777 [RHICOMPL-777] Fix issue with empty state flashing

view details

push time in 10 days

PR merged RedHatInsights/frontend-components

[RHICOMPL-777] Fix issue with empty state flashing release

This refactors the Compliance components and fixes the issues with the empty state flashing before/when it is loading.

Before: before

After: after

To test this, please follow the instructions in the README to properly link the package and avoid an error regarding react hooks and multiple versions of react. Additionally, there is an issue caused by the way the packages are linked and built and cause the Remediations button to raise an error(*). To avoid this while testing disable the button:

diff --git a/packages/inventory-compliance/src/SystemRulesTable.js b/packages/inventory-compliance/src/SystemRulesTable.js
index cb737a61..67116ac6 100644
--- a/packages/inventory-compliance/src/SystemRulesTable.js
+++ b/packages/inventory-compliance/src/SystemRulesTable.js
@@ -326,7 +326,7 @@ class SystemRulesTable extends React.Component {
                         ...pagination,
                         dropDirection: 'down'
                     }}>
-                    { remediationsEnabled &&
+                    { false &&
                         <ToolbarItem>
                             <ComplianceRemediationButton
                                 allSystems={ [{ id: system.id, profiles: system.profiles, ruleObjectsFailed: [] }] }

These issues only occur when linking packages locally and building them from source and will not occur once the package has been properly released on npm and installed as a dependency of compliance.

(*) This will be fixed by passing down the redux store.

+46 -68

1 comment

3 changed files

bastilian

pr closed time in 10 days

push eventbastilian/frontend-components

Karel Hala

commit sha 9c7439dfa2df5869e10840488ff82aa40bf93d72

Introduce labels to pie chart

view details

Karel Hala

commit sha 85bb0eb342d811a10746d2d5419bd49c3980e063

Remove return statement

view details

Richard Všianský

commit sha d93d53b64b0d871f0a9e16667504c515272e513f

Merge branch 'master' into introduce-labels

view details

Richard Vsiansky

commit sha 9b7a3b7a261b5a3e031ff9e5d8e9b47891e2bb84

Make Ansible URL field consistent

view details

Martin Maroši

commit sha 23c0fb64e747edb07abaecc1c1ff807a32df97f2

Merge pull request #738 from karelhala/introduce-labels Introduce labels to pie chart

view details

Martin Maroši

commit sha be9c9f61409f2bcb5fe5404adf61b51beccdf8ae

Merge branch 'master' into makeAnsibleURLConsistent

view details

Richard Všianský

commit sha bddbb4a516597010434d709e59f525535930f893

Merge pull request #740 from rvsia/makeAnsibleURLConsistent Make Ansible URL field consistent

view details

Sebastian Gräßl

commit sha 9ea75a4d2805136f42f0cfbd95ca2714d880c8ac

[RHICOMPL-777] Fix issue with empty state flashing

view details

push time in 10 days

Pull request review commentRedHatInsights/compliance-backend

[RHICOMPL-759] Issue updates to Remediation service

 module Xccdf   # Methods related to saving RuleResults from openscap_parser   module RuleResults     def save_rule_results-      @rule_results = selected_op_rule_results.map do |op_rule_result|+      ::RuleResult.import!(rule_results.select(&:new_record?), ignore: true)+    end++    def rule_results+      @rule_results ||= selected_op_rule_results.map do |op_rule_result|

Is this called more often within the process of saving rule results? It might not be necessary to memoize this or even store it in an instance variable.

vkrizan

comment created time in 10 days

PullRequestReviewEvent

pull request commentRedHatInsights/frontend-components

[RHICOMPL-777] Fix issue with empty state flashing

@akofink I also only have the frontend-components-inventory-compliance package linked in the compliance app. Additionally react and react-dom are symlinked from the frontend-components directory back to compliance:

compliance-frontend $ ls -la node_modules/@redhat-cloud-services                                    
total 0
drwxr-xr-x     8 bastilian  staff    256 Sep 16 13:04 .
drwxr-xr-x  1138 bastilian  staff  36416 Sep 16 12:33 ..
drwxr-xr-x     9 bastilian  staff    288 Sep 16 12:14 frontend-components
lrwxr-xr-x     1 bastilian  staff    114 Sep 16 13:04 frontend-components-inventory-compliance -> ../../../../../../../../usr/local/lib/node_modules/@redhat-cloud-services/frontend-components-inventory-compliance
drwxr-xr-x    13 bastilian  staff    416 Sep 16 12:14 frontend-components-notifications
drwxr-xr-x    14 bastilian  staff    448 Sep 16 12:14 frontend-components-remediations
drwxr-xr-x     8 bastilian  staff    256 Sep 16 12:14 frontend-components-utilities
drwxr-xr-x     7 bastilian  staff    224 Sep 16 12:14 host-inventory-client
frontend-components $ ls -la node_modules | grep react                                                                            
drwxr-xr-x     8 bastilian  staff    256 Sep 16 12:55 @react-pdf
drwxr-xr-x    10 bastilian  staff    320 Sep 16 12:53 babel-plugin-react-intl
drwxr-xr-x     9 bastilian  staff    288 Sep 16 12:53 enzyme-adapter-react-16
drwxr-xr-x     8 bastilian  staff    256 Sep 16 12:53 eslint-plugin-react
drwxr-xr-x     9 bastilian  staff    288 Sep 16 12:53 hoist-non-react-statics
drwxr-xr-x    17 bastilian  staff    544 Sep 16 12:53 html-to-react
drwxr-xr-x     6 bastilian  staff    192 Sep 16 12:53 mini-create-react-context
lrwxr-xr-x     1 bastilian  staff     76 Sep 16 13:01 react -> /Users/bastilian/Projects/RedHat/CSfR/compliance-frontend/node_modules/react
drwxr-xr-x    75 bastilian  staff   2400 Sep 16 12:53 react-apollo
drwxr-xr-x     6 bastilian  staff    192 Sep 16 12:53 react-content-loader
lrwxr-xr-x     1 bastilian  staff     80 Sep 16 13:02 react-dom -> /Users/bastilian/Projects/RedHat/CSfR/compliance-frontend/node_modules/react-dom
drwxr-xr-x    19 bastilian  staff    608 Sep 16 12:53 react-dropzone

The ones in the frontend components to react are directly symlinked with ln -s not npm link.

bastilian

comment created time in 10 days

push eventbastilian/frontend-components

Karel Hala

commit sha 609a5dd4dd939f4bfbeecc62d9a30bf7f1054afb

Fix does have permission by using permission if given

view details

Richard Všianský

commit sha 89a7d19b23885eaaf3044429202780ff27db7e51

Merge pull request #739 from karelhala/proper-have-permissions Fix does have permission by using permission if given

view details

Sebastian Gräßl

commit sha 3492afe32fa2abf1a337ad14a60ab0c42219c74c

[RHICOMPL-777] Fix issue with empty state flashing

view details

push time in 11 days

push eventbastilian/frontend-components

Sebastian Gräßl

commit sha ed9f5a92e525d9e48ed12ee61cb0e93d6487f102

[RHICOMPL-777] Fix issue with empty state flashing

view details

push time in 11 days

push eventbastilian/frontend-components

Karel Hala

commit sha 2199ad5ed680278018020dc2e1acd450be9cdc6d

Add information about linking react and react-dom (#736) * Add information about linking react and react-dom * Add few more info to README

view details

Sebastian Gräßl

commit sha ebaea3b7e79e59c6083d04dc2bf2c4463e376c3e

[RHICOMPL-777] Fix issue with empty state flashing

view details

push time in 11 days

PR opened RedHatInsights/frontend-components

[RHICOMPL-777] Fix issue with empty state flashing

This refactors the Compliance components and fixes the issues with the empty state flashing before/when it is loading.

Before: before

After: after

To test this, please follow the instructions in the README to properly link the package and avoid an error regarding react hooks and multiple versions of react. Additionally, there is an issue caused by the way the packages are linked and built and cause the Remediations button to raise an error(*). To avoid this while testing disable the button:

diff --git a/packages/inventory-compliance/src/SystemRulesTable.js b/packages/inventory-compliance/src/SystemRulesTable.js
index cb737a61..67116ac6 100644
--- a/packages/inventory-compliance/src/SystemRulesTable.js
+++ b/packages/inventory-compliance/src/SystemRulesTable.js
@@ -326,7 +326,7 @@ class SystemRulesTable extends React.Component {
                         ...pagination,
                         dropDirection: 'down'
                     }}>
-                    { remediationsEnabled &&
+                    { false &&
                         <ToolbarItem>
                             <ComplianceRemediationButton
                                 allSystems={ [{ id: system.id, profiles: system.profiles, ruleObjectsFailed: [] }] }

These issues only occur when linking packages locally and building them from source and will not occur once the package has been properly released on npm and installed as a dependency of compliance.

(*) This will be fixed by passing down the redux store.

+42 -62

0 comment

2 changed files

pr created time in 11 days

create barnchbastilian/frontend-components

branch : 777

created branch time in 11 days

PullRequestReviewEvent

pull request commentRedHatInsights/frontend-components

Add information about linking react and react-dom

Thank you for adding more information @karelhala!

Following the steps solves the issues with React'n'Hooks! \o/

One thing that may be confusing might be where to run each command, so it might make sense to be very explicit in each step with run from the frontend-components directory/application.

karelhala

comment created time in 11 days

Pull request review commentRedHatInsights/frontend-components

Add information about linking react and react-dom

 To test changes from packages in this repository in other applications follow th   rm -rf node_modules/react; rm -rf node_modules/react-dom   ```   This is because we want to use hooks and different reacts are not playing nicely with hooks [facebook/react/issues/15315](https://github.com/facebook/react/issues/15315)+3. Link `react` and `react-dom` from your application.+```+ln -s $PWD/insights-inventory-frontend/node_modules/react frontend-components/node_modules/react

+1 and possible use something like /path/to/frontend-components/... for the target to not confuse people thinking it is implied that it is within the apps directory. I don't think anyone would think that, but to be sure. :)

karelhala

comment created time in 11 days

PullRequestReviewEvent

push eventbastilian/compliance-frontend

Sebastian Gräßl

commit sha 12b1b44fa95a3d5f871a4ebae58614fd0dad8436

[RHICOMPL-906] Remove actions from Policy Details completely (#753)

view details

push time in 12 days

push eventRedHatInsights/compliance-frontend

Karel Hala

commit sha 7d44afd18c258582b59d9d2b3b1ac4a9397fcbf4

Hide global filter on all compliance screens

view details

Sebastian Gräßl

commit sha 519a5cd5e87095f7c268775a95cf1723a7b52c5e

Bump @patternfly & @redhat-cloud-services dependencies (#732)

view details

Sebastian Gräßl

commit sha 744424dac69f7d13837dafccc0d69e9997645260

[RHICOMPL-906] Remove "Edit policies for system" (#752)

view details

Sebastian Gräßl

commit sha 12b1b44fa95a3d5f871a4ebae58614fd0dad8436

[RHICOMPL-906] Remove actions from Policy Details completely (#753)

view details

push time in 12 days

push eventRedHatInsights/compliance-frontend

Karel Hala

commit sha 7d44afd18c258582b59d9d2b3b1ac4a9397fcbf4

Hide global filter on all compliance screens

view details

Sebastian Gräßl

commit sha 519a5cd5e87095f7c268775a95cf1723a7b52c5e

Bump @patternfly & @redhat-cloud-services dependencies (#732)

view details

Sebastian Gräßl

commit sha 744424dac69f7d13837dafccc0d69e9997645260

[RHICOMPL-906] Remove "Edit policies for system" (#752)

view details

Sebastian Gräßl

commit sha 12b1b44fa95a3d5f871a4ebae58614fd0dad8436

[RHICOMPL-906] Remove actions from Policy Details completely (#753)

view details

push time in 12 days

PullRequestReviewEvent

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 12b1b44fa95a3d5f871a4ebae58614fd0dad8436

[RHICOMPL-906] Remove actions from Policy Details completely (#753)

view details

push time in 13 days

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 12b1b44fa95a3d5f871a4ebae58614fd0dad8436

[RHICOMPL-906] Remove actions from Policy Details completely (#753)

view details

push time in 13 days

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 12b1b44fa95a3d5f871a4ebae58614fd0dad8436

[RHICOMPL-906] Remove actions from Policy Details completely (#753)

view details

push time in 13 days

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 12b1b44fa95a3d5f871a4ebae58614fd0dad8436

[RHICOMPL-906] Remove actions from Policy Details completely (#753)

view details

push time in 13 days

push eventRedHatInsights/compliance-frontend

Sebastian Gräßl

commit sha 12b1b44fa95a3d5f871a4ebae58614fd0dad8436

[RHICOMPL-906] Remove actions from Policy Details completely (#753)

view details

push time in 13 days

PR merged RedHatInsights/compliance-frontend

Reviewers
[RHICOMPL-906] Remove actions from Policy Details completely

RHICOMPL-906 actually instructs to remove the Kebab menu from the policy details completely.

Screenshot 2020-09-14 at 17 09 05

+1 -0

1 comment

1 changed file

bastilian

pr closed time in 13 days

more