profile
viewpoint
Bartek Iwańczuk bartlomieju Warsaw, PL

deno-postgres/deno-postgres 221

PostgreSQL driver for Deno

denoland/deno_lint 79

Linter for JavaScript and TypeScript written in Rust

bartlomieju/parseargs 29

Migrated to https://github.com/denoland/deno_std

bartlomieju/deno 2

A secure TypeScript runtime on V8

hayd/deno 2

A secure TypeScript runtime on V8

bartlomieju/bartlomieju.github.io 0

Code that'll help you kickstart a personal website that showcases your work as a software developer.

bartlomieju/deno-logging 0

Migrated to https://github.com/denoland/deno_std/

bartlomieju/deno-redis 0

[WIP] An experimental implementation of redis client for deno

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha 11e0b152a5195cb46a1e0f376d7e17d337e25a25

destructure

view details

push time in 10 hours

delete branch bartlomieju/deno

delete branch : fix_es_private_fields

delete time in 11 hours

push eventdenoland/deno

Bartek Iwańczuk

commit sha 550556e948e750dc64039dcffd311752cf8312fd

fix: ES private fields parsing in SWC (#5964)

view details

push time in 11 hours

PR merged denoland/deno

fix: ES private fields parsing in SWC

This problem was introduced in #5817; I mistakenly set config for private fields to false.

Fixed and added a test case.

Fixes https://github.com/denoland/deno/issues/5960

+24 -3

0 comment

4 changed files

bartlomieju

pr closed time in 11 hours

issue closeddenoland/deno

Private field `#` cannot be recognized in bundled JS file on v1.0.3

After upgrading deno to v1.0.3, private field in a class cannot be recognized in bundled file.

Following is reproducable typescript file as test.ts.

class Foo {
  #field:string = "VALUE";
  setValue(val:string):void {
    this.#field = val;
  }
  getValue(): string {
    return this.#field;
  }
}

const bar = new Foo();
bar.setValue("PRIVATE")
console.log(bar.getValue());

On deno 1.0.3, # is recognized as Unexpected token.

$ deno bundle test.ts > test.js
Bundling file:///<PATH_TO_PROJECT>/test.ts
$ deno run test.js
error: Unexpected token '#' at file:///<PATH_TO_PROJECT>/test.js:111:9

But it works well on v1.0.2.

$ deno run test.js
PRIVATE

Could you please look into it?

Regards,

closed time in 11 hours

horihiro

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha 22734f63685a33f99f175d6f6addcd25fa538587

WIP noExAssign

view details

push time in 12 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha ef5e4b1155ef70b91d8e69e61ec3e37dd61aa6b6

remove debug

view details

push time in 12 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha 3edce14b905c78b85ee3d5c8a9857c3b79da6cb7

Add noClassAssign rule

view details

push time in 12 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha 648528d41541df24ab155de5e12ad817c4aa07cb

Add noCaseDeclarations rule (#57)

view details

Bartek Iwańczuk

commit sha 139ce1b8f458d54b9260e6da1d6c2d7d3e0dcb57

Add requireYield rule (#56)

view details

Bartek Iwańczuk

commit sha fe369f427f11d75138c7004d10d8d3b1d2228d5c

fix noExplicitAny rule (#58)

view details

Bartek Iwańczuk

commit sha 8e687ee19968ab4d173dacab1e4a3174a61b249f

Add noPrototypeBuiltins rule (#59)

view details

Bartek Iwańczuk

commit sha 09f2fc19a130348e3d400a40904272444bccf0e8

Add forDirection rule (#60)

view details

Bartek Iwańczuk

commit sha 2410472cc227a13e45935068ca2b5a460096bb56

temp

view details

Bartek Iwańczuk

commit sha 03aad4cda1a98ab3f8c27adea6a7fbad3518cf9e

basic scope manager

view details

Bartek Iwańczuk

commit sha 2a9a7dd85335482fa6c984ca7fb2e846f33ff44f

basic no_func_assign rule

view details

Bartek Iwańczuk

commit sha f48631cbe1b60782b65efb5e5782b08173b4dc72

lint

view details

Bartek Iwańczuk

commit sha 407fd408451cf96f00488317402b7658d8acc660

fix scope acquisition

view details

Bartek Iwańczuk

commit sha 31bdc4316aa31da44ff29e484025a1b8fed26bea

temp

view details

push time in 13 hours

delete branch bartlomieju/deno_lint

delete branch : for_direction

delete time in 13 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha 09f2fc19a130348e3d400a40904272444bccf0e8

Add forDirection rule (#60)

view details

push time in 13 hours

push eventdenoland/deno_lint

Bartek Iwańczuk

commit sha 09f2fc19a130348e3d400a40904272444bccf0e8

Add forDirection rule (#60)

view details

push time in 13 hours

PR merged denoland/deno_lint

Add forDirection rule
+332 -0

0 comment

3 changed files

bartlomieju

pr closed time in 13 hours

PR opened denoland/deno_lint

Add forDirection rule
+332 -0

0 comment

3 changed files

pr created time in 13 hours

create barnchbartlomieju/deno_lint

branch : for_direction

created branch time in 13 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha 8e687ee19968ab4d173dacab1e4a3174a61b249f

Add noPrototypeBuiltins rule (#59)

view details

push time in 14 hours

delete branch bartlomieju/deno_lint

delete branch : no_prototype_builtins

delete time in 14 hours

push eventdenoland/deno_lint

Bartek Iwańczuk

commit sha 8e687ee19968ab4d173dacab1e4a3174a61b249f

Add noPrototypeBuiltins rule (#59)

view details

push time in 14 hours

PR opened denoland/deno_lint

Add noPrototypeBuiltins rule
+152 -0

0 comment

3 changed files

pr created time in 14 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha ba69c814159ac506f53c041545cbd0847a4cbd0d

Add noPrototypeBuiltins rule

view details

push time in 14 hours

create barnchbartlomieju/deno_lint

branch : no_prototype_builtins

created branch time in 14 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha fe369f427f11d75138c7004d10d8d3b1d2228d5c

fix noExplicitAny rule (#58)

view details

push time in 14 hours

delete branch bartlomieju/deno_lint

delete branch : fix_no_explicit_any

delete time in 14 hours

push eventdenoland/deno_lint

Bartek Iwańczuk

commit sha fe369f427f11d75138c7004d10d8d3b1d2228d5c

fix noExplicitAny rule (#58)

view details

push time in 14 hours

PR merged denoland/deno_lint

fix noExplicitAny rule
+27 -13

0 comment

1 changed file

bartlomieju

pr closed time in 14 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha 50583f9501519c13b6e4d71d88495897e7aaa199

fix noExplicitAny rule

view details

push time in 14 hours

PR opened denoland/deno_lint

fix noExplicitAny rule
+95 -13

0 comment

2 changed files

pr created time in 14 hours

create barnchbartlomieju/deno_lint

branch : fix_no_explicit_any

created branch time in 14 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha 139ce1b8f458d54b9260e6da1d6c2d7d3e0dcb57

Add requireYield rule (#56)

view details

push time in 14 hours

delete branch bartlomieju/deno_lint

delete branch : require_yield

delete time in 14 hours

push eventdenoland/deno_lint

Bartek Iwańczuk

commit sha 139ce1b8f458d54b9260e6da1d6c2d7d3e0dcb57

Add requireYield rule (#56)

view details

push time in 14 hours

PR merged denoland/deno_lint

Add requireYield rule
+246 -3

0 comment

5 changed files

bartlomieju

pr closed time in 14 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha 648528d41541df24ab155de5e12ad817c4aa07cb

Add noCaseDeclarations rule (#57)

view details

Bartek Iwańczuk

commit sha 7e3647fd9b7c292cbb3089c35eb978e709c0be8e

Add require_yield rule

view details

Bartek Iwańczuk

commit sha a039101646ee5e261288c52c0df6386bec865915

Add requireYield rule

view details

push time in 15 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha 648528d41541df24ab155de5e12ad817c4aa07cb

Add noCaseDeclarations rule (#57)

view details

push time in 15 hours

delete branch bartlomieju/deno_lint

delete branch : no_case_declarations

delete time in 15 hours

push eventdenoland/deno_lint

Bartek Iwańczuk

commit sha 648528d41541df24ab155de5e12ad817c4aa07cb

Add noCaseDeclarations rule (#57)

view details

push time in 15 hours

issue commentswc-project/swc

swc_ecma_visit skips class body

@kdy1 thank you!

bartlomieju

comment created time in 15 hours

PR opened denoland/deno_lint

Add noCaseDeclarations rule
+210 -0

0 comment

3 changed files

pr created time in 15 hours

create barnchbartlomieju/deno_lint

branch : no_case_declarations

created branch time in 15 hours

Pull request review commentdenoland/deno_lint

Scopes again

+// Copyright 2020 the Deno authors. All rights reserved. MIT license.++#![allow(unused)]++use std::cell::RefCell;+use std::collections::HashMap;+use std::fmt;+use std::rc::Rc;+use std::sync::atomic::AtomicU32;+use std::sync::atomic::Ordering;+use swc_common::Span;+use swc_ecma_ast::AssignExpr;+use swc_ecma_ast::Decl;+use swc_ecma_ast::Expr;+use swc_ecma_ast::ExprStmt;+use swc_ecma_ast::Module;+use swc_ecma_ast::ModuleItem;+use swc_ecma_ast::Pat;+use swc_ecma_ast::Stmt;+use swc_ecma_visit::Node;+use swc_ecma_visit::Visit;++lazy_static! {+  static ref NEXT_ID: AtomicU32 = AtomicU32::new(0);+}++#[derive(Clone, Debug, PartialEq)]+pub enum BindingKind {+  Var,+  Const,+  Let,+  Function,+  Param,+}++#[derive(Clone, Debug)]+pub struct Binding {+  pub kind: BindingKind,+  pub name: String,+}++#[derive(Clone, Debug, PartialEq)]+pub enum ScopeKind {+  Program,+  Module,+  Function,+  Block,+  Loop,+  Class,+  Switch,+  With,+  Catch,+}++#[derive(Clone, Debug)]+pub struct Scope {+  pub kind: ScopeKind,+  pub id: u32,+  pub parent_id: Option<u32>,+  pub span: Span,+  pub child_scopes: Vec<u32>,

Ditto, it'd be better to own child scopes: Vec<Scope>

bartlomieju

comment created time in 15 hours

Pull request review commentdenoland/deno_lint

Scopes again

+// Copyright 2020 the Deno authors. All rights reserved. MIT license.++#![allow(unused)]++use std::cell::RefCell;+use std::collections::HashMap;+use std::fmt;+use std::rc::Rc;+use std::sync::atomic::AtomicU32;+use std::sync::atomic::Ordering;+use swc_common::Span;+use swc_ecma_ast::AssignExpr;+use swc_ecma_ast::Decl;+use swc_ecma_ast::Expr;+use swc_ecma_ast::ExprStmt;+use swc_ecma_ast::Module;+use swc_ecma_ast::ModuleItem;+use swc_ecma_ast::Pat;+use swc_ecma_ast::Stmt;+use swc_ecma_visit::Node;+use swc_ecma_visit::Visit;++lazy_static! {+  static ref NEXT_ID: AtomicU32 = AtomicU32::new(0);+}++#[derive(Clone, Debug, PartialEq)]+pub enum BindingKind {+  Var,+  Const,+  Let,+  Function,+  Param,+}++#[derive(Clone, Debug)]+pub struct Binding {+  pub kind: BindingKind,+  pub name: String,+}++#[derive(Clone, Debug, PartialEq)]+pub enum ScopeKind {+  Program,+  Module,+  Function,+  Block,+  Loop,+  Class,+  Switch,+  With,+  Catch,+}++#[derive(Clone, Debug)]+pub struct Scope {+  pub kind: ScopeKind,+  pub id: u32,+  pub parent_id: Option<u32>,

It would be much better to hold reference to parent: Option<&Scope>

bartlomieju

comment created time in 15 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha d8f49cb236ed6fbd7518f16dbdfbaca9f661f450

chore: upgrade Rust to 1.43.0 (#54)

view details

Bartek Iwańczuk

commit sha aab2373f03e79497fb7c42537990ef473609d275

Add no_with rule (#55)

view details

Bartek Iwańczuk

commit sha 4a9a1fa67b8a8df361849d8f7d040b32bddee58a

temp

view details

Bartek Iwańczuk

commit sha 3e73f6efd536c1d52d37ccf1a7e7b78667439a07

basic scope manager

view details

Bartek Iwańczuk

commit sha c7c88dd3f518126f3f317c3890d8ee9f3ffb1d8c

basic no_func_assign rule

view details

Bartek Iwańczuk

commit sha e735e01b53adaaf53ed8764e2016009eca242d5d

lint

view details

Bartek Iwańczuk

commit sha 766557a805359b10cfa336f094e191fd7bec5c8b

fix scope acquisition

view details

Bartek Iwańczuk

commit sha 2bd1b745578377092478dae2cf326db5d6f87d2c

temp

view details

push time in 15 hours

issue commentswc-project/swc

swc_ecma_visit skips class body

@kdy1 full repro in this PR: https://github.com/denoland/deno_lint/pull/56

You can run problematic test by: cargo test require_yield

bartlomieju

comment created time in 15 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha aab2373f03e79497fb7c42537990ef473609d275

Add no_with rule (#55)

view details

Bartek Iwańczuk

commit sha a1e6d4afbbcb49a3808d60256e352d7571705001

Add require_yield rule

view details

Bartek Iwańczuk

commit sha aece9c77ff25a982715781642cd69fdcdc3dddd7

wip

view details

push time in 15 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha aab2373f03e79497fb7c42537990ef473609d275

Add no_with rule (#55)

view details

push time in 15 hours

issue commentswc-project/swc

swc_ecma_visit skips class body

@kdy1 thanks, I was surprised as well - when I print out AST node of class I can see body containing method, but visit_class_method() is never called.

bartlomieju

comment created time in 15 hours

Pull request review commentdenoland/deno_lint

[WIP] Add requireYield rule

+// Copyright 2020 the Deno authors. All rights reserved. MIT license.+use super::Context;+use super::LintRule;+use swc_ecma_ast::FnDecl;+use swc_ecma_ast::FnExpr;+use swc_ecma_ast::Function;+use swc_ecma_ast::ClassMethod;+use swc_ecma_ast::YieldExpr;+use swc_ecma_visit::Node;+use swc_ecma_visit::Visit;++pub struct RequireYield;++impl LintRule for RequireYield {+  fn new() -> Box<Self> {+    Box::new(RequireYield)+  }++  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {+    let mut visitor = RequireYieldVisitor::new(context);+    visitor.visit_module(&module, &module);+  }+}++pub struct RequireYieldVisitor {+  context: Context,+  yield_stack: Vec<u32>,+}++impl RequireYieldVisitor {+  pub fn new(context: Context) -> Self {+    Self {+      context,+      yield_stack: vec![],+    }+  }++  fn check_function(&mut self, function: &Function) {+    if function.is_generator {+      let yield_count = self.yield_stack.pop().unwrap();++      // Verify that `yield` was called only if function body+      // is non-empty+      if let Some(body) = &function.body {+        if !body.stmts.is_empty() && yield_count == 0 {+          self.context.add_diagnostic(+            function.span,+            "requireYield",+            "Generator function has no `yield`",+          );+        }+      }+    }+  }+}++// TODO(bartlomieju): class methods and fn expr in object should be handled as well+impl Visit for RequireYieldVisitor {+  fn visit_yield_expr(&mut self, _yield_expr: &YieldExpr, _parent: &dyn Node) {+    if let Some(last) = self.yield_stack.last_mut() {+      *last += 1;+    }+  }++  fn visit_fn_decl(&mut self, fn_decl: &FnDecl, parent: &dyn Node) {+    if fn_decl.function.is_generator {+      self.yield_stack.push(0);+    }++    swc_ecma_visit::visit_fn_decl(self, fn_decl, parent);++    self.check_function(&fn_decl.function);+  }++  fn visit_fn_expr(&mut self, fn_expr: &FnExpr, parent: &dyn Node) {+    if fn_expr.function.is_generator {+      self.yield_stack.push(0);+    }++    swc_ecma_visit::visit_fn_expr(self, fn_expr, parent);++    self.check_function(&fn_expr.function);+  }++  fn visit_class_method(&mut self, class_method: &ClassMethod, parent: &dyn Node) {+    eprintln!("visit class method");+    if class_method.function.is_generator {+      self.yield_stack.push(0);

Possibly bug in SWC https://github.com/swc-project/swc/issues/808

bartlomieju

comment created time in 15 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha 2d73646a89531dc0ff7aa9c8c7764684b72bb2f8

wip

view details

push time in 15 hours

delete branch bartlomieju/deno_lint

delete branch : no_with

delete time in 15 hours

push eventdenoland/deno_lint

Bartek Iwańczuk

commit sha aab2373f03e79497fb7c42537990ef473609d275

Add no_with rule (#55)

view details

push time in 15 hours

PR merged denoland/deno_lint

Add no_with rule
+71 -0

0 comment

3 changed files

bartlomieju

pr closed time in 15 hours

issue openedswc-project/swc

swc_ecma_visit skips class body

Describe the bug swc_ecma_visit doesn't visit class body

Input code

impl Visit for RequireYieldVisitor {
  ... 
  fn visit_class(&mut self, class: &Class, parent: &dyn Node) {
    eprintln!("visit class");
    swc_ecma_visit::visit_class(self, class, parent);
  }

  fn visit_class_method(&mut self, class_method: &ClassMethod, parent: &dyn Node) {
    eprintln!("visit class method");
    swc_ecma_visit::visit_class_method(self, class_method, parent);
  }
}
$ cargo test require_yield
visit class

Expected behavior

$ cargo test require_yield
visit class
visit class method

Version swc_ecma_visit 0.5.0

created time in 15 hours

PR opened denoland/deno_lint

[WIP] Add requireYield rule
+158 -0

0 comment

3 changed files

pr created time in 16 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha d8f49cb236ed6fbd7518f16dbdfbaca9f661f450

chore: upgrade Rust to 1.43.0 (#54)

view details

Bartek Iwańczuk

commit sha 62005f1741d9fead0668233ddc7f96fdfe81ce13

Add require_yield rule

view details

push time in 16 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha d8f49cb236ed6fbd7518f16dbdfbaca9f661f450

chore: upgrade Rust to 1.43.0 (#54)

view details

Bartek Iwańczuk

commit sha 26d56858969a32a79f04915dc2077f0eb7b91d16

Add no_with rule

view details

push time in 16 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha d8f49cb236ed6fbd7518f16dbdfbaca9f661f450

chore: upgrade Rust to 1.43.0 (#54)

view details

push time in 16 hours

create barnchbartlomieju/deno_lint

branch : require_yield

created branch time in 16 hours

delete branch bartlomieju/deno_lint

delete branch : bump_ci

delete time in 16 hours

push eventdenoland/deno_lint

Bartek Iwańczuk

commit sha d8f49cb236ed6fbd7518f16dbdfbaca9f661f450

chore: upgrade Rust to 1.43.0 (#54)

view details

push time in 16 hours

PR merged denoland/deno_lint

chore: upgrade Rust to 1.43.0
+1 -5

0 comment

4 changed files

bartlomieju

pr closed time in 16 hours

PR opened denoland/deno_lint

Add no_with rule
+71 -0

0 comment

3 changed files

pr created time in 16 hours

create barnchbartlomieju/deno_lint

branch : no_with

created branch time in 16 hours

PR opened denoland/deno_lint

chore: upgrade Rust to 1.43.0
+1 -5

0 comment

4 changed files

pr created time in 16 hours

create barnchbartlomieju/deno_lint

branch : bump_ci

created branch time in 16 hours

push eventbartlomieju/deno_lint

Dom Parfitt

commit sha 67aafc4e019379e7cd708a31668f4b5e002b4e77

Adds no-empty Rule (#45)

view details

Bartek Iwańczuk

commit sha c80f4120b5fa7400c425b94e41ff1bc0c67172d8

add AstParser helper (#52)

view details

push time in 16 hours

push eventdenoland/deno_website2

Pablo Andrés Dorado Suárez

commit sha deaa3062cf64df74f63a8606cf2bfb8b25c96ac1

Add deno_http_server (#903)

view details

push time in 17 hours

PR merged denoland/deno_website2

Add deno_http_server
+6 -0

0 comment

1 changed file

pandres95

pr closed time in 17 hours

push eventpandres95/deno_website2

Karthik Thayyil

commit sha 85949ff3c2b1f31c4188dd865fdb353c2778e647

added download module to database.json (#906)

view details

EnokMan

commit sha 689d311a25fe689b3864bdf33e4a82a5cd514a08

add gzip module (#905)

view details

Leonel Vieyra

commit sha 9c98da5ddfe6f5bee671f68f18e7026debf6c80b

Add deno_imagemagick (#904)

view details

Deno Tutorials

commit sha a67d0033a8157a5e7b2045518d44e57468fa5383

Added opener to the database.json file (#902)

view details

Vinod Nimbalkar

commit sha faaf99cb1b172a10a94173744ea70031ea682150

update database.json with dinvishesh library (#890)

view details

Ryan Dahl

commit sha 93ad2ae352a9e69030dedf438e6070840ae58579

Remove hoodie link (#907)

view details

zfx

commit sha 7bc1940b1ca691924207b10dbf033fb9dca28f1b

add a progress bar module to database.json (#908)

view details

zfx

commit sha d9dc60dad3b41b4b190082656c7b284653bfbe54

add unrar module to database.json (#909)

view details

Elias Sjögreen

commit sha 77f19e626e42c0bd19a5a535b4940754f023245e

Add lz4 (#911)

view details

Szalay Kristóf

commit sha e5f1d95c3dbcb7f9c54d0d94dc4b25f3bb59bfe0

Add prettyBenching (#912)

view details

Fabrizio Vitale

commit sha 41659657b2bd0e1a0d3f4ae1cb36f19f33c8d0a2

add 'deno_minimist' to database.json (#913)

view details

Matheus Vinícius

commit sha 0a76700b89efd81431759b2ed332c51de977698c

Update database.json (#914)

view details

wuper

commit sha 4ce9a63e4951125dbe7a60c7df1610ba9726cb10

Add denologger to third party list (#916) Denologger is a simple to use tool that formats your logs into an easy to read, and clean format. With colors too!

view details

Ryan Dahl

commit sha 27443366a4abda7f6bf8aa33b75bc2d23c8b367e

update std version (#919)

view details

wuper

commit sha 81140421e14deb753ecf9c37614f7e04ce2f3f3c

Package rename - See details (#926) I copied one of the objects in database.json and replaced all of the values with my own, except for the actual name. Silly me!

view details

Güner Yildirim

commit sha 62a43b22b7439d23f8fa840df6e9ad6ddfa70da0

Add LRU to 3rd party modules (#927)

view details

eeve

commit sha 438057af211d8b2166e96be9c46d2f5b500ae9ff

Update database.json (#925)

view details

Pandawan

commit sha af8c91b21445af015839cebd12566ed7e7927c15

Add deno_notify (#924)

view details

Shawn Bullock

commit sha 66a437f9d817f22920067692d19ecda131be6375

Add zap to 3rd party modules (#923)

view details

Richard Tong

commit sha 3228d25cc7da272e7fd3bb87bb219d884bae1006

rubico - update description and owner (#922)

view details

push time in 17 hours

push eventdenoland/deno_website2

apiel

commit sha 11eac94f25edeeb49b1f4c2336ce221fa5e700ff

pub jsx-html (#930)

view details

push time in 17 hours

PR merged denoland/deno_website2

pub jsx-html

Hello, I would like to share my module jsx-html intended to convert JSX template to HTML.

https://github.com/apiel/jsx-html

+6 -0

3 comments

1 changed file

apiel

pr closed time in 17 hours

push eventdenoland/deno_website2

Acathur

commit sha 30200b4f534f557cf39f150e2769a39a724dbe19

Add `dep`, a dependency management tool. (#931)

view details

push time in 17 hours

PR merged denoland/deno_website2

Add `dep`, a dependency management tool.

Using import maps to manage deno project dependencies. Also provide services for publishing and hosting deno modules.

+6 -0

0 comment

1 changed file

acathur

pr closed time in 17 hours

push eventdenoland/deno_website2

Fausto German

commit sha b3d491357285fa33eb46535bc90437710beb23bc

Update database.json to include Rhino (#929)

view details

push time in 17 hours

PR merged denoland/deno_website2

Update database.json to include Rhino

Rhino is an Angular-inspired framework for creating scalable APIs.

+6 -0

0 comment

1 changed file

faustotnc

pr closed time in 17 hours

PR opened denoland/deno

fix: ES private fields parsing in SWC

This problem was introduced in #5817; I mistakenly set config for private fields to false.

Fixed and added a test case.

Fixes https://github.com/denoland/deno/issues/5960

+24 -3

0 comment

4 changed files

pr created time in 17 hours

create barnchbartlomieju/deno

branch : fix_es_private_fields

created branch time in 17 hours

push eventbartlomieju/deno

Bartek Iwańczuk

commit sha 106b00173806e088472e123d04fdc8d260c3820d

v1.0.3

view details

Ryan Dahl

commit sha d4b05dd89e94ed1bba5b24c683da0a895f2ce597

refactor: Split isolate and state using safe get_slot() (#5929)

view details

Dan Vega

commit sha 24e545d5bd2b679055e6c3b637119c57c8ad1243

typo (#5948)

view details

Marcos Casagrande

commit sha a82f24e9a8d269d43e32af10ae9cb6fd9bf88d9f

test to check that resource handle is closed after stream is cancelled (#5956)

view details

Ryan Dahl

commit sha dad551a3a77346d190663003e366dd94ce46626d

upgrade: Rust crates (#5959)

view details

push time in 17 hours

push eventdenoland/deno

Ryan Dahl

commit sha dad551a3a77346d190663003e366dd94ce46626d

upgrade: Rust crates (#5959)

view details

push time in 17 hours

PR merged denoland/deno

upgrade: crates

merge on approval

+257 -330

0 comment

7 changed files

ry

pr closed time in 17 hours

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha 8ac68d1c627d4b32924186d4d3b3239d1c5700a3

fix scope acquisition

view details

push time in a day

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha b22af9d883a91c82ef287fa577463c24d23388ee

lint

view details

push time in a day

push eventbartlomieju/deno_lint

Bartek Iwańczuk

commit sha 69bbb8f49cfe523ca5e5c3c5eb388eb2931d8647

bump ci

view details

push time in a day

PR closed denoland/deno_lint

[WIP] scopes 2
+270 -0

0 comment

4 changed files

bartlomieju

pr closed time in a day

PR opened denoland/deno_lint

Scopes again
+486 -0

0 comment

6 changed files

pr created time in a day

create barnchbartlomieju/deno_lint

branch : scopes_again

created branch time in a day

delete branch bartlomieju/deno_lint

delete branch : ast_parser

delete time in a day

push eventdenoland/deno_lint

Bartek Iwańczuk

commit sha c80f4120b5fa7400c425b94e41ff1bc0c67172d8

add AstParser helper (#52)

view details

push time in a day

PR merged denoland/deno_lint

add AstParser helper
+230 -99

0 comment

3 changed files

bartlomieju

pr closed time in a day

IssuesEvent

PR opened denoland/deno_lint

add AstParser helper
+230 -99

0 comment

3 changed files

pr created time in a day

create barnchbartlomieju/deno_lint

branch : ast_parser

created branch time in a day

created tagdenoland/deno

tagv1.0.3

A secure JavaScript and TypeScript runtime

created time in a day

Pull request review commentdenoland/deno

refactor: Split isolate and state using safe get_slot()

 type IsolateErrorHandleFn = dyn FnMut(ErrBox) -> Result<(), ErrBox>; /// Ops are created in JavaScript by calling Deno.core.dispatch(), and in Rust /// by implementing dispatcher function that takes control buffer and optional zero copy buffer /// as arguments. An async Op corresponds exactly to a Promise in JavaScript.-#[allow(unused)] pub struct CoreIsolate {-  pub v8_isolate: Option<v8::OwnedIsolate>,+  // This is an Option<OwnedIsolate> instead of just OwnedIsolate to workaround+  // an safety issue with SnapshotCreator. See CoreIsolate::drop.+  v8_isolate: Option<v8::OwnedIsolate>,   snapshot_creator: Option<v8::SnapshotCreator>,   has_snapshotted: bool,+  needs_init: bool,+  startup_script: Option<OwnedScript>,+}++/// Internal state for CoreIsolate which is stored in one of v8::Isolate's+/// embedder slots.+pub struct CoreIsolateState {   pub resource_table: Rc<RefCell<ResourceTable>>,   pub global_context: v8::Global<v8::Context>,   pub(crate) shared_ab: v8::Global<v8::SharedArrayBuffer>,   pub(crate) js_recv_cb: v8::Global<v8::Function>,   pub(crate) js_macrotask_cb: v8::Global<v8::Function>,   pub(crate) pending_promise_exceptions: HashMap<i32, v8::Global<v8::Value>>,-  shared_isolate_handle: Arc<Mutex<Option<*mut v8::Isolate>>>,   pub(crate) js_error_create_fn: Box<JSErrorCreateFn>,-  needs_init: bool,   pub(crate) shared: SharedQueue,   pending_ops: FuturesUnordered<PendingOpFuture>,   pending_unref_ops: FuturesUnordered<PendingOpFuture>,   have_unpolled_ops: bool,-  startup_script: Option<OwnedScript>,   pub op_registry: OpRegistry,   waker: AtomicWaker,+  // TODO(bartlomieju): get rid of this field?+  #[allow(unused)]   error_handler: Option<Box<IsolateErrorHandleFn>>,

Is this TODO still actionable? Can you remove this filed?

ry

comment created time in a day

delete branch bartlomieju/deno

delete branch : v1.0.3

delete time in a day

push eventdenoland/deno

Bartek Iwańczuk

commit sha 106b00173806e088472e123d04fdc8d260c3820d

v1.0.3

view details

push time in a day

PR merged denoland/deno

v1.0.3

<!-- Before submitting a PR, please read https://github.com/denoland/deno/blob/master/docs/contributing.md -->

+54 -12

1 comment

6 changed files

bartlomieju

pr closed time in a day

Pull request review commentdenoland/deno_lint

[WIP] scopes 2

+// Copyright 2020 the Deno authors. All rights reserved. MIT license.+use super::Context;+use super::LintRule;+use crate::scopes::BindingKind;+use crate::scopes::ScopeVisitor;+use swc_ecma_ast::AssignExpr;+use swc_ecma_ast::Pat;+use swc_ecma_ast::PatOrExpr;+use swc_ecma_visit::Node;+use swc_ecma_visit::Visit;++pub struct NoFuncAssign;++impl LintRule for NoFuncAssign {+  fn new() -> Box<Self> {+    Box::new(NoFuncAssign)+  }++  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {+    let mut scope_manager = ScopeVisitor::default();+    scope_manager.visit_module(&module, &module);+    let mut visitor = NoFuncAssignVisitor::new(context, scope_manager);+    visitor.visit_module(&module, &module);

@kdy1 thanks for quick response; I'll go through Resolver and Hygiene in SWC to get better grasp on how they work.

bartlomieju

comment created time in a day

Pull request review commentdenoland/deno_lint

[WIP] scopes 2

+// Copyright 2020 the Deno authors. All rights reserved. MIT license.+use super::Context;+use super::LintRule;+use crate::scopes::BindingKind;+use crate::scopes::ScopeVisitor;+use swc_ecma_ast::AssignExpr;+use swc_ecma_ast::Pat;+use swc_ecma_ast::PatOrExpr;+use swc_ecma_visit::Node;+use swc_ecma_visit::Visit;++pub struct NoFuncAssign;++impl LintRule for NoFuncAssign {+  fn new() -> Box<Self> {+    Box::new(NoFuncAssign)+  }++  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {+    let mut scope_manager = ScopeVisitor::default();+    scope_manager.visit_module(&module, &module);+    let mut visitor = NoFuncAssignVisitor::new(context, scope_manager);+    visitor.visit_module(&module, &module);

@kdy1 sorry for slow response; I'd like to follow up on it.

Using hygiene context seems like a better solution for the future (for example auto fixes for lint errors would change the spans).

Does it mean that I should use SyntaxContext as a key in the hash map or am I beating around the wrong bush?

bartlomieju

comment created time in a day

more