profile
viewpoint
Bartek Iwańczuk bartlomieju @denoland Warsaw, PL

denoland/deno_lint 595

Blazing fast linter for JavaScript and TypeScript written in Rust

denodrivers/postgres 324

PostgreSQL driver for Deno

denoland/doc_website 144

Auto-generated documentation for Deno modules

dprint/dprint-plugin-typescript 37

TypeScript and JavaScript code formatting plugin for dprint.

bartlomieju/parseargs 26

Migrated to https://github.com/denoland/deno_std

dprint/dprint-plugin-markdown 3

Markdown code formatting plugin for dprint.

dsherret/dprint-swc-ecma-ast-view 3

View of the swc AST that's easier to navigate.

bartlomieju/deno 2

A secure TypeScript runtime on V8

hayd/deno 2

A secure TypeScript runtime on V8

bartlomieju/deno_doc 1

Documentation generator for Deno

issue commentdenoland/deno

More deno bundle errors: Improve swc testing strategy

it feels like swc's testing strategy is a good issue potential discussion for swc

@kitsonk I agree, although the issue title might not be appropriately named. The issue is actually about testing swc as deno's bundler. In consideration of that, how will this be tracked within denoland?

jsejcksn

comment created time in 13 minutes

Pull request review commentdenoland/deno

BREAKING(coverage): move reporting into subcommand

 impl PrettyCoverageReporter {   } } -pub fn filter_script_coverages(-  coverages: Vec<Coverage>,-  test_file_url: Url,-  test_modules: Vec<Url>,-) -> Vec<Coverage> {-  coverages+fn collect_coverages(+  dir: &PathBuf,+  _ignore: Vec<PathBuf>,+) -> Result<Vec<Coverage>, AnyError> {+  let mut coverages: Vec<Coverage> = Vec::new();++  let entries = fs::read_dir(dir)?;+  for entry in entries {+    let json = fs::read_to_string(entry.unwrap().path())?;+    let coverage: Coverage = serde_json::from_str(&json)?;++    coverages.push(coverage);+  }++  coverages = coverages     .into_iter()-    .filter(|e| {-      if let Ok(url) = Url::parse(&e.script_coverage.url) {-        if url.path().ends_with("__anonymous__") {-          return false;-        }+    .filter(|e| !e.script_coverage.url.ends_with("__anonymous__"))+    .collect::<Vec<Coverage>>();

Reverted to a simpler filter for the time being.

caspervonb

comment created time in 44 minutes

issue commentdenoland/deno

Type Error With std/async/pool & a TSConfig

Don't worry about it, the core team can address it once we have a chat about it.

ebebbington

comment created time in an hour

issue commentdenoland/deno

More deno bundle errors: Improve swc testing strategy

@jsejcksn it feels like swc's testing strategy is a good issue potential discussion for swc. There is no need to re-open this issue in my opinion.

jsejcksn

comment created time in an hour

issue commentdenoland/deno

More deno bundle errors: Improve swc testing strategy

@kitsonk Does denoland use issues to track things like this?

If so, will you please reopen this issue?

If not, how are they tracked?

jsejcksn

comment created time in 2 hours

issue closeddenoland/deno

Publish on NPM?

So this is going to seem really dumb but I think it would be pretty cool if you published Deno binaries on NPM. It would be nice for projects that publish to Deno and NPM because then it would be easier to have one consistent version used by contributors and maintainers. Kind of like hugo-bin I guess. Also maybe make sure it has a different command in that (deno-bin?).

closed time in 2 hours

shadowtime2000

issue commentdenoland/deno

Publish on NPM?

There are sufficient ways to obtain Deno binaries already. Respectfully closing.

shadowtime2000

comment created time in 2 hours

issue commentdenoland/deno

More deno bundle errors: Improve swc testing strategy

No. Not yet.

jsejcksn

comment created time in 2 hours

issue openedrslint/rslint

Extensibility/modular definitions of new rules

Hello, excellent project!

What plans (if any) do you have so far for allowing end users to define their own sets of rules? One of the key "wins" provided by ESLint is that users can define their own rules and integrate them simply by providing them at a conventional path and then referring to them with ESLint's config. We use this extensively at LinkedIn to provide app-specific guidance, for rules specific to that project—whether due to technical limitations or simply to keep things consistent.

rslint (appropriately, in my view) is taking a different approach to configuration than ESLint does, and it will by necessity take a different approach to extensibility since the mechanics for doing this kind of thing with a compiled language are very different than they are for an interpreted language like JS/Node.

Obvious candidates:

  • Don't let users supply their own definitions, other than by forking rslint. (I believe this represents the current state of affairs?) This is the simplest, but also the least flexible for users.

  • Define an API for consumers to be able to supply dynamic libraries as “plugins”, which can be looked up from a conventional location and executed at runtime. This would have the best combination of performance and dynamic lookup, and would also most closely align… but would also almost certainly run into issues in short order due to Rust's lack of ABI stability. It would also require end users to actually do that build and/or distribute the binaries they build in some way.

  • Define an API/blueprint for consumers to be able run as separate binaries, the same way that binaries can work alongside something like the way cargo, git, etc. do this. This would probably require some kind of IPC with serialization (JSON?). It would also require end users to actually do that build and/or distribute the binaries they build in some way.

  • Follow SWC’s lead and make this consumable via WASM, which would (if carefully implemented!) still likely provide an order-of-magnitude speedup. I suspect this is the easiest story for extensibility from the perspective of end users… but also would presumably have the worst performance and the most implementation challenges on rslint’s end.

Thanks!

created time in 2 hours

issue commentdenoland/deno

More deno bundle errors: Improve swc testing strategy

@kdy1 It's been a while since I've looked at this. Has there been a new testing strategy implemented for swc?

jsejcksn

comment created time in 3 hours

issue openeddenoland/deno

Publish on NPM?

So this is going to seem really dumb but I think it would be pretty cool if you published Deno binaries on NPM. It would be nice for projects that publish to Deno and NPM because then it would be easier to have one consistent version used by contributors and maintainers. Kind of like hugo-bin I guess. Also maybe make sure it has a different command in that (deno-bin?).

created time in 3 hours

issue commentdenoland/vscode_deno

The img src links in the extension page are broken

Perhaps consider updating to links like these: https://github.com/denoland/vscode_deno/blob/v2/screenshot/screenshot.gif

Khobalt

comment created time in 3 hours

issue openeddenoland/vscode_deno

The img src links in the extension page are broken

The images are missing on the extension's landing page: https://marketplace.visualstudio.com/items?itemName=denoland.vscode-deno image

It seems as though they used to be hosted in this repository in the v2 branch: https://github.com/denoland/vscode_deno/raw/master/screenshot/screenshot.gif

created time in 3 hours

issue commentdenoland/deno

Type Error With std/async/pool & a TSConfig

I'll note that I'd have no clue where to start so it may well be i'm ill equipped to do so

ebebbington

comment created time in 4 hours

issue commentdenoland/deno

Type Error With std/async/pool & a TSConfig

@kitsonk If this is something you (or the core team) decide to go with, i'm happy to try implement it as I of course have my own reasons for the issue to be fixed - it sounds simple enough, depending on if rust will be used ;)

ebebbington

comment created time in 4 hours

issue commentdenoland/deno

Enable Deno namespace by default in Workers

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

nayeemrmn

comment created time in 4 hours

issue closeddprint/dprint-plugin-typescript

Missing space in JSX output

Describe the bug

dprint-plugin-typescript version: 0.38.3 playground

Input Code

function Test() {
    return <div>
        {foo} {bar}
    </div>;
}

Expected Output

function Test() {
    return <div>
        {foo} {bar}
    </div>;
}
// or
function Test() {
    return <div>
        {foo}
        {' '}
        {bar}
    </div>;
}

Actual Output (the space must be compensated with {' '}

function Test() {
    return <div>
        {foo}
        {bar}
    </div>;
}

closed time in 4 hours

thgh

issue commentdprint/dprint-plugin-typescript

Missing space in JSX output

This is #19. Closing, but I should really get on #19 now... I've also encountered this many times and it's an annoying bug.

thgh

comment created time in 4 hours

issue commentdprint/dprint-plugin-typescript

Invalid output for JSX comment

@thgh thanks for the great bug report!

thgh

comment created time in 5 hours

push eventdprint/dprint-plugin-typescript

David Sherret

commit sha 72f03fdca7e3fd690c8095d19ea9849578963865

fix: #89 - Support trailing comments on different lines within a JsxOpeningElement

view details

push time in 5 hours

issue closeddprint/dprint-plugin-typescript

Invalid output for JSX comment

Describe the bug

Comments in JSX tags are moved into the children when they don't appear on the same line as the component name. dprint-plugin-typescript version: 0.38.3 Several cases: playground

A different usecase

Input Code

function Test() {
  return <View
    // comment
  ></View>;
}

Expected Output

function Test() {
  return <View
    // comment
  />;
}

Actual Output

function Test() {
  return <View> // comment
  </View>;
}

closed time in 5 hours

thgh

issue openedswc-project/swc

@swc/wasm delaying process shutdown

Describe the bug

@swc/wasm appears to delay the graceful shutdown of a node process once it's loaded.

Input code

node -e 'require("@swc/wasm"); console.log("done.  Should ideally terminate immediately but is somehow delayed by @swc/wasm")'

The node process remains running for about 5 seconds after the log statement. I'm not sure if @swc/wasm is setting some sort of timer or why the process is staying up.

Expected behavior

node process gracefully terminates immediately after the log statement.

Version The version of @swc/wasm: 1.2.45 OS: Ubuntu Linux node: v14.15.3

created time in 6 hours

issue closeddenoland/deno

Add Node.js native module polyfills to std/node

Many Node.js native module polyfills are needed in std/node, to support loading npm packages (such that we are able to leverage some of the tools while Deno specific versions are not available yet).

Note some of the modules might not yet have a corresponding Deno API available. In that case, adding a new native binding for Deno or adding a new module in std modules might be reasonable.

#3382 is an example how to inject a polyfill for require().

Some of the polyfill tasks can be Good First Issue.

  • [x] buffer
  • [ ] child_process
  • [ ] cluster (maybe low priority?)
  • [ ] crypto
  • [ ] dns
  • [x] events
  • [ ] fs (partially, high priority)
  • [ ] http/https/http2/dgram/net/tls (maybe low priority?)
  • [x] modules
  • [x] os (more bindings needed, #3802)
  • [x] path
  • [x] querystring #4370
  • [ ] readline
  • [ ] repl
  • [ ] stream
  • [ ] tty
  • [ ] url
  • [ ] util (partially)

closed time in 7 hours

kevinkassimo

issue commentdenoland/deno

Type Error With std/async/pool & a TSConfig

Not in lib.dom in lib.dom.iterable @lucacasonato but for some reason they don't have any async iterables in there.

There is already an issue: https://github.com/microsoft/TypeScript/issues/29867

Considering that it has been open for a couple years with no action, maybe we need to add a custom lib, like we did for a couple other things.

ebebbington

comment created time in 8 hours

issue commentdenoland/deno

Q1 2021 roadmap

This isn't the place to put random comments about a wish list. This is an issue to communicate what the core team is working on. Other suggestions should be made in their own issue or discussions, and with more detail than a couple words.

bartlomieju

comment created time in 8 hours

issue commentdenoland/deno

Q1 2021 roadmap

Server-side rendering (SSR) native support

bartlomieju

comment created time in 9 hours

issue closeddenoland/deno

suggestion(std/examples): import from URL instead of relative path

New users use examples as tutorial. They change scripts to understand how deno works. However present scripts use import from relative path therefore they have to change it to import from URL before they modify script.

I suggest to use import from URL instead of relative path for easy to start

closed time in 9 hours

tokiedokie

issue closeddenoland/deno

http/file_server close with Uncaught Error: Short write

Not every time an exception is thrown, but most are

$ file_server
Compile https://deno.land/std/http/file_server.ts
HTTP server listening on http://0.0.0.0:4500/
[2019-12-10 02:51:41] "GET /bin/dvm_windows_amd64.tar.gz HTTP/1.1" 200
error: Uncaught Error: Short write
► https://deno.land/std/io/bufio.ts:458:18

458       this.err = new Error("Short write");
                     ^

    at flush (https://deno.land/std/io/bufio.ts:458:18)

closed time in 9 hours

axetroy

pull request commentdenoland/deno

[WIP] ffi support

I think the big effort of Wasm and Wasi is keeping js away from ISA dependent binary code, why bring FFI back to make it complex again? I think someone could argue that they need FFI for low level hardware access, but it think it could provide by the runtime(browser or deno) itself for standardisation. Have a look of the new Web Serial API and Web NFC API in Chrome 89. A restricted but "run everywhere" is unique and is its strength for deno comparing to go and rust.

manyuanrong

comment created time in 10 hours

issue commentdenoland/deno

Type Error With std/async/pool & a TSConfig

@lucacasonato Should i log an issue with them instead then?

ebebbington

comment created time in 10 hours

more