profile
viewpoint
Michaël Gallego bakura10 Sapporo, Japan

bakura10/DoctrineModule 4

Zend Framework 2 Module for Doctrine

bakura10/aws-missing-tools 3

Extensions to Amazon's AWS CLI Tools.

bakura10/DoctrineORMModule 1

Zend Framework 2 Module for Doctrine ORM

bakura10/aws-sdk-php 0

Official repository of the AWS SDK for PHP (@awsforphp)

bakura10/aws-sdk-php-zf2 0

ZF2 module for using the AWS SDK for PHP to interact with AWS services like S3, DynamoDB, SQS, EC2, etc.

bakura10/BaconUser 0

BaconUser provides simple user management

bakura10/bref 0

Serverless PHP on AWS Lambda

bakura10/broccoli-sass 0

Sass compiler for Broccoli, using libsass

fork samsonasik/ZfcAdmin

Admin interface for Zend Framework 2 modules - ZfcAdmin is a ZF-Commons initiative.

fork in 12 hours

fork samsonasik/ZfcBase

A set of generic (abstract) classes which are commonly used across multiple modules. (Formerly EdpCommon)

fork in 12 hours

fork samsonasik/Eye4webZf2Board

Board (forum) for Zend Framework 2

fork in 12 hours

pull request commentJouwWeb/SlmQueueSqs

change lib to use laminas instead of zend

yes sure

On Mon, Nov 30, 2020, 23:34 Roel van Duijnhoven notifications@github.com wrote:

Allright, let's figure that out in another PR or issue. So as far as you are concerned, we can release this repo @habibillah https://github.com/habibillah :)?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JouwWeb/SlmQueueSqs/pull/56#issuecomment-735897176, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEFSFWDFWFV5QLXQHHBOEDSSPCSFANCNFSM4T2CHLDQ .

habibillah

comment created time in 2 days

pull request commentJouwWeb/SlmQueueSqs

change lib to use laminas instead of zend

Allright, let's figure that out in another PR or issue. So as far as you are concerned, we can release this repo @habibillah :)?

habibillah

comment created time in 2 days

pull request commentJouwWeb/SlmQueueSqs

change lib to use laminas instead of zend

No no. I mean, because of a few issues my app does not utilize aws/aws-sdk-php-zf2. because I save my aws credential in database, I simply build my factory file look like below (doesn't follow your doc)

class SqsClientFactory implements FactoryInterface
{
    public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
    {
        /** @var OptionsTable $optionsTable */
        $optionsTable = $container->get(OptionsTable::class);

        return new SqsClient([
            'version'     => 'latest',
            'region'      => 'us-east-1',
            'credentials' => [
                'key' => $optionsTable->fetchByName('amazon_key')['value'] ?? '',
                'secret' => $optionsTable->fetchByName('amazon_secret')['value'] ?? '',
            ],
        ]);
    }
}

Some people may still use aws/aws-sdk-php-zf2 to automatically build their dependency to aws/aws-sdk-php, so I think it better to keep it there. I also tested using in simple app using aws/aws-sdk-php-zf2 and it work well as long you use composer v1. my notes above just in case you or other user use composer v2, you may get those error.

habibillah

comment created time in 2 days

pull request commentJouwWeb/SlmQueueSqs

change lib to use laminas instead of zend

@habibillah So what you are telling me is that your PR does not use aws/aws-sdk-php-zf2? If so: let's change the dependency from aws/aws-sdk-php-zf2 rto aws/aws-sdk-php. Right?

habibillah

comment created time in 2 days

pull request commentJouwWeb/SlmQueueSqs

change lib to use laminas instead of zend

I think you will get issue with aws/aws-sdk-php-zf2. that lib moved to use Laminas in v4.3. if you use composer v2 you will get conflict on laminas/laminas-dependency-plugin

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - laminas/laminas-dependency-plugin[1.0.0, ..., 1.0.4] require composer-plugin-api ^1.1 -> found composer-plugin-api[2.0.0] but it does not match the constraint.
    - aws/aws-sdk-php-zf2 4.3.0 requires laminas/laminas-dependency-plugin ^1.0 -> satisfiable by laminas/laminas-dependency-plugin[1.0.0, ..., 1.0.4].
    - Root composer.json requires aws/aws-sdk-php-zf2 ^4.3 -> satisfiable by aws/aws-sdk-php-zf2[4.3.0].

Fortunately, my project don't use aws/aws-sdk-php-zf2, but directly use aws/aws-sdk-php. So nothing issue in my end

habibillah

comment created time in 5 days

pull request commentJouwWeb/SlmQueueSqs

change lib to use laminas instead of zend

I have tested on my end, and it work well.

habibillah

comment created time in 5 days

pull request commentJouwWeb/SlmQueueSqs

change lib to use laminas instead of zend

Allright, looks fine to me! Great work @habibillah :clap:.

My plan is to first release a beta version. You can than test and use that version yourself. If no bugs occur, we can release a new major version.

But.. before I do that. Are there any deprecations or other notable problems with this new update that need to go into the changelog?

habibillah

comment created time in 8 days

startedFriendsOfPHP/pickle

started time in 8 days

pull request commentJouwWeb/SlmQueueSqs

change lib to use laminas instead of zend

yes please

On Tue, Nov 24, 2020 at 3:42 PM Roel van Duijnhoven < notifications@github.com> wrote:

Please let me know if you want me to review again @habibillah https://github.com/habibillah.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JouwWeb/SlmQueueSqs/pull/56#issuecomment-732745572, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEFSFQH4L3E4F43TVS6WOTSRNWWDANCNFSM4T2CHLDQ .

habibillah

comment created time in 9 days

pull request commentJouwWeb/SlmQueueSqs

change lib to use laminas instead of zend

Please let me know if you want me to review again @habibillah.

habibillah

comment created time in 9 days

issue openedJouwWeb/SlmQueueBeanstalkd

Set-up integration test that actually uses a Beanstalkd instance

This should be possible by utilizing a docker image.

Benefits is that we get a higher degree of whether this is functioning.

@taat I'll menion you also on this issue. Maybe if you feel the same way, we could try to do this together after your PR is merged.

created time in 10 days

Pull request review commentJouwWeb/SlmQueueBeanstalkd

Add: Rewrite to support latest Laminas, Pheanstalk and PHPUnit

 <?php -return array(-    'service_manager' => array(-        'factories' => array(-            'SlmQueueBeanstalkd\Options\BeanstalkdOptions' => 'SlmQueueBeanstalkd\Factory\BeanstalkdOptionsFactory',-            'SlmQueueBeanstalkd\Service\PheanstalkService' => 'SlmQueueBeanstalkd\Factory\PheanstalkFactory',-            'SlmQueueBeanstalkd\Worker\BeanstalkdWorker'   => 'SlmQueue\Factory\WorkerFactory'-        )-    ),--    'controllers' => array(-        'factories' => array(-            'SlmQueueBeanstalkd\Controller\BeanstalkdWorkerController' => 'SlmQueueBeanstalkd\Factory\BeanstalkdWorkerControllerFactory',-        ),-    ),+use SlmQueue\Strategy\MaxRunsStrategy;+use SlmQueueBeanstalkd\Factory\BeanstalkdQueueFactory;+use SlmQueue\Factory\WorkerFactory;+use SlmQueueBeanstalkd\Controller\BeanstalkdWorkerController;+use SlmQueueBeanstalkd\Factory\BeanstalkdWorkerControllerFactory;+use SlmQueueBeanstalkd\Strategy\ClearObjectManagerStrategy;+use SlmQueueBeanstalkd\Worker\BeanstalkdWorker; -    'console'   => array(-        'router' => array(-            'routes' => array(-                'slm-queue-beanstalked-worker' => array(+return [+    'service_manager' => [+        'factories' => [+            BeanstalkdWorker::class => WorkerFactory::class,+            \Pheanstalk::class => \SlmQueueBeanstalkd\Factory\PheanstalkFactory::class+        ]+    ],+    'controllers'     => [+        'factories' => [+            BeanstalkdWorkerController::class => BeanstalkdWorkerControllerFactory::class,+            \Pheanstalk::class => \SlmQueueBeanstalkd\Factory\PheanstalkFactory::class+        ],+    ],+    'console'         => [+        'router' => [+            'routes' => [+                'slm-queue-Beanstalkd-worker'  => [                     'type'    => 'Simple',-                    'options' => array(-                        'route'    => 'queue beanstalkd <queue> [--timeout=]',-                        'defaults' => array(-                            'controller' => 'SlmQueueBeanstalkd\Controller\BeanstalkdWorkerController',+                    'options' => [+                        'route'    => 'queue Beanstalkd <queue> [--timeout=] --start',

I find the way we use an argument to decide what action we are going to do perform a little bit strange. Let's remodel those to:

  • queue beanstalkd start <queue> [--timeout]
  • queue beanstalkd recover <queue>
  • etc..
taat

comment created time in 10 days

Pull request review commentJouwWeb/SlmQueueBeanstalkd

Add: Rewrite to support latest Laminas, Pheanstalk and PHPUnit

+<?php++namespace SlmQueueBeanstalkd\Options;++use Laminas\Stdlib\AbstractOptions;+use Pheanstalk\Pheanstalk;++class JobOptions extends AbstractOptions {+    protected $__strictMode__ = false;

What does strict mode do? And why is it wrapped around with __? Please do add a comment about this.

taat

comment created time in 10 days

Pull request review commentJouwWeb/SlmQueueBeanstalkd

Add: Rewrite to support latest Laminas, Pheanstalk and PHPUnit

+<?php++namespace SlmQueueBeanstalkd;++use Laminas\Console\Adapter\AdapterInterface;+use Laminas\ModuleManager\Feature\ConsoleBannerProviderInterface;+use Laminas\ModuleManager\Feature\ConsoleUsageProviderInterface;+use Laminas\Console\Adapter\AdapterInterface as Console;++/**+ * SlmQueueBeanstalkd+ */+class Module implements ConsoleBannerProviderInterface, ConsoleUsageProviderInterface+{+    const VERSION = '2.0.0-dev';++    public function getConfig()+    {+        return include __DIR__ . '/../config/module.config.php';+    }++    /**+     * Returns a string containing a banner text, that describes the module and/or the application.+     * The banner is shown in the console window, when the user supplies invalid command-line parameters or invokes+     * the application with no parameters.+     *+     * The method is called with active Laminas\Console\Adapter\AdapterInterface that can be used to directly access+     * Console and send output.+     *+     * @param AdapterInterface $console+     * @return string|null+     */+    public function getConsoleBanner(Console $console)+    {+        return 'SlmQueueBeanstalkd Module v.' . self::VERSION;+    }++    /**+     * Returns an array or a string containing usage information for this module's Console commands.+     * The method is called with active Laminas\Console\Adapter\AdapterInterface that can be used to directly access+     * Console and send output.+     *+     * If the result is a string it will be shown directly in the console window.+     * If the result is an array, its contents will be formatted to console window width. The array must+     * have the following format:+     *+     *     return array(+     *                'Usage information line that should be shown as-is',+     *                'Another line of usage info',+     *+     *                '--parameter'        =>   'A short description of that parameter',+     *                '-another-parameter' =>   'A short description of another parameter',+     *                ...+     *            )+     *+     * @param AdapterInterface $console+     * @return array|string|null+     */+    public function getConsoleUsage(Console $console)+    {+        return [+            'queue beanstalkd <queue> --start [--timeout=]'             => 'Process Beanstalkd queue',+            'queue beanstalkd <queue> --recover [--executionTime=]'     => 'Recover Beanstalkd worker',

stats is missing here.

taat

comment created time in 10 days

Pull request review commentJouwWeb/SlmQueueBeanstalkd

Add: Rewrite to support latest Laminas, Pheanstalk and PHPUnit

+<?php++namespace SlmQueueBeanstalkd\Job;++use Pheanstalk\Contract\JobIdInterface;++class JobId implements JobIdInterface  {+    /**+     * JobId constructor.+     * @param int $id+     */+    public function __construct(int $id = null)+    {+        $this->id = $id;+    }++    /**

Feel free to remove the PHPDoc on every method call that is allready fully typed :). Or remove useles comments about constructors and such.

taat

comment created time in 10 days

Pull request review commentJouwWeb/SlmQueueBeanstalkd

Add: Rewrite to support latest Laminas, Pheanstalk and PHPUnit

+<?php++namespace SlmQueueBeanstalkd\Controller;++use SlmQueue\Controller\AbstractWorkerController;+use SlmQueue\Controller\Exception\WorkerProcessException;+use SlmQueue\Exception\ExceptionInterface;+use SlmQueue\Queue\QueuePluginManager;+use SlmQueueBeanstalkd\Queue\BeanstalkdQueueInterface;++/**+ * Worker controller+ */+class BeanstalkdWorkerController extends AbstractWorkerController+{+    /**+     * Recover long running jobs+     */+    public function recoverAction(): string+    {+        $queueName     = $this->params('queue');+        $executionTime = $this->params('executionTime', 0);+        $queue         = $this->queuePluginManager->get($queueName);++        if (! $queue instanceof BeanstalkdQueueInterface) {+            return sprintf("\nQueue % does not support the recovering of job\n\n", $queueName);+        }++        try {+            $count = $queue->recover($executionTime);+        } catch (ExceptionInterface $exception) {+            throw new WorkerProcessException("An error occurred", $exception->getCode(), $exception);+        }++        return sprintf(+            "\nWork for queue %s is done, %s jobs were recovered\n\n",+            $queueName,+            $count+        );+    }++    public function processAction(): string+    {+        $options = $this->params()->fromRoute();+        $name = $options['queue'];+        $queue = $this->queuePluginManager->get($name);++        try {+            $messages = $this->worker->processQueue($queue, $options);+        } catch (ExceptionInterface $e) {+            throw new WorkerProcessException(+                'Caught exception while processing queue',+                $e->getCode(),+                $e+            );+        }++        return $this->formatOutput($name, $messages);+    }++    public function statsAction() {+        // @todo

TODO

taat

comment created time in 10 days

Pull request review commentJouwWeb/SlmQueueBeanstalkd

Add: Rewrite to support latest Laminas, Pheanstalk and PHPUnit

+<?php++namespace SlmQueueBeanstalkd\Job;++use Pheanstalk\Contract\JobIdInterface;++class JobId implements JobIdInterface  {

Formatting is of here. You can use https://github.com/JouwWeb/SlmQueue/blob/master/phpcs.xml to auto format your files if you want.

taat

comment created time in 10 days

Pull request review commentJouwWeb/SlmQueueBeanstalkd

Add: Rewrite to support latest Laminas, Pheanstalk and PHPUnit

 <?php -namespace SlmQueueBeanstalkd;--use Zend\Loader;-use Zend\Console\Adapter\AdapterInterface;-use Zend\ModuleManager\Feature;--/**- * SlmQueueBeanstalkd- */-class Module implements-    Feature\AutoloaderProviderInterface,-    Feature\ConfigProviderInterface,-    Feature\ConsoleBannerProviderInterface,-    Feature\ConsoleUsageProviderInterface-{-    /**-     * {@inheritDoc}-     */-    public function getAutoloaderConfig()-    {-        return array(-            Loader\AutoloaderFactory::STANDARD_AUTOLOADER => array(-                Loader\StandardAutoloader::LOAD_NS => array(-                    __NAMESPACE__ => __DIR__ . '/src/' . __NAMESPACE__,-                ),-            ),-        );-    }--    /**-     * {@inheritDoc}-     */-    public function getConfig()-    {-        return include __DIR__ . '/config/module.config.php';-    }--    /**-     * {@inheritDoc}-     */-    public function getConsoleBanner(AdapterInterface $console)-    {-        return 'SlmQueueBeanstalkd';-    }--    /**-     * {@inheritDoc}-     */-    public function getConsoleUsage(AdapterInterface $console)-    {-        return array(-            'queue beanstalkd <queue> [--timeout=]' => 'Process jobs with beanstalkd',--            array('<queue>', 'Queue\'s name to process'),-            array('--timeout=', 'Timeout (in seconds) to wait for a job to arrive')-        );-    }--    /**-     * {@inheritDoc}-     */-    public function getModuleDependencies()-    {-        return array('SlmQueue');-    }-}+require __DIR__ . '/src/Module.php';

Could you configure your IDE so each line ends with a return? See the warning GitHub issues here.

taat

comment created time in 10 days

Pull request review commentJouwWeb/SlmQueueBeanstalkd

Add: Rewrite to support latest Laminas, Pheanstalk and PHPUnit

 <?php -return array(-    'service_manager' => array(-        'factories' => array(-            'SlmQueueBeanstalkd\Options\BeanstalkdOptions' => 'SlmQueueBeanstalkd\Factory\BeanstalkdOptionsFactory',-            'SlmQueueBeanstalkd\Service\PheanstalkService' => 'SlmQueueBeanstalkd\Factory\PheanstalkFactory',-            'SlmQueueBeanstalkd\Worker\BeanstalkdWorker'   => 'SlmQueue\Factory\WorkerFactory'-        )-    ),--    'controllers' => array(-        'factories' => array(-            'SlmQueueBeanstalkd\Controller\BeanstalkdWorkerController' => 'SlmQueueBeanstalkd\Factory\BeanstalkdWorkerControllerFactory',-        ),-    ),+use SlmQueue\Strategy\MaxRunsStrategy;+use SlmQueueBeanstalkd\Factory\BeanstalkdQueueFactory;+use SlmQueue\Factory\WorkerFactory;+use SlmQueueBeanstalkd\Controller\BeanstalkdWorkerController;+use SlmQueueBeanstalkd\Factory\BeanstalkdWorkerControllerFactory;+use SlmQueueBeanstalkd\Strategy\ClearObjectManagerStrategy;+use SlmQueueBeanstalkd\Worker\BeanstalkdWorker; -    'console'   => array(-        'router' => array(-            'routes' => array(-                'slm-queue-beanstalked-worker' => array(+return [+    'service_manager' => [+        'factories' => [+            BeanstalkdWorker::class => WorkerFactory::class,+            \Pheanstalk::class => \SlmQueueBeanstalkd\Factory\PheanstalkFactory::class+        ]+    ],+    'controllers'     => [+        'factories' => [+            BeanstalkdWorkerController::class => BeanstalkdWorkerControllerFactory::class,+            \Pheanstalk::class => \SlmQueueBeanstalkd\Factory\PheanstalkFactory::class+        ],+    ],+    'console'         => [+        'router' => [+            'routes' => [+                'slm-queue-Beanstalkd-worker'  => [                     'type'    => 'Simple',-                    'options' => array(-                        'route'    => 'queue beanstalkd <queue> [--timeout=]',-                        'defaults' => array(-                            'controller' => 'SlmQueueBeanstalkd\Controller\BeanstalkdWorkerController',+                    'options' => [+                        'route'    => 'queue Beanstalkd <queue> [--timeout=] --start',+                        'defaults' => [+                            'controller' => BeanstalkdWorkerController::class,                             'action'     => 'process'-                        ),-                    ),-                ),-            ),-        ),-    ),--    'slm_queue' => array(-        'beanstalkd' => array(-            'connection' => array(-                'host'    => '0.0.0.0',-                'port'    => 11300,-                'timeout' => 2-            )+                        ],+                    ],+                ],+                'slm-queue-Beanstalkd-recover' => [+                    'type'    => 'Simple',+                    'options' => [+                        'route'    => 'queue Beanstalkd <queue> --recover [--executionTime=]',+                        'defaults' => [+                            'controller' => BeanstalkdWorkerController::class,+                            'action'     => 'recover'+                        ],+                    ],+                ],+                'slm-queue-Beanstalkd-stats' => [+                    'type'    => 'Simple',+                    'options' => [+                        'route'    => 'queue Beanstalkd <queue> --stats',+                        'defaults' => [+                            'controller' => BeanstalkdWorkerController::class,+                            'action'     => 'stats'+                        ],+                    ],+                ],+            ],+        ],+    ],+    'slm_queue' => [

I think everything below this line is some dummy / TODO code, that should now be removed. Right?

taat

comment created time in 10 days

Pull request review commentJouwWeb/SlmQueueBeanstalkd

Add: Rewrite to support latest Laminas, Pheanstalk and PHPUnit

 <?php -return array(-    'service_manager' => array(-        'factories' => array(-            'SlmQueueBeanstalkd\Options\BeanstalkdOptions' => 'SlmQueueBeanstalkd\Factory\BeanstalkdOptionsFactory',-            'SlmQueueBeanstalkd\Service\PheanstalkService' => 'SlmQueueBeanstalkd\Factory\PheanstalkFactory',-            'SlmQueueBeanstalkd\Worker\BeanstalkdWorker'   => 'SlmQueue\Factory\WorkerFactory'-        )-    ),--    'controllers' => array(-        'factories' => array(-            'SlmQueueBeanstalkd\Controller\BeanstalkdWorkerController' => 'SlmQueueBeanstalkd\Factory\BeanstalkdWorkerControllerFactory',-        ),-    ),+use SlmQueue\Strategy\MaxRunsStrategy;+use SlmQueueBeanstalkd\Factory\BeanstalkdQueueFactory;+use SlmQueue\Factory\WorkerFactory;+use SlmQueueBeanstalkd\Controller\BeanstalkdWorkerController;+use SlmQueueBeanstalkd\Factory\BeanstalkdWorkerControllerFactory;+use SlmQueueBeanstalkd\Strategy\ClearObjectManagerStrategy;+use SlmQueueBeanstalkd\Worker\BeanstalkdWorker; -    'console'   => array(-        'router' => array(-            'routes' => array(-                'slm-queue-beanstalked-worker' => array(+return [+    'service_manager' => [+        'factories' => [+            BeanstalkdWorker::class => WorkerFactory::class,+            \Pheanstalk::class => \SlmQueueBeanstalkd\Factory\PheanstalkFactory::class+        ]+    ],+    'controllers'     => [+        'factories' => [+            BeanstalkdWorkerController::class => BeanstalkdWorkerControllerFactory::class,+            \Pheanstalk::class => \SlmQueueBeanstalkd\Factory\PheanstalkFactory::class+        ],+    ],+    'console'         => [+        'router' => [+            'routes' => [+                'slm-queue-Beanstalkd-worker'  => [                     'type'    => 'Simple',-                    'options' => array(-                        'route'    => 'queue beanstalkd <queue> [--timeout=]',-                        'defaults' => array(-                            'controller' => 'SlmQueueBeanstalkd\Controller\BeanstalkdWorkerController',+                    'options' => [+                        'route'    => 'queue Beanstalkd <queue> [--timeout=] --start',

Let's keep the lower case b. I think that is better, and it is identical to before.

taat

comment created time in 10 days

Pull request review commentJouwWeb/SlmQueueSqs

change lib to use laminas instead of zend

         }     ],     "require": {-        "php": "^5.5 || ^7.0",-        "zendframework/zend-eventmanager": "^2.6 || ^3.0",-        "zendframework/zend-servicemanager": "^2.7 || ^3.0",-        "zendframework/zend-stdlib": "^2.2 || ^3.0",-        "slm/queue": "^1.0",+        "ext-json": "*",+        "php": "^7.2",+        "laminas/laminas-eventmanager": "^2.6 || ^3.0",+        "laminas/laminas-servicemanager": "^2.7 || ^3.0",+        "laminas/laminas-stdlib": "^2.2 || ^3.0",+        "slm/queue": "^2.0",         "aws/aws-sdk-php-zf2": "^3.0 || ^4.0"

Would it be an idea to bump this to >= 4.0?

habibillah

comment created time in 10 days

Pull request review commentJouwWeb/SlmQueueSqs

change lib to use laminas instead of zend

 class SqsQueue extends AbstractQueue implements SqsQueueInterface     /**      * Constructor      *-     * @param SqsClient        $sqsClient-     * @param SqsQueueOptions  $options-     * @param string           $name+     * @param SqsClient $sqsClient

You can simply remove the PHPDoc if the arguments in the function are allready typed :scissors:.

habibillah

comment created time in 10 days

Pull request review commentJouwWeb/SlmQueueSqs

change lib to use laminas instead of zend

         }     ],     "require": {-        "php": "^5.5 || ^7.0",-        "zendframework/zend-eventmanager": "^2.6 || ^3.0",-        "zendframework/zend-servicemanager": "^2.7 || ^3.0",-        "zendframework/zend-stdlib": "^2.2 || ^3.0",-        "slm/queue": "^1.0",+        "ext-json": "*",+        "php": "^7.2",+        "laminas/laminas-eventmanager": "^2.6 || ^3.0",+        "laminas/laminas-servicemanager": "^2.7 || ^3.0",+        "laminas/laminas-stdlib": "^2.2 || ^3.0",
        "laminas/laminas-stdlib": "^3.2",
habibillah

comment created time in 10 days

Pull request review commentJouwWeb/SlmQueueSqs

change lib to use laminas instead of zend

         }     ],     "require": {-        "php": "^5.5 || ^7.0",-        "zendframework/zend-eventmanager": "^2.6 || ^3.0",-        "zendframework/zend-servicemanager": "^2.7 || ^3.0",-        "zendframework/zend-stdlib": "^2.2 || ^3.0",-        "slm/queue": "^1.0",+        "ext-json": "*",+        "php": "^7.2",+        "laminas/laminas-eventmanager": "^2.6 || ^3.0",+        "laminas/laminas-servicemanager": "^2.7 || ^3.0",
        "laminas/laminas-servicemanager": "^3.3.1",
habibillah

comment created time in 10 days

Pull request review commentJouwWeb/SlmQueueSqs

change lib to use laminas instead of zend

         }     ],     "require": {-        "php": "^5.5 || ^7.0",-        "zendframework/zend-eventmanager": "^2.6 || ^3.0",-        "zendframework/zend-servicemanager": "^2.7 || ^3.0",-        "zendframework/zend-stdlib": "^2.2 || ^3.0",-        "slm/queue": "^1.0",+        "ext-json": "*",+        "php": "^7.2",+        "laminas/laminas-eventmanager": "^2.6 || ^3.0",
        "laminas/laminas-eventmanager": "^3.2.1",
habibillah

comment created time in 10 days

Pull request review commentJouwWeb/SlmQueueSqs

change lib to use laminas instead of zend

 cache:     - vendor  php:-  - 5.5-  - 5.6-  - 7.0--env:-  matrix:-    - PREFER_LOWEST="--prefer-lowest"-    - PREFER_LOWEST=""+  - 7.2

I would suggest to copy the stuff from https://github.com/JouwWeb/SlmQueue/blob/master/.travis.yml. That way you test more future versions, and the repos are more in sync :).

habibillah

comment created time in 10 days

more