profile
viewpoint
Jan-Erik Rediger badboy Mozilla World https://fnordig.de/ @rustfesteu organizer

alexmchale/try.redis 149

A demonstration of the Redis database.

badboy/base-emoji-rs 6

Output a buffer ([0xde, 0xad, 0xbe, 0xef]) in emojis ("️🐼 🚓 👅)

badboy/badbill 4

A client for the Billomat API

badboy/bygge 4

Build your project.

badboy/avv 2

unofficial fahrplan.avv.de command line client

badboy/android-components 1

A collection of Android libraries to build browsers or browser-like applications.

badboy/android-loc-map 1

Plot your Android Location Cache Data on Google Maps

push eventRustFestEU/blog.rustfest.eu

Jan-Erik Rediger

commit sha 1f33708b509345c3723e22a92e9e96827168c89e

Make the link bigger

view details

push time in 7 hours

delete branch RustFestEU/blog.rustfest.eu

delete branch : schedule-announcement

delete time in 7 hours

push eventRustFestEU/blog.rustfest.eu

Jan-Erik Rediger

commit sha 987954897addec5dde3eecd263870764e3eb0791

Schedule announcement (#103)

view details

push time in 7 hours

push eventberlinrs/berline.rs

Jan-Erik Rediger

commit sha 3204e8d58a63916dfee85e08dbef00cc71da9d6f

Remove not-really-tracked projects list

view details

Jan-Erik Rediger

commit sha 529d3777f6b22480492910d24ee85358371839b0

Cancel the next event

view details

push time in 9 hours

delete branch berlinrs/berline.rs

delete branch : badboy-patch-1

delete time in 9 hours

delete branch berlinrs/berline.rs

delete branch : hide-projects

delete time in 9 hours

delete branch berlinrs/berline.rs

delete branch : master

delete time in 9 hours

create barnchberlinrs/berline.rs

branch : main

created branch time in 9 hours

push eventRustFestEU/blog.rustfest.eu

Jan-Erik Rediger

commit sha 93435002f10a76adf03aa145360970f9f2607111

schedule announcement

view details

Jan-Erik Rediger

commit sha ec4f4226c18c40e034bdc56d9c935ddd4cf8230d

more font-weight for text, less for headers

view details

push time in 10 hours

create barnchRustFestEU/blog.rustfest.eu

branch : schedule-announcement

created branch time in 10 hours

push eventbadboy/whatrustisit

Deployment Bot (from Travis CI)

commit sha 22b51f20c021fec2759f849addb4d1d81743b72b

Deploy badboy/whatrustisit to github.com/badboy/whatrustisit.git:gh-pages

view details

push time in 15 hours

push eventbadboy/whatrustisit

Deployment Bot (from Travis CI)

commit sha 896145757febfad11f9364adb9183676970bb3b8

Deploy badboy/whatrustisit to github.com/badboy/whatrustisit.git:gh-pages

view details

push time in 2 days

push eventbadboy/whatrustisit

Deployment Bot (from Travis CI)

commit sha b6809fdf2c04a7bfc2946d5c6494326a2d80d7c4

Deploy badboy/whatrustisit to github.com/badboy/whatrustisit.git:gh-pages

view details

push time in 3 days

PR closed mozilla/glean

Bump crossbeam-channel from 0.4.4 to 0.5.0 dependencies rust

Bumps crossbeam-channel from 0.4.4 to 0.5.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/crossbeam-rs/crossbeam/blob/master/CHANGELOG.md">crossbeam-channel's changelog</a>.</em></p> <blockquote> <h1>Version 0.5.0</h1> <ul> <li>Update <code>crossbeam-channel</code> to 0.3.</li> <li>Update <code>crossbeam-utils</code> to 0.6.</li> <li>Add <code>AtomicCell</code>, <code>SharedLock</code>, and <code>WaitGroup</code>.</li> </ul> <h1>Version 0.4.1</h1> <ul> <li>Fix a double-free bug in <code>MsQueue</code> and <code>SegQueue</code>.</li> </ul> <h1>Version 0.4</h1> <ul> <li>Switch to the new implementation of epoch-based reclamation in <a href="https://github.com/crossbeam-rs/crossbeam-epoch"><code>crossbeam-epoch</code></a>, fixing numerous bugs in the old implementation. Its API is changed in a backward-incompatible way.</li> <li>Switch to the new implementation of <code>CachePadded</code> and scoped thread in <a href="https://github.com/crossbeam-rs/crossbeam-utils"><code>crossbeam-utils</code></a>. The scoped thread API is changed in a backward-incompatible way.</li> <li>Switch to the new implementation of Chase-Lev deque in <a href="https://github.com/crossbeam-rs/crossbeam-deque"><code>crossbeam-deque</code></a>. Its API is changed in a backward-incompatible way.</li> <li>Export channel implemented in <a href="https://github.com/crossbeam-rs/crossbeam-channel"><code>crossbeam-channel</code></a>.</li> <li>Remove <code>AtomicOption</code>.</li> <li>Implement <code>Default</code> and <code>From</code> traits.</li> </ul> <h1>Version 0.3</h1> <ul> <li>Introduced <code>ScopedThreadBuilder</code> with the ability to name threads and set stack size</li> <li><code>Worker</code> methods in the Chase-Lev deque don't require mutable access anymore</li> <li>Fixed a bug when unblocking <code>pop()</code> in <code>MsQueue</code></li> <li>Implemented <code>Drop</code> for <code>MsQueue</code>, <code>SegQueue</code>, and <code>TreiberStack</code></li> <li>Implemented <code>Default</code> for <code>TreiberStack</code></li> <li>Added <code>is_empty</code> to <code>SegQueue</code></li> <li>Renamed <code>mem::epoch</code> to <code>epoch</code></li> <li>Other bug fixes</li> </ul> <h1>Version 0.2</h1> <ul> <li>Changed existing non-blocking <code>pop</code> methods to <code>try_pop</code></li> <li>Added blocking <code>pop</code> support to Michael-Scott queue</li> <li>Added Chase-Lev work-stealing deque</li> </ul> <h1>Version 0.1</h1> <ul> <li>Added <a href="http://aturon.github.io/blog/2015/08/27/epoch/">epoch-based memory management</a></li> <li>Added Michael-Scott queue</li> <li>Added Segmented array queue</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/d9dfc9e1ffabcb3c01addad14878f16c2795c371"><code>d9dfc9e</code></a> Merge <a href="https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/581">#581</a></li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/2a3d84b8dbaa9554c6705d5318fab76005ac2a44"><code>2a3d84b</code></a> Prepare for the next release</li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/5ea6e705eadefe4cb454a14c723ffe77b15cd89a"><code>5ea6e70</code></a> Merge <a href="https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/580">#580</a></li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/b363b3dcd72e9caee55f4daafd47f9385984e20a"><code>b363b3d</code></a> Fix UB in destroy_array test</li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/e08b21cc086fc42af0e9927a68bc3120bee87af5"><code>e08b21c</code></a> Merge <a href="https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/577">#577</a></li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/6217abf4a97b85c22b8dbae247503779af182741"><code>6217abf</code></a> Ignore clippy::match_like_matches_macro lint</li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/9cbfae7380c902dd29cf83c812cf1d721f970c96"><code>9cbfae7</code></a> Update cfg-if to 1</li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/24447495c9e3f0cf2d98606263273e2f9b427d9b"><code>2444749</code></a> Merge <a href="https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/574">#574</a></li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/619f7db2dfae7bd683d6ebb7e9aeb062409c54ed"><code>619f7db</code></a> Fixed a few typos</li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/7cc83772635bab80b28daadfd0a3d911554884be"><code>7cc8377</code></a> Better plot.py with Python 3 & remove hard code (<a href="https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/569">#569</a>)</li> <li>Additional commits viewable in <a href="https://github.com/crossbeam-rs/crossbeam/compare/crossbeam-channel-0.4.4...crossbeam-channel-0.5.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+450 -418

1 comment

2 changed files

dependabot[bot]

pr closed time in 3 days

pull request commentmozilla/glean

Bump crossbeam-channel from 0.4.4 to 0.5.0

Delaying that update for coordination with m-c

dependabot[bot]

comment created time in 3 days

PR closed mozilla/glean

Bump env_logger from 0.7.1 to 0.8.1 dependencies rust

Bumps env_logger from 0.7.1 to 0.8.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/env-logger-rs/env_logger/releases">env_logger's releases</a>.</em></p> <blockquote> <h2>0.8.1</h2> <p>Update links in the documentation that were pointing to the old repository location.</p> <h2>0.8.0</h2> <p>Breaking changes:</p> <ul> <li>Update public dependency humantime to 2.0</li> </ul> <p>Improvements:</p> <ul> <li>Update default colors for debug (white => blue) and trace (black => cyan)</li> </ul> <p>Deprecations:</p> <ul> <li><code>env_logger::from_env</code> has been deprecated in favor of <code>env_logger::Builder::from_env</code></li> </ul> <p>This release raises the minimum supported Rust version to 1.41.0.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/env-logger-rs/env_logger/commit/26e821b94f0b0b9fd3536c0ba7095c1b6c7a3ffe"><code>26e821b</code></a> Update repository links and release 0.8.1</li> <li><a href="https://github.com/env-logger-rs/env_logger/commit/9ffe00de4ff1429ccd004c42f82034b56a41a957"><code>9ffe00d</code></a> Release version 0.8.0</li> <li><a href="https://github.com/env-logger-rs/env_logger/commit/2b33c97117355cdc599aa29fb1a64b8016ee3f68"><code>2b33c97</code></a> Fix rustc & clippy lints</li> <li><a href="https://github.com/env-logger-rs/env_logger/commit/b8c3754a1de50ac720657d2f328ea98148e1d80d"><code>b8c3754</code></a> chore(examples): add syslog friendly format (<a href="https://github-redirect.dependabot.com/env-logger-rs/env_logger/issues/174">#174</a>)</li> <li><a href="https://github.com/env-logger-rs/env_logger/commit/a5a7ddc34ee82fe043eed8c3f89f5f83058f6a6f"><code>a5a7ddc</code></a> ci(docs): remove ci crate (<a href="https://github-redirect.dependabot.com/env-logger-rs/env_logger/issues/173">#173</a>)</li> <li><a href="https://github.com/env-logger-rs/env_logger/commit/3a331e46362bd96c042af9558de3a638c841d448"><code>3a331e4</code></a> chore(readme): fix badge links</li> <li><a href="https://github.com/env-logger-rs/env_logger/commit/eeedfa99be9b9619e84154de8592ce24c0f4daf5"><code>eeedfa9</code></a> ci(docs): add manual run trigger (<a href="https://github-redirect.dependabot.com/env-logger-rs/env_logger/issues/171">#171</a>)</li> <li><a href="https://github.com/env-logger-rs/env_logger/commit/2793bb5696c7740ced5c82ad27d4a9a7cd093a44"><code>2793bb5</code></a> ci(workflow): add documentation workflow (<a href="https://github-redirect.dependabot.com/env-logger-rs/env_logger/issues/170">#170</a>)</li> <li><a href="https://github.com/env-logger-rs/env_logger/commit/0ef5cffa29a45c9b0c572f470581d617fc7e50b0"><code>0ef5cff</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/env-logger-rs/env_logger/issues/168">#168</a> from KodrAus/chore/build-fn-cleanup</li> <li><a href="https://github.com/env-logger-rs/env_logger/commit/b24920eb7afaaa95edca0dd36f50caaca2b95ccf"><code>b24920e</code></a> deprecate env_logger::from_env and clean up examples</li> <li>Additional commits viewable in <a href="https://github.com/env-logger-rs/env_logger/compare/v0.7.1...v0.8.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+426 -428

0 comment

4 changed files

dependabot[bot]

pr closed time in 3 days

push eventmozilla/glean

CircleCI docs-deploy job

commit sha bc4e07ae9c30ca21eddb832f4575a33ee7bb9b70

[skip ci] Updates

view details

push time in 3 days

PullRequestReviewEvent

push eventbadboy/whatrustisit

Deployment Bot (from Travis CI)

commit sha a699ea4a74809c46ad431faf3205adbc9ec778d0

Deploy badboy/whatrustisit to github.com/badboy/whatrustisit.git:gh-pages

view details

push time in 4 days

push eventRustFestEU/blog.rustfest.eu

Jan-Erik Rediger

commit sha 0bf6aea9dde8ca7aa1a394fa9345cb120d99df9f

Add missing link

view details

push time in 4 days

push eventmozilla/glean

CircleCI docs-deploy job

commit sha 6ef2f908454023f96e8f9bd1bb1d544553020400

[skip ci] Updates

view details

push time in 4 days

push eventmozilla/glean

CircleCI docs-deploy job

commit sha 0d47ab247784f029f2b1b488c3fb09fd94ae50a6

[skip ci] Updates

view details

push time in 4 days

push eventmozilla/glean

CircleCI docs-deploy job

commit sha 864564cf54a8ea3055cc790e03b7538cca1b17e0

[skip ci] Updates

view details

push time in 4 days

delete branch mozilla/glean

delete branch : document-ping-info-in-metrics-yaml

delete time in 4 days

PR merged mozilla/glean

Bug 1671192 - Document ping info in metrics yaml

All of these "metrics" land in the ping_info section. Internally this is considered the glean_internal_info ping.

One note: experiments is actually a key-value dictionary. This does not exist as a metric type, we therefore label it a string. The pipeline won't like this when it generates a schema purely based on what's annoated in metrics.yaml

@fbertsch Will this cause trouble for the schema generator?

+76 -1

4 comments

1 changed file

badboy

pr closed time in 4 days

Pull request review commentmozilla/glean

Bug 1672371 - Copy the dispatcher from mozilla-central to the RLB

 path = ".." version = "33.0.4"  [dependencies]+crossbeam-channel = "0.4.3"

We're landing updates in #1279. Let's rebase on that after and go up to v0.5.0

Dexterp37

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

delete branch mozilla/glean

delete branch : dependabot/cargo/ctor-0.1.16

delete time in 4 days

PR closed mozilla/glean

Bump ctor from 0.1.15 to 0.1.16 dependencies rust

Bumps ctor from 0.1.15 to 0.1.16. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/mmastrac/rust-ctor/commits">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+409 -411

1 comment

2 changed files

dependabot[bot]

pr closed time in 4 days

pull request commentmozilla/glean

Bump ctor from 0.1.15 to 0.1.16

Part of #1279.

dependabot[bot]

comment created time in 4 days

pull request commentmozilla/glean

Bug 1671192 - Document ping info in metrics yaml

I'm leaning towards 1. An "internal" type requires glean_parser to know it. We can still go that route afterwards and eventually remove special-casing it in MSG.

badboy

comment created time in 4 days

push eventmozilla/glean

CircleCI docs-deploy job

commit sha 772a4c5334c14e7a0d2cdb5730ba8a4cfe401f89

[skip ci] Updates

view details

push time in 4 days

pull request commentmozilla/glean

Bug 1671192 - Document ping info in metrics yaml

@fbertsch what do you think? I can leave out the experiments part for now and at least we get the metric docs for the other parts for now.

badboy

comment created time in 4 days

delete branch mozilla/glean

delete branch : mdboom-patch-2

delete time in 4 days

push eventmozilla/glean

Michael Droettboom

commit sha a1bc8e25cbb86930f373b4be969e92ce4321a115

Clarify when Glean.initialize must be called

view details

Jan-Erik Rediger

commit sha a32e4cbd12085e804c90b5d2ea893660690de393

Merge pull request #1269 from mozilla/mdboom-patch-2 Clarify when Glean.initialize must be called [doc only]

view details

push time in 4 days

PR merged mozilla/glean

Clarify when Glean.initialize must be called
+2 -0

0 comment

1 changed file

mdboom

pr closed time in 4 days

PullRequestReviewEvent

create barnchbadboy/pre-init-buffer

branch : main

created branch time in 4 days

created repositorybadboy/pre-init-buffer

created time in 4 days

PR opened mozilla/glean

Reviewers
Dependency update

@mdboom I had to revert #1268, mozilla-central is still at the old version and we should probably soon-ish get in the RLB part, so we can start working with it. By avoiding that upgrade we save us from one more thing to figure out right now.

+487 -462

0 comment

4 changed files

pr created time in 4 days

create barnchmozilla/glean

branch : dep-update

created branch time in 4 days

issue commentmozilla-mobile/fenix

[Crash] ConcurrentModificationException in java.util.LinkedHashMap

It wasn't. Looking at that crash: ac.glean.build_version28.0.0, ac.version39.0.1. That's pretty old. We fixed a related issue back then: https://github.com/mozilla/glean/pull/900

so I think this is a "fixed already, they need to upgrade" kind of bug.

eliserichards

comment created time in 4 days

push eventbadboy/whatrustisit

Deployment Bot (from Travis CI)

commit sha 85eaf4b9901c2e483f7d802f0d78a8675623bfd9

Deploy badboy/whatrustisit to github.com/badboy/whatrustisit.git:gh-pages

view details

push time in 5 days

PR opened XAMPPRocky/timetill.rs

Updates now that RustFest is coming up
+5 -5

0 comment

1 changed file

pr created time in 5 days

push eventbadboy/timetill.rs

Jan-Erik Rediger

commit sha af4971e732482777269ed992bba34cda104bce38

Updates now that RustFest is coming up

view details

push time in 5 days

push eventmozilla/glean

CircleCI docs-deploy job

commit sha fabf8735a34a2d5fa3bfcce7f71358df72d7b3ab

[skip ci] Updates

view details

push time in 5 days

push eventRustFestEU/blog.rustfest.eu

Jan-Erik Rediger

commit sha 809155d2ce086b23c3071e6939dd43594b948066

Add back duplicate of picture

view details

push time in 5 days

push eventmozilla/glean

CircleCI docs-deploy job

commit sha aba1451021cdad4a92890077b6fd50543b6f15f9

[skip ci] Updates

view details

push time in 5 days

push eventmozilla/glean

CircleCI docs-deploy job

commit sha 03dc63b0884a4c3435479a23e5a06fa5b9ddc864

[skip ci] Updates

view details

push time in 5 days

Pull request review commentmozilla/glean

Bug 1672351 - Add a `BooleanMetric` to the RLB

+// This Source Code Form is subject to the terms of the Mozilla Public+// License, v. 2.0. If a copy of the MPL was not distributed with this+// file, You can obtain one at https://mozilla.org/MPL/2.0/.++use inherent::inherent;++// We need to wrap the glean-core type: otherwise if we try to implement+// the trait for the metric in `glean_core::metrics` we hit error[E0117]:+// only traits defined in the current crate can be implemented for arbitrary+// types.++/// This implements the developer facing API for recording boolean metrics.+///+/// Instances of this class type are automatically generated by the parsers+/// at build time, allowing developers to record values that were previously+/// registered in the metrics.yaml file.+pub struct BooleanMetric(pub(crate) glean_core::metrics::BooleanMetric);++impl BooleanMetric {+    /// The public constructor used by automatically generated metrics.+    pub fn new(meta: glean_core::CommonMetricData) -> Self {+        Self(glean_core::metrics::BooleanMetric::new(meta))+    }+}++#[inherent(pub)]+impl glean_core::traits::Boolean for BooleanMetric {+    /// Sets to the specified boolean value.+    ///+    /// # Arguments+    ///+    /// * `value` - the value to set.+    fn set(&self, value: bool) {+        crate::with_glean(|glean| {+            // Important note: this will need to use the

Nope, let's figure out how to do once thing first, then wrap the dispatcher in as a followup

Dexterp37

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

issue commentRustFestEU/brand

RustFest Global website & brand refresh

Are there already sticker designs? (I'm getting a bit excited right now with all this perfectly matching branding)

flaki

comment created time in 5 days

issue commentRustFestEU/brand

RustFest Global website & brand refresh

I peaked at the new background images for the stream and the chat. These work really well, thank you!

flaki

comment created time in 5 days

delete branch RustFestEU/blog.rustfest.eu

delete branch : announcement

delete time in 5 days

push eventRustFestEU/blog.rustfest.eu

Jan-Erik Rediger

commit sha 18faea3819fbb113289c19fc519ae3088ee5282d

New website & tickets available now! (#102)

view details

push time in 5 days

push eventRustFestEU/blog.rustfest.eu

Jan-Erik Rediger

commit sha 889fbfe829009f6161be9cc0a2d4db76a1754359

move it

view details

push time in 5 days

push eventbadboy/whatrustisit

Deployment Bot (from Travis CI)

commit sha 79ee531233a910308e53428ae012c9e90ce53ab0

Deploy badboy/whatrustisit to github.com/badboy/whatrustisit.git:gh-pages

view details

push time in 6 days

Pull request review commentmozilla/glean

Bug 1671915 - Change the 'preview' crate to the 'rlb' crate

 run $SED -i.bak -E \     "${WORKSPACE_ROOT}/${FILE}" run rm "${WORKSPACE_ROOT}/${FILE}.bak" -### GLEAN-PREVIEW ###+### GLEAN RLB ###  # Update the version of the glean-core dependency -FILE=glean-core/preview/Cargo.toml

uh fancy, I can now see why. it's both a line with just version = ...

Dexterp37

comment created time in 6 days

PullRequestReviewEvent

push eventmozilla/glean

CircleCI docs-deploy job

commit sha 3df254ed34c18723db0595267f1b5058e9f56e00

[skip ci] Updates

view details

push time in 6 days

Pull request review commentmozilla/glean

Bug 1671915 - Change the 'preview' crate to the 'rlb' crate

 [package]-name = "glean-preview"+name = "glean" version = "0.0.5" authors = ["Jan-Erik Rediger <jrediger@mozilla.com>", "The Glean Team <glean-team@mozilla.com>"]-description = "Nice Glean SDK Rust API"+description = "Glean SDK Rust language bindings"

I can't comment on a moved-only file, but the glean-core/rlb/README.md needs changes too

Dexterp37

comment created time in 6 days

Pull request review commentmozilla/glean

Bug 1671915 - Change the 'preview' crate to the 'rlb' crate

 run $SED -i.bak -E \     "${WORKSPACE_ROOT}/${FILE}" run rm "${WORKSPACE_ROOT}/${FILE}.bak" -### GLEAN-PREVIEW ###+### GLEAN RLB ###  # Update the version of the glean-core dependency -FILE=glean-core/preview/Cargo.toml

glean-preview was versioned independently of glean-core (it's at 0.0.5). The code previously here ensured we update the glean-core version it depends on.

This needs changes to update both the glean-core version it depends on and its own version.

Dexterp37

comment created time in 6 days

Pull request review commentmozilla/glean

Bug 1671915 - Change the 'preview' crate to the 'rlb' crate

 [package]-name = "glean-preview"+name = "glean" version = "0.0.5"

As said above, do we immediately bump this to the same version as glean-core (33.y.z)?

Dexterp37

comment created time in 6 days

Pull request review commentmozilla/glean

Bug 1671915 - Change the 'preview' crate to the 'rlb' crate

 When CI has finished and is green for your specific release branch, you are read     cargo publish --verbose     cd ffi     cargo publish --verbose+    cd.. && cd rlb

https://bugzilla.mozilla.org/show_bug.cgi?id=1598291

Dexterp37

comment created time in 6 days

Pull request review commentmozilla/glean

Bug 1671915 - Change the 'preview' crate to the 'rlb' crate

 When CI has finished and is green for your specific release branch, you are read     cargo publish --verbose     cd ffi     cargo publish --verbose+    cd.. && cd rlb
    cd .. && cd rlb

Gnaaaah, I'm going to automate this away in the coming weeks.

Dexterp37

comment created time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentmozilla/glean

Bug 1671628 - Add traits to describe expected operations on Glean types

+// This Source Code Form is subject to the terms of the Mozilla Public+// License, v. 2.0. If a copy of the MPL was not distributed with this+// file, You can obtain one at https://mozilla.org/MPL/2.0/.++/// A description for the `JweMetric` type.+///+/// When changing this trait, make sure all the operations are+/// implemented in the related type in `../metrics/`.+pub trait Jwe {+    /// Sets to the specified JWE value.+    ///+    /// # Arguments+    ///+    /// * `value` - the [`compact representation`](https://tools.ietf.org/html/rfc7516#appendix-A.2.7) of a JWE value.+    fn set_with_compact_representation<S: Into<String>>(&self, value: S);++    /// Builds a JWE value from its elements and set to it.+    ///+    /// # Arguments+    ///+    /// * `header` - the JWE Protected Header element.+    /// * `key` - the JWE Encrypted Key element.+    /// * `init_vector` - the JWE Initialization Vector element.+    /// * `cipher_text` - the JWE Ciphertext element.+    /// * `auth_tag` - the JWE Authentication Tag element.+    fn set<S: Into<String>>(&self, header: S, key: S, init_vector: S, cipher_text: S, auth_tag: S);

https://bugzilla.mozilla.org/show_bug.cgi?id=1672183

Dexterp37

comment created time in 6 days

PullRequestReviewEvent

Pull request review commentmozilla/glean

Bug 1671628 - Add traits to describe expected operations on Glean types

+// This Source Code Form is subject to the terms of the Mozilla Public+// License, v. 2.0. If a copy of the MPL was not distributed with this+// file, You can obtain one at https://mozilla.org/MPL/2.0/.++use std::collections::HashMap;++use crate::event_database::RecordedEvent;++/// A description for the `EventMetric` type.+///+/// When changing this trait, make sure all the operations are+/// implemented in the related type in `../metrics/`.+pub trait Event {+    /// Records an event.+    ///+    /// # Arguments+    ///+    /// * `timestamp` - A monotonically increasing timestamp, in milliseconds.+    ///   This must be provided since the actual recording of the event may+    ///   happen some time later than the moment the event occurred.+    /// * `extra` - A HashMap of (key, value) pairs. The key is an index into+    ///   the metric's `allowed_extra_keys` vector where the key's string is+    ///   looked up. If any key index is out of range, an error is reported and+    ///   no event is recorded.+    fn record<M: Into<Option<HashMap<i32, String>>>>(&self, timestamp: u64, extra: M);

re timestamp: we kinda do need that API. For FOG's IPC we need to get the timestamp immediately, pass that through the IPC layer and then later record the full event. What we could do though is having a special* record_with_timestamp API on the RLB only, not on the trait

* I already dislike the "special" API, but I don't see a way around it

Dexterp37

comment created time in 6 days

Pull request review commentmozilla/glean

Bug 1671628 - Add traits to describe expected operations on Glean types

+// This Source Code Form is subject to the terms of the Mozilla Public+// License, v. 2.0. If a copy of the MPL was not distributed with this+// file, You can obtain one at https://mozilla.org/MPL/2.0/.++use std::collections::HashMap;++use crate::event_database::RecordedEvent;++/// A description for the `EventMetric` type.+///+/// When changing this trait, make sure all the operations are+/// implemented in the related type in `../metrics/`.+pub trait Event {+    /// Records an event.+    ///+    /// # Arguments+    ///+    /// * `timestamp` - A monotonically increasing timestamp, in milliseconds.+    ///   This must be provided since the actual recording of the event may+    ///   happen some time later than the moment the event occurred.+    /// * `extra` - A HashMap of (key, value) pairs. The key is an index into+    ///   the metric's `allowed_extra_keys` vector where the key's string is+    ///   looked up. If any key index is out of range, an error is reported and+    ///   no event is recorded.+    fn record<M: Into<Option<HashMap<i32, String>>>>(&self, timestamp: u64, extra: M);

https://bugzilla.mozilla.org/show_bug.cgi?id=1672179

Dexterp37

comment created time in 6 days

PullRequestReviewEvent

Pull request review commentmozilla/glean

Bug 1671628 - Add traits to describe expected operations on Glean types

+// This Source Code Form is subject to the terms of the Mozilla Public+// License, v. 2.0. If a copy of the MPL was not distributed with this+// file, You can obtain one at https://mozilla.org/MPL/2.0/.++//! The different metric types supported by the Glean SDK to handle data.

Can we call out that they are considered unstable / experimental right now? I have some ideas how we might improve them to better accomodate for a nice Rust-y API, so I wouldn't want us to have them be considered stable yet (and yes, I know, no one should be using glean-core, but this also acts as docs for us)

(In theory we should hide them behind a feature flag, but that will make integration in this repository with the RLB harder)

Dexterp37

comment created time in 6 days

Pull request review commentmozilla/glean

Bug 1671628 - Add traits to describe expected operations on Glean types

+// This Source Code Form is subject to the terms of the Mozilla Public+// License, v. 2.0. If a copy of the MPL was not distributed with this+// file, You can obtain one at https://mozilla.org/MPL/2.0/.++/// A description for the `BooleanMetric` type.+///+/// When changing this trait, make sure all the operations are+/// implemented in the related type in `../metrics/`.+pub trait Boolean {+    /// Sets to the specified boolean value.+    ///+    /// # Arguments+    ///+    /// * `value` - the value to set.+    fn set(&self, value: bool);++    /// **Test-only API (exported for FFI purposes).**

(applies to all traits)

Dexterp37

comment created time in 6 days

Pull request review commentmozilla/glean

Bug 1671628 - Add traits to describe expected operations on Glean types

+// This Source Code Form is subject to the terms of the Mozilla Public+// License, v. 2.0. If a copy of the MPL was not distributed with this+// file, You can obtain one at https://mozilla.org/MPL/2.0/.++/// A description for the `JweMetric` type.+///+/// When changing this trait, make sure all the operations are+/// implemented in the related type in `../metrics/`.+pub trait Jwe {+    /// Sets to the specified JWE value.+    ///+    /// # Arguments+    ///+    /// * `value` - the [`compact representation`](https://tools.ietf.org/html/rfc7516#appendix-A.2.7) of a JWE value.+    fn set_with_compact_representation<S: Into<String>>(&self, value: S);++    /// Builds a JWE value from its elements and set to it.+    ///+    /// # Arguments+    ///+    /// * `header` - the JWE Protected Header element.+    /// * `key` - the JWE Encrypted Key element.+    /// * `init_vector` - the JWE Initialization Vector element.+    /// * `cipher_text` - the JWE Ciphertext element.+    /// * `auth_tag` - the JWE Authentication Tag element.+    fn set<S: Into<String>>(&self, header: S, key: S, init_vector: S, cipher_text: S, auth_tag: S);

Uh oh, this actually means all parameters need to be of the same type. Not a problem for our current use, but we should consider changing that. (actually a nicer Rust-y API would probably to take a JweToken struct or something, I'll file a bug here as well)

Dexterp37

comment created time in 6 days

Pull request review commentmozilla/glean

Bug 1671628 - Add traits to describe expected operations on Glean types

+// This Source Code Form is subject to the terms of the Mozilla Public+// License, v. 2.0. If a copy of the MPL was not distributed with this+// file, You can obtain one at https://mozilla.org/MPL/2.0/.++/// A description for the `BooleanMetric` type.+///+/// When changing this trait, make sure all the operations are+/// implemented in the related type in `../metrics/`.+pub trait Boolean {+    /// Sets to the specified boolean value.+    ///+    /// # Arguments+    ///+    /// * `value` - the value to set.+    fn set(&self, value: bool);++    /// **Test-only API (exported for FFI purposes).**

The FFI part is not true anymore. This is becoming a general "exported for test purposes" part.

Dexterp37

comment created time in 6 days

Pull request review commentmozilla/glean

Bug 1671628 - Add traits to describe expected operations on Glean types

+// This Source Code Form is subject to the terms of the Mozilla Public+// License, v. 2.0. If a copy of the MPL was not distributed with this+// file, You can obtain one at https://mozilla.org/MPL/2.0/.++use std::collections::HashMap;++use crate::event_database::RecordedEvent;++/// A description for the `EventMetric` type.+///+/// When changing this trait, make sure all the operations are+/// implemented in the related type in `../metrics/`.+pub trait Event {+    /// Records an event.+    ///+    /// # Arguments+    ///+    /// * `timestamp` - A monotonically increasing timestamp, in milliseconds.+    ///   This must be provided since the actual recording of the event may+    ///   happen some time later than the moment the event occurred.+    /// * `extra` - A HashMap of (key, value) pairs. The key is an index into+    ///   the metric's `allowed_extra_keys` vector where the key's string is+    ///   looked up. If any key index is out of range, an error is reported and+    ///   no event is recorded.+    fn record<M: Into<Option<HashMap<i32, String>>>>(&self, timestamp: u64, extra: M);

Heh, after a FOG review I'm actually tasked to file a bug to get this changed. Wouldn't it be great if we don't need to take i32 but can take the enum instead? :)

I'm also not super happy that we need to expose the timestamp argument here, but we can approach that in a follow-up eventually

Dexterp37

comment created time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent

create barnchRustFestEU/blog.rustfest.eu

branch : announcement

created branch time in 6 days

push eventbadboy/whatrustisit

Deployment Bot (from Travis CI)

commit sha 0d84a535cabd043baa8a0b734cb44ad41aded7e2

Deploy badboy/whatrustisit to github.com/badboy/whatrustisit.git:gh-pages

view details

push time in 7 days

push eventmozilla/glean

CircleCI docs-deploy job

commit sha eb673e173f808a9919b65a812df377715fbe8ccb

[skip ci] Updates

view details

push time in 7 days

push eventmozilla/glean

CircleCI docs-deploy job

commit sha 212312615fb0918e079fb5c2eaf71d54b5e049ad

[skip ci] Updates

view details

push time in 7 days

delete branch mozilla/glean

delete branch : dependabot-updates

delete time in 7 days

push eventmozilla/glean

Jan-Erik Rediger

commit sha 8130e9df10e9869858f23eb82b0cd05de5dc5742

Dependabot can handle the cargo workspace as one

view details

Jan-Erik Rediger

commit sha 1f82cd67893e718b0df55dc2a14c8c1e178e49b2

Update Rust dependencies

view details

Jan-Erik Rediger

commit sha 4a55509f535ed021b3dd2d18d1d04908c3870824

Merge pull request #1267 from mozilla/dependabot-updates

view details

push time in 7 days

PR merged mozilla/glean

Dependabot updates

Dependabot should be able to handle the cargo workspace as one thing.

Otherwise I just ran cargo update to upgrade dependencies with minor/patch version releases.

+457 -453

0 comment

2 changed files

badboy

pr closed time in 7 days

Pull request review commentmozilla/glean

Dependabot updates

 version: 2 updates:-  # glean-core+  # glean   - package-ecosystem: "cargo"-    directory: "/glean-core"-    schedule:-      interval: "daily"-    ignore:-      # Pinned to old version due to breaking changes-      - dependency-name: "rkv"--  # glean-ffi-  - package-ecosystem: "cargo"-    directory: "/glean-core/ffi"-    schedule:-      interval: "daily"--  # glean benchmark-  - package-ecosystem: "cargo"-    directory: "/glean-core/benchmark"+    directory: "/"

Yes! We recently upgraded it (#1260)

badboy

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentmozilla/glean

Bug 1671628 - Add traits to describe expected operations on Glean types

 pub struct CustomDistributionMetric {     histogram_type: HistogramType, } +/// A description for the `CustomDistributionMetric` type.+pub trait CustomDistribution {+    /// Creates a new instance of the metric.+    fn new(+        meta: CommonMetricData,+        range_min: u64,+        range_max: u64,+        bucket_count: u64,+        histogram_type: HistogramType,+    ) -> Self;++    /// Accumulates the provided signed samples in the metric.+    ///+    /// This is required so that the platform-specific code can provide us with+    /// 64 bit signed integers if no `u64` comparable type is available. This+    /// will take care of filtering and reporting errors for any provided negative+    /// sample.

It might need to stay with us to make FOG's IPC work efficiently.

Dexterp37

comment created time in 7 days

Pull request review commentmozilla/glean

Bug 1671628 - Add traits to describe expected operations on Glean types

 mod uuid;  pub use crate::event_database::RecordedEvent; use crate::histogram::{Functional, Histogram, PrecomputedExponential, PrecomputedLinear};-pub use crate::metrics::datetime::Datetime;+pub use crate::metrics::datetime::ChronoDatetime; use crate::util::get_iso_time_string; use crate::CommonMetricData; use crate::Glean; -pub use self::boolean::BooleanMetric;-pub use self::counter::CounterMetric;-pub use self::datetime::DatetimeMetric;-pub use self::event::EventMetric;+pub use self::boolean::{Boolean, BooleanMetric};+pub use self::counter::{Counter, CounterMetric};+pub use self::datetime::{Datetime, DatetimeMetric};+pub use self::event::{Event, EventMetric}; pub(crate) use self::experiment::ExperimentMetric; pub use crate::histogram::HistogramType; // Note: only expose RecordedExperimentData to tests in // the next line, so that glean-core\src\lib.rs won't fail to build.-pub use self::custom_distribution::CustomDistributionMetric;+pub use self::custom_distribution::{CustomDistribution, CustomDistributionMetric}; #[cfg(test)] pub(crate) use self::experiment::RecordedExperimentData;-pub use self::jwe::JweMetric;+pub use self::jwe::{Jwe, JweMetric}; pub use self::labeled::{     combine_base_identifier_and_label, dynamic_label, strip_label, LabeledMetric, };-pub use self::memory_distribution::MemoryDistributionMetric;+pub use self::memory_distribution::{MemoryDistribution, MemoryDistributionMetric}; pub use self::memory_unit::MemoryUnit; pub use self::ping::PingType;-pub use self::quantity::QuantityMetric;-pub use self::string::StringMetric;-pub use self::string_list::StringListMetric;+pub use self::quantity::{Quantity, QuantityMetric};+pub use self::string::{/*String, THIS FAILS HARD TODO */ StringMetric};

(This would mean we create a new directory glean-core/src/traits/, add mod.rs there and several new counter.rs, string.rs, etc. Makes looking for just a file name a bit harder, but at least I can still see the path in my editor, so can differentiate them if I open both the metric type and trait.(

Dexterp37

comment created time in 7 days

Pull request review commentmozilla/glean

Bug 1671628 - Add traits to describe expected operations on Glean types

 mod uuid;  pub use crate::event_database::RecordedEvent; use crate::histogram::{Functional, Histogram, PrecomputedExponential, PrecomputedLinear};-pub use crate::metrics::datetime::Datetime;+pub use crate::metrics::datetime::ChronoDatetime; use crate::util::get_iso_time_string; use crate::CommonMetricData; use crate::Glean; -pub use self::boolean::BooleanMetric;-pub use self::counter::CounterMetric;-pub use self::datetime::DatetimeMetric;-pub use self::event::EventMetric;+pub use self::boolean::{Boolean, BooleanMetric};+pub use self::counter::{Counter, CounterMetric};+pub use self::datetime::{Datetime, DatetimeMetric};+pub use self::event::{Event, EventMetric}; pub(crate) use self::experiment::ExperimentMetric; pub use crate::histogram::HistogramType; // Note: only expose RecordedExperimentData to tests in // the next line, so that glean-core\src\lib.rs won't fail to build.-pub use self::custom_distribution::CustomDistributionMetric;+pub use self::custom_distribution::{CustomDistribution, CustomDistributionMetric}; #[cfg(test)] pub(crate) use self::experiment::RecordedExperimentData;-pub use self::jwe::JweMetric;+pub use self::jwe::{Jwe, JweMetric}; pub use self::labeled::{     combine_base_identifier_and_label, dynamic_label, strip_label, LabeledMetric, };-pub use self::memory_distribution::MemoryDistributionMetric;+pub use self::memory_distribution::{MemoryDistribution, MemoryDistributionMetric}; pub use self::memory_unit::MemoryUnit; pub use self::ping::PingType;-pub use self::quantity::QuantityMetric;-pub use self::string::StringMetric;-pub use self::string_list::StringListMetric;+pub use self::quantity::{Quantity, QuantityMetric};+pub use self::string::{/*String, THIS FAILS HARD TODO */ StringMetric};

I think we should use modules to differentiate between metric types, their traits (& libstd's types).

That way glean_core::metrics::String can be the type, glean_core::traits::String can be the trait. In code we can use glean_core::metrics and glean_core::traits and then use the more-qualified path to the type like metrics::String instead. That avoids awkward (and redudant) suffixes on type or trait names.

Dexterp37

comment created time in 7 days

Pull request review commentmozilla/glean

Bug 1671628 - Add traits to describe expected operations on Glean types

 pub struct BooleanMetric {     meta: CommonMetricData, } +/// A description for the `BooleanMetric` type.+pub trait Boolean {+    /// Creates a new instance of the metric.+    fn new(meta: CommonMetricData) -> Self;

Do we really need to expose new as a trait method? This is not necessarily "metric type behaviour"

Dexterp37

comment created time in 7 days

PullRequestReviewEvent
more