profile
viewpoint

attfarhan/about-1 0

Projects, content, and documentation as Open Source.

attfarhan/awesome-browser-extensions-for-github 0

A collection of awesome browser extensions for GitHub.

attfarhan/build-web-application-with-golang 0

A golang ebook intro how to build a web with golang

attfarhan/camelcase 0

Split a camelcase word into a slice of words in Go

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 07b27fa922e99039f42819ed4cc16dcf31ef0d32

Don't autofocus input on initial visit, only show tour when input focused

view details

push time in 7 hours

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 98190f6c453875cc014b5ff954195f518ae80d9c

Don't autofocus input on initial visit, only show tour when input focused

view details

push time in 7 hours

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 701bec63f6df2adc11c5b782c5297cd5dde25fb4

Don't autofocus input on initial visit, only show tour when input focused

view details

push time in 8 hours

PR opened sourcegraph/sourcegraph

Don't autofocus input on initial visit, only show tour when input focused

Fixes https://github.com/sourcegraph/sourcegraph/issues/14783.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+9 -3

0 comment

3 changed files

pr created time in 8 hours

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 8221f11a75ff4a840bc0fb26099d2f3171d1e53e

Don't autofocus input on initial visit, only show tour when input focused

view details

push time in 8 hours

create barnchsourcegraph/sourcegraph

branch : fa/no-autofocus-init

created branch time in 8 hours

issue commentsourcegraph/sourcegraph

Do not autofocus search input for users who will see the tour

Can you elaborate on why? I am very worried that it distracts users from the main value proposition and distracts them from making a successful search on the first visit.

rrhyne

comment created time in 9 hours

issue closedsourcegraph/sourcegraph

Add regression tests to ensure query builder works as expected

@attfarhan found this release blocker right before release: https://github.com/sourcegraph/sourcegraph/issues/6691

We should put in place regression tests to ensure the query builder works as expected.

closed time in 3 days

slimsag

issue commentsourcegraph/sourcegraph

Add regression tests to ensure query builder works as expected

Query builder is feature flagged off by default and will be removed, so closing.

slimsag

comment created time in 3 days

issue closedsourcegraph/sourcegraph

Search query builder omits useful result types

The search query builder shows this:

image

It is missing:

  • type:file (only give me code matches, different from "default" which includes more than just code matches)
  • type:repo (only give me repo matches)
  • type:path (only give me filepath matches

Additionally, I find it strange that Code (default) returns ALL result types. I would expect:

  • Code -> ONLY code matches
  • No selection -> ALL result types

Reported by https://app.hubspot.com/contacts/2762526/company/407948923

closed time in 3 days

slimsag

issue commentsourcegraph/sourcegraph

Search query builder omits useful result types

Query builder is feature flagged off by default and will be removed, so closing.

slimsag

comment created time in 3 days

issue closedsourcegraph/sourcegraph

Query builder should show query in search box

The query builder does currently not show the built query in the search box. This is a missed opportunity for teaching people how to achieve the query with direct search syntax. It is also confusing, because the query builder does not have a Submit button, but the "Search" submit button is implied to submit what is in the search box, not the query builder.

2019-02-16 11 08 03

I propose it makes the search box readonly and updates its contents.

closed time in 3 days

felixfbecker

issue commentsourcegraph/sourcegraph

Query builder should show query in search box

Query builder is feature flagged off by default and will be removed, so closing.

felixfbecker

comment created time in 3 days

PullRequestReviewEvent

issue commentsourcegraph/sourcegraph

Do not autofocus search input for users who will see the tour

@rrhyne what are your thoughts on the above?

rrhyne

comment created time in 5 days

issue commentsourcegraph/sourcegraph

"Files" sidebar is not expanding folders when navigating to subfolders

@felixfbecker @lguychard I built the file tree a couple years back, and can look into fixing this. However, this is a component that should probably be owned by the Web team now instead of Search. @felixfbecker can I assign you to delegate this?

mrnugget

comment created time in 7 days

issue commentsourcegraph/sourcegraph

Do not autofocus search input for users who will see the tour

I think this solution would help us solve the problem of competing attention, but I don't like the idea of not focusing the input on first view. For new users especially, we want the default action to be typing a query. Before running into any other concept, first and foremost, we want users to figure out our search.

Therefore, I think the tour should be the first thing they see, as it'll guide them to making their first search. My preference is the solution Juliana proposed: to dim the background while the tour is shown. This solves the problem of competing attention, but doesn't take users away from Sourcegraph's main functionality on initial visit.

rrhyne

comment created time in 7 days

Pull request review commentsourcegraph/about

Add search tour, tracking goals to next iteration plan

 This document contains the goals and work log for the search team's [2-week iter - **Work log:**     - YYYY-MM-DD: $UPDATE +### Search Tour+- **Owner(s):** @farhan+- **Outcomes:**+    - Search field is no longer focused by default for users who haven't searched yet [#14783](https://github.com/sourcegraph/sourcegraph/issues/14783).+    - Search tour is re-enabled by default for enterprise customers.+    - Search tour usage is tracked in pings [#14781](https://github.com/sourcegraph/sourcegraph/issues/14781).+- **Work log:**+    - YYYY-MM-DD: $UPDATE++### Improve tracking of search onboarding on enterprise instances+- **Owner(s):** @farhan+- **Outcomes:**+    - Total number of unique searchers is tracked in pings [#14575](https://github.com/sourcegraph/sourcegraph/issues/14575).+    - Weekly retention is tracked in pings [#13636](https://github.com/sourcegraph/sourcegraph/issues/13636).+    - SMTP is tracked in pings [#14115](https://github.com/sourcegraph/sourcegraph/issues/14115).

Is this relevant to search onboarding, or is this just a one-off request from analytics? I don't recall any portion of the search onboarding flow that requires this. It would be clearer to move this into a separate section if it's a separate request..

lguychard

comment created time in 7 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commentsourcegraph/sourcegraph

Add an awesome Sourcegraph/cncf page

@sourcegraph/search @poojaj-tech, https://github.com/sourcegraph/sourcegraph/pull/14342 addresses implementing the CNCF page as described above. I've addressed all feedback on the PR, so it should be able to get merged.

Two items I was not able to get to:

  • Set up opsgenie monitoring (@poojaj-tech appears to be on it at https://sourcegraph.slack.com/archives/C0J618TTM/p1601586185007400)
  • Remove the cookie notice. I could not get to this in time, and this needs to be handled in our cookiebot.com account.
poojaj-tech

comment created time in 25 days

pull request commentsourcegraph/sourcegraph

CNCF page

I've addressed all the feedback above, and this should be in a mergeable state. @sourcegraph/search, I'll be leaving on my holiday, could you own getting this merged?

attfarhan

comment created time in 25 days

push eventsourcegraph/about

Farhan Attamimi

commit sha 375cd062331193ad2900ff8f48903b25d2868c7c

Update iteration_log.md

view details

push time in 25 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha c958c8b84fd0c2d2598d417db2f3e3256a5d652b

Add story for CNCF page

view details

push time in 25 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha fbd02ad1e3eac5bfe6fea122a4026d0c4b4926fa

Add custom description for CNCF page

view details

push time in 25 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha fba636d4f6eafd2294a6d1f73bab451395634af8

Remove unused import

view details

push time in 25 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha e5c686cf2749d372e50b56ee486c86e03d5258ff

Remove server banner

view details

Farhan Attamimi

commit sha 2c5e349ea9674949e26cbb8af89c975e0a6f10bc

Remove query builder link

view details

Farhan Attamimi

commit sha 1771d1102b08896e09a0d56f56c31dc296a31fbc

CNCF loading title

view details

push time in 25 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 178510ae74f1874aacfdb6242370284a1270bb11

Fixes from Pooja's comments

view details

push time in 25 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 63b79a9a8a6c42306b67597b6be6f50fb06683bb

copy updates

view details

Farhan Attamimi

commit sha 54587643c1affaf004fddd81047f2c04bbbba7e4

Merge branch 'fa/cncf' of github.com:sourcegraph/sourcegraph into fa/cncf

view details

push time in 25 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 7ab4c4bcf0e43695025f4d405f6e0d5498b73f91

Update web/src/repogroups/cncf.tsx Co-authored-by: Dax McDonald <dax@sourcegraph.com>

view details

push time in 25 days

PullRequestReviewEvent

Pull request review commentsourcegraph/sourcegraph

CNCF page

+import { RepogroupMetadata } from './types'+import * as React from 'react'++export const cncf: RepogroupMetadata = {+    title: 'CNCF',+    name: 'cncf',+    url: '/cncf',+    description: (+        <>+            Search the{' '}+            <a href="https://landscape.cncf.io/project=hosted" target="_blank" rel="noopener noreferrer">+                67 CNCF projects

So what should the description be @poojaj-tech? Should we just remove the number?

attfarhan

comment created time in 25 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 965b57178f070cfcc73a0607a7aceb4f50b17601

Minimal CNCF page

view details

push time in 25 days

PR opened sourcegraph/sourcegraph

CNCF page

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+144 -80

0 comment

10 changed files

pr created time in 25 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 8ba5cb9486b9639181607297f6aba2b5e7048e0c

Minimal CNCF page

view details

push time in a month

push eventsourcegraph/sourcegraph

ᴜɴᴋɴᴡᴏɴ

commit sha 59f929c20a81b69b2ebdc4c583ebd092e7afc091

Transparent encryption and decryption for all tables that contain secrets or tokens (#14214) Co-authored-by: Asdine El Hrychy <asdine.elhrychy@gmail.com> Co-authored-by: Chayim I. Kirshen <chayim@gnupower.net> Co-authored-by: Dax McDonald <31839142+daxmc99@users.noreply.github.com> Co-authored-by: Dax McDonald <dax@sourcegraph.com> Co-authored-by: Chayim <c@kirshen.com>

view details

Stefan Hengl

commit sha 969b03d82fe5343b32082239dcca21e84d73809a

search: call zoekt early (#14093) For global queries, we call zoekt before resolving and splitting repositories. The scope of this PR is limited to file and path results for literal search without version contexts.

view details

Keegan Carruthers-Smith

commit sha 442760420e9697ba4ee534ab1aa9cec3c0b273db

gomod: zoekt always respects search.largeFiles (#14273) Updates zoekt to include changes around search.largeFiles. Previously we would exclude files which contained too many trigrams. We now increase the trigram limit in the case of files that match search.largeFiles. Includes commits from zoekt: - d0d95b8 build: always run checktext - db2988b build: ignore size max includes binary

view details

Keegan Carruthers-Smith

commit sha b0fa84aa6b49183160c49c228bde7f130f93b057

frontend: instrument failures in config file override watcher (#14274) This commit makes two changes. Firstly we introduce a new prometheus metric which is incremented everytime we try to update configuration while watching the files. Secondly we include a consistent key in logs related to config overrides so we can search for it.

view details

Farhan Attamimi

commit sha be5865f9e285289f0db4db04e810e20d7d134258

Revert "Revert "usagestats: replace usages of usagestatsdepreacted with usagestats pkg (#13810)" (#14279)" (#14294) This reverts commit d0829435805a356f68047bf232b84d033aec1bb6.

view details

Stefan Hengl

commit sha 175afb34cc8ab04c19c93fdfdfe9aad85745f116

search: add tracing to NewSearchImplementer (#14296)

view details

Loïc Guychard

commit sha ccd36490e9477b589235a0e53320f134ffe9fef0

Enable multiline search console in dev (#14301)

view details

ᴜɴᴋɴᴡᴏɴ

commit sha 9a172d197f145c9eaff6a8069dcd751e3a3ed623

dep: use our fork of golang.org/x/oauth2 (#14295)

view details

Loïc Guychard

commit sha a8e9732ea76de0c1879ba611891273f2a66a4234

Remove skipped interactive mode e2e tests (#14307) The feature is adequately tested by [integration tests](https://sourcegraph.com/github.com/sourcegraph/sourcegraph@9a172d197f145c9eaff6a8069dcd751e3a3ed623/-/blob/web/src/integration/search.test.ts?subtree=true#L86-437)

view details

Loïc Guychard

commit sha 44fed6b5680804f6c8884be0f000a5080aee57f6

Add rust to filter suggestions (#14308) Fixes #14217

view details

Keegan Carruthers-Smith

commit sha 29305d843174c3a8713e271d516dd573d10588c5

doc: mount volume for config file overrides (#14297) Rather than using subpath we mount the full volume. This allows kubernetes to update the configmap when it changes. It requires the full volume since it does updates via symlinks. For example here is the ls output on sourcegraph.com once we use this approach: # ls -la /etc/sourcegraph total 12 drwxrwxrwx 3 root root 4096 Sep 30 08:17 . drwxr-xr-x 1 root root 4096 Sep 30 08:17 .. drwxr-xr-x 2 root root 4096 Sep 30 08:17 ..2020_09_30_08_17_45.768252600 lrwxrwxrwx 1 root root 31 Sep 30 08:17 ..data -> ..2020_09_30_08_17_45.768252600 lrwxrwxrwx 1 root root 18 Sep 30 08:17 extsvc.json -> ..data/extsvc.json lrwxrwxrwx 1 root root 27 Sep 30 08:17 global-settings.json -> ..data/global-settings.json lrwxrwxrwx 1 root root 16 Sep 30 08:17 site.json -> ..data/site.json When a new configmap update goes out kubernetes writes the data into a directory like "..2020_09_30_08_17_45.768252600" and then can atomically update symlinks. We also suggest users mount to /etc/sourcegraph. This is a more natural path for this configuration data than under /mnt which should just contain volume mounts. Additionally /mnt has other mounts in it, so we require an empty directory as the target.

view details

Keegan Carruthers-Smith

commit sha 653c69d9c05690fdaf489c480098c17d3e36d8ab

web/search: scan over ISearchResults in stream (#14309) This simplifies the observable chain so we directly update the final ISearchResults in scan for each stream event. The main benefit of this is as we add more event types we don't need to grow the list of event buffers. We also use switch on the event type so that typescript checks exhaustiveness.

view details

Keegan Carruthers-Smith

commit sha d7bd837752fb465a48dcd007a52e9b4f5e6ad1f8

web/search: remove unused RepositorySearchResult (#14312) We rely on a generic result type returned from the backend. However, we may want to use this component again in the future with streaming search. For now I am removing it.

view details

Keegan Carruthers-Smith

commit sha d1e0f5f97f9b5bdd6d12b4b10d30cdf60150a8e5

search: factor out graphql to stream for filematch (#14310) We want to start adding adaptors for other types, to make that clean we extract out the existing adaptor for file matches.

view details

Erik Seliger

commit sha e7b52df3d9ad0633d71c7cb649c56b4abf56835d

Make breadcrumbs properly align with containers (#14138)

view details

davejrt

commit sha e167e01737c52930379ca1990ecabd65185ec14d

use commands directly in vagrant shell (#14286)

view details

Ryan Slade

commit sha 3d64ed788e51ddac632de572b5ce89614c91633a

repo-updater: Sync single external service at a time using workerutil (#14305) This PR makes two main changes: We sync each external service independently The syncing process now happens using the workerutil package Syncer.Run now enqueues external services into a job queue that are due to be synced every minute. These jobs are picked by up to three sync workers concurrently each worker syncs one service using the new Syncer.SyncExternalService method. We rely on database triggers to mark repos as deleted once they no longer exist in any external service. This is based on the state of the external_service_repos table which tracks the relationship between repos and external services. Triggers also exist that remove rows from external_service_repos when a repo or external service is deleted or soft deleted. We've tested syncing up to 500k repos successfully. * repo-updater: Sync single external service at a time using workerutil Tests are still failing * repoupdater: Fix server_test * testSyncerSyncWithErrors uses SyncExternalService Also removes a test case that tests a sync of muktiple external services as we no longer support that. * Add EnqueueJobs tests * Removed old references to syncer.Sync Code now compiles but a lot of tests still fail. Added a cleanup function that needs to be called when we stop a worker to unregister prometheus metrics so that it doesn't panic when we start another worker in a subsequent test. * Fix repo-updater tests * Delete orphaned repos * Avoid constraints by changing upsert order * Fix minSyncInterval * WIP test sync * Add a test that syncs multiple external services in sequence * WIP test for orphaned repos * Only delete orphaned repos * repo-updater: Remove stale jobs on startup If a job is processing when repo-updater dies that job would never complete. We would then not requeue the associated external service for syncing. To be safe we delete non locked processing rows on startup. * Typo * db: Mark next_synced_at on service save This will cause a sync to be triggered ASAP for the saved external service. On save, we trigger a call to repo-updater which causes us to enqueue any pending sync jobs. As we've just upated next_sync_at the job for the newly saved repo will be queued. * Rename trigger We no longer trigger a full sync but instead trigger enqueueing pending sync jobs. * Remove orphaned repo code We now have a trigger that does the same thing * Improve orphaned repo test * Test external service deletion * Remove orphaned repo code from syncSubset * Remove leftover debug line * Fix deleting of repos when called via syncSubset * Improve EnqueueSyncJobs docstring Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com> * Improve error message Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com> * Check rows.Err() after iteration * Change log line to debug Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com> * Remove leftover debug line * Add stalled jobs resetter * Pass prometheus register to the SyncWorker * Create ResetterMetrics inline * Remove unused field * Fix docstring * Typo * Missing period * Typo * Add failing test * Resolve name conflicts deterministically * Cleanup name conflicts resolution * Resolve name conflicts during renames * Don't wrap nil error * Don't queue jobs for Phabricator services * Handle large name lists in StoreListReposArgs.Names * Trigger rebuild * Remove stale job cleanup code We use the workerutil resetter now instead * Add failing test * Fix predicate on sourcegraphcom mode * Don't sync deleted external services * When in cloud mode DON'T sync admin added external services * Fix slow query * Account for sourced repo Sources map always containing one source Ensure that the Sources map on the newly sourced repo also contains any other sources we know about from the DB so that are diff functions can operate correctly. The repo from the source can by definition only ever know about on source. * Use URI when adding stored sources Before we used id which will always be 0 from a sourced repo as id is from our database. * Fix failing test The test was no longer valid as we now ensure that sourced repos also include any other sources we know about in our DB. * Add comment * Add some test helpers * Disallow external services owned by a user to sync private code * User more test helpers * Temp logging * More temp logging * Remove temp logging * Do not store github ViewPersmissions in our database The value changes depending on which token was used to fetch the repo. * Store prometheus Registerer in Syncer and record sync backoff * Record external service id with sync duration * Include external service id and family in sync metrics * Simplify syncSubset signature (#13911) * Change the signature of SyncSubset to expect only one repo * Rename syncSubset to syncSingleRepo * Renamed SyncSingleRepo to SyncRepo * Streaming inserter should not insert private repos owned by a user * Rename store to tx in SyncExternalService * Streaming inserter should not use a transaction It should use a store created outside of the workerutil package so that repos added are available asap and not delayed until the entire sync has completed. * Added failing test testConflictingSyncers * Make test more deterministic * Use separate Read Commited transaction in the handler * repo-updater: Use s.Logger where appropriate (#14095) * repo-updater: Use s.Logger where appropriate The syncer has it's own logger with should be used when logging from within any methods on the syncer struct. Also updated a couple of places where we were using the correct logger but not performing a nil check. * Demote log * Return early when UpsertSources has no work * Use IsolationLevel option * Make the number of workers configurable * Update comment * Typo * Fix comment * Typo * Use hardcoded number of workers * Consistent spacing * Disable git update scheduling on cloud * Remove unused context Co-authored-by: Asdine El Hrychy <asdine.elhrychy@gmail.com> Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com>

view details

Asdine El Hrychy

commit sha e94df71fb6c8048c170d2937ce23084656806eb7

Add background job to cleanup old sync jobs (#14098) Adds a background job that deletes completed or errored jobs from the `external_service_sync_jobs` table. This table can potentially grow a lot with the number of user-added external services, this change makes sure it remains small. All the completed and errored jobs finished since more than one day are deleted automatically. The function is run every hour by default.

view details

Felix Becker

commit sha d219ebdc745786fa08a48b85831b77726dd1d118

Don't show built-in auth provider on sign up (#14306)

view details

uwedeportivo

commit sha bfc1d662bdf650a13e8dcb98f1a309f723c43985

logging: introduce new json log format with automatic severity field (#14259) * logging: introduce new json log format with automatic severity field added * log level joe code review suggestion

view details

push time in a month

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 4fed3e8e8459b1c51b033e69a6773ae106da003a

Minimal CNCF page

view details

push time in a month

create barnchsourcegraph/sourcegraph

branch : fa/cncf

created branch time in a month

Pull request review commentsourcegraph/sourcegraph

search: enable enterprise home panels by default

 {   // This is set from an environment variable   "experimentalFeatures": {-    "showRepogroupHomepage": true,-    "showEnterpriseHomePanels": true+    "showRepogroupHomepage": true

Ah so sorry 🤦

limitedmage

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentsourcegraph/sourcegraph

search: enable enterprise home panels by default

 {   // This is set from an environment variable   "experimentalFeatures": {-    "showRepogroupHomepage": true,-    "showEnterpriseHomePanels": true+    "showRepogroupHomepage": true

Oh sorry I mistyped showEnterpriseHomePanels to showEnterpriseHomepage. Doesn't this PR want to enable showEnterpriseHomePanels by default? Why are we enabling showRepogroupHomepage by default in dev and not showEnterpriseHomePanels?

limitedmage

comment created time in a month

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha be5865f9e285289f0db4db04e810e20d7d134258

Revert "Revert "usagestats: replace usages of usagestatsdepreacted with usagestats pkg (#13810)" (#14279)" (#14294) This reverts commit d0829435805a356f68047bf232b84d033aec1bb6.

view details

push time in a month

delete branch sourcegraph/sourcegraph

delete branch : fa/unrevert-usagestats

delete time in a month

PR merged sourcegraph/sourcegraph

Revert "Revert "usagestats: replace usages of usagestatsdepreacted with usagestats pkg (#13810)" (#14279)"

This was reverted because it was thought it was causing CI failure. It wasn't the culprit, so unreverting.

This reverts commit d0829435805a356f68047bf232b84d033aec1bb6.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+8 -9

0 comment

4 changed files

attfarhan

pr closed time in a month

PR opened sourcegraph/sourcegraph

Revert "Revert "usagestats: replace usages of usagestatsdepreacted with usagestats pkg (#13810)" (#14279)"

This was reverted because it was thought it was causing CI failure. It wasn't the culprit, so unreverting.

This reverts commit d0829435805a356f68047bf232b84d033aec1bb6.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+8 -9

0 comment

4 changed files

pr created time in a month

Pull request review commentsourcegraph/sourcegraph

search: enable enterprise home panels by default

 {   // This is set from an environment variable   "experimentalFeatures": {-    "showRepogroupHomepage": true,-    "showEnterpriseHomePanels": true+    "showRepogroupHomepage": true

Should this be showEnterpriseHomepage?

    "showEnterpriseHomepage": true
limitedmage

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

create barnchsourcegraph/sourcegraph

branch : fa/unrevert-usagestats

created branch time in a month

PullRequestReviewEvent

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha df62c8d2ca56b0c544d92f402c66beb858d1f00b

Revert "tour: add snapshots (#13321)" (#14282) This reverts commit a9e38931821b7ea0dfe7e4686bf8202cf8e2110b.

view details

push time in a month

delete branch sourcegraph/sourcegraph

delete branch : fa/revert-snaps

delete time in a month

PR merged sourcegraph/sourcegraph

Revert "tour: add snapshots (#13321)"

This reverts commit a9e38931821b7ea0dfe7e4686bf8202cf8e2110b.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+1 -4

1 comment

1 changed file

attfarhan

pr closed time in a month

PR opened sourcegraph/sourcegraph

Revert "tour: add snapshots (#13321)"

This reverts commit a9e38931821b7ea0dfe7e4686bf8202cf8e2110b.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+1 -4

0 comment

1 changed file

pr created time in a month

create barnchsourcegraph/sourcegraph

branch : fa/revert-snaps

created branch time in a month

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha d403b7f9a375248df588f9d987e023f58785473d

usagestats: replace usages of usagestatsdepreacted with usagestats pkg (#13810)

view details

push time in a month

delete branch sourcegraph/sourcegraph

delete branch : fa/usagestats-deprecated

delete time in a month

PR merged sourcegraph/sourcegraph

Reviewers
Replace usages of usagestatsdepreacted with usagestats package

Fixes https://github.com/sourcegraph/sourcegraph/issues/13784.

There is one function I'm not entirely sure how to replace: LogActivity. I'm not entirely sure if this is completely equivalent to LogEvent in the usagestats package. Other than this, all usages of usagestatsdeprecated are removed.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+8 -9

1 comment

4 changed files

attfarhan

pr closed time in a month

issue closedsourcegraph/sourcegraph

Activation should use usage statistics from postgres instead of redis

The activation components fetches the user's usage stats. We still use the deprecated Redis event logs, but should switch over to the event logs in the postgres db.

closed time in a month

attfarhan

pull request commentsourcegraph/sourcegraph

Replace usages of usagestatsdepreacted with usagestats package

Going to merge this since it seems straightforward. Tagging @dadlerj to make sure you're aware!

attfarhan

comment created time in a month

push eventsourcegraph/sourcegraph

Erik Seliger

commit sha 4dc9144d6f4f5323089d5f251ff70fccd78ff5e8

Align create page with design (#13725) * Begin work on create page * Align with design * Fix BEM selector * Fix jest with yaml imports * Use .yaml consistently. * Insert copy from #13777. * Wire up the current namespace. * Rename tabs to filenames. * Make the specfile background $code-bg. * Fix storybook breakage. * Flip the flag order. This means that a user copy/pasting need only ^W and change the last placeholder in the normal case where they're creating the campaign in their user namespace. * Add examples subhead. * show border around code The previous background was `$code-bg` is defined as `--body-bg`, which means it was effectively transparent. * remove STEP The all-caps treatment is inconsistent (not used elsewhere) and unnecessary. * show the name of the selected file in the example command * add minimal campaign example I often find it helpful to have a minimal example for things. Also, use nav pills instead of nav tabs because the tabs are (more) likely to wrap onto 2 lines with the addition of this new example. * don't indent/center page on wide screens * colon to dot in step numbers Co-authored-by: Adam Harvey <aharvey@sourcegraph.com> Co-authored-by: Quinn Slack <quinn@slack.org>

view details

Stefan Hengl

commit sha 94ed71d5879d5d4f0de500c5d3af83db7c834325

search: update zoekt (#13791)

view details

Stefan Hengl

commit sha fb0e5895b5f6563aed0541ced985b3f1f32dbfb5

search: document .sourcegraph/ignore (#13788)

view details

Keegan Carruthers-Smith

commit sha 0b030ab577e4031305216066a92e671afb575db8

updatecheck: include aggregated repository statistics in pings (#13764) We want to start including the number of lines of code indexed by Sourcegraph as well as the total size of all git repositories stored on Sourcegraph. This commit was created by copying the structure of the saved searches pings commit.

view details

Thorsten Ball

commit sha b83f71e016f0e8c1c5d79af2e9fec89efa1754d4

Update the example comby-sprintf-to-itoa campaign to use goimports (#13812)

view details

Thorsten Ball

commit sha b54d339e79a531c29e42a9abf4013573bbcf4c28

Replace fmt.Sprintf with equivalent strconv.Itoa (#13811) * Replacing fmt.Sprintf with strconv.Iota * Fix conversion of int64 to string * More int conversions

view details

Thorsten Ball

commit sha 8bcd23852658e74f98c27c59a5b7bbcaa1a31456

Bump src-cli MinimumVersion to 3.20.0 (#13815) A new version of src-cli, 3.20.0, is out and I want to bump the MinimumVersion before the branch cut: https://github.com/sourcegraph/src-cli/releases/tag/3.20.0

view details

Keegan Carruthers-Smith

commit sha 9a320e5273932faeacb72dcdc66c01063d7e76a2

oauth2: use external http client when doing oauth2 calls (#13814) You can configure TLS settings via our site settings. In the future we may have other settings which affect sourcegraph's ability to communicate with the outside world. httpcli's external client takes into account those settings. This commit ensures golang.org/x/oauth2 will use that client. This commit injects the client at the top-level oauth middleware. For example this should ensure that oauth against a gitlab with a self signed certificate will work.

view details

Robert Lin

commit sha 4d1b44446db4ec91583805854f3614f06ec182b9

renovate-downstream: bump version (#13817)

view details

Keegan Carruthers-Smith

commit sha f2d9a37398e0984010191e7754bc784c647622b1

gomod: update all dependencies (#13818)

view details

Thorsten Ball

commit sha 9a7bb8330996b64356f3d9007f95ef4ca097a161

Update commit when author email/name changed (#13819) I noticed that the reconciler didn't create and push a new commit when I changed the author in my campaign spec and applied it. This fixes that issue. The code is simply an addition to what was there before and doesn't change anything. I want to investigate how/whether I can make CompareChangesetSpecs nicer, but I'll leave that for a follow-up.

view details

Rijnard van Tonder

commit sha 144b46522d102aa0f429b278182eaceb2c6956fd

search: merge and fix parens heuristics (#13803)

view details

Juliana Peña

commit sha 325c600436ce2abb235988d58e57f605097b4679

#13797: Enterprise home: Stabilize visual tests due to timestamps (#13801)

view details

ElizabethStirling

commit sha 60cc37a40f2f8d514618762a5ca3127a9f91a122

Prevent password reset code leakage via cross origin requests (#13804) * Update referrer to origin on cross-origin requests to prevent password reset codes from being leaked * Set to only record origin * return the entire URL in the referer header iff the request is from the same origin * Apply suggestions from code review Co-authored-by: Stephen Gutekanst <stephen.gutekanst@gmail.com> * Update changelog Co-authored-by: Stephen Gutekanst <stephen.gutekanst@gmail.com>

view details

ElizabethStirling

commit sha e9cf8dfb2236c3f8dec01efcf7e1f691ea6f878b

Fix markdown issue (#13820) * Fix markdown issue * No, really, fixed it this time

view details

Eric Fritz

commit sha 0876589882844aaaaedc697277599d121716fdd3

Squash migrations to 3.17.0 (#13753)

view details

Rijnard van Tonder

commit sha bf3d78c406166100147fabd19a340d25e9bfa3c8

search: don't run paren heuristics on quoted values (#13821)

view details

renovate[bot]

commit sha 52223f3964e8551667abab362f6e995f66d88478

Update comby/comby Docker tag to v0.18.4 (#13809)

view details

Rijnard van Tonder

commit sha 08f0f32eab1c94c8d997b3b42878c2abb55a7aa8

search: structural search changelog and doc updates (#13824)

view details

davejrt

commit sha 9ac9ac82cea26648324c3b0fe2c05d9c3c665e35

update changelog for 3.20 (#13826)

view details

push time in a month

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha a9e38931821b7ea0dfe7e4686bf8202cf8e2110b

tour: add snapshots (#13321)

view details

push time in a month

delete branch sourcegraph/sourcegraph

delete branch : fa/add-tour-snapshots

delete time in a month

PR merged sourcegraph/sourcegraph

Add tour snapshots team/search testing

Addresses https://github.com/sourcegraph/sourcegraph/pull/12972/files/732db55c9694a02c41cb7abda112b250fc867d35#r472387761

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+4 -1

4 comments

1 changed file

attfarhan

pr closed time in a month

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha e1c96c791d03fcb4193c3d58c61de45b6b68f332

tracking-issue: Supported nested tracking issues in different milestones (#14185)

view details

Eric Fritz

commit sha 717a2784bbdc9de95abd02c2c859e78c6ef3ce77

codeintel: RFC 235: Soft delete upload records (#13822)

view details

Renovate Bot

commit sha 2595e97c42bb926ea0b48675dd4a8d6d76e49cfe

Update dependency stylelint to ^13.7.2

view details

Rijnard van Tonder

commit sha 9ea8ef44453246959e8bd24060a7d3659ad47211

search: fix repogroups and introduce types for repogroup values (#14190)

view details

Felix Becker

commit sha 785cba86db4500d80c0264a63fbacc3e4c1b4448

Add integration tests for extensions (#12195) Co-authored-by: Loïc Guychard <loic@sourcegraph.com> Co-authored-by: Marek <marekz@gmail.com>

view details

Farhan Attamimi

commit sha 3877f09dc87dc04f5bf7c2e5d54cdda6ce807a88

Add author and message as negatable filters (#14198)

view details

ᴜɴᴋɴᴡᴏɴ

commit sha b108f7bd26bb3da7376e8691d79f728d27db73c4

secrets: add scanners for transparent encryption and decryption (#14191)

view details

ᴜɴᴋɴᴡᴏɴ

commit sha 41efc8b892ffc79209c560cc4a71218a72c852ab

secret: rename from secrets to avoid conflict with db.secrets (#14213)

view details

Farhan Attamimi

commit sha 6d30e8071ac672376c8fab0ff3a337a636a6f6a5

Add committer as valid filter (#14201)

view details

Beyang Liu

commit sha f4d37fb0af59fe31f8afec578f0a51d8c22d4c84

doc: add 1rem padding above each doc page title (#14215)

view details

Beyang Liu

commit sha 744eaceeb7e2fedb29745b4eb8f267612751e24c

doc: add tutorial for adding LSIF to many repos (#14211)

view details

Beyang Liu

commit sha df424915a3e48f82f1ba3991b372ff940830c29d

doc: link to adding_lsif_to_many_repos.md from another page (#14221)

view details

Beyang Liu

commit sha e0f7d08d501bcbc6601793a95985476446cfa1ad

Revert "doc: link to adding_lsif_to_many_repos.md from another page (#14221)" (#14222) This reverts commit df424915a3e48f82f1ba3991b372ff940830c29d.

view details

Farhan Attamimi

commit sha cd7dfa4e24c16eb024fd0a6a78efa6e0e1fce14c

Search onboarding tour QA updates (#14148)

view details

TJ Kandala

commit sha d3de57a277446122b043b1fc0af691a6732d41c8

Implement RFC 209: Extension discoverability (#13699)

view details

TJ Kandala

commit sha b872f78d5f68a70a76f861c4c1aa4da1b7af045c

web: hide scrollbar on new extension page(#14227)

view details

Rijnard van Tonder

commit sha f795818782ce6ed17ea367e625c6e7b51e33b30b

search: update repogroup regexp settings docs (#14209)

view details

Farhan Attamimi

commit sha 402d0f59e01b82e8954ee05fb3928fca85cb193d

Merge branch 'main' into fa/add-tour-snapshots

view details

push time in a month

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 0e1f038149dd6c2933c894589c72c5a4d2ab8e7b

Insert space after autocomplete suggestions (#14248)

view details

push time in a month

delete branch sourcegraph/sourcegraph

delete branch : fa/lang-suggestions-space

delete time in a month

PR merged sourcegraph/sourcegraph

Insert space after language autocomplete suggestions

Addresses https://github.com/sourcegraph/sourcegraph/pull/14148#issuecomment-698505045.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+3 -3

1 comment

1 changed file

attfarhan

pr closed time in a month

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 61c51059e923ee4b647d178084134233dc381ae4

Add space for symbolToCompletion and repogroupToCompletion

view details

push time in a month

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 9264fb50ff5df0ab2f03ffc6e50792cfe768ac93

Use options pattern for generateStepTooltip (#14244)

view details

push time in a month

delete branch sourcegraph/sourcegraph

delete branch : fa/generatesteptooltip

delete time in a month

PR merged sourcegraph/sourcegraph

Reviewers
Use options pattern for generateStepTooltip

Addresses https://github.com/sourcegraph/sourcegraph/pull/14148#discussion_r494310888. <!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+64 -46

0 comment

3 changed files

attfarhan

pr closed time in a month

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha a90c9b3a0ebaa08ae2f015688f050e1f02c9fd50

tour: remove eslint disable directive and type assertion (#14246)

view details

push time in a month

delete branch sourcegraph/sourcegraph

delete branch : fa/tour-lint

delete time in a month

PR merged sourcegraph/sourcegraph

tour: remove eslint disable directive and type assertion

Addresses https://github.com/sourcegraph/sourcegraph/pull/14148#discussion_r494314329.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+7 -9

1 comment

1 changed file

attfarhan

pr closed time in a month

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 570fd9df4a436af51b55f24c49ccd6d8bf96e27f

Add docs for COMPLETION_ITEM_SELECTED (#14245)

view details

push time in a month

delete branch sourcegraph/sourcegraph

delete branch : fa/completion-step-doc

delete time in a month

PR merged sourcegraph/sourcegraph

Add docs for COMPLETION_ITEM_SELECTED

Addresses https://github.com/sourcegraph/sourcegraph/pull/14148#discussion_r494311288. <!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+4 -0

0 comment

1 changed file

attfarhan

pr closed time in a month

PR opened sourcegraph/sourcegraph

Insert space after language autocomplete suggestions

Addresses https://github.com/sourcegraph/sourcegraph/pull/14148#issuecomment-698505045.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchsourcegraph/sourcegraph

branch : fa/lang-suggestions-space

created branch time in a month

PR opened sourcegraph/sourcegraph

tour: remove eslint disable directive and type assertion

Addresses https://github.com/sourcegraph/sourcegraph/pull/14148#discussion_r494314329.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+7 -9

0 comment

1 changed file

pr created time in a month

PR opened sourcegraph/sourcegraph

Add docs for COMPLETION_ITEM_SELECTED

Addresses https://github.com/sourcegraph/sourcegraph/pull/14148#discussion_r494311288. <!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+4 -0

0 comment

1 changed file

pr created time in a month

PR opened sourcegraph/sourcegraph

Use options pattern for generateStepTooltip

Addresses https://github.com/sourcegraph/sourcegraph/pull/14148#discussion_r494310888. <!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+64 -46

0 comment

3 changed files

pr created time in a month

create barnchsourcegraph/sourcegraph

branch : fa/tour-lint

created branch time in a month

create barnchsourcegraph/sourcegraph

branch : fa/completion-step-doc

created branch time in a month

create barnchsourcegraph/sourcegraph

branch : fa/generatesteptooltip

created branch time in a month

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 2d4dd3c589993af30638b1b00c915d07cf8ab6e6

Fixes

view details

push time in a month

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 513c0a7f73869749b1d824cc79f25ba7c5b62c91

Update callbacks, don't show saved query button

view details

push time in a month

Pull request review commentsourcegraph/sourcegraph

search: add mulitline search query console page

 export const routes: readonly LayoutRouteProps<any>[] = [     },     {         path: '/search/console',-        render: lazyComponent(() => import('./search/SearchConsolePage'), 'SearchConsolePage'),+        render: props =>+            props.showMultilineSearchConsole ? (+                <SearchConsolePage+                    {...props}+                    allExpanded={false}+                    showSavedQueryModal={false}+                    deployType={window.context.deployType}+                    onShowMoreResultsClick={() => undefined}+                    onExpandAllResultsToggle={() => undefined}+                    onSavedQueryModalClose={() => undefined}+                    onDidCreateSavedQuery={() => undefined}+                    onSaveQueryClick={() => undefined}+                    didSave={false}

These props are not defined anywhere in the component tree above this (i.e. these props are not passed through in the Layout component), so these should be passed at the SearchConsolePage level. Will push up a commit to fix.

rvantonder

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha cd7dfa4e24c16eb024fd0a6a78efa6e0e1fce14c

Search onboarding tour QA updates (#14148)

view details

push time in a month

delete branch sourcegraph/sourcegraph

delete branch : fa/tour-qa

delete time in a month

PR merged sourcegraph/sourcegraph

Reviewers
Search onboarding tour QA updates

Fixes https://github.com/sourcegraph/sourcegraph/issues/13944.

This PR includes two changes:

  1. The "Filter language" and "Filter repository" steps will now be advanced when a user chooses a suggestion from the dropdown after the repo: or lang: filters are inserted.
  2. The structural search examples are removed from the "Add query term" step. This step just prompts the user to add a query term now. As a result, the structural search informational step is also removed.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+199 -332

6 comments

6 changed files

attfarhan

pr closed time in a month

issue closedsourcegraph/sourcegraph

Search tour updates

  • Remove structural search examples temporarily
  • Add next and previous buttons to each step of the tour except the 'run search' and 'view search guide' steps
    • Previous buttons will not clear any input created in the previous step

closed time in a month

rrhyne

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 6d30e8071ac672376c8fab0ff3a337a636a6f6a5

Add committer as valid filter (#14201)

view details

push time in a month

more