profile
viewpoint

attfarhan/about-1 0

Projects, content, and documentation as Open Source.

attfarhan/awesome-browser-extensions-for-github 0

A collection of awesome browser extensions for GitHub.

attfarhan/build-web-application-with-golang 0

A golang ebook intro how to build a web with golang

attfarhan/camelcase 0

Split a camelcase word into a slice of words in Go

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha e79b5f45ce5b863ba62c6b686ee4fcda834dd7c9

Web content styles (#12387)

view details

push time in 4 hours

delete branch sourcegraph/sourcegraph

delete branch : fa/web-content-styles

delete time in 4 hours

issue closedsourcegraph/sourcegraph

Create web content stylesheet

The addition of 'web' oriented styles have been added to the following components and their scss files and require consolidation once they are properly defined within the global styles:

SearchPage.tsx & SearchPage.scss RepositoryGroupPage.tsx & RepositoryGroupPage.scss PrivateCode.tsx & PrivateCode.scss

Additionally, on RepositoryGroupPage.tsx, several font-weight-normal overrides are occurring to meet the design specification with existing styles. The font weight should be incorporated into the web-styles elements.

closed time in 4 hours

rrhyne

PR merged sourcegraph/sourcegraph

Web content styles

Fixes https://github.com/sourcegraph/sourcegraph/issues/12303. Fixes https://github.com/sourcegraph/sourcegraph/issues/12460.

This removes style overrrides in the SearchPage, RepogroupPage, and PrivateCodeCTA components to apply new web-oriented styles. This creates a stylesheet in web-content.scss to define standard web styles.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+133 -230

7 comments

14 changed files

attfarhan

pr closed time in 4 hours

pull request commentsourcegraph/sourcegraph

Web content styles

Resolved all remaining comments. Going to merge this since there isn't anything blocking and it's been open for a while.

attfarhan

comment created time in 4 hours

push eventsourcegraph/sourcegraph

github-actions[bot]

commit sha c6d280cec8513a8c2f56ae39185cba5acb955a6e

Update third-party licenses (#12488) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

view details

Thorsten Ball

commit sha 9a85a646af4887e3b9551bdcc43f8dac7f2614a2

Update example in basestore.Store docstring (#12432) I think the docstring was a bit outdated.

view details

Eric Fritz

commit sha 74f698b0c8fcb8cb247580580984cce550fed2c7

codeintel: Add CalculateVisibleUploads to store (#12408)

view details

Ryan Slade

commit sha 65d2eae2857724b745ad953f6b719a7bd1ee746c

go: Update out graphql-go dependency (#12459)

view details

Stefan Hengl

commit sha 255cb618c755026d801b2d2fd5bc9d30197c19a5

search: support negation for field content (#12412)

view details

Keegan Carruthers-Smith

commit sha a521dfbea179120227aae57e31720c998475eeaf

zoekt: prevent indexserver stalling (#12502) See https://github.com/sourcegraph/zoekt/compare/6ed80895db7e...a99799fdc041 - a99799f ctags: handle fatal ctags errors - 5fcad78 ctags: skip commands that are too large - cf36be0 ctags: use file basename - d4fecb4 indexserver: timeout if no output for 5m - 34a0dd6 indexserver: coarse 1h timeout on index job - fdc9c2c Merge remote-tracking branch 'gerrit/master' - b48e35d shards: a progress message every 10s when loading - 4481f7b shards: throttle loading in watcher

view details

Robert Lin

commit sha 434fd412bfeb7c2cdb0909797a31e09d1588944f

monitoring: fix alert state query, fix alert firing threshold (#12489)

view details

uwedeportivo

commit sha 30f8af2388bce040be095a762c5492608a8db2f4

release captain 3.19 (#12505)

view details

Robert Lin

commit sha 37a8af898fffc0be990240f4979b7c1877b8fc3e

monitoring: migrate out-of-band alerts to the generator (#12391) Migrates all out-of-band alert rules defined by deploy-sourcegraph to the generator, such that each alert now has a panel as part of a service dashboard like all our other alerts, with a few changes and additions.

view details

Stephen Gutekanst

commit sha cff20a845c2263deacdcbf18e3b50e2b3c4af94c

Release Docker Compose v3.18.0-1 (#12509) * Release Docker Compose v3.18.0-1 * Release Docker Compose v3.18.0-1 * Release Docker Compose v3.18.0-1

view details

Robert Lin

commit sha da520cf2c4aa5396860e9569d8efe1f68e668f04

monitoring: log prom-wrapper attempts at connecting to the frontend (#12508)

view details

Robert Lin

commit sha 9db0d540d5dab475de834378c8a38988ef17ccd0

monitoring: use prometheus model.Duration (#12510)

view details

Stefan Hengl

commit sha d5b9e2ba04807b8555026027e43ce7eb9aec9103

web: update syntax highlighting for field content (#12512)

view details

Stefan Hengl

commit sha 888a7e74fa8edc76e3a57796d01b8f58e8ae8ca4

search: treat repo and rev separately when converting from glob to regex (#12492)

view details

Anukul Sangwan

commit sha fb3ab217aba970391f533a4e070e11c2a2f3c184

repo-updater: add HTML version of repo-updater-state page (#12498)

view details

Stefan Hengl

commit sha 66de79d60c9d6b31a4482ff557862638e14a6c58

web: update tooltips to be agnostic of regex and globbing (#12514)

view details

Keegan Carruthers-Smith

commit sha 2dcc237e22867e7d1c09edbce8458cbad6fd9977

frontend: speed up needs index site admin page (#12513) This page can be slow since we will only fetch a small number of repos from the db at a time. By fetching twice as many repos we have indexed we are gaurenteed to only need to fetch the list once from the DB.

view details

Marek

commit sha 4831eab61090dbcc4b2b2e4b827223c6ec169ce0

Improve and fix the browser extension readme (#12478)

view details

Robert Lin

commit sha 5d73f94a7ad9c8c5a5d30954f737e9dde5c2a8b5

monitoring: implement owner routing for alerts (#12491) Adds a new owners field to observability.alerts as proposed in #12010 for RFC-189. Only alerts that match the specified owners will be received by the associated notifier. Notifiers configured without the owners field will continue to receive all alerts of the specified level, even with notifiers that have owners present. Co-authored-by: Stephen Gutekanst <stephen.gutekanst@gmail.com>

view details

Keegan Carruthers-Smith

commit sha 5d25b0d8afd22c7e5a549ec800e9b06910f369e9

search: trace and observe each zoekt host (#12516) * search: trace and observe each zoekt host This commit moves tracing and observability from being around the aggregated zoekt client to being both the aggregated client and a trace per zoekt replica. To do this we adjust the prometheus metric to have a hostname label. We also change the category / family name to indicate if its a search against a specific zoekt replica or its the aggregation. * search: test NewMeteredSearcher

view details

push time in 5 hours

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 82013fe5dff2ba24c965d22e10e59d7319af4b65

Update search-query-link style

view details

push time in 5 hours

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha c13dc53672d796a2648082b63e77d3b6fa412f20

Update web/src/global-styles/web-content.scss Co-authored-by: Felix Becker <felix.b@outlook.com>

view details

push time in 5 hours

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha f30ecf34e3eefc674f6f78c337fc6e3050b7b95f

Update web/src/global-styles/web-content.scss Co-authored-by: Felix Becker <felix.b@outlook.com>

view details

push time in 5 hours

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 77e86700638c8e58480056c883fe68997e98034e

Fix: parens get removed from interactive mode queries (#12696)

view details

push time in 6 hours

delete branch sourcegraph/sourcegraph

delete branch : fa/fix-closing-paren

delete time in 6 hours

PR merged sourcegraph/sourcegraph

Fix: trailing parens get removed from interactive mode queries

Fixes https://github.com/sourcegraph/sourcegraph/issues/12506 and fixes https://github.com/sourcegraph/sourcegraph/issues/12690.

The closing paren character seems to be mistakenly excluded from literal values, hence it will always be excluded when parsing queries. Can you confirm this is the correct fix @lguychard? <!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+17 -4

3 comments

2 changed files

attfarhan

pr closed time in 6 hours

issue closedsourcegraph/sourcegraph

Interactive mode erases trailing parenthesis from query

This only happens in interactive mode. Enter \) in interactive mode, press search. The trailing ) disappears (but the search still runs for \)). Same thing with refreshing. It's also possible to see this behavior if you enter \) in plain text mode, then switch to interactive mode (the ) gets deleted).

Thanks @daxmc99 for flagging. Here's the video:

trailing-paren-bug

closed time in 6 hours

rvantonder

issue closedsourcegraph/sourcegraph

Trailing parenthesis in search URL is erased sometimes

On Sourcegraph version: 3.18 and master

A URL containing patternType=regexp for a query like repo:(sourcegraph) works as expected.

When The URL does not contain patterntype=XXX, a trailing parenthesis in the URL is erased. Here is an example of a URL containing the trailing ) (encoded as %29), but when the value is populated in the search bar, the trailing ) briefly appears and is then erased:

https://sourcegraph.com/search?q=repo:%28sourcegraph%29

This seems almost certainly related to https://github.com/sourcegraph/sourcegraph/issues/12506

Customer reported working previously, but broken as of 3.18.

closed time in 6 hours

rvantonder

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 7d55933fabeb7e8d9afdbcb9bac80925c1a789dd

Trim whitespace on navbarQuery

view details

push time in 7 hours

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha a8f4a338c58376358f0d36f0fbab633786d4a6ef

Revert "Fix: trailing parens get removed from interactive mode queries" This reverts commit 1c57ebc07aa44d6064ac93e060220869347a32be.

view details

Farhan Attamimi

commit sha 813485ca10010bd5f80c07b8a710eb982e916876

Fix: handle parentheses when converting interactive mode queries

view details

push time in 8 hours

pull request commentsourcegraph/sourcegraph

Fix: trailing parens get removed from interactive mode queries

Ah, the conversion function doesn't handle this

attfarhan

comment created time in 8 hours

issue commentsourcegraph/sourcegraph

Trailing parenthesis in search URL is erased sometimes

Or, it actually may be because the closing paren is excluded from literal values in the parser: https://github.com/sourcegraph/sourcegraph/pull/11688/files#diff-a3aab87936ca3f27111203014e861b46R227. I have a PR open to fix this https://github.com/sourcegraph/sourcegraph/pull/12696.

rvantonder

comment created time in 8 hours

PR opened sourcegraph/sourcegraph

Fix: trailing parens get removed from interactive mode queries

Fixes https://github.com/sourcegraph/sourcegraph/issues/12506#issuecomment-668385964 and fixes https://github.com/sourcegraph/sourcegraph/issues/12690.

The closing paren character seems to be mistakenly excluded from literal values, hence it will always be excluded when parsing queries. Can you confirm this is the correct fix @lguychard? <!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+1 -1

0 comment

1 changed file

pr created time in 8 hours

create barnchsourcegraph/sourcegraph

branch : fa/fix-closing-paren

created branch time in 9 hours

issue commentsourcegraph/sourcegraph

Trailing parenthesis in search URL is erased sometimes

followedBy identifies whitespace or a closing paren as a delimiter, so all closing parens are actually parsed out. I think we'd need to check if there's whitespace after the closingParen when identifying it as a delimimetr.

rvantonder

comment created time in 10 hours

issue commentsourcegraph/sourcegraph

Search 3.19 Tracking issue

Last week (4 day week -- public holiday)

I spent most of my time working on the search tour implementation, experimenting with different OSS libraries, primarily Shepherd and React-joyride. Also spent time early in the week addressing comments on the web content styles PR (https://github.com/sourcegraph/sourcegraph/pull/12387), will need to address whatever is remaining there to get it merged.

This week

Continuing on tour implementation. I am working on an implementation using Shepherd, and currently ironing out a few kinks but I believe this will be the implementation I go with.

nicksnyder

comment created time in a day

pull request commentsourcegraph/sourcegraph

Web content styles

@felixfbecker @rrhyne Ok to merge? Addressed all comments.

attfarhan

comment created time in 5 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 76c2dc8a92e3cfdffb724f6e100b5833d54d2799

Move example searches to web-content

view details

push time in 8 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 83704a6a98553f44012c0e1d9d59e86d8dff2555

Comments

view details

push time in 8 days

Pull request review commentsourcegraph/sourcegraph

Web content styles

                 color: $gray-19;             }         }--        &__web-link {-            color: #1c7cd6;-        }--        &__keyword-text {

yup, this was helpful, thanks!

attfarhan

comment created time in 8 days

Pull request review commentsourcegraph/sourcegraph

Web content styles

+.web-content {+    --link-color: #329af0;++    h1,+    h2,+    h3 {+        color: $gray-08;+        font-weight: normal;+    }++    h4 {+        color: $gray-06;+        font-weight: normal;+    }++    h5,+    h6 {+        color: $gray-04;+        font-weight: normal;+    }++    p {+        font-weight: normal;+        font-size: 14px;+        line-height: 20px;+        color: $gray-06;+    }++    i {

Ah thanks

attfarhan

comment created time in 8 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha e48dd983b80bf8dfe142b3397fa0649225c1e2fa

Remove italic style

view details

push time in 8 days

issue commentsourcegraph/sourcegraph

Search 3.19 Tracking issue

Last week

My focus last week was wrapping up outstanding debt from the search and repogroup pages. I merged the private code CTAs PR, worked on and opened a PR up for web content styles, and added additional logging on the repogroup and search pages. Also spent time in meetings (1:1s, retros) to improve future design->engineering process. I helped out with implementation of and reviewed the frontend updates for globbing in filters. Finally, I spent time looking into issues surfaced during 3.18 release testing (https://github.com/sourcegraph/sourcegraph/issues/12420, https://github.com/sourcegraph/sourcegraph/issues/12310).

This week

I will be focused on the search tour implementation this week.

nicksnyder

comment created time in 8 days

Pull request review commentsourcegraph/sourcegraph

Web content styles

+.web-content {+    --link-color: #329af0;++    h1,+    h2,+    h3 {+        color: $gray-08;+        font-weight: normal;+    }++    h4 {+        color: $gray-06;+        font-weight: normal;+    }++    h5,+    h6 {+        color: $gray-04;+        font-weight: normal;+    }++    p {+        font-weight: normal;+        font-size: 14px;+        line-height: 20px;+        color: $gray-06;+    }++    i {

Remvoed

attfarhan

comment created time in 8 days

Pull request review commentsourcegraph/sourcegraph

Web content styles

+.web-content {+    --link-color: #329af0;++    h1,+    h2,+    h3 {+        color: $gray-08;+        font-weight: normal;+    }++    h4 {+        color: $gray-06;+        font-weight: normal;+    }++    h5,+    h6 {+        color: $gray-04;+        font-weight: normal;+    }++    p {+        font-weight: normal;+        font-size: 14px;+        line-height: 20px;+        color: $gray-06;+    }++    i {+        color: $gray-06;+    }++    strong {+        color: $gray-11;+    }++    &__small {+        font-size: 12px;+    }++    &__search-keyword {+        color: var(--link-color);

I just used the color hashes. Makes sense to decouple if we decide to change the link color and not the keyword color.

attfarhan

comment created time in 8 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 8e8d0d3de7b1f1a0358c9fbc4efceb36286d8ed8

Comments

view details

push time in 8 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha d98bedffc34e86605910672ca90fb96b6c5430ff

workerutil: Fix nil-deref in when using worker store transactionally (#12407)

view details

Keegan Carruthers-Smith

commit sha 4ad852548c256b82e8ee6ed4fd31c0b7d5074095

ci: skip db-backcompat check if branch is out of date (#12326)

view details

Eric Fritz

commit sha 8031e562ca8d0f132584b485bbf4faa6cf01cc3c

codeintel: Add tables for denormalizing nearest upload data (#12406)

view details

Rijnard van Tonder

commit sha 5d9aa988facb8af99745718d2220b4e26fe06e74

search: move search.Uppercase logic (#12386)

view details

Rijnard van Tonder

commit sha 3b82bd486a036172bdbf2fd65458642f8f6a6d38

search: add prometheus labels to search alerts (#12384)

view details

Dax McDonald

commit sha d708886a9e5a8802f5e53e7642029e14e656d798

Update changelong for 3.18 (#12413)

view details

Eric Fritz

commit sha 5c42d6954211dde1e74d601602f9cedb51919212

codeintel: Add CommitGraph to gitserver client (#12404)

view details

Eric Fritz

commit sha 8af9002ca940c8b064f32322ee717013040329a3

codeintel: Add commit graph utilities (#12402)

view details

Eric Fritz

commit sha 4db05a84e89d9115a7fcee2ac868a2a09d3b67b2

codeintel: Add Lock to store (#12401)

view details

Rijnard van Tonder

commit sha 568ad90e70537450358f39783c9ced70d27d43f7

search: add additional alert for comby out of memory (#12385)

view details

Rijnard van Tonder

commit sha 7814eca4dc3feb4b7fa06e88f4575061c8cc7ea6

search: add DNF conversion for hierarchical search (#12381)

view details

Keegan Carruthers-Smith

commit sha c22422b05c57a70afee1674a99db922e28f2820e

schema: cleanup schema gen (#12394) Moved logic into a shell script and deduplicated it a bit.

view details

Ryan Slade

commit sha f085ae76798b6c7f8351875fb4587d3a564a0923

go: Update our graphql-go dependency (#12430)

view details

Felix Becker

commit sha e7f82155835102cebed818e9aaa4f55a0ecb9e5e

Update info color to a lighter cyan (#12433)

view details

Keegan Carruthers-Smith

commit sha 62738b92764866c3b3d77e26dff35e1a69014672

search: limit indexed branches per repository to 64 (#12431) Zoekt only supports indexing up to 64 repositories. This commit enforces this in the JSON schema for "search.index.branches". Enforcing this for Version Contexts will require adding a custom validator, which I'll leave for a later improvement. Since we don't enforce this everywhere, the options we generate will deterministically only return up to 64 branches. If an admin specifies more, it is likely better to index 64 branches than index none and fail.

view details

Keegan Carruthers-Smith

commit sha c03c8d475820912385372d7502fdace795847aa5

endpoint: prom metric and debug logs for k8s service discovery (#12434)

view details

Rijnard van Tonder

commit sha 9d4818686873846ec6268801b0f38fc72168711b

search: update parser fuzzer harness (#12438)

view details

Dan Adler

commit sha 3f383db8a6757c9616a1bad36fa1c08403d8df0b

Add link to saved searches page in email (#11651) * Add link to saved searches page in email * Add changelog * Update changelog

view details

Dax McDonald

commit sha f04c93047b6317d88d0985730a774a122dc88f04

Add cleanup step to Grafana and Prometheus ignored files (#12428) * Add cleanup step to Grafana and Prometheus ignored files * Handle path err & use const

view details

Keegan Carruthers-Smith

commit sha 971f0eca42806e7ea042e95ef0879c9541feb809

debugproxies: clearer debug logs for watchEndpointEvents (#12427) We log errors for /-/debug endpoint's use of k8s service discovery as debug logs. This can look like real problems in our cluster when you spot the log messages. This commit updates the log message to be more informative, as well as to differentiate between expected errors vs unexpected errors.

view details

push time in 8 days

Pull request review commentsourcegraph/about

Add docs on how we style UI

+# Styling UI++Sourcegraph has many UI components. A unique constraint for these is that they need to run within different _environments_.+Wherever a component is running, it should look native to its environment and consistent with the design of that environment.+For example, our hover overlay needs to work and _behave_ the same in the Sourcegraph webapp and in the browser extension, where it is injected into a variety of code hosts, but _look_ native to the environment.+Components need to be able to adapt styles from CSS stylesheets already loaded on the page (no matter how those were architected).++## Goals++1. Components decoupled from styling, that look **consistent** with the host environment.+2. Support light and dark themes.+3. Tooling support:+   - Autocompletion for styles when writing components+   - Autocompletion when writing styles+   - Linting for styles+   - Browser dev tools to easily inspect and iterate on styles+   - Autoprefixer+4. Support for advanced CSS features, like state selectors, pseudo elements, flexbox, grid, media queries, CSS variables, ...++## Environments++### Host-agnostic UI++Components that need to run in different environments (any UI shared between our browser extension and the webapp) adopt styles from their environments through configurable CSS class names (as opposed to trying to replicate the styling with copied CSS).+A component may accept multiple class names for different elements of the component.+An example of this is `<HoverOverlay/>`: see how [the different props it accepts](https://sourcegraph.com/github.com/sourcegraph/sourcegraph@4047521a92904054e782d341001d08d61945c86f/-/blob/shared/src/hover/HoverOverlay.tsx#L27-39) for its child components' class names are passed in the [webapp](https://sourcegraph.com/github.com/sourcegraph/sourcegraph@4047521a92904054e782d341001d08d61945c86f/-/blob/web/src/components/shared.tsx#L35-44) and in [code host integrations](https://sourcegraph.com/github.com/sourcegraph/sourcegraph@4047521a92904054e782d341001d08d61945c86f/-/blob/browser/src/shared/code-hosts/shared/codeHost.tsx#L443:1).++### Host-specific UI++In the environments we control ourselves (such as our webapp, the options page of the browser extension, or our marketing website), we use a customized version of [Bootstrap](https://getbootstrap.com/) as a CSS framework.+Any code inside our webapp can and should make use of the CSS classes that Bootstrap provides as building blocks (and should generally do so instead of writing custom styles).+This includes classes like [cards](https://getbootstrap.com/docs/4.5/components/card/), [buttons](https://getbootstrap.com/docs/4.5/components/buttons/) or [input groups](https://getbootstrap.com/docs/4.5/components/input-group/), but also utility classes for [layout](https://getbootstrap.com/docs/4.5/utilities/flex/) and [spacing](https://getbootstrap.com/docs/4.5/utilities/spacing/).+Please refer to the excellent [Bootstrap documentation](https://getbootstrap.com/docs/4.5/) for everything that is available for use.+To see what our customizations look like visually (in both light and dark theme), you can find a [showcase in our Storybook](https://5f0f381c0e50750022dc6bf7-oozlspcdwk.chromatic.com/?path=/story/web-global-styles).++Components only used in a specific host environment do not need to support customization through class names.+They can however utilize environment-agnostic components by passing our Bootstrap classes as custom `className` values.++## Our approach to styling++### Structuring style sheets++A component may need styles that are common to all environments, like internal layout.+We write those styles in SCSS stylesheets that are imported into the host environment.+In some cases these can be overridden by passing another class name for that element.++To avoid naming conflicts we structure these files using the [BEM convention](http://getbem.com/naming/) (Block - Element - Modifier).+The _block_ name is always the React component name, _elements_ and _modifiers_ are used as specified in BEM.+A _block_ must not be referenced in any other React component than the one with the matching name.++Example:++```scss+.some-component {+    // .. styles ...++    &__element {+        // ... styles ...++        &--modifier {+            // ... styles ...+        }+    }+}+```++- **Block**: A React component name in kebab-case. This class is always assigned to the root DOM element of the component.+- **Element**: A sub-element of the component. This should be a name that describes the semantic of this element within the component.+- **Modifier**: A modifier of the _element_, e.g. `--loading` or `--closed`. This is only rarely needed.++Please note that there is no hierarchy in _elements_, as that would couple the styling to the DOM structure. Element names should be unambiguous within their component/_block_, or be split into a separate component/_block_.++We colocate stylesheets next to the component using the same file name.+This approach ensures styles are easy to find and makes it easy to tell which styles apply to which elements (by putting them side-by-side in an editor, or through a simple text search).++Using classes, as opposed to child and descendant selectors, decouples styles from the DOM structure of the component, ensures encapsulation and avoids CSS specificity issues.+Descendant selectors can still be useful in rare cases though, like styling in the browser extension, or styling markdown content.++### Typography++Avoid ever overriding font family, text sizes or text colors.+These are set globally by the host environment for semantic HTML elements, e.g. `<h1>`, `<a>`, `<code>` or `<small>`.++### Colors and theming++The brand color palette is [OpenColor](https://yeun.github.io/open-color/).+In addition to these, we define a blueish grayscale palette for backgrounds, text and borders.+These colors are all available as SCSS and CSS variables.+However, directly referencing these may not work well in both light and dark themes, and may not match code host themes (if the component is shared).+The best approach is to not reference colors at all and use building blocks that have borders, text colors etc defined.+This saves code and makes it easy to maintain design consistency even if we want to change colors in the future.+When that is not possible (for example UI contributed by extensions), prefer to reference CSS variables with semantic colors like `var(--danger)`, `var(--success)`, `var(--border-color)`, `var(--body-bg)` etc.+The values of these variables are changed globally when the theme changes.+Be aware that this means our stylesheets for each host environment need to define these variables too.++Defining different styles in the webapp depending on the `theme-dark` and `theme-light` classes predates CSS variables and is discouraged.

Does this refer to styles like this?:

.theme-light {
  .some-class {
    color: red;
  }
}

Wasn't aware this was discouraged, good to know.

felixfbecker

comment created time in 11 days

delete branch sourcegraph/sourcegraph

delete branch : fa/fix-contrast

delete time in 11 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha ed9e75d750d782fc240c203610c6dac0338a8445

Fix: low contrast search examples in dark theme (#12462)

view details

push time in 11 days

PR merged sourcegraph/sourcegraph

Fix: low contrast search examples in dark theme

Fixes https://github.com/sourcegraph/sourcegraph/issues/12460.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+0 -6

2 comments

1 changed file

attfarhan

pr closed time in 11 days

issue closedsourcegraph/sourcegraph

Low contrast on search examples

Reported at https://sourcegraph.slack.com/archives/C0HMGV90V/p1595551306125500.

Example searches the search page on Sourcegraph.com are low contrast. image

closed time in 11 days

attfarhan

PR opened sourcegraph/sourcegraph

Fix: low contrast search examples in dark theme

Fixes https://github.com/sourcegraph/sourcegraph/issues/12460.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+0 -6

0 comment

1 changed file

pr created time in 11 days

create barnchsourcegraph/sourcegraph

branch : fa/fix-contrast

created branch time in 11 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 3dd163b1925309b0d62fbff1f64acb9e31a612b0

Log click events on search homepage and repogroup page (#12405)

view details

push time in 11 days

delete branch sourcegraph/sourcegraph

delete branch : fa/logging

delete time in 11 days

PR merged sourcegraph/sourcegraph

Reviewers
Log click events on search homepage and repogroup page

Fixes https://github.com/sourcegraph/sourcegraph/issues/12356.

Adds 3 event to our logging:

  • RepogroupPageRepoLinkClicked event when clicking on repository links on the repogroup page
  • ExampleSearchClicked when an example search is clicked on the homepage
  • ExampleLanguageSearchClicked when an example language is clicked on the homepage

@ebrodymoore do these names suffice or should they be follow a certain format?

+23 -3

2 comments

2 changed files

attfarhan

pr closed time in 11 days

issue closedsourcegraph/sourcegraph

Log 3 click events for new features on Search Homepage and Repo Page

Feature request description

Add logging to measure usefulness of new features added to Search Home Page and Repo Group Page

  1. Homepage (Done) Repogroups section: click + repogroup title + search link (New) Example Searches list section: Item click + search link (New) Search a language list section: Item click + search link
  2. Repogroup (Done) Search Examples -> Search button: click + search link (New) Repositories List: click + repo link

Once we add this data, we can also segment users by new feature usage for other analytics like retention and # of searches. See Search Homepage Data (1. Usage) for more details.

closed time in 11 days

poojaj-tech

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha d98bedffc34e86605910672ca90fb96b6c5430ff

workerutil: Fix nil-deref in when using worker store transactionally (#12407)

view details

Keegan Carruthers-Smith

commit sha 4ad852548c256b82e8ee6ed4fd31c0b7d5074095

ci: skip db-backcompat check if branch is out of date (#12326)

view details

Eric Fritz

commit sha 8031e562ca8d0f132584b485bbf4faa6cf01cc3c

codeintel: Add tables for denormalizing nearest upload data (#12406)

view details

Rijnard van Tonder

commit sha 5d9aa988facb8af99745718d2220b4e26fe06e74

search: move search.Uppercase logic (#12386)

view details

Rijnard van Tonder

commit sha 3b82bd486a036172bdbf2fd65458642f8f6a6d38

search: add prometheus labels to search alerts (#12384)

view details

Dax McDonald

commit sha d708886a9e5a8802f5e53e7642029e14e656d798

Update changelong for 3.18 (#12413)

view details

Eric Fritz

commit sha 5c42d6954211dde1e74d601602f9cedb51919212

codeintel: Add CommitGraph to gitserver client (#12404)

view details

Eric Fritz

commit sha 8af9002ca940c8b064f32322ee717013040329a3

codeintel: Add commit graph utilities (#12402)

view details

Eric Fritz

commit sha 4db05a84e89d9115a7fcee2ac868a2a09d3b67b2

codeintel: Add Lock to store (#12401)

view details

Rijnard van Tonder

commit sha 568ad90e70537450358f39783c9ced70d27d43f7

search: add additional alert for comby out of memory (#12385)

view details

Rijnard van Tonder

commit sha 7814eca4dc3feb4b7fa06e88f4575061c8cc7ea6

search: add DNF conversion for hierarchical search (#12381)

view details

Keegan Carruthers-Smith

commit sha c22422b05c57a70afee1674a99db922e28f2820e

schema: cleanup schema gen (#12394) Moved logic into a shell script and deduplicated it a bit.

view details

Ryan Slade

commit sha f085ae76798b6c7f8351875fb4587d3a564a0923

go: Update our graphql-go dependency (#12430)

view details

Felix Becker

commit sha e7f82155835102cebed818e9aaa4f55a0ecb9e5e

Update info color to a lighter cyan (#12433)

view details

Keegan Carruthers-Smith

commit sha 62738b92764866c3b3d77e26dff35e1a69014672

search: limit indexed branches per repository to 64 (#12431) Zoekt only supports indexing up to 64 repositories. This commit enforces this in the JSON schema for "search.index.branches". Enforcing this for Version Contexts will require adding a custom validator, which I'll leave for a later improvement. Since we don't enforce this everywhere, the options we generate will deterministically only return up to 64 branches. If an admin specifies more, it is likely better to index 64 branches than index none and fail.

view details

Keegan Carruthers-Smith

commit sha c03c8d475820912385372d7502fdace795847aa5

endpoint: prom metric and debug logs for k8s service discovery (#12434)

view details

Rijnard van Tonder

commit sha 9d4818686873846ec6268801b0f38fc72168711b

search: update parser fuzzer harness (#12438)

view details

Dan Adler

commit sha 3f383db8a6757c9616a1bad36fa1c08403d8df0b

Add link to saved searches page in email (#11651) * Add link to saved searches page in email * Add changelog * Update changelog

view details

Dax McDonald

commit sha f04c93047b6317d88d0985730a774a122dc88f04

Add cleanup step to Grafana and Prometheus ignored files (#12428) * Add cleanup step to Grafana and Prometheus ignored files * Handle path err & use const

view details

Keegan Carruthers-Smith

commit sha 971f0eca42806e7ea042e95ef0879c9541feb809

debugproxies: clearer debug logs for watchEndpointEvents (#12427) We log errors for /-/debug endpoint's use of k8s service discovery as debug logs. This can look like real problems in our cluster when you spot the log messages. This commit updates the log message to be more informative, as well as to differentiate between expected errors vs unexpected errors.

view details

push time in 11 days

Pull request review commentsourcegraph/sourcegraph

Log click events on search homepage and repogroup page

 interface Props     showCampaigns: boolean } -const SearchExampleClicked = (): void => eventLogger.log('ExampleSearchClicked')-const LanguageExampleClicked = (): void => eventLogger.log('ExampleLanguageSearchClicked')+const SearchExampleClicked = (url: string) => (): void => eventLogger.log('ExampleSearchClicked', { url })

I'm going to avoid this for now, since examples can change down the line, and a naming convention for each could be imprecise. We pass URLs for other events so it's not an uncommon thing to see in our codebase. @ebrodymoore any objections here?

attfarhan

comment created time in 11 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha a47cf46e0a5802d499e338585c0b4551b89e0e08

Update snapshot

view details

push time in 11 days

issue openedsourcegraph/sourcegraph

Low contrast on search examples

Reported at https://sourcegraph.slack.com/archives/C0HMGV90V/p1595551306125500.

Example searches the search page on Sourcegraph.com are low contrast. image

created time in 11 days

pull request commentsourcegraph/sourcegraph

Web content styles

@rrhyne @felixfbecker please take a look, this removes the existing overrides and gives us a base for web styles

attfarhan

comment created time in 12 days

push eventsourcegraph/sourcegraph

Keegan Carruthers-Smith

commit sha d0d94c904a84d53f9e72c30e5b28380d8b3d4edb

src-expose: disable background updates in tests (#12361) We could complicate the design of Serve such that we wait for background updates to stop. However, this would be for the benefit of tests only. Instead we just disable background updates in tests.

view details

Nick Snyder

commit sha a536a0ae1dd9e0c1811e3bb1c79f9196cd389b95

Remove deprecated blacklist option (#12345)

view details

Felix Becker

commit sha 08acd53ade631ddcf417edb51be6a8703b0ff73e

Import * as H from 'history' (#12364)

view details

renovate[bot]

commit sha 5a95caff7fe715cda1c75b37f24863f6c0e6cf48

Update dependency bootstrap to ^4.5.0 (#10729) * Update dependency bootstrap to ^4.5.0 * Define dropdown variables before importing variables.scss Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Felix Becker <felix.b@outlook.com>

view details

renovate[bot]

commit sha 5319613346625f33274655554073dc49c3a2dd50

Update Node.js to v14.5.0 (#11840) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 90db38a2ee7f05f9749e9239777050a70a117b74

Update dependency typedoc to ^0.17.8 (#11884) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Chayim

commit sha c3a5992d5a93edeb3cf4175b5c6d862c85a742ef

unit tests for secrets database code (#12337) * unit tests for secrets database code

view details

Rob Rhyne

commit sha 3b2daf896c94398cfead0af2089e374ee174deea

add public code tag line (#12371) Adds a tag line below the sourcegraph logo to help users understand the differences between cloud and enterprise search.

view details

Jackson R

commit sha a6a6af53122fc77dd5e50c0c39c8404686180919

docs: Add DocForge annotations and introduce Sourcegraph link monitoring (#12222)

view details

ᴜɴᴋɴᴡᴏɴ

commit sha 806465d8812f888e69508470916b886c309a85c4

authz: remove on-demand permissions fetching (#12319) Co-authored-by: Ryan Slade <ryanslade@gmail.com>

view details

ᴜɴᴋɴᴡᴏɴ

commit sha 37ea28aeee5f1b8e186b826504246cc0f4dff0e2

gqltest: migrate commit, diff and global text search (#12355)

view details

Keegan Carruthers-Smith

commit sha 9ed7917606ca709aa03a12b1f9de00813e3e3262

github-proxy: use http.ProxyFromEnvironment for custom transport (#12389) github-proxy now respects the environment variables HTTP_PROXY, HTTPS_PROXY and NO_PROXY (or the lowercase versions thereof). Other services already respect these variables, but this was missed.

view details

Stefan Hengl

commit sha a3aeba39e0edc6068b56a0576c69d22b85c9cf5a

search: support globbing for filters (#12365)

view details

Felix Becker

commit sha 4047521a92904054e782d341001d08d61945c86f

Extend global styles storybook (#12392)

view details

Erik Seliger

commit sha 1253e395f9d4502ba2955ac2887918fc19058fdf

Fix schema file watcher (#12373)

view details

Thorsten Ball

commit sha 143e6a33498c2561e262f1b7a53174ffaf6b28df

Prepare codebase for new campaigns workflow (#11675) * WIP: New campaigns workflow * Remove old UI for switch to new campaigns workflow (#11891) * Add a basic implementation of the applyCampaign mutation (#11934) * update campaigns docs to reflect new flow (#11972) * update GraphQL API to remove unneeded namespace param, add applyCampaign test (#11982) * add applyCampaign resolver test, temporarily un-implement createCampaign The createCampaign mutation is strictly less powerful than applyCampaign, and it adds needless complexity to implement createCampaign now, especially since we'll be changing the impl of applyCampaign a lot. So, let's remove the createCampaign impl for now. Then we also need to change the resolver test from testing createCampaign to testing applyCampaign. * remove unneeded namespace param from createCampaign and applyCampaign mutations The namespace is immutably stored in the campaign spec, which is also provided as a param. * Implement moveCampaign mutation (#12049) * Fix campaigns web code after rebase * Implement ChangesetSpec resolver and validation of specs (#12092) * Implement ChangesetSpec.Description in resolver and data layer * Add ChangesetSpec/CampaignSpec schema and Validate() method * Validate ChangesetSpec against schema on create * Validate CampaignSpec against schema * Allow YAML as CampaignSpec input (caveat: 'on' needs to be quoted) * Fix critical whitespace error * Fix CampaignSpec.ParsedInput response * Remove debug log statement * Remove TODO comment * Fix indentation in raw specs for testing * Run prettier Co-authored-by: Erik Seliger <erikseliger@me.com> * Use fork of ghodss/yaml to use 'on' as key in CampaignSpec (#12153) As we noticed last week: we can't use `on` as a key in a `CampaignSpec` because `yaml.YAMLToJSON` would convert that `on` into a `true` and that in turn would fail when validated. The solution here is to use a custom fork of `ghodss/yaml` that allows passing in a custom unmarshal-function which does _not_ do the conversion. The function we're passing in comes from the yaml.v3 library which changed its behavior when parsing boolean values (see https://github.com/ghodss/yaml/pull/65). We lose the ability to use `YAMLToJSONStrict` since that only works with yaml.v2, but yaml.v3 already warns about duplicated keys and the JSON schema validation gives us enough of a safety net for the rest. * Remove duplication in ChangesetSpec/CampaignSpec.UnmarshalValidate (#12156) * Remove repositoryDiffs (#12205) * Remove openChangesets resolver (#12209) We don't need it for the new UI anymore, so reducing the headache of maintaining it. * Implement minimal resolvers to incorporate schema changes (#12215) * Use same changeset resolver for hidden and visible changesets (#12221) * Fix compilation after rebase * Delete expired CampaignSpecs and ChangesetSpecs (#12210) * Fix compilation after rebase * Delete expired Campaign/ChangesetSpecs * Return correct ExpiresAt in Campaign/ChangesetSpec resolvers * Clean up tests for spec expiry * Remove unneeded Truncate Co-authored-by: Erik Seliger <erikseliger@me.com> * Remove unused dependency (#12245) * Implement placeholders for status and preview API (#12226) * Remove store.GetRepoIDsForFailedChangesetJobs (#12323) This was a left-over from the last PR that removed some functionality. I know that there's a lot more code that's technically unused now, but this one stood out since it had the really specific usecase of loading error messages for a campaign. * Another set of small follow-ups after introducing ExternalChangesetState (#12330) * Add a ChangesetState.Valid() method * Rename test method to reflect name of method under test * Update naming and un-export methods * Implement missing bits in CampaignSpec/ChangesetSpec resolvers (#12247) * Fix intendation of query in test * Implement CampaignSpec.ViewerCanAdminister * Add safety-check to ChangesetSpecDescription.Diff method * Clean up repository permissions test * Implement rest of ChangesetSpec and CampaignSpec resolvers * Add options to CountChangesetSpecsOpts * Implement changesetSpecConnectionResolver * Reduce test data after reducing test cases * Change type checks on ChangesetSpecDescription * Query __typename in test to make sure we get the right response * Use same repo query pattern in ChangesetResolver as in changesetSpecResolver * Implement the after param for changesetSpecs connection * Check for permissions in applyCampaign and moveCampaign * Add a test for ChangesetSpec.Description.Diff * Remove isHidden filter * Do not yield ChangesetSpec if repo is (soft-)deleted * Fix rebase gone wrong * Check namespace perms in CreateCampaignSpec/MoveCampaign (#12362) (This is part #11675 and the new workflow) Before this, every user could create a campaign spec in any org or user namespace. And the same was true for moveCampaign: a user could move a campaign into namespace they wanted. This changes both implementations in the service layer to check for the permissions of the current user (saved in the ctx): 1. If it's a site admin, they can create/move things in any namespace. 2. If not and the target namespace is an org, we check for org membership. 3. If not and the target namespace is a user, we check that it's the same as the current user. * Make schema for env more strict to only accept strings (#12335) Environment variables can only be strings, so we shouldn't accept int, bool etc. * Drop old campaigns tables and add missing columns (#12388) * Drop old campaigns tables and add missing columns This drops the following tables: - changeset_jobs - patches - patch_sets Why drop them? Since we decided we're going to migrate existing campaigns into read-only versions and that we don't want to keep working state (changeset_jobs) around, it doesn't make sense to keep the tables. Why keep empty tables? So, this removes the tables and all the code that depends on them. It also does two other things: - Add a `changeset_spec_id` column to `changesets` (that's not yet read/written to in the `campaigns.Store`) - Add three `diff_stat_*` columns to `changeset_specs`, populate them when creating a new `ChangesetSpec` and reading/writing them in the `campaigns.Store`. Why? Because I don't want to write another migration that adds diff stats to changeset specs in case those were created between the introduction of changeset specs and us adding the fields. * Do not show changeset count in frontend * Add notice to WIP campaigns docs that they're WIP (#12393) * Campaign frontend cleanup work (#12256) Co-authored-by: Quinn Slack <sqs@sourcegraph.com> Co-authored-by: Erik Seliger <erikseliger@me.com>

view details

Thorsten Ball

commit sha c657aa984b01e9a47d87494be3d2cc284ecab6ec

Minor fix in campaign docs (#12397)

view details

Eric Fritz

commit sha b06f35688c54289ae5a03346bce9480f7a872c08

workerutil: Make all column names customizable (#12398)

view details

Asdine El Hrychy

commit sha 69c4e4ee0faae6f75774ac53e2ec709452c3901f

Add missing changelog entry (#12359)

view details

Thorsten Ball

commit sha 4c20cabd65390c3a636a0a75026796de75bb206c

Fix docforge warning for campaigns dev docs (#12400)

view details

push time in 12 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha d1409b87030323bb2f84830dad1ad75ea727c9fa

Remove overrides

view details

push time in 12 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 7bce7e5205fa5a9be8e697ba8518063a0503a766

Update styles

view details

Farhan Attamimi

commit sha cce0756ed6719b6573830d6a93cd5310a9543273

Remove overrides

view details

push time in 12 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 5a481bf948136bf67f9f2fcb93fa5c412ae8f674

Pass metadata to logs

view details

push time in 12 days

issue commentsourcegraph/sourcegraph

Branch names not showing up on search results

@dadlerj actually we have never shown this in the past. The issue here is that the inputRevision can be multiple things. You're diffing a head and a base, and the head/base could have a specified or unspecified input revision. So it's unclear what to show here.

But, this UX is not good and we should think about this more down the line. cc @poojaj-tech (to surface this to product/design)

dadlerj

comment created time in 12 days

issue commentsourcegraph/sourcegraph

Branch names not showing up on search results

Notes:

  • We pass through the html to render from the backend, not sure why it's suddenly excluding branch names
  • https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/cmd/frontend/graphqlbackend/search_commits.go#L365:1-377:2 this function doesn't seem to append branch name to the label, but quite sure it appeared before. Odd.
dadlerj

comment created time in 12 days

Pull request review commentsourcegraph/sourcegraph

Log click events on search homepage and repogroup page

 export const RepogroupPage: React.FunctionComponent<RepogroupPageProps> = (props     ) } +const RepoLinkClicked = (): void => eventLogger.log('RepogroupPageRepoLinkClicked')

@ebrodymoore pass through the actual language/example that was clicked?

attfarhan

comment created time in 13 days

pull request commentsourcegraph/sourcegraph

web: remove regex anchors if globbing is active

@stefanhengl your build is failing because there are still some components that require globbing to be passed through: https://buildkite.com/sourcegraph/sourcegraph/builds/68960#a8aff3cd-ec19-4f80-8498-3e96cc683c80

stefanhengl

comment created time in 13 days

PR opened sourcegraph/sourcegraph

Reviewers
Log click events on search homepage and repogroup page

Fixes https://github.com/sourcegraph/sourcegraph/issues/12356.

Adds 3 event to our logging:

  • RepogroupPageRepoLinkClicked event when clicking on repository links on the repogroup page
  • ExampleSearchClicked when an example search is clicked on the homepage
  • ExampleLanguageSearchClicked when an example language is clicked on the homepage

@ebrodymoore do these names suffice or should they be follow a certain format?

+13 -3

0 comment

2 changed files

pr created time in 13 days

create barnchsourcegraph/sourcegraph

branch : fa/logging

created branch time in 13 days

pull request commentsourcegraph/sourcegraph

WIP: Web content styles

@rrhyne I'm getting started on this stylesheet, but I am struggling to come up with the styling rules for web content. A lot of the overrides were one-off.

These are overrides that I need some clarification on:

  • On the repogroup page, the "repositories" header is an H2 with normal font-weight. Should all H2s be normal font weight, or what should this type of header be called?

image

  • Repository links are 12px font. Should all links be 12px, or what should these particular ones be called? image

  • I noticed in [SearchPage.scss]((https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/web/src/search/input/SearchPage.scss#L147-178) and RepogroupPage.scss you define colors for h1,h2...etc, but the colors differ between the two. Which ones do we want to standardize on?

attfarhan

comment created time in 13 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 301ef4b383e6eafef58a168fca9c5d34ab1a11a0

WIP: Web content styles

view details

push time in 13 days

PR opened sourcegraph/sourcegraph

WIP: Web content styles

Fixes https://github.com/sourcegraph/sourcegraph/issues/12303.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+37 -34

0 comment

6 changed files

pr created time in 13 days

create barnchsourcegraph/sourcegraph

branch : fa/web-content-styles

created branch time in 13 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 4f424a6e2f576ac21bf008385a0c0fc8e2c3ee20

WIP: use observable for globbing

view details

push time in 14 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha ebd15d4d10fc9d77a2f70b678ff55f651f524224

Add private code CTAs (#12288)

view details

push time in 14 days

delete branch sourcegraph/sourcegraph

delete branch : fa/private-code-ctas

delete time in 14 days

PR merged sourcegraph/sourcegraph

Add private code CTAs

Fixes https://github.com/sourcegraph/sourcegraph/issues/11799.

image

image

image

Adds CTAs to install Sourcegraph for private code to search homepage, campaigns, and repogroup pages, as in the design: https://www.figma.com/file/X5WmkZmMv8wACPpxFDgKpX/RFC-165-Search-CTAs?node-id=0%3A1&viewport=2658%2C620%2C0.25

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+600 -358

2 comments

13 changed files

attfarhan

pr closed time in 14 days

issue closedsourcegraph/sourcegraph

Add CTAs and what cloud searches message

CTAs for helping users find and install their private cloud images should be placed in the following locations:

  • Home page
  • Repository group page
  • Campaigns page

Additionally, users are confused as to what the cloud deployment searches. Text has been added under the filters on the home page to clarify.

This Figma file provides the designs and current copy. Final copy will likely change.

https://www.figma.com/file/X5WmkZmMv8wACPpxFDgKpX/RFC-159-Search-CTAs?node-id=0%3A1&viewport=2658%2C620%2C0.25

Project is related to this RFC: https://docs.google.com/document/d/1jzkLqidzJ57_ajpfIrcOYExea7MAvtww_dU_oVw9vI0/edit

closed time in 14 days

rrhyne

push eventsourcegraph/sourcegraph

Keegan Carruthers-Smith

commit sha 3cb30b5ff3f15ba152a9153873ea4b1ad3929519

honey: sample 1 in 16 events (#12317) Band-aid solution until we can investigate further. Again hitting very high usage. Likely due to recent scaling up of the indexed search cluster. Will require more investigation, but we should probably segment user request path.

view details

ᴜɴᴋɴᴡᴏɴ

commit sha 74159cd2319a43b08e7da75591fead5ba04d8758

authz: return empty `permissionsInfo` in OSS version (#12313)

view details

Ryan Slade

commit sha 9da26cb86fbf866625cd5133c23ee21c16dd124c

repo-updater: Sleep on error during syncClone (#12299) * repo-updater: Sleep on error during syncClone Instead of immediatley looping around and potentially putting more pressure on gitserver or the repo store. * Changes from review * Move err check * Refactor to remove sleep / continue pattern

view details

github-actions[bot]

commit sha 7fec1bcc70080af496621516526cd67851f6606e

Update third-party licenses (#12116) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

view details

ᴜɴᴋɴᴡᴏɴ

commit sha 4644536a09e4864073a60a812341b6d9342c418b

Update CHANGELOG.md (#12320)

view details

Keegan Carruthers-Smith

commit sha 2b195bf4f627fea8001aba68efbbf6bc2452b62c

doc: Update and add docs for multiple index search (#12295) Lots of changes have happened due to indexing multiple branches. We update the dev architecture docs to mention options (how we configure multiple branch search) as well as shallow cloning. We mention multiple revision search syntax. We mention how to configure multi branch indexing. We mention how to search HEAD explicitly.

view details

Keegan Carruthers-Smith

commit sha 42f81405fad86921e76e9b317d38ad5358e5dd34

ci: only run go steps if only changing go (#12321) This should significantly speed up Go PR checks.

view details

Thorsten Ball

commit sha d6d2fcdd1ab0ebfd50cb5431083b60853f2bfd04

Rename MockGitHubChangesetSync to more generic name (#12315) We've talked about this when the mock was introduced, but I think it got lost. So, here we go: this mock is not tied to GitHub, since its mocks are called in `SetDerivedState` when computing the `SyncState`, let's get rid of the `GitHub` in the name.

view details

Thorsten Ball

commit sha f18421a031104323cec4c830063efae1c6f28875

Remove unneeded context and error from CheckState method (#12316)

view details

Felix Becker

commit sha c6de674fa8b71600d28f4ab0028ccad8d97795b0

Automatically accept Chromatic baseline on master (#12325)

view details

Asdine El Hrychy

commit sha 90c8a30e6a4dbf48f23692658ca5be39e741df74

Replace gophermail by jordan-wright/email (#12239)

view details

Asdine El Hrychy

commit sha df326976fe6f99d344a1c6b66bf52f241370b998

Skip TLS Verify check if TLS is disabled (#12243)

view details

Erik Seliger

commit sha caa5695a399417f8f933ca30f55329e46a0368c4

Fix flacky chromatic snapshots (#12338)

view details

하광일 / CE / TC

commit sha 9161e3ef106ccc4ed1804b221f9db8fcd5d3fb96

Fix jaeger config in single docker container (#12312)

view details

Bunny

commit sha 219cc4d341d9fd293230a811d099bece7d777d9d

Revisions (#12217) * Revisions Updated the first paragraph and last sentence. Made a handful of other minor changes for readability * Removed redundancy about changeset * Fixed typo

view details

Keegan Carruthers-Smith

commit sha 1dffc994280aef9626250b1d64bc6b531e26636d

zoekt: improve logs and resource usage when loading (#12322) When an instance has a lot of shards it can take a while to start. This update includes two improvements to zoekt: - shards: throttle loading in watcher https://gerrit-review.googlesource.com/c/zoekt/+/275902 - shards: a progress message every 10s when loading https://gerrit-review.googlesource.com/c/zoekt/+/275903

view details

Dax McDonald

commit sha aa821d01117f83c7b5081f7f36e086655bbd7f2b

Update latest release to 3.18.0 (#12305)

view details

Felix Becker

commit sha 23b198aecbaf5dceb780176795d6dcc26cb116d2

Integration test improvements (#12324)

view details

Keegan Carruthers-Smith

commit sha 08e13f12caccde4960d2c49f98d9592639b2c1ac

src-expose: avoid git update-server-info in request path (#12342) We now only run git update-server-info if a repository has not been configured. This change exposed a bug in our hook setting being incorrect. This wasn't visible before since we would always run update-server-info when listing repos.

view details

Pooja Jain

commit sha 22dfa7cbd08d25676ad184b001d9e21d518fb50c

Update slow lang:python example with repogroup:python example (#12343) Co-authored-by: Pooja Jsin <poojajain@poojas-mbp.attlocal.net>

view details

push time in 14 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha fde90d0587675cbb4a9faf48bbc7b9774e1610c3

Lint

view details

push time in 14 days

issue commentsourcegraph/sourcegraph

WIP: Search 3.19 Tracking issue

Last week

  • Fix outstanding repogroup page issues:
    • Repogroup page responsiveness
    • Search page responsiveness
    • 404 flashing when visiting repogroup pages
    • Fixed flaky percy test
  • Indexed repogroup repos using ghdump
  • Private code call to actions
  • Reviewed globbing RFC

This week

  • Web content stylesheet https://github.com/sourcegraph/sourcegraph/issues/12303
  • Search homepage launch data (https://docs.google.com/document/d/1WJRst6C8JZcnlItvoRWs3baye_KJ0WDOrs9AIoHXI6k/edit#heading=h.trqab8y0kufp
  • Search tour
nicksnyder

comment created time in 15 days

issue commentsourcegraph/sourcegraph

Remove duplicate styles

I propose renaming this to "Create web content stylesheet" and I'll assign myself, and this will be the next thing I address.

The stylesheet will include the web content styles already in the repogroup pages and private code CTA, and I'll remove any overrides in those respective stylesheets. The stylesheet won't be complete yet, but we can add to it as we define our web styles more clearly.

rrhyne

comment created time in 15 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha d7f09997761054c284841a156cb966b4263b942d

add viweports

view details

push time in 15 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 5545a375c83c39f23df98d1e08b74f60817f6a94

Light-theme for story

view details

push time in 15 days

push eventsourcegraph/sourcegraph

AlicjaSuska

commit sha c8e4a41651cb7b17830f0d1bcc40187b0ef65f40

Add Figma URL for UserNavItem (#12290)

view details

Keegan Carruthers-Smith

commit sha f3d88f690a5767ef06d46796f8e976d951932bb0

trace: select http requests with trace=1 (#12291) Currently we parse trace=1 in our javascript layer. This adds trace selection to our endpoints that are directly requested via non-js endpoints (eg loading a page).

view details

Ryan Slade

commit sha 5cf616b29a9c53a6e6ab7784aaebe7596cc8a3a5

leader: Add a leader election package (#12289) * rcache: Add options param to TryAcquireMutex * leader: Add a leader package A small helper package that wraps our Redis based mutex to allow only a single instance of a function to run concurrently. * Update CODEOWNERS * Update internal/rcache/mutex_test.go Co-authored-by: Asdine El Hrychy <asdine.elhrychy@gmail.com> * No need for release func The outler leader loop can release when the worker function returns * Add jitter and respect ctx during sleep * Make worker fn to last parameter Makes it easier to use especially when fn is anonymous * Improve test Co-authored-by: Asdine El Hrychy <asdine.elhrychy@gmail.com>

view details

Loïc Guychard

commit sha eaa28952f62b9e7d3303b007b7f4400b9d327e53

Remove todo-security check (#12292) This check is old, very specific (anything other than `TODO(security)`, such as `todo security`, `TODO: security`, etc. will be missed), and is flaky: - https://buildkite.com/sourcegraph/sourcegraph/builds/68719#ef0d0bae-bdc7-4412-aa2a-dda5ac10aecb - https://sourcegraph.slack.com/archives/C07KZF47K/p1594989190353700?thread_ts=1594988538.353300&cid=C07KZF47K I feel like our code review process is a sufficient safeguard here.

view details

renovate[bot]

commit sha 35a4bb98ac463b91ff9934136f4aa9504d910a5b

Update dependency @types/puppeteer to v3 (#11197) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Felix Becker <felix.b@outlook.com>

view details

Eric Fritz

commit sha d39f0c72cc4c8379cc7b1c48619c29367729b461

codeintel: Extract generic worker process (#12262)

view details

Eric Fritz

commit sha c8c34394d09aa73ac47465d250167f386004c1a4

Update LSIF docs to link to example CI configurations (#12225)

view details

Keegan Carruthers-Smith

commit sha 5a1c63bec7bd289906cf340e3b7550800f9d452a

dev: only support watchman (#12252) Maintaining three different ways to watch files leads to unneccessary bugs. Instead lets pick just one.

view details

Chayim

commit sha e4a647a4e2c043828519cc712be00ef65e7c796e

Secure Token Schema (#12207) Creating the migrations for the token table, database schema change to accommodate key-value pairs.

view details

Felix Becker

commit sha 24ee7987c4e671d0df8ae3609652dc5b082b7cf9

Increase contrast of placeholders to meet WCAG (#12213)

view details

Felix Becker

commit sha d81fc27fa3d444becf126bf8fc4b7da60c1c7631

Add integration tests for spaces in paths (#12297) * Add integration tests for spaces in paths * Use test-* classes

view details

Eric Fritz

commit sha 80c27d5e64abb974b1ae857c9b0757c3cdfe9627

Add docs for rolling updates to migration readme. (#12298)

view details

ᴜɴᴋɴᴡᴏɴ

commit sha 5ce8ae587d734252af7d8ab439510a8fddb4f421

gqltest: add docs to run and add tests (#12285) Co-authored-by: Rijnard van Tonder <rvantonder@gmail.com>

view details

Farhan Attamimi

commit sha 4d9f02807eb0fe2a893e4fa7aeaf1e498d3fbe30

Merge branch 'master' into fa/private-code-ctas

view details

push time in 15 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 8c97ba3c063f1f643a1039d0a750de8447d5a3a8

Update snapshot

view details

push time in 15 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha e35914801fe196945316563f2e7a9ffac21d1a4b

Fix display of share feedback section

view details

push time in 15 days

issue commentsourcegraph/sourcegraph

Activation confetti does not appear on find references action

I was able to reproduce once, but on subsequent attempts it seems to work fine. Perhaps this is an issue only for the first user.

attfarhan

comment created time in 15 days

pull request commentsourcegraph/sourcegraph

web: remove regex anchors if globbing is active

@stefanhengl filter chip suggestions come from the backend, so you'll have to update this line in the backend code, which currently hardcodes the anchors: https://sourcegraph.com/github.com/sourcegraph/sourcegraph@sh/globbing-web/-/blob/cmd/frontend/graphqlbackend/search_results.go#L246:33.

You may have to do the same for this line here: https://sourcegraph.com/github.com/sourcegraph/sourcegraph@sh/globbing-web/-/blob/cmd/frontend/graphqlbackend/search_filter_suggestions.go?utm_source=VSCode-1.1.0#L33:45, which generates repo suggestions for the non-Monaco search input.

stefanhengl

comment created time in 15 days

issue openedsourcegraph/sourcegraph

Activation confetti does not appear on find references action

  • Sourcegraph version: <!-- the version of Sourcegraph or "Sourcegraph.com" -->
  • Platform information: <!-- OS version, cloud provider, web browser version, Docker version, etc., depending on the issue -->

Steps to reproduce:

  1. Start a new Sourcegraph instance
  2. Using a fresh user account, run a search.
  3. Do a find references action.

Expected behavior:

The confetti appears from activation dropdown both when doing a search and when doing find refs.

Actual behavior:

Find refs does not trigger confetti. The activation progress bar does advance, though.

created time in 16 days

Pull request review commentsourcegraph/about

Add Rollout Process

+# Feature rollout process++Features come in many different sizes and shapes, and the process for introducing new functionality ranges with these differences. For large or significantly impactful changes or changes that simply need a bit more time to bake, it is encouraged that the following rollout process is followed.++## Sourcegraph Cloud++Sourcegraph Cloud is continuously deployed with all new updates to master. We maintain a [releasability contract](../engineering/continuous_releasability.md) and require all new features to be released behind a feature flag to ensure that functionality can be turned off if a problem arises.

I don't think it's good to reference the releasability contract here. For example, private code CTAs shouldn't be feature flagged, IMO, but it seems that product does want to discuss/approve this before merging (https://sourcegraph.slack.com/archives/C0C324C91/p1595009322049800). Should we have two different paths for features that should and shouldn't be feature flagged?

poojaj-tech

comment created time in 16 days

Pull request review commentsourcegraph/about

Add Rollout Process

+# Feature rollout process++Features come in many different sizes and shapes, and the process for introducing new functionality ranges with these differences. For large or significantly impactful changes or changes that simply need a bit more time to bake, it is encouraged that the following rollout process is followed.++## Sourcegraph Cloud++Sourcegraph Cloud is continuously deployed with all new updates to master. We maintain a [releasability contract](../engineering/continuous_releasability.md) and require all new features to be released behind a feature flag to ensure that functionality can be turned off if a problem arises.++### Before merge++- Run hallway tests with internal users+- Complete a final [design review](design/design_process.md#final-review)+- Review documentation+- Review analytics and ensure desired metrics have been added to the feature+- Confirm feature flag functionality

Do we need to add a step here where the product team must approve the PR before merging? I worry that the code will be ready, the PR is approved by other developers, but the product team doesn't approve yet. It then becomes unclear when the dev can feel confident merging.

poojaj-tech

comment created time in 16 days

PR opened sourcegraph/sourcegraph

Add private code CTAs

Fixes https://github.com/sourcegraph/sourcegraph/issues/11799.

Adds CTAs to install Sourcegraph for private code to search homepage, campaigns, and repogroup pages, as in the design: https://www.figma.com/file/X5WmkZmMv8wACPpxFDgKpX/RFC-165-Search-CTAs?node-id=0%3A1&viewport=2658%2C620%2C0.25

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+341 -231

0 comment

8 changed files

pr created time in 18 days

create barnchsourcegraph/sourcegraph

branch : fa/private-code-ctas

created branch time in 18 days

delete branch sourcegraph/sourcegraph

delete branch : fa/flaky-percy

delete time in 19 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 68df57cef4fdb4aa258c22b3803164fe35cde8bb

Fix: don't show cursor in repogroup page storybooks (#12145)

view details

push time in 19 days

PR merged sourcegraph/sourcegraph

Fix: don't show cursor in repogroup page storybooks

Fixes https://github.com/sourcegraph/sourcegraph/issues/12124

Hides the blinking cursor to avoid flakiness.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+17 -4

5 comments

5 changed files

attfarhan

pr closed time in 19 days

issue closedsourcegraph/sourcegraph

Repogroup homepage Percy snapshots are flaky because cursor is blinking

image

The solution would probably be to hide the cursor within a Percy-only media query.

closed time in 19 days

felixfbecker

Pull request review commentsourcegraph/sourcegraph

Fix: don't show cursor in repogroup page storybooks

 export const SearchPageInput: React.FunctionComponent<Props> = (props: Props) =>                                     queryState={userQueryState}                                     onChange={setUserQueryState}                                     onSubmit={onSubmit}-                                    autoFocus={true}+                                    autoFocus={!props.noAutoFocus}                                 />                             ) : (                                 <QueryInput                                     {...props}                                     value={userQueryState}                                     onChange={setUserQueryState}-                                    autoFocus="cursor-at-end"+                                    autoFocus={!props.noAutoFocus || 'cursor-at-end'}

fixed this

attfarhan

comment created time in 19 days

push eventsourcegraph/sourcegraph

Adam Harvey

commit sha 289f21241818c943a49a4a3ce0bd86817dd46002

CODEOWNERS: campaigns should own docs (#12218)

view details

Asdine El Hrychy

commit sha 70e7e46e516419e90ce0f1576748bcd4a2ec6add

Revert "Revert "cloud: use the cloned column to filter by clone status"" (#12149) * Revert "Revert "cloud: use the cloned column to filter by clone status (#11932)" (#12128)" This reverts commit 52130ea0e92d3e653f09b5b212dae0d2ae114220. * Fix cloned repositories listing and counting (#12152)

view details

Asdine El Hrychy

commit sha ea5afc0ee6a80c4b10596daa6a0ba2672ba894e6

Delete cloning tab from the site-admin repositories page (#12043) This reverts commit 314584824f9bcd0def4d4d903e5f8a2eaf26a402.

view details

stefanhengl

commit sha 83538ba49978b2fe44b363490923b25684001c40

search: support globbing for selected keywords (#12093)

view details

Felix Becker

commit sha 837016e39d80c1f50ddc1cbe66ee61cd93941ab1

Auto-retry Chromatic step in CI (#12234)

view details

Felix Becker

commit sha 418d0a5a2cd0bf620786d425a33e23fda60f27e7

Disable animation in story (#12237)

view details

Loïc Guychard

commit sha a3b40f3ae9376b42ce9a67b5a33f177ba98ac050

Fix file fuzzy completion (#12241) Fixes #12240

view details

garo (they/them)

commit sha 16bee624393a346da1aa0ac40a25425d115d1ea8

bump extension api version (#12224)

view details

Keegan Carruthers-Smith

commit sha 067156456f15d9af4bcf584959552ca929b74d68

dev: ignore changes to _test.go files (#12251) We don't need to recompile if a _test.go file is changed since they don't contribute to main. This change updates watchman to exclude triggering updates in that case. We only do this for watchman since the other file watchers do not make it as easy to express these sorts of rules. I also want to one day make watchman the only way to do this.

view details

Chayim

commit sha 0ab488b18221cc9933155884a951ebb30834d4fa

Added a comment on the OverrideAuthMiddleware to address (#12253) * Added a comment on the OverrideAuthMiddleware to address https://github.com/sourcegraph/security-issues/issues/79 * Update cmd/frontend/internal/cli/http.go

view details

Keegan Carruthers-Smith

commit sha dac9530db93bb6660742e7b1e268921a8ca8aec5

search: set input rev for indexed results (#12246) Missed this when implementing multi branch search for indexed search. We go through all the effort to find the input revision for generating the resource URL. However, we forget to set the input revision leading to it not being shown in search results.

view details

Keegan Carruthers-Smith

commit sha cda11183af6ac8bfeb5bc5b2efd2475a55e595a7

search: return a result per branch in indexed results (#12249) If a file is the same in two branches and we have results on it, our indexed search currently will only return one result. This would be misleading in the UI since the user would not know the other branches have results. This change will copy how we do it for non-indexed search and just duplicate results (but with different input revs). In future we should dedup results and display this information more compactly.

view details

renovate[bot]

commit sha 09c72f28fc8d40af1f79ce8fce840413e99babaf

Update polly to v5 (major) (#12255) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Ryan Slade

commit sha b7d6d2c5b039361ef21457c0c88043e27355d70e

rcache: Clarify comments (#12254) * rcache: Clarify comments Replaced a couple of TODO's with the reasons for the current implementation. * Update doc comment

view details

Farhan Attamimi

commit sha b089c1919a93f0315f4af71e6e85287ec804ecf2

Merge branch 'master' into fa/flaky-percy

view details

push time in 19 days

push eventsourcegraph/sourcegraph

Thorsten Ball

commit sha 0c6d7a436462cbea6684a63a7c7e61780f29d2af

Add SupportLabels() method to Changeset (#12198) I prefer having the logic in about what's supported and what not in a central place.

view details

Thorsten Ball

commit sha ff1272e50a3e97b45034e871837e46028167fb97

Turn ChangsetEvents.Labels into ComputeLabels function (#12199) * Turn ChangsetEvents.Labels into ComputeLabels function I think it makes more sense to follow the same style for all of these "compute a state based on the changeset and its events" methods/functions. `(*ChangesetEvents).Labels` was the last one that we didn't convert. Since I've been looking at it in #12198 I decided to change it to a `ComputeLabels` function (that also does the sorting) * Use slice type for events in changesetResolver and sort by default

view details

Ryan Slade

commit sha a547a87f9d3a447be90e2c53760f4792799e8e2c

db: Move db packages out of frontend (#12201) * db: Move cmd/frontend/db package to internal/db * Update script * db: Move enterprise/frontend/db to enterprise/internal/db * Update CI script * Replace more instances of frontend/db

view details

Felix Becker

commit sha 0560c078d240ad9482e4513e9ddaf5462e8c8c5a

Fix Bitbucket file path wrapping (#12182) Fixes #11110

view details

Felix Becker

commit sha 14f0cce7e9e218a93950fd41001a98d864476643

Upload storybook to Chromatic (#12216)

view details

Felix Becker

commit sha e6e0d4a366c7852686f0c38641216434bba2d370

Rename e2e-* selectors to test-* (#12203) They are used by other tests too, especially the new integration tests.

view details

Keegan Carruthers-Smith

commit sha e90e8fa9df43446bc8a4fd5df327f15b42aa3e98

dev: check version of bash on startup (#12204) If you are using an old version of bash our dev scripts fails in subtle ways. For example we will detect file changes, but recompilation will fail. This check ensures a dev is on version 5 of bash. If not it fails the script and informs them how to upgrade.

view details

Rijnard van Tonder

commit sha 62b61c3dec0b33e3617948c1f2e4d54ca0f02dfa

search: add query parser migration flag (#12184)

view details

Rijnard van Tonder

commit sha edd810cd44c4bfc3a24099815c3256bbb10ebcb3

search: wrap alerts in results resolver (#12185)

view details

Rijnard van Tonder

commit sha 275f99c25577d772246fd3c3337e65ce898cdfbd

search: detect patterntype field with new parser (#12188)

view details

Rijnard van Tonder

commit sha cc92548732b7da94fd04b994b38b757275dd2fd4

search: correctly merge token ranges (#12193)

view details

Eric Fritz

commit sha 1c2aee517524aa1d8f7447a923b817309ae588c1

db: Add generic workqueue store (#12058)

view details

Farhan Attamimi

commit sha 9e30b6fc7c58c7a83b8881fe2000a129fdd1201e

Make repogroup pages responsive (#12200)

view details

Farhan Attamimi

commit sha 20205242541bcc775767b25c6d872c7934070d0a

Merge branch 'master' into fa/flaky-percy

view details

push time in 19 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha ed8d922d79ecd5fdae51d7da8f54aa31a8c962eb

Use autofocus prop

view details

push time in 19 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha 9e30b6fc7c58c7a83b8881fe2000a129fdd1201e

Make repogroup pages responsive (#12200)

view details

push time in 20 days

delete branch sourcegraph/sourcegraph

delete branch : fa/responsive-repogroup-page

delete time in 20 days

PR merged sourcegraph/sourcegraph

Make repogroup pages responsive

Fixes https://github.com/sourcegraph/sourcegraph/pull/11783#discussion_r449064515.

Removes CSS grid and uses bootstrap row and col classes.

This makes it such that the two column layout becomes a single column layout on screens smaller than 992px.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+12 -12

2 comments

3 changed files

attfarhan

pr closed time in 20 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha e5b6d6a4b98b0d2b4e19a34e36926c93f60092d4

configure snapshot width

view details

Farhan Attamimi

commit sha fbab1d1246ee6f519e524a0c3037002f8b1bcc9e

Merge branch 'fa/responsive-repogroup-page' of github.com:sourcegraph/sourcegraph into fa/responsive-repogroup-page

view details

push time in 20 days

Pull request review commentsourcegraph/sourcegraph

Make repogroup pages responsive

 export const RepogroupPage: React.FunctionComponent<RepogroupPageProps> = (props                     interactiveModeHomepageMode={true}                 />             </div>-            <div className="repogroup-page__content">-                <div className="repogroup-page__column">+            <div className="repogroup-page__content row">+                <div className="repogroup-page__column col-xs-12 col-lg-7">

If we use the medium breakpoint, content gets squeezed together way too much before we wrap. Hence, using the large breakpoint made a lot more sense visually here.

attfarhan

comment created time in 20 days

Pull request review commentsourcegraph/sourcegraph

Make repogroup pages responsive

     }      &__content {-        display: grid;-        grid-template-columns: 7fr 5fr;+        // display: grid;+        // grid-template-columns: 7fr 5fr;         padding: 2rem;          &-description {

Still using the padding

attfarhan

comment created time in 20 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha d83e7b0c986ec7aed3722cbb0f8e1729e583ea6d

Update web/src/repogroups/RepogroupPage.tsx Co-authored-by: Felix Becker <felix.b@outlook.com>

view details

push time in 20 days

push eventsourcegraph/sourcegraph

Farhan Attamimi

commit sha c96c2ed8934501936de8ebbfcd872d4bc32cf498

Update web/src/repogroups/RepogroupPage.scss Co-authored-by: Felix Becker <felix.b@outlook.com>

view details

push time in 20 days

more