profile
viewpoint
Alexey Svetliakov asvetliakov Alicante, Spain

asvetliakov/Huject 47

Typescript dependency injection container for Humans!

asvetliakov/orm-redis 21

ORM for Redis and Typescript

asvetliakov/jest-create-mock-instance 16

Create mock instances with Jest

asvetliakov/move-imports 10

Move-imports VSCode extension

asvetliakov/Fallout4WheelMenu 5

Fallout4 WheelMenu widget

asvetliakov/babel-plugin-jest-easy-mock 2

Easy mocking with Jest!

asvetliakov/jest-mock-action-creators 2

Simplify testing of redux dispatch() with action creators in React components

asvetliakov/jest-mock-external-components 1

Easy mock your react components

asvetliakov/aphrodisiac 0

Aphrodite-like API on top of JSS.

asvetliakov/awesome-typescript-loader 0

Awesome TypeScript loader for webpack

issue closedasvetliakov/vscode-neovim

vscode neovim breaks CMD+c copy shortcut on macOS

When using vim or neovim with e.g. the vimR GUI frontend on macOS, CMD+X C V for cut/copy/paste works as expected. It also works as expected in vscode when using the vscodevim extension.

However, when using vscode-neovim extension, CMD+c does not copy the selected text, but instead copies the entire line of wherever the cursor is located. Also, the visual selection is not unselected when pressing CMD+c. Oddly, CMD+x and CMD+v work as expected to cut and paste, respectively.

closed time in 13 days

benwbooth

issue commentasvetliakov/vscode-neovim

vscode neovim breaks CMD+c copy shortcut on macOS

either 1) unbind cmd+c/cmd-x/cmd-v/whatever from vscode and don't send to neovim or 2) pass cmd-c/cmd-x/cmd-v to neovim and either call vscode copy/paste command or put/copy to "* register.

benwbooth

comment created time in 13 days

issue closedasvetliakov/vscode-neovim

Find a way to keep neovim and vscode selection in sync

Having the neovim and vscode selections out of sync breaks CMD+x c v cut/copy/paste shortcuts on macOS. It also breaks any extension that works on selected text. See #410.

closed time in 13 days

benwbooth

issue commentasvetliakov/vscode-neovim

Split window cursor retains its original position

Anyone with this problem has Mouse selection start visual mode turned on?

ozimos

comment created time in 17 days

issue commentyarnpkg/berry

[Feature] "yarn workspaces focus" option `--prune-cache`

@Larry1123 this is exactly what i was needed, thank you! This should be built into yarn itself, nobody wants to copy 300 MB of dev packages into production images or lambda

yinzara

comment created time in 18 days

IssuesEvent

issue commentasvetliakov/vscode-neovim

Can't paste text from register / (Ctrl-r,/)

Reopening to not forget to add missing keybinding by default

TyNguyen2k1

comment created time in a month

issue commentasvetliakov/vscode-neovim

Can't paste text from register / (Ctrl-r,/)

you can add this to your keybindings.json in meantime:

            {
                "command": "vscode-neovim.paste-register",
                "key": "ctrl+r /",
                "when": "editorTextFocus && neovim.mode == insert && !neovim.recording && neovim.ctrlKeysInsert",
                "args": "/"
            }
TyNguyen2k1

comment created time in a month

issue commentasvetliakov/vscode-neovim

Can't paste text from register / (Ctrl-r,/)

Sorry, i see now. There is no keybinding for pasting from register / in insert mode. And your screen is :registers message

TyNguyen2k1

comment created time in a month

issue commentasvetliakov/vscode-neovim

Can't paste text from register / (Ctrl-r,/)

That's not very informative issue description. What did you press, what happened, what should happen instead. Your init.vim content

TyNguyen2k1

comment created time in a month

issue commentasvetliakov/vscode-neovim

Unable to type into comment boxes when using GitHub PR extension

works for me with side-by-side too

KidVizious

comment created time in a month

issue commentasvetliakov/vscode-neovim

Unable to type into comment boxes when using GitHub PR extension

@KidVizious @ian-h-chamberlain are you using side by side or inline diff editor?

KidVizious

comment created time in a month

issue commentasvetliakov/vscode-neovim

ctrl+v then shift + i, only selects one row not all

try with empty init.vim if you have custom one

delolat

comment created time in a month

issue commentasvetliakov/vscode-neovim

ctrl+v then shift + i, only selects one row not all

Your use case works for me. Although there is only single cursor visible, the text will be inserted into all rows you've selected before. That's 100% correct vim behavior

delolat

comment created time in a month

issue commentasvetliakov/vscode-neovim

Unable to type into comment boxes when using GitHub PR extension

I'm using github PR extension too and don't have such problem. Try with empty init.vim first

KidVizious

comment created time in a month

issue closedasvetliakov/vscode-neovim

Navigate through previous commands on VIM Command Line

I love how it opens the VIM Command-Line at the top when pressing :. It is far more readable than on the bottom status bar, at least in my opinion.

Screen Shot 2020-09-24 at 9 59 32 AM

My only problem is that I'm used to navigating through previous commands by pressing up arrow/down arrow. This doesn't seem to be working on my version. Would this be a feature request or am I missing something?

I'm keen to contribute.

Env

Neo Vim 0.0.62 Mac OS 10.15.16 VS Codium Version: 1.49.1

closed time in a month

josecoelho

issue commentasvetliakov/vscode-neovim

Navigate through previous commands on VIM Command Line

VScode started to disallow to rebind up/down keybindings in quick edit. Ctrl-n/Ctrl-p navigates cmd history now. You can bind other keys too, except up/down. See #288

josecoelho

comment created time in a month

issue closedasvetliakov/vscode-neovim

Cursor movement break jump stack of vscode

When I use j/k to move cursor in vim mode, then I use vs code Go Back(^- on Mac), cursor will back to the previous lines instead of the position where I use goto definition command.

closed time in a month

gngshn

issue commentasvetliakov/vscode-neovim

Cursor movement break jump stack of vscode

You need to use vim's jumplist <C-o>/<C-i>/<Tab> commands. They're not perfect and have bugs but vscode back/forward is not supported and won't be.

gngshn

comment created time in a month

push eventasvetliakov/vscode-neovim

Vladimir Iashin

commit sha f7aad4c3205f9b59762c725243b56bfc2b6d129b

'type' command conflict precaution (#368, #380) (#383) * 'type' command conflict precaution (#368, #380) * a small change for consistency

view details

push time in a month

pull request commentasvetliakov/vscode-neovim

'type' command conflict precaution (#368, #380)

Thank you!

v-iashin

comment created time in a month

PullRequestReviewEvent

Pull request review commentasvetliakov/vscode-neovim

Check for insert mode before dispose

 export class TypingManager implements Disposable {                 );                 this.changeManager.getDocumentChangeCompletionLock(editor.document)?.then(() => {                     this.isEnteringInsertMode = false;-                    if (this.typeHandlerDisposable) {+                    if (this.typeHandlerDisposable && this.modeManager.isInsertMode) {                         this.logger.debug(`${LOG_PREFIX}: Waiting done, disposing type handler`);                         this.typeHandlerDisposable.dispose();                         this.typeHandlerDisposable = undefined;-                        if (this.pendingKeysAfterEnter) {-                            commands.executeCommand("default:type", { text: this.pendingKeysAfterEnter });-                            this.pendingKeysAfterEnter = "";-                        }+                    }+                    if (this.pendingKeysAfterEnter) {+                        commands.executeCommand("default:type", { text: this.pendingKeysAfterEnter });

I forgot - need one more thing here, executing default:type may insert text in normal mode which is wrong,

Change to: commands.executeCommand(this.modeManager.isInsertMode ? "default:type" : "type", ....)

Shatur95

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentasvetliakov/vscode-neovim

Check for insert mode before dispose

 export class TypingManager implements Disposable {                 );                 this.changeManager.getDocumentChangeCompletionLock(editor.document)?.then(() => {                     this.isEnteringInsertMode = false;-                    if (this.typeHandlerDisposable) {+                    if (this.typeHandlerDisposable && this.modeManager.isInsertMode) {                         this.logger.debug(`${LOG_PREFIX}: Waiting done, disposing type handler`);                         this.typeHandlerDisposable.dispose();

better to wrap these lines into a check instead because you might lose the pressed keys otherwise

Or move if(this.pendingKeysAfterEnter) check outside of this block

Shatur95

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

issue commentasvetliakov/vscode-neovim

Neovim stops responding

Awesome, care to compile a PR with fix & test ? (If not i'll do it but little busy now)

Shatur95

comment created time in a month

issue commentasvetliakov/vscode-neovim

Neovim stops responding

ah, i see now. It's queueing dispose of the type handler since it's entering the insert mode, but when it actually disposes it you're in normal mode already. Should be easy to fix by wrapping typeHandlerDisposable.dispose(); into if (modeManager.isInsertMode) check

Shatur95

comment created time in a month

issue commentasvetliakov/vscode-neovim

error message re WSL - on linux

I think we should just ignore useWSL flag on linux/mac

hholst80

comment created time in a month

issue closedasvetliakov/vscode-neovim

Conflicting behaviour with Overtype, and probably many others

Having the vscode extension overtype installed reproduces the same error as #368.

With any othe case found about this error, I assumed the linked issue's resolution was to uninstall a vim extension, I have none installed, but had overtype. I disabled overtype, reloaded vscode and it worked fine

To some may be obvius that those two confict each other, but it would be nice to have a note in the readme about possible unexpected errors at startup with extensions that extend the editor, like overtype.

I could publish a pr in a couple of hours if that's allowed

Steps to reproduce:

  • Install neo vim extension and set executable path
  • Reload vscode, neo vim should work
  • Install overtype, reload vscode
  • Error is shown at neovim init.

closed time in a month

GonziTaji

issue commentasvetliakov/vscode-neovim

Conflicting behaviour with Overtype, and probably many others

Nothing we can do here, vscode allows to register only single type command across all extensions

GonziTaji

comment created time in a month

issue commentasvetliakov/vscode-neovim

Neovim stops responding

Works with clipboard command too (macOS 10.15.6). I think that's something related to used clipboard tool

Shatur95

comment created time in a month

issue commentasvetliakov/vscode-neovim

NeoVim does not work in vscode 1.49

ENOENT means it can't find the requested path. Try with full path without ~/ , e.g. /Users/blah/.bin/...

MrLukashem

comment created time in a month

push eventasvetliakov/vscode-neovim

OJ Kwon

commit sha 6addadfe7d3d988266a2ff6ce26d9a1980500020

build(webpack): enable tree shaking (#378)

view details

push time in a month

PR merged asvetliakov/vscode-neovim

build(webpack): enable tree shaking

This PR attempts to improve #377 by enablind tree shaking.

To utilize proper tree shaking, PR replaces lodash to esm exports lodash (lodash-es) and updates ts-loader config to webpack properly analyze tree shaking imports.

Size comparison of bundle looks like below:

Previous image

After image

Total bundle size went down from 415 -> 341, among those lodash now takes ~3KB only.

+27 -9

4 comments

6 changed files

kwonoj

pr closed time in a month

pull request commentasvetliakov/vscode-neovim

build(webpack): enable tree shaking

Awesome, thank you for your PR @kwonoj !

kwonoj

comment created time in a month

PullRequestReviewEvent

pull request commentasvetliakov/vscode-neovim

build(webpack): enable tree shaking

@Shatur95 need better assertion metaphor for tests

kwonoj

comment created time in a month

issue commentasvetliakov/vscode-neovim

[Feature] filetype specific motions

Filetype must work fine and your example works ok for me

awilkins

comment created time in a month

issue closedasvetliakov/vscode-neovim

EasyMotion shifting text

My favorite things about easy motion is that you don't need to move your gaze away from where you want to go. The text decorations seem to break that though since they get placed behind the text and shift everything on the line over. When there are a lot of matches on a given line, it can move the characters significantly.

Is there any way to avoid replacing the text in the buffer like the original easymotion did while also keeping the text in it's original positions?

closed time in a month

jhgarner

issue commentasvetliakov/vscode-neovim

EasyMotion shifting text

Fixed by #358

jhgarner

comment created time in a month

push eventasvetliakov/vscode-neovim

Alexey Svetlyakov

commit sha 1a21d4be4bbad992747f13a83dce40426adfc9ce

wording

view details

push time in a month

created tagasvetliakov/vscode-neovim

tagv0.0.63

VSCode Neovim integration

created time in a month

push eventasvetliakov/vscode-neovim

Alexey Svetlyakov

commit sha 0a11e4bf22c0602535b075a061c9840366044eff

0.0.63

view details

push time in a month

delete branch asvetliakov/vscode-neovim

delete branch : webpack

delete time in a month

push eventasvetliakov/vscode-neovim

Alexey Svetliakov

commit sha e0c909bfc89e33a525fe0f30a488a34375d048ff

Webpack bundling (#377) * Webpack bundling * Build webpack also in CI step, add Test PreLaunch task for local dev * use webpack env plugin to stop neovim winston spam

view details

push time in a month

PR merged asvetliakov/vscode-neovim

Webpack bundling

There is Critical dependency: the request of a dependency is an expression error coming from neovim node client, but it's safe to ignore since it's related to neovim remote plugin loading, which is requiring global installed version anyway

Also fixes winston logger spam

Closes #134

Relates https://github.com/neovim/node-client/pull/136#issuecomment-688453651

+2362 -114

0 comment

9 changed files

asvetliakov

pr closed time in a month

issue closedasvetliakov/vscode-neovim

Set default logger transport for neovim/node-client

image

It looks like neovim node client is initialized with default values (debug loglevel / no transport) makes all debug message keep erroring in winston.

  • default loglevel may not need to be debug: maybe worth expose debug config for the extension to launch neovim in the full-debugging mode
  • set default transport : to console? for debug-mode, may write it into file transport instead.

closed time in a month

kwonoj

push eventasvetliakov/vscode-neovim

Alexey Svetlyakov

commit sha abe8f1baa6428b0a70c06a2c3b5ecefc29f76906

use webpack env plugin to stop neovim winston spam

view details

push time in a month

MemberEvent

push eventasvetliakov/vscode-neovim

Alexey Svetlyakov

commit sha 13c2809cf5d73ba5b80c920ac74b31b672468e8f

Build webpack also in CI step, add Test PreLaunch task for local dev

view details

push time in a month

PR opened asvetliakov/vscode-neovim

Webpack bundling

There is Critical dependency: the request of a dependency is an expression error coming from neovim node client, but it's safe to ignore since it's related to neovim remote plugin loading, which is requiring global installed version anyway

+2313 -114

0 comment

9 changed files

pr created time in a month

create barnchasvetliakov/vscode-neovim

branch : webpack

created branch time in a month

delete branch asvetliakov/vscode-neovim

delete branch : fix-dot-repeat-problems

delete time in a month

delete branch asvetliakov/vscode-neovim

delete branch : workaround-dot-repeat

delete time in a month

delete branch asvetliakov/vscode-neovim

delete branch : ci

delete time in a month

delete branch asvetliakov/vscode-neovim

delete branch : fix-324

delete time in a month

delete branch asvetliakov/vscode-neovim

delete branch : refactor

delete time in a month

delete branch asvetliakov/vscode-neovim

delete branch : fix-search-cursor

delete time in a month

delete branch asvetliakov/vscode-neovim

delete branch : fix-double-accepting-prompt

delete time in a month

push eventasvetliakov/vscode-neovim

Alexey Svetliakov

commit sha 6f2e797abee7336eeede44bed61084ed24607c49

Accept return prompt only when necessary (#376) * Accept return prompt only when necessary * Increase test timeout * Fix visual mode conversion

view details

push time in a month

PR merged asvetliakov/vscode-neovim

Accept return prompt only when necessary

Fix #372

Not sure if there is a better trust source here, but seems doing the trick

+11 -5

0 comment

3 changed files

asvetliakov

pr closed time in a month

issue closedasvetliakov/vscode-neovim

Easymotion incorrect jump to search

When using https://github.com/asvetliakov/vim-easymotion, and doing <leader>/ for search, when I type the search then choose the target, it jumps to the first non-whitespace col in the line below the target instead of directly to the target.

Peek 2020-09-20 11-04

closed time in a month

theol0403

push eventasvetliakov/vscode-neovim

Alexey Svetlyakov

commit sha 582b56eceb8d0cf1fa9301e48d05dd5039e80121

Fix visual mode conversion

view details

push time in a month

issue commentasvetliakov/vscode-neovim

Easymotion fork

I doubt the author will accept it but may be worth to try 😄

Shatur95

comment created time in a month

push eventasvetliakov/vscode-neovim

Alexey Svetlyakov

commit sha 54632a4ce79e9de7c17d99a4ab2e8e5409383ced

Increase test timeout

view details

push time in a month

issue commentasvetliakov/vscode-neovim

Neovim stops responding

@Shatur95 I just tried, works ok for me. Perhaps something with your init.vim ?

Shatur95

comment created time in a month

issue commentasvetliakov/vscode-neovim

NeoVim does not work in vscode 1.49

Check your neovim path in settings, try with empty init.vim

MrLukashem

comment created time in a month

PR opened asvetliakov/vscode-neovim

Accept return prompt only when necessary

Fix #372

Not sure if there is a better trust source here, but seems doing the trick

+8 -3

0 comment

1 changed file

pr created time in a month

issue commentasvetliakov/vscode-neovim

Easymotion incorrect jump to search

The problem here is the automatically accepting return prompt caused by easymotion. But for easymotion search it's "autoaccepted" already

theol0403

comment created time in a month

create barnchasvetliakov/vscode-neovim

branch : fix-double-accepting-prompt

created branch time in a month

push eventasvetliakov/vscode-neovim

Alexey Svetliakov

commit sha a26fee87bcd4c7ca6b5b7b440da4607c6af150cf

Fix search cursor (#374)

view details

push time in a month

PR merged asvetliakov/vscode-neovim

Fix search cursor

Fixes #366

+39 -1

0 comment

2 changed files

asvetliakov

pr closed time in a month

issue closedasvetliakov/vscode-neovim

search.action.focusNextSearchResult leaves the cursor somewhere else

Description

When calling search.action.focusNextSearchResult or clicking in one of the search occurrences, visually the cursor points to the word, but if I try to apply an action, such as ciw, it will use the last position, so basically, the cursor doesn't update, making search useless.

Screenshots

As shown in the gif below, when I try to change the word, the cursor is somewhere else. search-bug

closed time in a month

baldore

PR opened asvetliakov/vscode-neovim

Fix search cursor

Fixes #366

+39 -1

0 comment

2 changed files

pr created time in a month

create barnchasvetliakov/vscode-neovim

branch : fix-search-cursor

created branch time in a month

delete branch asvetliakov/vscode-neovim

delete branch : hl-adjustments

delete time in a month

push eventasvetliakov/vscode-neovim

Alexey Svetliakov

commit sha 3af5abb4a5417e7c8bdab86694c33586536868c7

Remove unneeded HL optimization (#371)

view details

push time in a month

PR merged asvetliakov/vscode-neovim

Remove unneeded HL optimization

This deleted lines were causing to apply vim HL regardless if it should be ignored or not. Especially frustrating with MatchParen HL at end of the line

+0 -12

0 comment

2 changed files

asvetliakov

pr closed time in a month

PR opened asvetliakov/vscode-neovim

Remove unneeded HL optimization

This deleted line was causing to apply vim HL regardless if it should be ignored or not. Especially frustrating with MatchParen HL at end of the line

+0 -12

0 comment

2 changed files

pr created time in a month

create barnchasvetliakov/vscode-neovim

branch : hl-adjustments

created branch time in a month

pull request commentasvetliakov/vscode-neovim

Fix marks jumping

cursorMove

Nope. cursorMove vscode command stops when reaching a new line and ignoring given value count. Possible workaround here too but too clunky. Need to fix vim jumplist

Shatur95

comment created time in a month

pull request commentasvetliakov/vscode-neovim

Fix marks jumping

Probably can be workarounded by using vscode's cursorMove command. But need to count character shifting then between old & new cursor pos

Shatur95

comment created time in a month

pull request commentasvetliakov/vscode-neovim

Fix marks jumping

Maybe use VSCode jumping for <C-o> / <C-i>? Yes, it works a bit differently, but do not have issues.

Unfortunately vscode jumping is completely broken because setting vscode cursor is creating vscode jumppoint for each cursor move

Shatur95

comment created time in a month

push eventasvetliakov/vscode-neovim

Theo Lemay

commit sha 3f45ff2a16ac76682d249ee48b55a8e42acbd957

Refactor Vimscript (#362) * Modernize command mappings * Undo multiply cursors changes * Try reverting changes * Try to use mode * Fix multiply cursors Co-authored-by: Shatur95 <genaloner@gmail.com>

view details

push time in a month

PR merged asvetliakov/vscode-neovim

Refactor Vimscript

I believe this was suggested by @Shatur95 in another issue.

A command exists called <Cmd> that replaces the need for :<C-U> and gv in mappings that call commands.

In brief: (help :map-cmd),

The <Cmd> pseudokey begins a "command mapping", which executes the command directly (without changing modes). This is more flexible than :<C-U> in visual and operator-pending mode, or <C-O>: in insert-mode, because the commands are executed directly in the current mode (instead of always going to normal-mode). Visual-mode is preserved, so tricks with |gv| are not needed. Commands can be invoked directly in cmdline-mode (which would otherwise require timer hacks).

I did a search and replace for this over the whole project, as well as removed all the unnecessary gv commands and even entirely removed some helper functions.

Finally, there is this note in the help txt:

Because <Cmd> avoids mode-changes (unlike ":") it does not trigger CmdlineEnter and CmdlineLeave events. This helps performance.

When testing out this PR, I've noticed an improvement in editor responsiveness and speed!

+157 -167

4 comments

10 changed files

theol0403

pr closed time in a month

pull request commentasvetliakov/vscode-neovim

Refactor Vimscript

Thank you @Shatur95 @theol0403

theol0403

comment created time in a month

issue commentasvetliakov/vscode-neovim

neovim init.vim autocmd issue

FocusLost , FocusGained not working issues, thx.

Neovim is non GUI backend here so obviously can't receive and lost focus

Although we can hook vscode and call doautocmd. Probably should work

VimLeave

Possibly but that's a use case for VimLeave with vscode?

ianzhuo

comment created time in a month

pull request commentasvetliakov/vscode-neovim

Fix marks jumping

You will have several Untitled buffers with content insted of opened files. It happens sometimes, but often. Try 1-3 steps two-three times and you should reproduce it.

I noticed this problem too, for some reason neovim sends /file/path instead file:/// uri when jumping and vscode ignores it. Will try to solve it by either fixing neovim or by accepting paths too

  1. <C-o>. It jumps to first file. This hotkey shouldn't have done that.

There are limitations with jumping. Opening a buffer doesn't create a jumppoint. Not easy to solve

Shatur95

comment created time in a month

push eventasvetliakov/vscode-neovim

Yuki Osaki

commit sha 0d97fdf2827e77bf09e75764c3f678eb98fa3adc

map r<C-w>gf to revealDefinitionAside (#365) Co-authored-by: Yuki Osaki <yuki.osaki7@gamail.com>

view details

push time in a month

PR merged asvetliakov/vscode-neovim

Remove <C-w>gf command

Currently When you type <C-w>gf, it does not work because editor.action. revealDeclarationAside does not exist in vscode.

image

+3 -3

7 comments

2 changed files

Yuuki77

pr closed time in a month

pull request commentasvetliakov/vscode-neovim

Remove <C-w>gf command

Thank you for your PR!

Yuuki77

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentasvetliakov/vscode-neovim

Text decorations at top

@jhgarner Thank you for your PR!

jhgarner

comment created time in a month

push eventasvetliakov/vscode-neovim

Jackson Garner

commit sha c800343bc75bae6046070edcdde1b75a8bb29303

Text decorations at top (#358) * Add option to draw text decorations on top Plugins like EasyMotion can be drawn with text decorations. This has a lot of benefits, but it cases text to shift all over the place. This commit adds an option to draw text decorations on top of their associated text in a way that is much more in line with how NeoVim/EasyMotion actually work. * Small comment change Co-authored-by: Jack Garner <jacksonhgarner@outlook.com>

view details

push time in a month

more