profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/astirpe/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Andrea Stirpe astirpe @onesteinbv Odoo addicted

OCA/edi 55

astirpe/koozic 0

Self-hosted media streaming server

astirpe/l10n-netherlands 0

Odoo Dutch Localization

astirpe/odoo_addons 0

Odoo addons developed by Smile

astirpe/OpenUpgrade 0

Open source upgrade path for Odoo/OpenERP

astirpe/TensorFlows 0

Implementation of photos recognizer in Odoo ERP using AI machine learning TensorFlow

tarteo/web 0

Odoo web client UI related addons

VanMoof/purchase-workflow 0

Odoo Purchases, Workflow and Organization

push eventVanMoof/delivery-carrier

Andrea

commit sha 067b970cd17ade4cbbc8a3b6f49aa839ee9061da

[FIX] delivery_carrier_label_ups: UPS returns labels

view details

push time in 5 days

push eventVanMoof/delivery-carrier

Andrea

commit sha 04767b0c688efe03b98f8937c11556f1c73340fe

[IMP] delivery_carrier_label_ups: fix email

view details

push time in 5 days

Pull request review commentOCA/delivery-carrier

[FIX] delivery_carrier_label_ups: UPS returns labels creation

 def _ups_shipping_data(self):                     ],                     **shipping_data,                 ),+                LabelSpecification=self._ups_label_specification(account),             )         ) +    def _ups_return_service(self):+        """Return a dict describing the UPS Return Label code"""+        self.ensure_one()+        recipient = self.picking_type_id.warehouse_id.partner_id+        recipient_email = recipient.email+        shipper_email = self.partner_id.email

@StefanRijnhart you are right! I was convinced they were inverted. Thanks!

astirpe

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentOCA/delivery-carrier

[FIX] delivery_carrier_label_ups: UPS returns labels creation

 def _ups_shipping_data(self):                     ],                     **shipping_data,                 ),+                LabelSpecification=self._ups_label_specification(account),             )         ) +    def _ups_return_service(self):+        """Return a dict describing the UPS Return Label code"""+        self.ensure_one()+        recipient = self.picking_type_id.warehouse_id.partner_id+        recipient_email = recipient.email+        shipper_email = self.partner_id.email

This is a return, isn't the recipient the company's warehouse? And the shipper the customer?

astirpe

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentOCA/server-tools

[13.0][REF] base_changeset: remove base model inheritance

Attaching this feature to mail.thread would mitigate the requiring of extra development for each model, however I'm afraid there still will be a lot of models excluded, like for example lines (eg.: invoice lines, order lines, ...), configuration records, etc... I'm not against the principle of this PR, I'm just noticing that this PR introduces a regression for the way this module was meant. Is it possible for this module to skip _process_end() somehow?

JordiMForgeFlow

comment created time in 8 days

pull request commentOCA/server-tools

[13.0][REF] base_changeset: remove base model inheritance

So this way the module become useless by itself, because it will require extra development for each model we want to use this functionality with. This was unwanted in my initial idea of this module.

JordiMForgeFlow

comment created time in 8 days

Pull request review commentVanMoof/currency

OD-1528: use end-of-day rates

 def _obtain_rates(self, base_currency, currencies, date_from, date_to):                     if 'description' in data                     else 'Unknown error'                 )-            date_content = content[date.isoformat()]+            data_date = datetime.utcfromtimestamp(data['timestamp']).date()+            if eod_rates and data_date != date:+                raise UserError(f"Exchange rate from incorrect date received. Got {data_date}, expected {date}")+            date_content = content[(date + timedelta(days=1) if eod_rates else date).isoformat()]

Ok, thanks for the explanation

pankk

comment created time in 8 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentVanMoof/currency

OD-1528: use end-of-day rates

 class ResCompany(models.Model):     openexchangerates_app_id = fields.Char(         string='OpenExchangeRates.org App ID',     )+    eod_rates = fields.Boolean(

Since this is a oxr related field, should be named openexchangerates_eod_rates

pankk

comment created time in 8 days

PullRequestReviewEvent

Pull request review commentVanMoof/currency

OD-1528: use end-of-day rates

 def _obtain_rates(self, base_currency, currencies, date_from, date_to):                     if 'description' in data                     else 'Unknown error'                 )-            date_content = content[date.isoformat()]+            data_date = datetime.utcfromtimestamp(data['timestamp']).date()+            if eod_rates and data_date != date:+                raise UserError(f"Exchange rate from incorrect date received. Got {data_date}, expected {date}")+            date_content = content[(date + timedelta(days=1) if eod_rates else date).isoformat()]

Shouldn't be date_content = content[date.isoformat()] ?

pankk

comment created time in 8 days

PullRequestReviewEvent

push eventVanMoof/delivery-carrier

Andrea

commit sha 31b92f74e9d639770c760745fc1737d07179d80f

[FIX] delivery_carrier_label_ups: UPS returns labels

view details

push time in 11 days

pull request commentOCA/delivery-carrier

[IMP] delivery_carrier_label_ups: split method for ReturnService

@StefanRijnhart code updated, would you give it a look?

astirpe

comment created time in 12 days

push eventVanMoof/delivery-carrier

Andrea

commit sha 4425d5e70f9ca86d7a673e01785813f7f4230939

[IMP] delivery_carrier_label_ups: implement Returns

view details

Andrea

commit sha 4bb09c5e3bbac3b6099e012d0d15f1583c084df8

[IMP] delivery_carrier_label_ups: add tests

view details

push time in 12 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentOCA/server-tools

[13.0][IMP] base_changeset: show change pop up in list view

 Known issues / Roadmap  * Only a subset of the type of fields is actually supported * Multicompany not fully supported+* When accepting a change in a X2Many field (list view) the page will be reloaded to display the new value.

This comment is obsolete now

AdriaGForgeFlow

comment created time in 19 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentOCA/server-tools

[13.0][IMP] base_changeset: show change pop up in list view

+odoo.define("base_changeset.relational_fields", function(require) {+    "use strict";++    var RelationalFields = require("web.relational_fields");++    RelationalFields.FieldX2Many.include({+        _render: function() {+            var res = this._super.apply(this, arguments);+            if (res instanceof Promise) {+                res.then(this._updateChangeset.bind(this));+            } else {+                this._updateChangeset.bind(this);+            }+            return res;+        },++        _updateChangeset: function() {+            var self = this;+            var model = this.value.model;+            return self+                ._rpc({+                    model: "record.changeset.change",+                    method: "get_fields_changeset_changes",+                    args: [model, false],+                })+                .then(function(changeset) {+                    var res = {};+                    _.each(changeset, function(changesetChange) {+                        if (!_.contains(_.keys(res), changesetChange.field_name)) {+                            res[changesetChange.field_name] = [];+                        }+                        res[changesetChange.field_name].push(changesetChange);+                    });+                    self.renderer.renderChangesetPopovers(res);+                });+        },++        applyChange: function(id) {+            return this._rpc({+                model: "record.changeset.change",+                method: "apply",+                args: [[id]],+                context: _.extend({}, this.context, {set_change_by_ui: true}),+            }).then(function() {+                window.location.reload();

@AdriaGForgeFlow can you try with this?

        applyChange: function(id) {
            var self = this;
            return this._rpc({
                model: "record.changeset.change",
                method: "apply",
                args: [[id]],
                context: _.extend({}, this.context, {set_change_by_ui: true}),
            }).then(function() {
                self.trigger_up('reload');
            });
        },
AdriaGForgeFlow

comment created time in 19 days

PullRequestReviewEvent
PullRequestReviewEvent